Back to build
Raw log | Switch to full mode | Login

/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh /b/swarming/w/ir/cache/builder/src src in dir /b/swarming/w/ir/k: allow_subannotations: False cmd: ['/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh', '/b/swarming/w/ir/cache/builder/src', 'src'] env: {'CHROME_HEADLESS': '1'} env_prefixes: {} env_suffixes: {} infra_step: False name_tokens: ('tree truth steps',) ok_ret: frozenset([0]) trigger_specs: () full environment: ADDRFAM: inet BOTO_CONFIG: /b/swarming/w/ir/tmp/gsutil_task/.boto BUILDBUCKET_EXPERIMENTAL: FALSE CHROME_HEADLESS: 1 CIPD_CACHE_DIR: /b/swarming/cipd_cache/cache CIPD_PROTOCOL: v2 DEVSHELL_CLIENT_PORT: 42580 DOCKER_CONFIG: /b/swarming/w/ir/tmp/docker_cfg_task DOCKER_TMPDIR: /b/swarming/w/ir/tmp/docker_tmp_task GIT_CONFIG_NOSYSTEM: 1 GIT_TERMINAL_PROMPT: 0 HOME: /home/chrome-bot IFACE: eth0 INFRA_GIT_WRAPPER_HOME: /b/swarming/w/ir/tmp/git_home_task LOGDOG_COORDINATOR_HOST: logs.chromium.org LOGDOG_STREAM_PREFIX: buildbucket/cr-buildbucket.appspot.com/8916532736487399680 LOGDOG_STREAM_PROJECT: chromium LOGDOG_STREAM_SERVER_PATH: unix:/b/swarming/w/ir/tmp/ld.sock LOGICAL: eth0 LUCI_CONTEXT: /b/swarming/w/it6Wcnsb/luci_context.157769581 MAC_CHROMIUM_TMPDIR: /b/swarming/w/ir/tmp/t METHOD: dhcp NO_GCE_CHECK: False PATH: /b/swarming/w/ir/cipd_bin_packages:/b/swarming/w/ir/cipd_bin_packages/bin:/b/swarming/cipd_cache/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin PWD: /b/swarming/w/ir/k PYTHONIOENCODING: UTF-8 PYTHONUNBUFFERED: 1 ROOT_SETUP_LOG: /var/log/messages/chromebuild/root-setup.log SHLVL: 1 STARTUP_LOG: /var/log/messages/chromebuild/startup.log SWARMING_BOT_ID: swarm2827-c4 SWARMING_EXTERNAL_BOT_SETUP: 1 SWARMING_HEADLESS: 1 SWARMING_SERVER: https://chromium-swarm.appspot.com SWARMING_TASK_ID: 4421cb8522d4f011 TEMP: /b/swarming/w/ir/tmp/t TEMPDIR: /b/swarming/w/ir/tmp/t TERM: linux TMP: /b/swarming/w/ir/tmp/t TMPDIR: /b/swarming/w/ir/tmp/t UPSTART_EVENTS: net-device-up UPSTART_INSTANCE: UPSTART_JOB: chromebuild-startup USER: chrome-bot USERNAME: chrome-bot VPYTHON_VIRTUALENV_ROOT: /b/swarming/w/ir/cache/vpython _: /b/swarming/w/ir/cipd_bin_packages/vpython !@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: cd413b40386030bb8c01ab2cdedbca981f6485b2 OOR-CORS: 3rd attempt to introduce ResourceRequest::cors_exempt_headers Takashi Toyoshima, Wed Apr 10 20:33:46 2019 +0000 cf655518736cd59e112ecc22aaaea4d17079ec77 Remove the restriction for the length of prefixes to be a multiple of prefix_size Varun Khaneja, Wed Apr 10 20:32:33 2019 +0000 9c16ed6bdc51a39dbc1fd36f100169223d549ea6 Enable sandboxed process for XR browser tests bsheedy, Wed Apr 10 20:32:11 2019 +0000 cd2b5179c3b416495dd4a3782f6fc9a4ef877b7e Import wpt@204c508cf54896d817a9244a9fd17eb2a2a236c1 Chromium WPT Sync, Wed Apr 10 20:22:25 2019 +0000 2103e63d8aa2154e36acbbd61739a0afd1abaabd Roll src-internal 6d7730600369..7682feb30b68 (6 commits) chromium-internal-autoroll, Wed Apr 10 20:14:04 2019 +0000 b155fdf88c59e9c941faf9e6474cb8e52c4f79f4 Extend the Android.Permissions.ReadStorage histogram to M77. Sébastien Séguin-Gagnon, Wed Apr 10 20:12:54 2019 +0000 d8d8d492fb8a7f087136588de7074423c99e7df0 Fix Parent Access Code config conversion. Henrique Grandinetti, Wed Apr 10 20:08:34 2019 +0000 c9d39c263df44407f367f71e04977baf843d462d Updating components and owners for benchmarks. Ushesh Desai, Wed Apr 10 20:05:33 2019 +0000 1f065759a2d6eed51bcb64eae4e71585c84a18ee Allow UIA Accessibility Tree Dumper to Dump Pattern Properties Jacques Newman, Wed Apr 10 20:03:51 2019 +0000 e00b6d61bc024123a7fa3671efd2717c1f27bdb8 Roll traffic_annotation checkers Nicolas Ouellet-payeur, Wed Apr 10 19:59:36 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit cd413b40386030bb8c01ab2cdedbca981f6485b2 Author: Takashi Toyoshima <toyoshim@chromium.org> Date: Wed Apr 10 20:33:46 2019 +0000 OOR-CORS: 3rd attempt to introduce ResourceRequest::cors_exempt_headers Updates in the 3rd patchset: - add a virtual method to the iOS BrowserState for obtainig cors_exempt_headers, that can be implemented outside ios/web, and missed users in ios/web can support X-Client-Data now. Updates between the 1st and the 2nd patchsets: - initial variation header support for iOS Chrome, this adds additional argument to one of ctor of NetworkContext, and set cors_exempt_headers in chrome/ uses. - additional variation header support for Chromecast - additional variation header support for StoragePartition Original descriptions: Now ResourceRequest has multiple special header entries that are aimed for escaping from CORS checks for internal uses. This patch introduces cors_exempt_headers to handle this kind of entries in an unified way. Also this patch removes {Get|Set}ClientDataHeader interfaces from WebURLRequest because these should not be used in Blink. Bug: 940331 Change-Id: Ie9a2b175e46f7dd567a9896d5e09c562f170a548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547611 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#649625} .../extensions/api/socket/tcp_socket_unittest.cc | 3 +- .../extensions/api/socket/tls_socket_unittest.cc | 3 +- .../browser/net/system_network_context_manager.cc | 4 +++ chromecast/browser/BUILD.gn | 2 ++ chromecast/browser/DEPS | 1 + chromecast/browser/cast_network_contexts.cc | 8 ++++- chromecast/browser/network_context_manager.cc | 7 +++- components/cast_channel/cast_socket_unittest.cc | 3 +- .../core/browser/hsts_query_unittest.cc | 3 +- .../browser/http_credentials_cleaner_unittest.cc | 6 ++-- .../browser/safe_browsing_network_context.cc | 3 +- components/variations/net/DEPS | 1 + .../variations/net/variations_http_headers.cc | 14 +++++--- .../variations/net/variations_http_headers.h | 7 ++++ content/browser/BUILD.gn | 1 + content/browser/DEPS | 1 + .../loader/resource_dispatcher_host_impl.cc | 16 +++------ content/browser/storage_partition_impl.cc | 12 ++++++- .../signed_exchange_handler_unittest.cc | 3 +- content/common/content_constants_internal.cc | 2 ++ content/common/content_constants_internal.h | 5 +++ content/public/browser/BUILD.gn | 2 ++ content/public/browser/DEPS | 1 + content/public/browser/cors_exempt_headers.cc | 18 ++++++++++ content/public/browser/cors_exempt_headers.h | 21 ++++++++++++ content/renderer/loader/web_url_loader_impl.cc | 12 ++++--- .../shell/browser/shell_content_browser_client.cc | 2 ++ google_apis/gcm/base/socket_stream_unittest.cc | 3 +- .../gcm/engine/connection_handler_impl_unittest.cc | 3 +- google_apis/gcm/tools/mcs_probe.cc | 3 +- ios/chrome/browser/BUILD.gn | 1 + ios/chrome/browser/DEPS | 1 + ios/chrome/browser/browser_state/BUILD.gn | 4 +++ .../browser/browser_state/chrome_browser_state.h | 2 ++ .../browser/browser_state/chrome_browser_state.mm | 6 ++++ .../browser_state/chrome_browser_state_unittest.cc | 40 ++++++++++++++++++++++ ios/chrome/browser/ios_chrome_io_thread.mm | 8 ++++- .../ui/location_bar/location_bar_coordinator.mm | 11 +++--- ios/web/browser_state.mm | 8 +++-- ios/web/network_context_owner.cc | 8 +++-- ios/web/network_context_owner_unittest.cc | 11 ++++-- ios/web/public/browser_state.h | 6 ++++ ios/web/public/network_context_owner.h | 5 +++ ios/web/public/test/fakes/test_browser_state.cc | 9 +++++ ios/web/public/test/fakes/test_browser_state.h | 4 +++ ios/web/url_loader_inttest.mm | 6 ++++ ios/web_view/BUILD.gn | 1 + ios/web_view/internal/DEPS | 1 + ios/web_view/internal/app/application_context.mm | 9 ++++- jingle/glue/network_service_config_test_util.cc | 3 +- services/network/cors/cors_url_loader_factory.cc | 20 +++++++++-- services/network/cors/cors_url_loader_factory.h | 3 +- services/network/network_context.cc | 19 ++++++---- services/network/network_context.h | 14 ++++++-- services/network/public/cpp/resource_request.cc | 4 +-- services/network/public/cpp/resource_request.h | 3 +- .../network/public/cpp/url_request_mojom_traits.cc | 3 +- .../network/public/cpp/url_request_mojom_traits.h | 8 ++--- .../cpp/url_request_mojom_traits_unittest.cc | 3 +- .../network/public/mojom/network_context.mojom | 4 +++ services/network/public/mojom/url_loader.mojom | 28 ++++++++------- .../network/test/test_shared_url_loader_factory.cc | 3 +- .../transitional_url_loader_factory_owner.cc | 3 +- services/network/url_loader.cc | 19 ++++------ .../blink/public/platform/web_url_request.h | 6 ---- .../renderer/platform/exported/web_url_request.cc | 8 ----- 66 files changed, 349 insertions(+), 113 deletions(-) commit cf655518736cd59e112ecc22aaaea4d17079ec77 Author: Varun Khaneja <vakh@chromium.org> Date: Wed Apr 10 20:32:33 2019 +0000 Remove the restriction for the length of prefixes to be a multiple of prefix_size R=nparker Bug: 933065 Change-Id: Ie2e790cd9ce5fa2aa5f0e7ef9d200b1d0e608060 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509012 Reviewed-by: Nathan Parker <nparker@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#649624} components/safe_browsing/db/v4_store_fuzzer.cc | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) commit 9c16ed6bdc51a39dbc1fd36f100169223d549ea6 Author: bsheedy <bsheedy@chromium.org> Date: Wed Apr 10 20:32:11 2019 +0000 Enable sandboxed process for XR browser tests Enables the use of the sandboxed process for the XR browser tests. This is achieved by running the tests through a wrapper script that sets the correct ACLs on the output directory before running the tests. Bug: 949619 Change-Id: If583d50234f8d763da23cd70ab65b898a4164492 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555499 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Bill Orr <billorr@chromium.org> Reviewed-by: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#649623} chrome/browser/vr/BUILD.gn | 31 +++++++- chrome/browser/vr/test/run_xr_browser_tests.py | 101 +++++++++++++++++++++++++ chrome/browser/vr/test/webvr_browser_test.h | 8 -- chrome/browser/vr/test/webxr_vr_browser_test.h | 12 --- chrome/browser/vr/test/xr_browser_test.cc | 3 +- chrome/browser/vr/test/xr_browser_tests.md | 12 ++- testing/buildbot/gn_isolate_map.pyl | 5 ++ tools/mb/mb.py | 3 +- 8 files changed, 149 insertions(+), 26 deletions(-) commit cd2b5179c3b416495dd4a3782f6fc9a4ef877b7e Author: Chromium WPT Sync <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Date: Wed Apr 10 20:22:25 2019 +0000 Import wpt@204c508cf54896d817a9244a9fd17eb2a2a236c1 Using wpt-import in Chromium 30bfe0fd96a8931f84594694f3fa2dd0ea3a16ae. With Chromium commits locally applied on WPT: 0a8f3ffa48 "Use testdriver Action API in WPT pointerevent touch tests - Part 2" adc34f41f6 "Fix web_test pointerevent_coordinates_when_locked on wpt" 8659792f35 "[WPT] Move wrapResult to common.js and clarify requestVia*() return values" e525003f05 "Do not resume a suspended BaseAudioContext when AudioWorklet starts" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ia35dade3eef0599dd3d5fc9d14b640f46de58365 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562152 Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649622} .../blink/web_tests/external/WPT_BASE_MANIFEST_5.json | 18 ++++++++++++++---- .../wpt/tools/wptrunner/wptrunner/wptcommandline.py | 2 ++ 2 files changed, 16 insertions(+), 4 deletions(-) commit 2103e63d8aa2154e36acbbd61739a0afd1abaabd Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Wed Apr 10 20:14:04 2019 +0000 Roll src-internal 6d7730600369..7682feb30b68 (6 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6d7730600369..7682feb30b68 Created with: gclient setdep -r src-internal@7682feb30b68 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=harrisjay@chromium.org,ellyjones@chromium.org,btolsch@chromium.org Change-Id: If8c9c134cfb9aac2680dcceb517fe6d688ba7711 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562041 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649621} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit b155fdf88c59e9c941faf9e6474cb8e52c4f79f4 Author: Sébastien Séguin-Gagnon <sebsg@chromium.org> Date: Wed Apr 10 20:12:54 2019 +0000 Extend the Android.Permissions.ReadStorage histogram to M77. Bug: 945572 Change-Id: Iddea284189237432651e030ca72193eec2a27c8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560555 Auto-Submit: sebsg <sebsg@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Commit-Queue: sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#649620} tools/metrics/histograms/histograms.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit d8d8d492fb8a7f087136588de7074423c99e7df0 Author: Henrique Grandinetti <hgrandinetti@chromium.org> Date: Wed Apr 10 20:08:34 2019 +0000 Fix Parent Access Code config conversion. Bug: 951242 Change-Id: I8a9a86683fd9143458fd62dbc53c41a91a85771d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561835 Reviewed-by: Aga Wronska <agawronska@chromium.org> Commit-Queue: Henrique Grandinetti <hgrandinetti@chromium.org> Cr-Commit-Position: refs/heads/master@{#649619} .../child_accounts/parent_access_code/policy_config_source.cc | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) commit c9d39c263df44407f367f71e04977baf843d462d Author: Ushesh Desai <ushesh@chromium.org> Date: Wed Apr 10 20:05:33 2019 +0000 Updating components and owners for benchmarks. Not included are the removals which require other changes (and are mostly being handled as part of those changes). Change-Id: If6164751335c90982e1094a464ef9dc3828916ad Bug: 886965 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552109 Reviewed-by: Annie Sullivan <sullivan@chromium.org> Reviewed-by: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Ushesh Desai <ushesh@chromium.org> Cr-Commit-Position: refs/heads/master@{#649618} tools/perf/benchmark.csv | 14 +++++++------- tools/perf/benchmarks/blink_perf.py | 2 ++ tools/perf/benchmarks/loading.py | 2 ++ tools/perf/benchmarks/v8.py | 2 +- tools/perf/core/perf_data_generator.py | 7 ++++--- 5 files changed, 16 insertions(+), 11 deletions(-) commit 1f065759a2d6eed51bcb64eae4e71585c84a18ee Author: Jacques Newman <janewman@microsoft.com> Date: Wed Apr 10 20:03:51 2019 +0000 Allow UIA Accessibility Tree Dumper to Dump Pattern Properties Added corresponding baselines for uia for each existing *-expected-win.txt. Modified optgroup.html to test the SelectionContainer property, updated corresponding *-expected files. Re-added pattern-specific properties, e.g. UIA_GridItemRowPropertyId It was required that we add the property to the cache request before they could be accessed from the pattern. The following properties are not working correctly: * ValuePattern.Value: - Should be fixed by this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1519319 * GridPattern: ColumnCount and RowCount are sometimes 0 when they should be greater than 0. Added and tested the following pattern properties: ExpandCollapse.ExpandCollapseState Grid.ColumnCount Grid.RowCount GridItem.Column GridItem.ColumnSpan GridItem.Row GridItem.RowSpan GridItem.ContainingGrid RangeValue.IsReadOnly RangeValue.LargeChange RangeValue.SmallChange RangeValue.Maximum RangeValue.Minimum RangeValue.Value Scroll.HorizontalScrollPercent Scroll.HorizontalViewSize Scroll.HorizontallyScrollable Scroll.VerticalScrollPercent Scroll.VerticalViewSize Scroll.VerticallyScrollable Selection.CanSelectMultiple Selection.IsSelectionRequired SelectionItem.IsSelected SelectionItem.SelectionContainer Table.RowOrColumnMajor Toggle.ToggleState Value.IsReadOnly Value.Value Window.IsModal Bug: 847971 Change-Id: I1fbfe2730e8281e8dbb1bc16bfecb68810a0fe27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521468 Commit-Queue: Jacques Newman <janewman@microsoft.com> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#649617} .../accessibility_tree_formatter_uia_win.cc | 620 +++++++++++++++++---- .../accessibility_tree_formatter_uia_win.h | 34 +- .../dump_accessibility_tree_browsertest.cc | 9 + .../data/accessibility/html/a-expected-uia-win.txt | 4 + .../html/a-name-calc-expected-uia-win.txt | 16 +- .../html/a-name-calc-expected-uia-win7.txt | 16 +- .../accessibility/html/a-name-expected-uia-win.txt | 4 +- .../html/a-onclick-expected-uia-win.txt | 2 +- .../html/a-with-img-expected-uia-win.txt | 10 +- .../accessibility/html/abbr-expected-uia-win.txt | 2 +- .../html/action-verbs-expected-uia-win.txt | 29 + .../html/actions-expected-uia-win.txt | 5 + .../html/address-expected-uia-win.txt | 2 +- .../accessibility/html/area-expected-uia-win.txt | 4 +- .../html/article-expected-uia-win.txt | 2 +- .../accessibility/html/aside-expected-uia-win.txt | 2 +- .../data/accessibility/html/b-expected-uia-win.txt | 6 + .../accessibility/html/base-expected-uia-win.txt | 1 + .../accessibility/html/bdo-expected-uia-win.txt | 7 + .../html/blockquote-expected-uia-win.txt | 2 +- .../accessibility/html/body-expected-uia-win.txt | 2 +- .../accessibility/html/br-expected-uia-win.txt | 2 +- .../accessibility/html/button-expected-uia-win.txt | 4 +- .../html/button-name-calc-expected-uia-win.txt | 20 +- .../html/button-name-calc-expected-uia-win7.txt | 20 +- .../accessibility/html/canvas-expected-uia-win.txt | 7 + .../html/caption-expected-uia-win.txt | 14 + .../html/checkbox-name-calc-expected-uia-win.txt | 8 + .../accessibility/html/cite-expected-uia-win.txt | 6 + .../accessibility/html/code-expected-uia-win.txt | 1 + .../accessibility/html/col-expected-uia-win.txt | 1 + .../html/colgroup-expected-uia-win.txt | 1 + ...ontenteditable-descendants-expected-uia-win.txt | 21 + ...descendants-with-selection-expected-uia-win.txt | 17 + ...-embedded-contenteditables-expected-uia-win.txt | 11 + ...itable-with-no-descendants-expected-uia-win.txt | 7 + .../accessibility/html/dd-expected-uia-win.txt | 7 + .../accessibility/html/del-expected-uia-win.txt | 6 + .../html/details-expected-uia-win.txt | 10 + .../accessibility/html/dfn-expected-uia-win.txt | 5 + .../accessibility/html/dialog-expected-uia-win.txt | 4 + .../accessibility/html/div-expected-uia-win.txt | 6 + .../accessibility/html/dl-expected-uia-win.txt | 9 + .../accessibility/html/dt-expected-uia-win.txt | 7 + .../element-class-id-src-attr-expected-uia-win.txt | 4 + .../accessibility/html/em-expected-uia-win.txt | 6 + .../accessibility/html/embed-expected-uia-win.txt | 4 + .../html/fieldset-expected-uia-win.txt | 5 + .../html/figcaption-expected-uia-win.txt | 6 + .../accessibility/html/figure-expected-uia-win.txt | 4 + .../accessibility/html/footer-expected-uia-win.txt | 4 + ...ooter-inside-other-section-expected-uia-win.txt | 14 + .../accessibility/html/form-expected-uia-win.txt | 4 + .../form-validation-message-expected-uia-win.txt | 7 + .../html/frameset-expected-uia-win.txt | 19 + .../accessibility/html/head-expected-uia-win.txt | 1 + .../accessibility/html/header-expected-uia-win.txt | 4 + ...eader-inside-other-section-expected-uia-win.txt | 14 + .../html/heading-expected-uia-win.txt | 8 + .../accessibility/html/hr-expected-uia-win.txt | 10 + .../accessibility/html/html-expected-uia-win.txt | 1 + .../data/accessibility/html/i-expected-uia-win.txt | 6 + ...-coordinates-cross-process-expected-uia-win.txt | 16 + .../html/iframe-coordinates-expected-uia-win.txt | 16 + .../html/iframe-cross-process-expected-uia-win.txt | 11 + .../accessibility/html/iframe-expected-uia-win.txt | 5 + .../iframe-presentational-expected-uia-win.txt | 5 + .../html/iframe-transform-expected-uia-win.txt | 8 + .../html/img-empty-alt-expected-uia-win.txt | 7 + .../accessibility/html/img-expected-uia-win.txt | 8 + .../html/img-link-empty-alt-expected-uia-win.txt | 10 + .../html/in-page-links-expected-uia-win.txt | 30 + .../html/input-button-expected-uia-win.txt | 4 + .../html/input-button-in-menu-expected-uia-win.txt | 6 + .../html/input-checkbox-expected-uia-win.txt | 8 + .../input-checkbox-in-menu-expected-uia-win.txt | 8 + .../html/input-color-expected-uia-win.txt | 4 + .../html/input-date-expected-uia-win.txt | 4 + .../html/input-datetime-expected-uia-win.txt | 4 + .../html/input-datetime-local-expected-uia-win.txt | 24 + .../html/input-email-expected-uia-win.txt | 4 + .../html/input-file-expected-uia-win.txt | 4 + .../html/input-hidden-expected-uia-win.txt | 1 + ...input-image-button-in-menu-expected-uia-win.txt | 1 + .../html/input-image-expected-uia-win.txt | 4 + .../html/input-list-expected-uia-win.txt | 6 + .../html/input-number-expected-uia-win.txt | 5 + .../html/input-password-expected-uia-win.txt | 4 + .../html/input-radio-expected-uia-win.txt | 14 + .../html/input-radio-in-menu-expected-uia-win.txt | 12 + .../html/input-range-expected-uia-win.txt | 4 + .../html/input-reset-expected-uia-win.txt | 5 + .../html/input-search-expected-uia-win.txt | 4 + .../html/input-submit-expected-uia-win.txt | 11 + ...suggestions-source-element-expected-uia-win.txt | 4 + .../html/input-tel-expected-uia-win.txt | 4 + .../html/input-text-expected-uia-win.txt | 4 + .../html/input-text-name-calc-expected-uia-win.txt | 22 +- .../html/input-text-read-only-expected-uia-win.txt | 4 + .../html/input-text-value-expected-uia-win.txt | 19 + .../input-text-with-selection-expected-uia-win.txt | 4 + .../html/input-time-expected-uia-win.txt | 14 + .../html/input-types-expected-uia-win.txt | 50 ++ .../html/input-url-expected-uia-win.txt | 4 + .../html/input-week-expected-uia-win.txt | 13 + .../accessibility/html/ins-expected-uia-win.txt | 10 + .../accessibility/html/label-expected-uia-win.txt | 5 + .../html/landmark-expected-uia-win.txt | 144 +++++ .../accessibility/html/legend-expected-uia-win.txt | 7 + .../accessibility/html/li-expected-uia-win.txt | 9 + .../accessibility/html/link-expected-uia-win.txt | 1 + .../html/link-inside-heading-expected-uia-win.txt | 4 + .../accessibility/html/list-expected-uia-win.txt | 15 + .../html/list-markers-expected-uia-win.txt | 9 + .../accessibility/html/main-expected-uia-win.txt | 6 + .../accessibility/html/mark-expected-uia-win.txt | 7 + .../accessibility/html/math-expected-uia-win.txt | 11 + .../html/menu-type-context-expected-uia-win.txt | 1 + .../accessibility/html/meta-expected-uia-win.txt | 1 + .../accessibility/html/meter-expected-uia-win.txt | 4 + .../html/modal-dialog-closed-expected-uia-win.txt | 8 + .../html/modal-dialog-opened-expected-uia-win.txt | 6 + .../html/modal-dialog-stack-expected-uia-win.txt | 6 + .../html/navigation-expected-uia-win.txt | 4 + .../html/noscript-expected-uia-win.txt | 1 + .../accessibility/html/object-expected-uia-win.txt | 4 + .../html/offscreen-iframe-expected-uia-win.txt | 7 + .../html/offscreen-select-expected-uia-win.txt | 12 + .../accessibility/html/ol-expected-uia-win.txt | 16 + .../html/optgroup-expected-uia-win.txt | 14 + content/test/data/accessibility/html/optgroup.html | 1 + .../data/accessibility/html/p-expected-uia-win.txt | 6 + .../accessibility/html/param-expected-uia-win.txt | 1 + .../accessibility/html/pre-expected-uia-win.txt | 10 + .../html/progress-expected-uia-win.txt | 5 + .../data/accessibility/html/q-expected-uia-win.txt | 8 + .../accessibility/html/ruby-expected-uia-win.txt | 7 + .../data/accessibility/html/s-expected-uia-win.txt | 1 + .../accessibility/html/samp-expected-uia-win.txt | 1 + .../accessibility/html/script-expected-uia-win.txt | 1 + .../html/scrollable-expected-uia-win.txt | 6 + .../html/scrollable-textarea-expected-uia-win.txt | 5 + .../test/data/accessibility/html/scrollable.html | 22 + .../html/section-expected-uia-win.txt | 4 + .../accessibility/html/select-expected-uia-win.txt | 26 + .../html/selection-container-expected-uia-win.txt | 9 + .../accessibility/html/selection-container.html | 13 + .../accessibility/html/small-expected-uia-win.txt | 1 + .../accessibility/html/span-expected-uia-win.txt | 65 +++ .../accessibility/html/strong-expected-uia-win.txt | 1 + .../accessibility/html/style-expected-uia-win.txt | 1 + .../accessibility/html/sub-expected-uia-win.txt | 6 + .../html/summary-expected-uia-win.txt | 5 + .../accessibility/html/sup-expected-uia-win.txt | 6 + .../accessibility/html/svg-expected-uia-win.txt | 2 +- .../table-focusable-sections-expected-uia-win.txt | 18 + .../html/table-layout-expected-uia-win.txt | 24 + .../html/table-presentation-expected-uia-win.txt | 10 + .../html/table-th-colheader-expected-uia-win.txt | 9 + .../html/table-th-rowheader-expected-uia-win.txt | 9 + .../html/textarea-expected-uia-win.txt | 4 + .../html/textarea-read-only-expected-uia-win.txt | 4 + .../textarea-with-selection-expected-uia-win.txt | 4 + .../accessibility/html/time-expected-uia-win.txt | 8 + .../accessibility/html/title-expected-uia-win.txt | 2 + .../accessibility/html/ul-expected-uia-win.txt | 9 + .../accessibility/html/var-expected-uia-win.txt | 1 + .../accessibility/html/wbr-expected-uia-win.txt | 6 + 168 files changed, 1965 insertions(+), 161 deletions(-) commit e00b6d61bc024123a7fa3671efd2717c1f27bdb8 Author: Nicolas Ouellet-payeur <nicolaso@chromium.org> Date: Wed Apr 10 19:59:36 2019 +0000 Roll traffic_annotation checkers win32 Bug: 949382 Change-Id: I4a12c77bb506f07678d2bd3e824c2364b37b905b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561630 Reviewed-by: Peter Collingbourne <pcc@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#649616} .../traffic_annotation_extractor/traffic_annotation_extractor.cpp | 4 ++-- tools/traffic_annotation/bin/README.md | 4 ++-- .../traffic_annotation/bin/win32/traffic_annotation_auditor.exe.sha1 | 2 +- .../bin/win32/traffic_annotation_extractor.exe.sha1 | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) commit 550f67648fa7562bb12516205a44296292982db0 Author: Alexander Guettler <alexander@guettler.io> Date: Wed Apr 10 19:56:39 2019 +0000 Fix incorrectly dropping WM_MOUSELEAVE after a call to SetCapture After fixing the bounds check in r623087 it could happen that the window below the mouse is still the render_widget_host after a tooltip was created and called SetCapture to not forward mouse events to us. This makes sure that we only do the bounds check if there is not a capture currently active. R=kenrb@chromium.org, lanwei@chromium.org Bug: 944772 Change-Id: Id6f5ab4ca1f643a8830ad22b36a6975b1da5bc95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554356 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#649615} content/browser/renderer_host/legacy_render_widget_host_win.cc | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) commit 3f6b4c3cf71e39e668c3dcae6aa36723d096459c Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 10 19:56:19 2019 +0000 Roll Fuchsia SDK from 891657183417 to 891654856501 The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I3649ea708153e3d33688e5d5fb96268364932f93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562043 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649614} build/fuchsia/linux.sdk.sha1 | 2 +- build/fuchsia/mac.sdk.sha1 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit 6a4420c76da22cd7b8536488f8ce030876a04528 Author: Jérôme Lebel <jlebel@chromium.org> Date: Wed Apr 10 19:55:31 2019 +0000 [iOS] Adding metrics in the Advanced settings sign-in Adding user actions for the advanced setting view: + Signin_Signin_ConfirmAdvancedSyncSettings The user taps on "Confirm". + Signin_Signin_CancelAdvancedSyncSettings The user cancels the settings (by tapping on the cancel button and then validate the alert dialog). Bug: 937110 Change-Id: I4d3653571febd373b0a642e56dc35f5d1f369532 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554675 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#649613} .../google_services/advanced_signin_settings_coordinator.mm | 10 ++++++++++ 1 file changed, 10 insertions(+) commit 8680bb35e936f41cc40ee40c3da181e08ba72103 Author: Mikel Astiz <mastiz@chromium.org> Date: Wed Apr 10 19:55:13 2019 +0000 Decouple SESSIONS and DEVICE_INFO sync datatypes This simplifies the dependencies and the interactions across datatypes, which are quite fragile and rely on special-casing for DeviceInfo in ProfileSyncService (very early initialization via InitLocalCacheGuid()). Instead, let's make SESSIONS read the individual fields it needs (i.e. device name and type) directly from common utility libraries. Bug: 951051 Change-Id: I99831ff5bc66003bc1142551f654b9fa387e4e28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560151 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#649612} .../browser/sync/session_sync_service_factory.cc | 10 -- components/sync/BUILD.gn | 2 + components/sync/base/get_session_name.h | 1 + .../device_info/local_device_info_provider_impl.cc | 25 +--- .../sync/device_info/local_device_info_util.cc | 30 +++++ .../sync/device_info/local_device_info_util.h | 16 +++ .../sync_sessions/mock_sync_sessions_client.h | 1 - components/sync_sessions/session_store.cc | 136 +++++++++++---------- components/sync_sessions/session_store.h | 43 +++---- components/sync_sessions/session_store_unittest.cc | 32 ++--- components/sync_sessions/session_sync_bridge.cc | 11 +- .../sync_sessions/session_sync_bridge_unittest.cc | 12 +- components/sync_sessions/sync_sessions_client.h | 8 -- .../browser/sync/session_sync_service_factory.mm | 11 -- 14 files changed, 150 insertions(+), 188 deletions(-) commit d01caf500642d628bc3d71aa17186248b7d14edb Author: Austin Eng <enga@chromium.org> Date: Wed Apr 10 19:54:27 2019 +0000 Revert "Remove sharding for dawn_end2end_tests" This reverts commit 9d4aadda13a5e933ddb3d94ae746176085f8bef2. Reason for revert: Breaking tests on waterfall and CQ Original change's description: > Remove sharding for dawn_end2end_tests > > These tests run very quickly and do not need to be sharded. > > Bug: 948902 > Change-Id: Ice7c19d1f603dc378af36eee86e396fcdebda88f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558709 > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Austin Eng <enga@chromium.org> > Cr-Commit-Position: refs/heads/master@{#649570} TBR=kbr@chromium.org,enga@chromium.org Change-Id: I0cdc653be4306cef6c78708d2b7f684acdb5acc6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 948902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562292 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#649611} testing/buildbot/chromium.dawn.json | 48 ++++++++---- testing/buildbot/chromium.gpu.fyi.json | 132 ++++++++++++++++++++++----------- testing/buildbot/test_suites.pyl | 6 ++ 3 files changed, 126 insertions(+), 60 deletions(-) commit 38d3e7c98537aed326e6cf89384ec262cdaec591 Author: Matt Mueller <mattm@chromium.org> Date: Wed Apr 10 19:54:06 2019 +0000 Skip NSS temp certificates in TrustStoreNSS This ensures that during the trial when CertVerifyProcNSS and CertVerifyProcBuiltin are being used simultaneously, the builtin verifier does not get to "cheat" by using AIA fetched certs from CertVerifyProcNSS. Bug: 951166 Change-Id: Ib0b3241f6764360df74bd5ede693e92cf0381de0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559206 Reviewed-by: Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#649610} net/cert/internal/system_trust_store.cc | 10 ++++++++++ net/cert/internal/trust_store_nss.cc | 11 +++++++++++ net/cert/internal/trust_store_nss_unittest.cc | 9 +++++++++ net/cert/test_root_certs.h | 3 +++ net/cert/test_root_certs_nss.cc | 19 +++++++++++++++++++ 5 files changed, 52 insertions(+) commit 6b8f7cbbbeefd3a1d3e2356b9fcbe130f43bc149 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 10 19:52:02 2019 +0000 Roll src/third_party/depot_tools 224e075bba5b..280474c2a985 (1 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/224e075bba5b..280474c2a985 git log 224e075bba5b..280474c2a985 --date=short --no-merges --format='%ad %ae %s' 2019-04-10 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@280474c2a985 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ia28cb9e19e31631a2db79818f905698d066989c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562039 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649609} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 39b7c5a1e465246aa2648e3a836bda762c1b004e Author: Matt Menke <mmenke@chromium.org> Date: Wed Apr 10 19:47:51 2019 +0000 GetAdditionalErrorState refactor 3, use SSLCertRequestInfo. This replaces ClientSocketHandle::ssl_error_response_info() with ClientSocketHandle::ssl_cert_request_info(), as only the cert request field of ssl_error_response_info was being populated. Bug: 927101, 950654 Change-Id: I9b0820904a4119714711275c1997c59546589117 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558572 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#649608} net/http/http_proxy_connect_job.cc | 12 ++++++------ net/http/http_proxy_connect_job.h | 4 ++-- net/http/http_stream_factory_job.cc | 3 +-- net/socket/client_socket_handle.cc | 2 +- net/socket/client_socket_handle.h | 18 +++++++++--------- net/socket/client_socket_pool_base_unittest.cc | 26 +++++++++++--------------- net/socket/socket_test_util.h | 1 + net/socket/ssl_connect_job.cc | 9 ++++----- net/socket/ssl_connect_job.h | 4 ++-- 9 files changed, 37 insertions(+), 42 deletions(-) commit 58093d29a6627f9ed24d6ed695dfdc18a2065fd7 Author: Jan Krcal <jkrcal@chromium.org> Date: Wed Apr 10 19:45:31 2019 +0000 [AF] Fix integration tests for autofill wallet This CL fixes problems in sync integration tests introduced by CL 1388430 and prepares for relanding CL 1538416. Bug: 836718 Change-Id: I70bc5ee1ff8b62cefc2705aedc399dcd2fe1f089 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561108 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by: Florian Uunk <feuunk@chromium.org> Cr-Commit-Position: refs/heads/master@{#649607} .../integration/single_client_wallet_sync_test.cc | 10 ++++++++++ .../test/integration/two_client_wallet_sync_test.cc | 9 +++++++++ .../browser/sync/test/integration/wallet_helper.cc | 20 +++++++------------- 3 files changed, 26 insertions(+), 13 deletions(-) commit faae31ac4265daa674f4db76afe35e6982254cfb Author: Matt Menke <mmenke@chromium.org> Date: Wed Apr 10 19:45:20 2019 +0000 GetAdditionalErrorState refactor 2, don't populate unused value. CliseSocketHandle::ssl_error_response_info() used to be used to pass along auth challenge information when establishing an HTTPS tunnel over an auth proxy. Proxy tunnel http auth has since been reworked to no longer use the field, but it's still populated in that case. This CL changes that - the field is now only populated in the case of SSL cert requests. Bug: 927101 Change-Id: Ia115967e7f88fb96131eb8a5e6295f92cdafe643 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558491 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#649606} net/socket/client_socket_handle.h | 9 ++++++--- net/socket/ssl_connect_job.cc | 11 ++++------- net/socket/ssl_connect_job.h | 3 +++ 3 files changed, 13 insertions(+), 10 deletions(-) commit f523816d7694baf743cd43fd3d87a72bc416bb7f Author: Michael Giuffrida <michaelpg@chromium.org> Date: Wed Apr 10 19:43:28 2019 +0000 Hide app icons and overflow button in Kiosk Next shelf This hides all shelf items other than the Back and Home buttons (including running apps, pinned apps, and dialog windows). This is a bit of a hack; a real fix would be to avoid creating the views for these items, but today the views are tightly coupled with the shelf model. Alternatively, we could avoid adding the shelf items to the shelf model, but that will require fixing several assumptions about running app windows. Bug: 951212 Test: KioskNextShelfViewTest Change-Id: Iabce1f2f566231f4d5ce74b2184a7fab1b26e5a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560750 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#649605} ash/BUILD.gn | 2 + .../kiosk_next_shell_controller_unittest.cc | 43 ++-------------------- ash/kiosk_next/kiosk_next_shell_test_util.cc | 40 ++++++++++++++++++++ ash/kiosk_next/kiosk_next_shell_test_util.h | 17 +++++++++ ash/shelf/shelf_view.cc | 12 ++++++ ash/shelf/shelf_view_unittest.cc | 40 +++++++++++++++++++- 6 files changed, 114 insertions(+), 40 deletions(-) commit 7eb0c33ec594af45b8063d59718f1780f8bb34da Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Wed Apr 10 19:42:48 2019 +0000 Update V8 to version 7.5.241. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/583668a3..7274e4b5 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I253082100ac51f58f19a63a72c83f6bd8ebc62bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562151 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649604} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 600fe244b189837b85b0f0e9f072d3cef267c80b Author: Collin Baker <collinbaker@chromium.org> Date: Wed Apr 10 19:37:26 2019 +0000 Suppress main menu button tooltip when in-product help is showing Bug: 944578 Change-Id: I9f98209315b9ca3b85e025ba2806c42501e0ea36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555416 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#649603} chrome/browser/ui/views/toolbar/browser_app_menu_button.cc | 10 ++++++++++ chrome/browser/ui/views/toolbar/browser_app_menu_button.h | 1 + 2 files changed, 11 insertions(+) commit 5c242777a5e7a96c2805157265ef96382568b464 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 10 19:32:28 2019 +0000 Roll src/third_party/chromite a903c04a7e50..c62d4b70f2c7 (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/a903c04a7e50..c62d4b70f2c7 git log a903c04a7e50..c62d4b70f2c7 --date=short --no-merges --format='%ad %ae %s' 2019-04-10 mikenichols@chromium.org upload_symbols: Remove prepare call as it is no longer needed Created with: gclient setdep -r src/third_party/chromite@c62d4b70f2c7 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: Ic3a844e608e5e51e93253d8ba294fbb7a601fef6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562031 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649602} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 3f358947ccbb12d5f39fa6096aae646279e29804 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 10 19:31:26 2019 +0000 Roll src/third_party/webrtc c21cf046181d..0951cfd13e29 (6 commits) https://webrtc.googlesource.com/src.git/+log/c21cf046181d..0951cfd13e29 git log c21cf046181d..0951cfd13e29 --date=short --no-merges --format='%ad %ae %s' 2019-04-10 crodbro@webrtc.org Add crodbro as owner of congestion controller. 2019-04-10 yvesg@webrtc.org Provide robust and efficient variance computation for online statistics. 2019-04-10 eladalon@webrtc.org Pass notifications of RTT, PLR and LossNotification RTCP through EncoderSimulcastProxy 2019-04-10 eladalon@webrtc.org Translate loss notifications and pass to encoder 2019-04-10 eladalon@webrtc.org RTPSenderVideo::GetSentRtpPacketInfo() over a set of sequence numbers 2019-04-10 yinwa@webrtc.org Add base class NetworkPredictor and NetworkPredictorFactory and wire up. Created with: gclient setdep -r src/third_party/webrtc@0951cfd13e29 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:none TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iea56327abd3b24c428c12d21c0a8b90396dff42c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562037 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649601} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit b38b64ccc042e315a0021e245ac1263c562a047b Author: Stephen Martinis <martiniss@chromium.org> Date: Wed Apr 10 19:30:12 2019 +0000 Add //tools/infra/reproduce.py script This script should help developers reproduce build failures on their local machine. Change-Id: I93c367f847a115b99c7c5d4a093674725dbfa82a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1399572 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#649600} .vpython | 10 + tools/infra/OWNERS | 5 + tools/infra/PRESUBMIT.py | 31 +++ tools/infra/reproduce.py | 552 ++++++++++++++++++++++++++++++++++++++ tools/infra/reproduce_unittest.py | 244 +++++++++++++++++ 5 files changed, 842 insertions(+) commit 32290196b7bc2c4686236833ea0905ab8cddd055 Author: Moe Ahmadi <mahmadi@chromium.org> Date: Wed Apr 10 19:29:28 2019 +0000 [IOS][Translate] Add manual translate entry in the popup menu TBR=noyau@google.com Bug: 905816 Change-Id: Id93c2774d4b839ab7cd523c748af1d713da23f32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559123 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Reviewed-by: anthonyvd <anthonyvd@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#649599} chrome/browser/about_flags.cc | 2 +- chrome/browser/android/chrome_feature_list.cc | 2 +- .../feature_engagement/public/event_constants.cc | 1 + .../feature_engagement/public/event_constants.h | 3 + .../feature_engagement/public/feature_constants.cc | 2 + .../feature_engagement/public/feature_constants.h | 1 + .../feature_engagement/public/feature_list.cc | 1 + .../feature_engagement/public/feature_list.h | 3 + .../translate/core/browser/translate_prefs.cc | 2 +- .../translate/core/browser/translate_prefs.h | 4 +- ios/chrome/app/strings/ios_strings.grd | 5 +- ios/chrome/browser/about_flags.mm | 3 + ios/chrome/browser/ios_chrome_flag_descriptions.cc | 4 ++ ios/chrome/browser/ios_chrome_flag_descriptions.h | 4 ++ ios/chrome/browser/ui/browser_view/BUILD.gn | 1 + .../ui/browser_view/browser_view_controller.mm | 13 ++++ ios/chrome/browser/ui/commands/browser_commands.h | 3 + ios/chrome/browser/ui/popup_menu/BUILD.gn | 3 + .../ui/popup_menu/popup_menu_action_handler.h | 8 +++ .../ui/popup_menu/popup_menu_action_handler.mm | 12 ++++ .../browser/ui/popup_menu/popup_menu_constants.h | 2 + .../browser/ui/popup_menu/popup_menu_constants.mm | 1 + .../ui/popup_menu/popup_menu_coordinator.mm | 2 + .../browser/ui/popup_menu/popup_menu_mediator.mm | 78 ++++++++++++++++++--- .../ui/popup_menu/public/cells/popup_menu_item.h | 1 + .../browser/ui/popup_menu/resources/BUILD.gn | 8 +++ .../popup_menu_translate.imageset/Contents.json | 18 +++++ .../popup_menu_translate@2x.png | Bin 0 -> 795 bytes .../popup_menu_translate@3x.png | Bin 0 -> 1165 bytes 29 files changed, 173 insertions(+), 14 deletions(-) commit c1ae1d5515368556d2eb12e8d4a440136ac1cce4 Author: Matt Menke <mmenke@chromium.org> Date: Wed Apr 10 19:28:27 2019 +0000 GetAdditionalErrorState refactor 1, add method to get proxy socket. Create new method ConnectJob::GetProxySocketOnFailure, to return the nested proxy socket on error. Also refactor how connection timing is extracted from the nested proxy ConnectJob and set created ClientSocketHandles. This is part of an effort to remove ConnectJob::SetAdditionalErrorState, which is a layering violation, since it takes a ClientSocketHandle, which is a SocketPool object, and SocketPools are a higher layer than ConnectJobs. Bug: 927101 Change-Id: I9f76fda07db8bc7479bf426e9f541e17a03cbbb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557863 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#649598} net/socket/client_socket_handle.cc | 15 ++++++++++++ net/socket/client_socket_handle.h | 6 +++++ net/socket/connect_job.cc | 4 ++++ net/socket/connect_job.h | 5 ++++ net/socket/ssl_connect_job.cc | 28 ++++++++++------------ net/socket/ssl_connect_job.h | 5 +++- net/socket/transport_client_socket_pool.cc | 4 ++-- .../websocket_transport_client_socket_pool.cc | 2 +- 8 files changed, 50 insertions(+), 19 deletions(-) commit 478b094e3c63aa1514132732d1aef442e49de645 Author: Justin Cohen <justincohen@google.com> Date: Wed Apr 10 19:27:45 2019 +0000 [ios] Remove dead code in the BVC. Followup to crrev.com/c/1470737. Change-Id: I2022a386423e7fbcad4d3f9c0a35bd7361288483 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561960 Commit-Queue: Justin Cohen <justincohen@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#649597} ios/chrome/browser/ui/browser_view/browser_view_controller.mm | 5 ----- 1 file changed, 5 deletions(-) commit 39e8fd620430b4fd09e98cf6fb250484cea235df Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 10 19:24:08 2019 +0000 Roll src/third_party/perfetto 62566e3bb1a3..28fa257fa607 (2 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/62566e3bb1a3..28fa257fa607 git log 62566e3bb1a3..28fa257fa607 --date=short --no-merges --format='%ad %ae %s' 2019-04-10 rsavitski@google.com Merge "Add tools/busy_threads for spawning N busy-wait threads for debugging" 2019-04-10 fmayer@google.com Merge "Do not swallow trace_to_text stderr in heap_profile script." Created with: gclient setdep -r src/third_party/perfetto@28fa257fa607 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I8e2df42ca592397d4cbb50c1ac09132afe5910b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562036 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649596} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 2a9a5ff66fa73ebb1d2fec5f8be8fba44cfdd2ff Author: Tim Song <tengs@chromium.org> Date: Wed Apr 10 19:22:18 2019 +0000 Update class comment for UnifiedSystemTray to be more clear. Change-Id: I85520cec577992d2989786088a30f4e8f2649a29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560382 Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#649595} ash/system/unified/unified_system_tray.h | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) commit b8bf92d2abc4fb845d87160b56c6ba436583e73a Author: Brandon Wylie <wylieb@chromium.org> Date: Wed Apr 10 19:18:26 2019 +0000 [Image Fetcher] Make ImageDecodedCallback a base::OnceCallback This is logically a once callback and clients binding with base::Bind or base::BindRepeating are a hassle and don't make sense. Also replaced some custom testing decoders with those provided by components/image_fetcher where appropriate. Bug: 946757 Change-Id: I90b4a3d76ec8e3c9daff3b561c987677fa1e596d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542158 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Sky Malice <skym@chromium.org> Reviewed-by: Patrick Noland <pnoland@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#649594} chrome/browser/image_fetcher/image_decoder_impl.cc | 10 +++---- chrome/browser/image_fetcher/image_decoder_impl.h | 7 ++--- .../thumbnail_decoder_impl_unittest.cc | 8 +++--- .../image_fetcher/core/fake_image_decoder.cc | 20 +++++++++++--- components/image_fetcher/core/fake_image_decoder.h | 11 +++++--- components/image_fetcher/core/image_decoder.h | 4 +-- .../image_fetcher/core/image_fetcher_impl.cc | 7 +++-- components/image_fetcher/core/image_fetcher_impl.h | 2 ++ components/image_fetcher/core/mock_image_decoder.h | 3 +- .../image_fetcher/ios/ios_image_decoder_impl.mm | 14 +++++----- .../remote/cached_image_fetcher_unittest.cc | 32 ++++------------------ .../remote_suggestions_provider_impl_unittest.cc | 22 ++------------- components/ntp_tiles/icon_cacher_impl_unittest.cc | 17 ++++-------- .../logo_service_impl_unittest.cc | 9 +++--- 14 files changed, 70 insertions(+), 96 deletions(-) commit e0ada6ad39996183463704e5c127a9d539011b3c Author: Jeroen de Borst <jeroendb@chromium.org> Date: Wed Apr 10 19:15:57 2019 +0000 Adding WebRTC-ICE-mDNS study Bug: None Change-Id: If81813713e4d476f6e7645684cf40482c31d79b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560458 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#649593} testing/variations/fieldtrial_testing_config.json | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) commit f62d7520ad73e280ed2ffecd47a9b4da0480b46a Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 10 19:12:12 2019 +0000 Roll src/third_party/angle a131a1515471..76a9a97fb2a1 (3 commits) https://chromium.googlesource.com/angle/angle.git/+log/a131a1515471..76a9a97fb2a1 git log a131a1515471..76a9a97fb2a1 --date=short --no-merges --format='%ad %ae %s' 2019-04-10 jmadill@chromium.org Minor update to auto-roller infra docs. 2019-04-10 syoussefi@chromium.org Vulkan: update GLES3 and EGL expectations 2019-04-10 spang@chromium.org Vulkan: Expose GL_EXT_memory_object_fd & GL_EXT_semaphore_fd Created with: gclient setdep -r src/third_party/angle@76a9a97fb2a1 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I2cbcea5d05ee43cde8390f346b2bf8253097c2a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562035 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649592} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 26f5dea92921f1ef460501e2edc0b05b3d9120cf Author: Min Qin <qinmin@chromium.org> Date: Wed Apr 10 19:04:25 2019 +0000 Make SimpleDownloadManagerCoordinator a KeyedService This CL makes SimpleDownloadManagerCoordinator a KeyedService, and a factory class is created to build the service for each profile dir. BUG=942770 Change-Id: I940a892929bb2f87b2e72181df9ff6394502e3ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554379 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#649591} chrome/browser/BUILD.gn | 2 + .../browser/download/download_service_factory.cc | 6 ++- .../simple_download_manager_coordinator_factory.cc | 41 +++++++++++++++++ .../simple_download_manager_coordinator_factory.h | 53 ++++++++++++++++++++++ .../factory/download_service_factory_helper.cc | 5 +- .../factory/download_service_factory_helper.h | 2 + .../content/internal/download_driver_impl.cc | 12 ++++- .../content/internal/download_driver_impl.h | 10 +++- .../internal/download_driver_impl_unittest.cc | 2 +- .../common/simple_download_manager_coordinator.cc | 4 ++ components/download/public/common/DEPS | 1 + .../common/simple_download_manager_coordinator.h | 11 ++++- 12 files changed, 140 insertions(+), 9 deletions(-) commit 2c0d90be5e0d290839fc9ba3c825cea13acbdd8d Author: Mikel Astiz <mastiz@chromium.org> Date: Wed Apr 10 19:01:22 2019 +0000 Infer DeviceInfo form factor internally This avoids callers having to inject |is_tablet|, which can be inferred internally, removing duplicated code across platforms and simplifying dependencies across components. Bug: 922971 Change-Id: Ic6fd4c9beb37c8caa4f86cc00d5e502edc01b320 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559960 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#649590} chrome/browser/sync/device_info_sync_service_factory.cc | 2 -- components/gcm_driver/gcm_desktop_utils.cc | 12 +++--------- components/history/core/browser/web_history_service.cc | 5 +---- components/sync/device_info/DEPS | 1 + .../sync/device_info/local_device_info_provider_impl.cc | 14 +++++++------- .../sync/device_info/local_device_info_provider_impl.h | 5 ----- .../local_device_info_provider_impl_unittest.cc | 2 +- components/sync/driver/DEPS | 1 + components/sync/driver/profile_sync_service_bundle.cc | 1 - components/sync/driver/sync_util.cc | 13 ++++++------- components/sync/driver/sync_util.h | 2 +- .../browser/sync/device_info_sync_service_factory.mm | 2 -- .../sync/web_view_device_info_sync_service_factory.mm | 2 -- 13 files changed, 21 insertions(+), 41 deletions(-) commit 2865600ac35d250beb407204eccd019b65da47ce Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Wed Apr 10 18:55:49 2019 +0000 Revert "Resolve AXAuraObjCache ownership" This reverts commit b4d917fe5e0945a916a626bb319755db5246dc54. Reason for revert: Introduces deterministic crash of views_unittests DesktopWindowTreeHostMusTest.Accessibility on linux-chromeos-dbg: [ RUN ] DesktopWindowTreeHostMusTest.Accessibility [5463:5560:0410/104940.835246:85200347:INFO:service_process_launcher.cc(251)] Launched child process pid=5583 id=E90E5C501330C04382B0A84F50CF8D84/test_ws/00000000000000000000000000000000/45829F28C930837741E0818977E545AD Received signal 11 SEGV_MAPERR ffffffffffffffe8 Original change's description: > Resolve AXAuraObjCache ownership > > TBR=seantopping@chromium.org > > Bug: 950972 > Change-Id: I60744f22b1b17b07545f6b5e4548d9cc67df4d83 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558059 > Commit-Queue: David Tseng <dtseng@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#649515} TBR=dmazzoni@chromium.org,sky@chromium.org,dtseng@chromium.org Change-Id: Id8e8518d023c77bca37d65e915a07cc9dbda25b7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 950972 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561844 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#649589} ash/login/ui/lock_contents_view.cc | 10 ++++-- ash/shelf/login_shelf_view.cc | 12 ++++--- ash/system/tray/tray_background_view.cc | 10 ++++-- ash/ws/ax_ash_window_utils_unittest.cc | 15 +++++---- .../accessibility/ax_tree_source_aura_unittest.cc | 36 ++++++++++----------- .../aura/accessibility/automation_manager_aura.cc | 28 ++++++++-------- .../aura/accessibility/automation_manager_aura.h | 7 ---- .../automation_manager_aura_browsertest.cc | 14 ++++---- .../aura/accessibility/automation_manager_aura.cc | 19 ++++++----- .../aura/accessibility/automation_manager_aura.h | 2 -- .../ui/aura/accessibility/ax_tree_source_aura.cc | 5 ++- .../ui/aura/accessibility/ax_tree_source_aura.h | 4 +-- ui/views/accessibility/ax_aura_obj_cache.cc | 13 +++++--- ui/views/accessibility/ax_aura_obj_cache.h | 7 ++-- .../accessibility/ax_aura_obj_cache_unittest.cc | 20 ++++++------ ui/views/accessibility/ax_aura_obj_wrapper.cc | 3 -- ui/views/accessibility/ax_aura_obj_wrapper.h | 8 ----- .../accessibility/ax_aura_window_utils_unittest.cc | 4 +-- ui/views/accessibility/ax_root_obj_wrapper.cc | 7 ++-- ui/views/accessibility/ax_root_obj_wrapper.h | 3 +- ui/views/accessibility/ax_tree_source_views.cc | 17 ++++------ ui/views/accessibility/ax_tree_source_views.h | 7 +--- .../accessibility/ax_tree_source_views_unittest.cc | 28 ++++++++-------- ui/views/accessibility/ax_view_obj_wrapper.cc | 23 +++----------- ui/views/accessibility/ax_view_obj_wrapper.h | 2 ++ ui/views/accessibility/ax_virtual_view.cc | 11 +++---- ui/views/accessibility/ax_virtual_view.h | 5 ++- ui/views/accessibility/ax_virtual_view_wrapper.cc | 20 +++++------- ui/views/accessibility/ax_virtual_view_wrapper.h | 7 ++-- ui/views/accessibility/ax_widget_obj_wrapper.cc | 2 +- ui/views/accessibility/ax_widget_obj_wrapper.h | 2 ++ ui/views/accessibility/ax_window_obj_wrapper.cc | 8 ++--- ui/views/accessibility/ax_window_obj_wrapper.h | 2 ++ ui/views/accessibility/view_accessibility.cc | 16 ---------- ui/views/accessibility/view_accessibility.h | 12 ------- .../view_ax_platform_node_delegate_unittest.cc | 16 ++++------ ui/views/mus/ax_remote_host.cc | 23 +++++++------- ui/views/mus/ax_remote_host.h | 3 +- ui/views/mus/ax_remote_host_unittest.cc | 37 +++++++++++----------- ui/views/mus/ax_tree_source_mus.cc | 5 ++- ui/views/mus/ax_tree_source_mus.h | 4 +-- ui/views/mus/ax_tree_source_mus_unittest.cc | 21 ++++++------ .../mus/desktop_window_tree_host_mus_unittest.cc | 3 +- ui/views/mus/mus_client.cc | 4 +-- ui/views/mus/mus_client.h | 5 --- 45 files changed, 219 insertions(+), 291 deletions(-) commit 59dd24b86802f43cb88a400823076801ed0da45d Author: Jianpeng Chao <chaopeng@chromium.org> Date: Wed Apr 10 18:48:06 2019 +0000 Revert "Recreate DirectManipulationHelper when every LRWHH UpdateParent" This reverts commit 61450bbccebefd7e16e694ae6f8ef5482b070a85. Reason for revert: crash, issue 951293 Original change's description: > Recreate DirectManipulationHelper when every LRWHH UpdateParent > > Compositor and window event target is associated with window's parent. We call > LRWHH UpdateParent when window's parent update, includes window's parent > actually update and window initialize. Recreate DirectManipulationHelper on > every window's parent update helps keep DirectManipulationHelper lifecycle > tracking simpler. We also make CompositorAnimationObserver owned by > DirectManipulationHelper. > > With this changes, we start the DirectManipulation event polling when > DirectManipulationHelper created and stop when it destroyed. The issue should be > fix since event polling start no more depends on DM_POINTERHITTEST. > > > This also includes 2 refactoring changes: > > 1. Move CompositorAnimationObserver into DirectManipulationHelper. > 2. Call ZoomToRect to reset viewport of DirectManipulation when viewport is > actually transformed in RUNNING - READAY sequence. > > Bug: 914914 > Change-Id: I0a63f9a407e0231d631e64f2b22a9975471f2fd9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547049 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#649342} TBR=sky@chromium.org,chaopeng@chromium.org Change-Id: I5b8ac4f3dfc3d52707038fbffda7baecdbec20c2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 914914 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562077 Reviewed-by: Jianpeng Chao <chaopeng@chromium.org> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#649588} .../direct_manipulation_event_handler_win.cc | 19 ++-- .../direct_manipulation_event_handler_win.h | 1 + .../direct_manipulation_helper_win.cc | 113 ++++++++++---------- .../renderer_host/direct_manipulation_helper_win.h | 38 +++---- .../direct_manipulation_win_browsertest.cc | 54 ++++++++++ .../direct_manipulation_win_unittest.cc | 27 +++-- .../renderer_host/legacy_render_widget_host_win.cc | 116 +++++++++++++++++++-- .../renderer_host/legacy_render_widget_host_win.h | 14 +++ 8 files changed, 268 insertions(+), 114 deletions(-) commit 7bccf4d10ab691093f392def064f14ada5ebe00b Author: Jacob DeWitt <jacde@chromium.org> Date: Wed Apr 10 18:41:16 2019 +0000 Expose XRInputSource.gamepad It will be null until plumbing is added in a separate CL. Also expose nullable button index on XRInputSourceEvent. Bug: 944880 Change-Id: Ic5c50b7583eb6efd8e28033d359243f31e15f29f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555252 Reviewed-by: Brandon Jones <bajones@chromium.org> Commit-Queue: Jacob DeWitt <jacde@chromium.org> Cr-Commit-Position: refs/heads/master@{#649587} third_party/blink/renderer/modules/xr/xr_input_source.cc | 6 ++++++ third_party/blink/renderer/modules/xr/xr_input_source.h | 3 +++ third_party/blink/renderer/modules/xr/xr_input_source.idl | 1 + third_party/blink/renderer/modules/xr/xr_input_source_event.cc | 7 +++++++ third_party/blink/renderer/modules/xr/xr_input_source_event.h | 2 ++ third_party/blink/renderer/modules/xr/xr_input_source_event.idl | 1 + .../blink/renderer/modules/xr/xr_input_source_event_init.idl | 1 + .../external/wpt/webxr/idlharness.https.window-expected.txt | 6 +++--- .../web_tests/webexposed/global-interface-listing-expected.txt | 2 ++ 9 files changed, 26 insertions(+), 3 deletions(-) commit fb5f677ef163ed6137a3b45d15168204ee3e90d1 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 10 18:36:58 2019 +0000 Roll src/third_party/swiftshader 26357f18cb2a..32a9ea1c5be2 (1 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/26357f18cb2a..32a9ea1c5be2 git log 26357f18cb2a..32a9ea1c5be2 --date=short --no-merges --format='%ad %ae %s' 2019-04-10 hliatis@google.com Resolve build issues with Reactor on Android Created with: gclient setdep -r src/third_party/swiftshader@32a9ea1c5be2 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: Id507b5b20a6431b57d7f6cfa3f34a6aea35f52b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562033 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649586} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 49939b3aacf77bca6c55c6e1b85987f8b81881c8 Author: siyua <siyua@chromium.org> Date: Wed Apr 10 18:35:23 2019 +0000 [AF][Paradise] Fix local card migration error dialog header in darkmode Bug: 897998 Change-Id: I1de5ac8bcf5ddf6c414736f483561f9584c41f39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560594 Reviewed-by: Evan Stade <estade@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#649585} .../ui/views/autofill/local_card_migration_error_dialog_view.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) commit 3fa6596d062d1b946d084bc98f6c76df2a25dc63 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Wed Apr 10 18:34:36 2019 +0000 Roll src-internal 0af947a1fa93..6d7730600369 (4 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0af947a1fa93..6d7730600369 Created with: gclient setdep -r src-internal@6d7730600369 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=harrisjay@chromium.org,ellyjones@chromium.org,btolsch@chromium.org Change-Id: I60c99926467c68010b94d38804e11bfef92f2466 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562030 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649584} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e48def67cb1475f05aeec112c4b05aadfa847a66 Author: Alan Cutter <alancutter@chromium.org> Date: Wed Apr 10 18:30:00 2019 +0000 Exponentially delay next PWA install animation for each scope This CL suppresses the next PWA install animation each time it is shown for an exponentially increasing amount of time to avoid spamming the user with visual distractions during normal web browsing. The exponential backoff factors used are: Initial delay: 1 day Exponent factor: x2 Max delay: 90 days Bug: 907351 Change-Id: I2bcefc4f23b1a1d9516cfa5b9b893097168104d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549301 Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#649583} chrome/browser/banners/app_banner_manager.cc | 30 +++-- chrome/browser/banners/app_banner_manager.h | 3 +- .../browser/banners/app_banner_settings_helper.cc | 141 +++++++++++++++++++++ .../browser/banners/app_banner_settings_helper.h | 11 ++ .../page_action/pwa_install_view_browsertest.cc | 19 +++ 5 files changed, 188 insertions(+), 16 deletions(-) commit 01c88d24a3b7f49924850e65d362226d62472087 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 10 18:29:49 2019 +0000 Roll src/third_party/skia 26f410d8cfc0..14003828df72 (9 commits) https://skia.googlesource.com/skia.git/+log/26f410d8cfc0..14003828df72 git log 26f410d8cfc0..14003828df72 --date=short --no-merges --format='%ad %ae %s' 2019-04-10 brianosman@google.com Delete SkSL::Compiler copy constructor and assignment operator 2019-04-10 bungeman@google.com Make path in Sk1DPathEffect thread safe. 2019-04-10 halcanary@google.com SkPDF: split GraphicStateStack out 2019-04-10 halcanary@google.com SkPDF: simplify device drawRect 2019-04-10 ethannicholas@google.com regenerated FP files to make bot happy 2019-04-10 bsalomon@google.com Add Vulkan implementation of transfering from GrSurface to a GrGpuBuffer 2019-04-10 brianosman@google.com Define all ImageSetEntry members out of line 2019-04-10 robertphillips@google.com Skip flush in GrDrawingManager if the specifed proxy doesn't have any work (take 2) 2019-04-10 rmistry@google.com [Android compile bot] Also build frameworks/base/libs/hwui Created with: gclient setdep -r src/third_party/skia@14003828df72 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: I3c1f0a72a22a11f7733eadba5791455b1ae63069 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562032 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649582} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 1b711e7faea010c5e589e55a053598a6635c178c Author: Robert Sesek <rsesek@chromium.org> Date: Wed Apr 10 18:27:12 2019 +0000 Get the service process working with Mojo running over Mach IPC. This adds support to registering launchd jobs with MachServices, and for running a Mojo server channel with it. Bug: 932175 Change-Id: I87a00c5aa329e141e70c154af79784d6bcc3c3ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555500 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#649581} chrome/common/mac/service_management.h | 5 ++++ chrome/common/mac/service_management.mm | 6 ++++ chrome/common/service_process_util_mac.mm | 49 ++++++++++++++++++++++++++++--- chrome/service/service_process.cc | 10 ++++++- 4 files changed, 65 insertions(+), 5 deletions(-) commit 436e62542f5e3ff991eebbc9e7e960d83463546b Author: Scott Violet <sky@chromium.org> Date: Wed Apr 10 18:24:23 2019 +0000 content/aura: makes WebContentsViewAura coalesce changes WebContentsViewAura::WindowObserver notifies the renderer when the WindowTreeHost's origin, or the Window's (or host window's) bounds changes. During a resize it's entirely likely all change (the bounds and origin). This adds observer functions to WindowTreeHostObserver that are called when bounds change processing starts and ends. This allows WebContentsViewAura::WindowObserver to only notify once. BUG=951015 TEST=none Change-Id: I36d9cdfffe0c6e0ef2b0fca21439650bc04f16bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560736 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#649580} .../browser/web_contents/web_contents_view_aura.cc | 89 +++++++++++++++++----- ui/aura/window_tree_host_observer.h | 8 ++ ui/aura/window_tree_host_platform.cc | 5 ++ 3 files changed, 85 insertions(+), 17 deletions(-) commit 24eba9233e976a000b3ca296211bc75e19adf2de Author: Vadym Doroshenko <dvadym@chromium.org> Date: Wed Apr 10 18:23:14 2019 +0000 Removing feature PasswordGenerationRequirementsDomainOverrides. This feature was launched > half year ago. Change-Id: If1597674eb40f0039210e68839361340cea9f98d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561137 Reviewed-by: Dominic Battré <battre@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#649579} .../password_requirements_service_factory.cc | 10 --------- .../core/common/password_manager_features.cc | 6 ------ .../core/common/password_manager_features.h | 1 - testing/variations/fieldtrial_testing_config.json | 24 ---------------------- 4 files changed, 41 deletions(-) commit 30f94ed3506892c0d91f883638cd5a43ac70fc67 Author: Austin Eng <enga@chromium.org> Date: Wed Apr 10 18:23:11 2019 +0000 Implement GPUComputePipeline in Blink Bug: 877147 Change-Id: I295d929190eb47197cf9ac88e2beb52b69e158cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553310 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#649578} .../renderer/modules/webgpu/dawn_conversions.cc | 17 +++++++++++++++++ .../blink/renderer/modules/webgpu/dawn_conversions.h | 3 +++ .../renderer/modules/webgpu/gpu_compute_pipeline.cc | 20 ++++++++++++++++++-- 3 files changed, 38 insertions(+), 2 deletions(-) commit 29da87ad06e21ef14c103f2a3e8628770419f78a Author: Egor Pasko <pasko@chromium.org> Date: Wed Apr 10 18:21:26 2019 +0000 simplecache: remove unused includes Spotted semi-randomly. We used to mmap the index file on load, but we seem no longer. Hm. Then I saw other unused includes, removed them too. Bug: None Change-Id: I680b928a8936ae1f8797a1721ed6c0c1ab66e0d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561690 Auto-Submit: Egor Pasko <pasko@chromium.org> Reviewed-by: Maks Orlovich <morlovich@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#649577} net/disk_cache/simple/simple_index_file.cc | 4 ---- 1 file changed, 4 deletions(-) commit bbb6234ca8dc2f023cd9e3ebb1f80d89df38d1c6 Author: Sammie Quon <sammiequon@google.com> Date: Wed Apr 10 18:21:07 2019 +0000 overview: Remove shield widget. Its not needed anymore because the dimming of wallpaper has been moved to wallpaper code. The children of the shield view have been moved to separate widgets in previous CLs. Home launcher used to observe if the grid shield was animating to avoid crashes, now that it is gone, use a boolean to track state. Fixes a bug with "No recent windows" window not sliding up when sliding from shelf, and adds a new test. Selection widget is now the only user of CreateBackgroudnWidget, so delete it and move its code inline. Use rounded corners clipping instead of a textured layer. Test: manual Bug: 942759, 949307 Change-Id: Icffc01f0e14231df39fc6c938ffe6e70c016d5da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549894 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#649576} ash/app_list/presenter/app_list_presenter_impl.cc | 2 +- ash/app_list/presenter/app_list_presenter_impl.h | 3 +- ash/home_screen/home_launcher_gesture_handler.cc | 200 +++++++++++---------- ash/home_screen/home_launcher_gesture_handler.h | 22 ++- .../home_launcher_gesture_handler_unittest.cc | 72 +++++--- ash/home_screen/home_screen_delegate.h | 3 +- ash/home_screen/home_screen_presenter.cc | 3 +- ash/kiosk_next/kiosk_next_home_controller.cc | 2 +- ash/shelf/shelf_layout_manager_unittest.cc | 14 +- ash/wm/overview/overview_grid.cc | 136 ++++---------- ash/wm/overview/overview_grid.h | 21 +-- ash/wm/overview/overview_item.cc | 16 +- ash/wm/overview/overview_item.h | 5 +- ash/wm/overview/overview_session.cc | 41 +++-- ash/wm/overview/overview_session.h | 53 +++--- ash/wm/overview/overview_session_unittest.cc | 31 ---- ash/wm/overview/overview_utils.cc | 113 ------------ ash/wm/overview/overview_utils.h | 20 --- 18 files changed, 286 insertions(+), 471 deletions(-) commit 65969a6e22b04017718cc2dcbb2f8fcd0ff102df Author: Jan Krcal <jkrcal@chromium.org> Date: Wed Apr 10 18:17:16 2019 +0000 [AF] Fix flaky wallet sync integration tests This CL addresses flakiness in the sync integration test ServerAddressConvertsToSameLocalAddress by waiting further until also the wallet metadata and autofill profiles sync data converge. This further revealed an inherent flakiness in the wallet metadata checker that is fixed by using a nestable RunLoop (as by design of being independent of the PersonalDataManager in its checks, this checker can run nested CheckExitCondition() tasks that in turn use nested RunLoops). Bug: 917498, 921386 Change-Id: Ia01bdd876506f46320f482e50397b74f29335a97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561105 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#649575} chrome/browser/sync/test/integration/two_client_wallet_sync_test.cc | 6 ++++++ chrome/browser/sync/test/integration/wallet_helper.cc | 5 ++++- 2 files changed, 10 insertions(+), 1 deletion(-) commit c565c16e31826bd4ffb0cd9d9658729f40240b2b Author: Sam Maier <smaier@chromium.org> Date: Wed Apr 10 18:15:39 2019 +0000 Android: automatically destroying SequencedTaskRunners This allows us to use SequencedTaskRunners without worrying about leaking the underlying native object. Whenever the SequencedTaskRunner goes empty, it will delete the native object. Bug: 877963 Change-Id: I0b95cd34cf3edd11ac7418d7039af9f37b2de22d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497306 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by: Alex Clarke <alexclarke@chromium.org> Reviewed-by: Karolina Soltys <ksolt@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#649574} .../java/src/org/chromium/base/task/PostTask.java | 2 + .../chromium/base/task/SequencedTaskRunner.java | 3 +- .../base/task/SequencedTaskRunnerImpl.java | 31 +++++++++++ .../base/task/SingleThreadTaskRunnerImpl.java | 6 ++- .../src/org/chromium/base/task/TaskRunnerImpl.java | 61 +++++++++++++++------- 5 files changed, 82 insertions(+), 21 deletions(-) commit 99b05c096d6c847d5450ba09a8f2a00d9ff51f06 Author: Martin Robinson <mrobinson@igalia.com> Date: Wed Apr 10 18:14:56 2019 +0000 Rebuild ATK platform node when list boxes expand The platform nodes for closed Views list boxes (like the omnibox suggestion popup) don't implement any optional ATK interfaces when they are closed. We should trigger a rebuild of the platform node, if necessary, when they expand. Bug: 948819 Change-Id: I942fec40434e6f7093970b0b41a52b2f5ddad5d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556799 Reviewed-by: Joanmarie Diggs <jdiggs@igalia.com> Commit-Queue: Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#649573} .../platform/ax_platform_node_auralinux.cc | 7 +++++- .../ax_platform_node_auralinux_unittest.cc | 28 ++++++++++++++++++++++ 2 files changed, 34 insertions(+), 1 deletion(-) commit 7145e0e71a58c548c08ac44a889a4da26199cf1f Author: Matt Simmons <mattsimmons@chromium.org> Date: Wed Apr 10 18:13:31 2019 +0000 Move ReturnToChromeExperimentsUtil to browser.tasks package. R=yusufo@chromium.org Bug: 934911 Change-Id: Ia2dc8e2789743d6c157bcce907cf1930dce903a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561833 Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Matt Simmons <mattsimmons@chromium.org> Cr-Commit-Position: refs/heads/master@{#649572} chrome/android/chrome_java_sources.gni | 2 +- .../src/org/chromium/chrome/browser/ChromeTabbedActivity.java | 1 + .../chrome/browser/{ => tasks}/ReturnToChromeExperimentsUtil.java | 8 +++++--- 3 files changed, 7 insertions(+), 4 deletions(-) commit 30bfe0fd96a8931f84594694f3fa2dd0ea3a16ae Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Wed Apr 10 18:11:09 2019 +0000 sheriff: mark a layout test as potentially leaky The test is external/wpt/html/user-activation/activation-transfer-cross-origin-with-click.sub.tentative.html Bug: 951453 Change-Id: Ib10b9e6971ac3f2f64f5d4895c6568897a45d801 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561954 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#649571} third_party/blink/web_tests/LeakExpectations | 3 +++ 1 file changed, 3 insertions(+) commit 9d4aadda13a5e933ddb3d94ae746176085f8bef2 Author: Austin Eng <enga@chromium.org> Date: Wed Apr 10 18:08:56 2019 +0000 Remove sharding for dawn_end2end_tests These tests run very quickly and do not need to be sharded. Bug: 948902 Change-Id: Ice7c19d1f603dc378af36eee86e396fcdebda88f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558709 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#649570} testing/buildbot/chromium.dawn.json | 48 ++++-------- testing/buildbot/chromium.gpu.fyi.json | 132 +++++++++++---------------------- testing/buildbot/test_suites.pyl | 6 -- 3 files changed, 60 insertions(+), 126 deletions(-) commit 5733d6f103f02faa53c252077d130d5735aeb5a2 Author: Ian Wells <iwells@chromium.org> Date: Wed Apr 10 18:04:52 2019 +0000 Rename OfflinePageThumbnail to OfflinePageVisuals The OfflinePageThumbnail struct now holds a favicon as well as a thumbnail so this CL renames the struct. Many other class and function names are also changed from "*Thumbnail*" to "*Visuals*" to reflect the inclusion of favicons. Bug: 950115 Change-Id: Iff245d81c2d12c6823b0fdd7e39d4f48f2e4e052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557751 Commit-Queue: Ian Wells <iwells@chromium.org> Reviewed-by: Dan H <harringtond@google.com> Cr-Commit-Position: refs/heads/master@{#649569} .../prefetch/prefetch_service_factory.cc | 6 +- components/offline_pages/core/BUILD.gn | 24 ++--- .../core/downloads/download_ui_adapter.cc | 12 +-- .../core/downloads/download_ui_adapter.h | 5 +- .../core/downloads/download_ui_adapter_unittest.cc | 28 +++--- .../core/model/cleanup_thumbnails_task.h | 48 ---------- ..._thumbnails_task.cc => cleanup_visuals_task.cc} | 31 +++---- .../core/model/cleanup_visuals_task.h | 48 ++++++++++ ...nittest.cc => cleanup_visuals_task_unittest.cc} | 73 +++++++-------- .../offline_pages/core/model/get_thumbnail_task.h | 48 ---------- .../{get_thumbnail_task.cc => get_visuals_task.cc} | 30 +++--- .../offline_pages/core/model/get_visuals_task.h | 48 ++++++++++ ...sk_unittest.cc => get_visuals_task_unittest.cc} | 98 ++++++++++---------- .../offline_pages/core/model/has_thumbnail_task.h | 43 --------- .../core/model/has_thumbnail_task_unittest.cc | 99 -------------------- .../core/model/offline_page_model_taskified.cc | 20 ++-- .../core/model/offline_page_model_taskified.h | 6 +- .../model/offline_page_model_taskified_unittest.cc | 66 +++++++------ .../core/model/offline_page_test_utils.cc | 10 +- .../offline_pages/core/model/store_visuals_task.h | 2 +- .../core/model/store_visuals_task_unittest.cc | 80 ++++++++-------- ...mbnail_task.cc => visuals_availability_task.cc} | 23 +++-- .../core/model/visuals_availability_task.h | 43 +++++++++ .../model/visuals_availability_task_unittest.cc | 100 ++++++++++++++++++++ .../core/offline_page_metadata_store_unittest.cc | 103 +++++++++++---------- components/offline_pages/core/offline_page_model.h | 12 +-- .../offline_pages/core/offline_page_thumbnail.cc | 39 -------- .../offline_pages/core/offline_page_thumbnail.h | 47 ---------- .../core/offline_page_thumbnail_unittest.cc | 55 ----------- components/offline_pages/core/offline_page_types.h | 8 +- .../offline_pages/core/offline_page_visuals.cc | 38 ++++++++ .../offline_pages/core/offline_page_visuals.h | 47 ++++++++++ .../core/offline_page_visuals_unittest.cc | 55 +++++++++++ components/offline_pages/core/prefetch/BUILD.gn | 6 +- .../core/prefetch/prefetch_dispatcher_impl.cc | 10 +- .../core/prefetch/prefetch_dispatcher_impl.h | 6 +- .../prefetch/prefetch_dispatcher_impl_unittest.cc | 58 ++++++------ .../offline_pages/core/prefetch/prefetch_service.h | 2 +- .../core/prefetch/prefetch_service_impl.cc | 12 +-- .../core/prefetch/prefetch_service_impl.h | 8 +- .../core/prefetch/stub_prefetch_service.cc | 2 +- .../core/prefetch/stub_prefetch_service.h | 2 +- ...bnail_info_task.cc => get_visuals_info_task.cc} | 24 ++--- ...umbnail_info_task.h => get_visuals_info_task.h} | 20 ++-- ...ittest.cc => get_visuals_info_task_unittest.cc} | 24 ++--- .../offline_pages/core/stub_offline_page_model.cc | 7 +- .../offline_pages/core/stub_offline_page_model.h | 6 +- 47 files changed, 789 insertions(+), 793 deletions(-) commit 0020bd60033fabff9742344bdcaeabdad96b635f Author: khachatryan <khachatryan@chromium.org> Date: Wed Apr 10 18:03:19 2019 +0000 [ChromeDriver] Update tests to conform for default w3c mode The default mode for chromeDriver is now set to w3c. These changes are made accordingly. Change-Id: I4e5d7f08cea203bc5fbb5f4ee146ff5a0f6895bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560513 Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Reviewed-by: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#649568} chrome/test/chromedriver/test/run_py_tests.py | 89 +++++++++++++-------------- 1 file changed, 44 insertions(+), 45 deletions(-) commit f5b31859adc1350d49c4c1f0b39113848ea4cd5d Author: Christopher Cameron <ccameron@chromium.org> Date: Wed Apr 10 18:01:09 2019 +0000 Mac: Defer -[NSWindow close] until after fullscreen transition ends Starting with the 10.13 SDK, calling -[NSWindow close] while in a fullscreen transiton causes the NSWindow to stay around in a zombie state forever. Avoid this by deferring the -[NSWindow close] call in BridgedNativeWidgetImpl::CloseWindow to after the current fullscreen transition is complete (if there is one). This doesn't cover all situations (e.g, CloseWindowNow), but fixes the most egregious of the bugs. Bug: 945237 Change-Id: Iaf3bf423793e8e900b9c8ace2065f9751f9c7c18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559464 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#649567} ui/views_bridge_mac/bridged_native_widget_impl.h | 7 +++++++ ui/views_bridge_mac/bridged_native_widget_impl.mm | 22 ++++++++++++++++++++++ 2 files changed, 29 insertions(+) commit 49e3b4ea11a770abbfc47a4779e32b5db5bd2312 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Wed Apr 10 18:00:31 2019 +0000 [Extensions Bindings] Remove schema_unused from CreateCustomEvent() The JS version of CreateCustomEvent took in the API schema, but the native one doesn't. Remove the unused variable since we no longer have to match signatures. Bug: 938998 Change-Id: I769f344cab416ffc2a66a5c0f1528b667adc9304 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559334 Reviewed-by: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#649566} chrome/renderer/resources/extensions/web_view/chrome_web_view.js | 4 ++-- extensions/renderer/bindings/api_binding_js_util.cc | 1 - extensions/renderer/bindings/api_binding_js_util.h | 3 --- extensions/renderer/resources/app_window_custom_bindings.js | 2 +- extensions/renderer/resources/context_menus_handlers.js | 3 +-- extensions/renderer/resources/guest_view/guest_view_events.js | 2 +- extensions/renderer/resources/guest_view/web_view/web_view_events.js | 2 +- extensions/renderer/resources/web_request_event.js | 4 ++-- 8 files changed, 8 insertions(+), 13 deletions(-) commit c93ba3b4efdd260538d749e7e92f90020b207bf9 Author: Aran Gilman <gilmanmh@google.com> Date: Wed Apr 10 17:59:55 2019 +0000 Re-submit bypass of ThemePainter for text fields in dark mode. This reverts commit c179aecf42ee0caf5e9c25d7b70ec99f8dccae39. (https://crrev.com/c/1554887) This version fixes the layout test failure on Mac. It looks like the bypass doesn't work as expected; the <input> still isn't inverted, though the <textarea> is. This will need to be addressed in a follow-up CL. Change-Id: Ifee683801cd06ee5023a34d159da7a7de7c7ffdb Bug: 937872 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554833 Commit-Queue: Aran Gilman <gilmanmh@google.com> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#649565} .../blink/renderer/core/paint/theme_painter_default.cc | 9 +++++++++ third_party/blink/web_tests/VirtualTestSuites | 10 ++++++++++ .../dark-mode/native-theme-off/text-input-elements.html | 1 + .../dark-mode/native-theme-on/text-input-elements.html | 1 + .../native-theme-off/text-input-elements-expected.png | Bin 0 -> 3031 bytes .../native-theme-on/text-input-elements-expected.png | Bin 0 -> 2961 bytes .../native-theme-off/text-input-elements-expected.png | Bin 0 -> 1831 bytes .../native-theme-on/text-input-elements-expected.png | Bin 0 -> 1784 bytes .../native-theme-off/text-input-elements-expected.png | Bin 0 -> 3018 bytes .../native-theme-on/text-input-elements-expected.png | Bin 0 -> 2984 bytes .../native-theme-off/text-input-elements-expected.png | Bin 0 -> 1815 bytes .../native-theme-on/text-input-elements-expected.png | Bin 0 -> 1727 bytes .../native-theme-off/text-input-elements-expected.png | Bin 0 -> 3031 bytes .../native-theme-on/text-input-elements-expected.png | Bin 0 -> 2961 bytes .../native-theme-off/text-input-elements-expected.png | Bin 0 -> 1830 bytes .../native-theme-on/text-input-elements-expected.png | Bin 0 -> 1782 bytes .../paint/dark-mode/native-theme-off/README.txt | 3 +++ .../dark-mode/paint/dark-mode/native-theme-on/README.txt | 3 +++ 18 files changed, 27 insertions(+) commit 847de3f0f4332f1e22a9de3d75e3a800559e281e Author: Nate Fischer <ntfschr@chromium.org> Date: Wed Apr 10 17:56:51 2019 +0000 AW: extend histogram expirations No change to logic. This extends three histogram expiration dates for one more year. These three histograms all correspond to long-term efforts to migrate apps toward better practices: - Android.WebView.LoadDataWithBaseUrl.BaseUrl: apps should stop using made-up schemes for baseUrls, and stop using file:// and android_asset/res schemes - Android.WebView.LoadUrl.UrlScheme: apps should stop using file:// and android_asset/res schemes - Android.WebView.SupportLibrary.ClientIsCompat: apps should migrate to AndroidX Bug: 950720, 950721, 950722 Test: None Change-Id: I813c29168d002d5f3673016c8b89b7864bba30d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559505 Reviewed-by: Richard Coles <torne@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#649564} tools/metrics/histograms/histograms.xml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit 7c9e61a336718158e5c2be65b576161d6b75bdf7 Author: Esmael El-Moslimany <aee@chromium.org> Date: Wed Apr 10 17:55:14 2019 +0000 Settings WebUI: replace instances of custom link rows with cr-link-row This originally was a part of a larger CL. For simplicity, this CL also includes three paper-icon-button-light to cr-icon-button replacements. Bug: 736891, 686905 Change-Id: I3a55b23f3b20db1c5309544b87784e08cfdfbc8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560300 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#649563} .../settings/a11y_page/manage_a11y_page.html | 29 ++------ .../android_apps_page/android_apps_page.html | 5 +- .../android_apps_page/android_apps_subpage.html | 9 +-- .../android_apps_page/android_apps_subpage.js | 2 +- .../appearance_page/appearance_fonts_page.html | 18 +---- .../settings/autofill_page/payments_section.html | 17 ++--- .../settings/date_time_page/date_time_page.html | 34 ++------- .../settings/date_time_page/date_time_page.js | 35 +++++---- .../resources/settings/device_page/display.js | 2 +- .../resources/settings/device_page/keyboard.html | 20 ++--- .../resources/settings/device_page/storage.html | 86 +++++----------------- .../resources/settings/device_page/storage.js | 10 +-- .../resources/settings/device_page/stylus.html | 21 ++---- .../settings/downloads_page/downloads_page.html | 10 +-- .../settings/downloads_page/downloads_page.js | 4 +- .../google_assistant_page.html | 14 +--- .../multidevice_page/multidevice_subpage.html | 19 +---- .../settings/privacy_page/privacy_page.html | 19 ++--- .../settings/privacy_page/privacy_page.js | 2 +- 19 files changed, 109 insertions(+), 247 deletions(-) commit a1a4e0b0b3a44a8fba97b15fbf53762c92687bb7 Author: Mike Reed <reed@google.com> Date: Wed Apr 10 17:54:16 2019 +0000 remove flag for legacy shader and colorfilter factories Bug: skia:8937 Change-Id: I3a0554104ffb8546e4b01257a4558062fd14826e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560340 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com> Cr-Commit-Position: refs/heads/master@{#649562} ash/wallpaper/wallpaper_view.cc | 4 ++-- cc/paint/paint_op_buffer_unittest.cc | 2 +- cc/paint/paint_shader.cc | 4 ++-- cc/paint/render_surface_filters.cc | 2 +- cc/trees/layer_tree_host_pixeltest_filters.cc | 9 +++------ components/viz/service/display/gl_renderer_unittest.cc | 2 +- components/viz/service/display/renderer_pixeltest.cc | 4 ++-- components/viz/service/display/skia_renderer.cc | 6 +++--- skia/config/SkUserConfig.h | 8 -------- .../blink/renderer/platform/graphics/draw_looper_builder.cc | 3 +-- .../blink/renderer/platform/graphics/filters/fe_color_matrix.cc | 2 +- third_party/blink/renderer/platform/graphics/filters/fe_flood.cc | 3 +-- .../blink/renderer/platform/graphics/filters/filter_effect.cc | 2 +- .../blink/renderer/platform/graphics/filters/source_alpha.cc | 3 +-- .../blink/renderer/platform/graphics/interpolation_space.cc | 4 ++-- ui/android/resources/resource_manager_impl.cc | 3 +-- ui/gfx/skbitmap_operations.cc | 2 +- ui/gfx/skia_paint_util.cc | 2 +- 18 files changed, 25 insertions(+), 40 deletions(-) commit 3a305bcc1de241e8f16d2d2ccd6a9c5a473e301a Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 10 17:47:29 2019 +0000 Roll src/third_party/perfetto 0d930129cf19..62566e3bb1a3 (1 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/0d930129cf19..62566e3bb1a3 git log 0d930129cf19..62566e3bb1a3 --date=short --no-merges --format='%ad %ae %s' 2019-04-10 hjd@google.com Merge changes I2b573d3d,I7bebb59b Created with: gclient setdep -r src/third_party/perfetto@62566e3bb1a3 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ib286870de5b7514a317fbaa92a12fca2c66a3ee3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561573 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649561} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit f66e9d5202a536ce7a0380f1abd0cb522d59ce13 Author: Kenneth Russell <kbr@chromium.org> Date: Wed Apr 10 17:47:11 2019 +0000 Restore "Win10 FYI Release (NVIDIA)" as Win VM. Perf test processing doesn't work when this bot is run on a thin Linux VM. Bug: 951421 Bug: 950764 Change-Id: I45d7030b33f36f860e76111f8a312d1b843b79c1 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561956 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#649560} infra/config/cr-buildbucket.cfg | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) commit 5c311ee225818161f852a1c5b390eda65622d8a3 Author: Robert Phillips <robertphillips@google.com> Date: Wed Apr 10 17:38:06 2019 +0000 Explicitly flush after an SkCanvas::writePixels Skia/Ganesh now less frequently flushes in its writePixels path. It appears (from the putImageData perf test) that Chrome always wants a flush. This CL makes that decision explicit. With this CL the putImageData perf test runs, locally, at 342.1 runs/s while w/o it, it runs at 304.8 runs/s. Bug: 942538 Change-Id: I4966787a732bc1bfeddc6d251978e8223dd4b593 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561611 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Robert Phillips <robertphillips@google.com> Cr-Commit-Position: refs/heads/master@{#649559} .../blink/renderer/platform/graphics/canvas_resource_provider.cc | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) commit f21ae484d1eeb6882c1d479a6b560bcd0d6ccd65 Author: Natalie Chouinard <chouinard@chromium.org> Date: Wed Apr 10 17:32:46 2019 +0000 Use FakeDBs in RemoteSuggestionsProviderImpl tests Switch the RemoteSuggestionsProviderImplTest unit tests from using "real" ProtoDatabases to FakeDB instances. This is a prerequisite step to make the RemoteSuggestionsDatabase API migration to support shared ProtoDatabases easier. Also includes some minor refactoring and completing a couple TODOs. Bug: 941796 Change-Id: Ic3ea617e223d340879d0956ef1f06fd34a5cc2d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559888 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#649558} .../remote_suggestions_provider_impl_unittest.cc | 1176 ++++++++++---------- 1 file changed, 594 insertions(+), 582 deletions(-) commit 1a8f28d68151246922b44a34463cb513c20fbc1e Author: Mustafa Emre Acer <meacer@chromium.org> Date: Wed Apr 10 17:28:33 2019 +0000 Lookalikes: Properly compute suggested domains Before this CL, suggested domain was the full version of the engaged domain. This is problematic: If the user engaged with docs.google.com, then navigated to googlé[.]com, the interstitial would suggest docs.google.com. This CL suggests the eTLD+1 of the matched domain. All of the following result in suggesting google.com: Navigated: Matched: googlé[.]com google.com mail[.]googlé[.]com google.com googlé[.]com mail.google.com docs[.]googlé[.]com mail.google.com máil.google.com mail.google.com máil.google.com google.com Bug: 950987 Change-Id: I1056eea88ad5380e259770e941d47e08f3987629 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560331 Reviewed-by: Emily Stark <estark@chromium.org> Reviewed-by: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#649557} .../lookalike_url_navigation_throttle.cc | 21 +++++++++- ...ookalike_url_navigation_throttle_browsertest.cc | 45 ++++++++++++---------- chrome/browser/lookalikes/lookalike_url_service.cc | 22 +++++------ chrome/browser/lookalikes/lookalike_url_service.h | 10 +++-- 4 files changed, 58 insertions(+), 40 deletions(-) commit 926900f1631d6ff063a1e81508a1c9ba9c0f0a10 Author: Sergey Ulanov <sergeyu@chromium.org> Date: Wed Apr 10 17:21:42 2019 +0000 [Fuchsia] Disable buffering in the symbolizer stdin stream Previosly the pipe used for symbolizer stdin stream was created with the default buffer size. As result some logs were delayed. Bug: 943745 Change-Id: I6007cf27be5dc29cc5fb7801b5471c1b95c2d0cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558704 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#649556} build/fuchsia/run_package.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit a2070296eb8bd415ffdb518312147dafce6640e1 Author: Julien Racle <jracle@logitech.com> Date: Wed Apr 10 17:19:45 2019 +0000 [base] Vector<T> now implements IIterable<T> Vector<T> shall implement implicitly defined IIterable<T> interface. ABI::Windows::Devices::Enumeration::IDeviceInformationStatics:: FindAllAsyncAqsFilterAndAdditionalProperties(...) will use it. Bug: 728870 Change-Id: I2bc973023fe69538b85e4c2f1ed4e92c654660e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557019 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by: Robert Liao <robliao@chromium.org> Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#649555} base/win/vector.h | 70 +++++++++++++++++++++++++++++++++++++++++++++ base/win/vector_unittest.cc | 49 +++++++++++++++++++++++++++++-- 2 files changed, 116 insertions(+), 3 deletions(-) commit 378c82e67c5b7dbc27c6460a919d841e6b2fad9a Author: dpapad <dpapad@chromium.org> Date: Wed Apr 10 17:18:32 2019 +0000 Extensions cleanup: Move c/b/r/md_extensions to c/b/r/extensions. Bug: 887150 Change-Id: I7a96b03aef50cde4439c1fa5fe484a6fc26dff79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558766 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#649554} chrome/browser/resources/BUILD.gn | 8 ++++---- chrome/browser/resources/{md_extensions => extensions}/BUILD.gn | 2 +- chrome/browser/resources/{md_extensions => extensions}/OWNERS | 0 .../resources/{md_extensions => extensions}/activity_log/BUILD.gn | 0 .../{md_extensions => extensions}/activity_log/activity_log.html | 0 .../{md_extensions => extensions}/activity_log/activity_log.js | 0 .../activity_log/activity_log_history.html | 0 .../activity_log/activity_log_history.js | 0 .../activity_log/activity_log_history_item.html | 0 .../activity_log/activity_log_history_item.js | 0 .../activity_log/activity_log_stream.html | 0 .../activity_log/activity_log_stream.js | 0 .../activity_log/activity_log_stream_item.html | 0 .../activity_log/activity_log_stream_item.js | 0 .../resources/{md_extensions => extensions}/code_section.html | 0 .../resources/{md_extensions => extensions}/code_section.js | 0 .../resources/{md_extensions => extensions}/detail_view.html | 0 .../resources/{md_extensions => extensions}/detail_view.js | 0 .../{md_extensions => extensions}/drag_and_drop_handler.html | 0 .../{md_extensions => extensions}/drag_and_drop_handler.js | 0 .../resources/{md_extensions => extensions}/drop_overlay.html | 0 .../resources/{md_extensions => extensions}/drop_overlay.js | 0 .../resources/{md_extensions => extensions}/error_page.html | 0 .../browser/resources/{md_extensions => extensions}/error_page.js | 0 .../resources/{md_extensions => extensions}/extensions.html | 0 .../{md_extensions => extensions}/extensions_resources.grd | 0 .../extensions_resources_vulcanized.grd | 6 +++--- .../host_permissions_toggle_list.html | 0 .../{md_extensions => extensions}/host_permissions_toggle_list.js | 0 chrome/browser/resources/{md_extensions => extensions}/icons.html | 0 .../{md_extensions => extensions}/install_warnings_dialog.html | 0 .../{md_extensions => extensions}/install_warnings_dialog.js | 0 chrome/browser/resources/{md_extensions => extensions}/item.html | 0 chrome/browser/resources/{md_extensions => extensions}/item.js | 0 .../resources/{md_extensions => extensions}/item_behavior.html | 0 .../resources/{md_extensions => extensions}/item_behavior.js | 0 .../resources/{md_extensions => extensions}/item_list.html | 0 .../browser/resources/{md_extensions => extensions}/item_list.js | 0 .../resources/{md_extensions => extensions}/item_util.html | 0 .../browser/resources/{md_extensions => extensions}/item_util.js | 0 .../{md_extensions => extensions}/keyboard_shortcuts.html | 0 .../resources/{md_extensions => extensions}/keyboard_shortcuts.js | 0 .../{md_extensions => extensions}/kiosk_browser_proxy.html | 0 .../{md_extensions => extensions}/kiosk_browser_proxy.js | 1 - .../resources/{md_extensions => extensions}/kiosk_dialog.html | 0 .../resources/{md_extensions => extensions}/kiosk_dialog.js | 0 .../resources/{md_extensions => extensions}/load_error.html | 0 .../browser/resources/{md_extensions => extensions}/load_error.js | 0 .../browser/resources/{md_extensions => extensions}/manager.html | 0 chrome/browser/resources/{md_extensions => extensions}/manager.js | 0 .../{md_extensions => extensions}/navigation_helper.html | 0 .../resources/{md_extensions => extensions}/navigation_helper.js | 8 +++++--- .../resources/{md_extensions => extensions}/options_dialog.html | 0 .../resources/{md_extensions => extensions}/options_dialog.js | 0 .../resources/{md_extensions => extensions}/pack_dialog.html | 0 .../resources/{md_extensions => extensions}/pack_dialog.js | 0 .../{md_extensions => extensions}/pack_dialog_alert.html | 0 .../resources/{md_extensions => extensions}/pack_dialog_alert.js | 0 .../{md_extensions => extensions}/runtime_host_permissions.html | 0 .../{md_extensions => extensions}/runtime_host_permissions.js | 0 .../{md_extensions => extensions}/runtime_hosts_dialog.html | 0 .../{md_extensions => extensions}/runtime_hosts_dialog.js | 0 .../browser/resources/{md_extensions => extensions}/service.html | 0 chrome/browser/resources/{md_extensions => extensions}/service.js | 0 .../resources/{md_extensions => extensions}/shared_style.html | 0 .../resources/{md_extensions => extensions}/shared_vars.html | 0 .../resources/{md_extensions => extensions}/shortcut_input.html | 0 .../resources/{md_extensions => extensions}/shortcut_input.js | 0 .../resources/{md_extensions => extensions}/shortcut_util.html | 0 .../resources/{md_extensions => extensions}/shortcut_util.js | 0 .../browser/resources/{md_extensions => extensions}/sidebar.html | 0 chrome/browser/resources/{md_extensions => extensions}/sidebar.js | 0 .../browser/resources/{md_extensions => extensions}/strings.html | 0 .../resources/{md_extensions => extensions}/toggle_row.html | 0 .../browser/resources/{md_extensions => extensions}/toggle_row.js | 0 .../browser/resources/{md_extensions => extensions}/toolbar.html | 0 chrome/browser/resources/{md_extensions => extensions}/toolbar.js | 0 .../browser/ui/webui/extensions/extension_settings_browsertest.cc | 2 +- tools/gritsettings/resource_ids | 4 ++-- 79 files changed, 16 insertions(+), 15 deletions(-) commit 2de9663b741936a8237330ae2206aa6285f2db67 Author: Tatiana Buldina <buldina@chromium.org> Date: Wed Apr 10 17:17:31 2019 +0000 [ChromeDriver] Update params.GetDictionary() to params.HasKey() Change-Id: Iea5f54571254c11a237e2e9f8bcf4da4ea81dbc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561870 Reviewed-by: John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#649553} chrome/test/chromedriver/session.h | 4 ++-- chrome/test/chromedriver/session_commands.cc | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) commit d94ae50eea96a984a93839c19a94f4b00e1df7a0 Author: 3su6n15k.default@developer.gserviceaccount.com <3su6n15k.default@developer.gserviceaccount.com> Date: Wed Apr 10 17:17:27 2019 +0000 Automated Commit: LKGM 12068.0.0 for chromeos. BUG=762641 TBR=wutao@google.com Change-Id: I496f950542e4bb9e3326ac034cd4f968f4d00958 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561557 Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649552} chromeos/CHROMEOS_LKGM | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit f51d51dc0402f994d938bfa418ec66c270448a22 Author: Maksym Onufriienko <monufriienko@chromium.org> Date: Wed Apr 10 17:16:13 2019 +0000 Move GREYAsserts from payment_request_egtest_base into the corresponding EG test. This is part of EG1 to EG2 migration, which involves moving EarlGrey code from app-side helpers into test code. For GREYAsserts, the policy is to take assert- containing-helpers that return void, modify them to return bools equivalent to their assert condition instead of asserting, and then assert on the result of the helper on the test side. NSErrors are used to return more detailed error messages for helper functions which contain multiple asserts. To filter mm-files that use payment_request_egtest_base I used: git grep --files-with-matches PaymentRequestEGTestBase . Added TODO for re-using chrome_error_util.h when https://crrev/c/1553085 is ready. Bug: 922813 Change-Id: Ic271519b4112a0e0689c3302f07da7191d70e58a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559889 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Cr-Commit-Position: refs/heads/master@{#649551} .../payment_request_accessibility_egtest.mm | 9 ++-- .../payment_request_can_make_payment_egtest.mm | 26 +++++++---- .../payment_request_cancel_pay_abort_egtest.mm | 7 ++- .../ui/payments/payment_request_debit_egtest.mm | 7 ++- .../ui/payments/payment_request_egtest_base.h | 11 +++-- .../ui/payments/payment_request_egtest_base.mm | 50 +++++++++++++++------- .../payment_request_journey_logger_egtest.mm | 12 ++++-- .../payments/payment_request_modifiers_egtest.mm | 7 ++- .../payment_request_payment_response_egtest.mm | 30 +++++++++---- .../ui/payments/payment_request_show_egtest.mm | 6 ++- .../payments/payment_request_use_stats_egtest.mm | 23 +++++++--- 11 files changed, 129 insertions(+), 59 deletions(-) commit 77120385fa27967de24fed5780552565cd5e7458 Author: Natalie Chouinard <chouinard@chromium.org> Date: Wed Apr 10 17:12:46 2019 +0000 Switch CachedImageFetcher tests to use FakeDBs Switch the NtpSnippetsCachedImageFetcherTest unit tests from using "real" ProtoDatabases to FakeDB instances. This is a prerequisite step to make the RemoteSuggestionsDatabase API migration to support shared ProtoDatabases easier. Bug: 941796 Change-Id: I588dcc014f50e5945f5d48b915823225351fd163 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560144 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#649550} .../remote/cached_image_fetcher_unittest.cc | 52 +++++++++++++++------- 1 file changed, 36 insertions(+), 16 deletions(-) commit edeeb219946d5e8ec30d23f14d2c15d8e70e8863 Author: Amit Hilbuch <amithi@chromium.org> Date: Wed Apr 10 17:04:59 2019 +0000 Re-enabling WPT for RID validations. WebRTC changed RID validations. This change re-enables the WPT tests that have changed as a result. Bug: webrtc:10491 Change-Id: I1191dafe11818c7247c812819376fb18ac05bc7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560412 Commit-Queue: Amit Hilbuch <amithi@chromium.org> Reviewed-by: Steve Anton <steveanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#649549} third_party/blink/web_tests/TestExpectations | 3 --- 1 file changed, 3 deletions(-) commit f83ea60175d8688e5ec632567ee6b71ade3b82c3 Author: Robert Sesek <rsesek@chromium.org> Date: Wed Apr 10 17:01:12 2019 +0000 Fix browser_tests AppShimHostManagerBrowserTest* for MojoChannelMac. Bug: 932175 Change-Id: I63d11771a726f710534651fd60431ec40c4f0b60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559708 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#649548} chrome/app_shim/app_shim_controller.h | 7 +++ chrome/app_shim/app_shim_controller.mm | 56 +++++++++++---------- chrome/browser/apps/app_shim/DEPS | 5 ++ .../app_shim_host_manager_browsertest_mac.mm | 58 ++++++++++++++++------ .../test/app_shim_host_manager_test_api_mac.cc | 4 ++ .../test/app_shim_host_manager_test_api_mac.h | 3 ++ 6 files changed, 93 insertions(+), 40 deletions(-) commit f55e7062f6b48d672f437c67f3e36c4038762921 Author: Esmael El-Moslimany <aee@chromium.org> Date: Wed Apr 10 16:55:53 2019 +0000 Settings WebUI: removing unused paper-icon-button-light imports Bug: 736891 Change-Id: I58fe1e7b7564827af7439e469185f9e95e3a01a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560250 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#649547} chrome/browser/resources/settings/a11y_page/a11y_page.html | 1 - chrome/browser/resources/settings/device_page/device_page.html | 1 - chrome/browser/resources/settings/device_page/display.html | 1 - chrome/browser/resources/settings/printing_page/printing_page.html | 1 - chrome/browser/resources/settings/reset_page/reset_page.html | 1 - chrome/browser/resources/settings/site_settings/site_data.html | 1 - .../resources/settings/site_settings_page/site_settings_page.html | 1 - 7 files changed, 7 deletions(-) commit a847afceccd58528ec6debeb0d744b83a6f14017 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Wed Apr 10 16:54:21 2019 +0000 Roll src-internal fe00b609c173..0af947a1fa93 (2 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fe00b609c173..0af947a1fa93 Created with: gclient setdep -r src-internal@0af947a1fa93 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=harrisjay@chromium.org,ellyjones@chromium.org,btolsch@chromium.org Change-Id: I430c5702435e1dea2c53f47e72784318de22fcaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561571 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649546} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit ca831f4d09fb2472670e33b436dafe003782e726 Author: Chris Lu <thegreenfrog@chromium.org> Date: Wed Apr 10 16:52:18 2019 +0000 Revert "[ios] Aggregate IOS.FindInPageSearchMatches Metric" This reverts commit 9b96b77d2c22aefaebf7570f104a1fd23b260892. Reason for revert: Rebase moved the code change to the wrong metric Original change's description: > [ios] Aggregate IOS.FindInPageSearchMatches Metric > > Bug: 919685 > Change-Id: Ib3ac0b2bfb94ac131b552646bdf25f555cd7aba7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559448 > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Commit-Queue: Chris Lu <thegreenfrog@chromium.org> > Cr-Commit-Position: refs/heads/master@{#649538} TBR=rkaplow@chromium.org,thegreenfrog@chromium.org Change-Id: I421afef4c1fcf7f956b4f98438170b62fdfb5669 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 919685 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561832 Reviewed-by: Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#649545} tools/metrics/ukm/ukm.xml | 7 ------- 1 file changed, 7 deletions(-) commit 38a98775a9d77ea478ffd51ed02d884747163bd6 Author: Yining Wang <yiningwang@google.com> Date: Wed Apr 10 16:51:13 2019 +0000 Follow up on HostedAppBrowserController refactor Follow up on https://chromium-review.googlesource.com/c/chromium/src/+/1549601 Remove unnecessary TODO and remove webappbrowsercontroller destructor body. Change-Id: I86ff570fb63f83626a28b343ddd8b8a2cd081de3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559701 Reviewed-by: Alan Cutter <alancutter@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Peter Boström <pbos@chromium.org> Reviewed-by: Dana Fried <dfried@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#649544} chrome/browser/ui/extensions/hosted_app_browser_controller.cc | 1 - chrome/browser/ui/web_app_browser_controller.cc | 4 +--- 2 files changed, 1 insertion(+), 4 deletions(-) commit 4c3d0be94599326cb8b12fd80063b375553d599b Author: Thomas Tangl <tangltom@chromium.org> Date: Wed Apr 10 16:37:41 2019 +0000 Add "Sync is off" badge in user menu Screenshot: https://drive.google.com/file/d/14aoAOUeJXWntkgHL728I9DWNgB3ye7sb/view?usp=sharing Bug: 951408 Change-Id: I6e18942b611dff015fb50c7888ca514fa92c7312 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561126 Reviewed-by: David Roger <droger@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#649543} chrome/browser/ui/views/profiles/badged_profile_photo.cc | 3 +++ chrome/browser/ui/views/profiles/badged_profile_photo.h | 1 + chrome/browser/ui/views/sync/dice_signin_button_view.cc | 11 +++-------- 3 files changed, 7 insertions(+), 8 deletions(-) commit dcb854bc46dd0e59fae5814e6be88ed144991106 Author: Sébastien Séguin-Gagnon <sebsg@chromium.org> Date: Wed Apr 10 16:36:44 2019 +0000 [SendTabToSelf] Add send_tab_to_self flags on iOS. Bug: 949806 Change-Id: Ifd8aa782f4c8ba4d229cfac81b56b3a0c018b10a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553397 Auto-Submit: sebsg <sebsg@chromium.org> Reviewed-by: Peter Lee <pkl@chromium.org> Commit-Queue: sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#649542} ios/chrome/browser/about_flags.mm | 9 +++++++++ ios/chrome/browser/ios_chrome_flag_descriptions.cc | 12 ++++++++++++ ios/chrome/browser/ios_chrome_flag_descriptions.h | 9 +++++++++ 3 files changed, 30 insertions(+) commit afdf81fdfbdfa55e14dccbb272bd4855c6a0f77b Author: Jordan Demeulenaere <jdemeulenaere@google.com> Date: Wed Apr 10 16:34:31 2019 +0000 [Autofill Assistant] Improve details. Mocks: https://screenshot.googleplex.com/8AR4ihV3aFp.png Result: http://go/aa-details Change-Id: I5d01a7abdb3617af85c4871e0205c1c15aaf5d68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561119 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#649541} .../java/res/layout/autofill_assistant_details.xml | 91 +++++++++++++--------- .../java/res/values-v17/dimens.xml | 2 +- .../java/res/values-v17/styles.xml | 7 +- .../details/AssistantDetails.java | 32 +++++--- .../details/AssistantDetailsViewBinder.java | 45 ++++++++++- .../AutofillAssistantUiTest.java | 8 +- .../autofill_assistant/ui_controller_android.cc | 3 +- components/autofill_assistant/browser/details.cc | 11 +++ .../autofill_assistant/browser/service.proto | 6 +- 9 files changed, 149 insertions(+), 56 deletions(-) commit c8bf4bdba1a3c9c577133876be434279ad124d98 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 10 16:34:22 2019 +0000 Roll src/third_party/webrtc cb2a4ffb2bbd..c21cf046181d (5 commits) https://webrtc.googlesource.com/src.git/+log/cb2a4ffb2bbd..c21cf046181d git log cb2a4ffb2bbd..c21cf046181d --date=short --no-merges --format='%ad %ae %s' 2019-04-10 sakal@webrtc.org Move frame adaptation inside video processor. 2019-04-10 eshr@google.com Revert "Add new field trial for controlling congestion window settings" 2019-04-10 danilchap@webrtc.org merge deps= and unconditional deps+= blocks in media/BUILD.gn 2019-04-10 hofbauer@webrtc.org Add FieldTrial to only send probes on OnMaxTotalAllocatedBitrate() 2019-04-10 eshr@google.com Add new field trial for controlling congestion window settings Created with: gclient setdep -r src/third_party/webrtc@c21cf046181d The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:None,chromium:951299,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I55fc07014d662dbdcd2b709ae754b522a82b57fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561570 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649540} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 6b6e58e96fa8f03ed8dcc7e04ded8de814e1839d Author: Michael Giuffrida <michaelpg@chromium.org> Date: Wed Apr 10 16:31:00 2019 +0000 Enable screenshots in Kiosk Next The Power + Volume Down accelerator should be allowed. Also allow keyboard shortcuts for partial screenshots (useful for developers). Bug: 951206 Change-Id: I7235410115c955cd9241cccfca4b2be1d7d5f828 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560590 Auto-Submit: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#649539} ash/accelerators/accelerator_table.cc | 3 +++ 1 file changed, 3 insertions(+) commit 9b96b77d2c22aefaebf7570f104a1fd23b260892 Author: Chris Lu <thegreenfrog@chromium.org> Date: Wed Apr 10 16:30:28 2019 +0000 [ios] Aggregate IOS.FindInPageSearchMatches Metric Bug: 919685 Change-Id: Ib3ac0b2bfb94ac131b552646bdf25f555cd7aba7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559448 Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#649538} tools/metrics/ukm/ukm.xml | 7 +++++++ 1 file changed, 7 insertions(+) commit 3f73752c32b43b545a08124a2e24a7c18298c1ef Author: Alison Maher <almaher@microsoft.com> Date: Wed Apr 10 16:29:55 2019 +0000 ExpandToEnclosingUnit (TextUnit_Page, TextUnit_Document) This adds an implementation of ITextRangeProvider::ExpandToEnclosingUnit for TextUnit_Page and TextUnit_Document. Behavior for TextUnit_Page is identical to TextUnit_Document, as web pages are not paginated. TextUnit_Document behavior is to always expand to the beginning and end of the top-level document. iframes will jump out of the current iframe and will also expand to the beginning and end of the top-most document. There currently is buggy behavior for the iframe case, and a follow up task will address this issue. Bug: 928948 Change-Id: I9790b2200d61b3449d905488596b7c731ba8c61b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559762 Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#649537} .../ax_platform_node_textrangeprovider_win.cc | 23 ++++- ...platform_node_textrangeprovider_win_unittest.cc | 108 +++++++++++++++++++++ 2 files changed, 130 insertions(+), 1 deletion(-) commit 0ef77c507edbb642219d6e70bb425d49ae4092c2 Author: Christian Dullweber <dullweber@chromium.org> Date: Wed Apr 10 16:29:15 2019 +0000 Fix ClearBrowsingDataPreferencesTest failures on O There can be left-over notification channels from other tests. To avoid them interfering with ClearBrowsingData tests, remove them. Bug: 808600 Change-Id: I617a733cd19f896cb6e1d1e34dc26f0e6d114209 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559177 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#649536} .../preferences/privacy/ClearBrowsingDataPreferencesTest.java | 11 +++++++++++ 1 file changed, 11 insertions(+) commit 48b95fbd75c90f6606805c45688fb1c0ce0f9a1a Author: siashah <siashah@chromium.org> Date: Wed Apr 10 16:27:45 2019 +0000 add components/resources/default_300_percent/google_chrome to gitignore Bug: 949743 Change-Id: Iae30c1ee5a5fa38ae7fc3499e97a1e07a6eaba77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561632 Commit-Queue: Siddharth Shah <siashah@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Auto-Submit: Siddharth Shah <siashah@chromium.org> Reviewed-by: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#649535} .gitignore | 1 + 1 file changed, 1 insertion(+) commit 60b6c62ed216050b1909a6feae7cc4bd3a82c0b8 Author: Jérôme Lebel <jlebel@chromium.org> Date: Wed Apr 10 16:17:49 2019 +0000 [iOS] Open Google services to configure sync settings with unity This patch sets the First Setup Sync flag when the sign-in is done and sync is enabled. This patch only modifies the behavior with UnifiedConsent on. For UnifiedConsent, Sync should never be turned on when the user doesn't agree. This patch renames CommitChanges() to PreUnityCommitChanges(), to make sure all calls have been reviewed and to be explicit that this method should not be called when UnifiedConsent is on. This method is replaced by: + SyncSetupService::SetFirstSetupComplete(): set FirstSetupComplete on, only if sync is on. + SyncSetupService::CommitSyncChanges(): only commit changes. Bug: 883075, 939783, 948681 Change-Id: I687e019d4710433b7a5e6d06ee3a44df360ef678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545290 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#649534} ios/chrome/browser/sync/BUILD.gn | 1 + ios/chrome/browser/sync/sync_setup_service.cc | 23 +++++++++++++++++- ios/chrome/browser/sync/sync_setup_service.h | 21 +++++++++++++++-- .../authentication_flow_performer.mm | 9 +++++++- .../chrome_signin_view_controller.mm | 9 ++++++-- .../advanced_signin_settings_coordinator.mm | 5 +++- .../google_services_navigation_coordinator.mm | 3 +++ .../google_services_settings_coordinator.h | 3 +++ .../google_services_settings_coordinator.mm | 27 ++++++++++++++++++++++ .../manage_sync_settings_coordinator.h | 2 ++ .../ui/settings/settings_navigation_controller.mm | 11 +++++++-- .../ui/settings/settings_table_view_controller.mm | 5 ++++ .../signin_interaction_coordinator.mm | 1 + 13 files changed, 111 insertions(+), 9 deletions(-) commit a9ce904143ff480d5bf2acbc0e02ad2ee0bf9050 Author: Lily Chen <chlily@chromium.org> Date: Wed Apr 10 16:17:08 2019 +0000 Add a PersistentNELStore to NetworkErrorLoggingService This CL adds a pointer to a PersistentNELStore to the NetworkErrorLoggingService. If the store pointer is null, then the NEL policies will be kept in memory only. Otherwise, this backing store will eventually provide persistent storage for NEL policies across browser restarts. Bug: 895821 Change-Id: Ic9d6314c5521f9c2ec10115dbb2c19d05f602492 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551466 Reviewed-by: Martin Šrámek <msramek@chromium.org> Reviewed-by: Eric Orth <ericorth@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#649533} .../browsing_data_remover_impl_unittest.cc | 8 ++++++-- .../network_error_logging_service.cc | 21 ++++++++++++++++----- .../network_error_logging_service.h | 5 ++++- .../network_error_logging_service_unittest.cc | 2 +- net/url_request/url_request_context_builder.cc | 3 ++- 5 files changed, 29 insertions(+), 10 deletions(-) commit a588c5d073e2f9b96e039fa79ad20e6d5a623f9d Author: Thomas Tangl <tangltom@chromium.org> Date: Wed Apr 10 16:16:08 2019 +0000 Don't show Google Account button in user menu when signed out of web Additional change: The account email is specified in the URL for the Google Account page, so the page always shows the account that is seen in the user menu. Bug: 950534 Change-Id: I3272397cbc670e3b87a6464eb8e6d9321753900b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559089 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#649532} .../ui/views/profiles/profile_chooser_view.cc | 38 +++++++++++++++------- .../ui/views/profiles/profile_chooser_view.h | 4 +-- chrome/common/url_constants.cc | 3 ++ chrome/common/url_constants.h | 3 ++ 4 files changed, 34 insertions(+), 14 deletions(-) commit 31318e61f61bf3c509711cf7718b430e8c1672b7 Author: Dan Harrington <harringtond@chromium.org> Date: Wed Apr 10 16:14:28 2019 +0000 Add .settings/ to .gitignore Change-Id: I51e5b5abb5872aa6b8e645f8304c9363b00a596a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559127 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Dan H <harringtond@google.com> Cr-Commit-Position: refs/heads/master@{#649531} tools/android/roll/android_deps/.gitignore | 1 + 1 file changed, 1 insertion(+) commit fd1e7fdcd9f81490d77d2613a011f83d32742c5d Author: Richard Knoll <knollr@chromium.org> Date: Wed Apr 10 16:12:36 2019 +0000 Add UMA logging for notification trigger usage. This also makes sure that we check the trigger delay to not be more than a year ahead of now. Bug: 891339 Change-Id: I9d9adc98cda09c5772b3f8eb1f748ec90aa20a50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503376 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#649530} .../platform_notification_context_impl.cc | 33 +++++++++++-- tools/metrics/histograms/histograms.xml | 54 ++++++++++++++++++++++ 2 files changed, 82 insertions(+), 5 deletions(-) commit 5476d87dc0c1e57868d8c36667013baa588279ee Author: Jorge Lucangeli Obes <jorgelo@google.com> Date: Wed Apr 10 16:08:28 2019 +0000 Add "ChromeOS.UrlXattrsCount" histogram. This histogram will dictate when to remove the file attribute cleaning added to fix https://crbug.com/919486. The histogram was added in https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1508817/. BUG=939386 TEST=pretty_print.py, validate_format.py Change-Id: I6007e3cc00dd1380c99371e3683b4045a837c486 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559891 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by: Brian White <bcwhite@chromium.org> Auto-Submit: Jorge Lucangeli Obes <jorgelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#649529} tools/metrics/histograms/histograms.xml | 10 ++++++++++ 1 file changed, 10 insertions(+) commit 7f6620ca56820c4f587e0a1c18f24524de31ab98 Author: Becca Hughes <beccahughes@chromium.org> Date: Wed Apr 10 16:07:44 2019 +0000 [Media Notification] Add count histogram Add a Media.Notification.Count histogram that records the count of media notifications displayed when a media notification is displayed. BUG=949303 Change-Id: I2503bb6faacd673927e653e2eb5659065bc18c9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552113 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Brian White <bcwhite@chromium.org> Reviewed-by: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#649528} ash/media/media_notification_controller.cc | 20 ++++++++++++++++++++ ash/media/media_notification_controller.h | 9 +++++++++ ash/media/media_notification_controller_unittest.cc | 15 +++++++++++++++ ash/media/media_notification_item.cc | 6 ++++++ tools/metrics/histograms/histograms.xml | 10 ++++++++++ 5 files changed, 60 insertions(+) commit ef816c9da65b44ceaf789fa449d1376383628f41 Author: Aleks Totic <atotic@chromium.org> Date: Wed Apr 10 16:04:39 2019 +0000 OOF bugfix: mark container chain This bug affected NG and Legacy. If an OOF container was no longer an OOF container, the new container needs to be marked for relayout. This did not happen if there was a relayout boundary between old and new OOF container. The fix marks new container for relayout. Bug: 949222 Change-Id: I676ea6d4b4fdbd989cbab08709b4977705250b67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555502 Commit-Queue: Aleks Totic <atotic@chromium.org> Auto-Submit: Aleks Totic <atotic@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#649527} .../blink/renderer/core/layout/layout_block.cc | 8 ++++ .../position-absolute-crash-chrome-005.html | 56 ++++++++++++++++++++++ 2 files changed, 64 insertions(+) commit 5a8e6ee841bd1b6dc5a7d115c8424bf5549fd747 Author: John Budorick <jbudorick@chromium.org> Date: Wed Apr 10 16:03:26 2019 +0000 mb: roll vpython pins to git_revision:0bff6ebf817352838b0e6f65fd6460b38c505c9c. Bug: 949372 Change-Id: I903b561d4441c7b1e9f0cb8711d5a75307f044ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558706 Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by: Nodir Turakulov <nodir@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#649526} tools/mb/mb.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit c1ea4252d0f3a84a14496c31ff3b82c588f38746 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Wed Apr 10 16:02:26 2019 +0000 flags: remove enable-video-player-chromecast-support This flag was wired to the switch of the same name, but the switch has no effect. Bug: None Change-Id: I39c555885c69c5f1af14ca033f221d15716a7669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559502 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#649525} chrome/browser/about_flags.cc | 5 ----- chrome/browser/chromeos/file_manager/video_player_browsertest.cc | 6 ------ chrome/browser/flag-metadata.json | 5 ----- chrome/browser/flag_descriptions.cc | 6 ------ chrome/browser/flag_descriptions.h | 3 --- chromeos/constants/chromeos_switches.cc | 4 ---- chromeos/constants/chromeos_switches.h | 2 -- 7 files changed, 31 deletions(-) commit 19364ba56426f9cc5310a4cff4574ced0e6ad63a Author: Tibor Goldschwendt <tiborg@chromium.org> Date: Wed Apr 10 15:59:55 2019 +0000 [modules] Add readme for how to use dynamic feature modules Bug: 939566 Change-Id: Id6e1de7a0bd0e08765f4f444a7a1d0ec0eb8d665 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547957 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#649524} build/android/docs/android_app_bundles.md | 26 +- docs/README.md | 2 + docs/android_dynamic_feature_modules.md | 687 ++++++++++++++++++++++++++++++ 3 files changed, 704 insertions(+), 11 deletions(-) commit ffdcfb9fe217543fd7bf801b780c3fae13fda3e4 Author: Kush Sinha <sinhak@chromium.org> Date: Wed Apr 10 15:56:16 2019 +0000 Add disclaimer for Primary Accounts in crOS Account Manager UI Bug: 943762 Test: browser_tests --gtest_filter="*CrSettingsPeoplePageAccountManagerTest*" Change-Id: Icf87e5e77e036ee0b831e047f214694405142bd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556847 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#649523} chrome/app/settings_strings.grdp | 6 ++ ...AGER_MANAGEMENT_STATUS_MANAGED_ACCOUNT.png.sha1 | 1 + ...ER_MANAGEMENT_STATUS_UNMANAGED_ACCOUNT.png.sha1 | 1 + .../settings/people_page/account_manager.html | 24 +++++-- .../settings/people_page/account_manager.js | 15 ++++ .../people_page/account_manager_browser_proxy.js | 1 + .../settings/chromeos/account_manager_handler.cc | 27 +++++++ .../md_settings_localized_strings_provider.cc | 4 ++ .../settings/people_page_account_manager_test.js | 84 +++++++++++++++++++++- 9 files changed, 155 insertions(+), 8 deletions(-) commit 7bcdbfc0703782dd5c9b26a26eb1309184e5ea2b Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Wed Apr 10 15:55:21 2019 +0000 flags: assign out-of-blink-cors Bug: None Change-Id: I7157149b4a0c2b144b76be33fdb21dfe4a4521fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560381 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#649522} chrome/browser/flag-metadata.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 581119f02dcfc15dd650708422e6e83a06c9a8ec Author: Charlie Reis <creis@chromium.org> Date: Wed Apr 10 15:51:51 2019 +0000 CORB allowlist additions - 2019-04-09. Bug: 950339 Bug: 950519 Bug: 950872 Bug: 951030 Bug: 951110 Change-Id: Ifdda69346c101c78e05858171d922b5f611327c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560737 Auto-Submit: Charlie Reis <creis@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#649521} extensions/browser/url_loader_factory_manager.cc | 6 ++++++ 1 file changed, 6 insertions(+) commit 7035e372772975670d5e5ec4e6b42ae080cb5a3a Author: Peng Huang <penghuang@chromium.org> Date: Wed Apr 10 15:42:56 2019 +0000 Fix vulkan_tests crashes The crash is because we are delaying creating swap chain until the SetSize() is called. So we need call SetSize() after initialization. Bug: None Change-Id: Id58d7bf8d65f43b70bf7d3ba46ad144a7c92b0a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558762 Commit-Queue: Peng Huang <penghuang@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#649520} gpu/vulkan/vulkan_surface.cc | 7 +++++-- gpu/vulkan/vulkan_surface.h | 2 ++ gpu/vulkan/x/vulkan_surface_x11.cc | 12 +++++++++--- 3 files changed, 16 insertions(+), 5 deletions(-) commit 749c9ea73978b3705efc0e2565a949a693879903 Author: Peter Wen <wnwen@chromium.org> Date: Wed Apr 10 15:42:30 2019 +0000 Android: Add lint-specific comment We explicitly chose to use 16px, so replacing lint TODO with rationale. Bug: 900912 Change-Id: I80b0d1ee7dc4a8500fc72e6dabbef0cd84e0f701 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561551 Commit-Queue: Peter Wen <wnwen@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#649519} chrome/android/java/res/values/dimens.xml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) commit b7cb37d68d4661ad3cbe1676ca51a63c4b346772 Author: Varun Khaneja <vakh@chromium.org> Date: Wed Apr 10 15:39:59 2019 +0000 Add vakh@ as the owner for all histograms owned by chrome-safebrowsing-alerts@ Since it is considered a best practice to have an individual be the point of contact, and it also unbreaks automated scripts. R=drubery Change-Id: I75c7e614efe3b50350b1de2ae5dbf90bcc87c462 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554824 Reviewed-by: Daniel Rubery <drubery@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#649518} tools/metrics/histograms/histograms.xml | 175 +++++++++++++++++++++++++++++++- 1 file changed, 174 insertions(+), 1 deletion(-) commit 41c1805215278d6bf4bb02aece32066b48fd972f Author: Kurt Catti-Schmidt <kschmi@microsoft.com> Date: Wed Apr 10 15:39:49 2019 +0000 ITextRangeProvider::MoveEndpointByUnit (TextUnit_Character) This change implements ITextRangeProvider::MoveEndpointByUnit for the character unit along with unit tests. Functionality is built upon existing CreateNextCharacterPosition/CreatePreviousCharacterPosition. Bug: 928948 Change-Id: I4edfa3cf502287498097589305cdaea3b6cdb1ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559577 Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#649517} .../ax_platform_node_textrangeprovider_win.cc | 37 +++- .../ax_platform_node_textrangeprovider_win.h | 8 +- ...platform_node_textrangeprovider_win_unittest.cc | 198 +++++++++++++++++++++ 3 files changed, 239 insertions(+), 4 deletions(-) commit 40fbef88a24c50f08311063be697b5eb980b0920 Author: Mohamed Amir Yosef <mamir@chromium.org> Date: Wed Apr 10 15:37:51 2019 +0000 [Sync::USS] Relax error detection in PasswordSyncBridge Before this CL: PasswordSyncBridge dealt with empty changes list returned from the password store upon addition and deletion as errors. This is however too strict since there are legit cases where an empty change list could be returned. After this CL: This is relaxed to be aligned with the pre-USS sync implementation. Follow up patches will introduce better error detection. Bug: 949493,902349 Change-Id: I742ef078b56006686e3e7e15a8576252dcd3ebf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561102 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#649516} .../core/browser/sync/password_sync_bridge.cc | 20 ++++++++------------ .../browser/sync/password_sync_bridge_unittest.cc | 17 ----------------- 2 files changed, 8 insertions(+), 29 deletions(-) commit b4d917fe5e0945a916a626bb319755db5246dc54 Author: David Tseng <dtseng@chromium.org> Date: Wed Apr 10 15:34:39 2019 +0000 Resolve AXAuraObjCache ownership TBR=seantopping@chromium.org Bug: 950972 Change-Id: I60744f22b1b17b07545f6b5e4548d9cc67df4d83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558059 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#649515} ash/login/ui/lock_contents_view.cc | 10 ++---- ash/shelf/login_shelf_view.cc | 12 +++---- ash/system/tray/tray_background_view.cc | 10 ++---- ash/ws/ax_ash_window_utils_unittest.cc | 15 ++++----- .../accessibility/ax_tree_source_aura_unittest.cc | 36 ++++++++++----------- .../aura/accessibility/automation_manager_aura.cc | 28 ++++++++-------- .../aura/accessibility/automation_manager_aura.h | 7 ++++ .../automation_manager_aura_browsertest.cc | 14 ++++---- .../aura/accessibility/automation_manager_aura.cc | 19 +++++------ .../aura/accessibility/automation_manager_aura.h | 2 ++ .../ui/aura/accessibility/ax_tree_source_aura.cc | 5 +-- .../ui/aura/accessibility/ax_tree_source_aura.h | 4 ++- ui/views/accessibility/ax_aura_obj_cache.cc | 13 +++----- ui/views/accessibility/ax_aura_obj_cache.h | 7 ++-- .../accessibility/ax_aura_obj_cache_unittest.cc | 20 ++++++------ ui/views/accessibility/ax_aura_obj_wrapper.cc | 3 ++ ui/views/accessibility/ax_aura_obj_wrapper.h | 8 +++++ .../accessibility/ax_aura_window_utils_unittest.cc | 4 +-- ui/views/accessibility/ax_root_obj_wrapper.cc | 7 ++-- ui/views/accessibility/ax_root_obj_wrapper.h | 3 +- ui/views/accessibility/ax_tree_source_views.cc | 17 ++++++---- ui/views/accessibility/ax_tree_source_views.h | 7 +++- .../accessibility/ax_tree_source_views_unittest.cc | 28 ++++++++-------- ui/views/accessibility/ax_view_obj_wrapper.cc | 23 +++++++++++--- ui/views/accessibility/ax_view_obj_wrapper.h | 2 -- ui/views/accessibility/ax_virtual_view.cc | 11 ++++--- ui/views/accessibility/ax_virtual_view.h | 5 +-- ui/views/accessibility/ax_virtual_view_wrapper.cc | 20 +++++++----- ui/views/accessibility/ax_virtual_view_wrapper.h | 7 ++-- ui/views/accessibility/ax_widget_obj_wrapper.cc | 2 +- ui/views/accessibility/ax_widget_obj_wrapper.h | 2 -- ui/views/accessibility/ax_window_obj_wrapper.cc | 8 ++--- ui/views/accessibility/ax_window_obj_wrapper.h | 2 -- ui/views/accessibility/view_accessibility.cc | 16 ++++++++++ ui/views/accessibility/view_accessibility.h | 12 +++++++ .../view_ax_platform_node_delegate_unittest.cc | 16 ++++++---- ui/views/mus/ax_remote_host.cc | 23 +++++++------- ui/views/mus/ax_remote_host.h | 3 +- ui/views/mus/ax_remote_host_unittest.cc | 37 +++++++++++----------- ui/views/mus/ax_tree_source_mus.cc | 5 +-- ui/views/mus/ax_tree_source_mus.h | 4 ++- ui/views/mus/ax_tree_source_mus_unittest.cc | 21 ++++++------ .../mus/desktop_window_tree_host_mus_unittest.cc | 3 +- ui/views/mus/mus_client.cc | 4 ++- ui/views/mus/mus_client.h | 5 +++ 45 files changed, 291 insertions(+), 219 deletions(-) commit 1c185917876e770c509ae1df369065a5d8f3c739 Author: Steven Valdez <svaldez@chromium.org> Date: Wed Apr 10 15:33:28 2019 +0000 Implement 0-RTT with HTTP/1.1 and HTTP/2. Reland of https://chromium-review.googlesource.com/c/chromium/src/+/1067603 with the HTTPSEarlyDataTest.TLSEarlyDataTooEarlyTest test updated to use ZeroRTTResponse to avoid early socket closing on Windows. Bug: 641225 Change-Id: I10f6468b000a0c5a07c78e967a4f14599c4ce499 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559893 Commit-Queue: Steven Valdez <svaldez@chromium.org> Reviewed-by: David Benjamin <davidben@chromium.org> Reviewed-by: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#649514} net/http/http_basic_state.cc | 3 - net/http/http_basic_state.h | 4 - net/http/http_basic_state_unittest.cc | 10 +- net/http/http_basic_stream.cc | 8 +- net/http/http_network_session.cc | 2 + net/http/http_network_session.h | 3 + net/http/http_network_transaction_unittest.cc | 377 +++++++++++++++ net/http/http_proxy_connect_job.cc | 5 +- net/http/http_proxy_connect_job_unittest.cc | 3 + net/http/http_stream_parser.cc | 13 + net/http/http_stream_parser.h | 7 + net/socket/socket_test_util.cc | 30 ++ net/socket/socket_test_util.h | 26 + net/spdy/bidirectional_stream_spdy_impl.cc | 3 +- net/spdy/spdy_http_stream.cc | 4 +- net/spdy/spdy_network_transaction_unittest.cc | 536 +++++++++++++++++++++ net/spdy/spdy_proxy_client_socket_unittest.cc | 11 +- net/spdy/spdy_session.cc | 111 ++++- net/spdy/spdy_session.h | 31 ++ net/spdy/spdy_session_fuzzer.cc | 6 +- net/spdy/spdy_session_unittest.cc | 36 +- net/spdy/spdy_test_util_common.cc | 9 +- net/spdy/spdy_test_util_common.h | 1 + net/url_request/url_request_unittest.cc | 396 +++++++++++++++ net/websockets/websocket_basic_handshake_stream.cc | 12 +- net/websockets/websocket_http2_handshake_stream.cc | 4 +- 26 files changed, 1596 insertions(+), 55 deletions(-) commit a4352cd27f4b62b0668d07e84ac74093a80f45a2 Author: Xi Han <hanxi@chromium.org> Date: Wed Apr 10 15:31:45 2019 +0000 Revert "[Bundles] Add Upstream 64-bit Trichrome Chrome Bundles." This reverts commit b4a06a456edebd47cdc421e752adb6b6e333f422. Reason for revert: Clank Official Build Failure - 75.0.3761.0 crbug.com/951364 Original change's description: > [Bundles] Add Upstream 64-bit Trichrome Chrome Bundles. > > This CL adds the following targets for 64-bit biulds: > trichrome_64_32_chrome_bundle > trichrome_64_chrome_bundle > > These complemnent existing Monochrome targets. > > Also rename template monochrome_public_bundle_tmpl to > monochrome_or_trichrome_public_bundle_tmpl. > > Change-Id: I1773085c82e2dbf068c9bfbd1ca03a7175fee1c8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553913 > Reviewed-by: Christopher Grant <cjgrant@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Commit-Queue: Samuel Huang <huangs@chromium.org> > Cr-Commit-Position: refs/heads/master@{#648671} TBR=huangs@chromium.org,cjgrant@chromium.org,agrieve@chromium.org,tiborg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ifce48fc21989590f7bdcdc5c1337653cf1d9a7cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561272 Reviewed-by: Xi Han <hanxi@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#649513} build/util/android_chrome_version.py | 4 +-- build/util/android_chrome_version_test.py | 8 ----- build/util/version.gni | 18 ++++------ build/util/version_test.py | 16 ++------- chrome/android/BUILD.gn | 56 ++++++++----------------------- chrome/android/chrome_public_apk_tmpl.gni | 4 +-- 6 files changed, 25 insertions(+), 81 deletions(-) commit bb0ffc019bdf9a5f5c7c5441dde84afa89285369 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Wed Apr 10 15:29:02 2019 +0000 Fix compilation with ASan on macOS A recent fix of gn enforced that variables used to perform expansion are defined (see https://bugs.chromium.org/p/gn/issues/detail?id=64). This causes a regression when enabling ASan on macOS as the target //components/policy:manifest_bundle_data defines a bundle that only stores data (no binary) but due to dependency on //base, ends up with a dependency on a bundle_data using {{bundle_executable_dir}} variable that is unset. The dependency on //base comes from the a target defined using the "grit" template that defines target ${target_name} which should be used by binary target that wants to link with the generated source files, and ${target_name}_grit for target that need preprocessing of the .grd files only. The dependency tree is the following: //components/policy:convert_mcx_plist //components/policy:policy_templates //components/policy:translate_policy_templates //base:base ... //components/policy:translate_policy_templates_grit //tools/grit:grit_sources As //components/policy:policy_templates is an action target that convert the preprocessed files in another format suitable for the final binary, there is no need to link against the generated .cc files, thus //components/policy:policy_templates can be changed to depend on //components/policy:translate_policy_templates_grit only instead. Bug: 950669 Change-Id: I0c63f4f90daa204f42626d5c3ddf46943d8b8b97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559147 Reviewed-by: Pavol Marko <pmarko@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#649512} components/policy/BUILD.gn | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 6ec1ce565a021c92f6386540846811fe8e0a6adb Author: Nektarios Paisios <nektar@chromium.org> Date: Wed Apr 10 15:27:08 2019 +0000 AXPosition: First check for a nullptr AXObject container and only then get its new DOM node TBR=dmazzoni@chromium.org, aleventhal@chromium.org Bug: 948470 Change-Id: Idde0dfb0c9feee6b18bdade3367771d24dc6cf25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558905 Reviewed-by: Nektarios Paisios <nektar@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#649511} .../blink/renderer/modules/accessibility/ax_position.cc | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) commit d39249fd7b1707c3d9cbf4dd019082e1817a213a Author: Chromium WPT Sync <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Date: Wed Apr 10 15:25:48 2019 +0000 Import wpt@ce91afa9fa7c840eb5b18fe7e7148f633d32af91 Using wpt-import in Chromium 0240dd9d0b52e3f9537ea9da3511438fd791706c. With Chromium commits locally applied on WPT: 0a8f3ffa48 "Use testdriver Action API in WPT pointerevent touch tests - Part 2" adc34f41f6 "Fix web_test pointerevent_coordinates_when_locked on wpt" 8659792f35 "[WPT] Move wrapResult to common.js and clarify requestVia*() return values" e525003f05 "Do not resume a suspended BaseAudioContext when AudioWorklet starts" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org: external/wpt/css/css-text-decor NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I4ea666dc300ef6fa285604792843c36f59585b6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559942 Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649510} third_party/blink/web_tests/TestExpectations | 10 ++ .../web_tests/external/WPT_BASE_MANIFEST_5.json | 102 ++++++++++++++++++++- .../text-underline-position-019-manual.html | 43 +++++++++ .../text-underline-position-020-manual.html | 43 +++++++++ .../text-underline-position-021-manual.html | 43 +++++++++ .../text-underline-position-022-manual.html | 43 +++++++++ .../text-underline-position-071-manual.html | 44 +++++++++ .../text-underline-position-072-manual.html | 44 +++++++++ .../text-underline-position-073-manual.html | 39 ++++++++ .../text-underline-position-074-manual.html | 39 ++++++++ .../text-underline-position-075-manual.html | 39 ++++++++ .../text-underline-position-076-manual.html | 39 ++++++++ 12 files changed, 527 insertions(+), 1 deletion(-) commit cb03456924c01dc5cef3f7a6588d7b902e21cb18 Author: Robert Phillips <robertphillips@google.com> Date: Wed Apr 10 15:19:04 2019 +0000 Flush pending work after calls to YUVGrBackendTexturesToSkImage Chrome has been relying on Skia flushing internally within RenderYUVAToRGBA (called from YUVGrBackendTexturesToSkImage). We are removing this internal flush, however, to better support DDLs (https://skia-review.googlesource.com/c/skia/+/206688/ (Remove unnecessary flush in RenderYUVAToRGBA (take 2))). Change-Id: I385c9804163eb9544f4deec472a58d4945e830e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560554 Reviewed-by: Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Robert Phillips <robertphillips@google.com> Cr-Commit-Position: refs/heads/master@{#649509} media/renderers/paint_canvas_video_renderer.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) commit 339ccf1d2296b278d6a588da8b4d2ae094f0fa60 Author: Hanfeng Zhu <hanfeng@google.com> Date: Wed Apr 10 15:15:46 2019 +0000 Implement the skeleton of location based customization. Bug: 949145 Change-Id: I7baf49c510a3ee2965fd138e9ceb72d7dab7b171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1550999 Commit-Queue: Hanfeng Zhu <hanfeng@google.com> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#649508} chrome/android/chrome_java_sources.gni | 1 + .../chrome/browser/ChromeTabbedActivity.java | 2 ++ .../LocationCustomizations.java | 23 ++++++++++++++++++++++ .../resources/default_300_percent/google_chrome | 1 + 4 files changed, 27 insertions(+) commit 7ffc69bfa9dae21aa85c20b9bb25215db73534ae Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 10 15:14:45 2019 +0000 Roll src/third_party/skia 064a0b4716d0..26f410d8cfc0 (1 commits) https://skia.googlesource.com/skia.git/+log/064a0b4716d0..26f410d8cfc0 git log 064a0b4716d0..26f410d8cfc0 --date=short --no-merges --format='%ad %ae %s' 2019-04-10 nifong@google.com externs needed for cpu/gpu switch Created with: gclient setdep -r src/third_party/skia@26f410d8cfc0 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: Ibb5f7dc8aab07f068537a6b09445d2f949b11d35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561351 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649507} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e987abb9b902ed9ebda71f5bb146c710454657de Author: Christian Biesinger <cbiesinger@chromium.org> Date: Wed Apr 10 15:13:44 2019 +0000 [layoutng] Use SetSelfNeedsLayoutForAvailableSpace if relayout_children=true This allows better invalidation (in NG we can skip layout in several cases when this condition is true because we can compare constraint spaces). However, in legacy this change causes some tests to fail. Just keep the old code there, as it provides no benefit anyway. This exposed a bug in our caching logic -- we did not check if the intrinsic size of the box has changed. This patch solves that by recomputing and comparing the inline size of the fragment. 32.1% improvement on flexbox-lots-of-data: https://pinpoint-dot-chromeperf.appspot.com/job/130051ff0c0000 Change-Id: I17bc18bd8dab12dd0b2bb17908e8cb777fa37a37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1544639 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#649506} .../blink/renderer/core/layout/layout_block.cc | 31 +++++++++++----------- .../blink/renderer/core/layout/layout_box.cc | 18 ++++++++++++- 2 files changed, 32 insertions(+), 17 deletions(-) commit 5cba50551fe1cbf47e9f68b13ee211dc1aca3a7e Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Wed Apr 10 15:13:25 2019 +0000 Roll src-internal 69aca274e3a2..fe00b609c173 (5 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/69aca274e3a2..fe00b609c173 Created with: gclient setdep -r src-internal@fe00b609c173 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:928220 TBR=harrisjay@chromium.org,ellyjones@chromium.org,btolsch@chromium.org Change-Id: I6cf20099a8308263baa9ef7fc53ce646cbf45a7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561350 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649505} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 4f4cf4850c7bc90677186e213dece33376bbf9db Author: Edwin Joe <ejoe@google.com> Date: Wed Apr 10 15:10:44 2019 +0000 Prevent the RenderWidget from staying visible when the WebContent is hidden. Right now, if we switch tabs in between the start of a navigation and before RenderWidgetHostImpl::WasShown is called in commit navigation, then we would have RenderWidget state stuck at not hidden even though it is hidden, causing it to generate paint event and submitting frames when it is not visible. The sequence of events are as follow: 1. On the start of navigation. RenderWidgetHostImpl is always created as hidden, while RenderWidget is created with its visibility state based on the WebContents' visibility. 2. When swapping the two RenderFrameHost, RenderWidgetHostImpl::WasShown is called to actually show frames to the screen. After this point, the visibility state of the RenderWidget and RenderWidgetHostImpl are in sync. 3. If between the start of navigation and commit navigation we switch out of the tab, we would call RenderWidgetHostImpl::WasHidden on the tab we switch out from, but since it is already hidden, it will exit early. After we finish commit navigation, since the delegate of the WebContents is hidden (since we switch away from the tab), RenderWidgetHostImpl::WasShown will not be called, but we also never tell the RenderWidget to be hidden. We end up with a backgrounded RenderWidget that has is_hidden set to false. This CL sends an IPC message to the RenderWidget when we finish commit if the WebContents is not visible. This change will also fix a problem with the Viz.DisplayCompositor.SurfaceEmbeddingTime UMA metric. If this bug occurs, the surface id allocation generated will be saved while hidden, and the timestamp will be used to record this metric when the WebContents become visible. Since the WebContents can be hidden for an arbitrarily long time, the metric will be inflated. Bug: 936858 Test: RenderFrameHostManagerTest.WebContentVisibilityHiddenBeforeCommit Change-Id: Ie556eb4c242dedacd29f63eeb27f5c6bee6712ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528925 Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Reviewed-by: Jonathan Ross <jonross@chromium.org> Commit-Queue: Edwin Joe <ejoe@google.com> Cr-Commit-Position: refs/heads/master@{#649504} .../frame_host/render_frame_host_manager.cc | 35 ++++++++++++++----- .../render_frame_host_manager_unittest.cc | 40 ++++++++++++++++++++++ .../renderer_host/render_widget_host_impl.cc | 4 +++ .../renderer_host/render_widget_host_impl.h | 5 +++ 4 files changed, 75 insertions(+), 9 deletions(-) commit 5a176962bf8404ab7ebbecbeff5230943e88ec80 Author: Kamila <hkamila@google.com> Date: Wed Apr 10 15:05:02 2019 +0000 Fixed crash in android due to NullPointerException In the new UI in Chrome Android, one can toggle the permissions even when they are blocked for Chrome or for all apps in Android. Geolocation is a special case where the permission can be both modified per app and per device (for all apps). In one scenario (described + video in the bug), switching the permission to blocked causes chrome to crash, due to attempting to setTitle() on a null object. This happens as when you toggle the binary toggle for permission category exceptions the name changes from "Allowed" to "Exceptions" and back. Bug: 949951 Change-Id: If8e7d2b58a977b42c10e5b18e064e79e84d76a2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560194 Reviewed-by: Balazs Engedy <engedy@chromium.org> Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Kamila Hasanbega <hkamila@google.com> Cr-Commit-Position: refs/heads/master@{#649503} .../chrome/browser/preferences/website/SingleCategoryPreferences.java | 2 ++ 1 file changed, 2 insertions(+) commit 124ace86d906bfcbc9252cbf02f4280d37cf59aa Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 10 15:02:56 2019 +0000 Roll src/third_party/webrtc d93a00408699..cb2a4ffb2bbd (3 commits) https://webrtc.googlesource.com/src.git/+log/d93a00408699..cb2a4ffb2bbd git log d93a00408699..cb2a4ffb2bbd --date=short --no-merges --format='%ad %ae %s' 2019-04-10 danilchap@webrtc.org Reland "Remove TaskQueue constructor that uses GlobalTaskQueueFactory" 2019-04-10 alessiob@webrtc.org RNN VAD: Switch to PFFFT 2019-04-10 alessiob@webrtc.org RNN VAD: Opus band spectral analysis refactoring Created with: gclient setdep -r src/third_party/webrtc@cb2a4ffb2bbd The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I01627be124ffb0b32ccf85035c2889cf308f60be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560668 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649502} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 4a27712a44daa57a758125edffaffb96161e44e4 Author: Steven Bennetts <stevenjb@chromium.org> Date: Wed Apr 10 15:02:21 2019 +0000 Separate chromeos/dbus OWNERS files Bug: none Change-Id: I975310395c5da5953350bb9cb5e1d7d73a293132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560451 Reviewed-by: Dan Erat <derat@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#649501} chromeos/dbus/OWNERS | 4 ---- chromeos/dbus/audio/OWNERS | 2 ++ chromeos/dbus/cryptohome/OWNERS | 2 ++ chromeos/dbus/power/OWNERS | 1 + chromeos/dbus/shill/OWNERS | 1 + 5 files changed, 6 insertions(+), 4 deletions(-) commit 8412d5f84ed4bf00fef68ced42b897659b0b5b1e Author: Marc Treib <treib@chromium.org> Date: Wed Apr 10 14:59:11 2019 +0000 components/sync/BUILD.gn: Pull sync/user_events out into a separate target This should probably be moved out of components/sync entirely; this is a first step towards making that happen. Bug: 947443 Change-Id: I6dfce97e32e3aa503788a788b41573cef90d9e73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561095 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#649500} chrome/browser/ui/BUILD.gn | 1 + components/browser_sync/BUILD.gn | 1 + components/sync/BUILD.gn | 39 ++++++++++++++++++++++++++++----------- ios/chrome/browser/sync/BUILD.gn | 1 + ios/web_view/BUILD.gn | 1 + 5 files changed, 32 insertions(+), 11 deletions(-) commit 1afdbc40708cfe9b642bdeccfc1190de9b8427a9 Author: Vasilii Sukhanov <vasilii@chromium.org> Date: Wed Apr 10 14:58:39 2019 +0000 Rewrite NewPasswordFormManager::CreatePendingCredentials. There are behavior changes. The function suggests a credential for update a bit more aggressively: For the case that the user submitted a form with a password but no username, we used to treat the case differently, that the user had a single credential stored. In this case we would offer to update that credential. If the user had more than one credential stored, we would offer to store a new credential. With this CL, on submission of a form with no username but a password, we always offer to update the credential whose username comes alphabetically first. It does not matter how many existing credentials are saved. The following special case remains for PSL matched credentials: - one can save different accounts for a.foo.com and b.foo.com in case they have different passwords but identical usernames. There are other potential follow-up improvement to the class. Namely - Introduce a single interface for IsNewLogin(), IsPasswordOverridden(), IsPasswordUpdate(), IsPendingCredentialsPublicSuffixMatch. Only one of the functions makes sense. We can call it 'IsUpdateForSomePassword' and it returns true if any credential is to be overwritten on the disk. This is blocked on the PasswordFormManager refactoring. - |is_new_login_| and |password_overridden_| are to be replaced with something more decent. This is blocked on the above. - The zoo of Save (which in production does both Save and Update operations) and Update is to be cleaned up. This is not blocked. Bug: 831123 Change-Id: Iab46cd566e08dd59ed8f21544391c6ec58991941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539977 Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by: Dominic Battré <battre@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#649499} .../password_manager_browsertest.cc | 11 +- .../password_manager/password_manager_test_base.cc | 1 + components/autofill/core/common/password_form.cc | 4 + components/autofill/core/common/password_form.h | 3 + .../password_manager/core/browser/form_saver.h | 18 +- .../core/browser/form_saver_impl.cc | 48 +++++- .../core/browser/form_saver_impl.h | 4 +- .../core/browser/form_saver_impl_unittest.cc | 190 +++++++++++---------- .../core/browser/new_password_form_manager.cc | 182 ++++---------------- .../core/browser/new_password_form_manager.h | 35 ++-- .../browser/new_password_form_manager_unittest.cc | 38 ++--- .../core/browser/password_form_manager.cc | 11 +- .../core/browser/password_form_manager.h | 1 - .../core/browser/password_form_manager_for_ui.h | 4 - .../core/browser/password_form_manager_unittest.cc | 39 +++-- .../core/browser/password_generation_state.cc | 3 +- .../core/browser/password_manager_util.cc | 47 +++++ .../core/browser/password_manager_util.h | 12 ++ .../core/browser/password_manager_util_unittest.cc | 143 ++++++++++++++++ .../core/browser/stub_form_saver.h | 4 +- 20 files changed, 472 insertions(+), 326 deletions(-) commit 9cbee243cbbf1d37b0f52fa1eb3e0a61a98488fc Author: Nate Fischer <ntfschr@chromium.org> Date: Wed Apr 10 14:51:58 2019 +0000 Docs: recommend "-no-window" emulator switch This changes the docs to recommend the "-no-window" flag over a combination of "xvfb-run" + "-gpu off". I originally recommended the latter, because ctrl-C didn't close the emulator when I used "-no-window" (see internal bug http://b/127373262). I'm changing my recommendation because: 1. I tried "-no-window" again recently, and can't reproduce the problem from before 2. "-gpu off" triggers a crash when running gradle tests which use ActivityTestRule , while "-no-window" avoids this issue (see internal bug http://b/127061659) Bug: 918221 Test: Upload to gerrit > open file > click "gitiles" Change-Id: I63fba988885b88b128adcee8cc670c11460ca079 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560517 Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#649498} docs/android_emulator.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) commit 0e7cf59b20c5175112e74ba1f417f0edc6d7f56c Author: Kyle Milka <kmilka@chromium.org> Date: Wed Apr 10 14:48:12 2019 +0000 [NTP] Enable Local NTP by default Enable the Local NTP and sub-features by default. Bug: 775965, 583289 Change-Id: I0e1a601cb1994d4055a29dfeadcfcc920a6b9b0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559698 Auto-Submit: Kyle Milka <kmilka@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Ramya Nagarajan <ramyan@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#649497} chrome/browser/search/ntp_features.cc | 8 ++++---- .../signin/process_dice_header_delegate_impl.cc | 4 ++-- .../process_dice_header_delegate_impl_unittest.cc | 6 +++--- .../ui/browser_instant_controller_unittest.cc | 2 -- testing/variations/fieldtrial_testing_config.json | 21 --------------------- 5 files changed, 9 insertions(+), 32 deletions(-) commit 4f03867c2e394cd0b8d5d45fe78b0f7d227f290a Author: David Roger <droger@chromium.org> Date: Wed Apr 10 14:41:16 2019 +0000 [signin][android] Skeleton for ConsistencyCookieManagerAndroid The ConsistencyCookieManagerAndroid is responsible for updating the CHROME_ID_CONSISTENCY_STATE cookie, which reflects the state of identity consistency. Bug: 948140 Change-Id: Id3fd206393b5887478903857ac88a7adea3253a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559080 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#649496} components/signin/core/browser/BUILD.gn | 2 + .../signin/core/browser/account_reconcilor.cc | 16 +++++++ .../signin/core/browser/account_reconcilor.h | 9 ++++ .../browser/consistency_cookie_manager_android.cc | 37 ++++++++++++++++ .../browser/consistency_cookie_manager_android.h | 50 ++++++++++++++++++++++ 5 files changed, 114 insertions(+) commit 201659fa5e0ffe59b0c59d2d7e0b3abe8c04c379 Author: Steven Bennetts <stevenjb@chromium.org> Date: Wed Apr 10 14:35:15 2019 +0000 Extract chromeos/dbus/hammerd/BUILD.gn Bug: 938717 Change-Id: Idb137762037d8e0d83cb724c1d9bc2c00de554cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560462 Reviewed-by: Toni Baržić <tbarzic@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#649495} ash/BUILD.gn | 2 ++ chrome/browser/chromeos/dbus/dbus_helper.cc | 1 - chromeos/dbus/BUILD.gn | 4 ---- chromeos/dbus/hammerd/BUILD.gn | 21 +++++++++++++++++++++ chromeos/dbus/hammerd/fake_hammerd_client.h | 2 +- chromeos/dbus/hammerd/hammerd_client.h | 7 +++++-- 6 files changed, 29 insertions(+), 8 deletions(-) commit 7915435b3e91273153e2436e0a1b8ac4704a43be Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 10 14:18:34 2019 +0000 Roll src/third_party/perfetto 7efdd578d3e9..0d930129cf19 (1 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/7efdd578d3e9..0d930129cf19 git log 7efdd578d3e9..0d930129cf19 --date=short --no-merges --format='%ad %ae %s' 2019-04-10 fmayer@google.com Merge "Allow to disconnect device for heap profile script." Created with: gclient setdep -r src/third_party/perfetto@0d930129cf19 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I834ef57b49f5fffca94fcfa271275a11e6a1cd82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560666 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649494} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 311aefe272250bbc70c9d864497c13b8f73ed83c Author: Alexander Hendrich <hendrich@chromium.org> Date: Wed Apr 10 14:14:26 2019 +0000 Fix typos in ExtensionInstallListsMergeEnabled Typos spotted during proto sync with server-side. Bug: none Change-Id: If6d02291f5b44b0c9bb1754a770b319ba37239b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559954 Auto-Submit: Alexander Hendrich <hendrich@chromium.org> Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#649493} components/policy/resources/policy_templates.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 621627ec30fc18f00d535dd37461efb1499e489a Author: Clemens Arbesser <arbesser@google.com> Date: Wed Apr 10 14:12:22 2019 +0000 [Autofill Assistant] Added missing plumbing for ask_for_payment. This will show/hide the payment method section from the PR depending on the ask_for_payment flag in the proto. Bug: b/130192692 Change-Id: I2feb77a6026321354166c7ff461279c0c06fe109 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561133 Reviewed-by: Jordan Demeulenaere <jdemeulenaere@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#649492} .../AssistantPaymentRequestCoordinator.java | 2 +- .../payment/AssistantPaymentRequestModel.java | 10 +++---- .../payment/AssistantPaymentRequestOptions.java | 6 +++-- .../payment/AssistantPaymentRequestUI.java | 31 +++++++++++----------- .../autofill_assistant/ui_controller_android.cc | 5 ++-- .../actions/get_payment_information_action.cc | 3 +++ .../autofill_assistant/browser/payment_request.h | 1 + 7 files changed, 33 insertions(+), 25 deletions(-) commit 8a7168eec4ad1815c7d3d73bb2520244abc3338d Author: Roman Aleksandrov <raleksandrov@google.com> Date: Wed Apr 10 14:12:11 2019 +0000 Show notification after Managed Guest Session auto launch Apply UI review requests: Update messages, add button and change icon. Bug: 927331 Change-Id: Ia7a408f905e6c9ecfcc5ce961a2dc958b79aa6ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1494654 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Commit-Queue: Thiemo Nagel <tnagel@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#649491} ash/public/cpp/vector_icons/BUILD.gn | 1 - .../auto_launch_managed_guest_session.icon | 40 ---------------------- .../message_center/message_center_controller.cc | 5 +-- chrome/app/chromeos_strings.grdp | 9 +++-- chrome/browser/chromeos/BUILD.gn | 1 + .../chromeos/login/existing_user_controller.cc | 14 ++++---- chrome/common/chrome_features.cc | 4 +-- 7 files changed, 19 insertions(+), 55 deletions(-) commit 05e3785f1baa00f8e6e4207e86dae25a5ca913db Author: Oskar Sundbom <ossu@chromium.org> Date: Wed Apr 10 14:08:28 2019 +0000 Audio Process: Initialize COM to use MTA on the main thread With audio running in the browser, the audio thread was initialized to use COM's Multi-Threaded Apartment. When running in a separate utility process, the main thread is used as the audio thread and it was not initialized to MTA. Bug: 951341 Change-Id: I3ccfa9ae6623cafe6be0ab1c3848b050d8d0596d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561114 Reviewed-by: Olga Sharonova <olka@chromium.org> Commit-Queue: Oskar Sundbom <ossu@chromium.org> Cr-Commit-Position: refs/heads/master@{#649490} services/audio/owning_audio_manager_accessor.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit d21d3046aae335e4b3c0606b0f97b277d7280a25 Author: Bruno Santos <brunoad@chromium.org> Date: Wed Apr 10 13:53:36 2019 +0000 Add mojoPrivate permission and remove unused arcAppsPrivate. MojoJS is enabled for blessed extensions which require some specific permissions, such as mojoPrivate: https://cs.chromium.org/chromium/src/extensions/renderer/module_system.cc?rcl=a0003ab27ca48726cf817e4bc0a5a5cf8b1aa976&l=123 KioskNextHome was being granted this permission indirectly, but we should explicitly require it to be safe. Bug: 927809 Change-Id: Ifc18d5b9ce66ebe52b8e778359fa52f8fbb058db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559990 Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Bruno Santos <brunoad@chromium.org> Cr-Commit-Position: refs/heads/master@{#649489} chrome/browser/resources/chromeos/kiosk_next_home/manifest.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit f2b6033804d220f20378d980e31c458f0dd94ec5 Author: Maggie Chen <magchen@chromium.org> Date: Wed Apr 10 13:44:46 2019 +0000 Add crash dumps for underlay BGRA swap chain creation failures Bug:868561 Change-Id: I14ec794f144a3b5c2a209ba7122fb3162021256f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559884 Reviewed-by: Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#649488} gpu/ipc/service/direct_composition_surface_win.cc | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) commit ffc99edece0b71d8d7687d6067a61bab3bfd604c Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Wed Apr 10 13:41:46 2019 +0000 Roll src-internal 4db2cc60967c..69aca274e3a2 (16 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4db2cc60967c..69aca274e3a2 Created with: gclient setdep -r src-internal@69aca274e3a2 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=harrisjay@chromium.org,ellyjones@chromium.org,btolsch@chromium.org Change-Id: Ia10ae1c512fac75d4cc4a6e4c2ee3a9449bff7a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560663 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649487} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit f53ec5c5f02f0a737c3d20f9c1dee2d476b8548f Author: Morten Stenshorne <mstensho@chromium.org> Date: Wed Apr 10 13:41:00 2019 +0000 [LayoutNG] Sticky images quirk in table cells should yield to <wbr>. <wbr> provides a break opportunity. Don't let the sticky images quirk mess that up. Bug: 613663 Change-Id: Ica16a5b6458e69ccb7b0a401381c681f5dc57f86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549079 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#649486} .../core/layout/ng/inline/ng_line_breaker.cc | 28 ++++++++++++++++++---- .../enable-blink-features=LayoutNG | 1 - 2 files changed, 23 insertions(+), 6 deletions(-) commit 55e34b389e3b7be2b73d7f3b377fe11fcfe23baa Author: Gyuyoung Kim <gyuyoung@igalia.com> Date: Wed Apr 10 13:36:20 2019 +0000 BlinkMemoryMgt: Annotate Blink's renderer/platform with the macros of Allocator This CL finishes annotating the rest of the classes of //third_party/blink/renderer/platform with the macros of Allocator. After some analyzes, it was concluded that for the case of DOMWrapperWorld, SharedPersistent, BlobDataHandle, DefaultConnector, FontFallbackIterator, HbFontCacheEntry, DestructionNotifier, ScopedStateRestorer, GraphicsContext3DUtils, ImageDataBuffer, PaintPropertyNode, RasterInvalidator, PictureSnapshot, WebGraphicsContext3DProviderWrapper, and so on classes, they makes sense to use USING_FAST_MALLOC because it has been used as a member variable with new() or smart pointers. In VertexPair, ColorBehavior, PropertyTreeManager, PaintChunkSubset, TransformAndOrigin, IncrementalMarkingScopeBase, TraceableVariableController, and so on classes, they make sense to use DISALLOW_NEW because it has been used as a member variable with a reference type. Lastly, the rest of the classes this CL annotates make sense to use STACK_ALLOCATED. Bug: 919389 Change-Id: I089bf5d0379d77db0e78c77c72504d848d690253 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560914 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#649485} third_party/blink/renderer/platform/audio/vector_math_test.cc | 5 +++++ third_party/blink/renderer/platform/bindings/dom_wrapper_world.h | 3 +++ third_party/blink/renderer/platform/bindings/shared_persistent.h | 2 ++ third_party/blink/renderer/platform/blob/blob_data.h | 3 +++ third_party/blink/renderer/platform/exported/platform.cc | 3 +++ .../blink/renderer/platform/fonts/font_fallback_iterator.h | 3 +++ .../blink/renderer/platform/fonts/shaping/harfbuzz_font_cache.h | 2 ++ third_party/blink/renderer/platform/geometry/float_polygon.h | 2 ++ third_party/blink/renderer/platform/graphics/color_behavior.h | 3 +++ .../platform/graphics/compositing/property_tree_manager.h | 2 ++ .../renderer/platform/graphics/contiguous_container_test.cc | 2 ++ .../blink/renderer/platform/graphics/gpu/drawing_buffer.h | 5 +++++ .../renderer/platform/graphics/gpu/graphics_context_3d_utils.h | 3 +++ third_party/blink/renderer/platform/graphics/image_data_buffer.h | 3 +++ .../blink/renderer/platform/graphics/paint/paint_chunk_subset.h | 3 +++ .../blink/renderer/platform/graphics/paint/paint_property_node.h | 3 +++ .../blink/renderer/platform/graphics/paint/raster_invalidator.h | 3 +++ .../platform/graphics/paint/transform_paint_property_node.h | 3 +++ third_party/blink/renderer/platform/graphics/picture_snapshot.h | 3 +++ .../renderer/platform/graphics/scoped_interpolation_quality.h | 3 +++ .../renderer/platform/graphics/squashing_disallowed_reasons.h | 2 ++ .../platform/graphics/web_graphics_context_3d_provider_wrapper.h | 3 +++ third_party/blink/renderer/platform/heap/heap_thread_test.cc | 3 +++ .../blink/renderer/platform/heap/incremental_marking_test.cc | 4 +++- .../blink/renderer/platform/heap/object_start_bitmap_test.cc | 3 +++ third_party/blink/renderer/platform/heap/persistent_node.h | 4 ++++ third_party/blink/renderer/platform/histogram.h | 9 +++++++++ .../blink/renderer/platform/mac/local_current_graphics_context.h | 3 +++ third_party/blink/renderer/platform/mojo/interface_invalidator.h | 3 +++ .../platform/network/content_security_policy_response_headers.h | 2 ++ .../blink/renderer/platform/scheduler/common/metrics_helper.h | 3 +++ .../platform/scheduler/common/pollable_thread_safe_flag.h | 3 +++ .../platform/scheduler/common/post_cancellable_task_unittest.cc | 3 +++ .../blink/renderer/platform/scheduler/common/tracing_helper.h | 5 +++++ .../platform/scheduler/public/aggregated_metric_reporter.h | 3 +++ .../platform/scheduler/public/frame_or_worker_scheduler.h | 4 ++++ .../renderer/platform/scheduler/public/pending_user_input_type.h | 4 ++++ third_party/blink/renderer/platform/shared_buffer.cc | 3 +++ .../renderer/platform/speech/platform_speech_synthesis_voice.h | 3 +++ .../blink/renderer/platform/testing/shape_result_perf_test.cc | 3 +++ third_party/blink/renderer/platform/testing/unit_test_helpers.h | 3 +++ .../blink/renderer/platform/testing/viewport_layers_setup.h | 3 +++ third_party/blink/renderer/platform/text/bidi_resolver_test.cc | 3 +++ third_party/blink/renderer/platform/wtf/conditional_destructor.h | 4 ++++ third_party/blink/renderer/platform/wtf/doubly_linked_list.h | 2 ++ .../renderer/platform/wtf/text/integer_to_string_conversion.h | 3 +++ third_party/blink/renderer/platform/wtf/text/string_builder.h | 2 ++ third_party/blink/renderer/platform/wtf/text/string_impl.h | 1 + .../blink/renderer/platform/wtf/thread_restriction_verifier.h | 3 +++ .../blink/renderer/platform/wtf/typed_arrays/array_buffer_view.h | 3 +++ 50 files changed, 155 insertions(+), 1 deletion(-) commit cd3feaf794bcf29087cb878918dcd94d7ef0157c Author: Roman Aleksandrov <raleksandrov@google.com> Date: Wed Apr 10 13:34:20 2019 +0000 Management WebUI: Local trust roots section Place the section between overview and device section. Hide the section if there are no installed certifcates. Delete unused string. Bug: 879146 Change-Id: I945d436a3ff2e9aaf53867faba27ec456ef62c96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554768 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Thiemo Nagel <tnagel@chromium.org> Cr-Commit-Position: refs/heads/master@{#649484} .../browser/resources/management/management_ui.html | 14 ++++++-------- chrome/browser/resources/management/management_ui.js | 6 +++--- chrome/browser/ui/webui/management_ui.cc | 13 ++----------- components/management_strings.grdp | 20 +++++++------------- 4 files changed, 18 insertions(+), 35 deletions(-) commit 30ef6a10bf02e532f7f9dad0b9c2b5dd02ed1fe7 Author: Joshua Pawlicki <waffles@chromium.org> Date: Wed Apr 10 13:34:00 2019 +0000 Reland "Refactor update_client deps." This is a reland of 46935a5d3a85362f574f967780348f4c5c8dad57 Original change's description: > Refactor update_client deps. > > This reduces the build artifacts necessary to build chrome/updater from > 5k to 1.7k. > > Change-Id: I7332c69a5f564a08786d7e21e5891448feca8f11 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557988 > Commit-Queue: Joshua Pawlicki <waffles@chromium.org> > Reviewed-by: Sorin Jianu <sorin@chromium.org> > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Auto-Submit: Joshua Pawlicki <waffles@chromium.org> > Cr-Commit-Position: refs/heads/master@{#649098} Change-Id: I6c50876963ceea92eb1ea05488797c6a06efbb12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559874 Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#649483} chrome/browser/BUILD.gn | 3 +- chrome/browser/extensions/BUILD.gn | 3 +- chrome/updater/configurator.cc | 1 - components/update_client/BUILD.gn | 39 +++++++--------------- components/update_client/DEPS | 1 - components/update_client/url_fetcher_downloader.cc | 1 - components/update_client/utils.cc | 1 - ios/chrome/browser/component_updater/BUILD.gn | 3 +- 8 files changed, 15 insertions(+), 37 deletions(-) commit 58d12e3a1de5b882efab9b96270faa45628c4e51 Author: Hirokazu Honda <hiroh@chromium.org> Date: Wed Apr 10 13:25:07 2019 +0000 media/gpu/test: Image: Add a function to create VideoFrame from Image ImageProcessorClient currently creates VideoFrame from Image. The part seems common. It thus will be useful we have a function to create VideoFrame from Image. Bug: None Test: image_processor_test Change-Id: Ib725a6317ab70d80b15fae723b982d2a71017b2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557659 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by: David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#649482} media/gpu/BUILD.gn | 1 + media/gpu/image_processor_test.cc | 12 ++-- media/gpu/test/BUILD.gn | 15 +++-- .../test/image_processor/image_processor_client.cc | 40 ++------------ media/gpu/test/video_frame_helpers.cc | 64 +++++++++++++++++++--- media/gpu/test/video_frame_helpers.h | 15 ++++- 6 files changed, 93 insertions(+), 54 deletions(-) commit f1e0aec321c463495001f9762740a56bcf01fc9f Author: Nektarios Paisios <nektar@chromium.org> Date: Wed Apr 10 13:20:42 2019 +0000 Ensures that Document is not null before trying to retrieve the focused AXObject TBR=dmazzoni@chromium.org, aleventhal@chromium.org Bug: 949021 Change-Id: Ia256605aabc0df9c97396bbefb83c759510a9be3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560253 Reviewed-by: Nektarios Paisios <nektar@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#649481} third_party/blink/renderer/modules/exported/web_ax_object.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit af33dd912dd40e6e256b2e809db09bfe1bba1552 Author: Clemens Arbesser <arbesser@google.com> Date: Wed Apr 10 13:19:57 2019 +0000 [Autofill Assistant] Fix for hard crash in OnQuerySelectorAll. This was recently introduced in http://crrev/c/1554764. Bug: 806868 Change-Id: Ieaaac9b055328ec3b633ed3e55b22c5e846f3dd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561116 Auto-Submit: Clemens Arbesser <arbesser@google.com> Reviewed-by: Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#649480} components/autofill_assistant/browser/web_controller.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 30aaa6e76fc2cdd55aad5754c8026e6f0dfd5b55 Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Wed Apr 10 13:19:37 2019 +0000 Update V8 to version 7.5.234. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/076616f4..583668a3 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I51561589e3fcc923ef117343d860f94150c6e8b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560901 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649479} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 14bfb110610e079c2778652ff9f55c8f380f0786 Author: Miguel Casas <mcasas@chromium.org> Date: Wed Apr 10 13:16:47 2019 +0000 CrOs: Remove kUseMonitorColorSpace flag This CL removes the kUseMonitorColorSpace flag since the associated feature is launched and the same effect (as disabling it) can be achieved using chrome://flags/#force-color-profile. Bug: 897809, 771345 Change-Id: Ifa9ae84284147dcee904b94bc6320c59a3cee6f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559386 Auto-Submit: Miguel Casas <mcasas@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#649478} chrome/browser/about_flags.cc | 6 ------ chrome/browser/flag-metadata.json | 5 ----- chrome/browser/flag_descriptions.cc | 6 ------ ui/display/display_features.cc | 8 -------- ui/display/manager/display_manager.cc | 6 ------ 5 files changed, 31 deletions(-) commit 46a967284e2486d78c85ddd4fa9e68bf7a187414 Author: Harald Alvestrand <hta@chromium.org> Date: Wed Apr 10 13:06:31 2019 +0000 Add WPT test for sending over-long messages. Bug: chromium:943975 Change-Id: I4c3f1d99b55897deef37cbf516bb1b51291622bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559188 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#649477} .../wpt/webrtc/RTCDataChannel-send-expected.txt | 1 + .../external/wpt/webrtc/RTCDataChannel-send.html | 19 ++++++++++++++++++- .../wpt/webrtc/RTCDataChannel-send-expected.txt | 14 ++++++++++++++ 3 files changed, 33 insertions(+), 1 deletion(-) commit 26467397bc7f605342ec800403ec99c9e325e536 Author: Marc Treib <treib@chromium.org> Date: Wed Apr 10 13:02:41 2019 +0000 components/sync/BUILD.gn: Pull sync/js out into a separate target Bug: 947443 Change-Id: I19803d6bb56d301e9db8ce9821c38b984edf92df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561093 Reviewed-by: Jan Krcal <jkrcal@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#649476} components/sync/BUILD.gn | 24 +++++++++++++++++------- 1 file changed, 17 insertions(+), 7 deletions(-) commit 89df5e46f5754c6d0d871c3d9f34f3e72543e7c4 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 10 13:00:16 2019 +0000 Roll src/third_party/angle f39b4f0280ef..a131a1515471 (1 commits) https://chromium.googlesource.com/angle/angle.git/+log/f39b4f0280ef..a131a1515471 git log f39b4f0280ef..a131a1515471 --date=short --no-merges --format='%ad %ae %s' 2019-04-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src d90aae9a5a6c..82ebbbba15c2 (2 commits) Created with: gclient setdep -r src/third_party/angle@a131a1515471 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I87e83fbdcc7051357c2f04f19f0ffcb84669e3e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560895 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649475} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit f8db8f66c3fd675511e1f05bf0494c688d1fb76c Author: Sebastian Jansson <srte@chromium.org> Date: Wed Apr 10 12:53:46 2019 +0000 Using sequence checkers in RTCVideoDecoderAdapter. This prepares for using a decoder task queue rather than a decoder thread in webrtc. Bug: webrtc:10365 Change-Id: Ie37b63e0a7feb4206b6234a5a8afa083c12bbccc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559951 Auto-Submit: Sebastian Jansson <srte@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#649474} content/renderer/media/webrtc/rtc_video_decoder_adapter.cc | 12 ++++++------ content/renderer/media/webrtc/rtc_video_decoder_adapter.h | 6 +++--- 2 files changed, 9 insertions(+), 9 deletions(-) commit 1ebf07c718f9962c8bb485795c79623c3ee71aeb Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 10 12:40:56 2019 +0000 Roll Fuchsia SDK from 891660307559 to 891657183417 The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I5a7c02bd33ef14d7e4af950b92f7e6356ceeb7ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560664 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649473} build/fuchsia/linux.sdk.sha1 | 2 +- build/fuchsia/mac.sdk.sha1 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit cbafbf78d1c9504ab34dfd6a0f252eed29dbdee5 Author: Marc Treib <treib@chromium.org> Date: Wed Apr 10 12:40:23 2019 +0000 components/sync/BUILD.gn: Pull sync/base out into a separate target This is a first step in breaking up the monolithic "sync" target. Bug: 947443 Change-Id: I6ae8c8374e5977d701d9e7b14c372b48bd48e9ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561090 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by: Jan Krcal <jkrcal@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#649472} components/sync/BUILD.gn | 48 +++++++++++++++++++++++++++++++----------------- 1 file changed, 31 insertions(+), 17 deletions(-) commit 601c1f75f318a9753d0021639a8df9b2a32a0f02 Author: Cathie Chen <cathiechen@igalia.com> Date: Wed Apr 10 12:37:41 2019 +0000 Make list-and-block-textarea-001.html testing line-break only. The purpose of list-and-block-textarea-001.html is to test line-break between list marker and content. Separate the line-height issue to another test case. Bug: 919818 Change-Id: I5206e1d057925d42849d18453777d33c00bfe999 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1404908 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#649471} .../FlagExpectations/enable-blink-features=LayoutNG | 1 - .../wpt/css/css-lists/list-and-block-textarea-001.html | 15 ++++++++------- 2 files changed, 8 insertions(+), 8 deletions(-) commit 95d2e03d547ca3132782bb4f4d06ef944ac62fc1 Author: Jan Krcal <jkrcal@chromium.org> Date: Wed Apr 10 12:33:43 2019 +0000 Revert "[Sync] Add fieldtrial testing config for SyncUSSAutofillProfile" This reverts commit 67d55968aa899e5756fa182c1bee62a096effc3f. Reason for revert: failures in the build cycle Original change's description: > [Sync] Add fieldtrial testing config for SyncUSSAutofillProfile > > This CL prepares the feature for a Beta experiment. > > The CL also adapts android java AutofillProfile tests to USS. > Concretely, it makes FakeServer provide client tag hashes that are > consistent with the data being served (which is asserted by USS). > > Lastly, this CL also updates parameter names in FakeServerHelper to > avoid confusion when deleting faked entities. > > Bug: 836718 > Change-Id: I788553f9b58396f79fb75f1152e887c12e8167e6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538416 > Commit-Queue: Jan Krcal <jkrcal@chromium.org> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Reviewed-by: Jesse Doherty <jwd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#649443} TBR=jwd@chromium.org,jkrcal@chromium.org,mastiz@chromium.org Change-Id: Iaef8136a76d82316e514fe5d773e0bedc61eae70 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 836718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561118 Reviewed-by: Jan Krcal <jkrcal@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#649470} testing/variations/fieldtrial_testing_config.json | 20 -------------------- 1 file changed, 20 deletions(-) commit 0240dd9d0b52e3f9537ea9da3511438fd791706c Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 10 12:22:46 2019 +0000 Roll src/third_party/webrtc f4770401dc29..d93a00408699 (4 commits) https://webrtc.googlesource.com/src.git/+log/f4770401dc29..d93a00408699 git log f4770401dc29..d93a00408699 --date=short --no-merges --format='%ad %ae %s' 2019-04-10 srte@webrtc.org Adds AddSamples function to SamplesStatsCounter. 2019-04-10 kthelgason@webrtc.org Reland "Remove old audio device implementation." 2019-04-10 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 819d50e7b3..23e694012f (649313:649414) 2019-04-09 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 56b0d36f99..819d50e7b3 (649210:649313) Created with: gclient setdep -r src/third_party/webrtc@d93a00408699 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I45453dc935cd6964b96e8178cf08dd6cdbd40adf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561012 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649469} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 68309bbd86213b7b5710ebac11b495bdb44a42dd Author: jdoerrie <jdoerrie@chromium.org> Date: Wed Apr 10 12:08:26 2019 +0000 [Autofill] Clean Up PasswordFormFillData This change cleans up PasswordFormFillData by making InitPasswordFormFillData() a constructor instead, simplifying parts of its implementation and providing default values to POD members that missed them. Bug: 875768 Change-Id: I4dbf620c13cc852b0ba4e2f0244c1c3f71174ec9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559189 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#649468} .../core/common/password_form_fill_data.cc | 60 +++++++++++----------- .../autofill/core/common/password_form_fill_data.h | 43 ++++++++-------- .../common/password_form_fill_data_unittest.cc | 53 ++++++------------- .../content_password_manager_driver_unittest.cc | 5 +- .../core/browser/password_form_filling.cc | 11 ++-- .../password_manager/ios/password_form_helper.mm | 10 ++-- 6 files changed, 77 insertions(+), 105 deletions(-) commit 399867797f9be3e76226dabeaa9545f18041d403 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 10 11:43:36 2019 +0000 Roll src/third_party/perfetto 9bbf1af0d9fe..7efdd578d3e9 (1 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/9bbf1af0d9fe..7efdd578d3e9 git log 9bbf1af0d9fe..7efdd578d3e9 --date=short --no-merges --format='%ad %ae %s' 2019-04-10 lalitm@google.com Merge "trace_processor: cleanup trace processor shell and API further" Created with: gclient setdep -r src/third_party/perfetto@7efdd578d3e9 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I27cff6b719a80b761674c06fec4b76264d874b4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561011 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649467} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 50a82c094a9920df383e6f9e39a4fe7915008438 Author: Boris Sazonov <bsazonov@chromium.org> Date: Wed Apr 10 11:40:47 2019 +0000 [Android] Disable NotificationPlatformBridgeIntentTest#testLaunchProcessForNotificationActivation Disable the test as it is flaky. Failed build: https://ci.chromium.org/p/chromium/builders/ci/Lollipop%20Tablet%20Tester/13387. TBR=peter@chromium.org Bug: 950635 Change-Id: I870ea83832db8bdfe199d91c5aac4e6132839785 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561130 Reviewed-by: Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#649466} .../browser/notifications/NotificationPlatformBridgeIntentTest.java | 2 ++ 1 file changed, 2 insertions(+) commit f654021d22136ed1b82adc05ce471709ad8f3c74 Author: Hirokazu Honda <hiroh@chromium.org> Date: Wed Apr 10 11:21:55 2019 +0000 media/gpu/linux: Remove vaapi_dmabuf_video_frame_mapper.cc I wrongly duplicated vaapi_dmabuf_video_frame_mapper.cc in crrev.com/c/1538102. vaapi_dmabuf_video_frame_mapper.cc in media/gpu/linux is totally redundant. TBR=dstaessens@chromium.org Bug: None Test: None Change-Id: I6b9c17a44e082a034e1a415e5c24fcbdd865e223 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559422 Reviewed-by: Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#649465} media/gpu/linux/vaapi_dmabuf_video_frame_mapper.cc | 155 --------------------- 1 file changed, 155 deletions(-) commit 173217e7a69032ce202db6f340e247c83551694c Author: Stephen McGruer <smcgruer@chromium.org> Date: Wed Apr 10 11:20:19 2019 +0000 Revert "Ship the Animation constructor" This reverts commit c6d3f910632a539f6b044d056a279412c6000f37. Reason for revert: Reason for revert: I missed a DCHECK for WebAnimationsAPIEnabled() in the Animation constructor, so it crashes on stable -_- Original change's description: > Ship the Animation constructor > > Intent to ship with 3x LGTM: > https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer#!msg/blink-dev/UMxgGkxhdCo/CHZ2H9DsBgAJ > > Bug: 948657 > Change-Id: I9c9ac4969f5708c310c9a8a95120fd5a0d3cdc87 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553448 > Reviewed-by: Kent Tamura <tkent@chromium.org> > Reviewed-by: Majid Valipour <majidvp@chromium.org> > Commit-Queue: Stephen McGruer <smcgruer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#649066} TBR=tkent@chromium.org,majidvp@chromium.org,smcgruer@chromium.org Change-Id: If2871222cb72c5182118ff7a396762c004e249d0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 948657 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560904 Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#649464} .../blink/renderer/core/animation/animation.idl | 2 +- .../global-interface-listing-expected.txt | 21 --------------------- .../webexposed/web-animations-api-expected.txt | 2 ++ .../webexposed/web-animations-api-expected.txt | 2 ++ .../web_tests/webexposed/web-animations-api.html | 4 ++++ 5 files changed, 9 insertions(+), 22 deletions(-) commit 596b8abac78234651fd679f9f9279af0d878d39e Author: Clemens Arbesser <arbesser@google.com> Date: Wed Apr 10 11:07:27 2019 +0000 [Autofill Assistant] Fix for hard crash when cancelling the onboarding. This was introduced in http://crrev/c/1552835, which was not cherry-picked for M-74. Bug: 806868 Change-Id: Ia94175846f8445f7d351e5c2d10f47b754403194 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561091 Auto-Submit: Clemens Arbesser <arbesser@google.com> Reviewed-by: Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#649463} components/autofill_assistant/browser/controller.cc | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) commit 04efbc7b3ddfe31aff96ac48db27f0227ae7f3a1 Author: Alan Cutter <alancutter@chromium.org> Date: Wed Apr 10 11:05:16 2019 +0000 Record PWA installation from the omnibox icon Bug: 907351 Change-Id: I6560402bd1dfdbb0a0a1f8296a3b40225cdcf56b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553131 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by: Alexey Baskakov <loyso@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#649462} chrome/browser/installable/installable_metrics.cc | 3 ++- chrome/browser/installable/installable_metrics.h | 3 +++ chrome/browser/ui/views/page_action/pwa_install_view.cc | 8 +++++++- chrome/browser/ui/web_applications/web_app_dialog_utils.h | 4 +++- tools/metrics/histograms/enums.xml | 1 + 5 files changed, 16 insertions(+), 3 deletions(-) commit 84dc82b845d202c41e75c582b920a019a72f21e7 Author: Polina Bondarenko <pbond@google.com> Date: Wed Apr 10 10:55:46 2019 +0000 diagnostics: wire up DeviceWilcoDtcConfiguration blob Wire up DeviceWilcoDtcConfiguration blob: device policy -- DiagnosticsdManager -- DiagnosticsdBridge -- mojo Diagnosticsd -- wilco_dtc_supportd The data blob is stored in DiagnosticsdManager. BUG=b:123933434 TEST=unit_tests Change-Id: I88c920ccdefe26f179b37da677fa45339de1b951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545913 Reviewed-by: Maksim Ivanov <emaxx@chromium.org> Reviewed-by: Greg Kerr <kerrnel@chromium.org> Commit-Queue: Polina Bondarenko <pbond@chromium.org> Auto-Submit: Polina Bondarenko <pbond@chromium.org> Cr-Commit-Position: refs/heads/master@{#649461} chrome/browser/chromeos/BUILD.gn | 4 +- .../chromeos/diagnosticsd/diagnosticsd_bridge.cc | 14 ++ .../chromeos/diagnosticsd/diagnosticsd_bridge.h | 12 ++ .../diagnosticsd/diagnosticsd_bridge_unittest.cc | 1 + .../chromeos/diagnosticsd/diagnosticsd_manager.cc | 79 +++++++++- .../chromeos/diagnosticsd/diagnosticsd_manager.h | 25 +++ .../diagnosticsd/diagnosticsd_manager_unittest.cc | 168 ++++++++++++++++----- .../diagnosticsd_messaging_unittest.cc | 23 +-- ...e.cc => testing_diagnosticsd_bridge_wrapper.cc} | 54 ++++--- ...dge.h => testing_diagnosticsd_bridge_wrapper.h} | 32 ++-- .../device_wilco_dtc_configuration_handler.cc | 16 +- .../diagnosticsd/public/mojom/diagnosticsd.mojom | 15 ++ 12 files changed, 353 insertions(+), 90 deletions(-) commit 603bfc775a93bac63dfbb27c20ee006662e5aea3 Author: Guido Urdaneta <guidou@chromium.org> Date: Wed Apr 10 10:53:20 2019 +0000 Revert "Reland "[TaskScheduler]: Simplify sequence preemption logic."" This reverts commit 328f55781b6911025c18a6a1bf2ca640906eba9e. Reason for revert: Suspect of making ios-simulator trybot fail, preventing several rolls such as WebRTC and Angle. The test that fails fairly consistently is: GenericParallel/TaskSchedulerWorkerPoolTest.CanRunPolicyLoad/0 Example failure: [03:18:30:INFO] [ RUN ] GenericParallel/TaskSchedulerWorkerPoolTest.CanRunPolicyLoad/0 [03:18:30:INFO] [41263:107219:0410/031830.728022:11325966320328:FATAL:scheduler_worker_pool_impl.cc(661)] Check failed: outer_->GetNumAwakeWorkersLockRequired() <= outer_->GetDesiredNumAwakeWorkersLockRequired() (3 vs. 0) [03:18:30:INFO] 0 base_unittests 0x000000010c17ae41 base::debug::CollectStackTrace(void**, unsigned long) + 33 [03:18:30:INFO] 1 base_unittests 0x000000010bf2275d base::debug::StackTrace::StackTrace(unsigned long) + 61 [03:18:30:INFO] 2 base_unittests 0x000000010bf227bd base::debug::StackTrace::StackTrace(unsigned long) + 29 [03:18:30:INFO] 3 base_unittests 0x000000010bf22798 base::debug::StackTrace::StackTrace() + 40 [03:18:30:INFO] 4 base_unittests 0x000000010bf5f283 logging::LogMessage::~LogMessage() + 131 [03:18:30:INFO] 5 base_unittests 0x000000010bf5e1d5 logging::LogMessage::~LogMessage() + 21 [03:18:30:INFO] 6 base_unittests 0x000000010c0b09a1 base::internal::SchedulerWorkerPoolImpl::SchedulerWorkerDelegateImpl::GetWork(base::internal::SchedulerWorker*) + 1809 [03:18:30:INFO] 7 base_unittests 0x000000010c0ab469 base::internal::SchedulerWorker::RunWorker() + 985 [03:18:30:INFO] 8 base_unittests 0x000000010c0ab01c base::internal::SchedulerWorker::RunPooledWorker() + 28 [03:18:30:INFO] 9 base_unittests 0x000000010c0aaf29 base::internal::SchedulerWorker::ThreadMain() + 265 [03:18:30:INFO] 10 base_unittests 0x000000010c19af8a base::(anonymous namespace)::ThreadFunc(void*) + 170 [03:18:30:INFO] 11 libsystem_pthread.dylib 0x0000000116bc0661 _pthread_body + 340 [03:18:30:INFO] 12 libsystem_pthread.dylib 0x0000000116bc050d _pthread_body + 0 [03:18:30:INFO] 13 libsystem_pthread.dylib 0x0000000116bbfbf9 thread_start + 13 First WebRTC roll failure: https://chromium-review.googlesource.com/c/chromium/src/+/1560893 Other failures: https://chromium-review.googlesource.com/c/chromium/src/+/1561013/2 https://chromium-review.googlesource.com/c/chromium/src/+/1560895 Original change's description: > Reland "[TaskScheduler]: Simplify sequence preemption logic." > > This is a reland of 5d4c05db6d02f9422b3a7b6fb2b6b637691ccc2e > > Problem: PlatformNativeWorkerPool::RunNextSequenceImpl expects sequence > returned from GetWork() to be non-null and DCHECK. > Solution: Handle null sequences by skipping RunAndPopNextTask. > > Original change's description: > > [TaskScheduler]: Simplify sequence preemption logic. > > > > This CL removes preempted sequences from TaskTracker, > > removing need for CanScheduleSequenceObserver and > > simplifying shutdown. > > A CanRunPolicy enum is used instead, specifying whether > > or not tasks at a given priority can run. > > When CanRunPolicy is updated, wakeup workers needs > > to be done as appropriate. > > > > In addition, Shutdown was split in 2 phases start + complete > > to allow caller (TaskScheduler) to update CanRunPolicy after > > shutdown was started. > > > > This CL was recycled from: > > https://chromium-review.googlesource.com/c/chromium/src/+/1478007 > > I took ownership because simplifying Sequence lifecycle > > will simplify implementation of job API. > > > > TBR=gab@chromium.org > > > > Bug: 889029 > > Change-Id: Ie5dbc226705880c5e598e013aa2dd3e7e874158b > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531161 > > Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org> > > Reviewed-by: François Doray <fdoray@chromium.org> > > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#648346} > > Bug: 889029, 950383 > Change-Id: I1f64517d312e65fb59ae235373b4f4d504da87dd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557861 > Commit-Queue: François Doray <fdoray@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#649399} TBR=gab@chromium.org,fdoray@chromium.org,etiennep@chromium.org Change-Id: I5155371d473c9e6eaa937d48183915dc974b93ee No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 889029, 950383 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560903 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#649460} base/BUILD.gn | 2 +- base/task/task_scheduler/can_run_policy_test.h | 189 --------- .../can_schedule_sequence_observer.h | 27 ++ .../task_scheduler/platform_native_worker_pool.cc | 43 +- .../task_scheduler/platform_native_worker_pool.h | 1 - .../scheduler_single_thread_task_runner_manager.cc | 171 +++----- .../scheduler_single_thread_task_runner_manager.h | 4 - ...r_single_thread_task_runner_manager_unittest.cc | 79 ++-- base/task/task_scheduler/scheduler_worker.cc | 3 +- base/task/task_scheduler/scheduler_worker.h | 10 +- base/task/task_scheduler/scheduler_worker_pool.cc | 38 +- base/task/task_scheduler/scheduler_worker_pool.h | 24 +- .../task_scheduler/scheduler_worker_pool_impl.cc | 53 +-- .../task_scheduler/scheduler_worker_pool_impl.h | 1 - .../scheduler_worker_pool_impl_unittest.cc | 69 +--- .../scheduler_worker_pool_unittest.cc | 58 +-- .../scheduler_worker_stack_unittest.cc | 3 + .../task_scheduler/scheduler_worker_unittest.cc | 19 +- base/task/task_scheduler/task_scheduler.cc | 4 +- base/task/task_scheduler/task_scheduler.h | 5 +- base/task/task_scheduler/task_scheduler_impl.cc | 58 +-- base/task/task_scheduler/task_scheduler_impl.h | 20 +- .../task_scheduler/task_scheduler_impl_unittest.cc | 69 ---- base/task/task_scheduler/task_tracker.cc | 317 ++++++++++++-- base/task/task_scheduler/task_tracker.h | 226 ++++++++-- .../task_scheduler/task_tracker_posix_unittest.cc | 8 +- base/task/task_scheduler/task_tracker_unittest.cc | 459 ++++++++++++++++++--- base/task/task_scheduler/test_utils.cc | 10 +- base/task/task_scheduler/test_utils.h | 6 +- base/test/task_scheduler_test_helpers_android.cc | 3 +- 30 files changed, 1094 insertions(+), 885 deletions(-) commit 3fd30426245645b5ce564a645fb2afe4e963b5a6 Author: Stephen McGruer <smcgruer@chromium.org> Date: Wed Apr 10 10:37:57 2019 +0000 Revert "Ship AnimationEffect and part of KeyframeEffect" This reverts commit 7dffea0baf77a4242634da40d3df8c567bcd51ec. Reason for revert: I missed a DCHECK for WebAnimationsAPIEnabled() in the KeyframeConstructor, so it crashes on stable -_- Bug: 951315 Original change's description: > Ship AnimationEffect and part of KeyframeEffect > > This ships AnimationEffect plus the KeyframeEffect interface and > 'target' member. It does not ship either getKeyframes/setKeyframes or > composite/iterationComposite. The former is not shipped because our > implementation has bugs that would cause web-compat problems > (crbug.com/816956), the latter is not shipped because the spec for it > has not yet settled. > > Intent to ship thread (with 3x LGTM): > https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer#!msg/blink-dev/1EQKF7il48U/BJWTPiqwBgAJ > > Bug: 948253 > Change-Id: I8c86220d28e1e81ee764fac7a11d95a685f17684 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553447 > Reviewed-by: Kent Tamura <tkent@chromium.org> > Reviewed-by: Jeremy Roman <jbroman@chromium.org> > Reviewed-by: Majid Valipour <majidvp@chromium.org> > Commit-Queue: Stephen McGruer <smcgruer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#649377} TBR=jbroman@chromium.org,tkent@chromium.org,majidvp@chromium.org,smcgruer@chromium.org Change-Id: Ie6013a3cc0be41b1c0368fdc70d576452a6b29fa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 948253 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560902 Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#649459} .../blink/public/mojom/web_feature/web_feature.mojom | 2 -- third_party/blink/renderer/core/animation/animation.idl | 4 ++-- .../blink/renderer/core/animation/animation_effect.idl | 5 +++-- .../blink/renderer/core/animation/keyframe_effect.idl | 12 ++++++------ .../interfaces/Animation/style-change-events-expected.txt | 4 ++-- .../stable/webexposed/global-interface-listing-expected.txt | 13 ------------- tools/metrics/histograms/enums.xml | 2 -- 7 files changed, 13 insertions(+), 29 deletions(-) commit 02a8332918a0bdbfb000b6712179b2672b4f7a74 Author: Chromium WPT Sync <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Date: Wed Apr 10 10:16:43 2019 +0000 Import wpt@54e83cba22ded535ead8a9c97fbcb0646edaa6a4 Using wpt-import in Chromium 67d55968aa899e5756fa182c1bee62a096effc3f. With Chromium commits locally applied on WPT: 0a8f3ffa48 "Use testdriver Action API in WPT pointerevent touch tests - Part 2" adc34f41f6 "Fix web_test pointerevent_coordinates_when_locked on wpt" 8659792f35 "[WPT] Move wrapResult to common.js and clarify requestVia*() return values" e525003f05 "Do not resume a suspended BaseAudioContext when AudioWorklet starts" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I66917fa3be9ac375c3942cc1b71df3d28ed1216b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560896 Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649458} third_party/blink/web_tests/external/WPT_BASE_MANIFEST_5.json | 4 ++-- .../blink/web_tests/external/wpt/content-security-policy/README.html | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) commit 55a3cd3bb4e57c26322c9475d1545555eec467ff Author: Sylvain Defresne <sdefresne@chromium.org> Date: Wed Apr 10 10:08:01 2019 +0000 Move wipeSyncUserDataIfRequired to SyncUserDataWiper In preparation of componentization of SigninManager.java, move wipeSyncUserDataIfRequired method to SyncUserDataWiper as the method is just a wrapper around wipeSyncUserData from the same class. Bug: 943612 Change-Id: Id158fb34bd0ace9cd15dfe278c280967a558f8a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530988 Reviewed-by: Boris Sazonov <bsazonov@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#649457} .../chromium/chrome/browser/signin/AccountSigninView.java | 3 ++- .../chrome/browser/signin/SigninFragmentBase.java | 3 ++- .../org/chromium/chrome/browser/signin/SigninManager.java | 13 ------------- .../chromium/chrome/browser/sync/SyncAccountSwitcher.java | 2 +- .../chromium/chrome/browser/sync/SyncUserDataWiper.java | 15 ++++++++++++++- 5 files changed, 19 insertions(+), 17 deletions(-) commit 743ff0eec552244c909970b1c089b04d9e10b28b Author: Jordan Demeulenaere <jdemeulenaere@google.com> Date: Wed Apr 10 09:53:38 2019 +0000 [Autofill Assistant] Use ChipView widget for assistive chips. Change-Id: I6805c00a84c2ff7ad812993b3ac547843469ede9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559178 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by: Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#649456} .../autofill_assistant_chip_assistive_bg.xml | 11 -------- ...autofill_assistant_chip_assistive_bg_normal.xml | 15 ----------- ...utofill_assistant_chip_assistive_bg_pressed.xml | 12 --------- .../layout/autofill_assistant_chip_assistive.xml | 15 ----------- .../carousel/AssistantChipViewHolder.java | 30 +++++++++++++++------- 5 files changed, 21 insertions(+), 62 deletions(-) commit 6d318cb622eafac0a59d6a05836c41eb50077be6 Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Wed Apr 10 09:50:08 2019 +0000 Update V8 to version 7.5.233. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b68b2c11..076616f4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I82de13bb6f460a779bffbbdd3472f54981f37ba3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560496 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649455} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 083c1b21e4275e7553a9259e0a66ce46117cfd84 Author: Shu Chen <shuchen@chromium.org> Date: Wed Apr 10 09:48:50 2019 +0000 Avoid duplicated text when CommitText. Bug: 951253 Change-Id: I500a03cd0c3690ebfca77f77e6a4e616681a46dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560877 Reviewed-by: Lan Wei <azurewei@chromium.org> Commit-Queue: Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#649454} chrome/browser/ui/input_method/input_method_engine.cc | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) commit b46b7b8820b689e718dda0a9fc9a7a494d47ee47 Author: Maksim Ivanov <emaxx@chromium.org> Date: Wed Apr 10 09:47:08 2019 +0000 diagnostics: Add pbond into OWNERS Also mark emaxx@ and pmarko@ as only backup OWNERS. BUG=none TEST=none Change-Id: I4518b46ad6036ab8163705ef833ef790af910b83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552818 Reviewed-by: Pavol Marko <pmarko@chromium.org> Reviewed-by: Polina Bondarenko <pbond@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#649453} chrome/browser/chromeos/diagnosticsd/OWNERS | 3 +++ chrome/services/diagnosticsd/OWNERS | 3 +++ 2 files changed, 6 insertions(+) commit 9eb57973e4f62261e8a904db9e73b8884267e9d4 Author: Kent Tamura <tkent@chromium.org> Date: Wed Apr 10 09:45:20 2019 +0000 Fix coding style of generated foo_element_factory.{h,cc} - Use 'using' instead of 'typedef' - Fix variable names; g_HTML_constructors -> g_html_constructors localName -> local_name - Use 'nullptr' instead of '0'. - Fix a function name; createHTMLFunctionMap -> CreateHTMLFunctionMap - Fix constructor function names e.g. HTMLkObjectConstrcutor -> HTMLObjectConstructor This CL has no behavior changes. Change-Id: If8046726467a94c1a30b964c7dfd466b832dfbbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559527 Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#649452} .../scripts/templates/element_factory.cc.tmpl | 32 ++++++++++------------ .../build/scripts/templates/element_factory.h.tmpl | 4 +-- 2 files changed, 17 insertions(+), 19 deletions(-) commit 20a9694b78979886adf9d485e7caf0ca33113d32 Author: Nikita Podguzov <nikitapodguzov@chromium.org> Date: Wed Apr 10 09:44:48 2019 +0000 Change printing restriction names and add ColorModeRestriction to JS code. Bug: 848942 Change-Id: I33bb34748c6087a65952cc934bc0dbe1c38b5e9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557022 Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#649451} .../resources/print_preview/data/destination.js | 30 +++++++++++++++------- .../browser/resources/print_preview/new/model.js | 3 ++- .../webui/print_preview/destination_search_test.js | 4 +-- .../print_preview/model_settings_policy_test.js | 18 ++++++------- printing/backend/printing_restrictions.cc | 6 ++--- printing/backend/printing_restrictions.h | 10 ++++---- 6 files changed, 42 insertions(+), 29 deletions(-) commit df09cb0da5d95293f685b40bcf0be1257c1bdb0e Author: Thomas Tangl <tangltom@chromium.org> Date: Wed Apr 10 09:32:32 2019 +0000 Add metric for 'Manage your Google Account' button in user menu Bug: 950534 Change-Id: Ia5ea6b16e633c371550cac515c645963b8235a13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559316 Reviewed-by: Brian White <bcwhite@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#649450} chrome/browser/ui/views/profiles/profile_chooser_view.cc | 2 ++ tools/metrics/actions/actions.xml | 9 +++++++++ 2 files changed, 11 insertions(+) commit f356df5d4deeb198f2502a6582340da7415009ea Author: Victor Hugo Vianna Silva <victorvianna@google.com> Date: Wed Apr 10 09:29:13 2019 +0000 [Sync] Avoid unnecessary copy in AddMetadata By changing the type of metadata_map_ to use an unique_ptr we can avoid unnecessary copy Bug: 914396 Change-Id: I713e048630b6075c300a7b4f09d7b5d5a047123a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1550830 Reviewed-by: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by: Jan Krcal <jkrcal@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Auto-Submit: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#649449} .../core/browser/webdata/autofill_table_unittest.cc | 4 ++-- .../autofill_wallet_metadata_sync_bridge_unittest.cc | 3 ++- .../typed_url_sync_metadata_database_unittest.cc | 4 ++-- .../core/browser/login_database_unittest.cc | 4 ++-- components/sync/model/metadata_batch.cc | 4 +--- components/sync/model/metadata_batch.h | 3 ++- .../client_tag_based_model_type_processor.cc | 5 ++++- .../model_impl/model_type_store_impl_unittest.cc | 2 +- components/sync/test/test_matchers.h | 20 ++++++++++++++++++-- components/sync_sessions/session_store.cc | 2 +- 10 files changed, 35 insertions(+), 16 deletions(-) commit d266ea62e9f1df0dffc3dc9e6051f0d381e4cb25 Author: Angelika Kurtz <akurtz@google.com> Date: Wed Apr 10 09:22:18 2019 +0000 Remove unsused Sync.ResponseContentLength..* histograms Bug: 900073 Change-Id: Ic7231ef565bf0400d1b3c63f7a0028d7a003ae94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559075 Commit-Queue: Angelika Kurtz <akurtz@google.com> Auto-Submit: Angelika Kurtz <akurtz@google.com> Reviewed-by: Brian White <bcwhite@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#649448} components/sync/engine/net/http_bridge.cc | 20 +++----------------- components/sync/engine/net/http_bridge.h | 1 - components/sync/engine/net/http_bridge_unittest.cc | 3 +-- tools/metrics/histograms/histograms.xml | 12 ++++++++++-- 4 files changed, 14 insertions(+), 22 deletions(-) commit 4d08d70c23940a1257c2449452b04365cbfaf662 Author: Jazz Xu <jazzhsu@chromium.org> Date: Wed Apr 10 09:19:30 2019 +0000 [Media Controls] Time display Implement time display in media controls for touchless device. Bug: 942153 Change-Id: I0579996f8f241b4ae48cd1d4088e08a300c6b9e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560383 Reviewed-by: Tommy Steimel <steimel@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#649447} .../blink/renderer/modules/media_controls/BUILD.gn | 2 + .../elements/media_control_time_display_element.cc | 26 +---------- .../media_controls/media_controls_shared_helper.cc | 28 ++++++++++++ .../media_controls/media_controls_shared_helper.h | 3 ++ ...edia_controls_touchless_time_display_element.cc | 49 +++++++++++++++++++++ ...media_controls_touchless_time_display_element.h | 37 ++++++++++++++++ .../touchless/media_controls_touchless_impl.cc | 11 ++++- .../media_controls_touchless_impl_test.cc | 18 ++++++++ .../touchless/resources/gradient_bg.png | Bin 0 -> 715 bytes .../touchless/resources/mediaControlsTouchless.css | 31 ++++++++++++- 10 files changed, 178 insertions(+), 27 deletions(-) commit 92e1f9af0e08a5caca9b1475e3a2c2b0e3738077 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 10 09:03:54 2019 +0000 Roll src/third_party/perfetto 7ed01b7a5be9..9bbf1af0d9fe (1 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/7ed01b7a5be9..9bbf1af0d9fe git log 7ed01b7a5be9..9bbf1af0d9fe --date=short --no-merges --format='%ad %ae %s' 2019-04-10 treehugger-gerrit@google.com Merge "Add the ability for the command line client to activate triggers." Created with: gclient setdep -r src/third_party/perfetto@9bbf1af0d9fe The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I4d0154f880e14bfd3fcc4cd359f3d501b7828db0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559466 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649446} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit cd76481fcd85a38cb235fc4451b4c08ff791dd43 Author: David Staessens <dstaessens@chromium.org> Date: Wed Apr 10 09:01:54 2019 +0000 media/gpu/test: Add parameter to overwrite default video test metadata file. When running the video decoder tests on a video file, it's assumed there is an accompanying metadata file in the same folder with the ".json" suffix. This CL allows overriding the default metadata location so it doesn't need to be present in the same folder. This CL also makes some of the loading failure error messages a bit more explicit. TEST=ran new VDA (perf) tests on nocturne BUG=879065 Change-Id: I6f7cc5db0b61d28ff8356d7eda6a473fc9950fab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552392 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#649445} media/gpu/test/video_player/video.cc | 70 ++++++++++++++-------- media/gpu/test/video_player/video.h | 13 +++- .../video_player/video_player_test_environment.cc | 4 +- .../video_player/video_player_test_environment.h | 8 ++- media/gpu/video_decode_accelerator_perf_tests.cc | 5 +- media/gpu/video_decode_accelerator_tests.cc | 23 ++++--- 6 files changed, 85 insertions(+), 38 deletions(-) commit f8ba16abb0740f8b61396c30071c5c39df3d8ef6 Author: Mohamed Amir Yosef <mamir@chromium.org> Date: Wed Apr 10 08:40:31 2019 +0000 [Sync] Make UpdateResponseData non-copyable This is in preparation for replacing EntityDataPtr with unique_ptr Bug: 924978 Change-Id: Id984fd29b1c73255706e564b630277892b3ade74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556789 Reviewed-by: Marc Treib <treib@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#649444} .../extensions/api/sessions/sessions_apitest.cc | 10 ++- .../ui/toolbar/recent_tabs_builder_test_helper.cc | 11 +-- .../ui/toolbar/recent_tabs_builder_test_helper.h | 2 +- .../webdata/autocomplete_sync_bridge_unittest.cc | 8 +- .../autofill_profile_sync_bridge_unittest.cc | 8 +- ...utofill_wallet_metadata_sync_bridge_unittest.cc | 12 +-- .../autofill_wallet_sync_bridge_unittest.cc | 8 +- .../sync/engine/fake_model_type_processor.cc | 2 +- components/sync/engine/fake_model_type_processor.h | 2 +- components/sync/engine/model_type_processor.h | 2 +- .../sync/engine/model_type_processor_proxy.cc | 8 +- .../sync/engine/model_type_processor_proxy.h | 2 +- components/sync/engine/non_blocking_sync_common.cc | 3 - components/sync/engine/non_blocking_sync_common.h | 6 +- components/sync/engine_impl/model_type_worker.cc | 57 +++++++------ components/sync/engine_impl/model_type_worker.h | 3 +- .../sync/engine_impl/model_type_worker_unittest.cc | 94 +++++++++++++-------- .../sync/engine_impl/uss_migrator_unittest.cc | 33 +++++--- .../client_tag_based_model_type_processor.cc | 55 ++++++------ .../client_tag_based_model_type_processor.h | 2 +- ...ient_tag_based_model_type_processor_unittest.cc | 37 ++++---- .../sync/model_impl/processor_entity_unittest.cc | 70 +++++++++------- .../sync/nigori/nigori_model_type_processor.cc | 2 +- .../sync/nigori/nigori_model_type_processor.h | 2 +- .../sync/test/engine/mock_model_type_processor.cc | 47 ++++++----- .../sync/test/engine/mock_model_type_processor.h | 15 ++-- .../sync/test/engine/mock_model_type_worker.cc | 51 +++++------ .../sync/test/engine/mock_model_type_worker.h | 13 +-- components/sync_bookmarks/bookmark_model_merger.cc | 22 +++-- .../bookmark_model_merger_unittest.cc | 16 ++-- .../bookmark_model_type_processor.cc | 2 +- .../sync_bookmarks/bookmark_model_type_processor.h | 2 +- .../bookmark_model_type_processor_unittest.cc | 41 +++++---- .../bookmark_remote_updates_handler.cc | 15 ++-- .../bookmark_remote_updates_handler_unittest.cc | 98 ++++++++++++---------- .../sync_sessions/session_sync_bridge_unittest.cc | 31 ++++--- 36 files changed, 437 insertions(+), 355 deletions(-) commit 67d55968aa899e5756fa182c1bee62a096effc3f Author: Jan Krcal <jkrcal@chromium.org> Date: Wed Apr 10 08:23:39 2019 +0000 [Sync] Add fieldtrial testing config for SyncUSSAutofillProfile This CL prepares the feature for a Beta experiment. The CL also adapts android java AutofillProfile tests to USS. Concretely, it makes FakeServer provide client tag hashes that are consistent with the data being served (which is asserted by USS). Lastly, this CL also updates parameter names in FakeServerHelper to avoid confusion when deleting faked entities. Bug: 836718 Change-Id: I788553f9b58396f79fb75f1152e887c12e8167e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538416 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Reviewed-by: Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#649443} testing/variations/fieldtrial_testing_config.json | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) commit bf7c5e9ffaea86a48cd7e23df506e777b370ebbb Author: Alex Danilo <adanilo@chromium.org> Date: Wed Apr 10 08:08:04 2019 +0000 Removed variable alias when file sniffing The MIME sniffer added a special case in https://codereview.chromium.org/467035 to detect a passed in hint of application/octet-stream and then return early if that was passed in. This was so that servers returning application/octet-stream to trigger a download would get that behavior (which matched Firefox at the time). The call to SniffMimeType() for file: URLs was passing in the same string object as the hint and result, causing a side-effect of setting the type_hint as the sniffing was under way which in turn, stopped the sniff early. This CL fixes the call-site to pass in a new string to store the result into and remove the aliasing issue. Bug: 848124 Tests: Added test using PDF that triggered this behavior. Change-Id: I862056ad43efea5497937d1f394394eaabc4742c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543059 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Ken Rockot <rockot@google.com> Reviewed-by: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#649442} chrome/browser/pdf/pdf_extension_test.cc | 19 +++++++++++++++++++ chrome/test/data/pdf/imgpdf | Bin 0 -> 1608 bytes content/browser/file_url_loader_factory.cc | 4 +++- 3 files changed, 22 insertions(+), 1 deletion(-) commit 4f2aba795c6c3e9f386856adefcb3be413ac00fd Author: Florian Uunk <feuunk@chromium.org> Date: Wed Apr 10 08:05:34 2019 +0000 Add integration test for butter credit card save dialog Tests upload scenario and local save because payments rejected the card. This is a reland of crrev.com/1486336, with a fix for the official builds here: https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/linux64%20trunk/builds/15834 The problem was that SaveCardBubbleViewsBrowserTest overrode the url loader factory from sync_test, which broke sync_test's setup logic. Bug: 876301,915216 Change-Id: I88f8b49786228209347852ad291da79f3dce00dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559083 Commit-Queue: Florian Uunk <feuunk@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#649441} .../autofill/save_card_bubble_views_browsertest.cc | 82 +++++++++++++++++++++- 1 file changed, 81 insertions(+), 1 deletion(-) commit 7657aa7a5001e0ae5dbbd3ce16622f4292364704 Author: Jakob Ivarsson <jakobi@google.com> Date: Wed Apr 10 08:01:55 2019 +0000 Add field trial testing config for WebRTC-Audio-NetEqDelayHistogram. Bug: chromium:949156 Change-Id: I26d9c8c4e1b15240dd70cc03a47eebd794c454b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559136 Reviewed-by: Brian White <bcwhite@chromium.org> Commit-Queue: Jakob Ivarsson <jakobi@google.com> Cr-Commit-Position: refs/heads/master@{#649440} testing/variations/fieldtrial_testing_config.json | 15 +++++++++++++++ 1 file changed, 15 insertions(+) commit 9ffa7b3a923623a5982380a8ef9ee4a81698dfdb Author: Manu Cornet <manucornet@chromium.org> Date: Wed Apr 10 08:01:34 2019 +0000 CrOS Shelf: Slight increase in default shelf background alpha This increases the default alpha from ~60% to ~74%. This change was requested by UX, see the linked bug. Bug: 934995 Change-Id: Id95cc0ad00c6738272639dceac0c5d4ebc733d7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559418 Reviewed-by: Stefan Kuhne <skuhne@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#649439} ash/shelf/shelf_constants.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit db20baed897e18683f50c7c18bef3f576782f92f Author: Mao Huang <littlecvr@google.com> Date: Wed Apr 10 07:54:18 2019 +0000 Implement general audience browsing feature This feature blocks inappropriate content (such as adult content) to make the browsing experience suitable for general audience. Bug: b/110951484 Test: Manually tested with '--enable-features=enable_general_audience_browsing' flag Change-Id: Iaba478ab353e6961de7106119d9fdd844cccf6c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534588 Reviewed-by: Marc Treib <treib@chromium.org> Reviewed-by: Drew Wilson <atwilson@chromium.org> Reviewed-by: Luke Halliwell <halliwell@chromium.org> Commit-Queue: Mao Huang <littlecvr@chromium.org> Cr-Commit-Position: refs/heads/master@{#649438} chromecast/base/cast_features.cc | 4 + chromecast/base/cast_features.h | 1 + chromecast/browser/BUILD.gn | 8 ++ chromecast/browser/DEPS | 2 + chromecast/browser/cast_browser_main_parts.cc | 2 + chromecast/browser/cast_content_browser_client.cc | 16 +++ chromecast/browser/cast_content_browser_client.h | 5 + .../general_audience_browsing/mojom/BUILD.gn | 11 ++ .../browser/general_audience_browsing/mojom/OWNERS | 2 + .../mojom/general_audience_browsing.mojom | 14 +++ ...eneral_audience_browsing_navigation_throttle.cc | 92 +++++++++++++++++ ...general_audience_browsing_navigation_throttle.h | 57 +++++++++++ .../browser/general_audience_browsing_service.cc | 113 +++++++++++++++++++++ .../browser/general_audience_browsing_service.h | 67 ++++++++++++ 14 files changed, 394 insertions(+) commit 3d70825847caeb3aeba23740ddabf35cc5fc9cf8 Author: Jeevan Shikaram <jshikaram@chromium.org> Date: Wed Apr 10 07:47:51 2019 +0000 [App Management] Clicking on a permission item toggles permission. This CL fixes a regression which was caused when permissions are hidden in an ARC permissions view. Tests are added to catch this in the future. Bug: 951234 Change-Id: If5332c9063592273c15911e4082ef5b4d540c1f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559416 Reviewed-by: calamity <calamity@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#649437} .../resources/app_management/permission_item.js | 4 +- .../app_management/arc_permission_view_test.js | 68 ++++++++++++++++++++++ .../app_management/pwa_permission_view_test.js | 2 +- 3 files changed, 71 insertions(+), 3 deletions(-) commit 10c09836c91d59aca856908f81bedea9c79ed951 Author: Florian Uunk <feuunk@chromium.org> Date: Wed Apr 10 07:47:30 2019 +0000 Add field trial config for Butter. Requires small changes to sync integration tests: - The helper methods that create a PersonalDataManager now also pass the sync service to it, so that the server database is set. Outside of tests, AutofillManager does this. - SingleClientWalletSyncTest was passing sync data to PDM before sync was active, which now causes a db switch from profile to account. Instead, set up sync before the test, and then trigger an explicit sync cycle. Change-Id: Icf46f46a8f3a1dbbd92df1ef3924b2aa35de5b6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1388430 Commit-Queue: Florian Uunk <feuunk@chromium.org> Reviewed-by: Jan Krcal <jkrcal@chromium.org> Reviewed-by: Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#649436} .../sync/test/integration/autofill_helper.cc | 8 +++- .../integration/single_client_wallet_sync_test.cc | 44 ++++++++++++++++------ .../integration/two_client_wallet_sync_test.cc | 8 ---- .../browser/sync/test/integration/wallet_helper.cc | 8 +++- testing/variations/fieldtrial_testing_config.json | 22 +++++++++++ 5 files changed, 68 insertions(+), 22 deletions(-) commit 6f844ad6b858dffebf8fe9fd4fe8fd10d7918551 Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Wed Apr 10 07:38:39 2019 +0000 Update V8 to version 7.5.232. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5fc4030a..b68b2c11 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib6b080cfe2830132a659c3805213f97380df56a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560740 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649435} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 7911d57c74dc2dd125f1d4bcc6020ce6dde16cf7 Author: Mikel Astiz <mastiz@chromium.org> Date: Wed Apr 10 07:35:09 2019 +0000 Parse DeviceInfo protos in backend thread This avoids keeping the UI busy for users with a high number of devices. In follow-up patches, we intend to add further (and more expensive) logic in there. Bug: 922971 Change-Id: Id007cf1a9c78c07170bf442ac25a9c92685f134c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560191 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#649434} .../sync/device_info/device_info_sync_bridge.cc | 53 ++++++++++++++++------ .../sync/device_info/device_info_sync_bridge.h | 4 +- 2 files changed, 40 insertions(+), 17 deletions(-) commit 0273c651b0c34101f43dca38a98004aa9dfa525b Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 10 07:23:15 2019 +0000 Roll src/third_party/skia 42bd04767743..064a0b4716d0 (3 commits) https://skia.googlesource.com/skia.git/+log/42bd04767743..064a0b4716d0 git log 42bd04767743..064a0b4716d0 --date=short --no-merges --format='%ad %ae %s' 2019-04-10 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset 2019-04-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 82418c821689..f39b4f0280ef (12 commits) 2019-04-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader eba396cc66d3..f0aa9d5ab738 (14 commits) Created with: gclient setdep -r src/third_party/skia@064a0b4716d0 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: I20b9472163c0a2d459d5026a2fbe9ee744467f89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560891 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649433} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit abb5f6df1b20d8c76f2ef5ad2cd6fb20170f0fc3 Author: Jan Krcal <jkrcal@chromium.org> Date: Wed Apr 10 07:20:05 2019 +0000 [AF Profile Sync] Fix ios instrumentation tests for USS This CL fixes an EG test on iOS that did not work well with the USS implementation of sync. Concretely, it makes FakeServer provide the right client tag hash when deleting an entity (which is required by USS). Bug: 836718 Change-Id: I4ca9ca1fedb2fd2d902d01a0a4cb9d67823ee2b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547988 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#649432} ios/chrome/test/app/sync_test_util.mm | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) commit 405b8974be855a844135d0db75f63b59f60b980f Author: Darren Shen <shend@chromium.org> Date: Wed Apr 10 07:16:29 2019 +0000 Add shend to VK watchlist. TBR=dstockwell@chromium.org Change-Id: If8564d45bc8cd3f22d6161974363d99591b5d1ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560812 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#649431} WATCHLISTS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit 08faf1f0f8a80725395388134de52c14828e0e3b Author: Angelika Kurtz <akurtz@google.com> Date: Wed Apr 10 07:16:04 2019 +0000 Remove unused Sync.RequestContentLength..* histograms Bug: 900075 Change-Id: Ia5a25bef4e58690702ae07d37727a727aa12d449 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559179 Auto-Submit: Angelika Kurtz <akurtz@google.com> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Reviewed-by: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#649430} components/sync/engine/net/http_bridge.cc | 10 ---------- tools/metrics/histograms/histograms.xml | 12 ++++++++++-- 2 files changed, 10 insertions(+), 12 deletions(-) commit 988305027aaa0ac24c71901dcec4935ff13286f8 Author: Stephane Zermatten <szermatt@chromium.org> Date: Wed Apr 10 07:15:24 2019 +0000 [Autofill Assistant] Report too many element matches differently from no matches. With this change, when looking for an element in strict mode, client actions will return TOO_MANY_ELEMENTS instead of ELEMENT_RESOLUTION_FAILED. The goal of this change is to be able to tell the difference between these two very different issues: TOO_MANY_ELEMENTS is always a scripting issue, while ELEMENT_RESOLUTION_FAILED has many different causes. This change also rejects empty selectors early and cleanly with a custom error code. The motivation is mostly to understand why click actions fail, though this change is not limited to these actions. Bug: b/129387787 Change-Id: I98a3964a293767320355191d03045d869bec9176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554764 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#649429} .../autofill_assistant/browser/client_status.cc | 4 +++ .../autofill_assistant/browser/service.proto | 5 ++++ .../autofill_assistant/browser/web_controller.cc | 34 ++++++++++++++++------ .../browser/web_controller_browsertest.cc | 18 ++++++++++++ 4 files changed, 52 insertions(+), 9 deletions(-) commit 8724df8eb89987c8aa8917c4939eca3bce2d9e40 Author: Nigel Tao <nigeltao@chromium.org> Date: Wed Apr 10 07:04:24 2019 +0000 Give LoadIconFromExtension a fallback icon This code path is contingent on the App Service being enabled. If, for whatever reason, the underyling extension system can't find an icon, we now default to the IDR_APP_DEFAULT_ICON instead of an empty icon. This matches the existing behavior with the App Service disabled. BUG=826982 Change-Id: I1f79a4a02513871ba955e6bdbd1a91107b230b45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558568 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#649428} .../browser/apps/app_service/app_icon_factory.cc | 119 ++++++++++++++------- 1 file changed, 80 insertions(+), 39 deletions(-) commit 95d3e773769ae068ddc65d4f446718aa0bcae1f4 Author: Marc Treib <treib@chromium.org> Date: Wed Apr 10 07:00:24 2019 +0000 Delete variations::CHROME_SYNC_EVENT_LOGGER This existed to support recording of field trials as Sync user events. That feature was abandoned and recently deleted (crrev.com/c/1557020). Bug: 934762 Change-Id: Ic6deed6a5e951dac9e33e7e6891f92b76161a910 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556805 Reviewed-by: Steven Holte <holte@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#649427} .../variations/variations_associated_data.cc | 5 ++- components/variations/variations_associated_data.h | 3 -- .../variations_associated_data_unittest.cc | 50 ---------------------- .../variations/variations_http_header_provider.cc | 5 +-- components/variations/variations_seed_processor.cc | 6 --- 5 files changed, 5 insertions(+), 64 deletions(-) commit 1fcc09e2cf639602bd86fca33c838a2843b45b1f Author: Hirokazu Honda <hiroh@chromium.org> Date: Wed Apr 10 07:00:04 2019 +0000 media/gpu: Move VideoFrameMappers to a production directory For LibyuvIP to support DMABUF input, it is necessary to map DMABUF-backed video frame inside LibyuvIP. We have VideoFrameMapper class which has been used in test code. We should make use of the classes to reduce code duplication. Bug: 944822 Test: Build chrome and video tests Change-Id: I6f90ab9a9f515694153da5499f45529ebe2d22a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538102 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by: David Staessens <dstaessens@chromium.org> Reviewed-by: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#649426} media/gpu/BUILD.gn | 38 +++++ media/gpu/linux/BUILD.gn | 17 +++ .../generic_dmabuf_video_frame_mapper.cc | 4 +- .../generic_dmabuf_video_frame_mapper.h | 16 +-- .../vaapi_dmabuf_video_frame_mapper.cc | 12 +- media/gpu/test/BUILD.gn | 33 +---- .../video_encode_accelerator_unittest_helpers.cc | 11 +- media/gpu/test/video_frame_file_writer.cc | 4 +- media/gpu/test/video_frame_file_writer.h | 5 +- media/gpu/test/video_frame_validator.cc | 8 +- media/gpu/test/video_frame_validator.h | 3 +- media/gpu/vaapi/BUILD.gn | 3 + media/gpu/vaapi/vaapi_dmabuf_video_frame_mapper.cc | 155 +++++++++++++++++++++ .../vaapi_dmabuf_video_frame_mapper.h | 20 ++- media/gpu/{test => }/video_frame_mapper.h | 14 +- media/gpu/{test => }/video_frame_mapper_factory.cc | 34 ++--- media/gpu/{test => }/video_frame_mapper_factory.h | 13 +- 17 files changed, 283 insertions(+), 107 deletions(-) commit 1439620a6cd4e68b0e2d70eb120fdbe536a9cf2e Author: Jan Krcal <jkrcal@chromium.org> Date: Wed Apr 10 06:37:02 2019 +0000 [UMA] Extend two Autofill Profile Sync histograms The launch is getting slightly delayed and thus it is safer to extend the lifetime by one milestone. Bug: 945547 Change-Id: I4fb9803d980fec9bb0a37e079509d77dea8ea540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559314 Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by: Mark Pearson <mpearson@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#649425} tools/metrics/histograms/histograms.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 9cc64eb6ae6cc9161b62d72396e32847177e87f6 Author: Aleksei Loshkarev <lixan@yandex-team.ru> Date: Wed Apr 10 06:34:12 2019 +0000 Fixes EnableDisableSingleClientTest EnableDisableSingleClientTest.ResendsBagOfChips is flaky, because it uses UpdatedProgressMarkerChecker that relies on 'self-notify' feature. Also disables run for TwoClientPasswordsSyncTest.MergeWithTheMostRecent in E2E mode because external server does not support 'self-notify' feature. Change-Id: Iaf4ef7926dae15c744c76dce9ccd13eca48a7b90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559184 Reviewed-by: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Aleksei Loshkarev <lixan@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#649424} .../sync/test/integration/enable_disable_test.cc | 33 ++++++++++++++-------- .../integration/two_client_passwords_sync_test.cc | 4 +-- .../integration/updated_progress_marker_checker.cc | 4 +++ 3 files changed, 26 insertions(+), 15 deletions(-) commit c19fc2b8ab6f447d196d66db9d8971ed9c9dc313 Author: Takashi Sakamoto <tasak@google.com> Date: Wed Apr 10 06:30:52 2019 +0000 Freeze a page quickly after backgrounded. Change-Id: I2d9014f6951657d9bf09530e70546266d98b8852 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1417430 Reviewed-by: François Doray <fdoray@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#649423} third_party/blink/common/features.cc | 5 + third_party/blink/public/common/features.h | 2 + .../renderer/core/loader/idleness_detector.cc | 21 ++++ .../blink/renderer/core/loader/idleness_detector.h | 1 + third_party/blink/renderer/core/page/page.cc | 8 ++ third_party/blink/renderer/core/page/page.h | 1 + .../scheduler/main_thread/page_scheduler_impl.cc | 95 +++++++++++++--- .../scheduler/main_thread/page_scheduler_impl.h | 12 +- .../main_thread/page_scheduler_impl_unittest.cc | 122 ++++++++++++++++++++- .../platform/scheduler/public/page_scheduler.h | 6 + .../platform/scheduler/test/fake_page_scheduler.h | 1 + .../test/renderer_scheduler_test_support.cc | 1 + 12 files changed, 259 insertions(+), 16 deletions(-) commit a4bfceac6333dc7a7704e6bd98cdf9b9c5e64305 Author: Abhijeet Kandalkar <abhijeet@igalia.com> Date: Wed Apr 10 06:30:32 2019 +0000 Make case style consistent in web_url_request.h The primary motivation of CL is that the function names aren't consistent within web_url_request.h (e.g."HttpMethod" and "SetHTTPMethod"). This CL renames function |SetHTTPMethod| to |SetHttpMethod| and ports other dependent files to refer to a new function name. Bug: 937196 Change-Id: I179542a2a036811cd23b562e4b2648665655a330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558561 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#649422} content/renderer/pepper/url_request_info_util.cc | 2 +- content/renderer/render_view_browsertest.cc | 4 ++-- third_party/blink/public/platform/web_url_request.h | 2 +- .../blink/renderer/core/exported/web_associated_url_loader_impl.cc | 2 +- .../renderer/core/exported/web_associated_url_loader_impl_test.cc | 2 +- third_party/blink/renderer/core/fetch/fetch_manager.cc | 4 ++-- third_party/blink/renderer/core/loader/form_submission.cc | 2 +- third_party/blink/renderer/core/loader/frame_fetch_context_test.cc | 2 +- third_party/blink/renderer/core/loader/history_item.cc | 2 +- third_party/blink/renderer/core/loader/ping_loader.cc | 6 +++--- .../blink/renderer/core/loader/resource/image_resource_test.cc | 2 +- third_party/blink/renderer/core/loader/threadable_loader.cc | 2 +- .../blink/renderer/core/workers/worker_classic_script_loader.cc | 4 ++-- third_party/blink/renderer/core/xmlhttprequest/xml_http_request.cc | 2 +- third_party/blink/renderer/modules/eventsource/event_source.cc | 2 +- third_party/blink/renderer/platform/exported/web_url_request.cc | 4 ++-- .../renderer/platform/loader/fetch/memory_cache_correctness_test.cc | 4 ++-- .../blink/renderer/platform/loader/fetch/resource_request.cc | 4 ++-- third_party/blink/renderer/platform/loader/fetch/resource_request.h | 2 +- 19 files changed, 27 insertions(+), 27 deletions(-) commit fafbf783f4b6f46ed24def8980a2ef8949a87831 Author: Maggie Cai <mxcai@chromium.org> Date: Wed Apr 10 06:12:32 2019 +0000 Show intent picker icon in Omnibox for all navigations. Currently if we are not navigate from a link, the intent picker will not show at all. This CL shows the intent picker icon in the Omnibox for all navigations when there are apps that can handle the url. BUG=939205, 856907 Change-Id: I655195f65359e230c004df90de1ea2a778d5984c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551734 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: David Jacobo <djacobo@chromium.org> Cr-Commit-Position: refs/heads/master@{#649421} .../apps/intent_helper/apps_navigation_throttle.cc | 49 ++++-------- .../apps/intent_helper/apps_navigation_throttle.h | 7 ++ .../apps_navigation_throttle_unittest.cc | 87 ++++++++-------------- .../chromeos_apps_navigation_throttle.cc | 3 +- 4 files changed, 55 insertions(+), 91 deletions(-) commit a822212d727da7abf8212698e540b4e3ac8c2914 Author: David Staessens <dstaessens@chromium.org> Date: Wed Apr 10 06:11:37 2019 +0000 media/gpu/test: Fix merge error in video decode accelerator tests. When switching the new video decode accelerator tests from the VDA to the VD interface (crrev.com/c/1476949), the number of simultaneous decodes was adapted to line up with the value in the VdaVideoDecoder wrapper used by Chrome. Unfortunately crrev.com/c/1550179 accidentally restored this value to its old value by an erroneous merge. This CL fixes it back to the intended value. TEST=ran new VDA tests on nocturne BUG=None Change-Id: I7fa323f7808d2f94501f07f093d52ac0300a0197 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558552 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#649420} media/gpu/video_decode_accelerator_tests.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 578752cc00b151cb5a156731b68f9a755a18db9d Author: rajendrant <rajendrant@chromium.org> Date: Wed Apr 10 06:11:27 2019 +0000 Change 502 response with no bypass info to be configurable via field trial CORB failures could block any response headers being sent to the rendere. These are treated as a random 1-5 minute bypass, since Chrome-Proxy is not in the response. This CL changes the bypass duration to be configurable via field trial. Bug: 947736 Change-Id: I0e114fb103887dabf6ccef76bd2d552492ecac45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553088 Reviewed-by: Tarun Bansal <tbansal@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#649419} .../data_reduction_proxy_browsertest.cc | 40 ++++++++++++++++++++++ .../core/common/data_reduction_proxy_features.cc | 7 ++++ .../core/common/data_reduction_proxy_features.h | 1 + .../core/common/data_reduction_proxy_headers.cc | 16 ++++++++- 4 files changed, 63 insertions(+), 1 deletion(-) commit e9fb2bc7b016cc004c3e812d04f3a71395ed21c2 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 10 06:10:30 2019 +0000 Roll src/third_party/swiftshader f0aa9d5ab738..26357f18cb2a (1 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/f0aa9d5ab738..26357f18cb2a git log f0aa9d5ab738..26357f18cb2a --date=short --no-merges --format='%ad %ae %s' 2019-04-10 swiftshader.regress@gmail.com Regres: Update test lists @ f0aa9d5a Created with: gclient setdep -r src/third_party/swiftshader@26357f18cb2a The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: I1627b3bc9add721446832b6f37e085f05def0935 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559469 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649418} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e9e148948823fb8b0069ffcd61548cb7c69fd01b Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 10 06:10:22 2019 +0000 Roll src/third_party/skia b5c685991faa..42bd04767743 (1 commits) https://skia.googlesource.com/skia.git/+log/b5c685991faa..42bd04767743 git log b5c685991faa..42bd04767743 --date=short --no-merges --format='%ad %ae %s' 2019-04-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 79154509c679..1b121674f584 (400 commits) Created with: gclient setdep -r src/third_party/skia@42bd04767743 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: I1fe2bc737b2053262c2f244a0998566e25312dd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559468 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649417} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 5f0ec5ca5c160cd43060324123b73b02a4dfe615 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Wed Apr 10 06:09:18 2019 +0000 Roll src-internal c516188a7211..4db2cc60967c (2 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c516188a7211..4db2cc60967c Created with: gclient setdep -r src-internal@4db2cc60967c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=huangs@chromium.org,battre@chromium.org,collinbaker@chromium.org,tasak@chromium.org Change-Id: Ic4c923d77b14b2e4c8439e16086c47c68eaf5a99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559467 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649416} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 6404b743fd86aac97905bd2a9ea5524d305ba4c1 Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Wed Apr 10 06:09:13 2019 +0000 Update V8 to version 7.5.230. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bd925e99..5fc4030a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If7e6938e91d24fe9d46adde43ffb912ed7752966 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560738 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649415} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 23e694012f660045a39ec775c63d58f73c382f35 Author: Shu Chen <shuchen@chromium.org> Date: Wed Apr 10 05:15:52 2019 +0000 [Mojo-IMF] Add MojoIMF feature flag and hook it up in WindowTreeHostMus. This cl includes the some test helper changes to disable key event dispatching in the tests. So that the tests can pass without InputMethodMus. Bug: 937167 Change-Id: I4c3237269c445200f71f3e1bc2276934c0c8efa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556955 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#649414} ui/aura/mus/window_tree_client.cc | 19 ++----------- ui/aura/mus/window_tree_host_mus.cc | 38 +++++++++++++++++++++++--- ui/aura/mus/window_tree_host_mus.h | 6 ++-- ui/aura/mus/window_tree_host_mus_init_params.h | 4 --- ui/aura/test/mus/input_method_mus_test_api.h | 5 ---- ui/aura/window_tree_host.cc | 3 +- ui/base/ui_base_features.cc | 13 +++++++++ ui/base/ui_base_features.h | 9 ++++++ ui/views/test/platform_test_helper_mus.cc | 23 +++++++++++++++- 9 files changed, 87 insertions(+), 33 deletions(-) commit 614cd80c9a71fac261897bf5cde00e9ccf0fdacc Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 10 05:13:32 2019 +0000 Roll Fuchsia SDK from 891662942428 to 891660307559 The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I78a2cc99fc35c83473493c2b29a00f6848d425d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559465 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649413} build/fuchsia/linux.sdk.sha1 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit eab439705cbe95df3cb902b6cd573c56b25da7b4 Author: Charles Zhao <charleszhao@chromium.org> Date: Wed Apr 10 05:06:31 2019 +0000 TabDiscarder: add discardcount to adjust how a discard candidate is selected. (2) DiscardCount is added as an adjustment. A tab that has been discarded and reloaded many times should not be discarded again. (3) We also add the MRUScorer as a comparison of the MLScorer. Change-Id: Ib501416db8e89743cabd51fd3f453b069a2f02ad Bug: 948915 Change-Id: Ib501416db8e89743cabd51fd3f453b069a2f02ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546737 Reviewed-by: François Doray <fdoray@chromium.org> Commit-Queue: Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/master@{#649412} chrome/browser/BUILD.gn | 3 +- chrome/browser/resource_coordinator/BUILD.gn | 15 +++++++ .../resource_coordinator/tab_manager_features.cc | 15 +++++++ .../resource_coordinator/tab_manager_features.h | 9 +++++ .../resource_coordinator/tab_metrics_logger.cc | 14 +++++++ .../tab_metrics_logger_interactive_uitest.cc | 34 ++++++++++++++++ .../resource_coordinator/tab_ranker/BUILD.gn | 2 +- .../resource_coordinator/tab_ranker/tab_features.h | 4 +- .../tab_ranker/tab_score_predictor.cc | 46 +++++++++++++++++++++- .../tab_ranker/tab_score_predictor.h | 11 +++++- .../tab_ranker/tab_score_predictor_unittest.cc | 33 +++++++++++++--- 11 files changed, 175 insertions(+), 11 deletions(-) commit 28c2a419a4eeae59c7bd1065ed6cf2d8c08f9b67 Author: Kenneth Russell <kbr@chromium.org> Date: Wed Apr 10 05:05:12 2019 +0000 Fix specification of two tester bots on chromium.gpu.fyi. Thin Linux VMs are being tested in place of either Windows VMs or Mac VMs (or physical hardware) for the purpose of triggering tests on bots in the Swarming pool. Bug: 950764 Change-Id: I973cc68d7f0f257ed805fece0e0f9c126c07bdc0 Tbr: martiniss@chromium.org No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560739 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#649411} infra/config/cr-buildbucket.cfg | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) commit 76aae627f5769815f0b79dc7a28e9df8e3bfb6c9 Author: Chromium WPT Sync <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Date: Wed Apr 10 04:53:11 2019 +0000 Import wpt@0524bbe1052793b4b2c50a76b7d1b7d2b2797ed6 Using wpt-import in Chromium d443dfb4a52fa07c3c478c4fb2343c6d53099034. With Chromium commits locally applied on WPT: 0a8f3ffa48 "Use testdriver Action API in WPT pointerevent touch tests - Part 2" adc34f41f6 "Fix web_test pointerevent_coordinates_when_locked on wpt" 8659792f35 "[WPT] Move wrapResult to common.js and clarify requestVia*() return values" e525003f05 "Do not resume a suspended BaseAudioContext when AudioWorklet starts" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kenneth.r.christiansen@intel.com, rijubrata.bhaumik@intel.com: external/wpt/web-nfc NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ic5eee59acdf9d7c116ca2ff0df737ddaca85d516 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560731 Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649410} .../web_tests/external/WPT_BASE_MANIFEST_5.json | 56 +++++++++++++++------- ...der_options_mediaType-manual.https-expected.txt | 4 ++ .../NFCReader_options_mediaType-manual.https.html | 31 ++++++++++++ 3 files changed, 73 insertions(+), 18 deletions(-) commit b4ba96de2bfd2a2e1c0300b5b4f46533a92f4948 Author: Takashi Sakamoto <tasak@google.com> Date: Wed Apr 10 04:26:20 2019 +0000 Add RendererScheduler.TaskCountPerFrameType.HasSafepoint.* metrics Add metrics to measure tasks which has CooperativeScheduling Safepoint: - RendererScheduler.TaskCountPerFrameType.HasSafepoint - RendererScheduler.TaskCountPerFrameType.HasSafepoint.LongerThan16ms - RendererScheduler.TaskCountPerFrameType.HasSafepoint.LongerThan50ms - RendererScheduler.TaskCountPerFrameType.HasSafepoint.LongerThan100ms - RendererScheduler.TaskCountPerFrameType.HasSafepoint.LongerThan150ms - RendererScheduler.TaskCountPerFrameType.HasSafepoint.LongerThan1s Change-Id: Ic048b1a7afde519357f1381b80d8f6fd1040a65e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535927 Reviewed-by: Brian White <bcwhite@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#649409} .../common/cooperative_scheduling_manager.cc | 3 ++ .../main_thread/main_thread_metrics_helper.cc | 36 ++++++++++++++++++++++ .../main_thread/main_thread_scheduler_impl.cc | 11 ++++++- .../main_thread/main_thread_scheduler_impl.h | 4 +++ .../platform/scheduler/public/thread_scheduler.h | 2 ++ tools/metrics/histograms/histograms.xml | 16 ++++++++++ 6 files changed, 71 insertions(+), 1 deletion(-) commit ae03bda66a9b8790ccbdb48b539752ad91a76972 Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Wed Apr 10 04:21:00 2019 +0000 Update V8 to version 7.5.229. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a1fea4b4..bd925e99 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1b0c56dd121b25cfd01a53d53315296023f0c13a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560733 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649408} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 1ae942dc574562202e082945ab9fbe959d4b7756 Author: Shu Chen <shuchen@chromium.org> Date: Wed Apr 10 04:07:26 2019 +0000 [Mojo-IMF] Fixes the client side issues. When creating a new InputMethodChromeOS, it should not set to the current input context handler to the IMEBridge. Otherwise, it would cause problem when showing a new candidate window view and the ime engine tries to use it through IMEBridge (non-Mojo based). A particular bug is when creating the candidate window view, a new InputMethodChromeOS is created, but its OnFocus() never gets called (because the candidate window is unfocusable). This cl fix the issue by explicit calling OnFocus() in the InputMethodBridge, and remove the SetInputContextHandler() call from the InputMethodChromeOS::ctor. Another issue is avoid this call chain in InputMethodChromeOS::ctor: InputMethodChromeOS::ctor InputMethodChromeOS::UpdateContextFocusState CandidateWindowControllerImpl::FocusStateChanged CandidateWindowView::HidePreeditText Widget::Close Instead, it is safe to just ResetContext() in InputMethodChromeOS::ctor. Bug: 937167 Change-Id: Ib868ed8719f633e29dd27fe6b68605cd2d3a0d81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558740 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#649407} chrome/browser/ui/views/ime_driver/input_method_bridge_chromeos.cc | 1 + ui/base/ime/chromeos/input_method_chromeos.cc | 4 +--- 2 files changed, 2 insertions(+), 3 deletions(-) commit 3f765fec7c6adbf2972ade6fa2be2f7f3a528c82 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Wed Apr 10 04:04:00 2019 +0000 Roll src-internal 9ce4d5d3cc11..c516188a7211 (3 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9ce4d5d3cc11..c516188a7211 Created with: gclient setdep -r src-internal@c516188a7211 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=huangs@chromium.org,battre@chromium.org,collinbaker@chromium.org,tasak@chromium.org Change-Id: I92ada07a10171c645732aee1ed95730142e28807 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560734 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649406} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 3889a4a46b28ccff1eab8c7077a474deda46da8c Author: Gyuyoung Kim <gyuyoung@igalia.com> Date: Wed Apr 10 04:03:10 2019 +0000 BlinkMemoryMgt: Annotate Blink's renderer/core with the macros of Allocator This CL finishes annotating the rest of the classes of //third_party/blink/renderer/core with the macros of Allocator. After some analyzes, it was concluded that for the case of MediaQuery and Entry classes, it makes sense to use USING_FAST_MALLOC because it has been used as a member variable with new() or smart pointers. In LayoutObjectCounter and CompositingInputsRoot class, they make sense to use DISALLOW_NEW because it has been used as a member variable with a reference type. Lastly, the rest of the classes this CL annotates make sense to use STACK_ALLOCATED. Bug: 919389 Change-Id: I6c81513e12b2c100170a8a7d02a0e3ea5eda8b40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559417 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#649405} third_party/blink/renderer/core/css/media_query.h | 3 +++ third_party/blink/renderer/core/input/event_handler.h | 3 +++ third_party/blink/renderer/core/inspector/inspector_css_agent.cc | 3 +++ .../blink/renderer/core/paint/compositing/compositing_inputs_root.h | 4 ++++ third_party/blink/renderer/core/paint/layout_object_counter.h | 4 ++++ third_party/blink/renderer/core/svg/svg_path_blender.cc | 3 +++ .../blink/renderer/core/workers/worklet_module_responses_map.h | 3 +++ third_party/blink/renderer/core/xmlhttprequest/xml_http_request.cc | 3 +++ 8 files changed, 26 insertions(+) commit 1b121674f5847dc695e6e7a660cd3d3faf0e2da0 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 10 03:54:40 2019 +0000 Roll src/third_party/skia 2655ede7c9f9..b5c685991faa (1 commits) https://skia.googlesource.com/skia.git/+log/2655ede7c9f9..b5c685991faa git log 2655ede7c9f9..b5c685991faa --date=short --no-merges --format='%ad %ae %s' 2019-04-10 reed@google.com remove shader factory guard define Created with: gclient setdep -r src/third_party/skia@b5c685991faa The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: I294f7310b451ea3e47454783e3ab7a8e469dcc78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559585 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649404} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 8f3badfeaae38cfbd4bed1d99ec92dafe2aed3e5 Author: Frank Tang <ftang@chromium.org> Date: Wed Apr 10 03:50:45 2019 +0000 Roll ICU to 4ae748 from 69c72a6 https://chromium.googlesource.com/chromium/deps/icu.git/+log/69c72a6d..4ae7482a It includes only 4ae7482 Update IANA timezone database to 2019a Test: See ICU 4ae7482a0 CL description for tz test. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Bug: 473288 Change-Id: I5aff7c67243151217e2800b12eab2480dbaac2cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560308 Reviewed-by: Jungshik Shin <jshin@chromium.org> Commit-Queue: Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#649403} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 1654649e28c1b4fa6dd442147775027a255ba7bd Author: Shu Chen <shuchen@chromium.org> Date: Wed Apr 10 03:50:27 2019 +0000 Reland "[Mojo-IMF] Defines/implements mojo interface - ImeEngineClient." This reverts commit c9c2c4a43094b7c31b799d80740d458bf53398c7. Reason for revert: reland with fix. The root cause of the issue is that the callback passed to ProcessKeyEventDone() is released unexpectedly. Please see patchset diff for details. Original change's description: > Revert "[Mojo-IMF] Defines/implements mojo interface - ImeEngineClient." > > This reverts commit 6716700301b80d7003fa0a9c417e7efd8ef381ac. > > Reason for revert: http://crbug.com/950211 > > Original change's description: > > [Mojo-IMF] Defines/implements mojo interface - ImeEngineClient. > > > > - Makes InputMethodChromeOS as an ImeEngineClient. > > - Hooks up WindowTreeHostMus/WindowTreeClient to connect to ImeEngine. > > - Makes calls from ImeEngine to ImeEngineClient. > > > > Bug: 937167 > > Change-Id: I0d27ce6e9bc547f4d269cdfe0ef38e8e83673267 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546795 > > Commit-Queue: Shu Chen <shuchen@chromium.org> > > Reviewed-by: Scott Violet <sky@chromium.org> > > Reviewed-by: Dominick Ng <dominickn@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#648188} > > TBR=sky@chromium.org,shuchen@chromium.org,dominickn@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 937167 > Change-Id: Iedc3a4e21c4236ee7a3529977fe74ba9f3a74c6b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559846 > Reviewed-by: Michael Wasserman <msw@chromium.org> > Commit-Queue: Michael Wasserman <msw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#649171} TBR=sky@chromium.org,msw@chromium.org,shuchen@chromium.org,dominickn@chromium.org Change-Id: I91512f3ba03cd2cca122584fada92fd534537e04 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 937167 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559415 Commit-Queue: Shu Chen <shuchen@chromium.org> Reviewed-by: Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#649402} ash/ime/ime_engine_factory_registry_unittest.cc | 9 ++ .../chromeos/input_method/input_method_engine.cc | 19 +-- .../input_method/input_method_engine_unittest.cc | 20 +++ services/ws/window_service_unittest.cc | 9 ++ ui/aura/mus/window_tree_client.cc | 6 + ui/aura/mus/window_tree_client.h | 2 + ui/aura/mus/window_tree_host_mus.cc | 7 + ui/aura/mus/window_tree_host_mus.h | 3 + ui/aura/mus/window_tree_host_mus_delegate.h | 6 + ui/base/ime/BUILD.gn | 46 ++++-- ui/base/ime/candidate_window.h | 6 +- ui/base/ime/character_composer.h | 2 +- ui/base/ime/chromeos/BUILD.gn | 1 + ui/base/ime/chromeos/input_method_chromeos.cc | 159 +++++++++++++++++---- ui/base/ime/chromeos/input_method_chromeos.h | 8 ++ .../ime/chromeos/input_method_chromeos_unittest.cc | 68 +++++++++ ui/base/ime/composition_text.h | 2 +- ui/base/ime/ime_text_span.h | 2 +- ui/base/ime/infolist_entry.h | 2 +- ui/base/ime/input_method_delegate.cc | 7 + ui/base/ime/input_method_delegate.h | 15 ++ ui/base/ime/mojo/ime.mojom | 19 +++ ui/base/ime/mojo/ime_types.typemap | 2 +- ui/keyboard/BUILD.gn | 1 + ui/keyboard/test/run_all_unittests.cc | 2 + 25 files changed, 374 insertions(+), 49 deletions(-) commit f06ac3891c14c3100a05bea0445ef7ae867f269a Author: Tom Anderson <thomasanderson@chromium.org> Date: Wed Apr 10 03:49:38 2019 +0000 Make //tools/gdb easier to use //tools/gdb was broken up into several different files that developers had to source manually. This change makes it so that all files get pulled in by //tools/gdb/gdbinit, and also updates the documentation to point to a common location for using gdbinit. BUG=929992 R=thakis Change-Id: Iea6c015a919b5615c0860e78ada246d7dbb5a278 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538564 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#649401} base/debug/debugger_posix.cc | 6 +-- docs/gdbinit.md | 13 ++++++ docs/graphical_debugging_aid_chromium_views.md | 7 ++-- docs/linux_debugging.md | 31 ++++---------- tools/gdb/gdb_chrome.py | 2 +- tools/gdb/gdbinit | 58 +++++++++++++++++--------- tools/gdb/viewg.gdb | 2 +- 7 files changed, 68 insertions(+), 51 deletions(-) commit 5c4810f704168edcccbcc11c4502e8451bd90bbe Author: Nigel Tao <nigeltao@chromium.org> Date: Wed Apr 10 03:36:24 2019 +0000 Fix LoadIconFromExtension for components (again) Not every component extension has resource-backed icons. BUG=826982 Change-Id: Id349ae1a98ef0332b9e5a0cdc4f4b2a3582d4502 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559524 Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#649400} chrome/browser/apps/app_service/app_icon_factory.cc | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) commit 328f55781b6911025c18a6a1bf2ca640906eba9e Author: Etienne Pierre-doray <etiennep@chromium.org> Date: Wed Apr 10 03:33:57 2019 +0000 Reland "[TaskScheduler]: Simplify sequence preemption logic." This is a reland of 5d4c05db6d02f9422b3a7b6fb2b6b637691ccc2e Problem: PlatformNativeWorkerPool::RunNextSequenceImpl expects sequence returned from GetWork() to be non-null and DCHECK. Solution: Handle null sequences by skipping RunAndPopNextTask. Original change's description: > [TaskScheduler]: Simplify sequence preemption logic. > > This CL removes preempted sequences from TaskTracker, > removing need for CanScheduleSequenceObserver and > simplifying shutdown. > A CanRunPolicy enum is used instead, specifying whether > or not tasks at a given priority can run. > When CanRunPolicy is updated, wakeup workers needs > to be done as appropriate. > > In addition, Shutdown was split in 2 phases start + complete > to allow caller (TaskScheduler) to update CanRunPolicy after > shutdown was started. > > This CL was recycled from: > https://chromium-review.googlesource.com/c/chromium/src/+/1478007 > I took ownership because simplifying Sequence lifecycle > will simplify implementation of job API. > > TBR=gab@chromium.org > > Bug: 889029 > Change-Id: Ie5dbc226705880c5e598e013aa2dd3e7e874158b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531161 > Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > Cr-Commit-Position: refs/heads/master@{#648346} Bug: 889029, 950383 Change-Id: I1f64517d312e65fb59ae235373b4f4d504da87dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557861 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#649399} base/BUILD.gn | 2 +- base/task/task_scheduler/can_run_policy_test.h | 189 +++++++++ .../can_schedule_sequence_observer.h | 27 -- .../task_scheduler/platform_native_worker_pool.cc | 43 +- .../task_scheduler/platform_native_worker_pool.h | 1 + .../scheduler_single_thread_task_runner_manager.cc | 171 +++++--- .../scheduler_single_thread_task_runner_manager.h | 4 + ...r_single_thread_task_runner_manager_unittest.cc | 79 ++-- base/task/task_scheduler/scheduler_worker.cc | 3 +- base/task/task_scheduler/scheduler_worker.h | 10 +- base/task/task_scheduler/scheduler_worker_pool.cc | 38 +- base/task/task_scheduler/scheduler_worker_pool.h | 24 +- .../task_scheduler/scheduler_worker_pool_impl.cc | 53 ++- .../task_scheduler/scheduler_worker_pool_impl.h | 1 + .../scheduler_worker_pool_impl_unittest.cc | 69 +++- .../scheduler_worker_pool_unittest.cc | 58 ++- .../scheduler_worker_stack_unittest.cc | 3 - .../task_scheduler/scheduler_worker_unittest.cc | 19 +- base/task/task_scheduler/task_scheduler.cc | 4 +- base/task/task_scheduler/task_scheduler.h | 5 +- base/task/task_scheduler/task_scheduler_impl.cc | 58 ++- base/task/task_scheduler/task_scheduler_impl.h | 20 +- .../task_scheduler/task_scheduler_impl_unittest.cc | 69 ++++ base/task/task_scheduler/task_tracker.cc | 317 ++------------ base/task/task_scheduler/task_tracker.h | 226 ++-------- .../task_scheduler/task_tracker_posix_unittest.cc | 8 +- base/task/task_scheduler/task_tracker_unittest.cc | 459 +++------------------ base/task/task_scheduler/test_utils.cc | 10 +- base/task/task_scheduler/test_utils.h | 6 +- base/test/task_scheduler_test_helpers_android.cc | 3 +- 30 files changed, 885 insertions(+), 1094 deletions(-) commit 52d0d88760df6a19ae36a02edf4cd73b21af9f0f Author: David Staessens <dstaessens@chromium.org> Date: Wed Apr 10 03:26:27 2019 +0000 media/gpu/test: Fix Windows build for new video decode accelerator tests. The video_decode_accelerator_tests and video_decode_accelerator_perf_tests are currently not used on Windows, but by default the targets are built nonetheless so chrome-specific defines were added to the build files. This CL fixes building the tests on Windows, so these defines can be removed. Even though the tests are currently only supported on ChromeOS, it's better to avoid platform-specific defines if not really necessary. This also makes it easier to port the tests to other platforms in the future. Changes made to fix Windows build: - Added missing include only the windows build seems to complain about. - Use FILE_PATH_LITERAL whenever dealing with file path strings. - Add a function to get the test name in a platform independent way. TEST=ran new VDA (perf) tests on nocturne BUG=879065 Change-Id: Ia6a51ff9287ec0c3eaa0512e343097fa246e6d26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1438777 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by: Alexandre Courbot <acourbot@chromium.org> Reviewed-by: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#649398} media/gpu/BUILD.gn | 68 ++++++------ media/gpu/test/BUILD.gn | 121 ++++++++++----------- .../test/video_player/frame_renderer_thumbnail.cc | 1 + .../test/video_player/test_vda_video_decoder.cc | 11 +- .../video_player/video_player_test_environment.cc | 17 ++- .../video_player/video_player_test_environment.h | 3 + media/gpu/video_decode_accelerator_perf_tests.cc | 18 +-- media/gpu/video_decode_accelerator_tests.cc | 7 +- 8 files changed, 131 insertions(+), 115 deletions(-) commit f5f28026582b75bf2a6b9dd98ef1db5a5c107162 Author: Tom Anderson <thomasanderson@chromium.org> Date: Wed Apr 10 03:21:43 2019 +0000 libcxx-pretty-printers: Fix iterator printing Fixes pretty printing for: * std::list::iterator * std::set::iterator * std::multiset::iterator * std::map::iterator * std::multimap::iterator * std::unordered_set::iterator * std::unordered_multiset::iterator * std::unordered_map::iterator * std::unordered_multimap::iterator Also remove duplicate registration for some printers. BUG=929992 R=thakis Change-Id: If925ad88e32e117488004e84533053244eae716a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559364 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#649397} third_party/libcxx-pretty-printers/printers.py | 44 ++++++++++++++------------ 1 file changed, 23 insertions(+), 21 deletions(-) commit 9491267fb63887bef49dd35d3153e3f5fc2e8538 Author: Pavel Yatsuk <pavely@google.com> Date: Wed Apr 10 03:21:13 2019 +0000 Reset mAppModalDialogView immediately in onDismiss before the next dialog is shown This change fixes a crash in PermissionDialogController (PDC). PDC.onDismiss() calls scheduleDisplay() which might pull next permission dialog from queue and create mAppModalDialogView for it. Later in onDismiss() it resets mAppModalDialogView to null. Dismissing this next dialog from native causes dereference of mAppModalDialogView resulting in exception. R=dominickn@chromium.org BUG=949771 Change-Id: I70fb7eeeb7d0139b49269de41a4a8a6065da1c3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560142 Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#649396} .../chromium/chrome/browser/permissions/PermissionDialogController.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit cf6e405c8b5205aecfff2877dc8d0c2a36a19225 Author: chrome-release-bot <chrome-release-bot@chromium.org> Date: Wed Apr 10 03:13:57 2019 +0000 Updating trunk VERSION from 3761.0 to 3762.0 # This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I22029296c9047777a657ce40cd3c466751afc12a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558903 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#649395} chrome/VERSION | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 1defcc76e6b666a70d21210f9cf92f19cb448109 Author: Noel Gordon <noel@chromium.org> Date: Wed Apr 10 03:07:18 2019 +0000 [piexwasm] test.js: write the test images into a DOM file system filesystem: urls can be fetched way faster than HTTP urls. To use them in test, create a DOM file system at start-up and copy the test images into that file system. The page under test provides the api calls: async window.createFileSystem(length) - create a DOM file system to hold |length| images. async window.writeToFileSystem(image) - write the given |image| to the DOM file system. and their implementation will be the subject of a follow-up patch. For details about DOM file system (a chrome-only API), suggest MDN search, or the spec https://dev.w3.org/2009/dap/file-system/pub/FileSystem. Bug: 935285 Change-Id: I7f5b78b6656e9dda19a9ae531826ffe542927003 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558838 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Reviewed-by: Alex Danilo <adanilo@chromium.org> Reviewed-by: Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#649394} ui/file_manager/image_loader/piex/tests.js | 15 +++++++++++++++ 1 file changed, 15 insertions(+) commit 34662d2e4d43bae6666162510a2aae3ebee04c4c Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Wed Apr 10 02:55:22 2019 +0000 Roll src-internal b75b3fcef932..9ce4d5d3cc11 (7 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b75b3fcef932..9ce4d5d3cc11 Created with: gclient setdep -r src-internal@9ce4d5d3cc11 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=huangs@chromium.org,battre@chromium.org,collinbaker@chromium.org,tasak@chromium.org Change-Id: I0fd8667545bd9022f8395169fa6e896466316404 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558974 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649393} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 96a29b06c56fae6e1163cb57cd8f78f58d81d3d2 Author: siyua <siyua@chromium.org> Date: Wed Apr 10 02:51:42 2019 +0000 [AF][Status Chip] Move profile avatar icon into the status chip. 1) Change protected by feature flag. 2) When feature is enabled, avatar icon will be added to the ToolbarPageActionIconContainer, otherwise it will be added to the ToolbarView as current implementation does. 3) Changed some getters to const Bug: 932818 Change-Id: I663c9002743c047d3535b47f5fb83bed61be98e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521978 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by: Peter Boström <pbos@chromium.org> Reviewed-by: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#649392} .../autofill/local_card_migration_browsertest.cc | 4 ++ .../autofill/save_card_bubble_views_browsertest.cc | 4 ++ chrome/browser/ui/views/frame/browser_view.cc | 2 +- .../profiles/profile_chooser_view_browsertest.cc | 53 ++++++++++++++++++---- .../toolbar_page_action_icon_container_view.cc | 7 +++ .../toolbar_page_action_icon_container_view.h | 4 ++ chrome/browser/ui/views/toolbar/toolbar_view.cc | 39 ++++++++++++---- chrome/browser/ui/views/toolbar/toolbar_view.h | 4 +- 8 files changed, 95 insertions(+), 22 deletions(-) commit 938c059773db19661f04122870636b47379d2929 Author: Michael Giuffrida <michaelpg@chromium.org> Date: Wed Apr 10 02:49:23 2019 +0000 Update KioskNext OWNERS Bug: None Change-Id: I444e640644b375023625366f1748d1a429e3468f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560752 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Auto-Submit: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#649391} ash/kiosk_next/OWNERS | 5 +++-- chrome/browser/chromeos/kiosk_next_home/OWNERS | 5 +++-- chrome/browser/resources/chromeos/kiosk_next_home/OWNERS | 3 +++ 3 files changed, 9 insertions(+), 4 deletions(-) commit 1b1c89d9d07d16f0ad4f848e410aa36dc3dcaf5f Author: Tom Anderson <thomasanderson@chromium.org> Date: Wed Apr 10 02:47:33 2019 +0000 libcxx-pretty-printers: Fix std::tuple and null std::{shared,weak}_ptr BUG=929992 R=thakis Change-Id: If7384005900dde08aa015f1745dfe726b02655b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560495 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#649390} third_party/libcxx-pretty-printers/printers.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) commit 4b26a2d3d06f48f46729d2da05d9eacbe0c26bfd Author: Ben Kelly <wanderview@chromium.org> Date: Wed Apr 10 02:44:01 2019 +0000 Add missing explicit to CachedMetadata constructor. This is a follow-on CL to crrev.com/c/1553388 to address additional review feedback from hiroshige@. Bug: 946676 Change-Id: I4c6c3be4687a2f135e6f6f4d880b04c614927ec3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560256 Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#649389} third_party/blink/renderer/platform/loader/fetch/cached_metadata.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 15d152cfed6a21ea9350af4a7192b1113da9eff0 Author: Austin Eng <enga@chromium.org> Date: Wed Apr 10 02:43:57 2019 +0000 Implement GPUTexture in Blink Bug: 877147 Change-Id: I3c547a4d62a6bf4b3328c08d7af3b1f005142dad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546057 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#649388} .../blink/renderer/modules/webgpu/gpu_texture.cc | 69 +++++++++++++++++++++- .../blink/renderer/modules/webgpu/gpu_texture.h | 6 +- .../blink/renderer/modules/webgpu/gpu_texture.idl | 3 + 3 files changed, 75 insertions(+), 3 deletions(-) commit 720e07b2b7f73f9a13b4b9bf792cc3026e479064 Author: Collin Baker <collinbaker@chromium.org> Date: Wed Apr 10 02:42:53 2019 +0000 Disable flaky test WebContentsImplBrowserTest.GetSizeForNewRenderView TBR=jam@chromium.org Bug: 951219 Change-Id: I6c2eca7544e3a0d9f32598d9531c424e889a8a57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559366 Reviewed-by: Collin Baker <collinbaker@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#649387} content/browser/web_contents/web_contents_impl_browsertest.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 78c631f9422c99cb0118aebfdf2e64d2cf2c21c6 Author: Mingyun Li <mekiali@chromium.org> Date: Wed Apr 10 02:42:49 2019 +0000 Log user type to UMA. Register a metrics provider which logs the user type when uploading UMA log, so the user type can be used as a filter. The implementation is same with Android (http://crrev/c/1535300) BUG=944726 Change-Id: I772f3d42de98f6595845a0794b8b85d33270333d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559402 Commit-Queue: Mingyun Li <mekiali@chromium.org> Reviewed-by: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#649386} ios/chrome/browser/metrics/BUILD.gn | 4 ++++ .../metrics/ios_chrome_metrics_service_client.mm | 4 ++++ .../metrics/ios_user_type_metrics_provider.h | 25 ++++++++++++++++++++++ .../metrics/ios_user_type_metrics_provider.mm | 23 ++++++++++++++++++++ .../browser/providers/chromium_browser_provider.h | 2 ++ .../browser/providers/chromium_browser_provider.mm | 6 ++++++ .../chrome/browser/user/special_user_provider.h | 2 ++ .../chrome/browser/user/special_user_provider.mm | 2 ++ 8 files changed, 68 insertions(+) commit d60f46bdb5b48702336441b31cc979b7138d4e74 Author: Maggie Cai <mxcai@chromium.org> Date: Wed Apr 10 02:41:46 2019 +0000 Hide the "remember my choice" checkbox for the intent picker on non-Chrome OS. Currently there is no way to persist choice for desktop PWAs, so do not show the remember my choice checkbox for non-Chrome OS desktop platforms. BUG=939205 Change-Id: I6f8ff8aa0944429669ded6fbe06c8070351b7ee0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548968 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: David Jacobo <djacobo@chromium.org> Cr-Commit-Position: refs/heads/master@{#649385} .../apps/intent_helper/apps_navigation_throttle.cc | 10 +- .../apps/intent_helper/apps_navigation_throttle.h | 3 + .../chromeos_apps_navigation_throttle.cc | 5 + .../chromeos_apps_navigation_throttle.h | 2 + .../intent_helper/arc_external_protocol_dialog.cc | 3 +- chrome/browser/ui/browser_window.h | 12 +- chrome/browser/ui/views/frame/browser_view.cc | 6 +- chrome/browser/ui/views/frame/browser_view.h | 3 +- .../browser/ui/views/intent_picker_bubble_view.cc | 186 +++++++++++---------- .../browser/ui/views/intent_picker_bubble_view.h | 13 +- .../ui/views/intent_picker_bubble_view_unittest.cc | 27 +-- chrome/browser/ui/views/toolbar/toolbar_view.cc | 5 +- chrome/browser/ui/views/toolbar/toolbar_view.h | 3 +- chrome/test/base/test_browser_window.h | 3 +- 14 files changed, 162 insertions(+), 119 deletions(-) commit 094a1d4f409710d5080de10f47ed834e06d48e8a Author: Marcin Wiącek <marcin@mwiacek.com> Date: Wed Apr 10 02:41:43 2019 +0000 Share code with TimeUtils in the ContextualSearchPanelMetrics.java Use time conversion variable defined with https://chromium-review.googlesource.com/c/chromium/src/+/1444831 Change-Id: Ibd6c254d72f8e1daa9f2adbec1d110bb6956da63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554355 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#649384} .../ContextualSearchPanelMetrics.java | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) commit 6f44da0471a054d1957db5e87a06a7e46c6d1df0 Author: Hirokazu Honda <hiroh@chromium.org> Date: Wed Apr 10 02:40:42 2019 +0000 media/gpu/v4l2: Correct a wrong queue name in comments I called wrong names v4l2 queues previously, VIDIOC_OUTPUT and VIDIOC_CAPTURE. They would rather be called VIDEO_OUTPUT and VIDEO_CAPTURE. Bug: None Test: None Change-Id: I5f616fdb54acf8a0fbf6703de6990d89a0f47669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556868 Auto-Submit: Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#649383} media/gpu/v4l2/v4l2_slice_video_decode_accelerator.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit a6c55d8f86afe4858fcef8786d92fc0f0ff53a86 Author: Stephen Martinis <martiniss@chromium.org> Date: Wed Apr 10 02:40:38 2019 +0000 Enable test results merging for coverage bots This CL re-uses the test results logic already present in existing merge scripts. It currently doesn't work for layout tests, because they need their own custom script. I'll add support for that in a follow up CL. gtests and other json test results tests should work fine. Bug: 923711 Change-Id: Ica847dbcf1cc0279fd416accbd3ca1b43b40d16d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526790 Reviewed-by: John Budorick <jbudorick@chromium.org> Reviewed-by: Yuke Liao <liaoyuke@chromium.org> Reviewed-by: Roberto Carrillo <robertocn@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#649382} .../merge_scripts/code_coverage/merge_profiles.py | 68 +--------------- .../merge_scripts/code_coverage/merge_results.py | 93 ++++++++++++++++++++++ ...erge_profiles_test.py => merge_results_test.py} | 0 3 files changed, 94 insertions(+), 67 deletions(-) commit d37e52247657f438afc1f3de3cb7a6d9fd2e4906 Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Wed Apr 10 02:39:37 2019 +0000 Update V8 to version 7.5.228. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/59a29d88..a1fea4b4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I722fedb7c9eca87c360f3cf0c97fe8b3f7bbe7f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558703 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649381} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit f3df18a363d431bebdc0065fdd584e71c53c3c95 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 10 02:39:33 2019 +0000 Roll src/third_party/skia ff4fb3335bb7..2655ede7c9f9 (3 commits) https://skia.googlesource.com/skia.git/+log/ff4fb3335bb7..2655ede7c9f9 git log ff4fb3335bb7..2655ede7c9f9 --date=short --no-merges --format='%ad %ae %s' 2019-04-10 egdaniel@google.com Revert "Add non-AA support to OvalFactoryOps." 2019-04-09 kjlubick@google.com Move common canvas/pathkit dockerfiles to more intuitive location 2019-04-09 jvanverth@google.com Add non-AA support to OvalFactoryOps. Created with: gclient setdep -r src/third_party/skia@2655ede7c9f9 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: If031f6e46e6947b9c89f0354dfa236dd00325d8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558972 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649380} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit c2532a7f1c37f2197a7a8d72a9fd410a3be9afe9 Author: Matt Reynolds <mattreynolds@google.com> Date: Wed Apr 10 02:38:33 2019 +0000 Move haptic actuators to NavigatorGamepad Previously, the haptic actuator associated with a Gamepad was held as a member of the Gamepad object itself. The GamepadHapticActuator object retains some internal state that must be preserved when gamepad buffers are swapped. This introduced unnecessary complexity when swapping that could be avoided by separating the state received from the device from the internal state retained by the renderer. This CL moves the GamepadHapticActuator objects to NavigatorGamepad and allows a Gamepad object to fetch the actuator when it is needed. Because the actuator is now retained by only one object, initialization can be delayed until it is first accessed. As a side effect of this change, the vibration actuator for a disconnected gamepad can no longer be accessed. This also allows devices that initialize their haptics capabilities late to correctly propagate the change. The capabilities change may not be observable until some other gamepad state changes (e.g., a button is pressed). BUG=948397 Change-Id: I91798515393613eef9f1856a5ba0a08f1627fd38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548786 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#649379} .../blink/renderer/modules/gamepad/gamepad.cc | 34 ++-- .../blink/renderer/modules/gamepad/gamepad.h | 24 ++- .../renderer/modules/gamepad/navigator_gamepad.cc | 219 ++++++++++----------- .../renderer/modules/gamepad/navigator_gamepad.h | 13 +- .../blink/web_tests/gamepad/gamepad-vibration.html | 31 ++- 5 files changed, 164 insertions(+), 157 deletions(-) commit 9d78513faaeef090eb42c368665d1e3d0f67a18f Author: Manu Cornet <manucornet@chromium.org> Date: Wed Apr 10 02:38:31 2019 +0000 CrOS Shelf: Make tooltip preview bubbles not activatable This follows the same pattern as the simpler |ShelfTooltipBubble| class uses. These bubbles/widgets don't actually need to be activated. Making them not activatable prevents a crash stemming from a bad interaction between the "close on deactivate" behavior and the |ShelfTooltipManager|'s manual handling of when bubbles/tooltips are closed. Bug: 941183, 937504 Change-Id: I8ac5e949ff89540fbeb01cbb0779394d414a7cd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559131 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#649378} ash/shelf/shelf_tooltip_preview_bubble.cc | 2 ++ 1 file changed, 2 insertions(+) commit 7dffea0baf77a4242634da40d3df8c567bcd51ec Author: Stephen McGruer <smcgruer@chromium.org> Date: Wed Apr 10 02:37:27 2019 +0000 Ship AnimationEffect and part of KeyframeEffect This ships AnimationEffect plus the KeyframeEffect interface and 'target' member. It does not ship either getKeyframes/setKeyframes or composite/iterationComposite. The former is not shipped because our implementation has bugs that would cause web-compat problems (crbug.com/816956), the latter is not shipped because the spec for it has not yet settled. Intent to ship thread (with 3x LGTM): https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer#!msg/blink-dev/1EQKF7il48U/BJWTPiqwBgAJ Bug: 948253 Change-Id: I8c86220d28e1e81ee764fac7a11d95a685f17684 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553447 Reviewed-by: Kent Tamura <tkent@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Reviewed-by: Majid Valipour <majidvp@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#649377} .../blink/public/mojom/web_feature/web_feature.mojom | 2 ++ third_party/blink/renderer/core/animation/animation.idl | 4 ++-- .../blink/renderer/core/animation/animation_effect.idl | 5 ++--- .../blink/renderer/core/animation/keyframe_effect.idl | 12 ++++++------ .../interfaces/Animation/style-change-events-expected.txt | 4 ++-- .../stable/webexposed/global-interface-listing-expected.txt | 13 +++++++++++++ tools/metrics/histograms/enums.xml | 2 ++ 7 files changed, 29 insertions(+), 13 deletions(-) commit 0f284fd66c5531d73d0c108f9989163601747e70 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 10 02:37:24 2019 +0000 Roll src/third_party/catapult 1186c84261e1..f8d4d2df5377 (1 commits) https://chromium.googlesource.com/catapult.git/+log/1186c84261e1..f8d4d2df5377 git log 1186c84261e1..f8d4d2df5377 --date=short --no-merges --format='%ad %ae %s' 2019-04-09 rmhasan@google.com Reland "[Typ] Adds new methods to the API of TestSet and runner.py" Created with: gclient setdep -r src/third_party/catapult@f8d4d2df5377 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:945481 TBR=skyostil@chromium.org Change-Id: I6cc04d71d5e0939f5665d936f062e55ffb9e2e2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560189 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649376} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 56bfa785ffcc934db79e236bd3fd1b63d6819b91 Author: John Budorick <jbudorick@chromium.org> Date: Wed Apr 10 02:36:21 2019 +0000 Run resource_sizes as an isolated script on android. Bug: 807273 Change-Id: Ie5ec9a4c6529ebacf66eec30df662b5fc22f0444 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554184 Reviewed-by: Paul Jensen <pauljensen@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#649375} build/android/resource_sizes.gni | 37 +++++++++++ build/android/resource_sizes.py | 115 +++++++++++++++++++++------------ build/util/generate_wrapper.gni | 4 ++ components/cronet/android/BUILD.gn | 5 ++ testing/buildbot/chromium.android.json | 27 ++++++++ testing/buildbot/gn_isolate_map.pyl | 8 +++ testing/buildbot/test_suites.pyl | 8 +++ testing/buildbot/waterfalls.pyl | 3 + tools/mb/mb.py | 8 +++ 9 files changed, 175 insertions(+), 40 deletions(-) commit 8540115ad0a323aadf15cd262ba2dc6e93bb59c9 Author: dpapad <dpapad@chromium.org> Date: Wed Apr 10 02:36:18 2019 +0000 File Manager: Convert more cr.EventTarget subclasses to ES6 class syntax. - quick_view_model.js - search_box.js (only converted SearchBox class) This is in preparation of removing the custom cr.EventTarget implementation in favor of native EventTarget, which requires all subclasses to be ES6 classes, otherwise a runtime "Illegal invocation" error is thrown. Bug: 854268,778674 Change-Id: I29c7577d31f846e07a6733f3a721ca399c617d1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560299 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#649374} .../file_manager/foreground/js/quick_view_model.js | 49 ++- .../file_manager/foreground/js/ui/search_box.js | 345 ++++++++++----------- 2 files changed, 194 insertions(+), 200 deletions(-) commit af0f5942847d30a31558776d773285258afda9c3 Author: Michael Giuffrida <michaelpg@chromium.org> Date: Wed Apr 10 02:35:15 2019 +0000 Prevent KioskNextHome from opening twice The app can be launched from the shelf icon, which creates a second instance. Use a window id to ensure there is only ever one window open. Bug: 951180 Change-Id: I9b00fff9d3c5c5502ec923a3d1ea1721dd421920 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558705 Auto-Submit: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#649373} chrome/browser/resources/chromeos/kiosk_next_home/bg.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit 1f6c50f752d121818c92c07b85dae3e0b4abaeac Author: Manu Cornet <manucornet@chromium.org> Date: Wed Apr 10 02:35:12 2019 +0000 CrOS Shelf: Change shelf/systray focus border color This change was requested by UX for better contrast (see linked bug). Bug: 884799 Change-Id: I31499064ae8ac0b6002b76ff635d666e9b3c99b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559132 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#649372} ash/shelf/shelf_button.cc | 5 +++-- ash/shelf/shelf_constants.h | 2 ++ ash/shelf/shelf_control_button.cc | 2 +- ash/system/tray/tray_background_view.cc | 2 +- 4 files changed, 7 insertions(+), 4 deletions(-) commit d443dfb4a52fa07c3c478c4fb2343c6d53099034 Author: Jeremy Roman <jbroman@chromium.org> Date: Wed Apr 10 01:43:40 2019 +0000 Update UI strings to refer to "Google LLC" instead of "Google Inc." Bug: 928220 Change-Id: Ie46c21a128f725aebaea978bc61bf1f1641dd1fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558451 Reviewed-by: Greg Thompson <grt@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#649371} chrome/android/java/strings/android_chrome_strings.grd | 2 +- chrome/app/google_chrome_strings.grd | 4 ++-- ios/chrome/app/strings/ios_google_chrome_strings.grd | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) commit 61cf4a49bf6623954b1f2b1514e55c198b4ca7bd Author: Toni Barzic <tbarzic@chromium.org> Date: Wed Apr 10 01:40:21 2019 +0000 Unit tests for recommend_apps_fetcher_impl BUG=947203 Change-Id: I78462aa67c51241da10cafcf9e5e6ea7728fe3d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555573 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#649370} chrome/browser/chromeos/BUILD.gn | 4 + chrome/browser/chromeos/DEPS | 1 + .../fake_recommend_apps_fetcher_delegate.cc | 50 + .../fake_recommend_apps_fetcher_delegate.h | 66 + .../recommend_apps/recommend_apps_fetcher.cc | 16 +- .../recommend_apps/recommend_apps_fetcher.h | 6 +- .../recommend_apps_fetcher_delegate.h | 31 + .../recommend_apps/recommend_apps_fetcher_impl.cc | 61 +- .../recommend_apps/recommend_apps_fetcher_impl.h | 28 +- .../recommend_apps_fetcher_impl_unittest.cc | 1386 ++++++++++++++++++++ .../login/screens/recommend_apps_screen.cc | 17 +- .../chromeos/login/screens/recommend_apps_screen.h | 13 +- .../screens/recommend_apps_screen_browsertest.cc | 19 +- 13 files changed, 1647 insertions(+), 51 deletions(-) commit c1fb612bd3de2cf5d2a1879359d7e0fed68fa811 Author: Alexander Alekseev <alemate@chromium.org> Date: Wed Apr 10 01:38:42 2019 +0000 Chrome OS: Add more c/b/r/c/login/ sources to webui_closure_compile target. This adds 39 files of c/b/r/c/login/*.js to webui_closure_compilation target. Changes are cosmetic. DISPLAY_TYPE enum is moved form display_manager.js to display_manager_types.js. Added obvious JSDoc function specifications. Should not affect the behavior. Bug: 949823 Change-Id: I8c68575340980a52704ac373d49e33cf342124ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554042 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#649369} chrome/browser/resources/chromeos/login/BUILD.gn | 273 ++++++++- .../login/active_directory_password_change.js | 7 +- .../chromeos/login/arc_terms_of_service.js | 7 +- .../resources/chromeos/login/demo_preferences.js | 27 +- .../chromeos/login/encryption_migration.js | 2 +- .../browser/resources/chromeos/login/fake_oobe.js | 3 + .../resources/chromeos/login/fingerprint_setup.js | 9 +- .../resources/chromeos/login/gaia_buttons.js | 18 +- .../browser/resources/chromeos/login/gaia_input.js | 14 +- .../resources/chromeos/login/gaia_input_form.js | 13 +- .../chromeos/login/gaia_password_changed.js | 7 + .../browser/resources/chromeos/login/html-echo.js | 4 + .../resources/chromeos/login/navigation_bar.js | 5 + .../chromeos/login/network_select_login.js | 651 +++++++++++---------- .../resources/chromeos/login/notification_card.js | 20 +- .../resources/chromeos/login/offline_gaia.js | 13 +- .../resources/chromeos/login/oobe_dialog.js | 1 + .../browser/resources/chromeos/login/oobe_eula.js | 9 +- .../resources/chromeos/login/oobe_i18n_dropdown.js | 8 +- .../resources/chromeos/login/oobe_network.js | 3 + .../browser/resources/chromeos/login/oobe_types.js | 2 +- .../resources/chromeos/login/recommend_apps.js | 6 +- .../resources/chromeos/login/saml_interstitial.js | 1 + .../login/unrecoverable_cryptohome_error_card.js | 1 + ui/login/display_manager.js | 13 - ui/login/display_manager_types.js | 15 + ui/webui/resources/js/i18n_behavior.js | 4 +- 27 files changed, 745 insertions(+), 391 deletions(-) commit 227ef6de5358902a8e531946fb887c87332e73ac Author: Kenneth Russell <kbr@chromium.org> Date: Wed Apr 10 01:34:47 2019 +0000 Dawn/Mac CI bots: define bots. Finish setting up this entire set on the chromium.dawn waterfall: Dawn Mac x64 Builder Dawn Mac x64 Release (AMD) Dawn Mac x64 Release (Intel) Dawn Mac x64 DEPS Builder Dawn Mac x64 DEPS Release (AMD) Dawn Mac x64 DEPS Release (Intel) Bug: 948902 Change-Id: I6a62c4ba4e137b89bae43a08edb6248d36a01b09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560255 Reviewed-by: Stephen Martinis <martiniss@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#649368} infra/config/cr-buildbucket.cfg | 38 +++++++--- infra/config/luci-milo.cfg | 40 ++++++++--- infra/config/luci-scheduler.cfg | 44 ++++++++++++ testing/buildbot/chromium.dawn.json | 136 ++++++++++++++++++++++++++++++++++++ testing/buildbot/waterfalls.pyl | 33 +++++++++ tools/mb/mb_config.pyl | 1 + 6 files changed, 271 insertions(+), 21 deletions(-) commit 829d14695bd787c47f819919b4fc92bf1a302f92 Author: Peter K. Lee <pkl@chromium.org> Date: Wed Apr 10 01:34:18 2019 +0000 Adds missing category implementations for UIFont MDC added some UIFont+ categories, but the implementation files were not included in the BUILD.gn file. This resulted in a crash. Bug: 950920 Change-Id: I75c00a78b036b9da925010df8c89add6b800f3e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560463 Reviewed-by: Sergio Collazos <sczs@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#649367} ios/third_party/material_components_ios/BUILD.gn | 4 ++++ 1 file changed, 4 insertions(+) commit 769fac52585f2813794fc865f3a4eec871e64842 Author: dpapad <dpapad@chromium.org> Date: Wed Apr 10 01:33:17 2019 +0000 Settings a11y page: Fix toggle button erroneously showing over subpage. When a settings section has a subpage (which is the case for CrOS chrome://settings/accessibility), the section's default content should reside within the "default" div. Bug: 950467 Change-Id: I009e2b5a9a21553665f083f837e9394a57c93c1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560455 Reviewed-by: Dan Beam <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#649366} .../resources/settings/a11y_page/a11y_page.html | 24 ++++++++++++++-------- 1 file changed, 16 insertions(+), 8 deletions(-) commit ec8d90df733a91dabeba493ac687e0db87dbe827 Author: Eliot Courtney <edcourtney@google.com> Date: Wed Apr 10 01:33:10 2019 +0000 End SplitView mode upon expanding a PIP window. According to UX, we should end SplitView mode upon expanding a PIP window. Bug: 941788 Test: added unit test Change-Id: I7249f2b49e7709a7da54425f0420445ecd9d6bab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551737 Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#649365} ash/wm/splitview/split_view_controller.h | 2 + ash/wm/tablet_mode/tablet_mode_window_manager.cc | 1 + components/exo/client_controlled_shell_surface.cc | 4 +- .../client_controlled_shell_surface_unittest.cc | 72 ++++++++++++++++++++++ 4 files changed, 78 insertions(+), 1 deletion(-) commit 717fdb98a35e2f8ef826351f07d9f9a58f1771de Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Wed Apr 10 01:29:27 2019 +0000 Roll src-internal 6e6256a3131d..b75b3fcef932 (3 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6e6256a3131d..b75b3fcef932 Created with: gclient setdep -r src-internal@b75b3fcef932 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=huangs@chromium.org,battre@chromium.org,collinbaker@chromium.org,tasak@chromium.org Change-Id: I6a055fffb27cb916459726de93565f91d42d4de8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560400 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649364} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 8ca9debec8484ebfede35c80fc3f6976fa66c160 Author: Joshua Peraza <jperaza@chromium.org> Date: Wed Apr 10 01:28:07 2019 +0000 Update Crashpad to cc0c2f90df7e1abbd37efb86563a5458fcc305ea cc0c2f90df7e Add lss to third_party and use sys_getpid() Also update tools/licenses.py with a special cases entry for lss. Crashpad's lss is only used in the external build. When building in Chromium, Crashpad uses Chromium's third_party/lss which has its own special cases entry. Bug: crashpad:265 Change-Id: I0774b560f363f58cbfe0f17aca8a8b307888b791 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558683 Reviewed-by: Mark Mentovai <mark@chromium.org> Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#649363} third_party/crashpad/README.chromium | 2 +- third_party/crashpad/crashpad/DEPS | 3 +++ third_party/crashpad/crashpad/client/BUILD.gn | 10 ++++++- third_party/crashpad/crashpad/client/client.gyp | 1 + .../crashpad/client/crashpad_client_linux.cc | 3 ++- .../crashpad/crashpad/third_party/lss/BUILD.gn | 31 ++++++++++++++++++++++ .../crashpad/third_party/lss/README.crashpad | 16 +++++++++++ .../crashpad/crashpad/third_party/lss/lss.gyp | 27 +++++++++++++++++++ .../crashpad/crashpad/third_party/lss/lss.h | 26 ++++++++++++++++++ tools/licenses.py | 7 +++++ 10 files changed, 123 insertions(+), 3 deletions(-) commit f22dec0e63baacba87ecf61f709dfaa44eb5a9c8 Author: Joel Hockey <joelhockey@chromium.org> Date: Wed Apr 10 01:19:54 2019 +0000 Add plugin_vm IsPluginVmEnabled IsPluginVmEnabled checks IsPluginVmAllowedForProfile and IsPluginVmConfigured. Added constant kPluginVmName = "PluginVm". Bug: 946273 Change-Id: I5be1ae26030f4d31c5fdfee9bf6ec2643a1ea6eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553043 Reviewed-by: Alex Oldemeier <aoldemeier@chromium.org> Reviewed-by: Timothy Loh <timloh@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#649362} .../chromeos/extensions/file_manager/private_api_strings.cc | 6 ++---- chrome/browser/chromeos/plugin_vm/plugin_vm_util.cc | 4 ++++ chrome/browser/chromeos/plugin_vm/plugin_vm_util.h | 7 +++++++ chrome/browser/ui/app_list/internal_app/internal_app_metadata.cc | 2 +- 4 files changed, 14 insertions(+), 5 deletions(-) commit 2a6d91edeecb3705140d2a6ba261f5f28ef8f839 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 10 01:16:52 2019 +0000 Roll src/third_party/chromite 9a5d312903e2..a903c04a7e50 (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/9a5d312903e2..a903c04a7e50 git log 9a5d312903e2..a903c04a7e50 --date=short --no-merges --format='%ad %ae %s' 2019-04-10 dhanyaganesh@chromium.org Add 'inflight' to the list of NON_FAILURE_STATUSES Created with: gclient setdep -r src/third_party/chromite@a903c04a7e50 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I6a5969e2a27bfbf51b98b17cfd8c099b415fb1c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560408 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649361} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 63c8aa2f4e8dff67bee6856efc51f12b01f8605b Author: Joel Einbinder <einbinder@chromium.org> Date: Wed Apr 10 01:05:01 2019 +0000 DevTools: Wait for all scripts to load in inspector protocol tests inspector-protocol tests using startHTML were not properly awaiting for external scripts to finish executing, causing them to be flaky. Bug: 943969 Change-Id: I8a24435bc19292b8c75fafabca00fb5bbe22d5ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558563 Commit-Queue: Joel Einbinder <einbinder@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#649360} third_party/blink/web_tests/TestExpectations | 4 ---- .../resources/inspector-protocol-test.js | 19 ++++++++++++++++++- 2 files changed, 18 insertions(+), 5 deletions(-) commit d5bc4c0e405b5509a7033fb05efe52c975b7d8a6 Author: Nicholas Verne <nverne@chromium.org> Date: Wed Apr 10 01:03:44 2019 +0000 Only show Usb sharing notifications when Crostini is enabled. If other guest OSes are supported in future, we will refine this rule. Bug: 948913 Change-Id: I2fb3db1a6cb690237a2c6896826311e895862531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559412 Commit-Queue: Nicholas Verne <nverne@chromium.org> Auto-Submit: Nicholas Verne <nverne@chromium.org> Reviewed-by: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#649359} chrome/browser/chromeos/usb/cros_usb_detector.cc | 6 ++++-- chrome/browser/chromeos/usb/cros_usb_detector_unittest.cc | 7 +++++++ 2 files changed, 11 insertions(+), 2 deletions(-) commit 53eff102e8f99e6a33785d073e7adedc71455b50 Author: Bo Liu <boliu@chromium.org> Date: Wed Apr 10 00:57:11 2019 +0000 Mark all webview pixel tests as RetryOnFailure WebView triggers a driver bug that crashes sometimes. So mark all tests as flaky. Bug: 950932 Change-Id: I1cd59077975482b5889ce4f2c7b7325be64906bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559768 Commit-Queue: Bo <boliu@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Bo <boliu@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#649358} content/test/gpu/gpu_tests/test_expectations/pixel_expectations.txt | 3 +++ 1 file changed, 3 insertions(+) commit 5b3f81fa3882a7bce84ee9a61286cbc8880a0011 Author: Lei Zhang <thestig@chromium.org> Date: Wed Apr 10 00:54:58 2019 +0000 Remove else-if after return in ChromeContentBrowserClient. Do the same for AwContentBrowserClient. Change-Id: I48be536b9b5aec28f1ad08172b4ab64d041469f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560461 Reviewed-by: Tao Bai <michaelbai@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#649357} android_webview/browser/aw_content_browser_client.cc | 8 ++++---- chrome/browser/chrome_content_browser_client.cc | 20 ++++++++++---------- 2 files changed, 14 insertions(+), 14 deletions(-) commit 700d778298c740bcc03c5048d520d307d58d4829 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 10 00:43:45 2019 +0000 Roll src/third_party/catapult 4689063021d2..1186c84261e1 (1 commits) https://chromium.googlesource.com/catapult.git/+log/4689063021d2..1186c84261e1 git log 4689063021d2..1186c84261e1 --date=short --no-merges --format='%ad %ae %s' 2019-04-09 benjhayden@chromium.org Replace tr.b.GUID.allocateSimple in spa Created with: gclient setdep -r src/third_party/catapult@1186c84261e1 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:950011 TBR=skyostil@chromium.org Change-Id: I0ab73aa49af3d34cd98ffcfbb02b7d914b9203d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560404 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649356} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 0ee09a046359e9ef75d8a81b5b8e0d18756af5b2 Author: Scott Violet <sky@chromium.org> Date: Wed Apr 10 00:38:27 2019 +0000 views: removal of dead code in NativeViewHost NativeViewHost has code to deal with being clipped by an ancestor. This logic dates back to when we used NativeViewHost more often, and in particular when NativeViewHost was contained in a ScrollView. AFAIK we no longer have this scenario, so, this removes the unnecessary logic. BUG=none TEST=covered by tests Change-Id: I7b1a9ba047bd7c4abab68f9fe49c651bf50209d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560130 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#649355} ui/views/controls/native/native_view_host.cc | 20 +---------- ui/views/controls/native/native_view_host.h | 8 ----- ui/views/controls/native/native_view_host_aura.cc | 19 +++------- ui/views/controls/native/native_view_host_aura.h | 5 ++- .../native/native_view_host_aura_unittest.cc | 42 ---------------------- ui/views/controls/native/native_view_host_mac.h | 2 -- ui/views/controls/native/native_view_host_mac.mm | 8 ----- .../controls/native/native_view_host_wrapper.h | 12 +------ 8 files changed, 9 insertions(+), 107 deletions(-) commit 8204d68f563c1467cfd44307682822289cc406ca Author: Matt Reynolds <mattreynolds@google.com> Date: Wed Apr 10 00:34:37 2019 +0000 Use PermissionBrokerClient to access gamepads on Chrome OS For some gamepad devices, Chrome supports haptic effects by writing to the raw HID device node. On Linux-based OSes, the raw HID device node is not writable by default. Chrome OS provides an alternate way to request access to the raw HID device node using the PermissionBrokerClient. This CL lets Chrome use PermissionBrokerClient as a fallback on Chrome OS when the permissions on the device node are insufficient. BUG=948397 Change-Id: Ic5c1d647c0c8fdffc5459e1bc7ba4449a55303b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1550014 Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#649354} device/gamepad/BUILD.gn | 4 + device/gamepad/DEPS | 1 + device/gamepad/gamepad_device_linux.cc | 102 +++++++++++++++++++-- device/gamepad/gamepad_device_linux.h | 34 ++++++- device/gamepad/gamepad_platform_data_fetcher.h | 3 +- .../gamepad/gamepad_platform_data_fetcher_linux.cc | 59 +++++++++--- .../gamepad/gamepad_platform_data_fetcher_linux.h | 24 ++++- 7 files changed, 198 insertions(+), 29 deletions(-) commit 9a6fe11a5921e6792bcb0c2805d30e1c127eb78b Author: Fabrice de Gans-Riberi <fdegans@chromium.org> Date: Wed Apr 10 00:34:07 2019 +0000 [fuchsia] Remove unused source files. * not_implemented_api_bindings.cc was not used anywhere. * Update two callers of Frame.ExecuteJavascript() with ON_PAGE_LOAD to use the new Frame.AddJavascriptBindings() API. Change-Id: I32126315c980ebfea0f3bc80a80ed430ddd8f092 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560447 Reviewed-by: Wez <wez@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#649353} fuchsia/runners/BUILD.gn | 2 -- fuchsia/runners/cast/cast_component.cc | 7 +++-- fuchsia/runners/cast/cast_platform_bindings_ids.h | 1 + .../runners/cast/not_implemented_api_bindings.cc | 32 ---------------------- .../runners/cast/not_implemented_api_bindings.h | 17 ------------ .../not_implemented_api_bindings_browsertest.cc | 7 +++-- 6 files changed, 9 insertions(+), 57 deletions(-) commit 44eba93fe5df0b2f10d5564ee7ca2247827f8f77 Author: Brian Sheedy <bsheedy@chromium.org> Date: Wed Apr 10 00:32:30 2019 +0000 Move Feed data inclusion from VR to XR Moves the inclusion of data necessary for the Feed feature in tests from the VR Java test library to the XR Java test library since both AR and VR tests need the files. Bug: 951065 Change-Id: Ib831e606bdbe22609c651e896cb2cbe5af9d9b7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560445 Reviewed-by: Brandon Wylie <wylieb@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#649352} chrome/android/BUILD.gn | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit fa3b0e04b47c43672d8c9461804d8da5e1b67ee3 Author: Nate Fischer <ntfschr@chromium.org> Date: Wed Apr 10 00:30:26 2019 +0000 AW docs: add instructions to get adb into path I deleted these instructions in http://crrev/c/1552570, but then I realized we had later steps which advise using 'adb'. This adds the instructions back for how to add adb to the $PATH, but moves them to the relevant section. Bug: 918221 Test: Upload to gerrit > open file > click "gitiles" Change-Id: I737a35b9389b99b717e5242644f1d813696567ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560313 Reviewed-by: Shimi Zhang <ctzsm@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#649351} android_webview/docs/quick-start.md | 4 ++++ 1 file changed, 4 insertions(+) commit f40e6c58ca46fe11f7033ad651b9160ba4b85da0 Author: John Budorick <jbudorick@chromium.org> Date: Wed Apr 10 00:28:01 2019 +0000 sizes: remove prefix positional arg. Has been unused since crrev.com/c/1269104 Bug: 861983 Change-Id: Iaa297fcfb1f7b2e7ec294eaac661724859e80aab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560459 Reviewed-by: Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#649350} testing/scripts/sizes_common.py | 1 - 1 file changed, 1 deletion(-) commit 7debc719bb9776c72ae0922022140d8b80689058 Author: Brandon Wylie <wylieb@chromium.org> Date: Wed Apr 10 00:27:58 2019 +0000 [Image Fetcher] Move image_decoder_impl under c/b/image_fetcher This class was added under search/suggestions for convenience. Now that we have the image_fetcher directory, moving it there as the decoder is logically associated with image fetching. Bug: 624761 Change-Id: Ie5356cf784c68e73a955df8352534fd6d8bbc450 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542497 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Reviewed-by: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#649349} chrome/browser/BUILD.gn | 4 +-- .../explore_sites_bridge_experimental.cc | 4 +-- .../browser/favicon/large_icon_service_factory.cc | 4 +-- .../image_decoder_impl.cc | 11 ++----- .../image_decoder_impl.h | 13 ++------ .../image_fetcher_impl_browsertest.cc | 12 +++----- .../image_fetcher/image_fetcher_service_factory.cc | 36 ++++++++++------------ .../image_fetcher/image_fetcher_service_factory.h | 8 ++--- .../content_suggestions_service_factory.cc | 3 +- .../ntp_tiles/chrome_most_visited_sites_factory.cc | 4 +-- .../downloads/offline_page_download_bridge.cc | 4 +-- .../offline_pages/android/prefetch_test_bridge.cc | 4 +-- .../prefetch/prefetch_service_factory.cc | 6 ++-- .../offline_pages/thumbnail_decoder_impl.cc | 1 + .../browser/offline_pages/thumbnail_decoder_impl.h | 5 ++- chrome/browser/search/ntp_icon_source.cc | 4 +-- .../suggestions/suggestions_service_factory.cc | 1 - .../search_provider_logos/logo_service_factory.cc | 4 +-- chrome/browser/signin/identity_manager_factory.cc | 8 ++--- chrome/browser/ui/webui/ntp_tiles_internals_ui.cc | 1 - chrome/test/BUILD.gn | 2 +- 21 files changed, 60 insertions(+), 79 deletions(-) commit 80cde0abd4e5697e92ff8bdc87e7d20b81c4e4fe Author: Suman Kancherla <sumankancherla@chromium.org> Date: Wed Apr 10 00:24:55 2019 +0000 [ui/vr] Fixed UX strings to reflect changes to PRD The fixes are: * correctly capitalize acronyms * fix non-responsive change prompt Also, cleaned up ids to be build specific Bug: 950291, 951055 Change-Id: I6a2bd43660008ef48d6439c37648d93921cd1b52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557748 Commit-Queue: Suman Kancherla <sumankancherla@chromium.org> Reviewed-by: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#649348} chrome/app/vr_strings.grdp | 51 ++++++++++++++-------- .../IDS_VR_SHELL_SITE_CAN_USE_BLUETOOTH.png.sha1 | 1 + .../IDS_VR_SHELL_SITE_CAN_USE_MIDI.png.sha1 | 2 +- .../IDS_VR_SHELL_SITE_IS_USING_BLUETOOTH.png.sha1 | 1 + .../IDS_VR_SHELL_SITE_IS_USING_MIDI.png.sha1 | 2 +- .../IDS_VR_SHELL_SITE_IS_USING_USB.png.sha1 | 2 +- chrome/browser/vr/elements/indicator_spec.cc | 4 ++ chrome/browser/vr/ui_unittest.cc | 4 +- 8 files changed, 43 insertions(+), 24 deletions(-) commit f40c4f3bec81d841c9136fc25ace8e65fc9c3a68 Author: Ken MacKay <kmackay@chromium.org> Date: Wed Apr 10 00:22:03 2019 +0000 [Chromecast] Remove shim threads Mutex priority inheritance is enabled, so shim threads aren't needed anymore. Bug: internal b/129965245 Change-Id: Ie59a8e0896f1359caa91d734018a501605340585 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553389 Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Reviewed-by: Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#649347} .../media/cma/backend/buffering_mixer_source.cc | 26 ++-- .../media/cma/backend/buffering_mixer_source.h | 1 - chromecast/media/cma/backend/stream_mixer.cc | 157 ++++++++------------- chromecast/media/cma/backend/stream_mixer.h | 47 +----- .../media/cma/backend/stream_mixer_unittest.cc | 41 +++--- 5 files changed, 84 insertions(+), 188 deletions(-) commit 4d71c399c2cfe34f45114e13ba83e293122ecf2c Author: Peter Boström <pbos@chromium.org> Date: Wed Apr 10 00:21:04 2019 +0000 Add extension pop-out to Extension menu This changes ExtensionActionViewController to be aware of a main ToolbarActionsBar, which it asks directly in ::GetPreferredPopupViewController() instead of delegating into the owner's ::GetMainControllerForAction(), which is now gone. Separating the main bar from the owning bar allows ExtensionMenuView to make use of it even though it's not a ToolbarActionsBar. Bug: chromium:943702 Change-Id: I63e735cf318f2e2c9559397669d2498b94a6190e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549892 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#649346} .../extensions/extension_action_view_controller.cc | 76 +++++++++------------- .../extensions/extension_action_view_controller.h | 20 +++--- chrome/browser/ui/toolbar/toolbar_actions_bar.cc | 23 +++---- chrome/browser/ui/toolbar/toolbar_actions_bar.h | 12 ++-- chrome/browser/ui/toolbar/toolbar_actions_model.cc | 18 +++-- chrome/browser/ui/toolbar/toolbar_actions_model.h | 6 +- .../ui/views/extensions/extensions_menu_view.cc | 13 ++-- .../ui/views/extensions/extensions_menu_view.h | 11 +++- .../views/extensions/extensions_toolbar_button.cc | 7 +- .../views/extensions/extensions_toolbar_button.h | 4 +- chrome/browser/ui/views/toolbar/toolbar_view.cc | 6 +- 11 files changed, 104 insertions(+), 92 deletions(-) commit aabcd1437dc8dd11a12c958adcafdde424608445 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 10 00:20:55 2019 +0000 Roll src/third_party/webrtc 2af5dcbe9ec3..f4770401dc29 (1 commits) https://webrtc.googlesource.com/src.git/+log/2af5dcbe9ec3..f4770401dc29 git log 2af5dcbe9ec3..f4770401dc29 --date=short --no-merges --format='%ad %ae %s' 2019-04-09 amithi@webrtc.org Reland "Adding a restriction for legal RID values." Created with: gclient setdep -r src/third_party/webrtc@f4770401dc29 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib63e9e452e966a83fccc8e3eb40d859eba7ffa93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560399 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649345} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit be69ea9af7db3193cbaa7f14fad28f7214001ed7 Author: lemeshev <lemeshev@google.com> Date: Wed Apr 10 00:19:58 2019 +0000 All functioning autofill captured sites Adding all currently functioning autofill captured sites tests, including 80 new tests Bug: 847905 Change-Id: I6856765eefba3cc802664384e1b910e9561581e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557429 Auto-Submit: Pavel Lemeshev <lemeshev@google.com> Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#649344} DEPS | 2 +- chrome/test/data/autofill/captured_sites/cipd.yaml | 161 ++++++++++++++++++++- 2 files changed, 161 insertions(+), 2 deletions(-) commit 38aaea4fdbab7f494e0f26a006d38769b1702e2e Author: dpapad <dpapad@chromium.org> Date: Wed Apr 10 00:19:49 2019 +0000 WebUI cleanup: Rename IDS_MD_EXTENSIONS_ to IDS_EXTENSIONS_. This is part of the effort to remove unnecessary "md_" prefixes from various parts of the WebUI codebase. Bug: 887150 Change-Id: I9bb8dafcee8a9379f1afccebbb495f865a4fb193 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559709 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#649343} chrome/app/chromium_strings.grd | 2 +- chrome/app/generated_resources.grd | 2 +- chrome/app/google_chrome_strings.grd | 2 +- chrome/app/md_extensions_strings.grdp | 246 ++++++++++----------- chrome/browser/extensions/load_error_reporter.cc | 3 +- .../browser/ui/webui/extensions/extensions_ui.cc | 246 ++++++++++----------- .../page_not_available_for_guest_ui.cc | 2 +- 7 files changed, 251 insertions(+), 252 deletions(-) commit 61450bbccebefd7e16e694ae6f8ef5482b070a85 Author: chaopeng <chaopeng@chromium.org> Date: Wed Apr 10 00:18:48 2019 +0000 Recreate DirectManipulationHelper when every LRWHH UpdateParent Compositor and window event target is associated with window's parent. We call LRWHH UpdateParent when window's parent update, includes window's parent actually update and window initialize. Recreate DirectManipulationHelper on every window's parent update helps keep DirectManipulationHelper lifecycle tracking simpler. We also make CompositorAnimationObserver owned by DirectManipulationHelper. With this changes, we start the DirectManipulation event polling when DirectManipulationHelper created and stop when it destroyed. The issue should be fix since event polling start no more depends on DM_POINTERHITTEST. This also includes 2 refactoring changes: 1. Move CompositorAnimationObserver into DirectManipulationHelper. 2. Call ZoomToRect to reset viewport of DirectManipulation when viewport is actually transformed in RUNNING - READAY sequence. Bug: 914914 Change-Id: I0a63f9a407e0231d631e64f2b22a9975471f2fd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547049 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#649342} .../direct_manipulation_event_handler_win.cc | 19 ++-- .../direct_manipulation_event_handler_win.h | 1 - .../direct_manipulation_helper_win.cc | 113 ++++++++++---------- .../renderer_host/direct_manipulation_helper_win.h | 38 +++---- .../direct_manipulation_win_browsertest.cc | 54 ---------- .../direct_manipulation_win_unittest.cc | 27 ++--- .../renderer_host/legacy_render_widget_host_win.cc | 116 ++------------------- .../renderer_host/legacy_render_widget_host_win.h | 14 --- 8 files changed, 114 insertions(+), 268 deletions(-) commit 0b245cc267b55fa18e7ac37ad9d0f0f3e6ea418c Author: Jan Krcal <jkrcal@chromium.org> Date: Wed Apr 10 00:18:44 2019 +0000 [AF] Move conversion of server addresses to the DB sequence This CL fixes a long-standing race condition between PDM and sync for wallet_metadata / autofill_profile. After this change the conversion of a server profile into a local profile happens on the DB sequence and thus it becomes an atomic operation w.r.t. other operations on the DB sequence (such as w.r.t. processing new data from sync). Bug: 911133 Change-Id: I653810d243734a951649f25c7952ad4d35fc2f87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547971 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by: sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#649341} components/autofill/core/browser/BUILD.gn | 2 + .../autofill/core/browser/personal_data_manager.cc | 182 ++------------ .../autofill/core/browser/personal_data_manager.h | 4 +- .../core/browser/personal_data_manager_unittest.cc | 30 +-- .../core/browser/webdata/autofill_webdata.h | 8 + .../browser/webdata/autofill_webdata_backend.h | 6 + .../webdata/autofill_webdata_backend_impl.cc | 22 ++ .../webdata/autofill_webdata_backend_impl.h | 12 + .../webdata/autofill_webdata_backend_util.cc | 264 +++++++++++++++++++++ .../webdata/autofill_webdata_backend_util.h | 27 +++ .../browser/webdata/autofill_webdata_service.cc | 24 +- .../browser/webdata/autofill_webdata_service.h | 5 +- .../webdata/autofill_webdata_service_observer.h | 2 + .../webdata/mock_autofill_webdata_backend.h | 1 + .../profile_sync_service_autofill_unittest.cc | 1 + 15 files changed, 398 insertions(+), 192 deletions(-) commit 7581dd15e8c7da3f9781b889d948cd461e1d69fb Author: Shakti Sahu <shaktisahu@chromium.org> Date: Wed Apr 10 00:17:42 2019 +0000 Fixed redundant download completed observer updates We should be careful to not let the same download completion update surface twice to the UI layer. Otherwise it might inadvertently introduce duplicate notification bugs. Bug : 949941 Change-Id: I161066f81fd6d12afb57236847d9d6c47fb2984a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555653 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#649340} .../browser/download/DownloadNotificationService.java | 2 +- .../browser/download/download_offline_content_provider.cc | 15 +++++++++++---- .../browser/download/download_offline_content_provider.h | 1 + 3 files changed, 13 insertions(+), 5 deletions(-) commit b0b81be18d82028fd24d9e15a4a1dbd2669a87e5 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 10 00:17:37 2019 +0000 Roll src/third_party/chromite 69a3f230f57f..9a5d312903e2 (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/69a3f230f57f..9a5d312903e2 git log 69a3f230f57f..9a5d312903e2 --date=short --no-merges --format='%ad %ae %s' 2019-04-09 evanhernandez@chromium.org artifacts: Die gracefully if artifacts don't exist Created with: gclient setdep -r src/third_party/chromite@9a5d312903e2 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: Iacd360718b352e5cf58770d4a2620274e93ed6ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560396 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649339} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit bb07547cba557d5ed0ce2f051fb7a36bbd62258a Author: Ben Wells <benwells@chromium.org> Date: Wed Apr 10 00:16:34 2019 +0000 Add related_web_apps extensions manifest field. This will be used in the chrome.management.installWebApp API to verify that the extension calling installWebApp owns the web app to be installed. Bug: 944397 Change-Id: I95ee4819ff8b9f342736c9d81b20f547d63f34d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549300 Commit-Queue: Ben Wells <benwells@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#649338} extensions/common/BUILD.gn | 3 + extensions/common/api/_manifest_features.json | 5 ++ extensions/common/common_manifest_handlers.cc | 2 + extensions/common/manifest_constants.cc | 3 + extensions/common/manifest_constants.h | 2 + extensions/common/manifest_handler.h | 2 +- .../manifest_handlers/replacement_web_app.cc | 70 ++++++++++++++++++++ .../common/manifest_handlers/replacement_web_app.h | 45 +++++++++++++ .../replacement_web_app_unittest.cc | 75 ++++++++++++++++++++++ 9 files changed, 206 insertions(+), 1 deletion(-) commit 74f3dd3f3f6b745f9a8f3e80968e530463c2471d Author: Lei Zhang <thestig@chromium.org> Date: Wed Apr 10 00:16:31 2019 +0000 Fix some nits in CreateCrashHandlerHost(). Use the returned iterator from a std::map::insert() operation, rather than doing a second look up. Also remove some NULLs. Change-Id: I8a5751b75fcdf02d8fb970bd3325718098d21f4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560305 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#649337} chrome/browser/chrome_content_browser_client.cc | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) commit 57cc785d7107e04d8667f5000e9e7aee51cbb4e5 Author: Mitsuru Oshima <oshima@chromium.org> Date: Wed Apr 10 00:15:27 2019 +0000 CrOS: interactive ui test for Overview animations - This trigger enter/exist with various conditions number of windows: 2 or 8 tab content: blank or new tab page device mode: clamshell or tablet mode This also adds new test api to wait for overview animation state. Bug: 948324 Change-Id: Ic8d56e12bbd5a60cf93c3add6522cfa128a2764b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559384 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#649336} ash/public/interfaces/shell_test_api.test-mojom | 8 ++ ash/shell_test_api.cc | 59 ++++++++++++ ash/shell_test_api.h | 3 + chrome/browser/ui/ash/ash_test_util.cc | 8 ++ chrome/browser/ui/ash/ash_test_util.h | 3 + .../ash/overview_animations_interactive_uitest.cc | 100 +++++++++++++++++++++ chrome/test/BUILD.gn | 1 + 7 files changed, 182 insertions(+) commit dc6942938a25dea793f3aa90056c74f5983de6f1 Author: Xiyuan Xia <xiyuan@chromium.org> Date: Wed Apr 10 00:15:24 2019 +0000 cros: Forward VK bounds adjustment to embedding side Support embedded windows in EnsureWindowNotInRect and RestoreWindowBoundsOnClientFocusLost in ime_util_chromeos by using a window property to forward the bounds adjustment to the embedding side top level window. Bug: 948015 Change-Id: I08e2afa3f566667d8c92bd3c04412404af55df5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558575 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#649335} services/ws/public/mojom/window_manager.mojom | 6 ++ services/ws/remote_view_host/BUILD.gn | 5 ++ .../ws/remote_view_host/server_remote_view_host.cc | 9 +++ .../ws/remote_view_host/server_remote_view_host.h | 8 +++ ui/aura/client/aura_constants.cc | 3 + ui/aura/client/aura_constants.h | 6 ++ ui/aura/mus/property_converter.cc | 3 + ui/views/mus/remote_view/BUILD.gn | 5 ++ ui/views/mus/remote_view/remote_view_host.cc | 9 +++ ui/views/mus/remote_view/remote_view_host.h | 8 +++ ui/wm/core/ime_util_chromeos.cc | 48 +++++++++++++- ui/wm/core/ime_util_chromeos.h | 27 +++++++- ui/wm/core/ime_util_chromeos_unittest.cc | 76 ++++++++++++++++++++++ 13 files changed, 210 insertions(+), 3 deletions(-) commit bad4a05331293353d1b7d01741b455fee9378808 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 10 00:14:20 2019 +0000 Roll src/third_party/angle e4458b7bb63a..f39b4f0280ef (2 commits) https://chromium.googlesource.com/angle/angle.git/+log/e4458b7bb63a..f39b4f0280ef git log e4458b7bb63a..f39b4f0280ef --date=short --no-merges --format='%ad %ae %s' 2019-04-09 timvp@google.com Vulkan Android: Remove workaround to clamp the point size 2019-04-09 spang@chromium.org Fix leak of MemoryObjectManager from context state Created with: gclient setdep -r src/third_party/angle@f39b4f0280ef The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:951049 TBR=ynovikov@chromium.org Change-Id: I57f789b8617e6a671d8f5a6bf31e9ee05033bc5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560402 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649334} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit a979b5dbf400795decadd3b65fa0999fdf87211b Author: Orin Jaworski <orinj@chromium.org> Date: Wed Apr 10 00:14:17 2019 +0000 [omnibox] Update translation icon for answers in suggest This CL adds the answer_translation.icon vector file and removes the raster translate_round_32.png because it is no longer used. Bug: 950075 Change-Id: If4ddff3b66c40628696edaa5743ad5693ba6742b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559239 Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#649333} .../common/translate_round_32.png | Bin 1440 -> 0 bytes .../common/translate_round_32.png | Bin 3238 -> 0 bytes chrome/app/theme/theme_resources.grd | 3 -- .../ui/views/omnibox/omnibox_match_cell_view.cc | 24 ++++------- components/omnibox/browser/BUILD.gn | 1 + .../browser/vector_icons/answer_translation.icon | 45 +++++++++++++++++++++ 6 files changed, 53 insertions(+), 20 deletions(-) commit c93fff96d222811e0d616af359ebe4d6bc499fbe Author: Suman Kancherla <sumankancherla@chromium.org> Date: Wed Apr 10 00:13:17 2019 +0000 Added a few browser tests for in-headset UI Added following tests covering - * indicators when their respective devices become in-use. Since this feature depends on hardware/system capability, all except location permission test have been commented by an '#if 0' * indicators displaying the permissions already granted. This is not dependent on hardware/system, and so, testable on any machine. A few permutations of {allow, block, ask} are applied to {microphone, camera, location} permissions Things to explore/add are - * to try and run the second category of tests on all possible permutations * add bluetooth, midi, usb and screen capture to the above mix * add tests involving external prompt, timeout spinner UI and indicators Bug: 908925 Change-Id: Ide7e03716d9992372991fc2c66354e8276189182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555356 Commit-Queue: Suman Kancherla <sumankancherla@chromium.org> Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#649332} chrome/browser/vr/BUILD.gn | 6 +- chrome/browser/vr/ui.cc | 4 + chrome/browser/vr/ui_test_input.h | 4 + .../browser/vr/webxr_vr_indicators_browser_test.cc | 231 +++++++++++++++++++++ 4 files changed, 244 insertions(+), 1 deletion(-) commit 0eda3bf10c61d171e49502b226f032c606dc2724 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 10 00:13:13 2019 +0000 Roll src/third_party/swiftshader 1424ef650142..f0aa9d5ab738 (2 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/1424ef650142..f0aa9d5ab738 git log 1424ef650142..f0aa9d5ab738 --date=short --no-merges --format='%ad %ae %s' 2019-04-09 sugoi@google.com Query implementation 2019-04-09 sugoi@google.com No border for compressed cube images Created with: gclient setdep -r src/third_party/swiftshader@f0aa9d5ab738 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: I4b3005ca4a8d861ecf163631cd9320232469d707 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560394 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649331} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 1c0b284eb8b0ec7bc809303fef0f45ed032da936 Author: Sammie Quon <sammiequon@google.com> Date: Wed Apr 10 00:12:11 2019 +0000 overview: Do not animate wallpaper when kiosk next is enabled. Test: manual Bug: 950730 Change-Id: Id278b7b77a48603e4451293710e7f376a323fab2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559876 Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#649330} ash/wm/overview/overview_grid.cc | 6 ++++++ 1 file changed, 6 insertions(+) commit df8c1bf8bc5ae23ec8ce15021255ecab1c48eaa1 Author: Justin DeWitt <dewittj@chromium.org> Date: Wed Apr 10 00:11:41 2019 +0000 [Touchless] Don't force the NTP if media is playing. Since the NoTouchActivity is a single tab activity, there might be media playing in it while the user is doing something else. Don't stop the media by navigating to the NTP if it is playing. Bug: 937429 Change-Id: I153d93056bb76ff1d8195d660c12c2c784a2ac9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558055 Reviewed-by: Sky Malice <skym@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#649329} .../chrome/browser/touchless/NoTouchActivity.java | 20 +++++-- .../browser/touchless/TouchlessTabObserver.java | 62 +++++++++++++++++++++- 2 files changed, 75 insertions(+), 7 deletions(-) commit ca2c9afa7f75f3e35a04c76aa0497003988d60e0 Author: Adam Langley <agl@chromium.org> Date: Wed Apr 10 00:10:37 2019 +0000 device/fido: rework request cancelation. Previously, FidoDevice::Cancel would cancel any and all requests outstanding, and could corrupt a multi-frame message that was in the process of being sent. This change fixes that and augments the API to allow specific requests to be canceled. This is important for resident keys because we want to ensure that resident creation requests are effectively canceled once moot. Bug: 941120 Change-Id: Ie219c89fcfebe5be61fa77fff40201f06c1b328d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554110 Reviewed-by: Martin Kreichgauer <martinkr@google.com> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#649328} device/fido/ble/fido_ble_device.cc | 80 +++-- device/fido/ble/fido_ble_device.h | 30 +- device/fido/ble/fido_ble_device_unittest.cc | 62 +++- device/fido/ble/fido_ble_transaction.cc | 27 ++ device/fido/ble/fido_ble_transaction.h | 8 + device/fido/cable/fido_cable_device.cc | 11 +- device/fido/cable/fido_cable_device.h | 4 +- device/fido/ctap2_device_operation.h | 4 +- device/fido/device_operation.h | 19 +- device/fido/fido_device.h | 28 +- device/fido/fido_device_authenticator.cc | 10 +- device/fido/fido_request_handler_unittest.cc | 29 +- device/fido/fido_task.cc | 4 - device/fido/fido_task.h | 11 +- device/fido/get_assertion_request_handler.cc | 3 + device/fido/get_assertion_task.cc | 9 + device/fido/get_assertion_task.h | 3 + device/fido/hid/fido_hid_device.cc | 397 +++++++++++++++--------- device/fido/hid/fido_hid_device.h | 99 +++--- device/fido/hid/fido_hid_device_unittest.cc | 252 ++++++++++++--- device/fido/make_credential_handler_unittest.cc | 114 ++++++- device/fido/make_credential_request_handler.cc | 3 + device/fido/make_credential_task.cc | 10 + device/fido/make_credential_task.h | 3 + device/fido/mock_fido_device.cc | 21 +- device/fido/mock_fido_device.h | 8 +- device/fido/virtual_ctap2_device.cc | 14 +- device/fido/virtual_ctap2_device.h | 5 +- device/fido/virtual_u2f_device.cc | 12 +- device/fido/virtual_u2f_device.h | 5 +- 30 files changed, 958 insertions(+), 327 deletions(-) commit a50721cfd9ad77df4673334e1d9205e249602224 Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Wed Apr 10 00:10:33 2019 +0000 Update V8 to version 7.5.227. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/825bcc75..59a29d88 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3adb56920964eaa8235c43a611b624aa977e7e36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559361 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649327} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 70f81ba53d2d88af0a11609c88f1fb5c4a79a706 Author: Collin Baker <collinbaker@chromium.org> Date: Wed Apr 10 00:02:20 2019 +0000 Revert "Reland "Increase coverage for EULA browser tests"" This reverts commit c3e3793b3e7b8ac42b35aea22ce28f69208132c1. Reason for revert: Still causing test failures: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/32641?blamelist=1#blamelist-tab Original change's description: > Reland "Increase coverage for EULA browser tests" > > This is a reland of 426df2bedfa0c4c6bf9bcccaef6caf981c9a426c > > Original change's description: > > Increase coverage for EULA browser tests > > > > Adds tests for: > > * Clicking on "System security settings" button in EULA screen > > * Accepting and rejecting usage stats collection > > * Clicking on "Learn more" button in EULA screen > > > > Removes dead code from EulaScreen class. > > > > Adds a HelpApp extension manifest to use in tests and modifies > > HelpAppLauncher class to allow tests to set the extension id. > > > > Adds a HelpAppTestHelper class to facilitate writing tests that > > open HelpApp dialogs. > > > > Change-Id: Id7841be5bf3faabb067d3a75d3b034bdf0e00e32 > > Reviewed-on: > https://chromium-review.googlesource.com/c/chromium/src/+/1554123 > > Commit-Queue: Tony De Luna <tonydeluna@chromium.org> > > Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> > > Reviewed-by: Toni Baržić <tbarzic@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#648759} > > TBR=hashimoto > > Bug: 947358 > Change-Id: I23865c1957f300f55812f3275e830772aa27c32d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560146 > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Commit-Queue: Tony De Luna <tonydeluna@chromium.org> > Cr-Commit-Position: refs/heads/master@{#649258} TBR=hashimoto@chromium.org,tbarzic@chromium.org,alemate@chromium.org,tonydeluna@chromium.org Change-Id: Id84e11a36c78c355cac699a1d9a4c48c5863659d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 947358 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560493 Reviewed-by: Collin Baker <collinbaker@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#649326} chrome/browser/chromeos/BUILD.gn | 2 - chrome/browser/chromeos/login/eula_browsertest.cc | 161 +-------------------- chrome/browser/chromeos/login/help_app_launcher.cc | 21 +-- chrome/browser/chromeos/login/help_app_launcher.h | 3 - .../browser/chromeos/login/screens/eula_screen.cc | 18 +++ .../chromeos/login/test/help_app_test_helper.cc | 86 ----------- .../chromeos/login/test/help_app_test_helper.h | 57 -------- chrome/browser/chromeos/login/test/js_checker.cc | 4 +- .../resources/chromeos/login/oobe_eula.html | 4 +- .../extensions/api_test/help_app/manifest.json | 8 - .../data/extensions/api_test/help_app/oobe.html | 9 -- chromeos/dbus/cryptohome/fake_cryptohome_client.cc | 4 +- chromeos/dbus/cryptohome/fake_cryptohome_client.h | 3 - 13 files changed, 27 insertions(+), 353 deletions(-) commit 0efa76d0baccfed51e0a7e585fe8c154958743e9 Author: Collin Baker <collinbaker@chromium.org> Date: Tue Apr 9 23:55:31 2019 +0000 Revert "Enable use_dawn by default on Mac" This reverts commit c33140884d5968761542a69fa32477a584a67f3f. Reason for revert: speculative revert for WebGPUDecoderTest.Dummy failures - https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/41527 - https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/41528 Original change's description: > Enable use_dawn by default on Mac > > Mac is the first platform where WebGPU is implemented. Enabling use_dawn > there makes sure that dawn-related tests are run on the CQ, and allows > developers to use Mac Canary to test WebGPU. > > BUG=chromium:852089 > > Change-Id: Ic076afbe4d6d9efe97bee7bb56f0d375a35bec5c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559319 > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Commit-Queue: Corentin Wallez <cwallez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#649264} TBR=ellyjones@chromium.org,kbr@chromium.org,cwallez@chromium.org Change-Id: I125e6f63941fdf0007b42da1673f641a7b32de5d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:852089 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560530 Reviewed-by: Collin Baker <collinbaker@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#649325} ui/gl/features.gni | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 19e91f59a639465f31e96b1039fe17b83a64b60a Author: Lucas Tenório <ltenorio@chromium.org> Date: Tue Apr 9 23:24:52 2019 +0000 Add tests covering interaction between AppController and its client. The AppControllerService notifies the AppControllerClient of any app changes that might happen. These new tests cover which notifications are sent or filtered. It also covers cases where previous information used to inform the client is not available anymore, like Android package names. Bug: 927809 Change-Id: I0006a4cb898bb08894ad4388b9d95bfbd3983a40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558793 Commit-Queue: Lucas Tenório <ltenorio@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#649324} .../kiosk_next_home/app_controller_service.cc | 10 +- .../app_controller_service_unittest.cc | 208 +++++++++++++++++++-- 2 files changed, 200 insertions(+), 18 deletions(-) commit b7e2d525d2ce75faf43f293ef644e1d47f6da1b1 Author: Sergey Ulanov <sergeyu@chromium.org> Date: Tue Apr 9 23:24:48 2019 +0000 [Fuchsia] Enable blink web tests on Fuchsia x64 bots Also: 1. Removed --qemy-require-kvm flag from the runner script since run_web_tests.py doesn't support that flag. Instead KVM requirement is handled by the runner script directly. 2. Disabled sharding when running layout tests on Fuchsia, including on FYI bots: it doesn't make much sense to shard these tests since we run only smoke tests and sharding overhead is comparable to the time it takes to run all tests on a single bot. Bug: 778467 Change-Id: Ice7a11ebf5c51c84550745e8e88cd71cd300b0fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549585 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Reviewed-by: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#649323} build/fuchsia/common_args.py | 8 +-- testing/buildbot/chromium.fyi.json | 3 +- testing/buildbot/chromium.linux.json | 106 ++++++++--------------------- testing/buildbot/test_suite_exceptions.pyl | 11 +++ testing/buildbot/waterfalls.pyl | 4 +- 5 files changed, 46 insertions(+), 86 deletions(-) commit 89baca17e77f24d926b7a539c78641f1edfd840e Author: Alexey Baskakov <loyso@chromium.org> Date: Tue Apr 9 23:19:36 2019 +0000 WebApp: Extract WebAppInstallTask from WebAppInstallManager. Allow concurrent installs. WebAppInstallManager owns all install tasks. This CL introduces no behavior changes. Bug: 901226 Change-Id: Ib231faeb7b3749f3f68436ac01d872075c4e6cb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556659 Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#649322} chrome/browser/web_applications/BUILD.gn | 4 +- .../web_applications/web_app_install_manager.cc | 227 ++----------------- .../web_applications/web_app_install_manager.h | 77 ++----- .../web_applications/web_app_install_task.cc | 245 +++++++++++++++++++++ .../web_applications/web_app_install_task.h | 106 +++++++++ ...nittest.cc => web_app_install_task_unittest.cc} | 59 +++-- 6 files changed, 413 insertions(+), 305 deletions(-) commit f51633370fa45b09487fa231b74e331a3795321d Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Apr 9 23:16:45 2019 +0000 Roll src/third_party/pdfium c75ce35aa1a7..44034bca7d3e (5 commits) https://pdfium.googlesource.com/pdfium.git/+log/c75ce35aa1a7..44034bca7d3e git log c75ce35aa1a7..44034bca7d3e --date=short --no-merges --format='%ad %ae %s' 2019-04-09 tsepez@chromium.org Make CXFA_TraverseStrategy_ViewLayoutItem private to cxfa_layoutpagemgr.cpp. 2019-04-09 thestig@chromium.org Prevent out of bound access inside CXFA_LayoutPageMgr. 2019-04-09 tsepez@chromium.org Rename CXFA_ContainerLayoutItem to CXFA_ViewLayoutItem. 2019-04-09 thestig@chromium.org Switch from vector to deque for some CXFA_FFDocView members. 2019-04-08 tsepez@chromium.org Correct hierarchy description in xfa/fxfa/README.md Created with: gclient setdep -r src/third_party/pdfium@44034bca7d3e The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:925787 TBR=dsinclair@chromium.org Change-Id: I2b1c7473324b228a52aff4aada9295baa0c10833 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560393 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649321} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit fff70a410e6d97b9db43abe4be464dc386641afc Author: Jun Mukai <mukai@chromium.org> Date: Tue Apr 9 23:15:44 2019 +0000 synchronize visibility of hosted_app_buttons with caption buttons The hosted_app_buttons should be invisible when the caption buttons (i.e. maximize/minimize/close buttons) are invisible. Bug: 951068 Test: browser_tests Change-Id: Ic944b6d90c3cda4397f38f34d5de86e2a26ca070 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560314 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#649320} .../ui/views/frame/browser_non_client_frame_view_ash.cc | 10 ++++++++-- .../frame/browser_non_client_frame_view_ash_browsertest.cc | 11 +++++++++++ 2 files changed, 19 insertions(+), 2 deletions(-) commit 674b304012260beca328392bf585f69a4a9fb340 Author: Yue Zhang <yuezhanggg@google.com> Date: Tue Apr 9 23:11:49 2019 +0000 Show correct number of columns for tab grid as orientation changes Add ComponentCallbacks in TabListMediator to listen to orientation changes and change span count of GridLayoutManager accordingly. TODO: * Fix the problem of landscape Thumbnail showing incorrectly in portrait mode. * Dynamically set span count base on screen width, min width of cards and paddings. Bug: 945740 Change-Id: I961274492e35c097e6440caeaff78ae7cd7d83db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559238 Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@google.com> Cr-Commit-Position: refs/heads/master@{#649319} .../tasks/tab_management/TabListCoordinator.java | 8 +++++-- .../tasks/tab_management/TabListMediator.java | 25 ++++++++++++++++++++++ 2 files changed, 31 insertions(+), 2 deletions(-) commit e55ac133d0e807d98b6c840aa92d21bc21e0a6da Author: Jeffrey Kardatzke <jkardatzke@google.com> Date: Tue Apr 9 23:10:28 2019 +0000 Allow bluetooth logging for all boards This removes the restriction for including bluetooth logs in feedback reports from nocturne/eve only. It is now enabled for all boards. Bug: 872403 Test: BT logs appear in feedback report from kevin Change-Id: Ifeee8e1dc9c86fe2f3a05a34f24da0824ae344de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560254 Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#649318} .../browser/chromeos/login/users/chrome_user_manager_impl.cc | 6 ------ chrome/browser/feedback/show_feedback_page.cc | 12 +----------- 2 files changed, 1 insertion(+), 17 deletions(-) commit dff09a2a286f6bba94b195d2659bed744d7c887e Author: Christian Fremerey <chfremer@chromium.org> Date: Tue Apr 9 23:08:34 2019 +0000 Reland "[Tab Capture] Simplify reuse of already captured content" This is a reland of ca79d9d86dd27bb55e0bd0a12d722618fce89502 Reason for revert was a too strict expectation in a test case, which has been fixed here: https://chromium-review.googlesource.com/c/chromium/src/+/1559125 Original change's description: > [Tab Capture] Simplify reuse of already captured content > > Before this CL, class FrameSinkVideoCapturerImpl uses a somewhat > hard-to-follow protocol with InterprocessFramePool for resurrecting > video frames in case that the source content did not change. > > This CL changes this protocol to a simpler-to-follow mechanism, which > also can reduce the cases where content is re-captured even though > it is already available in a previously captured buffer. > > Change-Id: I635e3cf0dce61f704a6b613702791f03ff0c217a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1479154 > Commit-Queue: Christian Fremerey <chfremer@chromium.org> > Reviewed-by: Yuri Wiitala <miu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#648688} Change-Id: I07b3899b104eb78b039519791384f024bec30388 Bug: 951069 TBR=miu@chromium.org Change-Id: I07b3899b104eb78b039519791384f024bec30388 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559333 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#649317} .../frame_sink_video_capturer_impl.cc | 84 +++++----- .../video_capture/frame_sink_video_capturer_impl.h | 17 +- .../video_capture/interprocess_frame_pool.cc | 103 ++++++++---- .../video_capture/interprocess_frame_pool.h | 35 ++-- .../interprocess_frame_pool_unittest.cc | 185 +++++++++++++++------ 5 files changed, 276 insertions(+), 148 deletions(-) commit 7dfa8ec4db482c3940ebd5e9441340adfae14be9 Author: Kurt Horimoto <kkhorimoto@chromium.org> Date: Tue Apr 9 23:08:04 2019 +0000 [iOS] Create TestBrowser constructor that takes WebStateList. The previous TestBrowser constructor took a TabModel, which required tests that require a Browser to construct complicated OCMocks to construct the TestBrowser. This CL adds a second constructor that instead takes a WebStateList, and can be used to create TestBrowsers for objects that don't use the deprecated TabModel interface. Bug: none Change-Id: I306e536621f932f8d6b4ed22d3d149de2649fda6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559766 Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#649316} ios/chrome/browser/main/test_browser.h | 13 +++++++++++-- ios/chrome/browser/main/test_browser.mm | 10 ++++++++-- 2 files changed, 19 insertions(+), 4 deletions(-) commit baf43b2e9289e8bee3ce66af770bd173bb7ea8ff Author: Sébastien Séguin-Gagnon <sebsg@chromium.org> Date: Tue Apr 9 23:05:34 2019 +0000 [SendTabToSelf] Enable the receiving flag by default. Bug: 949612 Change-Id: Ibe0d0781df2398d7358ece7c657b29bbc7553c9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555246 Commit-Queue: sebsg <sebsg@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#649315} .../desktop_notification_handler_unittest.cc | 12 ++++++++++-- components/send_tab_to_self/send_tab_to_self_sync_service.h | 3 ++- components/sync/driver/sync_driver_switches.cc | 4 ++-- 3 files changed, 14 insertions(+), 5 deletions(-) commit b2ea3d296c6ba85d8d1f216a2759731fe1cedfe9 Author: Rohit Rao <rohitrao@chromium.org> Date: Tue Apr 9 23:05:05 2019 +0000 [ios] Compile ios/testing/earl_grey/matchers.mm under EG2. This file is compiled as an EG2 test-side helper and removed from the eg_app_support+eg2 target. BUG=922813 Change-Id: Ia842d0c0feb9f662419a07e6d79761e71184e309 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559383 Reviewed-by: Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#649314} ios/testing/earl_grey/BUILD.gn | 10 +++++++--- ios/testing/earl_grey/matchers.mm | 3 ++- 2 files changed, 9 insertions(+), 4 deletions(-) commit 819d50e7b35fe85a2e739e4ce9f98f5430aadbf5 Author: Ian Wells <iwells@chromium.org> Date: Tue Apr 9 23:01:09 2019 +0000 [Offline pages] Fetch and store favicon for Feed articles Adds fetching and storing of favicons to the prefetching pipeline for Feed only. Also adds snippet and attribution columns to the INSERT query in AddPageTask as this was missed in the schema update CL. NOTRY=true Bug: 841516 Change-Id: I04d0e1468ae55c7739360c040490e934efca9dda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534293 Commit-Queue: Ian Wells <iwells@chromium.org> Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by: Dan H <harringtond@google.com> Cr-Commit-Position: refs/heads/master@{#649313} components/offline_pages/core/BUILD.gn | 6 +- .../core/downloads/download_ui_adapter.cc | 8 +- .../core/downloads/download_ui_adapter.h | 3 +- .../core/downloads/download_ui_adapter_unittest.cc | 13 +- .../core/model/cleanup_thumbnails_task_unittest.cc | 63 ++++++--- .../offline_pages/core/model/get_thumbnail_task.cc | 9 +- .../offline_pages/core/model/get_thumbnail_task.h | 3 +- .../core/model/get_thumbnail_task_unittest.cc | 63 ++++++++- .../offline_pages/core/model/has_thumbnail_task.cc | 19 +-- .../offline_pages/core/model/has_thumbnail_task.h | 6 +- .../core/model/has_thumbnail_task_unittest.cc | 71 +++++++--- .../core/model/offline_page_model_taskified.cc | 39 ++++-- .../core/model/offline_page_model_taskified.h | 13 +- .../model/offline_page_model_taskified_unittest.cc | 54 +++++++- .../core/model/offline_page_test_utils.cc | 21 +++ .../core/model/store_thumbnail_task.cc | 56 -------- .../core/model/store_thumbnail_task.h | 43 ------ .../core/model/store_thumbnail_task_unittest.cc | 84 ------------ .../offline_pages/core/model/store_visuals_task.cc | 147 +++++++++++++++++++++ .../offline_pages/core/model/store_visuals_task.h | 66 +++++++++ .../core/model/store_visuals_task_unittest.cc | 124 +++++++++++++++++ .../core/offline_page_metadata_store_unittest.cc | 9 +- components/offline_pages/core/offline_page_model.h | 15 ++- .../offline_pages/core/offline_page_thumbnail.cc | 26 +--- .../offline_pages/core/offline_page_thumbnail.h | 5 +- .../core/offline_page_thumbnail_unittest.cc | 18 ++- components/offline_pages/core/offline_page_types.h | 8 ++ components/offline_pages/core/prefetch/BUILD.gn | 4 +- .../core/prefetch/prefetch_dispatcher_impl.cc | 102 +++++++++----- .../core/prefetch/prefetch_dispatcher_impl.h | 38 ++++-- .../prefetch/prefetch_dispatcher_impl_unittest.cc | 128 +++++++++++++----- .../core/prefetch/tasks/get_thumbnail_info_task.cc | 12 +- .../core/prefetch/tasks/get_thumbnail_info_task.h | 8 +- ...ail_fetch_by_url.cc => visuals_fetch_by_url.cc} | 46 +++++-- ...bnail_fetch_by_url.h => visuals_fetch_by_url.h} | 15 ++- .../offline_pages/core/stub_offline_page_model.cc | 7 +- .../offline_pages/core/stub_offline_page_model.h | 5 +- tools/traffic_annotation/summary/annotations.xml | 2 +- 38 files changed, 931 insertions(+), 428 deletions(-) commit dbc6d91a783d5410cf198c4e7a403b105ff9b6dc Author: John Lee <johntlee@chromium.org> Date: Tue Apr 9 23:00:29 2019 +0000 Settings WebUI: Disable spellcheck when all languages are turned off, and enable spellcheck for all languages when spellcheck is turned on Bug: 848536 Change-Id: I99f814b559fb591f85eda6012cca94d4a1c81635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559232 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#649312} .../settings/languages_page/languages_page.html | 5 ++-- .../settings/languages_page/languages_page.js | 31 ++++++++++++++++++-- .../data/webui/settings/languages_page_tests.js | 34 ++++++++++++++++++++++ 3 files changed, 65 insertions(+), 5 deletions(-) commit a8fb785b4bacbcd26460f90935780bd65bc79ba4 Author: Collin Baker <collinbaker@chromium.org> Date: Tue Apr 9 23:00:06 2019 +0000 Disable flaky test SyncCustomizationFragmentTest#testSyncSwitchClearsServerAutofillCreditCards TBR=nyquist@chromium.org Bug: 951141 Change-Id: Ia3352c9de1d8fc418a46076ffa08d41594a3bce4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559360 Reviewed-by: Collin Baker <collinbaker@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#649311} .../org/chromium/chrome/browser/sync/SyncCustomizationFragmentTest.java | 1 + 1 file changed, 1 insertion(+) commit c76b1b42849dc3aa64fd5684c48028e4400dfc9a Author: Shakti Sahu <shaktisahu@chromium.org> Date: Tue Apr 9 22:59:20 2019 +0000 Handling auto-resumption for history downloads After native AutoResumptionHandler is set into effect, we should be very careful that downloads long back from history shouldn't be resumed. In this CL, we are addressing that issue by setting the auto-resume count of history downloads to a max value. Change-Id: Iedb037da21c8a93e468f9c64fa1614fd0cf6c7a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559454 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#649310} components/download/internal/common/download_item_impl.cc | 4 ++++ components/download/public/common/download_item_impl.h | 2 ++ content/browser/download/download_browsertest.cc | 14 ++++++++++++++ content/browser/download/download_manager_impl.cc | 8 +++++++- 4 files changed, 27 insertions(+), 1 deletion(-) commit 9c63850f082b8128731a0983dbdf800d1c49f923 Author: Yann Dago <ydago@chromium.org> Date: Tue Apr 9 22:56:07 2019 +0000 Management WebUI: Add settings search to the toolbar Add a search field to the toolbar that redirects to the settings page on each search. Bug: 948259 Change-Id: I5c81ef285fdb2f9042d5d1d843129589af428937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548137 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#649309} .../resources/management/management_ui.html | 5 +++-- .../browser/resources/management/management_ui.js | 22 +++++++++++++--------- chrome/browser/ui/webui/management_ui.cc | 4 +++- 3 files changed, 19 insertions(+), 12 deletions(-) commit d21ddb01104f95b801541afb90bd5cb5085f8ab3 Author: Victor Hugo Vianna Silva <victorvianna@google.com> Date: Tue Apr 9 22:56:02 2019 +0000 Distinguish configuration time statistics for first sync We unite histograms that distinguish first-time/subsequent synchronization (Sync.ServiceInitialConfigureTime,Sync.ServiceSubsequentConfigureTime) and histograms that distinguish based on the configuration result status (Sync.ConfigureTime_Long.{OK,ABORTED,UNRECOVERABLE_ERROR}) into a single set of histograms. Bug: 169053 Change-Id: I757a86e50b907edf7ace2137d9a34a34f8495dd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552827 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by: Brian White <bcwhite@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Reviewed-by: Jan Krcal <jkrcal@chromium.org> Auto-Submit: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#649308} components/sync/driver/data_type_manager_impl.cc | 32 ++++++++--- .../sync/driver/data_type_manager_impl_unittest.cc | 49 ++++++++++++++-- components/sync/driver/profile_sync_service.cc | 15 ----- components/sync/driver/profile_sync_service.h | 5 -- tools/metrics/histograms/histograms.xml | 67 ++++++++++++++++++++-- 5 files changed, 129 insertions(+), 39 deletions(-) commit fb4fe073221a5f1aec6403894647d5c94c3df8b8 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Tue Apr 9 22:55:02 2019 +0000 Roll src-internal de427f13cef6..6e6256a3131d (2 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/de427f13cef6..6e6256a3131d Created with: gclient setdep -r src-internal@6e6256a3131d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=huangs@chromium.org,battre@chromium.org,collinbaker@chromium.org,tasak@chromium.org Change-Id: Icad91c8ddfd6db199fbc5680827bc25aa7dbd4cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560228 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649307} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 6d4057599e6b7b2dd347b308822360f66a42a408 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Apr 9 22:54:32 2019 +0000 Roll src/third_party/webrtc d39e2c83b730..2af5dcbe9ec3 (1 commits) https://webrtc.googlesource.com/src.git/+log/d39e2c83b730..2af5dcbe9ec3 git log d39e2c83b730..2af5dcbe9ec3 --date=short --no-merges --format='%ad %ae %s' 2019-04-09 benwright@webrtc.org Reland "Refactor FrameDecryptorInterface::Decrypt to use new API." Created with: gclient setdep -r src/third_party/webrtc@2af5dcbe9ec3 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I91d39fbef69b5551602cdbb4c154a110fc1f8917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560392 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649306} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 268691cccb4dc3fa55841b49befcdde4860eac54 Author: Ian Prest <iapres@microsoft.com> Date: Tue Apr 9 22:50:19 2019 +0000 UIA: Fire structure-changed events 1. Added a new generated event (SUBTREE_CREATED) that is fired whenever a new node is added. 2. BrowserAccessibilityManagerWin now fires UIA structure-changed events in response to SUBTREE_CREATED (new) and CHILDREN_CHANGED (existing). 3. BrowserAccessibilityManagerWin overrides OnNode/SubtreeWillBeDeleted in order to fire "node-removed" events. -- We can't just have the event-generator add an event to its queue, because in that case the nodes have been deleted before the events get fired. -- Moved the MSAA implementation here, from UpdateStep3FireEvents; this will make it easier to move to the platform-nodes in the future. 4. UIA event-recorder now records & logs structure-changed events. -- And update existing unit-tests and event-tests were with new expectations. 5. Some events were being fired on IFRAMEs that hadn't yet been added to the tree, which would later result in crashes. -- ShouldFireEventForNode was updated to prevent this scenario. 6. We weren't checking the command-line flag prior to running some UIA specific code in response to the kEndOfTest event; fixed. Bug: 928949 Change-Id: I9f9b1bbeb522451d4c7b8046f21eb91cc8543d3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539141 Commit-Queue: Ian Prest <iapres@microsoft.com> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#649305} .../extensions/automation_ax_tree_wrapper.cc | 1 + .../extensions/automation_ax_tree_wrapper.cc | 1 + .../accessibility_event_recorder_uia_win.cc | 52 ++++++++++++- .../accessibility_event_recorder_uia_win.h | 8 ++ .../accessibility/browser_accessibility_com_win.cc | 4 - .../browser_accessibility_manager_android.cc | 4 +- .../browser_accessibility_manager_mac.mm | 1 + .../browser_accessibility_manager_win.cc | 87 ++++++++++++++++++---- .../browser_accessibility_manager_win.h | 5 ++ .../accessibility/browser_accessibility_win.cc | 4 - .../accessibility/browser_accessibility_win.h | 1 - .../event/add-subtree-expected-uia-win.txt | 3 + .../event/add-subtree-expected-win.txt | 6 +- .../test/data/accessibility/event/add-subtree.html | 7 +- .../event/aria-combo-box-delay-add-list.html | 1 + .../event/aria-combo-box-delay-show-list.html | 1 + .../accessibility/event/aria-combo-box-focus.html | 1 + ...escription-change-indirect-expected-uia-win.txt | 3 + ...scription-change-indirect-expected-uia-win7.txt | 3 + .../event/inner-html-change-expected-uia-win.txt | 5 ++ .../event/inner-html-change-expected-win.txt | 8 +- .../accessibility/event/inner-html-change.html | 5 +- .../event/live-region-create-expected-uia-win.txt | 2 + .../event/live-region-create-expected-uia-win7.txt | 2 + .../data/accessibility/event/menulist-popup.html | 1 + .../name-change-indirect-expected-uia-win.txt | 3 + .../event/remove-child-expected-uia-win.txt | 2 + .../event/text-changed-contenteditable.html | 1 + .../event/text-changed-expected-uia-win.txt | 2 + .../data/accessibility/event/text-changed.html | 1 + ui/accessibility/ax_event_generator.cc | 7 +- ui/accessibility/ax_event_generator.h | 1 + ui/accessibility/ax_event_generator_unittest.cc | 29 ++++++-- ui/accessibility/platform/ax_platform_node_win.cc | 18 +++-- ui/accessibility/platform/ax_platform_node_win.h | 5 ++ 35 files changed, 229 insertions(+), 56 deletions(-) commit f88bc54e44bb0e9313a71cd22f3fac249d5b7f35 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Apr 9 22:49:19 2019 +0000 Roll src/third_party/skia 201b3752e642..ff4fb3335bb7 (3 commits) https://skia.googlesource.com/skia.git/+log/201b3752e642..ff4fb3335bb7 git log 201b3752e642..ff4fb3335bb7 --date=short --no-merges --format='%ad %ae %s' 2019-04-09 ethannicholas@google.com ComposeShader GPU implementations 2019-04-09 jvanverth@google.com Add RG format to Metal 2019-04-09 mtklein@google.com extract ToolUtils::colortype_depth() Created with: gclient setdep -r src/third_party/skia@ff4fb3335bb7 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: I8b4085d87dda9ee23a975f301e2aef2387baac23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560391 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649304} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e525003f056eb1e14d52745488370b162c9767fe Author: Hongchan Choi <hongchan@chromium.org> Date: Tue Apr 9 22:48:24 2019 +0000 Do not resume a suspended BaseAudioContext when AudioWorklet starts When AudioWorklet.addModule() activates the worklet thread, it re-starts the destination handler even when the context is suspended. This CL fixes the bug by restarting destination only when the context is in the "running" state. Bug: 950997 Test: external/wpt/webaudio/the-audio-api/the-audioworklet-interface/audioworklet-suspend.https.html Change-Id: I0b44e3fca23bd069fac21f709fc665e8eacc4dd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560140 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#649303} .../modules/webaudio/base_audio_context.cc | 9 ++--- .../external/wpt/webaudio/resources/audit.js | 12 +++++++ .../audioworklet-suspend.https.html | 38 ++++++++++++++++++++++ .../blink/web_tests/webaudio/resources/audit.js | 12 +++++++ 4 files changed, 67 insertions(+), 4 deletions(-) commit c81a1cf34bfe3de3d5be53231f13697d8974766a Author: wutao <wutao@chromium.org> Date: Tue Apr 9 22:37:06 2019 +0000 app_list: Check assistant status It is possible that assistant service is not available when searching in the Launcher. This patch adds the check before directing the search to Assistant. Bug: 950149 Test: manual Change-Id: I136d0a8852c49b91315724b16a51bcbdb5890047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559352 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#649302} ash/app_list/app_list_controller_impl.cc | 14 +++++++++++++- ash/app_list/app_list_controller_impl.h | 2 ++ ash/assistant/assistant_controller.cc | 4 ++++ ash/assistant/assistant_controller.h | 2 ++ 4 files changed, 21 insertions(+), 1 deletion(-) commit e71edf47e63a7d518bd5fec9f12818f3bea39f92 Author: chrome-release-bot <chrome-release-bot@chromium.org> Date: Tue Apr 9 22:32:24 2019 +0000 Updating trunk VERSION from 3760.0 to 3761.0 # This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: I40e13e96ba23ccf901d9243cd2cfab29fbe01134 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560441 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#649301} chrome/VERSION | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 47f376e64d42fe3deed62518bd21932ef2f27112 Author: Lucas Tenório <ltenorio@chromium.org> Date: Tue Apr 9 22:31:46 2019 +0000 Add more tests to the AppControllerService. This second batch of tests cover the LaunchHomeUrl method. One small change was made to the AppControllerService to make the tests simple: We no longer read the URL prefix during initialization, instead we do it on demand when trying to launch home URLs. This makes it easier to override the prefix when testing the same service instance. Bug: 927809 Change-Id: I5460b055f6d423cd196b3c5b4b06d723e6abfd67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558411 Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Lucas Tenório <ltenorio@chromium.org> Cr-Commit-Position: refs/heads/master@{#649300} .../kiosk_next_home/app_controller_service.cc | 12 ++-- .../kiosk_next_home/app_controller_service.h | 3 - .../app_controller_service_unittest.cc | 82 ++++++++++++++++++++++ 3 files changed, 89 insertions(+), 8 deletions(-) commit 034efe37d181e01201e27fe0c9810ff7be2bcbc3 Author: Corentin Wallez <cwallez@chromium.org> Date: Tue Apr 9 22:30:46 2019 +0000 Move implementation of GL_sync_point to ImplementationBase This implements SyncTokens for the WebGPU interface by sharing implementations with the raster and gles2 interfaces. All interfaces now inherit from the abstract InterfaceBase class. BUG=chromium:948613 Change-Id: I54cde299d465bdbd7ed9176761ce1a59d4fb3313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1550829 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#649299} cc/raster/raster_buffer_provider_perftest.cc | 2 + components/viz/test/test_gles2_interface.h | 12 ++- gpu/GLES2/gl2chromium_autogen.h | 5 - gpu/command_buffer/build_gles2_cmd_buffer.py | 16 ---- gpu/command_buffer/build_raster_cmd_buffer.py | 9 -- gpu/command_buffer/client/BUILD.gn | 14 +++ gpu/command_buffer/client/gles2_c_lib_autogen.h | 30 ------ gpu/command_buffer/client/gles2_implementation.cc | 103 ++++----------------- gpu/command_buffer/client/gles2_implementation.h | 7 ++ .../client/gles2_implementation_autogen.h | 8 -- gpu/command_buffer/client/gles2_interface.h | 3 +- .../client/gles2_interface_autogen.h | 4 - gpu/command_buffer/client/gles2_interface_stub.cc | 7 ++ gpu/command_buffer/client/gles2_interface_stub.h | 6 ++ .../client/gles2_interface_stub_autogen.h | 4 - .../client/gles2_interface_stub_impl_autogen.h | 7 -- .../client/gles2_trace_implementation.cc | 16 ++++ .../client/gles2_trace_implementation.h | 6 ++ .../client/gles2_trace_implementation_autogen.h | 4 - .../gles2_trace_implementation_impl_autogen.h | 23 ----- gpu/command_buffer/client/implementation_base.cc | 86 +++++++++++++++++ gpu/command_buffer/client/implementation_base.h | 9 ++ gpu/command_buffer/client/interface_base.h | 23 +++++ gpu/command_buffer/client/raster_implementation.cc | 84 ++++------------- gpu/command_buffer/client/raster_implementation.h | 6 ++ .../client/raster_implementation_autogen.h | 6 -- .../client/raster_implementation_gles.cc | 30 +++--- .../client/raster_implementation_gles.h | 11 ++- gpu/command_buffer/client/raster_interface.h | 3 +- .../client/raster_interface_autogen.h | 3 - gpu/command_buffer/client/webgpu_implementation.cc | 24 +++++ gpu/command_buffer/client/webgpu_implementation.h | 9 ++ gpu/command_buffer/client/webgpu_interface.h | 4 +- gpu/command_buffer/gles2_cmd_buffer_functions.txt | 4 - gpu/command_buffer/raster_cmd_buffer_functions.txt | 3 - .../graphics/gpu/drawing_buffer_test_helpers.h | 28 +++--- 36 files changed, 298 insertions(+), 321 deletions(-) commit a03aa43f3e17901586cfa18bfe7765cd1da6d5de Author: Xing Liu <xingliu@chromium.org> Date: Tue Apr 9 22:29:44 2019 +0000 Notification: Fix a crash on Android M and L. NotificationCompatBuilder.build() may throw exception on Android M and L. Possibly when there is no Android user profiles. We don't know the reliable way to reproduce this crash. This issue might be Android bug. This CL adds a try catch block on the crashed function. Also fixed a couple of places where we assume notification object is non-null. We also calls startForeground() with a notification object, currently all Android versions has try catch block inside Service.startForeground() and no Android check to assert notification is not null. Bug: 949794 Change-Id: I9df1aeee3cf0f13168b40bb610042681f9acb657 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555053 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#649298} .../browser/notifications/ChromeNotification.java | 5 +++-- .../notifications/NotificationCompatBuilder.java | 14 +++++++++++++- .../notifications/NotificationManagerProxyImpl.java | 18 ++++++++++++++++++ .../browser/notifications/NotificationUmaTracker.java | 15 +++++++++++++-- tools/metrics/histograms/histograms.xml | 9 +++++++++ 5 files changed, 56 insertions(+), 5 deletions(-) commit 96ef3063ee72e010b905144d053fead3356c028e Author: Justin Cohen <justincohen@google.com> Date: Tue Apr 9 22:29:11 2019 +0000 [ios/web] Always keep transient views on top. In some cases, an transientContentView may be displayed when the CRWWebControllerContainerView has no window. When the CRWWebControllerContainerView is put back in a window and the main webViewContentView is restored, it will obscure the transientContentView. Instead, always keep the transientContentView on top. Bug: 949204 Change-Id: Ifa992620958ac3b7cfeb85d4451e2d13beee7810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559894 Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#649297} ios/web/web_state/ui/crw_web_controller_container_view.mm | 1 + 1 file changed, 1 insertion(+) commit 1a71ff1e6741318ee900e332b1bee7eb13ae55b6 Author: Yuwei Huang <yuweih@chromium.org> Date: Tue Apr 9 22:27:33 2019 +0000 [remoting][FTL] Implement FtlSignalingPlayground This CL implements FtlSignalingPlayground for testing JingleSessionManager::AcceptIncoming() and JingleSessionManager::Connect(). The test currently ends once the session is authenticated. This also changes some spammy VLOG(0) logs to VLOG(1) so that signaling messages are easier to read. Bug: 947337 Change-Id: I33c84c6e06a311ecdf58d3aad7ad6111bc52ef13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554480 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#649296} .../signaling/ftl_message_reception_channel.cc | 6 +- .../signaling/grpc_support/grpc_async_executor.cc | 6 +- .../signaling/grpc_support/grpc_async_request.cc | 2 +- .../grpc_async_server_streaming_request.cc | 6 +- remoting/test/BUILD.gn | 25 +- remoting/test/ftl_signaling_playground.cc | 298 +++++++++++++++++++++ remoting/test/ftl_signaling_playground.h | 82 ++++++ remoting/test/ftl_signaling_playground_main.cc | 32 +++ 8 files changed, 442 insertions(+), 15 deletions(-) commit 1fd2b4c76ad7a69d43882cc783a498f0dbefb78d Author: Eugene But <eugenebut@google.com> Date: Tue Apr 9 22:22:05 2019 +0000 Disable HistoryStateOperationsTest.ReplaceStateThenReload only for slim-nav. The test is not failing if slim-nav is not enabled. Bug: 950263 Change-Id: I71e226e6bc04dff6fa02553aeb69b202d9601007 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560370 Commit-Queue: Eugene But <eugenebut@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#649295} ios/web/navigation/history_state_operations_inttest.mm | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) commit 80a9ba91970a7279ea16ac41e3821c17aefdfc6a Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Apr 9 22:21:50 2019 +0000 Roll src/third_party/dawn 2d4c66d2b865..b4b3ea05ebde (1 commits) https://dawn.googlesource.com/dawn.git/+log/2d4c66d2b865..b4b3ea05ebde git log 2d4c66d2b865..b4b3ea05ebde --date=short --no-merges --format='%ad %ae %s' 2019-04-09 enga@chromium.org Reland "Rename texture.createTextureView to createView to match WebGPU" Created with: gclient setdep -r src/third_party/dawn@b4b3ea05ebde The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:877147 TBR=cwallez@chromium.org Change-Id: I227c6a396e1a207f6f541c65efcf6735cc1a164d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560226 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649294} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 903b9797cc0272cffe9e4577f5f8b740268f8101 Author: John Budorick <jbudorick@chromium.org> Date: Tue Apr 9 22:19:59 2019 +0000 Add //testing/merge_scripts to the analyze blacklist. Bug: 950789 Change-Id: I7af3cd1abf47022f1d95b1b3b66a13bb9984b706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559461 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#649293} testing/buildbot/trybot_analyze_config.json | 1 + 1 file changed, 1 insertion(+) commit a428902b47c1568a01cc72d32fa5f439eed8fa57 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Apr 9 22:17:39 2019 +0000 Roll src/third_party/swiftshader 3d497385cd77..1424ef650142 (2 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/3d497385cd77..1424ef650142 git log 3d497385cd77..1424ef650142 --date=short --no-merges --format='%ad %ae %s' 2019-04-09 sugoi@google.com PipelineCache basic operations support 2019-04-09 sugoi@google.com Fix creating Buffer objects in VK_SHARING_MODE_EXCLUSIVE mode Created with: gclient setdep -r src/third_party/swiftshader@1424ef650142 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: I1fbab0b4b1cbab42e291037b73872f51b335b7ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560227 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649292} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit c0ffc574df33f1b141de04df1b04455bf5b487db Author: Bruno Santos <brunoad@chromium.org> Date: Tue Apr 9 22:16:49 2019 +0000 Setup watchlist for Kiosk Next Home/Shell directories and files. Bug: 927809 Change-Id: I538fd2a67e31fa3184e819ccab195d0c56a5eef7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559991 Commit-Queue: Bruno Santos <brunoad@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#649291} WATCHLISTS | 15 +++++++++++++++ 1 file changed, 15 insertions(+) commit 96ab94f59ee5dad7ed6fc5c272592e91d1c7b7f6 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Apr 9 22:10:00 2019 +0000 Roll src/third_party/angle 3702d8c9d300..e4458b7bb63a (3 commits) https://chromium.googlesource.com/angle/angle.git/+log/3702d8c9d300..e4458b7bb63a git log 3702d8c9d300..e4458b7bb63a --date=short --no-merges --format='%ad %ae %s' 2019-04-09 jmadill@chromium.org Fix glCopyTexSubImage3D. 2019-04-09 syoussefi@chromium.org Rename getCurrentDisplay to getDisplay 2019-04-09 syoussefi@chromium.org Vulkan: fix CPU throttling frames to 2 Created with: gclient setdep -r src/third_party/angle@e4458b7bb63a The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:947342,chromium:None TBR=ynovikov@chromium.org Change-Id: I21e6846bc8a27c2cf8a714900a4cbaede701cbe8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560225 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649290} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 28dccc44d12f721579637eeb2f5baa9dc5123a04 Author: dpapad <dpapad@chromium.org> Date: Tue Apr 9 22:06:40 2019 +0000 WebUIDataSource: Add ability to query whether a URL is handled by a request filter. Before this CL WebUIDataSource::SetRequestFilter() accepted a single callback function as a parameter. That callback was responsible for - communicating via a boolean whether a given URL will be handled. - producing the response (bytes) for this request. This is inflexible, because there are cases where we need to know whether a URL will be handled by the request filter, without triggering the request yet. This is in preparation of simplifying the mechanism that WebUIDataSourceImpl uses to determine when a WebUI resource is gzipped. After this CL: WebUIDataSource::SetRequestFilter() accepts two callback functions. - |should_handle_request_callback| simply returns a boolean, indicating whether the request will be handled by the request filter, without handling the request. - |handle_request_callback| handles the request, without returning any boolean. TBR=jam@chromium.org Bug: 738243 Change-Id: I915b87801908885bcbf05e785bbacf8ad140c481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535164 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: calamity <calamity@chromium.org> Reviewed-by: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#649289} chrome/browser/accessibility/accessibility_ui.cc | 11 +++++--- chrome/browser/ui/webui/chromeos/login/oobe_ui.cc | 3 +- .../ui/webui/print_preview/print_preview_ui.cc | 17 +++++++---- chrome/browser/ui/webui/signin/inline_login_ui.cc | 6 ++-- .../browser/ui/webui/test_files_request_filter.cc | 33 ++++++++++++++++------ .../browser/ui/webui/test_files_request_filter.h | 4 +++ chrome/browser/ui/webui/welcome/welcome_ui.cc | 33 ++++++++++++++-------- .../system_web_app_manager_browsertest.cc | 33 ++++++++++++---------- content/browser/net/network_errors_listing_ui.cc | 11 +++++--- content/browser/tracing/tracing_ui.cc | 20 +++++++------ content/browser/webui/web_ui_data_source_impl.cc | 19 ++++++++++--- content/browser/webui/web_ui_data_source_impl.h | 8 ++++-- .../browser/webui/web_ui_data_source_unittest.cc | 4 +-- content/browser/webui/web_ui_mojo_browsertest.cc | 20 +++++++------ content/public/browser/web_ui_data_source.h | 20 +++++++++---- 15 files changed, 159 insertions(+), 83 deletions(-) commit db108e831f7b807ca72927481f18e13986679880 Author: Daniel Rubery <drubery@chromium.org> Date: Tue Apr 9 22:03:29 2019 +0000 Enable RAR content inspection by default Metrics on Stable look good (see bug for details), so set this to enabled by default. Bug: 909778 Change-Id: I8a7cfacfa28a72943be407186bafdd51d5a98137 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539014 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by: Jay Civelli <jcivelli@chromium.org> Reviewed-by: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#649288} .../public/cpp/sandboxed_rar_analyzer_unittest.cc | 60 +++++++++++++++++----- components/safe_browsing/features.cc | 4 +- 2 files changed, 50 insertions(+), 14 deletions(-) commit 5c427396e31767598b7ff71d64ba7f670470f768 Author: Justin DeWitt <dewittj@chromium.org> Date: Tue Apr 9 22:00:40 2019 +0000 [Touchless] Launch NTP in case of inactivity even if activity is stopped. Change-Id: I4ef7f45a017f24b59dae7dea24f17664c13b3136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555250 Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Sky Malice <skym@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#649287} .../chrome/browser/ChromeInactivityTracker.java | 8 ++++-- .../chrome/browser/touchless/NoTouchActivity.java | 14 +++++++-- .../browser/touchless/NoTouchActivityTest.java | 33 ++++++++++++++++++++++ 3 files changed, 50 insertions(+), 5 deletions(-) commit 5f615bcb8a27f811abbe1f3505c281863b8232cd Author: Kyle Milka <kmilka@chromium.org> Date: Tue Apr 9 21:59:54 2019 +0000 [NTP] Improve middle-slot promo metrics Fix NewTabPage.Promos.RequestLatency to properly capture if a request fails or succeeds and differentiate between succeeding with and without a promo present. Add NewTabPage.Promos.ShownTime to log the time from when an NTP is opened to when the promo is inserted into the page. Add NewTabPage.Promos.LinkClicked to log clicks on links embedded in middle-slot promos. Bug: 937505, 934604 Change-Id: I5f4fdb464929485ba38a7a134de4f4f5112e7670 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504221 Reviewed-by: Ramya Nagarajan <ramyan@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#649286} chrome/browser/resources/local_ntp/local_ntp.js | 14 +++++ chrome/browser/search/local_ntp_source.cc | 15 +++-- chrome/browser/search/promos/promo_service.cc | 47 ++++++++++------ chrome/browser/search/promos/promo_service.h | 26 +++++---- .../search/promos/promo_service_unittest.cc | 25 +++++++-- .../ui/search/local_ntp_promos_browsertest.cc | 64 +++++++++++++++++++--- chrome/browser/ui/search/ntp_user_data_logger.cc | 6 ++ chrome/common/search/ntp_logging_events.h | 7 ++- tools/metrics/histograms/histograms.xml | 44 +++++++++++++-- 9 files changed, 196 insertions(+), 52 deletions(-) commit 700ee14e1d3e20951e583e0db72eed7442669c43 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Apr 9 21:50:14 2019 +0000 Roll src/third_party/SPIRV-Tools/src d90aae9a5a6c..82ebbbba15c2 (2 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/d90aae9a5a6c..82ebbbba15c2 git log d90aae9a5a6c..82ebbbba15c2 --date=short --no-merges --format='%ad %ae %s' 2019-04-09 dneto@google.com README: fix formatting of requiring Python 'future' (#2500) 2019-04-09 stevenperron@google.com Accept OpBitCast in fix storage class. (#2505) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@82ebbbba15c2 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I62b775d43a9deb6d424a516465952f0ffeea4341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559459 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649285} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit fe310832348ef0085b952dc70a361985de667e13 Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Tue Apr 9 21:49:30 2019 +0000 Update V8 to version 7.5.226. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b4c008bb..825bcc75 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I502cefa1b0f3dd52c9aa9f97012afc30df95687c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560022 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649284} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit adfcdff666f31ebf62268dd60febff2569d2f6a8 Author: Yuwei Huang <yuweih@chromium.org> Date: Tue Apr 9 21:49:10 2019 +0000 [remoting][FTL] Implement FtlSignalStrategy This CL implements FtlSignalStrategy similar to XmppSignalStrategy that can be hooked into JingleSessionManager. Bug: 947337 Change-Id: I5ab582c9cb880d99b35c077b376dce5006eb5f75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552104 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#649283} remoting/signaling/BUILD.gn | 4 + .../signaling/ftl_message_reception_channel.cc | 4 + remoting/signaling/ftl_message_reception_channel.h | 1 + remoting/signaling/ftl_messaging_client.cc | 4 + remoting/signaling/ftl_messaging_client.h | 3 + .../signaling/ftl_messaging_client_unittest.cc | 2 + remoting/signaling/ftl_registration_manager.cc | 10 + remoting/signaling/ftl_registration_manager.h | 1 + remoting/signaling/ftl_signal_strategy.cc | 466 +++++++++++++++++++++ remoting/signaling/ftl_signal_strategy.h | 54 +++ .../signaling/grpc_support/grpc_async_executor.cc | 26 +- .../signaling/grpc_support/grpc_async_executor.h | 1 + .../grpc_support/grpc_async_executor_unittest.cc | 25 ++ .../grpc_support/grpc_authenticated_executor.cc | 6 + .../grpc_support/grpc_authenticated_executor.h | 1 + .../grpc_authenticated_executor_unittest.cc | 73 ++++ remoting/signaling/grpc_support/grpc_executor.h | 3 + remoting/signaling/message_reception_channel.h | 3 + remoting/signaling/registration_manager.h | 4 + 19 files changed, 682 insertions(+), 9 deletions(-) commit e540788615521d51000f1cc6aeecb98b90f08f58 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Apr 9 21:47:00 2019 +0000 Roll Fuchsia SDK from 891665364627 to 891662942428 The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ic257eaa06cdd9c7ffd055997fcbe77753d969b04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560222 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649282} build/fuchsia/linux.sdk.sha1 | 2 +- build/fuchsia/mac.sdk.sha1 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit 1b1346b713b22813eef29ab6fffd902479e0f905 Author: Dan Beam <dbeam@chromium.org> Date: Tue Apr 9 21:44:18 2019 +0000 WebUI Dark Mode: increase opacity for toolbar search placeholder text Screenshots: https://imgur.com/a/7sab9SR R=dpapad@chromium.org BUG=950814 Change-Id: I48ce37a3b7fd369fea9f6d3852017a0c423a32f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559398 Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#649281} .../resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) commit aded6463da68cb75848c7062833a0cfcdd1ad4e9 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Tue Apr 9 21:44:14 2019 +0000 flags: remove some obsolete spellcheck flags and switches This change removes: The enable-spelling-feedback-field-trial flag The enable-spelling-feedback-field-trial switch The spelling-service-feedback-interval-seconds switch The spelling-service-feedback-url switch Bug: None Change-Id: I1afd55697edcb5b2fc35a681d232b47ec5cf7f4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560371 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by: Richard Coles <torne@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#649280} .../browser/aw_content_browser_client.cc | 1 - chrome/browser/about_flags.cc | 8 ----- chrome/browser/flag-metadata.json | 5 ---- chrome/browser/flag_descriptions.cc | 4 --- chrome/browser/flag_descriptions.h | 3 -- components/spellcheck/common/BUILD.gn | 2 -- .../spellcheck/common/spellcheck_switches.cc | 35 ---------------------- components/spellcheck/common/spellcheck_switches.h | 23 -------------- components/spellcheck/renderer/spellcheck.cc | 1 - 9 files changed, 82 deletions(-) commit d4c553becb8277f60d8c59756bd81c7dcdebcf47 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Tue Apr 9 21:43:00 2019 +0000 flags: assign overscroll-history-navigation Bug: None Change-Id: I3bd9367fe4ee2eee7df32f3cc6f3a5539f9b08d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559503 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#649279} chrome/browser/flag-metadata.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit bd491a850f4064587abf0667f2db96cebec13682 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Apr 9 21:42:49 2019 +0000 Roll src/third_party/webrtc 6a489f22c71b..d39e2c83b730 (2 commits) https://webrtc.googlesource.com/src.git/+log/6a489f22c71b..d39e2c83b730 git log 6a489f22c71b..d39e2c83b730 --date=short --no-merges --format='%ad %ae %s' 2019-04-09 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision fe4d0c8e0f..56b0d36f99 (649101:649210) 2019-04-09 ilnik@webrtc.org Fix undefined behavior in FrameBuffer Created with: gclient setdep -r src/third_party/webrtc@d39e2c83b730 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:none TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I8b3cfe6247a0d885d67e50c771b89ca4480df7b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560221 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649278} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 573e1d9f901cc4394d54f4492c62cf55bf88826e Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Tue Apr 9 21:39:54 2019 +0000 flags: assign two hosted app flags Bug: 937166 Change-Id: Id928f7ef7dfa8fbdee76971870a22fd3d07af2b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560375 Reviewed-by: ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#649277} chrome/browser/flag-metadata.json | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) commit f5f1412118254fcb36256c241c8ca60ebfebf020 Author: Dominik Laskowski <domlaskowski@chromium.org> Date: Tue Apr 9 21:38:17 2019 +0000 display: Validate content protection requests DisplayConfigurator clients are responsible for renewing their content protection requests when the display configuration changes, as pending tasks will be killed on reconfiguration in a future CL. This CL invokes the failure callback for requests whose display is invalid. Bug: 929449 Test: display_unittests Change-Id: I74d247b8532a7072d7852903d1ce4c4e5006f1c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554004 Commit-Queue: Dominik Laskowski <domlaskowski@chromium.org> Reviewed-by: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#649276} ui/display/manager/display_configurator.cc | 31 ++++++++++++---------- ui/display/manager/display_configurator.h | 2 ++ .../manager/display_configurator_unittest.cc | 21 +++++++++++++++ 3 files changed, 40 insertions(+), 14 deletions(-) commit a19b0cb8618211b427ea25e11aa69b85645611da Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Apr 9 21:33:47 2019 +0000 Roll src/third_party/catapult 3d77140b9d58..4689063021d2 (1 commits) https://chromium.googlesource.com/catapult.git/+log/3d77140b9d58..4689063021d2 git log 3d77140b9d58..4689063021d2 --date=short --no-merges --format='%ad %ae %s' 2019-04-09 rmhasan@google.com Revert "[Typ] Adds new methods to the API of TestSet and runner.py" Created with: gclient setdep -r src/third_party/catapult@4689063021d2 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:951018 TBR=skyostil@chromium.org Change-Id: Ibb09ab7e092b641c618756b3a814c946c532659e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560220 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649275} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e51154d3304a42f89436779c590c011272d70f39 Author: Becca Hughes <beccahughes@chromium.org> Date: Tue Apr 9 21:29:03 2019 +0000 [Media Notification] Add histograms for metadata and artwork Adds two histograms. The first records what metadata was displayed by a notification. The seconds records whether the artwork is present. BUG=949303 Change-Id: Id9c172720503fd0906026ceb141139c70c80e21b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552289 Reviewed-by: Brian White <bcwhite@chromium.org> Reviewed-by: Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#649274} ash/media/media_notification_item.cc | 6 ++++-- ash/media/media_notification_item.h | 3 ++- ash/media/media_notification_view.cc | 27 ++++++++++++++++++++++++++ ash/media/media_notification_view.h | 18 +++++++++++++++++ ash/media/media_notification_view_unittest.cc | 28 +++++++++++++++++++++++++++ tools/metrics/histograms/enums.xml | 7 +++++++ tools/metrics/histograms/histograms.xml | 20 +++++++++++++++++++ 7 files changed, 106 insertions(+), 3 deletions(-) commit 2853116f59f889ac384ddb75a927bb4d915d2a6a Author: Caitlin Fischer <caitlinfischer@google.com> Date: Tue Apr 9 21:26:41 2019 +0000 [Autofill] Clean-up for the two-line layout being enabled by default. Bug: 870342 Change-Id: I680e7984cedbd2de073c1197ecf3780e90a180c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542238 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#649273} chrome/browser/about_flags.cc | 6 - chrome/browser/flag-metadata.json | 6 +- chrome/browser/flag_descriptions.cc | 5 - .../autofill/autofill_popup_view_native_views.cc | 160 +++++++++------------ .../autofill/core/browser/autofill_experiments.cc | 14 -- .../autofill/core/browser/autofill_experiments.h | 29 ---- 6 files changed, 69 insertions(+), 151 deletions(-) commit b2b92c1c848060c0bad8858f6d938f2de9b92f2a Author: Kelvin Jiang <kelvinjiang@chromium.org> Date: Tue Apr 9 21:25:27 2019 +0000 [Extensions] Move logic for parsing host permissions to its own function The code for parsing host permissions is moved to its own function as it will be used in more than one place in a follow up CL which adds a new manifest key for host permissions for Manifest V3. Bug: 62898 Change-Id: I6cbb8bf18048f0abcbdfb57219c87500dee142ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553398 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#649272} .../common/manifest_handlers/permissions_parser.cc | 162 +++++++++++---------- 1 file changed, 83 insertions(+), 79 deletions(-) commit d1429d1898a4028b04b4ecfed32b7647140e1826 Author: Scott Violet <sky@chromium.org> Date: Tue Apr 9 21:24:23 2019 +0000 chromeos: make app-list not layout search-box when closed As part of https://chromium-review.googlesource.com/c/chromium/src/+/1547051 InvalidateLayout() was changed to result in a Layout() at a later date. This means there may be an additional Layout() called. In particular, the app-list now attempts to layout the search-box when closed, which triggers the search-box to go off screen. The fix is to not layout the search box if closed. BUG=949368 TEST=see bug Change-Id: I810ba64a0d44cfedb4f1746697c78b74a303526d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559887 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#649271} ash/app_list/views/contents_view.cc | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) commit 374a30b935017052bca03359b7940e595b9e5a42 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Apr 9 21:21:30 2019 +0000 Roll src/third_party/skia d54b1fcdd915..201b3752e642 (5 commits) https://skia.googlesource.com/skia.git/+log/d54b1fcdd915..201b3752e642 git log d54b1fcdd915..201b3752e642 --date=short --no-merges --format='%ad %ae %s' 2019-04-09 bungeman@google.com Build HarfBuzz with multi-thread support. 2019-04-09 mtklein@google.com remove DMJsonWriter::AddTestFailure 2019-04-09 bsalomon@google.com Temporarily make TransferPixelsFromTest read BGRA as RGBA on ES. 2019-04-09 reed@google.com remove def of colorfilter flag 2019-04-09 reed@google.com New factories for SkShaders Created with: gclient setdep -r src/third_party/skia@201b3752e642 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: I7bfc816e1626436608b3abe8dcdb60400fec63cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560219 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649270} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit addd3c45103535c95fad33e4b31752a7182e9c1d Author: manuk <manukh@chromium.org> Date: Tue Apr 9 21:20:59 2019 +0000 [omnibox] Add a chrome://flag flag for local entities. - Enabling the local entities feature will also enable the rich entities feature. - This CL also updates some outdated flag descriptions and comments. Bug: 950512 Change-Id: Id9be6a3afa1f40b85fd193f5aec37d0bed73cc21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560148 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#649269} chrome/browser/about_flags.cc | 5 +++++ chrome/browser/flag-metadata.json | 5 +++++ chrome/browser/flag_descriptions.cc | 23 +++++++++++------------ chrome/browser/flag_descriptions.h | 6 +++--- components/omnibox/browser/omnibox_field_trial.cc | 7 ++----- components/omnibox/browser/omnibox_field_trial.h | 11 ++++------- components/omnibox/common/omnibox_features.cc | 6 ++++++ components/omnibox/common/omnibox_features.h | 1 + tools/metrics/histograms/enums.xml | 2 ++ 9 files changed, 39 insertions(+), 27 deletions(-) commit 726e27fe944aed75bdcbf4d694f12a04c1e8939c Author: Doug Arnett <dougarnett@chromium.org> Date: Tue Apr 9 21:14:48 2019 +0000 [Previews] Adds excluded optimization hint experiment support. Adds new Hint Optimization proto field: excluded_experiment_name and adds implementation support to consider an optimization as disabled if it has an excluded_experiment_name that matches the client's kOptimizationHintsExperiments name. This is the preferred approach to supporting an FCP feedback based server blacklist experiment. Bug: 950532 Change-Id: Ifbcbbb5d27b8a4c3f86e3abeeda84c3fd44351cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559258 Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#649268} components/optimization_guide/proto/hints.proto | 10 ++- components/previews/content/previews_hints.cc | 4 +- .../previews/content/previews_hints_unittest.cc | 80 ++++++++++++++++++++++ components/previews/content/previews_hints_util.cc | 21 +++--- components/previews/content/previews_hints_util.h | 9 ++- 5 files changed, 108 insertions(+), 16 deletions(-) commit 26551c5cf0b41143dc1665a9a72b7a6d9dd043a7 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Tue Apr 9 21:14:13 2019 +0000 Roll src-internal 572984e9ca2b..de427f13cef6 (6 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/572984e9ca2b..de427f13cef6 Created with: gclient setdep -r src-internal@de427f13cef6 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=huangs@chromium.org,battre@chromium.org,collinbaker@chromium.org,tasak@chromium.org Change-Id: I99f8415b73f2579c378f0a0b264b773031a92235 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560218 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649267} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 6d7abad801ae502125f7461856b46795a7e0fcb2 Author: Yue Ru Sun <yrsun@chromium.org> Date: Tue Apr 9 21:11:32 2019 +0000 Normalize UKM entry to avoid cache duplication Bug: 944942 Change-Id: I23b7909483f85a704ca02abd99dcbe96306875be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559752 Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Yue Ru Sun <yrsun@chromium.org> Cr-Commit-Position: refs/heads/master@{#649266} components/ukm/debug/ukm_internals.js | 23 ++++++++++++++++++----- 1 file changed, 18 insertions(+), 5 deletions(-) commit 10f04d6a09bdb1f87023bfed6297a0357df66334 Author: Sammie Quon <sammiequon@google.com> Date: Tue Apr 9 21:11:22 2019 +0000 overview: Back and esc should not exit single splitview. Test: added test Bug: 950100 Change-Id: Ia05e481a15ac3c42bdfef075b5f1b930f37f3605 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559253 Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#649265} ash/wm/overview/overview_session.cc | 5 ++++- ash/wm/overview/overview_session_unittest.cc | 18 +++++++++++++++--- 2 files changed, 19 insertions(+), 4 deletions(-) commit c33140884d5968761542a69fa32477a584a67f3f Author: Corentin Wallez <cwallez@chromium.org> Date: Tue Apr 9 21:09:04 2019 +0000 Enable use_dawn by default on Mac Mac is the first platform where WebGPU is implemented. Enabling use_dawn there makes sure that dawn-related tests are run on the CQ, and allows developers to use Mac Canary to test WebGPU. BUG=chromium:852089 Change-Id: Ic076afbe4d6d9efe97bee7bb56f0d375a35bec5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559319 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#649264} ui/gl/features.gni | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 283f3302d42dc7d10f4535f389e4fd8787459ced Author: Paul Miller <paulmiller@google.com> Date: Tue Apr 9 21:06:38 2019 +0000 WebView: Add histograms for variations seed loading WebView times out while waiting for the seed too frequently, and the current metrics don't explain why. We record Variations.SeedLoadResult and Variations.SeedLoadBlockingTime, but these are rather coarse measurements. Add Variations.SeedLoadSuccessTime, specifically for loading the seed file, and Variations.SeedLoadWouldBlockTime, to measure how long loading would take if not for the timeout. The latter should show how much we'd have to increase the timeout in order to improve the success rate. BUG=936172 Change-Id: Ia3fcd7bfdf394a4e6e4bdd85a2c6682425552194 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552487 Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Changwan Ryu <changwan@chromium.org> Commit-Queue: Paul Miller <paulmiller@chromium.org> Cr-Commit-Position: refs/heads/master@{#649263} .../android_webview/VariationsSeedLoader.java | 49 ++++++++++++++++++---- tools/metrics/histograms/histograms.xml | 32 ++++++++++++-- 2 files changed, 71 insertions(+), 10 deletions(-) commit 1ecf92e04d2883c9c25078042e3bf693110a9e78 Author: Josh Horwich <jhorwich@chromium.org> Date: Tue Apr 9 21:05:12 2019 +0000 arc: Avoid turning on BT discoverable mode. Current ARC Bluetooth bridge assumes that setting of discoverable timeout implies the adapter should go into discoverable mode. This change tracks the discoverable timeout separately from the actual transition to discoverable mode, and only puts the adapter into discoverable mode when the scan mode is set to discoverable. Bug: 945076 Test: OOBE flow on kevin Change-Id: I5b154af261563bb4d241327c81bb9a819259dcce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559992 Reviewed-by: Miao-chen Chou <mcchou@chromium.org> Reviewed-by: Yusuke Sato <yusukes@chromium.org> Commit-Queue: Josh Horwich <jhorwich@chromium.org> Cr-Commit-Position: refs/heads/master@{#649262} .../chromeos/arc/bluetooth/arc_bluetooth_bridge.cc | 18 +++++++++--------- .../chromeos/arc/bluetooth/arc_bluetooth_bridge.h | 2 ++ 2 files changed, 11 insertions(+), 9 deletions(-) commit 2508283053a3e6553485b2c7a9688e3ffa3d3640 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Apr 9 21:04:34 2019 +0000 Roll src/third_party/swiftshader 3ed8ba0c5a4b..3d497385cd77 (8 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/3ed8ba0c5a4b..3d497385cd77 git log 3ed8ba0c5a4b..3d497385cd77 --date=short --no-merges --format='%ad %ae %s' 2019-04-09 bclayton@google.com src/Pipeline: Add SIMD::Pointer 2019-04-09 bclayton@google.com SpirvShader: Implement OpBitFieldInsert 2019-04-09 bclayton@google.com SpirvShader: Implement OpBitFieldSExtract and OpBitFieldUExtract 2019-04-09 bclayton@google.com SpirvShader: Implement OpBitReverse 2019-04-09 bclayton@google.com SpirvShader: Implement OpBitCount 2019-04-09 bclayton@google.com SpirvShader: Implement OpTranspose 2019-04-09 bclayton@google.com SpirvShader: Implement OpOuterProduct 2019-04-09 bclayton@google.com SpirvShader: Add type field to GenericValue Created with: gclient setdep -r src/third_party/swiftshader@3d497385cd77 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/126126820,chromium:b/126873455,chromium:b/126873455,chromium:b/126873455,chromium:b/126873455,chromium:b/126873455,chromium:b/126873455 TBR=swiftshader-team+autoroll@chromium.org Change-Id: Icef00374eae583f1b0fa34ec982d0d844b1595ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560174 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649261} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 9ff78cd61641156cd994db4e51dc29dc744e7344 Author: Takuto Ikuta <tikuta@chromium.org> Date: Tue Apr 9 21:00:56 2019 +0000 Run more tests on win10 debug bot This is preparation CL to enable some tests on win10_chromium_x64_rel_ng builder. I don't have mini_installer_tests due to some cases fail. Bug: 950584 Cq-Include-Trybots: luci.chromium.try:win10_chromium_x64_dbg_ng Change-Id: Ic4dcf82a80b6a8a5309a6f8365ebadfd53a6627e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559090 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#649260} testing/buildbot/chromium.win.json | 51 ++++++++++++++++++++++++++++++++++++++ testing/buildbot/test_suites.pyl | 8 ++++++ testing/buildbot/waterfalls.pyl | 2 +- 3 files changed, 60 insertions(+), 1 deletion(-) commit fe8946d3318dae9f4f6a0fbfe753df56f7d6d04b Author: May Lippert <maybelle@chromium.org> Date: Tue Apr 9 20:59:09 2019 +0000 Add unoptimized build configs for new OS settings Build this by setting optimize_webui = false (default is true) What's in this change: - Move os_settings.html to c/b/r/settings/chromeos - Add new os_settings_resources.grd What's still WIP: - Optimized webui build BUG=950007 Change-Id: I752153668877a25a29b315cb82456ed564fd52df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553820 Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: May Lippert <maybelle@chromium.org> Auto-Submit: May Lippert <maybelle@chromium.org> Cr-Commit-Position: refs/heads/master@{#649259} chrome/BUILD.gn | 1 + chrome/browser/browser_resources.grd | 3 - chrome/browser/resources/BUILD.gn | 31 +++++++++++ chrome/browser/resources/chromeos/os_settings.html | 7 --- .../browser/resources/settings/chromeos/BUILD.gn | 65 ++++++++++++++++++++++ .../resources/settings/chromeos/lazy_load.html | 14 +++++ .../resources/settings/chromeos/os_settings.html | 19 +++++++ .../resources/settings/os_settings_resources.grd | 25 +++++++++ .../settings/os_settings_resources_vulcanized.grd | 24 ++++++++ .../ui/webui/settings/chromeos/os_settings_ui.cc | 9 ++- chrome/chrome_paks.gni | 2 + tools/gritsettings/resource_ids | 38 +++++++------ 12 files changed, 210 insertions(+), 28 deletions(-) commit c3e3793b3e7b8ac42b35aea22ce28f69208132c1 Author: Tony de Luna <tonydeluna@chromium.org> Date: Tue Apr 9 20:58:48 2019 +0000 Reland "Increase coverage for EULA browser tests" This is a reland of 426df2bedfa0c4c6bf9bcccaef6caf981c9a426c Original change's description: > Increase coverage for EULA browser tests > > Adds tests for: > * Clicking on "System security settings" button in EULA screen > * Accepting and rejecting usage stats collection > * Clicking on "Learn more" button in EULA screen > > Removes dead code from EulaScreen class. > > Adds a HelpApp extension manifest to use in tests and modifies > HelpAppLauncher class to allow tests to set the extension id. > > Adds a HelpAppTestHelper class to facilitate writing tests that > open HelpApp dialogs. > > Change-Id: Id7841be5bf3faabb067d3a75d3b034bdf0e00e32 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554123 > Commit-Queue: Tony De Luna <tonydeluna@chromium.org> > Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> > Reviewed-by: Toni Baržić <tbarzic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#648759} TBR=hashimoto Bug: 947358 Change-Id: I23865c1957f300f55812f3275e830772aa27c32d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560146 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Commit-Queue: Tony De Luna <tonydeluna@chromium.org> Cr-Commit-Position: refs/heads/master@{#649258} chrome/browser/chromeos/BUILD.gn | 2 + chrome/browser/chromeos/login/eula_browsertest.cc | 161 ++++++++++++++++++++- chrome/browser/chromeos/login/help_app_launcher.cc | 21 ++- chrome/browser/chromeos/login/help_app_launcher.h | 3 + .../browser/chromeos/login/screens/eula_screen.cc | 18 --- .../chromeos/login/test/help_app_test_helper.cc | 86 +++++++++++ .../chromeos/login/test/help_app_test_helper.h | 57 ++++++++ chrome/browser/chromeos/login/test/js_checker.cc | 4 +- .../resources/chromeos/login/oobe_eula.html | 4 +- .../extensions/api_test/help_app/manifest.json | 8 + .../data/extensions/api_test/help_app/oobe.html | 9 ++ chromeos/dbus/cryptohome/fake_cryptohome_client.cc | 4 +- chromeos/dbus/cryptohome/fake_cryptohome_client.h | 3 + 13 files changed, 353 insertions(+), 27 deletions(-) commit 1122a79d433ba08e80dcd52ee1072e5b929931f8 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Tue Apr 9 20:57:01 2019 +0000 [Chromecast] Remove unneccessary tabs custom bindings The `tabs` custom bindings have been entirely replaced by native counterparts. Remove the JS version. Bug: 938998 Change-Id: I7a55e00fb2bf008bcecae6c3b00179040f6aba8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559255 Reviewed-by: Luke Halliwell <halliwell@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#649257} .../cast_extensions_dispatcher_delegate.cc | 1 - .../resources/extensions/tabs_custom_bindings.js | 51 ---------------------- .../resources/extensions_renderer_resources.grd | 1 - 3 files changed, 53 deletions(-) commit 7043ec9f08a9169264144c208e17d16c89aee350 Author: Mike Wasserman <msw@chromium.org> Date: Tue Apr 9 20:53:38 2019 +0000 ws: Allow re-embedding in CompleteScheduleEmbedForExistingClient Destroy old embeddings as needed when a new one is requested. Bug: 944699 Test: No flaky window service DCHECKs running files app browser tests. Change-Id: I77d681b222a3e6608354f72dfe2663d7574e2c37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559336 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Michael Wasserman <msw@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#649256} .../server_remote_view_host_unittest.cc | 2 +- services/ws/window_service.cc | 6 ++-- services/ws/window_service.h | 5 +-- services/ws/window_service_unittest.cc | 40 +++++++++++++++++++--- 4 files changed, 42 insertions(+), 11 deletions(-) commit 9f87c074e7b0e0c142830cdf8fe686abff6582b4 Author: John Budorick <jbudorick@chromium.org> Date: Tue Apr 9 20:51:16 2019 +0000 Split testing/scripts/sizes.py by compile targets. This script is currently only invoked for cronet, but when we switch the perf bots to invoking it for chrome & webview, we can create separate chrome_sizes and webview_sizes scripts to similarly handle the compile targets. Bug: 861983 Change-Id: I98a77cedc40b356be0a07268fcb511e657c73ea9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560141 Reviewed-by: Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#649255} testing/buildbot/chromium.android.fyi.json | 2 +- testing/buildbot/chromium.android.json | 12 ++++++------ testing/buildbot/test_suites.pyl | 2 +- testing/scripts/cronet_sizes.py | 22 ++++++++++++++++++++++ testing/scripts/get_compile_targets.py | 3 ++- testing/scripts/{sizes.py => sizes_common.py} | 21 --------------------- 6 files changed, 32 insertions(+), 30 deletions(-) commit e980ca505f330c64f33612490b7d4652f07e0831 Author: Mike Reed <reed@google.com> Date: Tue Apr 9 20:49:47 2019 +0000 add flag to stage change to shader factories Bug: skia:8937 Change-Id: I59be04380805a78b7a9e24721e4f4349797735f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558685 Commit-Queue: Mike Reed <reed@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#649254} skia/config/SkUserConfig.h | 4 ++++ 1 file changed, 4 insertions(+) commit e8fa5a496b3c1a00f8abd053d2e7bdbd3b40768c Author: Sigurdur Asgeirsson <siggi@chromium.org> Date: Tue Apr 9 20:44:21 2019 +0000 PM: Endow ProcessNode with a base::Process in addition to process_id. This simplifies the property setter interfaces and allows using the process without race on the PM sequence (on Windows). Bug: 910288 Change-Id: I15a5e25a8ee3ab5f08464c819475a298491da11f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558573 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#649253} .../browser_child_process_watcher.cc | 10 ++-- .../performance_manager/graph/graph_unittest.cc | 37 +++++++++---- .../performance_manager/graph/mock_graphs.cc | 25 ++++++--- .../performance_manager/graph/mock_graphs.h | 19 +++++-- .../graph/node_attached_data_unittest.cc | 2 +- .../performance_manager/graph/process_node_impl.cc | 61 +++++++++++++--------- .../performance_manager/graph/process_node_impl.h | 14 ++++- .../graph/process_node_impl_unittest.cc | 37 ++++++++----- .../observers/working_set_trimmer_win.cc | 20 +++---- .../observers/working_set_trimmer_win_unittest.cc | 27 ++++------ .../render_process_user_data.cc | 11 ++-- 11 files changed, 156 insertions(+), 107 deletions(-) commit 4ec570dc48423187f0c7492c2931c39805f67f13 Author: Mehran Mahmoudi <mahmoudi@chromium.org> Date: Tue Apr 9 20:42:57 2019 +0000 Add Apphooks call for creating TouchlessMenuCoordinator This adds a new Apphooks method that instantiates TouchlessMenuCoordinator. Link to the internal CL in the bug. Bug: 930744 Change-Id: I5f7bf87b50633b793980e6dd945952f8b096910b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559018 Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#649252} chrome/android/java/src/org/chromium/chrome/browser/AppHooks.java | 5 +++++ .../src/org/chromium/chrome/browser/touchless/NoTouchActivity.java | 1 + 2 files changed, 6 insertions(+) commit 2c60346f3f39d0f8117468def9cfff37faaec676 Author: Takumi Fujimoto <takumif@chromium.org> Date: Tue Apr 9 20:42:27 2019 +0000 [Mirroring Service] Show tab capture indicator icon When mirroring a tab using the Mirroring Service, show an indicator icon on the tabstrip. Bug: 889942 Change-Id: I3e95484e01d84ac94d3afd400703ccc19119bb9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1550637 Reviewed-by: Yuri Wiitala <miu@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#649251} .../browser/media/cast_mirroring_service_host.cc | 18 ++++++ chrome/browser/media/cast_mirroring_service_host.h | 9 +++ .../cast_mirroring_service_host_browsertest.cc | 66 ++++++++++++++++++++++ 3 files changed, 93 insertions(+) commit f24c956ac4f6edaa96326da5fe145de2efaede13 Author: Daniel Cheng <dcheng@chromium.org> Date: Tue Apr 9 20:40:05 2019 +0000 base::Optional: CHECK if attempting to dereference no set value. base::Optional::value() already does this; change operator* and operator-> to match, and ensure the behavior is tested. Change-Id: Id686b86d0e68360dea3a92d01206aefde6782a16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531498 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#649250} base/optional.h | 12 ++++++------ base/optional_unittest.cc | 24 ++++++++++++++++++++++++ 2 files changed, 30 insertions(+), 6 deletions(-) commit 2f89e5300bf4fd84c1a06c0e5bac015bd11b3abc Author: Meilin Wang <meilinw@google.com> Date: Tue Apr 9 20:23:24 2019 +0000 Add a chromeos swicth to redirect libassistant logging. This change adds a new chromeos switch "redirect-libassistant-logging" to control redirect libassistant logging from /home/chronos/user/log to /var/log/chrome. One scenario to use this switch is in the Tast integration tests, where we want to export libassistant.log into the test result package to help debugging test failure. The previous logging directory /home/chronos/user is an encrypted user home directory, so we need to move the log to /var/log/chrome where Tast collects newly-written data after running all tests. Bug: 950197. Test: local compile and manually test. Change-Id: I4f5124d53d1c55f03738b9823c82dc83c3e3580f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560145 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by: Tao Wu <wutao@chromium.org> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#649249} chromeos/constants/chromeos_switches.cc | 3 +++ chromeos/constants/chromeos_switches.h | 2 ++ chromeos/services/assistant/utils.cc | 16 ++++++++++++---- 3 files changed, 17 insertions(+), 4 deletions(-) commit 0744b2bc6dffdfd5ec7928be5dc66c4f90c16ca0 Author: dpapad <dpapad@chromium.org> Date: Tue Apr 9 20:19:14 2019 +0000 WebUI cleanup: Rename IDR_MD_EXTENSIONS_ to IDR_EXTENSIONS_. This is part of the effort to remove unnecessary "md_" prefixes from various parts of the WebUI codebase. Bug: 887150 Change-Id: I5769e7064e8acd359a3293a42a3bded90072d0c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559460 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#649248} .../md_extensions/extensions_resources.grd | 142 ++++++++++----------- .../extensions_resources_vulcanized.grd | 23 +++- .../browser/ui/webui/extensions/extensions_ui.cc | 10 +- 3 files changed, 96 insertions(+), 79 deletions(-) commit 58bdbbf1c450e6be2b1a106a00c81cd357d4fceb Author: Josh Nohle <nohle@google.com> Date: Tue Apr 9 20:18:55 2019 +0000 Convert long_device_id field type from "bytes" to "string" This CryptAuth backend CL converted the long_device_id field of the ClientAppMetadata proto from type "bytes" to type "string": https://critique.corp.google.com/#review/242222308. Because Chrome OS has already been setting this field with a string, this change should have no effect. Note: This change is only necessary for v2 Enrollment; v1 code should remain the same. Bug: 899080 Change-Id: Icf4bd1c93b0c6aaad4a5245de8c882baa7b31f7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559757 Reviewed-by: Jeremy Klein <jlklein@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#649247} .../device_sync/proto/cryptauth_client_app_metadata.proto | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) commit 045305828c1225da52562d2c782ecfb33f37a68e Author: Jun Mukai <mukai@chromium.org> Date: Tue Apr 9 20:16:54 2019 +0000 Remove unnecessary SchedulePaint on BrowserNonClientFrameViewAsh This SchedulePaint causes to request repaints of the entire browser frame when overview-mode / splitview-mode changes. This can cause significant load on GPU, especially when there are many browser windows, and actually this is unnecessary because View::SetVisible change invalidates the painting of its bounds. I tried on nocturne with 15 browser windows; the toggle overview by key changes the Overview.AnimationSmoothness histogram as; - Enter: 18.9 -> 86.9 - Exit: 7.2 -> 61.3 Bug: 949227 Test: manually Change-Id: I9a71776a66d4b609027d18c17f6796114fdb3f82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560019 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#649246} chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc | 3 --- 1 file changed, 3 deletions(-) commit b6397cf5c42e32b384ca5fcee61bfe62d60e18fd Author: David Tseng <dtseng@chromium.org> Date: Tue Apr 9 20:15:44 2019 +0000 Reland: Use AXNode::GetSetSize/AXNode::GetPosInSet unconditionally Fixed issue by only using the AXTree::GetPosInSet/AXTree::GetSetSize heuristics if they provide a nonzero answer. Otherwise, fall back to raw attributes. This also exposes pos in set/set size if they are set without doing a role check as some renderers like ARC++ have no such restrictions. TBR=dmazzoni@chromium.org Original change description: This moves ChromeVox to use AXNode::GetSetSize and AXNode::GetPosInSet through their automation bindings. One issue is fixed: In AXTree:PopulateOrderedSetItems, an assumption is made that the first child node of the ordered set node, should determine the hierarchical level of the current layer of items. Unfortunately, for trees like: tree static text tree item ... this hueristic fails. See output_test.extjs::NestedLists. Test: browser_tests --gtest_filter=ChromeVoxOutput*.* Change-Id: I54911673215e245808a88fab07275a83c2d7109d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536470 Reviewed-by: David Tseng <dtseng@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Akihiro Ota <akihiroota@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#645669} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560015 Cr-Commit-Position: refs/heads/master@{#649245} .../chromeos/chromevox/cvox2/background/output.js | 65 ++++------------------ .../automation_internal_custom_bindings.cc | 10 ++-- ui/accessibility/ax_tree.cc | 17 +++--- 3 files changed, 25 insertions(+), 67 deletions(-) commit 4aa85f1c61ca9028c944026368943580282d6097 Author: Mei Liang <meiliang@chromium.org> Date: Tue Apr 9 20:13:41 2019 +0000 [UMA] Add undo closed tab user action for TabGroups UI This CL adds the following user actions for TabGroups UI: * GridTabSwitcher.UndoCloseTab * GridTabSwitcher.UndoCloseTabGroup * TabGridSheet.UndoCloseTab * TabStrip.UndoCloseTab Bug: 950190 Change-Id: Ic456b9f118e185f62c3866492e77ade27b51f7aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553090 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#649244} .../tab_management/GridTabSwitcherCoordinator.java | 2 +- .../tab_management/TabGridSheetCoordinator.java | 2 +- .../tab_management/TabGroupUiCoordinator.java | 2 +- .../tasks/tab_management/TabListMediator.java | 65 ++++++++++++++++++++++ tools/metrics/actions/actions.xml | 32 +++++++++++ 5 files changed, 100 insertions(+), 3 deletions(-) commit 8da36dff60030fd07ec764de0c25e7b77abdd791 Author: Amit Hilbuch <amithi@chromium.org> Date: Tue Apr 9 20:09:56 2019 +0000 Changing WPT for addTransceiver() to accomodate RID format validation. WPT tests will now fail with different error message (due to RTCError not being translated correctly). Tests are disabled temporarily until WebRTC change is merged. Bug: webrtc:10491 Change-Id: I89525bbe51a6606e71affa0e035b9e12f828b02c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560330 Reviewed-by: Steve Anton <steveanton@chromium.org> Commit-Queue: Amit Hilbuch <amithi@chromium.org> Cr-Commit-Position: refs/heads/master@{#649243} third_party/blink/web_tests/TestExpectations | 3 +++ .../wpt/webrtc/RTCPeerConnection-addTransceiver.https-expected.txt | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) commit a5eb6b467739852ee97f257684a7a2703ff266a8 Author: Tanya Gupta <tgupta@chromium.org> Date: Tue Apr 9 20:07:37 2019 +0000 [SendTabToSelf] Changed the text inside the Android Notification. Bug: 941124 Change-Id: I0955071e3aefccbe947752bd9ceea4fb8edfe088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559397 Commit-Queue: sebsg <sebsg@chromium.org> Reviewed-by: sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#649242} .../send_tab_to_self/NotificationManager.java | 24 +++++++++++++--------- .../java/strings/android_chrome_strings.grd | 3 +++ .../android_notification_handler.cc | 1 + 3 files changed, 18 insertions(+), 10 deletions(-) commit b2f34f2c82e940e75b55443d16cccffa2f4aff09 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Apr 9 20:02:35 2019 +0000 Roll src/third_party/skia 80658204f417..d54b1fcdd915 (5 commits) https://skia.googlesource.com/skia.git/+log/80658204f417..d54b1fcdd915 git log 80658204f417..d54b1fcdd915 --date=short --no-merges --format='%ad %ae %s' 2019-04-09 nifong@google.com full collection of externs 2019-04-09 herb@google.com Reland "Handle translating blob to origin in bulk" 2019-04-09 halcanary@google.com SkPDF: move annotations away from device. 2019-04-09 mtklein@google.com some refactoring ideas 2019-04-09 ethannicholas@google.com SkSL 'key' variables can now be controlled by 'when' expressions Created with: gclient setdep -r src/third_party/skia@d54b1fcdd915 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: I4cf00e7fb7a99cec5e74606bcdb4f625c4e87d3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560173 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649241} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 49938bfdddf504602e3e0077e288b623994b21ab Author: Caroline Rising <corising@chromium.org> Date: Tue Apr 9 20:00:29 2019 +0000 Mirror or offset bubble arrow if bubble exits parent window. Prior behavior was for bubbles to stay within the screen bounds. With this change the bubble will also attempt to stay within the parent window bounds (if one exist) while always staying within the screen bounds. Also add ability for any bubble to offset if out of given bounds instead of mirror. This behavior is used for tab hover cards. Bug: 910739 Change-Id: Ib1137646e818b09fe5192896414be9686d1e01fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552284 Reviewed-by: Dana Fried <dfried@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#649240} .../ui/views/tabs/tab_hover_card_bubble_view.cc | 5 + ui/views/bubble/bubble_border.h | 1 + ui/views/bubble/bubble_frame_view.cc | 115 +++-- ui/views/bubble/bubble_frame_view.h | 35 +- ui/views/bubble/bubble_frame_view_unittest.cc | 498 ++++++++++++++++----- 5 files changed, 501 insertions(+), 153 deletions(-) commit 75430c45379a36095ba725f0d41b71c1924e51d4 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Tue Apr 9 19:58:30 2019 +0000 Roll src-internal cce609cb3785..572984e9ca2b (5 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cce609cb3785..572984e9ca2b Created with: gclient setdep -r src-internal@572984e9ca2b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:949743,chromium:946405 TBR=huangs@chromium.org,battre@chromium.org,collinbaker@chromium.org,tasak@chromium.org Change-Id: Ife907dace76f72caafa13309fc4a8b1340a5261f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558763 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649239} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit fe899e47aadbcf5262e6706f67792bac33bd1b69 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Apr 9 19:56:45 2019 +0000 Roll src/third_party/angle fc15ae5571b3..3702d8c9d300 (2 commits) https://chromium.googlesource.com/angle/angle.git/+log/fc15ae5571b3..3702d8c9d300 git log fc15ae5571b3..3702d8c9d300 --date=short --no-merges --format='%ad %ae %s' 2019-04-09 geofflang@chromium.org Propogate dirty bit signals from TextureImpl to Texture up to Context. 2019-04-09 timvp@google.com Re-Enable MipmapTest.TextureCubeGeneralLevelZero/ES2_VULKAN Created with: gclient setdep -r src/third_party/angle@3702d8c9d300 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:949985 TBR=ynovikov@chromium.org Change-Id: I85b61516d4fd1c118469780b5650f2107ff6050a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560212 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649238} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit eaec33fbc2bacab55f63c1790ecd0b83d8cc03ae Author: Raul Tambre <raul@tambre.ee> Date: Tue Apr 9 19:55:44 2019 +0000 //base: Convert print statements to Python 3 style Ran "2to3 -w -n -f print ./base" and manually added imports. There are no intended behaviour changes. Bug: 941669 Change-Id: If5eb9217385a6d9a7807a4ca03116e1db9999695 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559958 Commit-Queue: Raul Tambre <raul@tambre.ee> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Auto-Submit: Raul Tambre <raul@tambre.ee> Cr-Commit-Position: refs/heads/master@{#649237} base/android/jni_generator/jni_generator.py | 8 +++++--- base/android/jni_generator/jni_generator_tests.py | 20 +++++++++++--------- base/android/jni_generator/jni_refactorer.py | 2 ++ base/win/embedded_i18n/create_string_rc.py | 15 +++++++++------ 4 files changed, 27 insertions(+), 18 deletions(-) commit fe27ac42b614ed4bfff46605fb887c1c1225dcf9 Author: khmel@chromium.org <khmel@chromium.org> Date: Tue Apr 9 19:54:29 2019 +0000 arc: Limit locale/preferredLanguages for autotest. In case arc-disable-locale-sync is used this limits ARC container to start with 'en-US' as a locale and 'en-US,en' as preferred languages. This stabilizes tests that expects UI resources be fixed in English. There is an alternative solution that could be implemented when needed to pass required combination as a switch. However this is not required at this time once we don't have such auto-tests. TEST=Set locale for local test account to 'ru' and confirmed that cheets_AppCompatTest.clamshell.com.google.android.apps.books is failing similar as described in bug. Apply this patch and test passes. BUG=b:130142125 Change-Id: I2219207d2d75c00c6ee04590e430a929389c7319 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559463 Reviewed-by: Yusuke Sato <yusukes@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#649236} chrome/browser/chromeos/arc/arc_session_manager.cc | 10 +++++++++- chromeos/constants/chromeos_switches.cc | 4 +++- 2 files changed, 12 insertions(+), 2 deletions(-) commit 28e20a2a766058bce5ded9fa81ca3f4d4f983986 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Tue Apr 9 19:54:05 2019 +0000 [Extensions] Add an install warning for too-high manifest versions Add an install warning for extensions added with a higher manifest version than is fully supported. We use a warning (rather than an error) so the extension still loads, and runs as best it can. Bug: 950647 Change-Id: I32ae2b21bb8cc83e2ec0effaab6d58324a93a25d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559021 Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#649235} extensions/common/extension.cc | 28 ++++++++++++++++++++++++---- extensions/common/extension_unittest.cc | 27 +++++++++++++++++++++++---- extensions/common/manifest_constants.cc | 3 +++ extensions/common/manifest_constants.h | 1 + 4 files changed, 51 insertions(+), 8 deletions(-) commit f206ba57883772711bd0f0a28653efcc671ac8e6 Author: Dominik Laskowski <domlaskowski@chromium.org> Date: Tue Apr 9 19:49:56 2019 +0000 display: Simplify content protection task deferral DisplayConfigurator serializes asynchronous content protection requests by storing pending query/apply tasks as closures in a queue. It also maintains queues for the query/apply callbacks supplied by the client. This CL consolidates the queues by relating QueryContentProtectionTask and ApplyContentProtectionTask by a common base class. It also replaces the Boolean for task success/failure with tri-state, whose extra bit is used to distinguish killed tasks during DisplayConfigurator destruction and (in a future CL) display reconfiguration. Bug: 929449 Test: display_unittests Change-Id: I3640b657ed5952c40e0999836ae92287984a3e9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495201 Reviewed-by: Daniel Nicoara <dnicoara@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Dominik Laskowski <domlaskowski@chromium.org> Cr-Commit-Position: refs/heads/master@{#649234} .../manager/apply_content_protection_task.cc | 19 ++-- ui/display/manager/apply_content_protection_task.h | 9 +- .../apply_content_protection_task_unittest.cc | 18 ++-- ui/display/manager/display_configurator.cc | 117 +++++++++------------ ui/display/manager/display_configurator.h | 32 ++++-- .../manager/query_content_protection_task.cc | 15 ++- ui/display/manager/query_content_protection_task.h | 10 +- .../query_content_protection_task_unittest.cc | 22 ++-- 8 files changed, 121 insertions(+), 121 deletions(-) commit b7b92d6f59b09192d6cca928a2bfe939d5bd9295 Author: Mehran Mahmoudi <mahmoudi@chromium.org> Date: Tue Apr 9 19:48:19 2019 +0000 Fix progress bar problem in touchless mode This fixes an issue which prevented the progress bar to be dismissed. Bug: 950988 Change-Id: I790b0eb4a3ef02b2d166edbc6e636c2803067e2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560018 Auto-Submit: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#649233} .../chrome/browser/touchless/ui/progressbar/ProgressBarViewBinder.java | 1 - 1 file changed, 1 deletion(-) commit 05ddf82cfb1a7cfe7ad26f2e793a7d02a3a111f9 Author: Greg Thompson <grt@chromium.org> Date: Tue Apr 9 19:40:42 2019 +0000 Log the process lineage of unexpected focused windows. We find that C:\Windows\System32\OpenWith.exe sometimes has focus and prevents tests from running to completion. This change logs the command line of the process and of its ancestors. With luck, this will shed a little more light on why this window appears. BUG=711256 Change-Id: I0553665f5f36e1e2be5be268479d5095a5771b88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559073 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#649232} chrome/test/BUILD.gn | 2 + .../test/base/always_on_top_window_killer_win.cc | 63 ++-------------------- chrome/test/base/interactive_test_utils_win.cc | 20 ++++--- chrome/test/base/process_lineage_win.cc | 56 +++++++++++++++++++ chrome/test/base/process_lineage_win.h | 47 ++++++++++++++++ 5 files changed, 118 insertions(+), 70 deletions(-) commit d9dc9f19a2d7b69536b9ebbeba601f0ed905898c Author: Chris Lu <thegreenfrog@chromium.org> Date: Tue Apr 9 19:36:10 2019 +0000 [ios] Add Inttests for Next and Previous FindInPageManager actions Add integration test coverage for calling FindInPageNext and FindInPagePrevious actions. Bug: 919685 Change-Id: If8894564135dacf61c4bd3510504013d4ef74ebd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551498 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by: Mike Dougherty <michaeldo@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#649231} .../find_in_page/find_in_page_manager_inttest.mm | 124 ++++++++++++++++++++- 1 file changed, 121 insertions(+), 3 deletions(-) commit 14b8ebf3ab9cf46f47ca587cdca59358fe7ba66e Author: Sam Maier <smaier@chromium.org> Date: Tue Apr 9 19:36:00 2019 +0000 Providing min-sdk to Proguard We had upstreamed min-sdk so that R8 could use it, but Proguard was forgotten. This adds min-sdk support for Proguard. Bug: 950918 Change-Id: I46aeb63ed89abcb2e384f874d3dbc1d43093884d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559579 Commit-Queue: Sam Maier <smaier@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Sam Maier <smaier@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#649230} build/android/gyp/proguard.py | 3 +-- build/android/gyp/util/proguard_util.py | 12 ++++++++++++ build/config/android/internal_rules.gni | 2 +- 3 files changed, 14 insertions(+), 3 deletions(-) commit fd581356a825191ae74b404cf51258109a949567 Author: Luke Halliwell <halliwell@chromium.org> Date: Tue Apr 9 19:34:42 2019 +0000 Add libinteraction to .gn check_targets list libinteraction is used in certain internal builds. Bug: b/110808839 Change-Id: I51c29bd0033d608413e97029f288de44b89fc441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560138 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#649229} .gn | 1 + 1 file changed, 1 insertion(+) commit fb83ece4375dc1fd1589879961805bf3e9b329a1 Author: Felix Ekblom <felixe@chromium.org> Date: Tue Apr 9 19:33:43 2019 +0000 CrOS enrollment: announce enrollment in progress This informs the user that enrollment is on-going. The 'alert' role is probably not perfect for this use case but it's the best I could find, and it's used in nearby code for similar scenarios. Testing by running through the remora enrollment flow and observing that "Enrolling device..." is read out. BUG=b:80126209 Change-Id: Iee7388dae29458412cb44f9d3578cfeee2d234cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559182 Auto-Submit: Felix Ekblom <felixe@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#649228} .../browser/resources/chromeos/login/oobe_screen_oauth_enrollment.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e811db8b8c7536f1addb45271edb7cf6554663e7 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Tue Apr 9 19:32:50 2019 +0000 flags: assign enable-pixel-canvas-recording Bug: None Change-Id: Id7d285352115e0aa97288a391b28782271a7bbd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559700 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#649227} chrome/browser/flag-metadata.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 54ff4f171a011b8555d5732a37542d1a2f0e69ed Author: Sidney San Martín <sdy@chromium.org> Date: Tue Apr 9 19:31:09 2019 +0000 Delete the unused/obsolete ImmersiveModeController::Type Followup from https://crrev.com/c/1427799. Bug: 868398 Change-Id: Id0c1f9ee80b90b9c3db0847b7df9de8e7aa8e888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560149 Commit-Queue: Sidney San Martín <sdy@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Sidney San Martín <sdy@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#649226} .../frame/browser_non_client_frame_view_ash_browsertest.cc | 2 -- .../browser/ui/views/frame/browser_view_layout_unittest.cc | 6 ------ chrome/browser/ui/views/frame/immersive_mode_controller.cc | 2 +- chrome/browser/ui/views/frame/immersive_mode_controller.h | 13 +------------ .../browser/ui/views/frame/immersive_mode_controller_ash.cc | 3 +-- .../views/frame/immersive_mode_controller_ash_unittest.cc | 1 - .../browser/ui/views/frame/immersive_mode_controller_mac.mm | 2 +- .../ui/views/frame/immersive_mode_controller_stub.cc | 6 ------ .../browser/ui/views/frame/immersive_mode_controller_stub.h | 6 ------ .../ui/views/location_bar/zoom_bubble_view_browsertest.cc | 1 - .../ui/views/tabs/tab_drag_controller_interactive_uitest.cc | 1 - 11 files changed, 4 insertions(+), 39 deletions(-) commit 928b37a815e902c2aac86b8cf5e837dd923b26a0 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Tue Apr 9 19:28:40 2019 +0000 flags: remove new-tab-button-position This change leaves the backing switch intact for later in-depth cleanup. Bug: 951038 Change-Id: I7b411324bee03ff0082fc69f1505f7150411d559 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560147 Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#649225} chrome/browser/about_flags.cc | 15 --------------- chrome/browser/flag-metadata.json | 5 ----- chrome/browser/flag_descriptions.cc | 8 -------- chrome/browser/flag_descriptions.h | 7 ------- .../browser/ui/views/tabs/browser_tab_strip_controller.cc | 2 ++ 5 files changed, 2 insertions(+), 35 deletions(-) commit 59bcd37cff574fb11b9b164c6eb5efa314542c72 Author: Dan Beam <dbeam@chromium.org> Date: Tue Apr 9 19:25:28 2019 +0000 WebUI Dark Mode: fix some nits in shared_vars_css.html * GB900 isn't used anywhere * Add some missing #hex annotations for -rgb vars R=dpapad@chromium.org BUG=none Change-Id: I7ca3063ba5e66af946638c9cb99caa7ae07a036c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559400 Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#649224} ui/webui/resources/cr_elements/shared_vars_css.html | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) commit c31de8c1de098620487d390ebcc632a39df4ba21 Author: Tao Bai <michaelbai@chromium.org> Date: Tue Apr 9 19:23:36 2019 +0000 ContentCapture whitelist - Added ContentCaptureController for whitelist which could be host name or regex. - Added mojom interface to let ContentCaptureReceiver talk to ContentCaptureSender to start/stop the ContentCapture. - ContentCapture is stopped by default in renderer side. Bug: 947639 TBR=pdr@chromium.org Change-Id: I42221afe78937ed696afa4bc6e2ab321159f6c97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557000 Reviewed-by: Tao Bai <michaelbai@chromium.org> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Changwan Ryu <changwan@chromium.org> Reviewed-by: Max Moroz <mmoroz@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#649223} android_webview/renderer/aw_render_frame_ext.cc | 2 +- chrome/renderer/chrome_content_renderer_client.cc | 6 +- components/content_capture/android/BUILD.gn | 5 ++ components/content_capture/android/DEPS | 1 + .../android/content_capture_controller.cc | 96 ++++++++++++++++++++++ .../android/content_capture_controller.h | 49 +++++++++++ .../content_capture_receiver_manager_android.cc | 5 ++ .../content_capture_receiver_manager_android.h | 3 + .../content_capture/ContentCaptureController.java | 58 +++++++++++++ components/content_capture/browser/DEPS | 1 + .../browser/content_capture_receiver.cc | 30 +++++++ .../browser/content_capture_receiver.h | 7 +- .../browser/content_capture_receiver_manager.cc | 13 +++ .../browser/content_capture_receiver_manager.h | 4 + .../browser/content_capture_receiver_test.cc | 2 + .../content_capture/common/content_capture.mojom | 9 +- .../renderer/content_capture_sender.cc | 23 +++++- .../renderer/content_capture_sender.h | 18 +++- 18 files changed, 322 insertions(+), 10 deletions(-) commit cd2804f3d773fb3f055e9c515151020ce6cca759 Author: Hesen Zhang <hesen@google.com> Date: Tue Apr 9 19:21:14 2019 +0000 Using backend file utils to replace getExtension in rename dialogs > Cleaned up a TODO flag for one corner case: for filename with double extension like "foo.tar.gz", "foo" should be highlighted by recognizing the extension ".tar.gz"; Previously using Java side util function, now using RenameUtils instead which connects the one in backend under FilePath class. Bug: 924751 Change-Id: Iea09538eccda452c1ebf91c2bf9e8e42458bec8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546586 Commit-Queue: Hesen Zhang <hesen@google.com> Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#649222} chrome/android/BUILD.gn | 1 + chrome/android/chrome_java_sources.gni | 1 + .../home/rename/RenameDialogCoordinator.java | 2 +- .../home/rename/RenameDialogCustomView.java | 5 +-- .../download/home/rename/RenameDialogManager.java | 13 +++----- .../rename/RenameExtensionDialogCoordinator.java | 2 +- .../browser/download/home/rename/RenameUtils.java | 38 ++++++++++++++++++++++ chrome/browser/BUILD.gn | 1 + chrome/browser/android/download/rename_utils.cc | 21 ++++++++++++ 9 files changed, 70 insertions(+), 14 deletions(-) commit af2bd19d579a62cd726cfd9f1a908e7a6f8cfd8b Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Apr 9 19:19:22 2019 +0000 Roll src/third_party/webrtc 6fdbba3a0381..6a489f22c71b (30 commits) https://webrtc.googlesource.com/src.git/+log/6fdbba3a0381..6a489f22c71b git log 6fdbba3a0381..6a489f22c71b --date=short --no-merges --format='%ad %ae %s' 2019-04-09 mbonadei@webrtc.org Fully qualify googletest symbols. 2019-04-09 guidou@webrtc.org Revert "Adding a restriction for legal RID values." 2019-04-09 noahric@chromium.org Remove atlbase dependency and lowercase Windows header includes. 2019-04-09 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 6c8246bc15..fe4d0c8e0f (648994:649101) 2019-04-09 srte@webrtc.org Disables slow scenario test on IOS ARM64 debug builds. 2019-04-09 ssilkin@webrtc.org Field trial to control inter-layer prediction. 2019-04-09 hbos@webrtc.org Implement RTC[In/Out]boundRtpStreamStats.contentType. 2019-04-09 srte@webrtc.org Refactoring scenario stats analysis. 2019-04-09 srte@webrtc.org Replacing SequencedTaskChecker with SequenceChecker. 2019-04-09 crodbro@webrtc.org Clean-up of unused PacingBufferPushback feature. 2019-04-09 aleloi@webrtc.org Fuzzer fix for multistream opus. 2019-04-09 srte@webrtc.org Adds GetStats to scenario receive streams. 2019-04-09 eladalon@webrtc.org Name changes inside VideoEncoder 2019-04-09 eladalon@webrtc.org Forward LossNotification from RTCPReceiver to EncoderRtcpFeedback 2019-04-09 nisse@webrtc.org Delete local convenience alias Buffer 2019-04-09 mbonadei@webrtc.org Make audio_device_module_from_input_and_output visible. 2019-04-09 hbos@webrtc.org Revert "Refactor FrameDecryptorInterface::Decrypt to use new API." 2019-04-09 marinaciocea@webrtc.org Fix comment - ice transport is cleared on the networking thread. 2019-04-09 nisse@webrtc.org Delete autoroll config for src/third_party/winsdk_samples 2019-04-09 hta@webrtc.org Datachannel: Use absl::optional for maxRetransmits and maxRetransmitTime. 2019-04-09 nisse@webrtc.org Delete interface class VideoCaptureExternal 2019-04-09 kwiberg@webrtc.org Add thread safety annotations for some more PeerConnection members (part 13) 2019-04-09 benwright@webrtc.org Added some more debugging logs 2019-04-09 danilchap@webrtc.org Fix and test CreateVideoStreamDecoder 2019-04-09 phensman@webrtc.org Update visibility of java_audio_device_module_jni target 2019-04-09 hbos@webrtc.org Wire up RTCOutboundRtpStreamStats.totalEncodeTime. 2019-04-09 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision afc02859a5..6c8246bc15 (648860:648994) 2019-04-08 amithi@webrtc.org Adding a restriction for legal RID values. 2019-04-08 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 827b96d72e..afc02859a5 (648742:648860) 2019-04-08 benwright@webrtc.org Refactor FrameDecryptorInterface::Decrypt to use new API. Created with: gclient setdep -r src/third_party/webrtc@6a489f22c71b The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:None,chromium:949536,chromium:950813,chromium:None,chromium:907849,chromium:854385,chromium:None,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I38e7b531ffba08e0b3b42c46efb1d92af3f4f1f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560213 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649221} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit f460f79e63a7b8f19a787897b05e6ee385cb7d07 Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Tue Apr 9 19:18:38 2019 +0000 Update V8 to version 7.5.225. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/78334315..b4c008bb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I942af034e8125c1d4dfca43a34b9c0f1a4eecc13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559578 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649220} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 57378ba89e58610620199d0b20df0b82445d0cce Author: Ted Choc <tedchoc@chromium.org> Date: Tue Apr 9 19:17:50 2019 +0000 Move HTTP auth handling to a subpackage. login was choosen to match login_handler.h in native. NOPRESUBMIT=true BUG=876369 Change-Id: Ibce85b4cdeeeedc33d762f18ed5939d5f388cd35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559877 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#649219} chrome/android/BUILD.gn | 2 +- chrome/android/chrome_java_sources.gni | 4 ++-- chrome/android/chrome_test_java_sources.gni | 2 +- .../chromium/chrome/browser/{ => login}/ChromeHttpAuthHandler.java | 6 +++--- .../src/org/chromium/chrome/browser/{ => login}/LoginPrompt.java | 2 +- .../chrome/browser/{ => login}/ChromeHttpAuthHandlerTest.java | 3 ++- 6 files changed, 10 insertions(+), 9 deletions(-) commit 3308bfd86d327062c89649813e62bf07ffb921bd Author: Sammie Quon <sammiequon@google.com> Date: Tue Apr 9 19:17:31 2019 +0000 overview: Hide status bubble. Its really hard to see, and almost impossible to read when shrunk. But animating the transform/opacity will add extra animations for most overview operations. This call is a no-op because we now suspend shelf changes until overview mode is animated in/out. The calls in workspace manager handled updating the shelf even without the suspend changes, so this was not needed for a while. Test: none Bug: 946780, 914147 Change-Id: Ica1c61ea5ae408addd401a9e797fcf4c5aa5003c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1544231 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#649218} ash/BUILD.gn | 1 + ash/public/cpp/window_properties.cc | 3 + ash/public/interfaces/window_properties.mojom | 3 + ash/wm/overview/overview_item.cc | 3 - ash/wm/overview/overview_session.cc | 13 +- ash/wm/overview/overview_utils.cc | 15 ++- ash/wm/overview/overview_utils.h | 9 +- ash/wm/overview/scoped_overview_hide_windows.cc | 22 +++- ash/wm/overview/scoped_overview_hide_windows.h | 11 +- .../overview/scoped_overview_transform_window.cc | 27 +++- ash/wm/overview/scoped_overview_transform_window.h | 6 +- .../scoped_overview_transform_window_unittest.cc | 37 ++++++ ash/wm/top_level_window_factory.cc | 12 ++ ash/wm/window_transient_descendant_iterator.cc | 78 ++++++++--- ash/wm/window_transient_descendant_iterator.h | 30 ++++- ...indow_transient_descendant_iterator_unittest.cc | 144 +++++++++++++++++++++ chrome/browser/ui/views/status_bubble_views.cc | 15 +++ 17 files changed, 371 insertions(+), 58 deletions(-) commit 67cb9c0e73ed23149ce7809fd48185ba55e1a345 Author: Stephen Martinis <martiniss@chromium.org> Date: Tue Apr 9 19:14:08 2019 +0000 Document the 'flag_name' json test results field Change-Id: Ic23a007188bcda0775e76633e72fc4f2047602b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539180 Reviewed-by: Aleks Totic <atotic@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#649217} docs/testing/json_test_results_format.md | 1 + 1 file changed, 1 insertion(+) commit 7a2625492cd17a45fd3583ff9dcd63e75aad5616 Author: Xing Liu <xingliu@chromium.org> Date: Tue Apr 9 19:13:50 2019 +0000 Android notification: Adds notification age metrics. We would like to know how long does the user interacts with the notification after shown, aka the age of notification. This CL adds metrics to track the age for notification body click, button click and dismiss. Bug: 942743 Change-Id: Ib806da9482a9a94025f509dd33259b9da09e1139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558454 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#649216} .../NotificationIntentInterceptor.java | 14 +++++++-- .../notifications/NotificationUmaTracker.java | 34 ++++++++++++++++++++-- tools/metrics/histograms/histograms.xml | 31 ++++++++++++++++++++ 3 files changed, 73 insertions(+), 6 deletions(-) commit c72d4f1f28dfa7eadc360e50506f27740e0cec82 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Tue Apr 9 19:09:31 2019 +0000 flags: assign explore-sites Bug: None Change-Id: I1c886560a1ae294bccd6b2fe4a000ae948d27d2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559890 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by: Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#649215} chrome/browser/flag-metadata.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit fa14052a4810e4320b7865ddfa8037843000227d Author: Dana Fried <dfried@chromium.org> Date: Tue Apr 9 19:09:01 2019 +0000 Use layers approach for bubble dialog rounded corners. Technique is courtesy of oshima@ (via sajadm@) and makes use of new layer masking API. Should fix the vast majority (if not all) rendering bugs on Bubble dialogs, but is not a general fix for all dialogs. As per markchang@'s guidance, we will now enable rounded corners on all bubble dialogs to get better telemetry from users in case there are still issues. Dialogs using DialogDelegate and lower-level dialog implementations will still be behind the flag (whose description I have updated accordingly) as they still have significant issues. Bug: 932970, 946673 Change-Id: I96c39d75ac9c79b9c33424c28d986093eb12caf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553508 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#649214} ash/assistant/ui/assistant_container_view.cc | 2 +- ash/system/tray/tray_bubble_view.cc | 4 ++-- chrome/browser/flag_descriptions.cc | 4 ++-- chrome/browser/ui/views/extensions/extension_popup.cc | 3 +-- ui/views/bubble/bubble_border.cc | 13 +++++-------- ui/views/bubble/bubble_border.h | 8 +++----- ui/views/bubble/bubble_dialog_delegate_view.cc | 9 +++++---- ui/views/bubble/bubble_frame_view.cc | 11 +++++------ ui/views/controls/menu/menu_scroll_view_container.cc | 2 +- 9 files changed, 25 insertions(+), 31 deletions(-) commit 9a49b3db7b3f06acac8ff6b17d54a68d7a3e070f Author: Dan Beam <dbeam@chromium.org> Date: Tue Apr 9 19:07:46 2019 +0000 WebUI Dark Mode: fix toolbar cancel icon fill color I accidentally used GG200 for the fill color (should be GG500). R=dpapad@chromium.org Change-Id: Ic178eaac3f254254d5bd15ee613a9cbd8e8871b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559399 Auto-Submit: Dan Beam <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#649213} ui/webui/resources/images/dark/icon_toolbar_cancel.svg | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 37522bdf3e391a238aa994c775a1a0d4fe128258 Author: Dana Fried <dfried@chromium.org> Date: Tue Apr 9 19:07:42 2019 +0000 Make sure OWNERS files have trailing newline. Change-Id: I04205a7b585dc1cc3868705ff964a57a98fb0d7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559885 Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#649212} ui/views/examples/OWNERS | 2 +- ui/views/layout/OWNERS | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit 89c01255bf25f22f4dfec4f90f4e016ac3f6dfcf Author: Micah Morton <mortonm@chromium.org> Date: Tue Apr 9 19:06:07 2019 +0000 Revert "Expose enable/disable switch for shill sandboxing over DBus" This reverts commit e87a5139db336775f3a6340227071d56e71aaa9c. Reason for revert: Remove this flag as we will be unconditionally running shill in minijail from M75 onward Original change's description: > Expose enable/disable switch for shill sandboxing over DBus > > This feature flag gates the use of minijail to sandbox shill (the > network manager) on CrOS. Defaults to true. We want a feature flag for > this in case any unforseen sandboxing compications occur on the beta or > stable channels and Finch is our only way of reverting. > > CQ-DEPEND=CL:1172729,CL:1177883 > "sudo -u chronos dbus-send --system --type=method_call --print-reply \ > --dest=org.chromium.ChromeFeaturesService \ > /org/chromium/ChromeFeaturesService \ > "org.chromium.ChromeFeaturesServiceInterface.IsShillSandboxingEnabled" > > Bug: 649417 > Test: Following command returned true (flag is true by default): > Change-Id: I359b28d463f8f0ce861739d7f165f5437690bae5 > Reviewed-on: https://chromium-review.googlesource.com/1173260 > Commit-Queue: Micah Morton <mortonm@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583750} Bug: 875028 Change-Id: Icd6dafd0ed677f597bffa6a96b13bc92d9d6c6cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1515273 Commit-Queue: Micah Morton <mortonm@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#649211} chrome/browser/about_flags.cc | 3 --- .../chromeos/dbus/chrome_features_service_provider.cc | 17 +---------------- .../chromeos/dbus/chrome_features_service_provider.h | 3 --- chrome/browser/flag_descriptions.cc | 5 ----- chrome/browser/flag_descriptions.h | 3 --- chrome/common/chrome_features.cc | 4 ---- chrome/common/chrome_features.h | 2 -- 7 files changed, 1 insertion(+), 36 deletions(-) commit 56b0d36f997f1b5351375d444c0e6bbde86d7a6b Author: Daniel Rubery <drubery@chromium.org> Date: Tue Apr 9 19:01:30 2019 +0000 Enable kInspectRarContent for the DownloadProtectionService browsertest Since official builds don't use the fieldtrial_testing_config, I need to enable kInspectRarContent within the test, so the Official builders can succeed. Bug: 950908 Change-Id: I779f3a2d2f7321225f5ef838cd8419f8ef432e68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559880 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#649210} .../download_protection_service_browsertest.cc | 10 ++++++++++ 1 file changed, 10 insertions(+) commit 8321f4b0fe6f5836b266d91f6b699b27124dd75a Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Apr 9 18:57:57 2019 +0000 Roll src/third_party/skia 4ffbfe61777f..80658204f417 (6 commits) https://skia.googlesource.com/skia.git/+log/4ffbfe61777f..80658204f417 git log 4ffbfe61777f..80658204f417 --date=short --no-merges --format='%ad %ae %s' 2019-04-09 fmalita@chromium.org Revert "[skottie] More snug kTop Shaper alignment" 2019-04-09 halcanary@google.com SkPDF: remove unused field 2019-04-09 egdaniel@google.com Fix to barrier batching. 2019-04-09 mtklein@google.com --parameters -> --properties 2019-04-09 michaelludwig@google.com Detect simpler quad type when possible 2019-04-09 reed@google.com remove guard for bitmap shader api Created with: gclient setdep -r src/third_party/skia@80658204f417 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: I9092ddacf5810f36bb4ebc04cb76b7c083b1a50a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559849 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649209} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e3a6ba6c8b41e7580d8d37ce923d42099a374e26 Author: Austin Eng <enga@chromium.org> Date: Tue Apr 9 18:55:34 2019 +0000 Implement GPUSampler in Blink Bug: 877147 Change-Id: I1f7a57faec80ae5896e6c2101093d04af38e124c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554139 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#649208} .../blink/renderer/modules/webgpu/gpu_sampler.cc | 37 ++++++++++++++++++++-- 1 file changed, 35 insertions(+), 2 deletions(-) commit 2b49880e2481658e0702fd6fe494859bca52b39c Author: Tatiana Buldina <buldina@chromium.org> Date: Tue Apr 9 18:54:15 2019 +0000 [ChromeDriver] Make W3C mode default Change-Id: I4081b451d59e6c3ef164b343e8f60cfbc07081b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559151 Reviewed-by: John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#649207} chrome/test/chromedriver/session.h | 2 +- chrome/test/chromedriver/session_commands.cc | 4 ++++ chrome/test/chromedriver/test/run_py_tests.py | 4 ++-- 3 files changed, 7 insertions(+), 3 deletions(-) commit 8866c89870b7c9a1da06c5f09033e16c4a261e17 Author: Alexei Filippov <alph@chromium.org> Date: Tue Apr 9 18:48:10 2019 +0000 [heap profiler] Add a DCHECK for adding the same observer twice to PAS. Change-Id: I3e02b365b0a30ab852a1eb141086bc2c2d23f74a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553503 Reviewed-by: Erik Chen <erikchen@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#649206} base/sampling_heap_profiler/poisson_allocation_sampler.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) commit 6ea3532930ab636c1dc84c966640bf8292093592 Author: Tom Sepez <tsepez@chromium.org> Date: Tue Apr 9 18:43:40 2019 +0000 Make additional PPB APIs require ppapi::PERMISSION_SOCKET. TCPServerSocketPrivate, TCPSocketPrivate, and UDPSocketPrivate now require this permission in addition to a whitelisted site/URL. Tidy code a bit while at it: - use early returns - use std::make_unique<> - pull a redundant permission check Bug: 950005 Change-Id: I6c24c39bf55c08fd538da62d1dc3a8a58610be2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553877 Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#649205} .../pepper/content_browser_pepper_host_factory.cc | 57 +++++++++++----------- .../thunk/interfaces_ppb_private_no_permissions.h | 19 ++------ ppapi/thunk/interfaces_ppb_public_socket.h | 12 +++++ 3 files changed, 43 insertions(+), 45 deletions(-) commit 10582bcea092245e53859fb6f7fe9d6601aa191e Author: Eugene But <eugenebut@google.com> Date: Tue Apr 9 18:41:57 2019 +0000 Remove unused ios/web/public/features.h includes. features.h will be moved to ios/web/public, and deleting unused includes will make the process easier. Bug: 942244 Change-Id: I7c1c5dd232390d85bb96555781c08b7475ec1b06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558725 Reviewed-by: Peter Lee <pkl@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#649204} ios/chrome/browser/ui/util/ui_util.mm | 1 - ios/chrome/browser/ui/webui/web_ui_egtest.mm | 1 - ios/web/common/crw_web_view_content_view.mm | 1 - ios/web/web_state/ui/crw_web_view_content_view_unittest.mm | 1 - 4 files changed, 4 deletions(-) commit b30e2375e3e5ec0daadecc1e7b27bb31c7893488 Author: Robbie Gibson <rkgibson@google.com> Date: Tue Apr 9 18:37:45 2019 +0000 🦁Handle multiple omniboxes Before, the layout gudes were attached in OmniboxContainerView's didMoveToWindow. However, this view is created a second time on NTP to make animations easier. This messes up the layout guide. Instead, attach them in OmniboxViewController's viewDidAppear. This is specific to the one omnibox we want to hook the layout guides to. Bug: 945323 Change-Id: I2e8f19ca19384105691526aff72dc8643e343c6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560150 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#649203} ios/chrome/browser/ui/omnibox/omnibox_container_view.h | 3 +++ ios/chrome/browser/ui/omnibox/omnibox_container_view.mm | 14 ++++++++------ ios/chrome/browser/ui/omnibox/omnibox_view_controller.mm | 6 ++++++ 3 files changed, 17 insertions(+), 6 deletions(-) commit 669f790321134b9e03a4de4a1835b678fe8a3b3e Author: Raymond Toy <rtoy@chromium.org> Date: Tue Apr 9 18:36:42 2019 +0000 Remove AudioBuffer::CreateFromAudioFileData AudioBuffer::CreateFromAudioFileData is never called. I noticed this from the code coverage results: https://analysis.chromium.org/p/chromium/coverage/file?host=chromium.googlesource.com&project=chromium/src&ref=refs/heads/master&revision=26f6898d74404efb8553aadf8862cac8e35215f9&path=//third_party/blink/renderer/modules/webaudio/audio_buffer.cc&platform=linux, Code search also confirms that it is never called. Therefore, remove this dead code. Bug: 938550 Change-Id: Ifeef5dc61065317de4947a95bcdf42d01da6456a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1550769 Reviewed-by: Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#649202} .../blink/renderer/modules/webaudio/audio_buffer.cc | 15 --------------- .../blink/renderer/modules/webaudio/audio_buffer.h | 6 ------ 2 files changed, 21 deletions(-) commit 6096893633bafbce6731503056b961a6604557a2 Author: David Benjamin <davidben@chromium.org> Date: Tue Apr 9 18:36:38 2019 +0000 Fix a handful of HTTP URLs to HTTPS. These are, in various error conditions, surfaced to users so they should be HTTPS. Remove the URL for the mobile-web-app-capable console warning as that URL is dead. (See review discussion.) Bug: none Change-Id: I9387d0c37a787c24215ef7e9677323a770dbde31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549748 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by: Roger Tawa <rogerta@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#649201} chrome/renderer/chrome_render_frame_observer.cc | 3 +-- extensions/browser/suggest_permission_util.cc | 4 ++-- google_apis/google_api_keys.cc | 2 +- sandbox/linux/services/libc_interceptor.cc | 4 ++-- third_party/blink/renderer/platform/loader/fetch/resource_error.cc | 2 +- 5 files changed, 7 insertions(+), 8 deletions(-) commit ff6e35a21ff45f32336ce08f7050aa4d184ebbc8 Author: Andrew Xu <andrewxu@chromium.org> Date: Tue Apr 9 18:35:34 2019 +0000 [Reland]Fix the data race in multi-profile mode The reason of being reverted: AppListControllerImpl::profile_id_ is expected to be initialized by Chrome process through mojo. However, SpokenFeedbackAppListTest is not end to end. As a result, that attribute is left without initialization and it always crashes during memory test.The updated CL assigns the initial value to |profile_id_|. The following contents are the original description: In multi-profile mode, each profile has its own ChromeAppListModel- Updater instance. However, the mojo callings from Ash side to access the app list item in Chrome side do not specify the target model updater instance. Instead it assumes that the target instance is always associated with the current profile. This assumption proves false in some edge cases. This CL does a quick fixing: use the additional parameter in mojo callings to specify the target. See the doc below for more details. Test: browser_tests Bug: 939755 Change-Id: Ia7e99d0d0261a4dc6bcd13fbf06732d98c674e62 Doc: https://docs.google.com/document/d/1MiTiaebjAviMav8CUs5XWbEnVOhJDpPo0iBU8YbdHkA/edit?usp=sharing Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559117 Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#649200} ash/app_list/app_list_controller_impl.cc | 19 +-- ash/app_list/app_list_controller_impl.h | 8 +- ash/app_list/test/test_app_list_client.cc | 1 + ash/app_list/test/test_app_list_client.h | 24 ++-- ash/public/cpp/app_list/app_list_types.h | 7 ++ ash/public/interfaces/app_list.mojom | 28 +++-- ash/shell/example_app_list_client.cc | 3 +- ash/shell/example_app_list_client.h | 4 +- .../spoken_feedback_app_list_browsertest.cc | 2 +- chrome/browser/ui/app_list/app_list_client_impl.cc | 129 +++++++++++++++------ chrome/browser/ui/app_list/app_list_client_impl.h | 65 +++++++++-- .../app_list/app_list_client_impl_browsertest.cc | 127 ++++++++++++++++++++ .../browser/ui/app_list/app_list_model_updater.cc | 10 ++ .../browser/ui/app_list/app_list_model_updater.h | 7 ++ .../ui/app_list/chrome_app_list_model_updater.cc | 4 +- 15 files changed, 360 insertions(+), 78 deletions(-) commit eec40dbe6fd2761a03609b289d7de13dd72a8cf7 Author: Yuwei Huang <yuweih@chromium.org> Date: Tue Apr 9 18:35:21 2019 +0000 [remoting][iOS] Make IosOauthTokenGetter::InvalidateCache() work This CL is to allow the SSO authenticator to cache the auth token and invalidate it. It: * Adds -(void)invalidateCache to RemotingAuthentication for invalidating cache. * Hooks IosOauthTokenGetter::InvalidateCache() to [RemotingService.instance.authentication invalidateCache] * Implements invalidateCache in RemotingOauthAuthentication, which is used by the Chromium build. Note that this CL must be checked in AFTER the internal CL: https://chrome-internal-review.googlesource.com/c/chrome/ios_internal/+/1159191 Bug: 950228 Change-Id: Ibf6f46e116266a16100dc4034783324fbac4ba3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558718 Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#649199} remoting/ios/facade/ios_oauth_token_getter.mm | 4 +--- remoting/ios/facade/remoting_authentication.h | 4 ++++ remoting/ios/facade/remoting_oauth_authentication.mm | 4 ++++ 3 files changed, 9 insertions(+), 3 deletions(-) commit 7dd6aa65cfa34091e0ee5b5656375c822c603958 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Apr 9 18:34:20 2019 +0000 Roll src/third_party/catapult 072a6f14b64c..3d77140b9d58 (1 commits) https://chromium.googlesource.com/catapult.git/+log/072a6f14b64c..3d77140b9d58 git log 072a6f14b64c..3d77140b9d58 --date=short --no-merges --format='%ad %ae %s' 2019-04-09 aluo@chromium.org Uninstall system packages even if their installed status is false. Created with: gclient setdep -r src/third_party/catapult@3d77140b9d58 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:949448 TBR=skyostil@chromium.org Change-Id: I067294d8f1a122429aa1e90e8017b353ee29ce62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559847 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649198} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 140d1251623404c7a56ba1af4c4a3902833df643 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Tue Apr 9 18:33:13 2019 +0000 [Extensions Cleanup] Remove webstore.json Remove the webstore.json file. Inline installation is no more (and has been gone for quite some time). Bug=882045 Change-Id: I9eef84ff49bd2ea3c0c1df7772cc90416fd699c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559231 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#649197} chrome/common/extensions/api/webstore.json | 167 ----------------------------- 1 file changed, 167 deletions(-) commit d01e738e30002f9f8650b99b498d94281bea091d Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Apr 9 18:32:58 2019 +0000 Roll src/third_party/chromite 3ef631ecd110..69a3f230f57f (2 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/3ef631ecd110..69a3f230f57f git log 3ef631ecd110..69a3f230f57f --date=short --no-merges --format='%ad %ae %s' 2019-04-09 shapiroc@chromium.org chromite: Don't test bvt-arc on non-arc 2019-04-09 shapiroc@chromium.org chromite: Fix invalid key-id path Created with: gclient setdep -r src/third_party/chromite@69a3f230f57f The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: If562bc91cd9e15c65afa8735018138430491e565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560062 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649196} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 8cf7d0ae0c09c376549e8c0a534a34b5629540d7 Author: Tanja Gornak <melandory@google.com> Date: Tue Apr 9 18:32:08 2019 +0000 [Tango->FCM] Enable FCMInvalidations featurein trial config for linux. BUG=801985 Change-Id: I9fe5891fb8d30f869e2e53f6c915c89ee109d50a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547848 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by: Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#649195} testing/variations/fieldtrial_testing_config.json | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) commit 47f7376c3d78e7c01ba3b9e55fba22be4a166274 Author: Sinan Sahin <sinansahin@google.com> Date: Tue Apr 9 18:31:44 2019 +0000 Update tablet tab strip colors Bug: 947749 Change-Id: If0703ff3f92bac66fde57c6a81e725e47d0f903a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554180 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by: Matthew Jones <mdjones@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#649194} chrome/android/chrome_java_sources.gni | 1 + .../drawable-hdpi/bg_tabstrip_background_tab.9.png | Bin 761 -> 0 bytes .../bg_tabstrip_background_tab_outline.9.png | Bin 0 -> 541 bytes .../bg_tabstrip_incognito_background_tab.9.png | Bin 694 -> 0 bytes .../drawable-hdpi/bg_tabstrip_incognito_tab.9.png | Bin 628 -> 0 bytes .../res/drawable-hdpi/btn_tab_close_pressed.png | Bin 176 -> 0 bytes .../drawable-hdpi/btn_tab_close_white_normal.png | Bin 154 -> 0 bytes .../drawable-hdpi/btn_tab_close_white_pressed.png | Bin 153 -> 0 bytes .../drawable-mdpi/bg_tabstrip_background_tab.9.png | Bin 557 -> 0 bytes .../bg_tabstrip_background_tab_outline.9.png | Bin 0 -> 402 bytes .../bg_tabstrip_incognito_background_tab.9.png | Bin 503 -> 0 bytes .../drawable-mdpi/bg_tabstrip_incognito_tab.9.png | Bin 465 -> 0 bytes .../res/drawable-mdpi/btn_tab_close_pressed.png | Bin 123 -> 0 bytes .../drawable-mdpi/btn_tab_close_white_normal.png | Bin 112 -> 0 bytes .../drawable-mdpi/btn_tab_close_white_pressed.png | Bin 112 -> 0 bytes .../bg_tabstrip_background_tab.9.png | Bin 901 -> 0 bytes .../bg_tabstrip_background_tab_outline.9.png | Bin 0 -> 659 bytes .../bg_tabstrip_incognito_background_tab.9.png | Bin 856 -> 0 bytes .../drawable-xhdpi/bg_tabstrip_incognito_tab.9.png | Bin 723 -> 0 bytes .../res/drawable-xhdpi/btn_tab_close_pressed.png | Bin 171 -> 0 bytes .../drawable-xhdpi/btn_tab_close_white_normal.png | Bin 154 -> 0 bytes .../drawable-xhdpi/btn_tab_close_white_pressed.png | Bin 156 -> 0 bytes .../bg_tabstrip_background_tab.9.png | Bin 1304 -> 0 bytes .../bg_tabstrip_background_tab_outline.9.png | Bin 0 -> 1180 bytes .../bg_tabstrip_incognito_background_tab.9.png | Bin 1234 -> 0 bytes .../bg_tabstrip_incognito_tab.9.png | Bin 1020 -> 0 bytes .../res/drawable-xxhdpi/btn_tab_close_pressed.png | Bin 205 -> 0 bytes .../drawable-xxhdpi/btn_tab_close_white_normal.png | Bin 195 -> 0 bytes .../btn_tab_close_white_pressed.png | Bin 197 -> 0 bytes .../bg_tabstrip_background_tab.9.png | Bin 1643 -> 0 bytes .../bg_tabstrip_background_tab_outline.9.png | Bin 0 -> 1587 bytes .../bg_tabstrip_incognito_background_tab.9.png | Bin 1551 -> 0 bytes .../bg_tabstrip_incognito_tab.9.png | Bin 1239 -> 0 bytes .../res/drawable-xxxhdpi/btn_tab_close_pressed.png | Bin 236 -> 0 bytes .../btn_tab_close_white_normal.png | Bin 234 -> 0 bytes .../btn_tab_close_white_pressed.png | Bin 235 -> 0 bytes chrome/android/java/res/values/colors.xml | 6 ++ .../android/java/res_night/values-night/colors.xml | 4 + .../layouts/components/CompositorButton.java | 5 +- .../layouts/components/TintedCompositorButton.java | 89 +++++++++++++++++++++ .../compositor/overlays/strip/StripLayoutTab.java | 57 ++++++++++--- .../resources/StaticResourcePreloads.java | 10 ++- .../compositor/scene_layer/TabStripSceneLayer.java | 16 ++-- .../android/compositor/layer/tab_handle_layer.cc | 52 +++++++----- .../android/compositor/layer/tab_handle_layer.h | 2 + .../scene_layer/tab_strip_scene_layer.cc | 23 ++++-- .../compositor/scene_layer/tab_strip_scene_layer.h | 4 + ui/android/java/res/values/color_palette.xml | 4 + ui/android/java/res/values/colors.xml | 3 + ui/android/java/res_night/values-night/colors.xml | 1 + 50 files changed, 227 insertions(+), 50 deletions(-) commit f2063c1e82390c8f35468def7e1af80446b70b19 Author: Camille Lamy <clamy@chromium.org> Date: Tue Apr 9 18:30:51 2019 +0000 Reland Refactor NavigationRequest selection in RenderFrameHost Original commit message: This is a preparatory CL for enforcing having a valid NavigationRequest at commit time. It makes clearer when NavigationRequests are deemed non-valid, and when a new NavigationRequest must be created at commit time. Bug: 943610, 942515 Change-Id: Idde1784bdcd55a782c74636d610b4c0da00d5286 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530866 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Auto-Submit: Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#649193} .../navigation_controller_impl_unittest.cc | 41 ++- .../browser/frame_host/render_frame_host_impl.cc | 295 ++++++++++----------- .../browser/frame_host/render_frame_host_impl.h | 35 ++- content/browser/navigation_browsertest.cc | 91 ------- content/common/frame_messages.h | 5 + content/common/navigation_params.cc | 6 +- content/common/navigation_params.h | 7 + content/renderer/render_frame_impl.cc | 9 + content/test/navigation_simulator_impl.cc | 7 +- content/test/navigation_simulator_impl.h | 1 + 10 files changed, 211 insertions(+), 286 deletions(-) commit 0c7cc698843302493af798000ab8f8c8fc3b4292 Author: Ayu Ishii <ayui@chromium.org> Date: Tue Apr 9 18:28:52 2019 +0000 [idle] Implement kill switch for IdleDetection IdleDetection allows sites to observe user idle status. Before launching this feature, we want to add a kill switch that can be set from server side that lets us turn off the feature in case where there is a security or privacy problem. Bug: 947707 Change-Id: Ic44fcaf6ed2ce5f5ae5026fc8040be1b51dac26f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548035 Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#649192} content/child/runtime_features.cc | 3 +++ content/public/common/content_features.cc | 6 ++++++ content/public/common/content_features.h | 1 + third_party/blink/public/platform/web_runtime_features.h | 1 + .../blink/renderer/platform/exported/web_runtime_features.cc | 4 ++++ 5 files changed, 15 insertions(+) Updated tag 'tree_truth' (was be974130ad11)