Back to build
Raw log | Switch to full mode | Login

/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh /b/swarming/w/ir/cache/builder/src src in dir /b/swarming/w/ir/k: allow_subannotations: False cmd: ['/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh', '/b/swarming/w/ir/cache/builder/src', 'src'] env: {'CHROME_HEADLESS': '1'} env_prefixes: {} env_suffixes: {} infra_step: False name_tokens: ('tree truth steps',) ok_ret: frozenset([0]) trigger_specs: () full environment: ADDRFAM: inet BOTO_CONFIG: /b/swarming/w/ir/tmp/gsutil_task/.boto BUILDBUCKET_EXPERIMENTAL: FALSE CHROME_HEADLESS: 1 CIPD_CACHE_DIR: /b/swarming/cipd_cache/cache CIPD_PROTOCOL: v2 DEVSHELL_CLIENT_PORT: 38570 DOCKER_CONFIG: /b/swarming/w/ir/tmp/docker_cfg_task DOCKER_TMPDIR: /b/swarming/w/ir/tmp/docker_tmp_task GIT_CONFIG_NOSYSTEM: 1 GIT_TERMINAL_PROMPT: 0 HOME: /home/chrome-bot IFACE: eth0 INFRA_GIT_WRAPPER_HOME: /b/swarming/w/ir/tmp/git_home_task LOGDOG_COORDINATOR_HOST: logs.chromium.org LOGDOG_STREAM_PREFIX: buildbucket/cr-buildbucket.appspot.com/8915811084284206576 LOGDOG_STREAM_PROJECT: chromium LOGDOG_STREAM_SERVER_PATH: unix:/b/swarming/w/ir/tmp/ld.sock LOGICAL: eth0 LUCI_CONTEXT: /b/swarming/w/itkGUWzA/luci_context.524245982 MAC_CHROMIUM_TMPDIR: /b/swarming/w/ir/tmp/t METHOD: dhcp NO_GCE_CHECK: False PATH: /b/swarming/w/ir/cipd_bin_packages:/b/swarming/w/ir/cipd_bin_packages/bin:/b/swarming/cipd_cache/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin PWD: /b/swarming/w/ir/k PYTHONIOENCODING: UTF-8 PYTHONUNBUFFERED: 1 ROOT_SETUP_LOG: /var/log/messages/chromebuild/root-setup.log SHLVL: 1 STARTUP_LOG: /var/log/messages/chromebuild/startup.log SWARMING_BOT_ID: swarm2234-c4 SWARMING_EXTERNAL_BOT_SETUP: 1 SWARMING_HEADLESS: 1 SWARMING_SERVER: https://chromium-swarm.appspot.com SWARMING_TASK_ID: 444ad0fa41940b11 TEMP: /b/swarming/w/ir/tmp/t TEMPDIR: /b/swarming/w/ir/tmp/t TERM: linux TMP: /b/swarming/w/ir/tmp/t TMPDIR: /b/swarming/w/ir/tmp/t UPSTART_EVENTS: net-device-up UPSTART_INSTANCE: UPSTART_JOB: chromebuild-startup USER: chrome-bot USERNAME: chrome-bot VPYTHON_VIRTUALENV_ROOT: /b/swarming/w/ir/cache/vpython _: /b/swarming/w/ir/cipd_bin_packages/vpython !@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: fb61fc335603bf19b175c1766fd097d57ec261b3 For bisect-builds.py, return early for revision if a command fails. cjamcl@google.com, Thu Apr 18 19:47:20 2019 +0000 75d9be844c385e909605c5f80cc7d926c0065ade Fix tools/traffic_annotation/summary/annotations.xml Xianzhu Wang, Thu Apr 18 19:47:06 2019 +0000 5caa0e1d2bbc97a404b89fa6e8ecf4bcc9fc9a3d Clean up NotificationHeaderView Evan Stade, Thu Apr 18 19:43:09 2019 +0000 6298d31bc55dfef55fc2913256c8bba22e9f0bcd Make MaybeCaptureSafetyNetId() a NO-OP for now. Varun Khaneja, Thu Apr 18 19:42:56 2019 +0000 f6fd738d04526b1e9e05e99ec56c36cc14c2140e Add EXTENDED_MODE & UNSPECIFIED to net::CookieSameSite and related enums Lily Chen, Thu Apr 18 19:39:45 2019 +0000 a403991fe3ac1c221bbf6145306af7102052de9c Disabling v8.browsing_mobile browse:news:toi on Android due to flakes Oystein Eftevaag, Thu Apr 18 19:35:45 2019 +0000 c162c7e282551ed059e099119cb83f4d6ee51705 Disable OfflinePageBridgeTest#testDownloadPage (flaky). Bret Sepulveda, Thu Apr 18 19:33:15 2019 +0000 606706405064ea1d0205c84c6e2ab5e4edd32226 DeviceStateMixin: Use file install attributes instead of StubInstallAttributes Roman Sorokin, Thu Apr 18 19:27:43 2019 +0000 0f9e5ca8833c1dc8a58fc17bf8e4a5ce273f4a90 Updating XTBs based on .GRDs from branch master David 'Digit' Turner, Thu Apr 18 19:20:45 2019 +0000 a71e1e74bff1ab4bdb919da3e26f3b067091d5e4 [modules] Add dummy lib to VR DFM Tibor Goldschwendt, Thu Apr 18 19:18:19 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit fb61fc335603bf19b175c1766fd097d57ec261b3 Author: cjamcl@google.com <cjamcl@google.com> Date: Thu Apr 18 19:47:20 2019 +0000 For bisect-builds.py, return early for revision if a command fails. Only relevant when doing multiple runs (-t) of a command. If any fail, there is no need to continue running the command for a revision. Speeds up bisects that have flaky repros. Also, resurrect bisect_test.py. Change-Id: I6b5302dc2408d5779192d1f4808b9d51ddfbc1f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540741 Reviewed-by: Roberto Carrillo <robertocn@chromium.org> Commit-Queue: Connor Clark <cjamcl@google.com> Cr-Commit-Position: refs/heads/master@{#652264} tools/bisect-builds.py | 44 +++++++++++++++++++++--------------------- tools/bisect_test.py | 52 ++++++++++++++++++++++++++++++++++++++++---------- 2 files changed, 64 insertions(+), 32 deletions(-) commit 75d9be844c385e909605c5f80cc7d926c0065ade Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Thu Apr 18 19:47:06 2019 +0000 Fix tools/traffic_annotation/summary/annotations.xml It missed a leading space, causing check_network_annotations failure on linux-rel and win7-rel. TBR=rhalavati@chromium.org,nicolaso@chromium.org Bug: 949382 Change-Id: If662c470e97ba8375b276a1bf46f77b065e7a262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574599 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#652263} tools/traffic_annotation/summary/annotations.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 5caa0e1d2bbc97a404b89fa6e8ecf4bcc9fc9a3d Author: Evan Stade <estade@chromium.org> Date: Thu Apr 18 19:43:09 2019 +0000 Clean up NotificationHeaderView Make label initialization more consistent and less verbose by pulling common init into a local lambda. This should have no behavioral effect except for giving the timestamp labels the same color as the other labels. Bug: none Change-Id: I1fea98a91e979d1dc5ebb6e3a3976e092f7673f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568085 Reviewed-by: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#652262} .../views/notification_header_view.cc | 61 +++++++--------------- 1 file changed, 20 insertions(+), 41 deletions(-) commit 6298d31bc55dfef55fc2913256c8bba22e9f0bcd Author: Varun Khaneja <vakh@chromium.org> Date: Thu Apr 18 19:42:56 2019 +0000 Make MaybeCaptureSafetyNetId() a NO-OP for now. This change needs to be merged back to M74 too :( For M75, I'll send a follow-upCL that enables this feature behind a Finch flag that's disabled by default. The relevant GmsCore release should be out soon so it should be safe for M75 release. R=drubery Bug: 954255 Change-Id: Iebb0f78aa4fd6e5219ffa3645c98fcf1b5d32244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574143 Auto-Submit: Varun Khaneja <vakh@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#652261} .../telemetry/android/android_telemetry_service.cc | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) commit f6fd738d04526b1e9e05e99ec56c36cc14c2140e Author: Lily Chen <chlily@chromium.org> Date: Thu Apr 18 19:39:45 2019 +0000 Add EXTENDED_MODE & UNSPECIFIED to net::CookieSameSite and related enums This CL adds two new values to the net::CookieSameSite enum, EXTENDED_MODE and UNSPECIFIED. Corresponding values are also added to network::mojom::CookieSameSite and net::DBCookieSameSite. The new values are not yet used. In switch statements, EXTENDED_MODE acts the same as LAX_MODE, and UNSPECIFIED acts the same as NO_RESTRICTION. Bug: 953306 Change-Id: I0cd221076bbc9286596d63c6c0de367dc5a42d43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568466 Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Reviewed-by: Maks Orlovich <morlovich@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#652260} chrome/browser/extensions/api/cookies/cookies_helpers.cc | 4 ++++ content/browser/devtools/protocol/network_handler.cc | 4 ++++ net/cookies/cookie_constants.cc | 6 ++++++ net/cookies/cookie_constants.h | 9 ++++++++- net/extras/sqlite/sqlite_persistent_cookie_store.cc | 10 ++++++++++ services/network/public/cpp/cookie_manager_mojom_traits.cc | 10 ++++++++++ services/network/public/mojom/cookie_manager.mojom | 9 ++++++--- .../blink/renderer/modules/cookie_store/cookie_change_event.cc | 2 ++ .../blink/renderer/platform/exported/web_canonical_cookie.cc | 4 ++++ 9 files changed, 54 insertions(+), 4 deletions(-) commit a403991fe3ac1c221bbf6145306af7102052de9c Author: Oystein Eftevaag <oysteine@google.com> Date: Thu Apr 18 19:35:45 2019 +0000 Disabling v8.browsing_mobile browse:news:toi on Android due to flakes CC=​mythria@chromium.org,ulan@chromium.org TBR=crouleau@chromium.org NOTRY=true Bug: 954260 Change-Id: Ie5647f9945d3b2dde9f246b15787bc1d45866594 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574638 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#652259} tools/perf/expectations.config | 2 ++ 1 file changed, 2 insertions(+) commit c162c7e282551ed059e099119cb83f4d6ee51705 Author: Bret Sepulveda <bsep@chromium.org> Date: Thu Apr 18 19:33:15 2019 +0000 Disable OfflinePageBridgeTest#testDownloadPage (flaky). TBR=dimich@chromium.org Bug: 954205 Change-Id: I515061b271ddb5ea78a4a031d9bd86dd7245127e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574222 Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#652258} .../org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java | 1 + 1 file changed, 1 insertion(+) commit 606706405064ea1d0205c84c6e2ab5e4edd32226 Author: Roman Sorokin <rsorokin@chromium.org> Date: Thu Apr 18 19:27:43 2019 +0000 DeviceStateMixin: Use file install attributes instead of StubInstallAttributes Also added SetUpUserDataDirectory into InProcessBrowserTestMixin Bug: 952855 Change-Id: I844ea3ed718cea27b74fe36df974defcacbdd958 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570024 Reviewed-by: Toni Baržić <tbarzic@chromium.org> Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#652257} .../enrollment_local_policy_server_browsertest.cc | 23 ++++++ .../login/mixin_based_in_process_browser_test.cc | 17 +++++ .../login/mixin_based_in_process_browser_test.h | 4 + .../chromeos/login/saml/saml_browsertest.cc | 12 +-- .../chromeos/login/test/device_state_mixin.cc | 87 +++++++++++++++++----- .../chromeos/login/test/device_state_mixin.h | 6 +- 6 files changed, 119 insertions(+), 30 deletions(-) commit 0f9e5ca8833c1dc8a58fc17bf8e4a5ce273f4a90 Author: David 'Digit' Turner <digit@google.com> Date: Thu Apr 18 19:20:45 2019 +0000 Updating XTBs based on .GRDs from branch master R=govind@chromium.org Exempt-From-Owner-Approval: Mechanical import from google3. Change-Id: I00360ddfc801d884815b21eaf9d1ba916f64ef8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573623 Reviewed-by: Krishna Govind <govind@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#652256} .../strings/ash_components_strings_te.xtb | 6 +- ash/strings/ash_strings_ta.xtb | 7 +- ash/strings/ash_strings_te.xtb | 2 +- ash/strings/ash_strings_th.xtb | 2 +- ash/strings/ash_strings_vi.xtb | 8 +- ...ndroid_chrome_autofill_assistant_strings_nl.xtb | 2 +- .../translations/android_chrome_strings_am.xtb | 3 - .../translations/android_chrome_strings_ar.xtb | 5 +- .../translations/android_chrome_strings_bg.xtb | 3 - .../translations/android_chrome_strings_bn.xtb | 11 +- .../translations/android_chrome_strings_ca.xtb | 3 - .../translations/android_chrome_strings_cs.xtb | 3 - .../translations/android_chrome_strings_da.xtb | 3 - .../translations/android_chrome_strings_de.xtb | 3 - .../translations/android_chrome_strings_el.xtb | 3 - .../translations/android_chrome_strings_en-GB.xtb | 3 - .../translations/android_chrome_strings_es-419.xtb | 3 - .../translations/android_chrome_strings_es.xtb | 3 - .../translations/android_chrome_strings_et.xtb | 3 - .../translations/android_chrome_strings_fa.xtb | 3 - .../translations/android_chrome_strings_fi.xtb | 3 - .../translations/android_chrome_strings_fil.xtb | 3 - .../translations/android_chrome_strings_fr.xtb | 3 - .../translations/android_chrome_strings_gu.xtb | 3 - .../translations/android_chrome_strings_hi.xtb | 3 - .../translations/android_chrome_strings_hr.xtb | 3 - .../translations/android_chrome_strings_hu.xtb | 3 - .../translations/android_chrome_strings_id.xtb | 3 - .../translations/android_chrome_strings_it.xtb | 5 +- .../translations/android_chrome_strings_iw.xtb | 3 - .../translations/android_chrome_strings_ja.xtb | 3 - .../translations/android_chrome_strings_kn.xtb | 3 - .../translations/android_chrome_strings_ko.xtb | 3 - .../translations/android_chrome_strings_lt.xtb | 3 - .../translations/android_chrome_strings_lv.xtb | 3 - .../translations/android_chrome_strings_ml.xtb | 3 - .../translations/android_chrome_strings_mr.xtb | 5 +- .../translations/android_chrome_strings_ms.xtb | 3 - .../translations/android_chrome_strings_nl.xtb | 3 - .../translations/android_chrome_strings_no.xtb | 5 +- .../translations/android_chrome_strings_pl.xtb | 3 - .../translations/android_chrome_strings_pt-BR.xtb | 3 - .../translations/android_chrome_strings_pt-PT.xtb | 3 - .../translations/android_chrome_strings_ro.xtb | 3 - .../translations/android_chrome_strings_ru.xtb | 3 - .../translations/android_chrome_strings_sk.xtb | 3 - .../translations/android_chrome_strings_sl.xtb | 3 - .../translations/android_chrome_strings_sr.xtb | 5 +- .../translations/android_chrome_strings_sv.xtb | 3 - .../translations/android_chrome_strings_sw.xtb | 5 +- .../translations/android_chrome_strings_ta.xtb | 11 +- .../translations/android_chrome_strings_te.xtb | 21 +-- .../translations/android_chrome_strings_th.xtb | 3 - .../translations/android_chrome_strings_tr.xtb | 3 - .../translations/android_chrome_strings_uk.xtb | 3 - .../translations/android_chrome_strings_vi.xtb | 3 - .../translations/android_chrome_strings_zh-CN.xtb | 3 - .../translations/android_chrome_strings_zh-TW.xtb | 3 - .../strings/translations/touchless_strings_ta.xtb | 2 + chrome/app/resources/chromium_strings_ar.xtb | 10 +- chrome/app/resources/chromium_strings_hi.xtb | 2 +- chrome/app/resources/chromium_strings_id.xtb | 2 +- chrome/app/resources/chromium_strings_no.xtb | 2 +- chrome/app/resources/chromium_strings_sl.xtb | 8 +- chrome/app/resources/chromium_strings_ta.xtb | 3 +- chrome/app/resources/chromium_strings_te.xtb | 26 +-- chrome/app/resources/generated_resources_am.xtb | 2 - chrome/app/resources/generated_resources_ar.xtb | 36 ++-- chrome/app/resources/generated_resources_bg.xtb | 2 - chrome/app/resources/generated_resources_bn.xtb | 2 - chrome/app/resources/generated_resources_ca.xtb | 4 +- chrome/app/resources/generated_resources_cs.xtb | 12 +- chrome/app/resources/generated_resources_da.xtb | 2 - chrome/app/resources/generated_resources_de.xtb | 2 - chrome/app/resources/generated_resources_el.xtb | 6 +- chrome/app/resources/generated_resources_en-GB.xtb | 2 - .../app/resources/generated_resources_es-419.xtb | 4 +- chrome/app/resources/generated_resources_es.xtb | 4 +- chrome/app/resources/generated_resources_et.xtb | 2 - chrome/app/resources/generated_resources_fa.xtb | 2 - chrome/app/resources/generated_resources_fi.xtb | 2 - chrome/app/resources/generated_resources_fil.xtb | 2 - chrome/app/resources/generated_resources_fr.xtb | 2 - chrome/app/resources/generated_resources_gu.xtb | 4 +- chrome/app/resources/generated_resources_hi.xtb | 10 +- chrome/app/resources/generated_resources_hr.xtb | 2 - chrome/app/resources/generated_resources_hu.xtb | 4 +- chrome/app/resources/generated_resources_id.xtb | 14 +- chrome/app/resources/generated_resources_it.xtb | 2 - chrome/app/resources/generated_resources_iw.xtb | 4 +- chrome/app/resources/generated_resources_ja.xtb | 2 - chrome/app/resources/generated_resources_kn.xtb | 2 - chrome/app/resources/generated_resources_ko.xtb | 2 - chrome/app/resources/generated_resources_lt.xtb | 2 - chrome/app/resources/generated_resources_lv.xtb | 4 +- chrome/app/resources/generated_resources_ml.xtb | 2 - chrome/app/resources/generated_resources_mr.xtb | 4 +- chrome/app/resources/generated_resources_ms.xtb | 8 +- chrome/app/resources/generated_resources_nl.xtb | 2 - chrome/app/resources/generated_resources_no.xtb | 22 +-- chrome/app/resources/generated_resources_pl.xtb | 2 - chrome/app/resources/generated_resources_pt-BR.xtb | 2 - chrome/app/resources/generated_resources_pt-PT.xtb | 2 - chrome/app/resources/generated_resources_ro.xtb | 2 - chrome/app/resources/generated_resources_ru.xtb | 2 - chrome/app/resources/generated_resources_sk.xtb | 6 +- chrome/app/resources/generated_resources_sl.xtb | 6 +- chrome/app/resources/generated_resources_sr.xtb | 4 +- chrome/app/resources/generated_resources_sv.xtb | 2 - chrome/app/resources/generated_resources_sw.xtb | 10 +- chrome/app/resources/generated_resources_ta.xtb | 44 ++++- chrome/app/resources/generated_resources_te.xtb | 83 ++++----- chrome/app/resources/generated_resources_th.xtb | 6 +- chrome/app/resources/generated_resources_tr.xtb | 4 +- chrome/app/resources/generated_resources_uk.xtb | 6 +- chrome/app/resources/generated_resources_vi.xtb | 8 +- chrome/app/resources/generated_resources_zh-CN.xtb | 2 - chrome/app/resources/generated_resources_zh-TW.xtb | 2 - chrome/app/resources/google_chrome_strings_ar.xtb | 12 +- chrome/app/resources/google_chrome_strings_hi.xtb | 2 +- chrome/app/resources/google_chrome_strings_id.xtb | 2 +- chrome/app/resources/google_chrome_strings_no.xtb | 2 +- chrome/app/resources/google_chrome_strings_sl.xtb | 10 +- chrome/app/resources/google_chrome_strings_ta.xtb | 3 +- chrome/app/resources/google_chrome_strings_te.xtb | 22 +-- .../camera/src/strings/camera_strings_ta.xtb | 1 + .../chromevox/strings/chromevox_strings_bn.xtb | 2 +- .../chromevox/strings/chromevox_strings_ca.xtb | 2 +- .../chromevox/strings/chromevox_strings_es-419.xtb | 2 +- .../chromevox/strings/chromevox_strings_es.xtb | 2 +- .../chromevox/strings/chromevox_strings_ja.xtb | 2 +- .../chromevox/strings/chromevox_strings_ko.xtb | 2 +- .../chromevox/strings/chromevox_strings_lt.xtb | 2 +- .../chromevox/strings/chromevox_strings_ml.xtb | 2 +- .../chromevox/strings/chromevox_strings_mr.xtb | 2 +- .../chromevox/strings/chromevox_strings_ro.xtb | 2 +- .../chromevox/strings/chromevox_strings_sk.xtb | 2 +- .../chromevox/strings/chromevox_strings_sl.xtb | 2 +- .../chromevox/strings/chromevox_strings_sr.xtb | 2 +- .../chromevox/strings/chromevox_strings_sv.xtb | 2 +- .../chromevox/strings/chromevox_strings_ta.xtb | 20 +- .../chromevox/strings/chromevox_strings_te.xtb | 10 +- .../chromevox/strings/chromevox_strings_uk.xtb | 2 +- .../gaiacp/strings/gaia_resources_ar.xtb | 2 +- .../gaiacp/strings/gaia_resources_cs.xtb | 2 +- .../gaiacp/strings/gaia_resources_es-419.xtb | 2 +- .../gaiacp/strings/gaia_resources_gu.xtb | 2 +- .../gaiacp/strings/gaia_resources_no.xtb | 6 +- .../policy/resources/policy_templates_am.xtb | 22 --- .../policy/resources/policy_templates_ar.xtb | 30 --- .../policy/resources/policy_templates_bg.xtb | 29 --- .../policy/resources/policy_templates_bn.xtb | 30 --- .../policy/resources/policy_templates_ca.xtb | 30 --- .../policy/resources/policy_templates_cs.xtb | 22 --- .../policy/resources/policy_templates_da.xtb | 30 --- .../policy/resources/policy_templates_de.xtb | 22 --- .../policy/resources/policy_templates_el.xtb | 30 --- .../policy/resources/policy_templates_en-GB.xtb | 30 --- .../policy/resources/policy_templates_es-419.xtb | 30 --- .../policy/resources/policy_templates_es.xtb | 22 --- .../policy/resources/policy_templates_et.xtb | 27 --- .../policy/resources/policy_templates_fa.xtb | 29 --- .../policy/resources/policy_templates_fi.xtb | 30 --- .../policy/resources/policy_templates_fil.xtb | 30 --- .../policy/resources/policy_templates_fr.xtb | 30 --- .../policy/resources/policy_templates_gu.xtb | 30 --- .../policy/resources/policy_templates_hi.xtb | 38 +--- .../policy/resources/policy_templates_hr.xtb | 30 --- .../policy/resources/policy_templates_hu.xtb | 30 --- .../policy/resources/policy_templates_id.xtb | 22 --- .../policy/resources/policy_templates_it.xtb | 30 --- .../policy/resources/policy_templates_iw.xtb | 30 --- .../policy/resources/policy_templates_ja.xtb | 30 --- .../policy/resources/policy_templates_kn.xtb | 34 ---- .../policy/resources/policy_templates_ko.xtb | 29 --- .../policy/resources/policy_templates_lt.xtb | 30 --- .../policy/resources/policy_templates_lv.xtb | 27 --- .../policy/resources/policy_templates_ml.xtb | 22 --- .../policy/resources/policy_templates_mr.xtb | 23 --- .../policy/resources/policy_templates_ms.xtb | 30 --- .../policy/resources/policy_templates_nl.xtb | 22 --- .../policy/resources/policy_templates_no.xtb | 32 +--- .../policy/resources/policy_templates_pl.xtb | 30 --- .../policy/resources/policy_templates_pt-BR.xtb | 30 --- .../policy/resources/policy_templates_pt-PT.xtb | 30 --- .../policy/resources/policy_templates_ro.xtb | 22 --- .../policy/resources/policy_templates_ru.xtb | 32 ---- .../policy/resources/policy_templates_sk.xtb | 23 --- .../policy/resources/policy_templates_sl.xtb | 30 --- .../policy/resources/policy_templates_sr.xtb | 30 --- .../policy/resources/policy_templates_sv.xtb | 29 --- .../policy/resources/policy_templates_sw.xtb | 24 --- .../policy/resources/policy_templates_ta.xtb | 51 ++--- .../policy/resources/policy_templates_te.xtb | 207 +++++++++------------ .../policy/resources/policy_templates_th.xtb | 30 --- .../policy/resources/policy_templates_tr.xtb | 29 --- .../policy/resources/policy_templates_uk.xtb | 30 --- .../policy/resources/policy_templates_vi.xtb | 30 --- .../policy/resources/policy_templates_zh-CN.xtb | 22 --- .../policy/resources/policy_templates_zh-TW.xtb | 23 --- components/strings/components_strings_bn.xtb | 2 +- components/strings/components_strings_ca.xtb | 4 +- components/strings/components_strings_es-419.xtb | 2 +- components/strings/components_strings_es.xtb | 4 +- components/strings/components_strings_hi.xtb | 2 +- components/strings/components_strings_ja.xtb | 2 +- components/strings/components_strings_ko.xtb | 2 +- components/strings/components_strings_lt.xtb | 2 +- components/strings/components_strings_ml.xtb | 2 +- components/strings/components_strings_mr.xtb | 2 +- components/strings/components_strings_ro.xtb | 4 +- components/strings/components_strings_sk.xtb | 2 +- components/strings/components_strings_sl.xtb | 2 +- components/strings/components_strings_sr.xtb | 2 +- components/strings/components_strings_sv.xtb | 2 +- components/strings/components_strings_ta.xtb | 14 +- components/strings/components_strings_te.xtb | 32 ++-- components/strings/components_strings_uk.xtb | 2 +- .../strings/translations/content_strings_ta.xtb | 12 +- .../strings/resources/ios_chromium_strings_te.xtb | 6 +- .../resources/ios_google_chrome_strings_te.xtb | 8 +- .../app/strings/resources/ios_strings_ta.xtb | 4 +- .../app/strings/resources/ios_strings_te.xtb | 4 +- remoting/resources/remoting_strings_am.xtb | 2 + remoting/resources/remoting_strings_ar.xtb | 2 + remoting/resources/remoting_strings_bg.xtb | 2 + remoting/resources/remoting_strings_bn.xtb | 2 + remoting/resources/remoting_strings_ca.xtb | 2 + remoting/resources/remoting_strings_cs.xtb | 2 + remoting/resources/remoting_strings_da.xtb | 2 + remoting/resources/remoting_strings_de.xtb | 2 + remoting/resources/remoting_strings_el.xtb | 2 + remoting/resources/remoting_strings_en-GB.xtb | 2 + remoting/resources/remoting_strings_es-419.xtb | 2 + remoting/resources/remoting_strings_es.xtb | 2 + remoting/resources/remoting_strings_et.xtb | 2 + remoting/resources/remoting_strings_fa.xtb | 2 + remoting/resources/remoting_strings_fi.xtb | 2 + remoting/resources/remoting_strings_fil.xtb | 2 + remoting/resources/remoting_strings_fr.xtb | 2 + remoting/resources/remoting_strings_gu.xtb | 2 + remoting/resources/remoting_strings_hi.xtb | 2 + remoting/resources/remoting_strings_hr.xtb | 2 + remoting/resources/remoting_strings_hu.xtb | 2 + remoting/resources/remoting_strings_id.xtb | 2 + remoting/resources/remoting_strings_it.xtb | 2 + remoting/resources/remoting_strings_iw.xtb | 2 + remoting/resources/remoting_strings_ja.xtb | 2 + remoting/resources/remoting_strings_kn.xtb | 2 + remoting/resources/remoting_strings_ko.xtb | 2 + remoting/resources/remoting_strings_lt.xtb | 2 + remoting/resources/remoting_strings_lv.xtb | 2 + remoting/resources/remoting_strings_ml.xtb | 2 + remoting/resources/remoting_strings_mr.xtb | 2 + remoting/resources/remoting_strings_ms.xtb | 2 + remoting/resources/remoting_strings_nl.xtb | 2 + remoting/resources/remoting_strings_no.xtb | 2 + remoting/resources/remoting_strings_pl.xtb | 2 + remoting/resources/remoting_strings_pt-BR.xtb | 2 + remoting/resources/remoting_strings_pt-PT.xtb | 2 + remoting/resources/remoting_strings_ro.xtb | 2 + remoting/resources/remoting_strings_ru.xtb | 2 + remoting/resources/remoting_strings_sk.xtb | 2 + remoting/resources/remoting_strings_sl.xtb | 2 + remoting/resources/remoting_strings_sr.xtb | 2 + remoting/resources/remoting_strings_sv.xtb | 2 + remoting/resources/remoting_strings_sw.xtb | 2 + remoting/resources/remoting_strings_ta.xtb | 2 + remoting/resources/remoting_strings_te.xtb | 16 +- remoting/resources/remoting_strings_th.xtb | 2 + remoting/resources/remoting_strings_tr.xtb | 2 + remoting/resources/remoting_strings_uk.xtb | 2 + remoting/resources/remoting_strings_vi.xtb | 2 + remoting/resources/remoting_strings_zh-CN.xtb | 2 + remoting/resources/remoting_strings_zh-TW.xtb | 2 + .../accessibility_extensions_strings_te.xtb | 4 +- .../translations/ui_chromeos_strings_am.xtb | 1 + .../translations/ui_chromeos_strings_ar.xtb | 1 + .../translations/ui_chromeos_strings_bg.xtb | 1 + .../translations/ui_chromeos_strings_bn.xtb | 1 + .../translations/ui_chromeos_strings_ca.xtb | 1 + .../translations/ui_chromeos_strings_cs.xtb | 5 +- .../translations/ui_chromeos_strings_da.xtb | 1 + .../translations/ui_chromeos_strings_de.xtb | 1 + .../translations/ui_chromeos_strings_el.xtb | 1 + .../translations/ui_chromeos_strings_en-GB.xtb | 1 + .../translations/ui_chromeos_strings_es-419.xtb | 1 + .../translations/ui_chromeos_strings_es.xtb | 1 + .../translations/ui_chromeos_strings_et.xtb | 1 + .../translations/ui_chromeos_strings_fa.xtb | 1 + .../translations/ui_chromeos_strings_fi.xtb | 1 + .../translations/ui_chromeos_strings_fil.xtb | 1 + .../translations/ui_chromeos_strings_fr.xtb | 1 + .../translations/ui_chromeos_strings_gu.xtb | 1 + .../translations/ui_chromeos_strings_hi.xtb | 1 + .../translations/ui_chromeos_strings_hr.xtb | 1 + .../translations/ui_chromeos_strings_hu.xtb | 1 + .../translations/ui_chromeos_strings_id.xtb | 1 + .../translations/ui_chromeos_strings_it.xtb | 1 + .../translations/ui_chromeos_strings_iw.xtb | 1 + .../translations/ui_chromeos_strings_ja.xtb | 1 + .../translations/ui_chromeos_strings_kn.xtb | 1 + .../translations/ui_chromeos_strings_ko.xtb | 1 + .../translations/ui_chromeos_strings_lt.xtb | 1 + .../translations/ui_chromeos_strings_lv.xtb | 1 + .../translations/ui_chromeos_strings_ml.xtb | 1 + .../translations/ui_chromeos_strings_mr.xtb | 1 + .../translations/ui_chromeos_strings_ms.xtb | 1 + .../translations/ui_chromeos_strings_nl.xtb | 1 + .../translations/ui_chromeos_strings_no.xtb | 1 + .../translations/ui_chromeos_strings_pl.xtb | 1 + .../translations/ui_chromeos_strings_pt-BR.xtb | 1 + .../translations/ui_chromeos_strings_pt-PT.xtb | 1 + .../translations/ui_chromeos_strings_ro.xtb | 1 + .../translations/ui_chromeos_strings_ru.xtb | 1 + .../translations/ui_chromeos_strings_sk.xtb | 1 + .../translations/ui_chromeos_strings_sl.xtb | 1 + .../translations/ui_chromeos_strings_sr.xtb | 1 + .../translations/ui_chromeos_strings_sv.xtb | 1 + .../translations/ui_chromeos_strings_sw.xtb | 1 + .../translations/ui_chromeos_strings_ta.xtb | 1 + .../translations/ui_chromeos_strings_te.xtb | 9 +- .../translations/ui_chromeos_strings_th.xtb | 1 + .../translations/ui_chromeos_strings_tr.xtb | 1 + .../translations/ui_chromeos_strings_uk.xtb | 1 + .../translations/ui_chromeos_strings_vi.xtb | 1 + .../translations/ui_chromeos_strings_zh-CN.xtb | 1 + .../translations/ui_chromeos_strings_zh-TW.xtb | 1 + ui/strings/translations/ui_strings_bn.xtb | 2 +- ui/strings/translations/ui_strings_ca.xtb | 2 +- ui/strings/translations/ui_strings_es-419.xtb | 2 +- ui/strings/translations/ui_strings_es.xtb | 2 +- ui/strings/translations/ui_strings_ja.xtb | 2 +- ui/strings/translations/ui_strings_ko.xtb | 2 +- ui/strings/translations/ui_strings_lt.xtb | 2 +- ui/strings/translations/ui_strings_ml.xtb | 2 +- ui/strings/translations/ui_strings_mr.xtb | 2 +- ui/strings/translations/ui_strings_ro.xtb | 2 +- ui/strings/translations/ui_strings_sk.xtb | 2 +- ui/strings/translations/ui_strings_sl.xtb | 2 +- ui/strings/translations/ui_strings_sr.xtb | 2 +- ui/strings/translations/ui_strings_sv.xtb | 2 +- ui/strings/translations/ui_strings_ta.xtb | 4 +- ui/strings/translations/ui_strings_te.xtb | 2 +- ui/strings/translations/ui_strings_uk.xtb | 2 +- 345 files changed, 661 insertions(+), 2126 deletions(-) commit a71e1e74bff1ab4bdb919da3e26f3b067091d5e4 Author: Tibor Goldschwendt <tiborg@chromium.org> Date: Thu Apr 18 19:18:19 2019 +0000 [modules] Add dummy lib to VR DFM This will enable testing the library loading mechanism in the wild. Bug: 943210 Change-Id: I4af3582924d4e6653f403a02898b54d5cf743a22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564334 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by: Christopher Grant <cjgrant@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#652255} build/config/android/rules.gni | 9 ++- chrome/android/BUILD.gn | 23 ++++-- chrome/android/features/vr/vr_module_tmpl.gni | 20 ++++++ chrome/browser/android/vr/BUILD.gn | 22 ++++++ chrome/browser/android/vr/ui_dummy.cc | 15 ++++ chrome/browser/android/vr/ui_dummy.h | 17 +++++ .../browser/android/vr/ui_module_dummy_factory.cc | 83 ++++++++++++++++++++++ .../browser/android/vr/ui_module_dummy_factory.h | 34 +++++++++ 8 files changed, 216 insertions(+), 7 deletions(-) commit 41417820be10c0edeff9cb515cb0d3bca94ae6dc Author: Miguel Casas-Sanchez <mcasas@chromium.org> Date: Thu Apr 18 19:17:17 2019 +0000 Correct TEAM in OWNERS to webrtc-dev@chromium.org Bug: 950943 Change-Id: I9b68a3e628ef022795a7666cd5b26571b9d6b9f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566336 Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Guido Urdaneta <guidou@chromium.org> Reviewed-by: Tommi <tommi@chromium.org> Reviewed-by: Christian Fremerey <chfremer@chromium.org> Auto-Submit: Miguel Casas <mcasas@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#652254} chrome/browser/extensions/api/desktop_capture/OWNERS | 2 +- content/browser/image_capture/OWNERS | 2 +- content/browser/renderer_host/media/OWNERS | 2 +- content/renderer/image_capture/OWNERS | 2 +- content/renderer/media/stream/OWNERS | 2 +- content/renderer/media_capture_from_element/OWNERS | 1 + media/capture/video/OWNERS | 2 +- media/capture/video/android/java/src/org/chromium/media/OWNERS | 2 +- services/video_capture/OWNERS | 2 +- third_party/blink/common/mediastream/OWNERS | 2 +- third_party/blink/public/common/mediastream/OWNERS | 2 +- third_party/blink/public/mojom/mediastream/OWNERS | 2 +- third_party/blink/public/platform/modules/mediastream/OWNERS | 2 +- third_party/blink/public/web/modules/mediastream/OWNERS | 2 +- third_party/blink/renderer/modules/imagecapture/OWNERS | 2 +- third_party/blink/renderer/modules/mediacapturefromelement/OWNERS | 2 +- third_party/blink/renderer/modules/mediastream/OWNERS | 2 +- third_party/blink/renderer/platform/exported/mediastream/OWNERS | 2 +- third_party/blink/web_tests/external/wpt/html-media-capture/OWNERS | 2 +- third_party/decklink/OWNERS | 2 +- 20 files changed, 20 insertions(+), 19 deletions(-) commit 80c575a9c39170d4619597626deb9e08c5ff3bc3 Author: Jacob Dufault <jdufault@google.com> Date: Thu Apr 18 19:14:26 2019 +0000 cros: Simplify BaseScreen configuration code Bug: 928555 Change-Id: I6ae62f29040216ea349c3d78f102716e86044d1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562715 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#652253} .../browser/chromeos/login/screens/base_screen.cc | 6 +-- .../browser/chromeos/login/screens/base_screen.h | 6 +-- .../chromeos/login/screens/mock_welcome_screen.h | 2 +- chrome/browser/chromeos/login/wizard_controller.cc | 8 ++- chrome/browser/chromeos/login/wizard_controller.h | 4 +- .../login/wizard_controller_browsertest.cc | 63 +++++++++++----------- 6 files changed, 40 insertions(+), 49 deletions(-) commit dc86bdf472b380da3e03f5f5eaa0e1cf77fac7fe Author: Yuwei Huang <yuweih@chromium.org> Date: Thu Apr 18 19:14:10 2019 +0000 [remoting][FTL] Enhance TestOauthTokenGetter * Caches the refresh token instead of the access token if the account is whitelisted to show 1P scope in consent page * Allow signing in as the service account Bug: 947337 Change-Id: Icdd18cbe7d9269a1f593f47d79a7867b37df0e91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572932 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#652252} remoting/test/cli_util.cc | 5 ++ remoting/test/cli_util.h | 4 ++ remoting/test/ftl_services_playground.cc | 3 +- remoting/test/ftl_signaling_playground.cc | 16 ++++-- remoting/test/test_oauth_token_getter.cc | 83 +++++++++++++++++++++++++------ remoting/test/test_oauth_token_getter.h | 15 +++++- 6 files changed, 104 insertions(+), 22 deletions(-) commit bb11b294a7fdf4f8f959f4234f4f5e7a3f8e44b7 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Apr 18 19:13:07 2019 +0000 Roll src/third_party/catapult f76561176b6c..c2caea81a024 (6 commits) https://chromium.googlesource.com/catapult.git/+log/f76561176b6c..c2caea81a024 git log f76561176b6c..c2caea81a024 --date=short --no-merges --format='%ad %ae %s' 2019-04-18 benjhayden@chromium.org Break words in details-table 2019-04-18 benjhayden@chromium.org Migrate alerts-section.js to es6 module 2019-04-18 benjhayden@chromium.org Migrate cp-loading.js to es6 module 2019-04-18 crouleau@chromium.org Revert "Telemetry: separate the preparation code while keeping old interface" 2019-04-18 khokhlov@google.com Revert "Skip non-module dirs when discovering classes" 2019-04-18 sergiyb@chromium.org Move telemetry binary dependencies config out of the internal namespace Created with: gclient setdep -r src/third_party/catapult@c2caea81a024 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:950011,chromium:950011,chromium:939374,chromium:952789,chromium:953776,chromium:895891 TBR=oysteine@chromium.org Change-Id: I20dfce7f7820f94bfeb35d25b9936e51f774d537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574038 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652251} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 31d721a985e4cae9ac2cb5a979155cfb56906e77 Author: Caleb Raitto <caraitto@chromium.org> Date: Thu Apr 18 19:07:58 2019 +0000 [Cronet] Add safety notes about adding / removing and destroying listeners. API users should know that adding / removing listeners may not take effect for already-stared requests -- add a note. Also, some of the earlier comments on listener and executor lifetime turned out to be wrong -- fix these, and simplify the wording. Bug: 879208 Change-Id: Ibd4e07993b598b7d7aafb416d9e571227c1db3ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556379 Reviewed-by: Misha Efimov <mef@chromium.org> Reviewed-by: Paul Jensen <pauljensen@chromium.org> Commit-Queue: Caleb Raitto <caraitto@chromium.org> Cr-Commit-Position: refs/heads/master@{#652250} components/cronet/native/cronet.idl | 86 +++++++++++++++++++++++++++++-------- 1 file changed, 67 insertions(+), 19 deletions(-) commit 58e393545409a17685aa22007c8f25633d0e5ac8 Author: Hui(Andy) Wu <wuandy@chromium.org> Date: Thu Apr 18 19:06:19 2019 +0000 Reland "[autofill assistant] Introduce small delay between key presses." This is a reland of 012bea0a560626025f95799134741a0aa59f0b2c, with flacky test deleted. Original change's description: > [autofill assistant] Introduce small delay between key presses. > > Introduce a small delay between key presses while simulate_key_presses > is true. This hopefully will allow any JS from the website to have time > to process the events. > > Bug: b/124505757 > Change-Id: I3ab90bde3434043ae9988a9e0b7ff43fdf6e86fb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1567920 > Commit-Queue: Hui Wu <wuandy@chromium.org> > Reviewed-by: Clemens Arbesser <arbesser@google.com> > Cr-Commit-Position: refs/heads/master@{#652013} Bug: b/124505757 Change-Id: Ieb9153190ec7c80fc4debde93b3159df6f70ce88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573642 Reviewed-by: Clemens Arbesser <arbesser@google.com> Commit-Queue: Hui Wu <wuandy@chromium.org> Cr-Commit-Position: refs/heads/master@{#652249} .../browser/actions/action_delegate.h | 2 + .../browser/actions/autofill_action.cc | 1 + .../browser/actions/mock_action_delegate.h | 4 +- .../browser/actions/set_form_field_value_action.cc | 7 +++- .../autofill_assistant/browser/script_executor.cc | 10 +++-- .../autofill_assistant/browser/script_executor.h | 2 + .../autofill_assistant/browser/service.proto | 6 +++ .../autofill_assistant/browser/web_controller.cc | 44 +++++++++++++++++----- .../autofill_assistant/browser/web_controller.h | 11 +++++- .../browser/web_controller_browsertest.cc | 31 +++++++++++++-- .../autofill_assistant_target_website.html | 15 ++++++++ 11 files changed, 114 insertions(+), 19 deletions(-) commit e24dc38a064585ae02328fe62520c94bd6727b53 Author: Moe Ahmadi <mahmadi@chromium.org> Date: Thu Apr 18 19:05:23 2019 +0000 [IOS][Translate] Update state of Manual Translate Trigger tools menu entry Updates the state of the Translate Manual Trigger entry once page language has been determined. Otherwise, if the tools menu is opened before page load completes, the entry remains disabled. TBR=ben@chromium.org Bug: 905816 Change-Id: Ia225dc312474cd5f190268e8736c805c95f55f57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573644 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Reviewed-by: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#652248} components/BUILD.gn | 1 + components/language/ios/browser/BUILD.gn | 16 ++++ ...language_detection_tab_helper_observer_bridge.h | 50 +++++++++++ ...anguage_detection_tab_helper_observer_bridge.mm | 45 ++++++++++ ...etection_tab_helper_observer_bridge_unittest.mm | 98 ++++++++++++++++++++++ ios/chrome/browser/ui/popup_menu/BUILD.gn | 2 + .../browser/ui/popup_menu/popup_menu_mediator.mm | 28 +++++++ .../ui/popup_menu/popup_menu_mediator_unittest.mm | 10 ++- 8 files changed, 249 insertions(+), 1 deletion(-) commit e36d10c6d21fa795d30ed0e38f3d681c0b785a25 Author: Sunny Sachanandani <sunnyps@chromium.org> Date: Thu Apr 18 19:04:16 2019 +0000 Plumbing for HDR10 color space surfaces Add support for setting GLSurface color space to HDR10 which is BT 2020 primaries with SMPTE ST 2084 (PQ) transfer function. Cleanup color space conversion between gfx::ColorSpace and GL / GLSurface enums. This CL doesn't change any behavior. It's intended to pave the way for using RGB10A2 surfaces with HDR10 color space in an upcoming CL: https://chromium-review.googlesource.com/c/chromium/src/+/1565631/ Bug: 937108 Change-Id: I4fbc31c7e8ff322427013ab7572afc4e8fa9e5b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573172 Reviewed-by: Antoine Labour <piman@chromium.org> Reviewed-by: ccameron <ccameron@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#652247} cc/test/pixel_test_output_surface.cc | 4 +-- .../service/display_embedder/gl_output_surface.cc | 4 +-- .../display_embedder/skia_output_device_gl.cc | 6 ++-- .../skia_output_surface_impl_non_ddl.cc | 6 ++-- components/viz/test/fake_output_surface.cc | 4 +-- .../gpu_browser_compositor_output_surface.cc | 4 +-- .../renderer_host/compositor_impl_android.cc | 4 +-- gpu/GLES2/extensions/CHROMIUM/CHROMIUM_resize.txt | 3 +- .../extensions/CHROMIUM/CHROMIUM_shared_image.txt | 4 +-- gpu/GLES2/gl2extchromium.h | 8 ++++-- .../gles2_cmd_utils_implementation_autogen.h | 6 +++- gpu/command_buffer/service/gles2_cmd_decoder.cc | 3 ++ .../service/gles2_cmd_decoder_passthrough_doers.cc | 3 ++ ui/compositor/test/in_process_context_factory.cc | 4 +-- ui/gfx/color_space.cc | 4 +-- ui/gfx/color_space.h | 11 ++++++++ ui/gl/BUILD.gn | 2 ++ ui/gl/color_space_utils.cc | 33 ++++++++++++++++++++++ ui/gl/color_space_utils.h | 31 ++++++++++++++++++++ ui/gl/gl_bindings.h | 5 ++-- ui/gl/gl_enums_implementation_autogen.h | 6 +++- ui/gl/gl_surface.h | 1 + ui/gl/gl_utils.cc | 7 ----- ui/gl/gl_utils.h | 6 ---- 24 files changed, 125 insertions(+), 44 deletions(-) commit 35a808c32f6a2563b7e73320bf6c05504c6bed04 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Apr 18 19:03:40 2019 +0000 Roll src/third_party/depot_tools 1e2cb1573bd2..ac9b0f378677 (1 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1e2cb1573bd2..ac9b0f378677 git log 1e2cb1573bd2..ac9b0f378677 --date=short --no-merges --format='%ad %ae %s' 2019-04-18 agable@chromium.org Restore py2/py3 compatibility with basestring Created with: gclient setdep -r src/third_party/depot_tools@ac9b0f378677 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:942522 TBR=agable@chromium.org Change-Id: Ib970dc84826f462aeb05f94719e56f03949235cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573282 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652246} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 483f4054f577fed673c5cec47f3396a40cd0591d Author: Xi Han <hanxi@google.com> Date: Thu Apr 18 19:00:05 2019 +0000 Make InProcessPrefServiceFactoryFactory a SimpleKeyedServiceFactory. In this CL, we convert InProcessPrefServiceFactoryFactory from a BrowserContextKeyedBaseFactory to a SimpleKeyedServiceFactory. This allows the InProcessPrefServiceFactoryFactory be used before the profile is created. Bug: 937469 Change-Id: I2704875d84e553b3f3af40ec37109ac6e4786fbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569347 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#652245} .../prefs/in_process_service_factory_factory.cc | 26 ++++++++++------------ .../prefs/in_process_service_factory_factory.h | 18 +++++++-------- .../profiles/off_the_record_profile_impl.cc | 4 ++-- chrome/browser/profiles/profile_impl.cc | 4 ++-- 4 files changed, 25 insertions(+), 27 deletions(-) commit 331170e56b322575af8d353aa568b53f0b02f0e8 Author: sczs <sczs@chromium.org> Date: Thu Apr 18 18:56:18 2019 +0000 [ios] Fixes IOSPasswordInfobarController condition. Context: https://chromium-review.googlesource.com/c/chromium/src/+/1531689 /4/ios/chrome/browser/passwords/ios_password_infobar_controller.mm TBR=vasilii@chromium.org Bug: 945478 Change-Id: I2074567bb4d453648c19179462a62c4b31678cca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572564 Reviewed-by: Sergio Collazos <sczs@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#652244} ios/chrome/browser/passwords/ios_password_infobar_controller.mm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit a7547bf0d112c307246547eb11fe05061f2fc5d2 Author: Eugene But <eugenebut@google.com> Date: Thu Apr 18 18:55:29 2019 +0000 Create OWNERS file for ios/web_view/internal/translate. jzw@ wrote most of this code and ichikawa@ reviewed most of the code. This CL effectively removes eugenebut@, michaeldo@ and rohitrao@ from ios/web_view/internal/translate OWNERS, because these engineers are not very familiar with the code. Bug: None Change-Id: Ifd906536502765ec57fd42995147be4bf733bfaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569692 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: John Wu <jzw@chromium.org> Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#652243} ios/web_view/internal/translate/OWNERS | 10 ++++++++++ 1 file changed, 10 insertions(+) commit ac0ec6f78b44c731ef4871c031e30d915395f107 Author: danakj <danakj@chromium.org> Date: Thu Apr 18 18:54:12 2019 +0000 Convert Callbacks to OnceCallbacks in BluetoothDeviceClient. This will allow us to convert more Callbacks in the bluetooth component over to OnceCallbacks, which will let us convert Callbacks in content eventually. R=reillyg@chromium.org Bug: 953861 Change-Id: I4b84898c8ffd5ee9e56f881bb2d852ecd60878bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572998 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#652242} device/bluetooth/dbus/bluetooth_device_client.cc | 144 ++++++++++---------- device/bluetooth/dbus/bluetooth_device_client.h | 55 ++++---- .../bluetooth/dbus/fake_bluetooth_device_client.cc | 148 +++++++++++---------- .../bluetooth/dbus/fake_bluetooth_device_client.h | 68 +++++----- .../device/bluetooth/bluetooth_system_unittest.cc | 44 +++--- 5 files changed, 236 insertions(+), 223 deletions(-) commit 74279ecad74a4242c5123c8d200c6f0e5ba87a65 Author: danakj <danakj@chromium.org> Date: Thu Apr 18 18:50:23 2019 +0000 Convert Callbacks to OnceCallbacks in FakeBluetoothDeviceClient. Also migrates BluetoothProfileServiceProvider::ConfirmationCallback in the process. This will allow us to convert more Callbacks in the bluetooth component over to OnceCallbacks, which will let us convert Callbacks in content eventually. R=reillyg@chromium.org Bug: 953861 Change-Id: I9d27bbe876a9e4efa20953674617fbf58c817098 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572802 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#652241} .../bluez/bluetooth_adapter_profile_bluez.cc | 12 +- .../bluez/bluetooth_adapter_profile_bluez.h | 4 +- .../bluetooth_adapter_profile_bluez_unittest.cc | 6 +- device/bluetooth/bluez/bluetooth_bluez_unittest.cc | 4 +- device/bluetooth/bluez/bluetooth_socket_bluez.cc | 38 ++-- device/bluetooth/bluez/bluetooth_socket_bluez.h | 13 +- device/bluetooth/dbus/bluetooth_device_client.h | 5 + .../dbus/bluetooth_profile_service_provider.cc | 9 +- .../dbus/bluetooth_profile_service_provider.h | 6 +- .../bluetooth/dbus/fake_bluetooth_device_client.cc | 208 +++++++++++---------- .../bluetooth/dbus/fake_bluetooth_device_client.h | 40 ++-- .../fake_bluetooth_profile_service_provider.cc | 9 +- .../dbus/fake_bluetooth_profile_service_provider.h | 4 +- 13 files changed, 190 insertions(+), 168 deletions(-) commit 9e29a8b99282479e43006e5daa9b623ff7128960 Author: Andrey Kosyakov <caseq@chromium.org> Date: Thu Apr 18 18:45:11 2019 +0000 DevTools: fix Page.frameRequestedNavigation to report proper frame id when another frame is being navigated - Replace FrameLoadRequest::SetClientRedirect() with SetClientRedirectReason() that implies the request is for client redirect and provides the reason; - Move probe::frameRequestedNavigation to FrameLoader::StartNavigation() and as late there as possible, so we only fire it when we actually request browser to navigate; - Pass Frame* target_frame to probe::frameRequestedNavigation() and report target frame as frameId if present, so that when a frame requests another frame to navigate, the id of the latter is reported. Bug: b/130664370 Change-Id: Ia424542edc90d39977abf49335bb1a89345233a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570424 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#652240} .../blink/renderer/core/frame/local_frame.cc | 20 ++---------- .../blink/renderer/core/frame/remote_frame.cc | 8 +++++ .../renderer/core/html/forms/html_form_element.cc | 1 - .../renderer/core/inspector/browser_protocol.pdl | 2 +- .../core/inspector/inspector_page_agent.cc | 4 +-- .../renderer/core/inspector/inspector_page_agent.h | 2 +- .../core/loader/appcache/application_cache_host.cc | 2 +- .../blink/renderer/core/loader/form_submission.cc | 3 ++ .../renderer/core/loader/frame_load_request.h | 15 +++++++-- .../blink/renderer/core/loader/frame_loader.cc | 5 +++ .../renderer/core/loader/navigation_scheduler.cc | 12 +++---- .../blink/renderer/core/probe/core_probes.pidl | 2 +- ...rame-requested-navigation-subframe-expected.txt | 4 +++ .../page/frame-requested-navigation-subframe.js | 37 ++++++++++++++++++++++ .../frame-requested-navigation-subframe.html | 17 ++++++++++ 15 files changed, 101 insertions(+), 33 deletions(-) commit 9010c438e07cabe343ad2ea37a927b67fe76b582 Author: Robert Ma <robertma@chromium.org> Date: Thu Apr 18 18:45:04 2019 +0000 [blinkpy] Suppress stderr of git-cl by default Bug: 953499 Change-Id: I0f7dfc4317b2de9bc92ef9900dd6888143133a84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573879 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#652239} .../blink/tools/blinkpy/common/net/git_cl.py | 21 ++++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-) commit 7ffa51630cbd5480990fb7642c102c49cdac9d0f Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Apr 18 18:44:30 2019 +0000 Roll src/third_party/swiftshader f45b3881ebc6..ac07ed82c3b7 (2 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/f45b3881ebc6..ac07ed82c3b7 git log f45b3881ebc6..ac07ed82c3b7 --date=short --no-merges --format='%ad %ae %s' 2019-04-18 bclayton@google.com Reactor: Implement debug info generation 2019-04-18 bclayton@google.com Add libbacktrace submodule. Created with: gclient setdep -r src/third_party/swiftshader@ac07ed82c3b7 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: Ibaead0064a914769667caf55fdaa2625faf88505 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573821 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652238} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit cf7d2dd2d30c16b997323bea95b40df43fcea926 Author: John Budorick <jbudorick@chromium.org> Date: Thu Apr 18 18:42:05 2019 +0000 chromium.android: run resource_sizes on swarming. Not sure this'll work, but if it does, it'll ensure that resource_sizes runs with the perf merge script. Bug: 861983 Change-Id: I8e62c92b5be4cdd429bdca00b05c98246e195f1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573861 Commit-Queue: John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#652237} testing/buildbot/chromium.android.json | 21 ++++++++++++++++++--- testing/buildbot/test_suites.pyl | 6 +++++- 2 files changed, 23 insertions(+), 4 deletions(-) commit 152d4e1342ea4bf51e14f726dfcfe4dd91a559a1 Author: Harley Li <hhli@chromium.org> Date: Thu Apr 18 18:41:01 2019 +0000 [DevTools] Application>Cache Storage: show query of urls and tooltip Bug: 951414 Change-Id: I2c52dfeead4963868154ffc8ea9394f6d7bd7221 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566120 Reviewed-by: Erik Luo <luoe@chromium.org> Commit-Queue: Haihong Li (Harley) <hhli@chromium.org> Cr-Commit-Position: refs/heads/master@{#652236} .../front_end/resources/ServiceWorkerCacheViews.js | 17 ++++++++++------- .../devtools/cache-storage/cache-data-expected.txt | 4 ++-- .../http/tests/devtools/cache-storage/cache-data.js | 4 ++-- 3 files changed, 14 insertions(+), 11 deletions(-) commit ad0585a042175a80123f6f994813f68f8fc74431 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Apr 18 18:40:56 2019 +0000 Roll src/third_party/SPIRV-Tools/src ac878fcbdd64..d754b70592ca (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/ac878fcbdd64..d754b70592ca git log ac878fcbdd64..d754b70592ca --date=short --no-merges --format='%ad %ae %s' 2019-04-18 stevenperron@google.com Shorten names of cmake targets (#2531) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@d754b70592ca The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I74b72a77fae01f636e795907fea0fedc31f27f3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573824 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652235} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 081d957f30a014184b0b1bdaf69cac3f2254f3fc Author: Chromium WPT Sync <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Date: Thu Apr 18 18:39:52 2019 +0000 Import wpt@604d57f8e21ffdea19f36ab01471b84425867d97 Using wpt-import in Chromium 313ab2379047d44ea646cd5794a3432f8c9c634c. With Chromium commits locally applied on WPT: 0a8f3ffa48 "Use testdriver Action API in WPT pointerevent touch tests - Part 2" 4e9215207a "[Code Health] Remove unnecessary reference file for web test" c1940432ee "[WPT/common/security-features] Merge subresource path construction" 40465b7400 "[Animation Worklet] Copy the effects of a migrating animator over to new global scope" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: Ie6bcaca1ec2243b90ec18135cb6c125cd094fd56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573804 Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652234} third_party/blink/web_tests/NeverFixTests | 1 + .../web_tests/external/WPT_BASE_MANIFEST_6.json | 360 +-------------------- .../external/wpt/common/get-host-info.sub.js | 2 +- .../abort/general.any.serviceworker-expected.txt | 49 ++- .../abort/general.any.sharedworker-expected.txt | 49 ++- .../api/abort/general.any.worker-expected.txt | 49 ++- .../basic/mode-same-origin.any.worker-expected.txt | 4 - .../api/basic/referrer.any.worker-expected.txt | 4 - .../api/cors/cors-basic.any.worker-expected.txt | 4 - .../cors-cookies-redirect.any.worker-expected.txt | 4 - .../api/cors/cors-cookies.any.worker-expected.txt | 4 - .../cors/cors-no-preflight.any.worker-expected.txt | 4 - .../api/cors/cors-origin.any.worker-expected.txt | 4 - .../cors-preflight-cache.any.worker-expected.txt | 4 - ...ght-not-cors-safelisted.any.worker-expected.txt | 4 - ...cors-preflight-redirect.any.worker-expected.txt | 11 +- ...cors-preflight-referrer.any.worker-expected.txt | 4 - .../cors-preflight-star.any.worker-expected.txt | 4 - .../cors-preflight-status.any.worker-expected.txt | 4 - .../cors/cors-preflight.any.worker-expected.txt | 4 - ...rs-redirect-credentials.any.worker-expected.txt | 4 - ...cors-redirect-preflight.any.worker-expected.txt | 4 - .../api/cors/cors-redirect.any.worker-expected.txt | 4 - ...back-to-original-origin.any.worker-expected.txt | 4 - .../redirect/redirect-mode.any.worker-expected.txt | 34 -- .../redirect-origin.any.worker-expected.txt | 4 - .../redirect-referrer.any.worker-expected.txt | 4 - .../redirect-to-dataurl.any.worker-expected.txt | 4 - .../fetch.any.sharedworker-expected.txt | 4 - .../fetch.any.worker-expected.txt | 4 - .../fetch.https.any.serviceworker-expected.txt | 4 - .../fetch.https.any.sharedworker-expected.txt | 4 - .../fetch.https.any.worker-expected.txt | 4 - .../scheme-restriction.any.worker-expected.txt | 4 - .../syntax.any.worker-expected.txt | 4 - .../fetch/origin/no-cors.any.worker-expected.txt | 4 - .../serviceworker/cache-match.https-expected.txt | 2 +- .../worker/cache-match.https-expected.txt | 2 +- ...ing-video-with-range-request.https-expected.txt | 4 +- ...tch-request-css-cross-origin.https-expected.txt | 9 - .../fetch-request-html-imports.https-expected.txt | 4 - .../multipart-image.https-expected.txt | 9 - .../opaque-response-preloaded.https-expected.txt | 5 - ...resource-timing-cross-origin.https-expected.txt | 4 - ...-with-body-accessed-response.https-expected.txt | 23 -- .../service-worker-csp-connect.https-expected.txt | 4 - .../service-worker-csp-default.https-expected.txt | 4 - .../service-worker-csp-script.https-expected.txt | 4 - .../external/wpt/xhr/send-redirect-post-upload.htm | 8 + .../service-worker-csp-default.https-expected.txt | 8 + .../service-worker-csp-script.https-expected.txt | 8 + 51 files changed, 193 insertions(+), 572 deletions(-) commit fd3e2d400b3b82314eaf50c4ab320086706da5e6 Author: Suman Kancherla <sumankancherla@chromium.org> Date: Thu Apr 18 18:39:24 2019 +0000 [xr] Added wait state and extra buttons to permission page Added a wait state (hour glass) to the UI so that when the user clicks on a permission button but the callbacks are yet to fire because of delay in the system, users do not perceive it as an issue with the XR stack. Also, added buttons for MIDI and screen-share. midi-button.png is created by snapshotting src/components/vector_icons/midi.icon icon loaded into views_examples_exe. GIMP is used to edit/export screen-share-button.png is sourced from src/chrome/android/java/res/drawable-xxxhdpi/infobar_screen_share.png, resized and colored black hourglass-button.png is essentially resized and colorized version of src/third_party/material_design_icons/src/action/ios/ic_hourglass_empty.imageset/ic_hourglass_empty_3x.png Bug: 952040, 951425 Change-Id: Ia51c0324d1c3864c1930868a9a66d4324fc1bc1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569968 Commit-Queue: Suman Kancherla <sumankancherla@chromium.org> Reviewed-by: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#652233} .../test-media/third-party/hourglass-button.png | Bin 0 -> 205 bytes .../test-media/third-party/midi-button.png | Bin 0 -> 303 bytes .../test-media/third-party/screen-share-button.png | Bin 0 -> 178 bytes .../webxr-samples/tests/permission-request.html | 16 ++++++++++++++++ 4 files changed, 16 insertions(+) commit c70e766cde70cffa12f936bab7b0ff30cd2de137 Author: Nick Harper <nharper@chromium.org> Date: Thu Apr 18 18:37:03 2019 +0000 Update bulk entries in HSTS preload list Change-Id: I2474df7f0e5f339f656811682be84ff4a67b8b32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557791 Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#652232} net/http/transport_security_state_static.json | 3385 ++++++++++++------------- 1 file changed, 1594 insertions(+), 1791 deletions(-) commit 1fee7f82e3bc21eeb7314c45a67f39303b2bbf6f Author: David Grogan <dgrogan@chromium.org> Date: Thu Apr 18 18:33:35 2019 +0000 [LayoutNG] Fragment caching interaction with FlexNG appears to be fixed https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=virtual%2Flayout_ng_experimental%2Fcss3%2Fflexbox%2Fflexbox-width-with-overflow-auto.html So we can remove this failure line from TestExpectations. Change-Id: Id2934204139eaa9c55807256f31d0ffa45a11e36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573809 Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#652231} third_party/blink/web_tests/TestExpectations | 2 -- 1 file changed, 2 deletions(-) commit fa575088ede8a7d8f0ca2a97444ae0bffcdcd050 Author: Alexei Filippov <alph@chromium.org> Date: Thu Apr 18 18:31:25 2019 +0000 [heap profiler] Remove profiling_fuzzer target A followup after r651916 BUG=954129,923459 Change-Id: I15e862e4b7cfe6f8ad59d42ad877f2c2d17b9083 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573656 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by: Max Moroz <mmoroz@chromium.org> Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#652230} testing/buildbot/chromium.fyi.json | 8 -------- testing/buildbot/gn_isolate_map.pyl | 4 ---- testing/buildbot/test_suites.pyl | 5 ----- 3 files changed, 17 deletions(-) commit c6b390387217a3610264bbb47ae985d22a7505e8 Author: Christopher Cameron <ccameron@chromium.org> Date: Thu Apr 18 18:22:24 2019 +0000 Add Skia/Metal to the Chromium build Keep it behind a skia_use_metal flag for the moment. Put the Metal sources in a separate place from skia_util_mac.mm, because Metal uses ARC and skia_util_mac.mm uses explicit reference counting. Bug: 952063 Change-Id: I601b3c9814b4beaf6a091871ba4dc2592c2fc498 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565387 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#652229} skia/BUILD.gn | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) commit 189db68019e8e0a40e1ed2b508d214acef239d51 Author: Alan Screen <awscreen@chromium.org> Date: Thu Apr 18 18:19:23 2019 +0000 Use unique_ptr for BrowserWithTestWindowTest::CreateBrowserWindow(). Bug: 948877 Change-Id: If2dee43b18c4e537ff25433918afae9b35268970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564563 Commit-Queue: Alan Screen <awscreen@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#652228} chrome/browser/printing/print_preview_test.cc | 4 ++-- chrome/browser/printing/print_preview_test.h | 2 +- chrome/browser/signin/signin_ui_util_unittest.cc | 4 ++-- .../ui/ash/launcher/chrome_launcher_controller_unittest.cc | 4 ++-- chrome/browser/ui/ash/media_client_unittest.cc | 2 +- .../local_card_migration_bubble_controller_impl_unittest.cc | 4 ++-- .../payments/save_card_bubble_controller_impl_unittest.cc | 4 ++-- chrome/browser/ui/browser_command_controller_unittest.cc | 4 ++-- chrome/browser/ui/browser_unittest.cc | 4 ++-- .../fullscreen_controller_state_unittest.cc | 13 ++++++++----- chrome/browser/ui/views/frame/test_with_browser_view.cc | 2 +- chrome/browser/ui/views/frame/test_with_browser_view.h | 2 +- .../ui/webui/media_router/media_router_web_ui_test.cc | 4 ++-- .../ui/webui/media_router/media_router_web_ui_test.h | 2 +- .../ui/webui/settings/site_settings_handler_unittest.cc | 2 +- .../ui/webui/signin/signin_error_handler_unittest.cc | 4 ++-- .../ui/webui/signin/sync_confirmation_handler_unittest.cc | 4 ++-- chrome/test/base/browser_with_test_window_test.cc | 11 ++++++----- chrome/test/base/browser_with_test_window_test.h | 8 +++++--- 19 files changed, 45 insertions(+), 39 deletions(-) commit 36089802c1e4e677ca93fceaa80ab1e51e789e33 Author: Olivier Robin <olivierrobin@chromium.org> Date: Thu Apr 18 18:17:09 2019 +0000 Restore reverse order when parsing UploadList. Before crrev/c/1460065, TextLogUploadList::ParseLogEntries returned a list of entries in reverse order. After this cl it is in the normal order. Because new crash upload are appended to the log file, the order in the source is oldest report first. The result is that crash reports were displayed in older first order, at least on iOS and Android. This CL restores the correct order of chrome://crashes which is showing newer crash uploaded first. Bug: 825994, 951449 Change-Id: Ib00d1f491773fbb3675e3a1927d36b75588c9401 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571406 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Auto-Submit: Olivier Robin <olivierrobin@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#652227} components/upload_list/text_log_upload_list.cc | 4 +++- components/upload_list/text_log_upload_list.h | 2 ++ components/upload_list/text_log_upload_list_unittest.cc | 5 +++-- 3 files changed, 8 insertions(+), 3 deletions(-) commit 2ab5fe796c873c8a43cc0f5a8008c7d2e85cc879 Author: Matt Menke <mmenke@chromium.org> Date: Thu Apr 18 18:14:13 2019 +0000 SpdySessionPool: Don't use IP pooling for requests that don't want it. This CL prevents the SpdySession pool from returning an IP pooled session to a request that does not want one. Bug: 912727 Change-Id: I06938adae3e1eca07e36d33f154a9bc473517785 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572584 Reviewed-by: Bence Béky <bnc@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#652226} net/spdy/spdy_session_pool.cc | 10 ++++++++-- net/spdy/spdy_session_pool.h | 3 +++ 2 files changed, 11 insertions(+), 2 deletions(-) commit e138d1b886e36727b5cf5b416ab41f290e93040f Author: Xi Han <hanxi@google.com> Date: Thu Apr 18 18:11:15 2019 +0000 Remove Profile from SupervisedUserSettingsService and SupervisedUserPrefStore. In this CL, we remove the registration of chrome::NOTIFICATION_PROFILE_DESTROYED event from SupervisedUserPrefStore. Instead, it will listens to the Shutdown() event from the SupervisedUserSettingsService. This is the same event that is sent from the KeyedServiceShutdownNotifier during Profile shutdown, and it is recommended to replace chrome::NOTIFICATION_PROFILE_DESTROYED event. Therefore, we can remove cached Profile* pointer from both classes. This is a precursor CL for: https://crrev.com/c/1532361/. Bug: 953716 Change-Id: Idde8a94d7d5f7c635b6dddb234416735abe6d635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535706 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#652225} .../content_settings_supervised_provider.cc | 4 +-- ...ontent_settings_supervised_provider_unittest.cc | 2 +- .../host_content_settings_map_factory.cc | 2 +- .../extensions/extension_service_sync_unittest.cc | 3 +- chrome/browser/profiles/profile_impl.cc | 2 +- ...omeos_mirror_account_consistency_browsertest.cc | 2 +- .../child_accounts/child_account_service.cc | 6 ++-- .../supervised_user/supervised_user_browsertest.cc | 29 ++++++++++-------- ...ervised_user_navigation_throttle_browsertest.cc | 5 ++-- .../supervised_user/supervised_user_pref_store.cc | 35 ++++++++++------------ .../supervised_user/supervised_user_pref_store.h | 18 +++++------ .../supervised_user_pref_store_unittest.cc | 2 +- .../supervised_user/supervised_user_service.cc | 3 +- .../supervised_user_service_browsertest.cc | 2 +- .../supervised_user_settings_service.cc | 23 +++++++------- .../supervised_user_settings_service.h | 28 +++++++++-------- .../supervised_user_settings_service_factory.cc | 35 +++++++++++----------- .../supervised_user_settings_service_factory.h | 20 ++++++------- .../supervised_user_settings_service_unittest.cc | 4 +-- chrome/browser/sync/chrome_sync_client.cc | 5 ++-- .../supervised_user_internals_message_handler.cc | 9 +++--- chrome/test/base/testing_profile.cc | 5 ++-- 22 files changed, 125 insertions(+), 119 deletions(-) commit 2498caba370cd6709f0d951ca69d2a06680a03a0 Author: Karandeep Bhatia <karandeepb@chromium.org> Date: Thu Apr 18 18:05:14 2019 +0000 DNR: Evaluate "removeHeaders" rules. This CL implements evaluation of "removeHeaders" rules. Currently removing cookie, set-cookie and referer headers is supported. BUG=947591 Change-Id: I90c9ca9dabfa3e97c4e9c1633c1ff8687e29a3d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559242 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#652224} .../declarative_net_request_apitest.cc | 9 + .../declarative_net_request_browsertest.cc | 71 +++++++- .../header_removal/background.js | 168 ++++++++++++++++++ .../header_removal/manifest.json | 23 +++ .../header_removal/rules_file_empty.json | 1 + .../declarative_net_request/simulate_click.html | 6 + .../declarative_net_request/simulate_click.js | 7 + content/public/test/test_navigation_observer.h | 2 + .../declarative_net_request/composite_matcher.cc | 23 +++ .../declarative_net_request/composite_matcher.h | 16 ++ .../api/declarative_net_request/constants.h | 14 ++ .../rules_monitor_service.cc | 55 ++++-- .../rules_monitor_service.h | 2 +- .../api/declarative_net_request/ruleset_manager.cc | 110 +++++++++++- .../api/declarative_net_request/ruleset_manager.h | 16 ++ .../api/declarative_net_request/ruleset_matcher.cc | 86 ++++++++- .../api/declarative_net_request/ruleset_matcher.h | 12 ++ .../ruleset_matcher_unittest.cc | 36 ++++ .../browser/api/web_request/web_request_api.cc | 192 ++++++++++++++++----- .../browser/api/web_request/web_request_api.h | 10 +- .../browser/api/web_request/web_request_info.h | 6 + .../api/declarative_net_request/test_utils.cc | 2 + .../api/declarative_net_request/test_utils.h | 1 + 23 files changed, 809 insertions(+), 59 deletions(-) commit 168468e5902843d429266ea5b4d2f44394b1ed95 Author: Oystein Eftevaag <oysteine@google.com> Date: Thu Apr 18 18:05:04 2019 +0000 Disabling v8.runtime_stats.top_25/Ads* on Mac due to perf bot failures NOTRY=true TBR=crouleau@chromium.org CC=mythria@chromium.org Bug: 954229 Change-Id: I1641cb1b8781c8236ce6a1eede4a2217b21dad54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574138 Reviewed-by: oysteine <oysteine@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#652223} tools/perf/expectations.config | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) commit f5d7fa32aace23b44a2d40e7a8bae1b2cc1ce8be Author: danakj <danakj@chromium.org> Date: Thu Apr 18 18:02:26 2019 +0000 Convert Callbacks to OnceCallbacks for BluetookAgentServiceProvider. This will allow us to convert more Callbacks in the bluetooth component over to OnceCallbacks, which will let us convert Callbacks in content eventually. R=reillyg@chromium.org Bug: 953861 Change-Id: I21555216157c1d56249c6ec93c910ce19a68f8a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572368 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#652222} device/bluetooth/bluez/bluetooth_adapter_bluez.cc | 32 ++++++------- device/bluetooth/bluez/bluetooth_adapter_bluez.h | 10 ++-- device/bluetooth/bluez/bluetooth_pairing_bluez.cc | 54 +++++++++------------- device/bluetooth/bluez/bluetooth_pairing_bluez.h | 18 ++++---- .../dbus/bluetooth_agent_service_provider.cc | 20 ++++---- .../dbus/bluetooth_agent_service_provider.h | 17 +++---- .../dbus/fake_bluetooth_agent_service_provider.cc | 20 ++++---- .../dbus/fake_bluetooth_agent_service_provider.h | 18 ++++---- 8 files changed, 90 insertions(+), 99 deletions(-) commit cd9b5ac2938ba52755eb35c09dfaccbca1384492 Author: Alexander Timin <altimin@chromium.org> Date: Thu Apr 18 17:58:51 2019 +0000 [scheduler] Rename DisableBackForwardCache scheduling policy. Rename DisableBackForwardCache to RecordMetricsForBackForwardCache as we don't yet have a back-forward cache to opt out from. R=kinuko@chromium.org CC=​haraken@chromium.org BUG=933147 Change-Id: Ia189926bcf24790cb5c055fce48d4d2b91362fc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571697 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#652221} .../blink/renderer/core/dom/events/event_target.cc | 2 +- .../renderer/core/html/html_plugin_element.cc | 2 +- .../blink/renderer/core/html/plugin_document.cc | 2 +- .../blink/renderer/core/loader/document_loader.cc | 4 +- .../scheduler/scheduler_affecting_features_test.cc | 107 ++++++++------- .../peerconnection/adapters/ice_transport_proxy.cc | 2 +- .../modules/peerconnection/rtc_peer_connection.cc | 2 +- .../modules/websockets/websocket_channel_impl.cc | 2 +- .../platform/loader/fetch/resource_loader.cc | 4 +- .../scheduler/main_thread/frame_scheduler_impl.cc | 15 ++- .../scheduler/main_thread/frame_scheduler_impl.h | 10 +- .../main_thread/frame_scheduler_impl_unittest.cc | 149 +++++++++++---------- .../platform/scheduler/public/frame_scheduler.h | 6 +- .../platform/scheduler/public/scheduling_policy.h | 7 +- .../test/renderer_scheduler_test_support.cc | 2 +- 15 files changed, 163 insertions(+), 153 deletions(-) commit 7136c9866ee6bf1def1a992e57bc3f95507776fb Author: Xi Han <hanxi@google.com> Date: Thu Apr 18 17:55:22 2019 +0000 Create ProfileKey early We remove the parameter of PrefService* from ProfileKey's constructor. This is because some KeyedService are created using ProfileKey* before the PrefService is created in the Profile. For example, SuperviseUserSettingService and InProcessPrefServiceFactoryFactory. Bug: 937469 Change-Id: I45c4b849e229a34ec6f465e428a7a514e9f77118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568793 Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by: Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#652220} chrome/browser/profiles/off_the_record_profile_impl.cc | 8 +++++--- chrome/browser/profiles/profile_impl.cc | 3 ++- chrome/browser/profiles/profile_key.cc | 18 ++++++++++++++---- chrome/browser/profiles/profile_key.h | 4 ++-- chrome/test/base/testing_profile.cc | 15 ++++++++------- 5 files changed, 31 insertions(+), 17 deletions(-) commit d3659a52a8b325c046bc8d64c57d191dbb959e9b Author: Kurt Horimoto <kkhorimoto@chromium.org> Date: Thu Apr 18 17:53:52 2019 +0000 [iOS] Mark flaky ios_web_inttests as FLAKY_. Affected tests: - ErrorPageTest.BackForwardErrorPage - WebStateObserverTest.FailedLoad TBR: eugenebut@chromium.org Bug: 954231, 954232 Change-Id: I1783732aa37b3ce7db3f9878a5342d1a5bc12271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574018 Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#652219} ios/web/web_state/error_page_inttest.mm | 2 +- ios/web/web_state/web_state_observer_inttest.mm | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit e858b4744cdf49e5f7f7b868752660bec9988fa3 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Thu Apr 18 17:53:04 2019 +0000 Roll src-internal fd816f4d5722..c8ee49fcfce8 (8 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fd816f4d5722..c8ee49fcfce8 Created with: gclient setdep -r src-internal@c8ee49fcfce8 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=fdoray@chromium.org,bsep@chromium.org,keishi@chromium.org,chanli@chromium.org Change-Id: I3abd802d306f433a8d3d8c2d44694e99a6826f3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573669 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652218} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 9fe5505431fbd51844f13e7f0ed3087b4dd08ca9 Author: wutao <wutao@chromium.org> Date: Thu Apr 18 17:52:02 2019 +0000 ksv: Move ChromeVox focus with Tab This patch fixes a bug that ChromeVox orange focus highlight does not follow the "Tab" to the shortcut list. Bug: 953874 Test: manual Change-Id: I649560519a7bc8bc53eabd67bc41508ef1207c27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572867 Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#652217} ash/components/shortcut_viewer/views/keyboard_shortcut_view.cc | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) commit 0ace6ce8a28601fdc46c09cd250612e02beab0e2 Author: Fabrice de Gans-Riberi <fdegans@chromium.org> Date: Thu Apr 18 17:51:54 2019 +0000 [fuchsia] Update local-sdk script for fx set command. Change-Id: I1ca0b592a9620d85e204302b6f0ce53cf915b588 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573095 Auto-Submit: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#652216} tools/fuchsia/local-sdk.py | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) commit f4ba6c5b332c4d893fd07801b21053fa68c0b949 Author: Alex Clarke <alexclarke@chromium.org> Date: Thu Apr 18 17:50:52 2019 +0000 java: Add a choreographer frame task trait This is useful if you need to guarantee something like a layout pass has occurred before your task runs. Tasks posted with TaskTraits.CHOREOGRAPHER_FRAME will run next time there's a vsync and after all other ready tasks on the thread have run. I put the trait under base because from what I understand there is some ui/ code that needs it but ui/ can't depend on content/. Bug: 863341 Change-Id: Ibcb7a843866c2b2c4f4394ebd18c8ef7aa33b5bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549114 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by: Karolina Soltys <ksolt@chromium.org> Cr-Commit-Position: refs/heads/master@{#652215} base/BUILD.gn | 1 + .../base/task/ChoreographerTaskRunner.java | 63 ++++++++++++++++++++++ .../chromium/base/task/DefaultTaskExecutor.java | 22 +++++++- .../src/org/chromium/base/task/TaskTraits.java | 12 +++++ .../src/org/chromium/base/task/PostTaskTest.java | 31 +++++++++++ .../browser/scheduler/UiThreadSchedulerTest.java | 47 ++++++++++++++++ 6 files changed, 174 insertions(+), 2 deletions(-) commit 952b66d46e9dbc6df43272abc6a988654b37b382 Author: Stepan Khapugin <stkhapugin@chromium.org> Date: Thu Apr 18 17:50:40 2019 +0000 [iOS] Adds plumbing for DSE favicon and answer icons in the omnibox. Plumbs the url of the favicon and the answer type from OPVI to OmniboxMediator. Bug: 945313, 945324 Change-Id: I759c5d83d7a677bb6be9e5aedf3ddd8666989fec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572354 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#652214} ios/chrome/browser/ui/omnibox/omnibox_left_image_consumer.h | 12 ++++++++++-- ios/chrome/browser/ui/omnibox/omnibox_mediator.mm | 8 ++++++-- ios/chrome/browser/ui/omnibox/omnibox_view_ios.h | 4 +++- ios/chrome/browser/ui/omnibox/omnibox_view_ios.mm | 8 ++++++-- .../browser/ui/omnibox/popup/omnibox_popup_view_ios.mm | 11 ++++++++++- .../omnibox/popup/omnibox_popup_view_suggestions_delegate.h | 10 +++++++++- 6 files changed, 44 insertions(+), 9 deletions(-) commit 9e885a06fa20c5cda3775796e66e967d5f0dbbba Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Apr 18 17:49:37 2019 +0000 Roll src/third_party/catapult 4e967e7e447d..f76561176b6c (1 commits) https://chromium.googlesource.com/catapult.git/+log/4e967e7e447d..f76561176b6c git log 4e967e7e447d..f76561176b6c --date=short --no-merges --format='%ad %ae %s' 2019-04-18 rmhasan@google.com [Typ] Make tags in test expectations files case insensitive Created with: gclient setdep -r src/third_party/catapult@f76561176b6c The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:698902 TBR=oysteine@chromium.org Change-Id: If3d7983bdbcfd7d8508709c2a2ff9be4880a0191 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573667 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652213} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 1e6642b0358084c7d9069dca4fd03cad16641700 Author: Orin Jaworski <orinj@chromium.org> Date: Thu Apr 18 17:49:33 2019 +0000 [omnibox] Add and load Pedal concept data for de, en, fr, ja, zh-CN Previously, Pedal concept data was a singular resource in English but this CL restructures the resources to load localized data from a pak depending on selected language. Data for the first four non-English languages localized by the translation team is included. Bug: 893183 Change-Id: I0e88d23de65038720a4f3543613ff8bd83dc5444 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572526 Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#652212} components/components_strings.grd | 4 + .../omnibox/browser/omnibox_pedal_concepts.h | 2 +- .../omnibox_pedal_implementations_unittest.cc | 106 +++++++++++++++++++-- .../omnibox/browser/omnibox_pedal_provider.cc | 8 +- .../omnibox/resources/omnibox_pedal_concepts.json | 1 - .../resources/omnibox_pedal_concepts_de.json | 1 + .../resources/omnibox_pedal_concepts_en.json | 1 + .../resources/omnibox_pedal_concepts_fr.json | 1 + .../resources/omnibox_pedal_concepts_ja.json | 1 + .../resources/omnibox_pedal_concepts_zh-CN.json | 1 + .../omnibox/resources/omnibox_resources.grdp | 23 +++++ components/resources/OWNERS | 1 - components/resources/components_resources.grd | 1 - components/resources/omnibox_resources.grdp | 4 - tools/gritsettings/resource_ids | 3 +- 15 files changed, 138 insertions(+), 20 deletions(-) commit cef68da1c2a0061d6ca6c7f929f68c1abb1bd570 Author: Yulun Wu <yulunwu@chromium.org> Date: Thu Apr 18 17:46:12 2019 +0000 Add tests to check fingerprint state, UI, and ability to login before/after policy timeout. Bug: 949707 Change-Id: I7767a632c895286858ebde9afe8473dca3ce0a5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566723 Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Toni Baržić <tbarzic@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#652211} ash/login/login_screen_test_api.cc | 8 + ash/login/login_screen_test_api.h | 1 + .../interfaces/login_screen_test_api.test-mojom | 3 + .../login/lock/fingerprint_unlock_browsertest.cc | 238 +++++++++++++++++++++ .../chromeos/login/lock/screen_locker_tester.cc | 9 + .../chromeos/login/lock/screen_locker_tester.h | 3 + .../login/quick_unlock/quick_unlock_storage.cc | 11 +- .../login/quick_unlock/quick_unlock_storage.h | 7 +- .../chromeos/login/test/login_screen_tester.cc | 7 + .../chromeos/login/test/login_screen_tester.h | 1 + chrome/test/BUILD.gn | 1 + 11 files changed, 285 insertions(+), 4 deletions(-) commit 599e84af9ec8234d5d117754d561a4f50942a655 Author: Seth Hampson <shampson@chromium.org> Date: Thu Apr 18 17:42:29 2019 +0000 QuicStreamHost copy updated to a move. Fixing a small bug - the WriteData function should use a move instead of a copy for the data. Bug: 874296 Change-Id: I8b572a9d492d6fcea0e238b49bb72b0ed9273baf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573805 Reviewed-by: Seth Hampson <shampson@chromium.org> Reviewed-by: Steve Anton <steveanton@chromium.org> Auto-Submit: Seth Hampson <shampson@chromium.org> Commit-Queue: Seth Hampson <shampson@chromium.org> Cr-Commit-Position: refs/heads/master@{#652210} .../blink/renderer/modules/peerconnection/adapters/quic_stream_host.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 77173954bfad4618ae7ea12dd84aec03c2b171f4 Author: Matt Menke <mmenke@chromium.org> Date: Thu Apr 18 17:42:14 2019 +0000 SpdySessionPool: Don't give non-WebSocket sessions to WebSocket requests When sessions are returned to SpdySessionRequests, there was previously no filter preventing sessions that don't support WebSockets to requests that only wanted WebSocket-supporting sessions. Bug: 912727 Change-Id: I20ade246dc5a8a4e7581c49801747723b8d36a87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572705 Reviewed-by: Bence Béky <bnc@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#652209} net/spdy/spdy_network_transaction_unittest.cc | 123 ++++++++++++++++++++++++++ net/spdy/spdy_session_pool.cc | 24 +++-- net/spdy/spdy_session_pool.h | 3 + 3 files changed, 145 insertions(+), 5 deletions(-) commit fef7399c060df4ae25879ac8fb05070f1b0ccf95 Author: Ben Pastene <bpastene@chromium.org> Date: Thu Apr 18 17:41:26 2019 +0000 chromeos: Restructure test runner args a bit. This makes the "test_type" arg the very first arg. Previously, anything that came before it couldn't be passed in from the generated test script. eg: running `./$out/bin/run_gtest --device $DUT_IP` would have no effect since "--device" came before the "test_type" arg (which itself was set in the generated script). Bug: 866062 Change-Id: I7712f11b23f78f28e9831fe506b9467db8c217e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572959 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#652208} build/chromeos/create_test_runner_script.py | 15 +++--- build/chromeos/test_runner.py | 81 +++++++++++++---------------- 2 files changed, 45 insertions(+), 51 deletions(-) commit 4f4c5ff15edd97d29d55ea6fa195cac11a9b4a85 Author: Torne (Richard Coles) <torne@google.com> Date: Thu Apr 18 17:30:31 2019 +0000 Set Trichrome min SDK properly Make the minimum SDK version for all components of Trichrome be Q, if we're building with the Q SDK. SDK28 builds of Trichrome are only for temporary testing and can be left alone until they're removed. Bug: 952383 Change-Id: I8e9bac555456868ccf414a56f499d03fd2d1ef34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566372 Auto-Submit: Richard Coles <torne@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#652207} chrome/android/trichrome.gni | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit 8d0466172c9ee2451236808661adc8274bbaeb09 Author: Nikita Podguzov <nikitapodguzov@chromium.org> Date: Thu Apr 18 17:26:40 2019 +0000 Print Preview: Change the behavior for empty PIN value. * Allow to save empty PIN in sticky settings. * Show the error if the PIN field is empty. Bug: 848942 Change-Id: If7c4f3af6b9d6a5ade041c06d4732903ce780ff9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570011 Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Cr-Commit-Position: refs/heads/master@{#652206} .../browser/resources/print_preview/new/BUILD.gn | 1 + .../resources/print_preview/new/pin_settings.html | 3 +- .../resources/print_preview/new/pin_settings.js | 41 +++++++++++++++++++--- .../print_preview/new/print_preview_sidebar.html | 2 +- .../data/webui/print_preview/pin_settings_test.js | 1 + 5 files changed, 42 insertions(+), 6 deletions(-) commit 2c03a3107fab428939da22c5d0ae5dccc0a4ca0b Author: Mohamed Amir Yosef <mamir@chromium.org> Date: Thu Apr 18 17:25:55 2019 +0000 [Sync::USS] Implement NigoriModelTypeProcessor::NudgeForCommitIfNeeded Bug: 922900 Change-Id: Idde575a3f4ba559811ab98373f6fb3e30bef0ea7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572406 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#652205} .../sync/nigori/nigori_model_type_processor.cc | 24 +++++++++-- .../sync/nigori/nigori_model_type_processor.h | 3 ++ .../nigori/nigori_model_type_processor_unittest.cc | 48 +++++++++++++++++++++- 3 files changed, 70 insertions(+), 5 deletions(-) commit f3dc22ca3b0542b75addf34569fae412c5215302 Author: Yeol <peary2@gmail.com> Date: Thu Apr 18 17:25:32 2019 +0000 Changed ContentBrowserClient::CreateQuotaPermissionContext() to return scoped_refptr. QuotaPermissionContext is a base::RefCountedThreadSafe class. The method should return scoped_refptr instead of the raw pointer. Bug: 951154 Change-Id: Ida5c64b6b5ce9eea6d3b42b49c0ab25b0263778e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569376 Reviewed-by: Luke Halliwell <halliwell@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Commit-Queue: Yeol Park <peary2@gmail.com> Cr-Commit-Position: refs/heads/master@{#652204} android_webview/browser/aw_content_browser_client.cc | 2 +- android_webview/browser/aw_content_browser_client.h | 3 ++- chrome/browser/chrome_content_browser_client.cc | 2 +- chrome/browser/chrome_content_browser_client.h | 4 ++-- chromecast/browser/cast_content_browser_client.cc | 2 +- chromecast/browser/cast_content_browser_client.h | 3 ++- content/public/browser/content_browser_client.cc | 3 ++- content/public/browser/content_browser_client.h | 3 ++- content/shell/browser/shell_content_browser_client.cc | 2 +- content/shell/browser/shell_content_browser_client.h | 3 ++- headless/lib/browser/headless_content_browser_client.cc | 2 +- headless/lib/browser/headless_content_browser_client.h | 3 ++- 12 files changed, 19 insertions(+), 13 deletions(-) commit de9772898e29a2ffb29be2e702b7b215b13415c1 Author: Abhishek Arya <inferno@chromium.org> Date: Thu Apr 18 17:24:18 2019 +0000 Revert "[Signin][Android] Add Java side of ConsistencyCookieManager" This reverts commit e646c056f825e05d7cc80984009a750fa0143dc7. Reason for revert: Broke UBSan vptr and Boris is OOO till early May. Original change's description: > [Signin][Android] Add Java side of ConsistencyCookieManager > > Adds ConsistencyCookieManager Java class that listens to > AccountManagerFacade.isUpdatePending and exposes it to the C++ code. > > Bug: 949562 > Change-Id: Ifc375bed3d0d878d89d106807f44f4e7807db999 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565880 > Commit-Queue: David Roger <droger@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#652073} TBR=droger@chromium.org,bsazonov@chromium.org Change-Id: Id672685a05ecea8dcd2bee210369faa9a207c35d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 949562 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573860 Reviewed-by: Abhishek Arya <inferno@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#652203} .../browser/signin/account_reconcilor_factory.cc | 22 +----- chrome/browser/signin/account_reconcilor_factory.h | 6 -- components/signin/core/browser/BUILD.gn | 17 +---- .../signin/core/browser/account_reconcilor.cc | 15 ++-- .../signin/core/browser/account_reconcilor.h | 13 ++-- components/signin/core/browser/android/BUILD.gn | 5 -- .../signin/ConsistencyCookieManager.java | 73 ------------------ .../browser/consistency_cookie_manager_android.cc | 86 +++++++++++++++------- .../browser/consistency_cookie_manager_android.h | 35 +++++---- ...consistency_cookie_manager_android_unittest.cc} | 26 ++----- .../browser/consistency_cookie_manager_base.cc | 80 -------------------- .../core/browser/consistency_cookie_manager_base.h | 61 --------------- 12 files changed, 110 insertions(+), 329 deletions(-) commit b9d12b3e0337d5018a92c6897548f55b5ade620d Author: Austin Eng <enga@chromium.org> Date: Thu Apr 18 17:23:29 2019 +0000 WebGPU: Always pick the discrete GPU if it is available This will be replaced when we implement the GPUAdapterOptions to select high/low power. Bug: chromium:852089 Change-Id: If698c1edd3c1cb8f6d10377133f276351d05dc2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572533 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#652202} gpu/command_buffer/service/webgpu_decoder_impl.cc | 32 ++++++++++++++++++++++- 1 file changed, 31 insertions(+), 1 deletion(-) commit 4ed9dea9bfb69e25e45c0e901c1c70e6fe035808 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Thu Apr 18 17:20:29 2019 +0000 flags: assign wallet-service-use-sandbox This flag never expires since it is used by TE to validate Payments features. Bug: None Change-Id: If0bfbfce132ef1f979c277c3e9ed6987598ba53d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570921 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#652201} chrome/browser/flag-metadata.json | 6 ++++-- chrome/browser/flag-never-expire-list.json | 3 ++- 2 files changed, 6 insertions(+), 3 deletions(-) Updated tag 'tree_truth' (was b099464e0edd)