Back to build
Raw log | Switch to full mode | Login

/b/s/w/ir/cache/builder/src/build/tree_truth.sh /b/s/w/ir/cache/builder/src src in dir /b/s/w/ir/k: allow_subannotations: False cmd: ['/b/s/w/ir/cache/builder/src/build/tree_truth.sh', '/b/s/w/ir/cache/builder/src', 'src'] env: {'CHROME_HEADLESS': '1'} env_prefixes: {} env_suffixes: {} infra_step: False name_tokens: ('tree truth steps',) ok_ret: frozenset([0]) trigger_specs: () full environment: BOTO_CONFIG: /b/s/w/ir/tmp/gsutil_task/.boto BUILDBUCKET_EXPERIMENTAL: FALSE CHROME_HEADLESS: 1 CIPD_CACHE_DIR: /b/s/cipd_cache/cache CIPD_PROTOCOL: v2 DEVSHELL_CLIENT_PORT: 37132 DOCKER_CONFIG: /b/s/w/ir/tmp/docker_cfg_task DOCKER_TMPDIR: /b/s/w/ir/tmp/docker_tmp_task GIT_CONFIG_NOSYSTEM: 1 GIT_TERMINAL_PROMPT: 0 HOME: /home/chrome-bot INFRA_GIT_WRAPPER_HOME: /b/s/w/ir/tmp/git_home_task LOGDOG_COORDINATOR_HOST: logs.chromium.org LOGDOG_STREAM_PREFIX: buildbucket/cr-buildbucket.appspot.com/8915806868721499232 LOGDOG_STREAM_PROJECT: chromium LOGDOG_STREAM_SERVER_PATH: unix:/b/s/w/ir/tmp/ld.sock LOGNAME: chrome-bot LUCI_CONTEXT: /b/s/w/it9AT9v4/luci_context.956597607 MAC_CHROMIUM_TMPDIR: /b/s/w/ir/tmp/t MAIL: /var/mail/chrome-bot NO_GCE_CHECK: False PATH: /b/s/w/ir/cipd_bin_packages:/b/s/w/ir/cipd_bin_packages/bin:/b/s/cipd_cache/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin PWD: /b/s/w/ir/k PYTHONIOENCODING: UTF-8 PYTHONUNBUFFERED: 1 SHELL: /bin/bash SHLVL: 1 SUDO_COMMAND: /usr/bin/python /b/s/swarming_bot.zip start_bot SUDO_GID: 0 SUDO_UID: 0 SUDO_USER: root SWARMING_BOT_ID: android-fyi-release-pixel2-0-vbyx SWARMING_EXTERNAL_BOT_SETUP: 1 SWARMING_HEADLESS: 1 SWARMING_SERVER: https://chromium-swarm.appspot.com SWARMING_TASK_ID: 444b0e43fe7f9611 TEMP: /b/s/w/ir/tmp/t TEMPDIR: /b/s/w/ir/tmp/t TERM: linux TMP: /b/s/w/ir/tmp/t TMPDIR: /b/s/w/ir/tmp/t USER: chrome-bot USERNAME: chrome-bot VPYTHON_VIRTUALENV_ROOT: /b/s/w/ir/cache/vpython _: /b/s/w/ir/cipd_bin_packages/vpython !@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: 1a2ee7991a0a09fbd98fd046c120ab4bffffcab8 Activate the use of is_unexpected field in the output JSON file. kyle Ju, Thu Apr 18 20:53:11 2019 +0000 040d96ebe41d853258003e2fb1850ccfef2178e7 Turn on a WPR flag to stablize captured sites tests. Yiming Zhou, Thu Apr 18 20:51:43 2019 +0000 f57a5da590522e0f5c4702e0133be2924c9de573 [Fuchsia] Remove deprecated bootserver flag --efi. Kevin Marshall, Thu Apr 18 20:49:33 2019 +0000 da222027d2242f59c500e10e194bb2d089aa0b7c Print Preview: Increase sidebar width rbpotter, Thu Apr 18 20:48:55 2019 +0000 d6d48af9644128f3549864632c51a25ebd1569cb vr/android: Disable SurfaceControl when in VR mode. Khushal, Thu Apr 18 20:45:46 2019 +0000 c0726120e98ddb42195c50620332fd4dff1b7967 Roll src-internal c8ee49fcfce8..fa3c64638fba (3 commits) chromium-internal-autoroll, Thu Apr 18 20:43:53 2019 +0000 de1c106f8deb9abdf36dd79ce45eb35f3276391a add alph as an OWNER to all heap profiling code. Erik Chen, Thu Apr 18 20:40:52 2019 +0000 709c0b93487486e04e1176e8cbe819ca053f544e [heap profiler] Add test for NATIVE_WITH_THREAD_NAMES mode Alexei Filippov, Thu Apr 18 20:36:41 2019 +0000 f5994a0255254e0ef6ae8fd704f878c9c465e148 cros: Move some *View classes into *Handler files Jacob Dufault, Thu Apr 18 20:35:25 2019 +0000 6b2059feb9caa5bf27ebf0cce482fb462439c690 Update comments in //extensions about BrowserContextKeyed_Base_Factory. Henrique Nakashima, Thu Apr 18 20:32:49 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit 1a2ee7991a0a09fbd98fd046c120ab4bffffcab8 Author: kyle Ju <kyleju@chromium.org> Date: Thu Apr 18 20:53:11 2019 +0000 Activate the use of is_unexpected field in the output JSON file. Check in bits of code from the pending two-way sync CL. It allows me to monitor the flakiness of webdriver_test_suit on Linux Tests (dbg)(1) while the other CL is being reviewed. The changes are taken from https://chromium-review.googlesource.com/c/chromium/src/+/1484616/36 Sample JSON output: https://pastebin.com/CfuVTuP8 The is_unexpected fields for all of the three tests are false because their expectations exist in the WebDriverExpectations. Bug: 934919 Change-Id: If068f2318f2f2cbe6b866f96f14cb97f941a4df0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574360 Reviewed-by: John Chen <johnchen@chromium.org> Reviewed-by: Robert Ma <robertma@chromium.org> Commit-Queue: Kyle Ju <kyleju@chromium.org> Cr-Commit-Position: refs/heads/master@{#652292} .../test/chromedriver/test/run_webdriver_tests.py | 40 +++-- .../blink/tools/blinkpy/web_tests/port/base.py | 5 + .../tools/blinkpy/web_tests/port/base_unittest.py | 9 ++ third_party/blink/web_tests/WebDriverExpectations | 175 ++++++++++++++++++++- 4 files changed, 215 insertions(+), 14 deletions(-) commit 040d96ebe41d853258003e2fb1850ccfef2178e7 Author: Yiming Zhou <uwyiming@google.com> Date: Thu Apr 18 20:51:43 2019 +0000 Turn on a WPR flag to stablize captured sites tests. In https://chromium.googlesource.com/catapult/+/734e7ea0cbf9e0965596350ea51e5b4c8fc623f0, I introduced a change to Web page Replay Go (WPR Go) to prefer previously unmatched responses. This change fixed a number of issues with capturing checkout workflows on captured sites. The change hides the fix behind a feature flag for compatibility reasons. This change enables the fix by turning on the feature flag in Captured Sites tests. Bug: 850756 Change-Id: I0331b3b5cfe8b0ddde84211bd0b320ef65faa8fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574358 Auto-Submit: Yiming Zhou <uwyiming@google.com> Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#652291} chrome/browser/autofill/captured_sites_test_utils.cc | 1 + 1 file changed, 1 insertion(+) commit f57a5da590522e0f5c4702e0133be2924c9de573 Author: Kevin Marshall <kmarshall@chromium.org> Date: Thu Apr 18 20:49:33 2019 +0000 [Fuchsia] Remove deprecated bootserver flag --efi. "bootserver" fails to run because we are passing it an arg that is now deprecated, "--efi". EFI partition management is now managed by default by "bootserver". Bug: 954277 Change-Id: Id71932b9969a71ef27d21362c010c299659dd459 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574224 Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#652290} build/fuchsia/device_target.py | 6 ------ 1 file changed, 6 deletions(-) commit da222027d2242f59c500e10e194bb2d089aa0b7c Author: rbpotter <rbpotter@chromium.org> Date: Thu Apr 18 20:48:55 2019 +0000 Print Preview: Increase sidebar width Increase the width of the Print Preview sidebar by 25px, providing an extra 25px for titles. Bug: 925960, 941369 Change-Id: I59f216523709547312348d33104aa5e467a3f585 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574225 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#652289} chrome/browser/resources/print_preview/new/app.html | 2 +- chrome/browser/resources/print_preview/new/settings_section.html | 2 +- chrome/browser/resources/print_preview/print_preview_new.html | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) commit d6d48af9644128f3549864632c51a25ebd1569cb Author: Khushal <khushalsagar@chromium.org> Date: Thu Apr 18 20:45:46 2019 +0000 vr/android: Disable SurfaceControl when in VR mode. The android surface used by the display compositor when in VR mode is backed by SurfaceTexture, which is incompatible for use with SurfaceControl. Disable it when in VR mode. Fundamentally, SurfaceControl can only be used when the consumer end of the display's frame updates is SurfaceFlinger. With SurfaceTexture, the consumer end can be any arbitrary process which created the SurfaceTexture. TBR=tsepez@chromium.org R=piman@chromium.org Bug: 953953 Change-Id: Ie132d143aeffcf1bb022f6c691a0738515b19a1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573164 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Reviewed-by: Eric Karl <ericrk@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#652288} .../chrome/browser/compositor/CompositorView.java | 8 +++++--- .../browser/android/compositor/compositor_view.cc | 9 +++++---- .../browser/android/compositor/compositor_view.h | 1 + .../android/view/content_view_render_view.cc | 4 ++-- components/viz/common/display/renderer_settings.h | 1 + .../display_embedder/gl_output_surface_android.cc | 12 +++++++---- .../display_embedder/gl_output_surface_android.h | 3 ++- .../display_embedder/gpu_display_provider.cc | 10 +++++++++- .../viz_process_context_provider.cc | 23 ++++++++-------------- .../renderer_host/compositor_impl_android.cc | 11 ++++++++--- .../renderer_host/compositor_impl_android.h | 3 ++- content/public/browser/android/compositor.h | 2 +- .../common/context_creation_attribs.h | 1 + gpu/ipc/common/gpu_command_buffer_traits_multi.h | 1 + gpu/ipc/in_process_command_buffer.cc | 9 +++++++-- .../interfaces/compositing/renderer_settings.mojom | 3 +++ .../compositing/renderer_settings_struct_traits.cc | 2 ++ .../compositing/renderer_settings_struct_traits.h | 4 ++++ 18 files changed, 70 insertions(+), 37 deletions(-) commit c0726120e98ddb42195c50620332fd4dff1b7967 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Thu Apr 18 20:43:53 2019 +0000 Roll src-internal c8ee49fcfce8..fa3c64638fba (3 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c8ee49fcfce8..fa3c64638fba Created with: gclient setdep -r src-internal@fa3c64638fba The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=fdoray@chromium.org,bsep@chromium.org,keishi@chromium.org,chanli@chromium.org Change-Id: I753bf73354a64acd7f4f20ae80831977aaa46ad6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574039 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652287} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit de1c106f8deb9abdf36dd79ce45eb35f3276391a Author: Erik Chen <erikchen@chromium.org> Date: Thu Apr 18 20:40:52 2019 +0000 add alph as an OWNER to all heap profiling code. Change-Id: Ie4ef73b77d2ffc02c1cd39026dc24ccd940f4a10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574220 Auto-Submit: Erik Chen <erikchen@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#652286} chrome/browser/profiling_host/OWNERS | 1 + components/heap_profiling/OWNERS | 1 + components/services/heap_profiling/OWNERS | 1 + 3 files changed, 3 insertions(+) commit 709c0b93487486e04e1176e8cbe819ca053f544e Author: Alexei Filippov <alph@chromium.org> Date: Thu Apr 18 20:36:41 2019 +0000 [heap profiler] Add test for NATIVE_WITH_THREAD_NAMES mode Change-Id: I2ffd5db7f3ea2ab30be495e496663b98ffa942fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573007 Reviewed-by: Erik Chen <erikchen@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#652285} chrome/browser/profiling_host/memlog_browsertest.cc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) commit f5994a0255254e0ef6ae8fd704f878c9c465e148 Author: Jacob Dufault <jdufault@google.com> Date: Thu Apr 18 20:35:25 2019 +0000 cros: Move some *View classes into *Handler files Also eliminate AppLaunchSplashScreenView::Delegate Bug: 928555 Change-Id: I056c5fa6efb94bb59c45cbaf8e4344588dd97230 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564935 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#652284} chrome/browser/chromeos/BUILD.gn | 3 - .../browser/chromeos/login/app_launch_controller.h | 27 +++++--- chrome/browser/chromeos/login/kiosk_browsertest.cc | 3 +- .../login/screens/app_downloading_screen.cc | 2 + .../login/screens/app_downloading_screen.h | 3 +- .../login/screens/app_downloading_screen_view.h | 34 ---------- .../login/screens/app_launch_splash_screen_view.h | 74 ---------------------- .../chromeos/login/screens/mock_welcome_screen.h | 2 +- .../chromeos/login/screens/welcome_screen.cc | 2 +- .../browser/chromeos/login/screens/welcome_view.h | 48 -------------- chrome/browser/chromeos/login/wizard_controller.cc | 2 +- .../login/app_downloading_screen_handler.h | 17 ++++- .../login/app_launch_splash_screen_handler.cc | 34 +++++----- .../login/app_launch_splash_screen_handler.h | 44 ++++++++++++- .../webui/chromeos/login/welcome_screen_handler.h | 37 +++++++++-- 15 files changed, 132 insertions(+), 200 deletions(-) commit 6b2059feb9caa5bf27ebf0cce482fb462439c690 Author: Henrique Nakashima <hnakashima@chromium.org> Date: Thu Apr 18 20:32:49 2019 +0000 Update comments in //extensions about BrowserContextKeyed_Base_Factory. These comments that say "BrowserContextKeyed_Base_Factory" are outdated and should refer to "BrowserContextKeyed_Service_Factory" instead. Bug: 937770 Change-Id: Ib851fcf251c064a59bdb79d5cf718712654a602c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574422 Reviewed-by: Ken Rockot <rockot@google.com> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#652283} .../api/display_source/display_source_event_router_factory.h | 2 +- extensions/browser/api/idle/idle_manager_factory.h | 2 +- .../api/networking_config/networking_config_service_factory.h | 2 +- .../networking_private/networking_private_event_router_factory.h | 2 +- extensions/browser/browser_context_keyed_api_factory.h | 8 ++++---- 5 files changed, 8 insertions(+), 8 deletions(-) commit deea48bcf4285d5d56d931bd11e94ce788428d5f Author: Mitsuru Oshima <oshima@chromium.org> Date: Thu Apr 18 20:32:05 2019 +0000 Fix OverviewWindowDragTest.DragToClose * The test should observe the active window (that will be dragged) instead of all. * PresentationTimeRecorder used to discard the presentation feedback that can happen after it is deleted. This CL introduces the internal state that can outlive until the feedback is recorded. * I also removed the max latency as it's very noisy and normal latency should be enough. (SplitView test does the same) Bug: 953355 Change-Id: I3b3e329ca4e866004763f18c55f71816d5a5d535 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572268 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#652282} ash/app_list/views/app_list_view.cc | 2 +- ash/app_list/views/apps_grid_view.cc | 14 +- ash/metrics/presentation_time_recorder_unittest.cc | 58 ++++- ash/public/cpp/presentation_time_recorder.cc | 246 ++++++++++++++++----- ash/public/cpp/presentation_time_recorder.h | 108 +++------ ash/wm/overview/overview_window_drag_controller.cc | 7 +- ash/wm/splitview/split_view_controller.cc | 27 +-- .../tablet_mode_window_drag_delegate.cc | 15 +- .../ash/overview_window_drag_interactive_uitest.cc | 3 +- 9 files changed, 302 insertions(+), 178 deletions(-) commit f30c07c091ea2a5fc52c10cb1d2019ae7678d8b0 Author: Shakti Sahu <shaktisahu@chromium.org> Date: Thu Apr 18 20:31:21 2019 +0000 Download Home : Fixed dark mode circular progress view colors Bug: 951200 Change-Id: Idad969c53e72fa3bc657883d580f6ed93fc5d484 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568041 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#652281} .../drawable/circular_progress_bar_background_small.xml | 7 +++++-- .../drawable/circular_progress_bar_determinate_small.xml | 10 +++++----- .../drawable/circular_progress_bar_indeterminate_small.xml | 6 +++--- chrome/android/java/res_download/values-v17/styles.xml | 4 ++-- ui/android/java/res/values/colors.xml | 6 ++++++ ui/android/java/res_night/values-night/colors.xml | 6 ++++++ 6 files changed, 27 insertions(+), 12 deletions(-) commit 551636190c33554b5c3ce7a1a8327336f655ffba Author: Shakti Sahu <shaktisahu@chromium.org> Date: Thu Apr 18 20:30:20 2019 +0000 Download home tab style refresh This CL tries to update the tab style used in download home to match with rest of chrome. Bug: 951819 Change-Id: Id9eab9209ae12e47fe5d5a4808a0f55c9c9cbaa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573094 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#652280} .../java/res/drawable/download_home_tabs_bg.xml | 18 -------- .../res_download/layout/download_home_tabs.xml | 51 ++++++++++++---------- 2 files changed, 27 insertions(+), 42 deletions(-) commit 3cad68fa83de357d25a1554f568b3482e21d519c Author: Bruce Dawson <brucedawson@chromium.org> Date: Thu Apr 18 20:30:17 2019 +0000 Remove cfi_linker from tests Windows 10's implementation of Control Flow Guard costs about 300 ms per process-create call with unit_tests.exe and other huge executables. Since process creation is serialized this adds about 300 s to the test run time of unit_tests.exe (10,000 tests divided by ten tests per process times 0.3 s), which means it takes significantly longer to run than it would otherwise. There have been reports that this causes unit_tests.exe to take 4-5x as long to run as when CFG is disabled. CFG is not needed for these tests, so disabling it is fine. unit_tests.exe, for example, has about 180,000 CFG functions, which is a lot, but it's not clear why it costs so much to set a bit for each function in the ~1.5 MB CFG bitmap. That is a problem for Microsoft to figure out and this is being discussed with them. The underlying issue and this change do not affect chrome.exe. See http://www.alex-ionescu.com/?p=246 for more information on CFG. Bug: 950923 Change-Id: I660ef68ca33141e54cfe895efaa3e7c11bc7118a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570694 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#652279} build/config/BUILD.gn | 4 ---- build/config/BUILDCONFIG.gn | 7 +++++++ testing/test.gni | 6 ++++++ 3 files changed, 13 insertions(+), 4 deletions(-) commit 0246317501a51d4a4441d9f85f94ea3b5f8220ec Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Apr 18 20:26:29 2019 +0000 Roll src/third_party/depot_tools ac9b0f378677..7b2943927c04 (1 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ac9b0f378677..7b2943927c04 git log ac9b0f378677..7b2943927c04 --date=short --no-merges --format='%ad %ae %s' 2019-04-18 ellyjones@chromium.org depot_tools: bail out if $PATH contains tildes Created with: gclient setdep -r src/third_party/depot_tools@7b2943927c04 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:952865 TBR=agable@chromium.org Change-Id: I1fb86cbfeef30d43fc4c6104f20c5dba844aaeb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574243 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652278} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 9220d4b37fc0bf0c27d386bfbe213f343f96eb36 Author: Ben Pastene <bpastene@chromium.org> Date: Thu Apr 18 20:23:44 2019 +0000 chromeos: Add a few more dirs to the list we don't copy over during tests. These shouldn't be used on the device during tests (only the host). Bug: 866062 Change-Id: I1d8ecf6cc9b416c34cc90bb55377bb8185556fa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572266 Auto-Submit: Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#652277} build/chromeos/test_runner.py | 8 ++++++++ 1 file changed, 8 insertions(+) commit b53d021fff34c192188eefca816c546b4f36fec3 Author: Becky Zhou <huayinz@chromium.org> Date: Thu Apr 18 20:23:27 2019 +0000 Add incognito badge and update background for location bar + Add an incognito badge on location bar on phone + Update incognito location bar background to black Bug: 942776 Change-Id: I13d64ac21a082e77a8df7b640f68f87ff9798072 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566754 Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#652276} chrome/android/chrome_test_java_sources.gni | 1 + .../drawable/ic_location_bar_incognito_badge.xml | 22 ++++++ chrome/android/java/res/layout/location_status.xml | 9 +++ .../res/layout/location_status_incognito_badge.xml | 14 ++++ chrome/android/java/res/values/colors.xml | 1 + chrome/android/java/res/values/dimens.xml | 2 + .../chrome/browser/ThemeColorProvider.java | 9 +++ .../browser/compositor/layouts/LayoutManager.java | 4 +- .../compositor/scene_layer/ToolbarSceneLayer.java | 6 +- .../chrome/browser/omnibox/LocationBarLayout.java | 2 + .../browser/omnibox/status/StatusMediator.java | 7 ++ .../browser/omnibox/status/StatusProperties.java | 6 +- .../chrome/browser/omnibox/status/StatusView.java | 42 ++++++++++ .../browser/omnibox/status/StatusViewBinder.java | 2 + .../omnibox/status/StatusViewCoordinator.java | 7 ++ .../toolbar/bottom/BottomToolbarCoordinator.java | 3 +- .../toolbar/bottom/BottomToolbarNewTabButton.java | 19 ++++- .../BrowsingModeBottomToolbarCoordinator.java | 6 +- .../browser/toolbar/bottom/SearchAccelerator.java | 42 ++++++++-- .../chrome/browser/toolbar/top/ToolbarPhone.java | 3 +- .../chrome/browser/toolbar/top/ToolbarTablet.java | 4 +- .../chromium/chrome/browser/util/ColorUtils.java | 13 +++- .../java/strings/android_chrome_strings.grd | 3 + .../IDS_ACCESSIBILITY_INCOGNITO_BADGE.png.sha1 | 1 + .../browser/omnibox/status/StatusViewTest.java | 90 ++++++++++++++++++++++ 25 files changed, 296 insertions(+), 22 deletions(-) commit f93d43e5f821da4bbc8faee754ed6ab74d73c9c2 Author: Lily Chen <chlily@chromium.org> Date: Thu Apr 18 20:22:02 2019 +0000 Decide cookie SameSite inclusion based on a (default disabled) feature This CL adds a base::Feature that controls the effective SameSite behavior of cookies with SameSite() equal to CookieSameSite::UNSPECIFIED. The effective SameSite behavior is the same as for CookieSameSite::NO_RESTRICTION if the feature is disabled (which is the current default), or the same as for CookieSameSite::LAX_MODE if the feature is enabled (which currently is only in tests). Currently, the only way to get a cookie with SameSite set to UNSPECIFIED is to construct it directly, i.e. parsing a cookie line without SameSite specified still sets SameSite to NO_RESTRICTION under all circumstances. Right now, there should not be any cookies in the CookieStore that have SameSite set to UNSPECIFIED. This will change in the future. The net::CookieInclusionStatus enum (as well as the mojom equivalent) is also extended with some new values, to be used when cookie exclusion results from an unspecified SameSite attribute that is interpreted as Lax, and in two other circumstances which are not yet implemented. Bug: 953306 Change-Id: I1dea6c04e58b52804fe03fabe920331afb30e3da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570748 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by: Maks Orlovich <morlovich@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#652275} chrome/browser/browsing_data/cookies_tree_model.cc | 4 +- net/base/features.cc | 3 + net/base/features.h | 7 ++ net/cookies/canonical_cookie.cc | 29 +++++- net/cookies/canonical_cookie.h | 22 ++++ net/cookies/canonical_cookie_unittest.cc | 116 ++++++++++++++++++++- net/cookies/cookie_monster.cc | 7 +- .../public/cpp/cookie_manager_mojom_traits.cc | 23 ++++ .../cpp/cookie_manager_mojom_traits_unittest.cc | 5 + services/network/public/mojom/cookie_manager.mojom | 3 + 10 files changed, 211 insertions(+), 8 deletions(-) commit 25303546cd876ff9dcd0f28136ed2ed94e77c782 Author: Chan <chanli@chromium.org> Date: Thu Apr 18 20:17:22 2019 +0000 Mark http/tests/security/svg-image-with-cached-remote-image.html as flaky TBR=fdoray@chromium.org Bug: 953994 Change-Id: Iec8853179e5d5e3ccd73c2f7a7beaf792f9b4b36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574148 Commit-Queue: Chan Li <chanli@chromium.org> Reviewed-by: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#652274} third_party/blink/web_tests/TestExpectations | 2 ++ 1 file changed, 2 insertions(+) commit 9da94a350ef0ae5a52754ed85fe9c94836442d47 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Apr 18 20:13:25 2019 +0000 Roll src/third_party/angle 422c94bdab7a..d18c048ab5a6 (2 commits) https://chromium.googlesource.com/angle/angle.git/+log/422c94bdab7a..d18c048ab5a6 git log 422c94bdab7a..d18c048ab5a6 --date=short --no-merges --format='%ad %ae %s' 2019-04-18 ynovikov@chromium.org Remove Nexus 5X Vulkan test suppressions. 2019-04-18 spang@chromium.org Vulkan: Implement glTexStorageMem2DEXT Created with: gclient setdep -r src/third_party/angle@d18c048ab5a6 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I007654cab9b59cc5d1b45a262fd5d6638a1129d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574241 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652273} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 4bb317d6f05137ba9a6683d489a890aeb0fd8efd Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Apr 18 20:13:22 2019 +0000 Roll src/third_party/dawn 0c133bbe554e..342c6ea1a933 (1 commits) https://dawn.googlesource.com/dawn.git/+log/0c133bbe554e..342c6ea1a933 git log 0c133bbe554e..342c6ea1a933 --date=short --no-merges --format='%ad %ae %s' 2019-04-18 enga@chromium.org Fix MultisampledRenderingWithDepthTest Created with: gclient setdep -r src/third_party/dawn@342c6ea1a933 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@chromium.org Change-Id: I28400bfb081eb9a06b825320b71d9358b5266275 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574239 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652272} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 630354225c608dc244342d30534ccd0ad0cdf319 Author: Caitlin Fischer <caitlinfischer@google.com> Date: Thu Apr 18 20:11:56 2019 +0000 [Autofill] Added UseImprovedLabelDisambiguation to testing file. Bug: 953073 Change-Id: Ib0ffe69b177ddbbe2694fe701de791e5779dab60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566596 Auto-Submit: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by: Tommy Martino <tmartino@chromium.org> Reviewed-by: Jesse Doherty <jwd@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#652271} testing/variations/fieldtrial_testing_config.json | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) Updated tag 'tree_truth' (was 17f5cabc3a20)