Back to build
Raw log | Switch to full mode | Login

/b/s/w/ir/cache/builder/src/build/tree_truth.sh /b/s/w/ir/cache/builder/src src in dir /b/s/w/ir/k: allow_subannotations: False cmd: ['/b/s/w/ir/cache/builder/src/build/tree_truth.sh', '/b/s/w/ir/cache/builder/src', 'src'] env: {'CHROME_HEADLESS': '1'} env_prefixes: {} env_suffixes: {} infra_step: False name_tokens: ('tree truth steps',) ok_ret: frozenset([0]) trigger_specs: () full environment: BOTO_CONFIG: /b/s/w/ir/tmp/gsutil_task/.boto BUILDBUCKET_EXPERIMENTAL: FALSE CHROME_HEADLESS: 1 CIPD_CACHE_DIR: /b/s/cipd_cache/cache CIPD_PROTOCOL: v2 DEVSHELL_CLIENT_PORT: 33203 DOCKER_CONFIG: /b/s/w/ir/tmp/docker_cfg_task DOCKER_TMPDIR: /b/s/w/ir/tmp/docker_tmp_task GIT_CONFIG_NOSYSTEM: 1 GIT_TERMINAL_PROMPT: 0 HOME: /home/chrome-bot INFRA_GIT_WRAPPER_HOME: /b/s/w/ir/tmp/git_home_task LOGDOG_COORDINATOR_HOST: logs.chromium.org LOGDOG_STREAM_PREFIX: buildbucket/cr-buildbucket.appspot.com/8915708663375695904 LOGDOG_STREAM_PROJECT: chromium LOGDOG_STREAM_SERVER_PATH: unix:/b/s/w/ir/tmp/ld.sock LOGNAME: chrome-bot LUCI_CONTEXT: /b/s/w/itzq8YUf/luci_context.168749456 MAC_CHROMIUM_TMPDIR: /b/s/w/ir/tmp/t MAIL: /var/mail/chrome-bot NO_GCE_CHECK: False PATH: /b/s/w/ir/cipd_bin_packages:/b/s/w/ir/cipd_bin_packages/bin:/b/s/cipd_cache/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin PWD: /b/s/w/ir/k PYTHONIOENCODING: UTF-8 PYTHONUNBUFFERED: 1 SHELL: /bin/bash SHLVL: 1 SUDO_COMMAND: /usr/bin/python /b/s/swarming_bot.zip start_bot SUDO_GID: 0 SUDO_UID: 0 SUDO_USER: root SWARMING_BOT_ID: luci-chromium-webrtc-fyi-trusty-6-xb1z SWARMING_EXTERNAL_BOT_SETUP: 1 SWARMING_HEADLESS: 1 SWARMING_SERVER: https://chromium-swarm.appspot.com SWARMING_TASK_ID: 4450a35dd1e08111 TEMP: /b/s/w/ir/tmp/t TEMPDIR: /b/s/w/ir/tmp/t TERM: linux TMP: /b/s/w/ir/tmp/t TMPDIR: /b/s/w/ir/tmp/t USER: chrome-bot USERNAME: chrome-bot VPYTHON_VIRTUALENV_ROOT: /b/s/w/ir/cache/vpython _: /b/s/w/ir/cipd_bin_packages/vpython !@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: b47924e0a0e2465111ee1e35806f643ff0553eb2 Factor most Dark Mode code out of GraphicsContext. Aran Gilman, Fri Apr 19 22:58:20 2019 +0000 92ecc62f74072bd8bad6c3401130c3fb476ba5d1 ash: Keep active window uncovered on display change Xiyuan Xia, Fri Apr 19 22:58:08 2019 +0000 9afe1f75e8ec053f2175cd526add3125689fd25d cros: Move *View classes into *Handler types Jacob Dufault, Fri Apr 19 22:55:28 2019 +0000 4a0a88d9aea791220aa65183cbcbdf327737d37f Download Home : Fixed video view for completed videos Shakti Sahu, Fri Apr 19 22:55:15 2019 +0000 a9fdeeb0eb78ea02d6f9f6a10424fa80e686a3a5 [CrOS PerfTest] Launcher Dragging Mitsuru Oshima, Fri Apr 19 22:53:51 2019 +0000 ab78741250a8d4ce2b6da4e3fb5383354020abcd [DevTools] Remove the nobinary-* test suites. Johannes Henkel, Fri Apr 19 22:51:55 2019 +0000 e45c305ded34b6e2f7aef303c5f670021ea1bdee [TTS] Add a test for dictionary definitions. Donn Denman, Fri Apr 19 22:50:17 2019 +0000 f60a2b021addf6f60887d7517dc6ecb5c86f0a83 Use ASCII case conversion and fewer copies in GetWindowFeaturesFromString. Jeremy Roman, Fri Apr 19 22:43:57 2019 +0000 3f0459f6adb39d7078c9cd918fc36059d1ad92b8 [remoting][FTL] Implement FtlDeviceIdProviderIos Yuwei Huang, Fri Apr 19 22:39:27 2019 +0000 690a479e7c458a1a274a862123f94edf7277d4cc Restore browser windows to correct desktop on Win10 (reland) David Bienvenu, Fri Apr 19 22:39:19 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit b47924e0a0e2465111ee1e35806f643ff0553eb2 Author: Aran Gilman <gilmanmh@google.com> Date: Fri Apr 19 22:58:20 2019 +0000 Factor most Dark Mode code out of GraphicsContext. This is a clean-up CL in preparation for adding an image-specific filter. Bug: 954318 Change-Id: I002e09c2ebd384c0f0d667dcb00eebc7550aee71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574629 Commit-Queue: Aran Gilman <gilmanmh@google.com> Reviewed-by: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#652679} third_party/blink/renderer/platform/BUILD.gn | 2 + .../renderer/platform/graphics/dark_mode_filter.cc | 72 ++++++++++++++++++ .../renderer/platform/graphics/dark_mode_filter.h | 34 +++++++++ .../renderer/platform/graphics/graphics_context.cc | 87 ++++++---------------- .../renderer/platform/graphics/graphics_context.h | 10 +-- 5 files changed, 133 insertions(+), 72 deletions(-) commit 92ecc62f74072bd8bad6c3401130c3fb476ba5d1 Author: Xiyuan Xia <xiyuan@chromium.org> Date: Fri Apr 19 22:58:08 2019 +0000 ash: Keep active window uncovered on display change - FocusActivationStore uses ActivateWindow(nullptr) for deactivating to avoid an arbitrary window covering the active window before Restore(). - RootWindowController puts the moved windows under existing ones on display change. Bug: 945754 Change-Id: I3cacfd3427b8c98c9ce9dd2da05977120c1c1d65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574824 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#652678} ash/display/window_tree_host_manager.cc | 9 ++++--- ash/root_window_controller.cc | 7 +++--- ash/root_window_controller_unittest.cc | 44 +++++++++++++++++++++++++++++++++ ash/wm/overview/overview_session.cc | 10 ++++++-- 4 files changed, 62 insertions(+), 8 deletions(-) commit 9afe1f75e8ec053f2175cd526add3125689fd25d Author: Jacob Dufault <jdufault@google.com> Date: Fri Apr 19 22:55:28 2019 +0000 cros: Move *View classes into *Handler types - DeviceDisabledScreenView - EnableDebuggingScreenView - EncryptionMigrationScreenView - FingerprintSetupScreenView - KioskAutoluanchScreenView Also eliminate unnecessary Delegate classes on the views. Bug: 928555 Change-Id: Ifd45f381f2fb9aaae60dbe3ec6ea1287424980bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572521 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#652677} chrome/browser/chromeos/BUILD.gn | 5 --- .../login/screens/device_disabled_screen.cc | 35 ++++++++-------- .../login/screens/device_disabled_screen.h | 23 +++++++---- .../login/screens/device_disabled_screen_view.h | 47 ---------------------- .../login/screens/enable_debugging_screen.h | 2 +- .../login/screens/enable_debugging_screen_view.h | 31 -------------- .../login/screens/encryption_migration_screen.cc | 13 +++--- .../login/screens/encryption_migration_screen.h | 13 +++--- .../screens/encryption_migration_screen_view.h | 47 ---------------------- .../login/screens/fingerprint_setup_screen.cc | 1 + .../login/screens/fingerprint_setup_screen.h | 3 +- .../login/screens/fingerprint_setup_screen_view.h | 34 ---------------- .../login/screens/kiosk_autolaunch_screen.cc | 13 +++--- .../login/screens/kiosk_autolaunch_screen.h | 19 +++++---- .../login/screens/kiosk_autolaunch_screen_view.h | 40 ------------------ .../screens/mock_device_disabled_screen_view.cc | 4 +- .../screens/mock_device_disabled_screen_view.h | 8 ++-- .../login/screens/mock_enable_debugging_screen.h | 2 +- .../login/device_disabled_screen_handler.cc | 3 +- .../login/device_disabled_screen_handler.h | 20 +++++++-- .../login/enable_debugging_screen_handler.cc | 1 - .../login/enable_debugging_screen_handler.h | 17 +++++++- .../login/encryption_migration_screen_handler.cc | 4 +- .../login/encryption_migration_screen_handler.h | 27 +++++++++++-- .../login/fingerprint_setup_screen_handler.h | 19 ++++++++- .../login/kiosk_autolaunch_screen_handler.cc | 4 +- .../login/kiosk_autolaunch_screen_handler.h | 27 +++++++++---- chrome/browser/ui/webui/chromeos/login/oobe_ui.cc | 1 - 28 files changed, 180 insertions(+), 283 deletions(-) commit 4a0a88d9aea791220aa65183cbcbdf327737d37f Author: Shakti Sahu <shaktisahu@chromium.org> Date: Fri Apr 19 22:55:15 2019 +0000 Download Home : Fixed video view for completed videos For completed videos 1 - We should show the play icon for completed videos 2 - We should not show the circle/square animation for completed videos 3 - Paused state should show a download icon rather than play button Bug: 951839 Change-Id: I3cd1aa07777f212824fe7a110ae834fdfe4d118a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575400 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#652676} .../android/java/res/drawable/ic_file_download_36dp.xml | 17 +++++++++++++++++ .../res_download/layout/download_manager_video_item.xml | 12 ++++++++++-- chrome/android/java/res_download/values-v17/styles.xml | 9 ++++++++- 3 files changed, 35 insertions(+), 3 deletions(-) commit a9fdeeb0eb78ea02d6f9f6a10424fa80e686a3a5 Author: Mitsuru Oshima <oshima@chromium.org> Date: Fri Apr 19 22:53:51 2019 +0000 [CrOS PerfTest] Launcher Dragging This measures the presentation time of following actions: * gesture-drag to show the launcher from shelf to fullscreen state. * gesture-drag to hide the fullscreen launcher. I also moved the perf test utility classes into separate file so that they can be used in other tests. Bug: 948324 Change-Id: Iac4d5ca7a39ab44c0404ab927df12608cb7529de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565235 Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#652675} .../ui/ash/launcher_drag_interactive_uitest.cc | 114 ++++++++++++++ .../ash/overview_window_drag_interactive_uitest.cc | 165 ++------------------- chrome/test/BUILD.gn | 3 + chrome/test/base/perf/drag_event_generator.cc | 140 +++++++++++++++++ chrome/test/base/perf/drag_event_generator.h | 78 ++++++++++ 5 files changed, 349 insertions(+), 151 deletions(-) commit ab78741250a8d4ce2b6da4e3fb5383354020abcd Author: Johannes Henkel <johannes@chromium.org> Date: Fri Apr 19 22:51:55 2019 +0000 [DevTools] Remove the nobinary-* test suites. We're removing the --disable-internal-devtools-binary-protocol flag so these virtual tests are no longer useful. See also: https://chromium-review.googlesource.com/c/chromium/src/+/1575999 Bug: 954618 Change-Id: Ia084f42b19ea11c92de9c3dc37d43249ca67d7bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576002 Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#652674} third_party/blink/web_tests/ASANExpectations | 6 - .../disable-features=NetworkService | 5 - .../FlagExpectations/disable-site-isolation-trials | 5 - .../enable-blink-features=CompositeAfterPaint | 5 - .../enable-blink-features=LayoutNG | 4 - third_party/blink/web_tests/LeakExpectations | 5 - third_party/blink/web_tests/MSANExpectations | 38 ------ third_party/blink/web_tests/NeverFixTests | 4 - third_party/blink/web_tests/SlowTests | 71 ---------- third_party/blink/web_tests/TestExpectations | 146 --------------------- third_party/blink/web_tests/VirtualTestSuites | 15 --- .../http/tests/devtools/README.txt | 2 - .../http/tests/inspector-protocol/README.txt | 2 - .../inspector-protocol/README.txt | 2 - .../dom/dom-getBoxModel-expected.txt | 52 -------- 15 files changed, 362 deletions(-) commit e45c305ded34b6e2f7aef303c5f670021ea1bdee Author: Donn Denman <donnd@chromium.org> Date: Fri Apr 19 22:50:17 2019 +0000 [TTS] Add a test for dictionary definitions. Adds a test to exercise the UI when a dictionary definition is returned by the server. BUG=936695 Change-Id: I1b18ab395a402948377d541e828e14f51f170fe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573862 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#652673} .../ContextualSearchManagerTest.java | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) commit f60a2b021addf6f60887d7517dc6ecb5c86f0a83 Author: Jeremy Roman <jbroman@chromium.org> Date: Fri Apr 19 22:43:57 2019 +0000 Use ASCII case conversion and fewer copies in GetWindowFeaturesFromString. All valid inputs are ASCII, and ASCII case conversion is currently done on both the key and value after the Unicode case conversion. While here, use StringView to just access into the ASCII-lowered buffer without copying out substrings for each key and value, since they're only read. Bug: 627682 Change-Id: Ibe11bd111205c286efb12273e006837f57254e19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575125 Reviewed-by: Hayato Ito <hayato@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#652672} .../blink/renderer/core/page/create_window.cc | 29 ++++++++++++++-------- 1 file changed, 18 insertions(+), 11 deletions(-) commit 3f0459f6adb39d7078c9cd918fc36059d1ad92b8 Author: Yuwei Huang <yuweih@chromium.org> Date: Fri Apr 19 22:39:27 2019 +0000 [remoting][FTL] Implement FtlDeviceIdProviderIos This CL provides an FtlDeviceIdProvider implementation for the iOS client, which generates the device ID from identifierForVendor: https://developer.apple.com/documentation/uikit/uidevice/1620059-identifierforvendor?language=objc Bug: 954594 Change-Id: Ieb5c373d66d17751294754c1674e86b8c7cb4ed3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575116 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#652671} remoting/ios/facade/BUILD.gn | 3 +++ remoting/ios/facade/ftl_device_id_provider_ios.h | 30 +++++++++++++++++++++++ remoting/ios/facade/ftl_device_id_provider_ios.mm | 30 +++++++++++++++++++++++ 3 files changed, 63 insertions(+) commit 690a479e7c458a1a274a862123f94edf7277d4cc Author: David Bienvenu <davidbienvenu@chromium.org> Date: Fri Apr 19 22:39:19 2019 +0000 Restore browser windows to correct desktop on Win10 (reland) This is a reland of crrev.com/c/1559168, with a fix for the issue restoring windows after minimize (crbug.com/952142). Bug: 873414,952142 Change-Id: I421c1334396c9525dc121d2e98864b7bf1b691a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570246 Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#652670} .../frame/browser_desktop_window_tree_host_win.cc | 60 ++++++++++++++++++++-- .../frame/browser_desktop_window_tree_host_win.h | 15 ++++++ 2 files changed, 71 insertions(+), 4 deletions(-) commit f46c54763b22b7c695c805e8c3a3d861d76ba80b Author: Jeremy Roman <jbroman@chromium.org> Date: Fri Apr 19 22:37:09 2019 +0000 Use ASCII case conversion in color input validation. All valid color strings are ASCII. Bug: 627682 Change-Id: Ib169ff7c1014557ac50286435b443dc1e3104533 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574210 Reviewed-by: Hayato Ito <hayato@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#652669} third_party/blink/renderer/core/html/forms/color_input_type.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 1de6cac58d76702e4af9293459859639883c40e4 Author: David Black <dmblack@google.com> Date: Fri Apr 19 22:36:35 2019 +0000 Attempt to fix crash in Assistant UI close sequence. I was unable to reproduce the crash, but based on the stack trace in crbug/952996, my understanding of the cause is: (1) User attempts to close Assistant UI via caption bar while animation is in progress. (2) This triggers an animation abort to occur which fires an animation ended callback in UiElementContainerView. (3) UiElementContainerView currently only handles the case where an animation end occurs due to a new Assistant response being queued for display. (4) We attempt to access the queued Assistant response and crash. Since (1) will ultimately result in the entire Assistant view hierarchy being destroyed, the cleanest way to handle this is to just prevent (3) - (4) from accessing invalid state. Bug: 952996 Change-Id: I056df562a21f18ae032beaeb46fc637ecef21c1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574743 Reviewed-by: Tao Wu <wutao@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#652668} ash/assistant/ui/main_stage/ui_element_container_view.cc | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) commit 7a281343ffbccad662f6d3dce487f40bc926de1a Author: Erik Luo <luoe@chromium.org> Date: Fri Apr 19 22:27:46 2019 +0000 DevTools: remove section editing state, manual height in SSP A) SSP used to manually set height, 'contain: strict' during edits for performance. This CL removes them, since there is no noticeable gain. See crbug.com/684341 B) Removes unnecessary 'editing state tracking', once used to manually focus sections before ShadowDOM-delegatesFocus. See also crbug.com/791494 Pre-keyboard navigation) SSP has tabIndex 0. On editingCommitted, we ensure focus goes back to the pane. After-keynav) Individual sections have tabIndex -1. On stopEditing, parent pane has focus, but we manually move focus to the section. After ShadowDOM V1) parent pane no longer has tabIndex, but uses 'delegatesFocus'. This makes moving focus around unnecessary. However, it also introduces 'blue flickering' when users 'Tab' navigate through properties, since focus is first delegated to the section. This bug is not addressed in this CL. Bug: 931145 Change-Id: If24177344ec975478fd91937daea58630b396069 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574366 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#652667} .../front_end/elements/StylePropertyTreeElement.js | 9 ------ .../front_end/elements/StylesSidebarPane.js | 34 +--------------------- 2 files changed, 1 insertion(+), 42 deletions(-) commit d5aeaaeb4ccfcf0d565dc056a5bf6fd3cd40c0e8 Author: rbpotter <rbpotter@chromium.org> Date: Fri Apr 19 22:26:46 2019 +0000 Print Preview: Clean up height/width values by moving to variables Also create a new print_preview_vars_css.html file, to store all CSS variables separately from common styles. Bug: 952960, 941369 Change-Id: I24bcc3cca781d7acfe7ff075e5b954827b009745 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573163 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#652666} .../new/advanced_settings_dialog.html | 1 + .../browser/resources/print_preview/new/app.html | 7 ++-- .../resources/print_preview/new/button_strip.html | 3 +- .../print_preview/new/destination_dialog.html | 7 ++-- .../print_preview/new/destination_list.html | 4 +- .../print_preview/new/destination_list_item.html | 4 +- .../print_preview/new/destination_settings.html | 5 ++- .../resources/print_preview/new/header.html | 4 +- .../resources/print_preview/new/header_new.html | 4 +- .../print_preview/new/link_container.html | 5 ++- .../resources/print_preview/new/more_settings.html | 2 +- .../print_preview/new/number_settings_section.html | 5 ++- .../print_preview/new/pages_settings.html | 6 --- .../resources/print_preview/new/pin_settings.html | 3 -- .../resources/print_preview/new/preview_area.html | 4 +- .../new/print_preview_shared_css.html | 37 +++---------------- .../print_preview/new/print_preview_sidebar.html | 5 ++- .../print_preview/new/print_preview_vars_css.html | 43 ++++++++++++++++++++++ .../new/provisional_destination_resolver.html | 1 + .../print_preview/new/settings_section.html | 9 +++-- .../resources/print_preview/print_preview_new.html | 2 +- .../print_preview/print_preview_resources.grd | 4 ++ 22 files changed, 92 insertions(+), 73 deletions(-) commit 5cb523d30c2ac2ac8a4df78f9e58a1ec43791926 Author: Charlene Yan <cyan@chromium.org> Date: Fri Apr 19 22:26:11 2019 +0000 Make dialogs not draggable by default. Updated a few known cases that should be draggable. Bug: 930782 Change-Id: I09ba7e0a71097317d241042e16a89f28dd27f4a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570126 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/master@{#652665} chrome/browser/ui/views/chrome_cleaner_reboot_dialog_win.cc | 4 ++++ chrome/browser/ui/views/chrome_cleaner_reboot_dialog_win.h | 1 + .../browser/ui/views/extensions/extension_install_dialog_view.cc | 7 +++++++ chrome/browser/ui/views/extensions/extension_install_dialog_view.h | 1 + chrome/browser/ui/views/policy/enterprise_startup_dialog_view.cc | 4 ++++ chrome/browser/ui/views/policy/enterprise_startup_dialog_view.h | 1 + ui/views/bubble/bubble_frame_view.cc | 3 +-- ui/views/window/dialog_delegate.cc | 4 ++++ ui/views/window/dialog_delegate.h | 4 ++++ ui/views/window/dialog_delegate_unittest.cc | 1 + 10 files changed, 28 insertions(+), 2 deletions(-) commit 12a26a1ca41487ed7b6b4a7b1dd955280eaf5402 Author: Ken Rockot <rockot@google.com> Date: Fri Apr 19 22:14:35 2019 +0000 [mojo-bindings] New associated endpoint types Adds associated analogs for Remote, Receiver, ReceiverSet, PendingRemote, and PendingReceiver. Basic smoke test coverage for compile and basic operation, since implementation is in terms of types with extensive coverage already. Bug: 875030 Change-Id: Ib441f15da94e1c481e9f7f88d3012ceda886bbf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574365 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#652664} mojo/public/cpp/bindings/BUILD.gn | 5 + mojo/public/cpp/bindings/associated_receiver.h | 194 +++++++++++++++++ mojo/public/cpp/bindings/associated_receiver_set.h | 28 +++ mojo/public/cpp/bindings/associated_remote.h | 236 +++++++++++++++++++++ .../cpp/bindings/lib/interface_serialization.h | 53 +++++ .../cpp/bindings/pending_associated_receiver.h | 53 +++++ .../cpp/bindings/pending_associated_remote.h | 67 ++++++ mojo/public/cpp/bindings/receiver_set.h | 10 +- mojo/public/cpp/bindings/remote.h | 6 + .../bindings/tests/new_endpoint_types_unittest.cc | 91 ++++++++ .../bindings/tests/new_endpoint_types.test-mojom | 9 + .../generators/cpp_templates/module-forward.h.tmpl | 2 + .../bindings/generators/mojom_cpp_generator.py | 18 +- .../bindings/generators/mojom_java_generator.py | 15 +- .../bindings/generators/mojom_js_generator.py | 36 ++-- .../tools/bindings/pylib/mojom/generate/module.py | 42 +++- .../tools/bindings/pylib/mojom/generate/pack.py | 5 +- .../bindings/pylib/mojom/generate/translate.py | 13 +- .../tools/bindings/pylib/mojom/parse/lexer.py | 4 +- .../tools/bindings/pylib/mojom/parse/parser.py | 12 ++ 20 files changed, 869 insertions(+), 30 deletions(-) commit 9afb37102ab263fdaf95a05f03e256f256ef5cc2 Author: dpapad <dpapad@chromium.org> Date: Fri Apr 19 22:13:15 2019 +0000 WebUI: Migrate content/browser/resources/ from var to let/const. Also: - Added an .eslintrc.js file to enforce these changes. - Added exception for content/browser/resources/media/ which is fairly large and should be updated separately. Bug: 792774 Change-Id: I80b6079220cea112016e5a25c79f01f52a353890 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572935 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Dan Beam <dbeam@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#652663} .../browser/resources/{process => }/.eslintrc.js | 7 +- .../resources/appcache/appcache_internals.js | 144 ++++++++++----------- content/browser/resources/gpu/browser_bridge.js | 10 +- .../browser/resources/gpu/browser_bridge_tests.js | 18 +-- content/browser/resources/gpu/gpu_internals.js | 2 +- content/browser/resources/gpu/info_view.js | 94 +++++++------- .../resources/indexed_db/indexeddb_internals.js | 28 ++-- content/browser/resources/media/.eslintrc.js | 10 ++ .../resources/net/network_errors_listing.js | 18 +-- .../service_worker/serviceworker_internals.js | 60 ++++----- 10 files changed, 199 insertions(+), 192 deletions(-) commit ae61fb43e0329ba875ecf4248ff4c211d2e9ff67 Author: Sinan Sahin <sinansahin@google.com> Date: Fri Apr 19 22:09:27 2019 +0000 Update Gpay logo and camera icon colors Bug: 951103, 951111 Change-Id: Iab209ea609e4de0db4dce6b29843ec6e2860d9dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574593 Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Becky Zhou <huayinz@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#652662} chrome/android/java/res/drawable/google_pay.xml | 6 +++--- chrome/android/java/res/drawable/google_pay_with_divider.xml | 9 ++++----- chrome/android/java/res/drawable/ic_photo_camera_black.xml | 6 ++---- 3 files changed, 9 insertions(+), 12 deletions(-) commit 65eadab092c939fe088e1b62ce555fa059ed36bf Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Fri Apr 19 22:09:02 2019 +0000 Roll src-internal 7be19dbfabac..990de7c7fcb5 (3 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7be19dbfabac..990de7c7fcb5 Created with: gclient setdep -r src-internal@990de7c7fcb5 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=fdoray@chromium.org,bsep@chromium.org,keishi@chromium.org,chanli@chromium.org Change-Id: Ie858b74bd619629b906ab4dd426f41af72b121ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575876 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652661} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 414ecb8a9475fb93735600463a7c25c011107e6b Author: Lily Chen <chlily@chromium.org> Date: Fri Apr 19 22:08:18 2019 +0000 Add "Extended" and "None" as cookie SameSite options in DevTools This CL adds "Extended" and "None" as possible values of SameSite for display in DevTools, to reflect the addition of new values to the enum net::CookieSameSite. Bug: 953306, 953995 Change-Id: Ic04eec726cfea0d9fcdbfcb26ff268bb532e85ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575109 Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#652660} content/browser/devtools/protocol/network_handler.cc | 14 ++++++++++---- .../blink/renderer/core/inspector/browser_protocol.pdl | 2 ++ 2 files changed, 12 insertions(+), 4 deletions(-) commit 602757c580a316bc3d63e491775a9016fe6e11ea Author: Jeffrey Kardatzke <jkardatzke@google.com> Date: Fri Apr 19 22:07:54 2019 +0000 Fix regression where feedback reports don't upload This was due to a coding error in another recent CL: crrev.com/c/1560516 Bug: 954563 Test: Generated feedback report is uploaded to server Change-Id: I2747760b1c41ec44476f2361148a351675719b97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575174 Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by: Chris Morin <cmtm@chromium.org> Reviewed-by: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by: J Kardatzke <jkardatzke@chromium.org> Reviewed-by: Rahul Chaturvedi <rkc@chromium.org> Commit-Queue: J Kardatzke <jkardatzke@chromium.org> Commit-Queue: Rahul Chaturvedi <rkc@chromium.org> Cr-Commit-Position: refs/heads/master@{#652659} .../extensions/api/feedback_private/chrome_feedback_private_delegate.cc | 1 + 1 file changed, 1 insertion(+) commit 33da179d28beb0f03278a04b6ee2d97bbd8daf82 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 19 22:05:58 2019 +0000 Roll src/third_party/chromite 7ef31b3e5b93..5609aa373c8e (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/7ef31b3e5b93..5609aa373c8e git log 7ef31b3e5b93..5609aa373c8e --date=short --no-merges --format='%ad %ae %s' 2019-04-19 dhanyaganesh@chromium.org history-aware: Extend the lookback period to a week Created with: gclient setdep -r src/third_party/chromite@5609aa373c8e The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: Idbc6b7135fa6ecfb8700cdd191daafed70bc3a37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575875 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652658} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 580ffed261aff220a23fa24daacbe5c96d834fa3 Author: Yue Li <updowndota@chromium.org> Date: Fri Apr 19 22:05:55 2019 +0000 Using LaunchIntent for open Android app device actions Bug: b/129505256 Test: Manual Test Change-Id: I0d4fbe6c6a2b0280e6bff4ce9340db13291d40a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571026 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#652657} chrome/browser/ui/ash/assistant/device_actions.cc | 61 ++++++++++++----------- 1 file changed, 31 insertions(+), 30 deletions(-) commit 1a3111e269fa7c156d12d3b2e595c37a5235dd1e Author: Sinan Sahin <sinansahin@google.com> Date: Fri Apr 19 22:04:22 2019 +0000 Fix TalkBack announcement for disabled Offer to translate list item Bug: 802284 Change-Id: I674255c3d1aa577206f677f13ad5bd30efc085ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572901 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#652656} .../java/src/org/chromium/chrome/browser/widget/ListMenuButton.java | 6 ++++++ 1 file changed, 6 insertions(+) commit 18daee4205765421694c621ad9e24be4a7645b88 Author: Oystein Eftevaag <oysteine@chromium.org> Date: Fri Apr 19 22:04:02 2019 +0000 Perfetto: Defer taskrunner creation to be on-demand Also queue up any tasks posted to the Perfetto task-runner-wrapper until the Chrome taskscheduler has been created. R=eseckler@chromium.org TBR=yusukes@chromium.org Change-Id: Ie9a2dd26ee529add9ce86709eef5876edbd7de27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553670 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by: oysteine <oysteine@chromium.org> Reviewed-by: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#652655} .../chromeos/arc/tracing/arc_tracing_bridge.cc | 7 ++++--- content/browser/tracing/cros_tracing_agent.cc | 2 +- .../tracing/perfetto/consumer_host_unittest.cc | 6 ++++-- .../perfetto/perfetto_integration_unittest.cc | 2 +- services/tracing/perfetto/test_utils.cc | 2 +- .../tracing/public/cpp/perfetto/producer_client.cc | 21 ++++++-------------- .../tracing/public/cpp/perfetto/task_runner.cc | 23 ++++++++++++++++++---- services/tracing/public/cpp/perfetto/task_runner.h | 3 ++- .../public/cpp/perfetto/task_runner_unittest.cc | 2 +- .../public/cpp/perfetto/trace_event_data_source.cc | 2 +- 10 files changed, 40 insertions(+), 30 deletions(-) commit 01f1f6a961b65bd2ada9419c96b8fce3be5b6f86 Author: Jeremy Roman <jbroman@chromium.org> Date: Fri Apr 19 22:03:16 2019 +0000 Use ASCII case folding for encoding type. Per spec, this should use ASCII, not Unicode, case folding: https://html.spec.whatwg.org/#enumerated-attribute Bug: 627682 Change-Id: I2e11153c3c391fd2a8e720b28d2412da59795c12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575085 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#652654} third_party/blink/renderer/platform/network/encoded_form_data.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit afc77d66e1706ab792f7d97fa85c6dad93ffa254 Author: Jeremy Roman <jbroman@chromium.org> Date: Fri Apr 19 22:02:57 2019 +0000 Use ASCII case conversion for WebElement::HasHTMLTagName. Unicode case conversion is slower and incorrect. Besides, all strings passed here today are ASCII. Bug: 627682 Change-Id: Ie2f5777599c62879e3e3460e7cbd516010c56792 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574790 Reviewed-by: Hayato Ito <hayato@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#652653} third_party/blink/renderer/core/exported/web_element.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit b46030d2da40cb4d38582c0a3afb6a9b840c1e7c Author: rbpotter <rbpotter@chromium.org> Date: Fri Apr 19 21:57:23 2019 +0000 Print Preview: Fix destinations dialog search issues - Add a "clear search" button to the print preview search box element. - Remove unnecessary timeout, since a timeout has subsequently been added to CrSearchFieldBehavior. Bug: 954278 Change-Id: I073a991227b71213968ac8dac2994a2a3b3a2873 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574609 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#652652} .../new/print_preview_search_box.html | 28 ++++++++++++++++++++-- .../print_preview/new/print_preview_search_box.js | 26 +++++++++++--------- 2 files changed, 41 insertions(+), 13 deletions(-) commit 21d18d87ecba7e76ea1b713039bdf0e92cc25ced Author: Bret Sepulveda <bsep@chromium.org> Date: Fri Apr 19 21:56:54 2019 +0000 Modify TestExpectations for contentSecurityPolicy tests. Attempting to deflake Windows 10 bot. These tests are now failing instead of crashing: http/tests/security/contentSecurityPolicy/register-bypassing-scheme-partial.html virtual/outofblink-cors/http/tests/security/contentSecurityPolicy/register-bypassing-scheme-partial.html These tests are now passing consistently: http/tests/security/contentSecurityPolicy/register-bypassing-scheme-script.https.html virtual/outofblink-cors/http/tests/security/contentSecurityPolicy/register-bypassing-scheme-script.https.html The expectations are updated accordingly. TBR=csharrison@chromium.org Bug: 686118, 954586 Change-Id: Ia11e2a602908f0f647d879203f660263739bfc16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574596 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#652651} third_party/blink/web_tests/TestExpectations | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) commit a77d5ba9c4621cfe14e7e1cd03bbae16904f269e Author: Chris Lu <thegreenfrog@chromium.org> Date: Fri Apr 19 21:53:52 2019 +0000 [ios] Add thegreenfrog and michaeldo as owners of //ios/web/find_in_page. Thegreenfrog has been responsible for creating all file contents in this directory, landing 10+ CLs in the process. Michaeldo has reviewed a majority of those CLs. Bug: 919685 Change-Id: I4da69fbbeee987381c632a174528f1ce606a1b22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574461 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#652650} ios/web/find_in_page/OWNERS | 5 +++++ 1 file changed, 5 insertions(+) commit de3c97f8e0ef1e06ec72aa386695d625bbf8286d Author: David Benjamin <davidben@chromium.org> Date: Fri Apr 19 21:38:37 2019 +0000 Support StringPiece in net_string_util.h Bug: 820198 Change-Id: I0c7689b2e866264494816eda4df400c2cf337636 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574589 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#652649} net/base/net_string_util.h | 14 ++++++++----- net/base/net_string_util_icu.cc | 21 +++++++++++-------- .../net_string_util_icu_alternatives_android.cc | 24 +++++++++++++--------- net/base/net_string_util_icu_alternatives_ios.mm | 10 ++++----- 4 files changed, 40 insertions(+), 29 deletions(-) commit 30e08b710b8e3f2f43259073dc342644f6197d4c Author: Achuith Bhandarkar <achuith@chromium.org> Date: Fri Apr 19 21:38:12 2019 +0000 Revert "chromeos: Disable Tast test security.SELinuxFilesNonARC to unblock LKGM roll." This reverts commit 854d09d1f360d737d15498879213d26e4bd5a105. Reason for revert: New LKGM 12105.0.0 has landed Original change's description: > chromeos: Disable Tast test security.SELinuxFilesNonARC to unblock LKGM roll. > > Unblocks https://chromium-review.googlesource.com/c/chromium/src/+/1573380 > > Bug: 954192 > Change-Id: If338e6fd4cb28ba8a18996c786b87cea978366fa > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574598 > Commit-Queue: Ben Pastene <bpastene@chromium.org> > Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> > Cr-Commit-Position: refs/heads/master@{#652420} TBR=stevenjb@chromium.org,achuith@chromium.org,bpastene@chromium.org,agawronska@chromium.org Change-Id: I8171e93bf1a4f75444749ae1bb564f4986f955a2 Bug: 954192 Change-Id: I8171e93bf1a4f75444749ae1bb564f4986f955a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575112 Reviewed-by: Aga Wronska <agawronska@chromium.org> Reviewed-by: Ben Pastene <bpastene@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#652648} chromeos/BUILD.gn | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 8c2be4d192d4c6db40d98247aece1f832f8dcfbd Author: rajendrant <rajendrant@chromium.org> Date: Fri Apr 19 21:36:52 2019 +0000 Populate data reduction proxy page ID for an alternate path This path seems to be used in some webdriver tests. The populated page ID will be sent in the data reduction proxy pingbacks. Bug: 951913 Change-Id: Ie246963027af6ea8d3219c00c23012fc98787e9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574215 Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#652647} .../browser/previews/previews_lite_page_decider.cc | 16 +++++++ .../browser/previews/previews_lite_page_decider.h | 8 ++++ .../previews_lite_page_decider_unittest.cc | 52 ++++++++++++++++++++++ .../renderer_host/chrome_navigation_ui_data.cc | 3 ++ chrome/browser/ui/browser_navigator.cc | 12 ++--- 5 files changed, 82 insertions(+), 9 deletions(-) commit 8afa9297a5783414513885a8cadb4538fac4cfa9 Author: Karan Bhatia <karandeepb@chromium.org> Date: Fri Apr 19 21:36:32 2019 +0000 DNR: Prevent web request extensions from adding removed headers. r652224 added initial support for removing headers through the Declarative Net Request API. This CL fixes an existing TODO by preventing web request extensions from adding back headers removed by DNR. BUG=947591 Change-Id: I8a6eb4bd3ae8d9bdd556feefb454cbd30944aa74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565613 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#652646} .../api/web_request/web_request_api_unittest.cc | 143 +++++++++++--- .../header_removal/background.js | 207 +++++++++++++++++---- .../header_removal/manifest.json | 1 + .../browser/api/web_request/web_request_api.cc | 10 +- .../api/web_request/web_request_api_helpers.cc | 99 ++++++---- .../api/web_request/web_request_api_helpers.h | 6 +- 6 files changed, 355 insertions(+), 111 deletions(-) commit 142ff4f60be3ddf3663380f51a54554bd2722f0f Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 19 21:35:03 2019 +0000 Roll src/third_party/catapult 1ff0422ebea4..cc0161223605 (6 commits) https://chromium.googlesource.com/catapult.git/+log/1ff0422ebea4..cc0161223605 git log 1ff0422ebea4..cc0161223605 --date=short --no-merges --format='%ad %ae %s' 2019-04-19 benjhayden@chromium.org Migrate ExistingBugRequest, NewBugRequest to es6 module 2019-04-19 benjhayden@chromium.org Migrate cp-radio-group to es6 module 2019-04-19 benjhayden@chromium.org Migrate chart-legend to es6 module 2019-04-19 benjhayden@chromium.org Migrate cp-textarea to es6 module 2019-04-19 benjhayden@chromium.org Migrate sparkline-compound to es6 module. 2019-04-19 benjhayden@chromium.org Migrate ConfigRequest, ReportRequest to es6 modules. Created with: gclient setdep -r src/third_party/catapult@cc0161223605 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:950011,chromium:950011,chromium:950011,chromium:950011,chromium:950011,chromium:950011 TBR=charliea@chromium.org Change-Id: Ib308bab857a83aa3e2fc7d6fbac12d1b1a81698b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575874 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652645} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit ff528d68212cbb5c0765af5a74fe560409402a99 Author: Michael Crouse <mcrouse@chromium.org> Date: Fri Apr 19 21:33:28 2019 +0000 [Previews] Use HintUpdateData in place of ComponentUpdateData. Continues the refactor of ComponentUpdateData out of the HintCacheStore by using the new HintUpdateData. HintUpdateData can be constructed with either component or fetched hints. Bug: 932707 Change-Id: Ib84208df9922028f99854339202e1896ffe75604 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572870 Reviewed-by: Doug Arnett <dougarnett@chromium.org> Reviewed-by: Tarun Bansal <tbansal@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#652644} components/previews/content/hint_cache.cc | 32 +++--- components/previews/content/hint_cache.h | 31 +++-- components/previews/content/hint_cache_store.cc | 121 ++++++-------------- components/previews/content/hint_cache_store.h | 120 +++++--------------- .../previews/content/hint_cache_store_unittest.cc | 126 +++++++++++---------- components/previews/content/hint_cache_unittest.cc | 111 +++++++++--------- components/previews/content/hint_update_data.cc | 9 +- .../previews/content/hint_update_data_unittest.cc | 2 +- components/previews/content/previews_hints.cc | 15 ++- components/previews/content/previews_hints.h | 15 +-- .../previews/content/previews_hints_unittest.cc | 4 +- .../content/previews_optimization_guide.cc | 21 ++-- 12 files changed, 251 insertions(+), 356 deletions(-) commit b873bc136679d85e90d57992f0f63cc6da948d5b Author: Bret Sepulveda <bsep@chromium.org> Date: Fri Apr 19 21:30:32 2019 +0000 Mark element-ready-check-containing-iframe-manual.html passing on Win10. Attempting to deflake Windows 10 bot. According to the flakiness dashboard, external/wpt/fullscreen/api/element-ready-check-containing-iframe-manual.html now passes consistently. Therefore, removing it from TestExpectations. TBR=mustaq@chromium.org Bug: 908841, 954586 Change-Id: Ia51a032a5470454527eefab570c61d57caa73d88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575165 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#652643} third_party/blink/web_tests/TestExpectations | 3 --- 1 file changed, 3 deletions(-) commit a4ce9ccc717ef723fb4ce2fa7043612c126bebc5 Author: Nate Fischer <ntfschr@chromium.org> Date: Fri Apr 19 21:30:01 2019 +0000 AW: dump commandline state to logs for debugging Similar to http://crrev/c/1266611, this dumps WebView's CommandLine state (including the "--enable-features" and "--disable-features" switches) to the log when the "dummy app" ("org.chromium.webview_log_verbosifier") is present. Notably, this will give us an idea of whether the NetworkService is enabled or not (FieldTrialList + CommandLine state + knowledge of whether it is enabled-or-disabled-by-default should be sufficient). This also adds a usage guide for the webview verbosifier app, including the new commandline stuff. Skipping presubmit for LOG(INFO). NOPRESUBMIT=true Bug: 929886, 918221 Test: Manual (following the steps in the new docs) Test: Upload to gerrit > open file > click "gitiles" Change-Id: I4c698d661c340f760e2a90da20439b44a56ea38b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573087 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by: Richard Coles <torne@chromium.org> Reviewed-by: Paul Miller <paulmiller@chromium.org> Cr-Commit-Position: refs/heads/master@{#652642} android_webview/browser/aw_contents_statics.cc | 14 +++++++++ .../webview/chromium/WebViewChromiumAwInit.java | 9 +++++- .../android_webview/AwContentsStatics.java | 5 ++++ .../tools/webview_log_verbosifier/README | 3 -- .../tools/webview_log_verbosifier/README.md | 35 ++++++++++++++++++++++ 5 files changed, 62 insertions(+), 4 deletions(-) commit bb1b1e2852d7b98c30493125259c5f530ae7c415 Author: Bret Sepulveda <bsep@chromium.org> Date: Fri Apr 19 21:22:59 2019 +0000 Mark webkit_layout_tests' control-chars-08E.html passing on Win10. Attempting to deflake Windows 10 bot. external/wpt/css/css-text/white-space/control-chars-08E.html now passes consistently on Windows 10, so marking it Failure only on Windows 7. TBR=eae@chromium.org Bug: 893490, 954586 Change-Id: Id82597d887e8579d50c3a0d73530c07657a0658c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574592 Reviewed-by: Emil A Eklund <eae@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#652641} third_party/blink/web_tests/TestExpectations | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit dbe884a8304a2914d11cc9e6b4b4cf32ec274606 Author: David Benjamin <davidben@chromium.org> Date: Fri Apr 19 21:22:53 2019 +0000 Convert easy bits of HttpUtil to StringPiece. Most of this file is awkwardly tied up with prtime.cc or StringTokenizer, but convert some boring ones. Bug: 820198 Change-Id: I339911e7cfbe6136a82d71ec1d1cd000ccc7b91a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575873 Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by: Eric Roman <eroman@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#652640} net/http/http_util.cc | 10 +++++----- net/http/http_util.h | 10 +++++----- 2 files changed, 10 insertions(+), 10 deletions(-) commit 77f34eb18173bae80cb37e47369772c4f48e11fb Author: Alexei Filippov <alph@chromium.org> Date: Fri Apr 19 21:21:15 2019 +0000 [heap profiler] Drop multithreading support from BacktraceStorage. The BacktraceStorage object livespan is local to ConnectionManager::HeapProfileRetrieved and accessed from a single thread. BUG=923459 Change-Id: I97dfa2642d5efd06461ea69cb833d4a6aba1083d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574942 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#652639} components/services/heap_profiling/BUILD.gn | 5 +- components/services/heap_profiling/address.h | 65 ---------- .../services/heap_profiling/allocation_event.h | 5 +- components/services/heap_profiling/backtrace.cc | 16 +-- components/services/heap_profiling/backtrace.h | 36 ++---- .../services/heap_profiling/backtrace_storage.cc | 135 --------------------- .../services/heap_profiling/backtrace_storage.h | 107 ---------------- ...e_storage_unittest.cc => backtrace_unittest.cc} | 4 +- .../services/heap_profiling/connection_manager.cc | 29 ++--- .../services/heap_profiling/connection_manager.h | 19 --- .../services/heap_profiling/json_exporter.cc | 16 ++- components/services/heap_profiling/json_exporter.h | 1 - .../heap_profiling/json_exporter_unittest.cc | 46 ++++--- 13 files changed, 55 insertions(+), 429 deletions(-) commit 7a7d567331594a11a9e3e2036256b2e3740b2bd6 Author: asteinha <asteinhauser@google.com> Date: Fri Apr 19 21:16:18 2019 +0000 Removing usages of a deleted flag. Deleted in https://chromium.googlesource.com/chromium/src.git/+/ba49d00fddeb39c0816090dad7d359df0dce9a1a Bug: 74848 Change-Id: Ia3d5c796ad34857f4e84fdb3a6f53fce3f00d63b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574829 Reviewed-by: Egor Pasko <pasko@chromium.org> Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Anthony Steinhauser <asteinhauser@google.com> Cr-Commit-Position: refs/heads/master@{#652638} .../native_client/tools/browser_tester/browsertester/browserlauncher.py | 1 - tools/android/customtabs_benchmark/scripts/chrome_setup.py | 2 -- 2 files changed, 3 deletions(-) commit 66eb3cbb49659ecf0f411999a30c2c9ec2257cb5 Author: Chris Harrelson <chrishtr@chromium.org> Date: Fri Apr 19 21:12:44 2019 +0000 Promote fixed-position elements with compositing descendants. This code was accidentally removed in an earlier commit (*). It seems fixed-position elements with compositing descendants need to be promoted for the existing compositing system to work. (*) https://chromium-review.googlesource.com/c/chromium/src/+/1407922 Bug: 950418 Change-Id: Iec04435bb1a20a17c54ce4f5ff35f4e00704e6b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574686 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#652637} .../core/paint/compositing/compositing_requirements_updater.cc | 5 +++++ .../blink/renderer/platform/graphics/compositing_reasons.cc | 7 +++---- third_party/blink/renderer/platform/graphics/compositing_reasons.h | 2 +- 3 files changed, 9 insertions(+), 5 deletions(-) commit b93aae7c03a1f837e689737d0b252900fc9d19ee Author: Ken Rockot <rockot@google.com> Date: Fri Apr 19 21:09:13 2019 +0000 [mojo-bindings] Clean-up/augment new binding types Adds minor API features and fixes some bugs in the Remote/Receiver types to support further conversion of code away from InterfacePtr etc. Bug: 875030 Change-Id: Ia001195c8fd0feed669d3cd65f501ace55de3015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574896 Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#652636} mojo/public/cpp/bindings/BUILD.gn | 1 + mojo/public/cpp/bindings/pending_receiver.h | 13 +- mojo/public/cpp/bindings/pending_remote.h | 19 +- mojo/public/cpp/bindings/receiver.h | 8 +- mojo/public/cpp/bindings/remote.h | 33 +++- mojo/public/cpp/bindings/thread_safe_remote.h | 195 +++++++++++++++++++++ .../tools/bindings/pylib/mojom/generate/module.py | 26 +-- 7 files changed, 271 insertions(+), 24 deletions(-) commit 32d39ff3d0aff12bc8aabcbd822bfdd101f3c4cb Author: Dale Curtis <dalecurtis@chromium.org> Date: Fri Apr 19 20:59:52 2019 +0000 Enable offloading for Dav1dVideoDecoder. This moves decoding of AV1 content via dav1d to a task pool instead of sharing the media thread -- which was apparently leading to underflow of the audio. This probably only fixes pausing and audio drop outs, if a video frame is taking more than 200ms (audio buffer size) to return, we've probably exhausted the video frame buffer too. This would result in video apprearing frozen for a moment, but would not trigger underflow since we have a 3 second threshold for underflow on video. Unlike the VP9 offloading, we offload for all resolutions of AV1 content, since we seem to be getting these issues even with 360p content. This removes an unnecessary BindToCurrentLoop for the OutputCB in the non-offloaded case for clarity. BUG=940686 TEST=all existing tests pass with offloading decoder. Change-Id: I7426a0353249646600c12019f868aa058c40e456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574830 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#652635} media/filters/dav1d_video_decoder.cc | 47 +++++++++++++++++++--------- media/filters/dav1d_video_decoder.h | 30 +++++++++++++++--- media/filters/offloading_video_decoder.h | 10 ++++++ media/filters/vpx_video_decoder.cc | 2 -- media/filters/vpx_video_decoder.h | 19 +++-------- media/renderers/default_decoder_factory.cc | 3 +- media/test/pipeline_integration_test_base.cc | 3 +- 7 files changed, 78 insertions(+), 36 deletions(-) commit ee755115eb2dfe2b290e175d5622ddba4d19a1de Author: Prashant Malani <pmalani@chromium.org> Date: Fri Apr 19 20:54:15 2019 +0000 Extend expiry date of LECredential histograms Bug: 945564,945565,945566,945567,945568,945570 Test: None Change-Id: I49a379e125084600b85cc721d0bfaac27b1d8417 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574361 Reviewed-by: Steven Holte <holte@chromium.org> Commit-Queue: Prashant Malani <pmalani@chromium.org> Auto-Submit: Prashant Malani <pmalani@chromium.org> Cr-Commit-Position: refs/heads/master@{#652634} tools/metrics/histograms/histograms.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit d29f92a871f173276c4cfdfd0d05823986ea699a Author: Charlene Yan <cyan@chromium.org> Date: Fri Apr 19 20:45:02 2019 +0000 Changing MenuRunner::RunMenuAt to take in a MenuButtonController. This is needed so Buttons can be not a subclass of MenuButton but still install a MenuButtonController for the same behavior. Bug: 901183, 819854 Change-Id: Iccd82dab68ba243f86a8784916332030a295b9ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503349 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Reviewed-by: Taylor Bergquist <tbergquist@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#652633} ash/app_menu/app_menu_model_adapter.cc | 5 +- ash/app_menu/notification_menu_controller.cc | 1 + ash/shelf/login_shelf_view.cc | 4 +- ash/shell/window_type_launcher.cc | 6 +- ash/shell_unittest.cc | 4 +- .../chrome_native_app_window_views_aura_ash.cc | 2 +- .../ui/views/bookmarks/bookmark_editor_view.cc | 26 ++++---- .../bookmarks/bookmark_menu_controller_views.cc | 3 +- .../download/download_shelf_context_menu_view.cc | 2 +- .../ui/views/extensions/extensions_menu_button.cc | 3 +- .../extensions/media_galleries_dialog_views.cc | 6 +- chrome/browser/ui/views/frame/app_menu_button.cc | 2 +- ...rowser_non_client_frame_view_ash_browsertest.cc | 2 +- chrome/browser/ui/views/frame/browser_view.cc | 3 +- .../ui/views/frame/hosted_app_button_container.cc | 2 +- .../ui/views/frame/hosted_app_button_container.h | 3 +- .../ui/views/frame/opaque_browser_frame_view.cc | 8 +-- chrome/browser/ui/views/menu_model_adapter_test.cc | 4 +- chrome/browser/ui/views/menu_test_base.cc | 12 ++-- .../ui/views/profiles/dice_accounts_menu.cc | 5 +- .../ui/views/status_icons/status_icon_win.cc | 2 +- .../ui/views/sync/dice_bubble_sync_promo_view.h | 1 + .../ui/views/tabs/browser_tab_strip_controller.cc | 10 ++- chrome/browser/ui/views/toolbar/app_menu.cc | 9 +-- chrome/browser/ui/views/toolbar/app_menu.h | 6 +- .../ui/views/toolbar/browser_actions_container.cc | 2 +- .../ui/views/toolbar/browser_actions_container.h | 4 +- .../browser_actions_container_browsertest.cc | 4 +- .../ui/views/toolbar/toolbar_action_view.cc | 3 +- .../browser/ui/views/toolbar/toolbar_action_view.h | 2 +- chrome/browser/ui/views/toolbar/toolbar_view.cc | 2 +- chrome/browser/ui/views/toolbar/toolbar_view.h | 2 +- .../webauthn/authenticator_request_dialog_view.cc | 2 +- ui/views/cocoa/bridged_native_widget_host_impl.mm | 1 + ui/views/controls/button/button.cc | 71 ++++++++++++---------- ui/views/controls/button/button.h | 22 ++++++- ui/views/controls/button/button_controller.h | 3 +- ui/views/controls/menu/menu_controller.cc | 6 +- ui/views/controls/menu/menu_controller.h | 5 +- ui/views/controls/menu/menu_controller_unittest.cc | 1 + ui/views/controls/menu/menu_item_view.h | 1 + ui/views/controls/menu/menu_runner.cc | 8 +-- ui/views/controls/menu/menu_runner.h | 4 +- ui/views/controls/menu/menu_runner_handler.h | 11 +++- ui/views/controls/menu/menu_runner_impl.cc | 11 ++-- ui/views/controls/menu/menu_runner_impl.h | 4 +- ui/views/controls/menu/menu_runner_impl_adapter.cc | 4 +- ui/views/controls/menu/menu_runner_impl_adapter.h | 2 +- ui/views/controls/menu/menu_runner_impl_cocoa.h | 2 +- ui/views/controls/menu/menu_runner_impl_cocoa.mm | 2 +- .../controls/menu/menu_runner_impl_interface.h | 3 +- ui/views/examples/menu_example.cc | 4 +- ui/views/test/combobox_test_api.cc | 2 +- 53 files changed, 178 insertions(+), 141 deletions(-) commit ce461e69b48cc058879f523a49e2c7cce85d73c3 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 19 20:44:08 2019 +0000 Roll src/third_party/skia 377befab7175..ba1602896d72 (4 commits) https://skia.googlesource.com/skia.git/+log/377befab7175..ba1602896d72 git log 377befab7175..ba1602896d72 --date=short --no-merges --format='%ad %ae %s' 2019-04-19 halcanary@google.com SkQP: new docker test code 2019-04-19 ethannicholas@google.com fixed Metal code generation for recursive functions 2019-04-19 michaelludwig@google.com Don't batch across domain modes in GrTextureOp 2019-04-19 brianosman@google.com Convexity checker: Wait for significant x-product when walking edges Created with: gclient setdep -r src/third_party/skia@ba1602896d72 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=herb@chromium.org Change-Id: I8ba3c8a8c0213eb8507aee18e4ed912bb0a3a96d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575867 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652632} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 538d9987048a70bab4a28de8271688bcea72fad2 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Fri Apr 19 20:38:37 2019 +0000 Roll src-internal 40beee366962..7be19dbfabac (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/40beee366962..7be19dbfabac Created with: gclient setdep -r src-internal@7be19dbfabac The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=fdoray@chromium.org,bsep@chromium.org,keishi@chromium.org,chanli@chromium.org Change-Id: Ife9c0d4d0a4a2925cbbdbc442b9db91fb8824cca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575862 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652631} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 9d83a7a5d5e233019ff08aef8b8ebbb56ea4fdd5 Author: Jacob Dufault <jdufault@google.com> Date: Fri Apr 19 20:37:40 2019 +0000 cros: Move some *View classes into *Handler files - KioskEnableScreenView - MarketingOptInScreenView - WrongHwidScreenView - SyncConsentScreenView Also remove the Delegate classes on the moved views where applicable. Bug: 928555 Change-Id: Ia833a286b49dda8af7c93f7b5aacebe239f021d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572539 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#652630} chrome/browser/chromeos/BUILD.gn | 6 --- .../chromeos/login/screens/hid_detection_screen.cc | 2 +- .../screens/hid_detection_screen_browsertest.cc | 1 - .../chromeos/login/screens/hid_detection_view.h | 48 -------------------- .../chromeos/login/screens/kiosk_enable_screen.cc | 13 +++--- .../chromeos/login/screens/kiosk_enable_screen.h | 18 ++++---- .../login/screens/kiosk_enable_screen_view.h | 40 ----------------- .../login/screens/marketing_opt_in_screen.cc | 2 +- .../login/screens/marketing_opt_in_screen_view.h | 34 --------------- .../login/screens/mock_wrong_hwid_screen.cc | 2 +- .../login/screens/mock_wrong_hwid_screen.h | 8 ++-- .../login/screens/recommend_apps_screen.cc | 1 + .../chromeos/login/screens/recommend_apps_screen.h | 3 +- .../login/screens/recommend_apps_screen_view.h | 51 ---------------------- .../chromeos/login/screens/sync_consent_screen.h | 2 +- .../login/screens/sync_consent_screen_view.h | 38 ---------------- .../chromeos/login/screens/wrong_hwid_screen.cc | 19 ++++---- .../chromeos/login/screens/wrong_hwid_screen.h | 16 ++++--- .../login/screens/wrong_hwid_screen_view.h | 41 ----------------- chrome/browser/chromeos/login/wizard_controller.cc | 2 +- .../chromeos/login/hid_detection_screen_handler.h | 31 ++++++++++++- .../chromeos/login/kiosk_enable_screen_handler.cc | 3 +- .../chromeos/login/kiosk_enable_screen_handler.h | 19 ++++++-- .../login/marketing_opt_in_screen_handler.h | 19 +++++++- .../chromeos/login/recommend_apps_screen_handler.h | 36 ++++++++++++++- .../chromeos/login/sync_consent_screen_handler.h | 23 +++++++++- .../chromeos/login/wrong_hwid_screen_handler.cc | 3 +- .../chromeos/login/wrong_hwid_screen_handler.h | 20 +++++++-- 28 files changed, 191 insertions(+), 310 deletions(-) commit def36cc8e63b98ac6912396224066d378a16b209 Author: David Tseng <dtseng@chromium.org> Date: Fri Apr 19 20:37:29 2019 +0000 Add ax action internalInvalidateTree This change allows a target process or anything outside of the context of a source tree to request that its source tree be invalidated. We make use of this new action in the Automation Internal browser side api, when a client extension's automation bindings requests an enable frame. Typically, chrome.automationInternal.enableFrame gets called whenever the extension process encounters a new child tree. This, in turn, resets state within the tree source and triggers a re-send of all tree data and node data on the next event. The action is hooked up to one tree source (ARC++). TBR=dominickn Bug: 929522 Test: toggle on ChromeVox, interact with Play Store. Toggle off and then back on ChromeVox, interact with Play Store. Repeat this several times. ChromeVox should work throughout. Change-Id: I8e2a729f079f932d06a615bb5fcca9ebbe7365f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573859 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by: Katie Dektar <katie@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#652629} .../arc_accessibility_helper_bridge.cc | 3 + .../arc/accessibility/ax_tree_source_arc.cc | 4 + .../arc/accessibility/ax_tree_source_arc.h | 3 + .../automation_internal/automation_internal_api.cc | 19 +- chrome/common/extensions/api/automation.idl | 1 + .../accessibility/render_accessibility_impl.cc | 7 +- third_party/closure_compiler/externs/automation.js | 1 + ui/accessibility/ax_enum_util.cc | 4 + ui/accessibility/ax_enums.mojom | 430 +++++++++++---------- ui/accessibility/ax_node_data.cc | 1 + 10 files changed, 255 insertions(+), 218 deletions(-) commit 144505c8f8defd5ed0f912fffbdb98057d857a48 Author: Bret Sepulveda <bsep@chromium.org> Date: Fri Apr 19 20:35:24 2019 +0000 Disable WebKitHitTestTest#testUnknownTypeUnrecognizedNode. Test is flaky on Android CFI bot. TBR=changwan@chromium.org Bug: 954578 Change-Id: I325856bd34a5f86c47c9370fb32f718aeb45923a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575161 Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#652628} .../src/org/chromium/android_webview/test/WebKitHitTestTest.java | 2 ++ 1 file changed, 2 insertions(+) commit b52864d54b6ccf257499f9d8d6168f984920ac96 Author: Paul Miller <paulmiller@google.com> Date: Fri Apr 19 20:32:58 2019 +0000 Fix StrictMode violation Work around bug b/120099466 in Android < Q in which faild reflection causes disk reads. BUG=948308 Change-Id: I38ab4c55a9e11f2bb2a5153740894f9f4f6c88d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574940 Reviewed-by: Matthew Jones <mdjones@chromium.org> Commit-Queue: Paul Miller <paulmiller@chromium.org> Cr-Commit-Position: refs/heads/master@{#652627} .../src/org/chromium/ui/touchless/TouchlessEventHandler.java | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) commit 60a7838bebeff130cb33ad59eccee401e367f80a Author: Michael Giuffrida <michaelpg@chromium.org> Date: Fri Apr 19 20:26:47 2019 +0000 Add demo apps disclaimer to Demo Mode ARC++ setup Bug: 945438 Change-Id: I314f5aecb5e12fa17fc033b51af0305c80039b47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568310 Reviewed-by: Toni Baržić <tbarzic@chromium.org> Reviewed-by: Aga Wronska <agawronska@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Auto-Submit: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#652626} chrome/app/chromeos_strings.grdp | 3 ++ .../IDS_ARC_OOBE_TERMS_DIALOG_DEMO_APPS.png.sha1 | 1 + .../login/demo_mode/demo_setup_browsertest.cc | 48 +++++++++++++++++----- .../chromeos/login/arc_terms_of_service.css | 3 +- .../chromeos/login/arc_terms_of_service.html | 4 ++ .../login/arc_terms_of_service_screen_handler.cc | 1 + 6 files changed, 48 insertions(+), 12 deletions(-) commit 4371c7d5bb0621846df3b58f1000e13101b536dd Author: Johannes Henkel <johannes@chromium.org> Date: Fri Apr 19 20:23:34 2019 +0000 [DevTools] Switch to AppendString8EntryToCBORMap. Change-Id: I78a34f2375794dae7aa7b6fb9f8ae0a45c193b1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574953 Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#652625} content/browser/devtools/devtools_session.cc | 27 ++++++++++++++++----------- 1 file changed, 16 insertions(+), 11 deletions(-) commit ff61827cfc35687950a0eb7b2b3eb24ef8a69987 Author: James Cook <jamescook@chromium.org> Date: Fri Apr 19 20:22:02 2019 +0000 Remove unused function OSSettingsUI::RegisterProfilePrefs The prefs are all browser-settings-specific and are registered in SettingsUI::RegisterProfilePrefs(). Bug: none Test: compiles Change-Id: I6fc2610b834a66f5ae502963aac19c93e19de61b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574962 Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#652624} chrome/browser/ui/webui/settings/chromeos/os_settings_ui.cc | 12 ------------ chrome/browser/ui/webui/settings/chromeos/os_settings_ui.h | 8 ++------ 2 files changed, 2 insertions(+), 18 deletions(-) commit 1827ab31362864ef20f909dea5656e41d4a5504d Author: Dan Beam <dbeam@chromium.org> Date: Fri Apr 19 20:18:59 2019 +0000 Use a more common and easily parsed format for chrome-search://ntpicon Instead of using custom dir/like/things, let's use the more standard: ?param1=val1&param2=val2 Because it allows us to use URLSearchParams[1] in JS: url.searchParams.set('param1', 'val1'); And net::QueryIterator in C++: for (net::QueryIterator it(url); !it.IsAtEnd(); it.Advance()) { // use it.GetKey() and it.GetValue() } R=kristipark@chromium.org BUG=953962 [1] https://developer.mozilla.org/en-US/docs/Web/API/URLSearchParams Change-Id: I8159e0f6d70b35bc803e9e1064c67ee27a93244b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574690 Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by: Kristi Park <kristipark@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#652623} .../resources/local_ntp/most_visited_single.js | 12 +-- chrome/browser/search/ntp_icon_source.cc | 96 +++++++++------------- .../ui/search/local_ntp_browsertest_base.cc | 2 +- 3 files changed, 49 insertions(+), 61 deletions(-) commit dfc9201aff7c4945babdd7e0b346a18be9492b5c Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 19 20:18:33 2019 +0000 Roll src/third_party/catapult b60ce313b947..1ff0422ebea4 (1 commits) https://chromium.googlesource.com/catapult.git/+log/b60ce313b947..1ff0422ebea4 git log b60ce313b947..1ff0422ebea4 --date=short --no-merges --format='%ad %ae %s' 2019-04-19 crouleau@chromium.org [Telemetry] Provide full error for metrics calculation failure. Created with: gclient setdep -r src/third_party/catapult@1ff0422ebea4 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:953365 TBR=charliea@chromium.org Change-Id: I91e0b588adcadf869997787709f84bd331cfb82a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574642 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652622} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 16ab7b9f6404498742c2088d39d7f3839ba2ce8f Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 19 20:16:11 2019 +0000 Roll src/third_party/swiftshader 97035bde89e6..c9ca99eecf1d (1 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/97035bde89e6..c9ca99eecf1d git log 97035bde89e6..c9ca99eecf1d --date=short --no-merges --format='%ad %ae %s' 2019-04-19 chrisforbes@google.com Fix comment describing compare/exchange behavior Created with: gclient setdep -r src/third_party/swiftshader@c9ca99eecf1d The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: I43b1fba71a4a96aed9450163f4f95548c234448e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574217 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652621} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit a029725367d552dd068cebfad337994acd5efa10 Author: Mason Freed <masonfreed@chromium.org> Date: Fri Apr 19 20:11:12 2019 +0000 Make BGPT de-composite trivial transforms With this CL, "trivial" transforms, which only produce at most a 2d translation, will be de-composited if possible (see below). They will be replaced by an offset that is set on the cc::Layer in offset_to_transform_parent. With this change, the layer offset will be stored in ForeignLayerDisplayItem, so that it can be used to update the cc::Layer, and cc::Layer::SetOffsetToTransformParent() will be used in many fewer cases directly. The conditions required to de-composite a transform are: 1. It is not the root transform node. 2. It is a 2d translation only. 3. The transform is not used for scrolling - its ScrollNode() is nullptr. 4. It has no direct compositing reasons, other than k3DTransform. Note that if it has a k3DTransform reason, check #2 above ensures that it isn't really 3D. 5. It has FlattensInheritedTransform matching that of its direct parent. 6. It has backface visibility matching its direct parent. 7. No clips have local_transform_space referring to this transform node. 8. No effects have local_transform_space referring to this transform node. 9. All child transform nodes are also able to be de-composited. Bug: 952386,938563 Change-Id: I666e1609b48046372196c3864912a59e462bea77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568195 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#652620} .../core/animation/compositor_animations_test.cc | 4 +- .../core/exported/web_plugin_container_impl.cc | 5 +- .../blink/renderer/core/frame/local_frame_view.cc | 10 +- .../core/inspector/inspector_overlay_agent.cc | 2 +- .../paint/compositing/composited_layer_mapping.cc | 4 +- .../renderer/core/paint/html_canvas_painter.cc | 5 +- .../renderer/core/paint/link_highlight_impl.cc | 12 +-- .../renderer/core/paint/link_highlight_impl.h | 4 + .../core/paint/paint_property_tree_builder_test.cc | 4 +- .../blink/renderer/core/paint/video_painter.cc | 11 +- .../compositing/paint_artifact_compositor.cc | 115 ++++++++++++++++++++- .../compositing/paint_artifact_compositor.h | 5 + .../compositing/paint_artifact_compositor_test.cc | 16 +-- .../renderer/platform/graphics/graphics_layer.cc | 16 +-- .../renderer/platform/graphics/link_highlight.h | 5 + .../graphics/paint/foreign_layer_display_item.cc | 24 +++-- .../graphics/paint/foreign_layer_display_item.h | 10 +- .../graphics/paint/transform_paint_property_node.h | 39 +++++-- .../platform/testing/test_paint_artifact.cc | 5 +- .../platform/testing/test_paint_artifact.h | 3 +- ...rotate-then-clip-effect-interleave-expected.png | Bin 6579 -> 7146 bytes ...rotate-then-clip-effect-interleave-expected.png | Bin 0 -> 6579 bytes .../linux/media/video-zoom-controls-expected.png | Bin 62124 -> 62124 bytes .../media/video-zoom-controls-expected.png | Bin 62124 -> 62124 bytes .../media/video-zoom-controls-expected.png | Bin 60442 -> 60448 bytes .../media/video-zoom-controls-expected.png | Bin 60442 -> 60448 bytes .../mac/media/video-zoom-controls-expected.png | Bin 60440 -> 60446 bytes .../win/media/video-zoom-controls-expected.png | Bin 59480 -> 59482 bytes ...rotate-then-clip-effect-interleave-expected.png | Bin 0 -> 6579 bytes 29 files changed, 228 insertions(+), 71 deletions(-) commit a33dc03fc65b5d33b94380b4f0ab879a887c480c Author: Sinan Sahin <sinansahin@google.com> Date: Fri Apr 19 20:11:08 2019 +0000 Fix permission dialog icon color by calling #mutate() This CL fixes a bug where a tinted drawable would preserve its tint when the same drawable is used in a different dialog. This is fixed by making the drawable mutable. Bug: 954127 Change-Id: I66578ffc409d0e160d238b62680676a322bd8e3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574251 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#652619} .../chromium/chrome/browser/widget/TextViewWithCompoundDrawables.java | 1 + 1 file changed, 1 insertion(+) commit ac6308130d561190357c37d2e16ba35f6f60533f Author: Peter Boström <pbos@chromium.org> Date: Fri Apr 19 20:08:54 2019 +0000 Disable menu button for disabled extensions This removes the confusing behavior where a user clicks a button, expecting an action to happen, but there is no associated action so we would instead spawn a context menu. This now does not look like a clickable button (no hover state) and the three-dot menu is used to access the context menu for extensions without actions. Bug: chromium:943702 Change-Id: I9ae6fe7d549dd2dac2d003fb6f1fecdab66e9c83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575859 Reviewed-by: Collin Baker <collinbaker@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#652618} chrome/browser/ui/views/extensions/extensions_menu_button.cc | 1 + .../ui/views/extensions/extensions_menu_button_unittest.cc | 8 ++++++++ 2 files changed, 9 insertions(+) commit fa67541476ee32cac2754529bfb1cd51baa9927c Author: Piotr Bialecki <bialpio@chromium.org> Date: Fri Apr 19 20:08:24 2019 +0000 Add bialpio@ to OWNERS of xr-related directories Change-Id: I735de5c7f56cad4fec89dd3033ad6748a875ebee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575360 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Auto-Submit: Piotr Bialecki <bialpio@chromium.org> Reviewed-by: David Dorwin <ddorwin@chromium.org> Reviewed-by: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#652617} chrome/browser/android/vr/arcore_device/OWNERS | 3 +-- device/vr/OWNERS | 2 +- third_party/arcore-android-sdk/OWNERS | 2 +- third_party/webxr_test_pages/OWNERS | 1 + 4 files changed, 4 insertions(+), 4 deletions(-) commit 71d81f86c044fa78c6b524839208fa93e811b3c6 Author: Simon Pelchat <spelchat@chromium.org> Date: Fri Apr 19 20:06:15 2019 +0000 Make integration tests use the default_integration policy. The default_integration policy should be used when no exp= is otherwise specified to make sure that the GFE cache is not used. Bug: 950734 Change-Id: I6129845bed78f84175fb440003575f626431ccbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560454 Reviewed-by: Robert Ogden <robertogden@chromium.org> Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Simon Pelchat <spelchat@chromium.org> Cr-Commit-Position: refs/heads/master@{#652616} tools/chrome_proxy/webdriver/bypass.py | 3 +-- tools/chrome_proxy/webdriver/common.py | 16 ++++++++++++++++ tools/chrome_proxy/webdriver/compression_regression.py | 1 - tools/chrome_proxy/webdriver/https_previews.py | 3 +-- tools/chrome_proxy/webdriver/lite_page.py | 11 +++++------ tools/chrome_proxy/webdriver/safebrowsing.py | 2 ++ tools/chrome_proxy/webdriver/variations_combinations.py | 3 --- 7 files changed, 25 insertions(+), 14 deletions(-) commit 8e441a04c34d1c81626a0722ac190de4b4550632 Author: 3su6n15k.default@developer.gserviceaccount.com <3su6n15k.default@developer.gserviceaccount.com> Date: Fri Apr 19 19:57:18 2019 +0000 Automated Commit: LKGM 12105.0.0 for chromeos. BUG=762641 TBR=agawronska@google.com Change-Id: I26b7b542d8172a9743da9a2fc5bf404be25f3c06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574262 Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Reviewed-by: Aga Wronska <agawronska@chromium.org> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652615} chromeos/CHROMEOS_LKGM | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit d373f41e6314cb6155126a7c1a62372d6585a30a Author: Torne (Richard Coles) <torne@google.com> Date: Fri Apr 19 19:56:41 2019 +0000 Document system_webview_package_name arg better Improve the doc comment for the GN arg "system_webview_package_name" to mention that it controls TrichromeWebView as well as SystemWebView, and to explain more about why you might want to use it. Change-Id: I4c4c6e003416c9e2f39ab2492078baaa049237b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575732 Commit-Queue: Richard Coles <torne@chromium.org> Reviewed-by: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#652614} android_webview/system_webview_apk_tmpl.gni | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) commit 5a1d77cc5215e19f8f76513c5b6f0eb8334c6063 Author: Roman Sorokin <rsorokin@chromium.org> Date: Fri Apr 19 19:54:31 2019 +0000 DeviceStateMixin: Write owner key file TBR=xiyuan@chromium.org CQ-DEPEND=CL:1570024 Bug: 952855 Change-Id: I783e41a3c810764d8118dda3643f2a1964186966 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572405 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by: Toni Baržić <tbarzic@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#652613} .../login/existing_user_controller_browsertest.cc | 39 ++++++++-------------- .../chromeos/login/test/device_state_mixin.cc | 30 +++++++++++++++-- .../chromeos/login/test/device_state_mixin.h | 1 + .../chromeos/login/webview_login_browsertest.cc | 4 --- .../chromeos/policy/affiliation_test_helper.cc | 6 +++- .../policy/device_policy_cros_browser_test.cc | 9 ----- .../policy/device_policy_cros_browser_test.h | 4 --- .../display_resolution_handler_browsertest.cc | 1 - ...display_rotation_default_handler_browsertest.cc | 1 - .../system/device_disabling_browsertest.cc | 2 -- .../enterprise_device_attributes_apitest.cc | 1 + .../api/platform_keys/platform_keys_test_base.cc | 1 + 12 files changed, 49 insertions(+), 50 deletions(-) commit b49732536ca138cc96048eeae9e11fbd9f1931a3 Author: David Benjamin <davidben@chromium.org> Date: Fri Apr 19 19:52:46 2019 +0000 Roll src/third_party/boringssl/src 4a8c05ffe..e55c64fdd https://boringssl.googlesource.com/boringssl/+log/4a8c05ffe826c61d50fdf13483b35097168faa5c..e55c64fdd3f47413e17eaa8e4f4d2a62622a01eb Bug: none Change-Id: I0f0220cfd3cd3288281d85808645eca3dc7fefb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574296 Auto-Submit: David Benjamin <davidben@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#652612} DEPS | 2 +- third_party/boringssl/crypto_test_data.cc | 30 +++++++++++++++--------------- 2 files changed, 16 insertions(+), 16 deletions(-) commit 685403bc25f98418bc2ca9af370856d801ca9d75 Author: Brandon Wylie <wylieb@chromium.org> Date: Fri Apr 19 19:50:14 2019 +0000 Add Omnibox.SearchEngineType metric to Android omnibox searches Bug: 953893 Change-Id: Ic30e369768a6c154209ef7fdd9b881374b3f8f30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572534 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Reviewed-by: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#652611} .../omnibox/autocomplete_controller_android.cc | 3 +++ components/omnibox/browser/autocomplete_match.cc | 19 +++++++++++++++++++ components/omnibox/browser/autocomplete_match.h | 5 +++++ components/omnibox/browser/omnibox_edit_model.cc | 6 +----- 4 files changed, 28 insertions(+), 5 deletions(-) commit 778f6f3298ad73725e2570fac605637095a6fbeb Author: Dana Fried <dfried@chromium.org> Date: Fri Apr 19 19:42:49 2019 +0000 Record open bookmarks via middle-click. Affects folders in the bookmark folder as well as subfolders. We could also log this at the event source using the existing BookmarkBar_ContextMenu_OpenAll event, but since it's a click/gesture rather than a context menu action I created a new event type for it. Bug: 954254 Change-Id: I4ae18d9f2dbdda5448fdc3993e06b6ef76159570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574147 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#652610} chrome/browser/bookmarks/bookmark_stats.cc | 9 +++++++++ chrome/browser/bookmarks/bookmark_stats.h | 5 +++++ chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc | 2 +- tools/metrics/actions/actions.xml | 9 +++++++++ 4 files changed, 24 insertions(+), 1 deletion(-) commit 651a5c3bc178bd2361aef7a2241a5ff98a281032 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 19 19:37:29 2019 +0000 Roll src/third_party/angle fcc3ec31b83b..c467f7b54188 (1 commits) https://chromium.googlesource.com/angle/angle.git/+log/fcc3ec31b83b..c467f7b54188 git log fcc3ec31b83b..c467f7b54188 --date=short --no-merges --format='%ad %ae %s' 2019-04-19 spang@chromium.org Compute usage from format properties cache in glTexStorageMem2DEXT Created with: gclient setdep -r src/third_party/angle@c467f7b54188 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Ic5bd49ac7a44e0d08263f331d0d91e4a10d20803 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575656 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652609} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit a318c2beaa08c1fb9a1f0e2002bed942b3c5ab34 Author: Yuwei Huang <yuweih@chromium.org> Date: Fri Apr 19 19:36:56 2019 +0000 [remoting][FTL] FTL signaling integration into remoting_me2me_host * Implement a MuxingSignalStrategy to be used exclusively by JingleSessionManager to handle messages from both signal strategies. * Integrate all the signaling stuff into remoting_me2me_host, which can be enabled by passing a `--enable-ftl-signaling` flag. This has been tested with ftl_signaling_playground and I'm able to finish candidate exchange for ~99% of the attempt. I did see one DCHECK failure when JingleSession receives a duplicated message, but that will be tracked and fixed in a different bug/CL. Bug: 947337 Change-Id: Id6a6a183041a2668a0dd31deb735b01ceb4c4aec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565537 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#652608} remoting/host/remoting_me2me_host.cc | 103 +++++++++++++++------- remoting/signaling/BUILD.gn | 2 + remoting/signaling/ftl_signal_strategy.cc | 5 +- remoting/signaling/muxing_signal_strategy.cc | 124 +++++++++++++++++++++++++++ remoting/signaling/muxing_signal_strategy.h | 80 +++++++++++++++++ 5 files changed, 283 insertions(+), 31 deletions(-) commit 547bbd6a8a6501d71226c8feb4f94aaf50c16a08 Author: Jacob Dufault <jdufault@google.com> Date: Fri Apr 19 19:34:04 2019 +0000 cros: Move views for DemoSetup, Discover, Eula, Gaia, and Reset TBR=xiyuan@chromium.org TBR=rsorokin@chromium.org Bug: 928555 Change-Id: Iae26e383c7fe81cbd5a0bf638c432bf1947f77da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572234 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#652607} chrome/browser/chromeos/BUILD.gn | 6 --- .../chromeos/login/login_utils_browsertest.cc | 2 +- chrome/browser/chromeos/login/oobe_browsertest.cc | 2 +- .../chromeos/login/oobe_interactive_ui_test.cc | 2 +- .../chromeos/login/saml/saml_browsertest.cc | 2 +- .../chromeos/login/screens/demo_setup_screen.cc | 2 +- .../login/screens/demo_setup_screen_view.cc | 11 ----- .../login/screens/demo_setup_screen_view.h | 43 ---------------- .../chromeos/login/screens/discover_screen.cc | 2 +- .../chromeos/login/screens/discover_screen_view.h | 34 ------------- .../browser/chromeos/login/screens/eula_screen.cc | 2 +- chrome/browser/chromeos/login/screens/eula_view.h | 33 ------------- .../browser/chromeos/login/screens/gaia_screen.cc | 2 +- chrome/browser/chromeos/login/screens/gaia_view.h | 52 -------------------- .../login/screens/mock_demo_setup_screen.h | 2 +- .../chromeos/login/screens/mock_eula_screen.h | 2 +- .../browser/chromeos/login/screens/reset_screen.cc | 2 +- chrome/browser/chromeos/login/screens/reset_view.h | 57 ---------------------- .../session/chrome_session_manager_browsertest.cc | 2 +- .../chromeos/login/signin/device_id_browsertest.cc | 2 +- .../chromeos/login/signin/oauth2_browsertest.cc | 2 +- .../login/sync_consent_interactive_ui_test.cc | 2 +- .../chromeos/login/ui/login_display_host_common.cc | 2 +- .../chromeos/login/ui/login_display_host_mojo.cc | 2 +- .../chromeos/login/ui/login_display_host_webui.cc | 2 +- .../chromeos/login/ui/login_display_webui.cc | 2 +- .../chromeos/login/ui/oobe_ui_dialog_delegate.cc | 2 +- .../chromeos/policy/blocking_login_browsertest.cc | 2 +- .../chromeos/policy/login_policy_test_base.cc | 2 +- .../site_isolation_flag_handling_browsertest.cc | 2 +- ...er_cloud_policy_manager_chromeos_browsertest.cc | 2 +- ...rk_configuration_updater_factory_browsertest.cc | 2 +- .../ui/ash/kiosk_next_shell_client_browsertest.cc | 2 +- .../chromeos/login/demo_setup_screen_handler.cc | 2 + .../chromeos/login/demo_setup_screen_handler.h | 25 +++++++++- .../webui/chromeos/login/discover_screen_handler.h | 19 +++++++- .../ui/webui/chromeos/login/eula_screen_handler.h | 18 ++++++- .../ui/webui/chromeos/login/gaia_screen_handler.h | 31 +++++++++++- chrome/browser/ui/webui/chromeos/login/oobe_ui.cc | 1 - .../ui/webui/chromeos/login/reset_screen_handler.h | 40 ++++++++++++++- 40 files changed, 156 insertions(+), 268 deletions(-) commit 36a70210b32edaa7fbea69f43c91ef64839d77b8 Author: Dana Fried <dfried@chromium.org> Date: Fri Apr 19 19:30:34 2019 +0000 Separate logging event for when a bookmark is launched from app menu. Requested by Chronav logging initiative. See attached bug for details. Bug: 951906 Change-Id: Ia532b16cde546b3cbadc1c52cafc2503a452f9de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574601 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by: Mark Pearson <mpearson@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#652606} chrome/browser/bookmarks/bookmark_stats.cc | 6 +++++- tools/metrics/actions/actions.xml | 9 +++++++++ 2 files changed, 14 insertions(+), 1 deletion(-) commit 685475b42c36c1d568ecf16d13d72cc636e05764 Author: Frank Poole <frpoole@microsoft.com> Date: Fri Apr 19 19:30:09 2019 +0000 Add GetInnerRangeBoundsRect To AXPlatformNodeDelegate This change adds the GetInnerRangeBoundsRect interface to AXPlatformNodeDelegate. Similar to GetRangeBoundsRect, GetInnerRangeBoundsRect also calculates bounds for a range. Unlike GetRangeBoundsRect, GetInnerRangeBoundsRect accepts text offsets relative to GetInnerText in which text offsets on descendant nodes are included. This interface is intended for clients which calculate text offsets relative to GetInnerText, such as the UIA ITextRangeProvider implementation which relies on AXNodePosition. This change also adds values to the result of BrowserAccessibility::GetInnerText so that it has parity with AXNodePosition::GetInnerText. GetHypertext and GetInnerText interfaces are added to AXPlatformNodeDelegate although they are currently only implemented on BrowserAccessibility and its subclasses. Bug: 928948 Change-Id: I5607ee796a9f4bfc4352e43b2f7209200685b155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558708 Commit-Queue: Frank Poole <frpoole@microsoft.com> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#652605} .../accessibility_tree_formatter_android.cc | 2 +- .../android_granularity_movement_browsertest.cc | 2 +- .../browser/accessibility/browser_accessibility.cc | 244 ++++++++----- .../browser/accessibility/browser_accessibility.h | 51 ++- .../accessibility/browser_accessibility_android.cc | 26 +- .../accessibility/browser_accessibility_android.h | 6 +- .../browser_accessibility_auralinux.cc | 6 +- .../browser_accessibility_auralinux.h | 1 + .../accessibility/browser_accessibility_cocoa.mm | 16 +- .../accessibility/browser_accessibility_com_win.cc | 45 +-- .../accessibility/browser_accessibility_manager.cc | 56 +-- .../accessibility/browser_accessibility_manager.h | 4 +- .../browser_accessibility_manager_android.cc | 6 +- .../browser_accessibility_manager_unittest.cc | 78 +++-- .../browser_accessibility_position.cc | 4 +- .../accessibility/browser_accessibility_position.h | 2 +- .../browser_accessibility_unittest.cc | 390 +++++++++++++++++++++ .../accessibility/browser_accessibility_win.cc | 6 +- .../accessibility/browser_accessibility_win.h | 1 + .../web_contents_accessibility_android.cc | 17 +- ui/accessibility/ax_node_position.cc | 6 +- ui/accessibility/ax_node_position.h | 2 +- ui/accessibility/ax_node_position_unittest.cc | 34 +- ui/accessibility/ax_position.h | 12 +- ui/accessibility/ax_range.h | 16 +- .../platform/ax_platform_node_auralinux.cc | 44 +-- .../platform/ax_platform_node_auralinux.h | 4 +- ui/accessibility/platform/ax_platform_node_base.cc | 16 +- ui/accessibility/platform/ax_platform_node_base.h | 13 +- .../platform/ax_platform_node_delegate.h | 35 +- .../platform/ax_platform_node_delegate_base.cc | 19 +- .../platform/ax_platform_node_delegate_base.h | 13 +- ui/accessibility/platform/ax_platform_node_mac.mm | 4 +- ui/accessibility/platform/ax_platform_node_win.cc | 14 +- ui/accessibility/platform/ax_platform_node_win.h | 2 +- ui/accessibility/platform/test_ax_node_wrapper.cc | 2 +- ui/accessibility/platform/test_ax_node_wrapper.h | 2 +- 37 files changed, 884 insertions(+), 317 deletions(-) commit dfafd36dff25beedade8e799a6a0f41cf0df0463 Author: sczs <sczs@chromium.org> Date: Fri Apr 19 19:29:25 2019 +0000 [ios] Creates InfobarContainerCoordinator unittests. This CL also makes some improvements to InfobarContainerCoordinator so the test can pass: - isPresentingInfobarBanner is now directly based on the ChildCoordinator Banner presentation and not just the existence of a VC. - A disconnect method is added to make sure the mediator stops observing WebStateList before being dealloced (This is a common pattern throughout mediators since the memory de-alloaction order in unittest can cause this) - Adds a legacyContainerFullscrenSupportDisabled to disable FullScreen support in the legacyContainer. This is needed to avoid a crash after cleaning up each test case, in order to properly fix this we'd need to know when the legacyContainer has been dismissed, that would require some refactoring and the effort/risk is not worth it at this point. - Removes a DCHECK in the legacyContainer since now the count of total Infobars doesn't necessarily match the count of total Infobars in the legacy Container. This because one of them can be a message. The iOS implementation of the container was merely sending infobar.count() for position, meaning we were never using position anyways. Bug: 911864 Change-Id: Ie46c9dc88d2f5277401eb1d08aa54a09d4dbaf82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566756 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by: Peter Lee <pkl@chromium.org> Reviewed-by: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#652604} ios/chrome/browser/ui/infobars/BUILD.gn | 17 ++ .../ui/infobars/coordinators/infobar_coordinator.h | 4 + .../infobars/coordinators/infobar_coordinator.mm | 7 +- ios/chrome/browser/ui/infobars/infobar_constants.h | 4 + .../browser/ui/infobars/infobar_constants.mm | 2 + .../ui/infobars/infobar_container_coordinator.mm | 35 ++- .../infobar_container_coordinator_unittest.mm | 259 +++++++++++++++++++++ .../ui/infobars/infobar_container_mediator.h | 3 + .../ui/infobars/infobar_container_mediator.mm | 11 +- .../legacy_infobar_container_view_controller.h | 3 + .../legacy_infobar_container_view_controller.mm | 4 +- 11 files changed, 332 insertions(+), 17 deletions(-) commit c7f7bcc3005b7912c6858b0febaa1dedf048e842 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 19 19:26:32 2019 +0000 Roll src/third_party/chromite 726fdfaee1e0..7ef31b3e5b93 (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/726fdfaee1e0..7ef31b3e5b93 git log 726fdfaee1e0..7ef31b3e5b93 --date=short --no-merges --format='%ad %ae %s' 2019-04-19 jclinton@chromium.org Revert "chromeos-config: disable boards affected by crbug.com/954446" Created with: gclient setdep -r src/third_party/chromite@7ef31b3e5b93 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I043ed8d16da0a2d4db0082bb7f7770413a05cfcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575655 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652603} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 33c7ee83367a4b488d8024ac040d6f0a942db6ab Author: cjamcl@google.com <cjamcl@google.com> Date: Fri Apr 19 19:25:18 2019 +0000 [Devtools] Change Lighthouse throttling text to "Slow 4G". For terminology alignment with CruX. Bug: https://github.com/googlechrome/lighthouse/pull/6163 Change-Id: I90ebd73384947114f9b237f4afee3fdd4683db15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575823 Reviewed-by: Erik Luo <luoe@chromium.org> Reviewed-by: Paul Irish <paulirish@chromium.org> Commit-Queue: Paul Irish <paulirish@chromium.org> Commit-Queue: Connor Clark <cjamcl@google.com> Cr-Commit-Position: refs/heads/master@{#652602} .../blink/renderer/devtools/front_end/audits2/Audits2Controller.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 0c3d1b35a2e9aa2826a0bf4c7e05d646719c6a30 Author: Charlie Harrison <csharrison@chromium.org> Date: Fri Apr 19 19:25:07 2019 +0000 Remove the ad delay throttle This experiment has been disabled for a while. It should be pretty easy to reland if we decide we want to do it. Bug: 829042 Change-Id: I273d7a757312f1628ce3878e266311455eb73eb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574281 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Josh Karlin <jkarlin@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Auto-Submit: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#652601} .../subresource_filter/ad_delay_browsertest.cc | 222 -------- .../renderer/url_loader_throttle_provider_impl.cc | 14 - .../renderer/url_loader_throttle_provider_impl.h | 4 - chrome/test/BUILD.gn | 1 - .../subresource_filter/content/common/BUILD.gn | 3 - .../content/common/ad_delay_throttle.cc | 213 -------- .../content/common/ad_delay_throttle.h | 178 ------- .../content/common/ad_delay_throttle_unittest.cc | 572 --------------------- .../subresource_filter/content/renderer/BUILD.gn | 2 - .../ad_delay_renderer_metadata_provider.cc | 54 -- .../renderer/ad_delay_renderer_metadata_provider.h | 44 -- .../core/common/common_features.cc | 5 - 12 files changed, 1312 deletions(-) commit 7ff85f3e039ca8a67a5b1bc371a83647e2ba73a7 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 19 19:22:12 2019 +0000 Roll src/third_party/skia 847d55be4e62..377befab7175 (27 commits) https://skia.googlesource.com/skia.git/+log/847d55be4e62..377befab7175 git log 847d55be4e62..377befab7175 --date=short --no-merges --format='%ad %ae %s' 2019-04-19 michaelludwig@google.com Update compositing benchmark to use image-set API 2019-04-19 csmartdalton@google.com ccpr: Indicate path fill type by winding direction of cover triangles 2019-04-19 ethannicholas@google.com added error detection for writing to a constant swizzle mask 2019-04-19 kjlubick@google.com [spec] Initial commit for web spec 2019-04-19 ethannicholas@google.com Revert "Revert "added more SPIR-V RelaxedPrecision decorations"" 2019-04-19 reed@google.com use char-to-glyph cache in freetype typeface 2019-04-19 brianosman@google.com Remove SK_TREAT_COLINEAR_DIAGONAL_POINTS_AS_CONCAVE 2019-04-19 robertphillips@google.com Allow GrShadowRRectOp::Make to fail 2019-04-19 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset 2019-04-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 82bcffa78747..145ec7fa7c81 (10 commits) 2019-04-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader abaecd5f2ba7..a16238df3f28 (12 commits) 2019-04-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src f968f64cdf27..a55917cb9824 (433 commits) 2019-04-18 martin@mainframe.co.uk Properly retrieve memory block in SkTextUtils 2019-04-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-04-18 halcanary@google.com SkPDF: move type1 font code into single file 2019-04-18 csmartdalton@google.com Swap front and back stencil sides when rendering bottom-left 2019-04-18 bsalomon@google.com Swap x/y radii for EllipticalRRectOp depending on matrix. 2019-04-18 halcanary@google.com SkQP: consolidate cut_release scripts 2019-04-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-04-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-04-18 reed@google.com remove experimental from some APIs (that are no longer experiments) 2019-04-18 michaelludwig@google.com Fix quad type detection from SkPoint array 2019-04-18 brianosman@google.com Remove the axis-aligned vector special case to convexity checker 2019-04-18 ethannicholas@google.com fixed assertion failure in skslc SPIR-V output 2019-04-18 bungeman@google.com Make more SkTypeface virtuals pure. 2019-04-18 borenet@google.com [infra] Fixes for chrome_release_branch 2019-04-18 hcm@google.com Update Skia milestone to 76 Created with: gclient setdep -r src/third_party/skia@377befab7175 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:935198,chromium:946965 TBR=herb@chromium.org Change-Id: I23c6433ad9bc7d5e0982253667916e854515899c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575654 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652600} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 077246c70c7808e9674a89a7ac07cf4f8e38d427 Author: Bret Sepulveda <bsep@chromium.org> Date: Fri Apr 19 19:19:32 2019 +0000 Revert "Reland "Move loading of data URLs out of the network process."" This reverts commit 4dd1f3cedfa5022f5fa9d076c2a0b75165987b3b. Reason for revert: Failing on Linux ChromiumOS MSan Tests. Sorry... Example failures: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/12454 https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/12450 https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/12438 Original change's description: > Reland "Move loading of data URLs out of the network process." > > This is a reland of f45ff75d1ee932e8695a34269c264f93b77439e2 > > Original change's description: > > Move loading of data URLs out of the network process. > > > > For subresources the renderer was already loading it in-process. Now for navigations and downloads, we keep them in the browser process. This avoids: > > 1) sending GURLs bigger than 2MB to a different process, which strips them as they're bigger than url::kMaxURLChars > > 2) having the network process deal with a scheme that's not going over the network, which we avoid > > > > Bug: 937146, 939871 > > Change-Id: I8ca8225308b2a5f1f90594ab06943f0641a5c551 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570805 > > Commit-Queue: John Abd-El-Malek <jam@chromium.org> > > Reviewed-by: Ken Rockot <rockot@google.com> > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > Reviewed-by: David Trainor <dtrainor@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#652196} > > Bug: 937146, 939871 > Change-Id: I480da494a987c9b223c1a571821b35e3bdbc7447 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574881 > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#652335} TBR=kinuko@chromium.org,jam@chromium.org,rockot@google.com,dtrainor@chromium.org Change-Id: I5e8c075a625f94841328b207c22ab45da0a32082 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 937146, 939871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575864 Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#652599} chrome/browser/download/download_browsertest.cc | 64 ------------- .../network_context_configuration_browsertest.cc | 23 +++++ chrome/test/data/downloads/large_image.png | Bin 2096938 -> 0 bytes content/browser/BUILD.gn | 2 - content/browser/data_url_loader_factory.cc | 104 --------------------- content/browser/data_url_loader_factory.h | 47 ---------- content/browser/download/download_manager_impl.cc | 35 +++---- content/browser/download/save_file_manager.cc | 18 +--- .../browser/frame_host/render_frame_host_impl.cc | 4 - .../browser/loader/navigation_url_loader_impl.cc | 4 - .../service_worker/embedded_worker_instance.cc | 3 - .../worker_host/worker_script_fetch_initiator.cc | 3 - content/public/common/url_utils.cc | 3 +- services/network/network_context.cc | 9 +- services/network/network_context_unittest.cc | 7 +- .../public/cpp/simple_url_loader_unittest.cc | 23 ++++- 16 files changed, 69 insertions(+), 280 deletions(-) commit 83d369e64678095ad2be8be0af82b61542ae5221 Author: Bret Sepulveda <bsep@chromium.org> Date: Fri Apr 19 19:18:44 2019 +0000 Disable HeadlessProtocolCompositorBrowserTest suite on Windows. Other tests in the suite continued to flake overnight, so this patch disables the entire suite. TBR=caseq@chromium.org Bug: 954398 Change-Id: I6bacd513c9d32164091237da3443542474ea49eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575860 Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#652598} headless/test/headless_protocol_browsertest.cc | 57 +++++++------------------- 1 file changed, 14 insertions(+), 43 deletions(-) commit 9338c379f4b6809a396da3e805e6d9a4dbe46988 Author: Matt Menke <mmenke@chromium.org> Date: Fri Apr 19 19:16:49 2019 +0000 SpdySessionPool: Invoke request deleted callbacks more discriminately. Previously, we'd invoke them whenever any request was deleted or when a SpdySession is created. With this CL, we invoke them only when the first request is deleted or a SpdySession is created. This reduces the number of PostTasks and searches through std::maps when we have a bunch of requests all waiting on the creation of the same SpdySession. Bug: 912727 Change-Id: I5083137cf0726e3b1ddb3ac4608b706121964cbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570914 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#652597} net/http/http_stream_factory_job.cc | 6 +- net/spdy/spdy_session_pool.cc | 83 ++++++++------ net/spdy/spdy_session_pool.h | 63 +++++++---- net/spdy/spdy_session_pool_unittest.cc | 193 +++++++++++++++++++++++++++++++++ 4 files changed, 290 insertions(+), 55 deletions(-) commit 2c90c99c7b027ef156b8e7476faaaa761a1b9126 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 19 19:14:24 2019 +0000 Roll Fuchsia SDK from 891589959621 to 891573215845 The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ia32c76a1410538f92b334b289af3563bcc3dd95a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575653 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652596} build/fuchsia/linux.sdk.sha1 | 2 +- build/fuchsia/mac.sdk.sha1 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit 62640eb010707bf98c756c8c1159c4458ca9a988 Author: Miguel Casas-Sanchez <mcasas@chromium.org> Date: Fri Apr 19 19:10:53 2019 +0000 Follow up comments to crrev.com/c/1560384 - s/DECODE_COMPLETE_TIMESTAMP/DECODE_TIME/ - Moved place where that metadata is stamped. Bug: 950183 Change-Id: Iab34674090aaf0bc10e65ed0bee157a0aa63586a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575580 Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#652595} .../renderer/media/webrtc/media_stream_remote_video_source.cc | 5 ++--- media/base/video_frame_metadata.h | 2 +- media/filters/decoder_stream_traits.cc | 11 +++++------ .../blink/renderer/platform/graphics/video_frame_submitter.cc | 5 ++--- 4 files changed, 10 insertions(+), 13 deletions(-) commit 180f7762398afc97e32856522b61c283a7708fe0 Author: Michel Promonet <michel.promonet.1@gmail.com> Date: Fri Apr 19 19:08:57 2019 +0000 allow to cross-compile to armv6 without thumb crosscompiling on crossbuild-essential-armhf from ubuntu 18.04 for armv6 that doesnot support thumb fails reporting error: - sorry, unimplemented: Thumb-1 hard-float VFP ABI Change-Id: I2c6a5c6ae3c8af9ab168f6dbd281e2eb4e94f509 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565885 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#652594} AUTHORS | 1 + build/config/compiler/BUILD.gn | 3 +++ 2 files changed, 4 insertions(+) commit 51069b94ca9e512d66f9f39aca3fb5dd16b0ec82 Author: Maks Orlovich <morlovich@chromium.org> Date: Fri Apr 19 19:08:15 2019 +0000 resource_coordinator: Report services a process is running in memory dumps This is to permit splitting up reporting of network service from utility without it basically duplicating ProcessMap for its own -- and to avoid every future potential service wanting its own memory usage stats needing to do that (Audio service already does, but it does more with it). Bug: 947573 Change-Id: I0b036b4a6a4db1b5ae22e87ed4df08841a2b9820 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548680 Reviewed-by: Will Harris <wfh@chromium.org> Reviewed-by: oysteine <oysteine@chromium.org> Reviewed-by: ssid <ssid@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#652593} .../memory_instrumentation/coordinator_impl.cc | 14 ++++++++-- .../memory_instrumentation/coordinator_impl.h | 3 +++ .../coordinator_impl_unittest.cc | 30 ++++++++++++++++++++-- .../memory_instrumentation/process_map.cc | 9 +++++++ .../memory_instrumentation/process_map.h | 8 ++++++ .../memory_instrumentation/process_map_unittest.cc | 24 +++++++++++++++++ .../memory_instrumentation/queued_request.cc | 1 + .../memory_instrumentation/queued_request.h | 2 ++ .../queued_request_dispatcher.cc | 23 ++++++++++++++--- .../queued_request_dispatcher.h | 7 ++++- .../memory_instrumentation/global_memory_dump.h | 3 +++ .../memory_instrumentation.mojom | 5 ++++ 12 files changed, 120 insertions(+), 9 deletions(-) commit dbc13c5e90001542bf3cafdbd4196a30f6e7613c Author: Yuwei Huang <yuweih@chromium.org> Date: Fri Apr 19 19:05:09 2019 +0000 [remoting][gRPC] Prevent task from running after scoped stream is deleted Previously deleting the scoped stream will only prevent new tasks from being scheduled, and it doesn't drop pending tasks. This is a potential issue if the caller expect its method not to be called after the scoped stream is deleted. This CL fixes this by making the stream request check the scoped stream's validity before running the task. Bug: 927962 Change-Id: I6a43b21772b89231ee89a8def68ba40c2b50c821 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574893 Reviewed-by: Joe Downing <joedow@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#652592} .../grpc_async_server_streaming_request.cc | 38 ++++++++++++++++------ .../grpc_async_server_streaming_request.h | 18 +++++++--- .../base/grpc_support/scoped_grpc_server_stream.cc | 6 +++- .../base/grpc_support/scoped_grpc_server_stream.h | 3 ++ 4 files changed, 49 insertions(+), 16 deletions(-) commit c53f440c745adddd073818ee0c5cef46895c7031 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Fri Apr 19 19:05:05 2019 +0000 Roll src-internal 8c5646485a95..40beee366962 (4 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8c5646485a95..40beee366962 Created with: gclient setdep -r src-internal@40beee366962 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=fdoray@chromium.org,bsep@chromium.org,keishi@chromium.org,chanli@chromium.org Change-Id: I0749e1b27c27d453e3a46fabd0e893c46fc45f53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575652 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652591} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 2d14675bc792e2fc6b7f65cf014ff7fa490b41fa Author: Dana Fried <dfried@chromium.org> Date: Fri Apr 19 19:00:41 2019 +0000 Log bookmark clicks in bookmark folders and overflow. Previously, only top-level bookmark buttons were logged. Bug: 951899 Change-Id: I9480ed64186ddc068db9a3184363680596df5b46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572811 Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Mark Pearson <mpearson@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#652590} chrome/browser/bookmarks/bookmark_stats.cc | 36 +++++++++++++++++++----------- tools/metrics/actions/actions.xml | 8 +++++-- 2 files changed, 29 insertions(+), 15 deletions(-) commit 8eae73c4ee54972067c627d035ddb14ce86085c4 Author: Andrey Kosyakov <caseq@chromium.org> Date: Fri Apr 19 18:57:14 2019 +0000 DevTools: make session.navigate() wait for load of the frame that was actually navigated Change-Id: Ic81533da811793d655efca111ceb3629d14275d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574108 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#652589} .../inspector-protocol/page/frame-requested-navigation-subframe.js | 2 +- .../page/resources/frame-requested-navigation-subframe.html | 3 --- .../tests/inspector-protocol/resources/inspector-protocol-test.js | 5 +++-- .../dom-snapshot/dom-snapshot-getSnapshot-origin-url-expected.txt | 2 +- .../inspector-protocol/resources/dom-snapshot-origin-url.html | 1 + 5 files changed, 6 insertions(+), 7 deletions(-) commit a60324bd454227c1646a2ecb5687b97097d4d907 Author: Becky Zhou <huayinz@chromium.org> Date: Fri Apr 19 18:50:15 2019 +0000 Fix some status bar issues Fix two issues introduced by https://crrev.com/c/1568092 + Scrim status bar color on pre-L. The old "parity" logic does not work now that we calculate the status bar color instead of passing in a previously used status bar base color. + In tab grid switcher, the url focus percentage can change before #onObservingDifferentTab() is notified, so we need to avoid calling #updateStatusBarColor() in #onUrlExpansionPercentageChanged() with the out-of-date tab. Bug: 952752, 953665 Change-Id: I175b1e2d3136fd5dc190d4ec8cdba2f88888c23d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572702 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#652588} .../ui/system/StatusBarColorController.java | 27 ++++++++++++++++++++-- 1 file changed, 25 insertions(+), 2 deletions(-) commit 100781636d32b69ed6dfd0e9362fb42c0ac41aae Author: Brandon Wylie <wylieb@chromium.org> Date: Fri Apr 19 18:49:59 2019 +0000 [Touchless] Update news feed more button to match specs Using dialog_list_item layout to match the more button to specs. Bug: 937450 Change-Id: I3f5966a5a9f8fb47e9d674361b02a9913c89561c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559236 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by: Matthew Jones <mdjones@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#652587} .../chrome/browser/ntp/cards/ActionItem.java | 16 ++++-- .../browser/ntp/cards/NewTabPageAdapter.java | 8 +-- .../touchless/java/res/drawable/ic_note_add.xml | 14 ++++++ .../touchless/java/res/layout/dialog_list_item.xml | 3 +- .../touchless/TouchlessActionItemViewHolder.java | 58 ++++++++++++++++++++++ .../touchless/TouchlessNewTabPageAdapter.java | 12 +++++ .../touchless/java/strings/touchless_strings.grd | 3 ++ .../android/touchless/touchless_java_sources.gni | 1 + 8 files changed, 106 insertions(+), 9 deletions(-) commit 593f2a36bacc7240bc5250ad67827fca7d0dc870 Author: sczs <sczs@chromium.org> Date: Fri Apr 19 18:45:59 2019 +0000 [ios] Adds metrics for Recent Tabs Open All from remote devices. Bug: 953532 Change-Id: Icd9233feb6e2c0df92f81dd5bc58132aa61487ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574600 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#652586} .../ui/recent_tabs/recent_tabs_table_view_controller.mm | 6 ++++++ tools/metrics/actions/actions.xml | 7 +++++++ tools/metrics/histograms/histograms.xml | 10 ++++++++++ 3 files changed, 23 insertions(+) commit f708a67a4bb19634e5e95ec524dff56ac507ae55 Author: Elly Fong-Jones <ellyjones@google.com> Date: Fri Apr 19 18:43:03 2019 +0000 flags: assign cros-regions-mode Bug: None Change-Id: I198bd3b15ddc6e4f871c6de517c0a2bb3442979a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575718 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#652585} chrome/browser/flag-metadata.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit a1f66ac0c96c8b43fbfb76f14666ff13fb56a363 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 19 18:41:40 2019 +0000 Roll src/third_party/catapult 92d14c28e81b..b60ce313b947 (1 commits) https://chromium.googlesource.com/catapult.git/+log/92d14c28e81b..b60ce313b947 git log 92d14c28e81b..b60ce313b947 --date=short --no-merges --format='%ad %ae %s' 2019-04-19 benjhayden@chromium.org Migrate alerts-controls.js to es6 module Created with: gclient setdep -r src/third_party/catapult@b60ce313b947 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:950011 TBR=charliea@chromium.org Change-Id: I5e578e0db41462e33512f81214ede8f3f892e856 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575651 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652584} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 98ddfe1db86e73d323de24518a46b2b5b2dca67c Author: Hesen Zhang <hesen@google.com> Date: Fri Apr 19 18:35:32 2019 +0000 Update notification finch config Bug: 952354 Change-Id: I63d493056071d0677cb6d8ff506ab51625d6b74a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575020 Commit-Queue: Hesen Zhang <hesen@chromium.org> Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#652583} .../chrome/browser/omaha/UpdateConfigs.java | 24 +++++++++++++++------- 1 file changed, 17 insertions(+), 7 deletions(-) commit e68ea7ceb9e5c46e2bbd09b232e81c6c817c154a Author: Matthew Cary <mattcary@chromium.org> Date: Fri Apr 19 18:30:39 2019 +0000 mojo: Set correct exports for [Un]WrapPlatformSharedMemoryRegion. The previous crrev.com/c/1570829 did not set these, which are necessary to build some targets. Bug: 849207, 640840 Change-Id: Ibc2b3e315e8a3bee040cfb054a15b54901a4edbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575581 Auto-Submit: Matthew Cary <mattcary@chromium.org> Reviewed-by: Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#652582} mojo/public/cpp/system/platform_handle.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) commit 04a10d52aeda7cd7e773a5fd2096ba90be390092 Author: Becky Zhou <huayinz@chromium.org> Date: Fri Apr 19 18:25:08 2019 +0000 Fix location bar search icon having the wrong tint on tablet Intialize the colors properly in StatusMediator so that the icon tint is set correctly when tint update is never called. Bug: 953975 Change-Id: I21909656d412667dd8958738884c60879d4e1295 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575121 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#652581} .../src/org/chromium/chrome/browser/omnibox/status/StatusMediator.java | 1 + 1 file changed, 1 insertion(+) commit 778cf535d059f00c0aba39f3a794577c4173aa67 Author: Ahmed Mehfooz <amehfooz@chromium.org> Date: Fri Apr 19 18:24:28 2019 +0000 Move Common Pagination code out of AppList to ash/public/cpp Create AppListPaginationController Move PaginationController to ash/public/cpp/pagination/ Move PaginationModelObserver to ash/public/cpp/pagination/ Move PaginationModel to ash/public Bug: 914077 CQ Dry Run to ensure no unit tests broken Test: Manual Test to ensure Pagination and Pagination Metrics not broken Change-Id: I25a665fb59e252c63d369445e8225e7d6b73722e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564583 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#652580} ash/app_list/BUILD.gn | 6 ---- ash/app_list/app_list_metrics.cc | 25 ++++++++++++++++ ash/app_list/app_list_metrics.h | 3 ++ .../app_list_presenter_delegate_unittest.cc | 1 - ash/app_list/presenter/app_list_presenter_impl.cc | 2 +- ash/app_list/presenter/app_list_presenter_impl.h | 4 +-- ash/app_list/views/app_list_folder_view.cc | 2 +- ash/app_list/views/app_list_main_view.cc | 6 ++-- ash/app_list/views/app_list_main_view.h | 7 +++-- ash/app_list/views/app_list_view.cc | 4 +-- ash/app_list/views/app_list_view.h | 7 +++-- ash/app_list/views/app_list_view_unittest.cc | 4 +-- ash/app_list/views/apps_grid_view.cc | 20 ++++++------- ash/app_list/views/apps_grid_view.h | 17 ++++++----- ash/app_list/views/apps_grid_view_unittest.cc | 18 +++++------ ash/app_list/views/contents_view.cc | 6 ++-- ash/app_list/views/contents_view.h | 13 ++++---- ash/app_list/views/horizontal_page_container.cc | 12 ++++---- ash/app_list/views/horizontal_page_container.h | 18 ++++++----- ash/app_list/views/page_switcher.cc | 4 +-- ash/app_list/views/page_switcher.h | 14 +++++---- ash/app_list/views/search_result_tile_item_view.cc | 4 +-- ash/app_list/views/search_result_tile_item_view.h | 9 ++++-- ash/public/cpp/BUILD.gn | 6 ++++ .../cpp/pagination}/pagination_controller.cc | 35 ++++++++++------------ .../cpp/pagination}/pagination_controller.h | 29 ++++++++++-------- .../cpp/pagination}/pagination_model.cc | 10 ++++--- .../cpp/pagination}/pagination_model.h | 16 +++++----- .../cpp/pagination}/pagination_model_observer.h | 14 ++++----- .../cpp/pagination}/pagination_model_unittest.cc | 8 ++--- 30 files changed, 184 insertions(+), 140 deletions(-) commit 4a6d0cb5d56405a6ed35a21a298d1fabf5acdf56 Author: Theresa <twellington@chromium.org> Date: Fri Apr 19 18:16:54 2019 +0000 [Android] Update bottom system navigation colors BUG=953462 Change-Id: I937076dbdf0fc97da644bf73aaf3e79678bf215b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570588 Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#652579} chrome/android/java/res/values-v29/colors.xml | 9 +++++++++ chrome/android/java/res/values-v29/values.xml | 10 ++++++++++ .../chrome/browser/ui/system/NavigationBarColorController.java | 5 +++-- 3 files changed, 22 insertions(+), 2 deletions(-) commit aadaf27702eec8d60d93d0c03cdb1735fb93eafd Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Fri Apr 19 18:09:59 2019 +0000 Cross-Origin-Resource-Policy shouldn't apply to Save-Link-As downloads. This CL makes sure that download requests initiated by download::ResourceDownloader::Start use network::mojom::FetchRequestMode::kNavigate mode (rather than the default kNoCors mode). Bug: 952834 Change-Id: Ie99a4e024864f442e439e621d54ed7dae92f1393 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572876 Reviewed-by: David Trainor <dtrainor@chromium.org> Reviewed-by: Charlie Reis <creis@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#652578} chrome/browser/download/download_browsertest.cc | 70 ++++++++++++++++++++++ .../cross-origin-resource-policy-resource.txt | 1 + ...-resource-policy-resource.txt.mock-http-headers | 3 + .../cross-origin-resource-policy-test.html | 3 + .../download/internal/common/download_utils.cc | 6 ++ content/browser/frame_host/navigation_request.cc | 2 + 6 files changed, 85 insertions(+) commit 1a8158b40d09e043354bea24dd735c19201197d9 Author: Matthew Cary <mattcary@chromium.org> Date: Fri Apr 19 18:09:55 2019 +0000 trace_event: Clean up shared memory comments. The shared memory parts of ProcessMemoryDump apply to both legacy base::SharedMemory as well as the new *SharedMemoryRegion and *SharedMemoryMapping api. This change cleans up the comments but does not change any code. Bug: 795291 Change-Id: I3b88445ad04fe3b94996e5ff895110c5527df1cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1567665 Commit-Queue: Antoine Labour <piman@chromium.org> Auto-Submit: Matthew Cary <mattcary@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Reviewed-by: Alex Ilin <alexilin@chromium.org> Reviewed-by: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#652577} base/trace_event/process_memory_dump.h | 16 +++++++--------- gpu/command_buffer/service/transfer_buffer_manager.cc | 2 -- 2 files changed, 7 insertions(+), 11 deletions(-) commit 6e1bf270f70d18b5a29d219fe08a7e8effe6427a Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 19 18:05:37 2019 +0000 Roll src/third_party/chromite 666a00adb2b3..726fdfaee1e0 (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/666a00adb2b3..726fdfaee1e0 git log 666a00adb2b3..726fdfaee1e0 --date=short --no-merges --format='%ad %ae %s' 2019-04-19 jrosenth@chromium.org chromeos-config: disable boards affected by crbug.com/954446 Created with: gclient setdep -r src/third_party/chromite@726fdfaee1e0 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I506ca0472627f84c8cf897c687ce2a36083ceac7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575649 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652576} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit fc968b4aa3acaca95301aa3ae3067dfd131eac0f Author: sczs <sczs@chromium.org> Date: Fri Apr 19 18:02:50 2019 +0000 [ios] Removes position parameter from InfobarContainerConsumer. This parameter is not really needed since position is always the count of current Infobars, meaning it was always adding the Infobars in the last position: https://cs.chromium.org/chromium/src/components/infobars/core/ infobar_container.cc?type=cs&q=OnInfoBarAdded&sq=package:chromium&g=0&l=98 Also, since we now have 2 InfobarContainers a single one of them can't keep track of how many Infobars are presented, for that reason the DCHECK on legacy_infobar_container is no longer relevant. Bug: 911864 Change-Id: I47909d40af15f40d80f822de31f865fb732c8047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574289 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#652575} ios/chrome/browser/infobars/infobar_badge_tab_helper_unittest.mm | 3 +-- ios/chrome/browser/infobars/infobar_container_ios.mm | 4 ++-- ios/chrome/browser/ui/infobars/infobar_container_consumer.h | 6 ++---- ios/chrome/browser/ui/infobars/infobar_container_coordinator.mm | 3 +-- .../browser/ui/infobars/legacy_infobar_container_view_controller.mm | 6 ++---- 5 files changed, 8 insertions(+), 14 deletions(-) commit 24530db6754fd8c65d3044f4c16e9c518cf89d9d Author: Martin Robinson <mrobinson@igalia.com> Date: Fri Apr 19 18:01:59 2019 +0000 Add ATK popup-for accessibility relation This relation is used to map from a popup back to its owning element. Orca needs this in order to properly walk up the accessibility tree to find the parent frame of the popup. Bug: 948787 Change-Id: I88587be59149ea667dc071f699ea3b68814f0516 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556786 Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by: Emily Stark <estark@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#652574} .../browser/ui/views/omnibox/omnibox_popup_contents_view.cc | 12 ++++++++++-- .../browser/ui/views/omnibox/omnibox_popup_contents_view.h | 6 +++--- chrome/browser/ui/views/omnibox/omnibox_view_views.h | 4 ++-- .../ui/views/omnibox/omnibox_view_views_browsertest.cc | 7 +++++++ .../accessibility/accessibility_tree_formatter_blink.cc | 1 + ui/accessibility/ax_enum_util.cc | 4 ++++ ui/accessibility/ax_enums.mojom | 1 + ui/accessibility/ax_node_data.cc | 4 ++++ ui/accessibility/platform/ax_platform_node_auralinux.cc | 2 ++ 9 files changed, 34 insertions(+), 7 deletions(-) commit 8497a0430089323e3a242199990dff38765ba541 Author: Peter Kasting <pkasting@chromium.org> Date: Fri Apr 19 18:00:36 2019 +0000 Remove View::child_count(). Bug: 940135 TBR: wjmaclean Change-Id: Ibf2be7d23cbca593dc639e2f946c72d32466f18b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574943 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#652573} ash/media/media_notification_view.cc | 4 +--- .../chrome_mime_handler_view_browsertest.cc | 17 ++++++++--------- chrome/test/views/accessibility_checker.cc | 14 +++++--------- ui/views/view.h | 5 +---- 4 files changed, 15 insertions(+), 25 deletions(-) commit 099cff7ab4957e0593ef50669b05b56ce903285c Author: Matthew Cary <mattcary@chromium.org> Date: Fri Apr 19 17:58:42 2019 +0000 Mark RenderThread::HostAllocateSharedMemoryBuffer for deprecation. This is a change to a comment only. Bug: 795291 Change-Id: I3665a92f2132d6c7af7441828b4f18d276bbb5cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569217 Auto-Submit: Matthew Cary <mattcary@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#652572} content/public/renderer/render_thread.h | 3 +++ 1 file changed, 3 insertions(+) commit 38d5062a0e826817e3a85121110e10d36bb53888 Author: Joshua Pawlicki <waffles@chromium.org> Date: Fri Apr 19 17:57:40 2019 +0000 Set allow-CRX2 to default to false again. This appears to have been accidentally reverted to "true" in a bad merge. Bug: 740715 Change-Id: I6219ab58555b44b258b9e1af32d010ada33a34d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574945 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#652571} extensions/browser/extension_prefs.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 59ebd7d7d12313290c98a8400899054e79f4deb5 Author: Matt Mueller <mattm@chromium.org> Date: Fri Apr 19 17:56:40 2019 +0000 TrustStoreMac: Check if certificate is self-issued rather than self-signed. On macOS, there are two different trust settings granting positive trust - kSecTrustSettingsResultTrustRoot (root is explicitly trusted) and kSecTrustSettingsResultTrustAsRoot (non-root is explicitly trusted as if it were a root). The former "should" only apply to self-signed certificates, while the latter applies to those not self-signed (which includes self-issued certificates). The existing code was checking whether or not a certificate was self-signed, in order to determine which SecTrustSettingsResult it should be expecting. However, that also meant checking potentially weak signature algorithms on roots, which was failing, and thus causing the certificate to be treated as untrusted. As the signature algorithm on a root certificate should not matter, this change now only checks for self-issued (subject == issuer), rather than self-signed. This isn't 100% in line with Apple's documentation for these values, and is thus a bit of a hack. However, this should be OK, as the Apple APIs to set trust settings validate the consistency between configured trust setting and the type of certificate it is, preventing invalid trust records. This also removes the now-unused x509_util_mac IsSelfSigned function, as this was the only usage. Bug: 410574 Change-Id: Id7e12ed4f92da9cb4e0b8decf048e3cfc77bb06e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574879 Reviewed-by: Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#652570} net/cert/internal/trust_store_mac.cc | 41 ++++++++++++++++++++++++------------ net/cert/x509_util_mac.cc | 36 ------------------------------- net/cert/x509_util_mac.h | 3 --- 3 files changed, 27 insertions(+), 53 deletions(-) commit d6dd55c625b6a93ed5fe86c589ecaa102b595ee7 Author: Jacob Dufault <jdufault@google.com> Date: Fri Apr 19 17:55:58 2019 +0000 cros: Move some *View classes TBR=hidehiko@chromium.org Bug: 928555 Change-Id: I5a381a350533c429c0cf8051cb8e02a47e334cdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572275 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#652569} chrome/browser/chromeos/BUILD.gn | 4 -- .../chromeos/arc/arc_session_manager_unittest.cc | 2 +- .../optin/arc_terms_of_service_oobe_negotiator.cc | 2 +- .../login/screens/arc_terms_of_service_screen.cc | 2 +- .../screens/arc_terms_of_service_screen_view.h | 50 ---------------------- .../login/screens/assistant_optin_flow_screen.cc | 4 +- .../screens/assistant_optin_flow_screen_view.h | 37 ---------------- .../login/screens/demo_preferences_screen.cc | 2 +- .../login/screens/demo_preferences_screen_view.cc | 11 ----- .../login/screens/demo_preferences_screen_view.h | 39 ----------------- .../screens/mock_arc_terms_of_service_screen.h | 2 +- .../login/screens/mock_demo_preferences_screen.h | 2 +- .../login/arc_terms_of_service_screen_handler.h | 30 ++++++++++++- .../login/assistant_optin_flow_screen_handler.h | 24 ++++++++++- .../login/demo_preferences_screen_handler.cc | 2 + .../login/demo_preferences_screen_handler.h | 22 +++++++++- chrome/browser/ui/webui/chromeos/login/oobe_ui.cc | 1 - 17 files changed, 83 insertions(+), 153 deletions(-) commit f1903918401a46787edfd53ffcdf4e184f17bfc5 Author: Chromium WPT Sync <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Date: Fri Apr 19 17:53:16 2019 +0000 Import wpt@4657e102531b29ebfbf73b547693288c51c8b8c0 Using wpt-import in Chromium ed2d9eac87d8ccef5e447bc056f81e3d338b6466. With Chromium commits locally applied on WPT: 0a8f3ffa48 "Use testdriver Action API in WPT pointerevent touch tests - Part 2" 4e9215207a "[Code Health] Remove unnecessary reference file for web test" 40465b7400 "[Animation Worklet] Copy the effects of a migrating animator over to new global scope" e28269b698 "[LayoutNG/PE] Clear visual overflow for LayoutText before setting." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I8ae839ca8028a6e23c8530ab51663975c8d65f40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574283 Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652568} .../web_tests/external/WPT_BASE_MANIFEST_6.json | 11 +- .../web_tests/external/wpt/tools/lint/lint.py | 264 ++++++----------- .../web_tests/external/wpt/tools/lint/rules.py | 316 +++++++++++++++++++++ 3 files changed, 412 insertions(+), 179 deletions(-) commit 72af91004716d973f99dd3895073c566085838d3 Author: Donn Denman <donnd@chromium.org> Date: Fri Apr 19 17:52:48 2019 +0000 [TTS] Enable displaying non-search pages for TTS. Enables showing Google pages in the Contextual Search Overlay panel that are not Google Search pages. The canonical example is to show a maps page when a location is detected. Also add UrlUtilities.isGoogleSubdomainUrl. BUG=939460 Change-Id: I7c7b8f1095c421821e7fa810cba2ee55f0a47160 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574780 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#652567} .../contextualsearch/ContextualSearchRequest.java | 8 ++++++- .../chromium/chrome/browser/util/UrlUtilities.java | 6 +++++ chrome/browser/android/url_utilities.cc | 26 ++++++++++++++++++++++ 3 files changed, 39 insertions(+), 1 deletion(-) commit 9f88460d6540c4af75b24d2e4af7efce0f188220 Author: Khushal <khushalsagar@chromium.org> Date: Fri Apr 19 17:49:47 2019 +0000 blink/canvas: Correctly handle shared images in SkiaTextureHolder. Use the shared image extension for consuming mailboxes and take a read lock on the shared image until an SkImage wrapping this texture is alive to ensure correct scope for access, if the mailbox is backing a SharedImage. R=piman@chromium.org Bug: 948133 Change-Id: I4521f2098dc3fccf766e0690de0ea3a567d47e0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575083 Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#652566} .../graphics/accelerated_static_bitmap_image.cc | 7 +++++-- .../platform/graphics/skia_texture_holder.cc | 22 +++++++++++++++++++--- .../platform/graphics/skia_texture_holder.h | 10 ++++++---- 3 files changed, 30 insertions(+), 9 deletions(-) commit 2c89329fcb2d6b416386ad841bb79eefaa95f4f7 Author: Esmael El-Moslimany <aee@chromium.org> Date: Fri Apr 19 17:49:16 2019 +0000 User Manager WebUI: replace paper-icon-button with cr-icon-button Bug: 736891 Change-Id: Ib277323c8275ee7c7db351ad5a18e3a097eef76b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570544 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#652565} ui/login/account_picker/chromeos_user_pod_row.css | 19 +++++++------- .../account_picker/chromeos_user_pod_template.css | 4 +++ .../account_picker/chromeos_user_pod_template.html | 30 ++++++++++------------ ui/login/account_picker/user_pod_row.css | 18 +++++-------- ui/login/account_picker/user_pod_template.html | 7 ++--- 5 files changed, 37 insertions(+), 41 deletions(-) commit 2f24ab6bb2ee2742bc02de42b3c43977114c542b Author: khmel@chromium.org <khmel@chromium.org> Date: Fri Apr 19 17:48:00 2019 +0000 arc: Add custom event view. This analyzes tracing for custom events and includes it into graphics model. TEST=Locally BUG=b:122555793 Change-Id: I8ce3062764c54cc221ddd79b41a1939aeb6a0d39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574110 Commit-Queue: Yury Khmel <khmel@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#652564} .../arc/tracing/arc_tracing_graphics_model.cc | 65 ++++++++++++++++++++-- .../arc/tracing/arc_tracing_graphics_model.h | 7 +++ .../arc/tracing/arc_tracing_model_unittest.cc | 47 ++++++++++------ .../arc_graphics_tracing_ui.js | 18 +++++- chrome/test/data/arc_graphics_tracing/gm_good.json | 2 +- 5 files changed, 114 insertions(+), 25 deletions(-) commit b364990c6df69bca4a530e0d4dbb3601d8836429 Author: Hesen Zhang <hesen@google.com> Date: Fri Apr 19 17:45:59 2019 +0000 added Rename Dialogs' Action UMA Bug: 924751 Change-Id: Ia4c841be540e8ff276c87b4512adbd9ef1699436 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570236 Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by: Brian White <bcwhite@chromium.org> Commit-Queue: Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#652563} .../browser/download/home/metrics/UmaUtils.java | 27 ++++++++++++++++++++++ .../download/home/rename/RenameDialogManager.java | 25 +++++++++++++++++++- tools/metrics/histograms/enums.xml | 9 ++++++++ tools/metrics/histograms/histograms.xml | 10 ++++++++ 4 files changed, 70 insertions(+), 1 deletion(-) commit a0083530d7a78ef2a1bfd62d96859f118af666ca Author: Ilia Samsonov <isamsonov@google.com> Date: Fri Apr 19 17:37:59 2019 +0000 [Test Automation] Use xvfb directly instead of xvfb-run Thereby fix signal handling for SIGTERM and SIGINT. The steps needed to start Xvfb are drawn from: https://github.com/cgoldberg/xvfbwrapper/blob/master/xvfbwrapper.py https://github.com/revnode/xvfb-run/blob/master/xvfb-run Added unit tests to presubmit to test xvfb.py Bug: 932240 Change-Id: I3b9439991697ae94e98b93e4f1fcfd411a451536 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548424 Commit-Queue: Ilia Samsonov <isamsonov@google.com> Reviewed-by: Caleb Rouleau <crouleau@chromium.org> Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#652562} testing/PRESUBMIT.py | 2 + testing/test_env.py | 4 +- testing/xvfb.py | 182 ++++++++++++++++++++++++++++++++------------ testing/xvfb_test_script.py | 33 ++++++++ testing/xvfb_unittest.py | 108 ++++++++++++++++++++++++++ 5 files changed, 280 insertions(+), 49 deletions(-) commit 35343a65631b720d3732237b5a07028fd23d9770 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Fri Apr 19 17:25:12 2019 +0000 Roll src-internal 773c5423460e..8c5646485a95 (3 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/773c5423460e..8c5646485a95 Created with: gclient setdep -r src-internal@8c5646485a95 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=fdoray@chromium.org,bsep@chromium.org,keishi@chromium.org,chanli@chromium.org Change-Id: I667c18d93fd405dcc7e09a73f5d99c3697f2988b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575646 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652561} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit b7877786a4930a6d28b5693c2ada11be9d39d69b Author: Daniel Kay <danielkay@google.com> Date: Fri Apr 19 17:24:29 2019 +0000 Allow the libassistant project to use absl Expand the visibility restrictions to allow the libassistant project to depend on absl targets even when built in the context of chromium. Bug: b/119188101 Test: manually verified Change-Id: I518eb2ee85ba6186c81d7c28af2f7d81ab9e382b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572543 Reviewed-by: Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Daniel Kay <danielkay@google.com> Cr-Commit-Position: refs/heads/master@{#652560} third_party/abseil-cpp/absl/algorithm/BUILD.gn | 1 + third_party/abseil-cpp/absl/base/BUILD.gn | 1 + third_party/abseil-cpp/absl/container/BUILD.gn | 1 + third_party/abseil-cpp/absl/debugging/BUILD.gn | 1 + third_party/abseil-cpp/absl/hash/BUILD.gn | 1 + third_party/abseil-cpp/absl/memory/BUILD.gn | 1 + third_party/abseil-cpp/absl/meta/BUILD.gn | 1 + third_party/abseil-cpp/absl/numeric/BUILD.gn | 1 + third_party/abseil-cpp/absl/strings/BUILD.gn | 1 + third_party/abseil-cpp/absl/synchronization/BUILD.gn | 1 + third_party/abseil-cpp/absl/time/BUILD.gn | 1 + third_party/abseil-cpp/absl/time/internal/cctz/BUILD.gn | 1 + third_party/abseil-cpp/absl/types/BUILD.gn | 1 + third_party/abseil-cpp/absl/utility/BUILD.gn | 1 + 14 files changed, 14 insertions(+) commit 72c26c97c652be0e7110ff8432d7be7d6ff1f8b8 Author: Chris Hall <chrishall@chromium.org> Date: Fri Apr 19 17:23:31 2019 +0000 Fixing ChromeVox options page selector not updated as part crrev.com/f08ad04 crrev.com/f08ad04 changed the id from underscore-style to hyphen-style but did not update one of the selectors. R=dtseng,aboxhall,sarakato Bug: 928185 Change-Id: Ic5053d0f73b0d6793125ee9981b6b4719b205d6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565734 Auto-Submit: Chris Hall <chrishall@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#652559} .../resources/chromeos/chromevox/chromevox/background/options.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit b000283f7c4e18004ee4f4075f28738b86b1a127 Author: Min Chen <minch@google.com> Date: Fri Apr 19 17:20:12 2019 +0000 Flip the action of side volume button if necessary. Bug: 937907 Change-Id: Ib49153233e54cc6be09fff64a73fcd2e38bbbc93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566615 Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#652558} ash/accelerators/accelerator_controller.cc | 90 ++++++++++--- ash/accelerators/accelerator_controller.h | 18 ++- .../accelerator_controller_unittest.cc | 148 +++++++++++++++++++++ .../input_devices/input_device_client_test_api.cc | 8 ++ .../input_devices/input_device_client_test_api.h | 1 + ui/base/accelerators/accelerator.h | 2 +- 6 files changed, 249 insertions(+), 18 deletions(-) commit 50296b02a8424ef839cf5202d8bffc6546194836 Author: Sinan Sahin <sinansahin@google.com> Date: Fri Apr 19 17:19:52 2019 +0000 Update editor dropdown text and error icon colors Bug: 953103, 953105 Change-Id: I576f1098f25f03c1e60017a1da25815032b79f57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574247 Reviewed-by: Becky Zhou <huayinz@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#652557} chrome/android/java/res/drawable/ic_error.xml | 15 +++++++++++++++ .../browser/widget/prefeditor/EditorDropdownField.java | 14 +++++++++++++- .../browser/widget/prefeditor/HintedDropDownAdapter.java | 3 +-- 3 files changed, 29 insertions(+), 3 deletions(-) commit ac4622a3707cf80ba1407af65ab791d57e7dfe62 Author: Ramin Halavati <rhalavati@chromium.org> Date: Fri Apr 19 17:12:42 2019 +0000 Update SandboxPrioritizedOriginDatabase to respect incognito. Sandbox prioritized origin database creates an on-disk file for the prioritized origin. This is disabled for in-memory file system to avoid writing file mappings to the disk. Bug: 93417 Change-Id: Ie6a251e7fae40b513bc2247ce07e09052ce469a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572401 Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Auto-Submit: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#652556} storage/browser/fileapi/sandbox_prioritized_origin_database.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) commit 82153a5d8edabe32bb38f60847621abbe887cced Author: James Cook <jamescook@chromium.org> Date: Fri Apr 19 17:08:12 2019 +0000 chromeos: Fix renderer locale cache for non-device-owner users When the device owner changes the locale, the new value is stored in both local state and a profile pref. However, when a non-owner changes the locale, the value is only stored in profile prefs. Bug: 510455 Change-Id: I3acbff94896c0aa96c7ce09af7e1d4b2ca752290 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575682 Reviewed-by: Ken Rockot <rockot@google.com> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#652555} chrome/browser/chromeos/chrome_browser_main_chromeos.cc | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) commit d850caad93d5c09342a499dd134ec999b5a224e4 Author: Bill Budge <bbudge@chromium.org> Date: Fri Apr 19 17:04:14 2019 +0000 Revert "[ppapi] Remove PPB_TrueTypeFont resource." This reverts commit a10bfe51237589f382d894a35c9301f84a8e6b53. Reason for revert: Breaks deterministic build product check (expectations need to be adjusted.) https://ci.chromium.org/p/chromium/builders/ci/Deterministic%20Linux/22416 Original change's description: > [ppapi] Remove PPB_TrueTypeFont resource. > > - UMA shows this interface has no usage. > > Change-Id: Ifcb68620aceab0d8a857b4a3a0c768990bf47905 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546762 > Commit-Queue: Bill Budge <bbudge@chromium.org> > Reviewed-by: Raymes Khoury <raymes@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Sam Clegg <sbc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#652404} TBR=raymes@chromium.org,sky@chromium.org,bbudge@chromium.org,sbc@chromium.org,binji@chromium.org,tsepez@chromium.org Change-Id: Iec735dd2220b443b0e8fddc93c7795e46dc7c0f3 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574294 Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#652554} chrome/common/ppapi_utils.cc | 1 + chrome/test/ppapi/ppapi_browsertest.cc | 8 + content/browser/BUILD.gn | 17 + .../pepper/content_browser_pepper_host_factory.cc | 21 + .../renderer_host/pepper/pepper_truetype_font.h | 57 +++ .../pepper/pepper_truetype_font_host.cc | 153 ++++++++ .../pepper/pepper_truetype_font_host.h | 72 ++++ .../pepper/pepper_truetype_font_linux.cc | 158 ++++++++ .../pepper/pepper_truetype_font_list.h | 36 ++ .../pepper/pepper_truetype_font_list_host.cc | 113 ++++++ .../pepper/pepper_truetype_font_list_host.h | 28 ++ .../pepper/pepper_truetype_font_list_mac.mm | 83 ++++ .../pepper/pepper_truetype_font_list_ozone.cc | 20 + .../pepper/pepper_truetype_font_list_pango.cc | 65 +++ .../pepper/pepper_truetype_font_list_win.cc | 91 +++++ .../pepper/pepper_truetype_font_mac.mm | 415 ++++++++++++++++++++ .../pepper/pepper_truetype_font_win.cc | 241 ++++++++++++ .../pepper/pepper_in_process_resource_creation.cc | 7 + .../pepper/pepper_in_process_resource_creation.h | 3 + .../renderer/pepper/pepper_plugin_instance_impl.cc | 1 + content/renderer/pepper/plugin_module.cc | 1 + content/test/ppapi/ppapi_browsertest.cc | 8 + native_client_sdk/src/libraries/ppapi/library.dsc | 1 + .../src/libraries/ppapi_cpp/library.dsc | 2 + ppapi/BUILD.gn | 2 + ppapi/api/dev/ppb_truetype_font_dev.idl | 276 +++++++++++++ ppapi/c/dev/ppb_truetype_font_dev.h | 301 ++++++++++++++ ppapi/cpp/BUILD.gn | 2 + ppapi/cpp/dev/truetype_font_dev.cc | 156 ++++++++ ppapi/cpp/dev/truetype_font_dev.h | 274 +++++++++++++ .../src/untrusted/pnacl_irt_shim/pnacl_shim.c | 58 +++ ppapi/proxy/BUILD.gn | 4 + ppapi/proxy/interface_list.cc | 1 + ppapi/proxy/ppapi_messages.h | 35 ++ ppapi/proxy/ppapi_param_traits.cc | 31 ++ ppapi/proxy/ppapi_param_traits.h | 12 + ppapi/proxy/ppb_instance_proxy.cc | 4 + ppapi/proxy/resource_creation_proxy.cc | 9 + ppapi/proxy/resource_creation_proxy.h | 3 + ppapi/proxy/serialized_structs.cc | 34 ++ ppapi/proxy/serialized_structs.h | 25 ++ ppapi/proxy/truetype_font_resource.cc | 164 ++++++++ ppapi/proxy/truetype_font_resource.h | 89 +++++ ppapi/proxy/truetype_font_singleton_resource.cc | 124 ++++++ ppapi/proxy/truetype_font_singleton_resource.h | 68 ++++ ppapi/shared_impl/resource.h | 2 + ppapi/shared_impl/singleton_resource_id.h | 1 + ppapi/tests/all_c_includes.h | 1 + ppapi/tests/test_truetype_font.cc | 436 +++++++++++++++++++++ ppapi/tests/test_truetype_font.h | 37 ++ ppapi/thunk/BUILD.gn | 3 + ppapi/thunk/interfaces_ppb_public_dev.h | 4 +- ppapi/thunk/ppb_pdf_thunk.cc | 4 +- ppapi/thunk/ppb_truetype_font_api.h | 38 ++ ppapi/thunk/ppb_truetype_font_dev_thunk.cc | 108 +++++ ppapi/thunk/ppb_truetype_font_singleton_api.h | 42 ++ ppapi/thunk/resource_creation_api.h | 4 + tools/ipc_fuzzer/fuzzer/fuzzer.cc | 9 + tools/metrics/histograms/enums.xml | 2 +- 59 files changed, 3959 insertions(+), 6 deletions(-) commit c48c5fbf5c78a26db5a04e052670361dc4a49bc4 Author: Mitsuru Oshima <oshima@chromium.org> Date: Fri Apr 19 17:03:08 2019 +0000 Allow smooth resizing when multi resizing windows Bug: 954510 Test: covered by unittest Change-Id: I954bd6b9b928b5d765e0d646cf77ebb6fca3745a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574285 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#652553} ash/wm/workspace/multi_window_resize_controller_unittest.cc | 11 +++++++++++ ash/wm/workspace/workspace_window_resizer.cc | 4 ++++ 2 files changed, 15 insertions(+) commit 8c874906c66b3fd37d2c9191eb833e9bfa6bbcb0 Author: Eugene But <eugenebut@chromium.org> Date: Fri Apr 19 16:53:56 2019 +0000 Correctly disable flaky tests on device. These tests are not failed on simulator and should only be disabled on devices. Also Added TODOs that reference the bugs. Bug: 954231, 954232 Change-Id: If1aa247e5686211187fddbc1b82c8051f71ab4d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574287 Auto-Submit: Eugene But <eugenebut@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#652552} ios/web/web_state/error_page_inttest.mm | 8 +++++++- ios/web/web_state/web_state_observer_inttest.mm | 8 +++++++- 2 files changed, 14 insertions(+), 2 deletions(-) commit 70e82bb324f5195ebaa6d160181246e019b08b09 Author: Frank Kastenholz <fkastenholz@chromium.org> Date: Fri Apr 19 16:51:41 2019 +0000 Roll src/net/third_party/quiche/src/ 3f0f67930..075a3dbe8 (8 commits) https://quiche.googlesource.com/quiche.git/+log/3f0f679307af..075a3dbe833c $ git log 3f0f67930..075a3dbe8 --date=short --no-merges --format='%ad %ae %s' 2019-04-19 fkastenholz Fix test so it compiles in chromium 2019-04-19 fayang gfe-relnote: In QUIC, terminate Google QUIC connections (<= v43) similar as IETF QUIC connection. Protected by gfe2_reloadable_flag_quic_terminate_gquic_connection_as_ietf. 2019-04-18 renjietang Change HTTP/3 frame type from 1 byte integer to variable length integer, and allow partial delivery. 2019-04-18 quiche-dev Inject a random number generator into QuartcEndpoint and SendAlgorithms. 2019-04-18 dschinazi Do not ACK when encryption keys are missing 2019-04-18 danzh gfe-relnote: n/a(test only code) switch from unordered_set to multimap. 2019-04-18 danzh gfe-relnote: n/a(code clean up) Inline WallTimeNowInUsec(). 2019-04-18 danzh gfe-relnote: n/a(code clean up) make epoll_server_test.cc platform independent. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src R=rch@chromium.org Change-Id: Ia235dd52984c098af6b754bc4790b5550d0be7e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575680 Reviewed-by: Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Frank Kastenholz <fkastenholz@chromium.org> Cr-Commit-Position: refs/heads/master@{#652551} DEPS | 2 +- net/quic/quic_flags_list.h | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) commit cb55cc49de2d106102e6355525cc8fe22c0b4f6a Author: Nico Weber <thakis@chromium.org> Date: Fri Apr 19 16:49:30 2019 +0000 win/libc++/natvis: Add support for many containers. Adds visualizers for: - array - deque - forward_list - initializer_list - list - multimap - multiset - priority_queue - queue - set - stack Also: - slightly improve the map visualizer to cast the size to the right type in all cases, so that it shows with a type like "unsigned int" and not some __compressed_pair - add a DisplayString to vector Bug: 947911 Change-Id: I547d8ccdf27377f91913ff73d639fc826967a0c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575679 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#652550} tools/win/DebugVisualizers/libc++.natvis | 175 ++++++++++++++++++++++++++++++- 1 file changed, 170 insertions(+), 5 deletions(-) commit a5f1dbd35a6ad198977311c036397ca47632082a Author: Dan Harrington <harringtond@chromium.org> Date: Fri Apr 19 16:47:51 2019 +0000 switch owners to chromium.org account Change-Id: I516016274fa18099048858d3be0df32bb4a50f88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574783 Reviewed-by: Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#652549} components/offline_pages/OWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit f55a1bb6cb9d06e735902f100b7398ea23f1e027 Author: Caleb Raitto <caraitto@chromium.org> Date: Fri Apr 19 16:31:51 2019 +0000 [Cronet] Rename reportFinished() to reportRequestFinished(). This is the Java-side followup to the rename request in the native API made here [1]. [1] https://crrev.com/c/1496296/26/components/cronet/native/engine.h#71 Bug: 879208 Change-Id: I0eb0bcc8c7e7f1a2376c271e45f56b9f457c22f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574227 Reviewed-by: Paul Jensen <pauljensen@chromium.org> Reviewed-by: Misha Efimov <mef@chromium.org> Commit-Queue: Caleb Raitto <caraitto@chromium.org> Cr-Commit-Position: refs/heads/master@{#652548} .../java/src/org/chromium/net/impl/CronetBidirectionalStream.java | 2 +- .../cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java | 2 +- .../android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) commit 9bdce258ade342f621d1f7f7b48412607c88dbb4 Author: Chan Li <chanli@chromium.org> Date: Fri Apr 19 16:16:27 2019 +0000 Revert "blink/bindings: Check that decompression is correct, and add UTF-16 testing." This reverts commit 8ca571cb6ddefcc76906bffa17fd1159709a5de5. Reason for revert: This change caused blink_platform_unittests failing on multiple builders sample build: https://analysis.chromium.org/waterfall/failure?url=https://ci.chromium.org/p/chromium/builders/ci/Win%207%20Tests%20x64%20%281%29/52324 Original change's description: > blink/bindings: Check that decompression is correct, and add UTF-16 testing. > > There are crashes in ParkableString decompression, which are assumed to be OOM > conditions. Add a check to make sure this is the case, and add testing for UTF16 > strings to make sure that this doesn't instead come from such strings. > > Bug: 946203 > Change-Id: Iaafde8c3c7b9c79bf87de67e6c5de5b71e1a310a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575499 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Benoit L <lizeb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#652513} TBR=haraken@chromium.org,lizeb@chromium.org Change-Id: Id697c7df2b13d7ff8a40e68a80b3189600f781c4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 946203 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574286 Reviewed-by: Chan Li <chanli@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#652547} .../renderer/platform/bindings/parkable_string.cc | 11 +++----- .../platform/bindings/parkable_string_test.cc | 30 ---------------------- 2 files changed, 4 insertions(+), 37 deletions(-) commit ae59440acd6136d645d5bfceb298da0b290274f6 Author: Sergey Kuznetsov <kuznetsovs@yandex-team.ru> Date: Fri Apr 19 16:08:05 2019 +0000 Create PatchService on Android. Android already depends on 'update_client' component. 'update_client' component uses 'patch::Patch' in 'DeltaUpdateOpPatch::DoRun'. But the underlying service for 'patch::Patch' - PatchService isn't create for Android (btw it is declared in manifest and it is required capability). This CL fixes this issue by creating PatchService on Android. Change-Id: I011e80833a48bf755006d9c6d9a3133aed287ed4 Bug: 948169 Binary-Size: Increase needed to support delta updates in 'component_update' component on Android. To properly support delta updates the whole library ("//components/services/patch:lib") is needed. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541095 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by: Ken Rockot <rockot@google.com> Reviewed-by: David Trainor <dtrainor@chromium.org> Reviewed-by: Joshua Pawlicki <waffles@chromium.org> Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#652546} .../android/download/download_manager_service.cc | 9 +++ .../android/download/download_manager_service.h | 3 + chrome/browser/chrome_content_browser_client.cc | 4 +- chrome/browser/services_unittest.cc | 68 ++++++++++++++++++++++ chrome/test/BUILD.gn | 1 + chrome/utility/BUILD.gn | 2 +- chrome/utility/chrome_content_utility_client.cc | 10 ++-- content/public/test/test_utils.cc | 49 ++++++++++------ content/public/test/test_utils.h | 8 ++- 9 files changed, 125 insertions(+), 29 deletions(-) commit e312259ff5be11bfa8c67aebb519cb6564a35903 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Fri Apr 19 15:50:52 2019 +0000 Roll src-internal 3126b113b51e..773c5423460e (2 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3126b113b51e..773c5423460e Created with: gclient setdep -r src-internal@773c5423460e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=fdoray@chromium.org,bsep@chromium.org,keishi@chromium.org,chanli@chromium.org Change-Id: I85a09ebd5ed9b91db18246033275aa6c5a0ebbd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575643 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652545} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 76776698bbe67fd71d836b3433600c0b560d63a6 Author: Javier Ernesto Flores Robles <javierrobles@chromium.org> Date: Fri Apr 19 15:47:43 2019 +0000 [iOS][Alert] Add insets for the message and title Bug: 951359, 951300 Change-Id: I838be733ab333b437f2ee22694207b52ef73d40d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575500 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#652544} .../alert_view_controller/alert_view_controller.mm | 50 ++++++++++++++-------- ios/chrome/common/ui_util/constraints_ui_util.h | 6 +++ ios/chrome/common/ui_util/constraints_ui_util.mm | 10 +++++ 3 files changed, 49 insertions(+), 17 deletions(-) commit ed2d9eac87d8ccef5e447bc056f81e3d338b6466 Author: Toni Barzic <tbarzic@chromium.org> Date: Fri Apr 19 15:42:22 2019 +0000 Make IdentityAccessorImpl scoped to IdentityService IdentityAccessorImpl uses and observes identity manager, which is scoped to profile, so it should not outlive the profile it's assigned to (before this IdentityAccessorImpl instances were leaked, never removed themselves from IdentityManager observer list, and were causing DCHECK failures during IdentityManager's observer_list_) BUG=None Change-Id: I6d7966d0d2a2db859c08e9a938a3cf73302ee37a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573169 Reviewed-by: Colin Blundell <blundell@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#652543} services/identity/identity_accessor_impl.cc | 20 ++------------------ services/identity/identity_accessor_impl.h | 12 +----------- services/identity/identity_service.cc | 5 ++++- services/identity/identity_service.h | 7 +++++++ 4 files changed, 14 insertions(+), 30 deletions(-) commit 4671054f75084ec987c461701887cd8a25c00f03 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Fri Apr 19 15:39:53 2019 +0000 Simplify AuthenticationService implementation Change internal implementation of two methods of AuthenticationService to remove unnecessary allocations. 1. AuthenticationService::MigrateAccountsStoredInPrefsIfNeeded is only interested in whether the system has stored refresh token for an account by account_id, so use HasAccountWithRefreshToken instead of fetching the whole AccountInfo 2. AuthenticationService::ReloadCredentialsFromIdentities only need to check whether the system has a primary account set, and is not interested in the email address, so use IsAuthenticated instead of GetAuthenticatedUserEmail Bug: none Change-Id: If5de15711ef2d2d96dc935162b11aa17c4b245fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569122 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#652542} ios/chrome/browser/signin/authentication_service.mm | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) commit a76905422d2093956ee2810db0b10106e4ee1fda Author: Paul Jensen <pauljensen@chromium.org> Date: Fri Apr 19 15:36:29 2019 +0000 [Cronet] add script to symbolicate stack traces Change-Id: I6127ef918487ba441a5b7f2b86d83d609aa83ad2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574378 Reviewed-by: Misha Efimov <mef@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#652541} components/cronet/tools/symbolicate.sh | 69 ++++++++++++++++++++++++++++++++++ 1 file changed, 69 insertions(+) commit 0e87e869181664d9570142b0bf52ca2d596afafa Author: sczs <sczs@chromium.org> Date: Fri Apr 19 15:21:53 2019 +0000 [ios] Enhances TableViewTextButton to work with the Passwords Infobar Modal Makes changes to TableViewTextButton so it can be used with the Password Infobar Modal. Adds these buttons to InfobarPasswordTableViewController and hooks them to their actions. Screenshot: https://drive.google.com/open?id=1CAJc2tT_oyL9Xyrm6b6krtZo1fxcey7T Bug: 945478 Change-Id: Iadfdec6081a5742ec786102e040cf7a38396c17b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572962 Reviewed-by: Peter Lee <pkl@chromium.org> Reviewed-by: Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#652540} .../coordinators/infobar_password_coordinator.mm | 10 ++ ios/chrome/browser/ui/infobars/modals/BUILD.gn | 2 +- .../modals/infobar_password_modal_delegate.h | 4 + .../infobar_password_table_view_controller.h | 4 + .../infobar_password_table_view_controller.mm | 38 +++++-- .../infobar_modal_presentation_controller.mm | 2 +- .../settings/table_cell_catalog_view_controller.mm | 37 ++++++- .../table_view/cells/table_view_text_button_item.h | 19 ++++ .../cells/table_view_text_button_item.mm | 115 +++++++++++++++------ 9 files changed, 187 insertions(+), 44 deletions(-) commit d6198c6c02b84a7a917acbd5a236c633c98b979c Author: Javier Ernesto Flores Robles <javierrobles@chromium.org> Date: Fri Apr 19 15:11:30 2019 +0000 Reland "[iOS][Alert] Add alert controller to Showcase" This reverts commit 7eacffe7807333a6a2407aeb7f13a4734fec3cdf. Reason for revert: Underlying issue has been fix. Original change's description: > Revert "[iOS][Alert] Add alert controller to Showcase" > > This reverts commit 2410dcb91e53dec59d02a983a5a4c186bc1d854d. > > Reason for revert: Bug 954134 > > Original change's description: > > [iOS][Alert] Add alert controller to Showcase > > > > Bug: 951301, 951300 > > Change-Id: If0af93103f0038ad35770cee09b94b455aeca92b > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561109 > > Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> > > Reviewed-by: edchin <edchin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#652122} > > TBR=edchin@chromium.org,javierrobles@chromium.org > > Bug: 954134 > Change-Id: I4f4d441cf3fa9ea5651a0b0bc01ef41e9bd0f277 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 951301, 951300 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573639 > Reviewed-by: François Doray <fdoray@chromium.org> > Commit-Queue: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#652127} TBR=fdoray@chromium.org,edchin@chromium.org,javierrobles@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 954134, 951301, 951300 Change-Id: I1740cd09d71efea1f982b8617eb4b7c940efa26e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574720 Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#652539} ios/showcase/BUILD.gn | 1 + ios/showcase/alert/BUILD.gn | 16 +++ ios/showcase/alert/sc_alert_coordinator.h | 13 +++ ios/showcase/alert/sc_alert_coordinator.mm | 178 +++++++++++++++++++++++++++++ ios/showcase/core/showcase_model.mm | 5 + 5 files changed, 213 insertions(+) commit 693f73fafe615cafdb652f4894270cc4dbd482c4 Author: Yuki Shiino <yukishiino@chromium.org> Date: Fri Apr 19 14:55:17 2019 +0000 v8binding: Fix ToFloat to throw Adds a missing check of exception_state.HadException(). Comment about crbug.com/939598 is not correct because of unrestricted float (Web IDL) => ToFloat (Blink) float (Web IDL) => ToRestrictedFloat (Blink) In case of 'unrestricted float', it shouldn't throw an exception. Bug: 939598 Change-Id: Ibda1cb445b630f38a8e3ab52c6839a49020d6941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574997 Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#652538} third_party/blink/renderer/bindings/core/v8/v8_binding_for_core.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) commit ecdd7645f66837ede4b9fdaf1583e5e996cc3469 Author: Pâris MEULEMAN <pmeuleman@chromium.org> Date: Fri Apr 19 14:43:06 2019 +0000 Remove unused method GetSecondaryAccountsForSignedInProfile Follow up of https://crrev.com/c/1569716 Bug: 953251 Change-Id: I6b441d72c673381236dbef1b0794a3a56c49da26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575579 Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#652537} chrome/browser/profiles/profiles_state.cc | 21 --------------------- chrome/browser/profiles/profiles_state.h | 6 ------ 2 files changed, 27 deletions(-) commit 7f93d6928831e64a7255eb759f2106ff38f7fe85 Author: Michael Giuffrida <michaelpg@chromium.org> Date: Fri Apr 19 14:39:58 2019 +0000 Fix more AppListController checks When using Kiosk Next Shell, AppListController might not exist. Also adds tests for these cases. Bug: 954317 Change-Id: I5da308b5be540f56d11136c0456b455654f6da98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574952 Auto-Submit: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#652536} PRESUBMIT.py | 2 +- ash/shelf/app_list_button_unittest.cc | 46 +++++++++++++++++++++++ ash/shelf/back_button_unittest.cc | 62 +++++++++++++++++++++++++++++++ ash/shelf/shelf_application_menu_model.cc | 8 +++- ash/shelf/shelf_context_menu_model.cc | 18 ++++----- ash/wm/overview/overview_session.cc | 5 ++- 6 files changed, 127 insertions(+), 14 deletions(-) commit 2c238ae0866e965c4628ecade8b0c6246645e404 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 19 14:39:54 2019 +0000 Roll src/third_party/swiftshader 7dd3889f2cf7..97035bde89e6 (2 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/7dd3889f2cf7..97035bde89e6 git log 7dd3889f2cf7..97035bde89e6 --date=short --no-merges --format='%ad %ae %s' 2019-04-19 bclayton@google.com Switch SIMD::Pointer::base from a Float* to Byte* 2019-04-19 bclayton@google.com SpirvRoutine: Use SIMD::Pointers for pointers map. Created with: gclient setdep -r src/third_party/swiftshader@97035bde89e6 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: Ie4c274226844bec100f5bc5b77f09635f4bc69b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575642 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652535} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 0151fd41c57fe2b94060ca704a6566c74c79570a Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Fri Apr 19 14:35:24 2019 +0000 flags: remove enable-webrtc-srtp-encrypted-headers Per email discussion, we aren't interested in shipping this feature any time soon. Bug: 954201 Change-Id: I28b4701d1f7fd9e56f1ced71d6eb3fb1d886ed57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572706 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#652534} chrome/browser/about_flags.cc | 4 ---- chrome/browser/flag-metadata.json | 5 ----- chrome/browser/flag_descriptions.cc | 6 ------ chrome/browser/flag_descriptions.h | 3 --- content/public/common/content_switches.cc | 1 + 5 files changed, 1 insertion(+), 18 deletions(-) commit 06d8049482c87540dc2d55c172cad64446f9bd5a Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Fri Apr 19 14:30:03 2019 +0000 Roll src-internal f9096e11484e..3126b113b51e (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f9096e11484e..3126b113b51e Created with: gclient setdep -r src-internal@3126b113b51e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=fdoray@chromium.org,bsep@chromium.org,keishi@chromium.org,chanli@chromium.org Change-Id: I4a33e042acf212c977cc4b3788740efcdab2d557 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575638 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652533} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 3972b2f44f896206ab26f5356a21d7c02a70cd1a Author: manuk <manukh@chromium.org> Date: Fri Apr 19 14:22:56 2019 +0000 [omnibox]: Dedupe zeroSuggest provider classification. This is the 11th refactoring CL aimed at reducing duplication and inconsistency for classifying omnibox results. ZeroSuggest suggestions to not match user text or bold their texts. Their contents are styled URL; their descriptions are styled NONE. Previously, `ClassifyLocationInString` was invoked with trivial parameters in order to create these length 1 (or length 0 for empty text) classifications. With this CL, we instead use the recent `ClassifyTermMatches` method. This doesn't reduce complexity but helps moves towards using the same methods for all providers' classifications. Bug: 366623 Change-Id: Ie91c6b595776c5d46bb4f6700a938216dea2bbd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573811 Reviewed-by: Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#652532} .../omnibox/browser/zero_suggest_provider.cc | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) commit 24819e511a5d16a5deee806c3b477e6a3c0956a4 Author: Frank Kastenholz <fkastenholz@chromium.org> Date: Fri Apr 19 14:13:55 2019 +0000 Roll src/net/third_party/quiche/src/ 2c5386eab..3f0f67930 (15 commits) https://quiche.googlesource.com/quiche.git/+log/2c5386eab92a..3f0f679307af $ git log 2c5386eab..3f0f67930 --date=short --no-merges --format='%ad %ae %s' 2019-04-18 dschinazi Fix compilation of QUIC transport_parameter_test on Windows 2019-04-18 ianswett Override << for QUIC's LostPacket Struct to make failing tests easier to debug. No functional change, not flag protected. 2019-04-18 wub gfe-relnote: (n/a) Deprecate --gfe2_reloadable_flag_quic_set_transmission_type_for_next_frame. 2019-04-18 fkastenholz Make a number unsigned in order to compile in Chromium 2019-04-18 fkastenholz Make test target unsigned so that it compiles on chromium. 2019-04-18 wub gfe-relnote: (n/a) Stop including unused quic_flags.h in quic_packet_number.h. Cleanup only. 2019-04-17 dschinazi Fix iOS compilation of transport parameters 2019-04-17 quiche-dev Send a PING frame at the start of QuartcPeer tests so that probing works. 2019-04-17 dschinazi Make TLS encryption levels match the QUIC ones 2019-04-17 dschinazi Update QUIC TLS transport parameters to IETF draft 18 2019-04-17 quiche-dev Create a RandomDelayLink (and symmetric version) and use it in QuartcBidiTest. 2019-04-17 quiche-dev Create a PacketFilter for random loss and use it in QuartcBidiTest. 2019-04-17 fayang gfe-relnote: Deprecate gfe2_reloadable_flag_quic_always_reset_short_header_packets. 2019-04-17 danzh gfe-relnote: n/a(code clean-up) Remove un-used #include. 2019-04-17 danzh gfe-relnote: n/a(code clean-up) Remove unused #include. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Update flags file to remove flag that has been deleted. R=rch@chromium.org Change-Id: Ide594ef9da61cd8dcb612b47e82c7e5336215af2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574150 Reviewed-by: Ryan Hamilton <rch@chromium.org> Commit-Queue: Frank Kastenholz <fkastenholz@chromium.org> Cr-Commit-Position: refs/heads/master@{#652531} DEPS | 2 +- net/quic/quic_flags_list.h | 6 ------ 2 files changed, 1 insertion(+), 7 deletions(-) commit bb756d1e68e8489b78bccbe05f7d450ac2b55bd3 Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Fri Apr 19 14:12:53 2019 +0000 Revert "DevTools: aXe core linting for main Elements tools" This reverts commit cb019fe81baf6392d3df8f643e57effb383b61c9. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 652424 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vY2IwMTlmZTgxYmFmNjM5MmQzZGY4ZjY0M2U1N2VmZmIzODNiNjFjOQw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/WebKit%20Linux%20Trusty%20MSAN/14010 Sample Failed Step: webkit_layout_tests Sample Flaky Test: http/tests/devtools/a11y-axe-core/elements/main-tool-test.js Original change's description: > DevTools: aXe core linting for main Elements tools > > This change adds aXe Core linting to the following components of > the main Elements tool: > > - DOM tree > - Breadcrumbs > - Styles pane > - Computed Styles pane > > Change-Id: I247d9a4d4883db936f09c4d252a0558e63295edf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566689 > Commit-Queue: Robert Paveza <Rob.Paveza@microsoft.com> > Reviewed-by: Joel Einbinder <einbinder@chromium.org> > Cr-Commit-Position: refs/heads/master@{#652424} Change-Id: Ie703a128289530af6313a7c61f09216fd4e6bb7f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574280 Cr-Commit-Position: refs/heads/master@{#652530} .../elements_test_runner/ElementsTestRunner.js | 9 --- .../elements/main-tool-test-expected.txt | 21 ------- .../a11y-axe-core/elements/main-tool-test.js | 67 ---------------------- 3 files changed, 97 deletions(-) commit 324657c38b04e13532d952c90674bc453b634706 Author: Lily Chen <chlily@chromium.org> Date: Fri Apr 19 14:09:44 2019 +0000 Parsing cookie SameSite: add None & Extended options, change default This CL changes the default net::CookieSameSite value to UNSPECIFIED (it was previously NO_RESTRICTION). The default is used when the cookie does not specify a SameSite attribute, or if the given SameSite attribute does not specify a valid value. Support is added for the new `SameSite=None` option, which parses as CookieSameSite::NO_RESTRICTION. Support is also added for the new `SameSite=Extended` option, which for now is identical to Lax mode. Bug: 953306, 953995 Change-Id: I96ee07f5e626a2f99e65e9c27260a8f6e5b6b9f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573081 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#652529} net/cookies/canonical_cookie.h | 4 +-- net/cookies/canonical_cookie_unittest.cc | 51 +++++++++++++++++++++++++------- net/cookies/cookie_constants.cc | 6 +++- net/cookies/cookie_constants.h | 2 +- net/cookies/cookie_constants_unittest.cc | 23 ++++++++++++++ net/cookies/parsed_cookie.cc | 6 ++-- net/cookies/parsed_cookie_unittest.cc | 27 ++++++++++++----- 7 files changed, 93 insertions(+), 26 deletions(-) commit 6afa41423fb95a30958db46de00a2e00f5f7cf73 Author: Javier Ernesto Flores Robles <javierrobles@chromium.org> Date: Fri Apr 19 14:03:45 2019 +0000 [iOS][Alert] Remove background view As mentioned by kkhorimoto@ the background view is not needed. And the chrome shouldn't be constraint to the safe areas, but cover the presenting view controller. Bug: 951300 Change-Id: I3097c8dc6ceaaf60c1d0f6ad817a87ef910e5991 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574799 Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#652528} .../browser/ui/alert_view_controller/alert_view_controller.mm | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) commit 3bc0544438ea6b806d435251bc961e897d869de4 Author: Javier Ernesto Flores Robles <javierrobles@chromium.org> Date: Fri Apr 19 14:03:15 2019 +0000 [iOS][Alert] Make init available Making init available again so it can compile with xcode clang. UIAlertAction also has this method available. Bug: 951301, 951300, 954134 Change-Id: Ie5b5e9d5f95694a38277ba25a1bed03bfdf1e355 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573621 Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#652527} ios/chrome/browser/ui/alert_view_controller/alert_view_controller.h | 2 -- 1 file changed, 2 deletions(-) commit d747ae9e41e405ca68b6885e4fe82802fc9e989c Author: Minggang Wang <minggang.wang@intel.com> Date: Fri Apr 19 13:56:00 2019 +0000 TaskManger: Invalidate the weak pointers after stopping updating Currently, the operation of getting service worker infos is asynchronous, during which the task manager may have stopped updating. In this case we have to invalidate the weak pointers to avoid the invoking of the callbacks. BUG=953432 Change-Id: I7f5bc3c0203008175264eb5a8f31ab5236d40d27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572648 Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Minggang Wang <minggang.wang@intel.com> Cr-Commit-Position: refs/heads/master@{#652526} .../browser/task_manager/providers/service_worker_task_provider.cc | 5 +++++ 1 file changed, 5 insertions(+) commit 464a98fd5ed5d14f77e30d73eb37e8395d816697 Author: Javier Ernesto Flores Robles <javierrobles@chromium.org> Date: Fri Apr 19 13:43:37 2019 +0000 [iOS][Alert] Support action handler blocks Bug: 951361, 951300 Change-Id: Ic653d533b927774f0d78de10c7fb4d5ab8dfa3c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565006 Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#652525} .../alert_view_controller/alert_view_controller.mm | 28 ++++++++++++++++++++++ 1 file changed, 28 insertions(+) commit 4d779c1c28c4c9994d732b17e20b2e13320c7e93 Author: Sébastien Séguin-Gagnon <sebsg@chromium.org> Date: Fri Apr 19 13:26:18 2019 +0000 Make iOS ConfirmInforBars close if delegate LinkClicked returns true. The delegate's documentation mentions that returning true should close the infobar. Bug: 954339 Change-Id: Ibbe75f180f828afebd72c4c7953045da9249b7c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574443 Reviewed-by: Sergio Collazos <sczs@chromium.org> Commit-Queue: sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#652524} ios/chrome/browser/infobars/confirm_infobar_controller.mm | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) commit 31bd4ef76f55fbd2268677b88b537a1ff1d83cde Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Fri Apr 19 13:13:26 2019 +0000 Roll src-internal f2976d2e4dec..f9096e11484e (2 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f2976d2e4dec..f9096e11484e Created with: gclient setdep -r src-internal@f9096e11484e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=fdoray@chromium.org,bsep@chromium.org,keishi@chromium.org,chanli@chromium.org Change-Id: I2d83e8b1e52cb00c894efa9f568ec407c441cf46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575417 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652523} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 64d63fed8396aa97aa651e0ad4d7b408a9b4abb8 Author: Alexander Timin <altimin@chromium.org> Date: Fri Apr 19 13:11:16 2019 +0000 [bfcache] Track service worker-controlled pages in metrics Track pages controlled by service workers. R=haraken@chromium.org,kinuko@chromium.org CC=falken@chromium.org BUG=933147 Change-Id: I27c2665bf6c484df7748a97ea5260c7407bbae90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571693 Commit-Queue: Alexander Timin <altimin@chromium.org> Auto-Submit: Alexander Timin <altimin@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#652522} .../blink/public/common/scheduler/web_scheduler_tracked_feature.h | 5 ++++- .../renderer/modules/service_worker/service_worker_container.cc | 3 +++ .../blink/renderer/platform/scheduler/common/scheduling_policy.cc | 4 +--- .../renderer/platform/scheduler/main_thread/frame_scheduler_impl.cc | 2 +- .../renderer/platform/scheduler/main_thread/frame_scheduler_impl.h | 2 +- .../renderer/platform/scheduler/public/frame_or_worker_scheduler.h | 2 +- 6 files changed, 11 insertions(+), 7 deletions(-) commit 31082d0f66de49b4038ae58460f14dd4c05f50c8 Author: Ramin Halavati <rhalavati@chromium.org> Date: Fri Apr 19 13:01:47 2019 +0000 Update incognito toolbar button's accessible title. Accessible name of incognito menu is updated to tell the number of open incognito windows when incognito window counter is active. Bug: 896235 Change-Id: I16deed985d9cf8170d6739f083f0c352df44c435 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569932 Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Peter Boström <pbos@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#652521} chrome/browser/ui/views/profiles/avatar_toolbar_button.cc | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) commit f2b46d895e5487a1b446fc1c676f971a14aff17f Author: Pâris MEULEMAN <pmeuleman@chromium.org> Date: Fri Apr 19 13:01:43 2019 +0000 Return CoreAccountInfo in IdentityManager::GetAccountsWithRefreshToken In the scope of the AccountInfo Split, Bug: 926204, we are evolving the identity manager API. This specific CL aims to change the return type of GetAccountsWithRefreshToken from vector<AccountInfo> to vector<CoreAccountInfo>. Two cases are using the extended Account Information and will use GetExtendedAccountInfoForAccountsWithRefreshToken instead. Bug: 953251 Change-Id: Ib7f39129bb0da7572c3975d34add98aa16abdac3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569716 Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#652520} chrome/browser/chromeos/arc/auth/arc_auth_service.cc | 4 ++-- .../extensions/api/identity/identity_apitest.cc | 2 +- .../api/identity/identity_get_accounts_function.cc | 2 +- chrome/browser/profiles/profiles_state.cc | 6 +++--- chrome/browser/profiles/profiles_state.h | 4 ++-- chrome/browser/signin/signin_ui_util.cc | 8 ++++---- .../supervised_user_internals_message_handler.cc | 3 ++- components/gcm_driver/account_tracker.cc | 4 ++-- .../signin/core/browser/about_signin_internals.cc | 4 ++-- components/signin/core/browser/account_reconcilor.cc | 2 +- .../core/browser/account_reconcilor_unittest.cc | 4 ++-- .../signin/core/browser/signin_error_controller.cc | 2 +- ios/chrome/browser/signin/authentication_service.mm | 8 ++++---- .../signin/authentication_service_unittest.mm | 6 +++--- .../sync/sync_settings_table_view_controller.mm | 2 +- .../identity/public/cpp/accounts_mutator_unittest.cc | 2 +- services/identity/public/cpp/identity_manager.cc | 18 +++++++++++++++++- services/identity/public/cpp/identity_manager.h | 7 ++++++- .../identity/public/cpp/identity_manager_unittest.cc | 20 ++++++++++---------- 19 files changed, 65 insertions(+), 43 deletions(-) commit bd4c0657c3e8861f92108bd691c91960393f3de2 Author: Tsuyoshi Horo <horo@chromium.org> Date: Fri Apr 19 12:57:33 2019 +0000 Update flag-metadata.json for allow-sxg-certs-without-extension Bug: 851778,862003 Change-Id: If6667d8b8f4813748fdd1bceb40850bdfd5da36f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573431 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#652519} chrome/browser/flag-metadata.json | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) commit d9d4f6eaee6742b03d00658cdb26e1ba9fab973e Author: Lily Chen <chlily@chromium.org> Date: Fri Apr 19 12:52:14 2019 +0000 Mark stored cookies without SameSite attribute as "unspecified" The SQLitePersistentCookieStore is upgraded to Version 11, which renames the firstpartyonly column to samesite, and adds support for two new values for that column (kCookieSameSiteUnspecified and kCookieSameSiteExtended). Upon migration from Version 10 to Version 11, any stored cookies which have a value of kCookieSameSiteNoRestriction, indicating that they were set without a SameSite attribute, are marked instead with kCookieSameSiteUnspecified to reflect the fact that their SameSite attribute was unspecified. Bug: 953306 Change-Id: I88a3fa7e4771d07716d9cc6c260e4fe67a19e3f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570416 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Reviewed-by: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#652518} .../sqlite/sqlite_persistent_cookie_store.cc | 104 ++++++++++-- .../sqlite_persistent_cookie_store_unittest.cc | 179 ++++++++++++++++++++- tools/metrics/histograms/histograms.xml | 10 ++ 3 files changed, 280 insertions(+), 13 deletions(-) commit 1bd70e22f25c97fe6697bde60f86113084b8caa2 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Fri Apr 19 12:51:04 2019 +0000 flags: remove enable-recurrent-interstitial Bug: 953972 Change-Id: Iaee80ccefd6bd3a23744994e016caf4a2cf7b4e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573641 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Emily Stark <estark@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#652517} chrome/browser/about_flags.cc | 5 ----- chrome/browser/flag-metadata.json | 5 ----- chrome/browser/flag_descriptions.cc | 6 ------ chrome/browser/flag_descriptions.h | 3 --- chrome/browser/ssl/chrome_ssl_host_state_delegate.cc | 1 + 5 files changed, 1 insertion(+), 19 deletions(-) commit 26d6a7880683fbaa186aade191b7e4b820b25a61 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 19 12:48:03 2019 +0000 Roll src/third_party/angle 51386f4a5e8b..fcc3ec31b83b (2 commits) https://chromium.googlesource.com/angle/angle.git/+log/51386f4a5e8b..fcc3ec31b83b git log 51386f4a5e8b..fcc3ec31b83b --date=short --no-merges --format='%ad %ae %s' 2019-04-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src 805b09f92203..0e5d1bb66ad3 (1 commits) 2019-04-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src ac878fcbdd64..7aad9653f9a3 (2 commits) Created with: gclient setdep -r src/third_party/angle@fcc3ec31b83b The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I424672334fcc228fdba8af717abea738c8f466e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575415 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652516} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit ce9c2042eab371cdf5c623135718b1d49a8b43be Author: Nektarios Paisios <nektar@chromium.org> Date: Fri Apr 19 12:39:55 2019 +0000 Introduced an enum that lists the text boundaries that are exposed on all supported platforms Different platforms have different ways of handling text boundaries, both while navigating, as well as when being asked to return a particular text unit surrounding the current position. On Windows, navigating by word always goes to the start of the word. When announcing the current word however, a screen reader whill not include anything that comes between the current word and the next one. On Linux and Mac, navigating by the same unit will stop at the start of the word when moving in the backward direction, but at the end of the word when navigating in the forward direction. Also, various platforms have text boundaries that are unsupported on others. For example, UI Automation can return text ranges based on style changes. This patch creates an enum that is a superset of all the text boundaries supported on all platforms and a set of functions to convert to the various platform specific text boundaries. R=dmazzoni@chromium.org Change-Id: I5fbc116a5f6dc9bc4e1ee3ab4cb46d5009003e0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1567953 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#652515} .../browser/accessibility/browser_accessibility.cc | 31 +++-- .../browser/accessibility/browser_accessibility.h | 3 +- .../accessibility/browser_accessibility_com_win.cc | 2 +- .../accessibility/browser_accessibility_com_win.h | 3 +- ui/accessibility/BUILD.gn | 4 + ui/accessibility/ax_text_boundary.cc | 50 ++++++++ ui/accessibility/ax_text_boundary.h | 60 +++++++++ ui/accessibility/ax_text_utils.cc | 60 +++++---- ui/accessibility/ax_text_utils.h | 19 +-- ui/accessibility/ax_text_utils_unittest.cc | 138 +++++++++++---------- .../platform/ax_platform_node_auralinux.cc | 90 +++----------- .../ax_platform_node_auralinux_unittest.cc | 6 +- ui/accessibility/platform/ax_platform_node_base.cc | 14 +-- ui/accessibility/platform/ax_platform_node_base.h | 3 +- .../platform/ax_platform_node_delegate.h | 3 +- .../platform/ax_platform_node_delegate_base.cc | 2 +- .../platform/ax_platform_node_delegate_base.h | 2 +- ui/accessibility/platform/ax_platform_node_win.cc | 23 +--- ui/accessibility/platform/ax_platform_node_win.h | 4 +- .../platform/ax_platform_text_boundary.cc | 90 ++++++++++++++ .../platform/ax_platform_text_boundary.h | 46 +++++++ 21 files changed, 423 insertions(+), 230 deletions(-) commit c3d639c51d53f085860ac061d2f981a4d0aa7025 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 19 12:35:04 2019 +0000 Roll src/third_party/glslang/src 0e5d1bb66ad3..86c72c9486a9 (3 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/0e5d1bb66ad3..86c72c9486a9 git log 0e5d1bb66ad3..86c72c9486a9 --date=short --no-merges --format='%ad %ae %s' 2019-04-19 cepheus@frii.com Bump revision. 2019-04-19 cepheus@frii.com GLSL: Add error check for an argument dropping the 'restrict' qualifier 2019-04-19 cepheus@frii.com Fix #1720: Give an error for parameter mismatched image format. Created with: gclient setdep -r src/third_party/glslang/src@86c72c9486a9 The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I81fd92cdb12b4ef210c952f23261f5862b981220 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575416 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652514} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 8ca571cb6ddefcc76906bffa17fd1159709a5de5 Author: Benoît Lizé <lizeb@chromium.org> Date: Fri Apr 19 12:04:44 2019 +0000 blink/bindings: Check that decompression is correct, and add UTF-16 testing. There are crashes in ParkableString decompression, which are assumed to be OOM conditions. Add a check to make sure this is the case, and add testing for UTF16 strings to make sure that this doesn't instead come from such strings. Bug: 946203 Change-Id: Iaafde8c3c7b9c79bf87de67e6c5de5b71e1a310a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575499 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#652513} .../renderer/platform/bindings/parkable_string.cc | 11 +++++--- .../platform/bindings/parkable_string_test.cc | 30 ++++++++++++++++++++++ 2 files changed, 37 insertions(+), 4 deletions(-) commit add02293cf597c9e39a77debbeaa53a4e151617c Author: Keishi Hattori <keishi@chromium.org> Date: Fri Apr 19 11:58:44 2019 +0000 Modify frameset console to use postMessage To introduce EventLoop concept we can't have AllowUniversalAccessFromFileURLs changing midway, and so we will be making AllowUniversalAccessFromFileURLs false for web_tests by default. Tests using frameset, write in the frame to show text. Without AllowUniversalAccessFromFileURLs, you cannot write directly into it, so this CL changes them to use postMessage. Bug=804661 Change-Id: I22a48a6a856f4cb2b14bcc956a2fa2cf47cea3f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573521 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#652512} .../fast/frames/frame-inherit-noresize-from-frameset.html | 2 +- .../web_tests/fast/frames/frame-programmatic-noresize.html | 2 +- ...th-noresize-can-be-resized-after-removal-of-noresize.html | 2 +- ...esize-can-be-resized-after-setting-noResize-to-false.html | 2 +- .../frames/frames-with-frameborder-zero-can-be-resized.html | 12 +++++++++--- .../fast/frames/resources/frame-programmatic-resize.js | 10 ++++++++-- 6 files changed, 21 insertions(+), 9 deletions(-) commit 9f4031e3be9d2cd41658e74834e78666c76d7d1e Author: Colin Blundell <blundell@chromium.org> Date: Fri Apr 19 11:55:34 2019 +0000 Update //components/OWNERS to properly allow trivial changes Followup to https://chromium-review.googlesource.com/c/chromium/src/+/1470974 to realize the intent of that CL. Credit to thakis@, who noticed the error. Change-Id: Ia0c8d02603713097566e8788e0e36083acbffeec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575498 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#652511} components/OWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 0a8820a7c42d2123ca79bf081e7a1df74430f0ac Author: Alexander Timin <altimin@chromium.org> Date: Fri Apr 19 11:35:04 2019 +0000 [bfcache] Track the presence of network requests for metrics R=kinuko@chromium.org,haraken@chromium.org BUG=933147 Change-Id: Ie6590bebb11e70e024f829045e1f8717d83e9af1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572128 Commit-Queue: Alexander Timin <altimin@chromium.org> Auto-Submit: Alexander Timin <altimin@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#652510} .../back_forward_cache_metrics_browsertest.cc | 27 ++++++++++++---------- .../scheduler/web_scheduler_tracked_feature.h | 3 ++- .../scheduler/scheduler_affecting_features_test.cc | 2 ++ .../platform/loader/fetch/resource_loader.cc | 7 ++++++ .../platform/loader/fetch/resource_loader.h | 4 ++++ .../platform/scheduler/common/scheduling_policy.cc | 1 + 6 files changed, 31 insertions(+), 13 deletions(-) commit 46a6f8729b6b786bb9f1d17452915d483a626b18 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Fri Apr 19 11:21:44 2019 +0000 Roll src-internal b2e2edfd0377..f2976d2e4dec (4 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b2e2edfd0377..f2976d2e4dec Created with: gclient setdep -r src-internal@f2976d2e4dec The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=fdoray@chromium.org,bsep@chromium.org,keishi@chromium.org,chanli@chromium.org Change-Id: Ic96debf4aceeed51852615f445c2783e01db56ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575413 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652509} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 237ee066f06717a94d62016816cbdc04c6ae300c Author: Camille Lamy <clamy@chromium.org> Date: Fri Apr 19 10:52:52 2019 +0000 Add support for custom PageState in NavigationSimulator This CL allows to set a custom PageState in the NavigationSimulator and converst one unit test that needed this functionality to using NavigationSimulator. Bug: 728571 Change-Id: Ie62b87f328f52e6ae51357a3ebfa9f295ea7ac80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569017 Reviewed-by: Nasko Oskov <nasko@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#652508} .../renderer_host/render_view_host_unittest.cc | 29 ++++++++-------------- content/test/navigation_simulator_impl.cc | 7 +++--- content/test/navigation_simulator_impl.h | 3 +++ 3 files changed, 18 insertions(+), 21 deletions(-) commit 1e9f9a24aa12bea9cf194a82a7e249bd1242ec4f Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 19 10:28:22 2019 +0000 Roll AFDO from 75.0.3769.0_rc-r1-merged to 75.0.3770.0_rc-r1-merged This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Ie75dc6d6262e968994c6bb2a72281c12fe8b4178 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575414 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652507} chrome/android/profiles/newest.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit f7711a39647964bd7b3e57e2249f4091f5393e3c Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 19 10:24:52 2019 +0000 Roll src/third_party/chromite 641336160936..666a00adb2b3 (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/641336160936..666a00adb2b3 git log 641336160936..666a00adb2b3 --date=short --no-merges --format='%ad %ae %s' 2019-04-19 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@666a00adb2b3 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I8c2b427692eaa09e3a52072a35d59f77998d10ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575412 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652506} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 6920e160562801ac5a3a5ac097c91d3155f8644c Author: Zhang Xiangze <xiangze.zhang@intel.com> Date: Fri Apr 19 10:03:31 2019 +0000 WebMediaPlayerMSCompositor cleanup In WebMediaPlayerMSCompositor, GetCurentFrame() no longer has side effect. This CL removes GetCurrentFrameWithoutUpdatingStatistics() and uses GetCurrentFrame() instead. This CL also removes an outdated comment. Bug: 948472 Change-Id: If18ccb69cfe47a8944bdb91a1a8cf72f91d34985 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542783 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Reviewed-by: Emircan Uysaler <emircan@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#652505} content/renderer/media/stream/webmediaplayer_ms.cc | 14 +++++--------- .../media/stream/webmediaplayer_ms_compositor.cc | 11 ----------- .../media/stream/webmediaplayer_ms_compositor.h | 11 ----------- .../media/stream/webmediaplayer_ms_unittest.cc | 22 +++++++++++----------- 4 files changed, 16 insertions(+), 42 deletions(-) commit 01a6334f6f5c581f63501ca45461f8931cc984ee Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 19 09:39:12 2019 +0000 Roll src/third_party/catapult 2ab4d326364e..92d14c28e81b (1 commits) https://chromium.googlesource.com/catapult.git/+log/2ab4d326364e..92d14c28e81b git log 2ab4d326364e..92d14c28e81b --date=short --no-merges --format='%ad %ae %s' 2019-04-19 benjhayden@chromium.org Migrate alerts-request.js to es6 module Created with: gclient setdep -r src/third_party/catapult@92d14c28e81b The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:950011 TBR=charliea@chromium.org Change-Id: I09e7cf37cba92257bcec523e6110942d8d5b6b94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575411 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652504} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 79e872fb87f063f565085eecfbef87fb98bbd6e2 Author: Yoshifumi Inoue <yosin@chromium.org> Date: Fri Apr 19 09:39:09 2019 +0000 Clear offset mapping cache in LayoutSVGText::UpdateLayout() This patch makes |LayoutSVGText::UpdateLayout()| to clear offset mapping cache if needed rather than in |LayoutBlockFlow::UpdateBlockLayout()|[1] to fix heap-use-after-free in |NGOffsetMapping|. Unlike other derived classes of |LayoutBlockFlow|, |LayoutSVGBlock::UpdateLayout()| doesn't call |UpdateBlockLayout()|, then |LayoutSVGBlock| holds stale offset mapping cache. [1] http://crrev.com/c/1488479 Make LayoutBlockFlowRareData to hold NGOffsetMapping for legacy layout Bug: 951218 Change-Id: Iacaa72a426cfcf9cd71495cf2c1ed6a0c6511ed9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574987 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#652503} third_party/blink/renderer/core/layout/layout_block_flow.cc | 8 ++++---- third_party/blink/renderer/core/layout/layout_block_flow.h | 2 +- third_party/blink/renderer/core/layout/svg/layout_svg_text.cc | 2 ++ 3 files changed, 7 insertions(+), 5 deletions(-) commit 5f7996b2c13f87036d610ce37f43b53b70b14746 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 19 09:38:08 2019 +0000 Roll src/third_party/angle 145ec7fa7c81..51386f4a5e8b (1 commits) https://chromium.googlesource.com/angle/angle.git/+log/145ec7fa7c81..51386f4a5e8b git log 145ec7fa7c81..51386f4a5e8b --date=short --no-merges --format='%ad %ae %s' 2019-04-19 kbr@chromium.org Reland "Define and expose EGL_ANGLE_power_preference extension." Created with: gclient setdep -r src/third_party/angle@51386f4a5e8b The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:2813 TBR=cwallez@chromium.org Change-Id: If1c618840fd9feca8e0ef3be05da953f1871f196 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575410 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652502} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 257a68d9d4d0462f30f79e27f165eb87feab3bc9 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Fri Apr 19 09:38:05 2019 +0000 Roll src-internal ecf68b73d5c9..b2e2edfd0377 (4 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ecf68b73d5c9..b2e2edfd0377 Created with: gclient setdep -r src-internal@b2e2edfd0377 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=fdoray@chromium.org,bsep@chromium.org,keishi@chromium.org,chanli@chromium.org Change-Id: Ieb2ee73fc3bb9f7ab7eec37490aa157ccc5cd8cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575409 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652501} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 0a02120209905157a816e501810f51a014544423 Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Fri Apr 19 09:20:02 2019 +0000 Revert "Reland "OnionSoup: Move web_bluetooth.mojom to public/mojom/bluetooth"" This reverts commit 12b303006bbd944b37ea0010904e3de88ed1bd77. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 652487 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzEyYjMwMzAwNmJiZDk0NGIzN2VhMDAxMDkwNGUzZGU4OGVkMWJkNzcM Sample Failed Build: https://ci.chromium.org/buildbot/chromium/mac-rel/4772 Sample Failed Step: compile Original change's description: > Reland "OnionSoup: Move web_bluetooth.mojom to public/mojom/bluetooth" > > This is a reland of d5b00821af44d875d6cad42ae578b999ddf9316c > > It updates //BUILD.gn and //content/public/common/BUILD.gn > in addition to the previous change to fix the dependency > problem. > > Original change's description: > > OnionSoup: Move web_bluetooth.mojom to public/mojom/bluetooth > > > > This CL moves bluetooth folder from public/platform/modules to > > public/mojom/ to gather mojom files to mojom folder with > > creating web_bluetooth_mojo_bindings. > > > > Bug: 919393 > > Change-Id: I42037e1c9738b03969e927dd00f6b24c2873b364 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530369 > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > Reviewed-by: Henrique Nakashima <hnakashima@chromium.org> > > Reviewed-by: John Budorick <jbudorick@chromium.org> > > Reviewed-by: Doug Turner <dougt@chromium.org> > > Reviewed-by: Colin Blundell <blundell@chromium.org> > > Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> > > Cr-Commit-Position: refs/heads/master@{#649061} > > Bug: 919393 > Change-Id: I61de3e625205e54959ad8d36c84eefa95f861035 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559368 > Reviewed-by: John Budorick <jbudorick@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Colin Blundell <blundell@chromium.org> > Reviewed-by: Henrique Nakashima <hnakashima@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> > Cr-Commit-Position: refs/heads/master@{#652487} Change-Id: I29f9dc1cdedf6f7f6aad104a2bced4aac446b7a6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 919393 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575520 Cr-Commit-Position: refs/heads/master@{#652500} BUILD.gn | 2 +- components/pdf/common/BUILD.gn | 6 +-- content/browser/BUILD.gn | 2 +- content/browser/DEPS | 7 +++ .../browser/bluetooth/bluetooth_allowed_devices.h | 2 +- content/browser/bluetooth/bluetooth_blocklist.h | 2 +- .../bluetooth_device_chooser_controller.h | 2 +- content/browser/bluetooth/bluetooth_metrics.h | 2 +- .../bluetooth/frame_connected_bluetooth_devices.h | 2 +- .../browser/bluetooth/web_bluetooth_service_impl.h | 2 +- .../browser/frame_host/render_frame_host_impl.h | 2 +- .../service_manager/service_manager_context.cc | 2 +- content/child/BUILD.gn | 1 + content/common/BUILD.gn | 2 +- content/common/DEPS | 1 + content/common/bluetooth/OWNERS | 3 -- .../bluetooth/web_bluetooth_device_id.typemap | 3 +- .../web_bluetooth_device_id_struct_traits.h | 2 +- content/public/browser/BUILD.gn | 1 + content/public/common/BUILD.gn | 3 +- content/renderer/BUILD.gn | 1 + content/test/test_render_frame_host.cc | 2 +- content/utility/BUILD.gn | 1 + services/device/public/mojom/BUILD.gn | 1 + third_party/blink/public/BUILD.gn | 60 ++++++++++++++++++++++ third_party/blink/public/mojom/BUILD.gn | 31 ----------- .../{mojom => platform/modules}/bluetooth/OWNERS | 0 .../modules}/bluetooth/bluetooth.typemap | 3 +- .../modules}/bluetooth/web_bluetooth.mojom | 0 .../blink/renderer/bindings/core/v8/BUILD.gn | 1 + .../blink/renderer/modules/bluetooth/README.md | 2 +- .../blink/renderer/modules/bluetooth/bluetooth.h | 2 +- .../renderer/modules/bluetooth/bluetooth_device.h | 2 +- .../renderer/modules/bluetooth/bluetooth_error.h | 2 +- .../bluetooth_remote_gatt_characteristic.h | 2 +- .../bluetooth/bluetooth_remote_gatt_server.h | 2 +- .../bluetooth/bluetooth_remote_gatt_service.h | 2 +- third_party/blink/renderer/platform/BUILD.gn | 2 +- .../renderer/platform/mojo/blink_typemaps.gni | 2 +- .../platform/mojo/bluetooth_struct_traits.h | 2 +- 40 files changed, 106 insertions(+), 63 deletions(-) commit 4d561f6ca2202865c0dcede8006de2817ce9c48c Author: Arthur Sonzogni <arthursonzogni@chromium.org> Date: Fri Apr 19 09:01:07 2019 +0000 Revert "Make renderer-initiated navigation to about:blank to use the default path." This reverts commit 2cd39eb02d017e6ce8db65045d6f13833505963c. Reason for revert: The branch cut was supposed to be yesterday, but I haven't received any confirmation is happened. To be sure revert this commit for the moment. Original change's description: > Make renderer-initiated navigation to about:blank to use the default path. > > We used to believe renderer initiated navigation from a document to > about:blank needed to happen sometimes "synchronously". This isn't the > case, a PostTask is currently used. The only real requirement is when > committing the initial empty document. > > This CL makes those navigation to use the default path instead. > > This requires a few tests to be updated: > > 1) The initiator and a few other properties needs to be properly set. There > are DCHECK in BeginNavigationInternal to enforce renderer initiated > navigation always have a defined initiator. > > 2) runtime-console-log-handle-navigate.js: In console-log-navigate, console.log > can use the 'getter' of the object several times (up to 2) to print the > object. It triggers several about:blank navigations. Since they are now going > to the browser process, they are committed later compared to the script > execution. The test became less reliable. The test was using > dp.Runtime.onceExecutionContextCreated to wait for new documents to commit, > but waiting was started potentially after the event occured. The new test is > now creating the Promise before triggering the action that will later resolve > it. The action is either creating the iframe or making use of the logXXX() > function. This is now fully reliable. > > Bug: 936696 > Change-Id: Ibf1a87f83d2e8bfd621d067f0a29a14a069384a8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543258 > Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Camille Lamy <clamy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#652493} TBR=dgozman@chromium.org,dcheng@chromium.org,nasko@chromium.org,clamy@chromium.org,alexmos@chromium.org,arthursonzogni@chromium.org Change-Id: I6a5fe676275d59027907a1c9540dfe941fab3e18 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 936696 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574320 Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#652499} content/public/common/referrer.cc | 5 +-- content/renderer/render_frame_impl.cc | 44 +++++++++------------- content/renderer/render_frame_impl.h | 5 --- content/renderer/render_view_browsertest.cc | 20 +++------- .../shell/renderer/web_test/blink_test_runner.cc | 8 +--- .../resources/console-log-navigate.html | 16 +++----- .../runtime/runtime-console-log-handle-navigate.js | 39 +++++++++---------- 7 files changed, 48 insertions(+), 89 deletions(-) commit 8d2eba94502edfced9dc08bca5cb9965e6d76319 Author: Ryo Hashimoto <hashimoto@chromium.org> Date: Fri Apr 19 08:15:08 2019 +0000 chromeos: Introduce use_real_dbus_clients GN arg use_real_dbus_clients=true will be used to avoid linking fakes to the shipped binary. BUG=952745 TEST=build Change-Id: I419b9b5c2460dbc9dd66fff7490d06d34ec02c9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571329 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#652498} ash/DEPS | 1 + ash/ash_service.cc | 25 ++++-------- ash/shell.cc | 11 ++---- chrome/browser/chromeos/dbus/dbus_helper.cc | 50 ++++++++---------------- chromeos/dbus/BUILD.gn | 13 +++++++ chromeos/dbus/dbus_clients_browser.cc | 59 +++++++++++++---------------- chromeos/dbus/dbus_thread_manager.cc | 11 ++++-- chromeos/dbus/initialize_dbus_client.h | 32 ++++++++++++++++ chromeos/dbus/shill/shill_clients.cc | 4 ++ 9 files changed, 111 insertions(+), 95 deletions(-) commit 99a6d4cc8bc0c34771e69242b096878573e20f55 Author: Chromium WPT Sync <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Date: Fri Apr 19 08:11:47 2019 +0000 Import wpt@d1e0662220364b642929f5fb0b43367074c1119c Using wpt-import in Chromium 263e7db86c6f187244392abe262d1206639b95c6. With Chromium commits locally applied on WPT: 0a8f3ffa48 "Use testdriver Action API in WPT pointerevent touch tests - Part 2" 4e9215207a "[Code Health] Remove unnecessary reference file for web test" 40465b7400 "[Animation Worklet] Copy the effects of a migrating animator over to new global scope" e28269b698 "[LayoutNG/PE] Clear visual overflow for LayoutText before setting." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: Icb769e141e801a0e6539af98581238a677f81a4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574446 Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652497} third_party/blink/web_tests/external/WPT_BASE_MANIFEST_6.json | 4 ++-- third_party/blink/web_tests/external/wpt/interfaces/webaudio.idl | 4 +++- 2 files changed, 5 insertions(+), 3 deletions(-) commit 08c347525af354e49166d0ca739f7e5d5335d978 Author: Yuzu Saijo <yuzus@chromium.org> Date: Fri Apr 19 08:06:38 2019 +0000 Disable Perfetto for leak detection This CL disables perfetto for leak detection for now because perfetto changed the timing of taking memory dumps and thus leak detection is not properly working any more. This is meant to be a temporary fix. Bug: 936805 Change-Id: I885e2abe074354878cae909af54c194d30e1f132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557665 Reviewed-by: Keishi Hattori <keishi@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#652496} tools/perf/contrib/leak_detection/leak_detection.py | 1 + tools/perf/contrib/leak_detection/page_sets.py | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) commit 440d2141c4ac744b742e9229bd31d379d2d86ead Author: v.paturi <v.paturi@samsung.com> Date: Fri Apr 19 08:01:59 2019 +0000 Split DarkModeImageClassifier for Bitmap and SVG images. The classifier for SVG images is going to have to work with layout objects. So the code for the SVG classifier cannot reside in the current DarkModeImageClassifier in platform as the code in platform cannot depend on core. A separate class is implemented in core for classification of SVG images in dark mode. The current DarkModeImageClassifier is renamed to a more appropriate DarkModeBitmapImageClassifier. The SVG classifier itself is a work in progress and will be submitted in a follow-up CL. Bug: 949943 Change-Id: I135a357c333655c11e197599466c314d2f20facf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564276 Commit-Queue: Varun Chowdhary Paturi <v.paturi@samsung.com> Reviewed-by: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#652495} third_party/blink/renderer/core/svg/BUILD.gn | 2 ++ .../svg/graphics/dark_mode_svg_image_classifier.cc | 17 ++++++++++ .../svg/graphics/dark_mode_svg_image_classifier.h | 27 ++++++++++++++++ .../blink/renderer/core/svg/graphics/svg_image.cc | 7 +++++ .../blink/renderer/core/svg/graphics/svg_image.h | 4 +-- .../core/svg/graphics/svg_image_for_container.cc | 7 +++++ .../core/svg/graphics/svg_image_for_container.h | 4 +-- third_party/blink/renderer/platform/BUILD.gn | 6 ++-- .../renderer/platform/graphics/bitmap_image.cc | 7 ++--- ...ier.cc => dark_mode_bitmap_image_classifier.cc} | 36 ++++++++++++---------- ...ifier.h => dark_mode_bitmap_image_classifier.h} | 16 +++++----- ...c => dark_mode_bitmap_image_classifier_test.cc} | 14 ++++----- 12 files changed, 101 insertions(+), 46 deletions(-) commit 0380fdb94bd03968ab0f614f71e5c320966ca159 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 19 08:00:01 2019 +0000 Roll src/third_party/glslang/src 805b09f92203..0e5d1bb66ad3 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/805b09f92203..0e5d1bb66ad3 git log 805b09f92203..0e5d1bb66ad3 --date=short --no-merges --format='%ad %ae %s' 2019-04-19 cepheus@frii.com clang-format correction and typo (clang format likely not complete) Created with: gclient setdep -r src/third_party/glslang/src@0e5d1bb66ad3 The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ibda22dac750cf4f7b4f62068062fd2c5892528ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575405 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652494} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 2cd39eb02d017e6ce8db65045d6f13833505963c Author: arthursonzogni <arthursonzogni@chromium.org> Date: Fri Apr 19 07:58:49 2019 +0000 Make renderer-initiated navigation to about:blank to use the default path. We used to believe renderer initiated navigation from a document to about:blank needed to happen sometimes "synchronously". This isn't the case, a PostTask is currently used. The only real requirement is when committing the initial empty document. This CL makes those navigation to use the default path instead. This requires a few tests to be updated: 1) The initiator and a few other properties needs to be properly set. There are DCHECK in BeginNavigationInternal to enforce renderer initiated navigation always have a defined initiator. 2) runtime-console-log-handle-navigate.js: In console-log-navigate, console.log can use the 'getter' of the object several times (up to 2) to print the object. It triggers several about:blank navigations. Since they are now going to the browser process, they are committed later compared to the script execution. The test became less reliable. The test was using dp.Runtime.onceExecutionContextCreated to wait for new documents to commit, but waiting was started potentially after the event occured. The new test is now creating the Promise before triggering the action that will later resolve it. The action is either creating the iframe or making use of the logXXX() function. This is now fully reliable. Bug: 936696 Change-Id: Ibf1a87f83d2e8bfd621d067f0a29a14a069384a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543258 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#652493} content/public/common/referrer.cc | 5 ++- content/renderer/render_frame_impl.cc | 44 +++++++++++++--------- content/renderer/render_frame_impl.h | 5 +++ content/renderer/render_view_browsertest.cc | 20 +++++++--- .../shell/renderer/web_test/blink_test_runner.cc | 8 +++- .../resources/console-log-navigate.html | 16 +++++--- .../runtime/runtime-console-log-handle-navigate.js | 39 ++++++++++--------- 7 files changed, 89 insertions(+), 48 deletions(-) commit e611e6cb82b3caebb221437b6642799585a81e5d Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 19 07:55:37 2019 +0000 Roll src/third_party/catapult 7f8529c21699..2ab4d326364e (3 commits) https://chromium.googlesource.com/catapult.git/+log/7f8529c21699..2ab4d326364e git log 7f8529c21699..2ab4d326364e --date=short --no-merges --format='%ad %ae %s' 2019-04-19 benjhayden@chromium.org Migrate report-template to es6 module 2019-04-19 benjhayden@chromium.org Migrate chart-compound.js to es6 module 2019-04-19 benjhayden@chromium.org Migrate report-controls.js to es6 module Created with: gclient setdep -r src/third_party/catapult@2ab4d326364e The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:950011,chromium:950011,chromium:950011 TBR=oysteine@chromium.org Change-Id: Ic5cf0e87ca81eec9fe398053689824308ba5be84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575406 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652492} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e785a3de35b40cc933acefa8a034c1852f313ef0 Author: Yutaka Hirano <yhirano@chromium.org> Date: Fri Apr 19 07:54:57 2019 +0000 Remove FetchContext::ModifyPriorityForExperiment Introduce ResourceFetcherProperties::IsSubframeDeprioritizationEnabled instead. Move the priority modification logic to ResourceFetcher. We need to have a IsMainFrame branch in ResourceFetcher in order to record histograms. Once it is deprecated we should move the logic into ResourceFetcherProperties and rename the method to something like ShouldDeprioritizeRequest. Bug: 914739 Change-Id: I6627ee9fd2860a257d68f64879a1cc5875685350 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570961 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#652491} third_party/blink/renderer/core/BUILD.gn | 1 + .../renderer/core/loader/frame_fetch_context.cc | 47 ------ .../renderer/core/loader/frame_fetch_context.h | 3 - .../core/loader/frame_fetch_context_test.cc | 88 ---------- .../loader/frame_resource_fetcher_properties.cc | 30 ++++ .../loader/frame_resource_fetcher_properties.h | 5 +- .../frame_resource_fetcher_properties_test.cc | 52 ++++++ .../loader/worker_resource_fetcher_properties.h | 1 + .../renderer/platform/loader/fetch/fetch_context.h | 7 - .../fetch/null_resource_fetcher_properties.h | 1 + .../platform/loader/fetch/resource_fetcher.cc | 177 ++++++++++++--------- .../platform/loader/fetch/resource_fetcher.h | 13 ++ .../loader/fetch/resource_fetcher_properties.h | 5 + .../platform/loader/fetch/resource_fetcher_test.cc | 83 ++++++++++ .../testing/test_resource_fetcher_properties.h | 7 + 15 files changed, 302 insertions(+), 218 deletions(-) commit 7335d73c4e53c84c5c9a6ac917942c945461b22a Author: Keishi Hattori <keishi@chromium.org> Date: Fri Apr 19 07:47:37 2019 +0000 Change web_tests to work without universal access to file urls To introduce EventLoop concept we can't have AllowUniversalAccessFromFileURLs changing midway, and so we will be making AllowUniversalAccessFromFileURLs false for web_tests by default. This CL changes iframes with dataurl to srcdoc since srcdoc allows access without AllowUniversalAccessFromFileURLs. Change-Id: Ic99ca1aaf33c37365caf7d1218f5847fd36c0409 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531924 Reviewed-by: Taiju Tsuiki <tzik@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#652490} .../fast/dom/navigator-with-content-detached-no-crash.html | 2 +- .../fast/dom/nodesFromRect/nodesFromRect-inner-documents.html | 2 +- .../blink/web_tests/fast/events/frame-click-clear-focus.html | 4 ++-- .../blink/web_tests/fast/events/mouseout-dead-subframe.html | 2 +- .../move-element-with-wheel-and-touch-event-listeners.html | 2 +- .../web_tests/fast/events/resize-display-none-iframe.html | 11 ++++++----- .../blink/web_tests/fast/frames/adopt-iframe-into-itself.html | 2 +- .../blink/web_tests/fast/frames/frame-focus-send-blur.html | 4 ++-- third_party/blink/web_tests/fast/leaks/002.html | 2 +- .../fast/spatial-navigation/snav-hidden-iframe-zero-size.html | 2 +- .../web_tests/fast/spatial-navigation/snav-hidden-iframe.html | 2 +- .../spatial-navigation/snav-iframe-no-focusable-content.html | 4 ++-- .../spatial-navigation/snav-iframe-no-scrollable-content.html | 4 ++-- .../snav-iframe-recursive-offset-parent.html | 2 +- .../snav-iframe-with-offscreen-focusable-element.html | 2 +- .../snav-iframe-with-outside-focusable-element.html | 2 +- 16 files changed, 25 insertions(+), 24 deletions(-) commit 41ff616224de640ba876d80c9fbd28cac2dd3df2 Author: Adam Rice <ricea@chromium.org> Date: Fri Apr 19 07:45:47 2019 +0000 Rename ReadableStreamDefaultReader to ReadableStreamReader Rename the implementation of ReadableStreamDefaultReader to ReadableStreamReader. Move the ReadableStreamReaderGeneric operations into the class. This will help prepare for the future addition of ReadableStreamBYOBReader. This CL only moves and renames code. No functional changes. BUG=902633 Change-Id: Icc42ee61886be21618ca417e1783f2a1056bc1ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573558 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#652489} third_party/blink/renderer/core/streams/BUILD.gn | 3 +- third_party/blink/renderer/core/streams/README.md | 3 +- .../streams/readable_stream_default_controller.cc | 2 +- .../streams/readable_stream_default_controller.h | 2 +- .../core/streams/readable_stream_default_reader.cc | 172 ----------- .../core/streams/readable_stream_default_reader.h | 62 +--- .../core/streams/readable_stream_native.cc | 187 +----------- .../renderer/core/streams/readable_stream_native.h | 34 +-- .../core/streams/readable_stream_reader.cc | 321 +++++++++++++++++++++ .../renderer/core/streams/readable_stream_reader.h | 98 +++++++ 10 files changed, 451 insertions(+), 433 deletions(-) commit 330a6489e8b4763246e40f9d790435668e820ca5 Author: tzik <tzik@chromium.org> Date: Fri Apr 19 07:34:08 2019 +0000 Fix camel-case name conversion of "URLs" name_style_converter.py used to convert "URLs" to "ur_ls", and that is used by settings_macro.h generation. Change-Id: I8289087219ae7ca3a31c8076160d48c39c1e3251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574983 Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#652488} .../blink/renderer/build/scripts/blinkbuild/name_style_converter.py | 1 + .../renderer/build/scripts/blinkbuild/name_style_converter_test.py | 3 +++ 2 files changed, 4 insertions(+) commit 12b303006bbd944b37ea0010904e3de88ed1bd77 Author: Julie Jeongeun Kim <jkim@igalia.com> Date: Fri Apr 19 07:26:57 2019 +0000 Reland "OnionSoup: Move web_bluetooth.mojom to public/mojom/bluetooth" This is a reland of d5b00821af44d875d6cad42ae578b999ddf9316c It updates //BUILD.gn and //content/public/common/BUILD.gn in addition to the previous change to fix the dependency problem. Original change's description: > OnionSoup: Move web_bluetooth.mojom to public/mojom/bluetooth > > This CL moves bluetooth folder from public/platform/modules to > public/mojom/ to gather mojom files to mojom folder with > creating web_bluetooth_mojo_bindings. > > Bug: 919393 > Change-Id: I42037e1c9738b03969e927dd00f6b24c2873b364 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530369 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Henrique Nakashima <hnakashima@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Reviewed-by: Doug Turner <dougt@chromium.org> > Reviewed-by: Colin Blundell <blundell@chromium.org> > Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> > Cr-Commit-Position: refs/heads/master@{#649061} Bug: 919393 Change-Id: I61de3e625205e54959ad8d36c84eefa95f861035 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559368 Reviewed-by: John Budorick <jbudorick@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#652487} BUILD.gn | 2 +- components/pdf/common/BUILD.gn | 6 +-- content/browser/BUILD.gn | 2 +- content/browser/DEPS | 7 --- .../browser/bluetooth/bluetooth_allowed_devices.h | 2 +- content/browser/bluetooth/bluetooth_blocklist.h | 2 +- .../bluetooth_device_chooser_controller.h | 2 +- content/browser/bluetooth/bluetooth_metrics.h | 2 +- .../bluetooth/frame_connected_bluetooth_devices.h | 2 +- .../browser/bluetooth/web_bluetooth_service_impl.h | 2 +- .../browser/frame_host/render_frame_host_impl.h | 2 +- .../service_manager/service_manager_context.cc | 2 +- content/child/BUILD.gn | 1 - content/common/BUILD.gn | 2 +- content/common/DEPS | 1 - content/common/bluetooth/OWNERS | 3 ++ .../bluetooth/web_bluetooth_device_id.typemap | 3 +- .../web_bluetooth_device_id_struct_traits.h | 2 +- content/public/browser/BUILD.gn | 1 - content/public/common/BUILD.gn | 3 +- content/renderer/BUILD.gn | 1 - content/test/test_render_frame_host.cc | 2 +- content/utility/BUILD.gn | 1 - services/device/public/mojom/BUILD.gn | 1 - third_party/blink/public/BUILD.gn | 60 ---------------------- third_party/blink/public/mojom/BUILD.gn | 31 +++++++++++ .../{platform/modules => mojom}/bluetooth/OWNERS | 0 .../modules => mojom}/bluetooth/bluetooth.typemap | 3 +- .../bluetooth/web_bluetooth.mojom | 0 .../blink/renderer/bindings/core/v8/BUILD.gn | 1 - .../blink/renderer/modules/bluetooth/README.md | 2 +- .../blink/renderer/modules/bluetooth/bluetooth.h | 2 +- .../renderer/modules/bluetooth/bluetooth_device.h | 2 +- .../renderer/modules/bluetooth/bluetooth_error.h | 2 +- .../bluetooth_remote_gatt_characteristic.h | 2 +- .../bluetooth/bluetooth_remote_gatt_server.h | 2 +- .../bluetooth/bluetooth_remote_gatt_service.h | 2 +- third_party/blink/renderer/platform/BUILD.gn | 2 +- .../renderer/platform/mojo/blink_typemaps.gni | 2 +- .../platform/mojo/bluetooth_struct_traits.h | 2 +- 40 files changed, 63 insertions(+), 106 deletions(-) commit 46846c1226153f444aa645497f21f28995e73b06 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Fri Apr 19 07:21:25 2019 +0000 Roll src-internal fa3c64638fba..ecf68b73d5c9 (20 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fa3c64638fba..ecf68b73d5c9 Created with: gclient setdep -r src-internal@ecf68b73d5c9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:949105 TBR=fdoray@chromium.org,bsep@chromium.org,keishi@chromium.org,chanli@chromium.org Change-Id: Icd5ed364e2ba1258457cf17d897bee3fe53fb103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575380 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652486} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit a38dc4152f043e81310b0deff46f9a770b9f5fcb Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 19 06:50:50 2019 +0000 Roll src/third_party/dawn 342c6ea1a933..22cee9ae36b2 (1 commits) https://dawn.googlesource.com/dawn.git/+log/342c6ea1a933..22cee9ae36b2 git log 342c6ea1a933..22cee9ae36b2 --date=short --no-merges --format='%ad %ae %s' 2019-04-19 jiawei.shao@intel.com Enable MultisampledRenderingWithDepthTest on Windows Intel Vulkan Created with: gclient setdep -r src/third_party/dawn@22cee9ae36b2 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@chromium.org Change-Id: Ide973a3ce57b8ec5b75a16eea6983da4497eb07d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575403 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652485} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit df4b9caa58a5f941b0a686740d286bfdd4f6aa11 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 19 06:47:50 2019 +0000 Roll src/third_party/swiftshader a16238df3f28..7dd3889f2cf7 (1 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/a16238df3f28..7dd3889f2cf7 git log a16238df3f28..7dd3889f2cf7 --date=short --no-merges --format='%ad %ae %s' 2019-04-19 swiftshader.regress@gmail.com Regres: Update test lists @ a16238df Created with: gclient setdep -r src/third_party/swiftshader@7dd3889f2cf7 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: I9445b73bd19fd80fa481b68dc237a1c340abd108 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575402 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652484} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit a815a65d7776bb43b07d93e458817a0f7694fbe3 Author: Yao Xiao <yaoxia@chromium.org> Date: Fri Apr 19 06:46:23 2019 +0000 For service worker, add browser tests to check that the top_frame_origin is null and the request_initiator is the script origin. Also fixed 2 issues: - For the main resource request (serviceWorker.register(...)), it goes through FrameFetchContext::PrepareRequest() that will always set the top_frame_origin regardless whether it's from service worker. Adding a check for service worker seems to fix it. - The static function GetNetworkFactoryCallbackForTest() in embedded_worker_instance.cc returns an Optional of Callback, but the caller only checks the nullity of the Optional but not of the Callback. This sometimes is causing a crash in the test. Removing the Optional seems to fix it. Bug: 918868 Change-Id: I2a5b83d8b13b2d52310614dfb5a6dfa4d1cd620a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553948 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#652483} .../service_worker/embedded_worker_instance.cc | 12 ++--- .../service_worker/service_worker_browsertest.cc | 59 ++++++++++++++++++++++ .../service_worker_fetch_context_impl.cc | 2 - content/test/data/service_worker/one_subframe.html | 13 +++++ .../data/service_worker/request_origin_worker.js | 3 ++ services/network/public/mojom/url_loader.mojom | 19 +++++-- .../public/platform/web_worker_fetch_context.h | 2 +- .../renderer/core/loader/frame_fetch_context.cc | 9 +++- .../renderer/core/loader/worker_fetch_context.cc | 3 +- 9 files changed, 107 insertions(+), 15 deletions(-) commit 5e89e2ef375757a30335ae515ddc66f5637fc6f7 Author: Meilin Wang <meilinw@google.com> Date: Fri Apr 19 06:43:00 2019 +0000 Add unit tests for Assistant key remapping. This change expands the unit tests to cover the Assistant key remapping feature. Misc: fix typo and lint errors. Bug: None. Test: Local compile and run tests changed in this CL. Change-Id: I21a559a4d2cec07f581bcc3573034520c6c79c3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570806 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by: Tao Wu <wutao@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#652482} .../chromeos/device_keyboard_handler_unittest.cc | 41 ++++++++++++++++++---- .../test/data/webui/settings/device_page_tests.js | 16 +++++++++ 2 files changed, 50 insertions(+), 7 deletions(-) commit 263e7db86c6f187244392abe262d1206639b95c6 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 19 06:26:20 2019 +0000 Roll src/third_party/catapult 9f474a8e0e81..7f8529c21699 (1 commits) https://chromium.googlesource.com/catapult.git/+log/9f474a8e0e81..7f8529c21699 git log 9f474a8e0e81..7f8529c21699 --date=short --no-merges --format='%ad %ae %s' 2019-04-19 benjhayden@chromium.org Display median and 90th% in multi-event-sub-view Created with: gclient setdep -r src/third_party/catapult@7f8529c21699 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=oysteine@chromium.org Change-Id: If6bb33f87052693a47491f230372f0a171a2f7c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575401 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652481} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 1985193e542bb74ac533b53cd0cfed6eee81fb44 Author: Yue Zhang <yuezhanggg@google.com> Date: Fri Apr 19 05:52:28 2019 +0000 Add favicons to tabgrid thumbnails Add a layer of callback in MultiThumbnailCardProvider to fetch favicon and draw with shadowed circle background in thumbnail. Bug: 946286 Change-Id: Id4fce1c635d1f639778476730ba7cea131496376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574639 Commit-Queue: Yue Zhang <yuezhanggg@google.com> Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#652480} .../tab_management/MultiThumbnailCardProvider.java | 130 +++++++++++++++------ .../tasks/tab_management/SilenceLintErrors.java | 7 +- .../tab_management/TabListFaviconProvider.java | 28 ++--- chrome/android/java/res/values/dimens.xml | 5 + 4 files changed, 122 insertions(+), 48 deletions(-) commit b1603f083d6c67ad594055ee92af03b9ce0ec6af Author: liberato@chromium.org <liberato@chromium.org> Date: Fri Apr 19 05:43:48 2019 +0000 Select video decoder implementations for MojoVideoDecoder This CL enables the following: - SupportedVideoDecoderConfigs are now returned from the GPU process as a map [video decoder implementation] => vector of SupportedVideoDecoderConfig for that implementation. - GpuVideoAcceleratorFactories::IsDecoderConfigSupported takes the implementation enum value as an additional argument, and checks only against that implementation's supported configs. - MojoVideoDecoder accepts an implementation enum during construction, which will be provided to the service during decoder initialization. - GpuMojoMediaClient uses the kAlternate implementation enum value to select D3D11VideoDecoder on Windows, if the experiment is currently enabled. It no longer uses FallbackVideoDecoder. - MojoDecoderFactory adds a kAlternate decoder, in addition to the kDefault decoder, on Windows if the experiment is enabled. - RTCVideoDecoderAdapter always selects the default video decoder implementation. This causes RTC on windows to use only DXVA, rather than D3D11VideoDecoder. This will be addressed as follow- up work, though likely not immediately. The main reason for this is that it lets the renderer's decoder selection algorithm see two MojoVideoDecoder instances: one for DXVA and one for D3D11VideoDecoder. This lets decoder selection and fallback happen normally for them, rather than having the fallback happen in the GPU process via FallbackVideoDecoder. Bug: 954422 Change-Id: If6f056723c11ff50327623ac8d554d9f5da9f499 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534984 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Xing Liu <xingliu@chromium.org> Reviewed-by: Dan Sanders <sandersd@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#652479} .../android/download/download_media_parser.cc | 4 +- .../browser_gpu_video_accelerator_factories.cc | 2 + .../browser_gpu_video_accelerator_factories.h | 2 + .../gpu/gpu_video_accelerator_factories_impl.cc | 24 ++++++- .../gpu/gpu_video_accelerator_factories_impl.h | 7 +- .../media/webrtc/rtc_video_decoder_adapter.cc | 11 +++- .../webrtc/rtc_video_decoder_adapter_unittest.cc | 12 ++-- media/base/ipc/media_param_traits_macros.h | 4 ++ media/mojo/clients/mojo_decoder_factory.cc | 19 +++++- media/mojo/clients/mojo_video_decoder.cc | 8 ++- media/mojo/clients/mojo_video_decoder.h | 4 +- media/mojo/interfaces/video_decoder.mojom | 19 +++--- media/mojo/interfaces/video_decoder.typemap | 1 + media/mojo/services/gpu_mojo_media_client.cc | 74 ++++++++++++---------- media/mojo/services/gpu_mojo_media_client.h | 7 +- media/mojo/services/mojo_media_client.cc | 6 +- media/mojo/services/mojo_media_client.h | 13 ++-- media/mojo/services/mojo_video_decoder_service.cc | 7 +- media/mojo/services/mojo_video_decoder_service.h | 4 +- .../test/mojo_video_decoder_integration_test.cc | 7 +- media/video/gpu_video_accelerator_factories.h | 8 ++- media/video/mock_gpu_video_accelerator_factories.h | 6 +- media/video/supported_video_decoder_config.h | 14 ++++ 23 files changed, 177 insertions(+), 86 deletions(-) commit d88299f9fa0dd3764d9b2a5706fd794a13631b2a Author: Kenichi Ishibashi <bashi@chromium.org> Date: Fri Apr 19 05:39:58 2019 +0000 wpt: Fix dedicated-worker-options-credentials.html Before this CL credentials.py tried to get "Origin" header value unconditionally and resulted in an internal server error. This CL changes credentials.py so that it sets "Access-Control-Allow-Origin" only when "Origin" header is supplied. Bug: 952266 Change-Id: I804d538cc24c2fb51d0c156400425e056d51fb7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575300 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#652478} third_party/blink/web_tests/TestExpectations | 3 --- .../web_tests/external/wpt/workers/modules/resources/credentials.py | 5 ++++- 2 files changed, 4 insertions(+), 4 deletions(-) commit cb43a25a21f104178682b3dc3ab9753ec511b991 Author: Jeremy Roman <jbroman@chromium.org> Date: Fri Apr 19 05:38:18 2019 +0000 Use ASCII case conversion in PasswordCredential. It's what's expected per spec, and it's more efficient. Bug: 627682 Change-Id: I5462a9c34cf9a1b6f2825e9e0c58e3c64b8c1698 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575034 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#652477} .../blink/renderer/modules/credentialmanager/password_credential.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 62bf1c59b31bd9952b7f2cb71891ffdd1aaaf98c Author: liberato@chromium.org <liberato@chromium.org> Date: Fri Apr 19 05:35:49 2019 +0000 Add unweighted base tree / table experiments. Since the enhanced unweighted tree experiment seems to give us good results compared to the weighted base / enhanced tree and base table, add unweighted variants of the base tree and table. The goal is to see if unweighted examples help more or less with the (a) base features vs enhanced features, and (b) with the table vs the decision tree. Change-Id: Ie5b5938d42f6085518662e2a198e0d8a10e92cdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570702 Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#652476} media/capabilities/learning_helper.cc | 41 +++++++++++++++++++++++++++++---- media/capabilities/learning_helper.h | 7 +++++- tools/metrics/histograms/histograms.xml | 11 ++++++--- 3 files changed, 50 insertions(+), 9 deletions(-) commit dad2a32ca826210010e2ab95f728857ee3631b65 Author: dpapad <dpapad@chromium.org> Date: Fri Apr 19 05:34:49 2019 +0000 WebUI cleanup: Remove cr.getUid(), cr.createUid() and cr.makePublic(). Specifically: - cr.makePublic() was not used anywhere. - cr.getUid() was only used in one place, which is being replaced by using a Map instead. - cr.createUid() is still used, but only within cr.js, and therefore there is no need to export it on the cr namespace anymore. Note that the removal of cr.makePublic() also allows removing some code from https://github.com/google/closure-compiler/blob/master/src/com/google/javascript/jscomp/ChromePass.java Bug: None Change-Id: Ie1791cfac7c9c3658dff722556850a04dda81e80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575027 Reviewed-by: Dan Beam <dbeam@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#652475} ui/webui/resources/js/cr.js | 38 ---------------------------------- ui/webui/resources/js/cr/ui/command.js | 8 +++---- 2 files changed, 4 insertions(+), 42 deletions(-) commit 30de7d941688e6e4bbaa5a169c615bcaa8da11fa Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 19 05:26:19 2019 +0000 Roll src/third_party/angle ac58e63295f0..145ec7fa7c81 (1 commits) https://chromium.googlesource.com/angle/angle.git/+log/ac58e63295f0..145ec7fa7c81 git log ac58e63295f0..145ec7fa7c81 --date=short --no-merges --format='%ad %ae %s' 2019-04-19 kainino@chromium.org Revert "Define and expose EGL_ANGLE_power_preference extension." Created with: gclient setdep -r src/third_party/angle@145ec7fa7c81 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:2813 TBR=cwallez@chromium.org Change-Id: I8a909db355d5431ccb853b96e68eedddabe9512e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574437 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652474} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit c499dbdf61868335695b87669f10cbd295e74c92 Author: Rakina Zata Amni <rakina@chromium.org> Date: Fri Apr 19 05:24:59 2019 +0000 [DL]: Handle commit() calls that happen on the same frame as activation It's possible to be in a committing state without having a commit promise resolver, if the commit is caused by activation. This causes problems with commit() calls that happen on the same frame as activation-induced commit, as it expects the resolver to exist. This CL handles that case and adds a test. Bug: 953614 Change-Id: I83ba0b6e450672588ff960389fc045be4896fe32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573425 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Fergal Daly <fergal@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#652473} .../core/display_lock/display_lock_context.cc | 29 ++++++------- .../activation/activate-commit-same-frame.html | 49 ++++++++++++++++++++++ .../activate-update-and-commit-same-frame.html | 49 ++++++++++++++++++++++ .../activation/activate-update-same-frame.html | 48 +++++++++++++++++++++ 4 files changed, 159 insertions(+), 16 deletions(-) commit 12505b8e6e77fa4b7e269a17a245dffc0e6afa91 Author: Tao Bai <michaelbai@chromium.org> Date: Fri Apr 19 05:13:58 2019 +0000 Uses node address for removed node id This case will be covered in Java integration test. Bug: 954387 Change-Id: I1b34a031d47e97fbcabd24f4363ce6ca9fe97579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574946 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#652472} third_party/blink/renderer/core/content_capture/task_session.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit a8315825547cec11aa7c8cdefbb7ec1a0e028099 Author: Keishi Hattori <keishi@chromium.org> Date: Fri Apr 19 05:07:40 2019 +0000 Revert "[Tab Groups] Stop using TabGroupData pointers as group IDs." This reverts commit 133ed70bda2e19965af6d55a77795835207c6b7b. Reason for revert: Caused NewTabFromLinkOpensInGroup and others to fail https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.memory/builders/Linux%20ChromiumOS%20MSan%20Tests/builds/12442 Original change's description: > [Tab Groups] Stop using TabGroupData pointers as group IDs. > > Tab groups are currently identified using TabGroupData pointers. However, > this is fragile because those pointers may not be valid forever and > because memory address may be reused. It makes more sense to use an > opaque int ID for this purpose instead. This also allows the API to > explicitly define when a group may be null or not, by using > base::Optional. Also, in a future patch, tab_strip_layout.h/cc will be > able to operate using that ID and continue to avoid knowledge of any > particular View type. > > This patch also includes some miscellaneous refactoring in > tab_strip_model_unittest.cc. > > Bug: 905491 > Change-Id: I9700a50d5fa9e4050ec2169af8e1362d11d9dade > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562764 > Commit-Queue: Bret Sepulveda <bsep@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Taylor Bergquist <tbergquist@chromium.org> > Cr-Commit-Position: refs/heads/master@{#652391} TBR=pkasting@chromium.org,bsep@chromium.org,tbergquist@chromium.org Change-Id: I1ede97f8791b79649fbf6d98947fbb1567d8fee2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 905491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575259 Reviewed-by: Keishi Hattori <keishi@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#652471} chrome/browser/ui/browser_navigator_params.h | 3 +- .../browser/ui/browser_tab_strip_model_delegate.cc | 2 +- .../browser/ui/browser_tab_strip_model_delegate.h | 2 +- chrome/browser/ui/browser_tabstrip.cc | 2 +- chrome/browser/ui/browser_tabstrip.h | 4 +- .../ui/tabs/existing_tab_group_sub_menu_model.cc | 25 +- .../ui/tabs/existing_tab_group_sub_menu_model.h | 3 +- chrome/browser/ui/tabs/tab_group_data.cc | 10 +- chrome/browser/ui/tabs/tab_menu_model.cc | 2 +- chrome/browser/ui/tabs/tab_strip_model.cc | 95 ++--- chrome/browser/ui/tabs/tab_strip_model.h | 61 ++-- chrome/browser/ui/tabs/tab_strip_model_delegate.h | 4 +- chrome/browser/ui/tabs/tab_strip_model_observer.cc | 23 +- chrome/browser/ui/tabs/tab_strip_model_observer.h | 24 +- chrome/browser/ui/tabs/tab_strip_model_unittest.cc | 398 ++++++++++++++------- .../ui/tabs/test_tab_strip_model_delegate.cc | 2 +- .../ui/tabs/test_tab_strip_model_delegate.h | 5 +- .../ui/views/tabs/browser_tab_strip_controller.cc | 12 +- .../ui/views/tabs/browser_tab_strip_controller.h | 3 +- .../views/tabs/fake_base_tab_strip_controller.cc | 39 +- .../ui/views/tabs/fake_base_tab_strip_controller.h | 14 +- chrome/browser/ui/views/tabs/tab_strip.cc | 24 +- chrome/browser/ui/views/tabs/tab_strip.h | 12 +- .../browser/ui/views/tabs/tab_strip_controller.h | 7 +- chrome/browser/ui/views/tabs/tab_strip_unittest.cc | 11 +- 25 files changed, 433 insertions(+), 354 deletions(-) commit 56936d5a7e817d1be6e429603dff2391a4b51402 Author: Chromium WPT Sync <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Date: Fri Apr 19 04:43:02 2019 +0000 Import wpt@4131304c0d6b6a94b6bc4c4c0c9818a66fe31c39 Using wpt-import in Chromium 3d140e8c4599f567fcd0d6ed7010c23e16174851. With Chromium commits locally applied on WPT: 0a8f3ffa48 "Use testdriver Action API in WPT pointerevent touch tests - Part 2" 4e9215207a "[Code Health] Remove unnecessary reference file for web test" 40465b7400 "[Animation Worklet] Copy the effects of a migrating animator over to new global scope" e28269b698 "[LayoutNG/PE] Clear visual overflow for LayoutText before setting." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: raphael.kubo.da.costa@intel.com, rijubrata.bhaumik@intel.com, timvolodine@chromium.org: external/wpt/generic-sensor NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I762bf86e2ad7c862ebaf7480c7560efb389cd2a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574433 Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652470} .../web_tests/external/WPT_BASE_MANIFEST_6.json | 141 +++++++++++++++------ .../wpt/generic-sensor/generic-sensor-tests.js | 7 +- 2 files changed, 109 insertions(+), 39 deletions(-) commit 4f149a19e11b04502c5fc40386227b5f00f9c059 Author: Chris Lu <thegreenfrog@chromium.org> Date: Fri Apr 19 04:30:08 2019 +0000 [ios] Hide Setting kMetricsReportingWifiOnly behind Feature Flag UMA over Cellular feature removes kMetricsReportingWifiOnly local pref. Tests will fail if retrieving or setting occurs. Bug: 931289 Change-Id: Ibda70e02dde35f50426f6501210130a8c2834be0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574837 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#652469} ios/chrome/browser/ui/settings/google_services/BUILD.gn | 1 + .../google_services/google_services_settings_mediator.mm | 15 +++++++++++---- 2 files changed, 12 insertions(+), 4 deletions(-) commit b57f92f48ffca613e3233daaa160cbf0a109da44 Author: Meilin Wang <meilinw@google.com> Date: Fri Apr 19 04:27:10 2019 +0000 Add new feature flag for Assistant key remapping. This change adds a new flag in chrome://flags to enable Assistant key remapping in the keyboard settings. Bug: None. Test: local compile and manually test. Change-Id: I9708e705da6e9e012089a4559965cb2f431bd87f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573002 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#652468} chrome/browser/about_flags.cc | 5 +++++ chrome/browser/flag-metadata.json | 5 +++++ chrome/browser/flag_descriptions.cc | 5 +++++ chrome/browser/flag_descriptions.h | 3 +++ tools/metrics/histograms/enums.xml | 2 ++ 5 files changed, 20 insertions(+) commit efb6fcfbc3c74932c8030feaafaf90b725604a68 Author: Lily Chen <chlily@chromium.org> Date: Fri Apr 19 04:17:54 2019 +0000 Reporting: Refactor ReportingCache's storage of clients and endpoints See https://docs.google.com/document/d/19vDLCRVP-WvWxA_YNZfhkkW6fS5A2Ea9ulJ8i8AcPAM/edit?usp=sharing for details. This CL refactors the client side of the ReportingCacheImpl. Clients, endpoint groups, and endpoints are now represented by separate structs. The cache stores each in separate maps. Endpoints are evicted if an origin exceeds the per-origin endpoint limit, or if the cache exceeds the global endpoint limit. This fixes an incorrect assumption made by the previous implementation that a given endpoint URL cannot be in multiple groups for the same origin. Bug: 912951 Change-Id: I0c548c3cf20ac57a9f17482300dd9a57a14e53b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1453109 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by: Joshua Bell <jsbell@chromium.org> Reviewed-by: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#652467} .../browsing_data_remover_impl_unittest.cc | 57 +- net/http/http_network_transaction_unittest.cc | 14 +- net/reporting/reporting_browsing_data_remover.cc | 13 +- .../reporting_browsing_data_remover_unittest.cc | 53 +- net/reporting/reporting_cache.h | 211 ++-- net/reporting/reporting_cache_impl.cc | 1127 +++++++++++++++----- net/reporting/reporting_cache_impl.h | 276 ++++- net/reporting/reporting_cache_unittest.cc | 630 +++++++---- net/reporting/reporting_client.cc | 92 +- net/reporting/reporting_client.h | 161 ++- net/reporting/reporting_delivery_agent.cc | 42 +- net/reporting/reporting_delivery_agent_unittest.cc | 109 +- net/reporting/reporting_endpoint_manager.cc | 60 +- net/reporting/reporting_endpoint_manager.h | 17 +- .../reporting_endpoint_manager_unittest.cc | 150 +-- net/reporting/reporting_garbage_collector.cc | 2 + net/reporting/reporting_header_parser.cc | 123 +-- net/reporting/reporting_header_parser.h | 14 +- net/reporting/reporting_header_parser_fuzzer.cc | 12 +- net/reporting/reporting_header_parser_unittest.cc | 650 +++++++++-- .../reporting_network_change_observer_unittest.cc | 39 +- net/reporting/reporting_policy.cc | 4 +- net/reporting/reporting_policy.h | 10 +- net/reporting/reporting_policy.proto | 7 +- net/reporting/reporting_service_unittest.cc | 18 +- net/reporting/reporting_test_util.cc | 74 +- net/reporting/reporting_test_util.h | 55 +- services/network/network_context_unittest.cc | 48 +- tools/metrics/histograms/enums.xml | 8 +- 29 files changed, 2898 insertions(+), 1178 deletions(-) commit 52a28e416a9c4fe3a939f1fbdee309fef52b3c91 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 19 04:11:44 2019 +0000 Roll src/third_party/swiftshader 96fbe0810a3f..a16238df3f28 (3 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/96fbe0810a3f..a16238df3f28 git log 96fbe0810a3f..a16238df3f28 --date=short --no-merges --format='%ad %ae %s' 2019-04-19 chrisforbes@google.com Add support for OpAtomicCompareExchange 2019-04-19 chrisforbes@google.com Add support atomic instructions as used with storage images 2019-04-19 chrisforbes@google.com Add support for OpImageTexelPointer Created with: gclient setdep -r src/third_party/swiftshader@a16238df3f28 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/130768731,chromium:b/127472316,chromium:b/130768731,chromium:b/127472316,chromium:b/130768731 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I176d249ff7276933d0a27012a78d280db710657b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575358 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652466} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 94482e33ea728f367bc8c7085c29b4f52c21581c Author: Yoshifumi Inoue <yosin@chromium.org> Date: Fri Apr 19 04:03:42 2019 +0000 Introduce CompositeEditCommand::RemoveAllChildrenIfPossible() This patch Introduces |CompositeEditCommand::RemoveAllChildrenIfPossible()| to avoid infinite root in |TypingCommand| and |DeleteSelectionCommand|. This patch is a continuation of the CL[1]. Note: no regression test as there's no minimized test case in the original report, and it's not worth the minimization because the bug is a rather edge case that requires an editable <style> element that specifies editable style on its parent using deprecated '-webkit-user-modify'. [1] http://crrev.com/c/1567098 [Editing] Abort TypingCommand when RemoveNode() fails to remove a node Bug: 949501 Change-Id: I9bd19da22f54cd7cbda735103c599a5082f8d94f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573434 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#652465} .../editing/commands/composite_edit_command.cc | 19 +++++++++++++++ .../core/editing/commands/composite_edit_command.h | 5 ++++ .../editing/commands/delete_selection_command.cc | 28 +++++----------------- .../core/editing/commands/typing_command.cc | 8 +++---- 4 files changed, 33 insertions(+), 27 deletions(-) commit a55917cb98249d2059189502d2fa9851c466dcd4 Author: rbpotter <rbpotter@chromium.org> Date: Fri Apr 19 03:47:57 2019 +0000 WebUI dark mode: Make cr-input background consistent with md-selects - Make cr-input's background color consistent with md-select - Fix the background of the search icon in Print Preview's search box cr-input, so that it is the same color as the rest of the input. Bug: 954416 Change-Id: Iecc5c342ef6bd7f9e0400642ab6bab117164a79a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575029 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#652464} .../browser/resources/print_preview/new/print_preview_search_box.html | 1 - ui/webui/resources/cr_elements/cr_input/cr_input_style_css.html | 3 ++- 2 files changed, 2 insertions(+), 2 deletions(-) commit c4ec443645a60ddc55833668c0518858f13b847f Author: Matt Falkenhagen <falken@chromium.org> Date: Fri Apr 19 03:21:28 2019 +0000 service worker: Remove obsolete netlog events. These are no longer used following the launch of S13nServiceWorker. Bug: 926114 Change-Id: Ie9c74c0ed88d15f505c23c15a111271a96874566 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573427 Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#652463} net/log/net_log_event_type_list.h | 129 -------------------------------------- 1 file changed, 129 deletions(-) commit d62fe8a99f3c5f6d15b14a47e34662f6a8f35e5d Author: Shu Chen <shuchen@chromium.org> Date: Fri Apr 19 03:19:33 2019 +0000 Removes IsInterestedInKeyEvent() method in IMEEngineHandlerInterface. This makes the non-mojo-imf and mojo-imf have the consistent logic to handle key events. Bug: 937167 Change-Id: I90a9a8ce8a776a4144203062b56297d2fcb572f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574981 Reviewed-by: Lan Wei <azurewei@chromium.org> Commit-Queue: Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#652462} .../input_method/mock_input_method_engine.cc | 4 --- .../input_method/mock_input_method_engine.h | 1 - .../ui/input_method/input_method_engine_base.cc | 4 --- .../ui/input_method/input_method_engine_base.h | 1 - ui/base/ime/chromeos/input_method_chromeos.cc | 30 ++++++++-------------- ui/base/ime/chromeos/mock_ime_engine_handler.cc | 4 --- ui/base/ime/chromeos/mock_ime_engine_handler.h | 1 - ui/base/ime/ime_engine_handler_interface.h | 4 --- ui/base/ime/linux/input_method_auralinux.cc | 3 +-- ui/base/ime/win/input_method_win_base.cc | 3 +-- ui/base/ime/win/input_method_win_imm32.cc | 4 +-- 11 files changed, 14 insertions(+), 45 deletions(-) commit e794141ee23065f82ac311e3de8e88188d1d17c8 Author: Jarryd <jarrydg@chromium.org> Date: Fri Apr 19 03:18:37 2019 +0000 Quota: Ship Quota usage details by default. This change removes the feature flag that guards quota usage details and will thus enable the feature by default. Intent to Ship: https://groups.google.com/a/chromium.org/d/topic/blink-dev/lq83adC8QRo/discussion Bug: 904000 Change-Id: I729d807dcbe1861b7ae38296c2db96a42f0791a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570533 Auto-Submit: Jarryd Goodman <jarrydg@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#652461} .../blink/renderer/platform/runtime_enabled_features.json5 | 2 +- .../webexposed/storage-estimate-usage-details-expected.txt | 4 ---- .../web_tests/webexposed/storage-estimate-usage-details.html | 9 --------- 3 files changed, 1 insertion(+), 14 deletions(-) commit 6e720c5d7b22d9230f8f8fe4c874b84589da30cf Author: chrome-release-bot <chrome-release-bot@chromium.org> Date: Fri Apr 19 03:16:11 2019 +0000 Updating trunk VERSION from 3770.0 to 3771.0 and incrementing major version to 76 # This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: I379b273c6a440e753ce27eb8cbaac9fbbb93121f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575086 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#652460} chrome/MAJOR_BRANCH_DATE | 2 +- chrome/VERSION | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) commit 3d10bb3c11d46ad34b2fc304f93a0ae1a54c6d16 Author: Rakina Zata Amni <rakina@chromium.org> Date: Fri Apr 19 03:12:07 2019 +0000 Change frame tree node traversal in FindRequestManager There's a bug in TraverseNext that might cause a node to traverse back to itself, even though it should've traversed to another node, triggering an infinite loop. This is caused by treating inner WebContents as children of the main frame, and potentially adding the same node as a child of multiple nodes. This CL changes the child/parent frame tree node traversal in FindManager, such that we won't encounter these cases anymore. Bug: 942346 Change-Id: I030492cb4c8a2aa330c71a15f9f337eb7ed0f3b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530219 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#652459} .../chrome_mime_handler_view_browsertest.cc | 27 ++++++++++ .../mime_handler_view/find_in_page_one_frame.html | 8 +++ .../browser/browser_plugin/browser_plugin_guest.cc | 4 ++ .../browser/browser_plugin/browser_plugin_guest.h | 4 ++ content/browser/find_request_manager.cc | 58 +++++++++++++--------- .../browser/browser_plugin_guest_delegate.cc | 5 ++ .../public/browser/browser_plugin_guest_delegate.h | 4 ++ .../mime_handler_view/mime_handler_view_guest.h | 3 +- 8 files changed, 87 insertions(+), 26 deletions(-) commit 603bb8dfeeff79c16612ae9fe40e0c8a040ac3cc Author: Takashi Toyoshima <toyoshim@chromium.org> Date: Fri Apr 19 03:11:55 2019 +0000 OOR-CORS: Introduce an entry limit to the CORS preflight cache Since CORS preflight cache can live for a longer time in OOR-CORS mode, we introduce an entry limit to the CORS preflight cache. Also this patch adds a metric to count cache entries. Bug: 736308 Change-Id: Icd0ed0664d4bc592e921a632126ba88d1425f50b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573519 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#652458} .../network/public/cpp/cors/preflight_cache.cc | 49 +++++++++++++++++++++- services/network/public/cpp/cors/preflight_cache.h | 12 ++++++ .../public/cpp/cors/preflight_cache_unittest.cc | 8 ++++ tools/metrics/histograms/histograms.xml | 10 +++++ 4 files changed, 78 insertions(+), 1 deletion(-) commit 35badfaaf5c2adc2762f786474c30639de634aa3 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 19 03:08:52 2019 +0000 Roll src/third_party/chromite 067b46c33eed..641336160936 (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/067b46c33eed..641336160936 git log 067b46c33eed..641336160936 --date=short --no-merges --format='%ad %ae %s' 2019-04-19 manojgupta@google.com chromeos_config: Enable skylab for toolchain builders. Created with: gclient setdep -r src/third_party/chromite@641336160936 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I2e13b4066efe8b67d075a7f527cad6085f345e90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574371 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652457} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 2d0cbdd2a4a5fa32f5e0ac07e0e064cfffbf64c8 Author: Austin Eng <enga@chromium.org> Date: Fri Apr 19 03:08:47 2019 +0000 Make GPUDevice error callback log to console This allows us to know when errors have occured since the error handling API has not been implemented yet. Change-Id: Ic7f6b03b086393e5d25a54543ce9500c8e66bd2f Bug: 877147 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546059 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#652456} .../blink/renderer/modules/webgpu/gpu_adapter.cc | 5 ++-- .../blink/renderer/modules/webgpu/gpu_device.cc | 32 ++++++++++++++++++---- .../blink/renderer/modules/webgpu/gpu_device.h | 10 ++++++- 3 files changed, 39 insertions(+), 8 deletions(-) commit a76dd5034c8d8dea37cad6950690a1526431d37c Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 19 03:04:59 2019 +0000 Roll src/third_party/angle 85a239d09128..ac58e63295f0 (1 commits) https://chromium.googlesource.com/angle/angle.git/+log/85a239d09128..ac58e63295f0 git log 85a239d09128..ac58e63295f0 --date=short --no-merges --format='%ad %ae %s' 2019-04-19 kbr@chromium.org Define and expose EGL_ANGLE_power_preference extension. Created with: gclient setdep -r src/third_party/angle@ac58e63295f0 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:2813 TBR=cwallez@chromium.org Change-Id: I2be116ffebdaf7dc15a8fbf540f0994b5389ec8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574372 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652455} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 90bd56d103bc1b56b17c7ccafd5f8b3ae6a38a35 Author: Matt Falkenhagen <falken@chromium.org> Date: Fri Apr 19 03:01:07 2019 +0000 service worker: Remove service worker from ResourceRequestorInfo. This was needed for navigation preloads in the non-S13nServiceWorker path. It's obsolete following the launch of S13nServiceWorker. TBR=kinuko Bug: 926114 Change-Id: Ic808c733e4da886566567ce3036de0a65a810b40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572762 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#652454} .../loader/resource_dispatcher_host_impl.cc | 22 +-------- .../loader/resource_dispatcher_host_unittest.cc | 1 - content/browser/loader/resource_message_filter.cc | 3 -- content/browser/loader/resource_message_filter.h | 6 +-- content/browser/loader/resource_requester_info.cc | 53 ++-------------------- content/browser/loader/resource_requester_info.h | 23 ---------- content/browser/loader/url_loader_factory_impl.cc | 1 - .../loader/url_loader_factory_impl_unittest.cc | 1 - .../renderer_host/render_process_host_impl.cc | 1 - 9 files changed, 9 insertions(+), 102 deletions(-) commit bd446bff4abf36a79f87966e017eeff6f76365d3 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 19 02:49:05 2019 +0000 Roll src/third_party/catapult ad74585cca1c..9f474a8e0e81 (1 commits) https://chromium.googlesource.com/catapult.git/+log/ad74585cca1c..9f474a8e0e81 git log ad74585cca1c..9f474a8e0e81 --date=short --no-merges --format='%ad %ae %s' 2019-04-18 benjhayden@chromium.org Migrate cp-switch to es6 module Created with: gclient setdep -r src/third_party/catapult@9f474a8e0e81 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:950011 TBR=oysteine@chromium.org Change-Id: I6732014cacb097f379e462509469a5c6d3ebf4e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574370 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652453} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 3d140e8c4599f567fcd0d6ed7010c23e16174851 Author: rajendrant <rajendrant@chromium.org> Date: Fri Apr 19 02:33:04 2019 +0000 Add better check for page ID in chrome-proxy header Change-Id: I1e38e6d983a0f46c8ace24bfe19a97600f90675b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575127 Reviewed-by: Tarun Bansal <tbansal@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#652452} chrome/browser/data_reduction_proxy/data_reduction_proxy_browsertest.cc | 1 + 1 file changed, 1 insertion(+) commit 1247389d01a3e2f6c9043063982e2b873e2e986b Author: Drew Fisher <zarvox@google.com> Date: Fri Apr 19 02:03:18 2019 +0000 [fuchsia] Mark VMO from fdio_get_vmo_clone() exec Fuchsia's fdio_get_vmo_clone is documented as returning a read-only clone of the underlying VMO, but has long returned a vmo that is both readable and exec-capable. As we try to bring the implementation in line with the docs and make fewer APIs imply executability, we need to update callers to not rely on the implicit executability of the VMO, but to add that right explicitly. Bug: 954263 Change-Id: I4cc14e99b095d432f3163d7d85b70428393e83e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574688 Commit-Queue: Drew Fisher <zarvox@google.com> Auto-Submit: Drew Fisher <zarvox@google.com> Reviewed-by: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#652451} base/native_library_fuchsia.cc | 15 +++++++++++++++ 1 file changed, 15 insertions(+) commit 7e1651a23dd0db8371e42d88cedc1f2815091ebc Author: Lambros Lambrou <lambroslambrou@chromium.org> Date: Fri Apr 19 01:44:49 2019 +0000 Refactor OAuthTokenGetterImpl for token-exchange This is a very simple refactor, to facilitate hooking in a token-exchange service. Bug: 954427 Change-Id: If7b7a3528cd38090c64d6ab4e6990793ff5469ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575128 Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#652450} remoting/base/oauth_token_getter_impl.cc | 19 +++++++++++-------- remoting/base/oauth_token_getter_impl.h | 5 +++++ 2 files changed, 16 insertions(+), 8 deletions(-) commit 98c35081ed76b430e27842c3673b7e2e4e2b2a4c Author: dpapad <dpapad@chromium.org> Date: Fri Apr 19 01:43:42 2019 +0000 File Manager: Convert cast_video_element.js to ES6 class syntax. This is in preparation of removing the custom cr.EventTarget implementation in favor of native EventTarget, which requires all subclasses to be ES6 classes, otherwise a runtime "Illegal invocation" error is thrown. Bug: 854268,778674 Change-Id: I77e4924d9e22eb58d90f35e5c7b37b5f61759649 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574212 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#652449} .../video_player/js/cast/cast_video_element.js | 156 +++++++++++---------- 1 file changed, 79 insertions(+), 77 deletions(-) commit 52f2305eadf19abf74f07cf64e705dfd6a4a0718 Author: Hector Carmona <hcarmona@chromium.org> Date: Fri Apr 19 01:33:25 2019 +0000 Navi: Don't show onboarding if all modules are disabled. Bug: 951840 Change-Id: I628d3c86af68f2b36231b2497bdabf701c7ad8b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574607 Reviewed-by: Dan Beam <dbeam@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#652448} chrome/browser/ui/startup/startup_browser_creator_impl.cc | 10 ++++++++++ chrome/browser/ui/webui/welcome/nux_helper.cc | 4 ++++ chrome/browser/ui/webui/welcome/nux_helper.h | 2 ++ 3 files changed, 16 insertions(+) commit 285ee2f17f503b0749059ef2a62f24babc72c64b Author: Bret Sepulveda <bsep@chromium.org> Date: Fri Apr 19 01:32:22 2019 +0000 Re-enable passing printing tests. The following tests are passing now, so removing TestExpectations lines. * printing/list-item-with-empty-first-line.html * printing/quirks-percentage-height.html * virtual/threaded/printing/quirks-percentage-height.html * printing/subframes-percentage-height.html * virtual/threaded/printing/subframes-percentage-height.html TBR=forshaw@chromium.org Bug: 591500 Change-Id: I14e5781021d816fd78707e3c2a4df841e95959f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575028 Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#652447} third_party/blink/web_tests/TestExpectations | 5 ----- 1 file changed, 5 deletions(-) commit ea29cb8fd0070ae3032cd1d23ec3afe1108965e3 Author: Joey Arhar <jarhar@chromium.org> Date: Fri Apr 19 01:31:39 2019 +0000 [DevTools] Include DevTools headers in webRequest WebSocket WebRequestProxyingWebSocket currently ignores the user-agent override set by DevTools present in the additional_headers parameter of AddChannelRequest. This patch stores additional_headers and forwards them if they are not already overriden by an extension. Bug: 941433 Change-Id: I340d3358293bd0a56732b41f2db7e8e854c85486 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1544246 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by: Ken Rockot <rockot@google.com> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#652446} .../devtools/devtools_sanity_browsertest.cc | 17 ++++++++++++++ .../devtools/extensions/web_request/manifest.json | 8 +++++++ .../web_request/web_request_proxying_websocket.cc | 10 ++++++++ .../web_request/web_request_proxying_websocket.h | 1 + .../blink/renderer/devtools/front_end/Tests.js | 27 ++++++++++++++++++++++ 5 files changed, 63 insertions(+) commit 5b54989e9928f400b1b31826130fe14fa4b31601 Author: Daniel Cheng <dcheng@chromium.org> Date: Fri Apr 19 01:30:28 2019 +0000 //ui/gfx/mojo/buffer_types.mojom: Remove unnecessary _LAST enum values. Mojo provides predefined kMaxValue for circumstances where these sorts of values would be useful, so defining _LAST is redundant. In this case, it's only used to handle the NOTREACHED() case in the enum traits; just map the NOTREACHED() case to something arbitrary. Change-Id: Ieaca8b83f051f75f64071542c6135a0ddaca8544 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570735 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#652445} ui/gfx/mojo/buffer_types.mojom | 4 ---- ui/gfx/mojo/buffer_types_struct_traits.h | 4 ++-- 2 files changed, 2 insertions(+), 6 deletions(-) commit ffaa5f9dc8d747bc15edb11aa2d764cac9109fe5 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 19 01:29:24 2019 +0000 Roll src/third_party/chromite b76dd93cb5bb..067b46c33eed (5 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/b76dd93cb5bb..067b46c33eed git log b76dd93cb5bb..067b46c33eed --date=short --no-merges --format='%ad %ae %s' 2019-04-18 tomhughes@chromium.org chromeos_config: fix chromite-pre-cq description 2019-04-18 saklein@chromium.org Build API: Adding setup board functionality 2019-04-18 dhanyaganesh@chromium.org scripts: delete classify_special_tasks.py 2019-04-18 mikenichols@chromium.org upload_symbols: Refactor to utilize new endpoint 2019-04-18 lamontjones@chromium.org binhost: add RegenBuildCache Created with: gclient setdep -r src/third_party/chromite@067b46c33eed The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I82caba195d15b8d2e0e1efcfabc668b6eb75a003 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574206 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652444} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit be58786a597d73cb4156b19b2119f75b56b96f79 Author: Krishna Govind <govind@chromium.org> Date: Fri Apr 19 01:29:18 2019 +0000 Updating XTBs based on .GRDs from branch master TBR=meacer@chromium.org Change-Id: I9aa7c7be0033b78332c6dbeb7d6cad664e8ecbe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574431 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#652443} ash/strings/ash_strings_en-GB.xtb | 6 + ash/strings/ash_strings_vi.xtb | 2 +- ...oid_chrome_autofill_assistant_strings_en-GB.xtb | 5 + .../translations/android_chrome_strings_en-GB.xtb | 5 + .../translations/android_chrome_strings_tr.xtb | 6 +- .../translations/android_chrome_strings_vi.xtb | 8 +- chrome/app/resources/chromium_strings_pt-PT.xtb | 4 +- chrome/app/resources/generated_resources_en-GB.xtb | 38 +++++ chrome/app/resources/generated_resources_pt-BR.xtb | 2 +- chrome/app/resources/generated_resources_pt-PT.xtb | 2 +- chrome/app/resources/generated_resources_tr.xtb | 2 +- chrome/app/resources/generated_resources_vi.xtb | 14 +- .../app/resources/google_chrome_strings_en-GB.xtb | 2 + .../app/resources/google_chrome_strings_pt-PT.xtb | 4 +- .../chromevox/strings/chromevox_strings_en-GB.xtb | 10 ++ .../chromevox/strings/chromevox_strings_pt-PT.xtb | 2 +- .../gaiacp/strings/gaia_resources_tr.xtb | 2 +- .../policy/resources/policy_templates_en-GB.xtb | 185 +++++++++++++++++++++ components/strings/components_strings_am.xtb | 1 - components/strings/components_strings_ar.xtb | 1 - components/strings/components_strings_bg.xtb | 1 - components/strings/components_strings_bn.xtb | 1 - components/strings/components_strings_ca.xtb | 1 - components/strings/components_strings_cs.xtb | 1 - components/strings/components_strings_da.xtb | 1 - components/strings/components_strings_de.xtb | 1 - components/strings/components_strings_el.xtb | 1 - components/strings/components_strings_en-GB.xtb | 20 ++- components/strings/components_strings_es-419.xtb | 1 - components/strings/components_strings_es.xtb | 1 - components/strings/components_strings_et.xtb | 1 - components/strings/components_strings_fa.xtb | 1 - components/strings/components_strings_fi.xtb | 1 - components/strings/components_strings_fil.xtb | 1 - components/strings/components_strings_fr.xtb | 1 - components/strings/components_strings_gu.xtb | 1 - components/strings/components_strings_hi.xtb | 1 - components/strings/components_strings_hr.xtb | 1 - components/strings/components_strings_hu.xtb | 1 - components/strings/components_strings_id.xtb | 1 - components/strings/components_strings_it.xtb | 1 - components/strings/components_strings_iw.xtb | 1 - components/strings/components_strings_ja.xtb | 1 - components/strings/components_strings_kn.xtb | 1 - components/strings/components_strings_ko.xtb | 1 - components/strings/components_strings_lt.xtb | 1 - components/strings/components_strings_lv.xtb | 1 - components/strings/components_strings_ml.xtb | 1 - components/strings/components_strings_mr.xtb | 1 - components/strings/components_strings_ms.xtb | 1 - components/strings/components_strings_nl.xtb | 1 - components/strings/components_strings_no.xtb | 1 - components/strings/components_strings_pl.xtb | 1 - components/strings/components_strings_pt-BR.xtb | 1 - components/strings/components_strings_pt-PT.xtb | 3 +- components/strings/components_strings_ro.xtb | 1 - components/strings/components_strings_ru.xtb | 1 - components/strings/components_strings_sk.xtb | 1 - components/strings/components_strings_sl.xtb | 1 - components/strings/components_strings_sr.xtb | 1 - components/strings/components_strings_sv.xtb | 1 - components/strings/components_strings_sw.xtb | 1 - components/strings/components_strings_ta.xtb | 1 - components/strings/components_strings_te.xtb | 1 - components/strings/components_strings_th.xtb | 1 - components/strings/components_strings_tr.xtb | 1 - components/strings/components_strings_uk.xtb | 1 - components/strings/components_strings_vi.xtb | 1 - components/strings/components_strings_zh-CN.xtb | 1 - components/strings/components_strings_zh-TW.xtb | 1 - .../resources/ios_google_chrome_strings_en-GB.xtb | 2 + .../app/strings/resources/ios_strings_en-GB.xtb | 4 + .../translations/ui_chromeos_strings_vi.xtb | 2 +- ui/strings/translations/ui_strings_pt-PT.xtb | 2 +- 74 files changed, 303 insertions(+), 79 deletions(-) commit a6bb02af73a6f98e69caebb91e95e7fd80675aac Author: Daniel Cheng <dcheng@chromium.org> Date: Fri Apr 19 01:26:58 2019 +0000 [blink] Use clearer terminology for custom scheme registration check Bug: 842296 Change-Id: Icaa023b2ff2bd52ca36206cc1279939c9fbbac76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1567948 Reviewed-by: Jeremy Roman <jbroman@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#652442} .../navigator_content_utils.cc | 33 ++++++++-------------- 1 file changed, 11 insertions(+), 22 deletions(-) commit 269a1a5b23a798e07312b468d03107c9432ef1b0 Author: Johannes Henkel <johannes@chromium.org> Date: Fri Apr 19 01:25:00 2019 +0000 [DevTools] Roll inspector_protocol to rev 0ffa9dd64489868aad8fc40988558725eabd656e. This brings in the fix for AppendString8EntryToCBORMapTmpl. Change-Id: Iad4e450c5e7b998d311596096c0c5e6145e6d4a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574367 Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#652441} third_party/inspector_protocol/README.chromium | 2 +- .../inspector_protocol/encoding/encoding.cc | 4 +- .../inspector_protocol/encoding/encoding_test.cc | 46 ++++++++++++++-------- .../inspector_protocol/lib/encoding_cpp.template | 4 +- 4 files changed, 36 insertions(+), 20 deletions(-) commit 548ed1d572f800e1908044bbc9770e68487efbcb Author: 3su6n15k.default@developer.gserviceaccount.com <3su6n15k.default@developer.gserviceaccount.com> Date: Fri Apr 19 01:24:47 2019 +0000 Automated Commit: LKGM 12099.0.0 for chromeos. BUG=762641 TBR=agawronska@google.com Change-Id: Ie9f8934bf8136a21ab948f4b287f6a042b5156e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573380 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652440} chromeos/CHROMEOS_LKGM | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit a3b6c5bf9c45d9b236377b66b2ef2d9ad6f9eed5 Author: Koji Ishii <kojii@chromium.org> Date: Fri Apr 19 01:23:53 2019 +0000 [LayoutNG] Fix list-marker changes to mark |NeedsCollectInlines()| This patch fixes list-marker changes to mark |NeedsCollectInlines()| by marking once-collected list- markers in |CollectInlines()|. r651389 reduced unnecessary |CollectInlines()|, but list- markers were not properly marked. Bug: 953639 Change-Id: I905b3a18bf935f30b686391c24a2f24f9429c6b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574979 Reviewed-by: Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#652439} .../core/layout/ng/inline/ng_inline_node.cc | 5 ++-- .../core/layout/ng/inline/ng_inline_node_test.cc | 28 +++++++++++++++++----- 2 files changed, 24 insertions(+), 9 deletions(-) commit 8aaf1fb27b01a34c2c20091f92237ce25579f57a Author: Bret Sepulveda <bsep@chromium.org> Date: Fri Apr 19 01:23:43 2019 +0000 Disable ExtensionUpdaterTest.TestGalleryRequestsWithNonOrganicBrand. The test is flaky across all platforms. Also disabling TestGalleryRequestsWithOrganicBrand because the flakiness dashboard indicates it's flaky too. TBR=waffles@chromium.org Bug: 954419 Change-Id: I46e166933ea96cf54def1a9e37be3aad8ddd3916 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575120 Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#652438} chrome/browser/extensions/updater/extension_updater_unittest.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 739fec90d1fbef33184d365396715270f7cc192a Author: Wez <wez@chromium.org> Date: Fri Apr 19 01:22:35 2019 +0000 [bfcache] Clean up mock TickClock in BackForwardCacheMetricsTest. The BackForwardCacheMetricsTest base set a mock TickClock during SetUp() but never cleared it, meaning that later tests running the same process might use-after-free it. TBR=altimin Bug: 954421 Change-Id: I98946b4639f58288e87d4536d932bf7f588dab60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574211 Reviewed-by: Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#652437} content/browser/frame_host/back_forward_cache_metrics_unittest.cc | 5 +++++ 1 file changed, 5 insertions(+) commit c882297db4fd769d0a5593ce50e2cc8ffbc4eb8d Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 19 01:21:59 2019 +0000 Roll src/third_party/catapult 67f7f92555b7..ad74585cca1c (4 commits) https://chromium.googlesource.com/catapult.git/+log/67f7f92555b7..ad74585cca1c git log 67f7f92555b7..ad74585cca1c --date=short --no-merges --format='%ad %ae %s' 2019-04-18 benjhayden@chromium.org Migrate report-table to es6 module 2019-04-18 benjhayden@chromium.org Remove stale references to cp-loading.html 2019-04-18 crouleau@chromium.org [vinn] Raise original exception rather than exceptions hit during cleanup 2019-04-18 benjhayden@chromium.org Migrate triage-new and triage-existing to es6 modules Created with: gclient setdep -r src/third_party/catapult@ad74585cca1c The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:950011,chromium:950011,chromium:953365,chromium:950011 TBR=oysteine@chromium.org Change-Id: Iaee4e9dc4d27eeba3e012206f51273c30b89b31e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574208 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652436} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 17b09525d80cf52abd072bf6f6e17b0487ef8dbd Author: Alexander Timin <altimin@chromium.org> Date: Fri Apr 19 01:18:12 2019 +0000 [bfcache] Add a feature to delay history navigations. This will allow us to measure the performance difference and see the difference in the user engagement metrics and extrapolate to estimate the usefulness of bfcache. One-pager: https://docs.google.com/document/d/10Ff_5oq7k-oYuXTTKdN0v_JKG3bU1GPgAWWF7i4nMvs/edit# R=creis@chromium.org BUG=954271 Change-Id: Id31309a9e4926073b10b0e983ed193cf207ec9f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574798 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by: Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#652435} content/browser/BUILD.gn | 2 + ...avigation_ablation_study_navigation_throttle.cc | 66 ++++++++++++++++++++++ ...navigation_ablation_study_navigation_throttle.h | 46 +++++++++++++++ .../frame_host/navigation_throttle_runner.cc | 5 ++ 4 files changed, 119 insertions(+) commit 1ceb102baa5f1d21076396de5a1fc27798563b5f Author: Andres Calderon Jaramillo <andrescj@chromium.org> Date: Fri Apr 19 01:15:41 2019 +0000 media: Ignore EOI and beyond in JpegParser for size computation. This CL makes JpegParser not include the EOI marker and any data after that when computing the |data_size| for a JPEG. The assumption is that the |data_size| should only include scan data: the documentation for the field in jpeg_parser.h states that |data_size| is "the size of compressed data of the first image." The |image_size| field is also affected: it includes everything up to (and including) the EOI marker and ignores anything after that. This is done so that camera captures that come with trailing zeros don't get the size misreported to the hardware acceleration driver. Test: added a simple test to check the behavior. Bug: b:129728310 Change-Id: I68557f38527256e5f6d1116866ae56964ec40da8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554044 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#652434} media/filters/jpeg_parser.cc | 56 +++++++++++++--------- media/filters/jpeg_parser_unittest.cc | 25 +++++++++- media/test/data/README.md | 9 +++- media/test/data/pixel-1280x720-trailing-zeros.jpg | Bin 0 -> 121363 bytes 4 files changed, 65 insertions(+), 25 deletions(-) commit 84335134299a665fa0e8b59f15e9310096670a3a Author: Austin Eng <enga@chromium.org> Date: Fri Apr 19 01:14:07 2019 +0000 Implement GPURenderPipeline in Blink Bug: 877147 Change-Id: I6e09389ac04077f9f878f5c625cbd7b33474cc92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562896 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#652433} .../renderer/modules/webgpu/dawn_conversions.cc | 27 +++ .../blink/renderer/modules/webgpu/gpu_device.cc | 3 +- .../blink/renderer/modules/webgpu/gpu_device.h | 2 + .../blink/renderer/modules/webgpu/gpu_device.idl | 2 +- .../renderer/modules/webgpu/gpu_render_pipeline.cc | 233 ++++++++++++++++++++- .../renderer/modules/webgpu/gpu_render_pipeline.h | 2 + .../webgpu/gpu_render_pipeline_descriptor.idl | 3 +- .../modules/webgpu/gpu_vertex_input_descriptor.idl | 3 +- 8 files changed, 269 insertions(+), 6 deletions(-) commit 264a7fa9f685af6763c3f336fd1fbd107b25e494 Author: Hirokazu Honda <hiroh@chromium.org> Date: Fri Apr 19 01:13:58 2019 +0000 media/gpu/V4L2VDA: Store CheckConfig result into local value We store CheckConfig result in InitializeTask() to the value, |result|, that is in stuck in Initialize(). Since Initialize() progresses once CheckConfig() is done, |result| can be released before the value is checked in InitializeTask(). That causes that |result| is 0 and returns early in Initialize(). H264Decoder is not initialized in the case, h264_decoder is nullptr as a result. This fixes the issue by storing CheckConfig result to a local value in InitializeTask(). Bug: 954185, 951426 Test: video_decode_accelerator_unittest Change-Id: Ia98951ada7abd4c6f22491c504ded4b72f836a29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575039 Reviewed-by: Pawel Osciak <posciak@chromium.org> Commit-Queue: Pawel Osciak <posciak@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#652432} media/gpu/v4l2/v4l2_video_decode_accelerator.cc | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) commit 2a81d9939b4562dbf50c61f90677ad95690448e7 Author: Alison Maher <almaher@microsoft.com> Date: Fri Apr 19 01:06:16 2019 +0000 Update UIA control type for text inputs This change updates the UIA control type for text inputs from UIA_DocumentControlTypeId to UIA_EditControlTypeId. Unit tests added. Bug: 953870 Change-Id: Ie9a570ed10c730c436829af35ec9f81057953c06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572556 Reviewed-by: Katie Dektar <katie@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#652431} ui/accessibility/platform/ax_platform_node_win.cc | 2 +- .../platform/ax_platform_node_win_unittest.cc | 20 +++++++++++++++++++- 2 files changed, 20 insertions(+), 2 deletions(-) commit 7c50cfb3752c0f2968734a500164d10b721092f0 Author: Rob Paveza <Rob.Paveza@microsoft.com> Date: Fri Apr 19 00:55:51 2019 +0000 DevTools: aXe Core linting for Elements - Event Listeners widget. Adds aXe core linting automated tests for the Elements tool's Events pane and also corrects a lint failure in that the select item for how events are categorized lacked an accessible label. Change-Id: I69776e0dea8db9c7fd9f3c45d5e02fb77a01936d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1567892 Commit-Queue: Robert Paveza <Rob.Paveza@microsoft.com> Reviewed-by: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#652430} .../front_end/elements/EventListenersWidget.js | 1 + .../event-listeners-a11y-test-expected.txt | 8 ++++++ .../elements/event-listeners-a11y-test.js | 33 ++++++++++++++++++++++ 3 files changed, 42 insertions(+) commit 28acef072d23f2913372370ab517aae175a68e4e Author: Caleb Rouleau <crouleau@chromium.org> Date: Fri Apr 19 00:53:28 2019 +0000 [Perf Infra] Harden perf tests wrapper script. If a benchmark does not return any test results file, then currently our run_performance_tests.py script will hard fail. Instead, we should be more graceful. Note that an error is already logged when this happens in execute_telemetry_benchmark, so there's no need to log another error. Bug: 953365 Change-Id: Iadba50ffd43b6c7b930b91e5cc1365acc31c3588 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574888 Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#652429} testing/scripts/run_performance_tests.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) commit c091440a809c7cf17eaacf9cd3fd4230aeda8ef3 Author: Varun Khaneja <vakh@chromium.org> Date: Fri Apr 19 00:52:06 2019 +0000 Android: Update strings for Safe Browsing and SB Extended Reporting See: https://docs.google.com/document/d/1E1uyto12NGe9kZFpqH8T8pRyhaOdzcKwHW51RETw-0Q/edit CL for Desktop platforms: https://crrev.com/c/1574938 R=drubery Bug: 953997 Change-Id: I4c9b1b52488dd10e6b0f9e8c1c25f8265a4038e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574892 Reviewed-by: Daniel Rubery <drubery@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#652428} chrome/android/java/strings/android_chrome_strings.grd | 8 ++++---- .../IDS_SAFE_BROWSING_SCOUT_REPORTING_SUMMARY.png.sha1 | 1 + .../IDS_SAFE_BROWSING_SCOUT_REPORTING_TITLE.png.sha1 | 1 + .../android_chrome_strings_grd/IDS_SAFE_BROWSING_SUMMARY.png.sha1 | 1 + .../android_chrome_strings_grd/IDS_SAFE_BROWSING_TITLE.png.sha1 | 1 + 5 files changed, 8 insertions(+), 4 deletions(-) commit a9eee1c7c727ef42a15d86e9fa7b77ff0e63840a Author: Seth Hampson <shampson@chromium.org> Date: Fri Apr 19 00:46:45 2019 +0000 Adds usage counters to RTCQuicTransport. Adds usage counters for the datagram APIs on the RTCQuicTransport for the origin trial. Bug: 874296 Change-Id: Ifb3490b8bf0d3221f29c65a2d91830dbb8aeabd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573808 Commit-Queue: Seth Hampson <shampson@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: Seth Hampson <shampson@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Steve Anton <steveanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#652427} third_party/blink/public/mojom/web_feature/web_feature.mojom | 4 ++++ .../blink/renderer/modules/peerconnection/rtc_quic_transport.idl | 8 ++++---- tools/metrics/histograms/enums.xml | 5 +++++ 3 files changed, 13 insertions(+), 4 deletions(-) commit eefe67009f54d968d650d9e231a3799a12cffd16 Author: Drew Stonebraker <stonebraker@chromium.org> Date: Fri Apr 19 00:46:11 2019 +0000 Make standalone webview crash dump percentage contingent on channel We currently submit a manual CL every time we want to change the hardcoded crash dump percentage for standalone webview due to releasing a beta apk or promoting a beta to stable. Now that standalone webview has channels (https://bugs.chromium.org/p/chromium/issues/detail?id=919216), add logic to include different crash reporting rates for different channels. Bug: 954298 Change-Id: I3a6a9e32e67260cdb2190ea5b394c514d6df0c06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574362 Reviewed-by: Tao Bai <michaelbai@chromium.org> Commit-Queue: Drew Stonebraker <stonebraker@chromium.org> Cr-Commit-Position: refs/heads/master@{#652426} android_webview/common/crash_reporter/aw_crash_reporter_client.cc | 5 +++++ 1 file changed, 5 insertions(+) commit d3b57e4850a03a05808533ffeec7e719a62d7730 Author: Shakti Sahu <shaktisahu@chromium.org> Date: Fri Apr 19 00:44:58 2019 +0000 Download home : Show/hide prefetch tab correctly This CL fixes the prefetch tab visibility on download home. The prefetch tab is visible only when prefetching is enabled which requires the feature and the settings to be enabled. Also adds an observer to the user setting pref, so that the tab shows/hides as soon as the setting is toggled. Bug: 951821 Change-Id: I85bc2d0f346d01b1a0f7f9d8b42430f3614ed373 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564902 Reviewed-by: Carlos Knippschild <carlosk@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#652425} .../download/home/filter/FilterCoordinator.java | 48 ++++++++++++++++++++-- .../home/list/DateOrderedListCoordinator.java | 1 + .../download/home/DownloadActivityV2Test.java | 2 + chrome/browser/android/preferences/prefs.h | 3 ++ .../browser/android/preferences/prefs_unittest.cc | 2 + .../offline_pages/core/prefetch/prefetch_prefs.cc | 16 ++++---- .../offline_pages/core/prefetch/prefetch_prefs.h | 1 + 7 files changed, 61 insertions(+), 12 deletions(-) commit cb019fe81baf6392d3df8f643e57effb383b61c9 Author: Rob Paveza <Rob.Paveza@microsoft.com> Date: Fri Apr 19 00:44:34 2019 +0000 DevTools: aXe core linting for main Elements tools This change adds aXe Core linting to the following components of the main Elements tool: - DOM tree - Breadcrumbs - Styles pane - Computed Styles pane Change-Id: I247d9a4d4883db936f09c4d252a0558e63295edf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566689 Commit-Queue: Robert Paveza <Rob.Paveza@microsoft.com> Reviewed-by: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#652424} .../elements_test_runner/ElementsTestRunner.js | 9 +++ .../elements/main-tool-test-expected.txt | 21 +++++++ .../a11y-axe-core/elements/main-tool-test.js | 67 ++++++++++++++++++++++ 3 files changed, 97 insertions(+) commit 4578821f438b4a7150e949a5a4190c7d7507882c Author: Bret Sepulveda <bsep@chromium.org> Date: Fri Apr 19 00:41:26 2019 +0000 Disable many HeadlessProtocolCompositorBrowserTest on Windows. The tests are timeout-flaky. TBR=caseq@chromium.org Bug: 954398 Change-Id: I4d9e2658e49d599a5890042c92932eaa1906b4bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575023 Reviewed-by: Bret Sepulveda <bsep@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#652423} headless/test/headless_protocol_browsertest.cc | 54 ++++++++++++++++++++------ 1 file changed, 42 insertions(+), 12 deletions(-) commit 3dd508f388fd3d118c79813e5acc8ac521a5d7b5 Author: Peter Kasting <pkasting@chromium.org> Date: Fri Apr 19 00:41:21 2019 +0000 Remove uses of View::child_count() in chrome/browser/ui/views/. Bug: 940135 Change-Id: I3f206c6a86408b850ac23aa422e46995c9e6b00a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573006 Reviewed-by: Peter Boström <pbos@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#652422} .../autofill/payments/card_unmask_prompt_views.cc | 4 +- .../payments/local_card_migration_browsertest.cc | 2 +- .../payments/local_card_migration_dialog_view.cc | 3 +- .../views/autofill/payments/payments_view_util.cc | 3 +- .../ui/views/bookmarks/bookmark_bar_view_test.cc | 22 +++--- .../bookmarks/bookmark_menu_delegate_unittest.cc | 2 +- .../desktop_capture/desktop_media_list_view.cc | 18 ++--- .../extension_install_dialog_view_browsertest.cc | 3 +- chrome/browser/ui/views/frame/browser_view.cc | 14 ++-- .../browser/ui/views/frame/browser_view_layout.cc | 3 +- .../ui/views/infobars/infobar_container_view.cc | 38 +++++------ chrome/browser/ui/views/infobars/infobar_view.cc | 6 +- .../browser/ui/views/intent_picker_bubble_view.cc | 2 +- .../location_bar/location_bar_view_browsertest.cc | 6 +- .../ui/views/menu_view_drag_and_drop_test.cc | 4 +- .../views/omnibox/omnibox_popup_contents_view.cc | 6 +- .../ui/views/omnibox/omnibox_result_view.cc | 2 +- .../page_info/page_info_bubble_view_unittest.cc | 79 +++++++++++----------- ...edit_card_editor_view_controller_browsertest.cc | 6 +- .../ui/views/payments/modifiers_browsertest.cc | 22 +++--- .../payment_method_view_controller_browsertest.cc | 6 +- .../payments/payment_request_browsertest_base.cc | 8 +-- .../payments/payment_request_browsertest_base.h | 4 +- .../payments/payment_request_item_list_unittest.cc | 2 +- .../payments/payment_request_sheet_controller.cc | 4 +- .../profile_list_view_controller_browsertest.cc | 2 +- ...g_address_editor_view_controller_browsertest.cc | 20 +++--- .../ui/views/payments/view_stack_unittest.cc | 4 +- chrome/browser/ui/views/tabs/tab_strip_unittest.cc | 6 +- chrome/browser/ui/views/tabs/tab_unittest.cc | 16 ++--- chrome/browser/ui/views/toolbar/app_menu.cc | 20 +++--- .../toolbar_actions_bar_bubble_views_unittest.cc | 2 +- .../ui/views/translate/translate_bubble_view.cc | 8 +-- .../views/try_chrome_dialog_win/button_layout.cc | 8 +-- 34 files changed, 172 insertions(+), 183 deletions(-) commit 2d96af13ca1a1b5f06ba39e1b85771ce127fc027 Author: John Budorick <jbudorick@chromium.org> Date: Fri Apr 19 00:40:18 2019 +0000 Make resource_sizes.py accept --isolated-script-test-perf-output. It doesn't appear to do anything, but we still pass it (for now). Bug: 861983 Change-Id: I9e5aced1aeedd9dbb3151a5e1a1dcca5c60489f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574430 Commit-Queue: John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#652421} build/android/resource_sizes.py | 5 +++++ 1 file changed, 5 insertions(+) commit 854d09d1f360d737d15498879213d26e4bd5a105 Author: Ben Pastene <bpastene@chromium.org> Date: Fri Apr 19 00:40:14 2019 +0000 chromeos: Disable Tast test security.SELinuxFilesNonARC to unblock LKGM roll. Unblocks https://chromium-review.googlesource.com/c/chromium/src/+/1573380 Bug: 954192 Change-Id: If338e6fd4cb28ba8a18996c786b87cea978366fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574598 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#652420} chromeos/BUILD.gn | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 31ef11aad15d3f26332ab6cab6679608a7270f17 Author: Alexei Filippov <alph@chromium.org> Date: Fri Apr 19 00:37:31 2019 +0000 DevTools: Adjust devtools.timeline.RunTask event location Make its scope span across RunMicrotasks event scope. BUG=953914 Change-Id: I8fb42a6a3aba84b0dbf6a1e1c64a993e0c6c2d2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573998 Reviewed-by: Paul Irish <paulirish@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#652419} base/task/sequence_manager/thread_controller_impl.cc | 13 +++++++------ .../thread_controller_with_message_pump_impl.cc | 2 ++ 2 files changed, 9 insertions(+), 6 deletions(-) commit 6697f8ba79ab819a145ed33aa397c975851a8629 Author: Yeol Park <peary2@gmail.com> Date: Fri Apr 19 00:33:58 2019 +0000 Uses AddHeaderFromString instead of AddHeadersFromString, for code health. So it replaced AddHeadersFromString with AddHeaderFromString in the net_unittests. Bug: 862175 Change-Id: I3296f86f44ef5fca4b54fc267fdf4550707a3148 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573420 Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Yeol Park <peary2@gmail.com> Cr-Commit-Position: refs/heads/master@{#652418} net/url_request/redirect_util_unittest.cc | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) commit 53a914eac9ec6d2f53b4c17730e2eae348088bcc Author: Dale Curtis <dalecurtis@chromium.org> Date: Fri Apr 19 00:32:07 2019 +0000 Fix dav1d Windows arm64 + roll dav1d ace3855a6..589e96a1f (29 commits) Adds support for Windows ARM64 by cloning the x64 config and turning it into a arm64 one. Unfortunately meson (the build system dav1d uses) doesn't support clang-cl + arm64, so this is the best we can do for now. Also removes the need for wine when generating Windows configurations, since we don't care about running the tests anyways. Fixes typo in the win64 config which didn't matter too. https://chromium.googlesource.com/external/github.com/videolan/dav1d.git/+log/ace3855a6037..589e96a1f2cf $ git log ace3855a6..589e96a1f --date=short --no-merges --format='%ad %ae %s' 2019-04-18 liwei Add SSSE3 implementation for the {16, 32, 64}x64 and 64 x{16, 32} blocks in itx 2019-04-16 rsbultje Over-allocate level array by 3-bytes 2019-03-30 martin arm64: loopfilter: Implement NEON loop filters 2019-02-24 martin arm64: looprestoration: Add a NEON implementation of SGR 2019-04-16 martin msac: Add a cast to indicate intended narrowing from size_t to unsigned 2019-04-11 gramner x86-64: Add msac_decode_symbol_adapt SSE2 asm 2019-04-10 xuefeng Add SSSE3 implementation for ipred_paeth 2019-04-08 martin arm: Add a _neon suffix to all internal functions 2019-04-08 martin arm: Fix typos in comments 2019-04-03 martin arm: Consistently use 8/24 columns indentation for assembly 2019-04-04 xuefeng Add SSSE3 implementation for ipred_cfl_ac_444 2019-03-28 gramner CI: Check for newline at end of file 2019-03-21 victorien.lecouviour.tuffet x86: cdef_dir: optimize best cost finding for SSE 2019-03-19 victorien.lecouviour.tuffet x86: cdef_filter: use 8-bit arithmetic for SSE 2019-03-12 victorien.lecouviour.tuffet x86: cdef_filter: use a better constant for SSE4 2019-03-26 victorien.lecouviour.tuffet x86: cdef_filter: fix macro case (lower to upper) 2019-03-25 liwei Add SSSE3 implementation for the 16x32,32x16 and 32x32 blocks in itx 2019-03-25 gramner build: Split x86 asm files per bitdepth 2019-03-24 martin Only define DAV1D_API to dllexport when building dav1d itself 2019-03-24 gramner Simplify C for inverse transforms 2019-03-20 gramner x86: Add minor CDEF AVX2 optimizations 2019-03-15 liwei Add SSSE3 implementation for the 8x32 and 32x8 blocks in itx 2019-03-18 xuefeng Add SSSE3 implementation for ipred_cfl_ac_420 and ipred_cfl_ac_422 2019-03-16 jamrial decode: add a frame tile data buffer size check 2019-03-16 jamrial decode: don't realloc the tile data buffer when it needs to be enlarged 2019-03-13 janne-vlc tools/dav1d/md5: bswap big endian high bit depth pixel data 2019-02-27 janne-vlc tools/dav1d: make the md5 muxer endian-aware 2019-03-13 jb On the road to 0.2.2 2019-03-09 jamrial build: use the project version as product version in the windows resource file Created with: roll-dep src/third_party/dav1d/libdav1d BUG=938190,941022 R=chcunningham Change-Id: Id0e4545219009e18b1bb0011ae616301ed50a98d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574199 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#652417} DEPS | 2 +- media/media_options.gni | 11 ++------ third_party/dav1d/README.chromium | 6 ++--- third_party/dav1d/config/linux-noasm/x64/config.h | 2 ++ third_party/dav1d/config/linux/arm/config.h | 2 ++ third_party/dav1d/config/linux/arm64/config.h | 2 ++ third_party/dav1d/config/linux/x64/config.h | 2 ++ third_party/dav1d/config/linux/x86/config.h | 2 ++ third_party/dav1d/config/win/arm64/config.h | 32 +++++++++++++++++++++++ third_party/dav1d/config/win/x64/config.h | 2 ++ third_party/dav1d/config/win/x86/config.h | 2 ++ third_party/dav1d/crossfiles/win32.crossfile | 2 -- third_party/dav1d/crossfiles/win64.crossfile | 4 +-- third_party/dav1d/dav1d_generated.gni | 5 +++- third_party/dav1d/generate_configs.py | 32 ++++++++++++++++++----- 15 files changed, 83 insertions(+), 25 deletions(-) commit fda44632071bd2c4feb54afc3004e5166b6eb4e9 Author: Joshua Pawlicki <waffles@chromium.org> Date: Fri Apr 19 00:25:19 2019 +0000 Update dummyiap.crx to CRX3. The key for this CRX is owned by CWS, so I pulled the CWS CRX3 version. TBR=rdevlin.cronin@chromium.org Bug: 954322 Change-Id: I227a95182e95197c2ecc5ffe49b1a16dd2644b99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574944 Reviewed-by: Joshua Pawlicki <waffles@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#652416} chrome/test/data/extensions/dummyiap.crx | Bin 478 -> 189072 bytes 1 file changed, 0 insertions(+), 0 deletions(-) commit d2a84714990038ea79c43ffd22a91fe7895d615c Author: Chan <chanli@chromium.org> Date: Fri Apr 19 00:18:49 2019 +0000 Disable SyncUIUtilTest.DistinctCasesReportUniqueMessageSets TBR=bsep@chromium.org Bug: 954365 Change-Id: I74b47e8506392864146d7e94b1497a5990b12d7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575018 Reviewed-by: Chan Li <chanli@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#652415} chrome/browser/sync/sync_ui_util_unittest.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit 30bfc5f3cfbefb21b1607c164e01eaebef61fa06 Author: Rob Paveza <Rob.Paveza@microsoft.com> Date: Fri Apr 19 00:17:21 2019 +0000 DevTools: aXe core linting for Elements - Properties pane This adds an automated run of the aXe Core linter to the DOM Properties pane of the Elements tab. Change-Id: I3cd687358eea482ec690c8d4bbc53e58ae87fcdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1567909 Reviewed-by: Joel Einbinder <einbinder@chromium.org> Commit-Queue: Robert Paveza <Rob.Paveza@microsoft.com> Cr-Commit-Position: refs/heads/master@{#652414} .../http/tests/devtools/a11y-axe-core/basic-a11y-test-expected.txt | 3 +++ .../web_tests/http/tests/devtools/a11y-axe-core/basic-a11y-test.js | 2 ++ 2 files changed, 5 insertions(+) commit 9256ed57b35eb27125e8fe9efee7dadf942b81ef Author: Yann Dago <ydago@chromium.org> Date: Fri Apr 19 00:16:23 2019 +0000 Hide duplicate management disclosure in about page Settings page visual: http://screen/SmaWDcxWq2R About page visual: http://screen/db8RQ9EbOS7 Bug: 954400 Change-Id: If9d79de0ef5c5eba39af1a5c108e9d056c0a3573 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574440 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#652413} .../resources/settings/settings_main/settings_main.html | 3 ++- .../resources/settings/settings_main/settings_main.js | 3 ++- chrome/test/data/webui/settings/settings_main_test.js | 12 +++++++++++- 3 files changed, 15 insertions(+), 3 deletions(-) commit fa6ac1518ae74273da1014d3fdb30dada1f825d7 Author: Sinan Sahin <sinansahin@google.com> Date: Fri Apr 19 00:15:04 2019 +0000 Remove All dismissed dialog and image Bug: 915305, 950166 Change-Id: I1cdf7762b954db4e93be6e94aeb8d87b07c0c614 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562075 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#652412} chrome/android/chrome_java_sources.gni | 1 - chrome/android/chrome_test_java_sources.gni | 1 - .../res/drawable-hdpi/ntp_all_dismissed_white.webp | Bin 3796 -> 0 bytes .../res/drawable-mdpi/ntp_all_dismissed_white.webp | Bin 2308 -> 0 bytes .../drawable-xhdpi/ntp_all_dismissed_white.webp | Bin 5250 -> 0 bytes .../drawable-xxhdpi/ntp_all_dismissed_white.webp | Bin 8764 -> 0 bytes .../drawable-xxxhdpi/ntp_all_dismissed_white.webp | Bin 12494 -> 0 bytes ...ntent_suggestions_all_dismissed_card_modern.xml | 61 --------------- .../chrome/browser/ntp/cards/AllDismissedItem.java | 77 ------------------ .../chrome/browser/ntp/cards/CardViewHolder.java | 1 - .../chrome/browser/ntp/cards/ItemViewType.java | 8 +- .../browser/ntp/cards/NewTabPageAdapter.java | 21 ++--- .../browser/ntp/cards/StatusCardViewHolder.java | 9 +++ .../browser/ntp/cards/SuggestionsSection.java | 36 --------- .../java/strings/android_chrome_strings.grd | 12 --- .../browser/ntp/cards/AllDismissedItemTest.java | 87 --------------------- .../ntp/cards/NewTabPageRecyclerViewTest.java | 67 +++------------- .../suggestions/HomeSheetUiCaptureTest.java | 28 ------- .../browser/ntp/cards/NewTabPageAdapterTest.java | 86 +++----------------- .../browser/ntp/cards/SuggestionsSectionTest.java | 33 ++------ 20 files changed, 46 insertions(+), 482 deletions(-) commit f0cb8e6eb3828210b851a4e92a9299c9f26462ca Author: Lan Wei <lanwei@chromium.org> Date: Fri Apr 19 00:14:53 2019 +0000 Transfer user activation in other renderer processes through IPC In order to complete transferring user activation through cross-process postMessage, we need to transfer the user activation state in other renderer processes (non-source, non-target) through IPC. We will complete the same-process postMessage case in the following CL. Bug:928838 Change-Id: Ia959d8f43f1965b59674346e83b453bb6f2378ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546675 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#652411} content/browser/frame_host/frame_tree_node.cc | 15 ++-- content/browser/frame_host/frame_tree_node.h | 6 +- .../frame_host/render_frame_host_manager.cc | 15 ++++ .../browser/frame_host/render_frame_host_manager.h | 8 ++ .../browser/frame_host/render_frame_proxy_host.cc | 8 +- content/common/frame_messages.h | 4 + content/renderer/render_frame_proxy.cc | 10 +++ content/renderer/render_frame_proxy.h | 1 + third_party/blink/public/web/web_remote_frame.h | 5 ++ .../core/exported/web_remote_frame_impl.cc | 6 ++ .../renderer/core/exported/web_remote_frame_impl.h | 1 + .../blink/renderer/core/frame/dom_window.cc | 2 +- third_party/blink/renderer/core/frame/frame.cc | 2 +- third_party/blink/renderer/core/frame/frame.h | 2 +- .../renderer/core/frame/web_local_frame_impl.cc | 2 +- third_party/blink/web_tests/TestExpectations | 1 + ...-with-click-two-child-frames.sub.tentative.html | 90 ++++++++++++++++++++++ .../html/user-activation/resources/child-five.html | 15 ++++ .../html/user-activation/resources/child-four.html | 2 +- 19 files changed, 180 insertions(+), 15 deletions(-) commit 0136849d385efaa62ba01fd14a44106b38ca72de Author: Andrew Xu <andrewxu@chromium.org> Date: Fri Apr 19 00:12:13 2019 +0000 Add PresentationTimeRecorder For Tablet Mode Add PresentationTimeRecorder to record all tablet mode launcher gesture interactions, which include: (1) Swiping from bottom of screen to show launcher (2) Swiping from top of screen to hide launcher Test: ash_unittests Bug: 947105 Change-Id: Ib1d014b1b7141883d9e78035a26cbeeea689c651 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564880 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#652410} ash/app_list/app_list_controller_impl.cc | 18 +++ ash/app_list/app_list_controller_impl.h | 5 + ash/app_list/app_list_controller_impl_unittest.cc | 167 ++++++++++++++++++++++ ash/app_list/views/app_list_view.cc | 40 ++++-- ash/app_list/views/app_list_view.h | 9 ++ ash/home_screen/home_launcher_gesture_handler.cc | 34 ++++- ash/home_screen/home_screen_delegate.h | 6 + 7 files changed, 263 insertions(+), 16 deletions(-) commit 35be52ae9f230d3567ab565d76f3d28555b29396 Author: Koji Ishii <kojii@chromium.org> Date: Fri Apr 19 00:06:01 2019 +0000 [auto] Update FlagExpectations for LayoutNG Following bot results are included. 18207 18208 18215 18217 18219 18223 18233 18237 18241 18244 18251 18259 18264 18268 18281 18289 18297 18307 18316 18323 18329 18333 18342 18351 18360 18370 18381 18388 18397 18403 18420 18429 2 lines were removed and 4 lines were deflaked by consecutive results since 18329. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Change-Id: I0e1a5d04ca02a2fb4179263a1fa9764ebaabad08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566256 Reviewed-by: Koji Ishii <kojii@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#652409} .../FlagExpectations/enable-blink-features=LayoutNG | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) commit b8d18a872c9164db96bc786c0d707ba82db00bb7 Author: Victor Fei <vicfei@microsoft.com> Date: Fri Apr 19 00:05:07 2019 +0000 Implemented ITextRangeProvider::FindAttribute Implemented FindAttribute of ITextRangeProvider with associated unittests. Bug: 928948 Change-Id: I14ff986294309d599d3adb81a81587a2d7c7e229 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555052 Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Victor Fei <vicfei@microsoft.com> Cr-Commit-Position: refs/heads/master@{#652408} .../ax_platform_node_textrangeprovider_win.cc | 116 ++++- .../ax_platform_node_textrangeprovider_win.h | 10 +- ...platform_node_textrangeprovider_win_unittest.cc | 577 +++++++++++++++++++++ 3 files changed, 698 insertions(+), 5 deletions(-) commit a04d103294f534a530e303479799d3653f50bb66 Author: Hector Carmona <hcarmona@chromium.org> Date: Fri Apr 19 00:04:56 2019 +0000 Navi: Add C++ policy check for DefaultBrowserSettingEnabled. This change will be necessary in order to skip onboarding if all modules are disabled by policy. Bug: 951840 Change-Id: I305ae446732517db26a1b5ee096276e6c2ee7fd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572640 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#652407} chrome/browser/ui/webui/welcome/nux_helper.cc | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) commit 564356ff28f25ffa4b66202363dd9e4aa4bf46c0 Author: Dan Harrington <harringtond@chromium.org> Date: Thu Apr 18 23:59:22 2019 +0000 remove dead code: AddPageToDownloadManagerTask Change-Id: Ieaf2be762ed4719a7404c6b51c56db10fc367afa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574978 Reviewed-by: Peter Williamson <petewil@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#652406} components/offline_pages/core/BUILD.gn | 3 - .../model/add_page_to_download_manager_task.cc | 86 ----------------- .../core/model/add_page_to_download_manager_task.h | 59 ------------ .../add_page_to_download_manager_task_unittest.cc | 103 --------------------- 4 files changed, 251 deletions(-) commit 41bc3af952d49f7a807e887d92ca6ba8d7e6ca64 Author: Oystein Eftevaag <oysteine@google.com> Date: Thu Apr 18 23:57:52 2019 +0000 Disabled the v8.browsing_desktop twitter_infinite_scroll benchmark on Windows NOTRY=true TBR=croleau@chromium.org CC=mythria@chromium.org,ulan@chromium.org BUG=953371 Change-Id: Ibcb64d10e27ee87925f71f627abfe960e54464ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574604 Reviewed-by: oysteine <oysteine@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#652405} tools/perf/expectations.config | 2 ++ 1 file changed, 2 insertions(+) commit a10bfe51237589f382d894a35c9301f84a8e6b53 Author: Bill Budge <bbudge@chromium.org> Date: Thu Apr 18 23:55:54 2019 +0000 [ppapi] Remove PPB_TrueTypeFont resource. - UMA shows this interface has no usage. Change-Id: Ifcb68620aceab0d8a857b4a3a0c768990bf47905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546762 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by: Raymes Khoury <raymes@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Sam Clegg <sbc@chromium.org> Cr-Commit-Position: refs/heads/master@{#652404} chrome/common/ppapi_utils.cc | 1 - chrome/test/ppapi/ppapi_browsertest.cc | 8 - content/browser/BUILD.gn | 17 - .../pepper/content_browser_pepper_host_factory.cc | 21 - .../renderer_host/pepper/pepper_truetype_font.h | 57 --- .../pepper/pepper_truetype_font_host.cc | 153 -------- .../pepper/pepper_truetype_font_host.h | 72 ---- .../pepper/pepper_truetype_font_linux.cc | 158 -------- .../pepper/pepper_truetype_font_list.h | 36 -- .../pepper/pepper_truetype_font_list_host.cc | 113 ------ .../pepper/pepper_truetype_font_list_host.h | 28 -- .../pepper/pepper_truetype_font_list_mac.mm | 83 ---- .../pepper/pepper_truetype_font_list_ozone.cc | 20 - .../pepper/pepper_truetype_font_list_pango.cc | 65 --- .../pepper/pepper_truetype_font_list_win.cc | 91 ----- .../pepper/pepper_truetype_font_mac.mm | 415 -------------------- .../pepper/pepper_truetype_font_win.cc | 241 ------------ .../pepper/pepper_in_process_resource_creation.cc | 7 - .../pepper/pepper_in_process_resource_creation.h | 3 - .../renderer/pepper/pepper_plugin_instance_impl.cc | 1 - content/renderer/pepper/plugin_module.cc | 1 - content/test/ppapi/ppapi_browsertest.cc | 8 - native_client_sdk/src/libraries/ppapi/library.dsc | 1 - .../src/libraries/ppapi_cpp/library.dsc | 2 - ppapi/BUILD.gn | 2 - ppapi/api/dev/ppb_truetype_font_dev.idl | 276 ------------- ppapi/c/dev/ppb_truetype_font_dev.h | 301 -------------- ppapi/cpp/BUILD.gn | 2 - ppapi/cpp/dev/truetype_font_dev.cc | 156 -------- ppapi/cpp/dev/truetype_font_dev.h | 274 ------------- .../src/untrusted/pnacl_irt_shim/pnacl_shim.c | 58 --- ppapi/proxy/BUILD.gn | 4 - ppapi/proxy/interface_list.cc | 1 - ppapi/proxy/ppapi_messages.h | 35 -- ppapi/proxy/ppapi_param_traits.cc | 31 -- ppapi/proxy/ppapi_param_traits.h | 12 - ppapi/proxy/ppb_instance_proxy.cc | 4 - ppapi/proxy/resource_creation_proxy.cc | 9 - ppapi/proxy/resource_creation_proxy.h | 3 - ppapi/proxy/serialized_structs.cc | 34 -- ppapi/proxy/serialized_structs.h | 25 -- ppapi/proxy/truetype_font_resource.cc | 164 -------- ppapi/proxy/truetype_font_resource.h | 89 ----- ppapi/proxy/truetype_font_singleton_resource.cc | 124 ------ ppapi/proxy/truetype_font_singleton_resource.h | 68 ---- ppapi/shared_impl/resource.h | 2 - ppapi/shared_impl/singleton_resource_id.h | 1 - ppapi/tests/all_c_includes.h | 1 - ppapi/tests/test_truetype_font.cc | 436 --------------------- ppapi/tests/test_truetype_font.h | 37 -- ppapi/thunk/BUILD.gn | 3 - ppapi/thunk/interfaces_ppb_public_dev.h | 4 +- ppapi/thunk/ppb_pdf_thunk.cc | 4 +- ppapi/thunk/ppb_truetype_font_api.h | 38 -- ppapi/thunk/ppb_truetype_font_dev_thunk.cc | 108 ----- ppapi/thunk/ppb_truetype_font_singleton_api.h | 42 -- ppapi/thunk/resource_creation_api.h | 4 - tools/ipc_fuzzer/fuzzer/fuzzer.cc | 9 - tools/metrics/histograms/enums.xml | 2 +- 59 files changed, 6 insertions(+), 3959 deletions(-) commit 51874328de2bd12bd0baef58208706bac01ac213 Author: Khushal <khushalsagar@chromium.org> Date: Thu Apr 18 23:55:40 2019 +0000 viz/android: Plumbing to support preferred refresh rate setting. Plumb the supported refresh rates from the browser to GPU process and the preferred refresh rate setting from the GPU to browser process. R=ericrk@chromium.org Bug: 938106 Change-Id: I00f2564dfa523bebe0c76fa855ae844b72ba68da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556415 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Eric Karl <ericrk@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#652403} android_webview/browser/gfx/surfaces_instance.cc | 5 ++ android_webview/browser/gfx/surfaces_instance.h | 3 + components/viz/service/display/display.cc | 7 +- components/viz/service/display/display_client.h | 4 + components/viz/service/display/display_unittest.cc | 5 ++ .../viz/service/display/frame_rate_decider.cc | 1 - .../frame_sinks/direct_layer_tree_frame_sink.cc | 13 +++ .../frame_sinks/direct_layer_tree_frame_sink.h | 3 + .../service/frame_sinks/frame_sink_manager_impl.cc | 9 ++ .../service/frame_sinks/frame_sink_manager_impl.h | 5 ++ .../frame_sinks/root_compositor_frame_sink_impl.cc | 31 +++++++ .../frame_sinks/root_compositor_frame_sink_impl.h | 5 ++ components/viz/test/mock_display_client.h | 1 + components/viz/test/test_layer_tree_frame_sink.cc | 5 ++ components/viz/test/test_layer_tree_frame_sink.h | 3 + .../overscroll_controller_android_unittest.cc | 2 + .../renderer_host/compositor_impl_android.cc | 67 ++++++++------- .../renderer_host/compositor_impl_android.h | 4 + .../android/synchronous_layer_tree_frame_sink.cc | 5 ++ .../android/synchronous_layer_tree_frame_sink.h | 3 + .../interfaces/compositing/display_private.mojom | 7 ++ .../delegated_frame_host_android_unittest.cc | 3 + .../src/org/chromium/ui/base/WindowAndroid.java | 42 +++++++--- ui/android/window_android.cc | 97 ++++++++++------------ ui/android/window_android.h | 17 ++-- ui/android/window_android_compositor.h | 2 + 26 files changed, 234 insertions(+), 115 deletions(-) commit d475f6eaf80cb4fa7d9c3361b4c60ed6380d6936 Author: Varun Khaneja <vakh@chromium.org> Date: Thu Apr 18 23:54:26 2019 +0000 Desktop: Update strings for Safe Browsing and SB Extended Reporting See: https://docs.google.com/document/d/1E1uyto12NGe9kZFpqH8T8pRyhaOdzcKwHW51RETw-0Q/edit CL for Android: https://crrev.com/c/1574892 R=drubery TBR=rockot Bug: 953997 Change-Id: Ie2138e3f4c15a82a722351cc47ddbde06016e8ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574938 Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by: Daniel Rubery <drubery@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#652402} chrome/app/settings_strings.grdp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) commit f6d4864c5c526742c19ecd9de2864c2964d4a352 Author: Hector Carmona <hcarmona@chromium.org> Date: Thu Apr 18 23:53:21 2019 +0000 Navi: Add support for the NewTabPageLocation policy. If NewTabPageLocation is set to any URL, then we will skip the 'nux-ntp-background' module. Bug: 951833 Change-Id: I3ddbc76eb8a42d95b63cbec288df9b212dcff632 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568769 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#652401} chrome/browser/ui/webui/welcome/nux_helper.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 83049fa494b198f6ef8ec02fdf4b7e3c9413d7e0 Author: Dan Sanders <sandersd@chromium.org> Date: Thu Apr 18 23:52:59 2019 +0000 [media] VdaVideoDecoder: accept invalid bitstream buffer IDs. DXVA VDA outputs corrupted bitstream IDs in some cases. GVD allowed this (in Release builds) and sets the VideoFrame timestamp to 0. This change makes VdaVideoDecoder do the same. Bug: 936747 Change-Id: Ie127bb9c57caa21082bce9f1b631f4ae723b631a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574884 Reviewed-by: Frank Liberato <liberato@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#652400} media/gpu/ipc/service/vda_video_decoder.cc | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) commit de51bb9c0804afffbc77f46c5cbb593ffcf817b6 Author: Sam Fortiner <samfort@microsoft.com> Date: Thu Apr 18 23:51:54 2019 +0000 Expand interaction gutters for scrollbars There is a gutter rect around the scrollbar during which thumb drags will behave as though the mouse is on the thumb even if it moves off the thumb but is still inside the gutter rect. If the mouse moves outside of that gutter rect, the thumb snaps back to its original position. This behavior offers users the ability to quickly toggle between two positions in a scroller by intentionally moving the thumb in the non-scrolling direction in and out of the gutter. However, it also can frustrate users if they grabbed the scrollbar thumb and dragged in the scrolling direction but unintentionally move outside of the gutter causing the thumb to snap back. This change modifies the behavior so that scrollbars have an infinitely large interaction gutter rect in the scrolling direction. Bug: 801188 Change-Id: I838741053305122adf5b81345eb56d87916edd0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566027 Commit-Queue: Sam Fortiner <samfort@microsoft.com> Reviewed-by: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#652399} .../renderer/core/scroll/scrollbar_theme_aura.cc | 41 +++-- .../fast/overflow/scrollbar-drag-origin.html | 190 +++++++++++++++++++++ 2 files changed, 213 insertions(+), 18 deletions(-) commit 77895c86787a71fb6c99381755b862bb6dd5c50c Author: Xing Liu <xingliu@chromium.org> Date: Thu Apr 18 23:51:34 2019 +0000 Notification scheduler: Cache API calls before initialization is done. This CL adds a class to cache API calls before NotificationScheduler async initialization is done. Bug: 930968 Change-Id: Ic4bff46205393d684ec7c825e96daad788d0a914 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573240 Reviewed-by: David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#652398} chrome/browser/notifications/scheduler/BUILD.gn | 3 + .../scheduler/init_aware_scheduler.cc | 56 +++++++++ .../notifications/scheduler/init_aware_scheduler.h | 55 +++++++++ .../scheduler/init_aware_scheduler_unittest.cc | 127 +++++++++++++++++++++ .../scheduler/notification_scheduler.cc | 2 + .../scheduler/notification_scheduler.h | 5 + 6 files changed, 248 insertions(+) commit 09bb2c1c72ae1a5c85669941a7b212365c1c42d3 Author: Hector Carmona <hcarmona@chromium.org> Date: Thu Apr 18 23:50:19 2019 +0000 Navi: Add support for BookmarkBarEnabled and EditBookmarksEnabled. If either BookmarkBarEnabled or EditBookmarksEnabled is set and disabled then the 'nux-google-apps' module will not be shown. Bug: 951837 Change-Id: I8c696ceec0f408074c67610f2eff4c129d5f21d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568685 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#652397} chrome/browser/ui/webui/welcome/nux_helper.cc | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) commit 54c1ad229a32c01ff824a95abdfd840ed6c57e13 Author: Katie Dillon <kdillon@chromium.org> Date: Thu Apr 18 23:49:52 2019 +0000 Revert "Enabling forbid sync XHR in page dismissal by default." This reverts commit 1c60a4f01ea701458e70dbc01cd0225dd87ef047. Reason for revert: Causing a lot of regressions for developer apps. Original change's description: > Enabling forbid sync XHR in page dismissal by default. > > Bug: 827324 > Change-Id: Id12b26c1303a977081702e792b0bd8e3ecbd8012 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542148 > Commit-Queue: Katie Dillon <kdillon@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#649921} TBR=haraken@chromium.org,kdillon@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 827324 Change-Id: I01c10dc87ba39bb716502a995f076b3c31bb4e91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573878 Reviewed-by: Shubhie Panicker <panicker@chromium.org> Commit-Queue: Katie Dillon <kdillon@chromium.org> Cr-Commit-Position: refs/heads/master@{#652396} third_party/blink/common/features.cc | 2 +- .../xmlhttprequest-unload-sync-expected.txt | 4 +++ .../xmlhttprequest/xmlhttprequest-unload-sync.html | 36 ++++++++++++++++++++++ 3 files changed, 41 insertions(+), 1 deletion(-) commit aee5c031a69ebb58dffc6618244c0cb8efbcbb39 Author: Daniel Cheng <dcheng@chromium.org> Date: Thu Apr 18 23:49:05 2019 +0000 Make content::ResourceType an enum class. This allows us to be more explicit when content::ResourceType needs to be smuggled in an untyped int. It has the effect of introducing more static_cast<int>, but this makes the conversion sites explicit. This also allows several other incidental fixes: - the Mojo version of the enum no longer defines a sentinel value (which violates best practices in the security guidelines) - the C++ version of the enum can now define a compiler-enforced kMaxValue enumerator. - Since kMaxValue is no longer a distinct value, dummy handling for this value can be removed. This revealed a quirk in chrome/browser/predictors/loading_data_collector.cc Tbr: avi@chromium.org Tbr: blundell@chromium.org Tbr: droger@chromium.org Tbr: rdevlin.cronin@chromium.org Change-Id: I7203a029b1fcb06426c957d208e9278a25d4a45b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569345 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#652395} .../browser/aw_content_browser_client.cc | 3 +- .../browser/net/aw_web_resource_request.cc | 5 +- .../android_stream_reader_url_loader_unittest.cc | 3 +- .../aw_proxying_url_loader_factory.cc | 3 +- .../aw_resource_dispatcher_host_delegate.cc | 4 +- .../customtabs/detached_resource_request.cc | 3 +- chrome/browser/chrome_content_browser_client.cc | 2 +- .../chrome_data_use_ascriber.cc | 6 +- .../chrome_data_use_ascriber_unittest.cc | 4 +- .../extensions/api/chrome_extensions_api_client.cc | 2 +- .../api/chrome_extensions_api_client_unittest.cc | 6 +- .../ruleset_manager_unittest.cc | 20 +-- .../webrequest_rules_registry_unittest.cc | 2 +- .../api/web_request/web_request_api_unittest.cc | 2 +- .../api/web_request/web_request_apitest.cc | 3 +- .../web_request_permissions_unittest.cc | 8 +- ...hrome_content_browser_client_extensions_part.cc | 2 +- .../cross_origin_read_blocking_browsertest.cc | 5 +- .../extensions/extension_protocols_unittest.cc | 24 ++-- .../chrome_resource_dispatcher_host_delegate.cc | 15 +- .../net/network_request_metrics_browsertest.cc | 2 +- .../offline_page_request_handler_unittest.cc | 4 +- .../offline_pages/offline_page_request_job.cc | 2 +- .../offline_pages/offline_page_url_loader.cc | 3 +- .../metrics_web_contents_observer.cc | 4 +- .../metrics_web_contents_observer_unittest.cc | 16 +-- .../android_page_load_metrics_observer.cc | 2 +- .../android_page_load_metrics_observer_unittest.cc | 2 +- .../data_reduction_proxy_metrics_observer_base.cc | 2 +- ...duction_proxy_metrics_observer_base_unittest.cc | 2 +- ...requests_page_load_metrics_observer_unittest.cc | 8 +- .../lofi_page_load_metrics_observer_unittest.cc | 64 ++++----- .../observers/page_load_metrics_observer_tester.cc | 6 +- .../observers/previews_ukm_observer_unittest.cc | 66 ++++----- .../observers/ukm_page_load_metrics_observer.cc | 2 +- .../page_load_metrics_test_waiter.cc | 2 +- ...gin_response_interceptor_url_loader_throttle.cc | 3 +- .../browser/predictors/loading_data_collector.cc | 26 ++-- .../predictors/loading_data_collector_unittest.cc | 68 ++++----- .../loading_predictor_tab_helper_unittest.cc | 12 +- .../predictors/loading_stats_collector_unittest.cc | 20 +-- chrome/browser/predictors/loading_test_util.cc | 6 +- chrome/browser/predictors/loading_test_util.h | 4 +- .../resource_prefetch_predictor_unittest.cc | 40 +++--- .../previews_lite_page_url_loader_interceptor.cc | 3 +- ...ws_lite_page_url_loader_interceptor_unittest.cc | 10 +- .../browser_feature_extractor_unittest.cc | 8 +- .../safe_browsing/client_side_detection_host.cc | 4 +- .../client_side_detection_host_browsertest.cc | 4 +- .../client_side_detection_host_unittest.cc | 12 +- .../resource_request_detector.cc | 6 +- .../resource_request_detector_unittest.cc | 27 ++-- chrome/browser/signin/chrome_signin_helper.cc | 6 +- .../signin/chrome_signin_helper_unittest.cc | 4 +- ..._signin_proxying_url_loader_factory_unittest.cc | 6 +- .../signin/chrome_signin_url_loader_throttle.cc | 2 +- .../chrome_signin_url_loader_throttle_unittest.cc | 10 +- .../ui/search_engines/search_engine_tab_helper.cc | 3 +- chrome/common/prerender_url_loader_throttle.cc | 8 +- .../chromeos_merge_session_loader_throttle.cc | 3 +- .../page_load_metrics/page_resource_data_use.cc | 8 +- .../renderer/url_loader_throttle_provider_impl.cc | 2 +- chrome/test/nacl/pnacl_header_test.cc | 2 +- .../content/browser/content_lofi_decider.cc | 2 +- .../browser/content_lofi_decider_unittest.cc | 94 ++++++------ .../browser/content_lofi_ui_service_unittest.cc | 2 +- .../browser/content_resource_type_provider.cc | 4 +- .../content_resource_type_provider_unittest.cc | 68 ++++----- .../data_reduction_proxy_url_loader_throttle.cc | 5 +- ...reduction_proxy_url_loader_throttle_unittest.cc | 14 +- .../content/common/header_util.cc | 16 +-- .../content/common/header_util_unittest.cc | 12 +- .../content/content_url_request_classifier.cc | 7 +- .../android/remote_database_manager.cc | 24 ++-- .../android/remote_database_manager_unittest.cc | 25 ++-- .../browser/base_parallel_resource_throttle.cc | 2 +- .../base_parallel_resource_throttle_unittest.cc | 4 +- .../browser/safe_browsing_url_checker_impl.cc | 19 ++- .../renderer/websocket_sb_handshake_throttle.cc | 2 +- .../websocket_sb_handshake_throttle_unittest.cc | 2 +- .../browser/android/content_url_loader_factory.cc | 3 +- content/browser/android/url_request_content_job.cc | 2 +- .../android/url_request_content_job_unittest.cc | 2 +- .../browser/appcache/appcache_request_handler.cc | 11 +- .../appcache/appcache_request_handler_unittest.cc | 34 ++--- .../appcache/appcache_storage_impl_unittest.cc | 2 +- .../clear_site_data_throttle_unittest.cc | 4 +- .../devtools/devtools_url_loader_interceptor.cc | 4 +- .../devtools/devtools_url_request_interceptor.cc | 4 +- .../browser/devtools/protocol/network_handler.cc | 72 +++++----- .../browser/frame_host/render_frame_host_impl.cc | 2 +- .../cross_site_document_blocking_browsertest.cc | 22 +-- .../loader/cross_site_document_resource_handler.cc | 25 ++-- ...ross_site_document_resource_handler_unittest.cc | 121 ++++++++-------- .../loader/detachable_resource_handler_unittest.cc | 2 +- .../intercepting_resource_handler_unittest.cc | 2 +- .../loader/mime_sniffing_resource_handler.cc | 10 +- .../mime_sniffing_resource_handler_unittest.cc | 36 ++--- .../browser/loader/mojo_async_resource_handler.cc | 4 +- .../loader/mojo_async_resource_handler_unittest.cc | 4 +- .../browser/loader/navigation_url_loader_impl.cc | 19 +-- .../browser/loader/prefetch_url_loader_service.cc | 3 +- .../loader/resource_dispatcher_host_impl.cc | 16 +-- .../loader/resource_dispatcher_host_unittest.cc | 116 +++++++-------- content/browser/loader/resource_loader.cc | 2 +- content/browser/loader/resource_loader_unittest.cc | 16 +-- content/browser/loader/resource_message_filter.cc | 2 +- .../browser/loader/resource_request_info_impl.cc | 4 +- .../loader/url_loader_factory_impl_unittest.cc | 14 +- content/browser/net/accept_header_browsertest.cc | 34 ++--- content/browser/network_service_client.cc | 2 +- .../renderer_host/render_process_host_impl.cc | 4 +- content/browser/security_exploit_browsertest.cc | 2 +- .../service_worker/service_worker_browsertest.cc | 2 +- .../service_worker_controllee_request_handler.cc | 2 +- ...e_worker_controllee_request_handler_unittest.cc | 16 +-- .../service_worker_fetch_dispatcher.cc | 17 ++- .../service_worker/service_worker_metrics.cc | 6 +- .../service_worker/service_worker_metrics.h | 4 +- .../service_worker_metrics_unittest.cc | 16 +-- .../service_worker_navigation_loader.cc | 3 +- .../service_worker_new_script_loader.cc | 10 +- .../service_worker_new_script_loader.h | 4 +- .../service_worker_new_script_loader_unittest.cc | 6 +- .../service_worker_request_handler.cc | 12 +- .../service_worker_script_loader_factory.cc | 10 +- ...ervice_worker_script_loader_factory_unittest.cc | 3 +- .../service_worker_single_script_update_checker.cc | 4 +- content/browser/ssl/ssl_manager.cc | 8 +- content/browser/web_contents/web_contents_impl.cc | 2 +- .../web_contents/web_contents_impl_browsertest.cc | 18 +-- .../web_package/signed_exchange_cert_fetcher.cc | 3 +- .../signed_exchange_cert_fetcher_unittest.cc | 4 +- .../web_package/signed_exchange_validity_pinger.cc | 3 +- .../browser/worker_host/dedicated_worker_host.cc | 3 +- .../worker_host/shared_worker_service_impl.cc | 2 +- .../worker_host/worker_script_fetch_initiator.cc | 8 +- .../worker_host/worker_script_loader_factory.cc | 14 +- .../worker_script_loader_factory_unittest.cc | 3 +- content/common/content_param_traits_macros.h | 2 +- content/common/net/record_load_histograms.cc | 9 +- content/common/net/record_load_histograms.h | 6 +- .../service_worker_loader_helpers.cc | 3 +- .../common/service_worker/service_worker_utils.cc | 4 +- content/public/browser/site_isolation_policy.cc | 6 +- content/public/common/resource_intercept_policy.h | 2 +- content/public/common/resource_type.cc | 2 +- content/public/common/resource_type.h | 45 +++--- content/public/common/resource_type.mojom | 42 +++--- .../public/common/resource_type_struct_traits.cc | 159 ++++++++++----------- content/renderer/fetchers/resource_fetcher_impl.cc | 3 +- .../loader/child_url_loader_factory_bundle.cc | 2 +- content/renderer/loader/navigation_body_loader.cc | 2 +- content/renderer/loader/resource_dispatcher.cc | 7 +- .../loader/resource_dispatcher_unittest.cc | 2 +- content/renderer/loader/resource_load_stats.cc | 2 +- content/renderer/loader/web_url_loader_impl.cc | 22 +-- content/renderer/loader/web_url_request_util.cc | 40 +++--- content/renderer/render_frame_impl.cc | 4 +- .../service_worker_provider_context_unittest.cc | 2 +- .../service_worker_subresource_loader_unittest.cc | 2 +- .../api/declarative_net_request/ruleset_manager.cc | 2 +- .../api/declarative_net_request/ruleset_matcher.cc | 39 +++-- .../webrequest_condition_attribute_unittest.cc | 4 +- .../webrequest_condition_unittest.cc | 6 +- .../browser/api/web_request/web_request_api.cc | 2 +- .../api/web_request/web_request_permissions.cc | 10 +- .../web_request_permissions_unittest.cc | 36 ++--- .../api/web_request/web_request_resource_type.cc | 40 +++--- extensions/browser/extension_protocols.cc | 2 +- extensions/browser/url_request_util.cc | 6 +- .../search_engines/search_engine_tab_helper.mm | 9 +- services/network/cross_origin_read_blocking.h | 2 +- .../network/public/mojom/network_context.mojom | 6 +- .../network/public/mojom/network_service.mojom | 2 +- services/network/websocket_factory.cc | 2 +- 176 files changed, 1115 insertions(+), 1122 deletions(-) commit 1f6b18a3be54418f10eb7b0222507c797521d726 Author: David Bienvenu <davidbienvenu@chromium.org> Date: Thu Apr 18 23:48:34 2019 +0000 Ignore cloaked windows when computing occlusion. Bug: 939867 Change-Id: Ia1a8e99cea9ba5433b60f4213b1a3a1304cd9b91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573159 Reviewed-by: ccameron <ccameron@chromium.org> Reviewed-by: Bruce Dawson <brucedawson@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#652394} ui/aura/BUILD.gn | 6 +++++- ui/aura/native_window_occlusion_tracker_unittest.cc | 15 +++++++++++++++ ui/aura/native_window_occlusion_tracker_win.cc | 13 +++++++++++++ 3 files changed, 33 insertions(+), 1 deletion(-) commit 00ace4f2e6b4a33d6191df43df6031a3af5338ee Author: Chris Cunningham <chcunningham@chromium.org> Date: Thu Apr 18 23:47:50 2019 +0000 MediaCapabilities: query the stats DB for encrypted configurations This completes the chain of render-side CLs to fetch the smoothness and power efficiency stats for decodingInfo() with a KeySystemConfig. Bug: 907909 Change-Id: Ia39df593706a6b2447ea2666cd4005c4fbc8fbf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554897 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#652393} .../blink/webcontentdecryptionmoduleaccess_impl.cc | 11 +++++++ .../blink/webcontentdecryptionmoduleaccess_impl.h | 6 ++++ media/blink/webmediacapabilitiesclient_impl.cc | 24 +++++++++++--- media/blink/webmediacapabilitiesclient_impl.h | 1 + .../webmediacapabilitiesclient_impl_unittest.cc | 1 + .../web_media_capabilities_client.h | 1 + .../media_capabilities/media_capabilities.cc | 37 +++++++++++++++------- 7 files changed, 66 insertions(+), 15 deletions(-) commit c3bb1b3b51bc272a337286103038fd47de2aab8f Author: Karan Bhatia <karandeepb@chromium.org> Date: Thu Apr 18 23:46:20 2019 +0000 Extensions: Mark some web request perf. histograms as never expiring. This CL marks the following histograms as never expiring: -Extensions.WebRequest.TotalBlockingRequestTime -Extensions.WebRequest.TotalRequestTime -Extensions.WebRequest.TotalExtraHeadersRequestTime These are useful in monitoring the performance of the web request API and detecting regressions. BUG=953036 Change-Id: I296ad0a064261db44ec0004e42a27d3bad95f8c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572865 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#652392} tools/metrics/histograms/histograms.xml | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) commit 133ed70bda2e19965af6d55a77795835207c6b7b Author: Bret Sepulveda <bsep@chromium.org> Date: Thu Apr 18 23:40:31 2019 +0000 [Tab Groups] Stop using TabGroupData pointers as group IDs. Tab groups are currently identified using TabGroupData pointers. However, this is fragile because those pointers may not be valid forever and because memory address may be reused. It makes more sense to use an opaque int ID for this purpose instead. This also allows the API to explicitly define when a group may be null or not, by using base::Optional. Also, in a future patch, tab_strip_layout.h/cc will be able to operate using that ID and continue to avoid knowledge of any particular View type. This patch also includes some miscellaneous refactoring in tab_strip_model_unittest.cc. Bug: 905491 Change-Id: I9700a50d5fa9e4050ec2169af8e1362d11d9dade Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562764 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Reviewed-by: Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#652391} chrome/browser/ui/browser_navigator_params.h | 3 +- .../browser/ui/browser_tab_strip_model_delegate.cc | 2 +- .../browser/ui/browser_tab_strip_model_delegate.h | 2 +- chrome/browser/ui/browser_tabstrip.cc | 2 +- chrome/browser/ui/browser_tabstrip.h | 4 +- .../ui/tabs/existing_tab_group_sub_menu_model.cc | 25 +- .../ui/tabs/existing_tab_group_sub_menu_model.h | 3 +- chrome/browser/ui/tabs/tab_group_data.cc | 10 +- chrome/browser/ui/tabs/tab_menu_model.cc | 2 +- chrome/browser/ui/tabs/tab_strip_model.cc | 95 +++-- chrome/browser/ui/tabs/tab_strip_model.h | 61 ++-- chrome/browser/ui/tabs/tab_strip_model_delegate.h | 4 +- chrome/browser/ui/tabs/tab_strip_model_observer.cc | 23 +- chrome/browser/ui/tabs/tab_strip_model_observer.h | 24 +- chrome/browser/ui/tabs/tab_strip_model_unittest.cc | 398 +++++++-------------- .../ui/tabs/test_tab_strip_model_delegate.cc | 2 +- .../ui/tabs/test_tab_strip_model_delegate.h | 5 +- .../ui/views/tabs/browser_tab_strip_controller.cc | 12 +- .../ui/views/tabs/browser_tab_strip_controller.h | 3 +- .../views/tabs/fake_base_tab_strip_controller.cc | 39 +- .../ui/views/tabs/fake_base_tab_strip_controller.h | 14 +- chrome/browser/ui/views/tabs/tab_strip.cc | 24 +- chrome/browser/ui/views/tabs/tab_strip.h | 12 +- .../browser/ui/views/tabs/tab_strip_controller.h | 7 +- chrome/browser/ui/views/tabs/tab_strip_unittest.cc | 11 +- 25 files changed, 354 insertions(+), 433 deletions(-) commit e9d1bd018fad44aed84746f2136bae0b8be18592 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Apr 18 23:35:18 2019 +0000 Roll src/third_party/catapult f88c75708b4d..67f7f92555b7 (2 commits) https://chromium.googlesource.com/catapult.git/+log/f88c75708b4d..67f7f92555b7 git log f88c75708b4d..67f7f92555b7 --date=short --no-merges --format='%ad %ae %s' 2019-04-18 benjhayden@chromium.org Fix y-axis unit in spa 2019-04-18 benjhayden@chromium.org Fix report-template css Created with: gclient setdep -r src/third_party/catapult@67f7f92555b7 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:952290 TBR=oysteine@chromium.org Change-Id: I4f65e22452d69ab6b858c9cbb0ba57e26f67cd58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574784 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652390} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 9b1a738292b302209a9e82789ee08ac95493db18 Author: Caleb Raitto <caraitto@chromium.org> Date: Thu Apr 18 23:34:52 2019 +0000 [Cronet] Implement OnMetricsCollected() in native UrlRequest. Bug: 879208 Change-Id: I60eb7cf15b6817814addb6094ca1ff9c4c252b14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1423352 Commit-Queue: Caleb Raitto <caraitto@chromium.org> Reviewed-by: Paul Jensen <pauljensen@chromium.org> Reviewed-by: Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#652389} components/cronet/native/url_request.cc | 36 ++++++++++++++++++++++++++++++++- components/cronet/native/url_request.h | 5 +++++ 2 files changed, 40 insertions(+), 1 deletion(-) commit e781ffdd00763bc6220649c0f556e2be02131e52 Author: Chris Lu <thegreenfrog@chromium.org> Date: Thu Apr 18 23:31:36 2019 +0000 [ios] Add Const type to kCallJavascriptFunctionTimeout in FindInPageJSTest Bug: 919685 Change-Id: I8b890cf3601cdb2d2784b23b8f98f3929a7d7d39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574878 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#652388} ios/web/web_state/js/find_in_page_js_unittest.mm | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) commit 7f52fabbf7ede51631008b8245bd565f91062df2 Author: Hector Carmona <hcarmona@chromium.org> Date: Thu Apr 18 23:31:22 2019 +0000 Navi: Add support for the BrowserSignin policy. If BrowserSignin is set to Disabled (0): - "Already a Chrome user? Sign in" text will be replaced with "Skip" - The "signin-view" module will be skipped Screenshot in bug. Bug: 904875 Change-Id: I765cdf44513389111325c6aeb9c410707ac1c300 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568316 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#652387} .../resources/welcome/onboarding_welcome/BUILD.gn | 1 + .../welcome/onboarding_welcome/landing_view.html | 4 +- .../welcome/onboarding_welcome/landing_view.js | 14 ++- chrome/browser/ui/webui/welcome/nux_helper.cc | 107 ++++++++++++++++++--- chrome/browser/ui/webui/welcome/welcome_ui.cc | 3 + 5 files changed, 115 insertions(+), 14 deletions(-) commit 39c7e4b71bf2edfedb4fd8411f63d6c288cd8bc4 Author: Nikita Podguzov <nikitapodguzov@chromium.org> Date: Thu Apr 18 23:28:55 2019 +0000 Print Preview: Add test for empty PIN validation. Bug: 848942 Change-Id: I55c8c9ba6c61dbdb5de894bbf8aadc1e98239d83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571696 Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#652386} .../data/webui/print_preview/pin_settings_test.js | 38 ++++++++++++++++++++++ 1 file changed, 38 insertions(+) commit 1f7a2026ccb408ceca918ac4404598db67af15cd Author: Tanya Gupta <tgupta@chromium.org> Date: Thu Apr 18 23:28:17 2019 +0000 [SendTabToSelf] Moved ActiveNotification to its own class. This logic previously lived inside the NotificationManager making it harder to test. By moving it to a separate class, the SharedPreference logic can be tested more easily. Furthermore, the new class supports versioning so that the information stored in the SharedPreferences can be modified in the future in a backwards compatible way. Bug: 939026 Change-Id: I1953003ed3ef262c4aa7a5a038bc6d76875364bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568486 Commit-Queue: Tanya Gupta <tgupta@chromium.org> Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#652385} chrome/android/chrome_java_sources.gni | 1 + chrome/android/chrome_junit_test_java_sources.gni | 1 + .../send_tab_to_self/NotificationManager.java | 144 +-------------- .../NotificationSharedPrefManager.java | 199 +++++++++++++++++++++ .../NotificationSharedPrefManagerTest.java | 156 ++++++++++++++++ 5 files changed, 364 insertions(+), 137 deletions(-) commit c6da47318921738883feed990f55c3e4f92a8e1d Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Apr 18 23:17:38 2019 +0000 Roll src/third_party/angle d18c048ab5a6..85a239d09128 (3 commits) https://chromium.googlesource.com/angle/angle.git/+log/d18c048ab5a6..85a239d09128 git log d18c048ab5a6..85a239d09128 --date=short --no-merges --format='%ad %ae %s' 2019-04-18 jmadill@chromium.org Vulkan: Write docs on format tables. 2019-04-18 jmadill@chromium.org Vulkan: Rename Vulkan "Texture" format to "Image" 2019-04-18 jonahr@google.com Skipped tests not accumulated in dEQP stats output. Created with: gclient setdep -r src/third_party/angle@85a239d09128 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: If1d5325d2e1819b4406aa5c79025adcca78fd02b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574485 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652384} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e4f0e070faa80f2fdf97d2b36c31d63bd16f3e1a Author: Adithya Srinivasan <adithyas@chromium.org> Date: Thu Apr 18 23:17:20 2019 +0000 Portals: Expose portalHost in predecessor Exposing it in the activate callback ensures that the portalHost is exposed when the promise callback is executed. Bug: 948118, 921776 Change-Id: Ie654fdefd3e75187a06e8c06eba3de52f8276ff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548316 Reviewed-by: Nasko Oskov <nasko@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Reviewed-by: Lucas Gadani <lfg@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#652383} .../browser/frame_host/render_frame_host_impl.cc | 7 +++--- .../browser/frame_host/render_frame_host_impl.h | 3 ++- content/browser/portal/portal.cc | 6 ++--- content/browser/portal/portal.h | 2 +- content/browser/portal/portal_browsertest.cc | 2 +- content/common/frame.mojom | 6 +++-- content/renderer/render_frame_impl.cc | 6 +++-- content/renderer/render_frame_impl.h | 3 ++- third_party/blink/public/mojom/portal/portal.mojom | 2 +- third_party/blink/public/web/web_local_frame.h | 4 ++- .../renderer/core/events/portal_activate_event.cc | 20 ++++++++++++--- .../renderer/core/events/portal_activate_event.h | 10 ++++++-- .../renderer/core/frame/web_local_frame_impl.cc | 6 +++-- .../renderer/core/frame/web_local_frame_impl.h | 3 ++- .../core/html/portal/html_portal_element.cc | 25 +++++++++++-------- .../external/wpt/portals/portal-activate-data.html | 3 ++- .../wpt/portals/portals-activate-resolution.html | 21 ++++++++++++++++ .../wpt/portals/portals-adopt-predecessor.html | 2 -- .../wpt/portals/portals-create-orphaned.html | 19 -------------- .../portals/resources/portal-create-orphaned.html | 28 --------------------- .../portals-adopt-predecessor-portal.html | 11 ++++---- .../resources/portals-adopt-predecessor.html | 15 +++++------ .../portals/portals-create-orphaned.html | 29 ++++++++++++++++++++++ .../resources/portals-create-orphaned-portal.html | 11 ++++++++ .../portals/resources/simple-portal.html | 6 +++++ 25 files changed, 149 insertions(+), 101 deletions(-) commit b7942f01f858de1440f3b159402f2dbccc8672c1 Author: Nico Weber <thakis@chromium.org> Date: Thu Apr 18 23:14:59 2019 +0000 libc++/win/natvis: Add visualizer for std::map. Thanks to Eric Feiveson <ericfe@google.com> for suggesting to rely on the typedefs in std::map<> which was critical for getting this working. Bug: 947911 Change-Id: I2a73061698d45ace2eaf859534f696a86542d35b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574820 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#652382} tools/win/DebugVisualizers/libc++.natvis | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) commit 1ee4f5d86633cb7313740ac6a303a6e063d54370 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Apr 18 23:08:45 2019 +0000 Roll src/third_party/chromite 86dcbc73338c..b76dd93cb5bb (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/86dcbc73338c..b76dd93cb5bb git log 86dcbc73338c..b76dd93cb5bb --date=short --no-merges --format='%ad %ae %s' 2019-04-18 jrosenth@chromium.org chromeos-config: experimental/important changes Created with: gclient setdep -r src/third_party/chromite@b76dd93cb5bb The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: Ib27764b2a88be2ae7fdbef998133eb8c6256e399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574484 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652381} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 8fea23efde02315cea495037fd3bd19581883520 Author: Archana Simha <archanasimha@google.com> Date: Thu Apr 18 23:01:42 2019 +0000 Randomize timing of ad sample report after page has finished loading Bug: 953090 Change-Id: Idd7b74c5e32ddb711910b9c178b1e33037c7ff48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570696 Reviewed-by: Varun Khaneja <vakh@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#652380} components/safe_browsing/triggers/ad_sampler_trigger.cc | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) commit 0d5e714121df6703b1477d99cc2b883d24cf971c Author: Lucas Furukawa Gadani <lfg@chromium.org> Date: Thu Apr 18 23:00:50 2019 +0000 Remove more const interfaces from content/public. Bug: 908139 Change-Id: Ib362d71f610a90fe094f3c4ed892ef578ebf85aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566417 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#652379} .../chromeos/accessibility/speech_monitor.cc | 2 +- .../chromeos/accessibility/speech_monitor.h | 2 +- .../dom_distiller_viewer_source_browsertest.cc | 2 +- chrome/browser/prerender/prerender_browsertest.cc | 2 +- .../speech/extension_api/tts_extension_apitest.cc | 2 +- chrome/browser/speech/tts_chromeos.h | 2 +- .../browser/speech/tts_controller_delegate_impl.cc | 4 ++-- .../browser/speech/tts_controller_delegate_impl.h | 5 ++--- .../tts_controller_delegate_impl_unittest.cc | 3 +-- chrome/service/service_utility_process_host.cc | 2 +- chrome/service/service_utility_process_host.h | 2 +- content/browser/browser_child_process_host_impl.cc | 6 +++--- content/browser/browser_child_process_host_impl.h | 6 +++--- content/browser/child_process_launcher_helper.h | 5 ++--- .../child_process_launcher_helper_android.cc | 2 +- .../child_process_launcher_helper_fuchsia.cc | 2 +- .../browser/child_process_launcher_helper_linux.cc | 2 +- .../browser/child_process_launcher_helper_mac.cc | 2 +- .../browser/child_process_launcher_helper_win.cc | 2 +- .../browser/frame_host/navigation_handle_impl.cc | 4 ++-- .../browser/frame_host/navigation_handle_impl.h | 4 ++-- .../browser/frame_host/render_frame_host_impl.cc | 4 ++-- .../browser/frame_host/render_frame_host_impl.h | 4 ++-- content/browser/posix_file_descriptor_info_impl.cc | 15 +++++++------- content/browser/posix_file_descriptor_info_impl.h | 15 +++++++------- content/browser/ppapi_plugin_process_host.h | 2 +- .../pepper/browser_ppapi_host_impl.cc | 11 +++++----- .../renderer_host/pepper/browser_ppapi_host_impl.h | 6 +++--- content/browser/speech/tts_controller_unittest.cc | 4 ++-- content/browser/speech/tts_platform_impl.cc | 2 +- content/browser/speech/tts_platform_impl.h | 2 +- content/browser/speech/tts_utterance_impl.cc | 24 +++++++++++----------- content/browser/speech/tts_utterance_impl.h | 24 +++++++++++----------- content/browser/tracing/tracing_controller_impl.cc | 4 ++-- content/browser/tracing/tracing_controller_impl.h | 4 ++-- .../public/browser/browser_child_process_host.h | 4 ++-- content/public/browser/browser_ppapi_host.h | 6 +++--- content/public/browser/navigation_handle.h | 4 ++-- .../public/browser/posix_file_descriptor_info.h | 14 ++++++------- content/public/browser/render_frame_host.h | 4 ++-- content/public/browser/tracing_controller.h | 2 +- content/public/browser/tts_controller_delegate.h | 2 +- content/public/browser/tts_platform.h | 2 +- content/public/browser/tts_utterance.h | 24 +++++++++++----------- .../public/common/child_process_host_delegate.h | 2 +- content/public/test/mock_navigation_handle.h | 4 ++-- 46 files changed, 123 insertions(+), 129 deletions(-) commit 220a8164046fe57daadb47cf0f30a4442a69317b Author: John Lee <johntlee@chromium.org> Date: Thu Apr 18 22:59:49 2019 +0000 Settings WebUI: Display message when there are no supported languages for spellcheck Change-Id: I8d9681685e2320626d44528ead716f44d1bc327e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572814 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by: Esmael El-Moslimany <aee@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#652378} chrome/app/settings_strings.grdp | 3 +++ chrome/browser/resources/settings/languages_page/languages_page.html | 4 ++++ .../browser/ui/webui/settings/settings_localized_strings_provider.cc | 2 ++ 3 files changed, 9 insertions(+) commit 3e611bfbad1661e022a694f53e67bef05a8a5bc7 Author: Alexander Timin <altimin@chromium.org> Date: Thu Apr 18 22:58:52 2019 +0000 [bfcache] Track dedicated workers and non-main-thread worklets for bfcache metrics BUG=933147 R=nhiroki@chromium.org,kinuko@chromium.org Change-Id: I892b5dace7d56d55bd7087e75abc135793b7547a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569205 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#652377} .../frame_host/back_forward_cache_metrics_browsertest.cc | 16 ++++++++++++++++ .../back_forward_cache/page_with_dedicated_worker.html | 7 +++++++ content/test/data/back_forward_cache/worker.js | 5 +++++ .../common/scheduler/web_scheduler_tracked_feature.h | 3 ++- .../core/workers/threaded_messaging_proxy_base.cc | 6 ++++++ .../core/workers/threaded_messaging_proxy_base.h | 4 ++++ .../platform/scheduler/common/scheduling_policy.cc | 1 + 7 files changed, 41 insertions(+), 1 deletion(-) commit eb1f48e567c054fd8b2a3409383829b5e5ea1a4f Author: Robert Lord <lard@google.com> Date: Thu Apr 18 22:58:43 2019 +0000 [fuchsia] Check if InputEvent is null in IME's DidUpdateState DidUpdateState can be null if there is no key associated with a state update. In these cases, since we only care about extracting the keypress associated with edits, we can just ignore the DidUpdateState call and return early. Change-Id: I5a6ce0a5ef13b8afad89abf6dab3eaf39167e74a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573083 Commit-Queue: Robert Lord <lard@google.com> Reviewed-by: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#652376} ui/base/ime/fuchsia/input_method_fuchsia.cc | 7 +++++++ 1 file changed, 7 insertions(+) commit c1dec1c5b090ba257b898db35a1a3224d4269b2d Author: Tanya Gupta <tgupta@chromium.org> Date: Thu Apr 18 22:56:05 2019 +0000 [SendTabToSelf] Plumb device support for SendTabToSelf feature in DeviceInfo A callback is used to populate the DeviceInfo with the latest state on support for SendTabToSelf feature on the device. The information is used to determine which set of devices tabs can be shared to. Change-Id: Ib0f9093ae20ff8fc05494222789107a215057d79 Bug: 937004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570478 Commit-Queue: Tanya Gupta <tgupta@chromium.org> Reviewed-by: Peter Lee <pkl@chromium.org> Reviewed-by: sebsg <sebsg@chromium.org> Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#652375} .../id_mapping_helper_unittest.cc | 16 ++++--- .../signed_in_devices_api_unittest.cc | 50 ++++++++-------------- .../sync/device_info_sync_service_factory.cc | 10 ++++- components/send_tab_to_self/features.cc | 10 +++++ components/send_tab_to_self/features.h | 9 ++++ components/sync/device_info/device_info.cc | 20 +++++++-- components/sync/device_info/device_info.h | 10 ++++- .../sync/device_info/device_info_sync_bridge.cc | 9 +++- .../device_info_sync_bridge_unittest.cc | 9 +++- .../device_info/local_device_info_provider_impl.cc | 18 +++++++- .../device_info/local_device_info_provider_impl.h | 7 ++- .../local_device_info_provider_impl_unittest.cc | 24 ++++++++++- .../sync/protocol/device_info_specifics.proto | 16 +++++++ components/sync/protocol/proto_visitors.h | 5 +++ .../sync/device_info_sync_service_factory.mm | 7 ++- .../web_view_device_info_sync_service_factory.mm | 4 +- 16 files changed, 171 insertions(+), 53 deletions(-) commit 64854803606c97ddddb568c4266d1a1c4c87d20e Author: Alexander Timin <altimin@chromium.org> Date: Thu Apr 18 22:54:10 2019 +0000 [bfcache] Add a feature to disable HTTP cache for history navigations This will allow us to measure the performance difference and see the difference in the user engagement metrics and extrapolate to estimate the usefulness of bfcache. One-pager: https://docs.google.com/document/d/10Ff_5oq7k-oYuXTTKdN0v_JKG3bU1GPgAWWF7i4nMvs/edit# R=creis@chromium.org BUG=954271 Change-Id: I54dfe4634739a6c1eb3d33eee5025ecfe8622945 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572343 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by: Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#652374} content/browser/frame_host/navigation_request.cc | 15 +++++++++++++++ 1 file changed, 15 insertions(+) commit 706ee6daa65a6d1b38af7864b5b136893fb3a348 Author: Reilly Grant <reillyg@chromium.org> Date: Thu Apr 18 22:53:08 2019 +0000 Notify of UsbService destruction as 1st step in destructor This change ensures that observers are notified that the UsbService is being destroyed as the very first step of the destructor, which unfortunately means that an explicit call needs to be added as the first line of every subclass destructor. This allows the DeviceManagerImpl instance in the device service to close all bindings before callbacks owned by the UsbService are destroyed. Otherwise these trigger a DCHECK. Bug: 953248 Change-Id: I0a05f29a6e759cb4340301b92f13ea90af76bcd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574142 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#652373} device/usb/usb_service.cc | 10 +++++++--- device/usb/usb_service.h | 4 ++++ device/usb/usb_service_android.cc | 1 + device/usb/usb_service_android.h | 2 +- device/usb/usb_service_impl.cc | 1 + device/usb/usb_service_impl.h | 2 +- device/usb/usb_service_linux.cc | 4 +++- device/usb/usb_service_linux.h | 2 +- device/usb/usb_service_win.cc | 4 +++- device/usb/usb_service_win.h | 3 ++- 10 files changed, 24 insertions(+), 9 deletions(-) commit 7318c3d0bb4812240c2b71e9413f967900fce9c5 Author: Darwin Huang <huangdarwin@chromium.org> Date: Thu Apr 18 22:52:47 2019 +0000 Async Clipboard: Move function definitions to match declaration order Function declaration (.h) and definition (.cc) orders should match. Move them around so that they do match. Also, place helper functions under the main read/write functions. All changes affect only function declaration/definition order, except changes marked with comments. Change-Id: I546f8135e4f7ff9b597f31d316de64abda7deb73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572759 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#652372} .../modules/clipboard/clipboard_promise.cc | 231 ++++++++++----------- .../renderer/modules/clipboard/clipboard_promise.h | 33 ++- 2 files changed, 129 insertions(+), 135 deletions(-) commit 1746a9387f412165eec480a45300580d6d341d13 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Thu Apr 18 22:49:19 2019 +0000 flags: remove enable-block-tab-unders This change removes the flag and marks the feature for later removal. Bug: 954178 Change-Id: Ieeb004efb6fed206109ee8e8dad5cb40f4e0fd17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572704 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#652371} chrome/browser/about_flags.cc | 5 ----- chrome/browser/flag-metadata.json | 5 ----- chrome/browser/flag_descriptions.cc | 5 ----- chrome/browser/flag_descriptions.h | 3 --- chrome/browser/ui/blocked_content/tab_under_navigation_throttle.h | 1 + 5 files changed, 1 insertion(+), 18 deletions(-) commit 2ecc5d657db125c7711b91eb7e6d3836ab2de0e8 Author: Xing Liu <xingliu@chromium.org> Date: Thu Apr 18 22:45:52 2019 +0000 Notification scheduler: Register database in proto database. This CL registered the database needed by notification scheduler in leveldb proto. TBR=peter@chromium.org Bug: 930968 Change-Id: Ib397a706c0a91ca688f19bb98d022205b1e3ca14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566538 Reviewed-by: Mark Pearson <mpearson@chromium.org> Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Reviewed-by: ssid <ssid@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#652370} .../notification_schedule_service_factory.cc | 10 ++++-- chrome/browser/notifications/scheduler/BUILD.gn | 1 + .../scheduler/schedule_service_factory_helper.cc | 3 +- .../scheduler/schedule_service_factory_helper.h | 8 +++-- .../public/shared_proto_database_client_list.cc | 38 +++++++++++----------- .../public/shared_proto_database_client_list.h | 10 ++++-- tools/metrics/histograms/histograms.xml | 6 ++++ 7 files changed, 50 insertions(+), 26 deletions(-) commit bc1ee817becfd1037a1607cd3218bbd0c3801f68 Author: Sergey Ulanov <sergeyu@google.com> Date: Thu Apr 18 22:45:23 2019 +0000 [Fuchsia] Fix gfx::CloneHandleForIPC() to use correct rights flag Previously zx_handle_duplicate() was called with ZX_RIGHT_DUPLICATE. This means that the duplicate handle cannot be used for anything other than to create new handles. Fixed it to use ZX_RIGHT_SAME_RIGHTS. Bug: 852011 Change-Id: I3e628430676e7da56044502c3142ed1c5600e2c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572371 Reviewed-by: Michael Spang <spang@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#652369} ui/gfx/native_pixmap_handle.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 2d1a6655a5c2618a600771ecd1f1009ec41f2a96 Author: Orin Jaworski <orinj@chromium.org> Date: Thu Apr 18 22:41:10 2019 +0000 Revert "[omnibox] Add and load Pedal concept data for de, en, fr, ja, zh-CN" This reverts commit 1e6642b0358084c7d9069dca4fd03cad16641700. Reason for revert: This change broke a translation extraction tool process outside of Chromium. It can probably be updated to handle the change, and better to not be broken in the meantime. For details, see https://crbug.com/954348 : Translation extraction failure (components_strings.grd) Original change's description: > [omnibox] Add and load Pedal concept data for de, en, fr, ja, zh-CN > > Previously, Pedal concept data was a singular resource in English but > this CL restructures the resources to load localized data from a > pak depending on selected language. Data for the first four non-English > languages localized by the translation team is included. > > Bug: 893183 > Change-Id: I0e88d23de65038720a4f3543613ff8bd83dc5444 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572526 > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Tommy Li <tommycli@chromium.org> > Commit-Queue: Orin Jaworski <orinj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#652212} TBR=tommycli@chromium.org,tedchoc@chromium.org,agrieve@chromium.org,orinj@chromium.org Change-Id: I0e3a37b3828b164f43275fa937e7a2a9d9a746bd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 893183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574200 Reviewed-by: Orin Jaworski <orinj@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#652368} components/components_strings.grd | 4 - .../omnibox/browser/omnibox_pedal_concepts.h | 2 +- .../omnibox_pedal_implementations_unittest.cc | 106 ++------------------- .../omnibox/browser/omnibox_pedal_provider.cc | 8 +- .../omnibox/resources/omnibox_pedal_concepts.json | 1 + .../resources/omnibox_pedal_concepts_de.json | 1 - .../resources/omnibox_pedal_concepts_en.json | 1 - .../resources/omnibox_pedal_concepts_fr.json | 1 - .../resources/omnibox_pedal_concepts_ja.json | 1 - .../resources/omnibox_pedal_concepts_zh-CN.json | 1 - .../omnibox/resources/omnibox_resources.grdp | 23 ----- components/resources/OWNERS | 1 + components/resources/components_resources.grd | 1 + components/resources/omnibox_resources.grdp | 4 + tools/gritsettings/resource_ids | 3 +- 15 files changed, 20 insertions(+), 138 deletions(-) commit d05faaacb5e9c2402a652d7ff46ccd97db146d0c Author: Sunny Sachanandani <sunnyps@chromium.org> Date: Thu Apr 18 22:40:10 2019 +0000 gpu: Remove temporary debugging checks from direct composition surface TBR=zmo@chromium.org,magchen@chromium.org Bug: 848093, 868561, 890227 Change-Id: Idb5362622787a3b32cfdfe5e585b71c92af4f7e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574141 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#652367} gpu/ipc/service/direct_composition_surface_win.cc | 60 +---------------------- 1 file changed, 1 insertion(+), 59 deletions(-) commit 7fd36364466acd559bef29deaa8471d99a239e1f Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Apr 18 22:40:05 2019 +0000 Roll src/third_party/depot_tools 7b2943927c04..8dfc0bce4ac7 (1 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7b2943927c04..8dfc0bce4ac7 git log 7b2943927c04..8dfc0bce4ac7 --date=short --no-merges --format='%ad %ae %s' 2019-04-18 btolsch@chromium.org Add openscreen gclient config copy-pasta Created with: gclient setdep -r src/third_party/depot_tools@8dfc0bce4ac7 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I524f40b4f2c99256410e2e521d414b736591e095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574778 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652366} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit ac06fd99ac7ba5c031c05f31ab687215690165bc Author: Moe Ahmadi <mahmadi@chromium.org> Date: Thu Apr 18 22:39:03 2019 +0000 [IOS][Translate] Translate page when Translate Manual Trigger entry is tapped Changes the behaviour of the Translate Manual Trigger entry so that the page automatically gets translated when the entry is tapped. Bug: 905816 Change-Id: I7cebd628039c1d45e66832f0381b6ec040f4f610 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570528 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Reviewed-by: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#652365} .../translate/core/browser/translate_manager.cc | 10 +++++++++- .../translate/core/browser/translate_manager.h | 5 +++-- ios/chrome/app/strings/ios_strings.grd | 4 ++-- ios/chrome/browser/translate/translate_egtest.mm | 23 ++++++++++++++-------- .../ui/browser_view/browser_view_controller.mm | 2 +- 5 files changed, 30 insertions(+), 14 deletions(-) commit 1f14c5f6434f5a3eec97df39e20e9c59a41a5e94 Author: Dominic Mazzoni <dmazzoni@chromium.org> Date: Thu Apr 18 22:37:34 2019 +0000 Skip fuzzing accessibility trees with too many nodes. Clusterfuzz tries running this code with random inputs, and we got a bug that one input made it time out - but the issue was that the input was super large. It's not surprising that it would time out if you give it enough nodes. I set the limit at 500,000 nodes for release mode, which is larger than any web page I've ever seen. For debug mode I set it at 50,000 nodes because larger than that can time out. Bug: 944999 Change-Id: I50b57153876a65f92c5a88677bdffe64b8c7ae7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574622 Reviewed-by: Katie Dektar <katie@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#652364} ui/accessibility/ax_tree_fuzzer.cc | 11 +++++++++++ 1 file changed, 11 insertions(+) commit c004c70f4932d808cd80a757431d084c58f00f61 Author: Hongchan Choi <hongchan@chromium.org> Date: Thu Apr 18 22:37:07 2019 +0000 [WebAudio DevTools] Implements browser protocol and inspector agent * This is branched off from: crrev.com/c/1524645 This CL implements a new inspector domain for WebAudio and inspector agent class. In order to track activities of BaseAudioContext, a tracker class (BaseAudioContextTracker) was newly introduced as a supplement of Page object. Bug: 837323 Change-Id: I90e8446f340c20ba0822de4723643185159717ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1456684 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#652363} third_party/blink/renderer/core/inspector/BUILD.gn | 2 + .../renderer/core/inspector/browser_protocol.pdl | 73 ++++++++++++ .../core/inspector/inspector_protocol_config.json | 3 + .../blink/renderer/modules/modules_initializer.cc | 4 + .../blink/renderer/modules/webaudio/BUILD.gn | 4 + .../renderer/modules/webaudio/audio_context.cc | 6 + .../renderer/modules/webaudio/audio_context.h | 2 + .../modules/webaudio/base_audio_context.cc | 39 +++++++ .../renderer/modules/webaudio/base_audio_context.h | 21 +++- .../modules/webaudio/base_audio_context_tracker.cc | 83 ++++++++++++++ .../modules/webaudio/base_audio_context_tracker.h | 58 ++++++++++ .../modules/webaudio/inspector_web_audio_agent.cc | 124 +++++++++++++++++++++ .../modules/webaudio/inspector_web_audio_agent.h | 55 +++++++++ .../modules/webaudio/offline_audio_context.cc | 7 ++ .../modules/webaudio/offline_audio_context.h | 2 + .../devtools/agents-enable-disable-expected.txt | 4 + .../webaudio/webaudio-basic-expected.txt | 27 +++++ .../inspector-protocol/webaudio/webaudio-basic.js | 37 ++++++ 18 files changed, 549 insertions(+), 2 deletions(-) commit 716b7ef5a9bbd722587b583bcbc0eb66de84ae7a Author: Paul Miller <paulmiller@google.com> Date: Thu Apr 18 22:36:29 2019 +0000 Mirror crosstalk_test.py's simulated assignment tests in Chromium This is a gtest equivalent of the private Python tests which simulate assigning users to groups. The same expected results are hard-coded in both places, to ensure the implementations match. See internal change http://cr/243178499. Change-Id: I1f70ab628f9579a450b54c90f8a7db7e2e6c1ea1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564645 Reviewed-by: Steven Holte <holte@chromium.org> Commit-Queue: Paul Miller <paulmiller@chromium.org> Cr-Commit-Position: refs/heads/master@{#652362} components/variations/BUILD.gn | 1 + .../variations/simulate_for_crosstalk_unittest.cc | 110 +++++++++++++++++++++ 2 files changed, 111 insertions(+) commit d157a7394b68559eecaeee44d114f2786d5ec36a Author: Seth Hampson <shampson@chromium.org> Date: Thu Apr 18 22:35:50 2019 +0000 RTCQuicTransport datagram support. This includes implementation for supporting datagram APIs in the RTCQuicTransport. Adds APIs to IDL, wires to P2PQuicTransport & adds necessary implementation in JS binding code. Bug: 874296 Change-Id: I402a3dbe742db3a9acb121d900de13137d3ec14c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1567564 Commit-Queue: Seth Hampson <shampson@chromium.org> Reviewed-by: Seth Hampson <shampson@chromium.org> Reviewed-by: Steve Anton <steveanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#652361} .../peerconnection/adapters/p2p_quic_transport.h | 4 +- .../adapters/p2p_quic_transport_impl.cc | 2 +- .../adapters/p2p_quic_transport_test.cc | 10 +- .../peerconnection/adapters/quic_transport_host.cc | 28 +- .../peerconnection/adapters/quic_transport_host.h | 4 +- .../adapters/quic_transport_proxy.cc | 27 +- .../peerconnection/adapters/quic_transport_proxy.h | 14 +- .../test/mock_p2p_quic_transport_delegate.h | 2 +- .../adapters/web_rtc_cross_thread_copier.h | 6 + .../modules/peerconnection/rtc_quic_transport.cc | 163 +++++++++- .../modules/peerconnection/rtc_quic_transport.h | 73 ++++- .../modules/peerconnection/rtc_quic_transport.idl | 6 + .../peerconnection/rtc_quic_transport_stats.idl | 2 + .../peerconnection/rtc_quic_transport_test.cc | 357 ++++++++++++++++++++- .../wpt/webrtc-quic/RTCQuicTransport.https.html | 117 ++++++- .../global-interface-listing-expected.txt | 4 + 16 files changed, 779 insertions(+), 40 deletions(-) commit 6fa6fa798bd930390c4e1470ed8f2c29a332170f Author: Tibor Goldschwendt <tiborg@chromium.org> Date: Thu Apr 18 22:32:47 2019 +0000 [modules] Add mechanism to load native libraries from feature modules + Apply this to the VR dummy lib. Bug: 921665 Change-Id: Iacb7d9125ec04fbf2baa678a44ca24a9731e80b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568245 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by: Richard Coles <torne@chromium.org> Reviewed-by: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#652360} base/BUILD.gn | 3 +++ base/android/bundle_utils.cc | 27 ++++++++++++++++++++++ base/android/bundle_utils.h | 25 ++++++++++++++++++++ .../java/src/org/chromium/base/BundleUtils.java | 13 +++++++++++ .../browser/android/vr/ui_module_dummy_factory.cc | 6 ++--- 5 files changed, 71 insertions(+), 3 deletions(-) commit 56324206606cbf004f74bc0a5d0cf859b650cd44 Author: Gang Wu <gangwu@chromium.org> Date: Thu Apr 18 22:32:30 2019 +0000 [Feed] New Histogram OnTaskFinished Implement BasicLoggingApi#OnTaskFinished, which will record the tasks queuing time and executing time. Bug: 924739 Change-Id: Icd54fc9dad6b2150180508e912699086fd0d2bfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572554 Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Sky Malice <skym@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#652359} .../chrome/browser/feed/FeedLoggingBridge.java | 5 +- chrome/browser/android/feed/feed_logging_bridge.cc | 10 + chrome/browser/android/feed/feed_logging_bridge.h | 6 + components/feed/core/feed_logging_metrics.cc | 262 +++++++++++++++++++++ components/feed/core/feed_logging_metrics.h | 2 + .../feed/core/feed_logging_metrics_unittest.cc | 14 ++ tools/metrics/histograms/histograms.xml | 61 +++++ 7 files changed, 359 insertions(+), 1 deletion(-) commit d28f9bda6f56e77e94001499bbb5e189a79b588f Author: Yue Ru Sun <yrsun@chromium.org> Date: Thu Apr 18 22:31:12 2019 +0000 Reland "Specify relative order of nodes in ukm.xml" This is a reland of 2657e7df8f42b10e8dd0e66ea3fd9bc98e28c52c Original change's description: > Specify relative order of nodes in ukm.xml > > For each ObjectNodeType, specify alphabetization rules for all its child nodes types, which enforce their order relative to other types when pretty printed (sorting key is checked here: https://cs.chromium.org/chromium/src/tools/metrics/common/pretty_print_xml.py?q=_TransformByAlphabetizing&g=0&l=143). This patch fixes the issue where the pretty print script needs to be run more than once before the XML is sufficiently pretty for presubmit check. > > > Bug: 801614 > Change-Id: I7e9076c8e55d300f346bde07db0b12d4c7533661 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561610 > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Commit-Queue: Yue Ru Sun <yrsun@chromium.org> > Cr-Commit-Position: refs/heads/master@{#649863} Bug: 801614 Change-Id: Ib209b5eb941348dee78c35c5614264999d69963d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564792 Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Yue Ru Sun <yrsun@chromium.org> Cr-Commit-Position: refs/heads/master@{#652358} tools/metrics/BUILD.gn | 6 ++ tools/metrics/metrics_python_tests.py | 1 + tools/metrics/ukm/codegen.py | 13 ++-- tools/metrics/ukm/gen_builders_test.py | 112 +++++++++++++++++++++++++++++++++ tools/metrics/ukm/pretty_print.py | 2 +- tools/metrics/ukm/ukm_model.py | 58 +++++++++++------ tools/metrics/ukm/ukm_model_test.py | 55 ++++++++++++++-- 7 files changed, 218 insertions(+), 29 deletions(-) commit 03e3ce664d318dfd4d3905bb709b3b7d6585d5c5 Author: Oystein Eftevaag <oysteine@google.com> Date: Thu Apr 18 22:26:00 2019 +0000 Roll src/third_party/perfetto/ 3d46e0d12..7fa9a66b2 (3 commits) Manual roll + buildfix https://android.googlesource.com/platform/external/perfetto.git/+log/3d46e0d12b17..7fa9a66b28ac $ git log 3d46e0d12..7fa9a66b2 --date=short --no-merges --format='%ad %ae %s' 2019-04-18 fmayer Remove gaps from intern ids. 2019-04-17 oysteine Exposed GetInProcessShmemArbiter() in ProducerEndpoint 2019-04-17 rsavitski heapprofd: large increase to spinlock timeout ~10ms -> ~1s Created with: roll-dep src/third_party/perfetto TBR=eseckler@chromium.org Change-Id: I384ea91c0a5755a2b28d40b7001c231f7cb43bf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574819 Reviewed-by: oysteine <oysteine@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#652357} DEPS | 2 +- services/tracing/public/cpp/perfetto/producer_client.cc | 5 +++++ services/tracing/public/cpp/perfetto/producer_client.h | 1 + 3 files changed, 7 insertions(+), 1 deletion(-) commit dae5564b63592c361fd3e1de590b7c7bb9ecb0b3 Author: Tommy Steimel <steimel@chromium.org> Date: Thu Apr 18 22:24:52 2019 +0000 MPRIS: Add title/artist/album metadata This CL adds title, artist, and album names to MPRIS metadata. These were left out of crrev.com/c/1562628 since there was a failing perf unit test. However, it turns out the issue was just that the test happened to use non-ASCII characters and this hit a DCHECK as we were converting to ASCII. It turns out this conversion is unnecessary, as MPRIS can handle wide strings. So this CL switches MPRIS to intake base::string16s for the metadata so we can send the media session metadata strings directly. Bug: 951584, 952410 Change-Id: I3723554369d47041ac48e39a92bbd91c484eda21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566224 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#652356} content/browser/media/mpris_notifier.cc | 11 +++++++++-- content/browser/media/mpris_notifier_unittest.cc | 8 ++++++++ ui/base/mpris/mock_mpris_service.h | 6 +++--- ui/base/mpris/mpris_service.h | 7 ++++--- ui/base/mpris/mpris_service_impl.cc | 6 +++--- ui/base/mpris/mpris_service_impl.h | 6 +++--- ui/base/mpris/mpris_service_impl_unittest.cc | 5 +++-- 7 files changed, 33 insertions(+), 16 deletions(-) commit 6871d7f3ca1547c492e50cce4e104789eb061cbd Author: Varun Khaneja <vakh@chromium.org> Date: Thu Apr 18 22:24:31 2019 +0000 [M75] Try to capture the SafetyNetId if the feature is enabled (disabled by default) Patchset 1: Simply reverts: https://crrev.com/c/1574143 Patchset 2: Edit commit message Patchset 3: Adds a Finch flag and gates the GmsCore call Patchset 4: Edit commit message R=drubery Bug: 954255 Change-Id: If518147b60b74d539d8a53e1e0a9b2492168ce82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574821 Auto-Submit: Varun Khaneja <vakh@chromium.org> Reviewed-by: Daniel Rubery <drubery@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#652355} .../telemetry/android/android_telemetry_service.cc | 16 +++++++++++++--- components/safe_browsing/features.cc | 3 +++ components/safe_browsing/features.h | 4 ++++ 3 files changed, 20 insertions(+), 3 deletions(-) commit c5cd97e5d1e9052e2b6bb32b9d6e6f3d9159bbd4 Author: Ian Kilpatrick <ikilpatrick@chromium.org> Date: Thu Apr 18 22:23:46 2019 +0000 [LayoutNG] Fix float micro-benchmarks. The new exclusion space produced (for a layout result) gets its internal derived geometry from the previous input constraint space. However the patch: https://chromium-review.googlesource.com/c/chromium/src/+/1553646 ... made it so we always copy the new constraint space into the layout result first (moving hte derived geometry data-structure). As such when we access the "old" input exclusion space, it didn't contain the derived geometry data-structure. This make MergeExclusionSpaces use the copied constraint space's NGExclusionSpace instead. Bug: 635619 Change-Id: If5c2c856af39ac6af7516713a7d90e41d08b3e35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573523 Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#652354} third_party/blink/renderer/core/layout/ng/ng_layout_result.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 08a2676787550f3b3d19c011dba258e40a820096 Author: Jacob Dufault <jdufault@google.com> Date: Thu Apr 18 22:22:05 2019 +0000 cros: Eliminate ArcKioskSplashScreenView::Delegate Also move ArcKioskSplashScreenView into arc_kiosk_splash_screen_handler.h. Bug: 928555 Change-Id: I5f95c23cb11fa91e5a2380d4ab1e67fe50576971 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566611 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#652353} chrome/browser/chromeos/BUILD.gn | 1 - .../browser/chromeos/login/arc_kiosk_controller.cc | 21 ++++---- .../browser/chromeos/login/arc_kiosk_controller.h | 14 +++--- .../login/screens/arc_kiosk_splash_screen_view.h | 58 ---------------------- .../login/arc_kiosk_splash_screen_handler.cc | 14 +++--- .../login/arc_kiosk_splash_screen_handler.h | 35 +++++++++++-- 6 files changed, 57 insertions(+), 86 deletions(-) commit 61d37559c4a513d37f91b932190d2d16d1586c0f Author: Jinsuk Kim <jinsukkim@chromium.org> Date: Thu Apr 18 22:19:20 2019 +0000 Android: Add null checks in TabBrowserControlsState Thr reported bug about NPE shows it is possible that TabBrowserControlsState can be accessed before |Tab.initialize()| is executed. This CL adds null checks in the class to make the call no-op or return a reasonable default value when the situation occurs. Bug: 953643 Change-Id: Ie38edba7d9a500f62735dfc9cc7f435ecf27604c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572982 Reviewed-by: David Trainor <dtrainor@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#652352} .../org/chromium/chrome/browser/vr/VrShell.java | 4 +- .../browser/compositor/bottombar/OverlayPanel.java | 7 +--- .../fullscreen/ChromeFullscreenManager.java | 2 +- .../browser/modaldialog/TabModalPresenter.java | 4 +- .../browser/native_page/BasicNativePage.java | 2 +- .../chromium/chrome/browser/ntp/NewTabPage.java | 3 +- .../browser/tab/TabBrowserControlsState.java | 46 ++++++++++++++-------- .../chrome/browser/tab/TabFullscreenHandler.java | 8 ++-- .../chrome/browser/webapps/WebappActivity.java | 4 +- .../browser/widget/bottomsheet/BottomSheet.java | 5 +-- 10 files changed, 47 insertions(+), 38 deletions(-) commit 8babc70c0953ab907cacb83787c15bf2e2adff4a Author: Bret Sepulveda <bsep@chromium.org> Date: Thu Apr 18 22:18:20 2019 +0000 Revert "java: Add a choreographer frame task trait" This reverts commit f4ba6c5b332c4d893fd07801b21053fa68c0b949. Reason for revert: content_shell_test_apk failing on Android CFI Example: https://ci.chromium.org/p/chromium/builders/ci/Android%20CFI/5101 FindIt analysis: https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.memory/builders/Android%20CFI/builds/5101 Original change's description: > java: Add a choreographer frame task trait > > This is useful if you need to guarantee something like a layout pass has > occurred before your task runs. Tasks posted with TaskTraits.CHOREOGRAPHER_FRAME > will run next time there's a vsync and after all other ready tasks on the thread > have run. > > I put the trait under base because from what I understand there is some ui/ code > that needs it but ui/ can't depend on content/. > > Bug: 863341 > Change-Id: Ibcb7a843866c2b2c4f4394ebd18c8ef7aa33b5bc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549114 > Commit-Queue: Alex Clarke <alexclarke@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Reviewed-by: Karolina Soltys <ksolt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#652215} TBR=yfriedman@chromium.org,skyostil@chromium.org,alexclarke@chromium.org,ksolt@chromium.org Change-Id: I2340b5c6c7ce1ac41e87ef689470e798304eb8a8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 863341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574939 Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#652351} base/BUILD.gn | 1 - .../base/task/ChoreographerTaskRunner.java | 63 ---------------------- .../chromium/base/task/DefaultTaskExecutor.java | 22 +------- .../src/org/chromium/base/task/TaskTraits.java | 12 ----- .../src/org/chromium/base/task/PostTaskTest.java | 31 ----------- .../browser/scheduler/UiThreadSchedulerTest.java | 47 ---------------- 6 files changed, 2 insertions(+), 174 deletions(-) commit 8e41a5c4fb408295fcba41d23e1c69a8e2240caf Author: Ryan Hansberry <hansberry@chromium.org> Date: Thu Apr 18 22:12:51 2019 +0000 Create chromeos_bluetooth watchlist. Change-Id: Idb4aac9c285643178bf2b06bec0e0039a15b10a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574363 Reviewed-by: Jeremy Klein <jlklein@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Auto-Submit: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#652350} WATCHLISTS | 14 ++++++++++++++ 1 file changed, 14 insertions(+) commit 2e124a0c63d19fc3baeb131c8eed038599a553f4 Author: Zheda Chen <zheda.chen@intel.com> Date: Thu Apr 18 22:11:36 2019 +0000 Disable lid calculation in Chrome when cros_ec_lid_angle driver present This change disables lid angle calculation in browser, when cros_ec_lid_angle driver is present, which means EC (Embedded Controller) can handle lid angle calculation and notify browser tablet mode switch event. With the driver present, periodic accelerometer read for lid angle calculation is disabled in browser. However, browser still needs to read accelerometer for screen orientation calculation in tablet mode. Test: Capture Chrome trace. When cros_ec_lid_angle driver is present, no periodical accelerometer read in TaskSchedulerForegroundWorker thread of browser process in clamshell mode. When the driver not present (old EC), accelerometer read is always ON. R=gwendal@chromium.org, jonross@chromium.org, oshima@chromium.org, xdai@chromium.org Bug: 831974, 910904 Change-Id: Ifd33dc306044bb822dcb9283e86c326d019883f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1391911 Commit-Queue: Jonathan Ross <jonross@chromium.org> Auto-Submit: Zheda Chen <zheda.chen@intel.com> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Jonathan Ross <jonross@chromium.org> Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#652349} ash/accelerometer/accelerometer_reader.cc | 154 ++++++++++++++++++++- ash/accelerometer/accelerometer_reader.h | 7 + ash/accelerometer/accelerometer_types.cc | 2 +- ash/accelerometer/accelerometer_types.h | 17 ++- ash/display/display_manager_unittest.cc | 10 +- ash/display/display_prefs_unittest.cc | 16 ++- .../screen_orientation_controller_unittest.cc | 2 +- ash/shell.cc | 6 + ash/system/power/power_button_controller.cc | 9 ++ ash/wm/tablet_mode/tablet_mode_controller.cc | 18 ++- ash/wm/tablet_mode/tablet_mode_controller.h | 26 ++-- .../tablet_mode/tablet_mode_controller_test_api.cc | 8 +- 12 files changed, 236 insertions(+), 39 deletions(-) commit 4d88f20aee75402957f624d381d11c03bc7fba5a Author: David 'Digit' Turner <digit@google.com> Date: Thu Apr 18 22:11:28 2019 +0000 build/locale_tool.py: Fix buggy detection of grd translation elements. This fixes a small bug in the script that prevented it from recognizing lines like: <file path="...." lang=".." /> As valid elements of an <translations> session. In particular, this made the script ignore the content of certain .grd files, like android_webview/ui/aw_strings.grd. + Add new unit-tests BUG=NONE R=agrieve@chromium.org, estevenson@chromium.org Change-Id: I4ed0a8f417f5363fbfc6703127bca5da66b84d35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574319 Reviewed-by: Andrew Grieve <agrieve@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#652348} build/locale_tool.py | 75 +++++++++++++++++++++++++++++++++++++++------------- 1 file changed, 56 insertions(+), 19 deletions(-) commit 13d06221147039d6dbec9fbab8697c07ef4a371f Author: David Grogan <dgrogan@chromium.org> Date: Thu Apr 18 22:10:26 2019 +0000 [LayoutNG] Part 1 of resolving min-width:auto for flex items This CL implements the "specified size" and part of "content size" from https://www.w3.org/TR/css-flexbox-1/#min-size-auto . It doesn't do "transferred size" or the aspect ratio part of "content size". Bug: 845235 Change-Id: Ib063763cdf7ae303fa71d4f8b163f5d1e68a899f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1456944 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#652347} .../renderer/core/layout/flexible_box_algorithm.h | 7 +- .../core/layout/ng/ng_flex_layout_algorithm.cc | 91 +++++++++++++++++----- .../renderer/core/layout/ng/ng_length_utils.cc | 3 +- third_party/blink/web_tests/TestExpectations | 25 +----- 4 files changed, 81 insertions(+), 45 deletions(-) commit 1fab15f72d69047f63b34db670f6a8470a4c5667 Author: Caleb Raitto <caraitto@chromium.org> Date: Thu Apr 18 22:10:18 2019 +0000 [Cronet] Enable metrics reporting when there are listeners. A RequestFinishedListener can be set on the UrlRequestParam, and any number of listeners can be attached to the Engine. The common CronetURLRequest only needs to report metrics to the native UrlRequest class if that UrlRequest has a listener, or if its engine has one or more listeners. There are many code paths by which metrics can be collected (success, fail, cancel, upload failure), so instead of just adding a few new testcases to url_request_test.cc, cross-product the test parameterization with these cases: 1) no RequestFinishedInfoListener 2) listener on UrlRequest 3) listener on engine. This CL should land before any CL that modifies OnMetricsCollected() as it ensures that OnMetricsCollected() actually runs in a test and at the very least doesn't crash. Bug: 879208 Change-Id: Ib7b8a252102e2ff86310c42e2db0a339b39efaa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546517 Commit-Queue: Caleb Raitto <caraitto@chromium.org> Reviewed-by: Misha Efimov <mef@chromium.org> Reviewed-by: Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#652346} components/cronet/native/BUILD.gn | 1 + components/cronet/native/engine.cc | 26 ++- components/cronet/native/engine.h | 10 + components/cronet/native/engine_unittest.cc | 197 +++++++++++++++++ components/cronet/native/test/url_request_test.cc | 251 ++++++++++++++++++---- components/cronet/native/url_request.cc | 12 +- components/cronet/native/url_request.h | 15 ++ 7 files changed, 471 insertions(+), 41 deletions(-) commit 5f9bc7f72162b448ba858645419e0599f30a3df2 Author: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Date: Thu Apr 18 22:07:13 2019 +0000 Delete GWP-ASan Windows field trial GWP-ASan is rolling out to stable and has been enabled by default on ToT, this config is no longer required. Bug: 896019, 954210 Change-Id: I60c21f833b5c3449a960ed19a8a50a74e7ac8996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572562 Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#652345} testing/variations/fieldtrial_testing_config.json | 20 -------------------- 1 file changed, 20 deletions(-) commit db84a942ae5bbe5821a116fc18ab3636e5ea6da8 Author: Peter Boström <pbos@chromium.org> Date: Thu Apr 18 22:06:00 2019 +0000 Update context-menu strings for Extension pinning When the Extension Menu experiment is on, use strings that contain pinning and unpinning instead of hiding and showing. This also updates ExtensionActionViewController to check the corresponding action in the main bar instead of itself. This is necessary as the Extensions Menu case actions can be visible both in the menu and the toolbar at the same time. Bug: chromium:943702 Change-Id: I527ea60f00b5836a9c4c5902bcbdca5e67999ad8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574223 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#652344} chrome/app/generated_resources.grd | 12 ++++++++++++ chrome/browser/extensions/extension_context_menu_model.cc | 7 +++++++ .../ui/extensions/extension_action_view_controller.cc | 8 ++++++-- 3 files changed, 25 insertions(+), 2 deletions(-) commit 074b0b1ffa48c32e2dde99445222cfbf76d4fa5e Author: Alexander Timin <altimin@chromium.org> Date: Thu Apr 18 22:04:15 2019 +0000 [bfcache] Track document.onload for bfcache metrics. R=haraken@chromium.org,kinuko@chromium.org BUG=933147 Change-Id: I2a60f08b1e22eaa2f1f3ed26210416238588c2ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571699 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#652343} .../back_forward_cache_metrics_browsertest.cc | 16 ++++- .../scheduler/web_scheduler_tracked_feature.h | 3 +- third_party/blink/renderer/core/dom/document.cc | 4 ++ .../scheduler/scheduler_affecting_features_test.cc | 71 ++++++++++------------ .../platform/scheduler/common/scheduling_policy.cc | 1 + 5 files changed, 53 insertions(+), 42 deletions(-) commit 8109367ae62a00103285a68fce8b19e470bb89ae Author: inglorion <inglorion@chromium.org> Date: Thu Apr 18 22:03:34 2019 +0000 Revert crrev.com/c/1548839 and crrev.com/c/1549478 This reverts commits 63d7033a9b31a14dd123c44ddfce1ab93efc36af ("Do not block shutdown for process launch") and 6dc816e543555790648ec5af1ca827431a7d5807 ("Launch child unsandboxed processes in "Kill on Job Close" job."). Reason for revert: Causes browser_tests time-outs on Windows. Bug: 952529, 830954 Change-Id: I01ec7c713e0d406e3049d4e1d2e508204afd0aa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570193 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Will Harris <wfh@chromium.org> Reviewed-by: François Doray <fdoray@chromium.org> Commit-Queue: Bob Haarman <inglorion@chromium.org> Cr-Commit-Position: refs/heads/master@{#652342} content/browser/child_process_launcher_helper.cc | 13 ++----------- services/service_manager/sandbox/win/sandbox_win.cc | 13 +++++++------ 2 files changed, 9 insertions(+), 17 deletions(-) commit 9d068806890d54f3233291fd31e2401159a6786d Author: Justin DeWitt <dewittj@chromium.org> Date: Thu Apr 18 22:02:35 2019 +0000 [EoS] Add a new UI variant based on the touchless flag. This variant supports a denser layout. Also adds some features to the TileGridLayout: * Doesn't overflow when laying out without side margins * Customizable minimum gap between tiles Bug: 935795 Change-Id: I1cb3ec328f007f0c698ff6bb0c2c0b888195329a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568784 Reviewed-by: Matthew Jones <mdjones@chromium.org> Reviewed-by: Cathy Li <chili@chromium.org> Reviewed-by: Peter Conn <peconn@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#652341} chrome/android/chrome_java_sources.gni | 1 + .../layout/explore_sites_category_card_view.xml | 6 ++- .../explore_sites_category_card_view_condensed.xml | 38 +++++++++++++ .../java/res/layout/explore_sites_page_layout.xml | 3 +- .../layout/explore_sites_tile_view_condensed.xml | 63 ++++++++++++++++++++++ chrome/android/java/res/values/attrs.xml | 4 ++ chrome/android/java/res/values/dimens.xml | 14 ++++- .../CategoryCardViewHolderFactory.java | 22 ++++++-- .../CondensedCategoryCardViewHolderFactory.java | 23 ++++++++ .../ExploreSitesCategoryCardView.java | 7 ++- .../browser/explore_sites/ExploreSitesPage.java | 7 ++- .../chrome/browser/suggestions/TileGridLayout.java | 12 +++-- ...itesPageTest.initial_layout.Nexus_5-19.png.sha1 | 2 +- ...Test.scrolled_to_category_2.Nexus_5-19.png.sha1 | 2 +- 14 files changed, 188 insertions(+), 16 deletions(-) commit 7e50362ada7d1f4930845b2b4e0e0b99e4d9421f Author: Andres Calderon Jaramillo <andrescj@chromium.org> Date: Thu Apr 18 22:01:57 2019 +0000 Add LOGs to get more details about GpuMemoryBuffer allocation failures. This CL adds the following warning log messages: - When retrying an allocation of a GPU memory buffer due to a connection error in HostGpuMemoryBufferManager. - When the GPU process crashes. - When the GPU process is reinitialized after a crash (in order to get an idea of how long it takes to reinitialize the process). The motivation is to get better clues to diagnose the crash reports in the referenced bug. Bug: 941523 Test: Simulate a GPU process crash when creating a GpuMemoryBuffer and inspect logs (with /run/session_manager/enable_hang_detection). Change-Id: Iefc49dc8df1ffc6fd9e6732ba6e684b0b3195475 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573079 Reviewed-by: Daniele Castagna <dcastagna@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#652340} components/viz/host/host_gpu_memory_buffer_manager.cc | 9 +++++++++ content/browser/gpu/gpu_process_host.cc | 7 +++++++ 2 files changed, 16 insertions(+) commit b35f62b54d488067abad4b78aabd737635fd7304 Author: Aaron Colwell <acolwell@google.com> Date: Thu Apr 18 22:01:22 2019 +0000 Reset |expected_render_process_host_id_| if process is destroyed. Adding the NavigationRequest as an observer of the process associated with |expected_render_process_host_id_| so it can detect if the process is destroyed. This prevents crashes in the SiteProcessCountTracker caused by process entries that were not getting deleted. Bug: 793127 Change-Id: I1f8afe67662aab8c79659d6cc708349a55cd89b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572933 Reviewed-by: Nasko Oskov <nasko@chromium.org> Commit-Queue: Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#652339} content/browser/frame_host/navigation_request.cc | 7 +++++++ content/browser/frame_host/navigation_request.h | 7 ++++++- third_party/blink/web_tests/TestExpectations | 3 --- 3 files changed, 13 insertions(+), 4 deletions(-) commit 79559775390eab6eda89051750998c9cd7d809de Author: Peter E Conn <peconn@chromium.org> Date: Thu Apr 18 22:00:42 2019 +0000 🎫 Record how long origin verification takes. This change is apart of a larger sequence of CLs for implementing notification delegation auto-enrolment. See https://crbug.com/945258. Bug: 952263 Change-Id: Ic75bb2fe06fab5f181e8240b0c966d901f543931 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572129 Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Auto-Submit: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#652338} .../browserservices/BrowserServicesMetrics.java | 6 ++++++ .../browser/browserservices/OriginVerifier.java | 9 +++++++++ tools/metrics/histograms/histograms.xml | 21 +++++++++++++++++++++ 3 files changed, 36 insertions(+) commit bbc90e4fa40f9b98d1f18d3571570de013f9b15a Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Apr 18 22:00:12 2019 +0000 Roll src/third_party/catapult c2caea81a024..f88c75708b4d (1 commits) https://chromium.googlesource.com/catapult.git/+log/c2caea81a024..f88c75708b4d git log c2caea81a024..f88c75708b4d --date=short --no-merges --format='%ad %ae %s' 2019-04-18 benjhayden@chromium.org Migrate chart-section.js to es6 module Created with: gclient setdep -r src/third_party/catapult@f88c75708b4d The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:950011 TBR=oysteine@chromium.org Change-Id: I3398077649b4ce85f09c0e994af35b4b115e9718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574245 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652337} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 0cda8cc030554d1b9c85bd2e1e2c0d5e5a1e38cb Author: Jun Mukai <mukai@chromium.org> Date: Thu Apr 18 21:57:53 2019 +0000 Add more states to LauncherAnimationsTest Now we separate the histograms by the target state. These new test cases can ensure that the reporter will report certain metrics on certain operations. Bug: 951853 Test: interactive_ui_tests Change-Id: I3a63a7e637c941ad11c63c381eeebca910c1c87a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573166 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#652336} .../ash/launcher_animations_interactive_uitest.cc | 105 +++++++++++++++++++++ 1 file changed, 105 insertions(+) commit 4dd1f3cedfa5022f5fa9d076c2a0b75165987b3b Author: John Abd-El-Malek <jam@chromium.org> Date: Thu Apr 18 21:56:46 2019 +0000 Reland "Move loading of data URLs out of the network process." This is a reland of f45ff75d1ee932e8695a34269c264f93b77439e2 Original change's description: > Move loading of data URLs out of the network process. > > For subresources the renderer was already loading it in-process. Now for navigations and downloads, we keep them in the browser process. This avoids: > 1) sending GURLs bigger than 2MB to a different process, which strips them as they're bigger than url::kMaxURLChars > 2) having the network process deal with a scheme that's not going over the network, which we avoid > > Bug: 937146, 939871 > Change-Id: I8ca8225308b2a5f1f90594ab06943f0641a5c551 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570805 > Commit-Queue: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Cr-Commit-Position: refs/heads/master@{#652196} Bug: 937146, 939871 Change-Id: I480da494a987c9b223c1a571821b35e3bdbc7447 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574881 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#652335} chrome/browser/download/download_browsertest.cc | 64 +++++++++++++ .../network_context_configuration_browsertest.cc | 23 ----- chrome/test/data/downloads/large_image.png | Bin 0 -> 2096938 bytes content/browser/BUILD.gn | 2 + content/browser/data_url_loader_factory.cc | 104 +++++++++++++++++++++ content/browser/data_url_loader_factory.h | 47 ++++++++++ content/browser/download/download_manager_impl.cc | 35 ++++--- content/browser/download/save_file_manager.cc | 18 +++- .../browser/frame_host/render_frame_host_impl.cc | 4 + .../browser/loader/navigation_url_loader_impl.cc | 4 + .../service_worker/embedded_worker_instance.cc | 3 + .../worker_host/worker_script_fetch_initiator.cc | 3 + content/public/common/url_utils.cc | 3 +- services/network/network_context.cc | 9 +- services/network/network_context_unittest.cc | 7 +- .../public/cpp/simple_url_loader_unittest.cc | 23 +---- 16 files changed, 280 insertions(+), 69 deletions(-) commit 38595807bf3c57cad47508c506630ba6aa97d1d9 Author: Robert Ogden <robertogden@chromium.org> Date: Thu Apr 18 21:56:06 2019 +0000 Update color of dark mode verbose status separator See bug for more details. Bug: 952436 Change-Id: Ieeada1ea0dba9ce8760252db9cb820a73cfe93e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569826 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#652334} chrome/android/java/res/values/colors.xml | 3 --- .../org/chromium/chrome/browser/omnibox/status/StatusMediator.java | 4 ++-- .../chromium/chrome/browser/omnibox/status/StatusViewCoordinator.java | 3 +-- ui/android/java/res/values/color_palette.xml | 4 +++- ui/android/java/res/values/colors.xml | 2 +- ui/android/java/res_night/values-night/colors.xml | 2 +- 6 files changed, 8 insertions(+), 10 deletions(-) commit ca1135fe2271e85138410e8817e696e255895677 Author: Vincent Boisselle <vincb@chromium.org> Date: Thu Apr 18 21:55:03 2019 +0000 Added experiment IDs to API. Bug: 951635 Change-Id: Ia4edd29e3ec2397d5e7f6be58d25982414ca2b30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564790 Commit-Queue: Vincent Boisselle <vincb@chromium.org> Reviewed-by: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#652333} components/autofill/core/browser/proto/api_v1.proto | 4 +++- components/autofill/core/browser/proto/legacy_proto_bridge.cc | 1 + .../autofill/core/browser/proto/legacy_proto_bridge_unittest.cc | 4 ++++ 3 files changed, 8 insertions(+), 1 deletion(-) commit 9a37066e92a623cbf4e5ebd2bcd5c44e593ca941 Author: Johannes Henkel <johannes@chromium.org> Date: Thu Apr 18 21:53:49 2019 +0000 [DevTools] Revamp DevToolsSession::SendMessageFromChildSession. We want the internal traffic to be binary in the future. So, for SendMessageFromChildSession, it turns out that this comes from target_handler for flattened protocol sessions. So, we now check whether the session wants binary. This allows us to always patch up the message in binary, especially once the flag is removed, which should happen tomorrow. Change-Id: If8bf0cb4aa9c2299b5ea330338553c3c0b8e0b2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572931 Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#652332} content/browser/devtools/devtools_session.cc | 30 ++++++++++++++++------ .../browser/devtools/protocol/target_handler.cc | 2 ++ 2 files changed, 24 insertions(+), 8 deletions(-) commit 661a9182072acaa224608d2f33a3e425f13f368e Author: Albert J. Wong <ajwong@chromium.org> Date: Thu Apr 18 21:53:30 2019 +0000 Add blink.user_timing to kFilteredEventGroupNames. This allows trace events for blink.user_timing to be read from ETW. A followup change in UIforETW is necessary for reading the follows. That will be handled in another CL. Bug: none Change-Id: Ic71d7ba333fe1f9729a43460a9b4b782d251cda0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574151 Commit-Queue: Albert J. Wong <ajwong@chromium.org> Reviewed-by: Bruce Dawson <brucedawson@chromium.org> Reviewed-by: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#652331} base/trace_event/trace_event_etw_export_win.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) commit 8228ef489014d113022670fadff6ca6d47a228c0 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Thu Apr 18 21:50:57 2019 +0000 CORB allowlist additions - 2019-04-18. Bug: 954088 Change-Id: Ia234842a363473a8feadc0b1091c462d91def7e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574359 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#652330} extensions/browser/url_loader_factory_manager.cc | 1 + 1 file changed, 1 insertion(+) commit 765a04fa38fc251f9858b59274b0d606a69531ab Author: Aaron Leventhal <aleventhal@chromium.org> Date: Thu Apr 18 21:50:06 2019 +0000 Fix crash when role is requested before widget is available Bug: 952741 Change-Id: Ib4d37a308bf1b3c32304edd8bcdc29306b085df6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572708 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#652329} ui/views/window/dialog_delegate.cc | 4 ++++ 1 file changed, 4 insertions(+) commit 825564592e07340e758b21142ceaa70a2da9f0d3 Author: Yuwei Huang <yuweih@chromium.org> Date: Thu Apr 18 21:49:49 2019 +0000 [remoting][FTL] Flip transport roles in signaling playground The transport roles in signaling playground have been flipped, such that playgrounds can connect to each other but playground->host will fail because both the client and the host send each other an offer. This CL fixes this issue by flipping the roles. Bug: 947337 Change-Id: If4f5413ca86dfed0d5a1b2c6e949679f44e021a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574825 Reviewed-by: Joe Downing <joedow@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#652328} remoting/test/ftl_signaling_playground.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 6e22954cd62645918a9cb092cbda486ffcaf4fbf Author: Yann Dago <ydago@chromium.org> Date: Thu Apr 18 21:48:45 2019 +0000 Revert "Management WebUI: Remove duplicate link to management page from settings" This reverts commit 1b6db40331b2245bad669ccee0c00b6a8d75fa3f. Reason for revert: This change caused a regression, it removed the link to the management page from the settings page. Original change's description: > Management WebUI: Remove duplicate link to management page from settings > > Bug: 879146 > Change-Id: Id461109a2fff5b3d077158abefb638dd5527c7f4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569511 > Commit-Queue: Yann Dago <ydago@chromium.org> > Reviewed-by: Hector Carmona <hcarmona@chromium.org> > Cr-Commit-Position: refs/heads/master@{#651698} TBR=hcarmona@chromium.org,ydago@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 879146 Change-Id: If57862619c86a8ff4c9174d1bbfabfea26faaba4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574621 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#652327} .../settings/settings_main/settings_main.html | 20 +++++++++++++ .../settings/settings_main/settings_main.js | 8 +++++ .../test/data/webui/settings/settings_main_test.js | 34 ++++++++++++++++++++++ 3 files changed, 62 insertions(+) commit e1b9626d1e92c2c0511941c3c17ab8d699c3d075 Author: Mitsuru Oshima <oshima@chromium.org> Date: Thu Apr 18 21:48:10 2019 +0000 Update shelf upon rotation animation Bug: 951655 Change-Id: I74b1932cb717dc1d306e2594e33fe9591a50e953 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572358 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#652326} ash/shelf/shelf_layout_manager.cc | 51 ++++++++++++++++++++++++++++----------- ash/shelf/shelf_layout_manager.h | 33 ++++++++++++++++--------- ash/shelf/shelf_widget.cc | 1 + 3 files changed, 59 insertions(+), 26 deletions(-) commit ab0c27291e8a10175ea6963b8a5f76d5907eb385 Author: Koji Ishii <kojii@chromium.org> Date: Thu Apr 18 21:47:40 2019 +0000 [LayoutNG] Reorder check conditions when reusing lineboxes This patch: * Reorders check conditions when reusing lineboxes so that it can fail earlier in common cases. * Moved most of conditions to NGInlineNode to allow reordering and to avoid virtual calls. No behavior changes. Bug: 636993 Change-Id: I044871e5ab51724e5b256043e0471329c344d3fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568374 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#652325} .../renderer/core/layout/layout_block_flow.cc | 4 -- .../blink/renderer/core/layout/layout_block_flow.h | 2 - .../core/layout/ng/inline/ng_inline_node.cc | 62 ++++++++++++++++------ .../core/layout/ng/inline/ng_inline_node.h | 5 +- .../renderer/core/layout/ng/layout_ng_mixin.cc | 31 ----------- .../renderer/core/layout/ng/layout_ng_mixin.h | 3 -- .../core/layout/ng/ng_block_layout_algorithm.cc | 37 ++++--------- .../core/layout/ng/ng_block_layout_algorithm.h | 4 -- 8 files changed, 59 insertions(+), 89 deletions(-) commit 4dd359d5ed45c4f8c4b07be8632daa5d6ce87056 Author: Anders Leino <aleino@nvidia.com> Date: Thu Apr 18 21:47:04 2019 +0000 Fix incorrect bug number for delayed copy nv12 driver bug entry Bug: 945272 Change-Id: I39f3613ec5310ae33e97c717150d6ceb8f94ac87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569105 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#652324} gpu/config/gpu_driver_bug_list.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit d342f8474cd969523373adcde283a27ee8aadf5a Author: Kurt Horimoto <kkhorimoto@chromium.org> Date: Thu Apr 18 21:46:32 2019 +0000 Revert "[ios] Turn on UMA feature flag by default" This reverts commit 3a554bbcea3febe6d6b4ef5636a0fc3e3796a2e6. Reason for revert: Causing crbug.com/954356 Original change's description: > [ios] Turn on UMA feature flag by default > > Bug: 931289 > Change-Id: Ibd211f4a28d394793b986ad835015ac9c4948768 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569748 > Commit-Queue: Chris Lu <thegreenfrog@chromium.org> > Reviewed-by: Sergio Collazos <sczs@chromium.org> > Reviewed-by: Steven Holte <holte@chromium.org> > Cr-Commit-Position: refs/heads/master@{#651915} TBR=holte@chromium.org,sczs@chromium.org,thegreenfrog@chromium.org Change-Id: I4bc5a56ae19fddd87adef1e948265abbdf31205f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 931289 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574428 Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#652323} components/ukm/ios/features.cc | 2 +- ios/chrome/browser/ui/settings/BUILD.gn | 1 - ios/chrome/browser/ui/settings/password/BUILD.gn | 1 - .../privacy_table_view_controller_unittest.mm | 4 +- ios/chrome/browser/ui/settings/settings_egtest.mm | 85 ++++++++-------------- 5 files changed, 33 insertions(+), 60 deletions(-) commit 0b2c6fbbed7eb0ea45004b4047782ffba7765e18 Author: Sam McNally <sammc@chromium.org> Date: Thu Apr 18 21:45:46 2019 +0000 Mark most expiring Drive.* histograms as obsolete. Keep Drive.PushNotification* for a few more milestones since they'll be useful for monitoring the migration to FCM for Drive push notifications. The remaining histograms are only recorded by the legacy Drive client, which should be removed in 76, so mark them as obsolete. Bug: 945540 Change-Id: I58914b29519bc16d30135ee0fd064686d926e017 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568375 Commit-Queue: Jesse Doherty <jwd@chromium.org> Auto-Submit: Sam McNally <sammc@chromium.org> Reviewed-by: Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#652322} tools/metrics/histograms/histograms.xml | 49 +++++++++++++++++++++++++++++++-- 1 file changed, 47 insertions(+), 2 deletions(-) commit f94597bf4448808fe6129da8c45cf52af8b68497 Author: Nina Satragno <nsatragno@chromium.org> Date: Thu Apr 18 21:45:27 2019 +0000 Replace webauthn dialog PNG illustrations with vector icons. Vector icons allow us to use only one representation for all device scale factors and take less bits. This patch should save about 229kb on an official build: Before patch chrome_100_percent.pak 1,061,874 bytes chrome_200_percent.pak 1,462,605 bytes chrome 236,097,832 bytes total 238,622,311 bytes After patch chrome_100_percent.pak 977,496 bytes chrome_200_percent.pak 1,259,524 bytes chrome 236,155,296 bytes total 238,392,316 bytes difference 229,995 bytes Change-Id: Ib03fad381d1b2bc4bc7b9fa7a9660264ab751d49 Bug: 950110 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573665 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#652321} .../default_100_percent/common/webauthn/ble.png | Bin 5677 -> 0 bytes .../common/webauthn/ble_dark.png | Bin 6251 -> 0 bytes .../common/webauthn/ble_name.png | Bin 4399 -> 0 bytes .../common/webauthn/ble_name_dark.png | Bin 5036 -> 0 bytes .../common/webauthn/ble_pin.png | Bin 4499 -> 0 bytes .../common/webauthn/ble_pin_dark.png | Bin 5107 -> 0 bytes .../common/webauthn/ble_tap.png | Bin 5722 -> 0 bytes .../common/webauthn/ble_tap_dark.png | Bin 6355 -> 0 bytes .../default_100_percent/common/webauthn/error.png | Bin 3069 -> 0 bytes .../common/webauthn/error_bt.png | Bin 1687 -> 0 bytes .../common/webauthn/error_bt_dark.png | Bin 1833 -> 0 bytes .../common/webauthn/error_dark.png | Bin 3153 -> 0 bytes .../common/webauthn/permission.png | Bin 5468 -> 0 bytes .../common/webauthn/permission_dark.png | Bin 5838 -> 0 bytes .../default_100_percent/common/webauthn/phone.png | Bin 2111 -> 0 bytes .../common/webauthn/phone_dark.png | Bin 3265 -> 0 bytes .../common/webauthn/touchid.png | Bin 5604 -> 0 bytes .../common/webauthn/touchid_dark.png | Bin 5938 -> 0 bytes .../default_100_percent/common/webauthn/usb.png | Bin 3248 -> 0 bytes .../common/webauthn/usb_dark.png | Bin 3517 -> 0 bytes .../common/webauthn/welcome.png | Bin 3988 -> 0 bytes .../common/webauthn/welcome_dark.png | Bin 4027 -> 0 bytes .../default_200_percent/common/webauthn/OWNERS | 4 - .../default_200_percent/common/webauthn/ble.png | Bin 13988 -> 0 bytes .../common/webauthn/ble_dark.png | Bin 15062 -> 0 bytes .../common/webauthn/ble_name.png | Bin 10908 -> 0 bytes .../common/webauthn/ble_name_dark.png | Bin 12262 -> 0 bytes .../common/webauthn/ble_pin.png | Bin 11019 -> 0 bytes .../common/webauthn/ble_pin_dark.png | Bin 12354 -> 0 bytes .../common/webauthn/ble_tap.png | Bin 14170 -> 0 bytes .../common/webauthn/ble_tap_dark.png | Bin 15442 -> 0 bytes .../default_200_percent/common/webauthn/error.png | Bin 6868 -> 0 bytes .../common/webauthn/error_bt.png | Bin 3331 -> 0 bytes .../common/webauthn/error_bt_dark.png | Bin 3801 -> 0 bytes .../common/webauthn/error_dark.png | Bin 6824 -> 0 bytes .../common/webauthn/permission.png | Bin 13897 -> 0 bytes .../common/webauthn/permission_dark.png | Bin 14905 -> 0 bytes .../default_200_percent/common/webauthn/phone.png | Bin 6911 -> 0 bytes .../common/webauthn/phone_dark.png | Bin 7525 -> 0 bytes .../common/webauthn/touchid.png | Bin 13050 -> 0 bytes .../common/webauthn/touchid_dark.png | Bin 14107 -> 0 bytes .../default_200_percent/common/webauthn/usb.png | Bin 7409 -> 0 bytes .../common/webauthn/usb_dark.png | Bin 7982 -> 0 bytes .../common/webauthn/welcome.png | Bin 9134 -> 0 bytes .../common/webauthn/welcome_dark.png | Bin 9161 -> 0 bytes chrome/app/theme/theme_resources.grd | 24 -- chrome/app/vector_icons/BUILD.gn | 20 ++ .../common => vector_icons}/webauthn/OWNERS | 0 chrome/app/vector_icons/webauthn/webauthn_ble.icon | 195 +++++++++++++++ .../vector_icons/webauthn/webauthn_ble_dark.icon | 199 ++++++++++++++++ .../vector_icons/webauthn/webauthn_ble_name.icon | 113 +++++++++ .../webauthn/webauthn_ble_name_dark.icon | 112 +++++++++ .../vector_icons/webauthn/webauthn_ble_pin.icon | 138 +++++++++++ .../webauthn/webauthn_ble_pin_dark.icon | 137 +++++++++++ .../vector_icons/webauthn/webauthn_ble_tap.icon | 190 +++++++++++++++ .../webauthn/webauthn_ble_tap_dark.icon | 189 +++++++++++++++ .../app/vector_icons/webauthn/webauthn_error.icon | 164 +++++++++++++ .../webauthn/webauthn_error_bluetooth.icon | 73 ++++++ .../webauthn/webauthn_error_bluetooth_dark.icon | 80 +++++++ .../vector_icons/webauthn/webauthn_error_dark.icon | 202 ++++++++++++++++ .../vector_icons/webauthn/webauthn_permission.icon | 115 +++++++++ .../webauthn/webauthn_permission_dark.icon | 151 ++++++++++++ .../app/vector_icons/webauthn/webauthn_phone.icon | 177 ++++++++++++++ .../vector_icons/webauthn/webauthn_phone_dark.icon | 184 +++++++++++++++ chrome/app/vector_icons/webauthn/webauthn_usb.icon | 197 ++++++++++++++++ .../vector_icons/webauthn/webauthn_usb_dark.icon | 204 ++++++++++++++++ .../vector_icons/webauthn/webauthn_welcome.icon | 171 ++++++++++++++ .../webauthn/webauthn_welcome_dark.icon | 262 +++++++++++++++++++++ .../authenticator_dialog_view_browsertest.cc | 5 +- .../webauthn/authenticator_request_sheet_view.cc | 19 +- .../webauthn/authenticator_request_sheet_view.h | 3 + .../ui/views/webauthn/sheet_view_factory.cc | 5 +- .../webauthn/authenticator_request_sheet_model.h | 4 +- chrome/browser/ui/webauthn/sheet_models.cc | 184 +++++++-------- chrome/browser/ui/webauthn/sheet_models.h | 54 ++--- 75 files changed, 3409 insertions(+), 166 deletions(-) commit 25a7f03a0d33a0c3300de3cb8cf2c5f7ccff411c Author: Xi Han <hanxi@google.com> Date: Thu Apr 18 21:44:21 2019 +0000 Create Profile's PrefService before the Profile is created on Android. [2/4] This is a precursor CL for https://crrev.com/c/1532361. In this CL, we remove dependencies of g_browser_process in prefs_tab_helper. Bug: 937469 Change-Id: I4724ccaa3769a721743979f4300ab4a45d1315ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1567898 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#652320} chrome/browser/prefs/browser_prefs.cc | 14 ++++++++++---- chrome/browser/prefs/browser_prefs.h | 9 +++++++-- chrome/browser/ui/prefs/prefs_tab_helper.cc | 9 ++++----- chrome/browser/ui/prefs/prefs_tab_helper.h | 3 ++- 4 files changed, 23 insertions(+), 12 deletions(-) commit 85079c267464cfb90c4f5dff217d7d515ded6139 Author: Xi Han <hanxi@google.com> Date: Thu Apr 18 21:43:05 2019 +0000 Create Profile's PrefService before the Profile is created on Android. [1/4] This is a precursor CL for https://crrev.com/c/1532361. We introduce StartupData which owns all of the pre-create objects, including the ChromeFeatureListCreator. Bug: 937469 Change-Id: I9ea3d13d32de2a91e6eb4a0aecc13d2419f7f881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562573 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#652319} chrome/app/chrome_main_delegate.cc | 22 ++++++++----- chrome/app/chrome_main_delegate.h | 6 ++-- chrome/browser/BUILD.gn | 2 ++ chrome/browser/browser_process_impl.cc | 9 ++--- chrome/browser/browser_process_impl.h | 6 ++-- chrome/browser/chrome_browser_main.cc | 27 ++++++++------- chrome/browser/chrome_browser_main.h | 6 ++-- chrome/browser/chrome_browser_main_android.cc | 5 ++- chrome/browser/chrome_browser_main_android.h | 5 ++- chrome/browser/chrome_browser_main_linux.cc | 5 ++- chrome/browser/chrome_browser_main_linux.h | 5 ++- chrome/browser/chrome_browser_main_mac.h | 5 ++- chrome/browser/chrome_browser_main_mac.mm | 5 ++- chrome/browser/chrome_browser_main_posix.cc | 5 ++- chrome/browser/chrome_browser_main_posix.h | 5 ++- chrome/browser/chrome_browser_main_win.cc | 5 ++- chrome/browser/chrome_browser_main_win.h | 5 ++- chrome/browser/chrome_content_browser_client.cc | 38 ++++++++++------------ chrome/browser/chrome_content_browser_client.h | 7 ++-- .../chromeos/chrome_browser_main_chromeos.cc | 4 +-- .../chromeos/chrome_browser_main_chromeos.h | 5 ++- chrome/browser/startup_data.cc | 13 ++++++++ chrome/browser/startup_data.h | 33 +++++++++++++++++++ 23 files changed, 135 insertions(+), 93 deletions(-) commit b4cde05de893dafe1c318f11c0742a0d8e3a52a7 Author: Michael Thiessen <mthiesse@chromium.org> Date: Thu Apr 18 21:42:06 2019 +0000 Move Chrome Dino to its own (SingleTab)Activity. Bug: 951860 Change-Id: I452b27c0c778296933e50ab897ff4e8e8a2f3939 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574423 Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#652318} chrome/android/java/AndroidManifest.xml | 23 +++++--- .../chromium/chrome/browser/ChromeActivity.java | 3 +- .../chromium/chrome/browser/SingleTabActivity.java | 7 --- .../chrome/browser/touchless/DinoActivity.java | 63 ++++++++++++++++++++++ .../android/touchless/touchless_java_sources.gni | 1 + 5 files changed, 83 insertions(+), 14 deletions(-) commit 549e4c9cf3a3d1fa6f71747de2120b1b6748c0a1 Author: Chris Cunningham <chcunningham@chromium.org> Date: Thu Apr 18 21:41:29 2019 +0000 MediaCapabilities: Create a real MediaKeySystemAccess when requested This provides a real MediaKeySystemAccess to the MediaCapabilitiesDecodingInfo object when decodingInfo() is queried with a supported KeySystemConfiguration. This doesn't yet query the stats DB for smoothness and power efficiency - coming in a follow up. Bug: 907909 Change-Id: I049196ee2a3244a3f3ad6231c3d3da080beb91d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554420 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by: John Rummell <jrummell@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#652317} media/blink/webmediacapabilitiesclient_impl.cc | 21 -- .../modules/encryptedmedia/encrypted_media_utils.h | 5 + .../media_key_system_access_initializer_base.cc | 10 +- .../media_key_system_access_initializer_base.h | 8 +- .../navigator_request_media_key_system_access.cc | 14 +- .../media_capabilities/media_capabilities.cc | 313 +++++++++++++++++---- 6 files changed, 287 insertions(+), 84 deletions(-) commit 23978955f8eea530fb2670f8f599b0c2a786ab50 Author: Peter Kasting <pkasting@chromium.org> Date: Thu Apr 18 21:38:54 2019 +0000 Misc. cleanup found while removing uses of child_count(). * Shorten code * Use ClampToRange() * Facilitate later conversion to range-based for * Avoid implicit size_t->int conversions * DCHECK_LE * constexpr * Using non-const ref locals is less typical than pointers * No real need for ButtonLayout() to constantly DCHECK that it has one or two buttons Bug: none Change-Id: I0b6454f2cffdc9854358f81edc31491494909bd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574626 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by: Peter Boström <pbos@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#652316} .../payments/local_card_migration_dialog_view.cc | 7 ++- .../desktop_capture/desktop_media_list_view.cc | 6 +-- chrome/browser/ui/views/frame/browser_view.cc | 6 +-- .../browser/ui/views/frame/browser_view_layout.cc | 7 +-- .../views/omnibox/omnibox_popup_contents_view.cc | 8 +-- .../page_info/page_info_bubble_view_unittest.cc | 28 +++++----- .../ui/views/payments/modifiers_browsertest.cc | 61 ++++++---------------- chrome/browser/ui/views/tabs/tab_unittest.cc | 16 +++--- .../ui/views/translate/translate_bubble_view.cc | 9 ++-- .../views/try_chrome_dialog_win/button_layout.cc | 54 +++++++------------ .../ui/views/try_chrome_dialog_win/button_layout.h | 4 -- 11 files changed, 74 insertions(+), 132 deletions(-) commit 82fb3fd6b7578543e305ecc66132fcefc082181a Author: Donn Denman <donnd@chromium.org> Date: Thu Apr 18 21:38:32 2019 +0000 [TTS] Update Bar layout for Definitions. This CL adds new layout treatment for dictionary definitions when they are returned from the server: 1) Uses the existing "Book Round" vector icon when a dictionary is present. 2) Styles the Title to have two parts, with the first part being the word the second part being the pronunciation shown gray. The icon is controlled by a new ContextualSearchCardIconControl to allow displaying an icon for cards from the server that are not quick actions. Also update the ContextualSearchImageControl to use the term "Card Icon" in place of "Quick Action Icon" since the icon can come from either a Quick Action or some other kind of card. BUG=936695, 954225 Change-Id: I26230ae060a00deda621ab776e673da9103e5730 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572244 Reviewed-by: Matthew Jones <mdjones@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#652315} chrome/android/chrome_java_sources.gni | 1 + .../layout/contextual_search_card_icon_view.xml | 12 +++ .../ContextualSearchBarControl.java | 23 +++++- .../ContextualSearchCardIconControl.java | 87 ++++++++++++++++++++++ .../ContextualSearchImageControl.java | 52 ++++++------- .../contextualsearch/ContextualSearchPanel.java | 10 ++- .../scene_layer/ContextualSearchSceneLayer.java | 4 +- .../contextualsearch/ContextualSearchManager.java | 3 +- .../ContextualSearchManagerTest.java | 16 ++-- 9 files changed, 171 insertions(+), 37 deletions(-) commit 4a0fd660ae6792df0f8b9524d5caa4bbca87c65c Author: Bret Sepulveda <bsep@chromium.org> Date: Thu Apr 18 21:36:30 2019 +0000 Disable four flaky blink tests. This patch disables the following tests: * http/tests/devtools/oopif/oopif-presentation-console-messages.js * virtual/nobinary-for-devtools/http/tests/devtools/oopif/oopif-presentation-console-messages.js * http/tests/security/svg-image-with-cached-remote-image.html * virtual/outofblink-cors/http/tests/security/svg-image-with-cached-remote-image.html TBR=lukasza@chromium.org,pdr@chromium.org Bug: 953994, 954297 Change-Id: I14221edefd296b1a9b9d838e67ab4df16b2aec53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574678 Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#652314} third_party/blink/web_tests/TestExpectations | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) commit 395fcbbf075fe35e0c37164686edb13d58730e3f Author: Yann Dago <ydago@chromium.org> Date: Thu Apr 18 21:30:03 2019 +0000 Management WebUi: Fix state management state mismatch Bug: 954166 Change-Id: I7a59e32c60982eb4761d57bf64875991894adc43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572588 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#652313} chrome/browser/ui/webui/management_ui.cc | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) commit adbc0ed44c12f44564da86de99a0b5430ca19652 Author: Dustin Green <dustingreen@google.com> Date: Thu Apr 18 21:29:38 2019 +0000 [Fuchsia] use default packet count in FuchsiaVideoDecoder. The packet_count_for_client_min is 1 in this case. The default is 3 (so far). The default of 3 works fine, but 0 is below min. The min will be enforced soon so this CL prepares for that. Change-Id: Ia1184156d0aa4945f39dab2b69bea0d64ebab854 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574680 Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Dustin Green <dustingreen@google.com> Cr-Commit-Position: refs/heads/master@{#652312} media/filters/fuchsia/fuchsia_video_decoder.cc | 1 - 1 file changed, 1 deletion(-) commit cd096ff2b5a73ce06ee7b24b5485c604e8948333 Author: Jared Saul <jsaul@google.com> Date: Thu Apr 18 21:28:59 2019 +0000 Fix flag-metadata.json entry I don't have a @chromium.org address, so the @google.com is necessary. Change-Id: Iad68b94a35e67582191ba81343707f64ede5f4be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574228 Commit-Queue: Jared Saul <jsaul@google.com> Commit-Queue: Anne Lim <annelim@google.com> Auto-Submit: Jared Saul <jsaul@google.com> Reviewed-by: Anne Lim <annelim@google.com> Cr-Commit-Position: refs/heads/master@{#652311} chrome/browser/flag-metadata.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit f16e66ea377f35ee0ef9d49cc2e7a229456fc9f2 Author: Sergey Ulanov <sergeyu@google.com> Date: Thu Apr 18 21:28:30 2019 +0000 [Fuchsia] Add fuchsia support in GetPlatformSpecificTextureTarget() Added ifdef for OS_FUCHSIA in GetPlatformSpecificTextureTarget(). Previously it was marked as NOTREACHED(). Bug: 852011 Change-Id: I5c8d05b2db95e559d11586a39fb75928b2916d28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572536 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#652310} gpu/command_buffer/common/gpu_memory_buffer_support.cc | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) commit dc2193619cfcbf59ace8144de5bf5ecc7df4e979 Author: Peter Boström <pbos@chromium.org> Date: Thu Apr 18 21:27:52 2019 +0000 Add ScrollView to Extensions menu Prevents an "infinite" list of extensions to push beyond the screen. The actual max height for this scroll view was picked kind of arbitrarily and might be revisited. Bug: chromium:943702 Change-Id: Iee47cdfb97e6214f6b80a2d362abbfbda4d9babd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572877 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#652309} .../browser/ui/views/extensions/extensions_menu_view.cc | 16 ++++++++++++++-- .../browser/ui/views/extensions/extensions_menu_view.h | 4 ++++ .../views/extensions/extensions_menu_view_browsertest.cc | 1 + 3 files changed, 19 insertions(+), 2 deletions(-) commit 5ad6e057d3fcd4718729126b714d91fdd1c31e3b Author: Oksana Zhuravlova <oksamyt@chromium.org> Date: Thu Apr 18 21:27:15 2019 +0000 [mojo][JS] Add missing features to JS bindings This change adds a connection error handler to InterfaceTarget and exposes it in Foo and FooCallbackRouter generated classes, as well as modifies some conditions for consistency with the old bindings. Bug: 894376 Change-Id: I317d0ae5eb6cbf534d2411dd9c99c5770080b2df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555011 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#652308} mojo/public/js/interface_support.js | 17 ++++++++++++++++- .../js_templates/lite/interface_definition.tmpl | 4 ++++ third_party/blink/web_tests/mojo/bindings-lite.html | 17 +++++++++++++++++ 3 files changed, 37 insertions(+), 1 deletion(-) commit 81c99289ac43e49e408956e9880255fcbbd7c05d Author: Henrique Nakashima <hnakashima@chromium.org> Date: Thu Apr 18 21:24:32 2019 +0000 Create UserCloudPolicyManager without a KeyedServiceFactory. user_cloud_policy_manager_builder.cc now contains the code for creation. It is just a helper function to abstract details away from ProfileImpl. Bug: 940522 Change-Id: I2e37c34162afd366674b0b817c3c6760aabfa560 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568621 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by: Maksim Ivanov <emaxx@chromium.org> Reviewed-by: Xi Han <hanxi@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#652307} chrome/browser/BUILD.gn | 4 +- .../android/signin/signin_manager_android.cc | 3 +- .../policy/cloud/cloud_policy_browsertest.cc | 4 +- .../cloud/cloud_policy_manager_browsertest.cc | 4 +- .../cloud/component_cloud_policy_browsertest.cc | 4 +- .../policy/cloud/policy_header_service_factory.cc | 8 +- .../cloud/user_cloud_policy_invalidator_factory.cc | 6 +- .../cloud/user_cloud_policy_manager_builder.cc | 54 ++++++ .../cloud/user_cloud_policy_manager_builder.h | 29 +++ .../cloud/user_cloud_policy_manager_factory.cc | 210 --------------------- .../cloud/user_cloud_policy_manager_factory.h | 122 ------------ .../cloud/user_policy_signin_service_base.cc | 1 - .../cloud/user_policy_signin_service_factory.cc | 4 +- .../cloud/user_policy_signin_service_unittest.cc | 36 ++-- .../policy/profile_policy_connector_factory.cc | 5 +- .../chrome_browser_main_extra_parts_profiles.cc | 2 - .../profiles/off_the_record_profile_impl.cc | 16 +- .../browser/profiles/off_the_record_profile_impl.h | 1 + chrome/browser/profiles/profile.cc | 4 + chrome/browser/profiles/profile.h | 6 +- chrome/browser/profiles/profile_impl.cc | 26 ++- chrome/browser/profiles/profile_impl.h | 3 + chrome/browser/ui/webui/policy_ui_handler.cc | 6 +- chrome/test/base/testing_profile.cc | 35 +++- chrome/test/base/testing_profile.h | 9 + 25 files changed, 184 insertions(+), 418 deletions(-) commit 1c36baf30e2964d9dca49156d4c9921bb872cf61 Author: Carlos IL <carlosil@chromium.org> Date: Thu Apr 18 21:24:26 2019 +0000 Fix crash when SSL error does not trigger interstitial. When SSLInfo is empty, we need to trigger a regular net error instead of an interstitial, otherwise a crash happens. A case where this was happening was when loading a cert related error via chrome://network errors. This CL fixes that. Bug: 953812 Change-Id: Iee7a46e71586fde5f4bd51c40aae93bc796fbfa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573858 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#652306} chrome/browser/ssl/ssl_browsertest.cc | 14 ++++++++++++++ chrome/browser/ssl/ssl_error_navigation_throttle.cc | 7 +++++-- 2 files changed, 19 insertions(+), 2 deletions(-) commit 83f27898297e4d4d30a0f4efc0544454131a5434 Author: Jonathan Backer <backer@chromium.org> Date: Thu Apr 18 21:23:58 2019 +0000 Plumb proper texture format for planes I added some manual instrumentation, and planes are very rarely R_8 and never RG_88. They are usually RGBA_8888 and occasionally LUMINOSITY_F16. This is a follow up to a Skia side change: https://skia-review.googlesource.com/c/skia/+/206900 Change-Id: I87a9b7c1cf1069712cd132dca659377272c53c5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573663 Reviewed-by: Peng Huang <penghuang@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com> Cr-Commit-Position: refs/heads/master@{#652305} .../display_embedder/skia_output_surface_impl.cc | 39 ++++++++++++---------- 1 file changed, 21 insertions(+), 18 deletions(-) commit 98e4316a068c90c465d6fa5c0a00d10adb3c57fc Author: Eric Stevenson <estevenson@chromium.org> Date: Thu Apr 18 21:22:13 2019 +0000 Android: Update Manifest expectations checker docs. Now uses a different target. Also explicitly call out the option to copy the expectations from the trybot. Change-Id: I2d2865d830c1186557b2075c6b14389117ae87c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574152 Reviewed-by: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#652304} chrome/android/java/README.md | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) commit 7200d5427678d5d08de3d8d16250b07f708b698b Author: Michael Giuffrida <michaelpg@chromium.org> Date: Thu Apr 18 21:20:42 2019 +0000 Only record AppListController metrics when it exists ShelfView should check existence of AppListController before using it to avoid a crash. Bug: 954317 Change-Id: Id5d5797f1867c6f88f00d5a3e09e587f22e0fcdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574624 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#652303} ash/shelf/shelf_view.cc | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) commit 62a23d4d05671df038c8da347f92ed3832e82f88 Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Thu Apr 18 21:18:38 2019 +0000 Revert "Move loading of data URLs out of the network process." This reverts commit f45ff75d1ee932e8695a34269c264f93b77439e2. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 652196 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZjQ1ZmY3NWQxZWU5MzJlODY5NWEzNDI2OWMyNjRmOTNiNzc0MzllMgw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/11937 Sample Failed Step: browser_tests Sample Flaky Test: DownloadTest.SaveLargeImage Original change's description: > Move loading of data URLs out of the network process. > > For subresources the renderer was already loading it in-process. Now for navigations and downloads, we keep them in the browser process. This avoids: > 1) sending GURLs bigger than 2MB to a different process, which strips them as they're bigger than url::kMaxURLChars > 2) having the network process deal with a scheme that's not going over the network, which we avoid > > Bug: 937146, 939871 > Change-Id: I8ca8225308b2a5f1f90594ab06943f0641a5c551 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570805 > Commit-Queue: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Cr-Commit-Position: refs/heads/master@{#652196} Change-Id: I599629fd38c350366c44d4d5a88d86ab0b4bd6b5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 937146, 939871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574685 Cr-Commit-Position: refs/heads/master@{#652302} chrome/browser/download/download_browsertest.cc | 58 ------------ .../network_context_configuration_browsertest.cc | 23 +++++ chrome/test/data/downloads/large_image.png | Bin 2096938 -> 0 bytes content/browser/BUILD.gn | 2 - content/browser/data_url_loader_factory.cc | 104 --------------------- content/browser/data_url_loader_factory.h | 47 ---------- content/browser/download/download_manager_impl.cc | 35 +++---- content/browser/download/save_file_manager.cc | 18 +--- .../browser/frame_host/render_frame_host_impl.cc | 4 - .../browser/loader/navigation_url_loader_impl.cc | 4 - .../service_worker/embedded_worker_instance.cc | 3 - .../worker_host/worker_script_fetch_initiator.cc | 3 - content/public/common/url_utils.cc | 3 +- services/network/network_context.cc | 9 +- services/network/network_context_unittest.cc | 7 +- .../public/cpp/simple_url_loader_unittest.cc | 23 ++++- 16 files changed, 69 insertions(+), 274 deletions(-) commit 0df0fcef671d84eed652d489758dc900671ee39d Author: Hui(Andy) Wu <wuandy@chromium.org> Date: Thu Apr 18 21:18:27 2019 +0000 [autofill assistant] Fix resources references to base module. As crbug/948234 described, currently from within DFM it is not possible to access resources from base module via org.chromium.chrome.autofill_assistant.R. The error happens at runtime only, so you can compile, but then running into crashes. The solution is to use org.chromium.chrome.R instead, which means we need to use full path if autofill_assistant.R is already imported. Also, this CL fixes a bug in AutofillAssistantFacade which skips autobot start when it should not. Change-Id: I52b58e03ec1cf0a80fa5669b6c7e39d3ac6593d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574459 Commit-Queue: Hui Wu <wuandy@chromium.org> Reviewed-by: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#652301} .../AssistantBottomBarCoordinator.java | 2 +- .../autofill_assistant/AssistantSnackbar.java | 2 +- .../AssistantActionsCarouselCoordinator.java | 5 ++- .../carousel/AssistantChipViewHolder.java | 3 +- .../autofill_assistant/carousel/ButtonView.java | 47 ++++++++++++---------- .../details/AssistantDetailsViewBinder.java | 11 ++--- .../payment/AssistantChoiceList.java | 2 +- .../payment/AssistantPaymentRequestUI.java | 10 +++-- .../AutofillAssistantFacade.java | 2 +- 9 files changed, 46 insertions(+), 38 deletions(-) commit e28269b698eda69e98ca145a288bd7a5954f4e69 Author: Chris Harrelson <chrishtr@chromium.org> Date: Thu Apr 18 21:14:23 2019 +0000 [LayoutNG/PE] Clear visual overflow for LayoutText before setting. An earlier refactor (*) accidentally removed the clearing of previous visual overflow before computing a new value. This has the effect of the visual overflow being too large after movement or animation, but also overflow of LayoutRect precision for elements far off-screen. (*) https://chromium-review.googlesource.com/c/chromium/src/+/1366767 Bug: 950963 Change-Id: Idb0609c814d0acf6058383202063ed34a8caf69e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572924 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Reviewed-by: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#652300} .../blink/renderer/core/layout/layout_replaced.cc | 2 +- .../blink/renderer/core/layout/svg/layout_svg_text.cc | 1 + .../text-clipped-offscreen-move-onscreen-ref.html | 14 ++++++++++++++ .../text-clipped-offscreen-move-onscreen.html | 19 +++++++++++++++++++ 4 files changed, 35 insertions(+), 1 deletion(-) commit 660fa9f0e75482159d7550df0ee20e91e6539bde Author: Hesen Zhang <hesen@google.com> Date: Thu Apr 18 21:11:41 2019 +0000 Update notification implementation. > Created UpdateNotificaionController listening to the UpdateStatusProvider, and will push notification when available. > Implemented Play Store update flow and inline-update flow after receiving the notification. Bug: 952354 Change-Id: I81fa80c7f1cb350fdfb0b33df86c3ef8fd078f93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564584 Reviewed-by: David Trainor <dtrainor@chromium.org> Reviewed-by: Xing Liu <xingliu@chromium.org> Commit-Queue: Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#652299} chrome/android/chrome_java_sources.gni | 1 + chrome/android/java/AndroidManifest.xml | 2 + ...le__base_bundle_module.AndroidManifest.expected | 3 + .../chromium/chrome/browser/ChromeActivity.java | 11 ++ .../chrome/browser/omaha/UpdateConfigs.java | 18 ++ .../omaha/UpdateNotificationController.java | 198 +++++++++++++++++++++ .../chrome/browser/omaha/UpdateStatusProvider.java | 6 +- .../java/strings/android_chrome_strings.grd | 8 + tools/metrics/histograms/enums.xml | 1 + 9 files changed, 246 insertions(+), 2 deletions(-) commit b8aec5525b603a8a9e39928110cb0eaac8736295 Author: Kristi Park <kristipark@chromium.org> Date: Thu Apr 18 21:08:56 2019 +0000 [NTP] Add ability to toggle between Most Visited and custom links Implement toggleMostVisitedOrCustomLinks for the EmbbededSearchApi. This will allow users to toggle between Most Visited tiles and custom links. Bug: 953822 Change-Id: Ide2d1a62456649a5b6f9ff45d16548ac1212e0b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572233 Reviewed-by: Kyle Milka <kmilka@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Reviewed-by: Greg Kerr <kerrnel@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#652298} chrome/browser/search/instant_service.cc | 78 +++++++++++++--------- chrome/browser/search/instant_service.h | 17 +++-- chrome/browser/search/instant_service_unittest.cc | 39 +++++++++++ chrome/browser/ui/search/search_ipc_router.cc | 10 +++ chrome/browser/ui/search/search_ipc_router.h | 6 ++ .../ui/search/search_ipc_router_policy_impl.cc | 4 ++ .../ui/search/search_ipc_router_policy_impl.h | 1 + .../ui/search/search_ipc_router_unittest.cc | 28 ++++++++ chrome/browser/ui/search/search_tab_helper.cc | 5 ++ chrome/browser/ui/search/search_tab_helper.h | 1 + chrome/common/pref_names.cc | 3 + chrome/common/pref_names.h | 1 + chrome/common/search.mojom | 3 + chrome/renderer/searchbox/searchbox.cc | 4 ++ chrome/renderer/searchbox/searchbox.h | 3 + chrome/renderer/searchbox/searchbox_extension.cc | 11 +++ components/ntp_tiles/most_visited_sites.h | 3 +- 17 files changed, 179 insertions(+), 38 deletions(-) commit faf13c7a362ef14529ac02be10854cc6f95def7d Author: Esmael El-Moslimany <aee@chromium.org> Date: Thu Apr 18 21:02:36 2019 +0000 Settings WebUI: add 0 as a valid minimum font size and show tick labels on font sliders The preference minimum font size has a default value of 0. The preference is exposed in the UI on the appearance fonts page in settings via a slider. The allowable values for the preference excluded the default value of 0. The settings slider code was changed to ensure the value of the preference was also an allowable value. When the font settings page loaded, the preference was then updated to the closest allowable value. If the preference is set to the default value, the closest allowable value is 6px. This change adds 0 as an allowable value which will allow a user to turn off the effects of a minimum font size. Bug: 944002 Change-Id: Ifc1c72e3673eef60e62f3edecd07ccba6b67928a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573238 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#652297} .../resources/settings/appearance_page/BUILD.gn | 1 + .../settings/appearance_page/appearance_fonts_page.js | 18 +++++++++++++----- 2 files changed, 14 insertions(+), 5 deletions(-) commit 8879b5e58a5812cb5a48ff122938b38b28875584 Author: Henrik Grunell <grunell@chromium.org> Date: Thu Apr 18 21:02:17 2019 +0000 Remove setAudioExperiments extension API function. This function is used for controlling audio experiments. The only experiment available to control via this API was the AEC3 (new echo canceller). That has now been fully rolled out, and there are no plans to add other experiments to control this way. Thus removing the function completely. Bug: 696930 Change-Id: I398e783747865b8774637d712f33c4c4c07260ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570827 Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Reviewed-by: Camille Lamy <clamy@chromium.org> Reviewed-by: Guido Urdaneta <guidou@chromium.org> Reviewed-by: Emily Stark <estark@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Auto-Submit: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#652296} .../webrtc_audio_private_api.cc | 84 ---------------------- .../webrtc_audio_private_api.h | 25 ------- .../resources/hangout_services/manifest.json | 2 +- chrome/browser/resources/hangout_services/thunk.js | 5 -- .../common/extensions/api/webrtc_audio_private.idl | 24 ------- .../renderer_host/render_process_host_impl.cc | 28 -------- .../renderer_host/render_process_host_impl.h | 5 -- content/common/media/aec_dump_messages.h | 6 -- content/public/browser/render_process_host.h | 12 ---- content/public/test/mock_render_process_host.cc | 4 -- content/public/test/mock_render_process_host.h | 3 - .../media/stream/aec_dump_message_filter.cc | 21 ------ .../media/stream/aec_dump_message_filter.h | 14 ---- .../stream/media_stream_constraints_util_audio.cc | 10 --- ...media_stream_constraints_util_audio_unittest.cc | 67 ----------------- 15 files changed, 1 insertion(+), 309 deletions(-) commit 53200406a3367278411cc8434f39d84e7aa4afec Author: Chris Lu <thegreenfrog@chromium.org> Date: Thu Apr 18 21:01:29 2019 +0000 [ios] Use FindInPageManager when feature flag is turned on. Bug: 919685 Change-Id: I306637940553044ed6fd57b13f00c0d12b6cd0c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566612 Reviewed-by: Rohit Rao <rohitrao@chromium.org> Reviewed-by: Yi Su <mrsuyi@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#652295} ios/chrome/browser/find_in_page/BUILD.gn | 5 + .../browser/find_in_page/find_in_page_controller.h | 4 + .../find_in_page/find_in_page_controller.mm | 136 +++++++++++++++------ .../find_in_page_controller_unittest.mm | 2 + .../find_in_page/find_in_page_response_delegate.h | 18 +++ ios/chrome/browser/find_in_page/find_tab_helper.h | 5 + ios/chrome/browser/find_in_page/find_tab_helper.mm | 5 + .../ui/browser_view/browser_view_controller.mm | 9 ++ 8 files changed, 145 insertions(+), 39 deletions(-) commit 83be1e44416020ce91219de39914f1ab4852d4f1 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Apr 18 21:01:09 2019 +0000 Roll src/third_party/chromite 060c5300eae0..86dcbc73338c (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/060c5300eae0..86dcbc73338c git log 060c5300eae0..86dcbc73338c --date=short --no-merges --format='%ad %ae %s' 2019-04-18 evanhernandez@chromium.org api: Nuke dead controller/protos. Created with: gclient setdep -r src/third_party/chromite@86dcbc73338c The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I2d1212844179c8c12ce057ad07096be515e8ca2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574244 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652294} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit c5d2ad87587de81caa148fe49335ba2bfdd15711 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Apr 18 20:57:53 2019 +0000 Roll src/third_party/SPIRV-Tools/src d754b70592ca..7aad9653f9a3 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/d754b70592ca..7aad9653f9a3 git log d754b70592ca..7aad9653f9a3 --date=short --no-merges --format='%ad %ae %s' 2019-04-18 zoddicus@users.noreply.github.com Remove legacy utility functions (#2530) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@7aad9653f9a3 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Icb91fe0d002e3e2644f6ef6cfb78fff13a611672 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574242 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652293} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 1a2ee7991a0a09fbd98fd046c120ab4bffffcab8 Author: kyle Ju <kyleju@chromium.org> Date: Thu Apr 18 20:53:11 2019 +0000 Activate the use of is_unexpected field in the output JSON file. Check in bits of code from the pending two-way sync CL. It allows me to monitor the flakiness of webdriver_test_suit on Linux Tests (dbg)(1) while the other CL is being reviewed. The changes are taken from https://chromium-review.googlesource.com/c/chromium/src/+/1484616/36 Sample JSON output: https://pastebin.com/CfuVTuP8 The is_unexpected fields for all of the three tests are false because their expectations exist in the WebDriverExpectations. Bug: 934919 Change-Id: If068f2318f2f2cbe6b866f96f14cb97f941a4df0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574360 Reviewed-by: John Chen <johnchen@chromium.org> Reviewed-by: Robert Ma <robertma@chromium.org> Commit-Queue: Kyle Ju <kyleju@chromium.org> Cr-Commit-Position: refs/heads/master@{#652292} .../test/chromedriver/test/run_webdriver_tests.py | 40 +++-- .../blink/tools/blinkpy/web_tests/port/base.py | 5 + .../tools/blinkpy/web_tests/port/base_unittest.py | 9 ++ third_party/blink/web_tests/WebDriverExpectations | 175 ++++++++++++++++++++- 4 files changed, 215 insertions(+), 14 deletions(-) commit 040d96ebe41d853258003e2fb1850ccfef2178e7 Author: Yiming Zhou <uwyiming@google.com> Date: Thu Apr 18 20:51:43 2019 +0000 Turn on a WPR flag to stablize captured sites tests. In https://chromium.googlesource.com/catapult/+/734e7ea0cbf9e0965596350ea51e5b4c8fc623f0, I introduced a change to Web page Replay Go (WPR Go) to prefer previously unmatched responses. This change fixed a number of issues with capturing checkout workflows on captured sites. The change hides the fix behind a feature flag for compatibility reasons. This change enables the fix by turning on the feature flag in Captured Sites tests. Bug: 850756 Change-Id: I0331b3b5cfe8b0ddde84211bd0b320ef65faa8fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574358 Auto-Submit: Yiming Zhou <uwyiming@google.com> Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#652291} chrome/browser/autofill/captured_sites_test_utils.cc | 1 + 1 file changed, 1 insertion(+) commit f57a5da590522e0f5c4702e0133be2924c9de573 Author: Kevin Marshall <kmarshall@chromium.org> Date: Thu Apr 18 20:49:33 2019 +0000 [Fuchsia] Remove deprecated bootserver flag --efi. "bootserver" fails to run because we are passing it an arg that is now deprecated, "--efi". EFI partition management is now managed by default by "bootserver". Bug: 954277 Change-Id: Id71932b9969a71ef27d21362c010c299659dd459 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574224 Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#652290} build/fuchsia/device_target.py | 6 ------ 1 file changed, 6 deletions(-) commit da222027d2242f59c500e10e194bb2d089aa0b7c Author: rbpotter <rbpotter@chromium.org> Date: Thu Apr 18 20:48:55 2019 +0000 Print Preview: Increase sidebar width Increase the width of the Print Preview sidebar by 25px, providing an extra 25px for titles. Bug: 925960, 941369 Change-Id: I59f216523709547312348d33104aa5e467a3f585 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574225 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#652289} chrome/browser/resources/print_preview/new/app.html | 2 +- chrome/browser/resources/print_preview/new/settings_section.html | 2 +- chrome/browser/resources/print_preview/print_preview_new.html | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) commit d6d48af9644128f3549864632c51a25ebd1569cb Author: Khushal <khushalsagar@chromium.org> Date: Thu Apr 18 20:45:46 2019 +0000 vr/android: Disable SurfaceControl when in VR mode. The android surface used by the display compositor when in VR mode is backed by SurfaceTexture, which is incompatible for use with SurfaceControl. Disable it when in VR mode. Fundamentally, SurfaceControl can only be used when the consumer end of the display's frame updates is SurfaceFlinger. With SurfaceTexture, the consumer end can be any arbitrary process which created the SurfaceTexture. TBR=tsepez@chromium.org R=piman@chromium.org Bug: 953953 Change-Id: Ie132d143aeffcf1bb022f6c691a0738515b19a1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573164 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Reviewed-by: Eric Karl <ericrk@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#652288} .../chrome/browser/compositor/CompositorView.java | 8 +++++--- .../browser/android/compositor/compositor_view.cc | 9 +++++---- .../browser/android/compositor/compositor_view.h | 1 + .../android/view/content_view_render_view.cc | 4 ++-- components/viz/common/display/renderer_settings.h | 1 + .../display_embedder/gl_output_surface_android.cc | 12 +++++++---- .../display_embedder/gl_output_surface_android.h | 3 ++- .../display_embedder/gpu_display_provider.cc | 10 +++++++++- .../viz_process_context_provider.cc | 23 ++++++++-------------- .../renderer_host/compositor_impl_android.cc | 11 ++++++++--- .../renderer_host/compositor_impl_android.h | 3 ++- content/public/browser/android/compositor.h | 2 +- .../common/context_creation_attribs.h | 1 + gpu/ipc/common/gpu_command_buffer_traits_multi.h | 1 + gpu/ipc/in_process_command_buffer.cc | 9 +++++++-- .../interfaces/compositing/renderer_settings.mojom | 3 +++ .../compositing/renderer_settings_struct_traits.cc | 2 ++ .../compositing/renderer_settings_struct_traits.h | 4 ++++ 18 files changed, 70 insertions(+), 37 deletions(-) commit c0726120e98ddb42195c50620332fd4dff1b7967 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Thu Apr 18 20:43:53 2019 +0000 Roll src-internal c8ee49fcfce8..fa3c64638fba (3 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c8ee49fcfce8..fa3c64638fba Created with: gclient setdep -r src-internal@fa3c64638fba The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=fdoray@chromium.org,bsep@chromium.org,keishi@chromium.org,chanli@chromium.org Change-Id: I753bf73354a64acd7f4f20ae80831977aaa46ad6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574039 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652287} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit de1c106f8deb9abdf36dd79ce45eb35f3276391a Author: Erik Chen <erikchen@chromium.org> Date: Thu Apr 18 20:40:52 2019 +0000 add alph as an OWNER to all heap profiling code. Change-Id: Ie4ef73b77d2ffc02c1cd39026dc24ccd940f4a10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574220 Auto-Submit: Erik Chen <erikchen@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#652286} chrome/browser/profiling_host/OWNERS | 1 + components/heap_profiling/OWNERS | 1 + components/services/heap_profiling/OWNERS | 1 + 3 files changed, 3 insertions(+) commit 709c0b93487486e04e1176e8cbe819ca053f544e Author: Alexei Filippov <alph@chromium.org> Date: Thu Apr 18 20:36:41 2019 +0000 [heap profiler] Add test for NATIVE_WITH_THREAD_NAMES mode Change-Id: I2ffd5db7f3ea2ab30be495e496663b98ffa942fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573007 Reviewed-by: Erik Chen <erikchen@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#652285} chrome/browser/profiling_host/memlog_browsertest.cc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) commit f5994a0255254e0ef6ae8fd704f878c9c465e148 Author: Jacob Dufault <jdufault@google.com> Date: Thu Apr 18 20:35:25 2019 +0000 cros: Move some *View classes into *Handler files Also eliminate AppLaunchSplashScreenView::Delegate Bug: 928555 Change-Id: I056c5fa6efb94bb59c45cbaf8e4344588dd97230 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564935 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#652284} chrome/browser/chromeos/BUILD.gn | 3 - .../browser/chromeos/login/app_launch_controller.h | 27 +++++--- chrome/browser/chromeos/login/kiosk_browsertest.cc | 3 +- .../login/screens/app_downloading_screen.cc | 2 + .../login/screens/app_downloading_screen.h | 3 +- .../login/screens/app_downloading_screen_view.h | 34 ---------- .../login/screens/app_launch_splash_screen_view.h | 74 ---------------------- .../chromeos/login/screens/mock_welcome_screen.h | 2 +- .../chromeos/login/screens/welcome_screen.cc | 2 +- .../browser/chromeos/login/screens/welcome_view.h | 48 -------------- chrome/browser/chromeos/login/wizard_controller.cc | 2 +- .../login/app_downloading_screen_handler.h | 17 ++++- .../login/app_launch_splash_screen_handler.cc | 34 +++++----- .../login/app_launch_splash_screen_handler.h | 44 ++++++++++++- .../webui/chromeos/login/welcome_screen_handler.h | 37 +++++++++-- 15 files changed, 132 insertions(+), 200 deletions(-) commit 6b2059feb9caa5bf27ebf0cce482fb462439c690 Author: Henrique Nakashima <hnakashima@chromium.org> Date: Thu Apr 18 20:32:49 2019 +0000 Update comments in //extensions about BrowserContextKeyed_Base_Factory. These comments that say "BrowserContextKeyed_Base_Factory" are outdated and should refer to "BrowserContextKeyed_Service_Factory" instead. Bug: 937770 Change-Id: Ib851fcf251c064a59bdb79d5cf718712654a602c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574422 Reviewed-by: Ken Rockot <rockot@google.com> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#652283} .../api/display_source/display_source_event_router_factory.h | 2 +- extensions/browser/api/idle/idle_manager_factory.h | 2 +- .../api/networking_config/networking_config_service_factory.h | 2 +- .../networking_private/networking_private_event_router_factory.h | 2 +- extensions/browser/browser_context_keyed_api_factory.h | 8 ++++---- 5 files changed, 8 insertions(+), 8 deletions(-) commit deea48bcf4285d5d56d931bd11e94ce788428d5f Author: Mitsuru Oshima <oshima@chromium.org> Date: Thu Apr 18 20:32:05 2019 +0000 Fix OverviewWindowDragTest.DragToClose * The test should observe the active window (that will be dragged) instead of all. * PresentationTimeRecorder used to discard the presentation feedback that can happen after it is deleted. This CL introduces the internal state that can outlive until the feedback is recorded. * I also removed the max latency as it's very noisy and normal latency should be enough. (SplitView test does the same) Bug: 953355 Change-Id: I3b3e329ca4e866004763f18c55f71816d5a5d535 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572268 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#652282} ash/app_list/views/app_list_view.cc | 2 +- ash/app_list/views/apps_grid_view.cc | 14 +- ash/metrics/presentation_time_recorder_unittest.cc | 58 ++++- ash/public/cpp/presentation_time_recorder.cc | 246 ++++++++++++++++----- ash/public/cpp/presentation_time_recorder.h | 108 +++------ ash/wm/overview/overview_window_drag_controller.cc | 7 +- ash/wm/splitview/split_view_controller.cc | 27 +-- .../tablet_mode_window_drag_delegate.cc | 15 +- .../ash/overview_window_drag_interactive_uitest.cc | 3 +- 9 files changed, 302 insertions(+), 178 deletions(-) commit f30c07c091ea2a5fc52c10cb1d2019ae7678d8b0 Author: Shakti Sahu <shaktisahu@chromium.org> Date: Thu Apr 18 20:31:21 2019 +0000 Download Home : Fixed dark mode circular progress view colors Bug: 951200 Change-Id: Idad969c53e72fa3bc657883d580f6ed93fc5d484 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568041 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#652281} .../drawable/circular_progress_bar_background_small.xml | 7 +++++-- .../drawable/circular_progress_bar_determinate_small.xml | 10 +++++----- .../drawable/circular_progress_bar_indeterminate_small.xml | 6 +++--- chrome/android/java/res_download/values-v17/styles.xml | 4 ++-- ui/android/java/res/values/colors.xml | 6 ++++++ ui/android/java/res_night/values-night/colors.xml | 6 ++++++ 6 files changed, 27 insertions(+), 12 deletions(-) commit 551636190c33554b5c3ce7a1a8327336f655ffba Author: Shakti Sahu <shaktisahu@chromium.org> Date: Thu Apr 18 20:30:20 2019 +0000 Download home tab style refresh This CL tries to update the tab style used in download home to match with rest of chrome. Bug: 951819 Change-Id: Id9eab9209ae12e47fe5d5a4808a0f55c9c9cbaa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573094 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#652280} .../java/res/drawable/download_home_tabs_bg.xml | 18 -------- .../res_download/layout/download_home_tabs.xml | 51 ++++++++++++---------- 2 files changed, 27 insertions(+), 42 deletions(-) commit 3cad68fa83de357d25a1554f568b3482e21d519c Author: Bruce Dawson <brucedawson@chromium.org> Date: Thu Apr 18 20:30:17 2019 +0000 Remove cfi_linker from tests Windows 10's implementation of Control Flow Guard costs about 300 ms per process-create call with unit_tests.exe and other huge executables. Since process creation is serialized this adds about 300 s to the test run time of unit_tests.exe (10,000 tests divided by ten tests per process times 0.3 s), which means it takes significantly longer to run than it would otherwise. There have been reports that this causes unit_tests.exe to take 4-5x as long to run as when CFG is disabled. CFG is not needed for these tests, so disabling it is fine. unit_tests.exe, for example, has about 180,000 CFG functions, which is a lot, but it's not clear why it costs so much to set a bit for each function in the ~1.5 MB CFG bitmap. That is a problem for Microsoft to figure out and this is being discussed with them. The underlying issue and this change do not affect chrome.exe. See http://www.alex-ionescu.com/?p=246 for more information on CFG. Bug: 950923 Change-Id: I660ef68ca33141e54cfe895efaa3e7c11bc7118a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570694 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#652279} build/config/BUILD.gn | 4 ---- build/config/BUILDCONFIG.gn | 7 +++++++ testing/test.gni | 6 ++++++ 3 files changed, 13 insertions(+), 4 deletions(-) commit 0246317501a51d4a4441d9f85f94ea3b5f8220ec Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Apr 18 20:26:29 2019 +0000 Roll src/third_party/depot_tools ac9b0f378677..7b2943927c04 (1 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ac9b0f378677..7b2943927c04 git log ac9b0f378677..7b2943927c04 --date=short --no-merges --format='%ad %ae %s' 2019-04-18 ellyjones@chromium.org depot_tools: bail out if $PATH contains tildes Created with: gclient setdep -r src/third_party/depot_tools@7b2943927c04 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:952865 TBR=agable@chromium.org Change-Id: I1fb86cbfeef30d43fc4c6104f20c5dba844aaeb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574243 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652278} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Updated tag 'tree_truth' (was 9220d4b37fc0)