Back to build
Raw log | Switch to full mode | Login

/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh /b/swarming/w/ir/cache/builder/src src in dir /b/swarming/w/ir/k: allow_subannotations: False cmd: ['/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh', '/b/swarming/w/ir/cache/builder/src', 'src'] env: {'CHROME_HEADLESS': '1'} env_prefixes: {} env_suffixes: {} infra_step: False name_tokens: ('tree truth steps',) ok_ret: frozenset([0]) trigger_specs: () full environment: ADDRFAM: inet BOTO_CONFIG: /b/swarming/w/ir/tmp/gsutil_task/.boto BUILDBUCKET_EXPERIMENTAL: FALSE CHROME_HEADLESS: 1 CIPD_CACHE_DIR: /b/swarming/cipd_cache/cache CIPD_PROTOCOL: v2 DEVSHELL_CLIENT_PORT: 44034 DOCKER_CONFIG: /b/swarming/w/ir/tmp/docker_cfg_task DOCKER_TMPDIR: /b/swarming/w/ir/tmp/docker_tmp_task GIT_CONFIG_NOSYSTEM: 1 GIT_TERMINAL_PROMPT: 0 HOME: /home/chrome-bot IFACE: eth0 INFRA_GIT_WRAPPER_HOME: /b/swarming/w/ir/tmp/git_home_task LOGDOG_COORDINATOR_HOST: logs.chromium.org LOGDOG_STREAM_PREFIX: buildbucket/cr-buildbucket.appspot.com/8915384957200500928 LOGDOG_STREAM_PROJECT: chromium LOGDOG_STREAM_SERVER_PATH: unix:/b/swarming/w/ir/tmp/ld.sock LOGICAL: eth0 LUCI_CONTEXT: /b/swarming/w/itoE3Ck9/luci_context.225543183 MAC_CHROMIUM_TMPDIR: /b/swarming/w/ir/tmp/t METHOD: dhcp NO_GCE_CHECK: False PATH: /b/swarming/w/ir/cipd_bin_packages:/b/swarming/w/ir/cipd_bin_packages/bin:/b/swarming/cipd_cache/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin PWD: /b/swarming/w/ir/k PYTHONIOENCODING: UTF-8 PYTHONUNBUFFERED: 1 ROOT_SETUP_LOG: /var/log/messages/chromebuild/root-setup.log SHLVL: 1 STARTUP_LOG: /var/log/messages/chromebuild/startup.log SWARMING_BOT_ID: swarm1098-c4 SWARMING_EXTERNAL_BOT_SETUP: 1 SWARMING_HEADLESS: 1 SWARMING_SERVER: https://chromium-swarm.appspot.com SWARMING_TASK_ID: 446309e4ef511311 TEMP: /b/swarming/w/ir/tmp/t TEMPDIR: /b/swarming/w/ir/tmp/t TERM: linux TMP: /b/swarming/w/ir/tmp/t TMPDIR: /b/swarming/w/ir/tmp/t UPSTART_EVENTS: net-device-up UPSTART_INSTANCE: UPSTART_JOB: chromebuild-startup USER: chrome-bot USERNAME: chrome-bot VPYTHON_VIRTUALENV_ROOT: /b/swarming/w/ir/cache/vpython _: /b/swarming/w/ir/cipd_bin_packages/vpython !@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: d2546dc07676ebc7e7568473fdb8e9d28c29027c [AF Wallet Metadata] Simplify AutofillWalletMetadataSizeChecker again Jan Krcal, Tue Apr 23 12:35:57 2019 +0000 50588c11e073edd774c353de5a97de8d8adb6ecf sensors: Do not show usage indicator if allowed by default and access was allowed Raphael Kubo da Costa, Tue Apr 23 12:32:27 2019 +0000 212ca0835aed2d2e93aff55e03c213920ef59f30 Roll src/third_party/perfetto 7fa9a66b28ac..8581c921caa9 (2 commits) chromium-autoroll, Tue Apr 23 12:31:33 2019 +0000 0ab027f5800e5b4a4b58323c29df66d5ef2be7ce components/sync/BUILD.gn: Clean up test_support_* targets Marc Treib, Tue Apr 23 12:26:12 2019 +0000 a7c927104736bea0fea348aef0b402c92c1d9c8a Fix flaky chrome://webrtc-internals stats reporting bug. Henrik Boström, Tue Apr 23 12:25:04 2019 +0000 993f798d5ee6a98fac74627d49b32301d4f76422 Switch blink::CDATASection and blink::CharacterData to use new downcast helpers Abhijeet Kandalkar, Tue Apr 23 12:24:22 2019 +0000 e5ec52c84e7bf26c29c7595df075448a554bba03 Remove uses of child_at() in ui/. Peter Kasting, Tue Apr 23 12:20:21 2019 +0000 8aaf2b151ef92ba88df3a0acb7435c7bf39a0370 Create a TestRule for dagger module overrides Pavel Shmakov, Tue Apr 23 12:19:02 2019 +0000 aa9d0aad5501d4be4ae7c17a26ff795f22e143f3 Associate css-contain failures with the correct issue. Rune Lillesveen, Tue Apr 23 12:11:27 2019 +0000 21cf7c49f21560023663bf484a8601ee69406c71 Implement reporting of 3 VPD fields in DeviceReportRequest Polina Bondarenko, Tue Apr 23 12:06:57 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit d2546dc07676ebc7e7568473fdb8e9d28c29027c Author: Jan Krcal <jkrcal@chromium.org> Date: Tue Apr 23 12:35:57 2019 +0000 [AF Wallet Metadata] Simplify AutofillWalletMetadataSizeChecker again This CL removes now unnecessary logic to avoid nested RunLoops. The logic is not needed any more because the code does not use any run loops any more. The CL still leaves around a simplified version of the logic just to allow DCHECKs. Bug: 953152 Change-Id: I594f2b507ee3a3d0afa0fa61327ac2e506089f12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570831 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#653150} .../browser/sync/test/integration/wallet_helper.cc | 34 +++++++--------------- .../browser/sync/test/integration/wallet_helper.h | 5 +--- 2 files changed, 12 insertions(+), 27 deletions(-) commit 50588c11e073edd774c353de5a97de8d8adb6ecf Author: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Date: Tue Apr 23 12:32:27 2019 +0000 sensors: Do not show usage indicator if allowed by default and access was allowed Change the way we show the usage indicator on the desktop and follow the UX pattern settings such as cookies and images follow: if we allow by default and sensors were allowed, do not show the indicator at all. With this CL, we only show the indicator if: - We allow by default but access was blocked due to some other reason (e.g. the checks in PermissionContextBase::RequestPermission()). - We block by default but we have a site exception that allows access (so the exception can be removed). - We block by default and access was blocked (due to any reason, including any checks from PermissionContextBase::RequestPermission()), in which case we offer the option to add a site exception. Bug: 954131 Change-Id: I10cc828b56d0c37883470187e2d86bc5ebe2d841 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574806 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#653149} .../content_setting_image_model.cc | 11 ++++ .../content_setting_image_model_unittest.cc | 72 +++++++++++++++++++++- 2 files changed, 82 insertions(+), 1 deletion(-) commit 212ca0835aed2d2e93aff55e03c213920ef59f30 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Apr 23 12:31:33 2019 +0000 Roll src/third_party/perfetto 7fa9a66b28ac..8581c921caa9 (2 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/7fa9a66b28ac..8581c921caa9 git log 7fa9a66b28ac..8581c921caa9 --date=short --no-merges --format='%ad %ae %s' 2019-04-23 treehugger-gerrit@google.com Merge "Fix debug tests." 2019-04-23 treehugger-gerrit@google.com Merge "heapprofd_client: SIGABRT on timed out spinlock instead of indefinite spin" Created with: gclient setdep -r src/third_party/perfetto@8581c921caa9 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I39fbe784c42cb879b05902b029f324daf3ccaec3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578422 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653148} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 0ab027f5800e5b4a4b58323c29df66d5ef2be7ce Author: Marc Treib <treib@chromium.org> Date: Tue Apr 23 12:26:12 2019 +0000 components/sync/BUILD.gn: Clean up test_support_* targets This moves some source files into the test_support target that they belong to (e.g. from _driver to _engine or _model), and also adds a new test_support_js target. Bug: 947443 Change-Id: I09a4cbad9cedeb7c15ab871491f150f0149de417 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570830 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#653147} chrome/test/BUILD.gn | 1 + components/sync/BUILD.gn | 37 ++++++++++++++++++++++++++++--------- 2 files changed, 29 insertions(+), 9 deletions(-) commit a7c927104736bea0fea348aef0b402c92c1d9c8a Author: Henrik Boström <hbos@chromium.org> Date: Tue Apr 23 12:25:04 2019 +0000 Fix flaky chrome://webrtc-internals stats reporting bug. A timer polls stats regularly, using standard or legacy stats as specified in a UI. Which stats to use can change while a pending request is in progress. This CL adds a check to discard legacy stats that are given to JS if we are not currently expecting legacy stats. This is something we were already doing for addStandardStats() but had forgotten to add to addLegacyStats(). The bug was only apparent every now and then depending on timing. Drive-by: Rename "nukeStatsList" to "clearStatsList" NOTRY=True Bug: 803014 Change-Id: I5323d58f25792c2b34f2432fe1e8482008db1f39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578608 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#653146} content/browser/resources/media/stats_table.js | 2 +- content/browser/resources/media/webrtc_internals.js | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) commit 993f798d5ee6a98fac74627d49b32301d4f76422 Author: Abhijeet Kandalkar <abhijeet@igalia.com> Date: Tue Apr 23 12:24:22 2019 +0000 Switch blink::CDATASection and blink::CharacterData to use new downcast helpers Bug: 891908 Change-Id: Ib8ce35ef3ccfaf715ea25701acbd80cc5cbd875d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571267 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#653145} third_party/blink/renderer/core/dom/cdata_section.h | 8 +++++++- third_party/blink/renderer/core/dom/character_data.h | 6 +++++- third_party/blink/renderer/core/dom/node.cc | 4 ++-- third_party/blink/renderer/core/dom/range.cc | 12 ++++++------ .../blink/renderer/core/dom/range_boundary_point.h | 4 ++-- .../core/editing/commands/apply_style_command.cc | 4 ++-- .../blink/renderer/core/editing/editing_strategy.cc | 4 ++-- .../core/editing/markers/document_marker_controller.cc | 2 +- third_party/blink/renderer/core/editing/position.cc | 17 ++++++++--------- .../core/editing/serializers/markup_formatter.cc | 2 +- .../renderer/core/editing/testing/selection_sample.cc | 10 +++++----- .../testing/accessibility_selection_test.cc | 2 +- 12 files changed, 42 insertions(+), 33 deletions(-) commit e5ec52c84e7bf26c29c7595df075448a554bba03 Author: Peter Kasting <pkasting@chromium.org> Date: Tue Apr 23 12:20:21 2019 +0000 Remove uses of child_at() in ui/. Bug: 940135 Change-Id: Ia0f10b57fb10a5de1464c98ce01d6bee1450166b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575035 Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#653144} ui/chromeos/ime/candidate_view_unittest.cc | 4 +- .../views/message_popup_collection_unittest.cc | 4 +- ui/message_center/views/notification_view_md.cc | 2 +- ui/views/accessibility/ax_aura_obj_cache.cc | 2 +- ui/views/bubble/bubble_frame_view.cc | 2 +- ui/views/controls/menu/menu_controller.cc | 3 +- ui/views/controls/menu/menu_controller_unittest.cc | 36 +++++------ ui/views/controls/menu/menu_item_view.cc | 10 ++-- ui/views/controls/menu/menu_item_view_unittest.cc | 4 +- .../controls/menu/menu_scroll_view_container.cc | 4 +- ui/views/controls/scroll_view.cc | 2 +- ui/views/controls/styled_label_unittest.cc | 70 +++++++++++----------- ui/views/controls/tabbed_pane/tabbed_pane.cc | 2 +- .../tabbed_pane_accessibility_mac_unittest.mm | 8 +-- ui/views/debug_utils.cc | 2 +- ui/views/examples/layout_example_base.cc | 4 +- ui/views/examples/scroll_view_example.cc | 4 +- ui/views/focus/focus_search.cc | 5 +- ui/views/layout/flex_layout_unittest.cc | 14 ++--- ui/views/layout/grid_layout_unittest.cc | 6 +- .../touchui/touch_selection_menu_runner_views.cc | 2 +- ui/views/view_unittest.cc | 40 ++++++------- ui/views/widget/root_view.cc | 2 +- 23 files changed, 117 insertions(+), 115 deletions(-) commit 8aaf2b151ef92ba88df3a0acb7435c7bf39a0370 Author: Pavel Shmakov <pshmakov@google.com> Date: Tue Apr 23 12:19:02 2019 +0000 Create a TestRule for dagger module overrides If modules are overriden in @Before, dagger components may get created before the modules are overriden. This can lead to hard-to-debug test failures due to seemingly unrelated to changes in code. In this CL I add ModuleOverridesRule. It can be chained with other rules to make sure it's executed before them. Change-Id: I2952f56f2f4b1c852805e07e19774033c44d54cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565973 Reviewed-by: Peter Conn <peconn@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Cr-Commit-Position: refs/heads/master@{#653143} chrome/android/chrome_test_java_sources.gni | 1 + .../ModuleFactoryOverrides.java | 6 ++-- .../ContextualSuggestionsTest.java | 20 +++++++----- .../browser/customtabs/CustomTabActivityTest.java | 3 -- .../CustomTabsDynamicModuleNavigationTest.java | 18 ++++++---- .../CustomTabsDynamicModulePostMessageTest.java | 17 +++++++--- .../CustomTabsDynamicModuleUITest.java | 18 ++++++---- .../dependency_injection/ModuleOverridesRule.java | 38 ++++++++++++++++++++++ .../ContextualSuggestionsPreferenceTest.java | 15 +++++---- 9 files changed, 99 insertions(+), 37 deletions(-) commit aa9d0aad5501d4be4ae7c17a26ff795f22e143f3 Author: Rune Lillesveen <futhark@chromium.org> Date: Tue Apr 23 12:11:27 2019 +0000 Associate css-contain failures with the correct issue. Bug: 947733, 947730 Change-Id: I3e65769424b7d9c10c4debffe70eb7390298054a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576572 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#653142} third_party/blink/web_tests/TestExpectations | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 21cf7c49f21560023663bf484a8601ee69406c71 Author: Polina Bondarenko <pbond@google.com> Date: Tue Apr 23 12:06:57 2019 +0000 Implement reporting of 3 VPD fields in DeviceReportRequest Report 3 more VPD fields in DeviceRegisterRequest: - ethernet_mac0, - mfg_date, - doc_mac. Extract the common part of CloudPolicyClient::Register() and CloudPolicyClient::RegisterWithCertificates() into the helper method. BUG=b:124364709 TEST=unit_tests,components_unittests,local device Change-Id: If7acfb66020c56efcd7034ddd65014157b35b399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561107 Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Polina Bondarenko <pbond@chromium.org> Auto-Submit: Polina Bondarenko <pbond@chromium.org> Cr-Commit-Position: refs/heads/master@{#653141} .../chromeos/login/existing_user_controller.cc | 4 +- .../policy/device_cloud_policy_initializer.cc | 25 +++++++ .../policy/device_local_account_policy_service.cc | 5 +- .../policy/user_cloud_policy_manager_chromeos.cc | 5 +- .../enterprise_reporting_private_api.cc | 4 +- .../machine_level_user_cloud_policy_helper.cc | 10 ++- chromeos/system/statistics_provider.cc | 3 + chromeos/system/statistics_provider.h | 9 +++ .../core/common/cloud/cloud_policy_client.cc | 79 ++++++++++++---------- .../policy/core/common/cloud/cloud_policy_client.h | 29 +++++++- .../common/cloud/cloud_policy_client_unittest.cc | 15 +++- .../core/common/cloud/mock_cloud_policy_client.cc | 3 + .../core/common/cloud/user_cloud_policy_manager.cc | 4 +- .../remote_commands_service_unittest.cc | 3 + 14 files changed, 152 insertions(+), 46 deletions(-) Updated tag 'tree_truth' (was 5f33950bd044)