Back to build
Raw log | Switch to full mode | Login

/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh /b/swarming/w/ir/cache/builder/src src in dir /b/swarming/w/ir/k: allow_subannotations: False cmd: ['/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh', '/b/swarming/w/ir/cache/builder/src', 'src'] env: {'CHROME_HEADLESS': '1'} env_prefixes: {} env_suffixes: {} infra_step: False name_tokens: ('tree truth steps',) ok_ret: frozenset([0]) trigger_specs: () full environment: ADDRFAM: inet BOTO_CONFIG: /b/swarming/w/ir/tmp/gsutil_task/.boto BUILDBUCKET_EXPERIMENTAL: FALSE CHROME_HEADLESS: 1 CIPD_CACHE_DIR: /b/swarming/cipd_cache/cache CIPD_PROTOCOL: v2 DEVSHELL_CLIENT_PORT: 35569 DOCKER_CONFIG: /b/swarming/w/ir/tmp/docker_cfg_task DOCKER_TMPDIR: /b/swarming/w/ir/tmp/docker_tmp_task GIT_CONFIG_NOSYSTEM: 1 GIT_TERMINAL_PROMPT: 0 HOME: /home/chrome-bot IFACE: eth0 INFRA_GIT_WRAPPER_HOME: /b/swarming/w/ir/tmp/git_home_task LOGDOG_COORDINATOR_HOST: logs.chromium.org LOGDOG_STREAM_PREFIX: buildbucket/cr-buildbucket.appspot.com/8915375033321929328 LOGDOG_STREAM_PROJECT: chromium LOGDOG_STREAM_SERVER_PATH: unix:/b/swarming/w/ir/tmp/ld.sock LOGICAL: eth0 LUCI_CONTEXT: /b/swarming/w/itUjjCY0/luci_context.525315477 MAC_CHROMIUM_TMPDIR: /b/swarming/w/ir/tmp/t METHOD: dhcp NO_GCE_CHECK: False PATH: /b/swarming/w/ir/cipd_bin_packages:/b/swarming/w/ir/cipd_bin_packages/bin:/b/swarming/cipd_cache/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin PWD: /b/swarming/w/ir/k PYTHONIOENCODING: UTF-8 PYTHONUNBUFFERED: 1 ROOT_SETUP_LOG: /var/log/messages/chromebuild/root-setup.log SHLVL: 1 STARTUP_LOG: /var/log/messages/chromebuild/startup.log SWARMING_BOT_ID: swarm98-c4 SWARMING_EXTERNAL_BOT_SETUP: 1 SWARMING_HEADLESS: 1 SWARMING_SERVER: https://chromium-swarm.appspot.com SWARMING_TASK_ID: 44639a4cbdda3111 TEMP: /b/swarming/w/ir/tmp/t TEMPDIR: /b/swarming/w/ir/tmp/t TERM: linux TMP: /b/swarming/w/ir/tmp/t TMPDIR: /b/swarming/w/ir/tmp/t UPSTART_EVENTS: net-device-up UPSTART_INSTANCE: UPSTART_JOB: chromebuild-startup USER: chrome-bot USERNAME: chrome-bot VPYTHON_VIRTUALENV_ROOT: /b/swarming/w/ir/cache/vpython _: /b/swarming/w/ir/cipd_bin_packages/vpython !@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: a747aa9cb09c55ef6528f589c45507a0f98c6d1b Avoid shadowing variabels in new font code Daniel Bratell, Tue Apr 23 14:16:25 2019 +0000 25fceccfd120070d69dc0dd7392bdfc23dbb95a9 android: disable one ReturnToChromeTest Egor Pasko, Tue Apr 23 14:11:08 2019 +0000 438591e52d24a133a02f5f19576b133c1a9036a3 Inline Character::IsEmojiKeycapBase Emil A Eklund, Tue Apr 23 14:02:12 2019 +0000 4a21e75452085b84a0c935d91a011e00741d4726 Revert "Convert away from JSONReader::ReadDeprecated in devtools/" Pâris Meuleman, Tue Apr 23 13:51:52 2019 +0000 12a834ad6070f3c1e99e5377b817cb73a4b0b12a Refactor browser_thread_unittest.cc Carlos Caballero, Tue Apr 23 13:48:28 2019 +0000 f660fb7ef2f2f606e4c4f486b4193e86f25eefef Drop duplicated path separater at #include tzik, Tue Apr 23 13:47:58 2019 +0000 492495a5cc92b64c6d1509f3b6674db097c0159b Modernize AuthenticationService use of base::Value API Sylvain Defresne, Tue Apr 23 13:40:01 2019 +0000 ee89f19fe9de1e1c04ce4749c9d7d6018676161c Update V8 to version 7.6.4. v8-ci-autoroll-builder, Tue Apr 23 13:36:41 2019 +0000 cd9624cde95446e170cac41ce6f173763fa927b6 Roll src-internal ca5f18c2b4e5..11c47f6e5f74 (1 commits) chromium-internal-autoroll, Tue Apr 23 13:23:58 2019 +0000 b3b2d064bde5661bd7d2d64041d976103c66e30f Reland "Add UMA for sync favicons in recently closed tabs menu" Victor Hugo Vianna Silva, Tue Apr 23 13:21:05 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit a747aa9cb09c55ef6528f589c45507a0f98c6d1b Author: Daniel Bratell <bratell@opera.com> Date: Tue Apr 23 14:16:25 2019 +0000 Avoid shadowing variabels in new font code I'm trying to remove variable shadowing in some Chromium code to maybe make the code a bit more robust, and two functions in blink/platform/fonts/shaping used several instances of |i|. Bug: 925310 Change-Id: I3e09f7772a7865ec7f73976a57af355070b6ad4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578538 Commit-Queue: Dominik Röttsches <drott@chromium.org> Auto-Submit: Daniel Bratell <bratell@opera.com> Reviewed-by: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#653164} third_party/blink/renderer/platform/fonts/shaping/shape_result.cc | 6 +++--- .../blink/renderer/platform/fonts/shaping/shape_result_view.cc | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) commit 25fceccfd120070d69dc0dd7392bdfc23dbb95a9 Author: Egor Pasko <pasko@chromium.org> Date: Tue Apr 23 14:11:08 2019 +0000 android: disable one ReturnToChromeTest Disabling ReturnToChromeTest.testObserverModeTriggeredWithDelay, it has been failing on a bot with KK Tablet since approximately the time when it was introduced. Bug: 955436 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ibcc0e8497019291de2d495aa7b8df93f6d73428f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578747 Reviewed-by: Egor Pasko <pasko@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#653163} .../src/org/chromium/chrome/browser/tasks/ReturnToChromeTest.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) commit 438591e52d24a133a02f5f19576b133c1a9036a3 Author: Emil A Eklund <eae@chromium.org> Date: Tue Apr 23 14:02:12 2019 +0000 Inline Character::IsEmojiKeycapBase Inline the extremely hot Character::IsEmojiKeycapBase method. Bug: 789124 Change-Id: I540b243527a330a4f9c15652efe2fd5e3c141485 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577796 Auto-Submit: Emil A Eklund <eae@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#653162} third_party/blink/renderer/platform/text/character.h | 4 +++- third_party/blink/renderer/platform/text/character_emoji.cc | 4 ---- 2 files changed, 3 insertions(+), 5 deletions(-) commit 4a21e75452085b84a0c935d91a011e00741d4726 Author: Pâris Meuleman <pmeuleman@chromium.org> Date: Tue Apr 23 13:51:52 2019 +0000 Revert "Convert away from JSONReader::ReadDeprecated in devtools/" This reverts commit e31d40d74af30c268b6adc2b5a8762dc5de20821. Reason for revert: Incorrect check see Bug: 954874 Original change's description: > Convert away from JSONReader::ReadDeprecated in devtools/ > > Use the new JSONReader::Read API that use the new API of > base::Value (move semantic) and convert the surrounding > code to the new API at the same time. > > Bug: 925165, 646113 > Change-Id: I37fadaf55cf347c69fdcfa1b53f8f01fed2fd01e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1550455 > Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#652085} TBR=caseq@chromium.org,pfeldman@chromium.org,sdefresne@chromium.org,pmeuleman@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 925165, 646113 Change-Id: Ifd8c91323bc0255ca91632fe4db3914e01ce50d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578741 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#653161} .../devtools/device/devtools_device_discovery.cc | 89 +++++++++--------- .../devtools/device/devtools_device_discovery.h | 4 +- .../devtools/device/port_forwarding_controller.cc | 94 ++++++++++--------- chrome/browser/devtools/devtools_ui_bindings.cc | 62 +++++++------ chrome/browser/devtools/devtools_window.cc | 102 +++++++++++++-------- 5 files changed, 202 insertions(+), 149 deletions(-) commit 12a834ad6070f3c1e99e5377b817cb73a4b0b12a Author: Carlos Caballero <carlscab@google.com> Date: Tue Apr 23 13:48:28 2019 +0000 Refactor browser_thread_unittest.cc No need for the complicated constructor params if all can be done in the constructor itself. Change-Id: I75db0a61665923706f7b4b2b0f3f9ee792db1123 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569906 Auto-Submit: Carlos Caballero <carlscab@google.com> Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#653160} content/browser/browser_thread_unittest.cc | 35 +++++++++++++----------------- 1 file changed, 15 insertions(+), 20 deletions(-) commit f660fb7ef2f2f606e4c4f486b4193e86f25eefef Author: tzik <tzik@chromium.org> Date: Tue Apr 23 13:47:58 2019 +0000 Drop duplicated path separater at #include Tbr: dcheng@chromium.org, falken@chromium.org, haraken@chromium.org Change-Id: I7a9e81b2a3f186d373686391d67bcbb56846245b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578150 Reviewed-by: Taiju Tsuiki <tzik@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#653159} .../interfaces/typemaps/string16_embedded_nulls_mojom_traits.h | 2 +- content/browser/worker_host/worker_script_fetch_initiator.cc | 2 +- third_party/blink/renderer/core/aom/accessible_node.cc | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) commit 492495a5cc92b64c6d1509f3b6674db097c0159b Author: Sylvain Defresne <sdefresne@chromium.org> Date: Tue Apr 23 13:40:01 2019 +0000 Modernize AuthenticationService use of base::Value API Change AuthenticationService to use the new base::Value API. This is a purely mechanical change to remove use of deprecated APIs. Bug: none Change-Id: I17ae041cab9823ea7562b29faca085629a3766d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569715 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#653158} .../browser/signin/authentication_service.mm | 32 +++++++++++----------- 1 file changed, 16 insertions(+), 16 deletions(-) commit ee89f19fe9de1e1c04ce4749c9d7d6018676161c Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Tue Apr 23 13:36:41 2019 +0000 Update V8 to version 7.6.4. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ce596cfd..ab1a9efe Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5e07dd7a880768ef138ff8d12e12e02726601af7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578425 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653157} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit cd9624cde95446e170cac41ce6f173763fa927b6 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Tue Apr 23 13:23:58 2019 +0000 Roll src-internal ca5f18c2b4e5..11c47f6e5f74 (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ca5f18c2b4e5..11c47f6e5f74 Created with: gclient setdep -r src-internal@11c47f6e5f74 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=chcunningham@chromium.org,loyso@chromium.org,clamy@chromium.org,flackr@chromium.org Change-Id: I223295b19907d30f8137b3d3ba393086be84203a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578426 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653156} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit b3b2d064bde5661bd7d2d64041d976103c66e30f Author: Victor Hugo Vianna Silva <victorvianna@google.com> Date: Tue Apr 23 13:21:05 2019 +0000 Reland "Add UMA for sync favicons in recently closed tabs menu" This is a reland of 5432d3b6be72f04ea14518bd400e3b1247124589 Original change's description: > Add UMA for sync favicons in recently closed tabs menu > > We add metrics to evaluate sync's usefulness in helping obtain favicons > for the recently closed tabs menu. > > Bug: 948109 > Change-Id: I88958d41925dc9bab93d1714a0b4e56e88b10c17 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564995 > Commit-Queue: Victor Vianna <victorvianna@google.com> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Alex Ilin <alexilin@chromium.org> > Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org> > Reviewed-by: Dan Beam <dbeam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#652119} TBR=pkasting@chromium.org TBR=pkotwicz@chromium.org TBR=alexilin@chromium.org Bug: 948109 Change-Id: If6d6822379be38a8e0b0b18a2ffd0cc5e5497c43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573622 Reviewed-by: Jan Krcal <jkrcal@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#653155} chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc | 14 +++++++++++++- components/favicon_base/favicon_request_metrics.cc | 4 ++++ components/favicon_base/favicon_request_metrics.h | 2 ++ tools/metrics/histograms/histograms.xml | 2 ++ 4 files changed, 21 insertions(+), 1 deletion(-) commit 4e479107de435a6c78d937e79450a0028dceeacc Author: David Bienvenu <davidbienvenu@chromium.org> Date: Tue Apr 23 13:18:58 2019 +0000 Revert "Load urls in a window on the current desktop, on Windows 10." This reverts commit 79de52d890429b82aa9c1f0d66d465d239a42d7b. Reason for revert: <causes test flakiness> Original change's description: > Load urls in a window on the current desktop, on Windows 10. > > When Chrome is launched with a URL on the command line, and > Chrome is already running, it looks for a browser window to load > the URL in. This CL makes it ignore browser windows that are > not on the current desktop, on Windows 10 (or higher). > > Bug: 757853 > Change-Id: Ib251619cbcef18809b886b96e21034507ea14654 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538834 > Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#652693} TBR=pkasting@chromium.org,grt@chromium.org,davidbienvenu@chromium.org Change-Id: Ib5c68c4c2d8a73e9551a4dd2f17ed1d40bf03d02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577871 Reviewed-by: David Bienvenu <davidbienvenu@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#653154} chrome/browser/ui/browser_finder.cc | 52 ---------------------- .../browser/ui/startup/startup_browser_creator.cc | 45 ++++++------------- .../browser/ui/startup/startup_browser_creator.h | 6 --- 3 files changed, 14 insertions(+), 89 deletions(-) commit 5d45bf891c2b146c83855393b06a7ca1a411309d Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Apr 23 13:08:43 2019 +0000 Roll Fuchsia SDK from 891542344871 to 891539624597 The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ibec1bac93b8d03f14713c9f51c372f61365a172e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578424 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653153} build/fuchsia/linux.sdk.sha1 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 4d0fb740271d2b82b75780ab0a1ed5e4ed6808bb Author: Gauthier Ambard <gambard@chromium.org> Date: Tue Apr 23 13:05:16 2019 +0000 [iOS] Remove ios/chrome/browser/ui deps target This CL removes the deps on the ios/c/b/ui target. It updates the target to have direct deps on what they actually need instead of relying on the public deps. Bug: 944008 Change-Id: I56b1dfe3f8fc4e1fdda30e381509c9edb7cb900c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578607 Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#653152} ios/chrome/app/BUILD.gn | 1 - ios/chrome/app/application_delegate/BUILD.gn | 2 +- ios/chrome/browser/autofill/BUILD.gn | 9 +++++---- ios/chrome/browser/context_menu/BUILD.gn | 2 +- ios/chrome/browser/device_sharing/BUILD.gn | 2 +- ios/chrome/browser/memory/BUILD.gn | 2 +- ios/chrome/browser/metrics/BUILD.gn | 8 ++++---- ios/chrome/browser/omaha/BUILD.gn | 2 +- ios/chrome/browser/passwords/BUILD.gn | 4 ++-- ios/chrome/browser/prerender/BUILD.gn | 1 - ios/chrome/browser/snapshots/BUILD.gn | 4 ++-- ios/chrome/browser/tabs/BUILD.gn | 1 - ios/chrome/browser/ui/activity_services/BUILD.gn | 4 ++-- ios/chrome/browser/ui/alert_coordinator/BUILD.gn | 5 +++-- ios/chrome/browser/ui/authentication/BUILD.gn | 3 ++- ios/chrome/browser/ui/authentication/cells/BUILD.gn | 2 +- ios/chrome/browser/ui/autofill/BUILD.gn | 6 +++--- ios/chrome/browser/ui/autofill/cells/BUILD.gn | 1 - ios/chrome/browser/ui/bookmarks/BUILD.gn | 4 ++-- ios/chrome/browser/ui/bookmarks/cells/BUILD.gn | 2 +- ios/chrome/browser/ui/bubble/BUILD.gn | 3 +-- ios/chrome/browser/ui/content_suggestions/BUILD.gn | 11 +++++------ ios/chrome/browser/ui/content_suggestions/cells/BUILD.gn | 4 ++-- ios/chrome/browser/ui/dialogs/BUILD.gn | 4 ++-- ios/chrome/browser/ui/download/BUILD.gn | 2 +- ios/chrome/browser/ui/elements/BUILD.gn | 3 ++- ios/chrome/browser/ui/find_bar/BUILD.gn | 3 ++- ios/chrome/browser/ui/first_run/BUILD.gn | 3 +-- ios/chrome/browser/ui/history/BUILD.gn | 7 ++----- ios/chrome/browser/ui/infobars/BUILD.gn | 1 - ios/chrome/browser/ui/location_bar/BUILD.gn | 2 +- ios/chrome/browser/ui/main/BUILD.gn | 1 - ios/chrome/browser/ui/ntp/BUILD.gn | 6 +++--- ios/chrome/browser/ui/omnibox/BUILD.gn | 1 - ios/chrome/browser/ui/omnibox/popup/BUILD.gn | 3 ++- ios/chrome/browser/ui/omnibox/popup/shortcuts/BUILD.gn | 2 -- ios/chrome/browser/ui/overscroll_actions/BUILD.gn | 1 - ios/chrome/browser/ui/page_info/BUILD.gn | 3 +-- ios/chrome/browser/ui/payments/BUILD.gn | 4 ++-- ios/chrome/browser/ui/payments/cells/BUILD.gn | 3 ++- ios/chrome/browser/ui/popup_menu/BUILD.gn | 1 - ios/chrome/browser/ui/popup_menu/cells/BUILD.gn | 1 - ios/chrome/browser/ui/popup_menu/public/BUILD.gn | 2 +- ios/chrome/browser/ui/print/BUILD.gn | 2 +- ios/chrome/browser/ui/qr_scanner/BUILD.gn | 2 +- ios/chrome/browser/ui/reading_list/BUILD.gn | 4 ---- ios/chrome/browser/ui/recent_tabs/BUILD.gn | 3 +-- ios/chrome/browser/ui/sad_tab/BUILD.gn | 2 +- ios/chrome/browser/ui/safe_mode/BUILD.gn | 2 +- ios/chrome/browser/ui/settings/BUILD.gn | 2 +- ios/chrome/browser/ui/settings/cells/BUILD.gn | 3 ++- ios/chrome/browser/ui/settings/cells/legacy/BUILD.gn | 3 ++- ios/chrome/browser/ui/side_swipe/BUILD.gn | 3 ++- ios/chrome/browser/ui/signin_interaction/BUILD.gn | 2 +- ios/chrome/browser/ui/static_content/BUILD.gn | 2 -- ios/chrome/browser/ui/tab_grid/BUILD.gn | 1 - ios/chrome/browser/ui/table_view/BUILD.gn | 2 +- ios/chrome/browser/ui/tabs/BUILD.gn | 6 +++--- ios/chrome/browser/ui/toolbar/BUILD.gn | 4 +--- ios/chrome/browser/ui/toolbar/buttons/BUILD.gn | 2 +- ios/chrome/browser/ui/toolbar/fullscreen/BUILD.gn | 2 +- ios/chrome/browser/ui/toolbar/keyboard_assist/BUILD.gn | 2 +- ios/chrome/browser/ui/toolbar/public/BUILD.gn | 2 +- ios/chrome/browser/ui/webui/BUILD.gn | 2 +- ios/chrome/browser/url_loading/BUILD.gn | 1 - ios/chrome/browser/web/BUILD.gn | 4 +--- ios/chrome/test/earl_grey/BUILD.gn | 4 ++-- ios/chrome/test/fakes/BUILD.gn | 1 - ios/showcase/payments/BUILD.gn | 2 +- 69 files changed, 89 insertions(+), 112 deletions(-) commit 1f06e0953d3decf141dd98a97c36801ae7ebc667 Author: Thiemo Nagel <tnagel@chromium.org> Date: Tue Apr 23 13:04:06 2019 +0000 Remove tnagel from enrollment OWNERS Bug: none Change-Id: Id2398ffdb081b1dfd4bb24640a98a1b8147fe581 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578606 Auto-Submit: Thiemo Nagel <tnagel@chromium.org> Reviewed-by: Pavol Marko <pmarko@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#653151} chrome/browser/chromeos/login/enrollment/OWNERS | 1 - 1 file changed, 1 deletion(-) commit d2546dc07676ebc7e7568473fdb8e9d28c29027c Author: Jan Krcal <jkrcal@chromium.org> Date: Tue Apr 23 12:35:57 2019 +0000 [AF Wallet Metadata] Simplify AutofillWalletMetadataSizeChecker again This CL removes now unnecessary logic to avoid nested RunLoops. The logic is not needed any more because the code does not use any run loops any more. The CL still leaves around a simplified version of the logic just to allow DCHECKs. Bug: 953152 Change-Id: I594f2b507ee3a3d0afa0fa61327ac2e506089f12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570831 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#653150} .../browser/sync/test/integration/wallet_helper.cc | 34 +++++++--------------- .../browser/sync/test/integration/wallet_helper.h | 5 +--- 2 files changed, 12 insertions(+), 27 deletions(-) commit 50588c11e073edd774c353de5a97de8d8adb6ecf Author: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Date: Tue Apr 23 12:32:27 2019 +0000 sensors: Do not show usage indicator if allowed by default and access was allowed Change the way we show the usage indicator on the desktop and follow the UX pattern settings such as cookies and images follow: if we allow by default and sensors were allowed, do not show the indicator at all. With this CL, we only show the indicator if: - We allow by default but access was blocked due to some other reason (e.g. the checks in PermissionContextBase::RequestPermission()). - We block by default but we have a site exception that allows access (so the exception can be removed). - We block by default and access was blocked (due to any reason, including any checks from PermissionContextBase::RequestPermission()), in which case we offer the option to add a site exception. Bug: 954131 Change-Id: I10cc828b56d0c37883470187e2d86bc5ebe2d841 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574806 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#653149} .../content_setting_image_model.cc | 11 ++++ .../content_setting_image_model_unittest.cc | 72 +++++++++++++++++++++- 2 files changed, 82 insertions(+), 1 deletion(-) commit 212ca0835aed2d2e93aff55e03c213920ef59f30 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Apr 23 12:31:33 2019 +0000 Roll src/third_party/perfetto 7fa9a66b28ac..8581c921caa9 (2 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/7fa9a66b28ac..8581c921caa9 git log 7fa9a66b28ac..8581c921caa9 --date=short --no-merges --format='%ad %ae %s' 2019-04-23 treehugger-gerrit@google.com Merge "Fix debug tests." 2019-04-23 treehugger-gerrit@google.com Merge "heapprofd_client: SIGABRT on timed out spinlock instead of indefinite spin" Created with: gclient setdep -r src/third_party/perfetto@8581c921caa9 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I39fbe784c42cb879b05902b029f324daf3ccaec3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578422 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653148} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Updated tag 'tree_truth' (was 0ab027f5800e)