Back to build
Raw log | Switch to full mode | Login

/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh /b/swarming/w/ir/cache/builder/src src in dir /b/swarming/w/ir/k: allow_subannotations: False cmd: ['/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh', '/b/swarming/w/ir/cache/builder/src', 'src'] env: {'CHROME_HEADLESS': '1'} env_prefixes: {} env_suffixes: {} infra_step: False name_tokens: ('tree truth steps',) ok_ret: frozenset([0]) trigger_specs: () full environment: ADDRFAM: inet BOTO_CONFIG: /b/swarming/w/ir/tmp/gsutil_task/.boto BUILDBUCKET_EXPERIMENTAL: FALSE CHROME_HEADLESS: 1 CIPD_CACHE_DIR: /b/swarming/cipd_cache/cache CIPD_PROTOCOL: v2 DEVSHELL_CLIENT_PORT: 42261 DOCKER_CONFIG: /b/swarming/w/ir/tmp/docker_cfg_task DOCKER_TMPDIR: /b/swarming/w/ir/tmp/docker_tmp_task GIT_CONFIG_NOSYSTEM: 1 GIT_TERMINAL_PROMPT: 0 HOME: /home/chrome-bot IFACE: eth0 INFRA_GIT_WRAPPER_HOME: /b/swarming/w/ir/tmp/git_home_task LOGDOG_COORDINATOR_HOST: logs.chromium.org LOGDOG_STREAM_PREFIX: buildbucket/cr-buildbucket.appspot.com/8915369253381563088 LOGDOG_STREAM_PROJECT: chromium LOGDOG_STREAM_SERVER_PATH: unix:/b/swarming/w/ir/tmp/ld.sock LOGICAL: eth0 LUCI_CONTEXT: /b/swarming/w/itA7Vrb9/luci_context.782259737 MAC_CHROMIUM_TMPDIR: /b/swarming/w/ir/tmp/t METHOD: dhcp NO_GCE_CHECK: False PATH: /b/swarming/w/ir/cipd_bin_packages:/b/swarming/w/ir/cipd_bin_packages/bin:/b/swarming/cipd_cache/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin PWD: /b/swarming/w/ir/k PYTHONIOENCODING: UTF-8 PYTHONUNBUFFERED: 1 ROOT_SETUP_LOG: /var/log/messages/chromebuild/root-setup.log SHLVL: 1 STARTUP_LOG: /var/log/messages/chromebuild/startup.log SWARMING_BOT_ID: swarm2238-c4 SWARMING_EXTERNAL_BOT_SETUP: 1 SWARMING_HEADLESS: 1 SWARMING_SERVER: https://chromium-swarm.appspot.com SWARMING_TASK_ID: 4463ee732a6ddf11 TEMP: /b/swarming/w/ir/tmp/t TEMPDIR: /b/swarming/w/ir/tmp/t TERM: linux TMP: /b/swarming/w/ir/tmp/t TMPDIR: /b/swarming/w/ir/tmp/t UPSTART_EVENTS: net-device-up UPSTART_INSTANCE: UPSTART_JOB: chromebuild-startup USER: chrome-bot USERNAME: chrome-bot VPYTHON_VIRTUALENV_ROOT: /b/swarming/w/ir/cache/vpython _: /b/swarming/w/ir/cipd_bin_packages/vpython !@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: b81e73afd6418f4daaa181fd3e15711feedbee24 Send gamepad data to WebXR. Jacob DeWitt, Tue Apr 23 16:52:09 2019 +0000 bfa639ff7a40bfc67e4c3fa757c86b66c068f8b5 Set PlatNotificationContext task priority default to USER_VISIBLE. Richard Knoll, Tue Apr 23 16:50:49 2019 +0000 4d525538ea3e348868d79ad43b18fda60bff2234 [Animation Worklet] Use document from script state instead of the animated target Yi Gu, Tue Apr 23 16:50:08 2019 +0000 a866ed5a317cfd6f3d4b72018d984970f067cadd Fix Focus ring for Back button in detailed view Ahmed Mehfooz, Tue Apr 23 16:48:49 2019 +0000 600b6bd1379296b925907be5a3a6d5e5f0c099d4 Add paint internal method to canvas to respect global painting flags Aaron Krajeski, Tue Apr 23 16:48:22 2019 +0000 acbbaab0c2869dbcfae9bd927d4d5ef65840e191 Docs: extend Android emulator docs Nate Fischer, Tue Apr 23 16:46:20 2019 +0000 4bc4163e43896688b58e2b51f162ed144e255457 Too many top level Status aliases Daniel Bratell, Tue Apr 23 16:45:16 2019 +0000 325aad0c59717c5292ccb8d4d2f10af4c5904f01 IsStringUTF8 and StreamingUtf8Validator can differ. Adam Langley, Tue Apr 23 16:45:13 2019 +0000 c44b128425652a2b05e640bd093726a95851adb2 [base] Finalize ThreadPool OWNERS files post rename. Gabriel Charette, Tue Apr 23 16:41:27 2019 +0000 a15329e8f4a1ff5ddbf65210c4a4453f791f1a6f DevTools: do not render contrast info for non-text node. Pavel Feldman, Tue Apr 23 16:37:48 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit b81e73afd6418f4daaa181fd3e15711feedbee24 Author: Jacob DeWitt <jacde@chromium.org> Date: Tue Apr 23 16:52:09 2019 +0000 Send gamepad data to WebXR. Add Gamepad to XRInputSourceState mojo struct to send device gamepad data to Blink WebXR code, which updates the associated XRInputSource Gamepad on each frame. Changing shared_with_blink in device/gamepad/public/cpp/BUILD.gn from a source_set to a component and exporting the device::Gamepad and device::Gamepads classes is necessary to make the component build pass with no linker errors. Code changes to populate the Gamepad struct before sending it through mojo will come in later CLs for platforms such as WMR and Oculus. Bug: 944880 Change-Id: I2bf372cfd34c3250aeae13670056315f04e23bb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566683 Reviewed-by: David Dorwin <ddorwin@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Bill Orr <billorr@chromium.org> Reviewed-by: Brandon Jones <bajones@chromium.org> Commit-Queue: Jacob DeWitt <jacde@chromium.org> Cr-Commit-Position: refs/heads/master@{#653221} device/gamepad/public/cpp/BUILD.gn | 7 ++++++- device/gamepad/public/cpp/gamepad.h | 4 +++- device/gamepad/public/cpp/gamepads.h | 4 +++- device/vr/public/mojom/vr_service.mojom | 8 ++++++++ third_party/blink/renderer/modules/xr/xr.cc | 6 +++++- third_party/blink/renderer/modules/xr/xr.h | 6 ++++++ .../blink/renderer/modules/xr/xr_input_source.cc | 23 ++++++++++++++++++++-- .../blink/renderer/modules/xr/xr_input_source.h | 22 +++++++++++++++++++-- .../blink/renderer/modules/xr/xr_session.cc | 2 ++ 9 files changed, 74 insertions(+), 8 deletions(-) commit bfa639ff7a40bfc67e4c3fa757c86b66c068f8b5 Author: Richard Knoll <knollr@chromium.org> Date: Tue Apr 23 16:50:49 2019 +0000 Set PlatNotificationContext task priority default to USER_VISIBLE. This raises the task runner priority from BEST_EFFORT to USER_VISIBLE as we always post to the UI thread with USER_VISIBLE anyway. Bug: None Change-Id: I9e31b7880bb7dbe6cad5e61213d3b35ea84289dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573740 Reviewed-by: Peter Beverloo <peter@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#653220} .../platform_notification_context_impl.cc | 53 ++++++++++------------ 1 file changed, 25 insertions(+), 28 deletions(-) commit 4d525538ea3e348868d79ad43b18fda60bff2234 Author: Yi Gu <yigu@chromium.org> Date: Tue Apr 23 16:50:08 2019 +0000 [Animation Worklet] Use document from script state instead of the animated target By spec [1] the ctor of Worklet Animation should use the Document that is associated with the window that is the current global object. However the code takes the Document from the target of the first effect which is not spec-compliant. e.g. the target is an iframe, In addition, there may be security risks behind it. [1] https://drafts.css-houdini.org/css-animationworklet/#creating-worklet-animation Bug: 953466 Change-Id: I13ed9a44e5a77f359e4075f1bd147d7e7163804a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570628 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by: Majid Valipour <majidvp@chromium.org> Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#653219} .../modules/animationworklet/worklet_animation.cc | 2 +- .../wpt/animation-worklet/resources/iframe.html | 9 +++++++ .../worklet-animation-creation.https.html | 30 ++++++++++++++++++++++ 3 files changed, 40 insertions(+), 1 deletion(-) commit a866ed5a317cfd6f3d4b72018d984970f067cadd Author: Ahmed Mehfooz <amehfooz@chromium.org> Date: Tue Apr 23 16:48:49 2019 +0000 Fix Focus ring for Back button in detailed view Test: Manual UI Test Bug: 954934 Change-Id: Iafa3867f7780be11697137f899097cfb202daa07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577972 Reviewed-by: Tim Song <tengs@chromium.org> Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#653218} ash/system/tray/detailed_view_delegate.cc | 5 +++++ 1 file changed, 5 insertions(+) commit 600b6bd1379296b925907be5a3a6d5e5f0c099d4 Author: Aaron Krajeski <aaronhk@google.com> Date: Tue Apr 23 16:48:22 2019 +0000 Add paint internal method to canvas to respect global painting flags For dragging and printing operations gpu-composited canvases should still get drawn to their parent layer. Bug: 932405 Change-Id: I8a59345fa856876118c04fc446865f7837f09a8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573650 Reviewed-by: Fernando Serboncini <fserb@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#653217} .../renderer/core/html/canvas/html_canvas_element.cc | 19 ++++++++++++++++--- .../renderer/core/html/canvas/html_canvas_element.h | 6 +++++- .../blink/renderer/core/paint/html_canvas_painter.cc | 4 +++- 3 files changed, 24 insertions(+), 5 deletions(-) commit acbbaab0c2869dbcfae9bd927d4d5ef65840e191 Author: Nate Fischer <ntfschr@chromium.org> Date: Tue Apr 23 16:46:20 2019 +0000 Docs: extend Android emulator docs No change to logic, only docs. This extends Android emulator docs to address two issues: 1. x86 emulators don't work with arm-compiled APKs. Although this is, in some sense, obvious, it's worth calling out since ARM-compiled APKs are fairly common due to the popularity of the architecture. 2. Make it easier to find "Google APIs" images in the AVD creation wizard. This explains you need to go to the "x86 Images" tab in the wizard. Bug: 955135, 918221 Test: tools/md_browser/md_browser.py Test: Upload to gerrit > open file > click "gitiles" Change-Id: Id87efe8c8b8c96dc01f72819bd8c31199507c416 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578071 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#653216} docs/android_emulator.md | 20 ++++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) commit 4bc4163e43896688b58e2b51f162ed144e255457 Author: Daniel Bratell <bratell@opera.com> Date: Tue Apr 23 16:45:16 2019 +0000 Too many top level Status aliases Both leveldb::Status and inspector_protocol_encoding::Status are pulled into the global namespace as aliases. In certain non-default jumbo builds that causes problems. Since there are many-many usages of leveldb::Status as Status but only one usage of inspector_protocol_encoding::Status as Status, this changes only inspector_protocol_encoding::Status to not use an alias. This also touches an inspector_protocol_encoding::cbor to not conflict with another patch. Change-Id: If663fa8c7d14ab1cb11a88a037a588b0c4b2d5b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578559 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#653215} content/browser/devtools/devtools_session.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit 325aad0c59717c5292ccb8d4d2f10af4c5904f01 Author: Adam Langley <agl@chromium.org> Date: Tue Apr 23 16:45:13 2019 +0000 IsStringUTF8 and StreamingUtf8Validator can differ. This is relatively harmless, but can hit a NOTREACHED. This change makes the CTAP2 parsers follow the stricter, IsStringUTF8, result. Bug: 955317 Change-Id: If7f8b8a0c1e85566bb035b21626d52fd91038a42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576337 Commit-Queue: Adam Langley <agl@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#653214} device/fido/device_response_converter.cc | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) commit c44b128425652a2b05e640bd093726a95851adb2 Author: Gabriel Charette <gab@chromium.org> Date: Tue Apr 23 16:41:27 2019 +0000 [base] Finalize ThreadPool OWNERS files post rename. R=fdoray@chromium.org Bug: 951388 Change-Id: I66354e187f2c51bf73a0bcf42e6f9b4124450df7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578943 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#653213} base/task/task_scheduler/OWNERS | 8 -------- base/task/thread_pool/OWNERS | 1 - 2 files changed, 9 deletions(-) commit a15329e8f4a1ff5ddbf65210c4a4453f791f1a6f Author: Pavel Feldman <pfeldman@chromium.org> Date: Tue Apr 23 16:37:48 2019 +0000 DevTools: do not render contrast info for non-text node. Bug: 951817 Change-Id: I04a20eb391d1504d4211f677af51398a15d0c6a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577868 Commit-Queue: Pavel Feldman OOO <pfeldman@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#653212} .../renderer/core/inspector/inspector_css_agent.cc | 34 +++++++--------------- .../css/css-get-background-colors-expected.txt | 4 --- .../css/css-get-background-colors.js | 4 --- .../css/resources/css-get-background-colors.html | 16 ---------- 4 files changed, 10 insertions(+), 48 deletions(-) commit 04b55b40c16996feaed5af3ea2a07b431dc1c9dd Author: Nate Fischer <ntfschr@chromium.org> Date: Tue Apr 23 16:36:45 2019 +0000 WebView Tools: don't hardcode system image paths This modifies remove_preinstalled_webview.py to no longer hardcode system image paths. This addresses two issues with the script: 1. The script didn't support Trichrome, since that sits at a different path 2. The script wasn't robust against system image path changes (which already happened in the platform, breaking the script) Bug: 952077 Test: android_webview/tools/remove_preinstalled_webview.py Change-Id: I72bbfa27f47b1c92ec1d6c0d408dac4308724d84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578003 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by: Richard Coles <torne@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#653211} android_webview/tools/remove_preinstalled_webview.py | 20 +++++++------------- 1 file changed, 7 insertions(+), 13 deletions(-) commit 3f014bee9c5e7f0a4263ac4e54805431c06fe2b2 Author: Toni Barzic <tbarzic@chromium.org> Date: Tue Apr 23 16:36:42 2019 +0000 Enable DeviceLocalAccountTest.TermsOfServiceWithLocaleSwitch Try enabling the test, unable to repro flakiness locally. BUG=865702 Change-Id: I06fb79eb501118fead3b0d68da56233b257dd2f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574213 Reviewed-by: Pavol Marko <pmarko@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#653210} chrome/browser/chromeos/policy/device_local_account_browsertest.cc | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) commit 9c00c06ae242ce4e9b4e01536799ed29bf59521c Author: Henrik Boström <hbos@chromium.org> Date: Tue Apr 23 16:32:57 2019 +0000 Reland "Fix flaky chrome://webrtc-internals stats reporting bug." This is a reland of a7c927104736bea0fea348aef0b402c92c1d9c8a Original change's description: > Fix flaky chrome://webrtc-internals stats reporting bug. > > A timer polls stats regularly, using standard or legacy stats as > specified in a UI. Which stats to use can change while a pending request > is in progress. This CL adds a check to discard legacy stats that are > given to JS if we are not currently expecting legacy stats. > This is something we were already doing for addStandardStats() but had > forgotten to add to addLegacyStats(). The bug was only apparent every > now and then depending on timing. > > Drive-by: Rename "nukeStatsList" to "clearStatsList" > > NOTRY=True > > Bug: 803014 > Change-Id: I5323d58f25792c2b34f2432fe1e8482008db1f39 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578608 > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Commit-Queue: Henrik Boström <hbos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#653146} Bug: 803014 Change-Id: I688cf51d57e586743e204f1113fcef2b06526126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578569 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#653209} content/browser/resources/media/stats_table.js | 2 +- content/browser/resources/media/webrtc_internals.js | 5 ++++- content/browser/webrtc/webrtc_internals_browsertest.cc | 12 +++++++----- 3 files changed, 12 insertions(+), 7 deletions(-) commit 952a910505158a7a280f491f03ee513ac5e7fe90 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Apr 23 16:31:39 2019 +0000 Roll src/third_party/perfetto 8581c921caa9..22219acb4b58 (1 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/8581c921caa9..22219acb4b58 git log 8581c921caa9..22219acb4b58 --date=short --no-merges --format='%ad %ae %s' 2019-04-23 fmayer@google.com Merge "SharedRingBuffer: test empty write." Created with: gclient setdep -r src/third_party/perfetto@22219acb4b58 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ia4c5818b7672b1d5b27eaa34b63a0c18b9743dfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578428 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653208} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit fc5d94ead3459c9486ed7445ab2e82be0a8d8f04 Author: Dmitry Gozman <dgozman@chromium.org> Date: Tue Apr 23 16:31:09 2019 +0000 Remove some RenderViewObserver callbacks Navigation-related callbacks are already exposed on RenderFrameObserver. This patch starts using WebTestRenderFrameObserver for these instead of BlinkTestRunner. Bug: none Change-Id: Ia77d2e7ca1cb569f479c24895543bf8b78be4f66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576100 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#653207} content/public/renderer/render_view_observer.h | 10 ------ content/renderer/render_frame_impl.cc | 9 ------ .../shell/renderer/web_test/blink_test_runner.cc | 36 ++++++++-------------- .../shell/renderer/web_test/blink_test_runner.h | 7 +---- .../web_test/web_test_render_frame_observer.cc | 29 +++++++++++++++++ .../web_test/web_test_render_frame_observer.h | 6 ++++ 6 files changed, 48 insertions(+), 49 deletions(-) commit ab71dd0147ba6d0864b00acb0ada2e08b477b585 Author: Mei Liang <meiliang@chromium.org> Date: Tue Apr 23 16:29:06 2019 +0000 Tint TabStrip toolbar control buttons correctly Bug: 953835 Change-Id: Iae92f9f1e718f6364447c3e3058890cb7cd1890f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576513 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#653206} .../chrome/browser/tasks/tab_management/TabGroupUiToolbarView.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit f94f8181107a98d7e14d27890b0a6c8440859ef3 Author: Katie D <katie@chromium.org> Date: Tue Apr 23 16:28:08 2019 +0000 Three updates to Auto-Alt strings per request. * Mac should not use title case on opt-in buttons or dialog title. * Dialog title should have a question mark after it. * Settings text should match opt-in dialog. Bug: 955111 Change-Id: Ia2ffc028f27f8cb2ef82a9e798dfeac81ca42a03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577625 Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#653205} chrome/app/generated_resources.grd | 25 ++++++++++------------ chrome/app/settings_strings.grdp | 2 +- .../accessibility_labels_bubble_model.cc | 2 +- 3 files changed, 13 insertions(+), 16 deletions(-) commit b7fff232f8aeafa795ab2af2070b53fa57590c88 Author: James Cook <jamescook@chromium.org> Date: Tue Apr 23 16:27:16 2019 +0000 CrOS SplitSettings: Decouple browser font/page zoom from ARC++ app zoom Browser font size and default page zoom will only control browser content. Display zoom controls the size of ARC++ apps as usual. Bug: 955071, 950007 Change-Id: I29507bb2616068d47bc050bbff41e4d4a96b35a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577926 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by: David Jacobo <djacobo@chromium.org> Cr-Commit-Position: refs/heads/master@{#653204} .../arc/intent_helper/arc_settings_service.cc | 11 ++++++ .../intent_helper/arc_settings_service_unittest.cc | 40 ++++++++++++++++++++++ 2 files changed, 51 insertions(+) commit a8a0270e8a44183f9c539f3a8cc1c1008ac2b491 Author: Katie D <katie@chromium.org> Date: Tue Apr 23 16:27:02 2019 +0000 Scrolling the mouse wheel cancels an automatic click. This makes the behavior the same between scrolling the mousewheel and scrolling with the touchpad. After a scroll and automatic click does not begin right away; the user must move the mouse again to begin a click. Bug: 951172 Change-Id: Iea3feaf342f0bddaa250361ec7715e8db6d739ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576512 Reviewed-by: Anastasia Helfinstein <anastasi@google.com> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#653203} ash/autoclick/autoclick_controller.cc | 11 ++--------- ash/autoclick/autoclick_unittest.cc | 6 ++++++ 2 files changed, 8 insertions(+), 9 deletions(-) commit 5410cd11b02793435a6db6a3d40950cf89c566ff Author: Sky Malice <skym@chromium.org> Date: Tue Apr 23 16:25:59 2019 +0000 [Touchless] Reduce horizontal margin. Bug: 937446 Change-Id: I76cd5f5eefaf7950d64dce29b746006bcdc645ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579119 Reviewed-by: Justin DeWitt <dewittj@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#653202} chrome/android/touchless/java/res/values-v17/dimens.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 3d86375c7090efedf6ce7cb5aa55f993db8f58b9 Author: Miguel Casas-Sanchez <mcasas@chromium.org> Date: Tue Apr 23 16:25:55 2019 +0000 Add decode-delay output to WebRTC display perf test This CL adds parsing of chrome:webrtc-internals to get the webrtc video decode latency to WebRtcVideoDisplayPerfBrowserTest. Said parsing is a bit cumbersome because the internals produce a pretty large JSON, that needs to be parsed until finding recv-googMaxDecodeMs, which for more fun, is a vector in string form. Bug: 950183 Change-Id: I035cee0a3533141f092bb734300b39e9a84ece2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575582 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#653201} .../webrtc_video_display_perf_browsertest.cc | 79 ++++++++++++++++++++-- 1 file changed, 75 insertions(+), 4 deletions(-) commit fa6e35c53edff601993c8af6190ad2acbb2e0b0f Author: Becca Hughes <beccahughes@chromium.org> Date: Tue Apr 23 16:24:44 2019 +0000 [Media Notification] Enable on trunk Enable the media notification on trunk since our intention is to ship this in M76. BUG=942567 Change-Id: I64b4c9ac977ee3e9931fde03212638f45dd20d4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576169 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#653200} ash/public/cpp/ash_features.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit e415358836be89b0376d4bcdb08f4e523b6cd8d9 Author: Gauthier Ambard <gambard@chromium.org> Date: Tue Apr 23 16:24:22 2019 +0000 [iOS] Fix toolbar separator on NTP rotation This CL makes sure that the separator below the toolbar is correctly handled when rotating on landscape. Bug: 954906 Change-Id: I07f5492139eabb4a71a0dc26abee1050900698df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578552 Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#653199} .../ui/content_suggestions/content_suggestions_header_view.mm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) commit 3f76345f0dd6d7670d37c84781f6cad27829ed40 Author: Mike Wittman <wittman@chromium.org> Date: Tue Apr 23 16:23:12 2019 +0000 [Sampling profiler] Split out test unwind scenario setup Moves the setup for the test unwind scenario from the TargetThread into a separate UnwindScenario class. Changes the unwind scenario to be configured using callbacks rather than plain function pointers, to provide the flexibility that will be required to inject a custom setup function for V8 unwinds. While this approach has the disadvantage that it loses the ability to know the exact stack layout, it still allows frame existence and relative ordering to be checked which should be sufficient to catch failures. Bug: 909957 Change-Id: I5ddf18219becba922edcccde69bd09e1fbbd38f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577849 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#653198} base/profiler/stack_sampling_profiler_unittest.cc | 692 ++++++++++------------ 1 file changed, 304 insertions(+), 388 deletions(-) commit 870e19abe529a751412c5e054803e469a3cbecd0 Author: Matt Menke <mmenke@chromium.org> Date: Tue Apr 23 16:23:03 2019 +0000 SocketParams refactor 5: Make SocketParams no longer a callback. This CL makes SocketParams a combination of 4 values: * An annotation tag for the proxy (Which should be switched to a per-request value) * Two SSLConfigs (Which should be replaced with using global state) * An OnHostResolved() callback (Which I'm working on removing). Also, this CL has ClientSocketPools create ConnectJob params itself instead of invoking a callback owned by SocketParams. To do this, it uses those values, proxy/websocket information from each ClientSocketPool, global CommonConnectJobParams, and GroupIds. Bug: 533571 Change-Id: Ia0ae70992493708d6100411625dad28116f42518 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577484 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#653197} net/http/http_stream_factory_unittest.cc | 19 +- net/socket/client_socket_pool.cc | 103 +---- net/socket/client_socket_pool.h | 57 ++- net/socket/client_socket_pool_base_unittest.cc | 39 +- net/socket/client_socket_pool_manager.cc | 134 +----- net/socket/connect_job.cc | 91 ++++ net/socket/connect_job.h | 29 ++ .../transport_client_socket_pool_unittest.cc | 485 +++++++++------------ net/socket/transport_connect_job.h | 5 +- ...socket_transport_client_socket_pool_unittest.cc | 46 +- net/spdy/spdy_session_unittest.cc | 15 +- net/spdy/spdy_test_util_common.cc | 20 +- .../websocket_basic_stream_adapters_test.cc | 29 +- 13 files changed, 480 insertions(+), 592 deletions(-) commit c59799098f941381e43a18f99e2ead58f0f1e3ce Author: Suman Kancherla <sumankancherla@chromium.org> Date: Tue Apr 23 16:22:04 2019 +0000 [xr] Assign created display media device to a variable to keep it alive A device returned by navigator.mediaDevices.getDisplayMedia() seems to be immediately garbage collected leading to the symptoms described in the associated bug. Hence, this change assigns the device to an arbitrary member of the window object. Bug: 954403 Change-Id: I9a4be13da02fce881fe191c340b782af5050aefd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575024 Commit-Queue: Suman Kancherla <sumankancherla@chromium.org> Reviewed-by: Klaus Weidner <klausw@chromium.org> Reviewed-by: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#653196} .../webxr_test_pages/webxr-samples/tests/permission-request.html | 5 +++++ 1 file changed, 5 insertions(+) commit 218c5c15d2ee705f38a747371a7e9bed4261a8d9 Author: Emil A Eklund <eae@chromium.org> Date: Tue Apr 23 16:21:50 2019 +0000 Rebase fast/text/letter-spacing-negative-opacity.html Bug: 955165 Tbr: chcunningham@chromium.org Change-Id: I11fe20ef4d7eb32a494f86c07279b133d09e535a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578098 Reviewed-by: Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#653195} third_party/blink/web_tests/TestExpectations | 1 - .../letter-spacing-negative-opacity-expected.png | Bin 13367 -> 13356 bytes .../letter-spacing-negative-opacity-expected.png | Bin 13314 -> 13301 bytes .../letter-spacing-negative-opacity-expected.png | Bin 13324 -> 13311 bytes 4 files changed, 1 deletion(-) commit 3f2995bf9ecc51254bac6a865d4356cf48c85863 Author: Allen Bauer <kylixrd@chromium.org> Date: Tue Apr 23 16:18:03 2019 +0000 Removed View::OnEnabledChanged() and refactored to use enabled changed callback. Bug: 938501 Change-Id: I2b15292f28c2479f8aec7f1140b1d27c96daac7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512140 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#653194} .../shortcut_viewer/views/ksv_search_box_view.h | 5 ---- ash/login/ui/login_pin_view.cc | 19 +++++++++----- ash/system/tray/hover_highlight_view.cc | 10 ++++---- ash/system/tray/hover_highlight_view.h | 8 +++++- ash/system/unified/collapse_button.cc | 15 +++++------ ash/system/unified/collapse_button.h | 8 +++++- ash/system/unified/feature_pod_button.cc | 22 ++++++++-------- ash/system/unified/feature_pod_button.h | 16 ++++++++++-- .../views/media_router/cast_dialog_sink_button.cc | 1 - .../views/media_router/cast_dialog_sink_button.h | 8 +++++- ui/chromeos/search_box/search_box_view_base.h | 25 +++++++++++------- ui/views/controls/button/button.cc | 30 ++++++++++------------ ui/views/controls/button/button.h | 8 +++++- ui/views/controls/button/label_button_label.cc | 7 +++-- ui/views/controls/button/label_button_label.h | 7 ++++- ui/views/controls/textfield/textfield.cc | 13 ++++------ ui/views/controls/textfield/textfield.h | 10 +++++++- ui/views/view.cc | 7 ----- ui/views/view.h | 4 --- 19 files changed, 129 insertions(+), 94 deletions(-) commit 7f0c9032c2758127082ebbd5a8c0b4c60a221085 Author: Nicolas Ouellet-payeur <nicolaso@chromium.org> Date: Tue Apr 23 16:16:28 2019 +0000 [Annotations] Use win-annotator-rel to update spreadsheet Previously, the Network Annotations spreadsheet was updated by the linux-annotator-rel buildbot. This CL changes it to update on the win-annotator-rel buildbot instead. Bug: 878759 Change-Id: I8a17f5c14df78016541eb219ab7902f5bdbe8447 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553588 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#653193} testing/scripts/test_traffic_annotation_auditor.py | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) commit f869305e7fb1645a2ca88a22a4824660ddf1a31f Author: Anders Hartvoll Ruud <andruud@chromium.org> Date: Tue Apr 23 16:15:21 2019 +0000 [css-variables] Handle CSS-wide keywords on resolved var()-values. CSSPropertyParser::ParseSingleValue, which is used directly from CSSVariableResolver, didn't handle CSS-wide values at all. It probably _seems_ to work sometimes, because a resolved token sequence that doesn't parse for a given property will result in a value of "unset". This means that e.g. "color: var(--unknown, inherit)" will appear to work, because "inherit" won't parse for "color", resulting in "unset", which happens to mean "inherit" for "color". (Similarly for "initial" and non- inherited properties). BUG=954963 R=futhark@chromium.org,emilio@chromium.org Change-Id: I5555dfdc756220feb84fb9dc173b16e3bc4c69ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576574 Reviewed-by: Emilio Cobos Álvarez <emilio@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#653192} .../blink/renderer/core/css/css_inherited_value.h | 2 +- .../blink/renderer/core/css/css_unset_value.h | 2 +- .../core/css/parser/css_property_parser.cc | 42 ++++++++---- .../css/resolver/css_variable_resolver_test.cc | 76 ++++++++++++++++++++++ 4 files changed, 109 insertions(+), 13 deletions(-) commit bb460bf79ee4036c4f288acf3ab6669ef6c0deb8 Author: Guido Urdaneta <guidou@chromium.org> Date: Tue Apr 23 16:13:01 2019 +0000 [MediaRecorder] Resume WebmMuxer only if not null There are some cases in which the muxer is null, which lead to crashes. Bug: 954494 Change-Id: I571d54d56c71d7a674054979a441e6645bc5ac3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578614 Reviewed-by: Miguel Casas <mcasas@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#653191} content/renderer/media_recorder/media_recorder_handler.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit e43d3b222bbc69bb30f0295e1afe558d41f6bb76 Author: Livvie Lin <livvielin@chromium.org> Date: Tue Apr 23 16:11:57 2019 +0000 [DevTools] Add security state to main origin header in sidebar Picking the simplest change for now to solve the slightly odd labeling issue, and we can re-evaluate later if we want to do a larger update. Screenshot: https://drive.google.com/file/d/1ald5fs_hWjAvr1FsYSUJivW2rYDZ2l-A/view?usp=sharing Bug: 567380 Change-Id: I544d0efffb3548a175e3e9b9e0d5409953ec6f9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578065 Reviewed-by: Erik Luo <luoe@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#653190} .../renderer/devtools/front_end/security/SecurityPanel.js | 12 +++++++++--- ...main-origin-assigned-despite-request-missing-expected.txt | 2 +- 2 files changed, 10 insertions(+), 4 deletions(-) commit f5c849297c5787459622aca00634e98d3fe22e85 Author: Becca Hughes <beccahughes@chromium.org> Date: Tue Apr 23 16:08:10 2019 +0000 [Media Notification] Hide on lock screen Add a notification blocker to block media notifications so that they are not shown on the lock screen. BUG=897836 Change-Id: Iae5366eb905d9e6d3dc4ce7cfbadc28669b3b595 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577492 Reviewed-by: Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#653189} ash/media/media_notification_controller.cc | 67 +++++++++++++++++++++- ash/media/media_notification_controller.h | 6 ++ .../media_notification_controller_unittest.cc | 50 ++++++++++++++++ 3 files changed, 122 insertions(+), 1 deletion(-) commit 4195ba67ca066b6f0ac0fa916869a4c94d4d971d Author: Varun Khaneja <vakh@chromium.org> Date: Tue Apr 23 16:06:01 2019 +0000 Add kCaptureSafetyNetId to chrome://safe-browsing R=drubery Bug: 954255 Change-Id: Ia197947e65574de5d4f941803c30e74eb9b2b19d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577865 Auto-Submit: Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#653188} components/safe_browsing/features.cc | 1 + 1 file changed, 1 insertion(+) commit 056b935777d5f8b1914b27fedc243207c47ad443 Author: danakj <danakj@chromium.org> Date: Tue Apr 23 16:04:45 2019 +0000 Convert Callbacks to OnceCallbacks for errors in BluetoothGattDescriptor This will allow us to convert more Callbacks in the bluetooth component over to OnceCallbacks, which will let us convert Callbacks in content eventually. R=reillyg@chromium.org Bug: 953861 Change-Id: Iaca0042c4b2ed5559a70c2136f20881546673406 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574429 Auto-Submit: danakj <danakj@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#653187} .../bluetooth_low_energy_apitest.cc | 10 ++-- .../web_test_bluetooth_adapter_provider.cc | 46 ++++++++------- device/bluetooth/bluetooth_gatt_descriptor.h | 4 +- .../bluetooth/bluetooth_remote_gatt_descriptor.h | 4 +- .../bluetooth_remote_gatt_descriptor_android.cc | 30 +++++----- .../bluetooth_remote_gatt_descriptor_android.h | 4 +- .../bluetooth_remote_gatt_descriptor_mac.h | 4 +- .../bluetooth_remote_gatt_descriptor_mac.mm | 26 ++++----- .../bluetooth_remote_gatt_descriptor_win.cc | 10 ++-- .../bluetooth_remote_gatt_descriptor_win.h | 4 +- .../bluetooth_remote_gatt_descriptor_winrt.cc | 66 +++++++++++----------- .../bluetooth_remote_gatt_descriptor_winrt.h | 4 +- .../bluez/bluetooth_gatt_descriptor_bluez.h | 2 +- .../bluetooth_remote_gatt_descriptor_bluez.cc | 20 ++++--- .../bluez/bluetooth_remote_gatt_descriptor_bluez.h | 6 +- .../cast/bluetooth_remote_gatt_descriptor_cast.cc | 21 +++---- .../cast/bluetooth_remote_gatt_descriptor_cast.h | 10 ++-- .../dbus/bluetooth_gatt_descriptor_client.cc | 19 ++++--- .../dbus/bluetooth_gatt_descriptor_client.h | 9 +-- .../dbus/fake_bluetooth_gatt_descriptor_client.cc | 15 ++--- .../dbus/fake_bluetooth_gatt_descriptor_client.h | 4 +- .../bluetooth/test/fake_remote_gatt_descriptor.cc | 26 +++++---- .../bluetooth/test/fake_remote_gatt_descriptor.h | 8 +-- device/bluetooth/test/mock_bluetooth_device.cc | 6 +- device/bluetooth/test/mock_bluetooth_device.h | 4 +- .../test/mock_bluetooth_gatt_descriptor.h | 16 ++++-- .../api/bluetooth/bluetooth_private_apitest.cc | 2 +- .../bluetooth_socket/bluetooth_socket_apitest.cc | 6 +- 28 files changed, 200 insertions(+), 186 deletions(-) commit 7070e990cfd82f9380911d4a9629aff4477c9c88 Author: Egor Pasko <pasko@chromium.org> Date: Tue Apr 23 15:58:46 2019 +0000 android: disable one SyncCustomizationFragmentTest SyncCustomizationFragmentTest#testPaymentsIntegrationCheckboxClearsServerAutofillCreditCards is flaky. Let's disable. TBR=nyquist@chromium.org Bug: 955490 Change-Id: I0e676cfe5c8f70a740788002be538c78c74075a7 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578617 Reviewed-by: Egor Pasko <pasko@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#653186} .../chromium/chrome/browser/sync/SyncCustomizationFragmentTest.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit c4ff0ffd69fe03b3a235cff26536926cea449394 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Apr 23 15:58:36 2019 +0000 Roll src/third_party/chromite 13cb24c76e7e..776c917fd501 (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/13cb24c76e7e..776c917fd501 git log 13cb24c76e7e..776c917fd501 --date=short --no-merges --format='%ad %ae %s' 2019-04-23 dhanyaganesh@chromium.org buildbucket_v2: Add metadata_url data to Buildbucket Created with: gclient setdep -r src/third_party/chromite@776c917fd501 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I263af3a920ac04fc9b98feb7a804ad24e7d07bcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578433 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653185} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 12a07c997be53e24b5988705aac3121c11bed70b Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Apr 23 15:54:09 2019 +0000 Roll src/third_party/SPIRV-Tools/src 7aad9653f9a3..07c4dd4b9ecb (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/7aad9653f9a3..07c4dd4b9ecb git log 7aad9653f9a3..07c4dd4b9ecb --date=short --no-merges --format='%ad %ae %s' 2019-04-23 33432579+alan-baker@users.noreply.github.com Reduce runtime of array layout checks (#2534) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@07c4dd4b9ecb The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ic0d51eaf3d94f66138056756c453a3740bdbd990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578432 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653184} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 2d369ceb5845a02449e4f21cd6caa62b0d2df0cd Author: Camille Lamy <clamy@chromium.org> Date: Tue Apr 23 15:53:40 2019 +0000 Convert content_unittests to using NavigationSimulator This CL converts some more content_unittests to using NavigationSimulator. This is needed to enforce having a proper NavigationRequest at commit time. Bug: 728571 Change-Id: I12d445f4bb4bbe3929049e92f8c7074cc9d753ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535886 Commit-Queue: Camille Lamy <clamy@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#653183} .../navigation_controller_impl_unittest.cc | 29 +++--------- .../web_contents/web_contents_impl_unittest.cc | 51 ++++++++-------------- 2 files changed, 24 insertions(+), 56 deletions(-) commit 1febad91405ce542c41b8ddc4cb393900a3fe95c Author: Yutaka Hirano <yhirano@chromium.org> Date: Tue Apr 23 15:52:15 2019 +0000 Remove "WritableFiles" runtime enabled flag Removing a flag added accidentally at https://crrev.com/fb8ff28be837c61b79916d1bc79399b0fe51188b. Bug: None Change-Id: I9e9ec74930849f94c94d52c28e610d337c23332e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578725 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#653182} third_party/blink/renderer/platform/runtime_enabled_features.json5 | 4 ---- 1 file changed, 4 deletions(-) commit 0fcda219673ce241447009b42bf8a9dd26cd79b2 Author: Gauthier Ambard <gambard@chromium.org> Date: Tue Apr 23 15:43:51 2019 +0000 [iOS] Delete ios/chrome/browser/ui target This CL removes the target. Bug: 944008 Change-Id: Ie2239d585e6da86d444595839f00aaa8c2f692b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578545 Reviewed-by: Justin Cohen <justincohen@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#653181} ios/chrome/browser/providers/signin/BUILD.gn | 2 +- ios/chrome/browser/ui/BUILD.gn | 90 --------------------------- ios/chrome/test/data/testbadpass.pkpass | 1 - ios/chrome/test/data/testpass.pkpass | Bin 28280 -> 0 bytes 4 files changed, 1 insertion(+), 92 deletions(-) commit f05c2119db8a638612f5d07cb74734c71429a619 Author: Jan Krcal <jkrcal@chromium.org> Date: Tue Apr 23 15:31:32 2019 +0000 Revert "[AF Wallet Metadata] Enable USS implementation by default" This reverts commit 6560bcb5fd490a5bb689e61ca64a12d1fd8ce0b5. Reason for revert: this CL seems to have made some integration tests very flaky Original change's description: > [AF Wallet Metadata] Enable USS implementation by default > > This CL adds a testing config to prepare for a Beta launch. > > Bug: 853688 > Change-Id: I2e6f99a7d9bbf5aa7bc268e74c53f3af135837f8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569931 > Reviewed-by: Brian White <bcwhite@chromium.org> > Commit-Queue: Jan Krcal <jkrcal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#653113} TBR=bcwhite@chromium.org,jkrcal@chromium.org Change-Id: I2ba569cdeac18bf03b1e721207ed1dab79698054 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 853688 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578615 Reviewed-by: Jan Krcal <jkrcal@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#653180} testing/variations/fieldtrial_testing_config.json | 20 -------------------- 1 file changed, 20 deletions(-) commit 3b6ae2b824178685fed9450a280c99a45dd57d63 Author: Dominick Ng <dominickn@chromium.org> Date: Tue Apr 23 15:21:10 2019 +0000 Add {peconn,peter}@chromium.org to Android webapps OWNERs. The TWA team is going to start taking more responsibility for the Android-side PWA front-end implementation. BUG=None. Change-Id: I57475d5c65fc1d8fe5ebd63677a1c01a18b2eb42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578140 Reviewed-by: Peter Conn <peconn@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#653179} chrome/android/java/src/org/chromium/chrome/browser/webapps/OWNERS | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) commit 8aa2edb10e67303b0538bdf641d5c73ac8d1d7d3 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Tue Apr 23 15:10:08 2019 +0000 flags: assign per-method-can-make-payment-quota Bug: None Change-Id: Ifc240dcb90254175232eb4377a669f40dd049512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578941 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#653178} chrome/browser/flag-metadata.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 6ae62a9a7c0e8da5105ca73d6d01466c1d869c4a Author: Benoit L <lizeb@chromium.org> Date: Tue Apr 23 15:05:26 2019 +0000 Reland "blink/bindings: Check that decompression is correct, and add UTF-16 testing." This reverts commit 9bdce258ade342f621d1f7f7b48412607c88dbb4. Reason for reland: Fixed the test failure issue in https://chromium-review.googlesource.com/c/chromium/src/+/1577423 Original change's description: > Revert "blink/bindings: Check that decompression is correct, and add UTF-16 testing." > > This reverts commit 8ca571cb6ddefcc76906bffa17fd1159709a5de5. > > Reason for revert: This change caused blink_platform_unittests failing on multiple builders > > sample build: > https://analysis.chromium.org/waterfall/failure?url=https://ci.chromium.org/p/chromium/builders/ci/Win%207%20Tests%20x64%20%281%29/52324 > > Original change's description: > > blink/bindings: Check that decompression is correct, and add UTF-16 testing. > > > > There are crashes in ParkableString decompression, which are assumed to be OOM > > conditions. Add a check to make sure this is the case, and add testing for UTF16 > > strings to make sure that this doesn't instead come from such strings. > > > > Bug: 946203 > > Change-Id: Iaafde8c3c7b9c79bf87de67e6c5de5b71e1a310a > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575499 > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Commit-Queue: Benoit L <lizeb@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#652513} > > TBR=haraken@chromium.org,lizeb@chromium.org > > Change-Id: Id697c7df2b13d7ff8a40e68a80b3189600f781c4 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 946203 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574286 > Reviewed-by: Chan Li <chanli@chromium.org> > Commit-Queue: Chan Li <chanli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#652547} TBR=haraken@chromium.org,lizeb@chromium.org,chanli@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 946203 Change-Id: If03319ed1c94c66e38f8e6e3523edcc080de1865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578604 Reviewed-by: Benoit L <lizeb@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#653177} .../renderer/platform/bindings/parkable_string.cc | 11 +++++--- .../platform/bindings/parkable_string_test.cc | 30 ++++++++++++++++++++++ 2 files changed, 37 insertions(+), 4 deletions(-) commit d784fe663434989e844f1bd0ed234845e7e59fb5 Author: Oleh Lamzin <lamzin@google.com> Date: Tue Apr 23 15:00:18 2019 +0000 Roll src/third_party/cros_system_api/ a2b1d7545..3a78fde2f (5 commits) https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/a2b1d754558c..3a78fde2f314 $ git log a2b1d7545..3a78fde2f --date=short --no-merges --format='%ad %ae %s' 2019-04-17 jschettler arc: Add ARC Print Spooler experiment 2019-04-11 lamzin system_api, power: add new power policies 2019-04-17 benchan system_api: remove obsolete debugd constants 2019-04-17 emaxx system_api: Go proto bindings for cryptohome 2019-04-03 cmtm debugd: include journald log in feedback report Created with: roll-dep src/third_party/cros_system_api Change-Id: I054a2fa4ce421a50ade7ac0e3f9a7de8731f6803 Bug: none Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574811 Reviewed-by: Dan Erat <derat@chromium.org> Commit-Queue: Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#653176} DEPS | 2 +- chromeos/dbus/power/power_policy_controller.cc | 28 ++++++++++------------ .../dbus/power/power_policy_controller_unittest.cc | 3 +-- 3 files changed, 15 insertions(+), 18 deletions(-) commit 2383df73f7deb46ee85febba8080310a8b901007 Author: Dmitry Gozman <dgozman@chromium.org> Date: Tue Apr 23 14:51:17 2019 +0000 Migrate from RVO::Navigate to RFO::ReadyToCommitNavigation These two callbacks are called at approximately the same time, and we can use the more common one (ReadyToCommitNavigation) instead of an outlier (Navigate). This leaves a single client of RVO::Navigate, which can be removed in a follow up. ChromeRenderViewObserver can be removed as well. Bug: none Change-Id: I0e2a046f11f451c0a1e952a44a0e84236bf93c53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576012 Reviewed-by: Camille Lamy <clamy@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#653175} chrome/renderer/BUILD.gn | 2 -- chrome/renderer/chrome_content_renderer_client.cc | 5 +-- chrome/renderer/chrome_render_frame_observer.cc | 12 +++++-- chrome/renderer/chrome_render_frame_observer.h | 9 ++++- chrome/renderer/chrome_render_view_observer.cc | 27 -------------- chrome/renderer/chrome_render_view_observer.h | 43 ----------------------- 6 files changed, 19 insertions(+), 79 deletions(-) commit daf5197ead07dbc3fb01cd4391710643b1c8c8eb Author: Friedrich Horschig <fhorschig@chromium.org> Date: Tue Apr 23 14:45:48 2019 +0000 [Mfill Android] Ensure hiding the sheet trigggers relayouting When a keyboard disappears, the compositor waits for a relayout as a signal to proceed with a closed keyboard. With https://crrev.com/c/1503574, this was removed and caused tasks that were deferred to be executed when the next relayouting happened - see linked bug for an example. Bug: 954125 Change-Id: I925cb2b0f4e6fab7158bf7eb16348116e5c09b1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578611 Reviewed-by: Ioana Pandele <ioanap@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#653174} .../browser/autofill/keyboard_accessory/ManualFillingMediator.java | 3 +++ .../autofill/keyboard_accessory/ManualFillingControllerTest.java | 6 ++++++ 2 files changed, 9 insertions(+) commit dd80deebf7337ea86234a5f14ea6f35fbbb131f8 Author: Marcelo Almeida <marcelocra@chromium.org> Date: Tue Apr 23 14:44:57 2019 +0000 Extract code that is common to status collectors Currently this change is a no-op, but it is possible that we need to change it. Bug: 827386 Change-Id: I2afc355bdc646cf0136b3d00a9a3d7d46cdaf3a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558024 Reviewed-by: Aga Wronska <agawronska@chromium.org> Reviewed-by: Denis Kuznetsov <antrim@chromium.org> Reviewed-by: Henrique Grandinetti <hgrandinetti@chromium.org> Reviewed-by: Lutz Justen <ljusten@chromium.org> Commit-Queue: Marcelo Almeida <marcelocra@chromium.org> Cr-Commit-Position: refs/heads/master@{#653173} chrome/browser/chromeos/BUILD.gn | 4 + .../policy/status_collector/activity_storage.cc | 251 ++++++++++++ .../policy/status_collector/activity_storage.h | 115 ++++++ .../status_collector/device_status_collector.cc | 440 +++------------------ .../status_collector/device_status_collector.h | 35 +- .../status_collector/status_collector_state.cc | 28 ++ .../status_collector/status_collector_state.h | 54 +++ .../chromeos/policy/status_uploader_unittest.cc | 2 + 8 files changed, 514 insertions(+), 415 deletions(-) commit 9b95cd585b1d119da5eca4c39c04148b1d6faab9 Author: Robert Ogden <robertogden@chromium.org> Date: Tue Apr 23 14:43:58 2019 +0000 Add Offline Page Observer to Optimize Triggering of Offline Previews This CL adds a simple dictionary pref that keeps track of the available offline pages to help reduce the number of false positives when triggering offline previews. This logic is behind a feature flag. What's missing: * Logic to bootstrap the pref with all available pages * Offline previews triggering on redirect * Browser test Bug: 914577 Change-Id: I3f5f449a4dc49090a4b5e390a99f149ba8f6d1ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553102 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Dominic Battré <battre@chromium.org> Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#653172} chrome/browser/BUILD.gn | 2 + chrome/browser/prefs/browser_prefs.cc | 2 + chrome/browser/previews/previews_content_util.cc | 26 ++- chrome/browser/previews/previews_offline_helper.cc | 208 ++++++++++++++++++++ chrome/browser/previews/previews_offline_helper.h | 73 +++++++ .../previews/previews_offline_helper_unittest.cc | 218 +++++++++++++++++++++ chrome/browser/previews/previews_service.cc | 9 +- chrome/browser/previews/previews_service.h | 9 + chrome/test/BUILD.gn | 1 + components/previews/core/previews_features.cc | 6 + components/previews/core/previews_features.h | 1 + 11 files changed, 550 insertions(+), 5 deletions(-) commit fd4eaf45f5aa8198d1b065fdc262b66550d57332 Author: Robert Flack <flackr@chromium.org> Date: Tue Apr 23 14:40:37 2019 +0000 Revert "Fix flaky chrome://webrtc-internals stats reporting bug." This reverts commit a7c927104736bea0fea348aef0b402c92c1d9c8a. Reason for revert: This appears to have broken content_browsertests, failure here: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests/77190 Sample output: [ RUN ] WebRtcInternalsBrowserTest.BweCompoundGraph Xlib: extension "RANDR" missing on display ":107". DevTools listening on ws://127.0.0.1:43262/devtools/browser/38596d5e-bce2-4f71-b1d3-3d8e63d6e250 ../../content/browser/webrtc/webrtc_internals_browsertest.cc:219: Failure Value of: result Actual: false Expected: true Stack trace: #0 0x55905678adff StackTraceGetter::CurrentStackTrace() #1 0x5590567942fc testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop() #2 0x559056793c49 testing::internal::AssertHelper::operator=() #3 0x559055ef1064 content::WebRtcInternalsBrowserTest::VerifyElementWithId() #4 0x559055ef186e content::WebRtcInternalsBrowserTest::VerifyStatsTable() #5 0x559055ee8030 content::WebRtcInternalsBrowserTest::ExecuteAndVerifyAddStats() #6 0x559055ee9482 content::WebRtcInternalsBrowserTest_BweCompoundGraph_Test::RunTestOnMainThread() #7 0x559057b8a851 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #8 0x559057becee5 content::ShellBrowserMainParts::PreMainMessageLoopRun() #9 0x559057538def content::BrowserMainLoop::PreMainMessageLoopRun() #10 0x5590578f5017 content::StartupTaskRunner::RunAllTasksNow() #11 0x559057537a08 content::BrowserMainLoop::CreateStartupTasks() #12 0x55905753ac82 content::BrowserMainRunnerImpl::Initialize() #13 0x559057be9976 ShellBrowserMain() #14 0x559057be5fd9 content::ShellMainDelegate::RunProcess() #15 0x559057448efd content::ContentMainRunnerImpl::RunServiceManager() #16 0x559057448bc6 content::ContentMainRunnerImpl::Run() #17 0x5590593dc10b service_manager::Main() #18 0x559056920b71 content::ContentMain() ../../content/browser/webrtc/webrtc_internals_browsertest.cc:219: Failure Value of: result Actual: false Expected: true Stack trace: #0 0x55905678adff StackTraceGetter::CurrentStackTrace() #1 0x5590567942fc testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop() #2 0x559056793c49 testing::internal::AssertHelper::operator=() #3 0x559055ef1064 content::WebRtcInternalsBrowserTest::VerifyElementWithId() #4 0x559055ef1a4c content::WebRtcInternalsBrowserTest::VerifyStatsTableRow() #5 0x559055ef1893 content::WebRtcInternalsBrowserTest::VerifyStatsTable() #6 0x559055ee8030 content::WebRtcInternalsBrowserTest::ExecuteAndVerifyAddStats() #7 0x559055ee9482 content::WebRtcInternalsBrowserTest_BweCompoundGraph_Test::RunTestOnMainThread() #8 0x559057b8a851 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #9 0x559057becee5 content::ShellBrowserMainParts::PreMainMessageLoopRun() #10 0x559057538def content::BrowserMainLoop::PreMainMessageLoopRun() #11 0x5590578f5017 content::StartupTaskRunner::RunAllTasksNow() #12 0x559057537a08 content::BrowserMainLoop::CreateStartupTasks() #13 0x55905753ac82 content::BrowserMainRunnerImpl::Initialize() #14 0x559057be9976 ShellBrowserMain() #15 0x559057be5fd9 content::ShellMainDelegate::RunProcess() #16 0x559057448efd content::ContentMainRunnerImpl::RunServiceManager() #17 0x559057448bc6 content::ContentMainRunnerImpl::Run() #18 0x5590593dc10b service_manager::Main() #19 0x559056920b71 content::ContentMain() Please avoid using NOTRY=true unless necessary as it can result in unexpected breakages like this. Original change's description: > Fix flaky chrome://webrtc-internals stats reporting bug. > > A timer polls stats regularly, using standard or legacy stats as > specified in a UI. Which stats to use can change while a pending request > is in progress. This CL adds a check to discard legacy stats that are > given to JS if we are not currently expecting legacy stats. > This is something we were already doing for addStandardStats() but had > forgotten to add to addLegacyStats(). The bug was only apparent every > now and then depending on timing. > > Drive-by: Rename "nukeStatsList" to "clearStatsList" > > NOTRY=True > > Bug: 803014 > Change-Id: I5323d58f25792c2b34f2432fe1e8482008db1f39 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578608 > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Commit-Queue: Henrik Boström <hbos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#653146} TBR=hbos@chromium.org,guidou@chromium.org Change-Id: I7d2f36c3482366d9de784365e5198d027aa9a010 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 803014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576330 Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#653171} content/browser/resources/media/stats_table.js | 2 +- content/browser/resources/media/webrtc_internals.js | 5 +---- 2 files changed, 2 insertions(+), 5 deletions(-) commit e92b514d29abc86de9b6390c47949b6efcea37a2 Author: Egor Pasko <pasko@chromium.org> Date: Tue Apr 23 14:39:05 2019 +0000 android: disable WebXrArSessionTest Reason: fails consistently on hromium.android/android-pie-arm64-dbg Bug: 955447 Change-Id: I51eda762ef992c95688e72fb830a85e24b224d1b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578748 Reviewed-by: Egor Pasko <pasko@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#653170} .../src/org/chromium/chrome/browser/vr/WebXrArSessionTest.java | 2 ++ 1 file changed, 2 insertions(+) commit 3fc113f26b5d2c4944ead8aa290e4f8c532c5768 Author: Ovidio Henriquez <odejesush@chromium.org> Date: Tue Apr 23 14:37:10 2019 +0000 Use Value in ChooserContextBase This change refactors ChooserContextBase, its subclasses, and uses of the class to use base::Value instead of base::DictionaryValue. Bug: 920288 Change-Id: I53fc103fbcd38045ed23ce23b07a45fbbec32553 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575038 Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#653169} .../preferences/website_preference_bridge.cc | 18 ++- chrome/browser/permissions/chooser_context_base.cc | 107 +++++++------- chrome/browser/permissions/chooser_context_base.h | 23 ++- .../permissions/chooser_context_base_unittest.cc | 50 ++++--- chrome/browser/serial/serial_chooser_context.cc | 42 +++--- chrome/browser/serial/serial_chooser_context.h | 10 +- chrome/browser/ui/page_info/page_info.cc | 8 +- chrome/browser/ui/page_info/page_info.h | 4 +- chrome/browser/ui/page_info/page_info_ui.cc | 6 +- .../ui/webui/settings/site_settings_handler.cc | 12 +- .../settings/site_settings_handler_unittest.cc | 49 ++++--- chrome/browser/ui/webui/site_settings_helper.cc | 52 +++---- chrome/browser/ui/webui/site_settings_helper.h | 6 +- .../ui/webui/site_settings_helper_unittest.cc | 26 ++-- chrome/browser/usb/usb_chooser_context.cc | 160 ++++++++++----------- chrome/browser/usb/usb_chooser_context.h | 10 +- chrome/browser/usb/usb_chooser_context_unittest.cc | 71 +++++---- 17 files changed, 338 insertions(+), 316 deletions(-) commit 8632b589d56a1e0ee6105eee226d64a058ed999a Author: Richard Knoll <knollr@chromium.org> Date: Tue Apr 23 14:35:30 2019 +0000 NotificationMD: Hide timestamp and expand button in settings. This hides the timestamp and expand button from the notification header if we are in the inline settings, as they do not have much value and just waste space. Bug: 955410 Change-Id: I3a019e68021c619fe926d4a683c42a9f2797cb02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565001 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#653168} .../views/notification_header_view.cc | 37 +++++++++++++++------- ui/message_center/views/notification_header_view.h | 7 ++-- ui/message_center/views/notification_view_md.cc | 5 +++ 3 files changed, 36 insertions(+), 13 deletions(-) commit d392d03229bc6cf96078529822ae60479951ef4b Author: Sylvain Defresne <sdefresne@chromium.org> Date: Tue Apr 23 14:33:57 2019 +0000 Remove method -postNotificationOnNextRunLoopCycle: The method -[MainController postNotificationOnNextRunLoopCycle:] is never called thus can be removed. Bug: none Change-Id: I708540aa7ed2233483b7657bcf2c6ae05ce8a358 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578744 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#653167} ios/chrome/app/main_controller.mm | 18 ------------------ 1 file changed, 18 deletions(-) commit 63bd6ea3fa461757a96a3f614951569cd5f31363 Author: Mike Wittman <wittman@chromium.org> Date: Tue Apr 23 14:28:37 2019 +0000 [Sampling profiler] Use self-reported function start address in unwind tests For functions to be unwound, requests the address near the start of the function from the function itself rather than using the function pointer value. This enables the use of functions on the stack to be unwound for which we can't easily obtain a function pointer (e.g. Callbacks) and eliminates the need to special case incremental linking. Bug: 909957 Change-Id: Ib08fac1bf3cca12a607af6c3a0ffd939924de443 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574291 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#653166} base/profiler/stack_sampling_profiler_unittest.cc | 166 ++++++++++------------ 1 file changed, 76 insertions(+), 90 deletions(-) commit 3e4bdb9e4cb4b377f5493b266a803c51cb4b1e9b Author: Brian Sheedy <bsheedy@chromium.org> Date: Tue Apr 23 14:27:41 2019 +0000 Switch pre-test VR usage to reflection Removes VR imports from ChromeJUnit4ClassRunner and switches VR usage in the file to reflection. This is because the required VR files are likely, but not guaranteed, to be included when building the test binary. Bug: 953842 Change-Id: If1dadbc9e6e95a4812440f3c3727fc0283b0d431 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577497 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#653165} chrome/test/android/BUILD.gn | 1 - .../chrome/test/ChromeJUnit4ClassRunner.java | 77 +++++++++++++++++----- third_party/gvr-android-sdk/BUILD.gn | 3 + 3 files changed, 63 insertions(+), 18 deletions(-) commit a747aa9cb09c55ef6528f589c45507a0f98c6d1b Author: Daniel Bratell <bratell@opera.com> Date: Tue Apr 23 14:16:25 2019 +0000 Avoid shadowing variabels in new font code I'm trying to remove variable shadowing in some Chromium code to maybe make the code a bit more robust, and two functions in blink/platform/fonts/shaping used several instances of |i|. Bug: 925310 Change-Id: I3e09f7772a7865ec7f73976a57af355070b6ad4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578538 Commit-Queue: Dominik Röttsches <drott@chromium.org> Auto-Submit: Daniel Bratell <bratell@opera.com> Reviewed-by: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#653164} third_party/blink/renderer/platform/fonts/shaping/shape_result.cc | 6 +++--- .../blink/renderer/platform/fonts/shaping/shape_result_view.cc | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) commit 25fceccfd120070d69dc0dd7392bdfc23dbb95a9 Author: Egor Pasko <pasko@chromium.org> Date: Tue Apr 23 14:11:08 2019 +0000 android: disable one ReturnToChromeTest Disabling ReturnToChromeTest.testObserverModeTriggeredWithDelay, it has been failing on a bot with KK Tablet since approximately the time when it was introduced. Bug: 955436 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ibcc0e8497019291de2d495aa7b8df93f6d73428f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578747 Reviewed-by: Egor Pasko <pasko@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#653163} .../src/org/chromium/chrome/browser/tasks/ReturnToChromeTest.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) commit 438591e52d24a133a02f5f19576b133c1a9036a3 Author: Emil A Eklund <eae@chromium.org> Date: Tue Apr 23 14:02:12 2019 +0000 Inline Character::IsEmojiKeycapBase Inline the extremely hot Character::IsEmojiKeycapBase method. Bug: 789124 Change-Id: I540b243527a330a4f9c15652efe2fd5e3c141485 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577796 Auto-Submit: Emil A Eklund <eae@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#653162} third_party/blink/renderer/platform/text/character.h | 4 +++- third_party/blink/renderer/platform/text/character_emoji.cc | 4 ---- 2 files changed, 3 insertions(+), 5 deletions(-) commit 4a21e75452085b84a0c935d91a011e00741d4726 Author: Pâris Meuleman <pmeuleman@chromium.org> Date: Tue Apr 23 13:51:52 2019 +0000 Revert "Convert away from JSONReader::ReadDeprecated in devtools/" This reverts commit e31d40d74af30c268b6adc2b5a8762dc5de20821. Reason for revert: Incorrect check see Bug: 954874 Original change's description: > Convert away from JSONReader::ReadDeprecated in devtools/ > > Use the new JSONReader::Read API that use the new API of > base::Value (move semantic) and convert the surrounding > code to the new API at the same time. > > Bug: 925165, 646113 > Change-Id: I37fadaf55cf347c69fdcfa1b53f8f01fed2fd01e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1550455 > Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#652085} TBR=caseq@chromium.org,pfeldman@chromium.org,sdefresne@chromium.org,pmeuleman@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 925165, 646113 Change-Id: Ifd8c91323bc0255ca91632fe4db3914e01ce50d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578741 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#653161} .../devtools/device/devtools_device_discovery.cc | 89 +++++++++--------- .../devtools/device/devtools_device_discovery.h | 4 +- .../devtools/device/port_forwarding_controller.cc | 94 ++++++++++--------- chrome/browser/devtools/devtools_ui_bindings.cc | 62 +++++++------ chrome/browser/devtools/devtools_window.cc | 102 +++++++++++++-------- 5 files changed, 202 insertions(+), 149 deletions(-) commit 12a834ad6070f3c1e99e5377b817cb73a4b0b12a Author: Carlos Caballero <carlscab@google.com> Date: Tue Apr 23 13:48:28 2019 +0000 Refactor browser_thread_unittest.cc No need for the complicated constructor params if all can be done in the constructor itself. Change-Id: I75db0a61665923706f7b4b2b0f3f9ee792db1123 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569906 Auto-Submit: Carlos Caballero <carlscab@google.com> Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#653160} content/browser/browser_thread_unittest.cc | 35 +++++++++++++----------------- 1 file changed, 15 insertions(+), 20 deletions(-) commit f660fb7ef2f2f606e4c4f486b4193e86f25eefef Author: tzik <tzik@chromium.org> Date: Tue Apr 23 13:47:58 2019 +0000 Drop duplicated path separater at #include Tbr: dcheng@chromium.org, falken@chromium.org, haraken@chromium.org Change-Id: I7a9e81b2a3f186d373686391d67bcbb56846245b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578150 Reviewed-by: Taiju Tsuiki <tzik@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#653159} .../interfaces/typemaps/string16_embedded_nulls_mojom_traits.h | 2 +- content/browser/worker_host/worker_script_fetch_initiator.cc | 2 +- third_party/blink/renderer/core/aom/accessible_node.cc | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) commit 492495a5cc92b64c6d1509f3b6674db097c0159b Author: Sylvain Defresne <sdefresne@chromium.org> Date: Tue Apr 23 13:40:01 2019 +0000 Modernize AuthenticationService use of base::Value API Change AuthenticationService to use the new base::Value API. This is a purely mechanical change to remove use of deprecated APIs. Bug: none Change-Id: I17ae041cab9823ea7562b29faca085629a3766d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569715 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#653158} .../browser/signin/authentication_service.mm | 32 +++++++++++----------- 1 file changed, 16 insertions(+), 16 deletions(-) commit ee89f19fe9de1e1c04ce4749c9d7d6018676161c Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Tue Apr 23 13:36:41 2019 +0000 Update V8 to version 7.6.4. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ce596cfd..ab1a9efe Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5e07dd7a880768ef138ff8d12e12e02726601af7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578425 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653157} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit cd9624cde95446e170cac41ce6f173763fa927b6 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Tue Apr 23 13:23:58 2019 +0000 Roll src-internal ca5f18c2b4e5..11c47f6e5f74 (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ca5f18c2b4e5..11c47f6e5f74 Created with: gclient setdep -r src-internal@11c47f6e5f74 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=chcunningham@chromium.org,loyso@chromium.org,clamy@chromium.org,flackr@chromium.org Change-Id: I223295b19907d30f8137b3d3ba393086be84203a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578426 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653156} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit b3b2d064bde5661bd7d2d64041d976103c66e30f Author: Victor Hugo Vianna Silva <victorvianna@google.com> Date: Tue Apr 23 13:21:05 2019 +0000 Reland "Add UMA for sync favicons in recently closed tabs menu" This is a reland of 5432d3b6be72f04ea14518bd400e3b1247124589 Original change's description: > Add UMA for sync favicons in recently closed tabs menu > > We add metrics to evaluate sync's usefulness in helping obtain favicons > for the recently closed tabs menu. > > Bug: 948109 > Change-Id: I88958d41925dc9bab93d1714a0b4e56e88b10c17 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564995 > Commit-Queue: Victor Vianna <victorvianna@google.com> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Alex Ilin <alexilin@chromium.org> > Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org> > Reviewed-by: Dan Beam <dbeam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#652119} TBR=pkasting@chromium.org TBR=pkotwicz@chromium.org TBR=alexilin@chromium.org Bug: 948109 Change-Id: If6d6822379be38a8e0b0b18a2ffd0cc5e5497c43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573622 Reviewed-by: Jan Krcal <jkrcal@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#653155} chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc | 14 +++++++++++++- components/favicon_base/favicon_request_metrics.cc | 4 ++++ components/favicon_base/favicon_request_metrics.h | 2 ++ tools/metrics/histograms/histograms.xml | 2 ++ 4 files changed, 21 insertions(+), 1 deletion(-) commit 4e479107de435a6c78d937e79450a0028dceeacc Author: David Bienvenu <davidbienvenu@chromium.org> Date: Tue Apr 23 13:18:58 2019 +0000 Revert "Load urls in a window on the current desktop, on Windows 10." This reverts commit 79de52d890429b82aa9c1f0d66d465d239a42d7b. Reason for revert: <causes test flakiness> Original change's description: > Load urls in a window on the current desktop, on Windows 10. > > When Chrome is launched with a URL on the command line, and > Chrome is already running, it looks for a browser window to load > the URL in. This CL makes it ignore browser windows that are > not on the current desktop, on Windows 10 (or higher). > > Bug: 757853 > Change-Id: Ib251619cbcef18809b886b96e21034507ea14654 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538834 > Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#652693} TBR=pkasting@chromium.org,grt@chromium.org,davidbienvenu@chromium.org Change-Id: Ib5c68c4c2d8a73e9551a4dd2f17ed1d40bf03d02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577871 Reviewed-by: David Bienvenu <davidbienvenu@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#653154} chrome/browser/ui/browser_finder.cc | 52 ---------------------- .../browser/ui/startup/startup_browser_creator.cc | 45 ++++++------------- .../browser/ui/startup/startup_browser_creator.h | 6 --- 3 files changed, 14 insertions(+), 89 deletions(-) commit 5d45bf891c2b146c83855393b06a7ca1a411309d Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Apr 23 13:08:43 2019 +0000 Roll Fuchsia SDK from 891542344871 to 891539624597 The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ibec1bac93b8d03f14713c9f51c372f61365a172e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578424 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653153} build/fuchsia/linux.sdk.sha1 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 4d0fb740271d2b82b75780ab0a1ed5e4ed6808bb Author: Gauthier Ambard <gambard@chromium.org> Date: Tue Apr 23 13:05:16 2019 +0000 [iOS] Remove ios/chrome/browser/ui deps target This CL removes the deps on the ios/c/b/ui target. It updates the target to have direct deps on what they actually need instead of relying on the public deps. Bug: 944008 Change-Id: I56b1dfe3f8fc4e1fdda30e381509c9edb7cb900c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578607 Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#653152} ios/chrome/app/BUILD.gn | 1 - ios/chrome/app/application_delegate/BUILD.gn | 2 +- ios/chrome/browser/autofill/BUILD.gn | 9 +++++---- ios/chrome/browser/context_menu/BUILD.gn | 2 +- ios/chrome/browser/device_sharing/BUILD.gn | 2 +- ios/chrome/browser/memory/BUILD.gn | 2 +- ios/chrome/browser/metrics/BUILD.gn | 8 ++++---- ios/chrome/browser/omaha/BUILD.gn | 2 +- ios/chrome/browser/passwords/BUILD.gn | 4 ++-- ios/chrome/browser/prerender/BUILD.gn | 1 - ios/chrome/browser/snapshots/BUILD.gn | 4 ++-- ios/chrome/browser/tabs/BUILD.gn | 1 - ios/chrome/browser/ui/activity_services/BUILD.gn | 4 ++-- ios/chrome/browser/ui/alert_coordinator/BUILD.gn | 5 +++-- ios/chrome/browser/ui/authentication/BUILD.gn | 3 ++- ios/chrome/browser/ui/authentication/cells/BUILD.gn | 2 +- ios/chrome/browser/ui/autofill/BUILD.gn | 6 +++--- ios/chrome/browser/ui/autofill/cells/BUILD.gn | 1 - ios/chrome/browser/ui/bookmarks/BUILD.gn | 4 ++-- ios/chrome/browser/ui/bookmarks/cells/BUILD.gn | 2 +- ios/chrome/browser/ui/bubble/BUILD.gn | 3 +-- ios/chrome/browser/ui/content_suggestions/BUILD.gn | 11 +++++------ ios/chrome/browser/ui/content_suggestions/cells/BUILD.gn | 4 ++-- ios/chrome/browser/ui/dialogs/BUILD.gn | 4 ++-- ios/chrome/browser/ui/download/BUILD.gn | 2 +- ios/chrome/browser/ui/elements/BUILD.gn | 3 ++- ios/chrome/browser/ui/find_bar/BUILD.gn | 3 ++- ios/chrome/browser/ui/first_run/BUILD.gn | 3 +-- ios/chrome/browser/ui/history/BUILD.gn | 7 ++----- ios/chrome/browser/ui/infobars/BUILD.gn | 1 - ios/chrome/browser/ui/location_bar/BUILD.gn | 2 +- ios/chrome/browser/ui/main/BUILD.gn | 1 - ios/chrome/browser/ui/ntp/BUILD.gn | 6 +++--- ios/chrome/browser/ui/omnibox/BUILD.gn | 1 - ios/chrome/browser/ui/omnibox/popup/BUILD.gn | 3 ++- ios/chrome/browser/ui/omnibox/popup/shortcuts/BUILD.gn | 2 -- ios/chrome/browser/ui/overscroll_actions/BUILD.gn | 1 - ios/chrome/browser/ui/page_info/BUILD.gn | 3 +-- ios/chrome/browser/ui/payments/BUILD.gn | 4 ++-- ios/chrome/browser/ui/payments/cells/BUILD.gn | 3 ++- ios/chrome/browser/ui/popup_menu/BUILD.gn | 1 - ios/chrome/browser/ui/popup_menu/cells/BUILD.gn | 1 - ios/chrome/browser/ui/popup_menu/public/BUILD.gn | 2 +- ios/chrome/browser/ui/print/BUILD.gn | 2 +- ios/chrome/browser/ui/qr_scanner/BUILD.gn | 2 +- ios/chrome/browser/ui/reading_list/BUILD.gn | 4 ---- ios/chrome/browser/ui/recent_tabs/BUILD.gn | 3 +-- ios/chrome/browser/ui/sad_tab/BUILD.gn | 2 +- ios/chrome/browser/ui/safe_mode/BUILD.gn | 2 +- ios/chrome/browser/ui/settings/BUILD.gn | 2 +- ios/chrome/browser/ui/settings/cells/BUILD.gn | 3 ++- ios/chrome/browser/ui/settings/cells/legacy/BUILD.gn | 3 ++- ios/chrome/browser/ui/side_swipe/BUILD.gn | 3 ++- ios/chrome/browser/ui/signin_interaction/BUILD.gn | 2 +- ios/chrome/browser/ui/static_content/BUILD.gn | 2 -- ios/chrome/browser/ui/tab_grid/BUILD.gn | 1 - ios/chrome/browser/ui/table_view/BUILD.gn | 2 +- ios/chrome/browser/ui/tabs/BUILD.gn | 6 +++--- ios/chrome/browser/ui/toolbar/BUILD.gn | 4 +--- ios/chrome/browser/ui/toolbar/buttons/BUILD.gn | 2 +- ios/chrome/browser/ui/toolbar/fullscreen/BUILD.gn | 2 +- ios/chrome/browser/ui/toolbar/keyboard_assist/BUILD.gn | 2 +- ios/chrome/browser/ui/toolbar/public/BUILD.gn | 2 +- ios/chrome/browser/ui/webui/BUILD.gn | 2 +- ios/chrome/browser/url_loading/BUILD.gn | 1 - ios/chrome/browser/web/BUILD.gn | 4 +--- ios/chrome/test/earl_grey/BUILD.gn | 4 ++-- ios/chrome/test/fakes/BUILD.gn | 1 - ios/showcase/payments/BUILD.gn | 2 +- 69 files changed, 89 insertions(+), 112 deletions(-) commit 1f06e0953d3decf141dd98a97c36801ae7ebc667 Author: Thiemo Nagel <tnagel@chromium.org> Date: Tue Apr 23 13:04:06 2019 +0000 Remove tnagel from enrollment OWNERS Bug: none Change-Id: Id2398ffdb081b1dfd4bb24640a98a1b8147fe581 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578606 Auto-Submit: Thiemo Nagel <tnagel@chromium.org> Reviewed-by: Pavol Marko <pmarko@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#653151} chrome/browser/chromeos/login/enrollment/OWNERS | 1 - 1 file changed, 1 deletion(-) commit d2546dc07676ebc7e7568473fdb8e9d28c29027c Author: Jan Krcal <jkrcal@chromium.org> Date: Tue Apr 23 12:35:57 2019 +0000 [AF Wallet Metadata] Simplify AutofillWalletMetadataSizeChecker again This CL removes now unnecessary logic to avoid nested RunLoops. The logic is not needed any more because the code does not use any run loops any more. The CL still leaves around a simplified version of the logic just to allow DCHECKs. Bug: 953152 Change-Id: I594f2b507ee3a3d0afa0fa61327ac2e506089f12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570831 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#653150} .../browser/sync/test/integration/wallet_helper.cc | 34 +++++++--------------- .../browser/sync/test/integration/wallet_helper.h | 5 +--- 2 files changed, 12 insertions(+), 27 deletions(-) commit 50588c11e073edd774c353de5a97de8d8adb6ecf Author: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Date: Tue Apr 23 12:32:27 2019 +0000 sensors: Do not show usage indicator if allowed by default and access was allowed Change the way we show the usage indicator on the desktop and follow the UX pattern settings such as cookies and images follow: if we allow by default and sensors were allowed, do not show the indicator at all. With this CL, we only show the indicator if: - We allow by default but access was blocked due to some other reason (e.g. the checks in PermissionContextBase::RequestPermission()). - We block by default but we have a site exception that allows access (so the exception can be removed). - We block by default and access was blocked (due to any reason, including any checks from PermissionContextBase::RequestPermission()), in which case we offer the option to add a site exception. Bug: 954131 Change-Id: I10cc828b56d0c37883470187e2d86bc5ebe2d841 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574806 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#653149} .../content_setting_image_model.cc | 11 ++++ .../content_setting_image_model_unittest.cc | 72 +++++++++++++++++++++- 2 files changed, 82 insertions(+), 1 deletion(-) commit 212ca0835aed2d2e93aff55e03c213920ef59f30 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Apr 23 12:31:33 2019 +0000 Roll src/third_party/perfetto 7fa9a66b28ac..8581c921caa9 (2 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/7fa9a66b28ac..8581c921caa9 git log 7fa9a66b28ac..8581c921caa9 --date=short --no-merges --format='%ad %ae %s' 2019-04-23 treehugger-gerrit@google.com Merge "Fix debug tests." 2019-04-23 treehugger-gerrit@google.com Merge "heapprofd_client: SIGABRT on timed out spinlock instead of indefinite spin" Created with: gclient setdep -r src/third_party/perfetto@8581c921caa9 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I39fbe784c42cb879b05902b029f324daf3ccaec3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578422 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653148} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 0ab027f5800e5b4a4b58323c29df66d5ef2be7ce Author: Marc Treib <treib@chromium.org> Date: Tue Apr 23 12:26:12 2019 +0000 components/sync/BUILD.gn: Clean up test_support_* targets This moves some source files into the test_support target that they belong to (e.g. from _driver to _engine or _model), and also adds a new test_support_js target. Bug: 947443 Change-Id: I09a4cbad9cedeb7c15ab871491f150f0149de417 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570830 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#653147} chrome/test/BUILD.gn | 1 + components/sync/BUILD.gn | 37 ++++++++++++++++++++++++++++--------- 2 files changed, 29 insertions(+), 9 deletions(-) commit a7c927104736bea0fea348aef0b402c92c1d9c8a Author: Henrik Boström <hbos@chromium.org> Date: Tue Apr 23 12:25:04 2019 +0000 Fix flaky chrome://webrtc-internals stats reporting bug. A timer polls stats regularly, using standard or legacy stats as specified in a UI. Which stats to use can change while a pending request is in progress. This CL adds a check to discard legacy stats that are given to JS if we are not currently expecting legacy stats. This is something we were already doing for addStandardStats() but had forgotten to add to addLegacyStats(). The bug was only apparent every now and then depending on timing. Drive-by: Rename "nukeStatsList" to "clearStatsList" NOTRY=True Bug: 803014 Change-Id: I5323d58f25792c2b34f2432fe1e8482008db1f39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578608 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#653146} content/browser/resources/media/stats_table.js | 2 +- content/browser/resources/media/webrtc_internals.js | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) commit 993f798d5ee6a98fac74627d49b32301d4f76422 Author: Abhijeet Kandalkar <abhijeet@igalia.com> Date: Tue Apr 23 12:24:22 2019 +0000 Switch blink::CDATASection and blink::CharacterData to use new downcast helpers Bug: 891908 Change-Id: Ib8ce35ef3ccfaf715ea25701acbd80cc5cbd875d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571267 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#653145} third_party/blink/renderer/core/dom/cdata_section.h | 8 +++++++- third_party/blink/renderer/core/dom/character_data.h | 6 +++++- third_party/blink/renderer/core/dom/node.cc | 4 ++-- third_party/blink/renderer/core/dom/range.cc | 12 ++++++------ .../blink/renderer/core/dom/range_boundary_point.h | 4 ++-- .../core/editing/commands/apply_style_command.cc | 4 ++-- .../blink/renderer/core/editing/editing_strategy.cc | 4 ++-- .../core/editing/markers/document_marker_controller.cc | 2 +- third_party/blink/renderer/core/editing/position.cc | 17 ++++++++--------- .../core/editing/serializers/markup_formatter.cc | 2 +- .../renderer/core/editing/testing/selection_sample.cc | 10 +++++----- .../testing/accessibility_selection_test.cc | 2 +- 12 files changed, 42 insertions(+), 33 deletions(-) commit e5ec52c84e7bf26c29c7595df075448a554bba03 Author: Peter Kasting <pkasting@chromium.org> Date: Tue Apr 23 12:20:21 2019 +0000 Remove uses of child_at() in ui/. Bug: 940135 Change-Id: Ia0f10b57fb10a5de1464c98ce01d6bee1450166b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575035 Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#653144} ui/chromeos/ime/candidate_view_unittest.cc | 4 +- .../views/message_popup_collection_unittest.cc | 4 +- ui/message_center/views/notification_view_md.cc | 2 +- ui/views/accessibility/ax_aura_obj_cache.cc | 2 +- ui/views/bubble/bubble_frame_view.cc | 2 +- ui/views/controls/menu/menu_controller.cc | 3 +- ui/views/controls/menu/menu_controller_unittest.cc | 36 +++++------ ui/views/controls/menu/menu_item_view.cc | 10 ++-- ui/views/controls/menu/menu_item_view_unittest.cc | 4 +- .../controls/menu/menu_scroll_view_container.cc | 4 +- ui/views/controls/scroll_view.cc | 2 +- ui/views/controls/styled_label_unittest.cc | 70 +++++++++++----------- ui/views/controls/tabbed_pane/tabbed_pane.cc | 2 +- .../tabbed_pane_accessibility_mac_unittest.mm | 8 +-- ui/views/debug_utils.cc | 2 +- ui/views/examples/layout_example_base.cc | 4 +- ui/views/examples/scroll_view_example.cc | 4 +- ui/views/focus/focus_search.cc | 5 +- ui/views/layout/flex_layout_unittest.cc | 14 ++--- ui/views/layout/grid_layout_unittest.cc | 6 +- .../touchui/touch_selection_menu_runner_views.cc | 2 +- ui/views/view_unittest.cc | 40 ++++++------- ui/views/widget/root_view.cc | 2 +- 23 files changed, 117 insertions(+), 115 deletions(-) commit 8aaf2b151ef92ba88df3a0acb7435c7bf39a0370 Author: Pavel Shmakov <pshmakov@google.com> Date: Tue Apr 23 12:19:02 2019 +0000 Create a TestRule for dagger module overrides If modules are overriden in @Before, dagger components may get created before the modules are overriden. This can lead to hard-to-debug test failures due to seemingly unrelated to changes in code. In this CL I add ModuleOverridesRule. It can be chained with other rules to make sure it's executed before them. Change-Id: I2952f56f2f4b1c852805e07e19774033c44d54cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565973 Reviewed-by: Peter Conn <peconn@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Cr-Commit-Position: refs/heads/master@{#653143} chrome/android/chrome_test_java_sources.gni | 1 + .../ModuleFactoryOverrides.java | 6 ++-- .../ContextualSuggestionsTest.java | 20 +++++++----- .../browser/customtabs/CustomTabActivityTest.java | 3 -- .../CustomTabsDynamicModuleNavigationTest.java | 18 ++++++---- .../CustomTabsDynamicModulePostMessageTest.java | 17 +++++++--- .../CustomTabsDynamicModuleUITest.java | 18 ++++++---- .../dependency_injection/ModuleOverridesRule.java | 38 ++++++++++++++++++++++ .../ContextualSuggestionsPreferenceTest.java | 15 +++++---- 9 files changed, 99 insertions(+), 37 deletions(-) commit aa9d0aad5501d4be4ae7c17a26ff795f22e143f3 Author: Rune Lillesveen <futhark@chromium.org> Date: Tue Apr 23 12:11:27 2019 +0000 Associate css-contain failures with the correct issue. Bug: 947733, 947730 Change-Id: I3e65769424b7d9c10c4debffe70eb7390298054a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576572 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#653142} third_party/blink/web_tests/TestExpectations | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 21cf7c49f21560023663bf484a8601ee69406c71 Author: Polina Bondarenko <pbond@google.com> Date: Tue Apr 23 12:06:57 2019 +0000 Implement reporting of 3 VPD fields in DeviceReportRequest Report 3 more VPD fields in DeviceRegisterRequest: - ethernet_mac0, - mfg_date, - doc_mac. Extract the common part of CloudPolicyClient::Register() and CloudPolicyClient::RegisterWithCertificates() into the helper method. BUG=b:124364709 TEST=unit_tests,components_unittests,local device Change-Id: If7acfb66020c56efcd7034ddd65014157b35b399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561107 Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Polina Bondarenko <pbond@chromium.org> Auto-Submit: Polina Bondarenko <pbond@chromium.org> Cr-Commit-Position: refs/heads/master@{#653141} .../chromeos/login/existing_user_controller.cc | 4 +- .../policy/device_cloud_policy_initializer.cc | 25 +++++++ .../policy/device_local_account_policy_service.cc | 5 +- .../policy/user_cloud_policy_manager_chromeos.cc | 5 +- .../enterprise_reporting_private_api.cc | 4 +- .../machine_level_user_cloud_policy_helper.cc | 10 ++- chromeos/system/statistics_provider.cc | 3 + chromeos/system/statistics_provider.h | 9 +++ .../core/common/cloud/cloud_policy_client.cc | 79 ++++++++++++---------- .../policy/core/common/cloud/cloud_policy_client.h | 29 +++++++- .../common/cloud/cloud_policy_client_unittest.cc | 15 +++- .../core/common/cloud/mock_cloud_policy_client.cc | 3 + .../core/common/cloud/user_cloud_policy_manager.cc | 4 +- .../remote_commands_service_unittest.cc | 3 + 14 files changed, 152 insertions(+), 46 deletions(-) commit 5f33950bd04421c3a50f23dd23b22bd1e3afdc63 Author: Abhijeet Kandalkar <abhijeet@igalia.com> Date: Tue Apr 23 12:04:07 2019 +0000 Switch blink::LayoutBlockFlow to use new downcast helpers (5/n) Bug: 891908 Change-Id: I8abcbef0a8be790a8c477c1e7b3c6fa1a9568f30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571265 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#653140} third_party/blink/renderer/core/editing/layout_selection.cc | 2 +- third_party/blink/renderer/core/layout/layout_block.cc | 2 +- third_party/blink/renderer/core/layout/layout_block_flow.cc | 2 +- third_party/blink/renderer/core/layout/layout_block_flow.h | 2 -- third_party/blink/renderer/core/layout/layout_block_test.cc | 3 +-- third_party/blink/renderer/core/layout/ng/ng_block_node.cc | 6 +++--- 6 files changed, 7 insertions(+), 10 deletions(-) commit d8865d502f33937f06e05119a46cb6dfe0d9c6ad Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Tue Apr 23 12:01:38 2019 +0000 Revert "[Video Capture Service] Add tests cases for mixing single client and multi client APIs" This reverts commit 07927033a8fe3ae7b492bdc598acd1d04353175c. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 652964 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMDc5MjcwMzNhOGZlM2FlN2I0OTJiZGM1OThhY2QxZDA0MzUzMTc1Yww Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Cast%20Audio%20Linux/39859 Sample Failed Step: content_browsertests Sample Flaky Test: WebRtcVideoCaptureSharedDeviceBrowserTest.ReceiveFrameInRendererWhileDeviceAlreadyInUseViaDirectServiceClient/0 Original change's description: > [Video Capture Service] Add tests cases for mixing single client and multi client APIs > > Bug: 783442 > Change-Id: I1c2c081c8647950c1e7b54f5205b51ed86d0631f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554882 > Commit-Queue: Christian Fremerey <chfremer@chromium.org> > Reviewed-by: Emircan Uysaler <emircan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#652964} Change-Id: I1d9bc8a8d8c2afd76fa4cd2e2434c36f855e9c01 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 783442 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578427 Cr-Commit-Position: refs/heads/master@{#653139} ...brtc_video_capture_shared_device_browsertest.cc | 183 ++++++++------------- 1 file changed, 65 insertions(+), 118 deletions(-) commit 312d722518957655eb765001aa6f9a78905b3608 Author: Rayan Kanso <rayankans@chromium.org> Date: Tue Apr 23 11:53:14 2019 +0000 Add braces for multi-line if block. Change-Id: I000e4fef434fcb2422f815dafd22cf3e67a860cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578738 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Auto-Submit: Rayan Kanso <rayankans@chromium.org> Reviewed-by: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#653138} chrome/browser/background_fetch/background_fetch_delegate_impl.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit f03ea5a5c2ff26e239dfd23e263b15da2d9cee93 Author: Lowell Manners <lowell@chromium.org> Date: Tue Apr 23 11:47:58 2019 +0000 Convert FrameHostMsg_DidAddMessageToConsole to Mojo. Note: Since this required changing the test RenderViewImplTest.DispatchBeforeUnloadCanDetachFrame, I manually re-introduced https://crbug.com/666714 locally (the bug the test was added for), and reran the test to confirm that it still covers the bug. Bug: 786836 Change-Id: I110668fa6f0f261fd2ac36bb91a8d8b31c99f4f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526270 Commit-Queue: Lowell Manners <lowell@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#653137} .../browser/frame_host/render_frame_host_impl.cc | 34 ++++++++---- .../browser/frame_host/render_frame_host_impl.h | 9 +-- .../service_worker/service_worker_context_core.cc | 2 +- content/common/frame.mojom | 9 +++ content/common/frame_messages.h | 8 --- content/renderer/render_frame_impl.cc | 6 +- content/renderer/render_view_browsertest.cc | 64 +++++++--------------- content/test/test_render_frame.cc | 22 ++++++++ content/test/test_render_frame.h | 5 ++ .../renderer/core/frame/navigation_rate_limiter.cc | 2 +- 10 files changed, 89 insertions(+), 72 deletions(-) commit c246049ec1b28d1af4fe3be886ac5904e1762026 Author: Alex Loiko <aleloi@chromium.org> Date: Tue Apr 23 11:47:54 2019 +0000 Cover experiment params by fieldtrial tests. The feature is the WebRTC Hybrid automatic gain controller 2. The params used in experimentation are * 5 db saturation margin * using root-mean-square and not peaks for estimating autio levels. Bug: chromium:873650 Change-Id: Id814c19e202e7bf5dd643838304a8a12c801066c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571413 Reviewed-by: Jesse Doherty <jwd@chromium.org> Commit-Queue: Alex Loiko <aleloi@chromium.org> Cr-Commit-Position: refs/heads/master@{#653136} testing/variations/fieldtrial_testing_config.json | 4 ++++ 1 file changed, 4 insertions(+) commit 44dc0a35034d139105204c1b3ff023f4ba582ed4 Author: Roman Sorokin <rsorokin@chromium.org> Date: Tue Apr 23 11:43:45 2019 +0000 Chrome OS: Use DeviceStateMixin It's used instead of StubInstallAttributes where possible Bug: 952855 Change-Id: Iae9700e8d611e3b114ca5681c0f89942c128a02b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572126 Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by: Toni Baržić <tbarzic@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#653135} .../login/active_directory_login_browsertest.cc | 6 +++- .../login/test/active_directory_login_mixin.cc | 10 ++---- .../login/test/active_directory_login_mixin.h | 5 +-- .../chromeos/login/test/device_state_mixin.cc | 12 +++++-- .../users/avatar/user_image_manager_browsertest.cc | 6 ++-- .../login/users/wallpaper_policy_browsertest.cc | 10 +++--- .../login/wizard_controller_browsertest.cc | 38 +++++++++++++++------- .../site_isolation_flag_handling_browsertest.cc | 9 +++-- 8 files changed, 55 insertions(+), 41 deletions(-) commit a0589888ab2c0b0797a18d38eadf77357078fbad Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Tue Apr 23 11:36:45 2019 +0000 Update V8 to version 7.6.2. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/49d1e6f9..ce596cfd Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia945f9c47832362a5af88ca5e2cb63b2dab39628 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578420 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653134} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 8c8f0977a1b2a00c0db31c69b799f1488ca4e720 Author: David Roger <droger@chromium.org> Date: Tue Apr 23 11:34:19 2019 +0000 [extensions][signin] Extensions use any accounts when Dice is enabled Extensions were restricted to the primary (Sync) account. When Dice is enabled, this restriction can be lifted, because Chrome can create oauth tokens even when Sync is not enabled. Bug: 852147 Change-Id: I0594500bcd950aaf74019817ea5a5e4b5bf7fa26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1454896 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#653133} chrome/browser/extensions/api/identity/identity_api.cc | 2 +- chrome/common/extensions/api/identity.idl | 8 +++----- 2 files changed, 4 insertions(+), 6 deletions(-) commit 6f00c97c68b1c9497cd5f950fd8322b2c6baed28 Author: Boris Sazonov <bsazonov@chromium.org> Date: Tue Apr 23 11:33:55 2019 +0000 [Signin][Android] Reland "Add Java side of ConsistencyCookieManager" Relands https://crrev.com/c/1565880 that broke UBSan build: https://crbug.com/954204. The only difference in this CL is that ConsistencyCookieManagerBase is now built on all platforms. Adds ConsistencyCookieManager Java class that listens to AccountManagerFacade.isUpdatePending and exposes it to the C++ code. TBR=droger@chromium.org Bug: 949562 Change-Id: I28165658f298865a54942c056158950825d41090 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578560 Reviewed-by: Boris Sazonov <bsazonov@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#653132} .../browser/signin/account_reconcilor_factory.cc | 22 +++++- chrome/browser/signin/account_reconcilor_factory.h | 6 ++ components/signin/core/browser/BUILD.gn | 17 ++++- .../signin/core/browser/account_reconcilor.cc | 15 ++-- .../signin/core/browser/account_reconcilor.h | 13 ++-- components/signin/core/browser/android/BUILD.gn | 5 ++ .../signin/ConsistencyCookieManager.java | 73 ++++++++++++++++++ .../browser/consistency_cookie_manager_android.cc | 86 +++++++--------------- .../browser/consistency_cookie_manager_android.h | 35 ++++----- .../browser/consistency_cookie_manager_base.cc | 80 ++++++++++++++++++++ .../core/browser/consistency_cookie_manager_base.h | 61 +++++++++++++++ ...t.cc => consistency_cookie_manager_unittest.cc} | 26 +++++-- 12 files changed, 329 insertions(+), 110 deletions(-) commit b6d732af07a579baacaa65f23ec0d0652898b7df Author: Henrik Boström <hbos@chromium.org> Date: Tue Apr 23 11:32:29 2019 +0000 Standardized getStats() in chrome://webrtc-internals. This CL replaces the stats displayed in in chrome://webrtc-internals with the standardized metrics (https://w3c.github.io/webrtc-stats/). This includes... - Stats Tables - Stats Graphs - Create Dump > Download the PeerConnection updates and stats data In addition to the raw stats, there are some calculated metrics added to the results as well. This is because new metrics are typically accumulative (total counters) but rates are usually much more relatable. These are calculated every second. The view of the old stats is still supported through a UI option where you switch to "Read Stats From:" the legacy API. This affects stats tables, graphs and dumps. The old mode should be unaffected by this CL. Bug: 803014 Change-Id: Iaaf4fe0444be30a6300e4a8c94e0db486d54613f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565882 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#653131} .../browser/resources/media/stats_graph_helper.js | 99 ++++++- .../resources/media/stats_rates_calculator.js | 300 +++++++++++++++++++++ content/browser/resources/media/stats_table.js | 12 + .../browser/resources/media/webrtc_internals.js | 92 ++++++- 4 files changed, 494 insertions(+), 9 deletions(-) commit 969aca61b01005976fa88d3602272585e375272a Author: Victor Hugo Vianna Silva <victorvianna@google.com> Date: Tue Apr 23 11:28:34 2019 +0000 Reland "Add UMA for sync favicons in history WebUIs" This is a reland of 19d0ffa55117052243499e0216e56aef6ab0eda3 Original change's description: > Add UMA for sync favicons in history WebUIs > > We add metrics to evaluate sync's usefulness in helping obtain favicons > for chrome://history and chrome://history/syncedTabs that would not be > available locally. > > Bug: 948109 > Change-Id: I38b527ffd3c0efb9c452d84e1c44c465b1234cec > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561112 > Commit-Queue: Victor Vianna <victorvianna@google.com> > Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org> > Reviewed-by: Dan Beam <dbeam@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Reviewed-by: Brian White <bcwhite@chromium.org> > Cr-Commit-Position: refs/heads/master@{#652116} TBR=bcwhite@chromium.org Bug: 948109 Change-Id: I233641c6c44e237227ff305cfdc159f5ced912df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572411 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#653130} chrome/browser/ui/webui/favicon_source.cc | 63 ++++++++++++++++------ chrome/browser/ui/webui/favicon_source.h | 5 +- components/favicon_base/BUILD.gn | 2 + components/favicon_base/favicon_request_metrics.cc | 26 +++++++++ components/favicon_base/favicon_request_metrics.h | 33 ++++++++++++ tools/metrics/histograms/enums.xml | 6 +++ tools/metrics/histograms/histograms.xml | 19 +++++++ 7 files changed, 138 insertions(+), 16 deletions(-) commit 758497a2c3380f361d9015c60041d8e0af0d9e3a Author: Jochen Eisinger <jochen@chromium.org> Date: Tue Apr 23 11:27:54 2019 +0000 Replace raw pointer to content settings with rvalue ref to unique_ptr Bug: 914453 Change-Id: I3cc2e47c21979d44648d17004d27519dc2a408f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577420 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#653129} .../content_settings_default_provider_unittest.cc | 59 +++++++-------- .../content_settings_policy_provider_unittest.cc | 8 +- .../content_settings_pref_provider_unittest.cc | 80 ++++++++++---------- .../content_settings_supervised_provider.cc | 2 +- .../content_settings_supervised_provider.h | 2 +- .../host_content_settings_map_unittest.cc | 4 +- .../content_settings_custom_extension_provider.cc | 2 +- .../content_settings_custom_extension_provider.h | 2 +- .../installable/installed_webapp_provider.cc | 2 +- .../installable/installed_webapp_provider.h | 2 +- .../notification_channels_provider_android.cc | 6 +- .../notification_channels_provider_android.h | 2 +- ...ification_channels_provider_android_unittest.cc | 88 +++++++++++----------- .../ui/webui/site_settings_helper_unittest.cc | 20 ++--- .../browser/content_settings_default_provider.cc | 4 +- .../browser/content_settings_default_provider.h | 2 +- .../browser/content_settings_ephemeral_provider.cc | 4 +- .../browser/content_settings_ephemeral_provider.h | 2 +- ...content_settings_ephemeral_provider_unittest.cc | 48 ++++++------ .../browser/content_settings_policy_provider.cc | 2 +- .../browser/content_settings_policy_provider.h | 2 +- .../core/browser/content_settings_pref.cc | 6 +- .../core/browser/content_settings_pref.h | 2 +- .../core/browser/content_settings_pref_provider.cc | 5 +- .../core/browser/content_settings_pref_provider.h | 2 +- .../core/browser/content_settings_provider.h | 2 +- .../browser/content_settings_provider_unittest.cc | 19 ++--- .../core/browser/host_content_settings_map.cc | 3 +- .../core/test/content_settings_mock_provider.cc | 4 +- .../core/test/content_settings_mock_provider.h | 2 +- 30 files changed, 190 insertions(+), 198 deletions(-) commit 8eb96d4a54ab1070caa984f61b0bd0020be1be1c Author: dpapad <dpapad@chromium.org> Date: Tue Apr 23 11:15:52 2019 +0000 WebUI cleanup: Remove obsolete dependencies to cr/ui/touch_handler.js Moreover, some of these dependencies appeared within <include> tags, which were adding unnecessary size to the binary. For example component_extension_resources.pak is reduced on ChromeOS by 1.8%. (1618551b -> 1588929b) Bug: None Change-Id: Ic810f08ef7d2dacb8e1ed08fa2eaf05ea81daef2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574595 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Reviewed-by: May Lippert <maybelle@chromium.org> Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#653128} chrome/browser/resources/chromeos/login/md_login.html | 1 - chrome/browser/resources/chromeos/login/oobe.html | 1 - chrome/browser/resources/chromeos/wallpaper_manager/js/main_scripts.js | 2 -- chrome/browser/resources/chromeos/wallpaper_manager/main.html | 1 - components/sync/driver/resources/index.html | 1 - ui/file_manager/file_manager/foreground/js/main_scripts.js | 1 - ui/file_manager/gallery/js/gallery_scripts.js | 1 - 7 files changed, 8 deletions(-) commit 5d0f88340b60f18b8bc8a4207fa7a9fe14aa59e4 Author: Carlos Caballero <carlscab@google.com> Date: Tue Apr 23 11:15:22 2019 +0000 Add deprecation notice to BrowserThread::PostAfterStartupTask Bug: 887407 Change-Id: I21777fedb072a12499c11c703c99228778eda280 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571662 Commit-Queue: Carlos Caballero <carlscab@google.com> Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#653127} content/public/browser/browser_thread.h | 6 ++++++ 1 file changed, 6 insertions(+) commit ef608fa895c918b635c72d6d0388720db931f7b2 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Tue Apr 23 11:13:12 2019 +0000 Remove AuthenticationService::GetAuthenticatedUserEmail Most of the call-sites are only interested whether the user is authenticated (i.e. they check whether the value returned it not nil) so convert them to instead use the IsAuthenticatedMethod() method. The only call-site that used the returned value can instead be converted to call GetAuthenticatedIdentity() and use -userEmail property. Bug: none Change-Id: Iac07ad957adef4065cafdf8b681c7677dd674cdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574800 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#653126} ios/chrome/browser/signin/authentication_service.h | 4 ---- ios/chrome/browser/signin/authentication_service.mm | 9 --------- ios/chrome/browser/signin/authentication_service_fake.h | 2 -- ios/chrome/browser/signin/authentication_service_fake.mm | 4 ---- ios/chrome/browser/signin/authentication_service_unittest.mm | 5 ----- .../browser/ui/authentication/authentication_flow_performer.mm | 2 +- .../browser/ui/authentication/re_signin_infobar_delegate.mm | 2 +- ios/chrome/browser/ui/promos/signin_promo_view_controller.mm | 2 +- .../sync/sync_encryption_passphrase_table_view_controller.mm | 4 ++-- 9 files changed, 5 insertions(+), 29 deletions(-) commit a007a487d0a353549535838907d896b533291d5a Author: Marc Treib <treib@chromium.org> Date: Tue Apr 23 10:59:22 2019 +0000 Split out separate BUILD.gn files from components/sync/BUILD.gn This CL pulls out separate BUILD.gn files for those subfolders that already have their own build targets: base device_info driver js user_events Bug: 947443 Change-Id: Icb9eb25dd3322f9ccfe2a6ecf320744725be4dad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569224 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#653125} chrome/browser/BUILD.gn | 2 +- chrome/browser/ui/BUILD.gn | 2 +- components/browser_sync/BUILD.gn | 2 +- components/sync/BUILD.gn | 333 +---------------------------------- components/sync/base/BUILD.gn | 116 ++++++++++++ components/sync/device_info/BUILD.gn | 46 +++++ components/sync/driver/BUILD.gn | 136 ++++++++++++++ components/sync/js/BUILD.gn | 23 +++ components/sync/protocol/BUILD.gn | 2 +- components/sync/user_events/BUILD.gn | 31 ++++ components/sync_sessions/BUILD.gn | 2 +- ios/chrome/browser/metrics/BUILD.gn | 2 +- ios/chrome/browser/sync/BUILD.gn | 4 +- ios/chrome/test/app/BUILD.gn | 2 +- ios/web_view/BUILD.gn | 4 +- 15 files changed, 371 insertions(+), 336 deletions(-) commit c16fb58b2bca1bba7248ac509dde60ececf94d63 Author: Dan Elphick <delphick@chromium.org> Date: Tue Apr 23 10:48:22 2019 +0000 [v8] Fix use of deprecated Object::Set in renderer Uses the context version of Set and checks the return value (which cannot actually fail in this case but the API requires it). Bug: v8:7283 Change-Id: I1c8b5d0daf846579cb429ef4c71c2a37681a5c46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576571 Auto-Submit: Dan Elphick <delphick@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#653124} chrome/renderer/sandbox_status_extension_android.cc | 7 +++++-- content/renderer/java/gin_java_bridge_object.cc | 4 +++- 2 files changed, 8 insertions(+), 3 deletions(-) commit 5c7c5d31ac0fea5a0a186e094dc5f54bbe3783e1 Author: Mohamed Abdelhalim <zetamoo@chromium.org> Date: Tue Apr 23 10:33:50 2019 +0000 Navigation: Move NavigationHandleImpl::DidCommitNavigation to NavigationRequest. This is the first part of splitting https://chromium-review.googlesource.com/c/chromium/src/+/1554767 This includes moving these members with their accessors: bool did_replace_entry_ bool should_update_history_ bool subframe_entry_committed_ GURL previous_url_ GURL base_url_ NavigationType navigation_type_ Next steps: Move the remaining members from NavigationHandleImpl to NavigationRequest, and merge NavigationRequest::NavigationHandleState into NavigationRequest::NavigationState. Bug: 916537 Change-Id: Ibaac4db36fe92de34ef698f5dccaca0aea6f4909 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569706 Commit-Queue: Mohamed Abdelhalim <zetamoo@google.com> Reviewed-by: Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#653123} .../frame_host/interstitial_page_navigator_impl.cc | 4 +- .../browser/frame_host/navigation_handle_impl.cc | 117 +--------------- .../browser/frame_host/navigation_handle_impl.h | 30 +--- content/browser/frame_host/navigation_request.cc | 156 +++++++++++++++++++++ content/browser/frame_host/navigation_request.h | 73 ++++++++++ content/browser/frame_host/navigator_impl.cc | 6 +- 6 files changed, 247 insertions(+), 139 deletions(-) commit 4042ac3574167a804b1827610dd444e0f9e48627 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Tue Apr 23 10:33:35 2019 +0000 Roll src-internal f0d8b0b44468..ca5f18c2b4e5 (2 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f0d8b0b44468..ca5f18c2b4e5 Created with: gclient setdep -r src-internal@ca5f18c2b4e5 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=chcunningham@chromium.org,loyso@chromium.org,clamy@chromium.org,flackr@chromium.org Change-Id: Id5bbf7236dbe55a93a2f73514612ecbf054762df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578419 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653122} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 22cb11259469c42bcfe1fd59ec69dcad4071a156 Author: Alex Clarke <alexclarke@chromium.org> Date: Tue Apr 23 10:32:45 2019 +0000 Reland: java: Add a choreographer frame task trait This is useful if you need to guarantee something like a layout pass has occurred before your task runs. Tasks posted with TaskTraits.CHOREOGRAPHER_FRAME will run next time there's a vsync and after all other ready tasks on the thread have run. I put the trait under base because from what I understand there is some ui/ code that needs it but ui/ can't depend on content/. TBR=skyostil@chromium.org, yfriedman@chromium.org Bug: 863341 Change-Id: Ib703f9e9de091d4bb3734f98b2b7789839a10f3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578498 Reviewed-by: Alex Clarke <alexclarke@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#653121} base/BUILD.gn | 1 + .../base/task/ChoreographerTaskRunner.java | 63 ++++++++++++++++++++++ .../chromium/base/task/DefaultTaskExecutor.java | 22 +++++++- .../src/org/chromium/base/task/TaskTraits.java | 12 +++++ .../src/org/chromium/base/task/PostTaskTest.java | 31 +++++++++++ 5 files changed, 127 insertions(+), 2 deletions(-) commit 764d342c053e018eda1607a2be5c4ea1d51b4743 Author: Dan Elphick <delphick@chromium.org> Date: Tue Apr 23 10:28:55 2019 +0000 [v8] Fix use of deprecated Object::Set in supervised_user_error_page Uses the context version of Set and checks the return value (which cannot actually fail in this case but the API requires it). Bug: v8:7283 Change-Id: Ib22e132cee49da508a00a811f5bd67e4f5903ff2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576570 Auto-Submit: Dan Elphick <delphick@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#653120} components/supervised_user_error_page/gin_wrapper.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) commit 0cbed54f7a63d80ccc22b5cb331c224f9f4e3e08 Author: A Olsen <olsen@chromium.org> Date: Tue Apr 23 10:12:14 2019 +0000 Update js2gtest rule to support source-absolute paths. See either of the two .unitjs files for how this change makes test slightly simpler. BUILD rules (including js2gtest) support source absolute paths (eg //foo/bar.js), however the js compilation step of the js2gtest rule only supported relative paths. So from within the test, the GEN_INCLUDE would have to be '../../../../../foo/bar.js'. This is fragile (breaks if the test is moved) and surprising (the source-absolute syntax works in the BUILD file but not in the associated JS file). This change fixes the js2gtest rule to support source-absolute syntax, and, switches one js2gtest rule to use the new feature as proof it works. Other js2gtests rules are left as-is to prove nothing is broken. Change-Id: Id153e35dd9d88bf6fc9c0e26f0de23ab17a1e003 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547734 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: David Tseng <dtseng@chromium.org> Commit-Queue: A Olsen <olsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#653119} .../login/saml_password_attributes_test.unitjs | 5 +- .../chromeos/login/saml_timestamps_test.unitjs | 5 +- chrome/test/base/js2gtest.gni | 2 +- chrome/test/base/js2gtest.js | 99 +++++++++++++--------- tools/OWNERS | 2 +- tools/gypv8sh.py | 6 +- 6 files changed, 68 insertions(+), 51 deletions(-) commit 33ece3e9f476239dade7ee2e7e434d2014c49487 Author: Henrik Boström <hbos@chromium.org> Date: Tue Apr 23 10:08:53 2019 +0000 Plumbing in preparation for standardized getStats() in webrtc-internals. This CL implements the calling chain from webrtc_internals.js all the way to getStats() and back, including process hops and layering. - This adds the calling chain for standard getStats() API. The original calling chain for legacy getStats() remains intact, but is renamed. rtc_peer_connection_handler.cc implements invoking the standard API and formats the result in the way that webrtc_internals.js expects stats to be formatted. These are roughly the layers: - webrtc_internals.js "get[Legacy/Standard]Stats" - WebRTCInternalsMessageHandler::OnGet[Legacy/Standard]Stats - PeerConnectionTracker::OnGet[Legacy/Standard]Stats - webrtc::PeerConnectionInterface::GetStats - Internal[Legacy/Standard]StatsObserver::[OnComplete/OnStatsDelivered] - PeerConnectionTrackerHost::OnAdd[Legacy/Standard]Stats - WebRTCInternals::OnAdd[Legacy/Standard]Stats - WebRTCInternalsMessageHandler::OnUpdate - webrtc_internals.js "add[Legacy/Standard]Stats" This CL is split up from https://chromium-review.googlesource.com/c/chromium/src/+/1536186 to ease reviewing. The new calling chain is NOT exercised in this CL, this will be handled in a follow-up CL. Bug: 803014 Change-Id: Ied4b0b8f136f92aaad4633edb38ccb288e41ef3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565327 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Auto-Submit: Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#653118} .../media/peer_connection_tracker_host.cc | 20 ++- .../media/peer_connection_tracker_host.h | 3 +- .../browser/resources/media/webrtc_internals.js | 21 ++- content/browser/webrtc/webrtc_internals.cc | 22 ++- content/browser/webrtc/webrtc_internals.h | 14 +- .../browser/webrtc/webrtc_internals_browsertest.cc | 2 +- .../webrtc/webrtc_internals_message_handler.cc | 21 ++- .../webrtc/webrtc_internals_message_handler.h | 3 +- .../browser/webrtc/webrtc_internals_unittest.cc | 35 ++++- .../media/peer_connection_tracker_messages.h | 8 +- .../media/webrtc/peer_connection_tracker.cc | 154 ++++++++++++++++++--- .../media/webrtc/peer_connection_tracker.h | 3 +- .../media/webrtc/rtc_peer_connection_handler.cc | 5 + .../media/webrtc/rtc_peer_connection_handler.h | 3 + 14 files changed, 270 insertions(+), 44 deletions(-) commit fb8ff28be837c61b79916d1bc79399b0fe51188b Author: Yutaka Hirano <yhirano@chromium.org> Date: Tue Apr 23 10:01:26 2019 +0000 Remove "XSLT" runtime enabled feature The flag was introduced at https://crrev.com/eae49e58e1365c1d010cb49b6d2eb87823904fc4 to run an experiment to disable the feature, but it was more than 5 years ago. Remove the flag as there seems no activity around it. Bug: None Change-Id: I186e804da25138455eef4ca8a66812ff40fb7e29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575261 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#653117} content/public/common/common_param_traits_macros.h | 1 - content/public/common/web_preferences.cc | 1 - content/public/common/web_preferences.h | 1 - content/renderer/render_view_impl.cc | 1 - content/shell/renderer/web_test/blink_test_helpers.cc | 1 - third_party/blink/public/platform/web_runtime_features.h | 1 - third_party/blink/renderer/core/dom/processing_instruction.cc | 6 +----- .../renderer/core/loader/resource/xsl_style_sheet_resource.cc | 2 -- third_party/blink/renderer/core/xml/document_xslt.cc | 9 ++------- .../blink/renderer/core/xml/parser/xml_document_parser.cc | 4 ---- third_party/blink/renderer/core/xml/xsl_style_sheet.h | 4 ---- third_party/blink/renderer/core/xml/xslt_extensions.cc | 2 -- third_party/blink/renderer/core/xml/xslt_processor.h | 2 -- third_party/blink/renderer/core/xml/xslt_processor.idl | 1 - .../blink/renderer/platform/exported/web_runtime_features.cc | 4 ---- .../blink/renderer/platform/loader/fetch/resource_fetcher.cc | 4 ---- .../blink/renderer/platform/runtime_enabled_features.json5 | 4 ++-- 17 files changed, 5 insertions(+), 43 deletions(-) commit 6c1d962ad63f18ff1d8d771086bce376210ad91c Author: Marina Ciocea <marinaciocea@chromium.org> Date: Tue Apr 23 09:42:52 2019 +0000 Compute RTCPeerConnection iceConnectionState based on RTCIceTransport states. Previously both RTCPeerConnection::iceConnectionState and RTCIceTransport states were calculated based on updates coming from webrtc layer to blink layer (from signaling thread to main thread). Because there is no ordering between the two updates, the peer connection iceConnectionState and ice transport states could end up out of sync in blink layer. Fix state mismatch by updating the peer connection iceConnectionState using blink layer ice transport states, on ice transport state updates. These changes only apply for unified plan because RTCIceTransport is not exposed for plan B. Bug: 953694,944036 Change-Id: I3b96189593a89715cc42a8113e97c2b31c7f0eb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566334 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#653116} .../modules/peerconnection/rtc_dtls_transport.cc | 8 +- .../modules/peerconnection/rtc_ice_transport.cc | 47 ++++++--- .../modules/peerconnection/rtc_ice_transport.h | 21 +++- .../modules/peerconnection/rtc_peer_connection.cc | 111 +++++++++++++++++---- .../modules/peerconnection/rtc_peer_connection.h | 16 ++- third_party/blink/web_tests/TestExpectations | 2 - ...onnection-iceConnectionState.https-expected.txt | 8 -- ...RTCPeerConnection-iceConnectionState.https.html | 3 +- 8 files changed, 161 insertions(+), 55 deletions(-) commit 6a9fe56c7228cbb6f3580a07ce7a96a03394825d Author: Takashi Sakamoto <tasak@google.com> Date: Tue Apr 23 09:35:29 2019 +0000 Replace metric name: "HasSafepoint" with "HasSafePoint". Change-Id: Ia9c9c5c21e028c0209d772c23c4e0a2133910dbf TBR=haraken@chromium.org Change-Id: Ia9c9c5c21e028c0209d772c23c4e0a2133910dbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575298 Reviewed-by: Takashi Sakamoto <tasak@google.com> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#653115} .../platform/scheduler/main_thread/main_thread_metrics_helper.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 63860ed142dd894a7f4de765c015389340f57374 Author: Benoît Lizé <lizeb@chromium.org> Date: Tue Apr 23 09:34:27 2019 +0000 blink/bindings: Wait for ThreadTicks initialization in tests. This is the likely cause for this revert: https://chromium-review.googlesource.com/c/chromium/src/+/1574286 If true, then the culprit CL only triggered the issue by accident. Bug: 924164 Change-Id: I8261f20e91fbcdf7284b17630bad25f19176ff60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577423 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#653114} .../blink/renderer/platform/bindings/parkable_string_test.cc | 6 ++++++ 1 file changed, 6 insertions(+) commit 6560bcb5fd490a5bb689e61ca64a12d1fd8ce0b5 Author: Jan Krcal <jkrcal@chromium.org> Date: Tue Apr 23 09:30:57 2019 +0000 [AF Wallet Metadata] Enable USS implementation by default This CL adds a testing config to prepare for a Beta launch. Bug: 853688 Change-Id: I2e6f99a7d9bbf5aa7bc268e74c53f3af135837f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569931 Reviewed-by: Brian White <bcwhite@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#653113} testing/variations/fieldtrial_testing_config.json | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) commit 54ecbff708072782523569cd2fa02a57c89211c5 Author: Lowell Manners <lowell@chromium.org> Date: Tue Apr 23 09:20:30 2019 +0000 Update IdentityManager to own AccountTrackerService. With this change, AccountTrackerService is now constructed only when creating an IdentityManager, eliminating the need for AccountTrackerService factories. Change-Id: I18a527d6c56446ced653aca9c7ff42a9c657065b Bug: 939372 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549083 Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Commit-Queue: Lowell Manners <lowell@chromium.org> Cr-Commit-Position: refs/heads/master@{#653112} chrome/browser/BUILD.gn | 2 - .../signin/account_tracker_service_factory.cc | 46 --------------- .../signin/account_tracker_service_factory.h | 45 --------------- chrome/browser/signin/identity_manager_factory.cc | 50 ++++++++++------- .../identity_test_environment_profile_adaptor.cc | 6 +- .../signin/profile_oauth2_token_service_builder.cc | 33 ++++++----- .../signin/profile_oauth2_token_service_builder.h | 4 +- .../signin/core/browser/account_tracker_service.h | 10 ++-- .../core/browser/identity_manager_wrapper.cc | 6 +- .../signin/core/browser/identity_manager_wrapper.h | 2 +- ios/chrome/browser/signin/BUILD.gn | 2 - .../signin/account_tracker_service_factory.cc | 53 ------------------ .../signin/account_tracker_service_factory.h | 51 ----------------- .../browser/signin/identity_manager_factory.cc | 41 ++++++++------ ...est_environment_chrome_browser_state_adaptor.cc | 26 ++------- ios/web_view/BUILD.gn | 2 - .../web_view_account_tracker_service_factory.h | 52 ----------------- .../web_view_account_tracker_service_factory.mm | 57 ------------------- .../signin/web_view_identity_manager_factory.mm | 39 +++++++------ services/identity/public/cpp/BUILD.gn | 4 ++ services/identity/public/cpp/DEPS | 4 ++ services/identity/public/cpp/identity_manager.cc | 10 ++-- services/identity/public/cpp/identity_manager.h | 4 +- .../public/cpp/identity_manager_unittest.cc | 25 +++++---- .../public/cpp/identity_test_environment.cc | 65 ++++++++++++++-------- .../public/cpp/identity_test_environment.h | 19 +++++-- 26 files changed, 192 insertions(+), 466 deletions(-) commit 79eda218bfef76f69645ff336c3c000e2a1d6963 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Tue Apr 23 09:17:36 2019 +0000 Roll src-internal 7a8bbc22887c..f0d8b0b44468 (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7a8bbc22887c..f0d8b0b44468 Created with: gclient setdep -r src-internal@f0d8b0b44468 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=chcunningham@chromium.org,loyso@chromium.org,clamy@chromium.org,flackr@chromium.org Change-Id: I5d18856afec1552ad6e903634db95815c260335b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576329 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653111} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit c876c586e40c989546992d4c19d90a1738516e77 Author: Jeevan Shikaram <jshikaram@chromium.org> Date: Tue Apr 23 09:16:08 2019 +0000 [App Management] Search is now case insensitive. App search is now case insensitive and sorts search results alphabetically. Bug: 950216 Change-Id: Ie1baf5b51d67ddf3a13fb013979247ed0439bfbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575308 Reviewed-by: Dominick Ng <dominickn@chromium.org> Auto-Submit: Jeevan Shikaram <jshikaram@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#653110} chrome/browser/resources/app_management/main_view.js | 4 +++- chrome/browser/resources/app_management/reducers.js | 9 ++++++++- chrome/browser/resources/app_management/util.js | 11 +++++++++++ 3 files changed, 22 insertions(+), 2 deletions(-) commit da41fa9f9249186bc57efeecd37118b5190ee229 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Apr 23 08:56:30 2019 +0000 Roll AFDO from 76.0.3773.0_rc-r1-merged to 76.0.3774.0_rc-r1-merged This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Id7d907e4445b9d3beed60a87d77165720a2c7f7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578418 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653109} chrome/android/profiles/newest.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit a10cd65c2606ae46822cff59d5a47a957b16d392 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Tue Apr 23 08:50:54 2019 +0000 Change AuthenticationService::SetPromptForSignIn() Remove the should_prompt parameter and instead introduce a second method ResetPromptForSignIn() method. This solves and issue where HandleForgottenIdentity() would clear the flag if it was invoked with false for should_prompt instead of leaving the value unchanged. After this change, if HandleForgottenIdentity() checks whether it should set the flag. If not, then it can leave it untouched. This may resolve a bug where PromptForSignIn flag would end up set to false if the primary account refresh token was lost while the app was in the background. Bug: none Change-Id: I459f78beecd50c80f223963e1b960777b89ff3bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569144 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#653108} ios/chrome/browser/signin/authentication_service.h | 8 +++++--- ios/chrome/browser/signin/authentication_service.mm | 18 ++++++++++-------- .../browser/signin/authentication_service_unittest.mm | 4 ++-- .../ui/authentication/re_signin_infobar_delegate.mm | 6 +++--- .../re_signin_infobar_delegate_unittest.mm | 12 ++++++------ 5 files changed, 26 insertions(+), 22 deletions(-) commit 355b515ff77275cd041e32bef33c50d06690ed99 Author: Donna Wu <donna.wu@intel.com> Date: Tue Apr 23 08:50:14 2019 +0000 Use USB Mojo interfaces in UsbPrinterDetector on ChromeOS Bug: 699790 Change-Id: I19311a368925636d47d20b333c49ab152c9732fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564648 Commit-Queue: Donna Wu <donna.wu@intel.com> Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#653107} chrome/browser/BUILD.gn | 1 - chrome/browser/chromeos/BUILD.gn | 1 + .../chromeos/printing/usb_printer_detector.cc | 127 ++++++++++--------- .../chromeos/printing/usb_printer_detector.h | 6 +- .../printing/usb_printer_detector_unittest.cc | 138 +++++++++++++++++++++ 5 files changed, 213 insertions(+), 60 deletions(-) commit 7c438ba6dd619108b8b4ca90fdab12316104d018 Author: Chromium WPT Sync <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Date: Tue Apr 23 08:40:00 2019 +0000 Import wpt@daac93ce1af71078f958781aabed8ceeeb83a540 Using wpt-import in Chromium c294c1a75753693c083c1e96167b548a44cc5a85. With Chromium commits locally applied on WPT: 0a8f3ffa48 "Use testdriver Action API in WPT pointerevent touch tests - Part 2" 4e9215207a "[Code Health] Remove unnecessary reference file for web test" 40465b7400 "[Animation Worklet] Copy the effects of a migrating animator over to new global scope" e28269b698 "[LayoutNG/PE] Clear visual overflow for LayoutText before setting." aff3c8feca "Add tests for crbug.com/363609 and crbug.com/954591" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org: external/wpt/css/CSS2/text NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I1e3497e123cad6546c4b37225db3d65abc85720a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577572 Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653106} third_party/blink/web_tests/TestExpectations | 2 ++ .../blink/web_tests/external/WPT_BASE_MANIFEST_6.json | 18 +++++++++++++++++- .../wpt/css/CSS2/text/white-space-processing-005.xht | 4 ++-- .../css/css-text/white-space/control-chars-00C.html | 18 ++++++++++++++++++ 4 files changed, 39 insertions(+), 3 deletions(-) commit 65b033261806b4b564a0f5eb098d2250052ade8f Author: Daniel Bratell <bratell@opera.com> Date: Tue Apr 23 08:17:06 2019 +0000 Find #include "foo.cc" with a presubmit check An #include "foo.cc" will often compile, until it causes linking problems later, for instance in jumbo builds. The error messages are then not good at pointing out what is wrong. Change-Id: Ic155dc5542e22b54d13c213230d6df4977263642 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566344 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#653105} PRESUBMIT.py | 85 +++++++++++++++++++++++++++++++++++++++++++------------ PRESUBMIT_test.py | 76 +++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 143 insertions(+), 18 deletions(-) commit 177b57b58aeb63604238675faef2dff0a1fbda9b Author: Emil A Eklund <eae@chromium.org> Date: Tue Apr 23 08:15:26 2019 +0000 Clean up ComputeGlyphPositions Remove obsolete comments & code from ShapeResult::ComputeGlyphPositions. Change-Id: I67006a80f0558fe8f610a6ab01845d2acc3f0cb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577781 Auto-Submit: Emil A Eklund <eae@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#653104} .../platform/fonts/shaping/shape_result.cc | 45 ++++++---------------- .../fonts/shaping/shape_result_inline_headers.h | 12 ------ 2 files changed, 12 insertions(+), 45 deletions(-) commit 00b9d94aa1b29f8535e8264773b2faefbe4b1bfe Author: Niels Möller <nisse@chromium.org> Date: Tue Apr 23 08:12:35 2019 +0000 Use EncodedImage::Allocate, to avoid using storage not owned by EncodedImage. Bug: webrtc:9378 Change-Id: Ia6078548550617887c61481df1890eb461faba90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529024 Reviewed-by: Gary Kacmarcik <garykac@chromium.org> Reviewed-by: Emircan Uysaler <emircan@chromium.org> Commit-Queue: Niels Möller <nisse@chromium.org> Cr-Commit-Position: refs/heads/master@{#653103} content/renderer/media/webrtc/rtc_video_decoder.cc | 14 +++++------ .../webrtc/rtc_video_decoder_adapter_unittest.cc | 27 +++++++++++----------- .../media/webrtc/rtc_video_decoder_unittest.cc | 24 +++++++++---------- content/renderer/media/webrtc/rtc_video_encoder.cc | 7 +++--- remoting/protocol/webrtc_dummy_video_encoder.cc | 9 +++++--- 5 files changed, 41 insertions(+), 40 deletions(-) commit c16998b28bd1cac7ae2ff045374e20fac03b65d6 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Tue Apr 23 08:10:59 2019 +0000 Roll src-internal fcc05e93113e..7a8bbc22887c (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fcc05e93113e..7a8bbc22887c Created with: gclient setdep -r src-internal@7a8bbc22887c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=chcunningham@chromium.org,loyso@chromium.org,clamy@chromium.org,flackr@chromium.org Change-Id: I7c0e558844d72ecc059181ef93d7392c15370e44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578351 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653102} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 926019e70731b6c466f71294d44f5f790d710c0b Author: Yoshifumi Inoue <yosin@chromium.org> Date: Tue Apr 23 08:04:22 2019 +0000 Assert LayoutBlockFlow::GetOffsetMapping() called in layout clean This patch add |CHECK(!NeedsLayout()| to |LayoutBlockFlow::GetOffsetMapping()| to stop when it is called with dirty layout instead of causing use-after-tree. Note: This patch isn't actual fix of http://crbug.com/952718 because we're not sure why |LayoutBlockFlow::GetOffsetMapping()| is called with dirty layout tree. Bug: 952718 Change-Id: I9af4a764dbe3899158e8a22cf82b6d92c03a24e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578148 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#653101} third_party/blink/renderer/core/layout/layout_block_flow.cc | 1 + 1 file changed, 1 insertion(+) commit 6d0514b0d03a311ea6563b24c4fc2e253572ab7c Author: Luciano Pacheco <lucmult@chromium.org> Date: Tue Apr 23 07:46:50 2019 +0000 [Files app] ES6 class for util.js Caveat: DOMError is deprecated according to MDN [1], but it's still used in File System API so we have to stick with it. However Closure externs for DOMError doesn't include the constructor with two arguments which is available (at least in Chrome), so I kept the existing helper createDOMError to take care of closure typing for UserDOMError and DOMError. I tried to use DOMError directly in CL:1571270 but closure didn't like it. :-/ [1] - https://developer.mozilla.org/en-US/docs/Web/API/DOMError Bug: 778674 Change-Id: Id316ecbcec23328ed62a0135450ad9edd7403553 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571327 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by: Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#653100} ui/file_manager/file_manager/common/js/util.js | 50 ++++++++++++++------------ 1 file changed, 28 insertions(+), 22 deletions(-) commit 028c8b919bf83f7e9db599e6922efd9a7d240391 Author: Wei Lee <wtlee@google.com> Date: Tue Apr 23 07:45:38 2019 +0000 Change namespace of JEA/MJDA mojo interfaces This CL changes the namespace of JEA/MJDA mojo interfaces from media::mojom to chromeos_camera::mojom. Bug: 946366 Test: Compiles successfully and camera works normally. Change-Id: I9b1434934829519660634b4b111276d9d1acc963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565733 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by: Christian Fremerey <chfremer@chromium.org> Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Reviewed-by: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#653099} .../common/jpeg_encode_accelerator.mojom | 3 +- .../common/jpeg_encode_accelerator.typemap | 5 ++- .../common/jpeg_encode_accelerator_mojom_traits.cc | 39 +++++++++-------- .../common/jpeg_encode_accelerator_mojom_traits.h | 6 +-- .../common/mjpeg_decode_accelerator.mojom | 5 +-- .../common/mjpeg_decode_accelerator.typemap | 4 +- .../mjpeg_decode_accelerator_mojom_traits.cc | 50 +++++++++++----------- .../common/mjpeg_decode_accelerator_mojom_traits.h | 10 ++--- components/viz/host/gpu_client.cc | 2 +- components/viz/host/gpu_client.h | 3 +- .../host_gpu_memory_buffer_manager_unittest.cc | 6 ++- components/viz/service/gl/gpu_service_impl.cc | 4 +- components/viz/service/gl/gpu_service_impl.h | 7 ++- ...e_to_browser_gpu_service_accelerator_factory.cc | 2 +- .../gpu/chromeos/video_capture_dependencies.cc | 4 +- .../gpu/chromeos/video_capture_dependencies.h | 4 +- ...te_to_browser_gpu_service_accelerator_factory.h | 3 +- .../video/chromeos/camera_hal_dispatcher_impl.cc | 4 +- .../video/chromeos/camera_hal_dispatcher_impl.h | 8 ++-- .../video/chromeos/mojo/cros_camera_service.mojom | 4 +- .../video_capture_device_factory_chromeos.h | 4 +- .../chromeos/video_capture_jpeg_decoder_impl.cc | 2 +- .../chromeos/video_capture_jpeg_decoder_impl.h | 2 +- .../capture/video/video_capture_device_unittest.cc | 4 +- .../clients/cros_mojo_mjpeg_decode_accelerator.cc | 2 +- .../clients/cros_mojo_mjpeg_decode_accelerator.h | 15 ++++--- .../cros_mojo_jpeg_encode_accelerator_service.cc | 2 +- .../cros_mojo_jpeg_encode_accelerator_service.h | 11 ++--- .../cros_mojo_mjpeg_decode_accelerator_service.cc | 2 +- .../cros_mojo_mjpeg_decode_accelerator_service.h | 11 ++--- ...jo_mjpeg_decode_accelerator_service_unittest.cc | 2 +- .../video_capture/device_factory_provider_impl.cc | 2 +- .../public/mojom/device_factory_provider.mojom | 3 +- .../viz/privileged/interfaces/gl/gpu_service.mojom | 5 ++- services/ws/public/cpp/gpu/gpu.cc | 4 +- services/ws/public/cpp/gpu/gpu.h | 2 +- services/ws/public/cpp/tests/gpu_unittest.cc | 3 +- services/ws/public/mojom/gpu.mojom | 3 +- 38 files changed, 134 insertions(+), 118 deletions(-) commit 170bd80b4e94b8516ac40e8859b04ea17046ad53 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Apr 23 07:43:27 2019 +0000 Roll src/third_party/skia f31ae87fe0cb..f153e221140a (1 commits) https://skia.googlesource.com/skia.git/+log/f31ae87fe0cb..f153e221140a git log f31ae87fe0cb..f153e221140a --date=short --no-merges --format='%ad %ae %s' 2019-04-23 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@f153e221140a The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@chromium.org Change-Id: I8d8a2a6918ddfe952ae9482a3095ca433507abef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578349 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653098} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit fe5c343e3bbf81731a2cf206fd9f70371df0e1e2 Author: Ben Wells <benwells@chromium.org> Date: Tue Apr 23 07:41:37 2019 +0000 Add API tests for chrome.management.installReplacementWebApp. Bug: 944397 Change-Id: Ied196867a1115cbd77f78cded6a7e13572d4c196 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573300 Commit-Queue: Ben Wells <benwells@chromium.org> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#653097} .../api/management/management_apitest.cc | 104 ++++++++++++++++++++- .../web_applications/components/install_manager.cc | 5 +- .../bad_web_app/index.html | 1 + .../good_web_app/image-512px.png | Bin 0 -> 5872 bytes .../good_web_app/index.html | 12 +++ .../good_web_app/manifest.json | 12 +++ .../install_replacement_web_app/good_web_app/sw.js | 6 ++ .../api/management/management_api_constants.cc | 2 +- 8 files changed, 139 insertions(+), 3 deletions(-) commit 33e6967d22a082c5b862d68dc20dd6621103376e Author: Donna Wu <donna.wu@intel.com> Date: Tue Apr 23 07:40:58 2019 +0000 Use USB Mojo interfaces in usb_printer_util on ChromeOS Bug: 699790 Change-Id: I07c8bdfa0a6bd6cf3f4b62ee7e1fb50fbed73d3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560897 Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Donna Wu <donna.wu@intel.com> Cr-Commit-Position: refs/heads/master@{#653096} chrome/browser/chromeos/BUILD.gn | 1 + .../chromeos/printing/usb_printer_detector.cc | 26 ++--- .../browser/chromeos/printing/usb_printer_util.cc | 110 +++++++++++++-------- .../browser/chromeos/printing/usb_printer_util.h | 24 +++-- 4 files changed, 101 insertions(+), 60 deletions(-) commit 0d30a8fced40e04bf17231cd53a1ecf1b1ed7dc6 Author: Koji Ishii <kojii@chromium.org> Date: Tue Apr 23 07:33:55 2019 +0000 Revert "Use WTF::ListHashSet default inline capacity" This reverts commit aa2b2d07efb7ed721436d62da72e9b9ccfb29386. Reason for revert: crbug.com/955315 perf regression in layer_overlap* Original change's description: > Use WTF::ListHashSet default inline capacity > > This is a step towards replacing WTF::ListHashSet by WTF::LinkedHashSet. > Particularly, this CL changes the inline capacity values used today > in ToT with WTF::ListHashSet to its default value. > > Reason: ListedHashSet, our target class to replace ListHashSet, does > not support inline capacity. In order to verify whether it needs to support > it or not, this CL experiments with removing the call sites that set an > explicit inline capacity to ListHashSet and watches out for performance > regressions, if any. > > In case no performance regressions are observed, a next CL will remove > the inline capacity support of ListedHashSet altogether, making its > replacement by LinkedHashSet more straightforward. > > R=​haraken@chromium.org > CC=​blink-reviews-vendor@chromium.org > > BUG=614112 > > Change-Id: I58e17ba181ad7077ea0cfa740bc80ec1f696b76e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575747 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> > Cr-Commit-Position: refs/heads/master@{#653027} TBR=haraken@chromium.org,tonikitoo@igalia.com Change-Id: Ie130ab77dd52936b4f23c6951f906c5a199e11bb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 614112 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578151 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#653095} third_party/blink/renderer/core/dom/tree_ordered_list.h | 8 ++++---- third_party/blink/renderer/core/layout/floating_objects.h | 2 +- third_party/blink/renderer/core/layout/layout_block.h | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) commit bc919dc3a1de6c8dab04de49ff4de7cb4efb5507 Author: Minggang Wang <minggang.wang@intel.com> Date: Tue Apr 23 07:24:02 2019 +0000 ServiceWorker: Make the script_loader_factory non-associated The current script_loader_factory_ptr_info is defined as associated in the service_worker_provider.mojom, which is unnecessary. This CL makes it to be non-associated. BUG=949543 Change-Id: I67f82fa2605e12ec6534e219a9e4b7ea6fbd8d9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577278 Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Minggang Wang <minggang.wang@intel.com> Cr-Commit-Position: refs/heads/master@{#653094} content/browser/service_worker/embedded_worker_instance.cc | 11 +++++------ content/browser/service_worker/embedded_worker_instance.h | 7 +++---- .../service_worker_network_provider_for_service_worker.cc | 3 +-- .../service_worker_network_provider_for_service_worker.h | 5 ++--- .../public/mojom/service_worker/service_worker_provider.mojom | 2 +- 5 files changed, 12 insertions(+), 16 deletions(-) commit 70d5c2e040336d154cb0e220798f38d531d680d6 Author: Stuart Langley <slangley@google.com> Date: Tue Apr 23 07:13:49 2019 +0000 ES6 conversion for progress_center_common.js Bug: 778674 Change-Id: I046748ce29aca4a1f2eb33e411de6f6fff8e2727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575311 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#653093} .../common/js/progress_center_common.js | 160 ++++++++++----------- 1 file changed, 79 insertions(+), 81 deletions(-) commit 67199f3e206a1686346c7d64c35c0de9c469d292 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Tue Apr 23 07:07:39 2019 +0000 Roll src-internal 4bedfed51327..fcc05e93113e (2 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4bedfed51327..fcc05e93113e Created with: gclient setdep -r src-internal@fcc05e93113e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=chcunningham@chromium.org,loyso@chromium.org,clamy@chromium.org,flackr@chromium.org Change-Id: I0152ff2c919b6de76bbeeaaaaef6ac24f6b68f05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578130 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653092} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 3346d365fa51a535ae0ef4a9fb81519db57699ee Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Apr 23 06:41:36 2019 +0000 Roll src/third_party/skia 977b16d9c978..f31ae87fe0cb (2 commits) https://skia.googlesource.com/skia.git/+log/977b16d9c978..f31ae87fe0cb git log 977b16d9c978..f31ae87fe0cb --date=short --no-merges --format='%ad %ae %s' 2019-04-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 c467f7b54188..cff6f150eae1 (1 commits) 2019-04-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 3ed0f75776bb..29e17ed23dea (265 commits) Created with: gclient setdep -r src/third_party/skia@f31ae87fe0cb The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@chromium.org Change-Id: Id3b9291b5328a32f32f8780fc2ab082042893693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578129 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653091} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 592d04e9f365e30ff2ab9262f03daa4457e218eb Author: David Tseng <dtseng@chromium.org> Date: Tue Apr 23 06:36:14 2019 +0000 Remove call to reverse when focusing nested iframes Follow / fix to https://chromium-review.googlesource.com/c/chromium/src/+/1577919/3/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js#453 TBR=dmazzoni@chromium.org Change-Id: I142e355d422c0eb23b22b3cb977413367439584a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577570 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#653090} .../browser/resources/chromeos/chromevox/cvox2/background/background.js | 1 - 1 file changed, 1 deletion(-) commit 34f92348c50b132938fdbdac17d5b4936aea4e47 Author: Hiroki Nakagawa <nhiroki@chromium.org> Date: Tue Apr 23 06:33:26 2019 +0000 Worker: Set AddressSpace in WorkerShadowPage WorkerShadowPage's AddressSpace is used for creating outside FetchClientSettingsObject. Lack of this setting causes CORS failures during off-the-main-thread worker script fetch when cors-rfc1918 is enabled. Bug: 945215 Change-Id: I787f23900960ee2bc517403f4b21937e4694da11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578138 Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#653089} third_party/blink/renderer/core/exported/web_shared_worker_impl.cc | 5 +++++ .../blink/renderer/modules/exported/web_embedded_worker_impl.cc | 5 +++++ .../cors-rfc1918/addressspace-serviceworker-basic-expected.txt | 4 ++-- .../cors-rfc1918/addressspace-sharedworker-basic-expected.txt | 6 ------ 4 files changed, 12 insertions(+), 8 deletions(-) commit c294c1a75753693c083c1e96167b548a44cc5a85 Author: Chromium WPT Sync <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Date: Tue Apr 23 06:23:08 2019 +0000 Import wpt@1333b3faf118f108341ff37a55e61d9309f9e7a8 Using wpt-import in Chromium 59d7b8c9593f8c6450cf431f483c2491e93dcd61. With Chromium commits locally applied on WPT: 0a8f3ffa48 "Use testdriver Action API in WPT pointerevent touch tests - Part 2" 4e9215207a "[Code Health] Remove unnecessary reference file for web test" 40465b7400 "[Animation Worklet] Copy the effects of a migrating animator over to new global scope" e28269b698 "[LayoutNG/PE] Clear visual overflow for LayoutText before setting." aff3c8feca "Add tests for crbug.com/363609 and crbug.com/954591" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I7f5b24fd4e358b0a0918139a91b9988ecc306c21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578123 Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653088} third_party/blink/web_tests/TestExpectations | 8 + .../web_tests/external/WPT_BASE_MANIFEST_6.json | 311 ++++++++++++++++++++- .../line-breaking/line-breaking-atomic-001.html | 24 ++ .../line-breaking/line-breaking-atomic-002.html | 33 +++ .../line-breaking/line-breaking-atomic-003.html | 22 ++ .../line-breaking/line-breaking-atomic-004.html | 22 ++ .../line-breaking/line-breaking-atomic-005.html | 22 ++ .../line-breaking/line-breaking-atomic-006.html | 22 ++ .../line-breaking/line-breaking-atomic-007.html | 24 ++ .../line-breaking/line-breaking-atomic-008.html | 32 +++ .../line-breaking/line-breaking-replaced-001.html | 23 ++ .../line-breaking/line-breaking-replaced-002.html | 23 ++ .../line-breaking/line-breaking-replaced-003.html | 23 ++ .../line-breaking/line-breaking-replaced-004.html | 17 ++ .../line-breaking/line-breaking-replaced-005.html | 18 ++ .../reference/line-breaking-atomic-003-ref.html | 15 + .../reference/line-breaking-atomic-005-ref.html | 15 + .../reference/line-breaking-atomic-007-ref.html | 15 + .../reference/line-breaking-atomic-008-ref.html | 15 + .../reference/line-breaking-replaced-001-ref.html | 9 + .../reference/line-breaking-replaced-002-ref.html | 9 + .../reference/line-breaking-replaced-003-ref.html | 9 + .../reference/line-breaking-replaced-004-ref.html | 9 + .../reference/line-breaking-replaced-005-ref.html | 9 + .../css/css-text/white-space/break-spaces-003.html | 1 - .../css/css-text/white-space/break-spaces-004.html | 1 - .../css/css-text/white-space/break-spaces-005.html | 1 - .../css/css-text/white-space/break-spaces-006.html | 1 - .../css/css-text/white-space/break-spaces-007.html | 1 - .../css/css-text/white-space/break-spaces-008.html | 1 - .../css/css-text/white-space/break-spaces-009.html | 2 - .../wpt/css/css-text/white-space/pre-wrap-008.html | 1 - .../wpt/css/css-text/white-space/pre-wrap-015.html | 1 - .../wpt/css/css-text/white-space/pre-wrap-016.html | 1 - .../white-space-break-spaces-005-ref.html | 1 - 35 files changed, 718 insertions(+), 23 deletions(-) commit 4d832e98fa67a6cbd1d5645549caa59e41bc5b45 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Tue Apr 23 05:56:47 2019 +0000 Roll src-internal 467fc379a09b..4bedfed51327 (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/467fc379a09b..4bedfed51327 Created with: gclient setdep -r src-internal@4bedfed51327 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=chcunningham@chromium.org,loyso@chromium.org,clamy@chromium.org,flackr@chromium.org Change-Id: I9f23256ca0182c55bf0a2befeca0c6a96de88a2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578128 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653087} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit db045f5e76d144588a32e0edc9841908c33c882e Author: Abhijeet Kandalkar <abhijeet@igalia.com> Date: Tue Apr 23 05:42:58 2019 +0000 Switch blink::Attr to use new downcast helpers Bug: 891908 Change-Id: I142e86e519f53de394c086dbd1e59992f25eae98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570326 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#653086} .../renderer/bindings/core/v8/v8_gc_controller.cc | 4 ++-- third_party/blink/renderer/core/dom/attr.h | 6 +++++- third_party/blink/renderer/core/dom/document.cc | 2 +- third_party/blink/renderer/core/dom/node.cc | 21 ++++++++++---------- .../core/editing/serializers/markup_accumulator.cc | 2 +- .../renderer/core/inspector/inspector_dom_agent.cc | 6 +++--- .../blink/renderer/core/xml/xpath_functions.cc | 6 +++--- .../blink/renderer/core/xml/xpath_node_set.cc | 11 ++++++----- third_party/blink/renderer/core/xml/xpath_step.cc | 23 +++++++++++----------- 9 files changed, 42 insertions(+), 39 deletions(-) commit 5c4614f7420e71db54f13300b211e3de4094c725 Author: 3su6n15k.default@developer.gserviceaccount.com <3su6n15k.default@developer.gserviceaccount.com> Date: Tue Apr 23 05:41:26 2019 +0000 Automated Commit: LKGM 12118.0.0 for chromeos. BUG=762641 TBR=oshima@google.com, xdai@google.com Change-Id: If4494a6adb4122d8cc0fa82c9d64e4dfe1279399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578125 Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653085} chromeos/CHROMEOS_LKGM | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 7f2afad68fc6c8c14ba314772f89116f34af0e0e Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Apr 23 05:40:37 2019 +0000 Roll src/third_party/skia c3186302bd8a..977b16d9c978 (1 commits) https://skia.googlesource.com/skia.git/+log/c3186302bd8a..977b16d9c978 git log c3186302bd8a..977b16d9c978 --date=short --no-merges --format='%ad %ae %s' 2019-04-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader bcc71a322953..707ed9974cb3 (3 commits) Created with: gclient setdep -r src/third_party/skia@977b16d9c978 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@chromium.org Change-Id: I98f8347e0428885b2003725ff1c735ee98ac1d8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578126 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653084} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 6dfa53b2ef78c49863fb7d07761c8394e936a6d9 Author: Kazuki Takise <takise@google.com> Date: Tue Apr 23 05:35:18 2019 +0000 Don't replay window state change sent from Android When Android sends a window state change to a shell surface whose widget hasn't been created, the widget is created first and the window state change is applied later, which ends up requesting a window state change back to Android. This happens when a window enters PIP via minimize and a new task is created in a minimized stack. state just after it entered PIP. Bug: b/130125505 Test: Confirmed a PIP window of VLC didn't go back to minimized Change-Id: I5159ceaa8cf81a7d6f2c042fd5bdfdd71ae07647 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573433 Reviewed-by: Mitsuru Oshima (Slow 4/22-26) <oshima@chromium.org> Commit-Queue: Kazuki Takise <takise@chromium.org> Cr-Commit-Position: refs/heads/master@{#653083} components/exo/client_controlled_shell_surface.cc | 4 +++- .../exo/client_controlled_shell_surface_unittest.cc | 19 +++++++++++++++++++ .../exo/test/test_client_controlled_state_delegate.cc | 4 ++++ 3 files changed, 26 insertions(+), 1 deletion(-) commit 5e5219081e7a9e8c6d476d4cf0f354678f78b851 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Apr 23 05:28:36 2019 +0000 Roll Fuchsia SDK from 891570654529 to 891542344871 The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I26b25a8230b8e40ccff71602bd3d477de6d9be94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578122 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653082} build/fuchsia/linux.sdk.sha1 | 2 +- build/fuchsia/mac.sdk.sha1 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit 286d9ff9b3cf5e0cbddf32bc6fbece58568884cd Author: Hwanseung Lee <hs1217.lee@samsung.com> Date: Tue Apr 23 04:55:04 2019 +0000 Remove CancelAll() function at menu_controller.h it was used for OneShotTimer. but it can replace with base::BindOnce using Cancel(). and other places which is just call it also can replace with Cancel(). Bug: 940736 Change-Id: I4c0bf87a347640048ef81c1386a13a5f0349caf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573315 Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#653081} .../browser/ui/views/bookmarks/bookmark_bar_view_test.cc | 15 +++++++++------ ui/views/controls/menu/menu_controller.cc | 13 +++++++------ ui/views/controls/menu/menu_controller.h | 4 ---- ui/views/controls/menu/menu_controller_unittest.cc | 12 ++++++------ ui/views/controls/menu/menu_host.cc | 4 ++-- ui/views/controls/menu/menu_pre_target_handler_aura.cc | 4 ++-- ui/views/controls/menu/menu_runner_impl.cc | 4 ++-- ui/views/controls/menu/menu_runner_unittest.cc | 4 ++-- 8 files changed, 30 insertions(+), 30 deletions(-) commit 24e9f563f698d839c246c12f79b4322742573141 Author: Junyi Xiao <juxiao@microsoft.com> Date: Tue Apr 23 04:49:04 2019 +0000 Devtools: a11y fixes for Service Worker view Accessibility testing revealed the following issues within the tool: 1. missing name for focusable controls 2. some of the links and buttons are not keyboard accessible This change adds: 1. aria-label to the input field 2. tab stop to those links and buttons mentioned above 3. better described placeholder message for the filter input and focus indicator 4. mark role as h1 and h2 for report tiltle and section header 5. test coverage see the gif: https://imgur.com/a/ycK3n70 Change-Id: I83c61c5b8abe91179451f1e7a07bde550011b9c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559704 Reviewed-by: Erik Luo <luoe@chromium.org> Commit-Queue: Junyi Xiao <juxiao@microsoft.com> Cr-Commit-Position: refs/heads/master@{#653080} .../devtools/front_end/components/Linkifier.js | 1 + .../front_end/resources/ServiceWorkersView.js | 67 +++++++++++++--------- .../front_end/resources/serviceWorkersView.css | 13 ++++- .../renderer/devtools/front_end/ui/ARIAUtils.js | 9 +++ .../renderer/devtools/front_end/ui/ReportView.js | 2 + .../devtools/front_end/ui/inspectorCommon.css | 11 ++++ .../service-worker-view-a11y-test-expected.txt | 5 ++ .../service-worker-view-a11y-test.js | 25 ++++++++ 8 files changed, 103 insertions(+), 30 deletions(-) commit 770cb4e33c0d215ceb8d12f69b5a75ff1eb34b35 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Tue Apr 23 04:45:14 2019 +0000 Roll src-internal 1a0208013d69..467fc379a09b (2 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1a0208013d69..467fc379a09b Created with: gclient setdep -r src-internal@467fc379a09b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=chcunningham@chromium.org,loyso@chromium.org,clamy@chromium.org,flackr@chromium.org Change-Id: I73cb26a9ed17db6263b90b7f04f14f4180b20bea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578121 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653079} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 32e3e6ae0bb019d6e6ed4fe23375ce2fd1ed4313 Author: Hirokazu Honda <hiroh@chromium.org> Date: Tue Apr 23 04:37:58 2019 +0000 components/arc: GpuArcVideoEncodeAccelerator: Remove EncodeDeprecated EncodeDeprecated is no longer used. This just remove the function from GpuArcVideoEncodeAccelerator. Bug: b:118544836 Test: CtsMediaTestCases Change-Id: Ifcad057da3cfeb27ca8adfcaac1d8c664017f636 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1567713 Reviewed-by: Kuang-che Wu <kcwu@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#653078} components/arc/common/video_encode_accelerator.mojom | 16 ---------------- .../gpu_arc_video_encode_accelerator.cc | 10 ---------- .../video_accelerator/gpu_arc_video_encode_accelerator.h | 5 ----- 3 files changed, 31 deletions(-) commit 7026e7c7140b1f3b44ac2e1a44af58d93e3fa7ee Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Tue Apr 23 04:24:53 2019 +0000 Revert "Update CCT to hide origin if requested by security interstitial." This reverts commit ff13eb075d3322425053da03c26eafdbd71530b9. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 653038 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZmYxM2ViMDc1ZDMzMjI0MjUwNTNkYTAzYzI2ZWFmZGJkNzE1MzBiOQw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.mac/Mac10.11%20Tests/36826 Sample Failed Step: browser_tests on (none) GPU on Mac on Mac-10.11 Sample Flaky Test: CustomTabBarViewBrowserTest.InterstitialCanHideOrigin Original change's description: > Update CCT to hide origin if requested by security interstitial. > > This CL modifies the behavior of CCTs such that they hide the > origin of a page and page info button if there is an active security > interstitial that requests it. This brings the behavior in line with > that of desktop and mobile. > > Bug: 939601 > Change-Id: I6c46cb4918871b9d2a760a72bee742fc7867e1b7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570415 > Reviewed-by: Jay Harris <harrisjay@chromium.org> > Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> > Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> > Cr-Commit-Position: refs/heads/master@{#653038} Change-Id: Idcc560a6b4b99d033fafe5971e6b8b715ac60d73 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 939601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578124 Cr-Commit-Position: refs/heads/master@{#653077} .../ui/views/location_bar/custom_tab_bar_view.cc | 32 +------- .../ui/views/location_bar/custom_tab_bar_view.h | 1 - .../custom_tab_bar_view_browsertest.cc | 85 ---------------------- 3 files changed, 4 insertions(+), 114 deletions(-) commit 59d7b8c9593f8c6450cf431f483c2491e93dcd61 Author: Chromium WPT Sync <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Date: Tue Apr 23 04:11:09 2019 +0000 Import wpt@9e1c19d759da5d72edf384f4fd47dde17b261543 Using wpt-import in Chromium a4b8fc38b62da894dc4f8e441afdb7f1b42bb129. With Chromium commits locally applied on WPT: 0a8f3ffa48 "Use testdriver Action API in WPT pointerevent touch tests - Part 2" 4e9215207a "[Code Health] Remove unnecessary reference file for web test" 40465b7400 "[Animation Worklet] Copy the effects of a migrating animator over to new global scope" e28269b698 "[LayoutNG/PE] Clear visual overflow for LayoutText before setting." aff3c8feca "Add tests for crbug.com/363609 and crbug.com/954591" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I580e20c3020fbd9d7bfed13d7f26b5244c4651a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577906 Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653076} .../web_tests/external/WPT_BASE_MANIFEST_6.json | 109 +++++++++++++++++---- .../css/css-text/parsing/word-break-invalid.html | 7 +- .../wpt/css/css-text/parsing/word-break-valid.html | 3 +- 3 files changed, 96 insertions(+), 23 deletions(-) commit 0cdabc91b17c8bae0ffc12b4da51f6815c51efca Author: Wei Lee <wtlee@google.com> Date: Tue Apr 23 04:06:19 2019 +0000 Moves interfaces of MJDA for Chrome OS Camera to specific folder This CL moves interfaces of MJDA that only used by Chrome OS Camera from media/mojo/interfaces to components/chromeos_camera. It makes the ownership more clear. Bug: 946366 Test: Compiles successfully and camera works normally. Change-Id: Ic978ddf00322793ed2a5e3ec709f29e739e76cef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564272 Reviewed-by: Luke Sorenson <lasoren@chromium.org> Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Reviewed-by: Christian Fremerey <chfremer@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#653075} .../media_perception_api_delegate_chromeos.cc | 2 +- components/chromeos_camera/common/BUILD.gn | 1 + .../common}/mjpeg_decode_accelerator.mojom | 1 + .../common}/mjpeg_decode_accelerator.typemap | 9 +++--- .../mjpeg_decode_accelerator_mojom_traits.cc | 2 +- .../mjpeg_decode_accelerator_mojom_traits.h | 8 ++--- components/chromeos_camera/common/typemaps.gni | 6 ++-- components/viz/host/gpu_client.cc | 2 ++ components/viz/host/gpu_client.h | 3 ++ .../host_gpu_memory_buffer_manager_unittest.cc | 5 +-- components/viz/service/gl/gpu_service_impl.cc | 15 +++++---- components/viz/service/gl/gpu_service_impl.h | 4 +-- content/browser/BUILD.gn | 15 ++++++--- ...e_to_browser_gpu_service_accelerator_factory.cc | 4 +-- .../{ => chromeos}/video_capture_dependencies.cc | 2 +- .../{ => chromeos}/video_capture_dependencies.h | 8 ++--- .../media/fake_video_capture_device_launcher.cc | 19 ++++++++--- .../in_process_video_capture_device_launcher.cc | 16 ++++++++-- .../renderer_host/media/media_stream_manager.cc | 2 +- .../media/service_video_capture_provider.cc | 37 ++++++++++++++++------ .../media/service_video_capture_provider.h | 10 ++++-- .../service_video_capture_provider_unittest.cc | 5 +++ .../media/video_capture_browsertest.cc | 2 ++ .../media/video_capture_controller_unittest.cc | 14 +++++++- content/public/browser/BUILD.gn | 6 +++- ...te_to_browser_gpu_service_accelerator_factory.h | 6 ++-- media/capture/BUILD.gn | 12 +++---- .../video/chromeos/camera_hal_dispatcher_impl.h | 2 ++ .../video/chromeos/mojo/cros_camera_service.mojom | 2 +- .../scoped_video_capture_jpeg_decoder.cc | 2 +- .../scoped_video_capture_jpeg_decoder.h | 8 ++--- .../video_capture_device_factory_chromeos.h | 4 +++ .../{ => chromeos}/video_capture_jpeg_decoder.h | 6 ++-- .../video_capture_jpeg_decoder_impl.cc | 5 +-- .../video_capture_jpeg_decoder_impl.h | 11 ++++--- media/capture/video/video_capture_device_client.cc | 20 +++++++++++- media/capture/video/video_capture_device_client.h | 10 +++++- .../video/video_capture_device_client_unittest.cc | 13 +++++++- media/capture/video/video_capture_device_factory.h | 4 --- media/mojo/DEPS | 6 ++++ media/mojo/clients/BUILD.gn | 29 +++++++++-------- ...or.cc => cros_mojo_mjpeg_decode_accelerator.cc} | 28 ++++++++-------- ...ator.h => cros_mojo_mjpeg_decode_accelerator.h} | 18 +++++------ media/mojo/interfaces/BUILD.gn | 1 - media/mojo/interfaces/typemaps.gni | 1 - media/mojo/services/BUILD.gn | 9 ++++-- media/mojo/services/DEPS | 3 ++ ... cros_mojo_mjpeg_decode_accelerator_service.cc} | 27 ++++++++-------- ...> cros_mojo_mjpeg_decode_accelerator_service.h} | 16 +++++----- ...o_mjpeg_decode_accelerator_service_unittest.cc} | 21 ++++++------ .../device_factory_media_to_mojo_adapter.cc | 14 ++++++++ .../device_factory_media_to_mojo_adapter.h | 13 ++++++-- .../video_capture/device_factory_provider_impl.cc | 15 +++++++++ .../video_capture/device_factory_provider_impl.h | 3 +- .../video_capture/device_media_to_mojo_adapter.cc | 25 +++++++++++++-- .../video_capture/device_media_to_mojo_adapter.h | 14 +++++++- .../device_media_to_mojo_adapter_unittest.cc | 6 ++++ .../public/cpp/mock_device_factory_provider.cc | 2 ++ .../public/cpp/mock_device_factory_provider.h | 3 ++ services/video_capture/public/mojom/BUILD.gn | 4 +++ .../public/mojom/device_factory_provider.mojom | 5 ++- .../test/mock_device_shared_access_unittest.cc | 5 +++ services/video_capture/test/mock_device_test.cc | 7 +++- .../viz/privileged/interfaces/gl/gpu_service.mojom | 4 ++- services/ws/public/cpp/gpu/gpu.cc | 4 +++ services/ws/public/cpp/gpu/gpu.h | 2 ++ services/ws/public/cpp/tests/gpu_unittest.cc | 2 ++ services/ws/public/mojom/BUILD.gn | 5 ++- services/ws/public/mojom/gpu.mojom | 4 ++- 69 files changed, 426 insertions(+), 173 deletions(-) commit 8c4d7e09f2d4bde9c950f8c42d318b0687cc7510 Author: Daniel Cheng <dcheng@chromium.org> Date: Tue Apr 23 04:04:01 2019 +0000 Remove external header dependencies from //base/component_export.h Change-Id: I126b339910a3105326b8bea95aaaccdbc857ae1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578000 Reviewed-by: Ken Rockot <rockot@google.com> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#653074} base/component_export.h | 2 -- 1 file changed, 2 deletions(-) commit 29e17ed23dea53930edde4cbc7cedb8abedb7c20 Author: Erik Jensen <rkjnsn@chromium.org> Date: Tue Apr 23 03:42:58 2019 +0000 remoting: Add host name for One Platform API endpoint. Change-Id: If6fb006933488778f47846cdcac1a2c239a856f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576279 Reviewed-by: Joe Downing <joedow@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#653073} remoting/base/service_urls.cc | 9 ++++++++- remoting/base/service_urls.h | 5 +++++ 2 files changed, 13 insertions(+), 1 deletion(-) commit e2a9eed27365c390d759ed1e94aee5cb86ae91fd Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Tue Apr 23 03:40:08 2019 +0000 Roll src-internal cd9b4083b9f2..1a0208013d69 (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cd9b4083b9f2..1a0208013d69 Created with: gclient setdep -r src-internal@1a0208013d69 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=chcunningham@chromium.org,loyso@chromium.org,clamy@chromium.org,flackr@chromium.org Change-Id: Ib6bc5b30b6ac3cc1c193da42c9f0f85eef2ebab8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577569 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653072} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 6951fc3c5fe684cfb6157e9e00b06a65cd867e44 Author: Miyoung Shin <myid.shin@igalia.com> Date: Tue Apr 23 03:33:28 2019 +0000 Replace use of std::map with WTF's equivalent in rejected_promises.cc Replace the use of std::map of std container with WTF::HashMap in rejected_promises.cc. Bug: 952716 Change-Id: I3d67ef2401369dd2ed9bbc4151e62221b160e02c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577230 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#653071} .../blink/renderer/bindings/core/v8/rejected_promises.cc | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) commit 74273a1532bc220dc1c66e3d099c26e301715885 Author: David Tseng <dtseng@chromium.org> Date: Tue Apr 23 03:26:02 2019 +0000 Fixes navigation across widgets on login screen On the login screen, the |nextFocus| and |previousFocus| attributes point to the next/previous widgets respectively. Due to the way focus gets managed per widget, the backing C++ code can only resolve to the widget level and not directly to each view. For example: widget: shelf toolbar has next focus widget status tray An accessibility service such as ChromeVox needs to follow these links and then descend into the widget to find the first or last focusable view e.g. in the shelf, the add person button. Test: chrome --login-manager navigate with ChromeVox using both Search+Right, and Search+Left on the sign in screen. Focus should move to all controls, including add person button, status tray button, in both directions. Change-Id: Idf2d720ff1d12facf8cb6fa6490e2c789e55843d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576168 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#653070} .../chromevox/cvox2/background/automation_predicate.js | 3 ++- .../chromevox/cvox2/background/automation_util.js | 5 ++++- .../chromevox/cvox2/background/automation_util_test.extjs | 15 +++++++++------ .../chromeos/chromevox/cvox2/background/cursors.js | 6 +----- 4 files changed, 16 insertions(+), 13 deletions(-) commit 93aa8975c5549b51110f34e81635b39be4a373b5 Author: chrome-release-bot <chrome-release-bot@chromium.org> Date: Tue Apr 23 03:16:25 2019 +0000 Updating trunk VERSION from 3774.0 to 3775.0 # This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: I0d8d13aa63fe7d9ed9b5bbf78872dd8b56d39b53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578240 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#653069} chrome/VERSION | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit dd7812df3188fd7d5a8245992a7f5cb00aa8d65b Author: Christopher Cameron <ccameron@chromium.org> Date: Tue Apr 23 03:12:21 2019 +0000 Change gpu::SharedContextState::use_vulkan_gr_context() Add a MetalContextCreator to gpu::SharedContextState, and replace the calls to use_vulkan_gr_context with the more specific calls to GrContextIsGL, GrContextIsVulkan, and GrContextIsMetal. Bug: 952063 Change-Id: I1da0c9e40072b7cfecb287b631ead3dc3b9fe529 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577794 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#653068} android_webview/browser/gfx/surfaces_instance.h | 3 +- .../skia_output_surface_impl_non_ddl.cc | 20 +++++-------- gpu/command_buffer/service/BUILD.gn | 1 + gpu/command_buffer/service/DEPS | 1 + .../service/external_vk_image_backing.cc | 2 +- gpu/command_buffer/service/raster_decoder.cc | 6 ++-- gpu/command_buffer/service/shared_context_state.cc | 34 +++++++++++++++------- gpu/command_buffer/service/shared_context_state.h | 14 ++++++--- ...shared_image_backing_factory_ahardwarebuffer.cc | 3 +- gpu/command_buffer/service/shared_image_factory.cc | 2 +- 10 files changed, 51 insertions(+), 35 deletions(-) commit d24702349474117241f4f1e34881d6fece98386e Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Apr 23 03:05:21 2019 +0000 Roll src/third_party/swiftshader 4f15ce2eb993..707ed9974cb3 (2 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/4f15ce2eb993..707ed9974cb3 git log 4f15ce2eb993..707ed9974cb3 --date=short --no-merges --format='%ad %ae %s' 2019-04-23 chrisforbes@google.com Add support for OpAtomicISub, OpAtomicIIncrement, OpAtomicIDecrement 2019-04-23 chrisforbes@google.com Add support for OpExtension Created with: gclient setdep -r src/third_party/swiftshader@707ed9974cb3 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/127472316,chromium:b/130937460 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I33ef25071249ed460dbabb5ea3b006f791b8120a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577568 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653067} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit bb354d5e3c4902f122f0a109b18e48af2ef2d645 Author: Ian Barkley-Yeung <iby@chromium.org> Date: Tue Apr 23 03:04:11 2019 +0000 Measure # of login crash loops Histograms.xml changes for crrev.com/c/1574738 BUG=chromium:857317 TEST=Viewed histograms in Chrome R=jkardatzke@chromium.org Change-Id: Id4b4b78de50b9eee8589dc7a02e1ade834e568ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574623 Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Jeffrey Kardatzke <jkardatzke@google.com> Commit-Queue: Ian Barkley-Yeung <iby@chromium.org> Auto-Submit: Ian Barkley-Yeung <iby@chromium.org> Cr-Commit-Position: refs/heads/master@{#653066} tools/metrics/histograms/enums.xml | 9 +++++++++ tools/metrics/histograms/histograms.xml | 8 ++++++++ 2 files changed, 17 insertions(+) commit bbca5afc9bad3a8064df1baf92159bac73163257 Author: David Tseng <dtseng@chromium.org> Date: Tue Apr 23 02:56:31 2019 +0000 Suppress load complete events on roots with no url populated Bug: 948906 Change-Id: I5ed95c58088ed2e688488b339454c3fdb4d23dd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577850 Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#653065} .../chromevox/cvox2/background/desktop_automation_handler.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) commit 945f1210cddb0b351e16918bd8bd863b21ecac7a Author: sczs <sczs@chromium.org> Date: Tue Apr 23 02:44:07 2019 +0000 [ios] Adds support for Infobar Modal dynamic height. - The InfobarModal will now change its height so it can contain its content. In case the content's height is larger than the screen we can scroll the Modal. Screenshot: https://drive.google.com/open?id=1paoV27CdDMaF0tTQ8vHgvF37z0tMtv4K https://drive.google.com/open?id=1dI725bQX5qyqu3FvgEndBIeCFCCdh0EA Bug: 911864 Change-Id: Ie5142259f6bd6a449f2a4350875e4be41c5840d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575119 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by: Chris Lu <thegreenfrog@chromium.org> Reviewed-by: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#653064} .../coordinators/infobar_confirm_coordinator.mm | 7 ++++++ .../infobars/coordinators/infobar_coordinator.mm | 17 ++++++++++++++- .../infobar_coordinator_implementation.h | 3 +++ .../coordinators/infobar_password_coordinator.mm | 7 ++++++ .../infobar_password_table_view_controller.mm | 7 +++++- .../browser/ui/infobars/presentation/BUILD.gn | 1 + .../presentation/infobar_modal_positioner.h | 18 ++++++++++++++++ .../infobar_modal_presentation_controller.h | 5 +++++ .../infobar_modal_presentation_controller.mm | 25 ++++++++++++++-------- .../presentation/infobar_modal_transition_driver.h | 5 +++++ .../infobar_modal_transition_driver.mm | 1 + .../infobars/sc_infobar_banner_coordinator.mm | 12 ++++++++++- 12 files changed, 96 insertions(+), 12 deletions(-) commit e7b4a01e16aa707520fa84223aec9fe8f2695f4b Author: Alexei Filippov <alph@chromium.org> Date: Tue Apr 23 02:38:47 2019 +0000 [heap profiler] Refactor json_writer to use base::Value BUG=923459 Change-Id: I115ecb687e2bd4de609f4f52a4e4439d02515420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578001 Reviewed-by: Erik Chen <erikchen@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#653063} .../services/heap_profiling/connection_manager.cc | 4 +- .../services/heap_profiling/json_exporter.cc | 418 +++++++-------------- components/services/heap_profiling/json_exporter.h | 7 +- .../heap_profiling/json_exporter_unittest.cc | 22 +- 4 files changed, 156 insertions(+), 295 deletions(-) commit 912d62fa7b9852c0e6db803348294f15205ba94c Author: Maggie Cai <mxcai@chromium.org> Date: Tue Apr 23 02:35:07 2019 +0000 Turn on intent picker flag by default. This CL turns on the intent picker flag by default. BUG=939205 Change-Id: Idb625f17c0d81bb2ebbc478a00c9381b61f5001d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575304 Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#653062} chrome/common/chrome_features.cc | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) commit ebd63639c3172a4bdfb44a628cc61fa69f2f1d39 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Tue Apr 23 02:29:22 2019 +0000 Roll src-internal 6a76dff6be38..cd9b4083b9f2 (2 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6a76dff6be38..cd9b4083b9f2 Created with: gclient setdep -r src-internal@cd9b4083b9f2 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=chcunningham@chromium.org,loyso@chromium.org,clamy@chromium.org,flackr@chromium.org Change-Id: Id5c0c4988edff44b9049218c722a625562de5329 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577567 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653061} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit a4b8fc38b62da894dc4f8e441afdb7f1b42bb129 Author: Mohamed Heikal <mheikal@chromium.org> Date: Tue Apr 23 02:24:32 2019 +0000 Allow native code running in reduced mode to launch full browser This cl implements NativeStartupBridge which allows native code running in reduced mode to interface with java and launch full browser. The first client of this is DownloadService which is being refactored into being able to run in reduced mode but may require launching full browser if needed. Change-Id: I27d2d7cb4a7d89fa376698e7773a6d41b5daf4d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572529 Reviewed-by: David Trainor <dtrainor@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#653060} chrome/android/BUILD.gn | 1 + chrome/android/chrome_java_sources.gni | 1 + .../chrome/browser/init/NativeStartupBridge.java | 47 ++++++++++++++++++++++ chrome/browser/BUILD.gn | 2 + chrome/browser/android/startup_bridge.cc | 25 ++++++++++++ chrome/browser/android/startup_bridge.h | 12 ++++++ tools/metrics/histograms/histograms.xml | 11 +++++ 7 files changed, 99 insertions(+) commit 451fa18dae5bf98920fd4f0f0614b23fa5b6b6d7 Author: Koji Ishii <kojii@chromium.org> Date: Tue Apr 23 02:23:52 2019 +0000 [LayoutNG] Move paint invalidations to layout This patch moves paint invalidations from NGPaintFragment creation to layout code. Style and layout knows what were really changed, and should be smarter to invalidate. This patch matches paint invalidations for inline boxes to legacy in most cases. 1. Text boxes will always be FullPaintInvalidation. There maybe cases where legacy can skip it, as it does so when InlineTextBox is moved. This is to be investigated in future caching code. 2. Inline boxes (LayoutInline) is FullPaintInvalidation if it produces box fragments (DisplayItemClient). Otherwise NG does no paint invalidation. Legacy does |CheckForPaintInvalidation| even when it's culled, but this doesn't seem necessary. This patch avoids paint invalidations on position changes for the test case in crbug.com/950373. Bug: 950373 Change-Id: I0b80a527ef4243e5a5eb5dc59a2fd9d52a913c39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574982 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#653059} .../blink/renderer/core/layout/layout_object.h | 18 ++++++- .../core/layout/ng/inline/ng_inline_box_state.cc | 4 ++ .../layout/ng/inline/ng_inline_layout_algorithm.cc | 9 ++-- .../renderer/core/paint/ng/ng_paint_fragment.cc | 9 ---- ...ne-paint-with-layout-invalidations-expected.txt | 55 +++++++++++++++++++ .../background-resize-height-expected.txt | 50 +++++++++--------- .../paint/invalidation/bugzilla-3509-expected.txt | 4 +- .../paint/invalidation/bugzilla-6278-expected.txt | 20 +++---- .../remove-squashed-layer-plus-move-expected.txt | 61 ++++++++++++++++++++++ .../line-flow-with-floats-1-expected.txt | 4 +- .../line-flow-with-floats-5-expected.txt | 5 -- .../line-flow-with-floats-8-expected.txt | 5 -- .../selection/selection-clear-expected.txt | 4 +- ...dth-height-change-content-box-size-expected.txt | 10 ++-- ...ze-centered-inline-under-fixed-pos-expected.txt | 9 +--- 15 files changed, 190 insertions(+), 77 deletions(-) commit 2ffdc739c1eb9a15e84237cb82e7c73659340e0b Author: Kenneth Russell <kbr@chromium.org> Date: Tue Apr 23 02:20:44 2019 +0000 Add kainino@ as Chrome GPU testing co-owner. Kai has made significant contributions to the test infrastructure and should be a co-owner of the files. Bug: none Change-Id: I20aa18127fb7d066c69b3d1fcdceba4ecd646be6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578070 Reviewed-by: Zhenyao Mo <zmo@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#653058} content/test/gpu/OWNERS | 1 + 1 file changed, 1 insertion(+) commit 98a4dac310f54916b4f007bff7972d8397b3d98a Author: Yeol <peary2@gmail.com> Date: Tue Apr 23 02:04:46 2019 +0000 Changed views::BubbleFrameView::CreateCloseButton() to return std::unique_ptr In order to better convey property object ownership, changed CreateCloseButton() to return std::unique_ptr. Bug: 948266 Change-Id: I781ee11dd46d80d41d61eb65e88ce265d88313e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575878 Reviewed-by: Dana Fried <dfried@chromium.org> Commit-Queue: Yeol Park <peary2@gmail.com> Cr-Commit-Position: refs/heads/master@{#653057} .../apps/app_info_dialog/app_info_dialog_container.cc | 5 ++--- ui/views/bubble/bubble_frame_view.cc | 17 +++++++++-------- ui/views/bubble/bubble_frame_view.h | 3 ++- 3 files changed, 13 insertions(+), 12 deletions(-) commit a8545184faa99789e413b6bd9beb487f37272042 Author: Miyoung Shin <myid.shin@igalia.com> Date: Tue Apr 23 02:03:20 2019 +0000 Add Manifest struct converters This is a part of moving manifest implementation to blink and the precursor patch before moving content::ManifestManager to blink and will be used for RequestManifestCallback in blink::ManifestManager to convert from blink::Manifest to blink::mojom::blink::ManifestPtr. Bug: 704441 Change-Id: Iafb5d052f927d6200f7780c5d3537f2120b74ab7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575258 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#653056} .../blink/renderer/modules/manifest/BUILD.gn | 2 + .../modules/manifest/manifest_type_converters.cc | 213 +++++++++++++++++++++ .../modules/manifest/manifest_type_converters.h | 63 ++++++ 3 files changed, 278 insertions(+) commit 97222db6eca545383e9d6ff72986dd284a5e95c5 Author: Matthew Mourgos <mmourgos@chromium.org> Date: Tue Apr 23 02:00:39 2019 +0000 cros: Split AppListSearchResultOpenTypeV2 by clamshell and tablet mode Bug: 953525 Change-Id: If7c8d9e27c57ae6023e3b3ffcf035f5f2cad621d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574901 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#653055} ash/app_list/app_list_controller_impl.cc | 2 +- ash/public/cpp/app_list/app_list_metrics.cc | 14 +++++++++++++- ash/public/cpp/app_list/app_list_metrics.h | 3 ++- chrome/browser/ui/app_list/app_list_client_impl.cc | 3 ++- tools/metrics/histograms/histograms.xml | 3 +++ 5 files changed, 21 insertions(+), 4 deletions(-) commit 0459de05ee52cfd04ea045487aebd9adf2a294b9 Author: Robert Ogden <robertogden@chromium.org> Date: Tue Apr 23 01:59:14 2019 +0000 Enable Reloads as Soft Opt Outs by default Bug: 914029 Change-Id: I74f924a9b3b937ea2ceee1015d26322214ad3393 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576149 Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Reviewed-by: Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#653054} components/previews/core/previews_features.cc | 2 +- testing/variations/fieldtrial_testing_config.json | 15 --------------- 2 files changed, 1 insertion(+), 16 deletions(-) commit 1c361c87bc116eacb8b7d338e1a65e6ebafda9f6 Author: Pavel Feldman OOO <pfeldman@chromium.org> Date: Tue Apr 23 01:52:34 2019 +0000 Revert "[DevTools] Disable contrast information in inspect tooltip" This reverts commit 568f3235767392764ddb1082f7d7b285b7e4164f. Reason for revert: there is a better fix, uploading shortly. Original change's description: > [DevTools] Disable contrast information in inspect tooltip > > Calculating contrast ratio has performance issues on large DOMs. > Disabling until further investigation to not regress existing users. > > Bug: 951817 > Change-Id: I564e0b42d84771d61e58488412e96969a3326294 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570646 > Reviewed-by: Erik Luo <luoe@chromium.org> > Commit-Queue: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#651482} TBR=dgozman@chromium.org,luoe@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 951817 Change-Id: Ie377f84793a00b6d139380d94d37d74987379b91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577866 Reviewed-by: Pavel Feldman OOO <pfeldman@chromium.org> Commit-Queue: Pavel Feldman OOO <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#653053} third_party/blink/renderer/core/inspector/inspect_tools.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 9c9fa4a7a783e2ff8b04a5323dcbc5184c6fb3b8 Author: Bailey Berro <baileyberro@chromium.org> Date: Tue Apr 23 01:52:21 2019 +0000 Introduce Printer::IsUsbProtocol method - Adds an IsUsbProtocol method to the Printer class for determining whether the printer is a USB printer - Fixes incorrect comment wrapping Bug: 951136 Change-Id: I7802db79b608931eda466c1434e72ac7c1ca1124 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1567885 Reviewed-by: Sean Kau <skau@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#653052} chrome/browser/chromeos/printing/cups_printers_manager.cc | 13 ++++--------- chromeos/printing/printer_configuration.cc | 11 +++++++++++ chromeos/printing/printer_configuration.h | 4 ++++ 3 files changed, 19 insertions(+), 9 deletions(-) commit 7968b899c6cd74f2a01b33a03c70bdb3a2aaca86 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Apr 23 01:42:23 2019 +0000 Roll src/third_party/catapult 4b68d1e3e421..fb33e51cc0d8 (1 commits) https://chromium.googlesource.com/catapult.git/+log/4b68d1e3e421..fb33e51cc0d8 git log 4b68d1e3e421..fb33e51cc0d8 --date=short --no-merges --format='%ad %ae %s' 2019-04-22 ntfschr@chromium.org devil: better error output for invalid signature Created with: gclient setdep -r src/third_party/catapult@fb33e51cc0d8 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:955135 TBR=charliea@chromium.org Change-Id: I8ecc10c44aa5d02d94e774be240962271fd9b7cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578021 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653051} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit fd7417b96a6d114c6940fb42bb714ee532a38766 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Apr 23 01:40:26 2019 +0000 Roll src/third_party/pdfium 4fcc1f28e25e..0f35a9ee0be1 (4 commits) https://pdfium.googlesource.com/pdfium.git/+log/4fcc1f28e25e..0f35a9ee0be1 git log 4fcc1f28e25e..0f35a9ee0be1 --date=short --no-merges --format='%ad %ae %s' 2019-04-23 tsepez@chromium.org Use unique ptrs to free all varieties of annots. 2019-04-23 thestig@chromium.org Roll third_party/libjpeg_turbo/ 61a2bbaa9..2de84a43e (5 commits) 2019-04-22 tsepez@chromium.org Separate CXFA_ViewLayoutItem from CXFA_FFPageView. 2019-04-22 tsepez@chromium.org Use CFX_RectF::ToFloatRect() instead of explicit arithmetic. Created with: gclient setdep -r src/third_party/pdfium@0f35a9ee0be1 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:922430 TBR=dsinclair@chromium.org Change-Id: Ib82663ca76b2f836c354525ca8fff376e6492b6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577655 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653050} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e3b4260ee889203e9d9ec9852412f7a767018417 Author: Tim Song <tengs@chromium.org> Date: Tue Apr 23 01:32:24 2019 +0000 Ash Tray: Hide user chooser view when changing brightness or volume. Unlike other detailed views, the UserChooserView is not created using the DetailedViewController, so it is not properly hidden after the brightness/volume buttons are pressed. TEST=new unit test, manually verified BUG=953658 Change-Id: Ifc7d63249811f725ffaccc643171cdccaff3da52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572812 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#653049} ash/BUILD.gn | 2 ++ .../unified/unified_system_tray_controller.cc | 8 +++-- .../unified_system_tray_controller_unittest.cc | 14 +++++++++ ash/system/unified/unified_system_tray_view.h | 2 ++ .../user_chooser_detailed_view_controller.cc | 22 ++++++++++++++ .../user_chooser_detailed_view_controller.h | 34 ++++++++++++++++++++++ 6 files changed, 79 insertions(+), 3 deletions(-) commit e818bc227e8f0f25f8243019f5f10a90e14af3db Author: Joel Hockey <joelhockey@chromium.org> Date: Tue Apr 23 01:27:19 2019 +0000 Crostini USB settings page ui tweaks Capitalized USB, changed list to use 'list-item' class which removes top line from first list item. Bug: 951519 Change-Id: I0aebf186bd8d6ecd44c4f7b86977a7594c982142 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1563590 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by: Nicholas Verne <nverne@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#653048} chrome/app/settings_strings.grdp | 2 +- .../settings/crostini_page/crostini_shared_usb_devices.html | 7 +++---- 2 files changed, 4 insertions(+), 5 deletions(-) commit 7f4d96f0586a712c62d011a7884c8aab4e9be3a1 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Tue Apr 23 01:26:17 2019 +0000 Roll src-internal 279cf61c3dec..6a76dff6be38 (3 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/279cf61c3dec..6a76dff6be38 Created with: gclient setdep -r src-internal@6a76dff6be38 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:b/129156659 TBR=chcunningham@chromium.org,loyso@chromium.org,clamy@chromium.org,flackr@chromium.org Change-Id: I2caee37a927032318d940a326f5502e093613d24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578023 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653047} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 24d8f18a25e4b3b725ee4640192dd57a1e480f13 Author: rajendrant <rajendrant@chromium.org> Date: Tue Apr 23 01:25:10 2019 +0000 Fix the test by expecting on histgram value TBR=robertogden@chromium.org Bug: 948301 Change-Id: I7d3ede0743130a452a900211045b10f59fb32c0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578102 Reviewed-by: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#653046} tools/chrome_proxy/webdriver/fallback.py | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) commit 8bd5d21a2e47451b0d30dfd81735d33a9d515784 Author: dpapad <dpapad@chromium.org> Date: Tue Apr 23 01:24:32 2019 +0000 WebUI Polymer2: Remove Polymer1 support, part 2. Removing kWebUIPolymer2 flag. It has been turned on by default on all platforms, since M72 for Linux/Mac/Win, and M74 for CrOS. Also removing - ShadowDOMV0, CustomElementsV0 exceptions for PDF viewer - ShadowDOMV0, CustomElementsV0, HTMLImports exceptions for File Manager since those should no longer be needed. Bug: 944281 Change-Id: I7f684c4102cfc0a1a88149a16c30acce7e50cca7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532892 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Charlie Reis <creis@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#653045} chrome/browser/ui/webui/bookmarks/bookmarks_ui.cc | 6 +--- .../ui/webui/chromeos/bluetooth_pairing_dialog.cc | 6 +--- .../ui/webui/chromeos/internet_config_dialog.cc | 6 +--- .../ui/webui/chromeos/internet_detail_dialog.cc | 6 +--- chrome/browser/ui/webui/downloads/downloads_ui.cc | 6 +--- .../browser/ui/webui/extensions/extensions_ui.cc | 6 +--- chrome/browser/ui/webui/history_ui.cc | 12 ++----- .../ui/webui/print_preview/print_preview_ui.cc | 7 +--- .../ui/webui/settings/chromeos/os_settings_ui.cc | 13 ++----- chrome/browser/ui/webui/settings/settings_ui.cc | 11 ++---- .../browser/webui/shared_resources_data_source.cc | 42 ++++++---------------- content/public/common/content_features.cc | 17 +++------ content/public/common/content_features.h | 4 --- extensions/renderer/dispatcher.cc | 25 ------------- 14 files changed, 30 insertions(+), 137 deletions(-) commit 98d45f1d1902a81875b2d6e1be66161a3d9655c6 Author: sczs <sczs@chromium.org> Date: Tue Apr 23 01:23:11 2019 +0000 [ios] Presents Password Settings from Passwords InfobarModal. Tapping on the Settings Modal icon will now present Password settings. -Creates new presentPasswordSettings method. -Adds animated support to dismissInfobarModal. -Plumbs a dispatcher to InfobarCoordinator. Bug: 945478 Change-Id: Ied85947edc35c807718cfac79d7812bf4211a6f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576004 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by: Chris Lu <thegreenfrog@chromium.org> Reviewed-by: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#653044} ios/chrome/browser/ui/infobars/coordinators/BUILD.gn | 1 + .../ui/infobars/coordinators/infobar_coordinator.h | 4 ++++ .../ui/infobars/coordinators/infobar_coordinator.mm | 9 +++++---- .../coordinators/infobar_password_coordinator.mm | 16 ++++++++++++++-- .../browser/ui/infobars/infobar_container_coordinator.mm | 1 + .../browser/ui/infobars/modals/infobar_modal_delegate.h | 4 +++- .../ui/infobars/modals/infobar_modal_view_controller.mm | 4 +++- .../ui/infobars/modals/infobar_password_modal_delegate.h | 4 ++++ .../modals/infobar_password_table_view_controller.mm | 14 ++++++++------ ios/showcase/infobars/sc_infobar_banner_coordinator.mm | 6 ++++-- 10 files changed, 47 insertions(+), 16 deletions(-) commit c94ceccb458cf8af79a406a1b589f7214ee31ac6 Author: sczs <sczs@chromium.org> Date: Tue Apr 23 01:17:12 2019 +0000 [ios] Adds metrics for opening History item in new Tab. Bug: 954293 Change-Id: I61044ae18811372f3694ff24b958428987b78d7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575169 Reviewed-by: Mark Pearson <mpearson@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#653043} .../browser/ui/history/history_table_view_controller.mm | 4 ++++ tools/metrics/actions/actions.xml | 13 +++++++++++++ 2 files changed, 17 insertions(+) commit 8b3c0e39bcabf443264af48c22c4169f847f27c0 Author: Abigail Klein <abigailbklein@google.com> Date: Tue Apr 23 01:16:45 2019 +0000 Delete AXActionData::ToString and AXActionData::IsFlagSet. Neither is called or covered elsewhere in the codebase. Bug: 953317 Change-Id: I82f8f4d7b689992f27cf423f17691c6f9222419b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574898 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#653042} ui/accessibility/ax_action_data.cc | 45 -------------------------------------- 1 file changed, 45 deletions(-) commit 976f3ead181c5438a8a05c470522adcc06e04f88 Author: Katie D <katie@chromium.org> Date: Tue Apr 23 01:12:03 2019 +0000 Fix image labels enabled histogram. Like the other accessibility enabled histograms, this should be Accessibility.FeatureName, not Accessibility.FeatureName.Enabled. Additionally, it's already being used correctly in accessibility_labels_service.cc: https://cs.chromium.org/chromium/src/chrome/browser/accessibility/accessibility_labels_service.cc?type=cs&g=0&l=131 Bug: 955096 Change-Id: I9b48856cef41df8341931ad439b4fa99b1778e61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577920 Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#653041} tools/metrics/histograms/histograms.xml | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) commit 1f75a7dfbe5f110e34c0a4138715584f6a06bde1 Author: Tim Song <tengs@chromium.org> Date: Tue Apr 23 01:08:42 2019 +0000 Ash Tray: Fix collapse animation when removing the last notification. Currently, the autoscroll logic interferes with the collapse animation after removing the last notification, causing the animation to be skipped. TEST=manually verified, new unit test BUG=954001 Change-Id: I27450a10edd22f962c1c3c1b2858a4c3af559f4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574891 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#653040} .../message_center/unified_message_center_view.cc | 11 +++++- .../unified_message_center_view_unittest.cc | 45 +++++++++++++++++++++- .../message_center/unified_message_list_view.cc | 4 ++ .../message_center/unified_message_list_view.h | 3 ++ 4 files changed, 60 insertions(+), 3 deletions(-) commit ca7a7d3fa51a2c2f7c7d9a3111cac32afed4bc50 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Apr 23 01:06:16 2019 +0000 Roll src/third_party/chromite 06df2c4fd1b4..13cb24c76e7e (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/06df2c4fd1b4..13cb24c76e7e git log 06df2c4fd1b4..13cb24c76e7e --date=short --no-merges --format='%ad %ae %s' 2019-04-22 mikenichols@chromium.org chromeos_config: Migrate release builds to release builders Created with: gclient setdep -r src/third_party/chromite@13cb24c76e7e The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I2fc5941e122714b9888292f8699429d90add05c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578022 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653039} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit ff13eb075d3322425053da03c26eafdbd71530b9 Author: Joe DeBlasio <jdeblasio@chromium.org> Date: Tue Apr 23 01:01:37 2019 +0000 Update CCT to hide origin if requested by security interstitial. This CL modifies the behavior of CCTs such that they hide the origin of a page and page info button if there is an active security interstitial that requests it. This brings the behavior in line with that of desktop and mobile. Bug: 939601 Change-Id: I6c46cb4918871b9d2a760a72bee742fc7867e1b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570415 Reviewed-by: Jay Harris <harrisjay@chromium.org> Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#653038} .../ui/views/location_bar/custom_tab_bar_view.cc | 32 +++++++- .../ui/views/location_bar/custom_tab_bar_view.h | 1 + .../custom_tab_bar_view_browsertest.cc | 85 ++++++++++++++++++++++ 3 files changed, 114 insertions(+), 4 deletions(-) commit 296743e50a5c4e2c461dd94fe1dfc897236c6ca2 Author: Caleb Rouleau <crouleau@chromium.org> Date: Tue Apr 23 00:26:45 2019 +0000 Disable twitter_infinite_scroll on Desktop. This story is suspected of causing IO Timeouts of entire shards on Mac, Windows, and Linux. Since timing out a whole shard prevents any of the other benchmarks on that shard from getting data, I'm disabling this broadly. TBR=ulan@chromium.org NOTRY=true Bug: 953371 Change-Id: I1674159dd688bffa2f5408a03de81a120582101a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578120 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#653037} tools/perf/expectations.config | 4 ++++ 1 file changed, 4 insertions(+) commit 8b616ec799cc7913ad868a130374f8c4ba72a062 Author: Chris Palmer <palmer@chromium.org> Date: Tue Apr 23 00:23:15 2019 +0000 Add some additional death tests to `base::span`. Just to be careful. Bug: 817982 Change-Id: I3b56f324b05f43b0ccb55a811740ef0c5a79085b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577743 Commit-Queue: Chris Palmer <palmer@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#653036} base/containers/span_unittest.cc | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) commit d99bdec69607120fabe2bba6a26973d9d431e124 Author: Tom Sepez <tsepez@chromium.org> Date: Tue Apr 23 00:17:32 2019 +0000 Use base::span<> in text break iterators This case was selected to illustrate the utility of the new WTF::String::Span8() and Span16() methods, and of spans in general. Bug: 955067 Change-Id: I5108c38bba6dde93429f317ab7a6d9a028d3c739 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575866 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#653035} .../core/editing/selection_modifier_word.cc | 4 +- .../core/editing/spellcheck/spell_checker.cc | 3 +- .../core/editing/visible_units_sentence.cc | 12 ++--- .../renderer/core/editing/visible_units_word.cc | 12 ++--- .../platform/fonts/shaping/shape_result.cc | 10 ++-- .../renderer/platform/fonts/shaping/shape_result.h | 4 +- .../platform/fonts/shaping/shape_result_view.cc | 2 +- .../blink/renderer/platform/text/capitalize.cc | 2 +- .../renderer/platform/text/text_boundaries.cc | 31 ++++++----- .../renderer/platform/text/text_break_iterator.h | 32 +++++------- .../platform/text/text_break_iterator_icu.cc | 61 ++++++++++------------ 11 files changed, 76 insertions(+), 97 deletions(-) commit 8035452b8c84024bdd90336e3b4586f0c52b8b69 Author: David Tseng <dtseng@chromium.org> Date: Tue Apr 23 00:16:32 2019 +0000 Explicitly give entered iframes focus Bug: b:112665662 Change-Id: I6e0d7661d08ba6560b3a6591db1a29073462b116 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577919 Reviewed-by: Anastasia Helfinstein <anastasi@google.com> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#653034} .../chromeos/chromevox/cvox2/background/background.js | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) commit 2a9355a59d4c13798fe26f068f96ab1894bda777 Author: Adam Langley <agl@chromium.org> Date: Tue Apr 23 00:11:02 2019 +0000 device/fido: no silent requests for caBLE authenticators. caBLE authenticators may not be able to serve silent authentication requests silently, therefore don't send them. This change only addresses the GetAssertion flow as credential creation for caBLE is not done with CTAP2. Bug: 954355 Change-Id: If55ca42b325d98533d3234f9b46d25aed2dceab8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575723 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by: Martin Kreichgauer <martinkr@google.com> Auto-Submit: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#653033} .../browser/webauth/authenticator_impl_unittest.cc | 81 ++++++++++++++++++++-- device/fido/get_assertion_task.cc | 9 ++- device/fido/scoped_virtual_fido_device.cc | 1 + device/fido/virtual_ctap2_device.cc | 5 ++ device/fido/virtual_ctap2_device.h | 3 + 5 files changed, 90 insertions(+), 9 deletions(-) commit a69ab46787c8f94f06e9d29fa9ac8ac08d0b207d Author: Kyle Horimoto <khorimoto@chromium.org> Date: Tue Apr 23 00:08:21 2019 +0000 [CrOS Cellular] Make url.mojom-lite.js a shared resource. This CL shares url.mojom-lite.js from chrome://resources and updates relevant clients to refer to the shared resource instead of packaging the resource individually for each page. This is in preparation for utilizing url.mojom-lite.js in the cellular activation dialog. Bug: 953400 Change-Id: Ifd18cf7598d426fbe3deba87760d5d4f80008ccb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570253 Reviewed-by: Nasko Oskov <nasko@chromium.org> Reviewed-by: calamity <calamity@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#653032} chrome/browser/resources/engagement/site_engagement.html | 2 +- chrome/browser/resources/feed_internals/feed_internals.html | 2 +- chrome/browser/resources/interventions_internals/index.html | 2 +- chrome/browser/resources/media/media_engagement.html | 2 +- chrome/browser/resources/usb_internals/usb_internals.html | 2 +- chrome/browser/ui/webui/engagement/site_engagement_ui.cc | 1 - chrome/browser/ui/webui/feed_internals/feed_internals_ui.cc | 1 - .../interventions_internals/interventions_internals_ui.cc | 1 - chrome/browser/ui/webui/media/media_engagement_ui.cc | 1 - chrome/browser/ui/webui/usb_internals/usb_internals_ui.cc | 1 - content/BUILD.gn | 2 ++ content/browser/process_internals/process_internals_ui.cc | 1 - content/browser/resources/process/process_internals.html | 2 +- content/browser/webui/shared_resources_data_source.cc | 10 ++++++++++ content/content_resources.grd | 6 +++++- 15 files changed, 23 insertions(+), 13 deletions(-) commit 1a497e5ecde9cc542840316a7fa5d2be4ff06d33 Author: rajendrant <rajendrant@chromium.org> Date: Tue Apr 23 00:05:54 2019 +0000 Add better check for page ID More checks are added to verify that page ID sent in the pingback is the same as sent in chrome-proxy request header. Bug: 954537 Change-Id: I40c958f19e84e68775ad1a27b5e22275d67a4844 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574654 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#653031} .../data_reduction_proxy_browsertest.cc | 53 +++++++++++++++++++--- 1 file changed, 46 insertions(+), 7 deletions(-) commit 8eed5e0b36d819cfb73fc9ca155691e790851e7c Author: John Lee <johntlee@chromium.org> Date: Tue Apr 23 00:05:25 2019 +0000 Settings WebUI: Update some pages to use cr-link-row where they can Bug: 686905 Change-Id: I5c997c834acf9dfd5d744223bc2ec209b3eb6724 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577594 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#653030} .../settings/crostini_page/crostini_subpage.html | 37 +++++++++++----------- .../internet_known_networks_page.html | 20 ++++++------ .../settings/internet_page/internet_subpage.html | 11 ++++--- .../settings/site_settings/site_details.html | 16 ++++------ .../test/data/webui/settings/crostini_page_test.js | 12 +++---- 5 files changed, 46 insertions(+), 50 deletions(-) commit 29fdbbb039809c241f063739e0a06e06f718916a Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Tue Apr 23 00:02:05 2019 +0000 Roll src-internal c5f0b9634495..279cf61c3dec (3 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c5f0b9634495..279cf61c3dec Created with: gclient setdep -r src-internal@279cf61c3dec The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=chcunningham@chromium.org,loyso@chromium.org,clamy@chromium.org,flackr@chromium.org Change-Id: Ib2063d2275bca5abee6d5405e8f9bca6f8bc1521 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576414 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653029} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 757dd6cb1476dd9cc1ecb56ab2b88d8ee7eb9751 Author: Robert Ogden <robertogden@chromium.org> Date: Mon Apr 22 23:58:25 2019 +0000 Remove old server lofi test that no longer works TBR=tbansal@chromium.org Bug: 953406 Change-Id: I7eaae43a9496ef99e97e4fbf506fddef67d01ee9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576514 Reviewed-by: Robert Ogden <robertogden@chromium.org> Reviewed-by: Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#653028} tools/chrome_proxy/webdriver/lite_page.py | 47 ------------------------------- 1 file changed, 47 deletions(-) commit aa2b2d07efb7ed721436d62da72e9b9ccfb29386 Author: Antonio Gomes <tonikitoo@igalia.com> Date: Mon Apr 22 23:58:15 2019 +0000 Use WTF::ListHashSet default inline capacity This is a step towards replacing WTF::ListHashSet by WTF::LinkedHashSet. Particularly, this CL changes the inline capacity values used today in ToT with WTF::ListHashSet to its default value. Reason: ListedHashSet, our target class to replace ListHashSet, does not support inline capacity. In order to verify whether it needs to support it or not, this CL experiments with removing the call sites that set an explicit inline capacity to ListHashSet and watches out for performance regressions, if any. In case no performance regressions are observed, a next CL will remove the inline capacity support of ListedHashSet altogether, making its replacement by LinkedHashSet more straightforward. R=haraken@chromium.org CC=blink-reviews-vendor@chromium.org BUG=614112 Change-Id: I58e17ba181ad7077ea0cfa740bc80ec1f696b76e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575747 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#653027} third_party/blink/renderer/core/dom/tree_ordered_list.h | 8 ++++---- third_party/blink/renderer/core/layout/floating_objects.h | 2 +- third_party/blink/renderer/core/layout/layout_block.h | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) commit 5d7e1a1fa193f44478d9a24cf66710a0ee9678cd Author: John Williams <jrw@google.com> Date: Mon Apr 22 23:53:54 2019 +0000 [Cast MRP] Implement join by session ID and autojoin. Bug: 809249 Change-Id: I7b81887c875fe8a4dc9f219339125c772311adfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1432675 Commit-Queue: John Williams <jrw@chromium.org> Reviewed-by: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#653026} .../media/router/mojo/media_router_desktop.cc | 3 +- .../router/providers/cast/cast_activity_manager.cc | 165 +++++++++++++++++++-- .../router/providers/cast/cast_activity_manager.h | 32 +++- .../cast/cast_activity_manager_unittest.cc | 18 +++ .../providers/cast/cast_media_route_provider.cc | 17 ++- .../providers/cast/cast_media_source.cc | 15 ++ .../providers/cast/cast_media_source.h | 14 +- 7 files changed, 234 insertions(+), 30 deletions(-) commit 352cf6ceeb20dddd6a1925ebffdf3da5f0e0e132 Author: Ben Pastene <bpastene@chromium.org> Date: Mon Apr 22 23:53:49 2019 +0000 Remove interactive_ui_tests from chromeos-vm-code-coverage. Failing due to lack of disk space in the VMs. Bug: 954633 Change-Id: I9c3792af927fce7d5a5d5cc5c07611d9419a49b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577759 Auto-Submit: Ben Pastene <bpastene@chromium.org> Reviewed-by: Roberto Carrillo <robertocn@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#653025} testing/buildbot/chromium.fyi.json | 20 -------------------- testing/buildbot/test_suite_exceptions.pyl | 3 +++ 2 files changed, 3 insertions(+), 20 deletions(-) commit 277b78937fafbcb1451c578baf0fcf02febaad55 Author: Kenneth Russell <kbr@chromium.org> Date: Mon Apr 22 23:53:07 2019 +0000 Add NVIDIA GeForce GTX 1660 bot to chromium.gpu.fyi waterfall. This card is being qualified for potential scale-out. Bug: 881625 Change-Id: I7cb0f3b4239d51e42f11527620bb906525ecd396 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577998 Reviewed-by: Stephen Martinis <martiniss@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#653024} infra/config/cr-buildbucket.cfg | 4 + infra/config/luci-milo.cfg | 5 + infra/config/luci-scheduler.cfg | 11 + testing/buildbot/chromium.gpu.fyi.json | 797 +++++++++++++++++++++++++++++++++ testing/buildbot/mixins.pyl | 9 + testing/buildbot/waterfalls.pyl | 14 + 6 files changed, 840 insertions(+) commit 804bd3d6ba3768c8907fa1a6ab72935da5b0606a Author: rbpotter <rbpotter@chromium.org> Date: Mon Apr 22 23:52:47 2019 +0000 Print Preview: Change some file/element names to match convention Most elements in Print Preview have paths: print_preview/new/element_name.* and ids print-preview-element-name The sidebar and advanced settings dialog were the two exceptions to this rule. Change them to match all the other elements. Bug: none Change-Id: Iee530c7bf38d4fef3fbeb26d36d0c6c8db225af2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577973 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#653023} chrome/browser/resources/print_preview/new/BUILD.gn | 5 ++++- .../resources/print_preview/new/advanced_options_settings.html | 4 ++-- .../resources/print_preview/new/advanced_settings_dialog.html | 2 +- .../resources/print_preview/new/advanced_settings_dialog.js | 2 +- chrome/browser/resources/print_preview/new/app.html | 2 +- .../new/{print_preview_sidebar.html => sidebar.html} | 2 +- .../print_preview/new/{print_preview_sidebar.js => sidebar.js} | 4 ++-- .../browser/resources/print_preview/print_preview_resources.grd | 8 ++++---- chrome/test/data/webui/print_preview/advanced_dialog_test.js | 2 +- .../data/webui/print_preview/new_print_preview_ui_browsertest.js | 2 +- 10 files changed, 18 insertions(+), 15 deletions(-) commit 651ae21e5aa553d0133a27bba69bdc68523b3375 Author: Kenneth Russell <kbr@chromium.org> Date: Mon Apr 22 23:51:17 2019 +0000 Add ynovikov@ as GPU infra co-owner. Yuly has made substantial contributions to the Chrome GPU infrastructure and should be recognized as a co-owner. Bug: none No-Try: True Change-Id: I0047b83634d1703a78499217603693ed1e82846c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578064 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#653022} content/test/gpu/OWNERS | 1 + infra/OWNERS | 1 + 2 files changed, 2 insertions(+) commit 596984fa01c4af33db430dc958b4932d6fe7aba5 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Apr 22 23:48:17 2019 +0000 Roll src/third_party/chromite 47f37d2d77a4..06df2c4fd1b4 (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/47f37d2d77a4..06df2c4fd1b4 git log 47f37d2d77a4..06df2c4fd1b4 --date=short --no-merges --format='%ad %ae %s' 2019-04-22 seanabraham@chromium.org config: Swap scarlet from chrome to chromium PFQ builder Created with: gclient setdep -r src/third_party/chromite@06df2c4fd1b4 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I4ad7a634de5ab85554dc8e6ed4192aeaa138a007 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577979 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653021} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit d8d671781677685345ed16d0b2c790ca99e89007 Author: John Lee <johntlee@chromium.org> Date: Mon Apr 22 23:46:07 2019 +0000 Settings WebUI: Allow cr-radio-button slotted content to be styled Bug: 954908 Change-Id: I7e579f3a4bd116efa2790e6ab5ef6aa78bc6c754 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577945 Reviewed-by: Esmael El-Moslimany <aee@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#653020} chrome/browser/resources/settings/people_page/lock_screen.html | 2 +- .../cr_elements/cr_radio_button/cr_radio_button_style_css.html | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) commit f18558717042a7ecf3c38e1d298f661bb00bb79b Author: John Budorick <jbudorick@chromium.org> Date: Mon Apr 22 23:43:24 2019 +0000 Add luci-notify entry for cronet. This only includes ios-simulator-cronet for now, but it'll be expanded to include the android-cronet-* luci bots once they're all ready. Change-Id: Ic621082c4bca89241c90567e76835c223dbb1cbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577939 Reviewed-by: Misha Efimov <mef@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#653019} infra/config/luci-notify.cfg | 14 ++++++++++++++ 1 file changed, 14 insertions(+) commit 66c0e97960fed83511d320eded9f028e1cb678ad Author: Mandy Chen <mandy.chen@microsoft.com> Date: Mon Apr 22 23:39:44 2019 +0000 DevTools: Include module.json in build.gn presubmit check Discovered a bug in check_gn.js, which is part of the presubmit check that verifies all the devtools frontend files are included in devtools/BUILD.gn. The bug prevents missing module.json files from being reported. Output of running npm run check-gn Before the fix: DevTools BUILD.gn checker passed After: DevTools BUILD.gn checker detected errors! There's an issue with: D:\chromium\src\third_party\blink\renderer\devtools\BUILD.gn Missing file in BUILD.gn for all_devtools_files: "front_end\elements_test_runner\module.json", Missing file in BUILD.gn for all_devtools_files: "front_end\persistence\module.json", Missing file in BUILD.gn for all_devtools_files: "front_end\search\module.json", Missing file in BUILD.gn for all_devtools_files: "front_end\services\module.json", Missing file in BUILD.gn for all_devtools_files: "front_end\terminal\module.json", Missing file in BUILD.gn for all_devtools_files: "front_end\worker_service\module.json", I added these missing module.json files to BUILD.gn. Change-Id: I05a72e353475af142c13f0644fd430361edfff72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576409 Reviewed-by: Joel Einbinder <einbinder@chromium.org> Commit-Queue: Mandy Chen <mandy.chen@microsoft.com> Cr-Commit-Position: refs/heads/master@{#653018} third_party/blink/renderer/devtools/BUILD.gn | 6 ++++++ third_party/blink/renderer/devtools/scripts/check_gn.js | 4 +++- 2 files changed, 9 insertions(+), 1 deletion(-) commit 67e4dfedd5f8596e06913dbd4f5dc1b67be94ca4 Author: Matt Menke <mmenke@chromium.org> Date: Mon Apr 22 23:38:40 2019 +0000 SocketParams refactor 4: Use ProxyServer in CreateSocketParams(). It doesn't actually need the entire ProxyInfo class. This does reveal that there's also proxy_annotation_tag for us to worry about, unfortunately. Bug: 533571 Change-Id: I42adaa26f9687aae688955c90094678415afe67b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562301 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#653017} net/socket/client_socket_pool_manager.cc | 49 ++++++++++++++++++-------------- 1 file changed, 27 insertions(+), 22 deletions(-) commit b026d4726473507cf849cb4982d3ce1e1c725f3a Author: Aga Wronska <agawronska@chromium.org> Date: Mon Apr 22 23:38:34 2019 +0000 Fix status area color when immersive app is opened Status area background color was incorrect when switching from KioskNext home to immersive app, because shelf turns to auto-hide mode then and both shelf and status area are not visible. Bug: 949289 Change-Id: I28213355ea0f65d7638bd59714e50fbaceef3371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577944 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#653016} ash/shelf/shelf_layout_manager.cc | 2 -- 1 file changed, 2 deletions(-) commit 419517604940533a77f138b4422634c09bcf6e04 Author: Kenneth Russell <kbr@chromium.org> Date: Mon Apr 22 23:36:59 2019 +0000 Remove testing/buildbot/GENERATION_OWNERS. This file is no longer referenced. Bug: 662541 No-Try: True Change-Id: I0cd0c3ae19c6084a406b64cc38d43b63331d4ae6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578066 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#653015} testing/buildbot/GENERATION_OWNERS | 11 ----------- 1 file changed, 11 deletions(-) commit 3908cf0c66854312820ebd33e259a1e156eb2e54 Author: Kelvin Jiang <kelvinjiang@chromium.org> Date: Mon Apr 22 23:35:17 2019 +0000 [Declarative Net Request]: Prevent self-redirect loops from the same URL Do not match redirect rules if the request and redirect URLs are the same. Bug: 954646 Change-Id: I003a0fe56c2e9251206ea61fe51a75debf241030 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576102 Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#653014} .../declarative_net_request_browsertest.cc | 5 +++++ .../api/declarative_net_request/ruleset_matcher.cc | 3 ++- .../ruleset_matcher_unittest.cc | 20 ++++++++++++++++++++ 3 files changed, 27 insertions(+), 1 deletion(-) commit d1935b0a269484d7a64718027449b6a4d04187f0 Author: Roberto Carrillo <robertocn@google.com> Date: Mon Apr 22 23:26:16 2019 +0000 remove stgao from chromium/src R=robertocn Change-Id: I0425120722b8d7e57b6e19d9243b07bcd5338f1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576224 Reviewed-by: Roberto Carrillo <robertocn@chromium.org> Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Cr-Commit-Position: refs/heads/master@{#653013} tools/checkteamtags/OWNERS | 1 - tools/checkteamtags/extract_components_test.py | 8 ++++---- 2 files changed, 4 insertions(+), 5 deletions(-) commit f60f6909a35d11950fbc79e8a5e682bff6232d97 Author: Peter K. Lee <pkl@chromium.org> Date: Mon Apr 22 23:24:04 2019 +0000 [MDC roll] Roll Material Components to aaee6a1c5e9fc402d281caf249c8b13e8903b17f This is: Wed Apr 17 10:41:26 2019 (HEAD, tag: v82.0.0, origin/stable) Bug: 955127 Change-Id: I58a6695993a611589bd290479d536968120ac9fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577854 Reviewed-by: Sergio Collazos <sczs@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#653012} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 90bb4730da246d0e5aa775ad0463eeee5ebd33a4 Author: Adam Langley <agl@chromium.org> Date: Mon Apr 22 23:18:12 2019 +0000 device/fido: decomplexify AuthenticatorGetInfoResponse It's just a struct, no need to wrap everything in trivial getters and setters. Change-Id: Ib350d3db0ed2bc48ed35c2cd4c49f52c2ec12c47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577677 Auto-Submit: Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#653011} device/fido/authenticator_get_info_response.cc | 55 ++++++++------------------ device/fido/authenticator_get_info_response.h | 37 +++++------------ device/fido/ctap_response_unittest.cc | 32 +++++++-------- device/fido/device_response_converter.cc | 8 ++-- device/fido/fido_device.cc | 4 +- device/fido/fido_device_authenticator.cc | 4 +- device/fido/get_assertion_task.cc | 3 +- device/fido/make_credential_task.cc | 8 ++-- device/fido/make_credential_task_unittest.cc | 4 +- device/fido/virtual_ctap2_device.cc | 16 ++++---- 10 files changed, 64 insertions(+), 107 deletions(-) commit 4fef13cd8e1b215ddfa3fc68c07423e69b98573a Author: Ben Pastene <bpastene@chromium.org> Date: Mon Apr 22 23:16:25 2019 +0000 Fix testing/buildbot json specs after r652972 + r652982 conflicts. //testing/buildbot/ presubmit is failing due to incorrect configs caused by the following CLs landing independently & simelataneously: https://chromium-review.googlesource.com/c/chromium/src/+/1572926 https://chromium-review.googlesource.com/c/chromium/src/+/1533085 NOTRY=true # To fix presubmit asap. Change-Id: I756e9a068fb431883a591f385d5cf6f2960132bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578060 Commit-Queue: Ben Pastene <bpastene@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Auto-Submit: Ben Pastene <bpastene@chromium.org> Reviewed-by: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#653010} testing/buildbot/chromium.fyi.json | 25 ------------------------- 1 file changed, 25 deletions(-) commit 0e2e2812fcfceb1bfa6174114e8385bcde744802 Author: Josh Nohle <nohle@google.com> Date: Mon Apr 22 23:15:07 2019 +0000 [DeviceSync v2] Add support for unenrolled keys in key registry The DeviceSync v2 protocol specifies that device metadata is end-to-end encrypted. Consequently, devices must locally retain the "group key pair" that is shared by all user devices and used to encrypt/decrypt all device metadata. This key pair cannot be enrolled with CryptAuth because that would undermine the end-to-end encryption promise. We update the key registry to support both key bundles that enroll with CryptAuth and those that do not. A static method is added to the key bundle class, CryptAuthKeyBundle::AllNamesToEnroll(), that provides the enroller with a list of only those key bundles that enroll with CryptAuth. We add the unenrolled "DeviceSync:BetterTogether" group key bundle to the CryptAuthKeyBundle::Name enum. This will go unused until the DeviceSync v2 protocol is fully implemented. We also update method names and comments to reflect our changes. Bug: 951969 Change-Id: I0e67a176b75585681120edb8f06e6ea8675854a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575826 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#653009} .../services/device_sync/cryptauth_key_bundle.cc | 16 ++++++++ .../services/device_sync/cryptauth_key_bundle.h | 31 ++++++++++----- .../device_sync/cryptauth_key_bundle_unittest.cc | 1 + .../services/device_sync/cryptauth_key_registry.cc | 42 ++++++++++----------- .../services/device_sync/cryptauth_key_registry.h | 14 ++++--- .../device_sync/cryptauth_key_registry_impl.cc | 4 +- .../device_sync/cryptauth_key_registry_impl.h | 8 ++-- .../cryptauth_key_registry_impl_unittest.cc | 44 ++++++++-------------- .../device_sync/cryptauth_v2_enroller_impl.cc | 4 +- .../device_sync/cryptauth_v2_enroller_impl.h | 2 +- .../cryptauth_v2_enroller_impl_unittest.cc | 29 +++++++------- .../cryptauth_v2_enrollment_manager_impl.cc | 2 +- ...ryptauth_v2_enrollment_manager_impl_unittest.cc | 11 +++--- 13 files changed, 113 insertions(+), 95 deletions(-) commit b8709ac31de7f5a3f227f159d950b5963725bd81 Author: Hiroki Nakagawa <nhiroki@chromium.org> Date: Mon Apr 22 23:14:50 2019 +0000 Worker: Run http/tests/security/cors-rfc1918 with off-the-main-thread worker script fetch This directory contains tests for AddressSpace on classic workers. Tests on module workers will be added later (see https://crbug.com/954853). Change-Id: Ieb117cfb36efcc8ba3510972507a46c911a7a7fe Bug: 945215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577218 Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#653008} third_party/blink/web_tests/VirtualTestSuites | 6 ++++++ .../cors-rfc1918/addressspace-serviceworker-basic-expected.txt | 6 ++++++ .../cors-rfc1918/addressspace-sharedworker-basic-expected.txt | 6 ++++++ 3 files changed, 18 insertions(+) commit b409da85ff0ebd9c17b1aa8989bc3838f2693c95 Author: Matt Menke <mmenke@chromium.org> Date: Mon Apr 22 23:12:45 2019 +0000 Fix ClientSocketPool::RequestSocket docs. Bug: None Change-Id: I3ea09ca94f45619a1564ebdb59d4066c60ce0aea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577623 Reviewed-by: Asanka Herath <asanka@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#653007} net/socket/client_socket_pool.h | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) commit e103f7133a3fa38340db40137de80fe5234100b8 Author: Robert Ogden <robertogden@chromium.org> Date: Mon Apr 22 23:07:20 2019 +0000 Use the DRP Server Experiment for LitePageRedirect Request from the server team. Bug: 955026 Change-Id: Ia6792a5c03dbda1288664c4b18c9bb8eed08e07a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577951 Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#653006} .../previews/previews_lite_page_navigation_throttle.cc | 7 +++++-- .../previews_lite_page_navigation_throttle_unittest.cc | 17 +++++++++++++++-- components/previews/core/previews_experiments.cc | 5 ----- components/previews/core/previews_experiments.h | 3 --- 4 files changed, 20 insertions(+), 12 deletions(-) commit 2696c1dcb47a98ca68f698741172c191cd8afb20 Author: Matt Simmons <mattsimmons@chromium.org> Date: Mon Apr 22 23:06:47 2019 +0000 Add a null check on the tab when starting or stopping tab engagement. Bug: 947572 Change-Id: I7180ae2bae5129ce3e650adbc4d07478b9ce7c2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577763 Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Matt Simmons <mattsimmons@chromium.org> Cr-Commit-Position: refs/heads/master@{#653005} .../java/src/org/chromium/chrome/browser/tasks/JourneyManager.java | 4 ++++ 1 file changed, 4 insertions(+) commit c2b7455f735272466e9f41075293392ea8299d4a Author: David Benjamin <davidben@chromium.org> Date: Mon Apr 22 23:05:59 2019 +0000 Support StringPiece to CFStringRef/NSString conversions. This avoids the copy in https://chromium-review.googlesource.com/c/chromium/src/+/1576436. Now we only make three copies, rather than four! Bug: 820198 Change-Id: I421c14a141a35eb6eb0491477f28cb8ebdb27994 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577595 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#653004} base/strings/sys_string_conversions.h | 8 +++--- base/strings/sys_string_conversions_mac.mm | 34 +++++++++++------------- net/base/net_string_util_icu_alternatives_ios.mm | 5 +--- 3 files changed, 21 insertions(+), 26 deletions(-) commit 55e00e6280d7721c3967b44df325aa59c55955c1 Author: Chris Cunningham <chcunningham@chromium.org> Date: Mon Apr 22 23:01:16 2019 +0000 Mark fast/text/letter-spacing-negative-opacity.html as failing NOTRY=true Bug: 955165 Change-Id: I735298fdf0eb16d5a1acf4a7e2b621acee74219d TBR: eae@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578058 Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#653003} third_party/blink/web_tests/TestExpectations | 1 + 1 file changed, 1 insertion(+) commit c8208408d39be4c09fd39b5e21ea50f468df1e76 Author: Archana Simha <archanasimha@google.com> Date: Mon Apr 22 23:00:18 2019 +0000 Moved FullHashToStoreAndPrefixesMap into PendingCheck. Change-Id: Ic79622652ab032b4a716a0f11d7546223eb9afd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566121 Commit-Queue: Archana Simha <archanasimha@google.com> Reviewed-by: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#653002} .../db/v4_get_hash_protocol_manager.cc | 2 +- .../db/v4_get_hash_protocol_manager.h | 2 +- .../safe_browsing/db/v4_local_database_manager.cc | 47 +++++++++------------- .../safe_browsing/db/v4_local_database_manager.h | 16 ++++---- .../db/v4_local_database_manager_unittest.cc | 6 +-- 5 files changed, 30 insertions(+), 43 deletions(-) commit 6441880ce6125b0c7489d1b08982c63ea05205b5 Author: Sunny Sachanandani <sunnyps@chromium.org> Date: Mon Apr 22 23:00:08 2019 +0000 gpu: Enable decode swap chain by default Enable DirectCompositionUseNV12DecodeSwapChain finch feature by default. Also reject DXVA frames which have texture arrays containing a single element, and record that in UMA. Bug: 848093 Change-Id: Ic6e56395d8544af3c8206facff5df60ec0785e92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574657 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#653001} gpu/config/gpu_finch_features.cc | 2 +- gpu/ipc/service/direct_composition_surface_win.cc | 11 +++++++++-- tools/metrics/histograms/enums.xml | 1 + 3 files changed, 11 insertions(+), 3 deletions(-) commit a575360dc5efd5aa76fe793b723365578f3f7813 Author: James Cook <jamescook@chromium.org> Date: Mon Apr 22 22:59:15 2019 +0000 Revert "CrOS SplitSettings: Hide browser sections in chrome://os-settings/" This reverts commit ed8a203d2b2b3247e0786006a1da020d3a23ee9b. Reason for revert: Broke appearance settings (chrome://settings/appearance), see https://crbug.com/955123 Original change's description: > CrOS SplitSettings: Hide browser sections in chrome://os-settings/ > > Use pageVisibility to hide sections like autofill, show bookmarks bar, > etc. > > Bug: 950007 > Change-Id: I871322a3eca51eb6995fa4ee304461c9f8bd0f35 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575032 > Reviewed-by: Dan Beam <dbeam@chromium.org> > Commit-Queue: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#652856} TBR=jamescook@chromium.org,dbeam@chromium.org Change-Id: I5309ea8815ae80bd895c2f9f20d134f3693c1035 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 950007 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577864 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#653000} .../browser/resources/settings/page_visibility.js | 121 +++++++++++++-------- .../ui/webui/settings/chromeos/os_settings_ui.cc | 1 - chrome/browser/ui/webui/settings/settings_ui.cc | 1 - 3 files changed, 76 insertions(+), 47 deletions(-) commit 534ab28cbc3fd592bca0e7e046a78a795ebe79f0 Author: John Abd-El-Malek <jam@chromium.org> Date: Mon Apr 22 22:58:36 2019 +0000 Revert "Reenable libc++ on Windows" This reverts commit aa9e6f586615eb96dac21ed2bfb26e4ee3f4ef11. Reason for revert: this is still broken, see repro steps in https://crbug.com/947911 Original change's description: > Reenable libc++ on Windows > > BUG=801780 > R=​thakis > > Change-Id: Ife6f11c4e02534c879731274d427b0f563b8fa08 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556590 > Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#652740} TBR=thakis@chromium.org,thomasanderson@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 801780, 947911 Change-Id: I500bcb164774f7d185dad336dc310b6f0c1a0614 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577941 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#652999} build/config/c++/c++.gni | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 35726780ab93519d467fea7dfab7c6845b89a802 Author: Ryan Hansberry <hansberry@chromium.org> Date: Mon Apr 22 22:52:39 2019 +0000 [Bluetooth] bluetooth_dialog: Do not assume pairingDevice is defined. getMessage_() and showDismiss_() are called when the dialog's |pairingDevice| field gets changed. That field is set to undefined in bluetooth_subpage.js [1], so these functions had to be tweaked to accomodate for that. This had no known user impact, but caused TypeErrors to be thrown. 1) https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/bluetooth_page/bluetooth_subpage.js?l=459 Bug: 954223 Change-Id: Ia751b303146505c3f9e31bd9ab6530467551e161 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574249 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#652998} ui/webui/resources/cr_components/chromeos/bluetooth_dialog.js | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) commit 2bcd16bf55573281d6ed1c720c52be67ceba68c2 Author: Brian Sheedy <bsheedy@chromium.org> Date: Mon Apr 22 22:47:08 2019 +0000 Add android-pie-arm64-dbg Adds the LUCI configs and test specs for the new "android-pie-arm64-dbg" bot on android.chromium. Bug: 953990 Change-Id: Iac5904a814469c8eae7e864cc3b01e0bce59fd7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577684 Reviewed-by: Ben Pastene <bpastene@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#652997} infra/config/cr-buildbucket.cfg | 6 + infra/config/luci-milo.cfg | 5 + infra/config/luci-scheduler.cfg | 10 ++ testing/buildbot/chromium.android.json | 194 ++++++++++++++++++++++++++++- testing/buildbot/test_suite_exceptions.pyl | 10 ++ testing/buildbot/test_suites.pyl | 13 +- testing/buildbot/waterfalls.pyl | 15 +++ 7 files changed, 246 insertions(+), 7 deletions(-) commit 80f97e274dc91c8aa4f43102962948b36850f1ad Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Mon Apr 22 22:47:05 2019 +0000 Roll src-internal bcfa4703827b..c5f0b9634495 (3 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bcfa4703827b..c5f0b9634495 Created with: gclient setdep -r src-internal@c5f0b9634495 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=chcunningham@chromium.org,loyso@chromium.org,clamy@chromium.org,flackr@chromium.org Change-Id: I7046efed04b590f2c8d25ea6be4ef1dd787e6a36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576509 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652996} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 0a194540ca037e1604e2ecd352c042e1f1278e07 Author: Alexei Filippov <alph@chromium.org> Date: Mon Apr 22 22:45:46 2019 +0000 [heap profiler] Refactor intermediate storage classes in json_exporter Remove Backtrace, BacktraceStorage. Replace AllocationEvent with AllocationSite & AllocationMetrics. BUG=923459 Change-Id: I7c1fa42e866c6cd6bb21a1f7d2c7ed4bd67d0919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574651 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#652995} components/services/heap_profiling/BUILD.gn | 7 +- components/services/heap_profiling/allocation.cc | 27 +++ components/services/heap_profiling/allocation.h | 68 +++++++ .../services/heap_profiling/allocation_event.cc | 29 --- .../services/heap_profiling/allocation_event.h | 104 ---------- components/services/heap_profiling/backtrace.cc | 44 ---- components/services/heap_profiling/backtrace.h | 58 ------ .../services/heap_profiling/backtrace_unittest.cc | 34 ---- .../services/heap_profiling/connection_manager.cc | 59 ++++-- .../services/heap_profiling/connection_manager.h | 5 +- .../services/heap_profiling/json_exporter.cc | 221 +++++++------------- components/services/heap_profiling/json_exporter.h | 14 +- .../heap_profiling/json_exporter_unittest.cc | 226 +++------------------ 13 files changed, 238 insertions(+), 658 deletions(-) commit 233f466f98b9cc5f7f2f93cf062bad43e5f68037 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Apr 22 22:44:12 2019 +0000 Roll src/third_party/skia 50d79af7b783..c3186302bd8a (3 commits) https://skia.googlesource.com/skia.git/+log/50d79af7b783..c3186302bd8a git log 50d79af7b783..c3186302bd8a --date=short --no-merges --format='%ad %ae %s' 2019-04-22 brianosman@google.com Add skcms directory to public includes 2019-04-22 egdaniel@google.com Add wait function on GrContext to wait on semaphores. 2019-04-22 jvanverth@google.com More buffer changes for Metal. Created with: gclient setdep -r src/third_party/skia@c3186302bd8a The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@chromium.org Change-Id: I49a34a886a11187cbc2f9c3ffe138a431aab5a58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576270 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652994} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit c27189f883f797f36aa0811c6280ccb0681bb232 Author: James Cook <jamescook@chromium.org> Date: Mon Apr 22 22:44:09 2019 +0000 CrOS SplitSettings: Use default font size in WebUI system dialogs When SplitSettings is enabled, system dialogs are considered native UI, so they do not follow the browser's web-page font sizes. Reset fonts to the base sizes. See go/split-settings-zoom for details. Bug: 950007, 955071 Test: added to browser_tests Change-Id: I5ac0af5f293bf913f9b5cfa672717f5409bb0f22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577664 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#652993} .../chrome_content_browser_client_chromeos_part.cc | 71 +++++++++++++++------- .../chromeos/system_web_dialog_browsertest.cc | 38 +++++++++++- .../webui/chromeos/system_web_dialog_delegate.cc | 9 +++ .../ui/webui/chromeos/system_web_dialog_delegate.h | 3 + chromeos/constants/chromeos_features.cc | 4 ++ chromeos/constants/chromeos_features.h | 2 + 6 files changed, 104 insertions(+), 23 deletions(-) commit 6eab58136c82df5095536993b0d1e71ce984743b Author: Min Qin <qinmin@chromium.org> Date: Mon Apr 22 22:41:04 2019 +0000 Add tests for AllDownloadEventNotifier This CL adds a number of tests to AllDownloadEventNotifier. Also, it refactors SimpleDownloadManager a little bit to switch the NotifyWhenInitialized() method to an observer method. This is done because the callback passed to the NotifyWhenInitialized() method can be invoked even after we switch to the new SimpleDownloadManager. But that is undesired since AllDownloadEventNotifier can wait for the new Manager to notify it when all downloads are loaded. Bug: 942770 Change-Id: I259712d4dcb6ad56482485ed509e4f413d64a838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565153 Reviewed-by: Min Qin <qinmin@chromium.org> Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#652992} .../android/download/download_manager_service.cc | 12 +- .../android/download/download_manager_service.h | 4 + components/download/internal/common/BUILD.gn | 1 + .../common/all_download_event_notifier_unittest.cc | 148 +++++++++++++++++++++ .../common/in_progress_download_manager.cc | 39 ++++++ .../internal/common/simple_download_manager.cc | 20 ++- .../common/simple_download_manager_coordinator.cc | 25 ++-- components/download/public/common/BUILD.gn | 2 + .../public/common/all_download_event_notifier.h | 3 +- .../public/common/in_progress_download_manager.h | 19 ++- .../public/common/mock_simple_download_manager.cc | 22 +++ .../public/common/mock_simple_download_manager.h | 44 ++++++ .../public/common/simple_download_manager.h | 11 +- .../common/simple_download_manager_coordinator.h | 7 +- content/browser/download/download_manager_impl.cc | 7 +- content/browser/download/download_manager_impl.h | 4 +- .../download/download_manager_impl_unittest.cc | 2 +- 17 files changed, 321 insertions(+), 49 deletions(-) commit bb4919a186115e25ad90ebd9f956d6228c95c986 Author: Alexander Alekseev <alemate@chromium.org> Date: Mon Apr 22 22:38:48 2019 +0000 Chrome OS: Fix and re-enable LoginTest.GaiaAuthOffline test. Revert "Revert "Chrome OS: Fix and re-enable LoginTest.GaiaAuthOffline test."" This reverts commit 45a7a301e7c2b90fa2fd9892d7b864930a225231 and re-lands https://crrev.com/d4a2bb5757 with fixes. Bug: 692364 Change-Id: I4dfea69a82cac07af1e79286ed7ce623b56e747e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568777 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Toni Baržić <tbarzic@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#652991} chrome/browser/chromeos/login/login_browsertest.cc | 70 ++++++++-------------- .../chromeos/settings/device_settings_provider.h | 6 +- .../resources/chromeos/login/offline_gaia.html | 4 +- .../ui/webui/chromeos/login/gaia_screen_handler.cc | 49 +++++++-------- .../ui/webui/chromeos/login/gaia_screen_handler.h | 30 ++++++++-- .../webui/chromeos/login/signin_screen_handler.cc | 2 +- 6 files changed, 80 insertions(+), 81 deletions(-) commit 25ee0b56792c273314710b156b0f74e453d835ff Author: Gang Wu <gangwu@chromium.org> Date: Mon Apr 22 22:38:24 2019 +0000 Reland "[Feed] Add spinner metrics to Zine" This is a reland of f9f7e45fd6f95925cfbcf5730fad0a4ff6b31e62 Original change's description: > [Feed] Add spinner metrics to Zine > > Adding 2 metrics, which existing in Feed, but not in Zine > ontentSuggestions.Feed.FetchPendingSpinner.Shown > ContentSuggestions.Feed.FetchPendingSpinner.VisibleDurationWithoutCompleting > > Bug: 943282 > Change-Id: Id72d6fe55a34a4a294f9ea2bb452ce007e376286 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576018 > Commit-Queue: Gang Wu <gangwu@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Cr-Commit-Position: refs/heads/master@{#652755} Bug: 943282 Change-Id: I05cf138d8a495430b50c54fa70189e0321b46e93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577958 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#652990} .../chrome/browser/ntp/cards/ActionItem.java | 22 ++++--- .../browser/ntp/cards/SuggestionsSection.java | 8 ++- .../browser/suggestions/SuggestionsMetrics.java | 75 ++++++++++++++++------ .../browser/ntp/cards/NewTabPageAdapterTest.java | 4 +- .../browser/ntp/cards/SuggestionsSectionTest.java | 6 +- .../touchless/TouchlessActionItemViewHolder.java | 5 +- 6 files changed, 85 insertions(+), 35 deletions(-) commit 056546be150084186d821e61506d7e839e2fcac8 Author: Evan Stade <estade@chromium.org> Date: Mon Apr 22 22:36:45 2019 +0000 Remove unnecessary chromeos:: namespace prefixes in chrome_browser_main_chromeos.cc Bug: none Change-Id: I4f99ca479b69a202aa2ad9970a3f25ecb0167e3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576266 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#652989} .../chromeos/chrome_browser_main_chromeos.cc | 34 ++++++++++------------ 1 file changed, 15 insertions(+), 19 deletions(-) commit 6eb736cfb702653a8768934191545a2d4ec69c7d Author: Evan Stade <estade@chromium.org> Date: Mon Apr 22 22:35:19 2019 +0000 Add unit tests for PowerManagerMojoController. Bug: 644348 Change-Id: I775b18407b7cd2fb64fcffc6ebbc175aacd90e79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572217 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#652988} chromeos/services/BUILD.gn | 1 + chromeos/services/power/public/cpp/BUILD.gn | 29 +++++- .../cpp/power_manager_mojo_controller_unittest.cc | 105 +++++++++++++++++++++ 3 files changed, 131 insertions(+), 4 deletions(-) commit 19ad70f5c33844efd4859be1962bceb5484e446c Author: John Budorick <jbudorick@chromium.org> Date: Mon Apr 22 22:35:16 2019 +0000 Add compile and luci configs for chromium/try:android-cronet-arm-dbg. Also switch chromium/try:linux-{ozone,blink-heap-concurrent-marking-tsan}-rel to builderless. Bug: 731988 Change-Id: I8d7365c257c62d904bde63085886929cb16bae9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576160 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by: Stephen Martinis <martiniss@chromium.org> Reviewed-by: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#652987} infra/config/cr-buildbucket.cfg | 23 ++++++++++++++++------- infra/config/luci-milo.cfg | 6 ++++++ tools/mb/mb_config.pyl | 5 +++-- 3 files changed, 25 insertions(+), 9 deletions(-) commit 284ea8a5f62159bb177edf9027333e60594eb6fe Author: Livvie Lin <livvielin@chromium.org> Date: Mon Apr 22 22:34:15 2019 +0000 [DevTools] Refactor origin group mapping logic Map origin group symbols to elements instead of using section titles and simplify some of the looping logic. Bug: 954524 Change-Id: Iba9ff9974763def630f3606b9e34219cd438eda8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574436 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#652986} .../devtools/front_end/security/SecurityPanel.js | 75 ++++++++++++---------- .../security_test_runner/SecurityTestRunner.js | 12 ++-- .../devtools/security/origin-group-names-unique.js | 6 +- 3 files changed, 51 insertions(+), 42 deletions(-) commit 7a6f79f77d6cf393d2078cb1571cf215850c48ad Author: Peter Kasting <pkasting@chromium.org> Date: Mon Apr 22 22:34:10 2019 +0000 Remove uses of child_at() in ash/. Bug: 940135 Change-Id: I363bc62b1d299403a64fcd28b893915327040c9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576011 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#652985} ash/app_list/views/apps_grid_view_unittest.cc | 2 +- ash/app_list/views/page_switcher.cc | 8 ++++---- ash/app_list/views/search_result_answer_card_view_unittest.cc | 3 ++- ash/assistant/ui/main_stage/assistant_main_stage.cc | 2 +- .../shortcut_viewer/views/keyboard_shortcut_item_view.cc | 4 ++-- ash/components/shortcut_viewer/views/keyboard_shortcut_view.cc | 8 ++++---- .../shortcut_viewer/views/keyboard_shortcut_view_unittest.cc | 9 +++++---- ash/login/ui/lock_contents_view.cc | 4 ++-- ash/login/ui/login_expanded_public_account_view_unittest.cc | 8 ++++---- ash/login/ui/login_menu_view.cc | 8 ++++---- ash/login/ui/login_menu_view.h | 4 ++-- .../message_center/unified_message_center_view_unittest.cc | 8 ++++---- ash/system/message_center/unified_message_list_view_unittest.cc | 8 ++++---- ash/system/network/network_list.cc | 2 +- ash/system/tray/tray_detailed_view.cc | 4 ++-- ash/system/tray/tri_view.cc | 2 +- ash/wallpaper/wallpaper_controller_unittest.cc | 4 ++-- ash/wallpaper/wallpaper_view.cc | 2 +- 18 files changed, 46 insertions(+), 44 deletions(-) commit 154ee1577c36eb01bae696aa21c1070b9a9d763a Author: Scott Violet <sky@chromium.org> Date: Mon Apr 22 22:31:41 2019 +0000 views: remove dead code NativeViewHost::fast_resize_at_last_layout_ is not used. BUG=none TEST=none Change-Id: Iea87a0447b32fc0bf948cc17cae7d7bfac26a247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577959 Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#652984} ui/views/controls/native/native_view_host.cc | 1 - ui/views/controls/native/native_view_host.h | 8 -------- 2 files changed, 9 deletions(-) commit c3c1dee08f4a96afb4f9a982cf8e1f1099c486b3 Author: Daniel Cheng <dcheng@chromium.org> Date: Mon Apr 22 22:31:20 2019 +0000 base: allow shared memory creation to be hooked This allows the shared memory APIs to work more consistently in sandboxed processes, rather than sandboxed code having to call Mojo-specific helpers. Bug: 876525 Change-Id: Icaf2fb7f8cd7a08d74f0f2a07ba8c67ce8e02a2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576101 Reviewed-by: Robert Sesek <rsesek@chromium.org> Reviewed-by: Ken Rockot <rockot@google.com> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#652983} base/BUILD.gn | 2 + base/memory/read_only_shared_memory_region.cc | 6 ++ base/memory/read_only_shared_memory_region.h | 6 ++ base/memory/shared_memory_hooks.h | 36 ++++++++++++ base/memory/shared_memory_hooks_unittest.cc | 85 +++++++++++++++++++++++++++ base/memory/unsafe_shared_memory_region.cc | 6 ++ base/memory/unsafe_shared_memory_region.h | 6 ++ base/memory/writable_shared_memory_region.cc | 6 ++ base/memory/writable_shared_memory_region.h | 7 +++ 9 files changed, 160 insertions(+) commit fee3f54d75c61dd90e5d442514220d8f85df7f4e Author: dpapad <dpapad@chromium.org> Date: Mon Apr 22 22:28:56 2019 +0000 WebUI Polymer2: Remove Polymer1 support, part 1. Remove - webui_polymer1_browser_tests - webui_polymer1_interactive_ui_tests suites from buildbot configuration. Bug: 944281,893078 Change-Id: I84808a63c8c91c1769f225f9a7e4c8cfea9ef344 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1533085 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#652982} testing/buildbot/chromium.chrome.json | 35 -- testing/buildbot/chromium.chromiumos.json | 46 -- testing/buildbot/chromium.clang.json | 654 --------------------- testing/buildbot/chromium.fyi.json | 178 ------ testing/buildbot/chromium.linux.json | 102 ---- testing/buildbot/chromium.mac.json | 210 ------- testing/buildbot/chromium.memory.json | 230 -------- testing/buildbot/chromium.win.json | 122 ---- testing/buildbot/filters/BUILD.gn | 2 - .../filters/webui_polymer1_browser_tests.filter | 299 ---------- .../webui_polymer1_interactive_ui_tests.filter | 28 - testing/buildbot/test_suite_exceptions.pyl | 17 - testing/buildbot/test_suites.pyl | 17 - testing/buildbot/tryserver.chromium.linux.json | 25 - 14 files changed, 1965 deletions(-) commit 51fc97a732fef1bfe6620188d78ef5c334f7108c Author: Jacob Dufault <jdufault@google.com> Date: Mon Apr 22 22:28:00 2019 +0000 cros: Move *View classes into *Handler - Moved CoreOobeView - Moved NetworkErrorView and renamed it to ErrorScreenView - Moved NetworkScreenView - Removed RecommendAppsScreenViewObserver, it only had one subclass so usage was inlined. TBR=yusukes@chromium.org Bug: 928555 Change-Id: Ife06668c7490d6969a5c2fc43e88b703a6e1cd38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572758 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#652981} chrome/browser/chromeos/BUILD.gn | 4 -- .../chromeos/arc/arc_session_manager_unittest.cc | 1 - .../optin/arc_terms_of_service_oobe_negotiator.h | 2 +- .../login/screens/arc_terms_of_service_screen.h | 2 +- .../arc_terms_of_service_screen_view_observer.h | 36 ------------- .../chromeos/login/screens/core_oobe_view.h | 51 ------------------ .../browser/chromeos/login/screens/error_screen.cc | 6 +-- .../browser/chromeos/login/screens/error_screen.h | 8 +-- .../chromeos/login/screens/mock_error_screen.cc | 10 ++-- .../chromeos/login/screens/mock_error_screen.h | 10 ++-- .../chromeos/login/screens/mock_network_screen.h | 2 +- .../chromeos/login/screens/network_error_view.h | 60 ---------------------- .../chromeos/login/screens/network_screen.cc | 2 +- .../chromeos/login/screens/network_screen_view.h | 50 ------------------ .../login/screens/recommend_apps_screen.cc | 28 +++++----- .../chromeos/login/screens/recommend_apps_screen.h | 20 +++++--- .../screens/recommend_apps_screen_browsertest.cc | 5 ++ .../screens/recommend_apps_screen_view_observer.h | 39 -------------- .../login/screens/update_screen_browsertest.cc | 2 +- .../login/screens/update_screen_unittest.cc | 2 +- .../login/ui/captive_portal_window_browsertest.cc | 2 +- .../chromeos/login/ui/login_display_host_webui.cc | 2 +- ...ive_directory_password_change_screen_handler.cc | 2 +- .../login/arc_terms_of_service_screen_handler.cc | 1 - .../login/arc_terms_of_service_screen_handler.h | 21 +++++++- .../ui/webui/chromeos/login/core_oobe_handler.h | 33 +++++++++++- .../ui/webui/chromeos/login/error_screen_handler.h | 49 ++++++++++++++++-- .../ui/webui/chromeos/login/eula_screen_handler.cc | 2 +- .../ui/webui/chromeos/login/gaia_screen_handler.h | 2 +- .../chromeos/login/hid_detection_screen_handler.cc | 2 +- .../webui/chromeos/login/network_screen_handler.cc | 2 +- .../webui/chromeos/login/network_screen_handler.h | 35 ++++++++++++- .../login/recommend_apps_screen_handler.cc | 55 +++++++++----------- .../chromeos/login/recommend_apps_screen_handler.h | 20 ++------ .../webui/chromeos/login/signin_screen_handler.cc | 2 +- .../login/terms_of_service_screen_handler.cc | 2 +- .../webui/chromeos/login/welcome_screen_handler.cc | 2 +- 37 files changed, 220 insertions(+), 354 deletions(-) commit 317de293a0b989503152db55a041df75244d1041 Author: Victor Costan <pwnall@chromium.org> Date: Mon Apr 22 22:27:50 2019 +0000 googletest: Stop specifying Version in README.chromium. //DEPS is the source of truth for the googletest version. This CL follows the pattern in //third_party/skia, so googletest can be auto-rolled using similar infrastructure. Change-Id: Idd6597732174fad7ebd5b2eb69f78137749599bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577970 Auto-Submit: Victor Costan <pwnall@chromium.org> Commit-Queue: Staphany Park <staphany@chromium.org> Reviewed-by: Staphany Park <staphany@chromium.org> Cr-Commit-Position: refs/heads/master@{#652980} third_party/googletest/README.chromium | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 42950301f90e4a055bb2a0d6f5d8fdc088ac8d4f Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Apr 22 22:26:55 2019 +0000 Roll src/third_party/chromite d4e1e42767a5..47f37d2d77a4 (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/d4e1e42767a5..47f37d2d77a4 git log d4e1e42767a5..47f37d2d77a4 --date=short --no-merges --format='%ad %ae %s' 2019-04-22 tomhughes@chromium.org chromeos_config: restore auron_paine to important boards Created with: gclient setdep -r src/third_party/chromite@47f37d2d77a4 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: Ia82a1edec6e4e899c62b01bec8e6277c2227e63b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576269 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652979} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 9f532a16e6a7569741457f48a1c7ccf63b8a4ac7 Author: Ryan Hamilton <rch@chromium.org> Date: Mon Apr 22 22:26:41 2019 +0000 Update Net.AlternateProtocolBrokenLocation in HttpNetworkTransaction. Change-Id: Ic0a624d62f0876ca02c204f874803809d2f81d1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577793 Reviewed-by: Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#652978} net/http/http_network_transaction.cc | 2 ++ net/http/http_server_properties.h | 1 + tools/metrics/histograms/enums.xml | 1 + 3 files changed, 4 insertions(+) commit 08718f7357da81ee2d6a31cc1b38569c55f008ff Author: Adam Langley <agl@chromium.org> Date: Mon Apr 22 22:21:33 2019 +0000 device/fido: handle user-info truncation. CTAP2 authenticators are permitted to truncate |name| and |displayName| fields at 64 bytes, and CTAP2 Yubikeys actually do so. However, this truncation is done without any reference to the UTF-8 structure thus can truncate in the middle of a multi-byte code-point. This makes future responses from the authenticator potentially invalid CBOR because the strings within are invalid UTF-8. This change adds a facility to components/cbor to allow users of the parser to indicate that invalid UTF-8 (except in map keys) should be returned as Values of type |INVALID_UTF8|. This change also uses this facility when processing CTAP2 GetAssertion responses to allow precisely the |name| and |displayName| fields to be truncated at (or after) 64 bytes. Any partial, multi-byte sequence at the end of the invalid UTF-8 is dropped. Bug: 941120 Change-Id: I1742128ee1e689fe400083404f17efc8afd55a97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573091 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by: Chris Palmer <palmer@chromium.org> Reviewed-by: Balazs Engedy <engedy@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#652977} components/cbor/diagnostic_writer.cc | 33 +++-- components/cbor/diagnostic_writer_unittest.cc | 13 ++ components/cbor/reader.cc | 93 ++++++++----- components/cbor/reader.h | 50 +++++-- components/cbor/reader_unittest.cc | 54 ++++++++ components/cbor/values.cc | 15 ++ components/cbor/values.h | 8 ++ components/cbor/writer.cc | 4 + device/fido/BUILD.gn | 1 + device/fido/ctap2_device_operation.h | 38 +++++- device/fido/ctap_response_fuzzer.cc | 15 +- device/fido/device_response_converter.cc | 189 ++++++++++++++++++++++++++ device/fido/device_response_converter.h | 5 + device/fido/fido_device_authenticator.cc | 21 ++- device/fido/get_assertion_handler_unittest.cc | 25 ++-- device/fido/get_assertion_task.cc | 29 +++- device/fido/get_assertion_task.h | 9 ++ device/fido/make_credential_task.cc | 18 ++- 18 files changed, 530 insertions(+), 90 deletions(-) commit 8195718464acd806ad772ca5c7bc9d567ba8a343 Author: Bruce Dawson <brucedawson@chromium.org> Date: Mon Apr 22 22:20:37 2019 +0000 Delete custom _load_config_used _load_config_used is a magic global that is used to configure how a process on Window starts up. We modified it in 2015 to change how the heap works, but it is not clear whether this was beneficial, and it means that we are now missing some changes to that structure. The cost/benefit analysis says that our custom structure isn't worth it. Bug: 954573 Change-Id: I9499d52377f25614123fbfd17a228f029c9d0267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575870 Reviewed-by: Carlos Pizano <cpu@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#652976} chrome/BUILD.gn | 1 - chrome/app/chrome_exe_load_config_win.cc | 114 ------------------------------- 2 files changed, 115 deletions(-) commit 637570b9b5c3b3f9761a0017240d0e598ddddfe1 Author: Josh Nohle <nohle@google.com> Date: Mon Apr 22 22:14:40 2019 +0000 [DeviceSync v2] Add "DeviceSync:BetterTogether" key Enrolling a key with name "DeviceSync:BetterTogether" adds the device to the user's DeviceSync v2 "DeviceSync:BetterTogether" group. Only devices that are in this group can send and receive device metadata using SyncMetadata calls. Note: This key is not to be confused with the unenrolled "group key-pair" which is used to end-to-end encrypt device metadata. Bug: 951969 Change-Id: I98d7a7aeda2656a86797d16410c2772d27d4a5a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575681 Auto-Submit: Josh Nohle <nohle@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#652975} chromeos/services/device_sync/cryptauth_constants.cc | 2 ++ chromeos/services/device_sync/cryptauth_constants.h | 1 + chromeos/services/device_sync/cryptauth_key_bundle.cc | 7 ++++++- chromeos/services/device_sync/cryptauth_key_bundle.h | 15 +++++++++++++-- 4 files changed, 22 insertions(+), 3 deletions(-) commit 3ea0a1b319d7acaf708abd2dbe440836173ad044 Author: Chris Lu <thegreenfrog@chromium.org> Date: Mon Apr 22 22:12:58 2019 +0000 Reland "[ios] Turn on UMA feature flag by default" This is a reland of 3a554bbcea3febe6d6b4ef5636a0fc3e3796a2e6 Original change's description: > [ios] Turn on UMA feature flag by default > > Bug: 931289 > Change-Id: Ibd211f4a28d394793b986ad835015ac9c4948768 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569748 > Commit-Queue: Chris Lu <thegreenfrog@chromium.org> > Reviewed-by: Sergio Collazos <sczs@chromium.org> > Reviewed-by: Steven Holte <holte@chromium.org> > Cr-Commit-Position: refs/heads/master@{#651915} Bug: 931289 Change-Id: I27f4e7421d4ee5408910b6806ed67d8764dc2471 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574292 Auto-Submit: Chris Lu <thegreenfrog@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#652974} components/ukm/ios/features.cc | 2 +- ios/chrome/browser/ui/settings/BUILD.gn | 1 + ios/chrome/browser/ui/settings/password/BUILD.gn | 1 + .../privacy_table_view_controller_unittest.mm | 4 +- ios/chrome/browser/ui/settings/settings_egtest.mm | 85 ++++++++++++++-------- 5 files changed, 60 insertions(+), 33 deletions(-) commit f3988cb9c9b5d81d418a486ad41edc1b13b8cbd9 Author: Kenneth Russell <kbr@chromium.org> Date: Mon Apr 22 22:10:57 2019 +0000 Revert "WebGPU decoder: Add Associate/Dissociate mailbox" This reverts commit 29f337ed7c913dc96196b28f4a2cc505362b3954. Reason for revert: caused Mac GPU ASAN failures since https://ci.chromium.org/p/chromium/builders/ci/Mac%20FYI%20GPU%20ASAN%20Release/6262 Original change's description: > WebGPU decoder: Add Associate/Dissociate mailbox > > These WebGPU IPC commands allows wrapping a mailbox in a Dawn texture > and associate it to a given ID in dawn_wire. There is the respective > dissociate command too. > > SharedImageRepresentationIOSurfaceDawn is changed to destroy() the Dawn > texture on EndAccess so it is an error to access the texture after the > mailbox has been dissociated. The class also gets some refcounting > improvements. > > This also makes some GPU service objects able to be used when no GL > context is present, as is the case when running WebGPU unittests. > > BUG=chromium:877147 > > Change-Id: I22233d01faf4948385cc028a7ce2a2a140ee7a1d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566347 > Reviewed-by: Antoine Labour <piman@chromium.org> > Commit-Queue: Corentin Wallez <cwallez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#652825} TBR=cwallez@chromium.org,piman@chromium.org Change-Id: I8ea19fd427b51e09b8b616e1f95e00bc30ef4c39 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:877147 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577950 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#652973} gpu/BUILD.gn | 1 - gpu/command_buffer/build_webgpu_cmd_buffer.py | 9 +- .../client/webgpu_cmd_helper_autogen.h | 23 --- gpu/command_buffer/client/webgpu_implementation.cc | 10 - gpu/command_buffer/client/webgpu_implementation.h | 2 - .../client/webgpu_implementation_autogen.h | 9 - .../client/webgpu_implementation_impl_autogen.h | 27 --- .../webgpu_implementation_unittest_autogen.h | 26 --- gpu/command_buffer/client/webgpu_interface.h | 7 - .../client/webgpu_interface_autogen.h | 8 - gpu/command_buffer/common/webgpu_cmd_format.h | 1 - .../common/webgpu_cmd_format_autogen.h | 105 ---------- .../common/webgpu_cmd_format_test_autogen.h | 51 ----- gpu/command_buffer/common/webgpu_cmd_ids_autogen.h | 5 +- .../shared_image_backing_factory_iosurface.h | 6 +- .../shared_image_backing_factory_iosurface.mm | 62 +----- ...red_image_backing_factory_iosurface_unittest.cc | 19 +- gpu/command_buffer/service/shared_image_factory.cc | 13 +- gpu/command_buffer/service/shared_image_factory.h | 3 +- .../service/shared_image_factory_unittest.cc | 4 +- .../service/shared_image_representation.h | 2 - gpu/command_buffer/service/webgpu_decoder.cc | 6 +- gpu/command_buffer/service/webgpu_decoder.h | 4 - gpu/command_buffer/service/webgpu_decoder_impl.cc | 126 +----------- gpu/command_buffer/service/webgpu_decoder_impl.h | 4 - .../service/webgpu_decoder_unittest.cc | 140 ------------- gpu/command_buffer/tests/fuzzer_main.cc | 2 +- gpu/command_buffer/tests/webgpu_fence_unittest.cc | 2 + .../tests/webgpu_mailbox_unittest.cc | 224 --------------------- gpu/command_buffer/tests/webgpu_test.cc | 22 -- gpu/command_buffer/tests/webgpu_test.h | 7 - gpu/command_buffer/webgpu_cmd_buffer_functions.txt | 4 +- gpu/ipc/in_process_command_buffer.cc | 17 +- gpu/ipc/service/shared_image_stub.cc | 2 +- gpu/ipc/service/webgpu_command_buffer_stub.cc | 3 +- 35 files changed, 39 insertions(+), 917 deletions(-) commit 0c2b7231b02a728ea1765a0edfaf0c66251e0762 Author: Roberto Carrillo <robertocn@google.com> Date: Mon Apr 22 22:10:15 2019 +0000 [code coverage] Spin up builder for custom oobe reports. This builder is expected to run code coverage builds with custom modifications for the code mauve effort. R=stgao,liaoyuke,jbudorick NOTRY=true Bug: 953123 Change-Id: I324de432632401db5956944225380144e7b23e3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572926 Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Reviewed-by: Yuke Liao <liaoyuke@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#652972} infra/config/cr-buildbucket.cfg | 11 + infra/config/luci-milo.cfg | 5 + infra/config/luci-scheduler.cfg | 11 + testing/buildbot/chromium.fyi.json | 829 +++++++++++++++++++++++++++++ testing/buildbot/test_suite_exceptions.pyl | 15 + testing/buildbot/waterfalls.pyl | 11 + tools/mb/mb_config.pyl | 1 + 7 files changed, 883 insertions(+) commit aafff540c0d786f08839b2a7f638f7eed48e047d Author: Matt Menke <mmenke@chromium.org> Date: Mon Apr 22 22:09:36 2019 +0000 SocketParams refactor 3: Add ClientSocketPool::CreateConnectJob. This new method takes in all the objects needed to create the socket params for a ConnectJob, and then returns a newly created one by invoking the ClientSocketPool::SocketParams callbacks (Which does not actually need all those parameters, as it has a number of them baked in). These parameters include the GroupID, the ProxyServer, and whether or not the socket is for use with websockets. This also required passing in the ProxyServer and websocket information to TransportClientSocketPool, which didn't previously need that information. In a followup CL, I'll make SocketParams no longer a callback, and have the method do some of what ClientSocketPoolMaager does. Bug: 533571 Change-Id: Ie9113ec941f5db3363255bf27a113841d1b30377 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562613 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#652971} net/http/http_network_transaction_unittest.cc | 3 ++ net/http/http_stream_factory_unittest.cc | 2 + net/socket/client_socket_pool.cc | 15 +++++- net/socket/client_socket_pool.h | 14 ++++- net/socket/client_socket_pool_base_unittest.cc | 4 +- net/socket/client_socket_pool_manager_impl.cc | 7 +-- net/socket/socket_test_util.cc | 3 ++ net/socket/transport_client_socket_pool.cc | 60 +++++++++++++--------- net/socket/transport_client_socket_pool.h | 8 ++- .../transport_client_socket_pool_unittest.cc | 25 +++++---- .../websocket_transport_client_socket_pool.cc | 14 +++-- .../websocket_transport_client_socket_pool.h | 3 ++ ...socket_transport_client_socket_pool_unittest.cc | 6 ++- 13 files changed, 115 insertions(+), 49 deletions(-) commit 8cc68ad17950074617f8b15154e750a3659a2583 Author: Matt Menke <mmenke@chromium.org> Date: Mon Apr 22 22:05:52 2019 +0000 SocketParams refactor 2: Split up CreateSocketParamsAndGetGroupId(). One method creates the group ID, one takes raw parameters and returns a SocketParams object, and one takes a group ID (and other values) and calls the second method. This is part of an effort to replace the current SocketParams callback with an object (And eventually remove all fields of the object, removing SocketParams entirely). Bug: 533571 Change-Id: I518d6a2e62f160879a0094aa4772359c56815e47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561845 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#652970} net/socket/client_socket_pool_manager.cc | 109 +++++++++++++++++-------------- 1 file changed, 61 insertions(+), 48 deletions(-) commit 5d638a8d18eb1a797c1f6ab287f49a184393bc36 Author: Kurt Catti-Schmidt <kschmi@microsoft.com> Date: Mon Apr 22 22:03:52 2019 +0000 Remove bubbled out HRESULTS from TextRange methods The current implementation of AXPlatformNodeTextProviderWin and AXPlatformNodeTextRangeProviderWin can bubble out any failed HRESULTS from CComObject<>::CreateInstance. As identified in other code review feedback, these HRESULTS can be misleading. This change updates the AXPlatformNodeText*ProviderCreate* methods to return void, and simply leave the out-pointer as nullptr upon failure of CComObject<>::CreateInstance. The GetPatternProviderFactoryMethod and associated helpers were also refactored to return void, as those can also never fail. Bug: 928948 Change-Id: Icff0250ae88544cbef7ffa979805e6681765322d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562216 Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#652969} .../ax_platform_node_textchildprovider_win.cc | 27 ++++++---- .../ax_platform_node_textchildprovider_win.h | 5 +- ...platform_node_textchildprovider_win_unittest.cc | 6 ++- .../platform/ax_platform_node_textprovider_win.cc | 59 +++++++++++----------- .../platform/ax_platform_node_textprovider_win.h | 5 +- .../ax_platform_node_textrangeprovider_win.cc | 27 +++++----- .../ax_platform_node_textrangeprovider_win.h | 6 +-- ui/accessibility/platform/ax_platform_node_win.cc | 7 ++- ui/accessibility/platform/ax_platform_node_win.h | 3 +- 9 files changed, 75 insertions(+), 70 deletions(-) commit c521fcd1eb9e7481bea9f76dba24e1c88f38c641 Author: Kyle Milka <kmilka@chromium.org> Date: Mon Apr 22 22:03:11 2019 +0000 [NTP] Remove unused parts of the embeddedSearch API CheckIsUserSignedInToChromeAs and HistorySyncCheck were only used by the Google remote NTP and never documented at https://www.chromium.org/embeddedsearch. Now that the local NTP is enabled they can be removed. Bug: 860370, 583289 Change-Id: I40c5fe0a7894721f7488124db3512b867fdacc3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576019 Reviewed-by: Kristi Park <kristipark@chromium.org> Reviewed-by: Chris Palmer <palmer@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#652968} chrome/browser/resources/local_ntp/externs.js | 10 --- chrome/browser/ui/search/local_ntp_browsertest.cc | 4 -- chrome/browser/ui/search/search_ipc_router.cc | 24 ------- chrome/browser/ui/search/search_ipc_router.h | 15 ---- .../ui/search/search_ipc_router_policy_impl.cc | 8 --- .../ui/search/search_ipc_router_policy_impl.h | 2 - .../ui/search/search_ipc_router_policy_unittest.cc | 22 ------ .../ui/search/search_ipc_router_unittest.cc | 72 ------------------- chrome/browser/ui/search/search_tab_helper.cc | 23 ------ chrome/browser/ui/search/search_tab_helper.h | 12 ---- .../ui/search/search_tab_helper_unittest.cc | 81 ---------------------- chrome/common/search.mojom | 7 -- chrome/common/search/mock_embedded_search_client.h | 2 - chrome/renderer/searchbox/searchbox.cc | 28 -------- chrome/renderer/searchbox/searchbox.h | 9 --- chrome/renderer/searchbox/searchbox_extension.cc | 66 ------------------ chrome/renderer/searchbox/searchbox_extension.h | 2 - 17 files changed, 387 deletions(-) commit c412f2209e81c1ede93982db1292e06584046d74 Author: Dale Curtis <dalecurtis@chromium.org> Date: Mon Apr 22 22:02:45 2019 +0000 Roll src/third_party/dav1d/libdav1d/ 589e96a1f..f8cac8c56 (2 commits) https://chromium.googlesource.com/external/github.com/videolan/dav1d.git/+log/589e96a1f2cf..f8cac8c56b3e $ git log 589e96a1f..f8cac8c56 --date=short --no-merges --format='%ad %ae %s' 2019-04-22 gramner Fix crash in SSSE3 inverse transform 2019-04-19 jb Update NEWS for 0.2.2 Created with: roll-dep src/third_party/dav1d/libdav1d TBR=tguilbert Bug: 955077 Change-Id: I24edeaac191bf5ac29dac9d6b5adcb1338265aae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577789 Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#652967} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 073277c4e537ccdf840b871344f695c732eec3ab Author: Bo Liu <boliu@chromium.org> Date: Mon Apr 22 22:00:47 2019 +0000 android: Add VariableSizeAllocatorImpl Very simple implementation so don't really need any tests yet. Again, nothing is using this new class yet. Bug: 953307 Change-Id: If2458a043b166dbc546ef3cd3de897b061341ef3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574338 Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Reviewed-by: ssid <ssid@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#652966} .../process_launcher/ChildConnectionAllocator.java | 97 ++++++++++++++++++---- .../ChildConnectionAllocatorTest.java | 3 +- .../ChildProcessLauncherIntegrationTest.java | 10 ++- .../content/browser/SpareChildConnectionTest.java | 3 +- 4 files changed, 93 insertions(+), 20 deletions(-) commit 2f5e583b1265e500da02ce4498450e38ebbfa683 Author: Peter Kasting <pkasting@chromium.org> Date: Mon Apr 22 21:58:03 2019 +0000 Change MenuItemView::RemoveMenuItemAt() to RemoveMenuItem(). This eliminates a use of View::child_at() and is simpler. Bug: 940135 Change-Id: Id878cb52fb2239aa9460c243f5f5d7b4686dc458 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575168 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by: Alex Newcomer <newcomer@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#652965} ash/app_menu/notification_menu_controller.cc | 3 +-- .../ui/views/bookmarks/bookmark_menu_delegate.cc | 2 +- .../ui/views/menu_item_view_interactive_uitest.cc | 4 ++-- ui/views/controls/menu/menu_item_view.cc | 10 +++------- ui/views/controls/menu/menu_item_view.h | 6 +++--- ui/views/controls/menu/menu_item_view_unittest.cc | 17 +++++++++++++++++ 6 files changed, 27 insertions(+), 15 deletions(-) commit 07927033a8fe3ae7b492bdc598acd1d04353175c Author: Christian Fremerey <chfremer@chromium.org> Date: Mon Apr 22 21:56:42 2019 +0000 [Video Capture Service] Add tests cases for mixing single client and multi client APIs Bug: 783442 Change-Id: I1c2c081c8647950c1e7b54f5205b51ed86d0631f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554882 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#652964} ...brtc_video_capture_shared_device_browsertest.cc | 183 +++++++++++++-------- 1 file changed, 118 insertions(+), 65 deletions(-) commit 9bac7c7fcd1df46c959fa4029a63fdf0939a69ce Author: Dana Fried <dfried@chromium.org> Date: Mon Apr 22 21:56:33 2019 +0000 Move bookmark_stats to c/b/ui since it's only used there. It's generally best to have shared code closest to where it's actually being used. Also since there is currently only one owner in c/b/bookmarks and he already gets a LOT of code reviews for other stuff, this makes it easier to update the UMA logging logic in the browser without creating needless drag on one individual. Change-Id: I0b9e7ebef075000f1665461381d2eceec4e8037c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576172 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#652963} chrome/browser/BUILD.gn | 2 -- .../api/bookmark_manager_private/bookmark_manager_private_api.cc | 1 - chrome/browser/ui/BUILD.gn | 2 ++ chrome/browser/ui/bookmarks/bookmark_context_menu_controller.h | 2 +- chrome/browser/{ => ui}/bookmarks/bookmark_stats.cc | 2 +- chrome/browser/{ => ui}/bookmarks/bookmark_stats.h | 8 ++++---- .../browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm | 2 +- chrome/browser/ui/omnibox/chrome_omnibox_client.cc | 2 +- chrome/browser/ui/views/bookmarks/bookmark_bar_view.h | 2 +- chrome/browser/ui/views/bookmarks/bookmark_context_menu.h | 2 +- .../browser/ui/views/bookmarks/bookmark_menu_controller_views.cc | 2 +- chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.h | 2 +- .../browser/ui/views/bookmarks/bookmark_menu_delegate_unittest.cc | 2 +- chrome/browser/ui/views/frame/browser_view.cc | 2 +- chrome/browser/ui/views/location_bar/star_view.cc | 2 +- chrome/browser/ui/views/toolbar/app_menu.cc | 2 +- 16 files changed, 18 insertions(+), 19 deletions(-) commit 248f67312c044011db1a13a934314d6c677579d7 Author: James Cook <jamescook@chromium.org> Date: Mon Apr 22 21:55:12 2019 +0000 Print an error if GN arg 'remove_webcore_debug_symbols' is set gn gen has printed a warning about this deprecated argument for 1 month. Upgrade to an error. Bug: 943869 Change-Id: I494bd3e2a4f1c881511026526e42b332689f8ace Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575175 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#652962} third_party/blink/renderer/config.gni | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) commit df4801c23777a65c03cafd58f7653f37d6c7fa63 Author: Chris Morin <cmtm@google.com> Date: Mon Apr 22 21:49:03 2019 +0000 debugd client: remove unused interface functions GetFeedbackLogs and GetUserLogFiles aren't used. BUG=chromium:907193 BUG=b:27210832 TEST=Code search for identifiers TEST=Ensure feedback reports still work Change-Id: I0f90bcb9622e646456e512f050b89cb5dec8361d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573175 Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> Commit-Queue: Chris Morin <cmtm@chromium.org> Cr-Commit-Position: refs/heads/master@{#652961} chromeos/dbus/debug_daemon_client.cc | 22 ---------------------- chromeos/dbus/debug_daemon_client.h | 8 +------- chromeos/dbus/fake_debug_daemon_client.cc | 15 --------------- chromeos/dbus/fake_debug_daemon_client.h | 2 -- 4 files changed, 1 insertion(+), 46 deletions(-) commit e7af4a7fdcfe6ad852beeb7c4e75d3a3fc7ada04 Author: Peter Kasting <pkasting@chromium.org> Date: Mon Apr 22 21:48:06 2019 +0000 Misc. cleanup found while removing View::child_at() from ash/. * Shorten code * Remove SearchResultActionsView::selected_action_ and associated machinery, which is vestigial (most was removed last year on bug 766807) * Fix use of NULL * Avoid negative tab index, which will make later conversion to size_t easier * HighLight -> Highlight Bug: 766807 Change-Id: Icc2bc6a5052b5951d14f920790e1ff626ea08d00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576165 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#652960} ash/app_list/views/search_result_actions_view.cc | 45 +++------------------- ash/app_list/views/search_result_actions_view.h | 9 +---- ash/app_list/views/search_result_view.cc | 31 ++++----------- ash/app_list/views/search_result_view.h | 3 -- .../views/keyboard_shortcut_view.cc | 5 ++- .../views/keyboard_shortcut_view_unittest.cc | 11 ++---- ash/login/ui/login_menu_view.cc | 8 ++-- ash/login/ui/login_menu_view.h | 4 +- 8 files changed, 29 insertions(+), 87 deletions(-) commit b4437d4079e6cd841190105e5c8ec352b7b92212 Author: Mike Wittman <wittman@chromium.org> Date: Mon Apr 22 21:47:59 2019 +0000 [Sampling profiler] Check post-unwind frame when testing unwinding To properly test that a special case unwind has succeeded, we need to check that we successfully unwound past the special case frame. This change adds a frame before the frame under test and verifies that it appears in the resulting stack. There remains a fair amount of duplication in this code which will be addressed in follow-on CLs. Bug: 909957 Change-Id: I6b39102e7bf23496a4b849d1dbf1780db383aaa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574218 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by: Charlie Andrews <charliea@chromium.org> Auto-Submit: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#652959} base/profiler/stack_sampling_profiler_unittest.cc | 128 +++++++++++++++++----- 1 file changed, 103 insertions(+), 25 deletions(-) commit 86b74d327ba548d5820200dc04723133c649174e Author: Jacob Dufault <jdufault@google.com> Date: Mon Apr 22 21:46:57 2019 +0000 cros: Move *View classes into *Handlers - MultideviceSetupScreenView - SupervisionTransitionScreenView - TermsOfServiceScreenView - UpdateRequiredView - UpdateView Also eliminate Delegate classes where present Bug: 928555 Change-Id: Ifa43817470959b9bb6c599074a5937d8b28795ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572522 Reviewed-by: Toni Baržić <tbarzic@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#652958} chrome/browser/chromeos/BUILD.gn | 5 -- .../screens/mock_supervision_transition_screen.h | 2 +- .../chromeos/login/screens/mock_update_screen.h | 2 +- .../login/screens/multidevice_setup_screen.cc | 2 +- .../screens/multidevice_setup_screen_unittest.cc | 2 +- .../login/screens/multidevice_setup_screen_view.h | 29 ----------- .../login/screens/supervision_transition_screen.cc | 2 +- .../screens/supervision_transition_screen_view.h | 37 -------------- .../login/screens/terms_of_service_screen.cc | 27 +++++----- .../login/screens/terms_of_service_screen.h | 20 +++++--- .../login/screens/terms_of_service_screen_view.h | 58 ---------------------- .../login/screens/update_required_screen.cc | 2 +- .../chromeos/login/screens/update_required_view.h | 38 -------------- .../chromeos/login/screens/update_screen.cc | 2 +- .../browser/chromeos/login/screens/update_view.h | 48 ------------------ .../login/multidevice_setup_screen_handler.h | 14 +++++- .../login/supervision_transition_screen_handler.h | 24 ++++++++- .../login/terms_of_service_screen_handler.cc | 3 +- .../login/terms_of_service_screen_handler.h | 35 +++++++++++-- .../login/update_required_screen_handler.h | 25 +++++++++- .../webui/chromeos/login/update_screen_handler.h | 34 ++++++++++++- 21 files changed, 160 insertions(+), 251 deletions(-) commit de891dfa7b7d96c1e569d25eafc0fef017132157 Author: Chris Cunningham <chcunningham@chromium.org> Date: Mon Apr 22 21:45:47 2019 +0000 Mark virtual/threaded/printing/webgl-oversized-printing.html as flaky NOTRY=true Bug: 955109 Change-Id: I6c454280e6d11bf5a7209a030193ca693dabe65d TBR: junov@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577847 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#652957} third_party/blink/web_tests/TestExpectations | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit 5e0ddb247eb5ed5f358a9d5cace2b8bf75e68b2e Author: Hongchan Choi <hongchan@chromium.org> Date: Mon Apr 22 21:42:47 2019 +0000 Silence output channels that are transferred in AudioWorkletGlobalScope::Process() This CL makes sure the audio rendering thread does not access the backing array buffer that is transferred by user. Bug: 952849 Change-Id: I436ce579e9f6b769bc0c1665f77937307f89cee2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570536 Reviewed-by: Raymond Toy <rtoy@chromium.org> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#652956} .../modules/webaudio/audio_worklet_global_scope.cc | 37 ++++++++++++---------- 1 file changed, 20 insertions(+), 17 deletions(-) commit e81d535f18c1ca870a05155d4e8c2550c39eb96f Author: Raymond Toy <rtoy@chromium.org> Date: Mon Apr 22 21:41:47 2019 +0000 Always leave an event in the AudioParam timeline Previously, when the last AudioParam event has been processed and is now in the past, the event would be removed from the timeline. This was an optimization so that we can skip sample-accurate processing of the timeline and just returned fixed values. However, if a new event is added after all events have been deleted, the starting point of the event could be incorrect. For example a setValueAtTime event in the past followed by a linearRampToValueAtTime. Therefore, always leave the very last event in the timeline to establish the starting event if needed by future events. Bug: 951863 Change-Id: Iae0b550a4b497b953a10e85e603ecebb59508a99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565375 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#652955} .../modules/webaudio/audio_param_timeline.cc | 51 ++++++-- .../modules/webaudio/audio_param_timeline.h | 5 + .../the-audioparam-interface/adding-events.html | 144 +++++++++++++++++++++ 3 files changed, 192 insertions(+), 8 deletions(-) commit febe9ee89acd8ba4c18c249ddeadb74fccd29de9 Author: Victor Costan <pwnall@chromium.org> Date: Mon Apr 22 21:41:34 2019 +0000 sqlite: Upgrade from 3.27.2 to 3.28.0. The upgrade did not require changes to Chrome's remaining patches. In SQLite 3.28, when SQLITE_OMIT_COMPILEOPTION_DIAGS is #defined, sqlite3_compileoption_{get,used}() are emitted as compiler macros instead of C functions. This clashes with Chrome's function renaming, and required straightforward workarounds in our shims for sqlite3.{c,h}. Bug: 953838 Change-Id: I8365a60d508d7be4eb3d8a3aabd643473f0d971e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574716 Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#652954} third_party/sqlite/README.chromium | 8 +- third_party/sqlite/amalgamation/rename_exports.h | 635 +- third_party/sqlite/amalgamation/shell/shell.c | 289 +- third_party/sqlite/amalgamation/sqlite3.c | 6134 ++-- third_party/sqlite/amalgamation/sqlite3.h | 59 +- third_party/sqlite/patched/LICENSE.md | 6 + third_party/sqlite/patched/Makefile.in | 17 +- third_party/sqlite/patched/Makefile.msc | 58 +- third_party/sqlite/patched/README.md | 67 +- third_party/sqlite/patched/VERSION | 2 +- third_party/sqlite/patched/autoconf/Makefile.msc | 11 +- third_party/sqlite/patched/configure | 70 +- .../sqlite/patched/ext/fts3/README.tokenizers | 6 +- third_party/sqlite/patched/ext/fts3/fts3.c | 2 +- third_party/sqlite/patched/ext/fts3/fts3_snippet.c | 21 +- third_party/sqlite/patched/ext/fts3/fts3_term.c | 2 +- third_party/sqlite/patched/ext/fts3/fts3_test.c | 2 +- .../sqlite/patched/ext/fts3/fts3_tokenizer.c | 6 +- third_party/sqlite/patched/ext/fts3/fts3_write.c | 10 +- .../sqlite/patched/ext/fts3/unicode/mkunicode.tcl | 2 +- third_party/sqlite/patched/ext/fts5/fts5.h | 4 +- third_party/sqlite/patched/ext/fts5/fts5Int.h | 3 +- third_party/sqlite/patched/ext/fts5/fts5_aux.c | 4 +- third_party/sqlite/patched/ext/fts5/fts5_buffer.c | 4 +- third_party/sqlite/patched/ext/fts5/fts5_config.c | 4 +- third_party/sqlite/patched/ext/fts5/fts5_expr.c | 8 +- third_party/sqlite/patched/ext/fts5/fts5_hash.c | 63 +- third_party/sqlite/patched/ext/fts5/fts5_index.c | 38 +- third_party/sqlite/patched/ext/fts5/fts5_main.c | 24 +- third_party/sqlite/patched/ext/fts5/fts5_storage.c | 2 +- .../sqlite/patched/ext/fts5/fts5_unicode2.c | 2 +- .../sqlite/patched/ext/fts5/test/fts5aa.test | 34 +- .../sqlite/patched/ext/fts5/test/fts5aux.test | 31 + .../sqlite/patched/ext/fts5/test/fts5corrupt3.test | 348 + third_party/sqlite/patched/ext/misc/amatch.c | 2 +- third_party/sqlite/patched/ext/misc/blobio.c | 152 + third_party/sqlite/patched/ext/misc/closure.c | 2 +- third_party/sqlite/patched/ext/misc/fileio.c | 14 +- third_party/sqlite/patched/ext/misc/fossildelta.c | 1086 + third_party/sqlite/patched/ext/misc/fuzzer.c | 4 +- third_party/sqlite/patched/ext/misc/percentile.c | 4 +- third_party/sqlite/patched/ext/misc/unionvtab.c | 4 +- third_party/sqlite/patched/ext/misc/vfsstat.c | 9 +- third_party/sqlite/patched/ext/rbu/rbupartial.test | 86 + third_party/sqlite/patched/ext/rbu/sqlite3rbu.c | 93 +- third_party/sqlite/patched/ext/rtree/rtree.c | 36 +- third_party/sqlite/patched/ext/session/changeset.c | 9 +- .../sqlite/patched/ext/session/changesetfuzz.c | 23 +- .../sqlite/patched/ext/session/sessionB.test | 3 +- .../sqlite/patched/ext/session/sqlite3session.c | 10 +- .../sqlite/patched/ext/session/sqlite3session.h | 2 +- third_party/sqlite/patched/main.mk | 7 +- third_party/sqlite/patched/manifest | 342 +- third_party/sqlite/patched/manifest.uuid | 2 +- third_party/sqlite/patched/src/alter.c | 12 +- third_party/sqlite/patched/src/attach.c | 6 +- third_party/sqlite/patched/src/btree.c | 358 +- third_party/sqlite/patched/src/btree.h | 3 - third_party/sqlite/patched/src/btreeInt.h | 2 +- third_party/sqlite/patched/src/build.c | 23 +- third_party/sqlite/patched/src/expr.c | 15 +- third_party/sqlite/patched/src/func.c | 4 + third_party/sqlite/patched/src/hash.c | 4 +- third_party/sqlite/patched/src/hash.h | 2 +- third_party/sqlite/patched/src/insert.c | 14 +- third_party/sqlite/patched/src/loadext.c | 7 +- third_party/sqlite/patched/src/main.c | 2 + third_party/sqlite/patched/src/malloc.c | 3 + third_party/sqlite/patched/src/pager.c | 5 +- third_party/sqlite/patched/src/parse.y | 111 +- third_party/sqlite/patched/src/pcache1.c | 4 +- third_party/sqlite/patched/src/printf.c | 9 +- third_party/sqlite/patched/src/resolve.c | 28 +- third_party/sqlite/patched/src/select.c | 2 +- third_party/sqlite/patched/src/shell.c.in | 275 +- third_party/sqlite/patched/src/sqlite.h.in | 47 +- third_party/sqlite/patched/src/sqlite3ext.h | 6 + third_party/sqlite/patched/src/sqliteInt.h | 43 +- third_party/sqlite/patched/src/tclsqlite.c | 225 +- third_party/sqlite/patched/src/test1.c | 34 +- third_party/sqlite/patched/src/test4.c | 44 +- third_party/sqlite/patched/src/test_fs.c | 16 +- third_party/sqlite/patched/src/test_func.c | 19 + third_party/sqlite/patched/src/test_tclsh.c | 2 + third_party/sqlite/patched/src/test_vdbecov.c | 120 + third_party/sqlite/patched/src/test_vfs.c | 2 + third_party/sqlite/patched/src/tokenize.c | 8 +- third_party/sqlite/patched/src/treeview.c | 50 +- third_party/sqlite/patched/src/utf.c | 14 +- third_party/sqlite/patched/src/util.c | 35 +- third_party/sqlite/patched/src/vacuum.c | 14 +- third_party/sqlite/patched/src/vdbe.c | 118 +- third_party/sqlite/patched/src/vdbeInt.h | 10 +- third_party/sqlite/patched/src/vdbeapi.c | 62 +- third_party/sqlite/patched/src/vdbeaux.c | 13 +- third_party/sqlite/patched/src/vdbemem.c | 30 +- third_party/sqlite/patched/src/vdbesort.c | 10 +- third_party/sqlite/patched/src/wal.c | 11 +- third_party/sqlite/patched/src/where.c | 10 +- third_party/sqlite/patched/src/wherecode.c | 46 +- third_party/sqlite/patched/src/whereexpr.c | 6 + third_party/sqlite/patched/src/window.c | 2425 +- third_party/sqlite/patched/test/altertab2.test | 2 + third_party/sqlite/patched/test/altertab3.test | 37 + third_party/sqlite/patched/test/autoinc.test | 24 + third_party/sqlite/patched/test/autoindex5.test | 3 + third_party/sqlite/patched/test/badutf2.test | 18 +- third_party/sqlite/patched/test/bestindex1.test | 57 + third_party/sqlite/patched/test/capi3d.test | 22 +- third_party/sqlite/patched/test/corrupt2.test | 18 +- third_party/sqlite/patched/test/corruptC.test | 3 +- third_party/sqlite/patched/test/corruptD.test | 5 +- third_party/sqlite/patched/test/corruptK.test | 6 + third_party/sqlite/patched/test/corruptL.test | 122 +- third_party/sqlite/patched/test/createtab.test | 10 +- third_party/sqlite/patched/test/dbfuzz001.test | 6 +- third_party/sqlite/patched/test/dbfuzz2.c | 4 +- third_party/sqlite/patched/test/delete4.test | 77 + third_party/sqlite/patched/test/e_vacuum.test | 47 +- third_party/sqlite/patched/test/fts3atoken.test | 38 + third_party/sqlite/patched/test/fts3corrupt4.test | 865 +- third_party/sqlite/patched/test/fts3expr4.test | 2 +- third_party/sqlite/patched/test/fts3varint.test | 9 +- third_party/sqlite/patched/test/func.test | 28 + third_party/sqlite/patched/test/fuzzcheck.c | 4 +- third_party/sqlite/patched/test/fuzzdata7.db | Bin 16417792 -> 16793600 bytes third_party/sqlite/patched/test/fuzzdata8.db | Bin 960512 -> 1057792 bytes third_party/sqlite/patched/test/in.test | 21 + third_party/sqlite/patched/test/indexfault.test | 10 + third_party/sqlite/patched/test/insert4.test | 20 + third_party/sqlite/patched/test/journal3.test | 3 + third_party/sqlite/patched/test/like3.test | 52 + third_party/sqlite/patched/test/memdb1.test | 18 + third_party/sqlite/patched/test/permutations.test | 16 +- third_party/sqlite/patched/test/pg_common.tcl | 35 +- third_party/sqlite/patched/test/pragma.test | 25 + third_party/sqlite/patched/test/pragma4.test | 7 + third_party/sqlite/patched/test/printf.test | 2 +- third_party/sqlite/patched/test/releasetest.tcl | 25 +- .../sqlite/patched/test/releasetest_data.tcl | 412 + third_party/sqlite/patched/test/scanstatus.test | 2 +- third_party/sqlite/patched/test/sessionfuzz.c | 1 - third_party/sqlite/patched/test/shell1.test | 2 + third_party/sqlite/patched/test/skipscan1.test | 28 + third_party/sqlite/patched/test/skipscan2.test | 1 + third_party/sqlite/patched/test/sqllimits1.test | 10 + third_party/sqlite/patched/test/tclsqlite.test | 140 +- third_party/sqlite/patched/test/tester.tcl | 40 + third_party/sqlite/patched/test/triggerC.test | 14 + third_party/sqlite/patched/test/vacuum-into.test | 13 + third_party/sqlite/patched/test/wal2.test | 6 +- third_party/sqlite/patched/test/wapp.tcl | 987 + third_party/sqlite/patched/test/wapptest.tcl | 674 + third_party/sqlite/patched/test/where.test | 101 + third_party/sqlite/patched/test/window1.test | 448 + third_party/sqlite/patched/test/window3.tcl | 28 +- third_party/sqlite/patched/test/window3.test | 34183 ++++++++++++++++++- third_party/sqlite/patched/test/window4.tcl | 2 +- third_party/sqlite/patched/test/window4.test | 9 +- third_party/sqlite/patched/test/window6.test | 55 +- third_party/sqlite/patched/test/window7.tcl | 91 + third_party/sqlite/patched/test/window7.test | 94 + third_party/sqlite/patched/test/window8.tcl | 299 + third_party/sqlite/patched/test/window8.test | 4875 +++ third_party/sqlite/patched/test/windowerr.tcl | 69 + third_party/sqlite/patched/test/windowerr.test | 111 + third_party/sqlite/patched/test/windowfault.test | 63 +- .../sqlite/patched/test/without_rowid1.test | 36 + third_party/sqlite/patched/tool/addopcodes.tcl | 64 - third_party/sqlite/patched/tool/cg_anno.tcl | 4 +- third_party/sqlite/patched/tool/dbtotxt.c | 2 +- .../sqlite/patched/tool/extract-sqlite3h.tcl | 21 + third_party/sqlite/patched/tool/mkkeywordhash.c | 10 +- third_party/sqlite/patched/tool/omittest.tcl | 13 +- third_party/sqlite/patched/tool/showdb.c | 2 +- third_party/sqlite/patched/tool/symbols.sh | 10 +- ...le-supporting-recovery-of-corrupted-datab.patch | 13 +- ...ell.c-helpers-to-load-Chromium-s-ICU-data.patch | 10 +- ...x-compilation-with-SQLITE_OMIT_WINDOWFUNC.patch | 32 - ...x-dbfuzz2.c-compilation-errors-on-Windows.patch | 43 - ...p-buffer-overflow-in-vdbeRecordCompareInt.patch | 28 - ...6-fix-heap-buffer-overflow-in-cellsizeptr.patch | 36 - .../0007-fix-integer-overflow-in-checkList.patch | 41 - ...Heap-use-after-free-in-releasePageNotNull.patch | 33 - .../0009-Fix-dangling-pointer-dereference.patch | 66 - .../patches/0010-Fix-faulty-assert-statement.patch | 29 - .../0011-Add-dbfuzz2-progress-handler-patch.patch | 84 - .../0012-Use-fixed-width-integer-type.patch | 28 - ...013-Do-early-detection-for-corrupt-schema.patch | 29 - ...-SQLITE_LIMIT_COLUMN-limit-on-virtual-tab.patch | 222 - ...Use-64-bit-memory-allocator-in-extensions.patch | 239 - third_party/sqlite/sqlite3.h | 18 + third_party/sqlite/sqlite3_shim.c | 18 + 193 files changed, 52476 insertions(+), 7229 deletions(-) commit 0beb9fc1485e525b63033cecc27405e74039e143 Author: K Moon <kmoon@chromium.org> Date: Mon Apr 22 21:40:26 2019 +0000 Return unique_ptr from BrowserWithTestWindowTest::CreateBrowser() This method used to return a raw pointer. A unique_ptr makes the ownership semantics self-evident (caller owns returned Browser), and compiler-enforced. Bug: 954967 Change-Id: I804c4f33d4671b68c059a44bfd7701b7caad0512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577641 Commit-Queue: K Moon <kmoon@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#652953} .../ui/ash/launcher/chrome_launcher_controller_unittest.cc | 3 +-- chrome/browser/ui/ash/media_client_unittest.cc | 4 ++-- .../ui/webui/settings/site_settings_handler_unittest.cc | 4 ++-- chrome/test/base/browser_with_test_window_test.cc | 8 ++++---- chrome/test/base/browser_with_test_window_test.h | 10 +++++----- 5 files changed, 14 insertions(+), 15 deletions(-) commit c671ff8c2ba5c44341c8c10ed9537edb643d6529 Author: Hongchan Choi <hongchan@chromium.org> Date: Mon Apr 22 21:38:16 2019 +0000 Skip calling context tracker when the page is detached When the associated Document or Page is detached, calling context tracker crashes because of the null pointer. This CL is to guard Tracker() getter when it does not exist. However, now the repro case crashes with a different stack trace, but it looks like a problem that has existed for a while. Bug: 954451 Change-Id: I445008b4bf7dfaa060b1055c94a5da2fbebdbef1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577486 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#652952} .../blink/renderer/modules/webaudio/base_audio_context.cc | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) commit 8fbc71eade3532a7701bab42114614d4a058a2b8 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Mon Apr 22 21:33:48 2019 +0000 Roll src-internal 640039f01b1f..bcfa4703827b (2 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/640039f01b1f..bcfa4703827b Created with: gclient setdep -r src-internal@bcfa4703827b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=chcunningham@chromium.org,loyso@chromium.org,clamy@chromium.org,flackr@chromium.org Change-Id: Icbf33505197e3d565aca6632d949a47dc7268f96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577647 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652951} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 8c87853388813f2de4f0e6151e85d66e59c115dd Author: Brian Geffon <bgeffon@chromium.org> Date: Mon Apr 22 21:29:47 2019 +0000 Chromium: Prevent assistant on Guest Logins. When performing a guest login IdentityManagerFactory can return a null pointer. Bug: 951416 Change-Id: I279d98d03892643e288cbaf107247938b00530db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574266 Commit-Queue: Brian Geffon <bgeffon@chromium.org> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#652950} chrome/browser/ui/ash/assistant/assistant_client.cc | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) commit 040e68ad7b0a30b97ab9103d330ff2a237f2fd17 Author: Brandon Wylie <wylieb@chromium.org> Date: Mon Apr 22 21:29:28 2019 +0000 Reland "[Image Fetcher] Replace AnswersImageFetcher with CachedImageFetcher" This is a reland of 9f25017463ee6cbfa63166b152212b5f705af328 Original change's description: > [Image Fetcher] Replace AnswersImageFetcher with CachedImageFetcher > > Removing a duplicate cached image fetcher here. > > Bug: 934950 > Change-Id: I0063aa8e26cbd4c0a0acb7f3c59f4ee86116e2db > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1481955 > Commit-Queue: Brandon Wylie <wylieb@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Cr-Commit-Position: refs/heads/master@{#651905} Bug: 934950 Change-Id: I33f1f4b6f2aefe8a6fc733102c568f9420f0451d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574628 Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#652949} chrome/android/BUILD.gn | 1 - chrome/android/chrome_java_sources.gni | 1 - .../org/chromium/chrome/browser/BitmapCache.java | 8 ++ .../browser/image_fetcher/CachedImageFetcher.java | 3 + .../chrome/browser/image_fetcher/ImageFetcher.java | 6 ++ .../browser/image_fetcher/ImageFetcherFactory.java | 42 +++++---- .../image_fetcher/InMemoryCachedImageFetcher.java | 7 +- .../browser/image_fetcher/NetworkImageFetcher.java | 3 + .../chrome/browser/omnibox/LocationBar.java | 5 + .../chrome/browser/omnibox/LocationBarLayout.java | 6 ++ .../omnibox/suggestions/AnswersImageFetcher.java | 104 --------------------- .../suggestions/AutocompleteCoordinator.java | 7 +- .../omnibox/suggestions/AutocompleteMediator.java | 7 +- .../answer/AnswerSuggestionProcessor.java | 66 ++++++++----- .../browser/toolbar/top/CustomTabToolbar.java | 3 + .../chrome/browser/toolbar/top/ToolbarLayout.java | 2 + .../chrome/browser/toolbar/top/ToolbarPhone.java | 3 + .../image_fetcher/ImageFetcherFactoryTest.java | 15 +-- .../browser/image_fetcher/ImageFetcherTest.java | 3 + chrome/browser/BUILD.gn | 1 - .../android/omnibox/answers_image_bridge.cc | 77 --------------- tools/metrics/histograms/histograms.xml | 2 + 22 files changed, 136 insertions(+), 236 deletions(-) commit a26757e70c45142be5d556f348ddbc709c56cdcb Author: Javier Ernesto Flores Robles <javierrobles@chromium.org> Date: Mon Apr 22 21:28:39 2019 +0000 Revert "[iOS][Sheriff] Spawns ios_chrome_payments_egtests" This reverts commit 09af73188b5c8408fb876d1d346bc7964b477065. Reason for revert: Sharding will be used instead of this. Bug: 953627 Original change's description: > [iOS][Sheriff] Spawns ios_chrome_payments_egtests > > ios_chrome_ui_egtests is constantly timing out in the waterfall when > running in devices. This CL creates 4 new targets with the tests > suites taking the longest time, effectively removing around 28 min to > run. This should be enough to fix the waterfall and allow some extra > tests to be created while a better solution is found. > > TBR=rohitrao@chromium.org,jbudorick@chromium.org > > Bug: 951468 > Change-Id: I20451a9aa1049a724c48290b616ab259c3c27352 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566337 > Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org> > Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> > Cr-Commit-Position: refs/heads/master@{#651238} TBR=rohitrao@chromium.org,justincohen@chromium.org,olivierrobin@chromium.org,lindsayw@chromium.org,jbudorick@chromium.org,javierrobles@chromium.org NOTRY=true # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 951468 Change-Id: I4b35ffb8664f98271eed11fae940acf350a2c2f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572340 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#652948} ios/build/bots/chromium.fyi/ios-simulator.json | 44 -------------------------- ios/build/bots/tests/eg_cq_tests.json | 20 ------------ ios/chrome/test/earl_grey/BUILD.gn | 32 +++---------------- testing/buildbot/gn_isolate_map.pyl | 20 ------------ testing/buildbot/manage.py | 4 --- 5 files changed, 4 insertions(+), 116 deletions(-) commit 5132591a1cc1b47b54dbe882808e3846cd5d9ada Author: Johannes Henkel <johannes@chromium.org> Date: Mon Apr 22 21:25:51 2019 +0000 [DevTools] Roll inspector_protocol. New rev: 13b84fe7332fe39a8aca39c5eba2ade9375bbb42 Renames sendRawNotification into sendRawJSONNotification / sendRawCBORNotification. Updates call sites in tracing_handler.cc. Change-Id: Ia93231c4b99565415fb7e6b45e38ae200563acad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576263 Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#652947} content/browser/devtools/protocol/tracing_handler.cc | 4 ++-- third_party/inspector_protocol/README.chromium | 2 +- third_party/inspector_protocol/templates/TypeBuilder_cpp.template | 4 ++-- third_party/inspector_protocol/templates/TypeBuilder_h.template | 4 ++-- 4 files changed, 7 insertions(+), 7 deletions(-) commit cca0802ce24f32245cca240fd5e87b4907874206 Author: Justin DeWitt <dewittj@chromium.org> Date: Mon Apr 22 21:24:54 2019 +0000 Revert "[Explore Sites] Fix render tests for other builders." This reverts commit f8c5dd0d94c9196dd5e40c5c3d858ba92c337a86. Reason for revert: Still failing on some builders. Original change's description: > [Explore Sites] Fix render tests for other builders. > > Some tablets failed because scrolling to a position did not guarantee > that position would be the first visible, since the catalog is not > big enough on a tablet. > > Also switches scrollToPosition -> scrollToPositionWithOffset to match > behavior of moving a tile to the top. > > Bug: 953254 > Change-Id: Id7671a73e4ce16cc834ac66daa25369205ed4eee > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570189 > Reviewed-by: Cathy Li <chili@chromium.org> > Commit-Queue: Justin DeWitt <dewittj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#652173} TBR=dewittj@chromium.org,chili@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 953254 Change-Id: Ic6c9b13fd32364261c90fbe9e25fce33833ae287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577663 Reviewed-by: Justin DeWitt <dewittj@chromium.org> Reviewed-by: Cathy Li <chili@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#652946} .../explore_sites/ExploreSitesPageTest.java | 48 +++------------------- ...tesPageTest.recycler_layout.Nexus_5-19.png.sha1 | 2 +- ...geTest.recycler_layout_back.Nexus_5-19.png.sha1 | 2 +- 3 files changed, 8 insertions(+), 44 deletions(-) commit 22d3dc0d74c2fb850756a0b89e30925048114238 Author: Christopher Cameron <ccameron@chromium.org> Date: Mon Apr 22 21:24:40 2019 +0000 Skia/Metal raster: Add viz::MetalContextProvider Add viz::MetalContextProvider, and add Metal to the Skia build by default. Do not wire up any of this yet. Bug: 952063 Change-Id: I1e87fa264219eebdc8d25282f6c2459b45a10974 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577878 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#652945} components/viz/common/BUILD.gn | 31 +++++++++++ components/viz/common/gpu/metal_context_provider.h | 29 ++++++++++ .../viz/common/gpu/metal_context_provider.mm | 65 ++++++++++++++++++++++ .../viz/common/viz_metal_context_provider_export.h | 29 ++++++++++ skia/BUILD.gn | 23 ++++---- 5 files changed, 165 insertions(+), 12 deletions(-) commit 4f204cb031e2a84d82cc81e501162a943b284ed8 Author: Scott Violet <sky@chromium.org> Date: Mon Apr 22 21:20:34 2019 +0000 linux: increase zygote message size The top crasher for ChromeOS dev is because we are hitting the limit of messages passed to the zygote. This increases the limit by 50%. If we didn't pass around features via the command line, this could likely be lowered. I filed a separate bug on that. BUG=955014,955075 TEST=none Change-Id: I5c112bde4d136c0b443d4e4c9e0ed5cc5749ece4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577675 Reviewed-by: Dan Erat <derat@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#652944} services/service_manager/zygote/common/zygote_commands_linux.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 1f812293fc3dd5d1000c009876166047ff7b60fe Author: Zhenyao Mo <zmo@chromium.org> Date: Mon Apr 22 21:15:41 2019 +0000 Add test for gather_power_measurement_results.py So we don't get surprises when we try to run it, it doesn't work because buildbucket APIs changed or step stdout format changed. BUG=867155 TEST=bots R=kbr@chromium.org,dpranke@chromium.org Change-Id: Iaed55b1f262f1ccd3b52b015feae41b08ad2abc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576161 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#652943} content/test/BUILD.gn | 1 + .../test/gpu/gather_power_measurement_results.py | 9 ++++--- .../scripts/test_buildbucket_api_gpu_use_cases.py | 30 +++++++++++++++++++++- 3 files changed, 35 insertions(+), 5 deletions(-) commit ae09f591cdb16a11f61a2118975f85d86d4190fc Author: Collin Baker <collinbaker@chromium.org> Date: Mon Apr 22 21:15:29 2019 +0000 Reset caption button state on download in progress dialog When the close button is pressed with a download in progress, a dialog pops up to confirm the close. This dialog captures all mouse events, and no WM_MOUSELEAVE or WM_NCMOUSELEAVE event gets sent. As a result, the button gets stuck in the hover state until it is re-hovered. Since there isn't a clear way to ensure a mouse leave event is sent, this CL simply resets the window controls when this pop-up is created. Bug: 946391 Change-Id: Ife8a90737aef44d20798154fb38112031d4aff8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577597 Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#652942} chrome/browser/ui/views/frame/browser_view.cc | 4 ++++ 1 file changed, 4 insertions(+) commit 4d17ae69430b9c9e10a65997dd24dd17578bc4b9 Author: Esmael El-Moslimany <aee@chromium.org> Date: Mon Apr 22 21:12:40 2019 +0000 WebUI: removing unused iron-form-element-behavior from third_party/polymer Change-Id: I9299978ccb534f40a0658e76771aac52107a3b75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576003 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#652941} third_party/polymer/v1_0/bower.json | 1 - .../iron-form-element-behavior/BUILD.gn | 10 --- .../iron-form-element-behavior/bower.json | 49 -------------- .../iron-form-element-behavior-extracted.js | 75 ---------------------- .../iron-form-element-behavior.html | 11 ---- third_party/polymer/v1_0/components_summary.txt | 6 -- third_party/polymer/v1_0/rsync_exclude.txt | 3 + ui/webui/resources/polymer_resources.grdp | 8 --- 8 files changed, 3 insertions(+), 160 deletions(-) commit ea44882bcad5c08355d66a8909ed429df033457d Author: Charlene Yan <cyan@chromium.org> Date: Mon Apr 22 21:12:29 2019 +0000 Change AppMenuButton to inherit from ToolbarButton. Bug: 819854 Change-Id: I1772ed67d13a82c1f2c2c19ccfeace7d14719daa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574449 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#652940} chrome/browser/ui/views/frame/app_menu_button.cc | 21 +++++++++++---------- chrome/browser/ui/views/frame/app_menu_button.h | 16 ++++++++++------ chrome/browser/ui/views/frame/browser_view.cc | 5 +++-- 3 files changed, 24 insertions(+), 18 deletions(-) commit 202ed939ac6bc7306807b9fa1c39d57383cebf82 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Apr 22 21:07:23 2019 +0000 Roll src/third_party/skia 7a5b6ec0f6c0..50d79af7b783 (10 commits) https://skia.googlesource.com/skia.git/+log/7a5b6ec0f6c0..50d79af7b783 git log 7a5b6ec0f6c0..50d79af7b783 --date=short --no-merges --format='%ad %ae %s' 2019-04-22 reed@google.com hide internals of SkColorMatrix (so we can migrate to col-major) 2019-04-22 mtklein@google.com deshard NP and N7 CPU test bots 2019-04-22 mtklein@google.com Revert "simplify and centralize SK_API" 2019-04-22 robertphillips@google.com Add explicit GrSurfaceProxy flag to skip explicit resource allocation (take 2) 2019-04-22 mtklein@google.com remove duplicate SkBase64.h 2019-04-22 mtklein@google.com rm src/compute 2019-04-22 borenet@google.com [docs] Update documentation for branching process 2019-04-22 mtklein@google.com simplify and centralize SK_API 2019-04-22 egdaniel@google.com Fully add back old GrContext flush api. 2019-04-22 mtklein@google.com add constexpr constructor to SkMatrix Created with: gclient setdep -r src/third_party/skia@50d79af7b783 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@chromium.org Change-Id: I2890c0331557537c02a3a00c54c31e613fe53260 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577646 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652939} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 26ba0c61abd97a85162a5f43349bec405bb0a743 Author: Akihiro Ota <akihiroota@chromium.org> Date: Mon Apr 22 21:03:32 2019 +0000 Simplify ash accessible battery strings. Reword accessible battery strings for more concise report of battery status and time remaining. Bug: 949047 Change-Id: Idf0109b16d707db69aa6f0455ac44468ccf45939 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565530 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by: David Tseng <dtseng@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#652938} ash/ash_strings.grd | 8 ++++---- .../browser/chromeos/accessibility/spoken_feedback_browsertest.cc | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) commit 17369190511c1e583102a339113729c60697547d Author: Aaron Leventhal <aleventhal@chromium.org> Date: Mon Apr 22 21:01:55 2019 +0000 Fix crash when role is requested before widget is available TBR=dfried@chromium.org Bug: 952741 Change-Id: I2a5beb1c37f45e76fa5014be498ae1b80706dc75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577786 Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by: Dana Fried <dfried@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#652937} ui/views/window/dialog_delegate.cc | 2 ++ 1 file changed, 2 insertions(+) commit f9007edcd4ee66ec6bb348841035bad2c87e1450 Author: Giovanni Panaro <tsrwebgl@gmail.com> Date: Mon Apr 22 20:55:28 2019 +0000 Fixed StatusBubble border on RTL languages The StatusBubble had a missing right or left border depending on its state. This is fixed by changing the right and left clip based on the language format. Bug: 949084 Change-Id: I90fd890a1b74d9c1023a4f1813a91cb0c0757e8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574444 Reviewed-by: Allen Bauer <kylixrd@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#652936} chrome/browser/ui/views/status_bubble_views.cc | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) commit b99496519a7b2383fb6c489662e9c5637b3a2680 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Apr 22 20:54:27 2019 +0000 Roll src/third_party/chromite 8c506a537d15..d4e1e42767a5 (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/8c506a537d15..d4e1e42767a5 git log 8c506a537d15..d4e1e42767a5 --date=short --no-merges --format='%ad %ae %s' 2019-04-22 saklein@chromium.org Build API: Add build packages endpoint. Created with: gclient setdep -r src/third_party/chromite@d4e1e42767a5 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I292f363980b0d2aa6ffdb9929c35bc1e908dcfb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577645 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652935} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 2cda353395d18529f9421c3d30e64c754890eccb Author: David Schinazi <dschinazi@chromium.org> Date: Mon Apr 22 20:51:31 2019 +0000 Roll src/net/third_party/quiche/src/ 075a3dbe8..9f459cbe9 (8 commits) https://quiche.googlesource.com/quiche.git/+log/075a3dbe833c..9f459cbe9aad $ git log 075a3dbe8..9f459cbe9 --date=short --no-merges --format='%ad %ae %s' 2019-04-21 ianswett Remove QuicSentPacketManagerPeer::GetBytesInFlight. 2019-04-20 ianswett Remove QuicSentPacketManagerPeer::HasUnackedCryptoPackets 2019-04-20 ianswett Remove QuicSentPacketManagerPeer::IsUnacked 2019-04-19 renjietang gfe-relnote: Move headers streams out of static stream map. Protected by gfe_reloadable_quic_eliminate_static_stream_map. 2019-04-19 nharper Check that the expected and actual public header types match 2019-04-19 nharper Reject IETF RETRY packets before they hit QUIC_BUGs 2019-04-19 ianswett Remove QuicSentPacketManagerPeer::HasPendingPackets. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: Ib9b051ee29bf285707438a0db1bf3c6f03fcd846 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577495 Auto-Submit: David Schinazi <dschinazi@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#652934} DEPS | 2 +- net/quic/quic_flags_list.h | 10 +++++++--- 2 files changed, 8 insertions(+), 4 deletions(-) commit 728fef038b234900e325a3b9bc528b1fc752f5f3 Author: Tom Sepez <tsepez@chromium.org> Date: Mon Apr 22 20:50:09 2019 +0000 Add Span8() and Span16() methods to WTF::String and StringView base::span<> is a modern method for performing checked access into a contiguous sequence of objects and should be used where possible instead of unsafe C-style pointers. Bug: 955067 Change-Id: Iee7532f398f9ae2244895fb7ff0fdaecf9d4be53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575730 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#652933} .../blink/renderer/platform/wtf/text/string_impl.h | 9 +++++++++ .../blink/renderer/platform/wtf/text/string_view.h | 11 +++++++++++ .../blink/renderer/platform/wtf/text/wtf_string.h | 16 ++++++++++++++++ 3 files changed, 36 insertions(+) commit 5e0d21f2d0b060e234a42a47c56466f0dc0a9ea6 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Apr 22 20:21:23 2019 +0000 Roll src/third_party/depot_tools 8dfc0bce4ac7..6d9913ab1893 (1 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8dfc0bce4ac7..6d9913ab1893 git log 8dfc0bce4ac7..6d9913ab1893 --date=short --no-merges --format='%ad %ae %s' 2019-04-22 vadimsh@chromium.org [lucicfg] Bump lucicfg version v1.7.0 -> v1.7.1. Created with: gclient setdep -r src/third_party/depot_tools@6d9913ab1893 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:953405 TBR=agable@chromium.org Change-Id: I5b40f4dadcc6f7b041256dd16338e895731b1cc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577644 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652932} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit de847a6f752ec375c7524fa2f3163e3f3af9cc95 Author: Xiyuan Xia <xiyuan@chromium.org> Date: Mon Apr 22 20:16:39 2019 +0000 Reland "ash: Keep active window uncovered on display change" This is a reland of 92ecc62f74072bd8bad6c3401130c3fb476ba5d1 Original change's description: > ash: Keep active window uncovered on display change > > - FocusActivationStore uses ActivateWindow(nullptr) for deactivating > to avoid an arbitrary window covering the active window before > Restore(). > - RootWindowController puts the moved windows under existing ones > on display change. > > Bug: 945754 > Change-Id: I3cacfd3427b8c98c9ce9dd2da05977120c1c1d65 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574824 > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#652678} Bug: 945754 Change-Id: If8b796e8b1736e17e35f34fd2e671689e3a88ed4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577561 Reviewed-by: Mitsuru Oshima (Slow 4/22-26) <oshima@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#652931} ash/display/window_tree_host_manager.cc | 9 ++++--- ash/root_window_controller.cc | 12 ++++++--- ash/root_window_controller_unittest.cc | 44 +++++++++++++++++++++++++++++++++ ash/wm/overview/overview_session.cc | 10 ++++++-- 4 files changed, 66 insertions(+), 9 deletions(-) commit b995030997624b9d1fd5adc80db216aa4965eac8 Author: Theresa <twellington@chromium.org> Date: Mon Apr 22 20:15:53 2019 +0000 [Dark theme] Work around default focus highlight bug on NTP For some unknown reason, sometimes our RecyclerView UIs get the default keyboard focus highlight applied after toggling dark mode in Chrome settings. Disable the default focus highlight on the NTP to work around the issue. BUG=943873 Change-Id: I89ba3f424f9efb93ec74b37b9d61444896ba40d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577779 Reviewed-by: Becky Zhou <huayinz@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#652930} .../java/src/org/chromium/chrome/browser/feed/FeedNewTabPage.java | 8 ++++++++ .../chrome/browser/suggestions/SuggestionsRecyclerView.java | 7 +++++++ 2 files changed, 15 insertions(+) commit e29fba53f7de05651f6082f9c5f89badbef04e88 Author: Matthew Jones <mdjones@chromium.org> Date: Mon Apr 22 20:03:54 2019 +0000 Implement half-height dialog for touchless mode This patch adds "half-height" functionality to dialogs in touchless mode. The dialogs at "half-height" have rounded top corners and wrap the content in them. Bug: 930746 Change-Id: I04c8707c90e8c485b2b18f0ab3907dcc0f7beb20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576157 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#652929} .../chrome/browser/feed/FeedNewTabPage.java | 2 +- .../content_suggestions_card_corner_bottom.xml | 4 ++-- .../content_suggestions_card_corner_top.xml | 4 ++-- ...contextual_suggestions_placeholder_thumbnail.xml | 2 +- .../drawable/hairline_border_card_background.xml | 2 +- .../hairline_border_card_background_with_inset.xml | 2 +- .../java/res/drawable/selected_tab_background.xml | 2 +- .../java/res/drawable/tab_grid_card_background.xml | 2 +- .../content_suggestions_card_modern_reversed.xml | 8 ++++---- .../android/java/res/layout/tab_grid_card_item.xml | 4 ++-- chrome/android/java/res/values/dimens.xml | 2 +- .../browser/suggestions/SuggestionsBinder.java | 2 +- .../java/res/drawable/dialog_rounded_top.xml | 16 ++++++++++++++++ .../java/res/layout/touchless_dialog_view.xml | 5 ++--- .../touchless/dialog/TouchlessDialogPresenter.java | 21 ++++++++++++++++++++- 15 files changed, 56 insertions(+), 22 deletions(-) commit 46ed23c7954e989d8a139c735dd9553443a40753 Author: Caroline Rising <corising@chromium.org> Date: Mon Apr 22 19:54:45 2019 +0000 Update bubble dialog delegate view's arrow value for RTL. This caused a bug where the arrow would be mirrored for the bubble border in RTL but not the bubble dialog delegate view causing the two to have differing values and incorrectly mirror/offset when out of bounds. Bug: 954882 Change-Id: I102453a09f1f3b57f65af98c79f1b330b7ac46f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577579 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#652928} ui/views/bubble/bubble_dialog_delegate_view.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) commit d489ae0a42f3d353903637fe5265c4fc98f86d1c Author: Chris Cunningham <chcunningham@chromium.org> Date: Mon Apr 22 19:52:48 2019 +0000 Mark timeline-js-line-level-profile-end-to-end.js as flaky Bug: 954998 Change-Id: Icaabb1e233fe39fe18bcf77033f3d71d913c4429 TBR: oysteine@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577643 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#652927} third_party/blink/web_tests/TestExpectations | 1 + 1 file changed, 1 insertion(+) commit 1ebc9a1af5432ece682822f7c1aa01d3c9942ffa Author: Bo Liu <boliu@chromium.org> Date: Mon Apr 22 19:50:50 2019 +0000 android: Refactor ChildConnectionAllocator Refactor code that assumes there is a fixed number of service slots into a FixedSizeAllocatorImpl subclass. This is to prepare for subsequent implementation with variable number of allocations support. Note FixedSizeAllocatorImpl should really be private but is public to support tests. Bug: 953307 Change-Id: Ie000b832806d2ef7b958db583f172fd8cba0dcb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573653 Reviewed-by: ssid <ssid@chromium.org> Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#652926} .../process_launcher/ChildConnectionAllocator.java | 227 ++++++++++++--------- .../process_launcher/ChildProcessLauncher.java | 1 - .../ChildConnectionAllocatorTest.java | 10 +- .../browser/ChildProcessLauncherHelperImpl.java | 7 +- .../browser/ChildProcessLauncherHelperTest.java | 5 +- .../content/browser/ChildProcessLauncherTest.java | 2 +- .../content/browser/SpareChildConnectionTest.java | 12 +- 7 files changed, 151 insertions(+), 113 deletions(-) commit 443606467b001beef3b3a02857fbc25eb6a00b37 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Mon Apr 22 19:49:21 2019 +0000 Roll src-internal 109321d1bdd1..640039f01b1f (5 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/109321d1bdd1..640039f01b1f Created with: gclient setdep -r src-internal@640039f01b1f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=chcunningham@chromium.org,loyso@chromium.org,clamy@chromium.org,flackr@chromium.org Change-Id: I4721c8977bc9c66e49b0acc933eb5441ed41a386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577589 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652925} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 376412a6a2a58ec9abb3d9570f398aae379a69cb Author: Brian Osman <brianosman@google.com> Date: Mon Apr 22 19:48:22 2019 +0000 Add skcms.h location to include_dirs when building Skia Skia wants to remove the abolute pathing to skcms.h for other clients. This lets us just #include "skcms.h" in Skia sources, which paves the way for relocating skcms.h into Skia's include directory. Change-Id: I7bc5d4d727784554f2a3800b3687d6ef615748f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576176 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Brian Osman <brianosman@google.com> Cr-Commit-Position: refs/heads/master@{#652924} skia/BUILD.gn | 1 + 1 file changed, 1 insertion(+) commit d358e1e86dca3968333de7bb4cd017c3c36bcfd3 Author: David Tseng <dtseng@chromium.org> Date: Mon Apr 22 19:48:13 2019 +0000 Fix ChromeVox presubmit TBR=akihiroota@chromium.org Change-Id: I7fed743fe8a85c4af503dc9c9a0316160588e1b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576325 Reviewed-by: David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#652923} .../chromeos/chromevox/cvox2/background/download_handler.js | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) commit ca7982b50a45ab6262a2d769c18ab87900e1c633 Author: Tarun Bansal <tbansal@chromium.org> Date: Mon Apr 22 19:47:00 2019 +0000 Clean up code related to experiment that delays reqeuests on multiplexed connections This experiment has been enabled for ~6 months from https://chromium-review.googlesource.com/c/chromium/src/+/1257677. This CL cleans up the related field trial code. Change-Id: Ic7a50e8e8b47b723a492d51a2b8ed841f898e416 Bug: 836552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576203 Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#652922} services/network/public/cpp/features.cc | 7 --- services/network/public/cpp/features.h | 2 - .../network/resource_scheduler_params_manager.cc | 54 ++++++---------------- .../network/resource_scheduler_params_manager.h | 2 + .../resource_scheduler_params_manager_unittest.cc | 45 +++--------------- 5 files changed, 23 insertions(+), 87 deletions(-) commit 47aec742bf420df144c5d235f024bceb5345d5a1 Author: Salvador Guerrero <salg@google.com> Date: Mon Apr 22 19:43:09 2019 +0000 [leveldb_proto] Removed unneeded arguments on feature engagement db init leveldb_proto databases in feature engagement were migrated to the new GetDB API, as they were migrated a long time ago they initialized with Init(uma_name, init_callback) This Init method has been deprecated (https://crrev.com/c/1519094) as uma_name is now stored in shared_proto_database_client_list.cc This CL updates both databases to use the current Init(init_callback) method, this is done so all UMA names can be stored in the same place and to be also used as experiment configuration names. Bug: 943162 Change-Id: I04bea2ffbfa94c0a15b9aa0e525e466d9e8d2f9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572921 Commit-Queue: Salvador Guerrero <salg@google.com> Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#652921} .../feature_engagement/internal/persistent_availability_store.cc | 7 +------ components/feature_engagement/internal/persistent_event_store.cc | 6 +----- 2 files changed, 2 insertions(+), 11 deletions(-) commit b3bf9496609464ae5c6f778d3efe2fecf9577f16 Author: Becky Zhou <huayinz@chromium.org> Date: Mon Apr 22 19:42:15 2019 +0000 Fix crash on DownloadProgressInfoBar.updateLayout Clear animation callbacks on InfoBar closed since layout updates are no longer valid. Bug: 954643 Change-Id: I6fd5a0b16f7938c942428e140924820fa9ccd569 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577658 Reviewed-by: Matthew Jones <mdjones@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#652920} .../src/org/chromium/chrome/browser/infobar/DownloadProgressInfoBar.java | 1 + 1 file changed, 1 insertion(+) commit 81f2379b76e78778e5e9f137d9f065e6470c9924 Author: rajendrant <rajendrant@chromium.org> Date: Mon Apr 22 19:41:14 2019 +0000 Enable data saver block duration feature Bug: 947736 Change-Id: Icc637afbcc32b5487e00893c98d73ee1dc27b3dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573239 Reviewed-by: Steven Holte <holte@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#652919} testing/variations/fieldtrial_testing_config.json | 15 +++++++++++++++ 1 file changed, 15 insertions(+) commit 656fbb38f2e58499259dada9bd792e937185087a Author: Ryan Hansberry <hansberry@chromium.org> Date: Mon Apr 22 19:41:11 2019 +0000 [Bluetooth] Stop listening to pairing events once pairing fails. Bug: 954242 Change-Id: I722b60fe37dd0b19d27f1aed44810b7a3ff2f3a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574149 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#652918} ui/webui/resources/cr_components/chromeos/bluetooth_dialog.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) commit 468268abff3322950f3d3010fc484c096795cb64 Author: Sky Malice <skym@chromium.org> Date: Mon Apr 22 19:40:06 2019 +0000 Revert "[Feed] Add spinner metrics to Zine" This reverts commit f9f7e45fd6f95925cfbcf5730fad0a4ff6b31e62. Reason for revert: Breaks touchless builds, see crbug.com/943282 Original change's description: > [Feed] Add spinner metrics to Zine > > Adding 2 metrics, which existing in Feed, but not in Zine > ontentSuggestions.Feed.FetchPendingSpinner.Shown > ContentSuggestions.Feed.FetchPendingSpinner.VisibleDurationWithoutCompleting > > Bug: 943282 > Change-Id: Id72d6fe55a34a4a294f9ea2bb452ce007e376286 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576018 > Commit-Queue: Gang Wu <gangwu@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Cr-Commit-Position: refs/heads/master@{#652755} TBR=twellington@chromium.org,gangwu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 943282 Change-Id: I17025c2b7f9684f377f29f4d7ed027aa87236885 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577578 Reviewed-by: Sky Malice <skym@chromium.org> Reviewed-by: Gang Wu <gangwu@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#652917} .../chrome/browser/ntp/cards/ActionItem.java | 22 +++---- .../browser/ntp/cards/SuggestionsSection.java | 8 +-- .../browser/suggestions/SuggestionsMetrics.java | 75 ++++++---------------- .../browser/ntp/cards/NewTabPageAdapterTest.java | 4 +- .../browser/ntp/cards/SuggestionsSectionTest.java | 6 +- 5 files changed, 33 insertions(+), 82 deletions(-) commit 8967c49035448553e1554633b84d460326b6c10a Author: Tommy C. Li <tommycli@chromium.org> Date: Mon Apr 22 19:40:02 2019 +0000 [omnibox] Steady State Elisions - Enable flag by default To prepare for launch, enabling these dy default on tip of tree. Bug: 842236 Change-Id: I0d40540fcfb6262238670ccfbcbe3d7f371e05e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577488 Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#652916} components/omnibox/common/omnibox_features.cc | 22 ++++++---------------- 1 file changed, 6 insertions(+), 16 deletions(-) commit bdf77780d81d423a6594c383cc594b7962188178 Author: Matt Menke <mmenke@chromium.org> Date: Mon Apr 22 19:38:59 2019 +0000 SocketParams refactor 1: Use PrivacyMode enum in GroupId instead of bools. Enum classes are safer, and since we're going to use this to create SocketParams objects, too, they're also simpler, as it's a bit weird to convert from an enum class to a bool and then back to the original enum class. Bug: 533571 Change-Id: Iead421aca8137de7428f8e0434806bf8da3577b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561962 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#652915} net/http/http_network_transaction_unittest.cc | 31 ++++++++--------- net/http/http_stream_factory_unittest.cc | 8 ++--- net/socket/client_socket_pool.cc | 5 +-- net/socket/client_socket_pool.h | 9 ++--- net/socket/client_socket_pool_base_unittest.cc | 15 +++++---- net/socket/client_socket_pool_manager.cc | 4 +-- net/socket/client_socket_pool_unittest.cc | 24 +++++++------ .../transport_client_socket_pool_unittest.cc | 39 ++++++++++++---------- ...socket_transport_client_socket_pool_unittest.cc | 3 +- net/spdy/spdy_session_unittest.cc | 7 ++-- .../http_with_dns_over_https_unittest.cc | 3 +- .../websocket_basic_stream_adapters_test.cc | 2 +- net/websockets/websocket_basic_stream_test.cc | 3 +- ...ebsocket_handshake_stream_create_helper_test.cc | 3 +- 14 files changed, 86 insertions(+), 70 deletions(-) commit 05068dcd0dafdea35e969a1536862bc493cdc8dd Author: Raymond Toy <rtoy@chromium.org> Date: Mon Apr 22 19:38:56 2019 +0000 Add OWNERS for webaudio tests Bug: 954593 Change-Id: I438bafec932f44a349fd0ba2e2d9910c194b9149 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575177 Reviewed-by: Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#652914} third_party/blink/web_tests/webaudio/OWNERS | 3 +++ 1 file changed, 3 insertions(+) commit aacbd758b2b036277b46d7cfe8f79843f6520fef Author: Alex Cooper <alcooper@chromium.org> Date: Mon Apr 22 19:37:55 2019 +0000 Register mixed_reality_renderloop as a UI Thread On windows release 1809 (and presumably up), input was not being routed to the chromium webxr process/threads. This resulted in polling tracked controllers and subscriptions to input events never firing or returning any controllers. This change has no effect on 1803. Bug: 953129 Change-Id: Ifdfbd47906b1d5817e791449ac94235e346ea0e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577485 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#652913} device/vr/windows_mixed_reality/mixed_reality_device.cc | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) commit f5f160141522e212a0a7769cc4ecea023ed93571 Author: Jarryd <jarrydg@chromium.org> Date: Mon Apr 22 19:37:51 2019 +0000 FileAPI: Add three new Blob APIs This change adds the implementation for three new Blob APIs: stream(), text(), and arrayBuffer(). Related web platform tests: https://crrev.com/c/1526796/ Spec: https://www.w3.org/TR/FileAPI/ Bug: 945893 Change-Id: Ieb06be0e9023685a12eaa79bd77d69cb13fa5412 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529716 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by: Steve Kobes <skobes@chromium.org> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#652912} third_party/blink/renderer/core/fileapi/blob.cc | 93 +++++++++++++++ third_party/blink/renderer/core/fileapi/blob.h | 9 ++ third_party/blink/renderer/core/fileapi/blob.idl | 3 + .../platform/runtime_enabled_features.json5 | 6 + third_party/blink/web_tests/TestExpectations | 8 -- .../external/wpt/FileAPI/idlharness-expected.txt | 112 ------------------ .../wpt/FileAPI/idlharness.worker-expected.txt | 126 --------------------- ...l-interface-listing-service-worker-expected.txt | 3 + ...interface-listing-dedicated-worker-expected.txt | 3 + .../global-interface-listing-expected.txt | 3 + ...al-interface-listing-shared-worker-expected.txt | 3 + 11 files changed, 123 insertions(+), 246 deletions(-) commit 29e6b1f7506733930e4b83a93904184c0eab7dc1 Author: Ryan Hansberry <hansberry@chromium.org> Date: Mon Apr 22 19:36:51 2019 +0000 [Bluetooth] Present user-friendly string on unknownError while pairing. Bug: 954347 Change-Id: I36aa7aaef7f907d5529c50aaf618fd6c85f40636 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574486 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#652911} .../resources/cr_components/chromeos/bluetooth_dialog.js | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) commit e7316d0a9a9efae9db934830f84a366b27691591 Author: Bo Liu <boliu@chromium.org> Date: Mon Apr 22 19:36:47 2019 +0000 android: Frame token with presentation feedback Send frame token from viz display with the presentation feedback. This is more inline with chrome's architecture where viz display service sends this update. There are other code paths that used to deliver CompositorFrameMetadata and they have to call the new path for delivering frame tokens. Eventually should remove CompositorFrameMetadata code paths. SynchronousCompositorHost has to ensure tokens are delivered in order. Previously this worked with metadata version. Now that it's independent, need to explicitly make sure it's delivered in order. For now, only call DidProcessFrame. Eventually should move devtools to frame token and RenderFrameMetadata. Bug: 881469 Change-Id: Ie49e97255d45ba7a7267cce87b37c29fadb302a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576428 Reviewed-by: Eric Karl <ericrk@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#652910} android_webview/browser/gfx/browser_view_renderer.cc | 5 +++-- .../browser/gfx/browser_view_renderer_unittest.cc | 3 ++- android_webview/browser/gfx/compositor_frame_consumer.h | 3 ++- android_webview/browser/gfx/hardware_renderer.cc | 11 ++++++----- android_webview/browser/gfx/render_thread_manager.cc | 8 ++++++-- android_webview/browser/gfx/render_thread_manager.h | 7 +++++-- content/browser/android/synchronous_compositor_host.cc | 13 ++++++++++++- content/browser/android/synchronous_compositor_host.h | 8 ++++++-- .../renderer_host/render_widget_host_view_android.cc | 9 ++++++--- .../browser/renderer_host/render_widget_host_view_android.h | 1 + content/public/browser/android/synchronous_compositor.h | 3 ++- content/public/test/test_synchronous_compositor_android.h | 4 ++-- 12 files changed, 53 insertions(+), 22 deletions(-) commit 338a35517570eb34e6087e2eaf3ca7ddd63b5ed8 Author: ccameron <ccameron@chromium.org> Date: Mon Apr 22 19:30:35 2019 +0000 Revert "Skia/Metal raster: Add viz::MetalContextProvider" This reverts commit 45f012f356246f0bc8962cbbc5c3c16263bdab76. Reason for revert: Broke mac compile Original change's description: > Skia/Metal raster: Add viz::MetalContextProvider > > Add viz::MetalContextProvider, and add Metal to the Skia build by > default. Do not wire up any of this yet. > > Bug: 952063 > Change-Id: I897d052bdbf046114c1ddc0527c1d3cafc8777c5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577296 > Reviewed-by: Brian Osman <brianosman@google.com> > Reviewed-by: Eric Karl <ericrk@chromium.org> > Commit-Queue: ccameron <ccameron@chromium.org> > Cr-Commit-Position: refs/heads/master@{#652899} TBR=ccameron@chromium.org,brianosman@google.com,ericrk@chromium.org Change-Id: Ic0a4f5201df55ac7ef0b8a191b572a9bbeee6dc0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 952063 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577783 Reviewed-by: ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#652909} components/viz/common/BUILD.gn | 31 ----------- components/viz/common/gpu/metal_context_provider.h | 29 ---------- .../viz/common/gpu/metal_context_provider.mm | 65 ---------------------- .../viz/common/viz_metal_context_provider_export.h | 29 ---------- skia/BUILD.gn | 20 ++++--- 5 files changed, 12 insertions(+), 162 deletions(-) commit 37b18194fad4ad8bb39d9557363ec1c77daad7a8 Author: Eric Orth <ericorth@chromium.org> Date: Mon Apr 22 19:09:28 2019 +0000 Use per-context HostCache Per-context HostCaches are now used for all resolution cache lookups and cache stores. The old manager-wide cache is gone along with the manager-wide option to enable/disable caching. The ContextHostResolver now also registers/deregisters the caches with HostResolverManager on creation/destruction in order for them to receive invalidation notifications. Note that it appears all callers of HostCache browser data removal already go through appropriate NetworkContexts rather than making assumptions about the cache being global, so it all works out that such cache clearings will clear the relevant per-context caches when NetworkContext gets the cache to clear from its URLRequestContext and ContextHostResolver. Bug: 934402 Change-Id: Icc27f248b86f2140e1306f87008b23b5ff7ac6b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560372 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#652908} .../single_tree_tracker_unittest.cc | 4 +- net/dns/context_host_resolver.cc | 26 ++- net/dns/context_host_resolver_unittest.cc | 97 +++++++++++ net/dns/host_cache.cc | 17 +- net/dns/host_cache.h | 20 ++- net/dns/host_cache_unittest.cc | 6 +- net/dns/host_resolver.cc | 3 +- net/dns/host_resolver.h | 4 - net/dns/host_resolver_manager.cc | 130 ++++++++------- net/dns/host_resolver_manager.h | 47 ++++-- net/dns/host_resolver_manager_fuzzer.cc | 1 - net/dns/host_resolver_manager_unittest.cc | 185 +++++++++++++++++---- net/quic/quic_stream_factory_test.cc | 26 +-- services/network/network_context.cc | 7 +- 14 files changed, 433 insertions(+), 140 deletions(-) commit 096edb6c220e800dddbef27a8fe7e66652e8661a Author: Raymond Toy <rtoy@chromium.org> Date: Mon Apr 22 19:08:33 2019 +0000 Rename iirdsp_kernel.* to iir_dsp_kernel.* This makes it consistent with other files. No other changes were made. Bug: 954519 Change-Id: I2b737e6c639caba48ad8de974832119691adfbf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575726 Reviewed-by: Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#652907} third_party/blink/renderer/modules/webaudio/BUILD.gn | 4 ++-- .../modules/webaudio/{iirdsp_kernel.cc => iir_dsp_kernel.cc} | 2 +- .../renderer/modules/webaudio/{iirdsp_kernel.h => iir_dsp_kernel.h} | 6 +++--- third_party/blink/renderer/modules/webaudio/iir_processor.cc | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) commit 90631306e35bd9a14d2c5a9d834816f1407a4e2c Author: David Benjamin <davidben@chromium.org> Date: Mon Apr 22 19:03:53 2019 +0000 Only call ToString in fuzzer if IsSetConfig. ToString (which is a test-only method so it doesn't really matter) is only call if IsSetConfig, not !IsParseError Bug: 954766 Change-Id: I1e956cb374d5bf9899e16942f6c13868e29e6100 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577563 Commit-Queue: David Benjamin <davidben@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#652906} components/domain_reliability/header.cc | 1 + components/domain_reliability/header.h | 2 ++ components/domain_reliability/header_fuzzer.cc | 2 +- 3 files changed, 4 insertions(+), 1 deletion(-) commit 15b1d7523e67e7cbdb70a89cd22af753504749e4 Author: Tommy C. Li <tommycli@chromium.org> Date: Mon Apr 22 19:02:35 2019 +0000 WebUI: Fix Welcome Windows 10 Handler's navigation to the NTP Previously, the Windows 10 Handler navigated to the NTP by making the WebContents load the URL of the NTP. That's is mostly correct, except that it doesn't tell the Browser to update the omnibox. This CL makes the Windows 10 Welcome Handler act the same way as the normal Welcome Handler, which performs a navigation at the chrome/ with a Browser object instead of at the content/ level with a WebContents object. It used to work before accidentally, essentially. Bug: 954120 Change-Id: I5514044f32ae542de52c8aba8c08373de1e84b53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576138 Auto-Submit: Tommy Li <tommycli@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#652905} chrome/browser/ui/webui/welcome/welcome_win10_handler.cc | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) commit d0c35dd37968925cb9f6ed2e92805810930ded82 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Mon Apr 22 18:59:25 2019 +0000 Inline some NGPhysicalOffsetRect methods We want to use NGPhysicalOffsetRect in more places in legacy code, but don't want performance regressions caused by the additional function calls. Some performance measurement (e.g. crrev.com/c/1567095) showed that such small function calls can accumualte to quite big cost if they are called very frequently. Change-Id: I2bbe10669e1c7bbcfae2cf155536fab44136402e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577586 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#652904} .../core/layout/ng/geometry/ng_physical_offset_rect.cc | 16 ---------------- .../core/layout/ng/geometry/ng_physical_offset_rect.h | 17 +++++++++++------ 2 files changed, 11 insertions(+), 22 deletions(-) commit 4a634b732f8b01031b5135fd92d16f036e11ba9a Author: Avi Drissman <avi@chromium.org> Date: Mon Apr 22 18:53:13 2019 +0000 [Mac Updater] Update Mac relauncher. Gate waiting for the update on whether there are other Chrome instances; show a dialog if there are. BUG=948283 Change-Id: I3b1d87150fb6c8058453c68f2e459717124a2db3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566813 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#652903} chrome/app/chromium_strings.grd | 11 + ...ANCES_OTHER_USER_AUTHENTICATION_PROMPT.png.sha1 | 1 + ...HER_INSTANCES_SAME_USER_DIALOG_MESSAGE.png.sha1 | 1 + ...OTHER_INSTANCES_SAME_USER_DIALOG_TITLE.png.sha1 | 1 + chrome/app/google_chrome_strings.grd | 11 + ...ANCES_OTHER_USER_AUTHENTICATION_PROMPT.png.sha1 | 1 + ...HER_INSTANCES_SAME_USER_DIALOG_MESSAGE.png.sha1 | 1 + ...OTHER_INSTANCES_SAME_USER_DIALOG_TITLE.png.sha1 | 1 + chrome/browser/BUILD.gn | 2 +- chrome/browser/first_run/upgrade_util_mac.cc | 86 ------ chrome/browser/first_run/upgrade_util_mac.h | 5 + chrome/browser/first_run/upgrade_util_mac.mm | 302 +++++++++++++++++++++ .../ui/views/update_recommended_message_box.cc | 9 + .../ui/webui/settings/browser_lifetime_handler.cc | 10 + tools/metrics/histograms/enums.xml | 20 ++ tools/metrics/histograms/histograms.xml | 10 + 16 files changed, 385 insertions(+), 87 deletions(-) commit c98fcadd98aa26108157430dd12db82a1af3ecfe Author: Khushal <khushalsagar@chromium.org> Date: Mon Apr 22 18:47:29 2019 +0000 viz/media: Plumb preferred frame interval for media. Plumb the frame rate of video updates to the display compositor. This information is used to configure the display to tick at the video's frame rate if possible. R=liberato@chromium.org Bug: 938106 Change-Id: Ic720900181f58eddf65069c3a6d4cc480a98efb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556458 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by: Frank Liberato <liberato@chromium.org> Reviewed-by: Eric Karl <ericrk@chromium.org> Reviewed-by: Stephen Chenney <schenney@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#652902} cc/layers/video_frame_provider.h | 4 ++ cc/test/fake_video_frame_provider.cc | 6 +++ cc/test/fake_video_frame_provider.h | 1 + .../viz/common/quads/compositor_frame_metadata.h | 2 + .../frame_sinks/compositor_frame_sink_support.cc | 5 ++ .../service/frame_sinks/frame_sink_manager_impl.cc | 8 ++++ .../service/frame_sinks/frame_sink_manager_impl.h | 2 + .../compositor_impl_android_browsertest.cc | 56 +++++++++++++++++++--- .../media/stream/webmediaplayer_ms_compositor.cc | 5 ++ .../media/stream/webmediaplayer_ms_compositor.h | 1 + media/DEPS | 3 ++ media/base/BUILD.gn | 1 + media/base/null_video_sink_unittest.cc | 4 ++ media/base/video_renderer_sink.h | 4 ++ media/blink/BUILD.gn | 1 + media/blink/DEPS | 1 + media/blink/video_frame_compositor.cc | 10 ++++ media/blink/video_frame_compositor.h | 1 + media/blink/video_frame_compositor_unittest.cc | 16 +++++++ media/renderers/video_renderer_impl.cc | 5 ++ media/renderers/video_renderer_impl.h | 1 + media/renderers/video_renderer_impl_unittest.cc | 3 ++ .../compositor_frame_metadata_struct_traits.cc | 3 +- .../compositor_frame_metadata_struct_traits.h | 5 ++ .../compositing/compositor_frame_metadata.mojom | 6 +++ .../graphics/test/mock_compositor_frame_sink.h | 1 + .../platform/graphics/video_frame_submitter.cc | 4 ++ .../graphics/video_frame_submitter_test.cc | 36 ++++++++++++++ ui/android/window_android.cc | 19 ++++++++ ui/android/window_android.h | 9 ++++ 30 files changed, 215 insertions(+), 8 deletions(-) commit 6aef680e2c53e45cd9a98c8c00ef486261d42893 Author: Kyle Milka <kmilka@chromium.org> Date: Mon Apr 22 18:46:19 2019 +0000 [NTP] Update background customization availability logging On the local NTP we allow background customization even if a theme is installed. Remove the logging for unavailablity due to having a theme installed as it's no longer true. Bug: None Change-Id: Ib181fd959f5e321343789f692f18c1491b53ebbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575637 Reviewed-by: Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#652901} chrome/browser/ui/search/ntp_user_data_logger.cc | 11 ----- chrome/browser/ui/search/ntp_user_data_logger.h | 3 -- .../ui/search/ntp_user_data_logger_unittest.cc | 47 ---------------------- 3 files changed, 61 deletions(-) commit b6cee043a5f01db4946f3b1ec8afd3010b6daaa5 Author: Garrett Beaty <gbeaty@chromium.org> Date: Mon Apr 22 18:42:09 2019 +0000 Add recursive and quiet flags to mb lookup. Change-Id: Ica0e38196c37e00e2503b8674323b64ce6490554 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576022 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#652900} tools/mb/mb.py | 47 ++++++++++++++++++++++++++++++++--------------- tools/mb/mb_unittest.py | 26 +++++++++++++++++++++++++- 2 files changed, 57 insertions(+), 16 deletions(-) commit 45f012f356246f0bc8962cbbc5c3c16263bdab76 Author: Christopher Cameron <ccameron@chromium.org> Date: Mon Apr 22 18:34:37 2019 +0000 Skia/Metal raster: Add viz::MetalContextProvider Add viz::MetalContextProvider, and add Metal to the Skia build by default. Do not wire up any of this yet. Bug: 952063 Change-Id: I897d052bdbf046114c1ddc0527c1d3cafc8777c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577296 Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Eric Karl <ericrk@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#652899} components/viz/common/BUILD.gn | 31 +++++++++++ components/viz/common/gpu/metal_context_provider.h | 29 ++++++++++ .../viz/common/gpu/metal_context_provider.mm | 65 ++++++++++++++++++++++ .../viz/common/viz_metal_context_provider_export.h | 29 ++++++++++ skia/BUILD.gn | 20 +++---- 5 files changed, 162 insertions(+), 12 deletions(-) commit f8f28226a933112724f4f87d9076358314bae8b2 Author: Martin Robinson <mrobinson@igalia.com> Date: Mon Apr 22 18:34:07 2019 +0000 atk_text_set_caret_offset should scroll to the target node Orca expects that this API also scroll to the target node onto the screen. Eventually Orca will be able to use the AtkComponent scrolling API, but that isn't widely available yet, so we implement this fallback behavior. Bug: 950530 Change-Id: Id769d32849221591dfdb9ab6e96c07c8fb0e6b4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576561 Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by: Joanmarie Diggs <jdiggs@igalia.com> Cr-Commit-Position: refs/heads/master@{#652898} .../accessibility_auralinux_browsertest.cc | 21 ++++++++++++++++++++- .../platform/ax_platform_node_auralinux.cc | 8 +++++++- 2 files changed, 27 insertions(+), 2 deletions(-) commit 3a8f8d2d575ac47af3275f36e0da8d4070d2b621 Author: Sergey Ulanov <sergeyu@google.com> Date: Mon Apr 22 18:33:11 2019 +0000 Pass VkDevice to SurfaceFactoryOzone::CreateNativePixmap() CreateNativePixmap() will need to get VkDevice to be able to allocate buffers compatible with the target device. Bug: 852011 Change-Id: I7294fbd48d93c0614f78440b023f63a84b01bae9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570534 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Michael Spang <spang@chromium.org> Reviewed-by: Daniele Castagna <dcastagna@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#652897} .../video_accelerator/protected_buffer_manager.cc | 6 ++--- components/exo/display_unittest.cc | 4 ++-- components/viz/service/gl/gpu_service_impl.cc | 5 ++-- components/viz/service/gl/gpu_service_impl.h | 4 ++-- gpu/command_buffer/tests/gl_manager.cc | 2 +- gpu/ipc/client/raster_in_process_context_tests.cc | 3 ++- .../common/gpu_memory_buffer_impl_native_pixmap.cc | 6 +++-- gpu/ipc/service/DEPS | 1 + gpu/ipc/service/gpu_memory_buffer_factory.cc | 16 +++++++------ gpu/ipc/service/gpu_memory_buffer_factory.h | 7 +++++- .../gpu_memory_buffer_factory_native_pixmap.cc | 27 ++++++++++++++++------ .../gpu_memory_buffer_factory_native_pixmap.h | 9 ++++++++ media/gpu/linux/platform_video_frame_utils.cc | 5 ++-- .../gpu/vaapi/vaapi_picture_native_pixmap_ozone.cc | 6 ++--- ui/ozone/demo/skia/skia_surfaceless_gl_renderer.cc | 3 ++- ui/ozone/demo/surfaceless_gl_renderer.cc | 3 ++- .../gl/gl_image_ozone_native_pixmap_unittest.cc | 4 ++-- ui/ozone/platform/cast/surface_factory_cast.cc | 1 + ui/ozone/platform/cast/surface_factory_cast.h | 1 + ui/ozone/platform/drm/gpu/gbm_surface_factory.cc | 1 + ui/ozone/platform/drm/gpu/gbm_surface_factory.h | 1 + .../platform/headless/headless_surface_factory.cc | 1 + .../platform/headless/headless_surface_factory.h | 1 + ui/ozone/platform/scenic/scenic_surface_factory.cc | 1 + ui/ozone/platform/scenic/scenic_surface_factory.h | 1 + .../wayland/gpu/wayland_surface_factory.cc | 1 + .../platform/wayland/gpu/wayland_surface_factory.h | 1 + ui/ozone/public/surface_factory_ozone.cc | 1 + ui/ozone/public/surface_factory_ozone.h | 1 + 29 files changed, 86 insertions(+), 37 deletions(-) commit 30e95af7b79323e23d46713f7d70a1a81deb21e0 Author: Brandon Wylie <wylieb@chromium.org> Date: Mon Apr 22 18:32:59 2019 +0000 [Touchless] Give last tab button a width independent of contents Change the button from wrap_content to a width relative to the width of parent element. Bug: 936052 Change-Id: I63ff28b1329a221255f14113f9ae65dba2cee514 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575361 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#652896} chrome/android/touchless/java/res/layout/new_tab_page_touchless.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit fc57404b56a38a7c96cc2087f7caa2963d61ce36 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Apr 22 18:27:09 2019 +0000 Roll src/third_party/chromite fe8eb40a01ae..8c506a537d15 (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/fe8eb40a01ae..8c506a537d15 git log fe8eb40a01ae..8c506a537d15 --date=short --no-merges --format='%ad %ae %s' 2019-04-22 norvez@chromium.org chromeos_config: mark cyan as important again Created with: gclient setdep -r src/third_party/chromite@8c506a537d15 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: Ie57851f6209b058e393ebb622a0ab654bf1b7f8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576297 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652895} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit b2299f908a5ee707c86c0504932d62e9bd668092 Author: Bailey Berro <baileyberro@chromium.org> Date: Mon Apr 22 18:26:28 2019 +0000 Switch CupsPrintersManager::GetPrinter to returning an optional Previously, we were constructing and returning a unique_ptr solely for the purpose of being able to return a nullptr if a printer was not found. Instead, let's just return an optional which makes more sense for this. Change-Id: I14db20b6f7ffc8855ee48de2eda622fb78ec6b57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572263 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#652894} .../chromeos/arc/print/arc_print_service.cc | 25 ++++++------ .../chromeos/printing/cups_printers_manager.cc | 12 +++--- .../chromeos/printing/cups_printers_manager.h | 4 +- .../printing/cups_printers_manager_unittest.cc | 19 ++++----- .../local_printer_handler_chromeos.cc | 29 ++++++-------- .../print_preview/local_printer_handler_chromeos.h | 2 +- .../local_printer_handler_chromeos_unittest.cc | 8 ++-- .../settings/chromeos/cups_printers_handler.cc | 46 +++++++++++----------- .../settings/chromeos/cups_printers_handler.h | 5 +-- .../chromeos/cups_printers_handler_unittest.cc | 4 +- 10 files changed, 77 insertions(+), 77 deletions(-) commit 21699e36971304727ce89601ff9b669e57e63ecb Author: Dale Curtis <dalecurtis@chromium.org> Date: Mon Apr 22 18:24:23 2019 +0000 Improve values for dav1d tile threads and frame threads. Current AV1 content doesn't use many tiles, so we see much better performance by increasing the number of frame threads on systems that can handle the increase versus increasing tile threads. This patch sets the number of tile threads based on current encoding practices and the frame threads based on recommendations from dav1d: https://bugzilla.mozilla.org/show_bug.cgi?id=1536783 It distributes tiles threads and frame threads based on the number of available processors and other //media limits -- preferring to fulfill tile thread recommendations first since the dav1d folk indicate they are more efficient. If a system has the cores for it, we'll now use the following: <300p: 2 tile threads, 2 frame threads. <700p: 3 tile threads, 2 frame threads. <1000p: 5 tile threads, 4 frame threads >1000p: 8 tile threads, 8 frame threads. If we don't have the cores for it; i.e., on systems with <= 3 cores we'll now use less threads. Previously even if a system had <= 3 cores, we would still allocate >= 3 threads (up to 3 tile, and 2 frame). Now, for such systems, we will set frame_threads=1 (which generates no more threads, since the calling thread counts as a thread) and at most 1 more tile thread over the core count. E.g. a 3 core system will use a maximum of 3 tile threads and 1 frame thread. Single and dual core systems will use 2 tile threads and 1 frame thread. BUG=954659 TEST=https://www.youtube.com/watch?v=Fmdb-KmlzD8 plays smoothly; see 1m30s+ for most intense areas. R=chcunningham Change-Id: I82e5725a32a987a98567af9aeba495d248000105 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576158 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#652893} media/filters/dav1d_video_decoder.cc | 66 ++++++++++++++++++++++++++++++------ 1 file changed, 55 insertions(+), 11 deletions(-) commit 93b4ec1b7a9d0fa7685119aee69c1a38b21385c4 Author: khmel@chromium.org <khmel@chromium.org> Date: Mon Apr 22 18:24:19 2019 +0000 arc: Discard queueBuffer and dequeueBuffer from client tasks. Before tracing was not activated for client tasks due to problem of activating tracing in their processes. Now it is solved and we have extra events to analyze. queueBuffer and dequeueBuffer may have the same hierarchy as surface flinger events that cause false error reporting. This CL adds detection of surface flinger process id and consume events from it. TEST=Locally BUG=b:122555793 Change-Id: I048275c56d21de0c6bf19f07ab472972af8f0e82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574648 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#652892} .../arc/tracing/arc_tracing_graphics_model.cc | 98 +++++++++++++++++----- 1 file changed, 78 insertions(+), 20 deletions(-) commit d899fb69ba8bd676a5083cf551084ec2f2318349 Author: Robert Ogden <robertogden@chromium.org> Date: Mon Apr 22 18:23:15 2019 +0000 Enable Lite Mode rebranding by default Bug: 909915 Change-Id: Ic64749cede88ed4ccfa0a28163fddde9f7f33e82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577489 Reviewed-by: Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#652891} components/previews/core/previews_features.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit cb03acb8680d0f546b33f568cfe060b7fd0b859a Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Mon Apr 22 18:23:12 2019 +0000 Roll src-internal 65dffa4595e2..109321d1bdd1 (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/65dffa4595e2..109321d1bdd1 Created with: gclient setdep -r src-internal@109321d1bdd1 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=chcunningham@chromium.org,loyso@chromium.org,clamy@chromium.org,flackr@chromium.org Change-Id: Ic3aa61e57d7ffe3002ed959621b9c9a926d7b640 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577560 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652890} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 06636de547ae825faa9d0ae4ccdfeeac6cb7dd8d Author: Matt Simmons <mattsimmons@chromium.org> Date: Mon Apr 22 18:21:18 2019 +0000 Track tab clobbering for tracking tab engagement. This change introduces a new metric Tabs.TimeSinceLastView.onTabClobber. This is emitted when a user focuses the omnibox and then subsequently navigates within a certain amount of time after returning to a tab. This and Tabs.TimeSinceLastView.onTabView are mutually exclusive (per-engagement). Bug: 947572 Change-Id: I61a6fff00197134ca806adf6f94bb8bcfef7416b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551942 Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Matt Simmons <mattsimmons@chromium.org> Cr-Commit-Position: refs/heads/master@{#652889} chrome/android/chrome_junit_test_java_sources.gni | 1 + .../chromium/chrome/browser/ChromeActivity.java | 8 - .../chrome/browser/ChromeTabbedActivity.java | 8 + .../chrome/browser/tasks/EngagementTimeUtil.java | 58 ++++++- .../chrome/browser/tasks/JourneyManager.java | 130 +++++++++++++-- .../browser/tasks/EngagementTimeUtilTest.java | 50 ++++++ .../chrome/browser/tasks/JourneyManagerTest.java | 180 ++++++++++++++++++++- tools/metrics/histograms/histograms.xml | 12 ++ 8 files changed, 423 insertions(+), 24 deletions(-) commit ca4bb5ee9b7e1537e627e672afae79c9913f8678 Author: Marijn Kruisselbrink <mek@chromium.org> Date: Mon Apr 22 18:19:42 2019 +0000 [Native File System] Be more consistent with feature flag naming. Use three-words "Native File System" everywhere. Also change RuntimeEnabledFeature status from "experimental" to no status, since it should currently only be changed by the base::Feature being enabled. Bug: 853326, 929490 Change-Id: Ifaead92ed2e236dda9661e3f58d02fff017e51f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572251 Auto-Submit: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#652888} chrome/browser/about_flags.cc | 6 +++--- chrome/browser/flag-metadata.json | 2 +- chrome/browser/flag_descriptions.cc | 8 ++++---- chrome/browser/flag_descriptions.h | 4 ++-- content/browser/fileapi/file_system_chooser_browsertest.cc | 2 +- content/browser/fileapi/file_system_manager_impl.cc | 4 ++-- content/child/runtime_features.cc | 4 ++-- third_party/blink/common/features.cc | 4 ++-- third_party/blink/public/common/features.h | 2 +- .../renderer/modules/filesystem/dom_window_file_system.cc | 2 +- third_party/blink/renderer/modules/filesystem/entry.idl | 2 +- .../modules/filesystem/file_system_base_handle.idl | 2 +- .../modules/filesystem/file_system_directory_handle.idl | 2 +- .../modules/filesystem/file_system_directory_iterator.idl | 2 +- .../modules/filesystem/file_system_file_handle.idl | 2 +- .../renderer/modules/filesystem/file_system_writer.idl | 2 +- .../renderer/modules/filesystem/window_file_system.idl | 2 +- .../blink/renderer/platform/runtime_enabled_features.json5 | 8 ++++---- third_party/blink/web_tests/VirtualTestSuites | 2 +- .../webexposed/global-interface-listing-expected.txt | 14 -------------- tools/metrics/histograms/enums.xml | 2 ++ 21 files changed, 33 insertions(+), 45 deletions(-) commit 2db8c540b4e529d1c521b41cadf6b9f1c1390c74 Author: Chris Cunningham <chcunningham@chromium.org> Date: Mon Apr 22 18:15:22 2019 +0000 Mark breakpoints-ui-in-multiple-workers.js test as flaky NOTRY=true Bug: 954319 Change-Id: Id8eeeb53df0dc8747b9f4f96ae9a6f5891eef8d1 TBR: alph@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576173 Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#652887} third_party/blink/web_tests/TestExpectations | 1 + 1 file changed, 1 insertion(+) commit 524fb16967422e34ea7cb1c715cc3de14b433a66 Author: Peter Kasting <pkasting@chromium.org> Date: Mon Apr 22 18:08:31 2019 +0000 Fix flaky test failure due to Layout() call during TearDown(). This also rewrites the test for style reasons while I'm touching it. Bug: 953836 Change-Id: I2cf956f9fae60a9fc9ef83748e977279a459a2ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572110 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#652886} .../ui/views/bookmarks/bookmark_bar_view_test.cc | 70 +++++++++++----------- 1 file changed, 36 insertions(+), 34 deletions(-) commit f504747a0a2bbb72d80657f2b641ceda775d1b8d Author: John Abd-El-Malek <jam@chromium.org> Date: Mon Apr 22 18:07:36 2019 +0000 Reland "Reland "Move loading of data URLs out of the network process."" This is a reland of 4dd1f3cedfa5022f5fa9d076c2a0b75165987b3b. Disabled test in msan as well. Original change's description: > Reland "Move loading of data URLs out of the network process." > > This is a reland of f45ff75d1ee932e8695a34269c264f93b77439e2 > > Original change's description: > > Move loading of data URLs out of the network process. > > > > For subresources the renderer was already loading it in-process. Now for navigations and downloads, we keep them in the browser process. This avoids: > > 1) sending GURLs bigger than 2MB to a different process, which strips them as they're bigger than url::kMaxURLChars > > 2) having the network process deal with a scheme that's not going over the network, which we avoid > > > > Bug: 937146, 939871 > > Change-Id: I8ca8225308b2a5f1f90594ab06943f0641a5c551 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570805 > > Commit-Queue: John Abd-El-Malek <jam@chromium.org> > > Reviewed-by: Ken Rockot <rockot@google.com> > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > Reviewed-by: David Trainor <dtrainor@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#652196} > > Bug: 937146, 939871 > Change-Id: I480da494a987c9b223c1a571821b35e3bdbc7447 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574881 > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#652335} TBR=bsep@chromium.org Bug: 937146, 939871 Change-Id: I7088f802cb5fef81021c488aa6426d1a87604e99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577483 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#652885} chrome/browser/download/download_browsertest.cc | 64 +++++++++++++ .../network_context_configuration_browsertest.cc | 23 ----- chrome/test/data/downloads/large_image.png | Bin 0 -> 2096938 bytes content/browser/BUILD.gn | 2 + content/browser/data_url_loader_factory.cc | 104 +++++++++++++++++++++ content/browser/data_url_loader_factory.h | 47 ++++++++++ content/browser/download/download_manager_impl.cc | 35 ++++--- content/browser/download/save_file_manager.cc | 18 +++- .../browser/frame_host/render_frame_host_impl.cc | 4 + .../browser/loader/navigation_url_loader_impl.cc | 4 + .../service_worker/embedded_worker_instance.cc | 3 + .../worker_host/worker_script_fetch_initiator.cc | 3 + content/public/common/url_utils.cc | 3 +- services/network/network_context.cc | 9 +- services/network/network_context_unittest.cc | 7 +- .../public/cpp/simple_url_loader_unittest.cc | 23 +---- 16 files changed, 280 insertions(+), 69 deletions(-) commit e6fd9fbe3f07b9afdb601626f1badfd254090caf Author: Nate Chapin <japhet@chromium.org> Date: Mon Apr 22 18:06:02 2019 +0000 Update tests in preparation for making location API navigations start synchronously A bunch of tests need to be updated for a behavior change in https://chromium-review.googlesource.com/c/chromium/src/+/1526426 These are the ones where the updated test passes before and after the behavior change. Bug: 914587 Change-Id: Ic8b34c4c205ea2f9bf59b620ca6baac47cd7b1ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576025 Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#652884} chrome/browser/extensions/process_manager_browsertest.cc | 12 ++++++++---- chrome/test/data/banners/main.js | 2 +- chrome/test/data/window.close.html | 2 +- .../browser/frame_host/render_frame_host_impl_browsertest.cc | 10 +++++++--- content/browser/security_exploit_browsertest.cc | 4 +++- .../protocol/sanity/renderer-double-redirect-expected.txt | 2 -- .../test/data/protocol/sanity/renderer-double-redirect.js | 6 ++++++ .../blink/web_tests/fast/events/before-unload-crash.html | 11 +++-------- .../web_tests/fast/events/onbeforeunload-focused-iframe.html | 4 +++- .../loader/resources/javascript-detached-frame-iframe.html | 4 +++- .../tests/security/xss-DENIED-javascript-variations.html | 6 +++--- 11 files changed, 38 insertions(+), 25 deletions(-) commit 747ce67ea16541cbbfaed3069f21ab8a4372a4e7 Author: David Black <dmblack@google.com> Date: Mon Apr 22 18:03:25 2019 +0000 Fixed issue which caused AssistantOptInView to be painted wrong. I was unable to repro the bug consistently with an unaltered build. I was able to repro the bug, however, with some local changes in which I posted the UpdateLabel calls to simulate a timing issue. With this change, I was able to reproduce the bug consistently. Bug: b:130758812 Change-Id: I063527e9c52f5584104ce556d3558fc4ed62e228 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577494 Reviewed-by: Tao Wu <wutao@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#652883} ash/assistant/ui/main_stage/assistant_opt_in_view.cc | 6 ++++++ 1 file changed, 6 insertions(+) commit 5dc4e14007b946507aefa826b0ffe38e8a70883f Author: Martin Robinson <mrobinson@igalia.com> Date: Mon Apr 22 18:01:36 2019 +0000 Add support for AtkComponent scrolling APIs Bug: 932708 Change-Id: Ib793df737907234c4ffe7f7d7f591086711d9f81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574721 Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#652882} .../accessibility_auralinux_browsertest.cc | 174 ++++++++++++++++++++- .../accessibility/accessibility_browsertest.cc | 19 +++ .../accessibility/accessibility_browsertest.h | 2 + .../accessibility/accessibility_win_browsertest.cc | 15 +- .../platform/ax_platform_node_auralinux.cc | 145 ++++++++++++++--- .../platform/ax_platform_node_auralinux.h | 7 +- .../ax_platform_node_auralinux_unittest.cc | 127 ++++++++++++++- ui/accessibility/platform/ax_platform_node_base.cc | 36 +++++ ui/accessibility/platform/ax_platform_node_base.h | 11 ++ ui/accessibility/platform/ax_platform_node_win.cc | 27 ++-- 10 files changed, 498 insertions(+), 65 deletions(-) commit 05fde3b74051918fba26f4775eab90d6b2f024e5 Author: Jun Mukai <mukai@chromium.org> Date: Mon Apr 22 17:58:09 2019 +0000 Change the timing of the SetTargetState on closing animation The animation is already ongoing when the closing is scheduled, Chrome is going to crash without SetTargetState() regardless of the side-shelf state. Bug: 954907, 951853 Test: manually Change-Id: Ic5e67e152341cb96829fd2d1e9e768485f8b2eff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577482 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#652881} ash/app_list/views/app_list_view.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit e509581144a4030318d619156f1ae35e49ed0c86 Author: Dana Fried <dfried@chromium.org> Date: Mon Apr 22 17:57:41 2019 +0000 Bookmarks differentiate between context menus in different places. This fixes an issue where a context menu opened from the app menu would trigger UMA logging events for the bookmarks bar. Bug: 951907 Change-Id: I4521b6b7101e2c662f347f479130201482617d6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574682 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#652880} .../bookmarks/bookmark_context_menu_controller.cc | 62 +++++++++++++++++++-- .../bookmarks/bookmark_context_menu_controller.h | 3 + .../bookmark_context_menu_controller_unittest.cc | 64 +++++++++++++--------- .../ui/views/bookmarks/bookmark_bar_view.cc | 4 +- .../ui/views/bookmarks/bookmark_context_menu.cc | 2 + .../ui/views/bookmarks/bookmark_context_menu.h | 2 + .../bookmarks/bookmark_context_menu_unittest.cc | 50 ++++++++++------- .../ui/views/bookmarks/bookmark_menu_delegate.cc | 7 ++- 8 files changed, 136 insertions(+), 58 deletions(-) commit 1e1e54849a38492e0f853ab794e16c119ec5fe10 Author: Wei Li <weili@chromium.org> Date: Mon Apr 22 17:57:05 2019 +0000 Fix status bubble text low contrast with some themes Status bubble text was drawn with certain transparency. When it was changed to be drawn on a label, the color would be automatically computed based on foreground and background colors, which makes the text color even lighter with some themes. We fix that by disable auto color readability on that label. BUG=952061 Change-Id: I25ec54aa82c4d62e7fa67f146f0e7c9e39511eac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565504 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#652879} chrome/browser/ui/views/frame/browser_view.cc | 3 +++ chrome/browser/ui/views/status_bubble_views.cc | 36 +++++++++++++++++++------- chrome/browser/ui/views/status_bubble_views.h | 3 +++ 3 files changed, 33 insertions(+), 9 deletions(-) commit 4a43698a1a4ea607f8610ebe2b18fe4e92293fcd Author: Sébastien Séguin-Gagnon <sebsg@chromium.org> Date: Mon Apr 22 17:53:42 2019 +0000 [SendTabToSelf] Record histogram for iOS infobar. Record when the infobar is shown, opened and dismissed. Bug: 942747 Change-Id: I76b8dbfc3538d7095eb2a9f0d4e96706954c0493 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574833 Auto-Submit: sebsg <sebsg@chromium.org> Reviewed-by: Peter Lee <pkl@chromium.org> Commit-Queue: sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#652878} .../ios_send_tab_to_self_infobar_delegate.cc | 12 ++++-------- .../send_tab_to_self/ios_send_tab_to_self_infobar_delegate.h | 1 - 2 files changed, 4 insertions(+), 9 deletions(-) commit 57027b6a5ae1006a8da593f729c53e97bf852f6e Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Apr 22 17:48:48 2019 +0000 Roll src/third_party/catapult 76c5c490d194..4b68d1e3e421 (1 commits) https://chromium.googlesource.com/catapult.git/+log/76c5c490d194..4b68d1e3e421 git log 76c5c490d194..4b68d1e3e421 --date=short --no-merges --format='%ad %ae %s' 2019-04-22 crouleau@chromium.org Speculatively reduce parallelism in metrics calculations to prevent d8 error. Created with: gclient setdep -r src/third_party/catapult@4b68d1e3e421 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:953365 TBR=charliea@chromium.org Change-Id: Id0e080bd242a0b35657db6b10230642d5d13218d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576292 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652877} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 9e42b0cc997a5246b7d01926c26fb70398693c51 Author: Nasko Oskov <nasko@chromium.org> Date: Mon Apr 22 17:46:28 2019 +0000 Use NavigationRequest parameter instead of member in debug data. Recent refactoring (r649193) added the NavigationRequest as parameter to ValidateDidCommitParams, but instrumentation landed in r652724 is using the member variable of RenderFrameHostImpl. This CL changes the debug instrumentation to use the passed in parameter, which should be available for most navigations. Bug: 931895 Change-Id: Ic8339dd81948af83fac822d6ab6d95cea01e1838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577581 Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#652876} content/browser/frame_host/render_frame_host_impl.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit b7b3ae04afbedcab8a742f7dc245890b7d5ab6c8 Author: Emil A Eklund <eae@chromium.org> Date: Mon Apr 22 17:44:20 2019 +0000 Defer text ink bounds computation until needed Defer computation of ink bounds until needed instead of pre-computing it during shaping. This does not yet change how the bounds are accumulated. In legacy layout the bounds are computed and cached by CachingWordShaper immediately after shaping, minimizing changes to the API or performance. In LayoutNG bounds are no longer computed during the PrepareLayout step, where initial paragraph shaping occurs, nor during the subsequent layout step, where line breaking and fragment construction takes place. Instead bounds are only computed when NGPhysicalTextFragment::SelfInkOverflow is called, typically during painting. This avoids unnecessary and repetitive bounds computation, lowers memory consumption, and simplifies the implementation. Resulting in significant performance improvements. Specifically for forced and off-screen layout. This improves performance significantly for LayoutNG, most of the layout benchmarks in the blink_perf.layout suite improve by between 5% and 20%. chapter-reflow-once 20% long-line-nowrap 18% fit-content-change-available-size-text 11% hindi-line-layout 10% change-text-css-contain 10% latin-ebook-resize 10% Furthermore it significantly improves the more realistic loading.desktop numbers which measure time to fully render a number of real world sites. timeToFirstContentfulPaint:layout 10% timeToInteractive 7% timeToFirstMeaningfulPaint 3% cpuTimeToFirstMeaningfulPaint 3% Bug: 636993 Change-Id: Ib1dbdf4483137039ddba37e4a48c816369425788 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572875 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#652875} .../core/css/threaded/font_object_threaded_test.cc | 9 +- .../layout/ng/inline/ng_physical_text_fragment.cc | 21 +- .../layout/ng/inline/ng_physical_text_fragment.h | 11 +- .../renderer/core/layout/ng/ng_physical_fragment.h | 1 + third_party/blink/renderer/platform/fonts/font.cc | 16 ++ third_party/blink/renderer/platform/fonts/font.h | 6 + .../fonts/shaping/caching_word_shape_iterator.cc | 57 ++++- .../fonts/shaping/caching_word_shape_iterator.h | 45 ++-- .../platform/fonts/shaping/caching_word_shaper.cc | 10 +- .../fonts/shaping/caching_word_shaper_test.cc | 116 ++++++----- .../platform/fonts/shaping/harfbuzz_shaper_test.cc | 97 +-------- .../renderer/platform/fonts/shaping/shape_cache.h | 1 + .../platform/fonts/shaping/shape_result.cc | 231 +++++---------------- .../renderer/platform/fonts/shaping/shape_result.h | 18 +- .../platform/fonts/shaping/shape_result_buffer.cc | 14 +- .../platform/fonts/shaping/shape_result_buffer.h | 7 +- .../fonts/shaping/shape_result_inline_headers.h | 34 --- .../platform/fonts/shaping/shape_result_view.cc | 125 +++++------ .../platform/fonts/shaping/shape_result_view.h | 13 +- .../fonts/shaping/shape_result_view_test.cc | 23 -- .../line-flow-with-floats-1-expected.txt | 38 ++-- .../line-flow-with-floats-10-expected.txt | 98 ++++----- .../line-flow-with-floats-2-expected.txt | 140 ++++++------- .../line-flow-with-floats-3-expected.txt | 74 +++---- .../line-flow-with-floats-4-expected.txt | 76 +++---- .../line-flow-with-floats-5-expected.txt | 82 ++++---- .../line-flow-with-floats-6-expected.txt | 82 ++++---- .../line-flow-with-floats-7-expected.txt | 82 ++++---- .../line-flow-with-floats-8-expected.txt | 78 +++---- .../line-flow-with-floats-9-expected.txt | 108 +++++----- 30 files changed, 777 insertions(+), 936 deletions(-) commit 6fedaa9b5854eee81e8b6832a3a5f0c5b89fd8a9 Author: Chris Cunningham <chcunningham@chromium.org> Date: Mon Apr 22 17:42:11 2019 +0000 Mark jpeg-yuv-image-decoding.html as flaky NOTRY=true Bug: 954994 Change-Id: I5a91e3fd45cb886990ab103911117285a7f6a813 TBR: mbarowsky@chromium.org, wangxianzhu@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577496 Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#652874} third_party/blink/web_tests/TestExpectations | 5 +++++ 1 file changed, 5 insertions(+) commit e95876d67a02f0c7b990d29c944138751178f397 Author: Siye Liu <siliu@microsoft.com> Date: Mon Apr 22 17:41:42 2019 +0000 Use ITfContextOwnerCompositionServices to terminate composition This change aims to demonstrate how we can re-implement the following methods in a sane way. * TSFTextStore::CancelComposition() * TSFTextStore::ConfirmComposition() In our initial implementation [1], those two methods were implemented in a really hacky way. It was implemented by simulating a text change event during a composition with an assumption that the current IME will terminate the composition when it receives |OnTextChange|. |ITfContextOwnerCompositionServices::TerminateComposition| should have been used instead in this scenario. [1]: e7888801425819ea95d23ae1ace812ed0e4b1715 Bug: 948783 Change-Id: Ibfb270d9f8dc2459ca73824c7405f10111e12ad1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572240 Commit-Queue: Siye Liu <siliu@microsoft.com> Reviewed-by: Yohei Yukawa <yukawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#652873} ui/base/ime/win/tsf_bridge.cc | 2 + ui/base/ime/win/tsf_text_store.cc | 82 +++++++++++++++------------------------ ui/base/ime/win/tsf_text_store.h | 8 ++++ 3 files changed, 41 insertions(+), 51 deletions(-) commit e2fa7198ebd81358a2b682c56a7a7d4665ad0b56 Author: Tatiana Buldina <buldina@chromium.org> Date: Mon Apr 22 17:38:10 2019 +0000 [ChromeDriver] Update atoms.cc to latest code Change-Id: I35cddbfae13842633ff611e2f85966ac12e8b6cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572208 Reviewed-by: John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#652872} third_party/webdriver/README.chromium | 2 +- third_party/webdriver/atoms.cc | 16314 ++++++++++++++++---------------- 2 files changed, 8164 insertions(+), 8152 deletions(-) commit a6dd3db735f0edc0b01a4d878a74673dcc67440e Author: Khushal <khushalsagar@chromium.org> Date: Mon Apr 22 17:38:04 2019 +0000 ui/gl: Add more usage bits required for buffers used with SurfaceControl Qualcomm needs a usage bit to be set on AHardwareBuffers used with HWC for direct scanout. Currently its set internally in the framework but since Chrome allocates its own buffers with SurfaceControl, it needs to be added by Chrome. R=piman@chromium.org Bug: 889328 Change-Id: Ie5596a1bfcd9916d9676ac29c1f6c0ae2555cef6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576000 Commit-Queue: Antoine Labour <piman@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#652871} .../shared_image_backing_factory_ahardwarebuffer.cc | 3 +++ gpu/ipc/service/gpu_init.cc | 16 ++++++++-------- ui/gl/android/android_surface_control_compat.cc | 9 ++++++++- ui/gl/android/android_surface_control_compat.h | 4 ++++ 4 files changed, 23 insertions(+), 9 deletions(-) commit d439db5830e1a329a42134d331ccdc7b0a7bb974 Author: Tommy C. Li <tommycli@chromium.org> Date: Mon Apr 22 17:30:37 2019 +0000 Omnibox: Suggestion Transparency - Provide explanation for matches. This CL surfaces the "Why this suggestion" text in the bubble for removing suggestions. Suggestions that can be removed now have a "More Info / Remove..." context menu entry. Suggestions that cannot be removed have a "More info..." context menu entry. Both bring up a bubble. This won't be the final UX treatment, but gets the capability in there for further refinement. Bug: 929477 Change-Id: I2dc9a5fea920653ead8ff9efea41fb77f91ff919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575872 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#652870} .../ui/views/omnibox/omnibox_result_view.cc | 11 ++++++-- .../browser/ui/views/omnibox/omnibox_result_view.h | 3 ++- .../ui/views/omnibox/remove_suggestion_bubble.cc | 30 +++++++++++++++++++--- 3 files changed, 38 insertions(+), 6 deletions(-) commit b4ee7db0a927332c9836e2a7f3856479e331d4d6 Author: Ovidio Henriquez <odejesush@chromium.org> Date: Mon Apr 22 17:30:08 2019 +0000 Clang Format site_settings_handler.cc and test This change formats the site_settings_handler.cc and site_settings_handler_unittest.cc files. Change-Id: Ia678d766341022b3f5fd3e06b8f2b3788d4f733b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575825 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#652869} .../ui/webui/settings/site_settings_handler.cc | 52 ++++++++++------------ .../settings/site_settings_handler_unittest.cc | 15 ++++--- 2 files changed, 32 insertions(+), 35 deletions(-) commit 545e4cfa6437631e03ef0800b02893a2095cad73 Author: David Benjamin <davidben@chromium.org> Date: Mon Apr 22 17:19:19 2019 +0000 Fix invalid StringPiece to string conversion. Found by the newly-added fuzzer. Fortunately this is not a problem for any existing callers, which only ever passed a StringPiece derived from a full std::string (which promises to be NUL-terminated). Bug: 954703, 954760 Change-Id: I274de66b785d9f272a25264980e21878c5a77872 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577580 Reviewed-by: Matt Mueller <mattm@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#652868} components/domain_reliability/header.cc | 6 ++++-- components/domain_reliability/header_unittest.cc | 12 ++++++++++-- 2 files changed, 14 insertions(+), 4 deletions(-) commit b114a6899e225a28701622ae86691b22ec5d2480 Author: Evan Stade <estade@chromium.org> Date: Mon Apr 22 17:16:14 2019 +0000 Fix flakiness in CrasAudioClientTest Bug: none Change-Id: If821edbfc5ea2f222c0a885cbe14d8a48c789d0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575868 Auto-Submit: Evan Stade <estade@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#652867} chromeos/dbus/audio/cras_audio_client_unittest.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) commit b8679aa6fc4c12b8bd38636f0a865552814ffefe Author: Bence Béky <bnc@chromium.org> Date: Mon Apr 22 17:15:01 2019 +0000 Remove excess spaces and reformat comment in spdy_session_pool.h. This is a follow-up to https://crrev.com/c/1570914. Bug: 912727 Change-Id: I284dbb580bb396da787c7d2f5755428458f88aeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577479 Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#652866} net/spdy/spdy_session_pool.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) commit 29c754596124486628e12031747b956186e2e81b Author: Tommy C. Li <tommycli@chromium.org> Date: Mon Apr 22 17:10:34 2019 +0000 Omnibox: Suggestion Transparency - Add 'Why this Suggestion' text. This extends AutocompleteMatch with explanatory text as to where this suggestion came from. This is currently purely based on the AutocompleteMatchType. These are placeholder strings meant for development only. Bug: 929477 Change-Id: Ia8bb271b6f7ad4b2848011bec98d16d4f64f64de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574886 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#652865} components/omnibox/browser/autocomplete_match.cc | 87 ++++++++++++++++++++++++ components/omnibox/browser/autocomplete_match.h | 4 ++ 2 files changed, 91 insertions(+) commit 41f48f32351e1ffcc281595d8cb028d82013766b Author: li <llin@chromium.org> Date: Mon Apr 22 17:10:17 2019 +0000 Add timer deeplinks for stop timer and add time to timer. Currently, we are sending text query for the timer notification actions. Improve it by adding timer deeplinks that trigger AlarmTimerManager APIs. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome Bug: b:119116816 Test: Manual Change-Id: Ife633a5978f9d0af1a5bef8a70782a7f7d364fa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531606 Commit-Queue: Li Lin <llin@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#652864} ash/assistant/assistant_alarm_timer_controller.cc | 99 ++++++++++++++- ash/assistant/assistant_alarm_timer_controller.h | 24 ++++ ash/assistant/assistant_controller.cc | 2 + ash/assistant/test/test_assistant_service.h | 3 + ash/assistant/util/deep_link_util.cc | 89 ++++++++++++++ ash/assistant/util/deep_link_util.h | 38 ++++++ ash/assistant/util/deep_link_util_unittest.cc | 135 ++++++++++++++++++++- .../assistant/assistant_manager_service_impl.cc | 15 +++ .../assistant/assistant_manager_service_impl.h | 2 + .../fake_assistant_manager_service_impl.cc | 3 + .../fake_assistant_manager_service_impl.h | 3 + chromeos/services/assistant/public/features.h | 1 - .../assistant/public/mojom/assistant.mojom | 7 ++ .../assistant/test_support/mock_assistant.h | 3 + 14 files changed, 417 insertions(+), 7 deletions(-) commit e0d3ac9fd01ab30fbd1ae5949ea4e802672eb6f2 Author: Lily Chen <chlily@chromium.org> Date: Mon Apr 22 16:55:53 2019 +0000 Add flag to chrome://flags to enable "SameSite by default cookies" This flag will enable net::features::kSameSiteByDefaultCookies, which will make cookies set without a valid SameSite attribute default to being treated as SameSite=Lax. When the feature is enabled, SameSite=None is required to get the previous default behavior of not having any same-site restrictions. Bug: 953306 Change-Id: Iaa7983e6568cdadf18752e89539c3e411325694e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574835 Reviewed-by: Maks Orlovich <morlovich@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#652863} chrome/browser/about_flags.cc | 5 +++++ chrome/browser/flag-metadata.json | 5 +++++ chrome/browser/flag_descriptions.cc | 6 ++++++ chrome/browser/flag_descriptions.h | 3 +++ tools/metrics/histograms/enums.xml | 2 ++ 5 files changed, 21 insertions(+) commit 7a91dd449f438c648a7de9669dd64db54b10040f Author: Matt Menke <mmenke@chromium.org> Date: Mon Apr 22 16:50:41 2019 +0000 SpdySessionRequest: Update docs. The class docs mention a number of methods that I have since removed. Bug: 912727 Change-Id: Ic3ac8c28167b09c8d9acf3b336b58385e17a9ff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575725 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#652862} net/spdy/spdy_session_pool.h | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) commit 41f3abefec85deaa66f8e65c31d9ffcdce7e4839 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Apr 22 16:45:34 2019 +0000 Roll src/third_party/skia cbc33b8e3574..7a5b6ec0f6c0 (2 commits) https://skia.googlesource.com/skia.git/+log/cbc33b8e3574..7a5b6ec0f6c0 git log cbc33b8e3574..7a5b6ec0f6c0 --date=short --no-merges --format='%ad %ae %s' 2019-04-22 egdaniel@google.com Update comment on vulkan allocator. 2019-04-22 egdaniel@google.com Add back deprecated GrCotnext flush API till clients get fixed. Created with: gclient setdep -r src/third_party/skia@7a5b6ec0f6c0 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@chromium.org Change-Id: Ifb87e61e0db201b05a73af059b645d9af4280a80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577565 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652861} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit a19868d4b9872d087c2f63494ee667a2e6ca4876 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Apr 22 16:42:56 2019 +0000 Roll src/third_party/chromite f66107f9aa31..fe8eb40a01ae (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/f66107f9aa31..fe8eb40a01ae git log f66107f9aa31..fe8eb40a01ae --date=short --no-merges --format='%ad %ae %s' 2019-04-22 dburger@chromium.org In config skew test switch to using proto buffer. Created with: gclient setdep -r src/third_party/chromite@fe8eb40a01ae The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I24bcc965c0f3f4208fb3a390ec7c772c8ba17dbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577564 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652860} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit aff3c8feca3a0d8787c60b590c997a3c076fcd67 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Mon Apr 22 16:38:44 2019 +0000 Add tests for crbug.com/363609 and crbug.com/954591 Bug: 363609, 954591 Change-Id: I522eaf916c9b2d7dbb3ba95a904e9b272d920902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577058 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#652859} third_party/blink/web_tests/TestExpectations | 4 ++++ ...ited-under-rotateY-180deg-clip-perspective.html | 2 +- .../composited-under-rotateY-180deg-clip-ref.html | 2 ++ .../composited-under-rotateY-180deg-clip.html | 12 ++++++++++++ .../composited-under-rotateY-180deg-ref.html | 2 ++ .../composited-under-rotateY-180deg.html | 12 ++++++++++++ .../rotateY-180deg-with-overflow-scroll-ref.html | 17 +++++++++++++++++ .../rotateY-180deg-with-overflow-scroll.html | 22 ++++++++++++++++++++++ 8 files changed, 72 insertions(+), 1 deletion(-) commit 0c424110c6ccfc15a0d48992777cf5ce228a0d0a Author: Robert Ogden <robertogden@chromium.org> Date: Mon Apr 22 16:37:14 2019 +0000 Get the DRP session_key when it is unavailable from the request headers The DRP session key may not be available from the request headers. If it isn't, get it from the UI thread instead. Bug: 952523 Change-Id: I82befab8a97b5c463db37b0d5e82edc640d9af18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576154 Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#652858} chrome/browser/previews/previews_content_util.cc | 19 +++++++++++++++---- .../previews/previews_lite_page_browsertest.cc | 5 ----- 2 files changed, 15 insertions(+), 9 deletions(-) commit d721da6c96e80e631612453e40cec13b7e6da8bb Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Apr 22 16:35:44 2019 +0000 Roll src/third_party/swiftshader bcc71a322953..4f15ce2eb993 (1 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/bcc71a322953..4f15ce2eb993 git log bcc71a322953..4f15ce2eb993 --date=short --no-merges --format='%ad %ae %s' 2019-04-22 swiftshader.regress@gmail.com Regres: Update test lists @ bcc71a32 Created with: gclient setdep -r src/third_party/swiftshader@4f15ce2eb993 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: I13750bafa8ef672260477937fd3dd6ecc5db18cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577562 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652857} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit ed8a203d2b2b3247e0786006a1da020d3a23ee9b Author: James Cook <jamescook@chromium.org> Date: Mon Apr 22 16:10:28 2019 +0000 CrOS SplitSettings: Hide browser sections in chrome://os-settings/ Use pageVisibility to hide sections like autofill, show bookmarks bar, etc. Bug: 950007 Change-Id: I871322a3eca51eb6995fa4ee304461c9f8bd0f35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575032 Reviewed-by: Dan Beam <dbeam@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#652856} .../browser/resources/settings/page_visibility.js | 121 ++++++++------------- .../ui/webui/settings/chromeos/os_settings_ui.cc | 1 + chrome/browser/ui/webui/settings/settings_ui.cc | 1 + 3 files changed, 47 insertions(+), 76 deletions(-) commit 7b459a69c765d5095eeb000022caf5cba88b8b0c Author: Eric Aleshire <ericale@google.com> Date: Mon Apr 22 16:05:27 2019 +0000 Introduce ASSERT_IF_ERROR, used test-side to wrap methods that return NSError*. As part of the EG2 migration, app-side helpers that used to GREYAssert now return NSError*, which are asserted on in test-side code. ASSERT_IF_ERROR simplifies the modification required for test code that call these app-side helpers, while preserving the line number of the failure. This CL aligns the test code in these 4 CLs to use ASSERT_IF_ERROR: http://crrev.com/c/1562756 http://crrev.com/c/1553085 http://crrev.com/c/1558155 http://crrev.com/c/1559889 Bug: 922813 Change-Id: I2d82dd9cd6a9eab6913418d357649c1f13f3699f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574954 Commit-Queue: ericale <ericale@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#652855} .../browser/metrics/tab_usage_recorder_egtest.mm | 66 +++++----------- ios/chrome/browser/metrics/ukm_egtest.mm | 4 +- .../browser/ui/first_run/first_run_egtest.mm | 14 ++-- .../browser/ui/fullscreen/fullscreen_egtest.mm | 90 ++++++---------------- .../payment_request_accessibility_egtest.mm | 10 +-- .../payment_request_can_make_payment_egtest.mm | 31 ++++---- .../payment_request_cancel_pay_abort_egtest.mm | 7 +- .../ui/payments/payment_request_debit_egtest.mm | 8 +- .../payment_request_journey_logger_egtest.mm | 13 ++-- .../payments/payment_request_modifiers_egtest.mm | 8 +- .../payment_request_payment_response_egtest.mm | 29 +++---- .../ui/payments/payment_request_show_egtest.mm | 7 +- .../payments/payment_request_use_stats_egtest.mm | 23 ++---- .../google_services/accounts_table_egtest.mm | 25 +++--- .../browser/ui/settings/signin_settings_egtest.mm | 11 ++- .../signin_interaction_controller_egtest.mm | 48 +++++------- .../browser/web/progress_indicator_egtest.mm | 7 +- ios/chrome/test/earl_grey/chrome_error_util.h | 12 +++ 18 files changed, 155 insertions(+), 258 deletions(-) Updated tag 'tree_truth' (was 287e77d76b54)