Back to build
Raw log | Switch to full mode | Login

/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh /b/swarming/w/ir/cache/builder/src src in dir /b/swarming/w/ir/k: allow_subannotations: False cmd: ['/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh', '/b/swarming/w/ir/cache/builder/src', 'src'] env: {'CHROME_HEADLESS': '1'} env_prefixes: {} env_suffixes: {} infra_step: False name_tokens: ('tree truth steps',) ok_ret: frozenset([0]) trigger_specs: () full environment: ADDRFAM: inet BOTO_CONFIG: /b/swarming/w/ir/tmp/gsutil-task/.boto BUILDBUCKET_EXPERIMENTAL: FALSE CHROME_HEADLESS: 1 CIPD_CACHE_DIR: /b/swarming/cipd_cache/cache CIPD_PROTOCOL: v2 DEVSHELL_CLIENT_PORT: 42472 DOCKER_CONFIG: /b/swarming/w/ir/tmp/docker-cfg-task DOCKER_TMPDIR: /b/swarming/w/ir/tmp/docker-tmp-task GIT_CONFIG_NOSYSTEM: 1 GIT_TERMINAL_PROMPT: 0 HOME: /home/chrome-bot IFACE: eth0 INFRA_GIT_WRAPPER_HOME: /b/swarming/w/ir/tmp/git-home-task LOGDOG_COORDINATOR_HOST: logs.chromium.org LOGDOG_STREAM_PREFIX: buildbucket/cr-buildbucket.appspot.com/8915348901874391024 LOGDOG_STREAM_PROJECT: chromium LOGDOG_STREAM_SERVER_PATH: unix:/b/swarming/w/ir/tmp/ld.sock LOGICAL: eth0 LUCI_CONTEXT: /b/swarming/w/ir/tmp/luci_context.901513245 MAC_CHROMIUM_TMPDIR: /b/swarming/w/ir/tmp/t METHOD: dhcp NO_GCE_CHECK: False PATH: /b/swarming/w/ir/cipd_bin_packages:/b/swarming/w/ir/cipd_bin_packages/bin:/b/swarming/cipd_cache/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin PWD: /b/swarming/w/ir/k PYTHONIOENCODING: UTF-8 PYTHONUNBUFFERED: 1 ROOT_SETUP_LOG: /var/log/messages/chromebuild/root-setup.log SHLVL: 1 STARTUP_LOG: /var/log/messages/chromebuild/startup.log SWARMING_BOT_ID: swarm98-c4 SWARMING_EXTERNAL_BOT_SETUP: 1 SWARMING_HEADLESS: 1 SWARMING_SERVER: https://chromium-swarm.appspot.com SWARMING_TASK_ID: 44651693643f1e11 TEMP: /b/swarming/w/ir/tmp/t TEMPDIR: /b/swarming/w/ir/tmp/t TERM: linux TMP: /b/swarming/w/ir/tmp/t TMPDIR: /b/swarming/w/ir/tmp/t UPSTART_EVENTS: net-device-up UPSTART_INSTANCE: UPSTART_JOB: chromebuild-startup USER: chrome-bot USERNAME: chrome-bot VPYTHON_VIRTUALENV_ROOT: /b/swarming/w/ir/cache/vpython _: /b/swarming/w/ir/cipd_bin_packages/vpython !@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: 559443a0cb5fb4a95e3c93b746b28209ef139435 Expose increment/decrement via standardActions in the automation API Anastasia Helfinstein, Tue Apr 23 21:30:11 2019 +0000 433c0c6b5e7cbc72faf696bbed34b408e7afbb6f [OT-PW] Support DocumentPaintDefinition for threaded worklet Stephen McGruer, Tue Apr 23 21:28:29 2019 +0000 f6bbc6fc28bbf9306d7c70c15f8f7132bb781cb4 [Sampling profiler] Fix V8 unwinding for post-startup Mike Wittman, Tue Apr 23 21:28:19 2019 +0000 9683677526bf8e4b9f87e52c1387da551078b0e4 [DevTools] Add WebSocket messages to HAR exports Joey Arhar, Tue Apr 23 21:26:17 2019 +0000 3d256ea09ce900c796386c41c0afc59fd4a344b0 Added a PausableElapsedTimer. Edwin Joe, Tue Apr 23 21:24:38 2019 +0000 2e9940c49fab7261750827b3ad35185925071aae viz: Set RPDQ blend to kSrcOver for empty backdrop rects Daniele Castagna, Tue Apr 23 21:21:51 2019 +0000 4773880bf43b91453d1055461c23fcf14ca84f0e Enable WizardControllerDemoSetupDeviceDisabled.OnlineDemoSetup Toni Barzic, Tue Apr 23 21:21:41 2019 +0000 fd2c486c7ded1a2bf6cd09c43fe3a0d74ed3e7c9 [iOS] Disable CBD button when no items are selected Huanzhong Huang, Tue Apr 23 21:20:07 2019 +0000 e57096e96fe95d4e639e2828f029b80ff365aaf2 [omnibox] Add OmniboxUICuesForSearchHistoryMatches feature flag Tommy C. Li, Tue Apr 23 21:18:55 2019 +0000 8f92c7d66bf998c112a7764408d81a22aa253663 PM: Remove last PageSignalGenerator user. Sigurdur Asgeirsson, Tue Apr 23 21:18:45 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit 559443a0cb5fb4a95e3c93b746b28209ef139435 Author: Anastasia Helfinstein <anastasi@google.com> Date: Tue Apr 23 21:30:11 2019 +0000 Expose increment/decrement via standardActions in the automation API Bug: 955201 Change-Id: Ib6a1d94d342696a370a17ed62852d8f7b7f39d52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578119 Reviewed-by: Katie Dektar <katie@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#653376} .../extensions/automation_internal_custom_bindings.cc | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) commit 433c0c6b5e7cbc72faf696bbed34b408e7afbb6f Author: Stephen McGruer <smcgruer@chromium.org> Date: Tue Apr 23 21:28:29 2019 +0000 [OT-PW] Support DocumentPaintDefinition for threaded worklet In the current, non-threaded design, the DocumentPaintDefinition is created in the global scope and passed to CSSPaintImageGeneratorImpl where it is used directly from main-thread call-points. This doesn't work for the threaded-worklet case, where the global scope runs on the worklet thread. Instead, the PaintWorkletProxyClient is responsible for gathering and detecting incompatible definitions. Once a valid set of definitions is received from all global scopes, a thread-safe version is created (MainThreadDocumentPaintDefinition) and passed cross-thread to the PaintWorklet instance on the main thread. That main thread version can then be used for main-thread call-points (not done in this CL). Bug: 946519 Change-Id: Ic150c42ae5d93610aec1e75ebf1117500441693b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576501 Reviewed-by: Jeremy Roman <jbroman@chromium.org> Reviewed-by: Xida Chen <xidachen@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#653375} third_party/blink/renderer/modules/BUILD.gn | 1 + .../blink/renderer/modules/csspaint/BUILD.gn | 2 + .../main_thread_document_paint_definition.cc | 32 +++ .../main_thread_document_paint_definition.h | 49 ++++ .../main_thread_document_paint_definition_test.cc | 94 +++++++ .../renderer/modules/csspaint/paint_worklet.cc | 11 +- .../renderer/modules/csspaint/paint_worklet.h | 22 +- .../modules/csspaint/paint_worklet_global_scope.cc | 8 +- .../csspaint/paint_worklet_global_scope_test.cc | 2 +- .../modules/csspaint/paint_worklet_proxy_client.cc | 49 +++- .../modules/csspaint/paint_worklet_proxy_client.h | 27 ++ .../csspaint/paint_worklet_proxy_client_test.cc | 310 ++++++++++++++++----- .../modules/worklet/worklet_thread_test_common.cc | 2 +- .../graphics/paint_worklet_paint_dispatcher.h | 10 +- 14 files changed, 534 insertions(+), 85 deletions(-) commit f6bbc6fc28bbf9306d7c70c15f8f7132bb781cb4 Author: Mike Wittman <wittman@chromium.org> Date: Tue Apr 23 21:28:19 2019 +0000 [Sampling profiler] Fix V8 unwinding for post-startup Uses a separate V8Unwinder object for each profile collection. This is required because of the unwinder's use of the ModuleCache, which is also scoped to the profile collection. To support this change auxiliary unwinder ownership is moved from ThreadProfiler to StackSamplerImpl. Bug: 909957 Change-Id: Idc78d6be2bbff6bbb52240ee647b28b9915ac962 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577787 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by: oysteine <oysteine@chromium.org> Reviewed-by: Charlie Andrews <charliea@chromium.org> Auto-Submit: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#653374} base/profiler/stack_sampler.h | 2 +- base/profiler/stack_sampler_impl.cc | 6 +++--- base/profiler/stack_sampler_impl.h | 4 ++-- base/profiler/stack_sampling_profiler.cc | 19 +++++++++++-------- base/profiler/stack_sampling_profiler.h | 2 +- chrome/common/thread_profiler.cc | 13 +++++++------ chrome/common/thread_profiler.h | 11 +++++++---- chrome/renderer/chrome_content_renderer_client.cc | 9 +++++++-- components/tracing/common/stack_sampler_android.cc | 4 +++- components/tracing/common/stack_sampler_android.h | 2 +- 10 files changed, 43 insertions(+), 29 deletions(-) commit 9683677526bf8e4b9f87e52c1387da551078b0e4 Author: Joey Arhar <jarhar@chromium.org> Date: Tue Apr 23 21:26:17 2019 +0000 [DevTools] Add WebSocket messages to HAR exports This patch also enables importing of the newly exported WebSocket messages Bug: 496006 Change-Id: I000468d266a570ca46eaa62ac9d7554713896acb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574606 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#653373} .../devtools/front_end/har_importer/HARFormat.js | 24 +++ .../devtools/front_end/har_importer/HARImporter.js | 18 +++ .../devtools/front_end/network/NetworkLogView.js | 14 +- .../renderer/devtools/front_end/sdk/HARLog.js | 10 ++ .../devtools/front_end/sdk/NetworkManager.js | 6 +- .../devtools/front_end/sdk/NetworkRequest.js | 10 +- .../http/tests/devtools/har-importer-expected.txt | 177 ++++++++++++++++++++- .../web_tests/http/tests/devtools/har-importer.js | 169 +++++++++++++++++++- .../devtools/websocket/har-websocket-expected.txt | 34 ++++ .../http/tests/devtools/websocket/har-websocket.js | 57 +++++++ 10 files changed, 494 insertions(+), 25 deletions(-) commit 3d256ea09ce900c796386c41c0afc59fd4a344b0 Author: Edwin Joe <ejoe@google.com> Date: Tue Apr 23 21:24:38 2019 +0000 Added a PausableElapsedTimer. There are some cases where an elapsed timer that can be paused is useful. An example case is recording surface embedding time to UMA metric. Currently, the surface embedding time is recorded by simply taking the different between the TimeTicks of the surface id allocation time and the TimeTicks of when Surface::OnWillBeDrawn is called. However, it is possible that surface id is allocated when the Renderer is not visible, i.e. when the child changes size while hidden. In this case, the surface embedding time will be arbitrarily inflated since Surface::OnWillBeDrawn will not be called until it becomes visible. By using a pausable elapsed timer, the surface embedding time can be paused if the renderer is hidden, and resumed when it becomes visible again. Bug: 949967 Change-Id: Ide8e5b67a06bae7d3ca1352574c477f35e32369c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576331 Reviewed-by: Jonathan Ross <jonross@chromium.org> Commit-Queue: Edwin Joe <ejoe@google.com> Cr-Commit-Position: refs/heads/master@{#653372} components/viz/common/BUILD.gn | 3 + components/viz/common/pausable_elapsed_timer.cc | 30 +++++++ components/viz/common/pausable_elapsed_timer.h | 42 +++++++++ .../viz/common/pausable_elapsed_timer_unittest.cc | 100 +++++++++++++++++++++ 4 files changed, 175 insertions(+) commit 2e9940c49fab7261750827b3ad35185925071aae Author: Daniele Castagna <dcastagna@chromium.org> Date: Tue Apr 23 21:21:51 2019 +0000 viz: Set RPDQ blend to kSrcOver for empty backdrop rects When the backdrop rect for a render pass is empty, gl_renderer currently sets use_shaders_for_blending to false, disregarding if the render pass blend mode is supported by the underlying graphics API. If it's not supported, a DCHECK is later hit when setting up alpha blending. This patch sets the blend function to kSrcOver in those cases where the backdrop rect is empty. The backdrop rect should be empty only in cases where the render pass draw quad is completely clipped. In the test case found by cluster fuzz the element has a clip-path: polygon(3px 0px, 35px 1px) that limits the render pass output rect. When computing the backdrop rect we intersect it with the render pass output rect resulting in an empty rect. Bug: 946464 Test: https://clusterfuzz.com/testcase?key=5140838366707712 Change-Id: Ie8a487a4f85c3a69ab4f809fc1ade1a71bdaaeda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576233 Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#653371} components/viz/service/display/gl_renderer.cc | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) commit 4773880bf43b91453d1055461c23fcf14ca84f0e Author: Toni Barzic <tbarzic@chromium.org> Date: Tue Apr 23 21:21:41 2019 +0000 Enable WizardControllerDemoSetupDeviceDisabled.OnlineDemoSetup Fixes a race where auto-enrollment screen would just hang if the auto-enrollment check triggered in posted EULA steps reported connection error, or server error before the auto enrollment check screen was started. The AutoEnrollmentController would report in complete state, but requests to (re) start auto-enrollment checks would be ignored due to client_ already being set. BUG=894384 Change-Id: Idd770f3e9d437a0a80df0e6243fc200dc6ae3e30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576144 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#653370} .../login/enrollment/auto_enrollment_check_screen.cc | 12 +++++++++++- .../browser/chromeos/login/wizard_controller_browsertest.cc | 10 ++++++---- 2 files changed, 17 insertions(+), 5 deletions(-) commit fd2c486c7ded1a2bf6cd09c43fe3a0d74ed3e7c9 Author: Huanzhong Huang <huanzhong@google.com> Date: Tue Apr 23 21:20:07 2019 +0000 [iOS] Disable CBD button when no items are selected Disable the Clear Browsing Data button (toolbar button in CBD table view) when no browsing data items are selected. Bug: 935346 Change-Id: I87417c2afca3d0297ae638cfb7cf100793bc2c81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575501 Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#653369} .../clear_browsing_data_table_view_controller.mm | 10 ++++++++++ 1 file changed, 10 insertions(+) commit e57096e96fe95d4e639e2828f029b80ff365aaf2 Author: Tommy C. Li <tommycli@chromium.org> Date: Tue Apr 23 21:18:55 2019 +0000 [omnibox] Add OmniboxUICuesForSearchHistoryMatches feature flag This CL provides a feature flag that enables a small subset of kOmniboxSuggestionTransparencyOptions. It just enables the clock icon on search history matches. Bug: 929477 Change-Id: I5aa112cd2627a25744ee00e70a735eed5892c0cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579466 Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#653368} components/omnibox/browser/autocomplete_match.cc | 4 +++- components/omnibox/common/omnibox_features.cc | 6 ++++++ components/omnibox/common/omnibox_features.h | 1 + 3 files changed, 10 insertions(+), 1 deletion(-) commit 8f92c7d66bf998c112a7764408d81a22aa253663 Author: Sigurdur Asgeirsson <siggi@chromium.org> Date: Tue Apr 23 21:18:45 2019 +0000 PM: Remove last PageSignalGenerator user. LocalSiteCharacteristicsWebContentsObserver (L41r) is the last user of the PageSignalGenerator (PSG). This CL replaces that functionality with a dedicated graph observer in preparation for retiring the PSG. The storage of load time performance estimates is also removed. The PSG maintains state for this that will be rewritten as a graph decorator in due course. Bug: 931407 Change-Id: I9840b6e9833702efde4d1587a990108c655e3b44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579363 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#653367} ...cal_site_characteristics_data_unittest_utils.cc | 3 +- ...al_site_characteristics_webcontents_observer.cc | 178 ++++++++++++++------- ...cal_site_characteristics_webcontents_observer.h | 35 ++-- ...haracteristics_webcontents_observer_unittest.cc | 85 +--------- chrome/browser/resource_coordinator/tab_helper.h | 2 +- .../tab_lifecycle_unit_unittest.cc | 2 +- 6 files changed, 144 insertions(+), 161 deletions(-) commit 7dab10eedaf25e4c82941fbae61bca3284f0e56c Author: Corentin Wallez <cwallez@chromium.org> Date: Tue Apr 23 21:17:44 2019 +0000 Reland: WebGPU decoder: Add Associate/Dissociate mailbox Reland with a fix for missing immediate data storage in the decoder unittests. These WebGPU IPC commands allows wrapping a mailbox in a Dawn texture and associate it to a given ID in dawn_wire. There is the respective dissociate command too. SharedImageRepresentationIOSurfaceDawn is changed to destroy() the Dawn texture on EndAccess so it is an error to access the texture after the mailbox has been dissociated. The class also gets some refcounting improvements. This also makes some GPU service objects able to be used when no GL context is present, as is the case when running WebGPU unittests. BUG=chromium:877147 Change-Id: Ib0c8f6251441c9dbe69252773279b53a1fec3736 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577422 Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#653366} gpu/BUILD.gn | 1 + gpu/command_buffer/build_webgpu_cmd_buffer.py | 9 +- .../client/webgpu_cmd_helper_autogen.h | 23 +++ gpu/command_buffer/client/webgpu_implementation.cc | 10 + gpu/command_buffer/client/webgpu_implementation.h | 2 + .../client/webgpu_implementation_autogen.h | 9 + .../client/webgpu_implementation_impl_autogen.h | 27 +++ .../webgpu_implementation_unittest_autogen.h | 26 +++ gpu/command_buffer/client/webgpu_interface.h | 7 + .../client/webgpu_interface_autogen.h | 8 + gpu/command_buffer/common/webgpu_cmd_format.h | 1 + .../common/webgpu_cmd_format_autogen.h | 105 ++++++++++ .../common/webgpu_cmd_format_test_autogen.h | 51 +++++ gpu/command_buffer/common/webgpu_cmd_ids_autogen.h | 5 +- .../shared_image_backing_factory_iosurface.h | 6 +- .../shared_image_backing_factory_iosurface.mm | 62 +++++- ...red_image_backing_factory_iosurface_unittest.cc | 19 +- gpu/command_buffer/service/shared_image_factory.cc | 13 +- gpu/command_buffer/service/shared_image_factory.h | 3 +- .../service/shared_image_factory_unittest.cc | 4 +- .../service/shared_image_representation.h | 2 + gpu/command_buffer/service/webgpu_decoder.cc | 6 +- gpu/command_buffer/service/webgpu_decoder.h | 4 + gpu/command_buffer/service/webgpu_decoder_impl.cc | 126 +++++++++++- gpu/command_buffer/service/webgpu_decoder_impl.h | 4 + .../service/webgpu_decoder_unittest.cc | 147 ++++++++++++++ gpu/command_buffer/tests/fuzzer_main.cc | 2 +- gpu/command_buffer/tests/webgpu_fence_unittest.cc | 2 - .../tests/webgpu_mailbox_unittest.cc | 224 +++++++++++++++++++++ gpu/command_buffer/tests/webgpu_test.cc | 22 ++ gpu/command_buffer/tests/webgpu_test.h | 7 + gpu/command_buffer/webgpu_cmd_buffer_functions.txt | 4 +- gpu/ipc/in_process_command_buffer.cc | 17 +- gpu/ipc/service/shared_image_stub.cc | 2 +- gpu/ipc/service/webgpu_command_buffer_stub.cc | 3 +- 35 files changed, 924 insertions(+), 39 deletions(-) commit cba24fa64620713bada881cde4d403186b0ef008 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Apr 23 21:17:40 2019 +0000 Roll src/third_party/chromite 18d98f00a12c..9616947a9374 (3 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/18d98f00a12c..9616947a9374 git log 18d98f00a12c..9616947a9374 --date=short --no-merges --format='%ad %ae %s' 2019-04-23 mathewk@chromium.org Mark lakitu boards as important 2019-04-23 norvez@chromium.org chromeos_config: mark nyan_big/blaze important 2019-04-23 derat@chromium.org chromeos_config: Run TastVMTest on amd64-generic-goma-full. Created with: gclient setdep -r src/third_party/chromite@9616947a9374 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: Iddea723ccd0f9c77371ffcc01a9372959607ceb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579443 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653365} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit c19340ae8d1a3e88a5c73943a96d9069e36a8d86 Author: Tanya Gupta <tgupta@chromium.org> Date: Tue Apr 23 21:16:25 2019 +0000 [SendTabToSelf] Added tests for sendtabtoself device info changes. The tests check for two cases: - When SendTabToSelf receiving is enabled on both devices, device info for both are updated to reflect this. - When SendTabToSelf receiving is disabled on one device, device info accurately reflects this change. Change-Id: Ie3350e66783890b8271d9700b1d6d4b35a8a84d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577946 Commit-Queue: Tanya Gupta <tgupta@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Reviewed-by: sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#653364} .../two_client_send_tab_to_self_sync_test.cc | 54 ++++++++++++++++++++++ 1 file changed, 54 insertions(+) commit ecd9bfd171df4d2d134bc867c0ebe9d0a6697c27 Author: Sky Malice <skym@chromium.org> Date: Tue Apr 23 21:15:32 2019 +0000 [Touchless] Restore focus to last tab button and site suggestions. * Reworked how focus was stored and passed around. Instead of having a JSON backed class with strong types, use a TypedKeyValues object backed by a Bundle. Each ViewHolder is responsible for creating these when they're focused, and after onViewBind() the ViewHolders are offered a generic focus object to see whether they want to restore focus with it. * Reworked when requestFocus() is called to be a little later, during LinearLayoutManager#onLayoutCompleted(). This was necessary for the above the fold views to correctly focus, and the NTP to mirror EoS. * Added support for focusing the view elements with the above the fold card. AboveTheFoldViewHolder itself is still outside of the MVC pattern, but delegation to the OpenTabButton and SiteSuggestions components follows MVC. Bug: 937452 Change-Id: I2df007f3a41007fd6a2b327b4729e30042d16bb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1563035 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by: Justin DeWitt <dewittj@chromium.org> Reviewed-by: Matthew Jones <mdjones@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#653363} .../browser/ntp/cards/NewTabPageAdapter.java | 4 +- .../browser/ntp/cards/NewTabPageViewHolder.java | 16 ++++ .../suggestions/SuggestionsRecyclerView.java | 11 ++- .../res/layout/new_tab_page_touchless_view.xml | 2 +- .../browser/touchless/AboveTheFoldViewHolder.java | 63 ++++++++++++++++ .../browser/touchless/FocusableComponent.java | 20 +++++ .../browser/touchless/OpenLastTabCoordinator.java | 14 +++- .../browser/touchless/OpenLastTabMediator.java | 12 ++- .../browser/touchless/OpenLastTabProperties.java | 13 +++- .../chrome/browser/touchless/OpenLastTabView.java | 20 +++++ .../browser/touchless/OpenLastTabViewBinder.java | 7 ++ .../browser/touchless/SiteSuggestionsAdapter.java | 18 ++++- .../touchless/SiteSuggestionsCoordinator.java | 21 +++++- .../browser/touchless/SiteSuggestionsMediator.java | 16 +++- .../touchless/TouchlessArticleViewHolder.java | 54 ++++++++++++++ .../browser/touchless/TouchlessLayoutManager.java | 65 +++++++++++++++++ .../browser/touchless/TouchlessNewTabPage.java | 22 +++--- .../touchless/TouchlessNewTabPageAdapter.java | 77 ++++++++++++++------ .../touchless/TouchlessNewTabPageFocusInfo.java | 85 ---------------------- .../touchless/TouchlessNewTabPageMediator.java | 27 ++++++- .../touchless/TouchlessNewTabPageProperties.java | 9 ++- .../browser/touchless/TouchlessRecyclerView.java | 24 ++++++ .../TouchlessNewTabPageFocusInfoTest.java | 82 --------------------- .../android/touchless/touchless_java_sources.gni | 11 +-- 24 files changed, 461 insertions(+), 232 deletions(-) commit daaf003edfd1493c2a628c99060415790d58181b Author: Staphany Park <staphany@chromium.org> Date: Tue Apr 23 21:15:14 2019 +0000 Roll src/third_party/googletest/src/ 9f893b995..a53e931dc (5 commits) https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/9f893b99598b..a53e931dcd00 $ git log 9f893b995..a53e931dc --date=short --no-merges --format='%ad %ae %s' 2019-04-18 gennadiycivil Update README.md 2019-04-18 misterg Googletest export 2019-04-18 absl-team Googletest export 2019-04-18 misterg Googletest export 2019-03-08 yaneurabeya clang: fix `-Wsign-conversion` errors Created with: roll-dep src/third_party/googletest/src Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel,mac_optional_gpu_tests_rel,linux_chromium_cfi_rel_ng;luci.chrome.try:win_chrome_official Change-Id: I063fb50f95b0af4a7686c3f59d01b7d0a2db6ae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577861 Commit-Queue: Staphany Park <staphany@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Auto-Submit: Staphany Park <staphany@chromium.org> Cr-Commit-Position: refs/heads/master@{#653362} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit f64aa5bd001c19ea77af8ab68795d7af91abc9b1 Author: John Williams <jrw@google.com> Date: Tue Apr 23 21:14:15 2019 +0000 [Cast MRP] Split cast_activity_manager.{cc,h} apart. Bug: 954797 Change-Id: Idec1306428c4efa4500534ad970da1606e132003 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575435 Commit-Queue: John Williams <jrw@chromium.org> Reviewed-by: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#653361} chrome/browser/media/router/BUILD.gn | 4 + .../router/providers/cast/cast_activity_manager.cc | 402 +-------------------- .../router/providers/cast/cast_activity_manager.h | 244 +------------ .../router/providers/cast/cast_activity_record.cc | 196 ++++++++++ .../router/providers/cast/cast_activity_record.h | 142 ++++++++ .../router/providers/cast/cast_session_client.cc | 231 ++++++++++++ .../router/providers/cast/cast_session_client.h | 144 ++++++++ .../router/providers/cast/cast_session_tracker.h | 1 + 8 files changed, 743 insertions(+), 621 deletions(-) commit 18766e6bdb8670312f0d73fbfdba2dfd108e1bb9 Author: Tanya Gupta <tgupta@chromium.org> Date: Tue Apr 23 21:12:20 2019 +0000 [SendTabToSelf] Potentially fixed sigsev in ShouldOfferFeature. The function assumed that all calls would return non-null pointers. Fixed that to explictly check for nullptr. Bug: 950640 Change-Id: I7b1ff107b3dd6b94b439f486779cfefe2ae1688e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577977 Reviewed-by: sebsg <sebsg@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Tanya Gupta <tgupta@chromium.org> Cr-Commit-Position: refs/heads/master@{#653360} chrome/browser/send_tab_to_self/send_tab_to_self_util.cc | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) commit d61bd53e385e2e249687cec28fe28f488a25fa0c Author: David Benjamin <davidben@chromium.org> Date: Tue Apr 23 21:11:37 2019 +0000 Unwind the SSL version interference probe. This takes away one source of SSLConfig variation. We can instead put it back in SSLConnectJob (the flattened socket pools should avoid the NTLM bug), but no point when we don't need it anymore. TLS 1.3 has been shipping for over a year now, and the admin policy expired in M75. Per chrome/VERSION, trunk is now M76. This CL does not change whether connections with TLS-1.3-intolerant networks or servers fail. It only shifts the error back to ERR_SSL_PROTOCOL_ERROR, ERR_CONNECTION_RESET, or whatever we actually get out of the server. Bug: 951205 Change-Id: I95f1730c7b835c9aab1998c0cda56bcfaca45e1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574368 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Steven Valdez <svaldez@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#653359} components/error_page/common/localized_error.cc | 6 ---- net/base/net_error_list.h | 17 ++------- net/http/http_network_transaction.cc | 38 +------------------- net/http/http_network_transaction.h | 4 --- net/http/http_network_transaction_unittest.cc | 46 ++++--------------------- net/http/http_stream_factory_unittest.cc | 3 +- net/log/net_log_event_type_list.h | 9 ----- net/socket/client_socket_pool.cc | 9 +---- net/socket/client_socket_pool.h | 3 -- net/socket/client_socket_pool_base_unittest.cc | 1 - net/socket/client_socket_pool_manager.cc | 15 ++------ net/socket/client_socket_pool_unittest.cc | 14 -------- net/socket/ssl_client_socket_impl.cc | 11 +----- net/socket/ssl_client_socket_unittest.cc | 31 ----------------- net/socket/ssl_connect_job.cc | 12 +++---- net/ssl/ssl_config.cc | 1 - net/ssl/ssl_config.h | 6 ---- net/url_request/url_request_unittest.cc | 19 ++-------- tools/metrics/histograms/histograms.xml | 6 ++++ 19 files changed, 30 insertions(+), 221 deletions(-) commit 28169c22aa15f38092d742115642429b9ad12b6a Author: Huanzhong Huang <huanzhong@google.com> Date: Tue Apr 23 21:10:53 2019 +0000 [iOS] Add another initializer for CBDManager -Add another initializer for ClearBrowsingDataManager -Make BrowsingDataRemover and CounterProducer explicit dependencies of CBDManager, so to allow dependency injections in tests. Bug: 935350 Change-Id: I2e445e474c7a549b3aebcf1007b543b371644bbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577421 Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#653358} .../ui/settings/clear_browsing_data/BUILD.gn | 17 +++++++ .../browsing_data_counter_wrapper_producer.h | 23 ++++++++++ .../browsing_data_counter_wrapper_producer.mm | 24 ++++++++++ .../clear_browsing_data_manager.h | 14 ++++-- .../clear_browsing_data_manager.mm | 52 ++++++++++++++++------ .../clear_browsing_data_manager_unittest.mm | 23 +++++----- .../fake_browsing_data_counter_wrapper_producer.h | 14 ++++++ .../fake_browsing_data_counter_wrapper_producer.mm | 23 ++++++++++ 8 files changed, 163 insertions(+), 27 deletions(-) commit 2618cfafba2c4815deff252ca5a32343d902447e Author: Caitlin Fischer <caitlinfischer@google.com> Date: Tue Apr 23 21:10:29 2019 +0000 [Autofill] Removes an unnecessary call to the string16 constructor. Bug: 955638 Change-Id: I375ca09f4c117ad35b84a85c97dae9702d8b534a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579521 Reviewed-by: Tommy Martino <tmartino@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#653357} components/autofill/core/browser/suggestion_selection.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit ab711ffb014dfd5a8565a25bc77bfaf64d68636f Author: Junbo Ke <juke@google.com> Date: Tue Apr 23 21:06:18 2019 +0000 [chromecast] Add a function in CastContentBrowserClient to initialize CastURLLoaderThrottle::Delegate Bug: b/129956026 Merge-With: eureka-internal/265739 Test: Manual test Change-Id: Icebc1806c842ba7b69be7dac425ccda433b23d0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577960 Commit-Queue: Junbo Ke <juke@chromium.org> Reviewed-by: Sean Topping <seantopping@chromium.org> Reviewed-by: Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#653356} chromecast/browser/cast_browser_main_parts.cc | 6 ++++-- chromecast/browser/cast_content_browser_client.cc | 2 ++ chromecast/browser/cast_content_browser_client.h | 2 ++ 3 files changed, 8 insertions(+), 2 deletions(-) commit a06522eb86d00a0679297a2e6135cdacf664f8c2 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Apr 23 21:05:06 2019 +0000 Roll src/third_party/depot_tools 6d9913ab1893..158a65393019 (1 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6d9913ab1893..158a65393019 git log 6d9913ab1893..158a65393019 --date=short --no-merges --format='%ad %ae %s' 2019-04-23 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@158a65393019 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I25cf0f0c3e52a1544216b8b57b61c2cf89c92f05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579439 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653355} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 19536ef7283881f82805b64a6f0e8382de512edb Author: Paul Meyer <paulmeyer@chromium.org> Date: Tue Apr 23 21:02:11 2019 +0000 Sniff WebP images for unoptimized image policies. This patch applies content sniffing to WebP images in order to determine whether they use lossy or lossless compression. This allows the the policies to be applied more precisely to WebP images. Bug: 955580 Change-Id: Id5d97d9d10e1253fe353dc03ffbdbdee69e9428b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569691 Reviewed-by: Stephen Chenney <schenney@chromium.org> Commit-Queue: Paul Meyer <paulmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#653354} .../core/loader/resource/image_resource_content.cc | 30 ++++------ .../core/loader/resource/image_resource_content.h | 10 +++- .../core/loader/resource/image_resource_test.cc | 52 +++++++++++++++++ .../blink/renderer/platform/image-decoders/DEPS | 1 + .../platform/image-decoders/image_decoder.cc | 66 ++++++++++++++++++++++ .../platform/image-decoders/image_decoder.h | 12 ++++ 6 files changed, 149 insertions(+), 22 deletions(-) commit 160e7288409b1015562297f6434d318e03f7a8f2 Author: Mike Klein <mtklein@chromium.org> Date: Tue Apr 23 21:00:11 2019 +0000 prepare for Skia include path shakeup Neither of these should do anything yet: - add top-level Skia directory to include path so includes like "include/core/SkCanvas.h" will work (see https://skia-review.googlesource.com/c/skia/+/209706) - define SK_USER_CONFIG_HEADER to point to Chromium's SkUserConfig.h (see https://skia-review.googlesource.com/c/skia/+/209866) As a small sanity cleanup: - remove Skia's include/config from the include path. We don't ever want to use Skia's default SkUserConfig.h, only ever Chromium's. I think the include order means we have no bug here, but removing the undesirable include path should make that extra snuggly safe. Change-Id: I87ac5132967251e80f7b0bbea01676df25195b02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577632 Reviewed-by: Florin Malita <fmalita@chromium.org> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#653353} skia/BUILD.gn | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit 3501550bca5a539b27a21512ddc1e396a2de7062 Author: Nate Chapin <japhet@chromium.org> Date: Tue Apr 23 20:58:47 2019 +0000 Don't send location API navigations through NavigationScheduler This is a small code change with a lot of test changes. The two most common reasons for those changes are: * Cases where the ordering of messages reaching the browser process changed in ways that browser_tests were sensitive to. * A navigation scheduled by NavigationScheduler doesn't prevent a DidStopLoading() callback, but starting the navigation immediately does prevent DidStopLoading(). So location API navigations inside onload used to result in two pairs of DidStartLoading/DidStopLoading callbacks, where there is now only one pair. Bug: 914587 Change-Id: I83b016041c4579a64cf9ccfd7876dba335b799d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526426 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#653352} chrome/browser/history/redirect_browsertest.cc | 13 ++++++------- .../extensions/api_test/activity_log_private/test/test.js | 4 ++++ .../test/data/extensions/api_test/tabs/on_updated/test.js | 1 - content/browser/security_exploit_browsertest.cc | 8 ++++++-- .../blink/renderer/bindings/core/v8/activity_logger_test.cc | 4 ++++ third_party/blink/renderer/core/frame/location.cc | 10 ++++++---- third_party/blink/renderer/core/frame/remote_frame.cc | 6 +++--- .../beforeunload-synchronous-expected.txt | 4 ---- .../the-script-element/execution-timing/028-expected.txt | 6 ------ .../fast/dom/location-new-window-no-crash-expected.txt | 3 +++ ...btree-layout-with-javascript-navigate-crash-expected.txt | 2 +- .../subtree-layout-with-javascript-navigate-crash.html | 3 +-- .../http/tests/loading/stop-load-at-commit-expected.txt | 4 ++-- .../onload-detach-during-csp-frame-src-none-expected.txt | 2 +- ...ecurity-context-grandchildren-write-lexical-expected.txt | 1 + ...urity-context-grandchildren-writeln-lexical-expected.txt | 1 + .../tests/security/xss-DENIED-javascript-variations.html | 6 +++--- 17 files changed, 42 insertions(+), 36 deletions(-) commit 70b812abe00ec43de6a985afb12870956e515180 Author: Zhenyao Mo <zmo@chromium.org> Date: Tue Apr 23 20:55:41 2019 +0000 Extend histogram GPU.GpuGeneration to M90. We want to know how our user base migrate to newer GPU generations over time, so definitely want to keep this alive for much longer. BUG=945562 TEST=bots Change-Id: Ibc762346b315454d4918b22aa51816700a48ae80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575084 Reviewed-by: Brian White <bcwhite@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#653351} tools/metrics/histograms/histograms.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit ec2ce62839c5280ac2386413b5696529d1f27794 Author: Daniel McArdle <dmcardle@chromium.org> Date: Tue Apr 23 20:54:31 2019 +0000 Replace base::MD5Context with boringssl in //media Testing with media_unittests Bug: 755368 Change-Id: I9b45735a5d3054207d3bc340bce45fb25014a447 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568847 Auto-Submit: Daniel McArdle <dmcardle@chromium.org> Commit-Queue: Daniel McArdle <dmcardle@chromium.org> Reviewed-by: Dan Sanders <sandersd@chromium.org> Reviewed-by: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#653350} media/DEPS | 1 + media/base/BUILD.gn | 1 + media/base/video_frame.cc | 8 ++--- media/base/video_frame.h | 7 ++-- media/base/video_frame_unittest.cc | 37 ++++++++++++---------- media/capture/BUILD.gn | 1 + media/capture/video/android/BUILD.gn | 1 + media/filters/BUILD.gn | 1 + media/filters/audio_decoder_unittest.cc | 20 ++++++------ media/filters/audio_file_reader_unittest.cc | 11 +++++-- media/gpu/image_processor_test.cc | 2 +- media/gpu/test/image.cc | 13 +++++--- media/gpu/test/video_frame_validator.cc | 13 ++++---- .../test/video_player/frame_renderer_thumbnail.cc | 7 ++-- media/gpu/v4l2/BUILD.gn | 1 + media/gpu/vaapi/BUILD.gn | 1 + media/gpu/video_decode_accelerator_unittest.cc | 10 ++++-- media/test/pipeline_integration_test_base.cc | 14 +++++--- media/test/pipeline_integration_test_base.h | 7 ++-- 19 files changed, 95 insertions(+), 61 deletions(-) commit ffdc2163c8e00148123a58f61f9f5e6bb28bad0a Author: Jared Saul <jsaul@google.com> Date: Tue Apr 23 20:52:53 2019 +0000 [Autofill] Clean up Sign in after local save flag Bug: 855182 Change-Id: I8760ab9eb7bf3fbae726674537555dad5dcb8870 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577876 Reviewed-by: Evan Stade <estade@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#653349} chrome/browser/about_flags.cc | 6 --- chrome/browser/flag-metadata.json | 5 -- chrome/browser/flag_descriptions.cc | 7 --- chrome/browser/flag_descriptions.h | 3 -- .../payments/save_card_bubble_controller_impl.cc | 11 ++--- ...save_card_bubble_controller_impl_browsertest.cc | 9 ---- .../save_card_bubble_controller_impl_unittest.cc | 56 ---------------------- .../payments/save_card_bubble_views_browsertest.cc | 52 ++------------------ .../core/common/autofill_payments_features.cc | 5 -- .../core/common/autofill_payments_features.h | 1 - tools/metrics/histograms/enums.xml | 4 -- 11 files changed, 7 insertions(+), 152 deletions(-) commit 6a06474fb4fa7bea169cfe9552dd9b80b2491230 Author: Emil A Eklund <eae@chromium.org> Date: Tue Apr 23 20:52:09 2019 +0000 [LayoutNG] Remove out-of-date TODOs in NGLineBreaker Bug: 714962 Change-Id: I37dea7db4dfc33b561871a20969629e8b497c103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579030 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#653348} third_party/blink/renderer/core/layout/ng/inline/ng_line_breaker.cc | 4 ---- 1 file changed, 4 deletions(-) commit e32aada7dcc5a56389b14798cda81e5ecb004242 Author: Regan Hsu <hsuregan@chromium.org> Date: Tue Apr 23 20:49:05 2019 +0000 [CrOS SplitSettings] Patch in new changes on browser settings to OS. Patches diff from https://chromium-review.googlesource.com/c/chromium/src/+/1574440 to os settings. Bug: 950007 Change-Id: Ifbd4489816055260f3fb1a48ee91620b53e6d61c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577943 Reviewed-by: May Lippert <maybelle@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#653347} .../resources/settings/chromeos/os_settings_main/os_settings_main.html | 3 ++- .../resources/settings/chromeos/os_settings_main/os_settings_main.js | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) commit 3172f00f35545636244e339eac68e1a469888ab8 Author: Nick Harper <nharper@chromium.org> Date: Tue Apr 23 20:48:57 2019 +0000 Update bulk entries in HSTS preload list Change-Id: I5244ca5369eba162c2314ad1aedddfbe9c7ddb62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577583 Reviewed-by: Nick Harper <nharper@chromium.org> Reviewed-by: Bence Béky <bnc@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#653346} net/http/transport_security_state_static.json | 485 +++++++++++++++++++++----- 1 file changed, 390 insertions(+), 95 deletions(-) commit f81e2b43b6eedf540952dffd51687d0bd26fdc4b Author: Sebastien Marchand <sebmarchand@chromium.org> Date: Tue Apr 23 20:47:00 2019 +0000 Remove the site-characteristics-database flag. This feature has been enabled by default for a while now, the flag isn't needed anymore. The feature is being kept for now as there's some feature parameters that we'll want to explore in the feature, but there's no need for a flag. Bug: 839878 Change-Id: Ib848d9762317985cf3c3df18710154c972dc445a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579323 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#653345} chrome/browser/about_flags.cc | 4 ---- chrome/browser/flag-metadata.json | 5 ----- chrome/browser/flag_descriptions.cc | 6 ------ chrome/browser/flag_descriptions.h | 3 --- 4 files changed, 18 deletions(-) commit ca74d63d451a3331e4a7e1265b19446dc7ea2a74 Author: Tom Sepez <tsepez@chromium.org> Date: Tue Apr 23 20:45:24 2019 +0000 Add Span() method to StringBuffer Prefer Span() to bare Characters() calls. Use it in one place where it is obvious to do so. Bug: 955067 Change-Id: I8ac39279f4c117ab235642e82da4db23c31a9e5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578595 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#653344} third_party/blink/renderer/platform/text/capitalize.cc | 3 +-- third_party/blink/renderer/platform/wtf/text/string_buffer.h | 6 ++++++ 2 files changed, 7 insertions(+), 2 deletions(-) commit fc7457605d36684fdeefbf31816148dbaa06d6cf Author: Sky Malice <skym@chromium.org> Date: Tue Apr 23 20:44:17 2019 +0000 [Touchless] Set spacing between label and first card to 24dp. Bug: 937446 Change-Id: I6fe3c61d715cf8e541922d01e561696c434155d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577935 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#653343} chrome/android/touchless/java/res/layout/new_tab_page_touchless.xml | 1 + chrome/android/touchless/java/res/values-v17/dimens.xml | 3 +++ 2 files changed, 4 insertions(+) commit 04f9b48b4df11a09c916a64491e876bc15fb6fe8 Author: Huanzhong Huang <huanzhong@google.com> Date: Tue Apr 23 20:37:00 2019 +0000 [iOS] Make corrections on ClearDataItemTest Remove a few tests in ClearDataItemTest, as enabling the new CBD UI flag breaks them, and we are switching to CBD table view. Bug: 935350 Change-Id: Ied27069a56d7bc67bc42de5f67596d741b004d98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576567 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Cr-Commit-Position: refs/heads/master@{#653342} .../cells/clear_browsing_data_item_unittest.mm | 33 ---------------------- 1 file changed, 33 deletions(-) commit eadcecb06a726ccbe4df318520eb631021004578 Author: Matt Menke <mmenke@chromium.org> Date: Tue Apr 23 20:36:38 2019 +0000 SocketParams refactor 6: Remove net::CreateConnectJobForRawConnect(). The one consumer of the method now creates ConnectJobs directly, instead of going through ClientSocketPoolManager. As the consumer isn't even using SocketPools, the new layering makes more sense. Bug: 533571 Change-Id: I7c7ade3a5204d6df4c26fd444b67f20192b8d707 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577843 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#653341} net/socket/client_socket_pool_manager.cc | 21 --------------------- net/socket/client_socket_pool_manager.h | 18 ------------------ services/network/proxy_resolving_client_socket.cc | 15 ++++++++++----- 3 files changed, 10 insertions(+), 44 deletions(-) commit e61cd138968e635dfc0c3671d652e9d38690fd0f Author: Karan Bhatia <karandeepb@chromium.org> Date: Tue Apr 23 20:35:53 2019 +0000 WebRequest: Remove unused WebRequestWSRequestHeadersModification enum. This CL removes the unused WebRequestWSRequestHeadersModification enum. This was added to report header modification for web sockets, but wasn't removed when the corresponding histogram was deprecated. BUG=None Change-Id: I1298a48772e9dec456f6902fc768b8754b82dd9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577742 Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#653340} extensions/browser/api/web_request/web_request_api_helpers.cc | 9 --------- 1 file changed, 9 deletions(-) commit 96af3d7a3fd6fafa31ea7c31fb9e8d34e1f4514f Author: Chris Cunningham <chcunningham@chromium.org> Date: Tue Apr 23 20:35:30 2019 +0000 Disable Flaky SettingsOptInTakeOverServicePrefChanges Test Flaking regularly on all platforms https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests&tests=UnifiedConsentBrowserTest.SettingsOptInTakeOverServicePrefChanges Bug: 954167 Change-Id: Iad5e8798636692ab692ef1980dd9b2ce694549b9 TBR: tangltom@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579519 Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#653339} chrome/browser/unified_consent/unified_consent_browsertest.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit ddc47ea282b94695756249697e7c7cf0bd1e260f Author: Elly Fong-Jones <ellyjones@google.com> Date: Tue Apr 23 20:33:29 2019 +0000 flags: assign silent-debugger-extension-api Bug: None Change-Id: I2151f1e9d30a4973f9b5ceea9ebef429aae5a374 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575678 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#653338} chrome/browser/flag-metadata.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 3118df327a2b129cddacb9ccd56711774795e165 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Apr 23 20:33:12 2019 +0000 Roll Fuchsia SDK from 891539624597 to 891536750703 The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I15ecfa935eb67952de961f40803db25a5fbfb231 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579441 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653337} build/fuchsia/linux.sdk.sha1 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 03484427e4817aaab55fe57ca14e8f077fc9a706 Author: Siddhartha S <ssid@chromium.org> Date: Tue Apr 23 20:30:00 2019 +0000 Track interface name of top queued IPC message For interface clients, track the name of the interface in tracing for the type of message that is queued a lot. BUG=874530 Change-Id: I3a6e2ea125758d4e0df9b851778e834f5805b502 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570195 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#653336} ipc/ipc_mojo_bootstrap.cc | 58 ++++++++++++++++++---- mojo/public/cpp/bindings/associated_binding.h | 7 +-- .../cpp/bindings/interface_endpoint_client.h | 6 ++- mojo/public/cpp/bindings/lib/associated_binding.cc | 5 +- .../bindings/lib/associated_interface_ptr_state.cc | 6 ++- .../bindings/lib/associated_interface_ptr_state.h | 5 +- mojo/public/cpp/bindings/lib/binding_state.cc | 2 +- .../cpp/bindings/lib/control_message_proxy.cc | 5 ++ .../cpp/bindings/lib/interface_endpoint_client.cc | 6 ++- .../public/cpp/bindings/lib/interface_ptr_state.cc | 5 +- mojo/public/cpp/bindings/lib/interface_ptr_state.h | 6 ++- mojo/public/cpp/bindings/lib/message.cc | 3 ++ .../cpp/bindings/lib/pipe_control_message_proxy.cc | 4 ++ mojo/public/cpp/bindings/message.h | 6 +++ .../public/cpp/bindings/tests/bindings_perftest.cc | 8 +-- .../bindings/tests/multiplex_router_unittest.cc | 38 +++++++------- .../public/cpp/trace_event_args_whitelist.cc | 3 +- 17 files changed, 124 insertions(+), 49 deletions(-) commit 5184480bde93971b88c4c1ef01a10a49f7d95fe8 Author: Matt Mueller <mattm@chromium.org> Date: Tue Apr 23 20:28:54 2019 +0000 cr_cronet.py: Replace most os.system uses with subprocess.call os.system passes the command line to a shell to execute, which requires careful quoting/escaping (which the script was not doing). subprocess.call executes the target directly and arguments are not processed by the shell. iossim has one argument that is itself a list of arguments to pass to its child process, so extra care is taken in escaping that argument. Change-Id: I6785c83d732dc1fe6a874598f13cb4e47eaa35e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577877 Reviewed-by: Misha Efimov <mef@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#653335} components/cronet/tools/cr_cronet.py | 76 +++++++++++++++++++++--------------- 1 file changed, 44 insertions(+), 32 deletions(-) commit ff071f8aab0d8853c699634cbe730c7cd74a96c7 Author: Yi Gu <yigu@chromium.org> Date: Tue Apr 23 20:28:33 2019 +0000 [Animation Worklet] Drop assumption on effects being from the same doc Currently all effects must have the same document to create a worklet animation. However, animating a target which is from a different document, e.g. an iframe, should be allowed. Change-Id: I24ed3597cbbe588f78829fb64e305e3cd07f637c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574427 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by: Majid Valipour <majidvp@chromium.org> Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#653334} .../modules/animationworklet/worklet_animation.cc | 7 ---- .../worklet-animation-creation.https.html | 8 ++-- ...n-with-effects-from-different-frames.https.html | 48 ++++++++++++++++++++++ 3 files changed, 52 insertions(+), 11 deletions(-) commit 8d4a6b126b229ae7de277971f1a33bb37f9a304a Author: Jared Saul <jsaul@google.com> Date: Tue Apr 23 20:26:20 2019 +0000 [Autofill] Remove unused strings, or confine them to Android Change-Id: Ib85fbac78d0ae96b5abad2cbec7a028fa64c78a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578062 Reviewed-by: Tommy Martino <tmartino@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#653333} components/autofill_payments_strings.grdp | 36 +++++++++++++++++-------------- components/autofill_strings.grdp | 15 ------------- 2 files changed, 20 insertions(+), 31 deletions(-) commit 1b7c2ea8a342fa7712a2b140a68adc08ef3628cc Author: Antoine Labour <piman@chromium.org> Date: Tue Apr 23 20:15:56 2019 +0000 Port test_runner::TestPlugin to shared images Bug: 924592 Change-Id: I30bacfe9209cfca2680ec9e234c4e83b596acd22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577683 Auto-Submit: Antoine Labour <piman@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#653332} content/shell/test_runner/test_plugin.cc | 83 +++++++++++++++++++++----------- content/shell/test_runner/test_plugin.h | 12 ++++- 2 files changed, 64 insertions(+), 31 deletions(-) commit a7436576e2636c29517c856cf3976ff17e105161 Author: Yuly Novikov <ynovikov@chromium.org> Date: Tue Apr 23 20:13:10 2019 +0000 Increase Win10 FYI Release (NVIDIA GeForce GTX 1660) bot timeout. To 12 hours, since it fails to finish in 6 hours. TBR=martiniss Bug: 881625 Change-Id: I26b0d47d3f6e8d844a25987e3420483f1e7c5799 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579471 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#653331} infra/config/cr-buildbucket.cfg | 1 + 1 file changed, 1 insertion(+) commit da6500b3ad148d6c786eb39ec9d122681069bda6 Author: Chrome Cunningham <chcunningham@chromium.org> Date: Tue Apr 23 20:11:21 2019 +0000 Revert "Reland "[Image Fetcher] Replace AnswersImageFetcher with CachedImageFetcher"" This reverts commit 040e68ad7b0a30b97ab9103d330ff2a237f2fd17. Reason for revert: Suspected break of android omnibox tests. Original change's description: > Reland "[Image Fetcher] Replace AnswersImageFetcher with CachedImageFetcher" > > This is a reland of 9f25017463ee6cbfa63166b152212b5f705af328 > > Original change's description: > > [Image Fetcher] Replace AnswersImageFetcher with CachedImageFetcher > > > > Removing a duplicate cached image fetcher here. > > > > Bug: 934950 > > Change-Id: I0063aa8e26cbd4c0a0acb7f3c59f4ee86116e2db > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1481955 > > Commit-Queue: Brandon Wylie <wylieb@chromium.org> > > Reviewed-by: Ted Choc <tedchoc@chromium.org> > > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > > Reviewed-by: Theresa <twellington@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#651905} > > Bug: 934950 > Change-Id: I33f1f4b6f2aefe8a6fc733102c568f9420f0451d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574628 > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Commit-Queue: Brandon Wylie <wylieb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#652949} TBR=rkaplow@chromium.org,tedchoc@chromium.org,twellington@chromium.org,wylieb@chromium.org,ender@google.com Change-Id: Iae5f8a23d8fb7f6478e56128d0eb7c6cb4da02d7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 934950, 955634 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577997 Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#653330} chrome/android/BUILD.gn | 1 + chrome/android/chrome_java_sources.gni | 1 + .../org/chromium/chrome/browser/BitmapCache.java | 8 -- .../browser/image_fetcher/CachedImageFetcher.java | 3 - .../chrome/browser/image_fetcher/ImageFetcher.java | 6 -- .../browser/image_fetcher/ImageFetcherFactory.java | 42 ++++----- .../image_fetcher/InMemoryCachedImageFetcher.java | 7 +- .../browser/image_fetcher/NetworkImageFetcher.java | 3 - .../chrome/browser/omnibox/LocationBar.java | 5 - .../chrome/browser/omnibox/LocationBarLayout.java | 6 -- .../omnibox/suggestions/AnswersImageFetcher.java | 104 +++++++++++++++++++++ .../suggestions/AutocompleteCoordinator.java | 7 +- .../omnibox/suggestions/AutocompleteMediator.java | 7 +- .../answer/AnswerSuggestionProcessor.java | 66 +++++-------- .../browser/toolbar/top/CustomTabToolbar.java | 3 - .../chrome/browser/toolbar/top/ToolbarLayout.java | 2 - .../chrome/browser/toolbar/top/ToolbarPhone.java | 3 - .../image_fetcher/ImageFetcherFactoryTest.java | 15 ++- .../browser/image_fetcher/ImageFetcherTest.java | 3 - chrome/browser/BUILD.gn | 1 + .../android/omnibox/answers_image_bridge.cc | 77 +++++++++++++++ tools/metrics/histograms/histograms.xml | 2 - 22 files changed, 236 insertions(+), 136 deletions(-) commit 1d5834386c03a4746cfe411b99211d664eee8b99 Author: John Rummell <jrummell@chromium.org> Date: Tue Apr 23 20:10:55 2019 +0000 Add testing feature to disable MediaDrm provisioning If the feature "FailUrlProvisionFetcherForTesting" is enabled, all MediaDrm provisioning requests will not be sent to the provisioning server and will respond as if the request failed. BUG=954541 TEST=tested manually Change-Id: I9606e05671d1ffaede8743a150ebe67cfbfb2836 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576121 Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#653329} .../media/android/cdm/media_drm_origin_id_manager_unittest.cc | 2 ++ content/browser/media/url_provision_fetcher.cc | 8 ++++++++ media/base/media_switches.cc | 7 +++++++ media/base/media_switches.h | 1 + 4 files changed, 18 insertions(+) commit 6bce39540206225321bc6a15d7cddb7407a7112a Author: Wei Li <weili@chromium.org> Date: Tue Apr 23 20:09:51 2019 +0000 UIDevTools: Add support for metadata property setting Add a general support for setting properties in metadata. The properties are passed in as string from frontend, we will parse and set it accordingly. Also, since frontend doesn't do any checking, we also add a simple check for boolean type for now. BUG=954675 Change-Id: I1e6d241a27fe5dd390b2c5ff2888d77a3f13094a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578099 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#653328} components/ui_devtools/css_agent.cc | 4 +++ components/ui_devtools/ui_element.cc | 5 ++++ components/ui_devtools/ui_element.h | 5 ++++ components/ui_devtools/views/view_element.cc | 34 ++++++++++++++++++++++ components/ui_devtools/views/view_element.h | 1 + .../ui_devtools/views/view_element_unittest.cc | 30 +++++++++++++++++++ 6 files changed, 79 insertions(+) commit 175917892deb9d1f532853cda0aa6468f4ff04ca Author: Gayane Petrosyan <gayane@chromium.org> Date: Tue Apr 23 20:05:52 2019 +0000 [Themes cleanup] Remove supervised user theme. Remove supervised user theme as supervised users are not supported anymore and child accounts don't use this theme. There was previous attempt on removing some of this code that got reverted and never re-landed https://chromium-review.googlesource.com/c/chromium/src/+/1238113 Change-Id: I57079ac0c611f9574ade9cc5800f09a0998612ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574597 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#653327} chrome/browser/BUILD.gn | 2 - .../supervised_user/supervised_user_theme.cc | 69 ---------------------- .../supervised_user/supervised_user_theme.h | 33 ----------- chrome/browser/themes/custom_theme_supplier.h | 1 - chrome/browser/themes/theme_properties.h | 5 -- chrome/browser/themes/theme_service.cc | 44 +------------- chrome/browser/themes/theme_service_unittest.cc | 66 +-------------------- 7 files changed, 2 insertions(+), 218 deletions(-) commit 4f78f1144f4ca71370fd2336571631c396adf8c9 Author: Hongchan Choi <hongchan@chromium.org> Date: Tue Apr 23 20:04:13 2019 +0000 Handle the case of detached iframe in RendererWebAudioDeviceImpl DCHECK in RendererWebAudioDeviceImpl assumes an AudioContext to have a valid frame ID, and it makes DCHECK-enabled build crash when an AudioContext is originated from a detached iframe. This CL loosens the condition of DCHECK to allow such case. Bug: 954995 Change-Id: I50b577f0e0b466ed76c0d9bbb807cd10adb30acd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577841 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Reviewed-by: Hongchan Choi <hongchan@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#653326} content/renderer/media/renderer_webaudiodevice_impl.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 75cb884109bcac3d4bbb19586406e30325832ce8 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Tue Apr 23 20:02:03 2019 +0000 Roll src-internal c12c3c3531c0..643152926e86 (5 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c12c3c3531c0..643152926e86 Created with: gclient setdep -r src-internal@643152926e86 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:None,chromium:b/122971066 TBR=chcunningham@chromium.org,loyso@chromium.org,clamy@chromium.org,flackr@chromium.org Change-Id: I988fedfbdcf65b64029ff797e8b2639445668201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576273 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653325} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit b2041c7bdaeda5e99c44867a4626403e9cdd4440 Author: Brandon Wylie <wylieb@chromium.org> Date: Tue Apr 23 20:01:00 2019 +0000 [Touchless] Set icon visibility explicitly A change landed while writing this that defaulted the icon visibility to GONE. So I need to set the visibility explicitly. Bug: 937450 Change-Id: I3d5e8b7ef000c84e665aca4a020a4fdaf2663705 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579420 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#653324} .../chrome/browser/touchless/TouchlessActionItemViewHolder.java | 2 ++ 1 file changed, 2 insertions(+) commit 758b797d084dd1d02ad979ca5b56588f77282e15 Author: Lucas Furukawa Gadani <lfg@chromium.org> Date: Tue Apr 23 20:00:02 2019 +0000 Portals: Test that adoptPredecessor can't be called after PortalActivateEvent. Bug: 942286 Change-Id: I5e8b509da8e1df9ccaf1a3bb468177d17e4ab588 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577937 Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#653323} .../blink/web_tests/external/wpt/lint.whitelist | 1 + .../wpt/portals/portals-adopt-predecessor.html | 10 ++++++++ .../portals-adopt-predecessor-portal.html | 28 ++++++++++++++++++---- 3 files changed, 35 insertions(+), 4 deletions(-) commit a89836ee1fbe91638d330eb56a10c348f7d14d92 Author: Yuwei Huang <yuweih@chromium.org> Date: Tue Apr 23 19:57:50 2019 +0000 [remoting][FTL] Extend FtlSignalingPlayground to support Chromotocol This CL allows FtlSignalingPlayground to use Chromotocol when the user passes a --enable-ftl-signaling flag to the playground. This makes it easier to test Chromotocol over FTL. Bug: 955617 Change-Id: I513b13acb56751cce875aa697c3637ea0e19d719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578955 Reviewed-by: Joe Downing <joedow@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#653322} remoting/test/BUILD.gn | 4 ++ remoting/test/fake_ice_connection.cc | 61 +++++++++++++++++++++ remoting/test/fake_ice_connection.h | 50 +++++++++++++++++ remoting/test/fake_webrtc_connection.cc | 49 +++++++++++++++++ remoting/test/fake_webrtc_connection.h | 47 ++++++++++++++++ remoting/test/ftl_signaling_playground.cc | 89 ++++++++++++------------------- remoting/test/ftl_signaling_playground.h | 10 ++-- 7 files changed, 252 insertions(+), 58 deletions(-) commit 0dd4331c52077f11707851a7c918e4233a54c723 Author: Eric Roman <eroman@chromium.org> Date: Tue Apr 23 19:56:59 2019 +0000 Remove histogram Net.Cronet.PrefsInitTime. Change-Id: I0d03deb5ec5eda34e2e64778e3721d26e8cb5c8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577867 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by: Misha Efimov <mef@chromium.org> Reviewed-by: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#653321} components/cronet/cronet_prefs_manager.cc | 1 - tools/metrics/histograms/histograms.xml | 6 +++++- 2 files changed, 5 insertions(+), 2 deletions(-) commit 120c0c0102921a8b626d2d9726b59b696a772751 Author: Emil A Eklund <eae@chromium.org> Date: Tue Apr 23 19:54:46 2019 +0000 Remove obsolete AAT fallback perf test The layout/character_fallback_aat.html performance test has outlived its usefulness now that we no longer fallback on CoreText rendering for AAT. Change-Id: I842d586919e70f776ca29f8a442a21798def238a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579399 Commit-Queue: Emil A Eklund <eae@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: Emil A Eklund <eae@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#653320} .../perf_tests/layout/character_fallback_aat.html | 18 ------------------ 1 file changed, 18 deletions(-) commit 97894215147c0e7c48c0d88fe4e3de0a8f13ca80 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Tue Apr 23 19:53:04 2019 +0000 [BGPT] Make render surface for opacity etc. simpler and more accurate The new algorithm takes advantage of an attribute of the cc property tree: a child always has a bigger id than its parent, which is simpler and has higher performance. It also fix a bug that sometimes we mistakenly ignored child render surfaces as a controlled layer. Now always count child render surface as a controlled layer of the parent. Bug: 955177 Change-Id: If0b9d657ddfbf69dd4f099aa85f52427479c6fbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576031 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#653319} .../compositing/paint_artifact_compositor.cc | 78 +++++++++------------ .../compositing/paint_artifact_compositor_test.cc | 29 +++++++- .../composited-filters-under-opacity-ref.html | 17 +++++ .../composited-filters-under-opacity.html | 20 ++++++ ...sted-render-surfaces-with-rotation-expected.png | Bin 16197 -> 15481 bytes ...sted-render-surfaces-with-rotation-expected.png | Bin 16198 -> 15484 bytes 6 files changed, 97 insertions(+), 47 deletions(-) commit 82bbb95809908ecfa47fa6dc094b156be5fd5a03 Author: James Cook <jamescook@chromium.org> Date: Tue Apr 23 19:52:32 2019 +0000 Eliminate IDS_DEFAULT_FONT_SIZE and IDS_DEFAULT_FIXED_FONT_SIZE These purport to be used for per-locale default font sizes. However, their values are always constant (16 and 13) across all platforms and locales. Just use the constants instead. Bug: 955029 Change-Id: I2c47f2d8a2b690397e38a548b7243a5bd72ba02a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577790 Reviewed-by: Michael Wasserman <msw@chromium.org> Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#653318} chrome/app/resources/locale_settings_chromiumos.grd | 10 ---------- chrome/app/resources/locale_settings_google_chromeos.grd | 10 ---------- chrome/app/resources/locale_settings_ko.xtb | 2 -- chrome/app/resources/locale_settings_linux.grd | 10 ---------- chrome/app/resources/locale_settings_mac.grd | 10 ---------- chrome/app/resources/locale_settings_win.grd | 10 ---------- chrome/browser/ui/prefs/prefs_tab_helper.cc | 6 ++---- ui/base/resource/resource_bundle.cc | 2 +- 8 files changed, 3 insertions(+), 57 deletions(-) commit cf6a4a26871a0deca08ea23604ecba4ed037e73a Author: Wei Li <weili@chromium.org> Date: Tue Apr 23 19:50:00 2019 +0000 UIDevTools: Show properties from View metadata Retrieve all the properties from View's metadata, send and show them through UI DevTools' frontend. Editing them is not implemented in this CL yet. BUG=954675 Change-Id: I5d737ca26ee728d7151e7e5cdfba523a00530f66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574645 Reviewed-by: Leonard Grey <lgrey@chromium.org> Reviewed-by: Allen Bauer <kylixrd@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#653317} components/ui_devtools/views/view_element.cc | 15 ++++++++++++--- components/ui_devtools/views/view_element_unittest.cc | 8 +++++--- 2 files changed, 17 insertions(+), 6 deletions(-) commit 5a380cfa54b6ddebeb3c570817a66ffc71ee6bef Author: Caroline Rising <corising@chromium.org> Date: Tue Apr 23 19:49:15 2019 +0000 Remove unnecessary uses of BubbleBorder::set_arrow_offset and limit access to BubbleBorder functions. Remove unused function from MenuScrollViewContainer and redundant call from InfolistWindow. Remove BubbleBorder getter from BubbleFrameView to restrict ability to change BubbleBorder outside of functions available in BubbleFrameView. This is a follow-up from https://chromium-review.googlesource.com/c/chromium/src/+/1552284. Bug: 910739 Change-Id: Iad0006dd515dcf89977e4b1a3a5c1533fdb4f098 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561837 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by: Dana Fried <dfried@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#653316} ash/assistant/ui/assistant_container_view.cc | 13 +- ash/shelf/shelf_bubble.cc | 4 +- ash/system/tray/tray_bubble_view.cc | 4 +- .../browser/ui/views/extensions/extension_popup.cc | 4 +- .../feature_promos/feature_promo_bubble_view.cc | 2 +- .../ui/views/tabs/tab_hover_card_bubble_view.cc | 2 +- ui/chromeos/ime/candidate_window_view.cc | 6 +- ui/chromeos/ime/infolist_window.cc | 1 - ui/views/bubble/bubble_border.cc | 12 +- ui/views/bubble/bubble_border.h | 8 +- ui/views/bubble/bubble_dialog_delegate_view.cc | 4 +- .../bubble/bubble_dialog_delegate_view_unittest.cc | 2 +- ui/views/bubble/bubble_frame_view.cc | 27 ++- ui/views/bubble/bubble_frame_view.h | 19 +- ui/views/bubble/bubble_frame_view_unittest.cc | 194 +++++++++++---------- .../controls/menu/menu_scroll_view_container.cc | 7 +- .../controls/menu/menu_scroll_view_container.h | 3 - 17 files changed, 167 insertions(+), 145 deletions(-) commit 78a27c066aaa4a088ae343f5c87d508ca2063b02 Author: Nate Fischer <ntfschr@chromium.org> Date: Tue Apr 23 19:48:01 2019 +0000 AW docs: expand on troubleshooting guide This expands the Quick Start's troubleshooting guide to include some more cases: - Incorrect signature errors - Trying to switch to a disabled fallback provider Bug: 955135, 918221 Test: tools/md_browser/md_browser.py Test: Upload to gerrit > open file > click "gitiles" Change-Id: Ia0dcd1d5c3cfe9d44de78a3398b3f9ce5373f928 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579263 Reviewed-by: Bo <boliu@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#653315} android_webview/docs/quick-start.md | 25 +++++++++++++++++++++---- 1 file changed, 21 insertions(+), 4 deletions(-) commit e2a58e9dcc7ab1cc708441327969d5e42fecdaea Author: Orin Jaworski <orinj@chromium.org> Date: Tue Apr 23 19:47:21 2019 +0000 [omnibox] Create omnibox_resources containing Pedal concept data This CL is like the previously landed (and reverted) CL... 1e6642b0358084c7d9069dca4fd03cad16641700 [omnibox] Add and load Pedal concept data for de, en, fr, ja, zh-CN Previously, Pedal concept data was a singular resource in English but this CL restructures the resources to load localized data from a pak depending on selected language. Data for the first four non-English languages localized by the translation team is included. ...But has the following differences: * Pedal concept data itself is improved (esp. for fr, ja, and zh-CN). * The per-locale resources are contained in a separate .grd file instead of being included in components_strings.grd. See https://crbug.com/954348 for details about why the revert and reworking of the previous CL was necessary. Bug: 893183, 954348 Change-Id: I337ce9a72f6e27165e895ac9b5055641b4019ac5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577782 Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#653314} chrome/chrome_repack_locales.gni | 6 ++ components/BUILD.gn | 2 + components/omnibox/browser/BUILD.gn | 1 + .../omnibox/browser/omnibox_pedal_concepts.h | 2 +- .../omnibox_pedal_implementations_unittest.cc | 106 +++++++++++++++++++-- .../omnibox/browser/omnibox_pedal_provider.cc | 8 +- components/omnibox/resources/BUILD.gn | 16 ++++ .../omnibox/resources/omnibox_pedal_concepts.json | 1 - .../resources/omnibox_pedal_concepts_de.json | 1 + .../resources/omnibox_pedal_concepts_en.json | 1 + .../resources/omnibox_pedal_concepts_fr.json | 1 + .../resources/omnibox_pedal_concepts_ja.json | 1 + .../resources/omnibox_pedal_concepts_zh-CN.json | 1 + components/omnibox/resources/omnibox_resources.grd | 104 ++++++++++++++++++++ components/resources/OWNERS | 1 - components/resources/components_resources.grd | 1 - components/resources/omnibox_resources.grdp | 4 - tools/gritsettings/resource_ids | 3 + tools/gritsettings/translation_expectations.pyl | 1 + 19 files changed, 242 insertions(+), 19 deletions(-) commit cd50d9d26b9fb883209a874175057df72cce4d9b Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Apr 23 19:46:24 2019 +0000 Roll src/third_party/skia f153e221140a..29c1c8029a52 (9 commits) https://skia.googlesource.com/skia.git/+log/f153e221140a..29c1c8029a52 git log f153e221140a..29c1c8029a52 --date=short --no-merges --format='%ad %ae %s' 2019-04-23 robertphillips@google.com Revert "Implement alternate method for determining recycle-ability of allocated GrSurfaces" 2019-04-23 reed@google.com change colormatrixfilter to be 0...1 for translate 2019-04-23 jvanverth@google.com Add GrMtlCommandBuffer 2019-04-23 halcanary@google.com Make default SkUserConfig a noop 2019-04-23 reed@google.com Fixes for saveBehind/drawBehind 2019-04-23 robertphillips@google.com Implement alternate method for determining recycle-ability of allocated GrSurfaces 2019-04-23 mtklein@google.com rename gamma stage gamma_ 2019-04-23 robertphillips@google.com Remove the option of disabling explicit resource allocation 2019-04-23 mtklein@google.com add third_party/skcms to includes Created with: gclient setdep -r src/third_party/skia@29c1c8029a52 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@chromium.org Change-Id: I8cabd91384f614c9cfec5be4fb540f662c9e53b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577630 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653313} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit c90d75228e09b046f841e494e478c0a0966996df Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Apr 23 19:46:13 2019 +0000 Roll src/third_party/catapult fb33e51cc0d8..0c3de1750970 (1 commits) https://chromium.googlesource.com/catapult.git/+log/fb33e51cc0d8..0c3de1750970 git log fb33e51cc0d8..0c3de1750970 --date=short --no-merges --format='%ad %ae %s' 2019-04-23 benjhayden@chromium.org Add M75 to CHROMIUM_MILESTONES Created with: gclient setdep -r src/third_party/catapult@0c3de1750970 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=crouleau@chromium.org Change-Id: Ie7f13835b1dcae35093fd8e7a481023498664030 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579122 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653312} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit c40ecbc76fba3539367d9bfc2a225829033dae56 Author: James Cook <jamescook@chromium.org> Date: Tue Apr 23 19:44:59 2019 +0000 CrOS SplitSettings: Remove "On startup" section from OS settings This is a browser setting ("Open the New Tab page", etc.), so remove it from the OS settings page. Removal reduces the browser's resources.pak file size by 3 KB (post gzip compression). Bug: 95007 Test: Enable SplitSettings, OS settings page does not show section Change-Id: I49dede7175eb546778dbbaba3d1688c85798678e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578593 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#653311} .../os_settings_menu/os_settings_menu.html | 5 --- .../os_settings_page/os_settings_page.html | 8 ----- .../resources/settings/os_settings_resources.grd | 38 ---------------------- .../ui/webui/settings/chromeos/os_settings_ui.cc | 6 ---- 4 files changed, 57 deletions(-) commit d46a56ab24d3965330efe5f999f2a97e69179194 Author: Julien Isorce <julien.isorce@chromium.org> Date: Tue Apr 23 19:43:10 2019 +0000 Implement gfx::ColorSpace::GetWithMatrixAndRange Useful to keep the gamma and transfer info from the original color space while setting an yuv transformation. It will be used in media::VideoCaptureDeviceClient where the captured data is converted to I420 using libyuv. Test: gfx_unittests --gtest_filter=*ColorSpace.Mixed* Bug: 945468 Change-Id: Ic3a5cc7540c58cdd2778d56a3be695003b2c963f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578581 Reviewed-by: ccameron <ccameron@chromium.org> Commit-Queue: Julien Isorce <julien.isorce@chromium.org> Cr-Commit-Position: refs/heads/master@{#653310} ui/gfx/color_space.cc | 11 +++++++++++ ui/gfx/color_space.h | 4 ++++ ui/gfx/color_space_unittest.cc | 32 ++++++++++++++++++++++++++++++++ 3 files changed, 47 insertions(+) commit 4e1a8b9acf74810ad7ac8eb1fff515949cfef497 Author: dpapad <dpapad@chromium.org> Date: Tue Apr 23 19:42:49 2019 +0000 WebUI Polymer2: Remove Polymer1 support, part 3. Stop generating and including both Polymer1 and Polymer2 HTML bundles in the binary. Only include Polymer2 bundles. Bug: 944281 Change-Id: I4cac6b9b6186a18a27d79075a7e5399aa0a389ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1533083 Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#653309} chrome/browser/browser_resources.grd | 7 ------ chrome/browser/resources/bookmarks/BUILD.gn | 1 - .../chromeos/bluetooth_pairing_dialog/BUILD.gn | 1 - .../chromeos/internet_config_dialog/BUILD.gn | 3 +-- .../chromeos/internet_detail_dialog/BUILD.gn | 3 +-- chrome/browser/resources/downloads/BUILD.gn | 1 - chrome/browser/resources/extensions/BUILD.gn | 1 - .../extensions/extensions_resources_vulcanized.grd | 7 ------ chrome/browser/resources/history/BUILD.gn | 4 ---- chrome/browser/resources/optimize_webui.gni | 8 ------- chrome/browser/resources/optimize_webui.py | 25 ++++++---------------- chrome/browser/resources/optimize_webui_test.py | 5 +---- chrome/browser/resources/print_preview/BUILD.gn | 1 - .../print_preview_resources_vulcanized.grd | 1 - chrome/browser/resources/settings/BUILD.gn | 4 ---- .../browser/resources/settings/chromeos/BUILD.gn | 4 ---- .../settings/os_settings_resources_vulcanized.grd | 14 ------------ .../settings/settings_resources_vulcanized.grd | 2 -- chrome/browser/ui/webui/bookmarks/bookmarks_ui.cc | 2 +- .../ui/webui/chromeos/bluetooth_pairing_dialog.cc | 2 +- .../ui/webui/chromeos/internet_config_dialog.cc | 2 +- .../ui/webui/chromeos/internet_detail_dialog.cc | 2 +- chrome/browser/ui/webui/downloads/downloads_ui.cc | 2 +- .../browser/ui/webui/extensions/extensions_ui.cc | 2 +- chrome/browser/ui/webui/history_ui.cc | 4 ++-- .../ui/webui/print_preview/print_preview_ui.cc | 2 +- .../ui/webui/settings/chromeos/os_settings_ui.cc | 4 ++-- chrome/browser/ui/webui/settings/settings_ui.cc | 4 ++-- 28 files changed, 22 insertions(+), 96 deletions(-) commit e9b5ad749b962cface4b295f1a6439237f6774b3 Author: Chris Cunningham <chcunningham@chromium.org> Date: Tue Apr 23 19:40:38 2019 +0000 Revert "Remove "XSLT" runtime enabled feature" This reverts commit fb8ff28be837c61b79916d1bc79399b0fe51188b. Reason for revert: I'm speculatively reverting this change. Its one of 3* under consideration for breaking these tests on mac inspector-protocol/heap-profiler/heap-snapshot-merged-nodes.js inspector-protocol/heap-profiler/heap-snapshot-with-event-listener.js I haven't been able to repro it locally, but this is the only CL of the 3 that touches anything in blink. Hopefully I got it right. *https://chromium.googlesource.com/chromium/src/+log/fb8ff28be837c61b79916d1bc79399b0fe51188b%5E..0cbed54f7a63d80ccc22b5cb331c224f9f4e3e08?pretty=fuller&n= Original change's description: > Remove "XSLT" runtime enabled feature > > The flag was introduced at > https://crrev.com/eae49e58e1365c1d010cb49b6d2eb87823904fc4 to run > an experiment to disable the feature, but it was more than 5 years ago. > Remove the flag as there seems no activity around it. > > Bug: None > Change-Id: I186e804da25138455eef4ca8a66812ff40fb7e29 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575261 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Yutaka Hirano <yhirano@chromium.org> > Cr-Commit-Position: refs/heads/master@{#653117} TBR=kinuko@chromium.org,yhirano@chromium.org,haraken@chromium.org Change-Id: Ibb77c58126185b8da1641f01804e15962a361124 Bug: 955521 Change-Id: Ibb77c58126185b8da1641f01804e15962a361124 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577994 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#653308} content/public/common/common_param_traits_macros.h | 1 + content/public/common/web_preferences.cc | 1 + content/public/common/web_preferences.h | 1 + content/renderer/render_view_impl.cc | 1 + content/shell/renderer/web_test/blink_test_helpers.cc | 1 + third_party/blink/public/platform/web_runtime_features.h | 1 + third_party/blink/renderer/core/dom/processing_instruction.cc | 6 +++++- .../renderer/core/loader/resource/xsl_style_sheet_resource.cc | 2 ++ third_party/blink/renderer/core/xml/document_xslt.cc | 9 +++++++-- .../blink/renderer/core/xml/parser/xml_document_parser.cc | 4 ++++ third_party/blink/renderer/core/xml/xsl_style_sheet.h | 4 ++++ third_party/blink/renderer/core/xml/xslt_extensions.cc | 2 ++ third_party/blink/renderer/core/xml/xslt_processor.h | 2 ++ third_party/blink/renderer/core/xml/xslt_processor.idl | 1 + .../blink/renderer/platform/exported/web_runtime_features.cc | 4 ++++ .../blink/renderer/platform/loader/fetch/resource_fetcher.cc | 4 ++++ .../blink/renderer/platform/runtime_enabled_features.json5 | 4 ++++ 17 files changed, 45 insertions(+), 3 deletions(-) commit e2de5aed7754abbc4e3b9083476dbf86b270bdf6 Author: Risan <risan@google.com> Date: Tue Apr 23 19:38:55 2019 +0000 Limit inotify_watches per FilePathWatcher instance This prevents a FilePathWatcher instance to exhaust the inotify watches limit (/proc/sys/fs/inotify/max_user_watches. The limit is based on the kernel limit/predicted number of FilePathWatcher instance (for example, at one time, in my eve there are 7 instance. Then, I round it up to the next next 2^k just so that it is large enough for audio client). In case the limit is hit, an error is reported through callback. correctly, divided by #predicted instances, and then error is reported accordingly. Bug: 921357 Test: Manually log everywhere to make sure that the proc entry is read Change-Id: Ib26d93e6d9c478a71759fb8ce0b76dce914f4567 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548974 Reviewed-by: François Doray <fdoray@chromium.org> Reviewed-by: Yusuke Sato <yusukes@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#653307} base/files/file_path_watcher_linux.cc | 73 ++++++++++++++++++++++++++++++++++- 1 file changed, 72 insertions(+), 1 deletion(-) commit a3d73b1b4119a2c03f9666e2ec0422b9524f23a8 Author: Pavel Yatsuk <pavely@google.com> Date: Tue Apr 23 19:32:10 2019 +0000 [Touchless] Show context menu from touchless NTP In this change: - Add tag for context menu delegate - Adjust objects that register for OnCreateContextMenu to store delegate reference in view's tag. - In TouchlessNTP, retrieve focused item, retrieve delegate and call ContextMenuManager to display context menu. BUG=937445 Change-Id: Ib4d2f85d5882098fcc48a0e201943d23796e3733 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574789 Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Matthew Jones <mdjones@chromium.org> Reviewed-by: Justin DeWitt <dewittj@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#653306} chrome/android/java/res/values/ids.xml | 1 + .../browser/native_page/ContextMenuManager.java | 16 +++++++++++++++ .../chrome/browser/ntp/cards/CardViewHolder.java | 1 + .../browser/touchless/SiteSuggestionsAdapter.java | 1 + .../browser/touchless/TouchlessNewTabPage.java | 23 ++++++++++++++++++---- 5 files changed, 38 insertions(+), 4 deletions(-) commit 56a09dc1cb68b59d24477532796afd680081f1aa Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Apr 23 19:17:08 2019 +0000 Roll src/third_party/chromite de445983dd92..18d98f00a12c (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/de445983dd92..18d98f00a12c git log de445983dd92..18d98f00a12c --date=short --no-merges --format='%ad %ae %s' 2019-04-23 hashimoto@chromium.org Revert "Point R75 ARC++ branch at nyc-mr1-arc-m75 and pi-arc-m75" Created with: gclient setdep -r src/third_party/chromite@18d98f00a12c The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: Ifa631b5b522a2e385ca08e2a12fc52abe006fced Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577628 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653305} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit b1cb9ffb9ec74accd4f9d04aba3d320f008680e2 Author: Anne Lim <annelim@google.com> Date: Tue Apr 23 19:16:00 2019 +0000 [AF] No local save prompt for saved cards Prevent unsupported cards to be offered local save if it is already saved. Bug: 955159 Change-Id: I5b47e8797062b1d9d660fb6428c9702f9b63dafd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576327 Commit-Queue: Anne Lim <annelim@google.com> Reviewed-by: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#653304} .../browser/payments/credit_card_save_manager.cc | 9 ++++-- .../payments/credit_card_save_manager_unittest.cc | 34 ++++++++++++++++++++++ 2 files changed, 40 insertions(+), 3 deletions(-) commit aa84a51c04502f2675096564c8043f05ab32b8e3 Author: Ted Choc <tedchoc@chromium.org> Date: Tue Apr 23 19:15:40 2019 +0000 More lightweight way for SendTabToSelfShareActivity to access navigation entry. getNavigationHistory() creates NavigationEntry items for the full tab history, and we only need the last item here. This should be a no-op. This exposes getVisibleEntry from NavigationController to match the visible URL shown in the omnibox. BUG= Change-Id: Ibb36a57dbaeb64cd7f5ea4725e7a18369176478d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574265 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by: sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#653303} .../browser/send_tab_to_self/SendTabToSelfShareActivity.java | 7 +++---- .../src/org/chromium/chrome/browser/NavigationPopupTest.java | 5 +++++ .../contextual_suggestions/GoogleSearchRestrictionTest.java | 5 +++++ .../send_tab_to_self/SendTabToSelfShareActivityTest.java | 7 +------ content/browser/frame_host/navigation_controller_android.cc | 12 ++++++++++++ content/browser/frame_host/navigation_controller_android.h | 3 +++ .../content/browser/framehost/NavigationControllerImpl.java | 10 ++++++++++ .../content_public/browser/NavigationController.java | 8 ++++++++ 8 files changed, 47 insertions(+), 10 deletions(-) commit 58e73ae459db7495f400455c93663b5f74213a24 Author: Chris Mumford <cmumford@google.com> Date: Tue Apr 23 19:13:29 2019 +0000 Marked ChildProcess.HungRendererCause as obsolete. This UMA was temporary and removed in r647374, but the UMA values were not marked as obsolete. Bug: 948332, 953044 Change-Id: I0ed956363b0b87dee12e07cc90e2cd4704e7ac4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575167 Commit-Queue: Chris Mumford <cmumford@google.com> Reviewed-by: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#653302} tools/metrics/histograms/enums.xml | 3 +++ tools/metrics/histograms/histograms.xml | 3 +++ 2 files changed, 6 insertions(+) commit 0a78536bdae102035e1ad50fee887a3799dcd65b Author: Ahmed Fakhry <afakhry@chromium.org> Date: Tue Apr 23 19:13:11 2019 +0000 Night Light: Timezone changes result in recalculation of sunset/sunrise times On timezone changes, request a new geoposition and push it to the NightLightController in ash in order to recalculate the sunset/sunrise times. BUG=953548 TEST=Added new test. Change-Id: I490fce272bf27a52191762b9dbefbfd89d40238a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579160 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#653301} .../chromeos/night_light/night_light_client.cc | 28 ++++++++- .../chromeos/night_light/night_light_client.h | 17 +++++- .../night_light/night_light_client_unittest.cc | 67 ++++++++++++++++++++++ 3 files changed, 110 insertions(+), 2 deletions(-) commit 392c611da19b999ead2641d5245e03101853ab2f Author: Reilly Grant <reillyg@chromium.org> Date: Tue Apr 23 19:12:12 2019 +0000 Update UsbChooserContext methods to take url::Origin This patch updates UsbChooserContext's GrantDevicePermission() and HasDevicePermission() methods to take a url::Origin instead of a GURL. The underlying ChooserContextBase methods still take a GURL. Bug: 951785 Change-Id: I709b0af7e58af0d4b7e8fdaf31f51d68decacca2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561554 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#653300} chrome/browser/policy/policy_browsertest.cc | 15 +- chrome/browser/ui/page_info/page_info_unittest.cc | 14 +- .../page_info/page_info_bubble_view_unittest.cc | 6 +- .../settings/site_settings_handler_unittest.cc | 22 +- .../ui/webui/site_settings_helper_unittest.cc | 60 ++--- chrome/browser/usb/usb_chooser_context.cc | 45 ++-- chrome/browser/usb/usb_chooser_context.h | 12 +- chrome/browser/usb/usb_chooser_context_unittest.cc | 267 +++++++++++---------- chrome/browser/usb/usb_chooser_controller.cc | 4 +- chrome/browser/usb/usb_chooser_controller.h | 6 +- chrome/browser/usb/web_usb_service_impl.cc | 9 +- chrome/browser/usb/web_usb_service_impl.h | 5 +- .../browser/usb/web_usb_service_impl_unittest.cc | 11 +- 13 files changed, 254 insertions(+), 222 deletions(-) commit b913cc8b4df6e97597e871db2a6e6fb3462756a9 Author: Gabriel Marin <gmx@chromium.org> Date: Tue Apr 23 19:11:17 2019 +0000 Handle _cxx_global_var_initN static constructors Add support for static constructors with names like _cxx_global_var_initN, which are sometimes emitted by clang. See discussion at: http://clang-developers.42468.n3.nabble.com/Static-constructors-cxx-global-var-initN-vs-GLOBAL-sub-I-XXX-td4049303.html Return matched global constructor symbol names and use the actual symbol name to understand relative branches in the disassembly of each symbol. BUG=b:119055819 Change-Id: I27d5c6019ee918506c03005969fbed442775a196 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577996 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#653299} tools/linux/dump-static-initializers.py | 37 ++++++++++++++++++++++----------- 1 file changed, 25 insertions(+), 12 deletions(-) commit 21cca4194ba849b19e33de5a9097993d620ba22f Author: asteinha <asteinhauser@google.com> Date: Tue Apr 23 19:11:05 2019 +0000 Cleanup dead flag --disable-web-resources. Removed more than 3 years ago in https://chromium.googlesource.com/chromium/src/+/e923740b2b3b65dffe86ecce49579f9121396ab0 Bug: 576772 Change-Id: I8151b3b266ae42cbee3baf93daf8ab18831e6f41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578241 Reviewed-by: Bill Budge <bbudge@chromium.org> Reviewed-by: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Anthony Steinhauser <asteinhauser@google.com> Cr-Commit-Position: refs/heads/master@{#653298} chrome/test/chromedriver/chrome_launcher.cc | 1 - .../native_client/tools/browser_tester/browsertester/browserlauncher.py | 1 - 2 files changed, 2 deletions(-) commit 778cf442a0040d196d9ce0aa870849c1fb698c83 Author: Joshua Peraza <jperaza@chromium.org> Date: Tue Apr 23 19:10:10 2019 +0000 Update Crashpad to c96226c6baa853f43981b0240974e33a0b661f8d 5f77cf41b62d Add CodeViewRecordBuildId 93366d782aab Make OSVersionFull work for SystemSnapshotMinidump c96226c6baa8 linux: move handler protocol types into a class Also updates crashpad_linux.cc with changes to handler protocol scoping. Change-Id: I482c14efaf3388ae788bff19e05d0152eb80941d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578591 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Auto-Submit: Joshua Peraza <jperaza@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#653297} components/crash/content/app/crashpad_linux.cc | 7 +- third_party/crashpad/README.chromium | 2 +- .../crashpad/client/crashpad_client_linux_test.cc | 2 +- .../crashpad/crashpad/handler/handler_main.cc | 2 +- .../linux/crash_report_exception_handler.cc | 6 +- .../handler/linux/crash_report_exception_handler.h | 22 +-- .../handler/linux/exception_handler_server.cc | 44 +++-- .../handler/linux/exception_handler_server.h | 29 +-- .../handler/linux/exception_handler_server_test.cc | 22 +-- .../crashpad/minidump/minidump_module_writer.cc | 84 ++++++--- .../crashpad/minidump/minidump_module_writer.h | 23 ++- .../minidump/minidump_module_writer_test.cc | 194 +++++++++++++++++++-- .../minidump/test/minidump_writable_test_util.cc | 88 ++++++---- .../minidump/test/minidump_writable_test_util.h | 56 +++--- .../crashpad/snapshot/elf/module_snapshot_elf.cc | 26 ++- .../crashpad/snapshot/elf/module_snapshot_elf.h | 1 + .../crashpad/snapshot/mac/module_snapshot_mac.cc | 13 +- .../crashpad/snapshot/mac/module_snapshot_mac.h | 1 + .../snapshot/minidump/module_snapshot_minidump.cc | 103 +++++++---- .../snapshot/minidump/module_snapshot_minidump.h | 7 + .../snapshot/minidump/process_snapshot_minidump.cc | 28 +-- .../snapshot/minidump/process_snapshot_minidump.h | 1 + .../minidump/process_snapshot_minidump_test.cc | 132 ++++++++++---- .../snapshot/minidump/system_snapshot_minidump.cc | 91 +++++----- .../snapshot/minidump/system_snapshot_minidump.h | 7 +- .../crashpad/crashpad/snapshot/module_snapshot.h | 15 ++ .../sanitized/module_snapshot_sanitized.cc | 4 + .../snapshot/sanitized/module_snapshot_sanitized.h | 1 + .../crashpad/snapshot/test/test_module_snapshot.cc | 10 +- .../crashpad/snapshot/test/test_module_snapshot.h | 5 + .../crashpad/snapshot/win/module_snapshot_win.cc | 8 +- .../crashpad/snapshot/win/module_snapshot_win.h | 1 + .../util/linux/exception_handler_client.cc | 29 +-- .../crashpad/util/linux/exception_handler_client.h | 7 +- .../util/linux/exception_handler_protocol.cc | 4 +- .../util/linux/exception_handler_protocol.h | 107 ++++++------ .../crashpad/crashpad/util/linux/ptrace_broker.cc | 25 +-- .../crashpad/crashpad/util/linux/ptrace_broker.h | 4 +- .../crashpad/crashpad/util/linux/ptrace_client.cc | 12 +- .../crashpad/crashpad/util/misc/pdb_structures.cc | 1 + .../crashpad/crashpad/util/misc/pdb_structures.h | 28 ++- 41 files changed, 871 insertions(+), 381 deletions(-) commit da4c168cd4f9d58f57334f3954e978bbdc9c7bfd Author: Abigail Klein <abigailbklein@google.com> Date: Tue Apr 23 19:06:50 2019 +0000 Call AXRelativeBounds::ToString in AXNodeData::ToString and remove duplicate code. Bug: 953319 Change-Id: I642a98fa25e88100e455b969f9deb282d3fd19cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577963 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#653296} ui/accessibility/ax_node_data.cc | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) commit 51cf7325ca071d2291619829505e640229f8c69f Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Apr 23 19:05:58 2019 +0000 Roll src/third_party/pdfium 0f35a9ee0be1..e9fa6a97fea6 (6 commits) https://pdfium.googlesource.com/pdfium.git/+log/0f35a9ee0be1..e9fa6a97fea6 git log 0f35a9ee0be1..e9fa6a97fea6 --date=short --no-merges --format='%ad %ae %s' 2019-04-23 tsepez@chromium.org Check for possibility of inf value from FXSYS_wcstof() 2019-04-23 tsepez@chromium.org Fix integer underflow in cfgas_stringformatter.cpp, part 2 2019-04-23 tsepez@chromium.org Check for nan in another place in cxfa_graphics.cpp 2019-04-23 thestig@chromium.org Update the email address for an AUTHORS entry. 2019-04-23 thestig@chromium.org Use std::make_unsigned<OPJ_OFF_T>::type in JPX code. 2019-04-23 thestig@chromium.org Roll third_party/skia/ 1383a38e1..e2aa08bf1 (1 commit) Created with: gclient setdep -r src/third_party/pdfium@e9fa6a97fea6 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:951712,chromium:947188,chromium:952301 TBR=dsinclair@chromium.org Change-Id: Id6586e32a8bfc712bd1425a9dbe1b6997ba880d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577629 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653295} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 4b79b21fdcfcf80edbfea62f38c8f8cac923b46e Author: Ken Buchanan <kenrb@chromium.org> Date: Tue Apr 23 19:02:02 2019 +0000 Expand transport reporting for WebAuthn MakeCredential and GetAssertion Add a histogram for authenticator transports used for MakeCredential calls from WebAuthentication, and expand GetAssertion to report both what authenticators are available at request time, as well as the transport used for a successful response. Bug: 803825 Change-Id: I94a748818bce38563bb1fc108a75ebdc0d17347b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574419 Commit-Queue: Ken Buchanan <kenrb@chromium.org> Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#653294} device/fido/get_assertion_request_handler.cc | 30 ++++++++++++++++----- device/fido/make_credential_request_handler.cc | 20 ++++++++++++++ tools/metrics/histograms/histograms.xml | 37 +++++++++++++++++++++++--- 3 files changed, 78 insertions(+), 9 deletions(-) commit 13849b1c420a5f78b103b76813b6520529a042a4 Author: danakj <danakj@chromium.org> Date: Tue Apr 23 19:01:52 2019 +0000 Remove unneeded reset of OnceCallback in bluetooth. Followup nit from https://chromium-review.googlesource.com/c/chromium/src/+/1574605 R=reillyg@chromium.org Bug: 953861 Change-Id: I10932e29c98e10e17bcb5996cd5fbac82a1cfab7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577993 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#653293} device/bluetooth/bluetooth_remote_gatt_descriptor_android.cc | 1 - 1 file changed, 1 deletion(-) commit 8bbb51ef385345d0791e88eb721aeaf3cb735d14 Author: sczs <sczs@chromium.org> Date: Tue Apr 23 18:56:21 2019 +0000 [ios] Creates InfobarPasswordDelegate strings for ModalInfobar. - Adds GetInfobarModalTitleText() as a virtual method to the parent password InfobarDelegate class to populate the InfobarModal title. - Updates the UpdatePasswordDelegate to return an empty string for GetButtonLabel for the Cancel button when the Infobar flag is enabled. This was hitting a DCHECK. - Creates "Never for this Site String". - Small UI tweaks. Bug: 945478 Change-Id: I6fa0ec38d30220112d671174d23b197758b9235f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577842 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#653292} ios/chrome/app/strings/ios_strings.grd | 9 ++++++ .../ios_chrome_password_manager_infobar_delegate.h | 3 ++ ...ios_chrome_password_manager_infobar_delegate.mm | 6 ++++ .../ios_chrome_save_password_infobar_delegate.h | 3 ++ .../ios_chrome_save_password_infobar_delegate.mm | 19 +++++++++++-- .../ios_chrome_update_password_infobar_delegate.h | 3 ++ .../ios_chrome_update_password_infobar_delegate.mm | 16 +++++++++-- .../coordinators/infobar_password_coordinator.mm | 4 +-- ios/chrome/browser/ui/infobars/modals/BUILD.gn | 1 + .../infobar_password_table_view_controller.h | 2 +- .../infobar_password_table_view_controller.mm | 32 ++++++++++++++-------- .../cells/table_view_text_button_item.mm | 2 +- 12 files changed, 80 insertions(+), 20 deletions(-) commit a4120a2b91166a69398889aa825ef3193407786f Author: Alex Cooper <alcooper@chromium.org> Date: Tue Apr 23 18:55:31 2019 +0000 Refactor WMR Input COM Calls into wrapper classes In order to test Windows Mixed Reality, there needs to be a place to add calls to the VR Test Hooks. Currently, the direct calls to COM are not mockable or easily replaced. By creating a simple wrapper for the COM calls, this change creates places for the test hooks to be added, while also cleaning up the code to make it more readable. This change creates a ~1:1 mapping with the underlying COM classes, with exceptions made for very simple classes/structs which are only exposed from one class (see mixed_reality_input_state for examples). Where a ".As" call may fail, and a reasonable default can be assumed, that reasonable default is returned. If a ".As" calls failure results in a method with no reasonable default able to be returned, a dcheck is used. Bug: 954413 Change-Id: I46440798aac0941b6a500ac0b829ae053d8b9ace Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574284 Reviewed-by: Klaus Weidner <klausw@chromium.org> Reviewed-by: Bill Orr <billorr@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#653291} device/vr/BUILD.gn | 12 + .../mixed_reality_input_helper.cc | 347 +++++---------------- .../mixed_reality_input_helper.h | 15 +- .../wrappers/wmr_input_location.cc | 86 +++++ .../wrappers/wmr_input_location.h | 50 +++ .../wrappers/wmr_input_manager.cc | 82 +++++ .../wrappers/wmr_input_manager.h | 46 +++ .../wrappers/wmr_input_source.cc | 71 +++++ .../wrappers/wmr_input_source.h | 49 +++ .../wrappers/wmr_input_source_state.cc | 163 ++++++++++ .../wrappers/wmr_input_source_state.h | 74 +++++ .../wrappers/wmr_pointer_pose.cc | 67 ++++ .../wrappers/wmr_pointer_pose.h | 46 +++ .../wrappers/wmr_pointer_source_pose.cc | 50 +++ .../wrappers/wmr_pointer_source_pose.h | 41 +++ 15 files changed, 923 insertions(+), 276 deletions(-) commit 08ff8a6f8660f3f5f2ca827d8be5397c09a63c87 Author: John Budorick <jbudorick@chromium.org> Date: Tue Apr 23 18:55:13 2019 +0000 perf: harden benchmark_log.txt handling. This CL ensures that process_perf_results doesn't fail in the event that benchmark_log.txt doesn't exist for a benchmark. It also cleans up some unnecessary system function (vs module) imports. Bug: 861983,807273 Change-Id: I0517248b465f7de498fed9588aa852c82fc9c5f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577985 Reviewed-by: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#653290} tools/perf/process_perf_results.py | 34 ++++++++++++++--------------- tools/perf/process_perf_results_unittest.py | 33 +++++++++++++++++++++++++++- 2 files changed, 48 insertions(+), 19 deletions(-) commit c3d0a653b14e19b0f0ab0b0580147805942ff27b Author: Jesse Schettler <jschettler@chromium.org> Date: Tue Apr 23 18:49:24 2019 +0000 arc: Add print-spooler-experiment feature flag BUG=b:130798103 TEST=android-sh -c getprop | grep ro.boot.arc_print_spooler Change-Id: Id2be21854b15f4fed6b398daed026ea01f4f7934 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574198 Reviewed-by: Yusuke Sato <yusukes@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#653289} chrome/browser/about_flags.cc | 4 ++++ chrome/browser/flag-metadata.json | 5 +++++ chrome/browser/flag_descriptions.cc | 5 +++++ chrome/browser/flag_descriptions.h | 3 +++ components/arc/arc_features.cc | 4 ++++ components/arc/arc_features.h | 1 + components/arc/session/arc_session_impl.cc | 2 ++ tools/metrics/histograms/enums.xml | 2 ++ 8 files changed, 26 insertions(+) Updated tag 'tree_truth' (was 26ca6b930af4)