Back to build
Raw log | Switch to full mode | Login

/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh /b/swarming/w/ir/cache/builder/src src in dir /b/swarming/w/ir/k: allow_subannotations: False cmd: ['/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh', '/b/swarming/w/ir/cache/builder/src', 'src'] env: {'CHROME_HEADLESS': '1'} env_prefixes: {} env_suffixes: {} infra_step: False name_tokens: ('tree truth steps',) ok_ret: frozenset([0]) trigger_specs: () full environment: ADDRFAM: inet BOTO_CONFIG: /b/swarming/w/ir/tmp/gsutil-task/.boto BUILDBUCKET_EXPERIMENTAL: FALSE CHROME_HEADLESS: 1 CIPD_CACHE_DIR: /b/swarming/cipd_cache/cache CIPD_PROTOCOL: v2 DEVSHELL_CLIENT_PORT: 45273 DOCKER_CONFIG: /b/swarming/w/ir/tmp/docker-cfg-task DOCKER_TMPDIR: /b/swarming/w/ir/tmp/docker-tmp-task GIT_CONFIG_NOSYSTEM: 1 GIT_TERMINAL_PROMPT: 0 HOME: /home/chrome-bot IFACE: eth0 INFRA_GIT_WRAPPER_HOME: /b/swarming/w/ir/tmp/git-home-task LOGDOG_COORDINATOR_HOST: logs.chromium.org LOGDOG_STREAM_PREFIX: buildbucket/cr-buildbucket.appspot.com/8915269552785211872 LOGDOG_STREAM_PROJECT: chromium LOGDOG_STREAM_SERVER_PATH: unix:/b/swarming/w/ir/tmp/ld.sock LOGICAL: eth0 LUCI_CONTEXT: /b/swarming/w/ir/tmp/luci_context.667169355 MAC_CHROMIUM_TMPDIR: /b/swarming/w/ir/tmp/t METHOD: dhcp NO_GCE_CHECK: False PATH: /b/swarming/w/ir/cipd_bin_packages:/b/swarming/w/ir/cipd_bin_packages/bin:/b/swarming/cipd_cache/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin PWD: /b/swarming/w/ir/k PYTHONIOENCODING: UTF-8 PYTHONUNBUFFERED: 1 ROOT_SETUP_LOG: /var/log/messages/chromebuild/root-setup.log SHLVL: 1 STARTUP_LOG: /var/log/messages/chromebuild/startup.log SWARMING_BOT_ID: swarm2398-c4 SWARMING_EXTERNAL_BOT_SETUP: 1 SWARMING_HEADLESS: 1 SWARMING_SERVER: https://chromium-swarm.appspot.com SWARMING_TASK_ID: 4469993e82bd2a11 TEMP: /b/swarming/w/ir/tmp/t TEMPDIR: /b/swarming/w/ir/tmp/t TERM: linux TMP: /b/swarming/w/ir/tmp/t TMPDIR: /b/swarming/w/ir/tmp/t UPSTART_EVENTS: net-device-up UPSTART_INSTANCE: UPSTART_JOB: chromebuild-startup USER: chrome-bot USERNAME: chrome-bot VPYTHON_VIRTUALENV_ROOT: /b/swarming/w/ir/cache/vpython _: /b/swarming/w/ir/cipd_bin_packages/vpython !@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: 43d5695828d744e24ad8a3ef8538b848ddfa624f Roll src/third_party/depot_tools 0d8271895be7..323487161e02 (1 commits) chromium-autoroll, Wed Apr 24 17:55:13 2019 +0000 ce3df784ce6136f8565b77bad02c8548664784be Revert "Android: Compile .proto and .arsc resources at the same time" Andrew Grieve, Wed Apr 24 17:55:06 2019 +0000 9aa52f73a834d78626ee648b6c7250ba10a12429 [AW NS] Fix crash: execute error callback and early-out when io_thread_client is null. Tim Volodine, Wed Apr 24 17:52:16 2019 +0000 1d73b8627604a61a69d4417d9b210d5c14d60308 cros: Reset the AppListView focus when it is reshown Alex Newcomer, Wed Apr 24 17:48:10 2019 +0000 cf5d5d8241a8d5054a18dd0554221b22892c845e Convert test to QuitClosure Sean Kau, Wed Apr 24 17:47:32 2019 +0000 fec5ba94d26feb50d9543e39cfca3aeec7e302ad Roll src/third_party/skia 82de21cb71c0..c0bd9f9fe533 (6 commits) chromium-autoroll, Wed Apr 24 17:46:48 2019 +0000 9c325777b17a3884e1e80c461e3e4aed01a5468a [Sync::USS] Deprecate ConflictResolution::USE_NEW Mohamed Amir Yosef, Wed Apr 24 17:43:18 2019 +0000 214e68160e5022109e4d08b7d2dcbf80c4b91a79 arc: Disable Custom Tabs when SPM is disabled Ryo Hashimoto, Wed Apr 24 17:42:36 2019 +0000 25d80f4bead925c2d9071b59a4f32146432d3e9e [LayoutNG] Reduce re-shape/NeedsCollectInlines to only when needed Koji Ishii, Wed Apr 24 17:39:53 2019 +0000 839c86b54de7b7fff9dd942f7e229c7ed0e455e2 Remove PowerManagerClient::WaitForServiceToBecomeAvailable() Evan Stade, Wed Apr 24 17:36:28 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit 43d5695828d744e24ad8a3ef8538b848ddfa624f Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 24 17:55:13 2019 +0000 Roll src/third_party/depot_tools 0d8271895be7..323487161e02 (1 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0d8271895be7..323487161e02 git log 0d8271895be7..323487161e02 --date=short --no-merges --format='%ad %ae %s' 2019-04-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@323487161e02 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I2b7ea07dba0ff16355630e55769525fcdb2d993e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582270 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653654} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit ce3df784ce6136f8565b77bad02c8548664784be Author: Andrew Grieve <agrieve@chromium.org> Date: Wed Apr 24 17:55:06 2019 +0000 Revert "Android: Compile .proto and .arsc resources at the same time" This reverts commit 697c9ab8d50ce3fa36199e4384b4c746855ebd29. Reason for revert: Broke resource_sizes.py Original change's description: > Android: Compile .proto and .arsc resources at the same time > > Saves a couple of seconds of build time for base bundle modules, > and simplifies the GN logic for resources. > > Also fixes chrome_apk using unoptimized arsc file when lemon is > enabled (broken by 2e296d8250295c3c07da06cbe3053fd0e4a869af). > > Simplifies temp file usage in compile_resources.py by having all > outputs go to the staging directory. > > Removes cruft: > * Unused --no-compress flag > * Unnecessary "Touch()" of R.txt > > Bug: 950233 > Change-Id: Ida77380e8038002435ec3d320105d9feaa3c2136 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568568 > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#653275} TBR=agrieve@chromium.org,tiborg@chromium.org Change-Id: I76bd9cf76b357156efa2848613ab576486d18476 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 950233, 955959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581988 Reviewed-by: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#653653} build/android/gyp/compile_resources.py | 348 +++++++++++++++------------- build/android/gyp/create_size_info_files.py | 7 +- build/android/gyp/util/resource_utils.py | 14 +- build/android/gyp/write_build_config.py | 5 +- build/config/android/internal_rules.gni | 149 +++++------- build/config/android/rules.gni | 101 ++++---- 6 files changed, 318 insertions(+), 306 deletions(-) commit 9aa52f73a834d78626ee648b6c7250ba10a12429 Author: Tim Volodine <timvolodine@chromium.org> Date: Wed Apr 24 17:52:16 2019 +0000 [AW NS] Fix crash: execute error callback and early-out when io_thread_client is null. Make sure to prevent crashes when io_thread_client is null, at the time when InterceptedRequest::Restart is called. There is a small amount of crash reports, see crbug.com/953584, which indicate this case could arise in special cases. BUG=953584,841556 Cq-Include-Trybots: luci.chromium.try:android_mojo Change-Id: I958fa4d622125a2d54ef99aee83a598f4cf46be5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578751 Reviewed-by: Richard Coles <torne@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#653652} .../browser/network_service/aw_proxying_url_loader_factory.cc | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) commit 1d73b8627604a61a69d4417d9b210d5c14d60308 Author: Alex Newcomer <newcomer@chromium.org> Date: Wed Apr 24 17:48:10 2019 +0000 cros: Reset the AppListView focus when it is reshown When the top window is deactivated, the AppListView is shown without any preparation. Fix this by resetting the focus and switching to the first page. Bug: 951586 Change-Id: I4a39dc503cf6cbee32cf60d29026eac10f3dc84d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576142 Auto-Submit: Alex Newcomer <newcomer@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#653651} ash/app_list/presenter/app_list_presenter_impl.cc | 1 + ash/app_list/views/app_list_view.cc | 10 ++++++++++ ash/app_list/views/app_list_view.h | 3 +++ 3 files changed, 14 insertions(+) commit cf5d5d8241a8d5054a18dd0554221b22892c845e Author: Sean Kau <skau@chromium.org> Date: Wed Apr 24 17:47:32 2019 +0000 Convert test to QuitClosure Use a QuitClosure instead of RunUntilIdle in the CupsPrintersHandlerTest. Test started failing if CupsPrinterManager creation was delayed. Bug: 954623 Change-Id: I0ce986ce0995f678197b88c06186737ab56787aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579325 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#653650} .../chromeos/cups_printers_handler_unittest.cc | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) commit fec5ba94d26feb50d9543e39cfca3aeec7e302ad Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 24 17:46:48 2019 +0000 Roll src/third_party/skia 82de21cb71c0..c0bd9f9fe533 (6 commits) https://skia.googlesource.com/skia.git/+log/82de21cb71c0..c0bd9f9fe533 git log 82de21cb71c0..c0bd9f9fe533 --date=short --no-merges --format='%ad %ae %s' 2019-04-24 mtklein@google.com rewrite includes to not need so much -Ifoo 2019-04-24 halcanary@google.com SkTInternalLList: remove SkPtrWrapper, SkNoncopyable 2019-04-24 robertphillips@google.com Implement alternate method for determining recycle-ability of allocated GrSurfaces (take 2) 2019-04-24 mtklein@google.com move SK_ENABLE_DISCRETE_GPU to cover only tools 2019-04-24 bsalomon@google.com Use tasks for GrVkGpuTextureCommandBuffer. 2019-04-24 reed@google.com rm older api from colormatrix, change to normalized translate Created with: gclient setdep -r src/third_party/skia@c0bd9f9fe533 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@chromium.org Change-Id: I51f18ade9656b86ac12ac276bd0736cbbdc5d67d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582264 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653649} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 9c325777b17a3884e1e80c461e3e4aed01a5468a Author: Mohamed Amir Yosef <mamir@chromium.org> Date: Wed Apr 24 17:43:18 2019 +0000 [Sync::USS] Deprecate ConflictResolution::USE_NEW Almost all data types have been migrated USS and yet USE_NEW conflict resolution has never been used. It's now deprecated in this CL, and we should bring it back if needed. This would unblock an upcoming clean up to remove EntityData.Clone() method. TBR=stevenjb@chromium.org Bug: 953281 Change-Id: Ic5469ffafceccd90fd279242c19ed20f8b512510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577419 Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#653648} .../chromeos/printing/printers_sync_bridge.cc | 6 +-- .../test/integration/two_client_uss_sync_test.cc | 16 +++---- components/sync/BUILD.gn | 1 - components/sync/model/conflict_resolution.cc | 43 ------------------ components/sync/model/conflict_resolution.h | 51 +++++---------------- .../sync/model/fake_model_type_sync_bridge.cc | 6 +-- .../sync/model/fake_model_type_sync_bridge.h | 2 +- components/sync/model/model_type_sync_bridge.cc | 4 +- components/sync/model/model_type_sync_bridge.h | 2 +- .../sync/model/model_type_sync_bridge_unittest.cc | 23 +++++----- .../client_tag_based_model_type_processor.cc | 45 +++++++------------ .../client_tag_based_model_type_processor.h | 8 ++-- ...ient_tag_based_model_type_processor_unittest.cc | 52 ++++------------------ .../model_impl/syncable_service_based_bridge.cc | 6 +-- components/sync/nigori/nigori_sync_bridge_impl.cc | 2 +- .../nigori/nigori_sync_bridge_impl_unittest.cc | 1 + .../bookmark_remote_updates_handler.cc | 20 ++++----- .../bookmark_remote_updates_handler_unittest.cc | 12 ++--- 18 files changed, 83 insertions(+), 217 deletions(-) commit 214e68160e5022109e4d08b7d2dcbf80c4b91a79 Author: Ryo Hashimoto <hashimoto@chromium.org> Date: Wed Apr 24 17:42:36 2019 +0000 arc: Disable Custom Tabs when SPM is disabled BUG=955035 TEST=Manually verify that Custom Tabs is disabled when SPM is disabled Change-Id: I64edf464a3ab54f83460395e1c85f8febdc10f93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580996 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#653647} components/arc/DEPS | 2 +- components/arc/session/arc_session_impl.cc | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) commit 25d80f4bead925c2d9071b59a4f32146432d3e9e Author: Koji Ishii <kojii@chromium.org> Date: Wed Apr 24 17:39:53 2019 +0000 [LayoutNG] Reduce re-shape/NeedsCollectInlines to only when needed This patch checks which CSS properties were changed to determine whether NeedsCollectInlines and/or re-shaping is needed. Following r651389 (CL:1554210) this change reduces cases where PrepareLayout/NeedsCollectInlines are needed to re-run. Bug: 636993 Change-Id: Ie0fa4e10b16860c8caecc22f767d408c231eba40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1567555 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#653646} .../blink/renderer/core/layout/layout_inline.cc | 3 +- .../blink/renderer/core/layout/layout_text.cc | 4 +- .../core/layout/ng/inline/ng_inline_node_test.cc | 4 +- .../renderer/core/layout/ng/layout_ng_mixin.cc | 4 +- .../blink/renderer/core/style/computed_style.cc | 16 ++++++ .../core/style/computed_style_diff_functions.json5 | 61 +++++++++++++--------- .../blink/renderer/core/style/style_difference.cc | 3 ++ .../blink/renderer/core/style/style_difference.h | 17 ++++-- .../renderer/core/style/style_difference_test.cc | 5 ++ 9 files changed, 79 insertions(+), 38 deletions(-) commit 839c86b54de7b7fff9dd942f7e229c7ed0e455e2 Author: Evan Stade <estade@chromium.org> Date: Wed Apr 24 17:36:28 2019 +0000 Remove PowerManagerClient::WaitForServiceToBecomeAvailable() Replace with PowerManagerClient::Observer::PowerManagerBecameAvailable() This should make it easier to support for the Mojo PowerManagerClient. Bug: 644348 Change-Id: I5c18e76eb34929a43769b6206ed16e8bc7fca4bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574681 Reviewed-by: Jia Meng <jiameng@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#653645} .../power/auto_screen_brightness/adapter.cc | 44 ++++++++-------------- .../power/auto_screen_brightness/adapter.h | 26 +++++-------- .../auto_screen_brightness/adapter_unittest.cc | 4 +- .../brightness_monitor_impl.cc | 38 +++++++++---------- .../brightness_monitor_impl.h | 5 ++- .../brightness_monitor_impl_unittest.cc | 1 + .../power/auto_screen_brightness/controller.cc | 6 +-- chromeos/dbus/power/fake_power_manager_client.cc | 7 +--- chromeos/dbus/power/fake_power_manager_client.h | 2 - chromeos/dbus/power/power_manager_client.cc | 20 +++++++--- chromeos/dbus/power/power_manager_client.h | 9 +++-- .../dbus/power/power_manager_client_unittest.cc | 17 ++++++--- .../power/public/cpp/power_manager_mojo_client.cc | 4 +- .../power/public/cpp/power_manager_mojo_client.h | 2 - 14 files changed, 86 insertions(+), 99 deletions(-) commit 62be31e85c3e4a7049690cb043c057b07e4703f1 Author: A Olsen <olsen@chromium.org> Date: Wed Apr 24 17:32:41 2019 +0000 Use source absolute paths in JS tests Source absolute paths //a/b/c are now supported, so no need to use ../../../../../a/b/c This migrates several tests where it is an easy change. Change-Id: Ia7a8ba50a20a9b218e4b271c25449e3064148e55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578616 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Commit-Queue: A Olsen <olsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#653644} .../test/data/webui/bluetooth_internals_browsertest.js | 15 ++++++--------- .../test/data/webui/chromeos/fake_networking_private.js | 2 +- .../webui/engagement/site_engagement_browsertest.js | 5 ++--- .../data/webui/interventions_internals_browsertest.js | 13 +++++-------- .../data/webui/media/media_engagement_browsertest.js | 5 ++--- .../webui/settings/settings_idle_load_browsertest.js | 4 +--- .../webui/sys_internals/sys_internals_browsertest.js | 7 +++---- chrome/test/data/webui/usb_internals_browsertest.js | 17 +++++++---------- .../test/data/webui/webui_resource_async_browsertest.js | 11 ++++------- 9 files changed, 31 insertions(+), 48 deletions(-) commit db66b204363a568d1d63df5ccdf40a2588f4aa40 Author: Eric Roman <eroman@chromium.org> Date: Wed Apr 24 17:30:02 2019 +0000 Remove histogram BrotliFilter.GzipHeaderDetected. Change-Id: Ib1725cf8380468329bcafc3f6d462b081f1e1526 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579462 Reviewed-by: Matt Mueller <mattm@chromium.org> Reviewed-by: Brian White <bcwhite@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#653643} net/filter/brotli_source_stream.cc | 18 +----------------- tools/metrics/histograms/histograms.xml | 5 ++++- 2 files changed, 5 insertions(+), 18 deletions(-) commit 6d3804d8cdfd66ea1c343e7c930feb708dbe1d36 Author: Ben Chan <benchan@chromium.org> Date: Wed Apr 24 17:26:31 2019 +0000 chromeos: remove WiMAX debugging mode in chrome://net-internals/#chromeos WiMAX support on Chrome OS has been deprecated along with daisy. This CL removes the button to set WiMAX debugging mode on chrome://net-internals/#chromeos. Bug: 954635 Test: Verify that chrome://net-internals/#chromeos no longer shows a 'WiMAX' button. Change-Id: Ia754b6aefcdb3ccdc976061038a004cc69171498 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580903 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Ben Chan <benchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#653642} chrome/browser/resources/net_internals/chromeos_view.html | 3 --- chrome/browser/resources/net_internals/chromeos_view.js | 4 ---- 2 files changed, 7 deletions(-) commit a2f777032a2745c4ce1246a8b40dc64e745b9d8a Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Wed Apr 24 17:26:07 2019 +0000 Roll src-internal 2635a51a68a1..07ff5e7b4122 (3 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2635a51a68a1..07ff5e7b4122 Created with: gclient setdep -r src-internal@07ff5e7b4122 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:955935 TBR=cmumford@chromium.org,gab@chromium.org,droger@chromium.org Change-Id: Id1d09ef363706d5770b985838d7fbf43e38fe342 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582444 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by: Chris Mumford <cmumford@google.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653641} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit ee2c57dfe5f613e735ad96d0ac2d7ba534b34486 Author: Justin DeWitt <dewittj@chromium.org> Date: Wed Apr 24 17:25:24 2019 +0000 [EoS] Add additional padding at the bottom tile text for touchless. This gives some space beneath the text for the focus ring. Bug: 935795 Change-Id: I6b6f2a9165814f4d376ad0f5d133c975f3cc0142 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579701 Reviewed-by: Matthew Jones <mdjones@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#653640} chrome/android/java/res/layout/explore_sites_tile_view_condensed.xml | 1 + chrome/android/java/res/values/dimens.xml | 1 + 2 files changed, 2 insertions(+) commit 862caf28837e21bcf5ef15c15ab4ff4bd3b9f4ac Author: Rune Lillesveen <futhark@chromium.org> Date: Wed Apr 24 17:21:57 2019 +0000 Move DarkModeObserver to ui/native_theme In preparation for using the observer in WebContentsImpl, make it available for content/. Bug: 889087 Change-Id: Iff4dbfae5525c6bae1655662d5f29208a024da28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574802 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Ramya Nagarajan <ramyan@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#653639} chrome/browser/search/instant_service.cc | 4 ++-- chrome/browser/search/instant_service.h | 7 +++++-- chrome/browser/ui/BUILD.gn | 2 -- chrome/browser/ui/webui/dark_mode_handler.h | 4 ++-- chrome/browser/ui/webui/ntp/new_tab_ui.h | 4 ++-- ui/native_theme/BUILD.gn | 2 ++ .../ui => ui/native_theme}/dark_mode_observer.cc | 10 +++++++--- .../ui => ui/native_theme}/dark_mode_observer.h | 22 +++++++++++++--------- 8 files changed, 33 insertions(+), 22 deletions(-) commit e48a4ebc172d788832b4f95cf9d526b1c2caecc4 Author: Mohamed Amir Yosef <mamir@chromium.org> Date: Wed Apr 24 17:21:30 2019 +0000 [Sync::USS] Report UMA metrics when Applying remote sync changes Bug: 956011 Change-Id: I537118020a14ed0883fab998293c34a5555a7c63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581582 Reviewed-by: Brian White <bcwhite@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#653638} .../core/browser/password_manager_metrics_util.cc | 4 ++++ .../core/browser/password_manager_metrics_util.h | 14 ++++++++++++++ .../core/browser/sync/password_sync_bridge.cc | 10 ++++++++++ tools/metrics/histograms/enums.xml | 8 ++++++++ tools/metrics/histograms/histograms.xml | 11 +++++++++++ 5 files changed, 47 insertions(+) commit 57a6dd2ad4984f40632274dfa9f180050e356768 Author: Anastasia Helfinstein <anastasi@google.com> Date: Wed Apr 24 17:20:52 2019 +0000 [Switch Access] Setup string localization Add a new strings.grd file (and surrounding infrastructure) for Switch Access, following the pattern used Select-to-speak and ChromeVox (other component extensions). Bug: 864835 Change-Id: I84ebe33ff31e007357df14d67e4a70b516ae9e3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574882 Reviewed-by: Robert Flack <flackr@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#653637} .../resources/chromeos/switch_access/BUILD.gn | 1 + .../chromeos/switch_access/manifest.json.jinja2 | 5 +- .../chromeos/switch_access/strings/BUILD.gn | 73 ++++++++++++ .../strings/switch_access_strings.grd | 127 +++++++++++++++++++++ .../strings/switch_access_strings_am.xtb | 4 + .../strings/switch_access_strings_ar.xtb | 4 + .../strings/switch_access_strings_bg.xtb | 4 + .../strings/switch_access_strings_bn.xtb | 4 + .../strings/switch_access_strings_ca.xtb | 4 + .../strings/switch_access_strings_cs.xtb | 4 + .../strings/switch_access_strings_da.xtb | 4 + .../strings/switch_access_strings_de.xtb | 4 + .../strings/switch_access_strings_el.xtb | 4 + .../strings/switch_access_strings_en-GB.xtb | 4 + .../strings/switch_access_strings_es-419.xtb | 4 + .../strings/switch_access_strings_es.xtb | 4 + .../strings/switch_access_strings_et.xtb | 4 + .../strings/switch_access_strings_fa.xtb | 4 + .../strings/switch_access_strings_fi.xtb | 4 + .../strings/switch_access_strings_fil.xtb | 4 + .../strings/switch_access_strings_fr.xtb | 4 + .../strings/switch_access_strings_gu.xtb | 4 + .../strings/switch_access_strings_hi.xtb | 4 + .../strings/switch_access_strings_hr.xtb | 4 + .../strings/switch_access_strings_hu.xtb | 4 + .../strings/switch_access_strings_id.xtb | 4 + .../strings/switch_access_strings_it.xtb | 4 + .../strings/switch_access_strings_iw.xtb | 4 + .../strings/switch_access_strings_ja.xtb | 4 + .../strings/switch_access_strings_kn.xtb | 4 + .../strings/switch_access_strings_ko.xtb | 4 + .../strings/switch_access_strings_lt.xtb | 4 + .../strings/switch_access_strings_lv.xtb | 4 + .../strings/switch_access_strings_ml.xtb | 4 + .../strings/switch_access_strings_mr.xtb | 4 + .../strings/switch_access_strings_ms.xtb | 4 + .../strings/switch_access_strings_nl.xtb | 4 + .../strings/switch_access_strings_no.xtb | 4 + .../strings/switch_access_strings_pl.xtb | 4 + .../strings/switch_access_strings_pt-BR.xtb | 4 + .../strings/switch_access_strings_pt-PT.xtb | 4 + .../strings/switch_access_strings_ro.xtb | 4 + .../strings/switch_access_strings_ru.xtb | 4 + .../strings/switch_access_strings_sk.xtb | 4 + .../strings/switch_access_strings_sl.xtb | 4 + .../strings/switch_access_strings_sr.xtb | 4 + .../strings/switch_access_strings_sv.xtb | 4 + .../strings/switch_access_strings_sw.xtb | 4 + .../strings/switch_access_strings_ta.xtb | 4 + .../strings/switch_access_strings_te.xtb | 4 + .../strings/switch_access_strings_th.xtb | 4 + .../strings/switch_access_strings_tr.xtb | 4 + .../strings/switch_access_strings_uk.xtb | 4 + .../strings/switch_access_strings_vi.xtb | 4 + .../strings/switch_access_strings_zh-CN.xtb | 4 + .../strings/switch_access_strings_zh-TW.xtb | 4 + tools/gritsettings/translation_expectations.pyl | 1 + 57 files changed, 413 insertions(+), 2 deletions(-) commit 1da0a775c785f7f414865a72f1cc1f02153d5af2 Author: Wez <wez@chromium.org> Date: Wed Apr 24 17:20:23 2019 +0000 [Fuchsia] Migrate call-sites from rea2() back to read(). zx::channel::read() now has the correct parameter order, so migrate to that, to allow rea2() to be removed. TBR=kmarshall Bug: 953523 Change-Id: I622531739609c0dfb935d44416687d7eca9a9567 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582541 Reviewed-by: Wez <wez@chromium.org> Reviewed-by: Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#653636} build/fuchsia/fidlgen_js/runtime/zircon.cc | 4 ++-- build/fuchsia/fidlgen_js/test/fidlgen_js_unittest.cc | 8 ++++---- mojo/core/channel_fuchsia.cc | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) commit 4f02afe97c595cbddc1fa03f061ae39b6cfd3ccb Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Wed Apr 24 17:17:58 2019 +0000 flags: remove disable-eol-notifications This change also removes the backing switch. Bug: None Change-Id: I10085a4d123978afd5819abbf8aca0f20ee67874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582226 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#653635} chrome/browser/about_flags.cc | 5 ----- chrome/browser/chromeos/eol_notification.cc | 6 ------ chrome/browser/flag-metadata.json | 5 ----- chrome/browser/flag_descriptions.cc | 4 ---- chrome/browser/flag_descriptions.h | 3 --- chromeos/constants/chromeos_switches.cc | 3 --- chromeos/constants/chromeos_switches.h | 2 -- 7 files changed, 28 deletions(-) commit c9750cf304b633cf7417da0841d8c909f64b82d9 Author: inglorion <inglorion@chromium.org> Date: Wed Apr 24 17:16:29 2019 +0000 Remove luci.chromium.clang console The consoles luci.chromium.clang and chromium.clang are duplicates of each other. This change removes one. Change-Id: I7f56221ce505632122640c1c4687d44f9bc643ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580499 Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Bob Haarman <inglorion@chromium.org> Cr-Commit-Position: refs/heads/master@{#653634} infra/config/luci-milo.cfg | 221 --------------------------------------------- 1 file changed, 221 deletions(-) commit 1b67f0dfd8459de3d47749589bec813ab0b115d1 Author: Mohamed Amir Yosef <mamir@chromium.org> Date: Wed Apr 24 17:15:34 2019 +0000 [Sync::USS] Implement NigoriModelTypeProcessor::OnSyncStopping() Bug: 922900 Change-Id: Ic3642e9bdb97c40b866f04703e6dc56a95586a96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575939 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#653633} .../sync/nigori/nigori_model_type_processor.cc | 31 +++++++++++++++++++++- .../nigori/nigori_model_type_processor_unittest.cc | 28 +++++++++++++++++++ 2 files changed, 58 insertions(+), 1 deletion(-) commit f39674aa656ebcf0c5bf91b322b94965dbf60482 Author: Khushal <khushalsagar@chromium.org> Date: Wed Apr 24 17:09:34 2019 +0000 chrome/android: Minor feature availability check cleanup. R=dtrainor@chromium.org Change-Id: Id1e4a0b1ca30addc7c385659c95d7eb3ba11a753 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574949 Auto-Submit: Khushal <khushalsagar@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#653632} chrome/browser/android/compositor/compositor_view.cc | 9 +++++---- chrome/browser/android/compositor/compositor_view.h | 2 -- 2 files changed, 5 insertions(+), 6 deletions(-) commit 5f37c0d4235df9233741daac71657769d4c7c7e4 Author: Jeremy Roman <jbroman@chromium.org> Date: Wed Apr 24 17:08:09 2019 +0000 Use ASCII case conversion in ScriptLoader. No behavior change since "window", "onload" and "onload()" don't contain any sequences that could match (with Unicode case folding) a string that wouldn't also match with ASCII case folding alone. However, this is what the spec asks us to do, and it's more efficient anyhow. Bug: 627682 Change-Id: Id262e058658192f8177082a1ddb03746253a568b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578430 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#653631} third_party/blink/renderer/core/script/script_loader.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit 2f261183dab6a49e4a7a2539f904599d4c0d6a3b Author: Abhishek Arya <inferno@chromium.org> Date: Wed Apr 24 17:06:45 2019 +0000 Fix code coverage documentation. GN args don't work since debug build is not allowed with static build and symbol_level=2. We shouldn't be using debug build with code coverage config anyway, so correct the set of gn flags. Also, format python code. R=mmoroz@chromium.org,liaoyuke@chromium.org Change-Id: I86b5a6041baaec2065ff553d9debd0e0f4249c1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582269 Reviewed-by: Yuke Liao <liaoyuke@chromium.org> Reviewed-by: Max Moroz <mmoroz@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#653630} tools/code_coverage/coverage.py | 6 +++--- tools/code_coverage/run_fuzz_target.py | 12 +++++------- tools/code_coverage/update_clang_coverage_tools.py | 7 +++---- 3 files changed, 11 insertions(+), 14 deletions(-) commit 5df957f858965f7bd7bfb23b425967be493f3e0a Author: Dan Beam <dbeam@chromium.org> Date: Wed Apr 24 17:06:41 2019 +0000 Add presubmit to check that folks are adding optimized .svg files Bug: 954683 Change-Id: Id7b8d1da4a69c809de4c2cb943e49c61f77990d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552569 Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#653629} chrome/browser/resources/PRESUBMIT.py | 19 ++++++++++-- tools/resources/OWNERS | 4 +++ tools/resources/PRESUBMIT.py | 23 ++++++++++++++ tools/resources/__init__.py | 0 tools/resources/svgo.py | 26 ++++++++++++++++ tools/resources/svgo_presubmit.py | 26 ++++++++++++++++ tools/resources/svgo_presubmit_test.py | 55 ++++++++++++++++++++++++++++++++++ ui/webui/resources/PRESUBMIT.py | 30 +++++++++++++++---- 8 files changed, 176 insertions(+), 7 deletions(-) commit 650f7430b16a90c208ec08189f5eda86fe34796c Author: Nicolas Ouellet-payeur <nicolaso@chromium.org> Date: Wed Apr 24 17:05:40 2019 +0000 [Network annotations] Fix command-line for Google Sheets Python scripts aren't executable directly on Windows, so this adds 'python.exe' to argv, letting the script actually start running. Bug: 949382 Change-Id: Ie0d259d7c0c4dc2aab2ad012a0dd7fcb2616d71f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582319 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#653628} testing/scripts/test_traffic_annotation_auditor.py | 1 + 1 file changed, 1 insertion(+) commit 04a516d07684eddf2e841b656419a7cb50fdac3e Author: Avery Musbach <amusbach@chromium.org> Date: Wed Apr 24 17:05:35 2019 +0000 overview: Fade in close icons differently when a window becomes snapped The overview close icons shall fade in with special animation parameters when a window gets snapped (either activating split view or taking the place of a lone snapped window). These parameters are specified here: https://mccanny.users.x20web.corp.google.com/www/splitscreen-motion/index.html#window-drop Test: manual Bug: 934977 Change-Id: Ib678560f5b1be00fa6d69e848d476ad2f88f98fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570218 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by: Mitsuru Oshima (Slow 4/22-26) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#653627} ash/wm/overview/caption_container_view.cc | 10 +++ ash/wm/overview/caption_container_view.h | 10 +++ ash/wm/overview/overview_animation_type.h | 6 +- ash/wm/overview/overview_grid.cc | 9 +-- ash/wm/overview/overview_grid.h | 5 +- ash/wm/overview/overview_item.cc | 22 ++++-- ash/wm/overview/overview_item.h | 2 +- ash/wm/overview/overview_session.cc | 32 ++++++--- ash/wm/overview/overview_session.h | 6 +- ash/wm/overview/overview_window_drag_controller.cc | 82 +++++++++++++--------- ash/wm/overview/overview_window_drag_controller.h | 18 +++-- .../overview/scoped_overview_animation_settings.cc | 18 +++++ ash/wm/splitview/split_view_controller.cc | 13 +++- .../tablet_mode_window_drag_delegate.cc | 3 +- 14 files changed, 174 insertions(+), 62 deletions(-) commit 11ccdec155ce1d8b9731211f7f5dc57ed5126855 Author: Jiaqi Han <jiaqih@google.com> Date: Wed Apr 24 17:03:47 2019 +0000 EXO: Include linux-explicit-synchronization unconditionally Enable the linux-explicit-synchronization interface unconditionally for Chromecast to use it. Bug: b/127985537 Test: Build and run exo_unittests Change-Id: I76f190c204acd9331bb28e629fde2d37638ef5b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582049 Reviewed-by: Daniel Nicoara <dnicoara@chromium.org> Reviewed-by: Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Jiaqi Han <jiaqih@google.com> Cr-Commit-Position: refs/heads/master@{#653626} components/exo/wayland/BUILD.gn | 4 ++-- components/exo/wayland/server.cc | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) commit fb75bb8d81a3358c13a1e3edb162c5f72d64e20c Author: Ramin Halavati <rhalavati@chromium.org> Date: Wed Apr 24 17:02:34 2019 +0000 Add foreign file copy support to in-memory file system. To support copying files from on-disk file systems into in-memory file system, a new |CopyInForeignFile| function is added to |ObfuscatedFileUtilDelegate| and its sub-classes. Bug: 93417 Change-Id: Icabd57c4442adb3b3506e0154d35fe80c0afecb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569930 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Auto-Submit: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#653625} storage/browser/fileapi/obfuscated_file_util.cc | 31 +++++++++----- storage/browser/fileapi/obfuscated_file_util.h | 14 ++++--- .../fileapi/obfuscated_file_util_delegate.h | 5 +++ .../fileapi/obfuscated_file_util_disk_delegate.cc | 8 ++++ .../fileapi/obfuscated_file_util_disk_delegate.h | 5 +++ .../obfuscated_file_util_memory_delegate.cc | 49 ++++++++++++++++++++++ .../fileapi/obfuscated_file_util_memory_delegate.h | 5 +++ ...bfuscated_file_util_memory_delegate_unittest.cc | 46 ++++++++++++++++++++ .../fileapi/obfuscated_file_util_unittest.cc | 30 ++++++------- 9 files changed, 159 insertions(+), 34 deletions(-) commit 77f99d41a01db075784ab575b50cb1fe5f691928 Author: Mohamed Amir Yosef <mamir@chromium.org> Date: Wed Apr 24 17:02:30 2019 +0000 [Sync::USS] Implement NigoriModelTypeProcessor::OnCommitCompleted() Bug: 922900 Change-Id: Ib954f8d9e059ab86b19e77fcdf411b887a725014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576559 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#653624} .../sync/nigori/nigori_model_type_processor.cc | 18 ++- .../nigori/nigori_model_type_processor_unittest.cc | 133 +++++++++++++++++++++ 2 files changed, 149 insertions(+), 2 deletions(-) commit ab158835aa770827d8b51b9bc2236dcf0e5cbce1 Author: Shimi Zhang <ctzsm@chromium.org> Date: Wed Apr 24 17:00:56 2019 +0000 aw: Remove AwContents::FromID(int render_process_id, int render_view_id) This FromID() has no call site now. One should be able to get AwContents from WebContents or figure out WebContents from RenderFrameHost, since RenderViewHost is deprecated. Bug: 304341 Change-Id: I3bfe1a060318d7290a496f0d7a256dbbf290d2de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579860 Reviewed-by: Bo <boliu@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#653623} android_webview/browser/aw_contents.cc | 13 ------------- android_webview/browser/aw_contents.h | 4 ---- 2 files changed, 17 deletions(-) commit 12385dfaaae95f38ce4c4f6dc7d2ee9114112bb7 Author: Carlos Caballero <carlscab@google.com> Date: Wed Apr 24 17:00:11 2019 +0000 Add support for single threaded tests to ScopedTaskEnvironment Some tests might want to make sure that they run single threaded and thus do not want a ThreadPool to be initialized. Add a new trait to support this use case. Bug: 708584 Change-Id: I022fbb99780e2865eeba51b844aa70c55bedd1a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578564 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#653622} base/test/scoped_task_environment.cc | 39 +++++++++++++------ base/test/scoped_task_environment.h | 54 +++++++++++++++++++------- base/test/scoped_task_environment_unittest.cc | 56 ++++++++++++++++----------- 3 files changed, 101 insertions(+), 48 deletions(-) commit 60dcc26b91b1d20e5bacc738db0ee60922024a8e Author: Chris Hamilton <chrisha@chromium.org> Date: Wed Apr 24 16:59:51 2019 +0000 Add IPC handler program counter to PendingTask and TaskAnnotator. This adds an additional "always present" task backtrace frame that will correspond to the program counter of an IPC handler. This is always nullptr for now, but a further CL will instrument the generated IPC dispatch functions. BUG=950668 Change-Id: I45074c4961d157b0ef34b4313ddc04d271917f93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579271 Reviewed-by: Fran├žois Doray <fdoray@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#653621} base/pending_task.h | 10 +++ base/task/common/task_annotator.cc | 85 ++++++++++++++---- base/task/common/task_annotator.h | 19 +++- base/task/common/task_annotator_unittest.cc | 134 +++++++++++++++++++--------- 4 files changed, 189 insertions(+), 59 deletions(-) commit 3278a19384c42ac4bec6dcd05c66620746a9b9d3 Author: Mohamed Amir Yosef <mamir@chromium.org> Date: Wed Apr 24 16:55:40 2019 +0000 [Sync::USS] Implement NigoriModelTypeProcessor::OnUpdateReceived() Bug: 922900 Change-Id: Ic0c140f62697c5a6cdae2ec56204aadae8c3e3cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575938 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#653620} .../sync/nigori/nigori_model_type_processor.cc | 66 ++++++++++- .../nigori/nigori_model_type_processor_unittest.cc | 121 +++++++++++++++++++-- components/sync/nigori/nigori_sync_bridge.h | 2 +- components/sync/nigori/nigori_sync_bridge_impl.cc | 62 ++++++----- components/sync/nigori/nigori_sync_bridge_impl.h | 3 +- 5 files changed, 211 insertions(+), 43 deletions(-) commit bedabe88830f2af68ca456fcf0cf88afd45feca3 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 24 16:55:02 2019 +0000 Roll src/third_party/swiftshader 3c830834002a..4d1f8d05a85a (1 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/3c830834002a..4d1f8d05a85a git log 3c830834002a..4d1f8d05a85a --date=short --no-merges --format='%ad %ae %s' 2019-04-24 bclayton@google.com Reactor: Hook up atomic load/store intrinsics. Created with: gclient setdep -r src/third_party/swiftshader@4d1f8d05a85a The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: I4e09191cf072ea7892a822b67bf784ed54c9cb0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582460 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653619} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 2cc440a15fe9bdd882ed36b2a749b0fc9dee4b2e Author: sczs <sczs@chromium.org> Date: Wed Apr 24 16:54:33 2019 +0000 [ios] Creates TestPasswordManagerClient class. Moves MockPasswordManagerClient into its own class/file so it can be used to test the InfobarPasswordCoordinator. Bug: 945478 Change-Id: I55bb48ffcb0ce88205a0ebef6ba742e7ed667347 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580349 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#653618} ios/chrome/browser/passwords/BUILD.gn | 1 + .../passwords/credential_manager_unittest.mm | 111 +-------------------- ios/chrome/browser/passwords/test/BUILD.gn | 21 ++++ .../passwords/test/test_password_manager_client.h | 78 +++++++++++++++ .../passwords/test/test_password_manager_client.mm | 95 ++++++++++++++++++ 5 files changed, 198 insertions(+), 108 deletions(-) commit 5f53a799c1671b8c6ae6f8b22a86ff1a2d9ed0fc Author: Chromium WPT Sync <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Date: Wed Apr 24 16:53:57 2019 +0000 Import wpt@87f25e32dd166d6ba74b9daaa416bb75a120cbce Using wpt-import in Chromium e58e865ec235dcf518f8515cae2a3421565fb71a. With Chromium commits locally applied on WPT: 0a8f3ffa48 "Use testdriver Action API in WPT pointerevent touch tests - Part 2" 4e9215207a "[Code Health] Remove unnecessary reference file for web test" 40465b7400 "[Animation Worklet] Copy the effects of a migrating animator over to new global scope" e28269b698 "[LayoutNG/PE] Clear visual overflow for LayoutText before setting." aff3c8feca "Add tests for crbug.com/363609 and crbug.com/954591" 143d2905e8 "[WPT/common/security-features] Stop using assert_* from common.js" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I8d04e14c1bad9e593c99c19ad9b2105dad5d1128 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582046 Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653617} .../web_tests/external/WPT_BASE_MANIFEST_6.json | 78 +++++++++------------- .../web_tests/external/wpt/tools/lint/lint.py | 20 ++++-- .../web_tests/external/wpt/tools/lint/rules.py | 47 ++++++++++--- .../external/wpt/tools/manifest/XMLParser.py | 7 +- .../web_tests/external/wpt/tools/manifest/item.py | 7 +- .../external/wpt/tools/manifest/manifest.py | 11 ++- .../external/wpt/tools/manifest/sourcefile.py | 12 +++- .../external/wpt/tools/manifest/update.py | 2 +- .../web_tests/external/wpt/tools/manifest/vcs.py | 4 +- .../blink/web_tests/external/wpt/tools/mypy.ini | 25 +++++++ .../external/wpt/tools/requirements_mypy.txt | 3 + .../blink/web_tests/external/wpt/tools/tox.ini | 9 ++- .../web_tests/external/wpt/tools/wpt/testfiles.py | 2 +- 13 files changed, 152 insertions(+), 75 deletions(-) commit 1c4f5d24abe649fe73a63806c0bca3f4f788fdca Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 24 16:53:27 2019 +0000 Roll src/third_party/catapult 429d9b410d9c..a606a564b60f (1 commits) https://chromium.googlesource.com/catapult.git/+log/429d9b410d9c..a606a564b60f git log 429d9b410d9c..a606a564b60f --date=short --no-merges --format='%ad %ae %s' 2019-04-24 ulan@chromium.org Avoid spread operator in findToplevelSchedulerTasks Created with: gclient setdep -r src/third_party/catapult@a606a564b60f The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:953371 TBR=crouleau@chromium.org Change-Id: Ib4879209d3d6e951ffdbcf6059395c62cf610523 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582441 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653616} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 6b74293051788ed09575a858b099e5c3680cf136 Author: Torne (Richard Coles) <torne@google.com> Date: Wed Apr 24 16:52:51 2019 +0000 Allow overriding WebView/Trichrome app labels. Add an application_label variable to the WebView and TrichromeLibrary manifests so that the default application label can be overridden with a jinja variable. This will be used to differentiate channel builds. Bug: 954668 Change-Id: I9a18c7c9ae393f374713471a9103a812f2c0a104 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579660 Reviewed-by: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#653615} android_webview/apk/java/AndroidManifest.xml | 2 +- chrome/android/java/AndroidManifest_trichrome_library.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit 73a20b589ad4fa7e459335f8c8cc91321cc6792e Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 24 16:52:23 2019 +0000 Roll src/third_party/perfetto 6b4473dce4d7..85fd37e47245 (1 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/6b4473dce4d7..85fd37e47245 git log 6b4473dce4d7..85fd37e47245 --date=short --no-merges --format='%ad %ae %s' 2019-04-24 lalitm@google.com perfetto: fix Bazel build files Created with: gclient setdep -r src/third_party/perfetto@85fd37e47245 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ic124a1c7fcb03b83a271593fd40df528142a1eba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582440 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653614} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit dc720c10e72adcafe27fb463e3e3dead720240d2 Author: David Bokan <bokan@chromium.org> Date: Wed Apr 24 16:49:10 2019 +0000 Fix nullptr deref in Viewport::TotalScrollOffset Some APIs like SetSynchronousInputHandlerRootScrollOffset can call into this method during initialization/destruction when there is no inner viewport scroll offset. In these cases, it's fine to just return (0,0) rather than crashing. The linked bug was occuring because this early-out used to exist but was inadvertantly dropped in https://crrev.com/f93bf42468f108274e3ea97853679047465a8412 Bug: 952170 Change-Id: I73f7b9676df3a21a240aa4addee2dc12192f19f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579270 Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#653613} cc/layers/viewport.cc | 3 +++ cc/trees/layer_tree_host_impl_unittest.cc | 12 ++++++++++++ 2 files changed, 15 insertions(+) commit bb6be13ba9debc4e9c8a8522408644a65883a573 Author: dpapad <dpapad@chromium.org> Date: Wed Apr 24 16:41:24 2019 +0000 WebUI: Remove conditional logic only applying to Polymer 1. Polymer 1 support has been removed from individual WebUI pages. All Polymer 1 specific logic can finally be removed as well (except for chrome://resources). Removing the bulk of codepaths only applying to Polymer 1 in this CL, but there are a few more that are a bit more complicated and will be addressed separately. Bug: 944281 Change-Id: Iacc8678247673eb46cdeeab6f8105ae1e3b8e3fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577992 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#653612} chrome/browser/resources/downloads/item.js | 10 ++-------- chrome/browser/resources/downloads/manager.js | 20 +------------------- chrome/browser/resources/history/history.js | 8 +------- .../viewer-pen-options/viewer-pen-options.js | 10 ++-------- .../print_preview/new/destination_settings.js | 14 +++----------- .../settings/autofill_page/autofill_section.js | 6 +----- .../resources/settings/basic_page/basic_page.js | 22 ++++++++-------------- .../settings/bluetooth_page/bluetooth_subpage.js | 10 ---------- .../chromeos/os_settings_main/os_settings_main.js | 7 +------ .../chromeos/os_settings_page/os_settings_page.js | 22 ++++++++-------------- .../settings/controls/settings_dropdown_menu.js | 14 ++++---------- .../settings/controls/settings_idle_load.js | 22 ---------------------- .../settings/settings_main/settings_main.js | 7 +------ .../resources/settings/settings_page/BUILD.gn | 1 + .../settings/settings_page/main_page_behavior.js | 5 +---- .../settings_page/settings_animated_pages.js | 20 ++++++-------------- chrome/test/data/webui/settings/all_sites_tests.js | 13 ++++--------- .../test/data/webui/settings/autofill_page_test.js | 8 +++----- third_party/closure_compiler/externs/pending.js | 15 +++++++++++++++ 19 files changed, 62 insertions(+), 172 deletions(-) Updated tag 'tree_truth' (was 6eaf0af71262)