Back to build
Raw log | Switch to full mode | Login

/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh /b/swarming/w/ir/cache/builder/src src in dir /b/swarming/w/ir/k: allow_subannotations: False cmd: ['/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh', '/b/swarming/w/ir/cache/builder/src', 'src'] env: FrozenDict([('CHROME_HEADLESS', '1')]) env_prefixes: {'mapping': FrozenDict([]), 'pathsep': ':'} env_suffixes: {'mapping': FrozenDict([]), 'pathsep': ':'} infra_step: False name_tokens: ['tree truth steps'] ok_ret: frozenset([0]) trigger_specs: [] full environment: ADDRFAM: inet BOTO_CONFIG: /b/swarming/w/ir/tmp/gsutil-task/.boto BUILDBUCKET_EXPERIMENTAL: FALSE CHROME_HEADLESS: 1 CIPD_CACHE_DIR: /b/swarming/cipd_cache/cache CIPD_PROTOCOL: v2 DEVSHELL_CLIENT_PORT: 46378 DOCKER_CONFIG: /b/swarming/w/ir/tmp/docker-cfg-task DOCKER_TMPDIR: /b/swarming/w/ir/tmp/docker-tmp-task GIT_CONFIG_NOSYSTEM: 1 GIT_TERMINAL_PROMPT: 0 HOME: /home/chrome-bot IFACE: eth0 INFRA_GIT_WRAPPER_HOME: /b/swarming/w/ir/tmp/git-home-task LOGDOG_COORDINATOR_HOST: logs.chromium.org LOGDOG_STREAM_PREFIX: buildbucket/cr-buildbucket.appspot.com/8915257266564215664 LOGDOG_STREAM_PROJECT: chromium LOGDOG_STREAM_SERVER_PATH: unix:/b/swarming/w/ir/tmp/ld.sock LOGICAL: eth0 LUCI_CONTEXT: /b/swarming/w/ir/tmp/luci_context.763150378 MAC_CHROMIUM_TMPDIR: /b/swarming/w/ir/tmp/t METHOD: dhcp NO_GCE_CHECK: False PATH: /b/swarming/w/ir/cipd_bin_packages:/b/swarming/w/ir/cipd_bin_packages/bin:/b/swarming/cipd_cache/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin PWD: /b/swarming/w/ir/k PYTHONIOENCODING: UTF-8 PYTHONUNBUFFERED: 1 ROOT_SETUP_LOG: /var/log/messages/chromebuild/root-setup.log SHLVL: 1 STARTUP_LOG: /var/log/messages/chromebuild/startup.log SWARMING_BOT_ID: swarm98-c4 SWARMING_EXTERNAL_BOT_SETUP: 1 SWARMING_HEADLESS: 1 SWARMING_SERVER: https://chromium-swarm.appspot.com SWARMING_TASK_ID: 446a4c1ab7357411 TEMP: /b/swarming/w/ir/tmp/t TEMPDIR: /b/swarming/w/ir/tmp/t TERM: linux TMP: /b/swarming/w/ir/tmp/t TMPDIR: /b/swarming/w/ir/tmp/t UPSTART_EVENTS: net-device-up UPSTART_INSTANCE: UPSTART_JOB: chromebuild-startup USER: chrome-bot USERNAME: chrome-bot VPYTHON_VIRTUALENV_ROOT: /b/swarming/w/ir/cache/vpython _: /b/swarming/w/ir/cipd_bin_packages/vpython !@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: 9cb08398aaa4e5790ee7adc3fe74412e0b1761d6 Use more URL constants throughout content_unittests. Matt Siembor, Wed Apr 24 21:34:39 2019 +0000 807df7a1c414e3f5853a72e8b768757879ee91fc [Switch Access] Refactor constants file Anastasia Helfinstein, Wed Apr 24 21:33:24 2019 +0000 304819288d90716a881e92770a85daf6a652dfba [SendTabToSelf] Only send entries targeted to this device to observers. Sébastien Séguin-Gagnon, Wed Apr 24 21:31:00 2019 +0000 71443b765c223df90b2f3e6b5ba5005573bd7948 [Switch Access] Compile the menu panel Javascript code Anastasia Helfinstein, Wed Apr 24 21:29:59 2019 +0000 a6912d7d57db7cd8ea2c88b63a21849d373ac76b [omnibox] Add about:flag for OmniboxAlternateMatchDescriptionSeparator Tommy C. Li, Wed Apr 24 21:27:46 2019 +0000 11eb4fc4130e24e3180a3ffe107d4669eab8edb2 Android: Exclude DumpWithoutCrashing in metrics Peter Wen, Wed Apr 24 21:27:25 2019 +0000 8cf90323cb27a96508e453a638619b1395d08225 Improve navigation to restricted web sites on iOS 12.2 with slim-nav. Eugene But, Wed Apr 24 21:21:32 2019 +0000 04a758d7eec6d8c0e8c2337fbcf189a3edb6fe1c Improve readability for ContextualSearchFieldTrial Marcin Wiącek, Wed Apr 24 21:20:10 2019 +0000 f93cb72217be490b47baca01b4ead389f1f223d4 Avoid merging user cloud policies when merging multiple source policies Yann Dago, Wed Apr 24 21:20:02 2019 +0000 e0105d5fd7e69e552840aa3984cfe105cc277003 [Chromecast] VLOG -> DVLOG Ken MacKay, Wed Apr 24 21:18:25 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit 9cb08398aaa4e5790ee7adc3fe74412e0b1761d6 Author: Matt Siembor <msiembor@microsoft.com> Date: Wed Apr 24 21:34:39 2019 +0000 Use more URL constants throughout content_unittests. This change eliminates several dependencies on hardcoded URL strings thoughout test code in content_unittests. An already existing helper function, GetWebUIURL, was moved into test_utils.h/.cc and taken advantage of across several different test code files. Bug: 955562 Change-Id: I3405e5f6c70d3f605a6bc9764cadbb68a6670ccb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577851 Commit-Queue: Matt Siembor <msiembor@microsoft.com> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#653760} .../child_process_security_policy_unittest.cc | 21 ++++---- .../fileapi/browser_file_system_helper_unittest.cc | 3 +- .../render_frame_host_manager_unittest.cc | 58 +++++++++++----------- content/browser/site_instance_impl_unittest.cc | 12 ++--- .../web_contents/web_contents_impl_unittest.cc | 10 ++-- .../webui/url_data_manager_backend_unittest.cc | 20 ++++---- .../csp_source_list_unittest.cc | 11 ++-- content/public/common/DEPS | 3 ++ content/public/common/url_utils_unittest.cc | 5 +- content/public/test/test_utils.cc | 10 ++++ content/public/test/test_utils.h | 6 +++ 11 files changed, 89 insertions(+), 70 deletions(-) commit 807df7a1c414e3f5853a72e8b768757879ee91fc Author: Anastasia Helfinstein <anastasi@google.com> Date: Wed Apr 24 21:33:24 2019 +0000 [Switch Access] Refactor constants file Separating this out into its own changelist. In order to cleanly and clearly express the preferences available, we need to be able to append the Commands to the Preferences (as each command can have a switch associated with it). The language did not allow that with the previous construction. Bug: None Change-Id: I9166a91436b44479b6a656748190f412980fdd27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578238 Reviewed-by: Akihiro Ota <akihiroota@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#653759} .../resources/chromeos/switch_access/menu_panel.js | 2 +- .../chromeos/switch_access/navigation_manager.js | 12 +- .../switch_access/switch_access_constants.js | 234 +++++++++++---------- .../chromeos/switch_access/text_input_manager.js | 6 +- 4 files changed, 133 insertions(+), 121 deletions(-) commit 304819288d90716a881e92770a85daf6a652dfba Author: Sébastien Séguin-Gagnon <sebsg@chromium.org> Date: Wed Apr 24 21:31:00 2019 +0000 [SendTabToSelf] Only send entries targeted to this device to observers. Bug: 946224 Change-Id: I17725ea898f427c7b1cecb9a54da16a0b2be5f71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570925 Commit-Queue: sebsg <sebsg@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Reviewed-by: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#653758} chrome/browser/about_flags.cc | 5 ++ chrome/browser/flag-metadata.json | 5 ++ chrome/browser/flag_descriptions.cc | 5 ++ chrome/browser/flag_descriptions.h | 3 + components/send_tab_to_self/features.cc | 3 + components/send_tab_to_self/features.h | 4 ++ .../send_tab_to_self/send_tab_to_self_bridge.cc | 18 ++++- .../send_tab_to_self/send_tab_to_self_bridge.h | 1 + .../send_tab_to_self_bridge_unittest.cc | 77 ++++++++++++++++++++++ ios/chrome/browser/about_flags.mm | 4 ++ ios/chrome/browser/ios_chrome_flag_descriptions.cc | 5 ++ ios/chrome/browser/ios_chrome_flag_descriptions.h | 5 ++ tools/metrics/histograms/enums.xml | 2 + 13 files changed, 136 insertions(+), 1 deletion(-) commit 71443b765c223df90b2f3e6b5ba5005573bd7948 Author: Anastasia Helfinstein <anastasi@google.com> Date: Wed Apr 24 21:29:59 2019 +0000 [Switch Access] Compile the menu panel Javascript code Bug: None Change-Id: I742dc48de34bd7131e2da3dc1001a7b09f9a5053 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577593 Reviewed-by: Akihiro Ota <akihiroota@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#653757} chrome/browser/resources/chromeos/switch_access/BUILD.gn | 7 +++++++ chrome/browser/resources/chromeos/switch_access/menu_panel.js | 4 ++-- 2 files changed, 9 insertions(+), 2 deletions(-) commit a6912d7d57db7cd8ea2c88b63a21849d373ac76b Author: Tommy C. Li <tommycli@chromium.org> Date: Wed Apr 24 21:27:46 2019 +0000 [omnibox] Add about:flag for OmniboxAlternateMatchDescriptionSeparator Bug: 955585 Change-Id: Ifbb7814a2087c1a77f462836aabffbbe41a2e14e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581987 Reviewed-by: Orin Jaworski <orinj@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#653756} chrome/browser/about_flags.cc | 5 +++++ chrome/browser/flag-metadata.json | 15 ++++++++++----- chrome/browser/flag_descriptions.cc | 6 ++++++ chrome/browser/flag_descriptions.h | 3 +++ tools/metrics/histograms/enums.xml | 4 ++++ 5 files changed, 28 insertions(+), 5 deletions(-) commit 11eb4fc4130e24e3180a3ffe107d4669eab8edb2 Author: Peter Wen <wnwen@chromium.org> Date: Wed Apr 24 21:27:25 2019 +0000 Android: Exclude DumpWithoutCrashing in metrics Our current metrics and other platforms all exclude DumpWithoutCrashing counts from stability metrics since these are simulated crashes, not real user-facing crashes. This splits ProcessedMinidumps histogram in two, one counting all the non-simulated exceptions and one counting the simulated ones. Also adds an enum for the utility process. Bug: 894027 Change-Id: I46d2b2b4dc4d57e503761ceb87e7260204da60da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573661 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#653755} .../rewrite_minidumps_as_mimes.cc | 41 +++++++++++++++------- tools/metrics/histograms/histograms.xml | 30 ++++++++++++++++ 2 files changed, 59 insertions(+), 12 deletions(-) commit 8cf90323cb27a96508e453a638619b1395d08225 Author: Eugene But <eugenebut@google.com> Date: Wed Apr 24 21:21:32 2019 +0000 Improve navigation to restricted web sites on iOS 12.2 with slim-nav. iOS 12.2 has a bug where navigation to restricted websites does not work correctly (https://bugs.webkit.org/show_bug.cgi?id=196930). This CL works around multiple problems to the point where navigation to restricted web sites is usable (load restricted URLs from NTP, from another web page, reload and backforward navigation). There are still a few minor bugs that were not fixed by this CL: - DCHECK inside ErrorRetryStateMachine::DidFinishNavigation - Reload and Back - Forward navigation to restricted URLs create duplicate navigation items - Restricted website error is not displayed until page reload These are minor bugs which are hard to fix and probably not worth the efforts. Bug: 950488, 954332 Change-Id: I01642a5a69cbfe55373e35a65058fe7aa6706223 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577875 Reviewed-by: Justin Cohen <justincohen@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#653754} ios/web/web_state/ui/crw_web_controller.mm | 43 +++++++++++++++++++++++++++--- 1 file changed, 40 insertions(+), 3 deletions(-) commit 04a758d7eec6d8c0e8c2337fbcf189a3edb6fe1c Author: Marcin Wiącek <marcin@mwiacek.com> Date: Wed Apr 24 21:20:10 2019 +0000 Improve readability for ContextualSearchFieldTrial Improvement after https://chromium-review.googlesource.com/c/chromium/src/+/1565311 - making file a little bit shorter and more readable (different sorting entries, using switch, etc.) Change-Id: I64f71a8b15e211a11706ccb376b0474839a5ec92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579720 Reviewed-by: Donn Denman <donnd@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#653753} .../ContextualSearchFieldTrial.java | 116 ++++++++++----------- 1 file changed, 57 insertions(+), 59 deletions(-) commit f93cb72217be490b47baca01b4ead389f1f223d4 Author: Yann Dago <ydago@chromium.org> Date: Wed Apr 24 21:20:02 2019 +0000 Avoid merging user cloud policies when merging multiple source policies On desktop, the user cloud policy potentially comes from a different domain/administrator than e.g. GPO policy or machine-level cloud policy, so prevent merging user cloud policy with other policy sources. Note: In the future, merging may be allowed if an affiliation check is possible and says that the user cloud policy and machine-level cloud policy come from affiliated domains. Bug: 950068 Change-Id: Id0d77671d682802f84054acf92ac74b7fd63ad64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572700 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#653752} .../policy/core/common/policy_map_unittest.cc | 56 ++++++++++++++-------- components/policy/core/common/policy_merger.cc | 10 +++- 2 files changed, 46 insertions(+), 20 deletions(-) commit e0105d5fd7e69e552840aa3984cfe105cc277003 Author: Ken MacKay <kmackay@chromium.org> Date: Wed Apr 24 21:18:25 2019 +0000 [Chromecast] VLOG -> DVLOG Change-Id: I612e295ec393c6a614967eebffc189d2a6e0f0c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579369 Reviewed-by: Luke Halliwell <halliwell@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#653751} chromecast/base/cast_sys_info_android.cc | 2 +- chromecast/base/device_capabilities_impl.cc | 4 +- chromecast/base/error_codes.cc | 4 +- chromecast/base/path_utils.cc | 4 +- .../accessibility/touch_exploration_controller.cc | 65 +++++++++++----------- .../accessibility/touch_exploration_controller.h | 4 +- .../touch_exploration_controller_unittest.cc | 4 +- chromecast/browser/cast_browser_main_parts.cc | 4 +- chromecast/browser/cast_content_gesture_handler.cc | 16 +++--- chromecast/browser/cast_display_configurator.cc | 4 +- chromecast/browser/cast_session_id_map.cc | 8 +-- chromecast/browser/cast_web_view_default.cc | 12 ++-- chromecast/browser/pref_service_helper.cc | 2 +- chromecast/crash/linux/minidump_uploader.cc | 2 +- chromecast/graphics/cast_screen.cc | 2 +- .../graphics/gestures/side_swipe_detector.cc | 14 ++--- chromecast/media/audio/cast_audio_output_stream.cc | 22 ++++---- chromecast/net/connectivity_checker_impl.cc | 10 ++-- 18 files changed, 91 insertions(+), 92 deletions(-) commit 4702ddc716c6c6c1355d5080f50988d410db9c31 Author: Ian Prest <iapres@microsoft.com> Date: Wed Apr 24 21:18:21 2019 +0000 UIA: Fire live-region events 1. Added a new LIVE_STATUS_CHANGED generated event, to allow us to fire the correct property-change event when a live-region is turned off. 2. UIA_LiveRegionChangedEventId fired when live regious are created or changed. 3. Following the pattern established by Edgehtml, when the *first* AT attaches, we find all our live-regions and fire a live-region change. -- Note: This only works on Win8+; because the live-region change event doesn't technically exist on Win7, we aren't advised of any listeners. Misc: -- Implementing IRawElementProviderAdviseEvents caused Win7 to start sending spurious focus events (even if the implementation did nothing); these events are now filtered out. -- The EventRecorder started hanging after I upgraded to Windows 19H1; I implemented a quick workaround to prevent the hang; see comments. Bug: 928949 Change-Id: Ibf34d8d66e7055c46c6a134745366249a2fef2b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566285 Commit-Queue: Ian Prest <iapres@microsoft.com> Reviewed-by: Luke Halliwell <halliwell@chromium.org> Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#653750} .../extensions/automation_ax_tree_wrapper.cc | 1 + .../extensions/automation_ax_tree_wrapper.cc | 1 + .../accessibility_event_recorder_uia_win.cc | 15 ++++++-- .../browser_accessibility_manager_android.cc | 1 + .../browser_accessibility_manager_mac.mm | 1 + .../browser_accessibility_manager_win.cc | 6 +++- .../dump_accessibility_events_browsertest.cc | 5 +++ .../event/live-region-add-expected-uia-win.txt | 5 +++ ...7.txt => live-region-add-expected-uia-win7.txt} | 2 ++ ...-region-add-live-attribute-expected-uia-win.txt | 2 ++ ...region-add-live-attribute-expected-uia-win7.txt | 1 + .../event/live-region-change-expected-uia-win.txt | 2 ++ .../event/live-region-change-expected-uia-win7.txt | 2 ++ .../event/live-region-create-expected-uia-win.txt | 2 +- .../live-region-elem-reparent-expected-uia-win.txt | 1 + .../event/live-region-elem-reparent.html | 2 ++ ui/accessibility/ax_event_generator.cc | 14 +++++--- ui/accessibility/ax_event_generator.h | 1 + ui/accessibility/ax_event_generator_unittest.cc | 20 ++++++++++- ui/accessibility/platform/ax_fragment_root_win.cc | 41 +++++++++++++++++++++- ui/accessibility/platform/ax_platform_node_win.cc | 23 ++++++++++++ ui/accessibility/platform/ax_platform_node_win.h | 3 ++ 22 files changed, 140 insertions(+), 11 deletions(-) commit a7a4c17843aac24470943630137e6f4a4822203f Author: Philip Rogers <pdr@chromium.org> Date: Wed Apr 24 21:16:26 2019 +0000 [BGPT] Add a fast-path for transform-origin changes. This patch adds a fast-path for updating composited transform-origin changes without requiring a PaintArtifactCompositor update. This closely follows the approach of https://crrev.com/651338. Bug: 952473 Change-Id: I8b82909c1761a7aa16705813207739d29596b0d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580260 Commit-Queue: Philip Rogers <pdr@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Reviewed-by: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#653749} .../blink/renderer/core/exported/web_layer_test.cc | 54 ++++++++++++++++++++++ .../core/paint/paint_property_tree_update_tests.cc | 22 +++++---- .../graphics/paint/transform_paint_property_node.h | 48 +++++++++++-------- .../http/tests/devtools/layers/layer-tree-model.js | 4 ++ 4 files changed, 101 insertions(+), 27 deletions(-) commit 6692d67ae45848ce84bc4190e6902596c7cab557 Author: Yue Li <updowndota@chromium.org> Date: Wed Apr 24 21:16:09 2019 +0000 Fix logic to disable hotword in optin handler The hotword should be disabled while closing only for the enrollment flow case. Bug: b/130761505 Test: Local build Change-Id: I2d3b2596c9b06b2917e3b53f85506a9d89c6f0fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574442 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#653748} .../login/assistant_optin_flow_screen_handler.cc | 18 ++++++++++-------- .../login/assistant_optin_flow_screen_handler.h | 3 ++- 2 files changed, 12 insertions(+), 9 deletions(-) commit 6262b38bd26911976d797e694cad563676d5a299 Author: David Benjamin <davidben@chromium.org> Date: Wed Apr 24 21:15:07 2019 +0000 Remove some unused Channel ID includes. Bug: 875053 Change-Id: Ic3ff8e974925b88ddb17d428d4ff709d9ff038f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582863 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#653747} net/BUILD.gn | 1 - net/http/http_network_transaction_ssl_unittest.cc | 108 ---------------------- net/http/http_stream_factory_job.cc | 1 - net/log/net_log_event_type_list.h | 1 - net/quic/quic_chromium_client_session.cc | 1 - net/spdy/spdy_http_stream_unittest.cc | 5 - net/tools/quic/quic_http_proxy_backend.cc | 1 - net/url_request/url_request_http_job.cc | 1 - 8 files changed, 119 deletions(-) commit 5d312b268d23de40f70358e7ae2d5ffb175bfa26 Author: Chris Hamilton <chrisha@chromium.org> Date: Wed Apr 24 21:12:45 2019 +0000 [PM] Add dev tools token to frame nodes. The dev tools token can be used to identify frames across content and blink, and will be used to send "batch" reports of frame-bound metrics from a renderer process. BUG=755840 Change-Id: I7cb309c44a13cf8ccec67d5f3e394428f990630c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579319 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#653746} .../performance_manager/graph/frame_node_impl.cc | 10 ++++- .../performance_manager/graph/frame_node_impl.h | 10 ++++- .../graph/frame_node_impl_unittest.cc | 12 ++---- .../performance_manager/graph/graph_test_harness.h | 48 ++++++++++++++++++---- .../performance_manager/graph/mock_graphs.cc | 4 +- .../graph/page_node_impl_unittest.cc | 8 ++-- .../observers/graph_observer_unittest.cc | 4 +- .../observers/metrics_collector_unittest.cc | 12 +++--- .../performance_manager/performance_manager.cc | 16 ++++---- .../performance_manager/performance_manager.h | 4 +- .../performance_manager_tab_helper.cc | 1 + .../performance_manager_unittest.cc | 21 ++++++---- 12 files changed, 101 insertions(+), 49 deletions(-) commit aa784fc6907c34e22943295ab46123f7517381c6 Author: Kevin Strohbehn <ginko@google.com> Date: Wed Apr 24 21:10:23 2019 +0000 Fixes blurry border on suggestion chips, uses standard focus ring. Removes some legacy code and unused overrides, removes chip mask as it is no longer needed via |SetRoundedCornerRadius| Changes suggestion chips to use focus painter to prepare for the future implementation of themes. Bug: 953559 Change-Id: I34373a2ba2c6ae84b4482b2cc8946a6624a33ba2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580819 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Kevin Strohbehn <ginko@google.com> Cr-Commit-Position: refs/heads/master@{#653745} .../views/search_result_suggestion_chip_view.cc | 56 +++++++++------------- .../views/search_result_suggestion_chip_view.h | 12 ++--- .../views/suggestion_chip_container_view.cc | 2 +- 3 files changed, 28 insertions(+), 42 deletions(-) commit 3730457006a5c9af7cc19c365e855a4000ca8d05 Author: Daniel Rubery <drubery@chromium.org> Date: Wed Apr 24 21:10:14 2019 +0000 Update platform_settings for IMG files on Windows IMGs can be executed by default, so mark them as dangerous on Windows. Change-Id: I2864d7fffc3ba577af724e29e52119208249bbf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578288 Reviewed-by: Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#653744} chrome/browser/resources/safe_browsing/download_file_types.asciipb | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) commit a4aaa9d213c46a6d970d679bc43a154e1745cae2 Author: Matt Mueller <mattm@chromium.org> Date: Wed Apr 24 21:09:14 2019 +0000 Make CertNetFetcher an explicit dependency of CertVerifyProcBuiltin & CertVerifyProcAndroid Use the profile's URLRequestContext when creating the CertVerifyProc. TBR=lambroslambrou@chromium.org Bug: 829029 Change-Id: I4930649d791d5fcbd5dca20959629d59ac482278 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573008 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by: Ryan Hamilton <rch@chromium.org> Reviewed-by: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Sean Topping <seantopping@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Reviewed-by: Toni Baržić <tbarzic@chromium.org> Reviewed-by: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#653743} .../api/platform_keys/verify_trust_api.cc | 3 +- chrome/browser/io_thread.cc | 16 +++++- chrome/browser/io_thread.h | 5 ++ chrome/browser/profiles/profile_io_data.cc | 17 +++++-- chrome/browser/profiles/profile_io_data.h | 5 ++ chromecast/browser/url_request_context_factory.cc | 3 +- .../browser/shell_url_request_context_getter.cc | 2 +- .../web_test_url_request_context_getter.cc | 2 +- ios/components/io_thread/ios_io_thread.mm | 3 +- ios/web/shell/shell_url_request_context_getter.mm | 3 +- .../web_view_url_request_context_getter.mm | 3 +- net/BUILD.gn | 1 - net/cert/cert_net_fetcher.cc | 40 --------------- net/cert/cert_net_fetcher.h | 20 -------- net/cert/cert_verifier.cc | 6 ++- net/cert/cert_verifier.h | 8 +-- net/cert/cert_verify_proc.cc | 8 +-- net/cert/cert_verify_proc.h | 7 ++- net/cert/cert_verify_proc_android.cc | 8 +-- net/cert/cert_verify_proc_android.h | 6 ++- net/cert/cert_verify_proc_android_unittest.cc | 22 ++++----- net/cert/cert_verify_proc_builtin.cc | 16 +++--- net/cert/cert_verify_proc_builtin.h | 4 +- net/cert/cert_verify_proc_unittest.cc | 35 ++++++++----- net/cert/test_root_certs_unittest.cc | 4 +- net/cert_net/cert_net_fetcher_impl.cc | 9 +++- net/cert_net/cert_net_fetcher_impl.h | 8 ++- net/cert_net/cert_net_fetcher_impl_unittest.cc | 5 +- .../impl/quic_default_proof_providers_impl.cc | 2 +- net/tools/cert_verify_tool/cert_verify_tool.cc | 57 +++++++++++++++------- .../cert_verify_tool/verify_using_path_builder.cc | 15 +++--- .../cert_verify_tool/verify_using_path_builder.h | 9 +++- net/tools/quic/quic_simple_client_bin.cc | 3 +- net/url_request/url_request_context_builder.cc | 4 +- net/url_request/url_request_test_util.cc | 6 ++- net/url_request/url_request_unittest.cc | 23 ++++----- remoting/signaling/xmpp_signal_strategy.cc | 3 +- .../cert_verifier_with_trust_anchors_unittest.cc | 3 +- services/network/network_context.cc | 32 +++++------- services/network/network_context.h | 5 ++ 40 files changed, 243 insertions(+), 188 deletions(-) commit 05ca4d25bf4af4d4a9d210c4a30d57235301ddb2 Author: Sinan Sahin <sinansahin@google.com> Date: Wed Apr 24 20:58:31 2019 +0000 Add tests for ThemePreferences Bug: 953816 Change-Id: I5efca223ec2723ffa2e3b626612be763c6215852 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577984 Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Becky Zhou <huayinz@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#653742} chrome/android/chrome_test_java_sources.gni | 1 + .../themes/RadioButtonGroupThemePreference.java | 11 +++ .../preferences/themes/ThemePreferencesTest.java | 108 +++++++++++++++++++++ 3 files changed, 120 insertions(+) commit c12a30506049e25a6ca5fefb1d4c60648e187c9c Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Date: Wed Apr 24 20:54:42 2019 +0000 Revert "Remove SoleIntegration flag" This reverts commit bfd17e5e46cad8a9aa563a627e3d492ef78aa836. Reason for revert: broke Clank downstream Original change's description: > Remove SoleIntegration flag > > Sole integration was launched in M65, and we no longer need this flag. > > Bug: 778805 > Change-Id: I6669a87dcb7a6ff4705a30aaa2cf71d6670a822a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578101 > Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Cr-Commit-Position: refs/heads/master@{#653718} TBR=twellington@chromium.org,wychen@chromium.org Change-Id: I9cd3a7f54acb633c6390d4ca0c9d47efa5e8e066 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 778805 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583064 Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#653741} .../chromium/chrome/browser/ChromeFeatureList.java | 1 + .../preferences/ChromePreferenceManager.java | 4 +-- .../chrome/browser/util/FeatureUtilities.java | 29 ++++++++++++++++++++++ chrome/browser/about_flags.cc | 6 +++++ chrome/browser/android/chrome_feature_list.cc | 4 +++ chrome/browser/android/chrome_feature_list.h | 1 + chrome/browser/flag_descriptions.cc | 5 ++++ chrome/browser/flag_descriptions.h | 3 +++ 8 files changed, 51 insertions(+), 2 deletions(-) commit 0440dccd59ce3cbe84f34335421bbcc01d3b6614 Author: Maksim Ivanov <emaxx@chromium.org> Date: Wed Apr 24 20:53:45 2019 +0000 [Extensions Bindings] Fix messaging test comment Update the ExtensionIncomingNativeMessagingTest test comment to remove the note about the parameterized test - the parameterization was removed in crrev.com/c/1507041. Bug: 938998 Test: existing tests Change-Id: Ia61d991f790abf9948b4096e2bbab4bd5295e2cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581623 Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#653740} .../browser/chromeos/extensions/incoming_native_messaging_apitest.cc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) commit 3ca646069996ddd3c040e28e9c6e9a1b789910c8 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 24 20:53:38 2019 +0000 Roll src/third_party/depot_tools 12104d63d7bb..8e254da2cf93 (1 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/12104d63d7bb..8e254da2cf93 git log 12104d63d7bb..8e254da2cf93 --date=short --no-merges --format='%ad %ae %s' 2019-04-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@8e254da2cf93 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I21e709b15383bc49642dead2239b55a184ebe38d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581994 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653739} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e57fb8f748b14b3a3c1d407cdbf3b8e69b862432 Author: Kurt Horimoto <kkhorimoto@chromium.org> Date: Wed Apr 24 20:44:27 2019 +0000 [iOS] Add ios/chrome/browser/ui/alert_view_controller/OWNERS This CL adds kkhorimoto (reviewer for directory) as the OWNER for the new non-modal alert view controller. javierrobles@, the code's original author, will be added as OWNER here after he has been a committer for 6 months, as per the OWNER nomination process. Bug: none Change-Id: I9287a0896f2419feba9d664707fc66d9dc77ce46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582262 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#653738} ios/chrome/browser/ui/alert_view_controller/OWNERS | 4 ++++ 1 file changed, 4 insertions(+) commit 438b105b7018be6217b54dd80c64e07933b8c362 Author: Tommy Steimel <steimel@chromium.org> Date: Wed Apr 24 20:44:03 2019 +0000 Media Controls: Reduce icon size to 20px This CL updates the media controls icon sizes to 20px from 24px. This does not affect the icons for the "sizing-medium" controls, since "sizing-medium" is going to be removed in a CL in the near future. Bug: 955552 Change-Id: I7cab075b2f1b533097d140662220b0fae28298fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577986 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#653737} .../resources/modernMediaControls.css | 2 +- .../video-controls-layer-creation-expected.png | Bin 4496 -> 4533 bytes .../overflow/overflow-of-video-outline-expected.png | Bin 4399 -> 4392 bytes ...buffered-range-contains-currentTime-expected.png | Bin 6278 -> 6148 bytes .../media/audio-controls-rendering-expected.png | Bin 16148 -> 16033 bytes .../linux/media/controls-after-reload-expected.png | Bin 40629 -> 40685 bytes .../media/controls-layout-direction-expected.png | Bin 11142 -> 11082 bytes .../linux/media/controls-strict-expected.png | Bin 40038 -> 40088 bytes .../linux/media/controls-styling-expected.png | Bin 74551 -> 74577 bytes .../media/controls-styling-strict-expected.png | Bin 40674 -> 40667 bytes .../media/controls-without-preload-expected.png | Bin 39834 -> 39891 bytes ...ls-webkit-appearance-none-custom-bg-expected.png | Bin 17434 -> 17448 bytes ...int-controls-webkit-appearance-none-expected.png | Bin 17384 -> 17428 bytes .../video-controls-with-cast-rendering-expected.png | Bin 94064 -> 94209 bytes .../linux/media/media-controls-clone-expected.png | Bin 11408 -> 11274 bytes .../media/media-controls-grey-scrubber-expected.png | Bin 4477 -> 4499 bytes .../media/media-document-audio-repaint-expected.png | Bin 11366 -> 11308 bytes .../media/video-controls-rendering-expected.png | Bin 95975 -> 96115 bytes .../linux/media/video-display-toggle-expected.png | Bin 40953 -> 41007 bytes .../linux/media/video-empty-source-expected.png | Bin 7886 -> 7875 bytes .../linux/media/video-no-audio-expected.png | Bin 18981 -> 19048 bytes .../linux/media/video-zoom-controls-expected.png | Bin 62124 -> 62090 bytes .../video-controls-layer-creation-expected.png | Bin 0 -> 4533 bytes .../media/audio-controls-rendering-expected.png | Bin 16148 -> 16033 bytes .../media/controls-after-reload-expected.png | Bin 40629 -> 40685 bytes .../media/controls-layout-direction-expected.png | Bin 11142 -> 11082 bytes .../media/controls-strict-expected.png | Bin 40038 -> 40088 bytes .../media/controls-styling-expected.png | Bin 74551 -> 74577 bytes .../media/controls-styling-strict-expected.png | Bin 40674 -> 40667 bytes .../media/controls-without-preload-expected.png | Bin 39834 -> 39891 bytes .../video-controls-with-cast-rendering-expected.png | Bin 94064 -> 94209 bytes .../media/media-controls-clone-expected.png | Bin 11408 -> 11274 bytes .../media/media-controls-grey-scrubber-expected.png | Bin 4477 -> 4499 bytes .../media/media-document-audio-repaint-expected.png | Bin 11366 -> 11308 bytes .../media/video-controls-rendering-expected.png | Bin 95975 -> 96115 bytes .../media/video-display-toggle-expected.png | Bin 40953 -> 41007 bytes .../media/video-empty-source-expected.png | Bin 7886 -> 7875 bytes .../media/video-no-audio-expected.png | Bin 18981 -> 19048 bytes .../media/video-zoom-controls-expected.png | Bin 62124 -> 62090 bytes .../video-controls-layer-creation-expected.png | Bin 4194 -> 4241 bytes .../overflow/overflow-of-video-outline-expected.png | Bin 4087 -> 4116 bytes ...buffered-range-contains-currentTime-expected.png | Bin 5499 -> 5434 bytes .../media/audio-controls-rendering-expected.png | Bin 11759 -> 11721 bytes .../media/controls-after-reload-expected.png | Bin 37874 -> 37902 bytes .../media/controls-layout-direction-expected.png | Bin 8859 -> 8834 bytes .../mac-mac10.12/media/controls-strict-expected.png | Bin 37667 -> 37695 bytes .../media/controls-styling-expected.png | Bin 71655 -> 71730 bytes .../media/controls-styling-strict-expected.png | Bin 38513 -> 38571 bytes .../media/controls-without-preload-expected.png | Bin 37754 -> 37782 bytes ...ls-webkit-appearance-none-custom-bg-expected.png | Bin 16785 -> 16797 bytes ...int-controls-webkit-appearance-none-expected.png | Bin 16739 -> 16759 bytes .../media/media-controls-clone-expected.png | Bin 9149 -> 9126 bytes .../media/media-controls-grey-scrubber-expected.png | Bin 4212 -> 4261 bytes .../media/media-document-audio-repaint-expected.png | Bin 7571 -> 7533 bytes .../media/video-controls-rendering-expected.png | Bin 93596 -> 93676 bytes .../media/video-display-toggle-expected.png | Bin 38090 -> 38118 bytes .../media/video-empty-source-expected.png | Bin 5034 -> 5066 bytes .../mac-mac10.12/media/video-no-audio-expected.png | Bin 16095 -> 16100 bytes .../media/video-zoom-controls-expected.png | Bin 60448 -> 60426 bytes .../media/audio-controls-rendering-expected.png | Bin 11759 -> 11721 bytes .../media/controls-after-reload-expected.png | Bin 37874 -> 37902 bytes .../media/controls-layout-direction-expected.png | Bin 8859 -> 8834 bytes .../media/controls-strict-expected.png | Bin 37667 -> 37695 bytes .../media/controls-styling-expected.png | Bin 71655 -> 71730 bytes .../media/controls-styling-strict-expected.png | Bin 38513 -> 38571 bytes .../media/controls-without-preload-expected.png | Bin 37754 -> 37782 bytes .../media/media-controls-clone-expected.png | Bin 9149 -> 9126 bytes .../media/media-controls-grey-scrubber-expected.png | Bin 4212 -> 4261 bytes .../media/media-document-audio-repaint-expected.png | Bin 7571 -> 7533 bytes .../media/video-controls-rendering-expected.png | Bin 93596 -> 93676 bytes .../media/video-display-toggle-expected.png | Bin 38090 -> 38118 bytes .../media/video-empty-source-expected.png | Bin 5034 -> 5066 bytes .../media/video-zoom-controls-expected.png | Bin 60448 -> 60426 bytes .../video-controls-layer-creation-expected.png | Bin 4218 -> 4262 bytes .../overflow/overflow-of-video-outline-expected.png | Bin 4111 -> 4141 bytes ...buffered-range-contains-currentTime-expected.png | Bin 5503 -> 5385 bytes .../mac/media/audio-controls-rendering-expected.png | Bin 11928 -> 11822 bytes .../mac/media/controls-after-reload-expected.png | Bin 37895 -> 37928 bytes .../media/controls-layout-direction-expected.png | Bin 8983 -> 8968 bytes .../platform/mac/media/controls-strict-expected.png | Bin 37687 -> 37722 bytes .../mac/media/controls-styling-expected.png | Bin 71713 -> 71808 bytes .../mac/media/controls-styling-strict-expected.png | Bin 38519 -> 38587 bytes .../mac/media/controls-without-preload-expected.png | Bin 37775 -> 37808 bytes ...ls-webkit-appearance-none-custom-bg-expected.png | Bin 16864 -> 16875 bytes ...int-controls-webkit-appearance-none-expected.png | Bin 16821 -> 16836 bytes .../mac/media/media-controls-clone-expected.png | Bin 9239 -> 9162 bytes .../media/media-controls-grey-scrubber-expected.png | Bin 4230 -> 4287 bytes .../media/media-document-audio-repaint-expected.png | Bin 7588 -> 7572 bytes .../mac/media/video-controls-rendering-expected.png | Bin 93611 -> 93727 bytes .../mac/media/video-display-toggle-expected.png | Bin 38112 -> 38144 bytes .../mac/media/video-empty-source-expected.png | Bin 5056 -> 5086 bytes .../platform/mac/media/video-no-audio-expected.png | Bin 16180 -> 16178 bytes .../mac/media/video-zoom-controls-expected.png | Bin 60446 -> 60426 bytes .../media/controls-strict-expected.png | Bin 37687 -> 0 bytes .../media/controls-styling-expected.png | Bin 0 -> 71808 bytes .../media/media-controls-clone-expected.png | Bin 0 -> 9162 bytes .../media/media-document-audio-repaint-expected.png | Bin 7588 -> 0 bytes .../media/video-display-toggle-expected.png | Bin 38112 -> 0 bytes .../media/video-empty-source-expected.png | Bin 0 -> 5086 bytes .../overflow/overflow-of-video-outline-expected.png | Bin 4090 -> 4116 bytes ...buffered-range-contains-currentTime-expected.png | Bin 5512 -> 5458 bytes .../win/media/audio-controls-rendering-expected.png | Bin 11919 -> 11827 bytes .../win/media/controls-after-reload-expected.png | Bin 37833 -> 37867 bytes .../media/controls-layout-direction-expected.png | Bin 8973 -> 8927 bytes .../platform/win/media/controls-strict-expected.png | Bin 37617 -> 37650 bytes .../win/media/controls-styling-expected.png | Bin 71563 -> 71667 bytes .../win/media/controls-styling-strict-expected.png | Bin 38408 -> 38466 bytes .../win/media/controls-without-preload-expected.png | Bin 37715 -> 37747 bytes ...ls-webkit-appearance-none-custom-bg-expected.png | Bin 16780 -> 16802 bytes ...int-controls-webkit-appearance-none-expected.png | Bin 16731 -> 16759 bytes .../win/media/media-controls-clone-expected.png | Bin 9238 -> 9211 bytes .../media/media-controls-grey-scrubber-expected.png | Bin 4214 -> 4264 bytes .../media/media-document-audio-repaint-expected.png | Bin 7533 -> 7511 bytes .../win/media/video-controls-rendering-expected.png | Bin 93405 -> 93533 bytes .../win/media/video-display-toggle-expected.png | Bin 38002 -> 38034 bytes .../win/media/video-empty-source-expected.png | Bin 4967 -> 4997 bytes .../platform/win/media/video-no-audio-expected.png | Bin 16043 -> 16045 bytes .../win/media/video-zoom-controls-expected.png | Bin 59482 -> 59439 bytes 118 files changed, 1 insertion(+), 1 deletion(-) commit 5ceff28f94659e64e42839f41157628b93435c6e Author: shrekshao <shrekshao@google.com> Date: Wed Apr 24 20:43:22 2019 +0000 Roll WebGL 3f6583d..6f0b34a Tests removed from suppresion: conformance/extensions/oes-texture-float.html conformance2/rendering/vertex-id.html Newly suppressed on D3D9: conformance/extensions/webgl-depth-texture.html Also some tests are updated to get rid of empty fragment-shader (or called gl.drawBuffers([gl.NONE]). We should be finally able to land patches fixing drawbuffers without fs output issue. https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/3f6583d..6f0b34a Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel Change-Id: Ia7c29010d34d75dcc847aaf3032c51831ce079e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580594 Commit-Queue: Shrek Shao <shrekshao@google.com> Reviewed-by: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#653736} DEPS | 2 +- content/test/gpu/gpu_tests/webgl2_conformance_expectations.py | 2 -- content/test/gpu/gpu_tests/webgl_conformance_expectations.py | 4 ++-- content/test/gpu/gpu_tests/webgl_conformance_revision.txt | 2 +- 4 files changed, 4 insertions(+), 6 deletions(-) commit 714da74d2623186ebeafcf63794695c742e9679c Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Wed Apr 24 20:42:58 2019 +0000 Roll src-internal c8367add4861..c62f6b014d35 (5 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c8367add4861..c62f6b014d35 Created with: gclient setdep -r src-internal@c62f6b014d35 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=cmumford@chromium.org,gab@chromium.org,droger@chromium.org Change-Id: I5aeaccc18df3d8dc6a5719a36b9e8612363cd10c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581995 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by: Chris Mumford <cmumford@google.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653735} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit d82f16b77ece93106eff5f88413eba0b476c87fe Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 24 20:42:19 2019 +0000 Roll src/third_party/swiftshader 47d879a7145e..821feba50692 (4 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/47d879a7145e..821feba50692 git log 47d879a7145e..821feba50692 --date=short --no-merges --format='%ad %ae %s' 2019-04-24 chrisforbes@google.com Remove useless const on ImageView::getImageSizeInBytes return value 2019-04-24 chrisforbes@google.com Add hwvulkan_headers to Android build 2019-04-24 bclayton@google.com CMakeLists: Treat trailing semicolons as warnings / errors 2019-04-24 bclayton@google.com CMakeLists: Migrate from set_cpp_flag to per-project settings. Created with: gclient setdep -r src/third_party/swiftshader@821feba50692 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/130343040,chromium:b/130335507,chromium:b/130343040,chromium:b/130335507 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I11b7c8334882da1f92ba646c95d7fb8dc2cc5e41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581996 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653734} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 343c786aa35c99b6b3191ec589322f3e09bba640 Author: Daniel Bratell <bratell@opera.com> Date: Wed Apr 24 20:41:27 2019 +0000 Block files >10MB in a presubmit check To avoid bloating the chromium/src git repo with large binary files, this adds a check that files are not too large and suggests to use cloud storage otherwise. Bug: 956017 Change-Id: Idf6e816a50030551fc6003b0f83b2071f685c9b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581803 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#653733} PRESUBMIT.py | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) commit 6a5c4b7fd6fc5f7e5ad7a6835ec9a605e32db41d Author: Maksim Ivanov <emaxx@chromium.org> Date: Wed Apr 24 20:39:38 2019 +0000 Allow runtime.onConnectNative API on all channels Enable the chrome.runtime.onConnectNative extensions API event on Chrome canary/beta/stable builds. The event was introduced in R74 and has been allowed only on trunk builds. Bug: 898746 Test: existing tests Change-Id: Ibbc8c2375afce3e104e337fb909d03d48785b472 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581801 Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#653732} extensions/common/api/_api_features.json | 1 - 1 file changed, 1 deletion(-) commit cab65be1d092bb951f6828f78f0bf4d9c4212eee Author: Stefan Zager <szager@chromium.org> Date: Wed Apr 24 20:29:21 2019 +0000 [IntersectionObserver] Fix testharness API usage Before this change, the tests did nothing useful :) Change-Id: Id3e5c18f6d97e9f6a7de23fdf8de3cc0fad3f50d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580159 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#653731} .../external/wpt/intersection-observer/v2/cross-origin-effects.sub.html | 2 +- .../wpt/intersection-observer/v2/cross-origin-occlusion.sub.html | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit e4ed53ce8925b293c87265b9c8ceab6d1130b42c Author: Allen Bauer <kylixrd@chromium.org> Date: Wed Apr 24 20:28:48 2019 +0000 Visible changes effect paint, not layout. Bug: 956182 Change-Id: I77872a0360b965e9c7370d2fcfc4dec3fc468ac1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582429 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Allen Bauer <kylixrd@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#653730} ui/views/view.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit eaccd31556e90d71b8f71ad4190f9e1bf273d3ba Author: Bo Liu <boliu@chromium.org> Date: Wed Apr 24 20:26:30 2019 +0000 android: Start using bindIsolatedService Construct objects that supports variable number of connections when bindIsolatedService is supported. Also need to support android possibly calling onBind multiple times due. The API never promised that onBind will only be called once, and there seem to be a behavior change in the new APIs. Bug: 953307 Change-Id: I0b927b7e5b761eecf0b379a756667ec7ed8cbf69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574637 Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Reviewed-by: ssid <ssid@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#653729} .../process_launcher/ChildConnectionAllocator.java | 12 ++- .../process_launcher/ChildProcessConnection.java | 7 ++ .../base/process_launcher/ChildProcessService.java | 13 ++-- .../ChildConnectionAllocatorTest.java | 85 ++++++++++++++++++---- .../browser/ChildProcessLauncherHelperImpl.java | 20 ++++- .../content/browser/BindingManagerTest.java | 55 ++++++++++++-- 6 files changed, 161 insertions(+), 31 deletions(-) commit 64d752de1b24b35e27180c1c6e5942294f942544 Author: Gabriel Marin <gmx@chromium.org> Date: Wed Apr 24 20:26:09 2019 +0000 Use new tcmalloc on Linux builds by default Known regressions and test breakages have been fixed. Changes the default version of tcmalloc used by Chrome on Linux from a modified tcmalloc 2.0 to a modified tcmalloc 2.7. BUG=724399,b:70905156 Change-Id: I505b1a3228889fc5eae856e4ad956fc93864609b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496237 Commit-Queue: Gabriel Marin <gmx@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#653728} build/config/allocator.gni | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 35b2e26855dd0a8b590ee1108111bbc0e215f34e Author: Bailey Berro <baileyberro@chromium.org> Date: Wed Apr 24 20:25:23 2019 +0000 cups_printing: Add metrics to capture USB printer setup source Allows us to set a baseline on usb printer setup methods. Bug: 951136 Change-Id: I3cd03b6d06b2cff5449a7e2d19ff32752fd501a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560296 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by: Sean Kau <skau@chromium.org> Auto-Submit: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#653727} chrome/browser/chromeos/printing/printer_configurer.cc | 11 ++++++++--- chrome/browser/chromeos/printing/printer_configurer.h | 18 +++++++++++++++--- .../print_preview/local_printer_handler_chromeos.cc | 17 ++++++++++++----- .../print_preview/local_printer_handler_chromeos.h | 1 + .../webui/settings/chromeos/cups_printers_handler.cc | 15 ++++++++++----- tools/metrics/histograms/enums.xml | 5 +++++ tools/metrics/histograms/histograms.xml | 9 +++++++++ 7 files changed, 60 insertions(+), 16 deletions(-) commit 9cd07e1b1b1d734e4f2679baa3311bcbbafebbaf Author: siashah <siashah@chromium.org> Date: Wed Apr 24 20:24:41 2019 +0000 Use internal icons for google pay and migration header in autofill. This impacts the UIs in the chromium builds. DESKTOP Autofill Popup without no Google Pay icon. https://screenshot.googleplex.com/gA8XxAhFLPG Card migration header image will be absent in the chromium builds. https://screenshot.googleplex.com/Y8TuqRmzye7 ANDROID Cardholder Name Fix Flow on Android https://screenshot.googleplex.com/r8awRP2JQ4F Expiration Date Fix Flow on Android https://screenshot.googleplex.com/yqrq2KSd6dB Save info bar on Android https://screenshot.googleplex.com/EzPAWSsfiMR Autofill Popup Dialog https://screenshot.googleplex.com/2JrF6D44qDN Will followup with the CL to remove the icons from the public repo. Bug: 949743 Change-Id: I93206fee18dc794775d5b1f0b047faac081c4db9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560317 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Jared Saul <jsaul@google.com> Reviewed-by: Siyu An <siyua@chromium.org> Commit-Queue: Siddharth Shah <siashah@chromium.org> Cr-Commit-Position: refs/heads/master@{#653726} .../AutofillExpirationDateFixFlowPrompt.java | 25 +++++++++++--------- .../autofill/AutofillNameFixFlowPrompt.java | 27 ++++++++++++---------- chrome/browser/android/resource_id.h | 3 ++- .../ui/autofill/autofill_popup_layout_model.cc | 20 +++++++++++++--- .../payments/local_card_migration_dialog_view.cc | 12 ++++++++-- .../local_card_migration_error_dialog_view.cc | 4 +++- .../autofill/core/browser/autofill_data_util.cc | 4 ++++ .../autofill_save_card_infobar_delegate_mobile.cc | 4 ++++ ...xpiration_date_fix_flow_view_delegate_mobile.cc | 4 ++++ .../card_name_fix_flow_view_delegate_mobile.cc | 4 ++++ .../resources/autofill_scaled_resources.grdp | 22 ++++++++++++------ 11 files changed, 92 insertions(+), 37 deletions(-) commit 09597f7dbfd9dc71428704aa878aa941addec2b1 Author: Ahmed Fakhry <afakhry@chromium.org> Date: Wed Apr 24 20:22:22 2019 +0000 Commit display prefs immediately after update Fix a flaky autotest in which rebooting the DUT may cause the display prefs being lost, and as a result DUT is not restored in mirror mode. BUG=936884 TEST=Manulayy using a chameleon device and kevin, and running: test_that --board=kevin --iterations 2 --results_dir=~/test --args "chameleon_host=<IP>" DUT_IP display_HotPlugAtBoot.mirrored Change-Id: Ib0515b751c1f2ca7106f48d42c7d9d8a9f54f88e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580461 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#653725} ash/display/display_prefs.cc | 5 +++++ 1 file changed, 5 insertions(+) commit 49c42d0a03e2b02ba73b80eca45b6b8180e70edc Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 24 20:22:08 2019 +0000 Roll src/third_party/skia 792597b1c597..e11e5c162fec (5 commits) https://skia.googlesource.com/skia.git/+log/792597b1c597..e11e5c162fec git log 792597b1c597..e11e5c162fec --date=short --no-merges --format='%ad %ae %s' 2019-04-24 mtklein@google.com AFAICT, only gm/etc1 uses third_party/etc1 2019-04-24 robertphillips@google.com Change flushing policy in GrContextPriv::writeSurfacePixels 2019-04-24 reed@google.com add gm/bench for runtime colorfilter 2019-04-24 mtklein@google.com update GL interface codegen 2019-04-24 ethannicholas@google.com minor interpreter cleanups Created with: gclient setdep -r src/third_party/skia@e11e5c162fec The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:942538,chromium:953720 TBR=mtklein@chromium.org Change-Id: Ieadba3d35f687d68e19e155feba47619f0d200dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581992 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653724} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit c295b4eafe30923b023e41228f9cd1df34f87d35 Author: Luum Habtemariam <luum@chromium.org> Date: Wed Apr 24 20:18:51 2019 +0000 CupsProxyService boilerplate DDoc: go/cups-plugin This sets up the CupsProxy Chrome Service. This service is a singleton, managed by the ServiceManager and lives in the browser process. The service is currently started with the Profile; there will be future work to lazily initiate it on first printing request. Service implementation (ProxyManager) landing in following CL. Bug: chromium:945409 Test: Builds succeed + service unused so far. Unittests + tast tests landing in future CLs. Change-Id: I1257f32dbff8a3bdbd5690651b7ccba9e693eb23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547813 Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Ken Rockot <rockot@google.com> Commit-Queue: Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#653723} chrome/app/BUILD.gn | 1 + chrome/app/DEPS | 1 + chrome/app/chrome_packaged_service_manifests.cc | 2 + chrome/browser/BUILD.gn | 1 + chrome/browser/DEPS | 1 + chrome/browser/chrome_content_browser_client.cc | 9 ++++ chrome/services/cups_proxy/BUILD.gn | 34 +++++++++++++ chrome/services/cups_proxy/OWNERS | 7 +++ chrome/services/cups_proxy/cups_proxy_service.cpp | 42 +++++++++++++++ chrome/services/cups_proxy/cups_proxy_service.h | 59 ++++++++++++++++++++++ chrome/services/cups_proxy/public/cpp/BUILD.gn | 21 ++++++++ chrome/services/cups_proxy/public/cpp/OWNERS | 4 ++ chrome/services/cups_proxy/public/cpp/manifest.cc | 32 ++++++++++++ chrome/services/cups_proxy/public/cpp/manifest.h | 18 +++++++ chrome/services/cups_proxy/public/mojom/BUILD.gn | 16 ++++++ chrome/services/cups_proxy/public/mojom/OWNERS | 2 + .../cups_proxy/public/mojom/constants.mojom | 11 ++++ 17 files changed, 261 insertions(+) commit 5f9118b0bc1cd9290edff0170ef2738e33acf7a7 Author: Peng Huang <penghuang@chromium.org> Date: Wed Apr 24 20:18:21 2019 +0000 RasterDecoder: avoid extra vulkan command buffer submissions. Change shared image api to provide begin and end semaphores for BeginWriteAccess(), so we can wait on and signal them with one command buffer submission (SkSurface::flush()) Bug: 944194 Change-Id: I941e3be92ffde6c7463b9249b20e3f7ee966a477 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582820 Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#653722} .../external_vk_image_skia_representation.cc | 5 +- .../external_vk_image_skia_representation.h | 4 +- gpu/command_buffer/service/raster_decoder.cc | 42 +++- ...shared_image_backing_factory_ahardwarebuffer.cc | 258 +++++++-------------- ...age_backing_factory_ahardwarebuffer_unittest.cc | 39 +++- .../shared_image_backing_factory_gl_texture.cc | 4 +- ...ed_image_backing_factory_gl_texture_unittest.cc | 16 +- .../shared_image_backing_factory_iosurface.mm | 4 +- ...red_image_backing_factory_iosurface_unittest.cc | 8 +- .../service/shared_image_representation.h | 12 +- gpu/command_buffer/service/wrapped_sk_image.cc | 4 +- 11 files changed, 201 insertions(+), 195 deletions(-) commit be290504b82719290ad6a3fa91e5fba78b2ce792 Author: Hector Carmona <hcarmona@chromium.org> Date: Wed Apr 24 20:11:05 2019 +0000 Navi: Add support for the ForceEphemeralProfiles policy. When this policy is set to true, we'll skip onboarding b/c any changes we make will be erased next time the browser starts up. Bug: 951838 Change-Id: Idb8fcf5e2ab5558d853c79c4f1ff7fac8fa1b02c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579767 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#653721} chrome/browser/ui/webui/welcome/nux_helper.cc | 9 +++++++++ 1 file changed, 9 insertions(+) commit cb5ce5938f6cda50eb66b48979ffefe93b843bd3 Author: Chris Hamilton <chrisha@chromium.org> Date: Wed Apr 24 20:09:55 2019 +0000 [PM] Add IsAdFrame bit to frame nodes. This will be used by process / frame priority logic. BUG=955482 Change-Id: I0a816bd57aa56964922f039d6b114d85f1fc5d78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578944 Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by: Will Harris <wfh@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#653720} chrome/browser/performance_manager/graph/frame_node_impl.cc | 8 ++++++++ chrome/browser/performance_manager/graph/frame_node_impl.h | 4 ++++ .../performance_manager/graph/frame_node_impl_unittest.cc | 12 ++++++++++++ .../public/mojom/coordination_unit.mojom | 1 + third_party/blink/renderer/core/frame/local_frame.cc | 3 +++ .../resource_coordinator/frame_resource_coordinator.cc | 4 ++++ .../resource_coordinator/frame_resource_coordinator.h | 2 ++ 7 files changed, 34 insertions(+) commit def993ad259ce6c9f5373e3fc6253266e24fff45 Author: Bo Liu <boliu@chromium.org> Date: Wed Apr 24 20:08:49 2019 +0000 Defer QueueMessageSwapPromise on invisible/defer commit Do not break swap promise if compositor is invisible or defer commit. Instead defer them until compositor is visible / non-deferred. Do this by bringing back DidNotSwapAction, ie largely reverting refs/heads/master@{#568118} Bug: 954578 Change-Id: I28d3c97c0506f9a7a3794e912220a4f457f4c623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579918 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#653719} .../android_webview/test/WebKitHitTestTest.java | 4 - cc/trees/latency_info_swap_promise.cc | 4 +- cc/trees/latency_info_swap_promise.h | 2 +- cc/trees/layer_tree_host_unittest.cc | 40 ++++++++-- cc/trees/layer_tree_impl.cc | 40 ++++++++-- cc/trees/layer_tree_impl_unittest.cc | 88 ++++++++++++++++++---- cc/trees/swap_promise.h | 9 ++- cc/trees/swap_promise_manager.cc | 11 ++- cc/trees/swap_promise_manager_unittest.cc | 4 +- content/renderer/frame_swap_message_queue.cc | 11 +-- content/renderer/frame_swap_message_queue.h | 7 +- content/renderer/queue_message_swap_promise.cc | 33 ++------ content/renderer/queue_message_swap_promise.h | 7 +- content/renderer/render_widget.cc | 4 +- 14 files changed, 178 insertions(+), 86 deletions(-) commit bfd17e5e46cad8a9aa563a627e3d492ef78aa836 Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Date: Wed Apr 24 20:06:56 2019 +0000 Remove SoleIntegration flag Sole integration was launched in M65, and we no longer need this flag. Bug: 778805 Change-Id: I6669a87dcb7a6ff4705a30aaa2cf71d6670a822a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578101 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#653718} .../chromium/chrome/browser/ChromeFeatureList.java | 1 - .../preferences/ChromePreferenceManager.java | 4 +-- .../chrome/browser/util/FeatureUtilities.java | 29 ---------------------- chrome/browser/about_flags.cc | 6 ----- chrome/browser/android/chrome_feature_list.cc | 4 --- chrome/browser/android/chrome_feature_list.h | 1 - chrome/browser/flag_descriptions.cc | 5 ---- chrome/browser/flag_descriptions.h | 3 --- 8 files changed, 2 insertions(+), 51 deletions(-) commit d20dd58cb8571c5303eae81125260d8d590d03ac Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Wed Apr 24 20:05:52 2019 +0000 Update V8 to version 7.6.24. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b80da604..7149a9ba Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8762db694910cf1b1ab84354c4d3b13ee276de7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582824 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653717} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 34d5800057a6108812f7aeedf853a7dcc0897ea1 Author: Dana Fried <dfried@chromium.org> Date: Wed Apr 24 20:05:48 2019 +0000 Remove all unnecessary heap allocation of gfx::ImageSkia ImageSkia is a thin wrapper around a refcounted smart pointer, so there is no need to allocate one on the heap (especially if the instance that is being created is just a shallow copy of an existing instance). This CL removes all of the pointer-to-ImageSkia (i.e. pointer-to-smart pointer) cases except those needed for compatibility with the class property system (which only allows complex types to be heap-allocated). Bug: 953845 Change-Id: I743b41ef19012517fe0dfc3bb78f3408e14f7a54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562762 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by: Pavol Marko <pmarko@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#653716} .../browser/aw_content_browser_client.cc | 4 +- .../browser/aw_content_browser_client.h | 2 +- ash/wm/resize_shadow.cc | 15 ++-- .../background_application_list_model.cc | 10 +-- .../background/background_application_list_model.h | 10 +-- .../browser/background/background_mode_manager.cc | 6 +- chrome/browser/chrome_content_browser_client.cc | 4 +- chrome/browser/chrome_content_browser_client.h | 2 +- .../users/avatar/user_image_manager_browsertest.cc | 88 +++++++++++----------- .../users/avatar/user_image_manager_test_util.cc | 9 +-- .../users/avatar/user_image_manager_test_util.h | 11 +-- .../policy/device_local_account_browsertest.cc | 14 ++-- .../internal_app/internal_app_icon_loader.cc | 11 ++- .../internal_app/internal_app_icon_loader.h | 3 +- chrome/browser/ui/views/tab_icon_view.cc | 54 +++++++------ chrome/browser/ui/views/tab_icon_view.h | 2 - content/public/browser/content_browser_client.cc | 5 +- content/public/browser/content_browser_client.h | 9 +-- content/public/browser/favicon_status.cc | 2 +- ui/gfx/image/image_family.cc | 4 +- ui/message_center/public/cpp/notification.cc | 16 ++-- 21 files changed, 136 insertions(+), 145 deletions(-) commit c2de834c1d71955c14e9a13128cfa93675c2fd62 Author: Leonard Grey <lgrey@chromium.org> Date: Wed Apr 24 19:57:43 2019 +0000 UIDevTools: Prevent overflow when setting views properties When setting a "CSS" property to the empty string in DevTools (easily done by accident), CSSAgent is called twice: (assume the property is "Enabled) First, with "\n Enabled:\n", and then, with " \n " or similar. The loop in the parsing code's exit condition is "size of parsed tokens - 1" The good news is that this means that the first call never enters the loop. The same is true for any odd number of tokens, so I removed the DCHECK. The bad news is that the size is unsigned, so when no tokens are parsed, it wraps around and we crash trying to read the first token. Bug: 954675 Change-Id: I31735f0344246458c3f33bf0cac3ed2eb3758ce6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582759 Reviewed-by: Wei Li <weili@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#653715} components/ui_devtools/views/view_element.cc | 4 +++- components/ui_devtools/views/view_element_unittest.cc | 9 +++++++++ 2 files changed, 12 insertions(+), 1 deletion(-) commit 950e42b1220cc1a9f64c591843222e0623c0df48 Author: Benoît Lizé <lizeb@chromium.org> Date: Wed Apr 24 19:57:30 2019 +0000 android: Remove dont-prefetch-libraries flag, as it is unused. Change-Id: Ia016c7beb92702de095fd40472f0327b907816d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581633 Reviewed-by: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#653714} .../base/library_loader/LibraryLoader.java | 39 ++-------------------- .../chromium/chrome/browser/ChromeFeatureList.java | 1 - .../chrome/browser/util/FeatureUtilities.java | 7 ++-- chrome/browser/about_flags.cc | 6 ---- chrome/browser/android/chrome_feature_list.cc | 4 --- chrome/browser/flag-metadata.json | 5 --- chrome/browser/flag_descriptions.cc | 4 --- 7 files changed, 4 insertions(+), 62 deletions(-) commit a87538d319ab883f2fff03a0991fdb1e3ae4dff7 Author: Yuly Novikov <ynovikov@chromium.org> Date: Wed Apr 24 19:54:48 2019 +0000 Increase Win10 FYI Release (NVIDIA GeForce GTX 1660) bot timeout further 12 hours was not enough, increase it to 18. TBR=kbr Bug: 881625 Change-Id: I06d76e656f905941b8bacae548569ee2d3d6aec0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582864 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#653713} infra/config/cr-buildbucket.cfg | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit c112c0114f2ae182d7de06585ca51fe4bbeb5f6c Author: Regan Hsu <hsuregan@chromium.org> Date: Wed Apr 24 19:53:36 2019 +0000 [CrOS SplitSettings] Change titlebar to a different shade of of gray. Bug: 950007 Change-Id: Ib2f488239cb62a32b427d47f69183f07c95a7c49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580200 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#653712} .../ui/views/frame/browser_non_client_frame_view_ash.cc | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) commit 96061703e684f045a9c4ac4863bae94fdf7d3c4d Author: Chromium WPT Sync <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Date: Wed Apr 24 19:49:31 2019 +0000 Import wpt@3625714dda1ad6aea9adea34455b9a61d5ac94ab Using wpt-import in Chromium 3278a19384c42ac4bec6dcd05c66620746a9b9d3. With Chromium commits locally applied on WPT: 0a8f3ffa48 "Use testdriver Action API in WPT pointerevent touch tests - Part 2" 4e9215207a "[Code Health] Remove unnecessary reference file for web test" 40465b7400 "[Animation Worklet] Copy the effects of a migrating animator over to new global scope" e28269b698 "[LayoutNG/PE] Clear visual overflow for LayoutText before setting." aff3c8feca "Add tests for crbug.com/363609 and crbug.com/954591" 143d2905e8 "[WPT/common/security-features] Stop using assert_* from common.js" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I356fe1d465346b62bbe7c35a946486f438fc313d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582278 Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653711} .../blink/web_tests/external/WPT_BASE_MANIFEST_6.json | 4 ++-- .../web_tests/external/wpt/tools/requirements_mypy.txt | 4 ++-- .../blink/web_tests/external/wpt/tools/runner/runner.js | 16 +++++++++++++--- 3 files changed, 17 insertions(+), 7 deletions(-) commit bdd7a225e3d6872c6f6e46e13905f8055a4247cc Author: Ben Wagner <bungeman@chromium.org> Date: Wed Apr 24 19:46:34 2019 +0000 Add SK_IGNORE_LINEAR_METRICS_FIX flag for Skia. This holds out a Skia fix for metrics which will require some tweaks to code and baselines in Blink. Change-Id: I54c88dea27546c2458cbeb95e44833bb7a1820fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582236 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Ben Wagner <bungeman@google.com> Cr-Commit-Position: refs/heads/master@{#653710} skia/BUILD.gn | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Updated tag 'tree_truth' (was cc1bc5941250)