Back to build
Raw log | Switch to full mode | Login

/b/s/w/ir/cache/builder/src/build/tree_truth.sh /b/s/w/ir/cache/builder/src src in dir /b/s/w/ir/k: allow_subannotations: False cmd: ['/b/s/w/ir/cache/builder/src/build/tree_truth.sh', '/b/s/w/ir/cache/builder/src', 'src'] env: FrozenDict([('CHROME_HEADLESS', '1')]) env_prefixes: {'mapping': FrozenDict([]), 'pathsep': ':'} env_suffixes: {'mapping': FrozenDict([]), 'pathsep': ':'} infra_step: False name_tokens: ['tree truth steps'] ok_ret: frozenset([0]) trigger_specs: [] full environment: BOTO_CONFIG: /b/s/w/ir/tmp/gsutil-task/.boto BUILDBUCKET_EXPERIMENTAL: FALSE CHROME_HEADLESS: 1 CIPD_CACHE_DIR: /b/s/cipd_cache/cache CIPD_PROTOCOL: v2 DEVSHELL_CLIENT_PORT: 42228 DOCKER_CONFIG: /b/s/w/ir/tmp/docker-cfg-task DOCKER_TMPDIR: /b/s/w/ir/tmp/docker-tmp-task GIT_CONFIG_NOSYSTEM: 1 GIT_TERMINAL_PROMPT: 0 HOME: /home/chrome-bot INFRA_GIT_WRAPPER_HOME: /b/s/w/ir/tmp/git-home-task LOGDOG_COORDINATOR_HOST: logs.chromium.org LOGDOG_STREAM_PREFIX: buildbucket/cr-buildbucket.appspot.com/8915191083536710448 LOGDOG_STREAM_PROJECT: chromium LOGDOG_STREAM_SERVER_PATH: unix:/b/s/w/ir/tmp/ld.sock LOGNAME: chrome-bot LUCI_CONTEXT: /b/s/w/ir/tmp/luci_context.697607329 MAC_CHROMIUM_TMPDIR: /b/s/w/ir/tmp/t MAIL: /var/mail/chrome-bot NO_GCE_CHECK: False PATH: /b/s/w/ir/cipd_bin_packages:/b/s/w/ir/cipd_bin_packages/bin:/b/s/cipd_cache/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin PWD: /b/s/w/ir/k PYTHONIOENCODING: UTF-8 PYTHONUNBUFFERED: 1 SHELL: /bin/bash SHLVL: 1 SUDO_COMMAND: /usr/bin/python /b/s/swarming_bot.zip start_bot SUDO_GID: 0 SUDO_UID: 0 SUDO_USER: root SWARMING_BOT_ID: luci-chromium-ci-trusty-8-12-0grl SWARMING_EXTERNAL_BOT_SETUP: 1 SWARMING_HEADLESS: 1 SWARMING_SERVER: https://chromium-swarm.appspot.com SWARMING_TASK_ID: 446e0f201fbd9711 TEMP: /b/s/w/ir/tmp/t TEMPDIR: /b/s/w/ir/tmp/t TERM: linux TMP: /b/s/w/ir/tmp/t TMPDIR: /b/s/w/ir/tmp/t USER: chrome-bot USERNAME: chrome-bot VPYTHON_VIRTUALENV_ROOT: /b/s/w/ir/cache/vpython _: /b/s/w/ir/cipd_bin_packages/vpython !@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: 5bb6166bf900b0ec78522c25a1133afbd35f8dc4 Rename GraphicsContext high contrast unit tests to dark mode. Aran Gilman, Thu Apr 25 15:32:32 2019 +0000 7c8273b9026611cb224fb170242178503a494312 Switch blink_web_tests to generate_wrapper gn template. John Budorick, Thu Apr 25 15:27:47 2019 +0000 93d078b0cea3b9e903a80fb9f88d9ceb68a79aa8 Avoid using the symbol name |interface| since it's a Win macro Daniel Bratell, Thu Apr 25 15:26:21 2019 +0000 bb97c4eb5233cd4431994959bf970dea7423eac0 Add myself to the wake_lock WATCHLIST. Raphael Kubo da Costa, Thu Apr 25 15:25:39 2019 +0000 d92dc336f2b4c332cf5beadadb1399120d56591b Roll src/third_party/skia 2444c0e9aa23..a24336b524b6 (2 commits) chromium-autoroll, Thu Apr 25 15:20:46 2019 +0000 b47f8dd60bf40949310435b442d438d5ccb24f68 coverage: Copy test results if only one shard ran Stephen Martinis, Thu Apr 25 15:18:49 2019 +0000 ece309c345eea8ae633872934022c9c14e321ecf Read Java constant pool to generate keep rules for async VR DFM Anthony Cui, Thu Apr 25 15:07:40 2019 +0000 1f7e8252555db8341ccb7e743cb0ea905902d4de Make auto- and never- translate parameters finchable. Alexandre Frechette, Thu Apr 25 15:06:26 2019 +0000 f41f385816eebadccd5c3bc96ca85048685cbcdf Roll src-internal 425d37734f91..c1d6ec7417db (2 commits) chromium-internal-autoroll, Thu Apr 25 15:04:36 2019 +0000 28ff9a4c454e9c1fc2d8027b501d71ff11fe3bf5 Reland "PM: Delete PageSignalGenerator." Sigurdur Asgeirsson, Thu Apr 25 15:00:55 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit 5bb6166bf900b0ec78522c25a1133afbd35f8dc4 Author: Aran Gilman <gilmanmh@google.com> Date: Thu Apr 25 15:32:32 2019 +0000 Rename GraphicsContext high contrast unit tests to dark mode. Bug: 938511 Change-Id: I5fe57c9529bc59340329365fa68255a5c46b440a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582433 Auto-Submit: Aran Gilman <gilmanmh@google.com> Reviewed-by: Stephen Chenney <schenney@chromium.org> Commit-Queue: Aran Gilman <gilmanmh@google.com> Cr-Commit-Position: refs/heads/master@{#654034} .../renderer/platform/graphics/graphics_context_test.cc | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) commit 7c8273b9026611cb224fb170242178503a494312 Author: John Budorick <jbudorick@chromium.org> Date: Thu Apr 25 15:27:47 2019 +0000 Switch blink_web_tests to generate_wrapper gn template. Bug: 816629,897803 Change-Id: I58eac925dafb827385694cccad758699977c23ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583125 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#654033} BUILD.gn | 27 +++++---- .../scripts/generators/gen_run_web_tests_script.py | 67 ---------------------- testing/test.gni | 56 ------------------ 3 files changed, 15 insertions(+), 135 deletions(-) commit 93d078b0cea3b9e903a80fb9f88d9ceb68a79aa8 Author: Daniel Bratell <bratell@opera.com> Date: Thu Apr 25 15:26:21 2019 +0000 Avoid using the symbol name |interface| since it's a Win macro In some Windows SDK headers |interface| is declared to be a macro so it's always a bit risky using that name in normal code. There are reports that the instance in BackgroundFetchRegistrationServiceImpl caused problems in some jumbo builds so let's just rename it mojo_interface. Bug: 956486 Change-Id: Ic261cdd76ce2f6b30e449c0a25000a8542ef0f53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584281 Commit-Queue: Daniel Bratell <bratell@opera.com> Commit-Queue: Peter Beverloo <peter@chromium.org> Auto-Submit: Daniel Bratell <bratell@opera.com> Reviewed-by: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#654032} .../background_fetch/background_fetch_registration_service_impl.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit bb97c4eb5233cd4431994959bf970dea7423eac0 Author: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Date: Thu Apr 25 15:25:39 2019 +0000 Add myself to the wake_lock WATCHLIST. TBR=reillyg Change-Id: I155320e471bd814d11acda1caae85acd7078a1e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584299 Reviewed-by: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#654031} WATCHLISTS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit d92dc336f2b4c332cf5beadadb1399120d56591b Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Apr 25 15:20:46 2019 +0000 Roll src/third_party/skia 2444c0e9aa23..a24336b524b6 (2 commits) https://skia.googlesource.com/skia.git/+log/2444c0e9aa23..a24336b524b6 git log 2444c0e9aa23..a24336b524b6 --date=short --no-merges --format='%ad %ae %s' 2019-04-25 mtklein@google.com roll libpng to pre-1.6.38 2019-04-25 robertphillips@google.com Remove GrInternalSurfaceFlags::kNoPendingIO as it is no longer needed Created with: gclient setdep -r src/third_party/skia@a24336b524b6 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@chromium.org Change-Id: I1a92caa4614ae467a4aa095af4737009fba390e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584024 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#654030} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit b47f8dd60bf40949310435b442d438d5ccb24f68 Author: Stephen Martinis <martiniss@chromium.org> Date: Thu Apr 25 15:18:49 2019 +0000 coverage: Copy test results if only one shard ran This restores behavior which was removed in https://crrev.com/c/1526790. That CL unintentionally broke builds, and followup CLs to that CL took longer than expected to land. Bug: 923711 Change-Id: I1649b39cf9c30a2fd37499986f0db3998d87956b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583341 Auto-Submit: Stephen Martinis <martiniss@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#654029} testing/merge_scripts/code_coverage/merge_results.py | 12 ++++++++++++ 1 file changed, 12 insertions(+) commit ece309c345eea8ae633872934022c9c14e321ecf Author: Anthony Cui <cuianthony@google.com> Date: Thu Apr 25 15:07:40 2019 +0000 Read Java constant pool to generate keep rules for async VR DFM Add bytecode rewriter method to read super classes, implemented interfaces, and field and method references from class constant pools. Convert list of references to keep rules. Integrate new keep rules into build to ensure VR stays compatible with base when proguarded separately. Bug: 952838 Change-Id: I0c9c44b1aa02cc9862ae3b03110e947fb28b6a3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560013 Reviewed-by: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Anthony Cui <cuianthony@google.com> Cr-Commit-Position: refs/heads/master@{#654028} build/android/bytecode/BUILD.gn | 1 + .../org/chromium/bytecode/ByteCodeProcessor.java | 10 + .../bytecode/ConstantPoolReferenceReader.java | 140 + build/android/constant_pool_refs_to_keep_rules.py | 175 + build/android/gyp/bytecode_processor.py | 2 + build/config/android/internal_rules.gni | 10 +- build/config/android/rules.gni | 2 + chrome/android/BUILD.gn | 5 +- chrome/android/features/vr/proguard_async.flags | 6875 +++++++++++++++++++- chrome/android/features/vr/vr_module_tmpl.gni | 6 + 10 files changed, 7134 insertions(+), 92 deletions(-) commit 1f7e8252555db8341ccb7e743cb0ea905902d4de Author: Alexandre Frechette <frechette@chromium.org> Date: Thu Apr 25 15:06:26 2019 +0000 Make auto- and never- translate parameters finchable. Bug: 953111 Change-Id: I60148bde27e2a63fd8b6dfe4b25424dc3dc753be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569972 Commit-Queue: Alexandre Frechette <frechette@chromium.org> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#654027} .../core/browser/translate_infobar_delegate.cc | 55 ++++++++++++++++++---- .../core/browser/translate_infobar_delegate.h | 21 +++++---- ios/chrome/browser/translate/translate_egtest.mm | 30 ++++++++---- 3 files changed, 78 insertions(+), 28 deletions(-) commit f41f385816eebadccd5c3bc96ca85048685cbcdf Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Thu Apr 25 15:04:36 2019 +0000 Roll src-internal 425d37734f91..c1d6ec7417db (2 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/425d37734f91..c1d6ec7417db Created with: gclient setdep -r src-internal@c1d6ec7417db The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=cmumford@chromium.org,gab@chromium.org,droger@chromium.org Change-Id: I6f1a7d0517ee64047038873d7856e65c5fd5844d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584023 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#654026} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 28ff9a4c454e9c1fc2d8027b501d71ff11fe3bf5 Author: Sigurdur Asgeirsson <siggi@chromium.org> Date: Thu Apr 25 15:00:55 2019 +0000 Reland "PM: Delete PageSignalGenerator." This is a reland of d620ba8e7da8d95dba8860244cd37d2a6f2f8bba Original change's description: > PM: Delete PageSignalGenerator. > > This can now be deleted as all its users have been deleted or diverted. > > Bug: 931407 > Change-Id: Ic09978861789dfa933821b5c755520aebe4e3c06 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579267 > Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> > Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: Chris Hamilton <chrisha@chromium.org> > Cr-Commit-Position: refs/heads/master@{#653800} TBR=wfh@chromium.org Bug: 931407 Change-Id: Ia32fb0e48ee863779e4756086c0d5e9ba9d83810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582332 Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by: François Doray <fdoray@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#654025} chrome/browser/BUILD.gn | 4 - .../observers/page_signal_generator_impl.cc | 179 ------------ .../observers/page_signal_generator_impl.h | 98 ------- .../page_signal_generator_impl_unittest.cc | 323 --------------------- .../performance_manager/performance_manager.cc | 7 - .../performance_manager_tab_helper.cc | 13 - .../performance_manager_tab_helper.h | 5 - .../resource_coordinator/page_signal_receiver.cc | 129 -------- .../resource_coordinator/page_signal_receiver.h | 116 -------- .../page_signal_receiver_unittest.cc | 133 --------- .../resource_coordinator_parts.cc | 8 +- .../resource_coordinator_parts.h | 8 - chrome/browser/resource_coordinator/tab_helper.cc | 42 +-- chrome/browser/resource_coordinator/tab_manager.cc | 3 +- chrome/browser/resource_coordinator/tab_manager.h | 5 +- ..._manager_resource_coordinator_signal_observer.h | 7 +- .../resource_coordinator/tab_manager_unittest.cc | 10 +- chrome/browser/resource_coordinator/utils.cc | 10 - chrome/browser/resource_coordinator/utils.h | 5 - chrome/test/BUILD.gn | 2 - .../public/cpp/coordination_unit.typemap | 2 - .../public/cpp/coordination_unit_mojom_traits.cc | 13 - .../public/cpp/coordination_unit_mojom_traits.h | 23 -- .../public/cpp/page_navigation_identity.h | 26 -- .../resource_coordinator/public/mojom/BUILD.gn | 1 - .../public/mojom/page_signal.mojom | 76 ----- 26 files changed, 10 insertions(+), 1238 deletions(-) commit 369760441bfdc09ca93e28601016d836b557107e Author: Friedrich Horschig <fhorschig@chromium.org> Date: Thu Apr 25 14:59:47 2019 +0000 Reland "Rename translation files for android_keyboard_accessory_strings.grd" This is a reland of ab4cac496a525970f6bb3bf9bb424499c45471d4 Original change's description: > Rename translation files for android_keyboard_accessory_strings.grd > > When running the translate.py script, it fails because the translation > files have an incorrect name: > android_keyboard_accessory_strings.grd: invalid xtb name: > "android_chrome_keyboard_accessory_strings_am.xtb. xtb name must be > android_keyboard_accessory_strings_<lang>.xtb where <lang> is the > language code." > > This CL drops the "chrome_" from all translation names to resolve this. > > Bug: 956128 > Change-Id: I667e824a2e1bebb8a85cf6674799230190997370 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582505 > Auto-Submit: Friedrich [CET] <fhorschig@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#654006} Bug: 956128 Change-Id: I8b849ce630bf844884fd599bfc6031d82d0357ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584260 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#654024} .../features/keyboard_accessory/internal/BUILD.gn | 88 +++++----- .../strings/android_keyboard_accessory_strings.grd | 192 ++++++++++----------- ...b => android_keyboard_accessory_strings_am.xtb} | 0 ...b => android_keyboard_accessory_strings_ar.xtb} | 0 ...b => android_keyboard_accessory_strings_bg.xtb} | 0 ...b => android_keyboard_accessory_strings_bn.xtb} | 0 ...b => android_keyboard_accessory_strings_ca.xtb} | 0 ...b => android_keyboard_accessory_strings_cs.xtb} | 0 ...b => android_keyboard_accessory_strings_da.xtb} | 0 ...b => android_keyboard_accessory_strings_de.xtb} | 0 ...b => android_keyboard_accessory_strings_el.xtb} | 0 ...> android_keyboard_accessory_strings_en-GB.xtb} | 0 ... android_keyboard_accessory_strings_es-419.xtb} | 0 ...b => android_keyboard_accessory_strings_es.xtb} | 0 ...b => android_keyboard_accessory_strings_et.xtb} | 0 ...b => android_keyboard_accessory_strings_fa.xtb} | 0 ...b => android_keyboard_accessory_strings_fi.xtb} | 0 ... => android_keyboard_accessory_strings_fil.xtb} | 0 ...b => android_keyboard_accessory_strings_fr.xtb} | 0 ...b => android_keyboard_accessory_strings_gu.xtb} | 0 ...b => android_keyboard_accessory_strings_hi.xtb} | 0 ...b => android_keyboard_accessory_strings_hr.xtb} | 0 ...b => android_keyboard_accessory_strings_hu.xtb} | 0 ...b => android_keyboard_accessory_strings_id.xtb} | 0 ...b => android_keyboard_accessory_strings_it.xtb} | 0 ...b => android_keyboard_accessory_strings_iw.xtb} | 0 ...b => android_keyboard_accessory_strings_ja.xtb} | 0 ...b => android_keyboard_accessory_strings_kn.xtb} | 0 ...b => android_keyboard_accessory_strings_ko.xtb} | 0 ...b => android_keyboard_accessory_strings_lt.xtb} | 0 ...b => android_keyboard_accessory_strings_lv.xtb} | 0 ...b => android_keyboard_accessory_strings_ml.xtb} | 0 ...b => android_keyboard_accessory_strings_mr.xtb} | 0 ...b => android_keyboard_accessory_strings_ms.xtb} | 0 ...b => android_keyboard_accessory_strings_nl.xtb} | 0 ...b => android_keyboard_accessory_strings_no.xtb} | 0 ...b => android_keyboard_accessory_strings_pl.xtb} | 0 ...> android_keyboard_accessory_strings_pt-BR.xtb} | 0 ...> android_keyboard_accessory_strings_pt-PT.xtb} | 0 ...b => android_keyboard_accessory_strings_ro.xtb} | 0 ...b => android_keyboard_accessory_strings_ru.xtb} | 0 ...b => android_keyboard_accessory_strings_sk.xtb} | 0 ...b => android_keyboard_accessory_strings_sl.xtb} | 0 ...b => android_keyboard_accessory_strings_sr.xtb} | 0 ...b => android_keyboard_accessory_strings_sv.xtb} | 0 ...b => android_keyboard_accessory_strings_sw.xtb} | 0 ...b => android_keyboard_accessory_strings_ta.xtb} | 0 ...b => android_keyboard_accessory_strings_te.xtb} | 0 ...b => android_keyboard_accessory_strings_th.xtb} | 0 ...b => android_keyboard_accessory_strings_tr.xtb} | 0 ...b => android_keyboard_accessory_strings_uk.xtb} | 0 ...b => android_keyboard_accessory_strings_vi.xtb} | 0 ...> android_keyboard_accessory_strings_zh-CN.xtb} | 0 ...> android_keyboard_accessory_strings_zh-TW.xtb} | 0 54 files changed, 140 insertions(+), 140 deletions(-) commit fad01bf35f34b040dab999c0ab5374e6e77529b1 Author: Carlos Caballero <carlscab@google.com> Date: Thu Apr 25 14:59:08 2019 +0000 Rename ScopedTaskEnvironment::ExecutionMode ScopedTaskEnvironment::ExecutionMode is becoming ScopedTaskEnvironment::ThreadPoolExecutionMode This CL was uploaded by git cl split. R=qinmin@chromium.org Bug: 708584 Change-Id: I83e15199cc8f11e4d46ba56b1ea7a15907e5c29e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583753 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by: Min Qin <qinmin@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#654023} components/download/internal/common/download_item_impl_unittest.cc | 2 +- .../download/internal/common/parallel_download_job_unittest.cc | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) commit 0b0aa3480be83a350c5151fb55418f41a6eaa1ee Author: Clemens Arbesser <arbesser@google.com> Date: Thu Apr 25 14:57:14 2019 +0000 Revert "[Autofill Assistant] Refactor of payment request UI." This reverts commit 2f44a657fad02ae6b5ec4d455d97a250184a4e82. Reason for revert: Just a quick revert to allow http://crrev/c/1583782 to land before this change, as that one will be merge-requested to M-75. Original change's description: > [Autofill Assistant] Refactor of payment request UI. > > This CL refactors the Autofill Assistant PR UI. The goal is to make the new UI modular (because parts of it will be used outside the PR) and more easily customizable. > > To this end, this CL introduces two new custom widgets: > - AssistantVerticalExpander is a widget container with a title and a chevron-icon to toggle between a 'collapsed' and 'expanded' state. It is intended to be used in all PR sections. > - AssistantVerticalExpanderAccordion is a linear layout which automatically ensures that a maximum of one of its child expanders is expanded at the same time. If an expander is expanded, all others are automatically collapsed. The accordion can otherwise be used just like a linear layout. > > This CL also introduces the necessary classes to facilitate translation between Chrome PR (SectionInformation) and the new AA UI. > > Bug: 806868 > Bug: 1538294 > Binary-Size: Added new UI widgets for use in the Autofill Assistant PR UI. > Change-Id: I432398c773e5329dc8aec553a71be72784b8ad97 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538294 > Commit-Queue: Clemens Arbesser <arbesser@google.com> > Reviewed-by: Stephane Zermatten <szermatt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#654015} TBR=szermatt@chromium.org,jdemeulenaere@chromium.org,arbesser@google.com Change-Id: I16c5e7815e30f7a82bb6f22667d5961af2860e6f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 806868, 1538294 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584300 Reviewed-by: Clemens Arbesser <arbesser@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#654022} .../android/features/autofill_assistant/BUILD.gn | 7 +- .../res/layout/autofill_assistant_address_full.xml | 31 - .../layout/autofill_assistant_address_summary.xml | 36 -- .../res/layout/autofill_assistant_contact_full.xml | 25 - .../layout/autofill_assistant_contact_summary.xml | 27 - .../autofill_assistant_payment_method_full.xml | 52 -- .../autofill_assistant_payment_method_summary.xml | 46 -- .../layout/autofill_assistant_payment_request.xml | 50 ++ ...ofill_assistant_payment_request_choice_list.xml | 21 - ...l_assistant_payment_request_section_divider.xml | 11 - ...ill_assistant_payment_request_section_title.xml | 40 -- ...istant_payment_request_terms_and_conditions.xml | 35 -- .../java/res/values-v17/attrs.xml | 10 +- .../java/res/values-v17/dimens.xml | 9 - .../AssistantBottomBarCoordinator.java | 33 +- .../payment/AssistantChoiceList.java | 202 +++---- ...sistantPaymentRequestContactDetailsSection.java | 134 ----- .../AssistantPaymentRequestCoordinator.java | 643 ++++++++++++--------- ...ssistantPaymentRequestPaymentMethodSection.java | 139 ----- .../payment/AssistantPaymentRequestSection.java | 330 +---------- ...istantPaymentRequestShippingAddressSection.java | 120 ---- .../AssistantPaymentRequestTermsSection.java | 73 --- .../payment/AssistantPaymentRequestUI.java | 549 ++++++++++++++++++ .../payment/AssistantVerticalExpander.java | 230 -------- .../AssistantVerticalExpanderAccordion.java | 123 ---- .../android_chrome_autofill_assistant_strings.grd | 3 - 26 files changed, 1124 insertions(+), 1855 deletions(-) commit 87832dcc62ae35b1e9862e84e422fa7db0db2bb1 Author: James Cook <jamescook@chromium.org> Date: Thu Apr 25 14:56:13 2019 +0000 Add test for renderers using correctly localized blink/content strings Adds a regression test for issue 510455 "Choose File" button not being localized. Bug: 510455, 952893 Test: added to browser_tests Change-Id: Ibb4d6e65b308820e1389dcb95eb9a392c9efbb50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575865 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Ken Rockot <rockot@google.com> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#654021} .../chromeos/startup_settings_cache_browsertest.cc | 49 ++++++++++++++++++++++ chrome/test/BUILD.gn | 1 + 2 files changed, 50 insertions(+) commit af23de78831d19e26fb984cb4a2d2ed3b9efd0be Author: Nina Satragno <nsatragno@chromium.org> Date: Thu Apr 25 14:55:23 2019 +0000 Update the webauthn account chooser UI This change prettifies the account chooser UI by implementing a version of the hover list instead of a table view. I'm planning to add user icons in a follow up patch to keep CL sizes low. For app/generated_resources: TBR=cpu@chromium.org Bug: 955439 Change-Id: I104b5db352eef7fb143ef74cb3cc5d2c1afd98cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577989 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#654020} chrome/app/generated_resources.grd | 3 + .../IDS_WEBAUTHN_UNKNOWN_ACCOUNT.png.sha1 | 1 + chrome/browser/ui/BUILD.gn | 2 + .../authenticator_select_account_sheet_view.cc | 48 +++------------- .../authenticator_select_account_sheet_view.h | 20 +++---- .../browser/ui/views/webauthn/hover_list_view.cc | 41 ++++++++++---- chrome/browser/ui/views/webauthn/hover_list_view.h | 6 +- .../ui/webauthn/account_hover_list_model.cc | 64 ++++++++++++++++++++++ .../browser/ui/webauthn/account_hover_list_model.h | 51 +++++++++++++++++ .../webauthn/authenticator_dialog_browsertest.cc | 5 +- .../ui/webauthn/ble_device_hover_list_model.cc | 4 ++ .../ui/webauthn/ble_device_hover_list_model.h | 1 + chrome/browser/ui/webauthn/hover_list_model.h | 1 + chrome/browser/ui/webauthn/sheet_models.cc | 18 ------ chrome/browser/ui/webauthn/sheet_models.h | 10 +--- .../ui/webauthn/transport_hover_list_model.cc | 4 ++ .../ui/webauthn/transport_hover_list_model.h | 1 + 17 files changed, 187 insertions(+), 93 deletions(-) Updated tag 'tree_truth' (was 35152ffc73e5)