Back to build
Raw log | Switch to full mode | Login

/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh /b/swarming/w/ir/cache/builder/src src in dir /b/swarming/w/ir/k: allow_subannotations: False cmd: ['/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh', '/b/swarming/w/ir/cache/builder/src', 'src'] env: FrozenDict([('CHROME_HEADLESS', '1')]) env_prefixes: {'mapping': FrozenDict([]), 'pathsep': ':'} env_suffixes: {'mapping': FrozenDict([]), 'pathsep': ':'} infra_step: False name_tokens: ['tree truth steps'] ok_ret: frozenset([0]) trigger_specs: [] full environment: ADDRFAM: inet BOTO_CONFIG: /b/swarming/w/ir/tmp/gsutil-task/.boto BUILDBUCKET_EXPERIMENTAL: FALSE CHROME_HEADLESS: 1 CIPD_CACHE_DIR: /b/swarming/cipd_cache/cache CIPD_PROTOCOL: v2 DEVSHELL_CLIENT_PORT: 37089 DOCKER_CONFIG: /b/swarming/w/ir/tmp/docker-cfg-task DOCKER_TMPDIR: /b/swarming/w/ir/tmp/docker-tmp-task GIT_CONFIG_NOSYSTEM: 1 GIT_TERMINAL_PROMPT: 0 HOME: /home/chrome-bot IFACE: eth0 INFRA_GIT_WRAPPER_HOME: /b/swarming/w/ir/tmp/git-home-task LOGDOG_COORDINATOR_HOST: logs.chromium.org LOGDOG_STREAM_PREFIX: buildbucket/cr-buildbucket.appspot.com/8915179329232731856 LOGDOG_STREAM_PROJECT: chromium LOGDOG_STREAM_SERVER_PATH: unix:/b/swarming/w/ir/tmp/ld.sock LOGICAL: eth0 LUCI_CONTEXT: /b/swarming/w/ir/tmp/luci_context.042753076 MAC_CHROMIUM_TMPDIR: /b/swarming/w/ir/tmp/t METHOD: dhcp NO_GCE_CHECK: False PATH: /b/swarming/w/ir/cipd_bin_packages:/b/swarming/w/ir/cipd_bin_packages/bin:/b/swarming/cipd_cache/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin PWD: /b/swarming/w/ir/k PYTHONIOENCODING: UTF-8 PYTHONUNBUFFERED: 1 ROOT_SETUP_LOG: /var/log/messages/chromebuild/root-setup.log SHLVL: 1 STARTUP_LOG: /var/log/messages/chromebuild/startup.log SWARMING_BOT_ID: swarm1596-c4 SWARMING_EXTERNAL_BOT_SETUP: 1 SWARMING_HEADLESS: 1 SWARMING_SERVER: https://chromium-swarm.appspot.com SWARMING_TASK_ID: 446eba2f2c8d9c11 TEMP: /b/swarming/w/ir/tmp/t TEMPDIR: /b/swarming/w/ir/tmp/t TERM: linux TMP: /b/swarming/w/ir/tmp/t TMPDIR: /b/swarming/w/ir/tmp/t UPSTART_EVENTS: net-device-up UPSTART_INSTANCE: UPSTART_JOB: chromebuild-startup USER: chrome-bot USERNAME: chrome-bot VPYTHON_VIRTUALENV_ROOT: /b/swarming/w/ir/cache/vpython _: /b/swarming/w/ir/cipd_bin_packages/vpython !@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: 09ef820ccf81b4e38eb55dbfe01719ca4fdd8b63 [Fuchsia] Add buffer_collection_id in NativePixmapHandle Sergey Ulanov, Thu Apr 25 19:06:41 2019 +0000 ee92240670ca64adc8260c3a85e2f68ce5e9915d Fix segfault calling GetFocusedFrame on unfocused WebContents Michael Thiessen, Thu Apr 25 19:05:50 2019 +0000 d92895e0f0de5f9b68f675012bcc3b9a8e1008ae Implement range matching for TextUrlFragments Nick Burris, Thu Apr 25 19:05:35 2019 +0000 b0758791f138ecc4e16a23bd3c22ef1d81f35b5c Implement RenderPassDrawQuad fuzzing. Céline O'Neil, Thu Apr 25 19:04:28 2019 +0000 fb22ad21bcbb08e9de086d5f80caa1b2f8cb13cd Omnibox Answer Logging - Add Test Mark Pearson, Thu Apr 25 19:02:55 2019 +0000 bfca1d4b750076847758121e2fe08b6c1642c18d [fuchsia] Remove the chromium.web API Fabrice de Gans-Riberi, Thu Apr 25 19:02:41 2019 +0000 ff0dca0c10e3afc73cbca7f08e27ed996c131eff Added in UMA metrics for UITabHelperOfflineErrors. Sean, Thu Apr 25 19:00:21 2019 +0000 242aefe9f5b04753557f9e5808fef04b36162528 Refactor accessibility focus rings Anastasia Helfinstein, Thu Apr 25 18:59:31 2019 +0000 251aebeeda9a6ee05aa9eb0ef5b79216176d13e1 Sort extensions in menu on page interaction status Peter Boström, Thu Apr 25 18:52:57 2019 +0000 66dbc6e3f3885e1d81e2b782b032c3c583d2eb73 Web Platform Tests: Append comment with instructions for chrome Jarryd Goodman, Thu Apr 25 18:52:25 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit 09ef820ccf81b4e38eb55dbfe01719ca4fdd8b63 Author: Sergey Ulanov <sergeyu@google.com> Date: Thu Apr 25 19:06:41 2019 +0000 [Fuchsia] Add buffer_collection_id in NativePixmapHandle NativePixmapHandle already contained VMO handle on Fuchsia. VMO handle can be used to identify buffers, but sysmem returns VMOs only for buffers for which CPU access was requested and we don't need all buffers to be CPU accessible. The new fields will allow to identify sysmem-allocated buffers without relying on VMO handles. VMO handles are still kept as part of NativePixmapHandle to allow clients access the buffers. Bug: 852011 Change-Id: I147af3de9c8f98c6216003ae19702cb67ab0bfcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576167 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Michael Spang <spang@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#654136} ui/gfx/ipc/gfx_param_traits_macros.h | 4 ++++ ui/gfx/mojo/buffer_types.mojom | 6 ++++++ ui/gfx/mojo/buffer_types_struct_traits.cc | 5 +++++ ui/gfx/mojo/buffer_types_struct_traits.h | 13 +++++++++++++ ui/gfx/native_pixmap_handle.cc | 17 +++++++++++++---- ui/gfx/native_pixmap_handle.h | 13 +++++++++++++ 6 files changed, 54 insertions(+), 4 deletions(-) commit ee92240670ca64adc8260c3a85e2f68ce5e9915d Author: Michael Thiessen <mthiesse@chromium.org> Date: Thu Apr 25 19:05:50 2019 +0000 Fix segfault calling GetFocusedFrame on unfocused WebContents Bug: 951568 Change-Id: Ide2e7e9aff6da1e919bd1f58a8d45c232edccbe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584562 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#654135} content/browser/web_contents/web_contents_android.cc | 5 ++++- .../java/src/org/chromium/content_public/browser/WebContents.java | 3 ++- 2 files changed, 6 insertions(+), 2 deletions(-) commit d92895e0f0de5f9b68f675012bcc3b9a8e1008ae Author: Nick Burris <nburris@chromium.org> Date: Thu Apr 25 19:05:35 2019 +0000 Implement range matching for TextUrlFragments Implement range matching in TextFragmentFinder. The parsing of the endText string is already implemented. TextFragmentFinder now checks if the end text is present in the TextFragmentSelector, searches for the first occurrence after it finds the start text, and returns the total range. Bug: 924964 Change-Id: Ifa913d1aef8d3406c1133608842c5a7d710f9f14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573814 Reviewed-by: David Bokan <bokan@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#654134} .../core/page/scrolling/text_fragment_anchor.cc | 4 +- .../page/scrolling/text_fragment_anchor_test.cc | 221 +++++++++++++++++++++ .../core/page/scrolling/text_fragment_finder.cc | 59 ++++-- .../core/page/scrolling/text_fragment_finder.h | 3 - 4 files changed, 265 insertions(+), 22 deletions(-) commit b0758791f138ecc4e16a23bd3c22ef1d81f35b5c Author: Céline O'Neil <celineo@google.com> Date: Thu Apr 25 19:04:28 2019 +0000 Implement RenderPassDrawQuad fuzzing. This CL introduces RenderPassDrawQuads to the fuzzable quad types. It does not yet fuzz masks/filters. R=kylechar@chromium.org, riajiang@chromium.org Bug: 923088 Change-Id: Ia3c8331c3c8093aff5842d4d23ad6338c1a8897c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566363 Commit-Queue: Céline O'Neil <celineo@google.com> Reviewed-by: kylechar <kylechar@chromium.org> Reviewed-by: Ria Jiang <riajiang@chromium.org> Auto-Submit: Céline O'Neil <celineo@google.com> Cr-Commit-Position: refs/heads/master@{#654133} .../viz/service/compositor_frame_fuzzer/BUILD.gn | 3 + .../compositor_frame_fuzzer.proto | 11 +- .../compositor_frame_fuzzer_util.cc | 95 +++++++- .../compositor_frame_fuzzer_util.h | 9 +- .../nested_render_pass_draw_quads.asciipb | 171 ++++++++++++++ ...rlapping_quads_in_render_pass_draw_quad.asciipb | 249 +++++++++++++++++++++ 6 files changed, 528 insertions(+), 10 deletions(-) commit fb22ad21bcbb08e9de086d5f80caa1b2f8cb13cd Author: Mark Pearson <mpearson@chromium.org> Date: Thu Apr 25 19:02:55 2019 +0000 Omnibox Answer Logging - Add Test Requested follow-up from https://chromium.googlesource.com/chromium/src.git/+/80d72d8cd21cf76df583e29676b987ac1e3b90e9 Bug: 950344 Change-Id: If96bf162fc230a6a1fb9d5460748e10d48bacf2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582451 Auto-Submit: Mark Pearson <mpearson@chromium.org> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#654132} components/omnibox/browser/suggestion_answer.cc | 8 ++++-- components/omnibox/browser/suggestion_answer.h | 3 +++ .../omnibox/browser/suggestion_answer_unittest.cc | 29 ++++++++++++++++++++++ 3 files changed, 38 insertions(+), 2 deletions(-) commit bfca1d4b750076847758121e2fe08b6c1642c18d Author: Fabrice de Gans-Riberi <fdegans@chromium.org> Date: Thu Apr 25 19:02:41 2019 +0000 [fuchsia] Remove the chromium.web API Bug: 946732 Change-Id: Ib7d4f62dcef88770a3516506d19ad2bdfb12f91d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580464 Reviewed-by: Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#654131} fuchsia/BUILD.gn | 20 --- fuchsia/engine/BUILD.gn | 12 -- fuchsia/engine/legacy_message_port_bridge.cc | 94 ------------- fuchsia/engine/legacy_message_port_bridge.h | 47 ------- fuchsia/fidl/cast/cast_channel.fidl | 6 - fuchsia/fidl/web/context.fidl | 14 -- fuchsia/fidl/web/context_provider.fidl | 31 ----- fuchsia/fidl/web/frame.fidl | 168 ------------------------ fuchsia/fidl/web/navigation_controller.fidl | 71 ---------- fuchsia/fidl/web/navigation_event_observer.fidl | 25 ---- 10 files changed, 488 deletions(-) commit ff0dca0c10e3afc73cbca7f08e27ed996c131eff Author: Sean <harrisonsean@chromium.org> Date: Thu Apr 25 19:00:21 2019 +0000 Added in UMA metrics for UITabHelperOfflineErrors. Bug: 955471 Change-Id: I6185fe047d762961940b082ad33627deef3a290e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578187 Reviewed-by: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Robert Ogden <robertogden@chromium.org> Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#654130} chrome/browser/previews/previews_ui_tab_helper.cc | 3 ++- tools/metrics/histograms/histograms.xml | 10 ++++++++++ 2 files changed, 12 insertions(+), 1 deletion(-) commit 242aefe9f5b04753557f9e5808fef04b36162528 Author: Anastasia Helfinstein <anastasi@google.com> Date: Thu Apr 25 18:59:31 2019 +0000 Refactor accessibility focus rings This is a pure refactor, with no functional change. Bug: 955783 Change-Id: I3c88bbda768f5ac863c7994e75a3c2a92ceca366 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583443 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#654129} ash/accessibility/accessibility_focus_ring.cc | 208 +++++++++++++-------- ash/accessibility/accessibility_focus_ring.h | 1 + .../accessibility_focus_ring_group_unittest.cc | 45 +++++ 3 files changed, 175 insertions(+), 79 deletions(-) commit 251aebeeda9a6ee05aa9eb0ef5b79216176d13e1 Author: Peter Boström <pbos@chromium.org> Date: Thu Apr 25 18:52:57 2019 +0000 Sort extensions in menu on page interaction status This groups extensions into three buckets: * Extensions that are accessing (can access) the page's data * Extensions that want to access the page's data * Extensions that can't access the page's data Labels are used as headings for each of these three buckets. No label is added for groups that don't have a corresponding extension. Bug: chromium:943702 Change-Id: I055f5f8824b65f2833f9d78b1f4289e28aad630e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577590 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#654128} chrome/app/generated_resources.grd | 9 +++ .../extensions/extension_action_view_controller.h | 17 +--- .../toolbar/test_toolbar_action_view_controller.cc | 6 ++ .../toolbar/test_toolbar_action_view_controller.h | 2 + .../ui/toolbar/toolbar_action_view_controller.h | 18 ++++- .../ui/views/extensions/extensions_menu_view.cc | 93 +++++++++++++++++++--- .../ui/views/extensions/extensions_menu_view.h | 1 + 7 files changed, 120 insertions(+), 26 deletions(-) commit 66dbc6e3f3885e1d81e2b782b032c3c583d2eb73 Author: Jarryd Goodman <jarrydg@chromium.org> Date: Thu Apr 25 18:52:25 2019 +0000 Web Platform Tests: Append comment with instructions for chrome The comment, as is today, only describes which flags to pass to V8 but now how to pass the flag to V8 when launching chrome. This change adds a little more color and should save developers time that would have been spent researching how to pass V8 flags from chrome launch. Change-Id: I9daa5e6e1089de2dc52248958d0320f03beea83a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584583 Auto-Submit: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by: Robert Ma <robertma@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#654127} third_party/blink/web_tests/external/wpt/streams/resources/test-utils.js | 1 + 1 file changed, 1 insertion(+) commit 306740d353a504ac480547d30515f11533b5df49 Author: Chris Hamilton <chrisha@chromium.org> Date: Thu Apr 25 18:48:36 2019 +0000 Integrate PendingTask::ipc_program_counter into logging messages. BUG=950668 Change-Id: I42f8a39523a3376e40ae42ba77f194792cbaf65f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582767 Reviewed-by: François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Auto-Submit: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#654126} base/logging.cc | 11 +++++++++++ 1 file changed, 11 insertions(+) commit 36789e49f6db2762b3b2afee2cd438522fe35ab9 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Apr 25 18:47:10 2019 +0000 Roll src/third_party/skia 27966fe16b80..8413ff13fefa (3 commits) https://skia.googlesource.com/skia.git/+log/27966fe16b80..8413ff13fefa git log 27966fe16b80..8413ff13fefa --date=short --no-merges --format='%ad %ae %s' 2019-04-25 mtklein@google.com SKIA_IMPLEMENTATION is only relevant in shared builds 2019-04-25 fmalita@chromium.org [skottie] Parented camera support 2019-04-25 brianosman@google.com Add SkSL editing to Viewer in Vulkan backend Created with: gclient setdep -r src/third_party/skia@8413ff13fefa The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@chromium.org Change-Id: Ide71009eeffc214046a61e9a42743fc65c66eb2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584604 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#654125} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 12a7fa9ac33f6bbef55bd2c13bf6bb187102b046 Author: Marijn Kruisselbrink <mek@chromium.org> Date: Thu Apr 25 18:46:37 2019 +0000 [File System API] Add more documentation for internal workings. Bug: None Change-Id: I8704bca5522850cfe86604179c40e7f90f3922e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583243 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Auto-Submit: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#654124} storage/browser/fileapi/README.md | 133 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 133 insertions(+) commit b7f92167110a738b074a3e9fb76828956250c9e2 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Apr 25 18:46:04 2019 +0000 Roll src/third_party/webrtc f204fafdb42f..ff727a8abb36 (4 commits) https://webrtc.googlesource.com/src.git/+log/f204fafdb42f..ff727a8abb36 git log f204fafdb42f..ff727a8abb36 --date=short --no-merges --format='%ad %ae %s' 2019-04-25 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 79fba5843c..f41f385816 (653914:654026) 2019-04-25 aleloi@webrtc.org Encoder side of Multistream Opus. 2019-04-25 sprang@webrtc.org Consolidate mock video encoders 2019-04-25 nisse@webrtc.org Delete WebRtcRTPHeader, this struct is no longer used. Created with: gclient setdep -r src/third_party/webrtc@ff727a8abb36 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Idd3b21e594fca498b5f32c7a54865080e6d48702 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584605 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#654123} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit b92892fb34ddffaf6fc95ac0398164473195bad0 Author: Maksim Ivanov <emaxx@chromium.org> Date: Thu Apr 25 18:44:52 2019 +0000 Cert utils for challenge-response login keys Add a helper function that builds the ChallengeResponseKey object based on the public key information in the specified certificate. This will be used for challenge-response logins (a.k.a. smart card login) as higher-level APIs will identify the user with the certificate, while the lower-level APIs (such as the cryptohomed D-Bus API) only deal with public keys and signature algorithms. BUG=chromium:826417 TEST=chromeos_unittests --gtest_filter=ChallengeResponseCertUtilsTest* Change-Id: Ie1ac1e9b13e44748f98aad4a0ac69df0e638e70f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1107058 Reviewed-by: Matt Mueller <mattm@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#654122} chromeos/login/auth/BUILD.gn | 5 ++ .../login/auth/challenge_response/cert_utils.cc | 54 +++++++++++++++++++ .../login/auth/challenge_response/cert_utils.h | 30 +++++++++++ .../auth/challenge_response/cert_utils_unittest.cc | 62 ++++++++++++++++++++++ 4 files changed, 151 insertions(+) commit 5da1af37d43557d515da60aff1e7bb57967f402b Author: Bruno Santos <brunoad@chromium.org> Date: Thu Apr 25 18:39:38 2019 +0000 Add launchIntent method to App Controller service. New method allows KioskNextHome to launch ARC intents. The intents will be checked via IntentConfigHelper which parses and enforces the config from a JSON resource file. Bug: 927809 Change-Id: Ibfd8b4ec5a2010c5a8b39b3cad4cd1bd97aa8cdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570426 Commit-Queue: Bruno Santos <brunoad@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#654121} chrome/browser/chromeos/BUILD.gn | 3 + .../kiosk_next_home/app_controller_service.cc | 48 +++++-- .../kiosk_next_home/app_controller_service.h | 9 ++ .../app_controller_service_unittest.cc | 78 +++++++++- .../kiosk_next_home/intent_config_helper.cc | 158 +++++++++++++++++++++ .../kiosk_next_home/intent_config_helper.h | 77 ++++++++++ .../intent_config_helper_unittest.cc | 138 ++++++++++++++++++ .../kiosk_next_home/mojom/app_controller.mojom | 5 + .../resources/chromeos/kiosk_next_home/api.js | 9 ++ .../resources/chromeos/kiosk_next_home/api_impl.js | 9 ++ .../chromeos/kiosk_next_home/intent_config.json | 5 + .../kiosk_next_home/kiosk_next_resources.grdp | 1 + 12 files changed, 525 insertions(+), 15 deletions(-) commit 4c32470add0b628ad3859f3983adae0865fe79bd Author: Tina Wang <tinazwang@chromium.org> Date: Thu Apr 25 18:35:15 2019 +0000 [SendTabToSelf] Add omnibox icon animation - The icon will slides in with "Send" label when the valid url is highlighted at the first time. - The icon will slides out and remain an icon to the right side of the omnibox. - The icon will remain if the url is valid, even after the sharing action of the user. Bug: 950388 Change-Id: Icbe7bc5806d6bc8e38c62a8eba9794b2900db16e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555501 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: sebsg <sebsg@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#654120} chrome/app/generated_resources.grd | 8 ++- .../IDS_OMNIBOX_ICON_SEND_TAB_TO_SELF.png.sha1 | 1 + .../IDS_OMNIBOX_TOOLTIP_SEND_TAB_TO_SELF.png.sha1 | 1 + chrome/app/vector_icons/BUILD.gn | 1 + chrome/app/vector_icons/send_tab_to_self.icon | 42 +++++++++++++ chrome/browser/ui/BUILD.gn | 2 + .../ui/autofill/payments/autofill_ui_util.cc | 1 + chrome/browser/ui/browser_command_controller.cc | 4 ++ .../ui/page_action/page_action_icon_container.h | 1 + .../ui/views/location_bar/location_bar_view.cc | 7 +++ .../browser/ui/views/omnibox/omnibox_view_views.cc | 12 +++- .../omnibox_page_action_icon_container_view.cc | 8 +++ .../omnibox_page_action_icon_container_view.h | 5 ++ .../ui/views/page_action/page_action_icon_view.cc | 6 ++ .../ui/views/page_action/page_action_icon_view.h | 3 + chrome/browser/ui/views/send_tab_to_self/OWNERS | 3 + .../ui/views/send_tab_to_self/share_icon_view.cc | 70 ++++++++++++++++++++++ .../ui/views/send_tab_to_self/share_icon_view.h | 42 +++++++++++++ 18 files changed, 215 insertions(+), 2 deletions(-) Updated tag 'tree_truth' (was 2ba607d58c14)