Back to build
Raw log | Switch to full mode | Login

/b/s/w/ir/cache/builder/src/build/tree_truth.sh /b/s/w/ir/cache/builder/src src in dir /b/s/w/ir/k: allow_subannotations: False cmd: ['/b/s/w/ir/cache/builder/src/build/tree_truth.sh', '/b/s/w/ir/cache/builder/src', 'src'] env: FrozenDict([('CHROME_HEADLESS', '1')]) env_prefixes: {'mapping': FrozenDict([]), 'pathsep': ':'} env_suffixes: {'mapping': FrozenDict([]), 'pathsep': ':'} infra_step: False name_tokens: ['tree truth steps'] ok_ret: frozenset([0]) trigger_specs: [] full environment: BOTO_CONFIG: /b/s/w/ir/tmp/gsutil-task/.boto BUILDBUCKET_EXPERIMENTAL: FALSE CHROME_HEADLESS: 1 CIPD_CACHE_DIR: /b/s/cipd_cache/cache CIPD_PROTOCOL: v2 DEVSHELL_CLIENT_PORT: 34923 DOCKER_CONFIG: /b/s/w/ir/tmp/docker-cfg-task DOCKER_TMPDIR: /b/s/w/ir/tmp/docker-tmp-task GIT_CONFIG_NOSYSTEM: 1 GIT_TERMINAL_PROMPT: 0 HOME: /home/chrome-bot INFRA_GIT_WRAPPER_HOME: /b/s/w/ir/tmp/git-home-task LOGDOG_COORDINATOR_HOST: logs.chromium.org LOGDOG_STREAM_PREFIX: buildbucket/cr-buildbucket.appspot.com/8915179046147914512 LOGDOG_STREAM_PROJECT: chromium LOGDOG_STREAM_SERVER_PATH: unix:/b/s/w/ir/tmp/ld.sock LOGNAME: chrome-bot LUCI_CONTEXT: /b/s/w/ir/tmp/luci_context.563794197 MAC_CHROMIUM_TMPDIR: /b/s/w/ir/tmp/t MAIL: /var/mail/chrome-bot NO_GCE_CHECK: False PATH: /b/s/w/ir/cipd_bin_packages:/b/s/w/ir/cipd_bin_packages/bin:/b/s/cipd_cache/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin PWD: /b/s/w/ir/k PYTHONIOENCODING: UTF-8 PYTHONUNBUFFERED: 1 SHELL: /bin/bash SHLVL: 1 SUDO_COMMAND: /usr/bin/python /b/s/swarming_bot.zip start_bot SUDO_GID: 0 SUDO_UID: 0 SUDO_USER: root SWARMING_BOT_ID: luci-chromium-ci-trusty-8-4-k408 SWARMING_EXTERNAL_BOT_SETUP: 1 SWARMING_HEADLESS: 1 SWARMING_SERVER: https://chromium-swarm.appspot.com SWARMING_TASK_ID: 446ebe4a62925211 TEMP: /b/s/w/ir/tmp/t TEMPDIR: /b/s/w/ir/tmp/t TERM: linux TMP: /b/s/w/ir/tmp/t TMPDIR: /b/s/w/ir/tmp/t USER: chrome-bot USERNAME: chrome-bot VPYTHON_VIRTUALENV_ROOT: /b/s/w/ir/cache/vpython _: /b/s/w/ir/cipd_bin_packages/vpython !@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: 5da1af37d43557d515da60aff1e7bb57967f402b Add launchIntent method to App Controller service. Bruno Santos, Thu Apr 25 18:39:38 2019 +0000 4c32470add0b628ad3859f3983adae0865fe79bd [SendTabToSelf] Add omnibox icon animation Tina Wang, Thu Apr 25 18:35:15 2019 +0000 2ba607d58c1476513dbd85d667d43e68618653a6 Update watchlist for the team Tarun Bansal, Thu Apr 25 18:30:52 2019 +0000 1992ca9937b6caa6f59a44ae29cdd0e8b565ad8d Add nikunjb to base/metrics, component/metrics and browser/metrics OWNERS file Nikunj Bhagat, Thu Apr 25 18:29:08 2019 +0000 3b06acce01851078c171e97d7480b8b719e7f6d9 Add partitioned native library generation tooling Christopher Grant, Thu Apr 25 18:26:41 2019 +0000 257520ecae10fbe80e30254fcdaa85b2ae46215a Add allowobfuscation to async proguard flags and applymapping to build Anthony Cui, Thu Apr 25 18:26:22 2019 +0000 3d0515e64ce8b16dfd04b9768e5ca53253a666f2 [DeviceSync v2] Add CryptAuthFeatureType enum and utils Josh Nohle, Thu Apr 25 18:24:30 2019 +0000 070651a73c9fa9cb5dae6e19023b3ddc1eaee87f Roll src-internal f7525b57b34a..34471d8b8ea8 (2 commits) chromium-internal-autoroll, Thu Apr 25 18:21:14 2019 +0000 13dc9dde6343f806aa9abd1b6f2f9331b653e90f Roll src/third_party/swiftshader 2527b4d22fb7..3c203531c7d7 (1 commits) chromium-autoroll, Thu Apr 25 18:20:42 2019 +0000 1230b7902746c335c936089e9ed3bb4090ac17fe Add the set of Google Trust Services' recommended roots for remoting Yuwei Huang, Thu Apr 25 18:19:13 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit 5da1af37d43557d515da60aff1e7bb57967f402b Author: Bruno Santos <brunoad@chromium.org> Date: Thu Apr 25 18:39:38 2019 +0000 Add launchIntent method to App Controller service. New method allows KioskNextHome to launch ARC intents. The intents will be checked via IntentConfigHelper which parses and enforces the config from a JSON resource file. Bug: 927809 Change-Id: Ibfd8b4ec5a2010c5a8b39b3cad4cd1bd97aa8cdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570426 Commit-Queue: Bruno Santos <brunoad@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#654121} chrome/browser/chromeos/BUILD.gn | 3 + .../kiosk_next_home/app_controller_service.cc | 48 +++++-- .../kiosk_next_home/app_controller_service.h | 9 ++ .../app_controller_service_unittest.cc | 78 +++++++++- .../kiosk_next_home/intent_config_helper.cc | 158 +++++++++++++++++++++ .../kiosk_next_home/intent_config_helper.h | 77 ++++++++++ .../intent_config_helper_unittest.cc | 138 ++++++++++++++++++ .../kiosk_next_home/mojom/app_controller.mojom | 5 + .../resources/chromeos/kiosk_next_home/api.js | 9 ++ .../resources/chromeos/kiosk_next_home/api_impl.js | 9 ++ .../chromeos/kiosk_next_home/intent_config.json | 5 + .../kiosk_next_home/kiosk_next_resources.grdp | 1 + 12 files changed, 525 insertions(+), 15 deletions(-) commit 4c32470add0b628ad3859f3983adae0865fe79bd Author: Tina Wang <tinazwang@chromium.org> Date: Thu Apr 25 18:35:15 2019 +0000 [SendTabToSelf] Add omnibox icon animation - The icon will slides in with "Send" label when the valid url is highlighted at the first time. - The icon will slides out and remain an icon to the right side of the omnibox. - The icon will remain if the url is valid, even after the sharing action of the user. Bug: 950388 Change-Id: Icbe7bc5806d6bc8e38c62a8eba9794b2900db16e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555501 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: sebsg <sebsg@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#654120} chrome/app/generated_resources.grd | 8 ++- .../IDS_OMNIBOX_ICON_SEND_TAB_TO_SELF.png.sha1 | 1 + .../IDS_OMNIBOX_TOOLTIP_SEND_TAB_TO_SELF.png.sha1 | 1 + chrome/app/vector_icons/BUILD.gn | 1 + chrome/app/vector_icons/send_tab_to_self.icon | 42 +++++++++++++ chrome/browser/ui/BUILD.gn | 2 + .../ui/autofill/payments/autofill_ui_util.cc | 1 + chrome/browser/ui/browser_command_controller.cc | 4 ++ .../ui/page_action/page_action_icon_container.h | 1 + .../ui/views/location_bar/location_bar_view.cc | 7 +++ .../browser/ui/views/omnibox/omnibox_view_views.cc | 12 +++- .../omnibox_page_action_icon_container_view.cc | 8 +++ .../omnibox_page_action_icon_container_view.h | 5 ++ .../ui/views/page_action/page_action_icon_view.cc | 6 ++ .../ui/views/page_action/page_action_icon_view.h | 3 + chrome/browser/ui/views/send_tab_to_self/OWNERS | 3 + .../ui/views/send_tab_to_self/share_icon_view.cc | 70 ++++++++++++++++++++++ .../ui/views/send_tab_to_self/share_icon_view.h | 42 +++++++++++++ 18 files changed, 215 insertions(+), 2 deletions(-) commit 2ba607d58c1476513dbd85d667d43e68618653a6 Author: Tarun Bansal <tbansal@chromium.org> Date: Thu Apr 25 18:30:52 2019 +0000 Update watchlist for the team Change-Id: I54f9b8df149b8b2678d8f1ddfe5463e096d11c83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584606 Reviewed-by: Doug Arnett <dougarnett@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#654119} WATCHLISTS | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) commit 1992ca9937b6caa6f59a44ae29cdd0e8b565ad8d Author: Nikunj Bhagat <nikunjb@chromium.org> Date: Thu Apr 25 18:29:08 2019 +0000 Add nikunjb to base/metrics, component/metrics and browser/metrics OWNERS file Change-Id: I734a9acb0497e75dfffc461d5f6e73626be6edad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545224 Commit-Queue: Nik Bhagat <nikunjb@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#654118} base/metrics/OWNERS | 1 + 1 file changed, 1 insertion(+) commit 3b06acce01851078c171e97d7480b8b719e7f6d9 Author: Christopher Grant <cjgrant@chromium.org> Date: Thu Apr 25 18:26:41 2019 +0000 Add partitioned native library generation tooling This change builds on the prototype posted by pcc@, here: http://crrev.com/c/1521283 The partitioned_shared_library GN template may be used in place of shared_library to create a set of libraries linked simultaneously. This will be leveraged in later changes to split code into Android dynamic feature modules. The current change adds the GN template for the set of partitions, along with the Python wrapper script invoked by GN. Bug: 921663 Change-Id: I805d598b03ae15bd4ceeb8e915526ed8b15af4cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568772 Reviewed-by: Peter Collingbourne <pcc@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#654117} build/extract_partition.py | 51 +++++++++++++ build/partitioned_shared_library.gni | 131 ++++++++++++++++++++++++++++++++++ build/toolchain/gcc_solink_wrapper.py | 28 ++++++++ build/toolchain/gcc_toolchain.gni | 2 +- 4 files changed, 211 insertions(+), 1 deletion(-) commit 257520ecae10fbe80e30254fcdaa85b2ae46215a Author: Anthony Cui <cuianthony@google.com> Date: Thu Apr 25 18:26:22 2019 +0000 Add allowobfuscation to async proguard flags and applymapping to build Added allowobfuscation to keep rules Specified async dex targets as dependent on synchronous dex target Passed synchronous proguarding run mapping file to be used by async proguarding runs via -applymapping option Bug: 952858 Change-Id: I6e5b0f215db46e961e2710f15590b6f2b69d58b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580900 Commit-Queue: Anthony Cui <cuianthony@google.com> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#654116} build/android/constant_pool_refs_to_keep_rules.py | 6 +- build/config/android/internal_rules.gni | 11 + build/config/android/rules.gni | 30 +- chrome/android/features/vr/proguard_async.flags | 1334 ++++++++++----------- 4 files changed, 702 insertions(+), 679 deletions(-) commit 3d0515e64ce8b16dfd04b9768e5ca53253a666f2 Author: Josh Nohle <nohle@google.com> Date: Thu Apr 25 18:24:30 2019 +0000 [DeviceSync v2] Add CryptAuthFeatureType enum and utils Enumerates the feature types used by CryptAuth v2 DeviceSync's BatchGetFeatureStatuses, BatchSetFeatureStatuses, and BatchNotifyGroupDevices. Each enum value is uniquely mapped to a string used in the protos and understood by CryptAuth. We include create utility functions to handle these conversions. Example: The following FeatureStatus messages received in a BatchGetFeatureStatuses response would indicate that BetterTogetherHost is supported but not enabled: [ message FeatureStatus { string feature_type = "BetterTogetherHostSupported"; bool enabled = true; }, message FeatureStatus { string feature_type = "BetterTogetherHostEnabled"; bool enabled = false; } ] Bug: 951969 Change-Id: I4e8f649acd29adf735dcf3f7eb456da7aa2f236d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584403 Auto-Submit: Josh Nohle <nohle@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#654115} chromeos/services/device_sync/BUILD.gn | 2 + .../services/device_sync/cryptauth_feature_type.cc | 95 ++++++++++++++++++++++ .../services/device_sync/cryptauth_feature_type.h | 80 ++++++++++++++++++ 3 files changed, 177 insertions(+) commit 070651a73c9fa9cb5dae6e19023b3ddc1eaee87f Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Thu Apr 25 18:21:14 2019 +0000 Roll src-internal f7525b57b34a..34471d8b8ea8 (2 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f7525b57b34a..34471d8b8ea8 Created with: gclient setdep -r src-internal@34471d8b8ea8 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=cmumford@chromium.org,gab@chromium.org,droger@chromium.org Change-Id: Ia6c5553c311c9a2756994d87846f05f3e4f5263a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584741 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#654114} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 13dc9dde6343f806aa9abd1b6f2f9331b653e90f Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Apr 25 18:20:42 2019 +0000 Roll src/third_party/swiftshader 2527b4d22fb7..3c203531c7d7 (1 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/2527b4d22fb7..3c203531c7d7 git log 2527b4d22fb7..3c203531c7d7 --date=short --no-merges --format='%ad %ae %s' 2019-04-25 chrisforbes@google.com Wire up texture swizzles Created with: gclient setdep -r src/third_party/swiftshader@3c203531c7d7 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/129523279 TBR=swiftshader-team+autoroll@chromium.org Change-Id: Ida661b6613002b95c78ed6f6191126f53e196b0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584409 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#654113} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 1230b7902746c335c936089e9ed3bb4090ac17fe Author: Yuwei Huang <yuweih@chromium.org> Date: Thu Apr 25 18:19:13 2019 +0000 Add the set of Google Trust Services' recommended roots for remoting This CL is modified from http://crrev.com/c/1577487 Google maintains a set of recommended trust anchors for talking only to Google services, now or in the future. This set is maintained at https://pki.goog/roots.pem, as documented at https://pki.goog/faq.html. Remoting wishes to speak to Google services using gRPC, and thus needs a way to configure gRPC's certificate validation. This imports that trust set for purposes of gRPC. Bug: 955058 Change-Id: Ic7e44baed25e9192a9df8d01d9849e6a3adcfc23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577784 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by: Chris Palmer <palmer@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#654112} remoting/base/DEPS | 1 + remoting/base/grpc_support/BUILD.gn | 2 +- remoting/base/grpc_support/grpc_channel.cc | 10 +- remoting/base/grpc_support/root_certs_prod.inc | 1424 --------------------- third_party/google_trust_services/BUILD.gn | 13 + third_party/google_trust_services/METADATA | 16 + third_party/google_trust_services/OWNERS | 3 + third_party/google_trust_services/README.chromium | 21 + third_party/google_trust_services/src/LICENSE | 27 + third_party/google_trust_services/src/roots.cc | 907 +++++++++++++ third_party/google_trust_services/src/roots.h | 11 + 11 files changed, 1003 insertions(+), 1432 deletions(-) commit 725db8be204fc46c54413779e2aefae46956b96c Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Apr 25 18:18:59 2019 +0000 Roll src/third_party/catapult 048ac4c46166..58d22d158bab (1 commits) https://chromium.googlesource.com/catapult.git/+log/048ac4c46166..58d22d158bab git log 048ac4c46166..58d22d158bab --date=short --no-merges --format='%ad %ae %s' 2019-04-25 eroman@chromium.org Pretty print base64 encoded "bytes" parameters. Created with: gclient setdep -r src/third_party/catapult@58d22d158bab The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:955574 TBR=crouleau@chromium.org Change-Id: I64e90feef547f4bda24a12164939da4e1f1ff637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584740 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#654111} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 4df69e7d6944e8a80c488c023785ad2bf81f5d21 Author: Koji Ishii <kojii@chromium.org> Date: Thu Apr 25 18:16:23 2019 +0000 DebugVisualizers: Fix base::Optional r531722 (crrev.com/c/883946) renamed `is_null_` to `is_populated_`. This patch fixes chrome.nativs to match to the new name. Change-Id: Ief8bb4faf90b94a6ca1a4dbd61a5f37bce37273b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584519 Auto-Submit: Koji Ishii <kojii@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#654110} tools/win/DebugVisualizers/chrome.natvis | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) commit e2aaf99178aafac584c8f0db5db2f08579be8d2d Author: Dan Elphick <delphick@chromium.org> Date: Thu Apr 25 18:11:08 2019 +0000 [v8] Fix uses of deprecated Object::Set/Get in fuchsia tests Always use the Context variant of Set/Get and check their return values. Bug: v8:7283 Change-Id: I948a4ef9e5cf7f8ca7b3debd22e968ac33d37b9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583785 Auto-Submit: Dan Elphick <delphick@chromium.org> Commit-Queue: Wez <wez@chromium.org> Reviewed-by: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#654109} .../fuchsia/fidlgen_js/test/fidlgen_js_unittest.cc | 85 ++++++++++++++++------ 1 file changed, 61 insertions(+), 24 deletions(-) commit ee9631f9ad86c0b926168cbefc151dd2fa7bfac2 Author: Ken Rockot <rockot@google.com> Date: Thu Apr 25 18:09:34 2019 +0000 [mojo-bindings] Move some unittest files around These will be heavily modified in a follow-up CL and should also be renamed to reflect the changes in what they cover (new types instead of old types). This does the rename seprately so that the diffs in the follow-up CL are clearer. Bug: 955171 Change-Id: Ica24749cce65f163ba9a9fee3994b9ad37ab14ba TBR: oksamyt@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581161 Reviewed-by: Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#654108} mojo/public/cpp/bindings/tests/BUILD.gn | 8 ++++---- ...binding_callback_unittest.cc => receiver_callback_unittest.cc} | 0 .../tests/{binding_set_unittest.cc => receiver_set_unittest.cc} | 0 .../bindings/tests/{binding_unittest.cc => receiver_unittest.cc} | 0 .../tests/{interface_ptr_unittest.cc => remote_unittest.cc} | 0 5 files changed, 4 insertions(+), 4 deletions(-) commit 958f7fc01e9c3d0c5d617c7aa53a2e26fa58736a Author: Robert Ogden <robertogden@chromium.org> Date: Thu Apr 25 18:06:06 2019 +0000 Remove chrome proxy ChromeDriver tests that do not run below M70 Change-Id: Ib23cebb278918266ffe3822d3458e67fc55dfbf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584599 Reviewed-by: Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#654107} tools/chrome_proxy/webdriver/bypass.py | 38 ----- tools/chrome_proxy/webdriver/fallback.py | 34 ---- tools/chrome_proxy/webdriver/lite_page.py | 117 ------------- tools/chrome_proxy/webdriver/lofi.py | 265 ------------------------------ 4 files changed, 454 deletions(-) commit f35ff83efa0e9fe06ca345cfa55afeb2050c917b Author: Aaron Colwell <acolwell@google.com> Date: Thu Apr 25 18:05:43 2019 +0000 Fix BrowsingInstance::GetSiteForURL() to use const GURL&. Fixing a typo that accidentally got committed in http://crrev.com/c/1582275. Change-Id: I7ef67f002090c0ec091f093fce7a847c6e3b93cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584430 Auto-Submit: Aaron Colwell <acolwell@chromium.org> Commit-Queue: Aaron Colwell <acolwell@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#654106} content/browser/browsing_instance.cc | 2 +- content/browser/browsing_instance.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit ea91b807dc58bafcf33163873aa15362f1a803fd Author: Céline O'Neil <celineo@google.com> Date: Thu Apr 25 18:00:57 2019 +0000 Clean up and refactor CompositorFrame fuzzer helper methods. Refactor the task of constructing a CompositorFrame into a builder class, which will make it easier going forward to modularize the utility code while keeping state such as allocated memory. Additionally, a few other usability changes (adding optional logging and making some protobuf fields optional with sensible defaults). R=kylechar@chromium.org, riajiang@chromium.org Bug: 923088 Change-Id: I10810b9bbf00bc5c5fb25cd3e418597279d7e047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580045 Reviewed-by: kylechar <kylechar@chromium.org> Commit-Queue: Céline O'Neil <celineo@google.com> Auto-Submit: Céline O'Neil <celineo@google.com> Cr-Commit-Position: refs/heads/master@{#654105} .../compositor_frame_fuzzer.cc | 20 +- .../compositor_frame_fuzzer.proto | 6 +- .../compositor_frame_fuzzer_util.cc | 223 +++++++++++++-------- .../compositor_frame_fuzzer_util.h | 77 ++++++- 4 files changed, 225 insertions(+), 101 deletions(-) commit 07aaf1f9a77b4023da1c9327d6fdf409a4d927aa Author: David Black <dmblack@google.com> Date: Thu Apr 25 17:59:53 2019 +0000 Remove banned initializer list usage in Assistant. Bug: 956581 Change-Id: I6328e3d6a7f75b232094e14507d0c5614277ccfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584468 Reviewed-by: Tao Wu <wutao@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#654104} ash/assistant/ui/main_stage/assistant_progress_indicator.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 2ed6f9c665726020f4d805e008256c9f614810e7 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Thu Apr 25 17:57:52 2019 +0000 A tiny optimization in PAC::UpdateRenderSurfaceForEffects() Check the lightweight condition first. Change-Id: I92e4372395154b53a9c964bb00d6b030b1c770fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584679 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#654103} .../platform/graphics/compositing/paint_artifact_compositor.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 51a49c0d44ecd95360a8c698f8cfb1e1d23e8826 Author: Carlos Caballero <carlscab@google.com> Date: Thu Apr 25 17:57:30 2019 +0000 Rename ScopedTaskEnvironment::ExecutionMode ScopedTaskEnvironment::ExecutionMode is becoming ScopedTaskEnvironment::ThreadPoolExecutionMode This CL was uploaded by git cl split. R=khorimoto@chromium.org Bug: 708584 Change-Id: I4f611ce69915156b5463f90a4ac39e4ae36fea88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583748 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#654102} chromeos/components/nearby/submittable_executor_base_unittest.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit db8940d5c6646cc3201b146bf4c606160edeeca8 Author: Aneesh Ali Nainamvalappil Cheriyakath <aneeshali@google.com> Date: Thu Apr 25 17:54:38 2019 +0000 [Autofill] Split CardUploadEnabled by sync status The metrics for checking the card upload enabled/disabled cases need to be broken down to submetrics. These submetrics will be based on the sync signin state of the user. This exercise is to figure out why there is a high number of SYNC_SERVICE_MISSING_AUTOFILL_WALLET_DATA_ACTIVE_TYPE (40-45%) reasons for disabling the card upload option for the user. Bug: 951190 Change-Id: Idc1c01505fe65436712d69c453b6420cecac93a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581986 Commit-Queue: Aneesh Ali Nainamvalappil Cheriyakath <aneeshali@google.com> Reviewed-by: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#654101} .../autofill/core/browser/autofill_experiments.cc | 42 +++--- .../autofill/core/browser/autofill_experiments.h | 4 +- .../core/browser/autofill_experiments_unittest.cc | 141 +++++++++++++++++---- .../autofill/core/browser/autofill_metrics.cc | 10 +- .../autofill/core/browser/autofill_metrics.h | 3 +- .../browser/payments/credit_card_save_manager.cc | 3 +- tools/metrics/histograms/histograms.xml | 1 + 7 files changed, 157 insertions(+), 47 deletions(-) commit 93a29ee838e577b07cb1bdacba3aaa8a1e4d69b9 Author: Carlos Caballero <carlscab@google.com> Date: Thu Apr 25 17:52:49 2019 +0000 Refactor sequence_manager_impl_unittest.cc Move TaskQueue related tests to their own file. Tests for TaskQueueImpl will stay here for now. Change-Id: I2ad2d82e29b23333ea3362f4b10ff6b7a53fa1a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571627 Reviewed-by: Alex Clarke <alexclarke@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#654100} base/BUILD.gn | 1 + .../sequence_manager_impl_unittest.cc | 72 --------------- base/task/sequence_manager/task_queue_unittest.cc | 101 +++++++++++++++++++++ 3 files changed, 102 insertions(+), 72 deletions(-) commit 97cee201053a54fa3525c381ab7c8310973cd605 Author: Kelvin Jiang <kelvinjiang@chromium.org> Date: Thu Apr 25 17:50:59 2019 +0000 [Extensions] Add histogram for # extensions with new tab overrides Add a new histogram to record the # of extensions which override the new tab page on startup. Bug: 942200 Change-Id: I9cfb7b00dca44c61dd8429c0d6f9eeeb92eeb1a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580382 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Brian White <bcwhite@chromium.org> Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#654099} chrome/browser/extensions/installed_loader.cc | 16 +++++++++++----- tools/metrics/histograms/histograms.xml | 9 +++++++++ 2 files changed, 20 insertions(+), 5 deletions(-) Updated tag 'tree_truth' (was e209e8aa046e)