Back to build
Raw log | Switch to full mode | Login

/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh /b/swarming/w/ir/cache/builder/src src in dir /b/swarming/w/ir/k: allow_subannotations: False cmd: ['/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh', '/b/swarming/w/ir/cache/builder/src', 'src'] env: FrozenDict([('CHROME_HEADLESS', '1')]) env_prefixes: {'mapping': FrozenDict([]), 'pathsep': ':'} env_suffixes: {'mapping': FrozenDict([]), 'pathsep': ':'} infra_step: False name_tokens: ['tree truth steps'] ok_ret: frozenset([0]) trigger_specs: [] full environment: ADDRFAM: inet BOTO_CONFIG: /b/swarming/w/ir/tmp/gsutil-task/.boto BUILDBUCKET_EXPERIMENTAL: FALSE CHROME_HEADLESS: 1 CIPD_CACHE_DIR: /b/swarming/cipd_cache/cache CIPD_PROTOCOL: v2 DEVSHELL_CLIENT_PORT: 39720 DOCKER_CONFIG: /b/swarming/w/ir/tmp/docker-cfg-task DOCKER_TMPDIR: /b/swarming/w/ir/tmp/docker-tmp-task GIT_CONFIG_NOSYSTEM: 1 GIT_TERMINAL_PROMPT: 0 HOME: /home/chrome-bot IFACE: eth0 INFRA_GIT_WRAPPER_HOME: /b/swarming/w/ir/tmp/git-home-task LOGDOG_COORDINATOR_HOST: logs.chromium.org LOGDOG_STREAM_PREFIX: buildbucket/cr-buildbucket.appspot.com/8915171130856097760 LOGDOG_STREAM_PROJECT: chromium LOGDOG_STREAM_SERVER_PATH: unix:/b/swarming/w/ir/tmp/ld.sock LOGICAL: eth0 LUCI_CONTEXT: /b/swarming/w/ir/tmp/luci_context.693708834 MAC_CHROMIUM_TMPDIR: /b/swarming/w/ir/tmp/t METHOD: dhcp NO_GCE_CHECK: False PATH: /b/swarming/w/ir/cipd_bin_packages:/b/swarming/w/ir/cipd_bin_packages/bin:/b/swarming/cipd_cache/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin PWD: /b/swarming/w/ir/k PYTHONIOENCODING: UTF-8 PYTHONUNBUFFERED: 1 ROOT_SETUP_LOG: /var/log/messages/chromebuild/root-setup.log SHLVL: 1 STARTUP_LOG: /var/log/messages/chromebuild/startup.log SWARMING_BOT_ID: swarm376-c4 SWARMING_EXTERNAL_BOT_SETUP: 1 SWARMING_HEADLESS: 1 SWARMING_SERVER: https://chromium-swarm.appspot.com SWARMING_TASK_ID: 446f3189e5afea11 TEMP: /b/swarming/w/ir/tmp/t TEMPDIR: /b/swarming/w/ir/tmp/t TERM: linux TMP: /b/swarming/w/ir/tmp/t TMPDIR: /b/swarming/w/ir/tmp/t UPSTART_EVENTS: net-device-up UPSTART_INSTANCE: UPSTART_JOB: chromebuild-startup USER: chrome-bot USERNAME: chrome-bot VPYTHON_VIRTUALENV_ROOT: /b/swarming/w/ir/cache/vpython _: /b/swarming/w/ir/cipd_bin_packages/vpython !@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: e53db1f02b29d568f5a5101a62ef4a8a7da91d96 Reland "Make Zombies ignore GWP-ASan backed allocations" Vlad Tsyrklevich, Thu Apr 25 20:06:19 2019 +0000 6ae342a3f37127542b2009d9168b21b4e3d2099f Adding field trial testing config for manual translate trigger. Alexandre Frechette, Thu Apr 25 20:04:37 2019 +0000 83cbc0f44ae5b5316c404fce43c0a93527cd81ed viz: Safe downcast from OutputSurface to SkiaOutputSurface Sunny Sachanandani, Thu Apr 25 20:03:37 2019 +0000 ad14b36f443aa4e4f1661ecf7d4c1d20dfc3a5dd Roll src/third_party/swiftshader 3c203531c7d7..244660437f4b (3 commits) chromium-autoroll, Thu Apr 25 19:58:12 2019 +0000 7291c4a2de9765287abf4e65a65b06cab2f8eeef Roll src-internal 34471d8b8ea8..0b6a22a105de (2 commits) chromium-internal-autoroll, Thu Apr 25 19:57:19 2019 +0000 f123e2c7a60d1390077cf4f9bdbe7a98581da504 [fuchsia] Remove stale references to webrunner. Fabrice de Gans-Riberi, Thu Apr 25 19:57:08 2019 +0000 0e602ef4055141ec70efa920cc5b9c7b9a62fc16 [SR] Fix a use-after-free in session restore logic. Chris Hamilton, Thu Apr 25 19:55:26 2019 +0000 0c4647477f02931733608d680eedeaf5c51fff4a Implement a feature allowing to add all missing URLs to the WPR archive Sergiy Belozorov, Thu Apr 25 19:53:19 2019 +0000 26d47ce236b7f979e858a56cefe88747355c6ed6 Update presubmit script to allow modifications to webxr_test_pages Alex Cooper, Thu Apr 25 19:51:44 2019 +0000 2c4df45d5c8376634ec9d599929e09673a4f5745 Convert remaining audio service to new Mojo types Ken Rockot, Thu Apr 25 19:50:36 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit e53db1f02b29d568f5a5101a62ef4a8a7da91d96 Author: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Date: Thu Apr 25 20:06:19 2019 +0000 Reland "Make Zombies ignore GWP-ASan backed allocations" This is a reland of 28000bb230411bf866115fe2e3695721db67bea7 with a fix for a gn gen --check failure for an #include in an #if block. Original change's description: > Make Zombies ignore GWP-ASan backed allocations > > Zombies is an macOS-specific tool for detecting Objective-C > use-after-frees by delaying Obj-C object deallocation and replacing > those objects' class information with a debug class that will cause a > crash on any attempt to call a method on the freed object. > > Zombies interferes with GWP-ASan on account of the fact that by delaying > the object's deallocation GWP-ASan does not get a correct deallocation > stack trace, nor can it detect errors during the time the object is in > Zombies' quarantine. > > Change Zombies to immediately deallocate Obj-C objects backed by a > GWP-ASan allocation. > > Bug: 944727 > Change-Id: Ifa452bce7f6678ed20a4cc51000748d11d366a59 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570631 > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Vitaly Buka <vitalybuka@chromium.org> > Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> > Cr-Commit-Position: refs/heads/master@{#653844} TBR=rsesek@chromium.org,vitalybuka@chromium.org Bug: 944727 Change-Id: I4f28294d41c43f4585916ec0e4786a9392f74813 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584369 Reviewed-by: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#654163} components/crash/core/common/BUILD.gn | 6 ++++++ components/crash/core/common/DEPS | 2 ++ components/crash/core/common/objc_zombie.mm | 15 +++++++++++++-- components/gwp_asan/client/sampling_allocator_shims.cc | 5 +++++ components/gwp_asan/client/sampling_allocator_shims.h | 6 ++++++ 5 files changed, 32 insertions(+), 2 deletions(-) commit 6ae342a3f37127542b2009d9168b21b4e3d2099f Author: Alexandre Frechette <frechette@chromium.org> Date: Thu Apr 25 20:04:37 2019 +0000 Adding field trial testing config for manual translate trigger. Change-Id: I1ca332c0a4557039609345ca13e2c40ee759ca8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572585 Reviewed-by: Nik Bhagat <nikunjb@chromium.org> Commit-Queue: Alexandre Frechette <frechette@chromium.org> Cr-Commit-Position: refs/heads/master@{#654162} testing/variations/fieldtrial_testing_config.json | 15 +++++++++++++++ 1 file changed, 15 insertions(+) commit 83cbc0f44ae5b5316c404fce43c0a93527cd81ed Author: Sunny Sachanandani <sunnyps@chromium.org> Date: Thu Apr 25 20:03:37 2019 +0000 viz: Safe downcast from OutputSurface to SkiaOutputSurface We need to instantiate Display with both OutputSurface and an equivalent pointer to SkiaOutputSurface. This CL provides a way to safely downcast from an OutputSurface to SkiaOutputSurface to decouple the creation of OutputSurface and Display in preparation for upcoming CLs. Bug: 953970 Change-Id: I7d25d980e208ccb39aa3f4e0eee3b9a662ccd502 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583049 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Reviewed-by: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#654161} android_webview/browser/gfx/surfaces_instance.cc | 5 +---- components/viz/service/display/display.cc | 5 ++--- components/viz/service/display/display.h | 5 ++--- components/viz/service/display/output_surface.cc | 4 ++++ components/viz/service/display/output_surface.h | 4 ++++ components/viz/service/display/skia_output_surface.cc | 4 ++++ components/viz/service/display/skia_output_surface.h | 2 ++ components/viz/service/display_embedder/gpu_display_provider.cc | 5 +---- components/viz/test/test_layer_tree_frame_sink.cc | 4 +--- 9 files changed, 21 insertions(+), 17 deletions(-) commit ad14b36f443aa4e4f1661ecf7d4c1d20dfc3a5dd Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Apr 25 19:58:12 2019 +0000 Roll src/third_party/swiftshader 3c203531c7d7..244660437f4b (3 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/3c203531c7d7..244660437f4b git log 3c203531c7d7..244660437f4b --date=short --no-merges --format='%ad %ae %s' 2019-04-25 chrisforbes@google.com Partial support for input attachments 2019-04-25 chrisforbes@google.com Fix weird sampled image format query 2019-04-25 chrisforbes@google.com Produce correct `one` value for integer textures Created with: gclient setdep -r src/third_party/swiftshader@244660437f4b The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/131171141,chromium:b/117974925,chromium:b/129523279 TBR=swiftshader-team+autoroll@chromium.org Change-Id: Ic0e63b9ed522df9ef0b07b03346bb2dc88a91601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584761 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#654160} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 7291c4a2de9765287abf4e65a65b06cab2f8eeef Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Thu Apr 25 19:57:19 2019 +0000 Roll src-internal 34471d8b8ea8..0b6a22a105de (2 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/34471d8b8ea8..0b6a22a105de Created with: gclient setdep -r src-internal@0b6a22a105de The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=cmumford@chromium.org,gab@chromium.org,droger@chromium.org Change-Id: I3e0c7fb1f2eb2f16287d4d33ba5ea988ce96a318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584762 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#654159} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit f123e2c7a60d1390077cf4f9bdbe7a98581da504 Author: Fabrice de Gans-Riberi <fdegans@chromium.org> Date: Thu Apr 25 19:57:08 2019 +0000 [fuchsia] Remove stale references to webrunner. The //fuchsia directory should no longer use "webrunner". Change some of the remaining references to "web_engine" or "WebEngine". Bug: 922635 Change-Id: I0fd8beb838c76a0a39b54c4aa78f0d73194ae02a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579779 Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#654158} fuchsia/BUILD.gn | 2 +- fuchsia/engine/BUILD.gn | 4 ++-- fuchsia/engine/browser/web_engine_net_log.cc | 2 +- fuchsia/engine/web_engine_main_delegate.cc | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) commit 0e602ef4055141ec70efa920cc5b9c7b9a62fc16 Author: Chris Hamilton <chrisha@chromium.org> Date: Thu Apr 25 19:55:26 2019 +0000 [SR] Fix a use-after-free in session restore logic. The callback being invoked can cause the retaining object to delete itself and the SessionRestorePolicy object, at which point setting the |notification_state_| property is invalid. BUG=946863 Change-Id: I54b9b3890eb729c541472c829476458511bb8d45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584370 Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#654157} chrome/browser/resource_coordinator/session_restore_policy.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) commit 0c4647477f02931733608d680eedeaf5c51fff4a Author: Sergiy Belozorov <sergiyb@chromium.org> Date: Thu Apr 25 19:53:19 2019 +0000 Implement a feature allowing to add all missing URLs to the WPR archive R=perezju@chromium.org Bug: 895891 Change-Id: Ifdcc5876e170a43166050a4d743a5d89e7a04962 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1511426 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#654156} tools/perf/cli_tools/update_wpr/update_wpr.py | 135 ++++++++++++++------- .../cli_tools/update_wpr/update_wpr_unittest.py | 66 +++++++--- tools/perf/core/path_util.py | 8 +- tools/perf/core/services/request.py | 6 +- 4 files changed, 150 insertions(+), 65 deletions(-) commit 26d47ce236b7f979e858a56cefe88747355c6ed6 Author: Alex Cooper <alcooper@chromium.org> Date: Thu Apr 25 19:51:44 2019 +0000 Update presubmit script to allow modifications to webxr_test_pages The webxr_test_pages started out as a sample pages from the immersive web working group, and such have to live in third_party; however these pages are now forked from that so that they can serve as manual test pages in-sync with the chrome implementation of the webxr spec for developers working on the spec. Because these changes are specific to chrome, they don't fit under web_platform_tests, and because they were originally third_party sample pages, they have to live in third_party. Change-Id: If5e09667bff8124b645e020f6e88824e7b848c0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554129 Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Bill Orr <billorr@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#654155} third_party/PRESUBMIT.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) commit 2c4df45d5c8376634ec9d599929e09673a4f5745 Author: Ken Rockot <rockot@google.com> Date: Thu Apr 25 19:50:36 2019 +0000 Convert remaining audio service to new Mojo types Update services/audio and closely related code to use new Mojo bindings types instead of old ones. This is a follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/1574452 which started the conversion process. Bug: 955171 Change-Id: I61907cb5eb7a39cad121dada6c17570fdf3f7948 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578019 Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Olga Sharonova <olka@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#654154} .../browser/media/audio_loopback_stream_broker.cc | 5 +- .../media/audio_loopback_stream_broker_unittest.cc | 19 ++--- content/browser/media/audio_muting_session.cc | 4 +- content/browser/media/audio_muting_session.h | 3 +- .../forwarding_audio_stream_factory_unittest.cc | 25 ++++--- ...er_frame_audio_input_stream_factory_unittest.cc | 6 +- content/browser/speech/speech_recognizer_impl.cc | 7 +- content/public/test/audio_service_test_helper.cc | 20 +++--- content/public/test/audio_service_test_helper.h | 16 +++-- content/public/utility/content_utility_client.h | 4 +- .../shell/utility/shell_content_utility_client.cc | 4 +- .../shell/utility/shell_content_utility_client.h | 2 +- content/utility/utility_service_factory.cc | 10 +-- content/utility/utility_service_factory.h | 5 +- services/audio/local_muter.cc | 2 +- services/audio/local_muter.h | 2 +- services/audio/local_muter_unittest.cc | 4 +- services/audio/log_factory_manager_unittest.cc | 19 ++--- services/audio/loopback_stream.cc | 16 ++--- services/audio/loopback_stream.h | 34 +++++---- services/audio/loopback_stream_unittest.cc | 50 +++++++------ services/audio/public/cpp/device_factory.cc | 4 +- services/audio/public/cpp/device_factory.h | 3 +- services/audio/public/cpp/fake_stream_factory.h | 8 +-- services/audio/public/cpp/fake_system_info.cc | 2 +- services/audio/public/cpp/fake_system_info.h | 4 +- services/audio/public/cpp/input_ipc.cc | 38 ++++------ services/audio/public/cpp/input_ipc.h | 19 ++--- services/audio/public/mojom/stream_factory.mojom | 15 ++-- services/audio/service.cc | 70 +++++++++--------- services/audio/service.h | 26 ++++--- services/audio/service_factory.cc | 10 +-- services/audio/service_factory.h | 13 ++-- services/audio/service_main.cc | 6 +- services/audio/stream_factory.cc | 18 ++--- services/audio/stream_factory.h | 10 +-- services/audio/stream_factory_unittest.cc | 8 +-- services/audio/system_info.cc | 4 +- services/audio/system_info.h | 10 +-- .../test/audio_system_to_service_adapter_test.cc | 84 +++++++++++----------- .../audio/test/debug_recording_session_unittest.cc | 14 ++-- services/audio/test/in_process_service_test.cc | 3 +- .../audio/test/service_lifetime_connector_test.cc | 6 +- .../audio/test/service_lifetime_test_template.h | 8 ++- services/audio/test/service_observer_mock.cc | 7 +- services/audio/test/service_observer_mock.h | 8 ++- 46 files changed, 346 insertions(+), 309 deletions(-) commit 1e19262f95a23b28e5b4564a8cadc67028e96e8d Author: Bruno Santos <brunoad@chromium.org> Date: Thu Apr 25 19:49:37 2019 +0000 Use internal manifest for Kiosk Next Home. Also, protects parts of code that should only run if Kiosk Next is enabled. Bug: 927809 Change-Id: I4ad58d9ac5c75c64440714021b1ffb86d7e609e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580079 Reviewed-by: Tommy Martino <tmartino@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Bruno Santos <brunoad@chromium.org> Cr-Commit-Position: refs/heads/master@{#654153} chrome/browser/BUILD.gn | 8 ++++++++ chrome/browser/browser_resources.grd | 11 ++++++++++- chrome/browser/chromeos/kiosk_next_home/kiosk_next.gni | 4 ++++ chrome/browser/extensions/BUILD.gn | 8 ++++++++ .../chrome_component_extension_resource_manager.cc | 2 +- .../extensions/chrome_extensions_interface_registration.cc | 14 +++++++++++--- .../extensions/component_extensions_whitelist/whitelist.cc | 4 +++- chrome/browser/extensions/component_loader.cc | 12 +++++++----- chrome/browser/resources/BUILD.gn | 8 ++++++++ chrome/browser/resources/component_extension_resources.grd | 6 ++++-- chrome/browser/ui/BUILD.gn | 8 ++++++++ chrome/browser/ui/startup/startup_browser_creator.cc | 2 +- chrome/browser/ui/webui/settings/settings_ui.cc | 3 ++- 13 files changed, 75 insertions(+), 15 deletions(-) commit 36d4868dc0316b9f1fbef6b0a56c0edf5f46c27c Author: Sergiy Belozorov <sergiyb@chromium.org> Date: Thu Apr 25 19:48:12 2019 +0000 Default to reuse option when branch name looks like one created by the script Also offer to do cleanup on exception. This way if script crashes, users can still do cleanup. R=perezju@chromium.org Bug: 895891 Change-Id: Ibd137b46a60a10753bd2be8de5afc4976a03bd58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520600 Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#654152} tools/perf/cli_tools/update_wpr/update_wpr.py | 56 ++++++++++++---------- .../cli_tools/update_wpr/update_wpr_unittest.py | 5 +- 2 files changed, 34 insertions(+), 27 deletions(-) commit fa25101faf091614edb81cc34ffba810e10f3a7b Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Thu Apr 25 19:46:50 2019 +0000 Move NG Physical/Logical Offset/Size/Rect out of ng - from layout/ng/geometry to layout/geometry - remove NG prefix - rename NGPhysicalOffsetRect to PhysicalRect. Change-Id: Ib04d8d65ea6c7b95444708ef5abc397c60c8f4ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582872 Reviewed-by: Bruce Dawson <brucedawson@chromium.org> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#654151} third_party/blink/renderer/core/BUILD.gn | 8 +- .../renderer/core/editing/visible_units_line.cc | 4 +- third_party/blink/renderer/core/layout/BUILD.gn | 24 +- .../core/layout/geometry/logical_offset.cc | 58 ++++ .../logical_offset.h} | 52 ++-- .../logical_offset_test.cc} | 16 +- .../logical_rect.cc} | 14 +- .../renderer/core/layout/geometry/logical_rect.h | 56 ++++ .../logical_rect_test.cc} | 18 +- .../logical_size.cc} | 6 +- .../renderer/core/layout/geometry/logical_size.h | 86 ++++++ .../core/layout/geometry/physical_offset.cc | 52 ++++ .../physical_offset.h} | 48 +-- .../physical_offset_test.cc} | 16 +- .../physical_rect.cc} | 22 +- .../physical_rect.h} | 44 ++- .../physical_rect_test.cc} | 18 +- .../physical_size.cc} | 6 +- .../renderer/core/layout/geometry/physical_size.h | 65 ++++ .../renderer/core/layout/layout_block_flow_line.cc | 2 +- .../blink/renderer/core/layout/layout_inline.cc | 9 +- .../blink/renderer/core/layout/layout_replaced.cc | 14 +- .../blink/renderer/core/layout/layout_text.cc | 6 +- .../renderer/core/layout/layout_tree_as_text.cc | 2 +- .../layout/ng/exclusions/ng_exclusion_space.cc | 2 +- .../core/layout/ng/exclusions/ng_exclusion_space.h | 6 +- .../core/layout/ng/geometry/ng_bfc_offset.h | 2 +- .../renderer/core/layout/ng/geometry/ng_bfc_rect.h | 2 +- .../core/layout/ng/geometry/ng_box_strut.h | 4 +- .../core/layout/ng/geometry/ng_logical_offset.cc | 63 ---- .../core/layout/ng/geometry/ng_logical_rect.h | 56 ---- .../core/layout/ng/geometry/ng_logical_size.h | 87 ------ .../core/layout/ng/geometry/ng_physical_offset.cc | 59 ---- .../core/layout/ng/geometry/ng_physical_size.h | 68 ---- .../core/layout/ng/geometry/ng_static_position.cc | 2 +- .../core/layout/ng/geometry/ng_static_position.h | 6 +- .../core/layout/ng/inline/ng_caret_rect.cc | 39 ++- .../core/layout/ng/inline/ng_inline_box_state.cc | 10 +- .../core/layout/ng/inline/ng_inline_box_state.h | 8 +- .../ng/inline/ng_inline_fragment_traversal.cc | 4 +- .../layout/ng/inline/ng_inline_layout_algorithm.cc | 4 +- .../ng/inline/ng_inline_layout_algorithm_test.cc | 16 +- .../core/layout/ng/inline/ng_inline_node.cc | 2 +- .../ng/inline/ng_line_box_fragment_builder.h | 12 +- .../core/layout/ng/inline/ng_line_breaker.cc | 6 +- .../core/layout/ng/inline/ng_line_breaker.h | 2 +- .../core/layout/ng/inline/ng_line_breaker_test.cc | 8 +- .../core/layout/ng/inline/ng_line_truncator.cc | 2 +- .../ng/inline/ng_physical_line_box_fragment.cc | 20 +- .../ng/inline/ng_physical_line_box_fragment.h | 11 +- .../layout/ng/inline/ng_physical_text_fragment.cc | 42 ++- .../layout/ng/inline/ng_physical_text_fragment.h | 13 +- .../ng/inline/ng_physical_text_fragment_test.cc | 16 +- .../layout/ng/inline/ng_text_fragment_builder.h | 2 +- .../renderer/core/layout/ng/layout_box_utils.cc | 6 +- .../core/layout/ng/layout_ng_block_flow.cc | 8 +- .../renderer/core/layout/ng/layout_ng_mixin.cc | 6 +- .../core/layout/ng/layout_ng_table_caption.cc | 4 +- .../layout/ng/list/ng_unpositioned_list_marker.cc | 13 +- .../layout/ng/list/ng_unpositioned_list_marker.h | 4 +- .../renderer/core/layout/ng/ng_absolute_utils.cc | 16 +- .../renderer/core/layout/ng/ng_absolute_utils.h | 12 +- .../core/layout/ng/ng_absolute_utils_test.cc | 4 +- .../layout/ng/ng_base_layout_algorithm_test.cc | 6 +- .../core/layout/ng/ng_base_layout_algorithm_test.h | 8 +- .../core/layout/ng/ng_block_layout_algorithm.cc | 46 +-- .../core/layout/ng/ng_block_layout_algorithm.h | 18 +- .../layout/ng/ng_block_layout_algorithm_test.cc | 342 ++++++++++----------- .../blink/renderer/core/layout/ng/ng_block_node.cc | 24 +- .../blink/renderer/core/layout/ng/ng_block_node.h | 16 +- .../core/layout/ng/ng_box_fragment_builder.cc | 32 +- .../core/layout/ng/ng_box_fragment_builder.h | 6 +- .../core/layout/ng/ng_column_layout_algorithm.cc | 30 +- .../core/layout/ng/ng_column_layout_algorithm.h | 10 +- .../layout/ng/ng_column_layout_algorithm_test.cc | 38 +-- .../renderer/core/layout/ng/ng_constraint_space.cc | 8 +- .../renderer/core/layout/ng/ng_constraint_space.h | 34 +- .../core/layout/ng/ng_constraint_space_builder.cc | 6 +- .../core/layout/ng/ng_constraint_space_builder.h | 18 +- .../layout/ng/ng_constraint_space_builder_test.cc | 12 +- .../layout/ng/ng_container_fragment_builder.cc | 57 ++-- .../core/layout/ng/ng_container_fragment_builder.h | 18 +- .../core/layout/ng/ng_fieldset_layout_algorithm.cc | 20 +- .../core/layout/ng/ng_fieldset_layout_algorithm.h | 6 +- .../layout/ng/ng_fieldset_layout_algorithm_test.cc | 4 +- .../core/layout/ng/ng_flex_layout_algorithm.cc | 6 +- .../core/layout/ng/ng_flex_layout_algorithm.h | 4 +- .../renderer/core/layout/ng/ng_floats_utils.cc | 36 +-- .../renderer/core/layout/ng/ng_floats_utils.h | 8 +- .../blink/renderer/core/layout/ng/ng_fragment.h | 4 +- .../renderer/core/layout/ng/ng_fragment_builder.h | 6 +- .../core/layout/ng/ng_inline_layout_test.cc | 11 +- .../core/layout/ng/ng_layout_input_node.cc | 16 +- .../renderer/core/layout/ng/ng_layout_input_node.h | 10 +- .../renderer/core/layout/ng/ng_layout_result.h | 6 +- .../renderer/core/layout/ng/ng_length_utils.cc | 76 ++--- .../renderer/core/layout/ng/ng_length_utils.h | 27 +- .../core/layout/ng/ng_length_utils_test.cc | 8 +- .../blink/renderer/core/layout/ng/ng_link.h | 12 +- .../core/layout/ng/ng_out_of_flow_layout_part.cc | 53 ++-- .../core/layout/ng/ng_out_of_flow_layout_part.h | 16 +- .../core/layout/ng/ng_page_layout_algorithm.cc | 12 +- .../core/layout/ng/ng_page_layout_algorithm.h | 4 +- .../core/layout/ng/ng_physical_box_fragment.cc | 19 +- .../core/layout/ng/ng_physical_box_fragment.h | 4 +- .../layout/ng/ng_physical_container_fragment.h | 2 +- .../core/layout/ng/ng_physical_fragment.cc | 31 +- .../renderer/core/layout/ng/ng_physical_fragment.h | 24 +- .../renderer/core/layout/ng/ng_relative_utils.cc | 14 +- .../renderer/core/layout/ng/ng_relative_utils.h | 8 +- .../core/layout/ng/ng_relative_utils_test.cc | 14 +- .../renderer/core/layout/ng/ng_space_utils.cc | 4 +- .../core/paint/ng/ng_box_fragment_painter.cc | 18 +- .../renderer/core/paint/ng/ng_paint_fragment.cc | 137 ++++----- .../renderer/core/paint/ng/ng_paint_fragment.h | 46 +-- .../core/paint/ng/ng_paint_fragment_test.cc | 8 +- .../core/paint/ng/ng_paint_fragment_traversal.h | 2 +- .../core/paint/ng/ng_text_fragment_painter.cc | 20 +- tools/win/DebugVisualizers/webkit.natvis | 24 +- 119 files changed, 1351 insertions(+), 1391 deletions(-) commit 99320c4f1a79d84985cdf9f3c9767a27191d55d4 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Apr 25 19:46:36 2019 +0000 Roll src/third_party/pdfium abc8777d6cf8..64b9a05218cd (4 commits) https://pdfium.googlesource.com/pdfium.git/+log/abc8777d6cf8..64b9a05218cd git log abc8777d6cf8..64b9a05218cd --date=short --no-merges --format='%ad %ae %s' 2019-04-25 tsepez@chromium.org Revert "Remove potentially tree-corrupting methods from CXFA_LayoutItem." 2019-04-25 thestig@chromium.org Roll third_party/skia/ b5c685991..06be07979 (241 commits; 42 trivial rolls) 2019-04-25 thestig@chromium.org Roll third_party/skia/ 2655ede7c..b5c685991 (1 commit) 2019-04-25 thestig@chromium.org Roll third_party/skia/ 442973874..2655ede7c (9 commits) Created with: gclient setdep -r src/third_party/pdfium@64b9a05218cd The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ieae020730ebc4c163298e715c96d02ecaef160bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584742 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#654150} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit af4feec96e13e1046509568743c3c8859a40f3d0 Author: Carlos Caballero <carlscab@google.com> Date: Thu Apr 25 19:43:43 2019 +0000 Rename ScopedTaskEnvironment::ExecutionMode ScopedTaskEnvironment::ExecutionMode is becoming ScopedTaskEnvironment::ThreadPoolExecutionMode This CL was uploaded by git cl split. R=yuweih@chromium.org Bug: 708584 Change-Id: Ib721ce0db3f4897daf8208c15c2eff99d042360a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583790 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by: Yuwei Huang <yuweih@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#654149} remoting/host/file_transfer/file_transfer_message_handler_unittest.cc | 2 +- remoting/host/file_transfer/ipc_file_operations_unittest.cc | 2 +- remoting/host/file_transfer/local_file_operations_unittest.cc | 2 +- remoting/host/gcd_state_updater_unittest.cc | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) commit 097af94950890d9c83ce8f7e503e7f45224ed77a Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Apr 25 19:42:00 2019 +0000 Roll src/third_party/depot_tools b2b66999ea37..97654081c73d (1 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b2b66999ea37..97654081c73d git log b2b66999ea37..97654081c73d --date=short --no-merges --format='%ad %ae %s' 2019-04-25 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@97654081c73d The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: If4e22183e80ce4fc0dc9d58dcefb0c60a563321c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584763 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#654148} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit b44c869ab26ed9112e0094fc311081cef1d2b689 Author: Ryan Sturm <ryansturm@chromium.org> Date: Thu Apr 25 19:40:49 2019 +0000 Preconnect at regular intervals in Navigation Predictor For users that stay foregrounded, we should preconnect every 60 (finch param) seconds. Bug: 956229 Change-Id: Ica092ce7d6b53de54e0ed16fbe8a6639cac171d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577975 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#654147} .../navigation_predictor/navigation_predictor.cc | 21 ++++++ .../navigation_predictor/navigation_predictor.h | 7 +- .../navigation_predictor_browsertest.cc | 86 +++++++++++++++++++++- tools/metrics/histograms/enums.xml | 3 + 4 files changed, 112 insertions(+), 5 deletions(-) commit bb18ab263004dc1a7ae01c50fb1302ccf7e6b476 Author: Ian Kilpatrick <ikilpatrick@chromium.org> Date: Thu Apr 25 19:39:58 2019 +0000 [LayoutNG] Rename old_layout -> legacy_layout. As above! There should be no behaviour change. Change-Id: I21ebb773d1051e4fcb8defef97c2a4f82a586bc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584566 Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#654146} .../renderer/core/layout/ng/layout_ng_block_flow.cc | 4 ++-- .../renderer/core/layout/ng/layout_ng_flexible_box.cc | 2 +- .../renderer/core/layout/ng/layout_ng_table_caption.cc | 2 +- .../renderer/core/layout/ng/layout_ng_table_cell.cc | 2 +- .../blink/renderer/core/layout/ng/ng_block_node.cc | 16 ++++++++-------- .../blink/renderer/core/layout/ng/ng_block_node.h | 12 ++++++------ .../renderer/core/layout/ng/ng_box_fragment_builder.h | 4 ++-- .../core/layout/ng/ng_container_fragment_builder.h | 2 +- .../blink/renderer/core/layout/ng/ng_layout_result.cc | 2 +- .../core/layout/ng/ng_out_of_flow_layout_part.cc | 2 +- .../renderer/core/layout/ng/ng_physical_box_fragment.cc | 2 +- .../core/layout/ng/ng_physical_box_fragment_test.cc | 17 +++++++++-------- .../renderer/core/layout/ng/ng_physical_fragment.cc | 8 ++++---- .../renderer/core/layout/ng/ng_physical_fragment.h | 8 ++++---- .../blink/renderer/core/paint/ng/ng_paint_fragment.cc | 2 +- 15 files changed, 43 insertions(+), 42 deletions(-) commit 1e25bf4e9db2d5d2c8dd6e67ab062600e590246c Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Apr 25 19:39:45 2019 +0000 Roll src/third_party/catapult 58d22d158bab..dfc385d7c610 (2 commits) https://chromium.googlesource.com/catapult.git/+log/58d22d158bab..dfc385d7c610 git log 58d22d158bab..dfc385d7c610 --date=short --no-merges --format='%ad %ae %s' 2019-04-25 benjhayden@chromium.org Reland Finish migrating spa to es6 modules. 2019-04-25 eroman@chromium.org Fix eslint errors in source_entry.js Created with: gclient setdep -r src/third_party/catapult@dfc385d7c610 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:950011 TBR=crouleau@chromium.org Change-Id: I0dd023519f0f076a35ccc0038dc2c1afe419b422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584760 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#654145} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 0ead651a5b21f5d7e3472d543735998ce70bb65f Author: Bruce Dawson <brucedawson@chromium.org> Date: Thu Apr 25 19:38:52 2019 +0000 Use range-based for loop and more references While investigating a UAF bug I noticed that a for loop was copying a scoped_refptr, causing a wasteful increment/decrement of the reference count. Fixing that was just a matter of making the range declaration a reference, but while I was in the area I converted a couple of loops from iterators to range-based loops, for modest readability and efficiency gains. Change-Id: I04534f7838c05afa6d38f3064c837bed46c60450 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584565 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Bruce Dawson <brucedawson@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#654144} base/metrics/field_trial.cc | 16 +++++++--------- base/test/scoped_feature_list.cc | 2 +- 2 files changed, 8 insertions(+), 10 deletions(-) commit 3c9b1bea4974fda872c250145d136dd74b382982 Author: Kevin Ellis <kevers@chromium.org> Date: Thu Apr 25 19:38:23 2019 +0000 Fix DCHECK failure in keyframe_effect.cc. A DCHECK failure was exposed by fixing the spec compliance of animation progress. The current iteration of a web animation may be unresolved. Bug: 954558 Change-Id: Ie4b464e4e173fc726774f07c072af21100a6836d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577927 Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#654143} .../blink/renderer/core/animation/timing_calculations.h | 8 +++++--- .../renderer/core/animation/timing_calculations_test.cc | 15 +++++++++++++++ 2 files changed, 20 insertions(+), 3 deletions(-) commit 32fbe21d3aa5e4650d947968f28d759988211dc4 Author: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Date: Thu Apr 25 19:36:07 2019 +0000 GWP-ASan: Report crash handler errors When we encounter an error in the crash handler and we know that we are processing a GWP-ASan exception, send up a protobuf with an error string instead of just sending up the type of failure via UMA histogram. Bug: 950958 Change-Id: I09911ede55141248a993ab625e93ac8db6a8cad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578360 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by: Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#654142} .../gwp_asan/client/guarded_page_allocator.h | 1 + components/gwp_asan/common/allocator_state.cc | 22 +++++++--- components/gwp_asan/common/allocator_state.h | 9 ++-- .../gwp_asan/common/allocator_state_unittest.cc | 11 ++--- components/gwp_asan/crash_handler/crash.proto | 4 ++ .../gwp_asan/crash_handler/crash_analyzer.cc | 49 ++++++++++------------ components/gwp_asan/crash_handler/crash_analyzer.h | 1 + .../crash_handler/crash_analyzer_unittest.cc | 25 +++++++++++ components/gwp_asan/crash_handler/crash_handler.cc | 7 +++- 9 files changed, 89 insertions(+), 40 deletions(-) commit 4961cfc60dbce5d59dfcb6be93ca8abd44bca684 Author: Josh Nohle <nohle@google.com> Date: Thu Apr 25 19:34:12 2019 +0000 [DeviceSync v2] Handle GCM messages from DeviceSync v2 GCM messages sent by the CryptAuth v2 DeviceSync backend may contain some or all of the following key-value pairs: "S": TargetService specification, e.g., "2" for DeviceSync "I": session ID string to be included in ClientMetadata "F": feature type string, e.g., "BetterTogetherHostEnabled" "K": DeviceSync group name, e.g., "DeviceSync:BetterTogether" Previously, for CryptAuth v1 and CryptAuth v2 Enrollment, the only relevant key-value pair was "registrationTickleType" which specified the target service, with values "1" or "2" for Enrollment and "3" for DeviceSync. We update the CryptAuth GCM manager to handle these new key-value pairs. Bug: 951969 Change-Id: Ie5e7fbc709613b61530d641c66072ed34e28f2b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579474 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#654141} .../device_sync/cryptauth_device_manager_impl.cc | 8 +- .../device_sync/cryptauth_device_manager_impl.h | 5 +- .../cryptauth_device_manager_impl_unittest.cc | 6 +- .../cryptauth_enrollment_manager_impl.cc | 4 +- .../cryptauth_enrollment_manager_impl.h | 5 +- .../cryptauth_enrollment_manager_impl_unittest.cc | 3 +- .../services/device_sync/cryptauth_gcm_manager.cc | 8 +- .../services/device_sync/cryptauth_gcm_manager.h | 21 +- .../device_sync/cryptauth_gcm_manager_impl.cc | 168 +++++++++++++-- .../cryptauth_gcm_manager_impl_unittest.cc | 239 ++++++++++++++++++++- .../cryptauth_v2_enrollment_manager_impl.cc | 5 +- .../cryptauth_v2_enrollment_manager_impl.h | 5 +- ...ryptauth_v2_enrollment_manager_impl_unittest.cc | 3 +- .../device_sync/fake_cryptauth_gcm_manager.cc | 12 +- .../device_sync/fake_cryptauth_gcm_manager.h | 12 +- 15 files changed, 457 insertions(+), 47 deletions(-) commit ef6832c65db01a5143580a363553ea56c2e30d36 Author: Tarun Bansal <tbansal@chromium.org> Date: Thu Apr 25 19:33:14 2019 +0000 Cleanup of some of the unused code from DRP params (i) Secure proxy holdback field trial is not being used anymore. Effectively, IsIncludedInSecureProxyHoldbackFieldTrial() now always returns false. (ii) Enabling/disabling quic for non-core data saver proxies is not used anymore. Effectively, IsQuicEnabledForNonCoreProxies() now always returns true. Change-Id: I356e0d9fc8409d9458119462fac33a43a8550e56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584780 Reviewed-by: Robert Ogden <robertogden@chromium.org> Reviewed-by: rajendrant <rajendrant@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#654140} .../core/browser/data_reduction_proxy_configurator.cc | 5 ----- .../browser/data_reduction_proxy_configurator_unittest.cc | 11 ----------- .../core/common/data_reduction_proxy_bypass_protocol.cc | 7 +++---- .../core/common/data_reduction_proxy_params.cc | 14 -------------- .../core/common/data_reduction_proxy_params.h | 7 ------- .../core/common/data_reduction_proxy_params_unittest.cc | 13 ++----------- 6 files changed, 5 insertions(+), 52 deletions(-) commit 7026e85f64bd5529e8fbbc38ac1141539800c35a Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Apr 25 19:30:34 2019 +0000 Roll src/third_party/chromite 724db0f084dd..1b47c3c54ee5 (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/724db0f084dd..1b47c3c54ee5 git log 724db0f084dd..1b47c3c54ee5 --date=short --no-merges --format='%ad %ae %s' 2019-04-25 moragues@google.com atlas: remove erroneous skylab configuration Created with: gclient setdep -r src/third_party/chromite@1b47c3c54ee5 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: Ie5cf3e3a05dc50f2c56a63fc289dfd47153d8df8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584840 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#654139} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 4cbb8e3ee8cf5438aa5db7890042a5814ad6fc02 Author: Christopher Thompson <cthomp@chromium.org> Date: Thu Apr 25 19:26:39 2019 +0000 Deflake SSLUIWorkerFetchTest.MixedContentSettings* This re-enables and deflakes the MixedContentSettings* tests by having RunMixedContentSettingsTest() create a new tab for each invocation. Previously, the SSLStatus::RAN_INSECURE_CONTENT bit was being retained when subsequent invocations caused the navigations to commit to the same previously used process (|SSLHostStateDelegate| tracks per-host/process and is used to populate the SSLStatus on new navigations) -- essentially once insecure content is run in the process we consider it tainted. This behavior is currently working-as-intended but we are considering followup changes in crbug.com/956193. The fix to deflake the test is as follows: 1) Have each invocation of RunMixedContentSettingsTest() run in a new tab (creating and tearing down the tab in each invocation). This forces new RenderFrames/processes to be used. 2) Ensure the WebkitPreferences are correctly set by calling RenderViewHost::OnWebkitPreferencesChanged() (this matches the behavior for similar tests that apply overrides like ServiceWorkerVersionBrowserTest.FetchWithSaveData [1]). 3) Check the security state based on the visible navigation entry rather than the last committed entry, which matches how |VisibleSecurityState| is calculated and used for displaying security state information about a tab. [1] https://cs.chromium.org/chromium/src/content/browser/service_worker/service_worker_browsertest.cc?l=1669&rcl=ab71dd0147ba6d0864b00acb0ada2e08b477b585 Bug: 890372 Change-Id: Ic89ffb31ae0e97420c0cefe3ade2db8128ad26bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559241 Reviewed-by: Emily Stark <estark@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#654138} chrome/browser/ssl/ssl_browsertest.cc | 48 +++++++++++++++++++++++------- chrome/browser/ssl/ssl_browsertest_util.cc | 5 ++-- 2 files changed, 39 insertions(+), 14 deletions(-) commit 2dc94dc10e6c23935fdf2552da6fad25ef6642c5 Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Thu Apr 25 19:15:12 2019 +0000 Revert "Reland: Use a per-frame task runner at mojom::SafeBrowsing binding" This reverts commit 23416d1cede8c6aa875bb86b59bc2b3a9392916d. Reason for revert: Introduce flakiness again: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMjM0MTZkMWNlZGU4YzZhYTg3NWJiODZiNTliYzJiM2E5MzkyOTE2ZAw Original change's description: > Reland: Use a per-frame task runner at mojom::SafeBrowsing binding > > This is reland of https://chromium-review.googlesource.com/c/chromium/src/+/1536036 > This was reverted once since ServiceWorkerTest.UpdateRefreshesServiceWorker > became flaky on Windows, but now this doesn't, though the reason is unclear. > > This CL switches task runners at several places from per-thread to > per-frame. The purpose of this change is to make it possible to freeze > tasks for bfcache. > > We found an actual case that JavaScript is executed: > ./tools/perf/run_tests benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop/load:media:soundcloud:2018 > > As this is a non-standard JavaScript API execution, we adopted > kInternalDefault as the task type. > > Bug: 913912 > Change-Id: Id03b1ac9f46e6c69adea8cd42c6af193dd83fa36 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578144 > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#653490} TBR=avi@chromium.org,hajimehoshi@chromium.org,altimin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 913912 Change-Id: I6b0156f3ef500c4da7e8c743a755c867cd9496dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584520 Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#654137} .../renderer/url_loader_throttle_provider_impl.cc | 31 ++++++---------------- .../renderer/url_loader_throttle_provider_impl.h | 5 ---- 2 files changed, 8 insertions(+), 28 deletions(-) commit 09ef820ccf81b4e38eb55dbfe01719ca4fdd8b63 Author: Sergey Ulanov <sergeyu@google.com> Date: Thu Apr 25 19:06:41 2019 +0000 [Fuchsia] Add buffer_collection_id in NativePixmapHandle NativePixmapHandle already contained VMO handle on Fuchsia. VMO handle can be used to identify buffers, but sysmem returns VMOs only for buffers for which CPU access was requested and we don't need all buffers to be CPU accessible. The new fields will allow to identify sysmem-allocated buffers without relying on VMO handles. VMO handles are still kept as part of NativePixmapHandle to allow clients access the buffers. Bug: 852011 Change-Id: I147af3de9c8f98c6216003ae19702cb67ab0bfcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576167 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Michael Spang <spang@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#654136} ui/gfx/ipc/gfx_param_traits_macros.h | 4 ++++ ui/gfx/mojo/buffer_types.mojom | 6 ++++++ ui/gfx/mojo/buffer_types_struct_traits.cc | 5 +++++ ui/gfx/mojo/buffer_types_struct_traits.h | 13 +++++++++++++ ui/gfx/native_pixmap_handle.cc | 17 +++++++++++++---- ui/gfx/native_pixmap_handle.h | 13 +++++++++++++ 6 files changed, 54 insertions(+), 4 deletions(-) commit ee92240670ca64adc8260c3a85e2f68ce5e9915d Author: Michael Thiessen <mthiesse@chromium.org> Date: Thu Apr 25 19:05:50 2019 +0000 Fix segfault calling GetFocusedFrame on unfocused WebContents Bug: 951568 Change-Id: Ide2e7e9aff6da1e919bd1f58a8d45c232edccbe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584562 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#654135} content/browser/web_contents/web_contents_android.cc | 5 ++++- .../java/src/org/chromium/content_public/browser/WebContents.java | 3 ++- 2 files changed, 6 insertions(+), 2 deletions(-) commit d92895e0f0de5f9b68f675012bcc3b9a8e1008ae Author: Nick Burris <nburris@chromium.org> Date: Thu Apr 25 19:05:35 2019 +0000 Implement range matching for TextUrlFragments Implement range matching in TextFragmentFinder. The parsing of the endText string is already implemented. TextFragmentFinder now checks if the end text is present in the TextFragmentSelector, searches for the first occurrence after it finds the start text, and returns the total range. Bug: 924964 Change-Id: Ifa913d1aef8d3406c1133608842c5a7d710f9f14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573814 Reviewed-by: David Bokan <bokan@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#654134} .../core/page/scrolling/text_fragment_anchor.cc | 4 +- .../page/scrolling/text_fragment_anchor_test.cc | 221 +++++++++++++++++++++ .../core/page/scrolling/text_fragment_finder.cc | 59 ++++-- .../core/page/scrolling/text_fragment_finder.h | 3 - 4 files changed, 265 insertions(+), 22 deletions(-) commit b0758791f138ecc4e16a23bd3c22ef1d81f35b5c Author: Céline O'Neil <celineo@google.com> Date: Thu Apr 25 19:04:28 2019 +0000 Implement RenderPassDrawQuad fuzzing. This CL introduces RenderPassDrawQuads to the fuzzable quad types. It does not yet fuzz masks/filters. R=kylechar@chromium.org, riajiang@chromium.org Bug: 923088 Change-Id: Ia3c8331c3c8093aff5842d4d23ad6338c1a8897c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566363 Commit-Queue: Céline O'Neil <celineo@google.com> Reviewed-by: kylechar <kylechar@chromium.org> Reviewed-by: Ria Jiang <riajiang@chromium.org> Auto-Submit: Céline O'Neil <celineo@google.com> Cr-Commit-Position: refs/heads/master@{#654133} .../viz/service/compositor_frame_fuzzer/BUILD.gn | 3 + .../compositor_frame_fuzzer.proto | 11 +- .../compositor_frame_fuzzer_util.cc | 95 +++++++- .../compositor_frame_fuzzer_util.h | 9 +- .../nested_render_pass_draw_quads.asciipb | 171 ++++++++++++++ ...rlapping_quads_in_render_pass_draw_quad.asciipb | 249 +++++++++++++++++++++ 6 files changed, 528 insertions(+), 10 deletions(-) commit fb22ad21bcbb08e9de086d5f80caa1b2f8cb13cd Author: Mark Pearson <mpearson@chromium.org> Date: Thu Apr 25 19:02:55 2019 +0000 Omnibox Answer Logging - Add Test Requested follow-up from https://chromium.googlesource.com/chromium/src.git/+/80d72d8cd21cf76df583e29676b987ac1e3b90e9 Bug: 950344 Change-Id: If96bf162fc230a6a1fb9d5460748e10d48bacf2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582451 Auto-Submit: Mark Pearson <mpearson@chromium.org> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#654132} components/omnibox/browser/suggestion_answer.cc | 8 ++++-- components/omnibox/browser/suggestion_answer.h | 3 +++ .../omnibox/browser/suggestion_answer_unittest.cc | 29 ++++++++++++++++++++++ 3 files changed, 38 insertions(+), 2 deletions(-) commit bfca1d4b750076847758121e2fe08b6c1642c18d Author: Fabrice de Gans-Riberi <fdegans@chromium.org> Date: Thu Apr 25 19:02:41 2019 +0000 [fuchsia] Remove the chromium.web API Bug: 946732 Change-Id: Ib7d4f62dcef88770a3516506d19ad2bdfb12f91d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580464 Reviewed-by: Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#654131} fuchsia/BUILD.gn | 20 --- fuchsia/engine/BUILD.gn | 12 -- fuchsia/engine/legacy_message_port_bridge.cc | 94 ------------- fuchsia/engine/legacy_message_port_bridge.h | 47 ------- fuchsia/fidl/cast/cast_channel.fidl | 6 - fuchsia/fidl/web/context.fidl | 14 -- fuchsia/fidl/web/context_provider.fidl | 31 ----- fuchsia/fidl/web/frame.fidl | 168 ------------------------ fuchsia/fidl/web/navigation_controller.fidl | 71 ---------- fuchsia/fidl/web/navigation_event_observer.fidl | 25 ---- 10 files changed, 488 deletions(-) commit ff0dca0c10e3afc73cbca7f08e27ed996c131eff Author: Sean <harrisonsean@chromium.org> Date: Thu Apr 25 19:00:21 2019 +0000 Added in UMA metrics for UITabHelperOfflineErrors. Bug: 955471 Change-Id: I6185fe047d762961940b082ad33627deef3a290e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578187 Reviewed-by: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Robert Ogden <robertogden@chromium.org> Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#654130} chrome/browser/previews/previews_ui_tab_helper.cc | 3 ++- tools/metrics/histograms/histograms.xml | 10 ++++++++++ 2 files changed, 12 insertions(+), 1 deletion(-) commit 242aefe9f5b04753557f9e5808fef04b36162528 Author: Anastasia Helfinstein <anastasi@google.com> Date: Thu Apr 25 18:59:31 2019 +0000 Refactor accessibility focus rings This is a pure refactor, with no functional change. Bug: 955783 Change-Id: I3c88bbda768f5ac863c7994e75a3c2a92ceca366 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583443 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#654129} ash/accessibility/accessibility_focus_ring.cc | 208 +++++++++++++-------- ash/accessibility/accessibility_focus_ring.h | 1 + .../accessibility_focus_ring_group_unittest.cc | 45 +++++ 3 files changed, 175 insertions(+), 79 deletions(-) commit 251aebeeda9a6ee05aa9eb0ef5b79216176d13e1 Author: Peter Boström <pbos@chromium.org> Date: Thu Apr 25 18:52:57 2019 +0000 Sort extensions in menu on page interaction status This groups extensions into three buckets: * Extensions that are accessing (can access) the page's data * Extensions that want to access the page's data * Extensions that can't access the page's data Labels are used as headings for each of these three buckets. No label is added for groups that don't have a corresponding extension. Bug: chromium:943702 Change-Id: I055f5f8824b65f2833f9d78b1f4289e28aad630e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577590 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#654128} chrome/app/generated_resources.grd | 9 +++ .../extensions/extension_action_view_controller.h | 17 +--- .../toolbar/test_toolbar_action_view_controller.cc | 6 ++ .../toolbar/test_toolbar_action_view_controller.h | 2 + .../ui/toolbar/toolbar_action_view_controller.h | 18 ++++- .../ui/views/extensions/extensions_menu_view.cc | 93 +++++++++++++++++++--- .../ui/views/extensions/extensions_menu_view.h | 1 + 7 files changed, 120 insertions(+), 26 deletions(-) commit 66dbc6e3f3885e1d81e2b782b032c3c583d2eb73 Author: Jarryd Goodman <jarrydg@chromium.org> Date: Thu Apr 25 18:52:25 2019 +0000 Web Platform Tests: Append comment with instructions for chrome The comment, as is today, only describes which flags to pass to V8 but now how to pass the flag to V8 when launching chrome. This change adds a little more color and should save developers time that would have been spent researching how to pass V8 flags from chrome launch. Change-Id: I9daa5e6e1089de2dc52248958d0320f03beea83a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584583 Auto-Submit: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by: Robert Ma <robertma@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#654127} third_party/blink/web_tests/external/wpt/streams/resources/test-utils.js | 1 + 1 file changed, 1 insertion(+) Updated tag 'tree_truth' (was 306740d353a5)