Back to build
Raw log | Switch to full mode | Login

/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh /b/swarming/w/ir/cache/builder/src src in dir /b/swarming/w/ir/k: allow_subannotations: False cmd: ['/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh', '/b/swarming/w/ir/cache/builder/src', 'src'] env: FrozenDict([('CHROME_HEADLESS', '1')]) env_prefixes: {'mapping': FrozenDict([]), 'pathsep': ':'} env_suffixes: {'mapping': FrozenDict([]), 'pathsep': ':'} infra_step: False name_tokens: ['tree truth steps'] ok_ret: frozenset([0]) trigger_specs: [] full environment: ADDRFAM: inet BOTO_CONFIG: /b/swarming/w/ir/tmp/gsutil-task/.boto BUILDBUCKET_EXPERIMENTAL: FALSE CHROME_HEADLESS: 1 CIPD_CACHE_DIR: /b/swarming/cipd_cache/cache CIPD_PROTOCOL: v2 DEVSHELL_CLIENT_PORT: 43020 DOCKER_CONFIG: /b/swarming/w/ir/tmp/docker-cfg-task DOCKER_TMPDIR: /b/swarming/w/ir/tmp/docker-tmp-task GIT_CONFIG_NOSYSTEM: 1 GIT_TERMINAL_PROMPT: 0 HOME: /home/chrome-bot IFACE: eth0 INFRA_GIT_WRAPPER_HOME: /b/swarming/w/ir/tmp/git-home-task LOGDOG_COORDINATOR_HOST: logs.chromium.org LOGDOG_STREAM_PREFIX: buildbucket/cr-buildbucket.appspot.com/8915157942712379232 LOGDOG_STREAM_PROJECT: chromium LOGDOG_STREAM_SERVER_PATH: unix:/b/swarming/w/ir/tmp/ld.sock LOGICAL: eth0 LUCI_CONTEXT: /b/swarming/w/ir/tmp/luci_context.953460359 MAC_CHROMIUM_TMPDIR: /b/swarming/w/ir/tmp/t METHOD: dhcp NO_GCE_CHECK: False PATH: /b/swarming/w/ir/cipd_bin_packages:/b/swarming/w/ir/cipd_bin_packages/bin:/b/swarming/cipd_cache/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin PWD: /b/swarming/w/ir/k PYTHONIOENCODING: UTF-8 PYTHONUNBUFFERED: 1 ROOT_SETUP_LOG: /var/log/messages/chromebuild/root-setup.log SHLVL: 1 STARTUP_LOG: /var/log/messages/chromebuild/startup.log SWARMING_BOT_ID: swarm2473-c4 SWARMING_EXTERNAL_BOT_SETUP: 1 SWARMING_HEADLESS: 1 SWARMING_SERVER: https://chromium-swarm.appspot.com SWARMING_TASK_ID: 446ff1615a5fba11 TEMP: /b/swarming/w/ir/tmp/t TEMPDIR: /b/swarming/w/ir/tmp/t TERM: linux TMP: /b/swarming/w/ir/tmp/t TMPDIR: /b/swarming/w/ir/tmp/t UPSTART_EVENTS: net-device-up UPSTART_INSTANCE: UPSTART_JOB: chromebuild-startup USER: chrome-bot USERNAME: chrome-bot VPYTHON_VIRTUALENV_ROOT: /b/swarming/w/ir/cache/vpython _: /b/swarming/w/ir/cipd_bin_packages/vpython !@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: 51eeb5e52adee36cec79d1e80613e63838d8260d Split TabStrip ideal layout code into a new file. Bret Sepulveda, Fri Apr 26 00:48:49 2019 +0000 fb50bbf492645d5ed0c11be3234723bcf47267e4 [Cellular] Add metrics for activation status and time to connected. Azeem Arshad, Fri Apr 26 00:45:52 2019 +0000 4359fd07df9d6d382ac24abe1948247b3ceec7e1 [🧹✨] Replace base::ResetAndReturn with std::move() in //content Daniel Cheng, Fri Apr 26 00:44:06 2019 +0000 cca250f2b02c47339d7d1663ffbb67cbe789eded Management WebUI: Use px instead of em Yann Dago, Fri Apr 26 00:44:03 2019 +0000 3c628a020ddf1fca02782832dd8c41a1a4df2111 CrOS: Check for selected_view_ before moving apps in the app grid. Alex Newcomer, Fri Apr 26 00:40:42 2019 +0000 8d5ea0efebd05f50bb0c088e0a847a75f219beee [Touchless] Update style of touchless cards. Sky Malice, Fri Apr 26 00:39:47 2019 +0000 0d68cbd77addd38909101f76847deea56de00524 Fix PIP window being blank after minimize/show Adrienne Walker, Fri Apr 26 00:39:23 2019 +0000 c6f0d22d508a551a40fc8bd7418941b77435aac3 omnibox: experiment with restoring placeholder when caret shows Dan Beam, Fri Apr 26 00:38:31 2019 +0000 e953a30757c1b52bb57209f19d22bb2afce67a71 Roll src/net/third_party/quiche/src/ 6cf180b63..43a1c0f10 (4 commits) David Schinazi, Fri Apr 26 00:36:18 2019 +0000 3bc38b2b75af1efee3129925d188c8beb90d214e [OnionSoup] Repair typemapping for EncodedFormData, FormDataElement, etc. Richard Li, Fri Apr 26 00:34:14 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit 51eeb5e52adee36cec79d1e80613e63838d8260d Author: Bret Sepulveda <bsep@chromium.org> Date: Fri Apr 26 00:48:49 2019 +0000 Split TabStrip ideal layout code into a new file. This patch creates TabStripLayoutHelper, a new class that is reponsible for ideal bounds generation. Since both Tab Groups and Tab Scrolling are about to add a lot to this step, this will prevent that complexity from being visible to TabStrip, which is already complex enough. Bug: 905491, 949660 Change-Id: I179a332e815c0bb9c415e695b94622617ff19982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584928 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by: Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#654286} chrome/browser/ui/BUILD.gn | 2 + .../browser/ui/views/tabs/tab_drag_controller.cc | 8 +- chrome/browser/ui/views/tabs/tab_strip.cc | 117 ++++++++------------- chrome/browser/ui/views/tabs/tab_strip.h | 38 ++++--- .../ui/views/tabs/tab_strip_layout_helper.cc | 80 ++++++++++++++ .../ui/views/tabs/tab_strip_layout_helper.h | 55 ++++++++++ chrome/browser/ui/views/tabs/tab_strip_unittest.cc | 28 +++-- 7 files changed, 216 insertions(+), 112 deletions(-) commit fb50bbf492645d5ed0c11be3234723bcf47267e4 Author: Azeem Arshad <azeemarshad@chromium.org> Date: Fri Apr 26 00:45:52 2019 +0000 [Cellular] Add metrics for activation status and time to connected. This CL adds metrics to track the cellular activation status on login and time to connected for cellular network. Bug: 951528 Change-Id: I6498be68213ed41168170ac30186732c02851f0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576500 Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#654285} chromeos/network/cellular_metrics_logger.cc | 115 ++++++++++++++++++++- chromeos/network/cellular_metrics_logger.h | 56 +++++++++- .../network/cellular_metrics_logger_unittest.cc | 107 ++++++++++++++++++- tools/metrics/histograms/enums.xml | 8 ++ tools/metrics/histograms/histograms.xml | 17 +++ 5 files changed, 299 insertions(+), 4 deletions(-) commit 4359fd07df9d6d382ac24abe1948247b3ceec7e1 Author: Daniel Cheng <dcheng@chromium.org> Date: Fri Apr 26 00:44:06 2019 +0000 [🧹✨] Replace base::ResetAndReturn with std::move() in //content Bug: 841899 Change-Id: Ie19782c08b5bc2612fd604f861fd311775e3d042 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584844 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#654284} content/browser/download/download_browsertest.cc | 5 ++--- content/browser/download/download_request_core.cc | 8 ++++---- content/browser/loader/stream_writer.cc | 5 +++-- .../media/in_process_launched_video_capture_device.cc | 6 ++++-- .../media/in_process_video_capture_device_launcher.cc | 8 ++++---- .../renderer_host/media/in_process_video_capture_provider.cc | 4 +++- .../media/media_stream_dispatcher_host_unittest.cc | 9 +++++---- .../renderer_host/media/media_stream_manager_unittest.cc | 3 ++- content/browser/renderer_host/media/media_stream_ui_proxy.cc | 4 ++-- .../media/service_launched_video_capture_device.cc | 4 +++- .../media/service_video_capture_device_launcher.cc | 8 +++++--- .../renderer_host/media/service_video_capture_provider.cc | 7 ++++--- .../media/service_video_capture_provider_unittest.cc | 11 ++++++----- .../renderer_host/media/video_capture_provider_switcher.cc | 5 +++-- .../browser/screen_orientation/screen_orientation_provider.cc | 3 +-- .../fetchers/multi_resolution_image_resource_fetcher.cc | 10 ++++------ .../renderer/media/android/media_player_renderer_client.cc | 5 ++--- content/renderer/media/stream/apply_constraints_processor.cc | 3 +-- content/renderer/media/stream/user_media_processor.cc | 2 +- .../media/video_capture/local_video_capturer_source.cc | 3 +-- content/renderer/p2p/host_address_request.cc | 5 +++-- content/renderer/pepper/pepper_platform_camera_device.cc | 5 +++-- 22 files changed, 66 insertions(+), 57 deletions(-) commit cca250f2b02c47339d7d1663ffbb67cbe789eded Author: Yann Dago <ydago@chromium.org> Date: Fri Apr 26 00:44:03 2019 +0000 Management WebUI: Use px instead of em Bug: 956781 Change-Id: I9b9388cc003b96d8fed93b63bcbd6c2fdbdfa823 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585240 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#654283} .../resources/management/management_ui.html | 38 +++++++++++----------- 1 file changed, 19 insertions(+), 19 deletions(-) commit 3c628a020ddf1fca02782832dd8c41a1a4df2111 Author: Alex Newcomer <newcomer@chromium.org> Date: Fri Apr 26 00:40:42 2019 +0000 CrOS: Check for selected_view_ before moving apps in the app grid. Fixes a crash when doing control->arrow when a suggested chip is focused. Bug: 956163 Change-Id: I4e2970e38078b52331a52802fd1b12f1ac2bd96b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582768 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by: Alex Newcomer <newcomer@chromium.org> Reviewed-by: Kevin Strohbehn <ginko@google.com> Auto-Submit: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#654282} ash/app_list/views/apps_grid_view.cc | 2 +- ash/app_list/views/apps_grid_view_unittest.cc | 11 +++++++++++ 2 files changed, 12 insertions(+), 1 deletion(-) commit 8d5ea0efebd05f50bb0c088e0a847a75f219beee Author: Sky Malice <skym@chromium.org> Date: Fri Apr 26 00:39:47 2019 +0000 [Touchless] Update style of touchless cards. Refactored SuggestionsBinder to have overridable methods that the touchless variant can use to control the behavior. It is a bit messy this way because the contextual logic decision is made with a boolean and if statements inside SuggestionsBinder and we are not consistent with that approach. However, we did not have that option, because the touchless code is not to be referenced from the normal Chrome, and I didn't think it was safe to significantly refactor SuggestionsBinder into multiple sub-classes, one for Zine and one for contextual. Bug: 937446 Change-Id: Ic638ddd5161413c2014a973ec40261420e4a7947 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575434 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#654281} .../browser/suggestions/SuggestionsBinder.java | 150 +++++++++++++-------- .../layout/touchless_content_suggestions_card.xml | 58 ++++++++ .../touchless/java/res/values-v17/dimens.xml | 16 +++ .../touchless/TouchlessArticleViewHolder.java | 15 ++- .../touchless/TouchlessSuggestionsBinder.java | 53 ++++++++ .../android/touchless/touchless_java_sources.gni | 1 + 6 files changed, 236 insertions(+), 57 deletions(-) commit 0d68cbd77addd38909101f76847deea56de00524 Author: Adrienne Walker <enne@chromium.org> Date: Fri Apr 26 00:39:23 2019 +0000 Fix PIP window being blank after minimize/show DesktopWindowTreeHostX11::SetVisible only made the call into OnNativeWidgetVisibilityChanged when transitioning from shown to minimized and not vice versa. This is because this change https://chromium-review.googlesource.com/c/chromium/src/+/1437263 considered IsVisible to be true when minimized, which made IsVisible always true in this case. This caused layers to be hidden but never shown again. This is a reland of: https://chromium-review.googlesource.com/c/chromium/src/+/1580103 Bug: 949199 Change-Id: I2151cd09e537d8ce8781897f43a3b8e9cec75996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584617 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#654280} ui/compositor/compositor.cc | 3 +++ ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc | 7 +++++-- ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h | 3 +++ 3 files changed, 11 insertions(+), 2 deletions(-) commit c6f0d22d508a551a40fc8bd7418941b77435aac3 Author: Dan Beam <dbeam@chromium.org> Date: Fri Apr 26 00:38:31 2019 +0000 omnibox: experiment with restoring placeholder when caret shows Shows the "Search Google or type a URL" omnibox placeholder even when the caret (text edit cursor) is showing / when focused. views::Textfield works this way, as does <input placeholder="">. Omnibox and the NTP's "fakebox" are exceptions in this regard and this experiment makes this more consistent. R=tommycli@chromium.org BUG=955585 Change-Id: I23c299c0973f2feb43f7a2be3bd3425a80b06c2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582315 Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#654279} chrome/browser/ui/views/omnibox/omnibox_view_views.cc | 5 ++++- components/omnibox/common/omnibox_features.cc | 8 ++++++++ components/omnibox/common/omnibox_features.h | 2 ++ 3 files changed, 14 insertions(+), 1 deletion(-) commit e953a30757c1b52bb57209f19d22bb2afce67a71 Author: David Schinazi <dschinazi@chromium.org> Date: Fri Apr 26 00:36:18 2019 +0000 Roll src/net/third_party/quiche/src/ 6cf180b63..43a1c0f10 (4 commits) https://quiche.googlesource.com/quiche.git/+log/6cf180b636ac..43a1c0f10f28 $ git log 6cf180b63..43a1c0f10 --date=short --no-merges --format='%ad %ae %s' 2019-04-25 danzh gfe-relnote: n/a(log only) 2nd try to fix enumeral and non-enumeral type in conditional expression in quic_connection_close_frame.cc 2019-04-25 bnc Use headers_decompressed() in QuicTestClient::response_headers(). 2019-04-25 fayang gfe-relnote: In QUIC, only check whether framer has corresponding encrypter (before sending an ACK) when multiple packet number space is supported. 2019-04-25 danzh gfe-relnote: n/a(new class type not in use) Add SimpleLinkedHashMap which is forked from chromium linked_hash_map.h. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: Iefb0768ee11f2e44989857d1891521ea20f54775 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585241 Auto-Submit: David Schinazi <dschinazi@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#654278} DEPS | 2 +- net/quic/quic_flags_list.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit 3bc38b2b75af1efee3129925d188c8beb90d214e Author: Richard Li <richard.li@intel.com> Date: Fri Apr 26 00:34:14 2019 +0000 [OnionSoup] Repair typemapping for EncodedFormData, FormDataElement, etc. The previous CL about typemaping for EncodedFormData, FormDataElement, and HTTPHeaderMap didn't enable, for "type_mappings" definition in related .typemap files has addtional blank before and after "=". This CL repair this bug. Bug: 860403 Change-Id: I84e32e95a25851c2abc2606a86ed34feb5b3b1d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581164 Reviewed-by: Leon Han <leon.han@intel.com> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Richard Li <richard.li@intel.com> Cr-Commit-Position: refs/heads/master@{#654277} .../blink/renderer/platform/network/encoded_form_data.h | 7 ++++++- .../blink/renderer/platform/network/encoded_form_data.typemap | 4 ++-- .../platform/network/encoded_form_data_mojom_traits.h | 6 ++++++ .../renderer/platform/network/http_request_headers.typemap | 4 ++-- .../platform/network/http_request_headers_mojom_traits.cc | 11 ++++++++--- .../platform/network/http_request_headers_mojom_traits.h | 2 +- 6 files changed, 25 insertions(+), 9 deletions(-) commit 573def87e148b819115c50a13aff9c276ae57bb5 Author: Anastasia Helfinstein <anastasi@google.com> Date: Fri Apr 26 00:28:14 2019 +0000 [Switch Access] Clean up preferences.js Bug: 864809 Change-Id: I8529852f4337dd095498f9f6b7359e3cd8dd2a53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578024 Reviewed-by: Akihiro Ota <akihiroota@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#654276} .../chromeos/switch_access/auto_scan_manager.js | 6 +++-- .../chromeos/switch_access/key_event_handler.js | 6 +++-- .../resources/chromeos/switch_access/options.html | 1 + .../resources/chromeos/switch_access/options.js | 11 ++++++--- .../chromeos/switch_access/preferences.js | 26 ++++++++-------------- .../chromeos/switch_access/switch_access.js | 16 ++++++------- .../switch_access/switch_access_constants.js | 24 ++++++++++++++++++++ .../switch_access/switch_access_interface.js | 16 ++++++------- 8 files changed, 66 insertions(+), 40 deletions(-) commit ce469520c5cc065dab8e4d0476921aea1a2d5b90 Author: Piotr Bialecki <bialpio@chromium.org> Date: Fri Apr 26 00:25:44 2019 +0000 Add methods for accessing plane information Add missing methods to enable accessing plane information in arcore_shim.cc. Bug: 954539 Change-Id: I23b485bb824ddc7a2f8457f2e6a29866a6381d1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580320 Auto-Submit: Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#654275} .../android/vr/arcore_device/arcore_shim.cc | 92 ++++++++++++++++++++-- 1 file changed, 85 insertions(+), 7 deletions(-) commit 6c8ad2fa9286e0dfdf7546114b5e13e0c46c8a71 Author: Johannes Henkel <johannes@chromium.org> Date: Fri Apr 26 00:25:24 2019 +0000 Encode the inspector agent state in CBOR. This is a stepping stone for adding fields that are byte arrays. Without CBOR, I'd have to base64 encode such fields, which is ugly. And I do want byte array fields so that I can CBOR encode the agent state for V8. This change requires whitelisting the third_party/inspector_protocol/encoding dependency. It shouldn't be a problem because that library doesn't depend on anything in Chromium. Change-Id: Id84fdd1732e9857891550f433954580994bf8d5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580779 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#654274} content/browser/devtools/devtools_session.cc | 2 +- .../public/mojom/devtools/devtools_agent.mojom | 2 +- third_party/blink/renderer/core/inspector/BUILD.gn | 1 + .../core/inspector/inspector_session_state.cc | 111 +++++++++++++++------ .../core/inspector/inspector_session_state.h | 58 ++++++----- .../core/inspector/inspector_session_state_test.cc | 2 +- .../blinkpy/presubmit/audit_non_blink_usage.py | 1 + 7 files changed, 120 insertions(+), 57 deletions(-) commit 000ce16cde7df67bf746a1fa012ca6ce1917c3bd Author: Hwanseung Lee <hs1217.lee@samsung.com> Date: Fri Apr 26 00:24:15 2019 +0000 Add GamepadMappingType enum at gamepad.idl According to spec[1], type of Gamepad.mapping attribute should be GamepadMappingType which has two values("" and "standard") [1] https://www.w3.org/TR/gamepad/#gamepadmappingtype-enum Bug: 954409 Change-Id: Id9944f31e5a43f2a2f89e602678e003554429056 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575048 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#654273} third_party/blink/renderer/modules/gamepad/gamepad.idl | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) Updated tag 'tree_truth' (was 7229bc4b85f6)