Back to build
Raw log | Switch to full mode | Login

/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh /b/swarming/w/ir/cache/builder/src src in dir /b/swarming/w/ir/k: allow_subannotations: False cmd: ['/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh', '/b/swarming/w/ir/cache/builder/src', 'src'] env: FrozenDict([('CHROME_HEADLESS', '1')]) env_prefixes: {'mapping': FrozenDict([]), 'pathsep': ':'} env_suffixes: {'mapping': FrozenDict([]), 'pathsep': ':'} infra_step: False name_tokens: ['tree truth steps'] ok_ret: frozenset([0]) trigger_specs: [] full environment: ADDRFAM: inet BOTO_CONFIG: /b/swarming/w/ir/tmp/gsutil-task/.boto BUILDBUCKET_EXPERIMENTAL: FALSE CHROME_HEADLESS: 1 CIPD_CACHE_DIR: /b/swarming/cipd_cache/cache CIPD_PROTOCOL: v2 DEVSHELL_CLIENT_PORT: 41979 DOCKER_CONFIG: /b/swarming/w/ir/tmp/docker-cfg-task DOCKER_TMPDIR: /b/swarming/w/ir/tmp/docker-tmp-task GIT_CONFIG_NOSYSTEM: 1 GIT_TERMINAL_PROMPT: 0 HOME: /home/chrome-bot IFACE: eth0 INFRA_GIT_WRAPPER_HOME: /b/swarming/w/ir/tmp/git-home-task LOGDOG_COORDINATOR_HOST: logs.chromium.org LOGDOG_STREAM_PREFIX: buildbucket/cr-buildbucket.appspot.com/8915150642189658544 LOGDOG_STREAM_PROJECT: chromium LOGDOG_STREAM_SERVER_PATH: unix:/b/swarming/w/ir/tmp/ld.sock LOGICAL: eth0 LUCI_CONTEXT: /b/swarming/w/ir/tmp/luci_context.991010314 MAC_CHROMIUM_TMPDIR: /b/swarming/w/ir/tmp/t METHOD: dhcp NO_GCE_CHECK: False PATH: /b/swarming/w/ir/cipd_bin_packages:/b/swarming/w/ir/cipd_bin_packages/bin:/b/swarming/cipd_cache/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin PWD: /b/swarming/w/ir/k PYTHONIOENCODING: UTF-8 PYTHONUNBUFFERED: 1 ROOT_SETUP_LOG: /var/log/messages/chromebuild/root-setup.log SHLVL: 1 STARTUP_LOG: /var/log/messages/chromebuild/startup.log SWARMING_BOT_ID: swarm2473-c4 SWARMING_EXTERNAL_BOT_SETUP: 1 SWARMING_HEADLESS: 1 SWARMING_SERVER: https://chromium-swarm.appspot.com SWARMING_TASK_ID: 44705b9fbd2e0411 TEMP: /b/swarming/w/ir/tmp/t TEMPDIR: /b/swarming/w/ir/tmp/t TERM: linux TMP: /b/swarming/w/ir/tmp/t TMPDIR: /b/swarming/w/ir/tmp/t UPSTART_EVENTS: net-device-up UPSTART_INSTANCE: UPSTART_JOB: chromebuild-startup USER: chrome-bot USERNAME: chrome-bot VPYTHON_VIRTUALENV_ROOT: /b/swarming/w/ir/cache/vpython _: /b/swarming/w/ir/cipd_bin_packages/vpython !@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: a9faf939ccfd0c55429a31dffd7f31eaecdf397e WebApp: Introduce kDesktopPWAsUnifiedInstall base feature. Alexey Baskakov, Fri Apr 26 02:43:04 2019 +0000 0781429bb10a95aae3c9eb3141fc47852cfe300a Raise WebGL back buffer size limit to handle 8K monitors. Kenneth Russell, Fri Apr 26 02:41:52 2019 +0000 67312fe7f282e36abe16c8e1cbddac032a03b85e ReEnable CookieStore unittests mrefaat, Fri Apr 26 02:38:02 2019 +0000 f10ace2e9bef0a1c11bb1b51298b008a96a0126b Roll src/third_party/angle 51ac37eecbce..6f691fbb59c7 (1 commits) chromium-autoroll, Fri Apr 26 02:37:31 2019 +0000 f6f996d261ec55f7b27f6c129a33c28f18fd1560 TEXTAREA: Fix selectionStart and selectionEnd after setting value while parsing TEXTAREA children. Kent Tamura, Fri Apr 26 02:34:21 2019 +0000 1f66030f01556063757e131985de756a2650b409 Roll src/third_party/swiftshader 244660437f4b..548e366ab3c3 (1 commits) chromium-autoroll, Fri Apr 26 02:32:42 2019 +0000 9058a46a416d588db08c4067bb0db3bb9f44fa02 Roll src-internal d976aa747010..6138c7806098 (3 commits) chromium-internal-autoroll, Fri Apr 26 02:30:11 2019 +0000 84dd86685519f3cd7a880d03fdae1ecae8463e94 Add comment explaining why chrome_proxy.exe exists Alan Cutter, Fri Apr 26 02:28:21 2019 +0000 b822fd4f2802e8ac24b2955601d228e0ddb26b96 Implement window.requestPostAnimationFrame Stefan Zager, Fri Apr 26 02:25:50 2019 +0000 d8715b3d539f50c0ae5c96cf0c4197fc53c6c347 Roll src/third_party/dawn 3826880f81c3..ef90079944eb (1 commits) chromium-autoroll, Fri Apr 26 02:25:40 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit a9faf939ccfd0c55429a31dffd7f31eaecdf397e Author: Alexey Baskakov <loyso@chromium.org> Date: Fri Apr 26 02:43:04 2019 +0000 WebApp: Introduce kDesktopPWAsUnifiedInstall base feature. --enable-features=DesktopPWAsUnifiedInstall will enable WebAppInstallManager implementation of the abstract InstallManager interface. This implementation doesn't use extensions at all. Bug: 915043 Change-Id: I895739d39839aa55425c0fe190d22732e95b4858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584526 Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#654329} chrome/browser/web_applications/web_app_provider.cc | 10 ++++++++-- chrome/common/chrome_features.cc | 5 +++++ chrome/common/chrome_features.h | 3 +++ 3 files changed, 16 insertions(+), 2 deletions(-) commit 0781429bb10a95aae3c9eb3141fc47852cfe300a Author: Kenneth Russell <kbr@chromium.org> Date: Fri Apr 26 02:41:52 2019 +0000 Raise WebGL back buffer size limit to handle 8K monitors. This is a short term fix to better handle larger monitors. Eliminating the need for this limit is a more difficult task, and will follow. Bug: 952724 Bug: 756347 Change-Id: Ia32fb6572f0888cdeb6a7dbfbe74ad382d839362 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583347 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#654328} .../renderer/modules/webgl/webgl_rendering_context_base.cc | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) commit 67312fe7f282e36abe16c8e1cbddac032a03b85e Author: mrefaat <mrefaat@chromium.org> Date: Fri Apr 26 02:38:02 2019 +0000 ReEnable CookieStore unittests Use off the record browserstate in the test to force using of non-persistent cookie store Bug: 956477 Change-Id: I70432fa2e5c4133e19d51267314972bb7bb67729 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585066 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#654327} .../system_cookie_store_unittest_template.h | 25 +++++++++------------- .../wk_http_system_cookie_store_unittest.mm | 3 +++ 2 files changed, 13 insertions(+), 15 deletions(-) commit f10ace2e9bef0a1c11bb1b51298b008a96a0126b Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 26 02:37:31 2019 +0000 Roll src/third_party/angle 51ac37eecbce..6f691fbb59c7 (1 commits) https://chromium.googlesource.com/angle/angle.git/+log/51ac37eecbce..6f691fbb59c7 git log 51ac37eecbce..6f691fbb59c7 --date=short --no-merges --format='%ad %ae %s' 2019-04-25 geofflang@chromium.org Port the WebGL2 framebuffer-texture-changing-base-level test to native Created with: gclient setdep -r src/third_party/angle@6f691fbb59c7 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: If369878026c1b7feb3d20633b6e04b4bd626a848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584712 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#654326} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit f6f996d261ec55f7b27f6c129a33c28f18fd1560 Author: Kent Tamura <tkent@chromium.org> Date: Fri Apr 26 02:34:21 2019 +0000 TEXTAREA: Fix selectionStart and selectionEnd after setting value while parsing TEXTAREA children. We checked IsFinishedParsingChildren() in SetValueCommon() in order to avoid changing selection repeatedly while parsing. It caused this bug, and the check is unnecessary now because parsing TEXTAREA children doesn't move selectionStart/End to the end of the value since crrev.com/653487. Bug: 822639 Change-Id: Ic4353c8cac372da1fc964f51576b306b240ae6b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583172 Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#654325} .../core/html/forms/html_text_area_element.cc | 3 +-- .../textarea-selection-while-parsing.xhtml | 20 ++++++++++++++++++++ 2 files changed, 21 insertions(+), 2 deletions(-) commit 1f66030f01556063757e131985de756a2650b409 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 26 02:32:42 2019 +0000 Roll src/third_party/swiftshader 244660437f4b..548e366ab3c3 (1 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/244660437f4b..548e366ab3c3 git log 244660437f4b..548e366ab3c3 --date=short --no-merges --format='%ad %ae %s' 2019-04-25 chrisforbes@google.com Plumb constants through to the sampler, and make sRGB work Created with: gclient setdep -r src/third_party/swiftshader@548e366ab3c3 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/129523279 TBR=swiftshader-team+autoroll@chromium.org Change-Id: Ifae40360fca74540f47b58d2dbc8492fd044a54c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584711 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#654324} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 9058a46a416d588db08c4067bb0db3bb9f44fa02 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Fri Apr 26 02:30:11 2019 +0000 Roll src-internal d976aa747010..6138c7806098 (3 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d976aa747010..6138c7806098 Created with: gclient setdep -r src-internal@6138c7806098 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=cmumford@chromium.org,gab@chromium.org,droger@chromium.org Change-Id: I7f4329aa10b225ed8b92d990ea1fa20f94617880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585112 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#654323} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 84dd86685519f3cd7a880d03fdae1ecae8463e94 Author: Alan Cutter <alancutter@chromium.org> Date: Fri Apr 26 02:28:21 2019 +0000 Add comment explaining why chrome_proxy.exe exists Bug: 732357 Change-Id: Iedae967997bade3143ba6a2b8bd8e5fb43534ca2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585399 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by: Bugs Nash <bugsnash@chromium.org> Cr-Commit-Position: refs/heads/master@{#654322} chrome/chrome_proxy/chrome_proxy_main_win.cc | 14 ++++++++++++++ 1 file changed, 14 insertions(+) commit b822fd4f2802e8ac24b2955601d228e0ddb26b96 Author: Stefan Zager <szager@chromium.org> Date: Fri Apr 26 02:25:50 2019 +0000 Implement window.requestPostAnimationFrame This can only be called from within a requestAnimationFrame callback. It registers a callback that will run synchronously at the end of a lifecycle update, with no possibility of any other javascript running before it. Bug: 956293 Change-Id: I9e42ef043588134ed9ded638e1f8474eedbf800b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1423738 Reviewed-by: Klaus Weidner <klausw@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#654321} third_party/blink/renderer/core/dom/document.cc | 23 +++++- third_party/blink/renderer/core/dom/document.h | 8 ++ .../core/dom/frame_request_callback_collection.cc | 96 +++++++++++++++++----- .../core/dom/frame_request_callback_collection.h | 36 ++++++-- .../core/dom/scripted_animation_controller.cc | 93 ++++++++++++++------- .../core/dom/scripted_animation_controller.h | 18 ++-- .../core/dom/scripted_animation_controller_test.cc | 22 ++--- .../blink/renderer/core/frame/local_dom_window.cc | 40 ++++++--- .../blink/renderer/core/frame/local_dom_window.h | 2 + third_party/blink/renderer/core/frame/window.idl | 2 + .../blink/renderer/core/page/page_animator.cc | 17 +++- .../blink/renderer/core/page/page_animator.h | 1 + .../renderer/core/page/page_widget_delegate.cc | 6 ++ .../renderer/core/page/page_widget_delegate.h | 1 + .../workers/worker_animation_frame_provider.cc | 7 +- .../blink/renderer/modules/vr/vr_display.cc | 6 +- .../platform/runtime_enabled_features.json5 | 4 + .../lifecycle/request-post-animation-frame.html | 71 ++++++++++++++++ .../global-interface-listing-expected.txt | 2 + 19 files changed, 362 insertions(+), 93 deletions(-) commit d8715b3d539f50c0ae5c96cf0c4197fc53c6c347 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 26 02:25:40 2019 +0000 Roll src/third_party/dawn 3826880f81c3..ef90079944eb (1 commits) https://dawn.googlesource.com/dawn.git/+log/3826880f81c3..ef90079944eb git log 3826880f81c3..ef90079944eb --date=short --no-merges --format='%ad %ae %s' 2019-04-25 cwallez@chromium.org CommandEncoder: promote errors to device errors after finish() Created with: gclient setdep -r src/third_party/dawn@ef90079944eb The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@chromium.org Change-Id: I208b733203dd7b4e207a6893d72ec6efc8432e1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585111 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#654320} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 4f7ce36dc808bcbff307bbc4b239a3abd3ad6efc Author: Christopher Cameron <ccameron@chromium.org> Date: Fri Apr 26 02:21:37 2019 +0000 Skia/Metal: Add base::Feature for Metal The feature controls creation of a viz::MetalContextProvider, then propagates to the SharedContextState. Bug: 952063 Change-Id: I38d221c18aea003a1e3ff5f9c390d713f349ef09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582452 Reviewed-by: Antoine Labour <piman@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Eric Karl <ericrk@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#654319} components/viz/service/gl/gpu_service_impl.cc | 9 ++++++++- components/viz/service/gl/gpu_service_impl.h | 2 ++ content/public/browser/gpu_utils.cc | 4 ++++ gpu/config/gpu_finch_features.cc | 5 +++++ gpu/config/gpu_finch_features.h | 4 ++++ gpu/config/gpu_preferences.h | 4 ++++ gpu/ipc/common/gpu_preferences.mojom | 1 + gpu/ipc/common/gpu_preferences_struct_traits.h | 4 ++++ gpu/ipc/service/gpu_channel_manager.cc | 8 +++++--- gpu/ipc/service/gpu_channel_manager.h | 9 +++++++-- 10 files changed, 44 insertions(+), 6 deletions(-) commit 2fb824353913bcc3ae815b8b0a6288ddee708358 Author: Alexey Baskakov <loyso@chromium.org> Date: Fri Apr 26 02:19:14 2019 +0000 WebApp: Implement InstallWebAppFromInfo for the new WebApp system. - Implement force_launch_container in InstallFinalizer::FinalizeOptions. - Use no_network_install option. Note: InstallWebAppFromInfo is used by: - chrome.management.generateAppForLink js API. - ApkWebAppInstaller (WebApps from PlayStore). Bug: 901226 Change-Id: Ib186d39d8f2231f64aa9e07d00301db0a4b495c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570956 Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#654318} .../components/install_finalizer.h | 4 + .../web_applications/components/install_manager.h | 7 +- .../components/web_app_install_utils.cc | 26 +++-- .../components/web_app_install_utils.h | 4 + .../extensions/bookmark_app_install_finalizer.cc | 26 +++-- .../bookmark_app_install_finalizer_unittest.cc | 38 ++++++- .../bookmark_app_installation_task_unittest.cc | 2 +- .../test/test_install_finalizer.cc | 7 +- .../web_applications/test/test_install_finalizer.h | 6 +- .../web_applications/web_app_install_manager.cc | 12 ++- .../web_applications/web_app_install_task.cc | 45 ++++++-- .../web_applications/web_app_install_task.h | 12 +++ .../web_app_install_task_unittest.cc | 120 +++++++++++++++++++++ 13 files changed, 271 insertions(+), 38 deletions(-) commit b74c13a3ee2bdc6c9e462a354d3a90dc47ad37f2 Author: Aga Wronska <agawronska@chromium.org> Date: Fri Apr 26 02:17:28 2019 +0000 Fix crash when session is restarted for child user During session restart ScreenTimeController was creating ParentAccessService that depends on the LoginScreenClient before LoginScreenClient was created. Lazy initialize ParentAccessService to prevent crash. Bug: 956375 Test: CrashRestoreChildUserTest Change-Id: I118e80b06297ae098f22e5132bc6d03b0ae21b4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585073 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#654317} .../parent_access_code/parent_access_service.cc | 1 + .../child_accounts/screen_time_controller.cc | 26 ++++--- .../child_accounts/screen_time_controller.h | 4 + .../screen_time_controller_factory.cc | 5 +- .../chromeos/login/crash_restore_browsertest.cc | 91 ++++++++++++++++++++++ .../login/encryption_migration_browsertest.cc | 17 ++-- .../login/login_ui_shelf_visibility_browsertest.cc | 7 +- chrome/browser/chromeos/login/reset_browsertest.cc | 6 +- .../assistant_optin_flow_screen_browsertest.cc | 8 +- .../login/session/chrome_session_manager.cc | 2 +- .../chromeos/login/test/login_manager_mixin.cc | 26 ++++--- .../chromeos/login/test/login_manager_mixin.h | 28 ++++++- 12 files changed, 178 insertions(+), 43 deletions(-) commit 8e5693c6b1a5595068de77db0c4e209cd25bdcf2 Author: Caleb Raitto <caraitto@chromium.org> Date: Fri Apr 26 02:17:04 2019 +0000 [Cronet] Note that the UrlRequest owns the response info and error. Also, note this in the implementation, including implications for locking. Bug: 938630 Change-Id: Id8ff8dda2e069905616e6b852d99532a289020d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582231 Reviewed-by: Misha Efimov <mef@chromium.org> Reviewed-by: Paul Jensen <pauljensen@chromium.org> Commit-Queue: Caleb Raitto <caraitto@chromium.org> Cr-Commit-Position: refs/heads/master@{#654316} components/cronet/native/cronet.idl | 18 +++++++++++------- components/cronet/native/url_request.h | 10 ++++++++++ 2 files changed, 21 insertions(+), 7 deletions(-) commit cd5baf9ca36c94792d5502713157617e72b51f4c Author: Piotr Bialecki <bialpio@chromium.org> Date: Fri Apr 26 02:16:24 2019 +0000 Add mojo changes for WebXR plane detection Bug: 954530 Change-Id: Ieb89dc326cae071ed8303736a54698ad82e6ad09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580139 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Bill Orr <billorr@chromium.org> Reviewed-by: Klaus Weidner <klausw@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#654315} .../android/vr/arcore_device/arcore_device_unittest.cc | 1 + chrome/browser/android/vr/arcore_device/arcore_gl.cc | 1 + chrome/browser/android/vr/arcore_device/arcore_gl.h | 3 ++- chrome/browser/android/vr/gvr_scheduler_delegate.cc | 2 +- chrome/browser/android/vr/gvr_scheduler_delegate.h | 3 ++- device/vr/public/mojom/vr_service.mojom | 16 ++++++++++++++-- device/vr/vr_display_impl.cc | 1 + device/vr/vr_display_impl.h | 3 ++- device/vr/vr_display_impl_unittest.cc | 18 ++++++++---------- device/vr/windows/compositor_base.cc | 7 ++++--- device/vr/windows/compositor_base.h | 3 ++- third_party/blink/renderer/modules/vr/vr_display.cc | 6 ++++-- .../blink/renderer/modules/xr/xr_frame_provider.cc | 10 ++++++---- 13 files changed, 48 insertions(+), 26 deletions(-) Updated tag 'tree_truth' (was b2242dae247a)