Back to build
Raw log | Switch to full mode | Login

!@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: f815e39bad34c1806419c6aaaf5230b5d5776c2e Revert "Don't update the shelf state while visibility update is suspended." Fergus Dall, Mon May 20 23:21:39 2019 +0000 9b38f10e6502ad7dddc23357de272a106c544ec8 Make sure View classes in ash/system/tray + others have specific class names. Andrew Lee, Mon May 20 23:21:29 2019 +0000 037896ecfceb90799def69d8e4e988b65554a2dd Roll src/third_party/skia aeb71ce166c7..1903c94f44fd (4 commits) chromium-autoroll, Mon May 20 23:20:15 2019 +0000 80044a08abd28f990b8ddd2317884d00f69ca27a Roll src-internal b28d01ad3a2a..eb21b0ed50d6 (1 commits) chromium-internal-autoroll, Mon May 20 23:18:24 2019 +0000 f91f9b9ac101c0bd216bf0f5c9b5b0911884842a app_list: Move AppListItemMetadata out of mojo Xiyuan Xia, Mon May 20 23:15:09 2019 +0000 5ebec7c53b2ea5685ddac816e0bbd657e8a1978b [CAP] Do not clear data in PAC::EnableExtraDataForTesting Philip Rogers, Mon May 20 23:07:07 2019 +0000 2b9e1e5dc412bd93e5de1e89840b5e355852b794 Ash network icons: Remove unused label code and strings Steven Bennetts, Mon May 20 23:06:48 2019 +0000 718c514e6500497d30faa920323da9dcdd0f8e4b [LayoutNG] Make LayoutNGMixin::PaintFragment const Aleks Totic, Mon May 20 23:04:55 2019 +0000 5bb31c07fbefa8ec97f1c9e7ebc9e94151738ff5 Add Metal support for gl::ProgressReporter Christopher Cameron, Mon May 20 23:03:11 2019 +0000 cc9f0ad18271670713b10277b6502e6f4051afaf Roll src/third_party/angle 7a026133ee45..08146a27b7bc (1 commits) chromium-autoroll, Mon May 20 23:00:48 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit f815e39bad34c1806419c6aaaf5230b5d5776c2e Author: Fergus Dall <sidereal@google.com> Date: Mon May 20 23:21:39 2019 +0000 Revert "Don't update the shelf state while visibility update is suspended." This reverts commit 2dab363330309e5ff874060cf03003acb97b75f5. Reason for revert: Seems to have broken linux-chromeos-rel, see https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/24627 for first failure Original change's description: > Don't update the shelf state while visibility update is suspended. > > Bug: 958932 > Test: covered by unittest > > Change-Id: Id77232962c0f43d54c26c04c283a8687783f558b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619333 > Reviewed-by: Alex Newcomer <newcomer@chromium.org> > Commit-Queue: Mitsuru Oshima <oshima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#661430} TBR=oshima@chromium.org,newcomer@chromium.org Change-Id: Iaf36d7e03c9503e59a760e44439345b667ed7304 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 958932 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621407 Reviewed-by: Fergus Dall <sidereal@google.com> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#661526} ash/shelf/shelf_layout_manager.cc | 3 --- ash/shelf/shelf_layout_manager_unittest.cc | 11 ----------- 2 files changed, 14 deletions(-) commit 9b38f10e6502ad7dddc23357de272a106c544ec8 Author: Andrew Lee <myungjaelee@chromium.org> Date: Mon May 20 23:21:29 2019 +0000 Make sure View classes in ash/system/tray + others have specific class names. Currently, some View subclasses do not override getClassName(), so their class names will be "View" instead of something more specific like "AppListFolderView". This branch overrides getClassName() for all View subclasses in the following directories: ash/system/cast ash/system/locale ash/system/overview ash/system/session ash/system/tray Bug: 962561 Test: None Change-Id: I04e57a53f3f4f5e362a39b848bc30d48b4e468c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616971 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Jenny Zhang <jennyz@chromium.org> Commit-Queue: MyungJae Lee <myungjaelee@chromium.org> Cr-Commit-Position: refs/heads/master@{#661525} ash/system/cast/tray_cast.cc | 4 ++++ ash/system/cast/tray_cast.h | 3 +++ ash/system/locale/locale_detailed_view.cc | 6 ++++++ ash/system/locale/locale_detailed_view.h | 3 +++ ash/system/overview/overview_button_tray.cc | 4 ++++ ash/system/overview/overview_button_tray.h | 3 +++ ash/system/session/logout_button_tray.cc | 4 ++++ ash/system/session/logout_button_tray.h | 1 + ash/system/session/logout_confirmation_dialog.cc | 4 ++++ ash/system/session/logout_confirmation_dialog.h | 1 + ash/system/tray/hover_highlight_view.cc | 4 ++++ ash/system/tray/hover_highlight_view.h | 1 + ash/system/tray/label_tray_view.cc | 4 ++++ ash/system/tray/label_tray_view.h | 3 +++ ash/system/tray/system_menu_button.cc | 4 ++++ ash/system/tray/system_menu_button.h | 1 + ash/system/tray/tray_bubble_view.cc | 4 ++++ ash/system/tray/tray_bubble_view.h | 1 + ash/system/tray/tray_container.cc | 4 ++++ ash/system/tray/tray_container.h | 1 + ash/system/tray/tray_detailed_view.cc | 6 ++++++ ash/system/tray/tray_detailed_view.h | 1 + ash/system/tray/tray_info_label.cc | 4 ++++ ash/system/tray/tray_info_label.h | 3 +++ ash/system/tray/tray_item_view.cc | 4 ++++ ash/system/tray/tray_item_view.h | 1 + 26 files changed, 79 insertions(+) commit 037896ecfceb90799def69d8e4e988b65554a2dd Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon May 20 23:20:15 2019 +0000 Roll src/third_party/skia aeb71ce166c7..1903c94f44fd (4 commits) https://skia.googlesource.com/skia.git/+log/aeb71ce166c7..1903c94f44fd git log aeb71ce166c7..1903c94f44fd --date=short --no-merges --format='%ad %ae %s' 2019-05-20 reed@google.com use rect-memset in legacy rect blit 2019-05-20 reed@google.com rect-memset: memset + stride and height 2019-05-20 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-20 mtklein@google.com SkSLInterpreter refactoring Created with: gclient setdep -r src/third_party/skia@1903c94f44fd The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@google.com Change-Id: I0d0dcac743c1341178fc23eaa510bec935662d98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621306 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#661524} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 80044a08abd28f990b8ddd2317884d00f69ca27a Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Mon May 20 23:18:24 2019 +0000 Roll src-internal b28d01ad3a2a..eb21b0ed50d6 (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b28d01ad3a2a..eb21b0ed50d6 Created with: gclient setdep -r src-internal@eb21b0ed50d6 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=mbarowsky@google.com,sidereal@google.com Change-Id: I7d5ba590907590949e5edea7f00eaebbd4a663b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620897 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#661523} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit f91f9b9ac101c0bd216bf0f5c9b5b0911884842a Author: Xiyuan Xia <xiyuan@chromium.org> Date: Mon May 20 23:15:09 2019 +0000 app_list: Move AppListItemMetadata out of mojo - Declare struct AppListItemMetadata in app_list_types.h - Remove mojom::AppListItemMetadata - AppListItemMetadataPtr -> std::unique_ptr<AppListItemMetadata> Bug: 958134 Change-Id: Ia2368ccf5e657ed16f2db38d7c6a43bd6b5469a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620571 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Reviewed-by: Sam McNally <sammc@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#661522} ash/app_list/app_list_controller_impl.cc | 21 +++++++++------- ash/app_list/app_list_controller_impl.h | 10 ++++---- ash/app_list/model/app_list_item.cc | 15 +++-------- ash/app_list/model/app_list_item.h | 18 ++++++++------ ash/app_list/test/test_app_list_client.h | 6 ++--- ash/public/cpp/BUILD.gn | 2 +- ash/public/cpp/app_list/app_list_client.h | 15 ++++++----- ash/public/cpp/app_list/app_list_controller.h | 27 +++++++++++--------- ash/public/cpp/app_list/app_list_types.cc | 8 ++++++ ash/public/cpp/app_list/app_list_types.h | 22 ++++++++++++++++ ash/public/interfaces/app_list.mojom | 17 ------------- chrome/browser/ui/app_list/app_list_client_impl.cc | 9 ++++--- chrome/browser/ui/app_list/app_list_client_impl.h | 6 ++--- .../browser/ui/app_list/app_list_model_updater.h | 9 ++++--- .../ui/app_list/app_list_syncable_service.h | 1 - chrome/browser/ui/app_list/chrome_app_list_item.cc | 17 ++++++------- chrome/browser/ui/app_list/chrome_app_list_item.h | 7 +++--- .../ui/app_list/chrome_app_list_model_updater.cc | 29 +++++++++++----------- .../ui/app_list/chrome_app_list_model_updater.h | 6 ++--- .../crostini_app_model_builder_unittest.cc | 3 +-- .../app_list/test/chrome_app_list_test_support.cc | 13 ++++++---- .../app_list/test/fake_app_list_model_updater.cc | 10 +++----- .../ui/app_list/test/fake_app_list_model_updater.h | 10 +++++--- 23 files changed, 152 insertions(+), 129 deletions(-) commit 5ebec7c53b2ea5685ddac816e0bbd657e8a1978b Author: Philip Rogers <pdr@chromium.org> Date: Mon May 20 23:07:07 2019 +0000 [CAP] Do not clear data in PAC::EnableExtraDataForTesting PaintArtifactCompositor::EnableExtraDataForTesting had a bug where the extra_data_for_testing_ data would be cleared without marking PaintArtifactCompositor as needing an update. This only occurred when there were multiple calls to PAC::EnableExtraDataForTesting. This patch updates the function to do nothing if extra data for testing is already enabled. Bug: 909749 Change-Id: Ifcab15364ec882adfab0358cdb1d62984a653f61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618501 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by: Mason Freed <masonfreed@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#661521} .../graphics/compositing/paint_artifact_compositor.cc | 6 ++++-- .../enable-blink-features=CompositeAfterPaint | 11 ----------- 2 files changed, 4 insertions(+), 13 deletions(-) commit 2b9e1e5dc412bd93e5de1e89840b5e355852b794 Author: Steven Bennetts <stevenjb@chromium.org> Date: Mon May 20 23:06:48 2019 +0000 Ash network icons: Remove unused label code and strings In the new feature pod tray re-factoring, some strings and code that are no longer in use got left behind, this cleans them up. network_icon::GetLabelForNetwork was only getting called with icon_type ICON_TYPE_MENU_LIST, and GetDefaultLabel was unused. Bug: 862420 Change-Id: I538c9f65fe68df56c116a8be70c75cfb5c10f07c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614141 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#661520} ash/ash_strings.grd | 8 +- ash/system/network/active_network_icon.cc | 10 -- ash/system/network/active_network_icon.h | 7 +- ash/system/network/active_network_icon_unittest.cc | 27 ------ ash/system/network/network_icon.cc | 45 ++------- ash/system/network/network_icon.h | 7 +- ash/system/network/network_icon_unittest.cc | 102 ++++++--------------- ash/system/network/network_list.cc | 3 +- ash/system/network/vpn_list_view.cc | 3 +- 9 files changed, 45 insertions(+), 167 deletions(-) commit 718c514e6500497d30faa920323da9dcdd0f8e4b Author: Aleks Totic <atotic@chromium.org> Date: Mon May 20 23:04:55 2019 +0000 [LayoutNG] Make LayoutNGMixin::PaintFragment const PaintFragment should be mostly immutable. Making LayoutNGMixin::PaintFragment() a const enforces this. Bug: 635619 Change-Id: Idf2d56fb9bcb69e9e89510f6044cad6b280352cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620970 Commit-Queue: Aleks Totic <atotic@chromium.org> Auto-Submit: Aleks Totic <atotic@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#661519} .../renderer/core/layout/layout_block_flow.cc | 2 +- .../renderer/core/layout/layout_block_flow_line.cc | 2 +- .../blink/renderer/core/layout/layout_object.h | 2 +- .../core/layout/ng/inline/ng_dirty_lines.h | 4 ++-- .../core/layout/ng/inline/ng_inline_node.cc | 6 ++--- .../core/layout/ng/inline/ng_inline_node.h | 2 +- .../renderer/core/layout/ng/layout_ng_mixin.h | 2 +- .../core/paint/block_flow_paint_invalidator.cc | 2 +- .../renderer/core/paint/ng/ng_paint_fragment.cc | 12 +++++----- .../renderer/core/paint/ng/ng_paint_fragment.h | 8 +++---- .../paint/ng/ng_paint_fragment_traversal_test.cc | 2 +- .../core/paint/paint_layer_painter_test.cc | 26 +++++++++++++--------- .../renderer/core/testing/core_unit_test_helper.h | 5 +++-- 13 files changed, 40 insertions(+), 35 deletions(-) commit 5bb31c07fbefa8ec97f1c9e7ebc9e94151738ff5 Author: Christopher Cameron <ccameron@chromium.org> Date: Mon May 20 23:03:11 2019 +0000 Add Metal support for gl::ProgressReporter As in OpenGL OOP-Raster, it is possible for the GPU watchdog to be starved (non non-OOP-Raster, it can slide in between any two GL calls, but this isn't an option for OOP-Raster because we call GL directly, not through the out-of-process command buffer). To counter this, gl::init::CreateGrGLInterface conditionally wraps some GL calls that can be longer (things that allocate GPU memory or compile shaders) in a gl::ScopedProgressReporter. We are seeing lots of hangs in Metal for similar-seeming reasons (most but not all of them in shader compilation). Add a wrapper over the Metal protocol to report progress for the potentially-longer calls. Bug: 964476 Change-Id: Ibcc40d8054f4d70ce74e5d5d62d5a4cdb57ab766 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616994 Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Eric Karl <ericrk@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#661518} components/viz/common/BUILD.gn | 3 + components/viz/common/gpu/DEPS | 6 + components/viz/common/gpu/metal_api_proxy.h | 33 +++ components/viz/common/gpu/metal_api_proxy.mm | 256 +++++++++++++++++++++ components/viz/common/gpu/metal_context_provider.h | 9 + .../viz/common/gpu/metal_context_provider.mm | 19 +- gpu/command_buffer/service/shared_context_state.cc | 5 + 7 files changed, 325 insertions(+), 6 deletions(-) commit cc9f0ad18271670713b10277b6502e6f4051afaf Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon May 20 23:00:48 2019 +0000 Roll src/third_party/angle 7a026133ee45..08146a27b7bc (1 commits) https://chromium.googlesource.com/angle/angle.git/+log/7a026133ee45..08146a27b7bc git log 7a026133ee45..08146a27b7bc --date=short --no-merges --format='%ad %ae %s' 2019-05-20 thomasanderson@chromium.org Remove non-source sources from binary targets Created with: gclient setdep -r src/third_party/angle@08146a27b7bc The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:964411 TBR=ynovikov@google.com Change-Id: I86f6806cb7a1ec2ffe108544fdd96ae7a268b73d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620708 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#661517} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 1f73b879b73c76619f81f168899f5267dfdd5ecb Author: Steven Bennetts <stevenjb@chromium.org> Date: Mon May 20 22:56:16 2019 +0000 Use network_config.mojo in TrayNetworkStateObserver This CL also replaces TrayNetworkStateObserver::Delegate with an Observer so that a single instance can be shared with all system tray code. Bug: 862420 Change-Id: I413dc13f2826f9d1ebe116fef1a74624c16b91ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612361 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#661516} ash/system/model/system_tray_model.cc | 5 +- ash/system/model/system_tray_model.h | 6 +- ash/system/network/active_network_icon.cc | 1 - ash/system/network/network_feature_pod_button.cc | 5 +- ash/system/network/network_feature_pod_button.h | 8 +- ash/system/network/network_tray_view.cc | 13 +- ash/system/network/network_tray_view.h | 8 +- ash/system/network/tray_network_state_observer.cc | 148 ++++++++++++--------- ash/system/network/tray_network_state_observer.h | 69 ++++++---- .../unified_network_detailed_view_controller.cc | 20 ++- .../unified_network_detailed_view_controller.h | 8 +- .../unified_vpn_detailed_view_controller.cc | 18 ++- .../network/unified_vpn_detailed_view_controller.h | 8 +- ash/system/network/vpn_feature_pod_controller.cc | 12 +- ash/system/network/vpn_feature_pod_controller.h | 8 +- 15 files changed, 204 insertions(+), 133 deletions(-) commit 2fc01cc0992d821632a031e6a7587029376b15ea Author: Dale Curtis <dalecurtis@chromium.org> Date: Mon May 20 22:53:52 2019 +0000 Remove kHaveFutureData restriction from play state notifications. Take 2. This is a reland of b0ec93f6f1c9dd4754c813f198336a7a4c2f22a4, where by all issues which caused its revert should be fixed now, so lets give it another shot. Now that we're looking to launch preload=metadata lazy load more broadly, we need to remove this so we can remove the buffering state lies that WebMediaPlayerImpl tells to progress playback state updates. ---- [ Original description ] ---- HTMLMediaElement should tell WebMediaPlayer about play state changes as soon as the kHaveMetaData state is reached. This will eventually allow us to delete a bunch of guessing-game type code for idle suspension and instead rely on actually getting a play() call from Blink to wake up when needed. We can't stop WMPI from reaching the future data state quite yet though, because it has implications on the delivery of 'canplay' and 'canplaythrough' events that need to be part of a larger preload=metadata experiment. See old discussion on this here: https://lists.w3.org/Archives/Public/public-whatwg-archive/2015Jul/0007.html Note: This change exposed some bugs in how the ready state maximum is used and the states at which a video frame is expected. These issues are fixed in the HTMLVideoElement. BUG=694855, 756897, 809998, 812423, 879406 TEST=All existing tests pass. Change-Id: I6f47359a883db5cedd035f5a5a526e5761a2e4c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610526 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#661515} media/blink/webmediaplayer_impl.cc | 11 ++++++++--- .../blink/renderer/core/html/media/html_media_element.cc | 14 +++++--------- .../blink/renderer/core/html/media/html_video_element.cc | 5 +++-- 3 files changed, 16 insertions(+), 14 deletions(-) commit d2c99bacac294cc42147e4e312a615d843783ae6 Author: Stefan Zager <szager@chromium.org> Date: Mon May 20 22:53:47 2019 +0000 Upstream flexbox+scrollbars+direction+writing-mode tests R=cbiesinger@chromium.org Change-Id: Ifc7de13e67368d273dde22ef62bf940bb6193884 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618150 Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#661514} third_party/blink/web_tests/TestExpectations | 4 ++-- .../wpt/css/css-flexbox/scrollbars-auto-ref.html} | 7 ++++++- .../wpt/css/css-flexbox}/scrollbars-auto.html | 11 ++++++++++- .../wpt/css/css-flexbox/scrollbars-ref.html} | 7 ++++++- .../flexbox => external/wpt/css/css-flexbox}/scrollbars.html | 11 ++++++++++- .../wpt/css/css-flexbox/support}/scrollbars.js | 0 6 files changed, 34 insertions(+), 6 deletions(-) commit 17024af3abb8309f053fdcab0f88a52925d777d6 Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Mon May 20 22:52:31 2019 +0000 Update V8 to version 7.6.224. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/71714da9..7afc9ca4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8af3aafaa77ab435a1acf8c8c947dfc5867a004c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620570 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#661513} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 845d829c8b9cffd98ca4fc2a9c7efea9214924a1 Author: Robert Sesek <rsesek@chromium.org> Date: Mon May 20 22:51:27 2019 +0000 macOS Signing Scripts: Skip requirements strings if signing ad hoc. When signing with the ad hoc identity, codesign(1) appends a hash to the identifier. This would violate most kinds of requirements (which are based on identifiers), so skip them when signing ad hoc. Bug: 964611, 958163 Change-Id: I1656b2a0c524d1fbfec02a3cd69fc3a1dd386d98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620814 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#661512} chrome/installer/mac/signing/model.py | 8 ++++++++ chrome/installer/mac/signing/model_test.py | 12 ++++++++++++ 2 files changed, 20 insertions(+) commit 7693ab60e1b91fe0a8a2dacbbc70293a086fb049 Author: Krishna Govind <govind@chromium.org> Date: Mon May 20 22:51:20 2019 +0000 Updating XTBs based on .GRDs from branch master TBR=meacer@chromium.org Change-Id: Iaac57471099066021b8b21941c1c9b5ba15db940 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620706 Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by: Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#661511} ash/strings/ash_strings_hr.xtb | 3 + ash/strings/ash_strings_vi.xtb | 4 +- ...ndroid_chrome_autofill_assistant_strings_am.xtb | 2 - ...ndroid_chrome_autofill_assistant_strings_ar.xtb | 2 - ...ndroid_chrome_autofill_assistant_strings_bg.xtb | 2 - ...ndroid_chrome_autofill_assistant_strings_bn.xtb | 2 - ...ndroid_chrome_autofill_assistant_strings_ca.xtb | 4 +- ...ndroid_chrome_autofill_assistant_strings_cs.xtb | 2 - ...ndroid_chrome_autofill_assistant_strings_da.xtb | 2 - ...ndroid_chrome_autofill_assistant_strings_de.xtb | 2 - ...ndroid_chrome_autofill_assistant_strings_el.xtb | 2 - ...oid_chrome_autofill_assistant_strings_en-GB.xtb | 2 - ...id_chrome_autofill_assistant_strings_es-419.xtb | 2 - ...ndroid_chrome_autofill_assistant_strings_es.xtb | 2 - ...ndroid_chrome_autofill_assistant_strings_et.xtb | 2 - ...ndroid_chrome_autofill_assistant_strings_fa.xtb | 2 - ...ndroid_chrome_autofill_assistant_strings_fi.xtb | 2 - ...droid_chrome_autofill_assistant_strings_fil.xtb | 2 - ...ndroid_chrome_autofill_assistant_strings_fr.xtb | 2 - ...ndroid_chrome_autofill_assistant_strings_gu.xtb | 2 - ...ndroid_chrome_autofill_assistant_strings_hi.xtb | 2 - ...ndroid_chrome_autofill_assistant_strings_hr.xtb | 2 - ...ndroid_chrome_autofill_assistant_strings_hu.xtb | 2 - ...ndroid_chrome_autofill_assistant_strings_id.xtb | 2 - ...ndroid_chrome_autofill_assistant_strings_it.xtb | 2 - ...ndroid_chrome_autofill_assistant_strings_iw.xtb | 2 - ...ndroid_chrome_autofill_assistant_strings_ja.xtb | 2 - ...ndroid_chrome_autofill_assistant_strings_kn.xtb | 2 - ...ndroid_chrome_autofill_assistant_strings_ko.xtb | 2 - ...ndroid_chrome_autofill_assistant_strings_lt.xtb | 2 - ...ndroid_chrome_autofill_assistant_strings_lv.xtb | 2 - ...ndroid_chrome_autofill_assistant_strings_ml.xtb | 2 - ...ndroid_chrome_autofill_assistant_strings_mr.xtb | 2 - ...ndroid_chrome_autofill_assistant_strings_ms.xtb | 2 - ...ndroid_chrome_autofill_assistant_strings_nl.xtb | 2 - ...ndroid_chrome_autofill_assistant_strings_no.xtb | 2 - ...ndroid_chrome_autofill_assistant_strings_pl.xtb | 2 - ...oid_chrome_autofill_assistant_strings_pt-BR.xtb | 4 +- ...oid_chrome_autofill_assistant_strings_pt-PT.xtb | 2 - ...ndroid_chrome_autofill_assistant_strings_ro.xtb | 2 - ...ndroid_chrome_autofill_assistant_strings_ru.xtb | 2 - ...ndroid_chrome_autofill_assistant_strings_sk.xtb | 2 - ...ndroid_chrome_autofill_assistant_strings_sl.xtb | 2 - ...ndroid_chrome_autofill_assistant_strings_sr.xtb | 2 - ...ndroid_chrome_autofill_assistant_strings_sv.xtb | 2 - ...ndroid_chrome_autofill_assistant_strings_sw.xtb | 2 - ...ndroid_chrome_autofill_assistant_strings_ta.xtb | 2 - ...ndroid_chrome_autofill_assistant_strings_te.xtb | 2 - ...ndroid_chrome_autofill_assistant_strings_th.xtb | 2 - ...ndroid_chrome_autofill_assistant_strings_tr.xtb | 2 - ...ndroid_chrome_autofill_assistant_strings_uk.xtb | 2 - ...ndroid_chrome_autofill_assistant_strings_vi.xtb | 2 - ...oid_chrome_autofill_assistant_strings_zh-CN.xtb | 2 - ...oid_chrome_autofill_assistant_strings_zh-TW.xtb | 2 - .../android_keyboard_accessory_strings_hr.xtb | 2 + .../translations/android_chrome_strings_et.xtb | 2 +- .../translations/android_chrome_strings_hr.xtb | 1 + .../translations/android_chrome_strings_iw.xtb | 2 +- .../translations/android_chrome_strings_kn.xtb | 2 +- .../translations/android_chrome_strings_ko.xtb | 2 +- .../translations/android_chrome_strings_ms.xtb | 2 +- .../translations/android_chrome_strings_pt-BR.xtb | 2 +- .../translations/android_chrome_strings_ta.xtb | 4 +- .../translations/android_chrome_strings_vi.xtb | 8 +-- chrome/app/resources/chromium_strings_pt-BR.xtb | 2 +- chrome/app/resources/generated_resources_am.xtb | 2 - chrome/app/resources/generated_resources_ar.xtb | 2 - chrome/app/resources/generated_resources_bg.xtb | 5 +- chrome/app/resources/generated_resources_bn.xtb | 5 +- chrome/app/resources/generated_resources_ca.xtb | 13 ++--- chrome/app/resources/generated_resources_cs.xtb | 2 - chrome/app/resources/generated_resources_da.xtb | 5 +- chrome/app/resources/generated_resources_de.xtb | 5 +- chrome/app/resources/generated_resources_el.xtb | 5 +- chrome/app/resources/generated_resources_en-GB.xtb | 2 - .../app/resources/generated_resources_es-419.xtb | 5 +- chrome/app/resources/generated_resources_es.xtb | 2 - chrome/app/resources/generated_resources_et.xtb | 5 +- chrome/app/resources/generated_resources_fa.xtb | 4 +- chrome/app/resources/generated_resources_fi.xtb | 5 +- chrome/app/resources/generated_resources_fil.xtb | 2 - chrome/app/resources/generated_resources_fr.xtb | 5 +- chrome/app/resources/generated_resources_gu.xtb | 2 - chrome/app/resources/generated_resources_hi.xtb | 5 +- chrome/app/resources/generated_resources_hr.xtb | 38 ++++++++++++- chrome/app/resources/generated_resources_hu.xtb | 5 +- chrome/app/resources/generated_resources_id.xtb | 2 - chrome/app/resources/generated_resources_it.xtb | 5 +- chrome/app/resources/generated_resources_iw.xtb | 11 ++-- chrome/app/resources/generated_resources_ja.xtb | 2 - chrome/app/resources/generated_resources_kn.xtb | 9 +-- chrome/app/resources/generated_resources_ko.xtb | 15 ++--- chrome/app/resources/generated_resources_lt.xtb | 5 +- chrome/app/resources/generated_resources_lv.xtb | 5 +- chrome/app/resources/generated_resources_ml.xtb | 5 +- chrome/app/resources/generated_resources_mr.xtb | 5 +- chrome/app/resources/generated_resources_ms.xtb | 12 ++-- chrome/app/resources/generated_resources_nl.xtb | 5 +- chrome/app/resources/generated_resources_no.xtb | 5 +- chrome/app/resources/generated_resources_pl.xtb | 2 - chrome/app/resources/generated_resources_pt-BR.xtb | 8 +-- chrome/app/resources/generated_resources_pt-PT.xtb | 2 - chrome/app/resources/generated_resources_ro.xtb | 2 - chrome/app/resources/generated_resources_ru.xtb | 5 +- chrome/app/resources/generated_resources_sk.xtb | 5 +- chrome/app/resources/generated_resources_sl.xtb | 5 +- chrome/app/resources/generated_resources_sr.xtb | 2 - chrome/app/resources/generated_resources_sv.xtb | 2 - chrome/app/resources/generated_resources_sw.xtb | 2 - chrome/app/resources/generated_resources_ta.xtb | 12 ++-- chrome/app/resources/generated_resources_te.xtb | 5 +- chrome/app/resources/generated_resources_th.xtb | 2 - chrome/app/resources/generated_resources_tr.xtb | 5 +- chrome/app/resources/generated_resources_uk.xtb | 2 - chrome/app/resources/generated_resources_vi.xtb | 12 ++-- chrome/app/resources/generated_resources_zh-CN.xtb | 2 - chrome/app/resources/generated_resources_zh-TW.xtb | 5 +- .../app/resources/google_chrome_strings_pt-BR.xtb | 2 +- chrome/app/resources/google_chrome_strings_vi.xtb | 2 +- .../camera/src/strings/camera_strings_hr.xtb | 2 + .../chromevox/strings/chromevox_strings_iw.xtb | 6 +- .../chromevox/strings/chromevox_strings_vi.xtb | 4 +- .../policy/resources/policy_templates_ca.xtb | 66 +++++++++++----------- .../policy/resources/policy_templates_hr.xtb | 60 ++++++++++++++++++++ .../policy/resources/policy_templates_iw.xtb | 36 ++++++------ .../policy/resources/policy_templates_kn.xtb | 2 +- .../policy/resources/policy_templates_ko.xtb | 20 +++---- .../policy/resources/policy_templates_ms.xtb | 22 ++++---- .../policy/resources/policy_templates_pt-BR.xtb | 36 ++++++------ .../policy/resources/policy_templates_ta.xtb | 18 +++--- .../policy/resources/policy_templates_vi.xtb | 64 ++++++++++----------- components/strings/components_strings_am.xtb | 3 - components/strings/components_strings_ar.xtb | 3 - components/strings/components_strings_bg.xtb | 3 - components/strings/components_strings_bn.xtb | 3 - components/strings/components_strings_ca.xtb | 3 - components/strings/components_strings_cs.xtb | 3 - components/strings/components_strings_da.xtb | 3 - components/strings/components_strings_de.xtb | 3 - components/strings/components_strings_el.xtb | 3 - components/strings/components_strings_en-GB.xtb | 3 - components/strings/components_strings_es-419.xtb | 3 - components/strings/components_strings_es.xtb | 3 - components/strings/components_strings_et.xtb | 3 - components/strings/components_strings_fa.xtb | 3 - components/strings/components_strings_fi.xtb | 3 - components/strings/components_strings_fil.xtb | 3 - components/strings/components_strings_fr.xtb | 3 - components/strings/components_strings_gu.xtb | 3 - components/strings/components_strings_hi.xtb | 3 - components/strings/components_strings_hr.xtb | 17 +++++- components/strings/components_strings_hu.xtb | 3 - components/strings/components_strings_id.xtb | 3 - components/strings/components_strings_it.xtb | 3 - components/strings/components_strings_iw.xtb | 3 - components/strings/components_strings_ja.xtb | 3 - components/strings/components_strings_kn.xtb | 3 - components/strings/components_strings_ko.xtb | 3 - components/strings/components_strings_lt.xtb | 3 - components/strings/components_strings_lv.xtb | 3 - components/strings/components_strings_ml.xtb | 3 - components/strings/components_strings_mr.xtb | 3 - components/strings/components_strings_ms.xtb | 3 - components/strings/components_strings_nl.xtb | 3 - components/strings/components_strings_no.xtb | 3 - components/strings/components_strings_pl.xtb | 3 - components/strings/components_strings_pt-BR.xtb | 3 - components/strings/components_strings_pt-PT.xtb | 3 - components/strings/components_strings_ro.xtb | 3 - components/strings/components_strings_ru.xtb | 3 - components/strings/components_strings_sk.xtb | 3 - components/strings/components_strings_sl.xtb | 3 - components/strings/components_strings_sr.xtb | 3 - components/strings/components_strings_sv.xtb | 3 - components/strings/components_strings_sw.xtb | 3 - components/strings/components_strings_ta.xtb | 7 +-- components/strings/components_strings_te.xtb | 3 - components/strings/components_strings_th.xtb | 3 - components/strings/components_strings_tr.xtb | 3 - components/strings/components_strings_uk.xtb | 3 - components/strings/components_strings_vi.xtb | 11 ++-- components/strings/components_strings_zh-CN.xtb | 3 - components/strings/components_strings_zh-TW.xtb | 3 - .../strings/translations/content_strings_hr.xtb | 1 + .../strings/resources/ios_chromium_strings_hr.xtb | 2 + .../resources/ios_google_chrome_strings_hr.xtb | 2 + .../app/strings/resources/ios_strings_ca.xtb | 2 +- .../app/strings/resources/ios_strings_hr.xtb | 15 +++++ .../app/strings/resources/ios_strings_ms.xtb | 2 +- remoting/resources/remoting_strings_ta.xtb | 4 +- .../translations/ui_chromeos_strings_am.xtb | 5 -- .../translations/ui_chromeos_strings_ar.xtb | 5 -- .../translations/ui_chromeos_strings_bg.xtb | 5 -- .../translations/ui_chromeos_strings_bn.xtb | 5 -- .../translations/ui_chromeos_strings_ca.xtb | 5 -- .../translations/ui_chromeos_strings_cs.xtb | 5 -- .../translations/ui_chromeos_strings_da.xtb | 5 -- .../translations/ui_chromeos_strings_de.xtb | 5 -- .../translations/ui_chromeos_strings_el.xtb | 5 -- .../translations/ui_chromeos_strings_en-GB.xtb | 5 -- .../translations/ui_chromeos_strings_es-419.xtb | 5 -- .../translations/ui_chromeos_strings_es.xtb | 5 -- .../translations/ui_chromeos_strings_et.xtb | 5 -- .../translations/ui_chromeos_strings_fa.xtb | 5 -- .../translations/ui_chromeos_strings_fi.xtb | 5 -- .../translations/ui_chromeos_strings_fil.xtb | 5 -- .../translations/ui_chromeos_strings_fr.xtb | 5 -- .../translations/ui_chromeos_strings_gu.xtb | 5 -- .../translations/ui_chromeos_strings_hi.xtb | 5 -- .../translations/ui_chromeos_strings_hr.xtb | 5 -- .../translations/ui_chromeos_strings_hu.xtb | 5 -- .../translations/ui_chromeos_strings_id.xtb | 5 -- .../translations/ui_chromeos_strings_it.xtb | 5 -- .../translations/ui_chromeos_strings_iw.xtb | 5 -- .../translations/ui_chromeos_strings_ja.xtb | 5 -- .../translations/ui_chromeos_strings_kn.xtb | 5 -- .../translations/ui_chromeos_strings_ko.xtb | 5 -- .../translations/ui_chromeos_strings_lt.xtb | 5 -- .../translations/ui_chromeos_strings_lv.xtb | 5 -- .../translations/ui_chromeos_strings_ml.xtb | 5 -- .../translations/ui_chromeos_strings_mr.xtb | 5 -- .../translations/ui_chromeos_strings_ms.xtb | 5 -- .../translations/ui_chromeos_strings_nl.xtb | 5 -- .../translations/ui_chromeos_strings_no.xtb | 5 -- .../translations/ui_chromeos_strings_pl.xtb | 5 -- .../translations/ui_chromeos_strings_pt-BR.xtb | 5 -- .../translations/ui_chromeos_strings_pt-PT.xtb | 5 -- .../translations/ui_chromeos_strings_ro.xtb | 5 -- .../translations/ui_chromeos_strings_ru.xtb | 5 -- .../translations/ui_chromeos_strings_sk.xtb | 5 -- .../translations/ui_chromeos_strings_sl.xtb | 5 -- .../translations/ui_chromeos_strings_sr.xtb | 5 -- .../translations/ui_chromeos_strings_sv.xtb | 5 -- .../translations/ui_chromeos_strings_sw.xtb | 5 -- .../translations/ui_chromeos_strings_ta.xtb | 4 -- .../translations/ui_chromeos_strings_te.xtb | 5 -- .../translations/ui_chromeos_strings_th.xtb | 5 -- .../translations/ui_chromeos_strings_tr.xtb | 5 -- .../translations/ui_chromeos_strings_uk.xtb | 5 -- .../translations/ui_chromeos_strings_vi.xtb | 5 -- .../translations/ui_chromeos_strings_zh-CN.xtb | 5 -- .../translations/ui_chromeos_strings_zh-TW.xtb | 5 -- ui/strings/translations/ui_strings_am.xtb | 1 - ui/strings/translations/ui_strings_ar.xtb | 1 - ui/strings/translations/ui_strings_bg.xtb | 1 - ui/strings/translations/ui_strings_bn.xtb | 1 - ui/strings/translations/ui_strings_ca.xtb | 1 - ui/strings/translations/ui_strings_cs.xtb | 1 - ui/strings/translations/ui_strings_da.xtb | 1 - ui/strings/translations/ui_strings_de.xtb | 1 - ui/strings/translations/ui_strings_el.xtb | 1 - ui/strings/translations/ui_strings_en-GB.xtb | 1 - ui/strings/translations/ui_strings_es-419.xtb | 1 - ui/strings/translations/ui_strings_es.xtb | 1 - ui/strings/translations/ui_strings_et.xtb | 1 - ui/strings/translations/ui_strings_fa.xtb | 1 - ui/strings/translations/ui_strings_fi.xtb | 1 - ui/strings/translations/ui_strings_fil.xtb | 1 - ui/strings/translations/ui_strings_fr.xtb | 1 - ui/strings/translations/ui_strings_gu.xtb | 1 - ui/strings/translations/ui_strings_hi.xtb | 1 - ui/strings/translations/ui_strings_hr.xtb | 1 - ui/strings/translations/ui_strings_hu.xtb | 1 - ui/strings/translations/ui_strings_id.xtb | 1 - ui/strings/translations/ui_strings_it.xtb | 1 - ui/strings/translations/ui_strings_iw.xtb | 1 - ui/strings/translations/ui_strings_ja.xtb | 1 - ui/strings/translations/ui_strings_kn.xtb | 1 - ui/strings/translations/ui_strings_ko.xtb | 1 - ui/strings/translations/ui_strings_lt.xtb | 1 - ui/strings/translations/ui_strings_lv.xtb | 1 - ui/strings/translations/ui_strings_ml.xtb | 1 - ui/strings/translations/ui_strings_mr.xtb | 1 - ui/strings/translations/ui_strings_ms.xtb | 3 +- ui/strings/translations/ui_strings_nl.xtb | 1 - ui/strings/translations/ui_strings_no.xtb | 1 - ui/strings/translations/ui_strings_pl.xtb | 1 - ui/strings/translations/ui_strings_pt-BR.xtb | 1 - ui/strings/translations/ui_strings_pt-PT.xtb | 1 - ui/strings/translations/ui_strings_ro.xtb | 1 - ui/strings/translations/ui_strings_ru.xtb | 1 - ui/strings/translations/ui_strings_sk.xtb | 1 - ui/strings/translations/ui_strings_sl.xtb | 1 - ui/strings/translations/ui_strings_sr.xtb | 1 - ui/strings/translations/ui_strings_sv.xtb | 1 - ui/strings/translations/ui_strings_sw.xtb | 1 - ui/strings/translations/ui_strings_ta.xtb | 1 - ui/strings/translations/ui_strings_te.xtb | 1 - ui/strings/translations/ui_strings_th.xtb | 1 - ui/strings/translations/ui_strings_tr.xtb | 1 - ui/strings/translations/ui_strings_uk.xtb | 1 - ui/strings/translations/ui_strings_vi.xtb | 1 - ui/strings/translations/ui_strings_zh-CN.xtb | 1 - ui/strings/translations/ui_strings_zh-TW.xtb | 1 - 294 files changed, 421 insertions(+), 876 deletions(-) commit f74d41e0b8b5765ee9c05a621ca4d37667ee7db2 Author: Bret Sepulveda <bsep@chromium.org> Date: Mon May 20 22:50:04 2019 +0000 Delete group menu button from TabGroupHeader. The current plan is to use a right-click context menu for the first pass, which means the current group menu button is no longer necessary. This also fixes an issue where browser tests could not tear down if a group was active, because the group menu button didn't have the correct accessibility settings. Bug: 905491, 946263 Change-Id: I3f60f3d23686021bd777c45913930158578f2d25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621245 Reviewed-by: Taylor Bergquist <tbergquist@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#661510} chrome/browser/ui/browser_browsertest.cc | 3 --- chrome/browser/ui/views/tabs/tab_group_header.cc | 7 ------- 2 files changed, 10 deletions(-) commit 88344c40429e14a38e9e78c02b3d40ef87b2052d Author: Siye Liu <siliu@microsoft.com> Date: Mon May 20 22:44:00 2019 +0000 Candidate window should show up in editable area in flash controls. When using TSF on Windows and the focus is in editable area in flash control, we report TS_E_NOLAYOUT to input service. The no layout notification blocks candidate window ui from showing up. Bug: 960885 Change-Id: I646877b284b8aaa8a7d445d20c8e0648e591f93a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603822 Reviewed-by: Yohei Yukawa <yukawa@chromium.org> Reviewed-by: Kazuhiro Inaba <kinaba@chromium.org> Commit-Queue: Siye Liu <siliu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#661509} ui/base/ime/win/tsf_text_store.cc | 26 ++++++++++++++++---------- ui/base/ime/win/tsf_text_store_unittest.cc | 4 +++- 2 files changed, 19 insertions(+), 11 deletions(-) commit c99969f800ec18e14893dd49b19b1399fa7bc5e6 Author: Alison Maher <almaher@microsoft.com> Date: Mon May 20 22:42:22 2019 +0000 Fix MoveEndpointByUnit (TextUnit_Format) degenerate range creation ITextRangeProvider::MoveEndpointByUnit for TextUnit_Format will not create a degenerate range in certain cases when at the beginning or end of a document. The reason is that CreatePositionAtFormatBoundary() uses CreateNextTextAnchorPosition()/CreatePreviousTextAnchorPosition() to traverse to the next anchor boundary. This can pose a problem in the case where the range start and end span the same anchor. For example: Text ^ ^ start end When the above case is at the beginning of the document, and you try to create a degenerate range by moving end to the start, CreatePositionAtFormatBoundary() will call CreatePreviousTextAnchorPosition(). This will return a null position because there is no previous text anchor. This causes CreatePositionAtFormatBoundary() to think that end is at the beginning of the document, and as a result will leave end where it is. However, end is still at the end of the first anchor and not at the beginning of the document. This change fixes the above issue by checking the text offset to see if the position is truly at the beginning/end of the document, or if there is actually more text to traverse. Unit tests added. Bug: 961351 Change-Id: Ib6ac2b279408aaf90edf9e8f3bbd2a34bf7c2f8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604407 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#661508} ui/accessibility/ax_node_position_unittest.cc | 62 +++++++++++++++ ui/accessibility/ax_position.h | 29 ++++--- ...platform_node_textrangeprovider_win_unittest.cc | 89 ++++++++++++++++++---- 3 files changed, 152 insertions(+), 28 deletions(-) commit 3c16d35b4dafedd80e63ace77ae3ba7b4b2cd969 Author: Gabriel Marin <gmx@chromium.org> Date: Mon May 20 22:41:46 2019 +0000 PerfEventsCollector: Enable collection on Gemini Lake BUG=b:128528236 Change-Id: Ic6874bd0cdfd56e286b4d5e0d993a27a3fa358a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616968 Reviewed-by: Gabriel Marin <gmx@chromium.org> Reviewed-by: George Burgess <gbiv@chromium.org> Commit-Queue: Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#661507} chrome/browser/metrics/perf/cpu_identity.cc | 1 + chrome/browser/metrics/perf/cpu_identity_unittest.cc | 10 ++++++++++ chrome/browser/metrics/perf/perf_events_collector.cc | 2 +- 3 files changed, 12 insertions(+), 1 deletion(-) commit 02f56dbf006d3c5c50104890861a10dde2d821a2 Author: Pavel Yatsuk <pavely@google.com> Date: Mon May 20 22:37:06 2019 +0000 Disable PermissionNavigationTest which flakes on official bots BUG=957902 TBR=dominickn@chromium.org Change-Id: I1cde4bd8073b078f8c11232542e5cd5453722dac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620690 Reviewed-by: Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#661506} .../chrome/browser/permissions/PermissionNavigationTest.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) commit 19ce23bd6302e6271b230a58fbb77dc5b539abdd Author: James Cook <jamescook@chromium.org> Date: Mon May 20 22:31:33 2019 +0000 Eliminate GN arg 'remove_webcore_debug_symbols' It was replaced by blink_symbol_level ~2 years ago. For the last month, gn gen has printed an error if this argument is set. GN printed a warning for 1 month before that. Two months notice seems sufficient. Bug: 943869 Change-Id: I27c16ac6ebd03f5f1b93e153dd2258a89e50c5e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619244 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#661505} third_party/blink/renderer/config.gni | 8 -------- 1 file changed, 8 deletions(-) commit 4cbfd14f305b4914d073421fd3125cc7ebbcf7f4 Author: Bill Orr <billorr@chromium.org> Date: Mon May 20 22:30:01 2019 +0000 Remove XRWebGLLayer.requestViewportScaling() Viewport scaling has been removed from the WebXR spec, so removing before the API is released. Bug: 961436 Change-Id: I9f1bbb7dde8971d1c659592b7d3b23e14a17b928 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620908 Reviewed-by: Brandon Jones <bajones@chromium.org> Reviewed-by: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#661504} .../blink/renderer/modules/xr/xr_webgl_layer.cc | 45 +--- .../blink/renderer/modules/xr/xr_webgl_layer.h | 3 - .../blink/renderer/modules/xr/xr_webgl_layer.idl | 1 - .../global-interface-listing-expected.txt | 1 - .../web_tests/xr/xrWebGLLayer_viewport_scale.html | 108 ---------- .../webxr_test_pages/webxr-samples/index.html | 4 - .../webxr-samples/viewport-scaling.html | 226 --------------------- 7 files changed, 7 insertions(+), 381 deletions(-) commit 490a0b42e691c5ff67e815a4e98fc31b2afe7fe0 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon May 20 22:29:47 2019 +0000 Roll src/third_party/chromite b396287d6e6c..f0a719c3731c (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/b396287d6e6c..f0a719c3731c git log b396287d6e6c..f0a719c3731c --date=short --no-merges --format='%ad %ae %s' 2019-05-20 jclinton@chromium.org Reland "Require LCQ label for all CL's processed by legacy PreCQ and CQ" Created with: gclient setdep -r src/third_party/chromite@f0a719c3731c The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I3278abbdaf41a36c5767a2334117f0894e72e56f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620830 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#661503} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 43fd4f1729df57b78f930e287cc21e58caa93d6d Author: Ian Wells <iwells@chromium.org> Date: Mon May 20 22:26:29 2019 +0000 [Feed] Import feed@6eeec6bf30698daf8960301a3cb7a418b935449e ******************************Resource Sizes Diff****************************** Specifics: +77,856 bytes main lib size +538,424 bytes main dex size +96,044 bytes secondary dex size +1,031,441 bytes normalized apk size InstallSize: +398,039 bytes APK size +1,140,367 bytes Estimated installed size (Android Go) +2,961,289 bytes Estimated installed size InstallBreakdown (+2,957,833 bytes): +4,021 bytes Native resources (no l10n) size +2,775 bytes Non-compiled Android resources size +77,856 bytes Native code size +788 bytes Package metadata size +2,844,257 bytes Java code size +28,136 bytes Compiled Android resources size Dex: +3,327 entries fields +4,964 entries methods +1,451 entries types +3,037 entries strings Bug: 948739 Change-Id: I59bc6fd003ad6a7d0b08ae74340f0a02e5892230 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620746 Reviewed-by: Sky Malice <skym@chromium.org> Commit-Queue: Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#661502} DEPS | 2 +- .../src/org/chromium/chrome/browser/feed/FeedDebuggingBridge.java | 2 +- .../java/src/org/chromium/chrome/browser/feed/FeedNewTabPage.java | 2 +- .../org/chromium/chrome/browser/feed/FeedProcessScopeFactory.java | 2 +- third_party/feed/README.chromium | 2 +- third_party/feed/java_sources.gni | 8 ++++---- 6 files changed, 9 insertions(+), 9 deletions(-) commit cb6a01488dcc201b34620e10a1ba6d534b01ee6d Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Mon May 20 22:25:25 2019 +0000 Harden first line background image observer registration Background image observer registration/unregistration is required to be strictly paired, and any object being destroyed must unregister it as image observer if it has registered itself as one. First line style complicates background image observer registration, because LayoutObject::GetCachedPseudoStyle() can return a different value after the DOM tree changed, so it's unreliable to depend on the old style's first line pseudo style to unregister a LayoutObject as an image observer. Add a bit to indicate whether the LayoutObject has registered itself as a first line image observer, and a static map to store the first line style based on which the object registered. In UpdateFirstLineImageObservers(), unregister based on these information instead of old style's cached first line pseudo style. Also let FirstLineStyleForCachedUncachedType() return nullptr when :before/:after is getting the first line style before inserted into the tree to avoid churn of first line style. Bug: 964795 Change-Id: I36b7517ec03fcdb02d5d9627dd732f8bb56af615 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620405 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Reviewed-by: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#661501} .../blink/renderer/core/layout/layout_object.cc | 57 ++++++++++++++-------- .../blink/renderer/core/layout/layout_object.h | 8 ++- 2 files changed, 44 insertions(+), 21 deletions(-) commit 5eb4690cebb62b749bcc355e62345c5221cf3bf3 Author: Darren Shen <shend@chromium.org> Date: Mon May 20 22:24:33 2019 +0000 ime: Add metrics for mode change key. We want to know: 1) Overall usage 2) What was result of pressing the key. We also expanded ImeSwitch enum to include the key. Bug: 953901 Change-Id: I0a59bfd836cdd9c56d68449f3417dfda7132ef18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619445 Reviewed-by: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#661500} ash/ime/ime_controller.cc | 29 +++++++++++++++++++++++++++-- ash/ime/ime_switch_type.h | 3 ++- tools/metrics/histograms/enums.xml | 13 +++++++++++++ tools/metrics/histograms/histograms.xml | 6 ++++++ 4 files changed, 48 insertions(+), 3 deletions(-) commit 15450175775febd225040000cc86c5c8e7447787 Author: Michael Giuffrida <michaelpg@chromium.org> Date: Mon May 20 22:17:58 2019 +0000 Demo mode: rename board-specific extension ID constants Use the board name instead of "alt <N>" for launched boards. Bug: 957772 Change-Id: I90b0e8772eec7041cda2e1913d4261b4613a2154 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621065 Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#661499} ash/metrics/demo_session_metrics_recorder.cc | 8 ++++---- .../chromeos/extensions/install_limiter_unittest.cc | 4 ++-- chrome/browser/chromeos/login/demo_mode/demo_session.cc | 8 ++++---- extensions/common/constants.cc | 16 ++++++++-------- extensions/common/constants.h | 16 ++++++++-------- 5 files changed, 26 insertions(+), 26 deletions(-) commit 38b296aa132e9540abffb2cc95924c2fe26afa31 Author: Antonio Gomes <tonikitoo@igalia.com> Date: Mon May 20 22:16:17 2019 +0000 Migrate ChromeClient::NotifySwapTime callees to CrossThreadBindOnce ... instead of CrossThreadBind(). ChromeClientImpl::NotifySwapTime actually calls out to blink::WebWidgetClient::NotifySwapTime(base::OnceCallback ...); BUG=964947 R=haraken@chromium.org, hiroshige@chromium.org Change-Id: Iba9da7b9c7912973c197791279d53f301e2c6f8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621105 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#661498} .../blink/renderer/core/paint/first_meaningful_paint_detector.cc | 4 ++-- third_party/blink/renderer/core/paint/image_element_timing.cc | 2 +- third_party/blink/renderer/core/paint/paint_timing.cc | 6 +++--- third_party/blink/renderer/core/paint/paint_timing.h | 4 ++-- .../blink/renderer/core/paint/text_paint_timing_detector.cc | 7 ++++--- third_party/blink/renderer/core/paint/text_paint_timing_detector.h | 4 ++-- third_party/blink/renderer/core/timing/window_performance.cc | 6 +++--- 7 files changed, 17 insertions(+), 16 deletions(-) commit 4d35c5694d348f5ff0b3fedd0e7c4cfeb8987445 Author: Antonio Gomes <tonikitoo@igalia.com> Date: Mon May 20 22:14:33 2019 +0000 Migrate blink::MediaStreamVideoTrack to WTF::Bind This CL is the 5th and last CL to convert modules/mediastream/ away from base::Bind{Once,Repeating} to their respective Blink/WTF counterparts. R=haraken@chromium.org, guidou@chromium.org CC=blink-reviews-vendor@chromium.org BUG=923394 Change-Id: I73e2ed0fdba9bf5dc7d13feb0f4aa1cf77386a53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597322 Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#661497} .../mediastream/media_stream_video_track.cc | 142 +++++++++++---------- 1 file changed, 76 insertions(+), 66 deletions(-) commit 13e89a7c7591fe36c1811bb6f1f2a9fd446dde8a Author: Darren Shen <shend@chromium.org> Date: Mon May 20 22:14:30 2019 +0000 vk: Create KeyboardUIModel and put state logic in there. We wish to refactor the keyboard code using MVC in order to reduce the size and responsibility of KeyboardController. The plan is to have MVC for both the keyboard (configuration, enable flags) and the keyboard UI (window management / animations etc.), akin to how //ash/assistant has both |assistant_controller| and |assistant_ui_controller|. This patch creates a KeyboardUIModel, meant to contain information related to the keyboard window & UI. We'll start by putting the UI state code in there. Future patches will move more code into the model and clean things up. Bug: 964191 Change-Id: Ia2b026874ee72e48a21140cd3db4a0d86b62c7b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616826 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#661496} ash/keyboard/ui/BUILD.gn | 2 + ash/keyboard/ui/keyboard_controller.cc | 120 ++++++--------------------------- ash/keyboard/ui/keyboard_controller.h | 30 ++------- ash/keyboard/ui/keyboard_ui_model.cc | 99 +++++++++++++++++++++++++++ ash/keyboard/ui/keyboard_ui_model.h | 62 +++++++++++++++++ 5 files changed, 190 insertions(+), 123 deletions(-) commit 1bea34c21c77b213b2e8f32db67921d43c9df9e3 Author: sczs <sczs@chromium.org> Date: Mon May 20 22:10:03 2019 +0000 [ios] Improves Password InfobarModal A11y. Bug: 961343 Change-Id: I292fb04c40117e47d3e1a45bb0a102debef9ed2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616973 Reviewed-by: Peter Lee <pkl@chromium.org> Reviewed-by: Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#661495} ios/chrome/app/strings/ios_strings.grd | 9 +++++++++ .../modals/infobar_password_table_view_controller.mm | 10 ++++++++++ .../ui/table_view/cells/table_view_text_edit_item.h | 3 +++ .../ui/table_view/cells/table_view_text_edit_item.mm | 14 +++++++++++--- 4 files changed, 33 insertions(+), 3 deletions(-) commit ca297213cf4da52910dc9c3870ab3d6ec6ac74e7 Author: Bryan McQuade <bmcquade@chromium.org> Date: Mon May 20 22:08:16 2019 +0000 Remove old AMP UMA metrics. With https://chromium-review.googlesource.com/c/chromium/src/+/1512304 landed, we have now migrated to measuring AMP performance without having to match against hard-coded URLs. This change removes the old UMA logic with hard-coded URL matching. Change-Id: I8cd9d5d5491f90b2e3357ed81ba0eadb0ed77732 Bug: 939333 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618271 Reviewed-by: Annie Sullivan <sullivan@chromium.org> Reviewed-by: Charlie Harrison <csharrison@chromium.org> Commit-Queue: Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#661494} .../observers/amp_page_load_metrics_observer.cc | 173 --------------------- .../observers/amp_page_load_metrics_observer.h | 29 ---- .../amp_page_load_metrics_observer_unittest.cc | 113 -------------- tools/metrics/histograms/enums.xml | 3 + tools/metrics/histograms/histograms.xml | 9 ++ 5 files changed, 12 insertions(+), 315 deletions(-) commit 3fe30476215816a8fbeff14c659215275782cbc7 Author: Annie Sullivan <sullivan@chromium.org> Date: Mon May 20 22:07:39 2019 +0000 Correct field trial name for SkipTouchEventFiter feature Bug: 914500 Change-Id: Ic4ee7918afca095289032c04ce18504c73769eef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620886 Reviewed-by: Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#661493} testing/variations/fieldtrial_testing_config.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit b4d4c01408f1bc8accd97ee82ef66d6d60142147 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon May 20 22:06:38 2019 +0000 Roll src/third_party/swiftshader 1d2ebed9e6a4..9e2844fa2744 (1 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/1d2ebed9e6a4..9e2844fa2744 git log 1d2ebed9e6a4..9e2844fa2744 --date=short --no-merges --format='%ad %ae %s' 2019-05-20 bclayton@google.com SpirvShader: Fixes for GLSLstd450Modf / GLSLstd450ModfStruct Created with: gclient setdep -r src/third_party/swiftshader@9e2844fa2744 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/126873455 TBR=swiftshader-team+autoroll@google.com Change-Id: If3867329a74a7e3e4bae44f7ca375f793cb057fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620594 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#661492} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 9ede84e9747c0f22c09ac2a1a6761e1b9e138472 Author: Kenneth Russell <kbr@chromium.org> Date: Mon May 20 22:05:09 2019 +0000 Suppress tex-2d-rgb16f-rgb-half_float on macOS. conformance2/textures/canvas/tex-2d-rgb16f-rgb-half_float.html has become flaky, reporting an error in SharedImageStub with subsequent context loss. Bug: 965209 Change-Id: I3e7e5e2f456d0bbf1b5f87cf5cc78511131e1083 Tbr: geofflang@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620699 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#661491} .../gpu/gpu_tests/test_expectations/webgl2_conformance_expectations.txt | 1 + 1 file changed, 1 insertion(+) commit daf793faa6da12c98fc007354c51b74ddd2e5adc Author: Gabriel Marin <gmx@chromium.org> Date: Mon May 20 22:03:46 2019 +0000 PerfEventsCollector: Add Goldmont specific TLB misses events Perf doesn't support the generic dTLB-misses event on Goldmont devices. Add Goldmont specific perf commands for sampling TLB misses on Goldmont. BUG=b:131614840 TEST=Tested that the events work on a Goldmont device. Change-Id: I6ed254a1a77fc6e074a1704912d8e8cad339c1d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616967 Reviewed-by: Gabriel Marin <gmx@chromium.org> Reviewed-by: George Burgess <gbiv@chromium.org> Commit-Queue: Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#661490} .../browser/metrics/perf/perf_events_collector.cc | 24 +++++++++++- .../metrics/perf/perf_events_collector_unittest.cc | 44 ++++++++++++++++++++++ 2 files changed, 66 insertions(+), 2 deletions(-) commit a73bd5c8e2496f548f9bdbf2d3579f78dc20f46a Author: Alberto Herrera <ahrfgb@google.com> Date: Mon May 20 22:03:35 2019 +0000 [Bluetooth] Make Connecting label alignment consistent with others screenshot: http://screen/8P4nzcFgoGG.png Bug: 956654 Change-Id: Idb9463b00249b91a0e3bcb330a1514c7198e8b84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617212 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Alberto Herrera <ahrfgb@google.com> Cr-Commit-Position: refs/heads/master@{#661489} .../settings/bluetooth_page/bluetooth_device_list_item.html | 1 - .../resources/settings/bluetooth_page/bluetooth_device_list_item.js | 5 ++++- 2 files changed, 4 insertions(+), 2 deletions(-) commit 17507d96758c5709d3f4416aab4a540df1f3483e Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Mon May 20 22:00:42 2019 +0000 Roll src-internal 6f41eaf82149..b28d01ad3a2a (2 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6f41eaf82149..b28d01ad3a2a Created with: gclient setdep -r src-internal@b28d01ad3a2a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=mbarowsky@google.com,sidereal@google.com Change-Id: I79795f97dc711b1c5ff9aa7d509fea689a456b8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620593 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#661488} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 754b598e2658979624869ce0f163c5de85a62113 Author: Fritz Koenig <frkoenig@chromium.org> Date: Mon May 20 21:59:52 2019 +0000 Disable MESA_framebuffer_flip_y extension The extension is not WebGL 2.0 compliant yet. BUG=964010 Change-Id: I7c89e79d534ad16baba64215e9827558084d2423 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620085 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Fritz Koenig <frkoenig@chromium.org> Cr-Commit-Position: refs/heads/master@{#661487} gpu/config/gpu_driver_bug_list.json | 8 ++++++++ 1 file changed, 8 insertions(+) commit 48a7020e08f6bd4d2b1ec7700beb7cc5dd77a5d3 Author: Marcin Wiącek <marcin@mwiacek.com> Date: Mon May 20 21:59:32 2019 +0000 Fix flickering Tab title on entering Stack (StackAnimation.java) Fix flickering title during switching from Tab to Tab Switcher. Earliest (found) code version with this bug: https://codereview.chromium.org/1141283003 (21 May 2015) BUG=957343 Change-Id: I3651436fda7ec608037cf25cf81877e9404e325a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607201 Reviewed-by: David Trainor <dtrainor@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#661486} .../chrome/browser/compositor/layouts/phone/stack/StackAnimation.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 82187b8df9fbb7f826074f30b3b26240887c3111 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon May 20 21:57:24 2019 +0000 Roll src/third_party/depot_tools ee7beb2bb283..ad39f9d8f8d1 (1 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ee7beb2bb283..ad39f9d8f8d1 git log ee7beb2bb283..ad39f9d8f8d1 --date=short --no-merges --format='%ad %ae %s' 2019-05-20 tandrii@chromium.org [lucicfg] Release v1.7.5 Created with: gclient setdep -r src/third_party/depot_tools@ad39f9d8f8d1 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ib5f15f1fc4217573560f7714b5518a534130294f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620828 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#661485} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 8556b759c47c4e0cfa9cbe340fa6587797291486 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon May 20 21:53:56 2019 +0000 Roll src/third_party/webrtc 94079f84523b..1ff16c87aa63 (2 commits) https://webrtc.googlesource.com/src.git/+log/94079f84523b..1ff16c87aa63 git log 94079f84523b..1ff16c87aa63 --date=short --no-merges --format='%ad %ae %s' 2019-05-20 guidou@webrtc.org Add RtpSenderInterface.SetStreams 2019-05-20 kwiberg@webrtc.org AudioEncoderOpus: Don't mix up sample rate and RTP timestamp rate Created with: gclient setdep -r src/third_party/webrtc@1ff16c87aa63 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I791dcd9ce8345f471155eb0da8bfbe55b0d718e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620591 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#661484} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 7504fddddd3db6e8932ba9cfac541cd35367935d Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon May 20 21:53:47 2019 +0000 Roll src/third_party/skia a848c3b829ad..aeb71ce166c7 (4 commits) https://skia.googlesource.com/skia.git/+log/a848c3b829ad..aeb71ce166c7 git log a848c3b829ad..aeb71ce166c7 --date=short --no-merges --format='%ad %ae %s' 2019-05-20 ethannicholas@google.com switched over to using fallthrough in SkSL interpreter vector operations 2019-05-20 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (nontrivial). 2019-05-20 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-20 bsalomon@google.com return kSkip in async read GMs when context is abandoned Created with: gclient setdep -r src/third_party/skia@aeb71ce166c7 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@google.com Change-Id: Ia0fb4a3841137b3a9956004cefaa426966e2b852 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620592 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#661483} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Updated tag 'tree_truth' (was 7ca0c1a47eda)