Back to build
Raw log | Switch to full mode | Login

!@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: d301cb6d75cb7a88ee183334c204caea2f409ea9 WebUI: Import Polymer3 in third_party/polymer. dpapad, Sat May 25 03:19:21 2019 +0000 1aa523a071bc3455dc3dd7e6bb53414e66f1ff65 Updating trunk VERSION from 3805.0 to 3806.0 chrome-release-bot, Sat May 25 03:19:16 2019 +0000 6700540dcbab00b4120fa39b41ea51d4c5fc3a3b Reland "Removes ui/platform_window/mojo as it is not used by anyone." Shu Chen, Sat May 25 03:13:12 2019 +0000 69adb3bd3b38f7c57e4fd600fcb3d818d6ea5f40 Converted waitForSyncInitialized and syncCacheGUID to compile under EG2 Maksym Onufriienko, Sat May 25 03:04:27 2019 +0000 be782f8d5ca446dd00ff8dfce22b694077f70702 Roll src/third_party/pdfium 2d2b08ea91dd..7eadbd640fc4 (1 commits) chromium-autoroll, Sat May 25 03:01:27 2019 +0000 a628a76319ac195628fe62ff5b867a9129273eba Roll src/third_party/webrtc 8b096a03b485..3a1b92772f66 (1 commits) chromium-autoroll, Sat May 25 02:47:07 2019 +0000 6d788f4239926d08e2f063b6abeef03813308cf9 Roll src/third_party/chromite a9d64606650c..6fb0eb821ce6 (2 commits) chromium-autoroll, Sat May 25 02:41:47 2019 +0000 1ccb20ab67d70b36264601507cc91d2a99f54034 Roll src/third_party/catapult cd7d9644c89f..9d1091665fb8 (2 commits) chromium-autoroll, Sat May 25 02:39:27 2019 +0000 b200c80047852cdeaad89fdd99fcdbb80212c64d Refactor bits of libgtkui Tom Anderson, Sat May 25 02:30:46 2019 +0000 363914f2ef5c5bb582e6969b4ac5a4b417b31edb Roll src/third_party/skia 46f2b58d86fb..f33c95cd6f55 (2 commits) chromium-autoroll, Sat May 25 02:27:30 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit d301cb6d75cb7a88ee183334c204caea2f409ea9 Author: dpapad <dpapad@chromium.org> Date: Sat May 25 03:19:21 2019 +0000 WebUI: Import Polymer3 in third_party/polymer. Specifically: - Add new third_party/polymer/v3_0/ folder. - Add package.json, package-lock.json and rsync_exclude.txt. - Add reproduce.sh script to update the v3 version. - Add chromium.patch with some initial local modifications. - Update existing scripts polymer_grdp_to_txt.py and txt_to_polymer_grdp.py to work for v3 as well. - Update shared_resources_data_source.cc to properly map chrome://resources/polymer/v3_0/ requests to files. Note: Given that Polymer 3 usage in WebUI is still at an early exploration phase, its resources are only included in the build for optimize_webui=false, to not affect release builds for now, while allowing making progress on other fronts like - type checking - bundling - HTML-to-JS automation - testing JS module based code wit js2gtest infra Bug: 965770 Test: Visit chrome://resources/polymer/v3_0/paper-button/paper-button.js Change-Id: I9a6f2c0d9c59d9569bd0f0f4d09ce94a1270cebd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610718 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#663383} .../browser/webui/shared_resources_data_source.cc | 2 + third_party/polymer/README.chromium | 5 + third_party/polymer/v3_0/chromium.patch | 39 + .../v3_0/components-chromium/font-roboto/roboto.js | 22 + .../iron-a11y-announcer/iron-a11y-announcer.js | 111 + .../iron-a11y-keys-behavior.js | 484 ++++ .../iron-a11y-keys/iron-a11y-keys.js | 170 ++ .../iron-behaviors/iron-button-state.js | 212 ++ .../iron-behaviors/iron-control-state.js | 104 + .../iron-collapse/iron-collapse.js | 273 ++ .../iron-dropdown/iron-dropdown-scroll-manager.js | 16 + .../iron-dropdown/iron-dropdown.js | 279 ++ .../iron-fit-behavior/iron-fit-behavior.js | 688 +++++ .../iron-flex-layout/iron-flex-layout-classes.js | 443 +++ .../iron-flex-layout/iron-flex-layout.js | 435 +++ .../components-chromium/iron-icon/iron-icon.js | 200 ++ .../iron-iconset-svg/iron-iconset-svg.js | 257 ++ .../components-chromium/iron-input/iron-input.js | 368 +++ .../components-chromium/iron-list/iron-list.js | 1960 ++++++++++++++ .../iron-location/iron-location.js | 395 +++ .../iron-location/iron-query-params.js | 94 + .../iron-media-query/iron-media-query.js | 110 + .../components-chromium/iron-meta/iron-meta.js | 210 ++ .../iron-focusables-helper.js | 215 ++ .../iron-overlay-behavior/iron-overlay-backdrop.js | 158 ++ .../iron-overlay-behavior/iron-overlay-behavior.js | 825 ++++++ .../iron-overlay-behavior/iron-overlay-manager.js | 389 +++ .../iron-overlay-behavior/iron-scroll-manager.js | 378 +++ .../components-chromium/iron-pages/iron-pages.js | 73 + .../iron-range-behavior/iron-range-behavior.js | 95 + .../iron-resizable-behavior.js | 273 ++ .../iron-scroll-target-behavior.js | 278 ++ .../iron-scroll-threshold/iron-scroll-threshold.js | 212 ++ .../iron-selector/iron-multi-selectable.js | 166 ++ .../iron-selector/iron-selectable.js | 399 +++ .../iron-selector/iron-selection.js | 107 + .../iron-selector/iron-selector.js | 87 + .../iron-test-helpers/iron-test-helpers.js | 12 + .../iron-test-helpers/mock-interactions.js | 480 ++++ .../iron-test-helpers/test-helpers.js | 102 + .../iron-validatable-behavior.js | 131 + .../neon-animation/animations/fade-in-animation.js | 42 + .../animations/fade-out-animation.js | 45 + .../neon-animation/neon-animatable-behavior.js | 144 + .../neon-animation/neon-animatable.js | 46 + .../neon-animation/neon-animated-pages.js | 194 ++ .../neon-animation/neon-animation-behavior.js | 88 + .../neon-animation-runner-behavior.js | 157 ++ .../neon-shared-element-animatable-behavior.js | 35 + .../neon-shared-element-animation-behavior.js | 72 + .../paper-behaviors/paper-button-behavior.js | 90 + .../paper-behaviors/paper-inky-focus-behavior.js | 51 + .../paper-behaviors/paper-ripple-behavior.js | 125 + .../paper-button/paper-button.js | 211 ++ .../paper-input/paper-input-addon-behavior.js | 39 + .../paper-input/paper-input-container.js | 697 +++++ .../paper-input/paper-input-error.js | 107 + .../paper-progress/paper-progress.js | 342 +++ .../paper-ripple/paper-ripple.js | 736 +++++ .../paper-spinner/paper-spinner-behavior.js | 73 + .../paper-spinner/paper-spinner-lite.js | 75 + .../paper-spinner/paper-spinner-styles.js | 346 +++ .../paper-styles/classes/global.js | 97 + .../paper-styles/classes/shadow.js | 65 + .../paper-styles/classes/typography.js | 169 ++ .../v3_0/components-chromium/paper-styles/color.js | 340 +++ .../paper-styles/default-theme.js | 76 + .../components-chromium/paper-styles/demo-pages.js | 83 + .../element-styles/paper-item-styles.js | 112 + .../element-styles/paper-material-styles.js | 124 + .../components-chromium/paper-styles/shadow.js | 81 + .../components-chromium/paper-styles/typography.js | 182 ++ .../paper-tooltip/paper-tooltip.js | 588 ++++ .../v3_0/components-chromium/polymer/LICENSE.txt | 27 + .../polymer/externs/closure-types.js | 1588 +++++++++++ .../polymer/externs/polymer-dom-api-externs.js | 179 ++ .../polymer/externs/polymer-externs.js | 216 ++ .../polymer/externs/polymer-iconset-externs.js | 36 + .../externs/polymer-internal-shared-types.js | 214 ++ .../polymer/externs/polymer-internal-types.html | 11 + .../polymer/externs/webcomponents-externs.js | 68 + .../polymer/lib/elements/array-selector.js | 434 +++ .../polymer/lib/elements/custom-style.js | 109 + .../polymer/lib/elements/dom-bind.js | 143 + .../polymer/lib/elements/dom-if.js | 289 ++ .../polymer/lib/elements/dom-module.js | 163 ++ .../polymer/lib/elements/dom-repeat.js | 733 +++++ .../polymer/lib/legacy/class.js | 534 ++++ .../polymer/lib/legacy/legacy-data-mixin.js | 181 ++ .../polymer/lib/legacy/legacy-element-mixin.js | 1059 ++++++++ .../polymer/lib/legacy/mutable-data-behavior.js | 150 + .../polymer/lib/legacy/polymer-fn.js | 48 + .../polymer/lib/legacy/polymer.dom.js | 482 ++++ .../polymer/lib/legacy/templatizer-behavior.js | 142 + .../polymer/lib/mixins/dir-mixin.js | 195 ++ .../polymer/lib/mixins/disable-upgrade-mixin.js | 122 + .../polymer/lib/mixins/element-mixin.js | 813 ++++++ .../polymer/lib/mixins/gesture-event-listeners.js | 75 + .../polymer/lib/mixins/mutable-data.js | 194 ++ .../polymer/lib/mixins/properties-changed.js | 555 ++++ .../polymer/lib/mixins/properties-mixin.js | 233 ++ .../polymer/lib/mixins/property-accessors.js | 323 +++ .../polymer/lib/mixins/property-effects.js | 2856 ++++++++++++++++++++ .../polymer/lib/mixins/strict-binding-parser.js | 414 +++ .../polymer/lib/mixins/template-stamp.js | 500 ++++ .../polymer/lib/utils/array-splice.js | 299 ++ .../components-chromium/polymer/lib/utils/async.js | 207 ++ .../components-chromium/polymer/lib/utils/boot.js | 25 + .../polymer/lib/utils/case-map.js | 47 + .../polymer/lib/utils/debounce.js | 165 ++ .../polymer/lib/utils/flattened-nodes-observer.js | 314 +++ .../components-chromium/polymer/lib/utils/flush.js | 33 + .../polymer/lib/utils/gestures.js | 1079 ++++++++ .../polymer/lib/utils/html-tag.js | 128 + .../components-chromium/polymer/lib/utils/mixin.js | 67 + .../components-chromium/polymer/lib/utils/path.js | 255 ++ .../polymer/lib/utils/render-status.js | 118 + .../polymer/lib/utils/resolve-url.js | 87 + .../polymer/lib/utils/settings.js | 160 ++ .../polymer/lib/utils/style-gather.js | 274 ++ .../polymer/lib/utils/telemetry.js | 50 + .../polymer/lib/utils/templatize.js | 610 +++++ .../polymer/lib/utils/unresolved.js | 21 + .../components-chromium/polymer/lib/utils/wrap.js | 23 + .../components-chromium/polymer/polymer-element.js | 31 + .../components-chromium/polymer/polymer-legacy.js | 27 + .../components-chromium/shadycss/apply-shim.html | 10 + .../components-chromium/shadycss/apply-shim.min.js | 32 + .../shadycss/custom-style-interface.html | 10 + .../shadycss/custom-style-interface.min.js | 15 + .../shadycss/entrypoints/apply-shim.js | 223 ++ .../shadycss/entrypoints/custom-style-interface.js | 82 + .../shadycss/entrypoints/scoping-shim.js | 108 + .../shadycss/externs/shadycss-externs.js | 66 + .../shadycss/scoping-shim.min.js | 59 + .../shadycss/src/apply-shim-utils.js | 149 + .../components-chromium/shadycss/src/apply-shim.js | 525 ++++ .../shadycss/src/common-regex.js | 19 + .../shadycss/src/common-utils.js | 59 + .../components-chromium/shadycss/src/css-parse.js | 264 ++ .../shadycss/src/custom-style-interface.js | 164 ++ .../shadycss/src/document-wait.js | 45 + .../shadycss/src/document-watcher.js | 198 ++ .../shadycss/src/scoping-shim.js | 607 +++++ .../shadycss/src/style-cache.js | 52 + .../components-chromium/shadycss/src/style-info.js | 75 + .../shadycss/src/style-placeholder.js | 55 + .../shadycss/src/style-properties.js | 608 +++++ .../shadycss/src/style-settings.js | 56 + .../shadycss/src/style-transformer.js | 487 ++++ .../components-chromium/shadycss/src/style-util.js | 414 +++ .../shadycss/src/template-map.js | 17 + .../shadycss/src/unscoped-style-handler.js | 40 + third_party/polymer/v3_0/package-lock.json | 362 +++ third_party/polymer/v3_0/package.json | 43 + third_party/polymer/v3_0/reproduce.sh | 77 + third_party/polymer/v3_0/rsync_exclude.txt | 77 + tools/polymer/polymer_grdp_to_txt.py | 22 +- tools/polymer/txt_to_polymer_grdp.py | 76 +- ui/webui/resources/polymer_resources.grdp | 22 +- ui/webui/resources/polymer_resources_v3.grdp | 621 +++++ ui/webui/resources/webui_resources.grd | 3 + 162 files changed, 39694 insertions(+), 43 deletions(-) commit 1aa523a071bc3455dc3dd7e6bb53414e66f1ff65 Author: chrome-release-bot <chrome-release-bot@chromium.org> Date: Sat May 25 03:19:16 2019 +0000 Updating trunk VERSION from 3805.0 to 3806.0 # This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I2a2d3eba79e45256687db5d9659b1b5b6823ce33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629908 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#663382} chrome/VERSION | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 6700540dcbab00b4120fa39b41ea51d4c5fc3a3b Author: Shu Chen <shuchen@chromium.org> Date: Sat May 25 03:13:12 2019 +0000 Reland "Removes ui/platform_window/mojo as it is not used by anyone." This is a reland of 6eb61402c1b1b4301762c6aaaea28b2921cbf4c2 Original change's description: > Removes ui/platform_window/mojo as it is not used by anyone. > > This is to remove the ref to some types under ui/base/ime/mojo, which will be removed later. > > Bug: 965908 > Change-Id: I7979524066104c829b4f4e287a0ab87c9365f124 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626055 > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Shu Chen <shuchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#662924} Bug: 965908 Change-Id: I6bb1c6d081ce235c959cc30e53d20b57dd0e1459 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626841 Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#663381} ash/BUILD.gn | 1 - ash/host/ash_window_tree_host_platform.cc | 1 - content/common/render_widget_host_ns_view.mojom | 1 - services/ws/public/mojom/BUILD.gn | 1 - ui/aura/BUILD.gn | 1 - ui/platform_window/mojo/BUILD.gn | 39 --------------- ui/platform_window/mojo/DEPS | 5 -- ui/platform_window/mojo/OWNERS | 5 -- ui/platform_window/mojo/ime_type_converters.cc | 63 ------------------------- ui/platform_window/mojo/ime_type_converters.h | 23 --------- ui/platform_window/mojo/mojo_ime_export.h | 32 ------------- ui/platform_window/mojo/text_input_state.mojom | 36 -------------- 12 files changed, 208 deletions(-) commit 69adb3bd3b38f7c57e4fd600fcb3d818d6ea5f40 Author: Maksym Onufriienko <monufriienko@chromium.org> Date: Sat May 25 03:04:27 2019 +0000 Converted waitForSyncInitialized and syncCacheGUID to compile under EG2 Bug: 922813 Change-Id: If3b4b92ae39c3051dcc5804f7221d0dfaa5bf218 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625748 Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#663380} ios/chrome/test/earl_grey/chrome_earl_grey.h | 22 +++++++------ ios/chrome/test/earl_grey/chrome_earl_grey.mm | 31 ++++++++----------- .../earl_grey/chrome_earl_grey_app_interface.h | 26 +++++++++++----- .../earl_grey/chrome_earl_grey_app_interface.mm | 36 +++++++++++++++++----- 4 files changed, 73 insertions(+), 42 deletions(-) commit be782f8d5ca446dd00ff8dfce22b694077f70702 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sat May 25 03:01:27 2019 +0000 Roll src/third_party/pdfium 2d2b08ea91dd..7eadbd640fc4 (1 commits) https://pdfium.googlesource.com/pdfium.git/+log/2d2b08ea91dd..7eadbd640fc4 git log 2d2b08ea91dd..7eadbd640fc4 --date=short --no-merges --format='%ad %ae %s' 2019-05-25 thestig@chromium.org Stop using CPDF_Array in CFX_GraphState. Created with: gclient setdep -r src/third_party/pdfium@7eadbd640fc4 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Change-Id: I13a2502f54d050483c2d1ef5a6e80f362cf997ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629967 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#663379} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit a628a76319ac195628fe62ff5b867a9129273eba Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sat May 25 02:47:07 2019 +0000 Roll src/third_party/webrtc 8b096a03b485..3a1b92772f66 (1 commits) https://webrtc.googlesource.com/src.git/+log/8b096a03b485..3a1b92772f66 git log 8b096a03b485..3a1b92772f66 --date=short --no-merges --format='%ad %ae %s' 2019-05-24 mellem@webrtc.org Remove rtp_ and rtcp_packet_transport() from the RtpTransport interface. Created with: gclient setdep -r src/third_party/webrtc@3a1b92772f66 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I93738f749dcf129d1bbae926961dcf4fa97b1aaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629753 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#663378} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 6d788f4239926d08e2f063b6abeef03813308cf9 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sat May 25 02:41:47 2019 +0000 Roll src/third_party/chromite a9d64606650c..6fb0eb821ce6 (2 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/a9d64606650c..6fb0eb821ce6 git log a9d64606650c..6fb0eb821ce6 --date=short --no-merges --format='%ad %ae %s' 2019-05-25 saklein@chromium.org SetBinhost: Use new file for new post-submit builders 2019-05-25 saklein@chromium.org cros_set_lsb_release: Fix keyset key set. Created with: gclient setdep -r src/third_party/chromite@6fb0eb821ce6 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I976b322a159de9074746a670468f9fdee4226b83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629927 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#663377} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 1ccb20ab67d70b36264601507cc91d2a99f54034 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sat May 25 02:39:27 2019 +0000 Roll src/third_party/catapult cd7d9644c89f..9d1091665fb8 (2 commits) https://chromium.googlesource.com/catapult.git/+log/cd7d9644c89f..9d1091665fb8 git log cd7d9644c89f..9d1091665fb8 --date=short --no-merges --format='%ad %ae %s' 2019-05-24 benjhayden@chromium.org Speed up loading XY data in spa 2019-05-24 hypan@google.com Add a new tag Pixel2_Webview to expectations Created with: gclient setdep -r src/third_party/catapult@9d1091665fb8 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:957556,chromium:867592 TBR=crouleau@chromium.org Change-Id: I5a351187ee0832bb8075dc340a7607e5419e5a2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629752 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#663376} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit b200c80047852cdeaad89fdd99fcdbb80212c64d Author: Tom Anderson <thomasanderson@chromium.org> Date: Sat May 25 02:30:46 2019 +0000 Refactor bits of libgtkui * Switch to using CHROMEG_CALLBACK in GtkUi. * Remove code that's conditional on GTK version < 3.10. The earlist supported version is now 3.10.8. * Ensure correct ordering of NativeThemeGtk::OnThemeChanged and GtkUi::OnThemeChanged. The ordering was correct before, but was dependent on glib dispatching events in the right order. Changed GtkUi::OnThemeChanged() to call NativeThemeGtk::OnThemeChanged(). BUG=None R=pkasting Change-Id: I19a4fbab8e4ad44445945e31fcd740faea91f5de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628993 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#663375} chrome/browser/ui/libgtkui/gtk_ui.cc | 50 +++++++--------------- chrome/browser/ui/libgtkui/gtk_ui.h | 10 +++-- chrome/browser/ui/libgtkui/native_theme_gtk.cc | 5 +-- chrome/browser/ui/libgtkui/native_theme_gtk.h | 8 +--- .../browser/ui/libgtkui/settings_provider_gtk.cc | 8 +--- 5 files changed, 27 insertions(+), 54 deletions(-) commit 363914f2ef5c5bb582e6969b4ac5a4b417b31edb Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sat May 25 02:27:30 2019 +0000 Roll src/third_party/skia 46f2b58d86fb..f33c95cd6f55 (2 commits) https://skia.googlesource.com/skia.git/+log/46f2b58d86fb..f33c95cd6f55 git log 46f2b58d86fb..f33c95cd6f55 --date=short --no-merges --format='%ad %ae %s' 2019-05-25 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@f33c95cd6f55 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@google.com Change-Id: I70167dc8e48a6c33882f3766eec42a62d82065b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629754 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#663374} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Updated tag 'tree_truth' (was 9e29ee4efa5a)