Back to build
Raw log | Switch to full mode | Login

!@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: a628a76319ac195628fe62ff5b867a9129273eba Roll src/third_party/webrtc 8b096a03b485..3a1b92772f66 (1 commits) chromium-autoroll, Sat May 25 02:47:07 2019 +0000 6d788f4239926d08e2f063b6abeef03813308cf9 Roll src/third_party/chromite a9d64606650c..6fb0eb821ce6 (2 commits) chromium-autoroll, Sat May 25 02:41:47 2019 +0000 1ccb20ab67d70b36264601507cc91d2a99f54034 Roll src/third_party/catapult cd7d9644c89f..9d1091665fb8 (2 commits) chromium-autoroll, Sat May 25 02:39:27 2019 +0000 b200c80047852cdeaad89fdd99fcdbb80212c64d Refactor bits of libgtkui Tom Anderson, Sat May 25 02:30:46 2019 +0000 363914f2ef5c5bb582e6969b4ac5a4b417b31edb Roll src/third_party/skia 46f2b58d86fb..f33c95cd6f55 (2 commits) chromium-autoroll, Sat May 25 02:27:30 2019 +0000 9e29ee4efa5a7962c30eb34fca568e1f09fcbbef Roll src-internal 69803aa39354..1edf6a6aaa9a (2 commits) chromium-internal-autoroll, Sat May 25 02:13:35 2019 +0000 3acf4b2539c301276641d78a865bde7ac5385b6e Implement PushProvider in Blink and update PushManager and PushSubscription Mario Sanchez Prada, Sat May 25 02:01:05 2019 +0000 621bb15ad1dbd50f6088becff0f57c51d0999825 Switch webview bots to google devices. Andrew Luo, Sat May 25 01:59:35 2019 +0000 f094ef99e0fb3989ce443ccc5013314a5ec78246 Convert TreeModel to expose GetChildren(). Peter Kasting, Sat May 25 01:55:57 2019 +0000 b1e829e2285edf71f116264d9f9ec11168edf8db Import wpt@512a587ab7eef3cfe1d3ebee1a672ce108bd7975 Chromium WPT Sync, Sat May 25 01:54:56 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit a628a76319ac195628fe62ff5b867a9129273eba Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sat May 25 02:47:07 2019 +0000 Roll src/third_party/webrtc 8b096a03b485..3a1b92772f66 (1 commits) https://webrtc.googlesource.com/src.git/+log/8b096a03b485..3a1b92772f66 git log 8b096a03b485..3a1b92772f66 --date=short --no-merges --format='%ad %ae %s' 2019-05-24 mellem@webrtc.org Remove rtp_ and rtcp_packet_transport() from the RtpTransport interface. Created with: gclient setdep -r src/third_party/webrtc@3a1b92772f66 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I93738f749dcf129d1bbae926961dcf4fa97b1aaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629753 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#663378} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 6d788f4239926d08e2f063b6abeef03813308cf9 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sat May 25 02:41:47 2019 +0000 Roll src/third_party/chromite a9d64606650c..6fb0eb821ce6 (2 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/a9d64606650c..6fb0eb821ce6 git log a9d64606650c..6fb0eb821ce6 --date=short --no-merges --format='%ad %ae %s' 2019-05-25 saklein@chromium.org SetBinhost: Use new file for new post-submit builders 2019-05-25 saklein@chromium.org cros_set_lsb_release: Fix keyset key set. Created with: gclient setdep -r src/third_party/chromite@6fb0eb821ce6 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I976b322a159de9074746a670468f9fdee4226b83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629927 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#663377} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 1ccb20ab67d70b36264601507cc91d2a99f54034 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sat May 25 02:39:27 2019 +0000 Roll src/third_party/catapult cd7d9644c89f..9d1091665fb8 (2 commits) https://chromium.googlesource.com/catapult.git/+log/cd7d9644c89f..9d1091665fb8 git log cd7d9644c89f..9d1091665fb8 --date=short --no-merges --format='%ad %ae %s' 2019-05-24 benjhayden@chromium.org Speed up loading XY data in spa 2019-05-24 hypan@google.com Add a new tag Pixel2_Webview to expectations Created with: gclient setdep -r src/third_party/catapult@9d1091665fb8 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:957556,chromium:867592 TBR=crouleau@chromium.org Change-Id: I5a351187ee0832bb8075dc340a7607e5419e5a2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629752 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#663376} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit b200c80047852cdeaad89fdd99fcdbb80212c64d Author: Tom Anderson <thomasanderson@chromium.org> Date: Sat May 25 02:30:46 2019 +0000 Refactor bits of libgtkui * Switch to using CHROMEG_CALLBACK in GtkUi. * Remove code that's conditional on GTK version < 3.10. The earlist supported version is now 3.10.8. * Ensure correct ordering of NativeThemeGtk::OnThemeChanged and GtkUi::OnThemeChanged. The ordering was correct before, but was dependent on glib dispatching events in the right order. Changed GtkUi::OnThemeChanged() to call NativeThemeGtk::OnThemeChanged(). BUG=None R=pkasting Change-Id: I19a4fbab8e4ad44445945e31fcd740faea91f5de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628993 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#663375} chrome/browser/ui/libgtkui/gtk_ui.cc | 50 +++++++--------------- chrome/browser/ui/libgtkui/gtk_ui.h | 10 +++-- chrome/browser/ui/libgtkui/native_theme_gtk.cc | 5 +-- chrome/browser/ui/libgtkui/native_theme_gtk.h | 8 +--- .../browser/ui/libgtkui/settings_provider_gtk.cc | 8 +--- 5 files changed, 27 insertions(+), 54 deletions(-) commit 363914f2ef5c5bb582e6969b4ac5a4b417b31edb Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sat May 25 02:27:30 2019 +0000 Roll src/third_party/skia 46f2b58d86fb..f33c95cd6f55 (2 commits) https://skia.googlesource.com/skia.git/+log/46f2b58d86fb..f33c95cd6f55 git log 46f2b58d86fb..f33c95cd6f55 --date=short --no-merges --format='%ad %ae %s' 2019-05-25 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@f33c95cd6f55 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@google.com Change-Id: I70167dc8e48a6c33882f3766eec42a62d82065b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629754 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#663374} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 9e29ee4efa5a7962c30eb34fca568e1f09fcbbef Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Sat May 25 02:13:35 2019 +0000 Roll src-internal 69803aa39354..1edf6a6aaa9a (2 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/69803aa39354..1edf6a6aaa9a Created with: gclient setdep -r src-internal@1edf6a6aaa9a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=yukishiino@google.com,lgrey@google.com,masonfreed@google.com,rsorokin@google.com Change-Id: I0872de74aa89062ba5cf54082c3104421e1264de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629751 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#663373} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 3acf4b2539c301276641d78a865bde7ac5385b6e Author: Mario Sanchez Prada <mario@igalia.com> Date: Sat May 25 02:01:05 2019 +0000 Implement PushProvider in Blink and update PushManager and PushSubscription This CL implements a version of content::PushProvider inside Blink itself that communicates directly via Mojo-based IPC with the implementation of blink::mojom::PushMessaging in //content/browser (i.e. PushMessagingManager), and update callers in Blink's PushManager and PushSubscription to use this new implementation instead of the old one, to be removed in a follow-up CL. Bug: 939943 Change-Id: I22c518214df9f14288aaa8b74fb8b08635a66331 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621140 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#663372} .../blink/renderer/modules/push_messaging/BUILD.gn | 4 + .../blink/renderer/modules/push_messaging/OWNERS | 3 + .../modules/push_messaging/push_manager.cc | 30 ++-- .../push_messaging_type_converters.cc | 41 +++++ .../push_messaging_type_converters.h | 33 ++++ .../modules/push_messaging/push_provider.cc | 194 +++++++++++++++++++++ .../modules/push_messaging/push_provider.h | 77 ++++++++ .../modules/push_messaging/push_subscription.cc | 13 +- 8 files changed, 374 insertions(+), 21 deletions(-) commit 621bb15ad1dbd50f6088becff0f57c51d0999825 Author: Andrew Luo <aluo@chromium.org> Date: Sat May 25 01:59:35 2019 +0000 Switch webview bots to google devices. Bug: 814405 Change-Id: I217f731c39f9ad0576ce98236c7c7dc78cf71dd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592874 Commit-Queue: Andrew Luo <aluo@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#663371} testing/buildbot/chromium.android.fyi.json | 5 +-- testing/buildbot/chromium.android.json | 54 +++++++++++++++++------------- testing/buildbot/waterfalls.pyl | 27 +++++++++------ tools/mb/mb_config.pyl | 16 +++++++-- 4 files changed, 64 insertions(+), 38 deletions(-) commit f094ef99e0fb3989ce443ccc5013314a5ec78246 Author: Peter Kasting <pkasting@chromium.org> Date: Sat May 25 01:55:57 2019 +0000 Convert TreeModel to expose GetChildren(). This is less efficient in some cases, but simpler, and a better API map to the underlying capabilities of TreeNode. It's possible there's a way to make it no less efficient (by being able to return TreeNode::children() directly), but I can't figure it out. Bug: 956419 Change-Id: Ib0e8778e8d3f900f51793a2cd29c573871214e6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625900 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#663370} ui/base/models/tree_model.h | 13 ++++++------ ui/base/models/tree_node_model.h | 24 ++++++++++++--------- ui/base/models/tree_node_model_unittest.cc | 4 ++-- ui/views/controls/tree/tree_view.cc | 34 ++++++++++++++---------------- 4 files changed, 38 insertions(+), 37 deletions(-) commit b1e829e2285edf71f116264d9f9ec11168edf8db Author: Chromium WPT Sync <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Date: Sat May 25 01:54:56 2019 +0000 Import wpt@512a587ab7eef3cfe1d3ebee1a672ce108bd7975 Using wpt-import in Chromium 78045bdf84d583dc8ef9bb3d19e859cef72dc9b5. With Chromium commits locally applied on WPT: c4dc34414b "[WPT] Reland Upload a test for sending mouse events with key pressed" d814fafce0 "Check for detached ArrayBuffers in Web Bluetooth writeValue functions" e90c6ef049 "NG/DL: Implement size containment (and display lock) for NG fieldset algo" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: ericwilligers@chromium.org: external/wpt/css/motion foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools jinho.bang@samsung.com, mathp@chromium.org, rouslan@chromium.org: external/wpt/payment-handler kojii@chromium.org: external/wpt/css/css-scoping rego@igalia.com: external/wpt/css/css-contain NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I6f7f60abc3c995bf842682fb411ee834bb01d92b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629333 Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#663369} third_party/blink/web_tests/TestExpectations | 2 + .../web_tests/external/WPT_BASE_MANIFEST_6.json | 311 +++++++++++++-------- .../css-contain/contain-layout-baseline-005.html | 3 +- .../css/css-contain/contain-layout-button-001.html | 8 +- .../reference/contain-layout-baseline-005-ref.html | 2 +- .../reference/contain-layout-button-001-ref.html | 8 +- .../wpt/css/css-lists/nested-marker-dynamic.html | 36 +++ .../wpt/css/css-lists/nested-marker-ref.html | 15 + .../external/wpt/css/css-lists/nested-marker.html | 26 ++ .../wpt/css/css-scoping/slotted-matches.html | 16 ++ .../external/wpt/css/motion/inheritance.html | 3 +- .../external/wpt/css/motion/offset-rotate-003.html | 25 ++ .../external/wpt/css/motion/offset-rotate-004.html | 37 +++ .../external/wpt/css/motion/offset-rotate-005.html | 37 +++ .../css/motion/parsing/offset-rotate-computed.html | 3 +- .../parsing/offset-rotate-parsing-valid.html | 6 +- .../wpt/css/support/computed-testcommon.js | 28 +- .../wpt/css/support/inheritance-testcommon.js | 32 ++- .../the-a-element/a.rel-getter-01.html | 19 -- .../the-a-element/a.rel-setter-01.html | 20 -- .../the-data-element/data.value-001.html | 66 ----- .../payment-handler/app-change-payment-method.js | 2 +- .../external/wpt/tools/wptrunner/requirements.txt | 2 +- 23 files changed, 448 insertions(+), 259 deletions(-) commit d35c9d907350c7fdd5f0e49c63de8fa40a56b0ee Author: Kinuko Yasuda <kinuko@chromium.org> Date: Sat May 25 01:30:17 2019 +0000 Histogram how much time we spend for UI/IO thread hopping during SW startup Not expecting to see a large value in major cases, but want to see how much. Bug: 824858 Change-Id: Ifacdd1d651f6512eb5fad4c45346d579f16eda2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627271 Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#663368} .../service_worker/embedded_worker_instance.cc | 37 +++++++++++++++------- .../service_worker/service_worker_metrics.cc | 8 +++++ .../service_worker/service_worker_metrics.h | 3 ++ tools/metrics/histograms/histograms.xml | 18 +++++++++++ 4 files changed, 54 insertions(+), 12 deletions(-) commit 0c4103da9c5421c44bc79c323caa22e9cef41ad0 Author: Thanh Nguyen <thanhdng@chromium.org> Date: Sat May 25 01:28:47 2019 +0000 [Files Ranking] Add metrics for files ranking. Adds 2 metrics for file ranking: 1. Number of clicks according to different search result's display type in zero-state. 2. Number of file opens according to different open types. Bug: 959679 Change-Id: I57e531162c5fdbb826a5e6cb4b0e266694c1e25e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616926 Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: calamity <calamity@chromium.org> Reviewed-by: Jia Meng <jiameng@chromium.org> Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#663367} .../ui/app_list/search/search_controller.cc | 11 ++++ .../search_result_ranker/search_result_ranker.cc | 58 +++++++++++++++++----- tools/metrics/histograms/enums.xml | 9 ++++ tools/metrics/histograms/histograms.xml | 21 ++++++++ 4 files changed, 86 insertions(+), 13 deletions(-) commit 5da1c244cbd754ea6f5cdc5c37fa17c93aabdd39 Author: Chris Lu <thegreenfrog@chromium.org> Date: Sat May 25 01:28:06 2019 +0000 [ios] Add methods to FindInPageManager::FindRequest This removes direct access to FindRequest's internal state. A followup commit will be done to move FindRequest to a separate class and make data members private. Change-Id: I22fd5dbd06ee14a7aa990f031beafc67fce0aaa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613971 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Reviewed-by: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#663366} ios/web/find_in_page/find_in_page_manager_impl.h | 50 ++++++--- ios/web/find_in_page/find_in_page_manager_impl.mm | 124 ++++++++++++++++------ 2 files changed, 129 insertions(+), 45 deletions(-) commit 880ed68bc11bdf4effb5637f6649557bc1bb334c Author: Oleh Prypin <oprypin@chromium.org> Date: Sat May 25 01:24:48 2019 +0000 Remove obsolete aliases of WebRTC's Chromium-compile trybots (renamed in https://chromium-review.googlesource.com/926010) Change-Id: I3276989c8f44e32144c1989c3ee68142014a7eab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628708 Auto-Submit: Oleh Prypin <oprypin@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#663365} tools/mb/mb_config.pyl | 4 ---- 1 file changed, 4 deletions(-) commit ea4048d97dac9509c7fbfdea31b014a2c9608f32 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sat May 25 01:23:39 2019 +0000 Roll src/third_party/depot_tools f46a3114178a..70968772003a (4 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f46a3114178a..70968772003a git log f46a3114178a..70968772003a --date=short --no-merges --format='%ad %ae %s' 2019-05-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-24 ehmaldonado@chromium.org presubmit_support: Run tests on parallel when asked. 2019-05-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@70968772003a The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:819774 TBR=agable@chromium.org Change-Id: I12c74169db2a9bfe55b5d99aa740b7ef1520a3d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629748 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#663364} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 7f0cc1b25759fdf289fe00c80852649819c2e083 Author: Ben Pastene <bpastene@chromium.org> Date: Sat May 25 01:22:49 2019 +0000 chromeos: Add vm-launching bits for betty tests. This duplicates the conditional in DEPS. We can't merge the two since: - We want bots to do all their downloady bits in bot_update/runhooks. - Some devs are likely used to using the simplechrome sdk without an appropriate .gclient config setup. (The sdk will download all the things everytime regardless of how you use it.) So neither site (ie: DEPS & build/config/chromeos/rules.gni) can be the single source of truth for the conditional :( R=jbudorick Bug: 947531 Change-Id: Ie50f483cf2ff06cad579dca2adae348e3c851f17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629711 Commit-Queue: Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: Ben Pastene <bpastene@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#663363} build/config/chromeos/rules.gni | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 1136ce550a1128b09b80744b74b8e8c9f2387d85 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sat May 25 01:17:19 2019 +0000 Roll src/third_party/pdfium b8f3573158b1..2d2b08ea91dd (1 commits) https://pdfium.googlesource.com/pdfium.git/+log/b8f3573158b1..2d2b08ea91dd git log b8f3573158b1..2d2b08ea91dd --date=short --no-merges --format='%ad %ae %s' 2019-05-24 chinsenj@google.com Added basic unit tests for PSOP_CEILING and PSOP_FLOOR Created with: gclient setdep -r src/third_party/pdfium@2d2b08ea91dd The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Change-Id: I421e445148c5980487fcf4416e233f01225a8dde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628558 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#663362} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 579b12b9050e905e8b64a775f6913efb3238043f Author: liberato@chromium.org <liberato@chromium.org> Date: Sat May 25 01:10:11 2019 +0000 Switch VideoFrameFactoryImpl to use a SharedImageVideoProvider This CL creates DirectSharedImageVideoProvider, which does a hop to the gpu main thread for every SharedImageVideo request. This is almost identical to what was happening before, just refactored. GpuVideoFrameFactory is now an implementation detail of the provider rather than VideoFrameFactoryImpl. A follow-up CL will provide an implementation of SharedImageVideoProvider that maintains a pool of SharedImageVideo objects to provide without hopping to the gpu main thread on the critical path. It will still post a "MaybeRenderEarly" to the main thread, but that doesn't need to hold up delivery of the VideoFrame to the renderer. Change-Id: Ia318862daf610327e716515f020b3eeb934dd012 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628154 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#663361} media/gpu/BUILD.gn | 2 + media/gpu/android/codec_image.cc | 20 ++- media/gpu/android/codec_image.h | 15 +- media/gpu/android/codec_image_group_unittest.cc | 5 +- media/gpu/android/codec_image_unittest.cc | 3 +- media/gpu/android/shared_image_video_provider.cc | 20 +++ media/gpu/android/shared_image_video_provider.h | 85 +++++++++ media/gpu/android/video_frame_factory_impl.cc | 215 +++++++++++++++-------- media/gpu/android/video_frame_factory_impl.h | 82 +++++---- 9 files changed, 328 insertions(+), 119 deletions(-) commit 12cb77dbae862ca2c79493cf3c8ce4b9f444d6c5 Author: Nancy Li <nancyly@google.com> Date: Sat May 25 01:08:57 2019 +0000 [USB Internals Test] Add test for rendering device descriptors Added UI test with same logic of user's journey. - Added test for rendering a new tab after user inspecting a device. - Added test for displaying the device descriptors correcty with correct response and short response. Make sure two views and error can displayed well, and the mapping effect works. Also added fake UsbDeviceProxy class to implement the functions that needed for test. Bug: 928923 Change-Id: Ifb87ef48eb42eb515937607cda0a2d1c433f3941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616382 Commit-Queue: Nancy Li <nancyly@google.com> Reviewed-by: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#663360} .../resources/usb_internals/descriptor_panel.js | 87 ++-- .../resources/usb_internals/devices_page.js | 314 ++++++++------- .../test/data/webui/usb_internals_browsertest.js | 440 +++++++++++++++++++-- 3 files changed, 612 insertions(+), 229 deletions(-) commit 688fcb55a4fc370e21f5e7b717a03c257a00714b Author: Daniel Libby <dlibby@microsoft.com> Date: Sat May 25 01:08:47 2019 +0000 Reland "Reland "Scroll scrollbar presses with gestures"" This is a reland of 77a8bf44f6130d08857f2715efdf8e4f31e8eb3e Original change's description: > Reland "Scroll scrollbar presses with gestures" > > This is a reland of 5fcb73a6bd727b53e9e5d5c0b6b203a17362b600, but now > behind a feature flag, along with fixes for regressions caused by the > original change - crrev.com/c/1600444, crrev.com/c/1614283 > > Bug: 954007,960747,963249,963825 > > Original change's description: > > Scroll scrollbar presses with gestures > > > > We don't currently track scrollbar scrolling latency - scrollbar > > scrolling is currently performed on the main thread in response to > > mouse events, so commits caused by this are categorized as LatencyInfo > > with MOUSE type. > > > > With the work being done to move scrollbar scrolling to the compositor > > thread (feature CompositorThreadedScrollbarScrolling), we want to be > > able to track how latency changes (presumably improves) when we roll > > out the feature in experiments. In order to do so we need to classify > > scrolls that originate from scrollbars separately - this change adds > > the foundation of how to accomplish this on the main thread. > > > > Instead of blink::Scrollbar directly scrolling its ScrollableArea in > > response to a mouse input event, it will instead queue up a series of > > scroll gestures, targetted at the ScrollableArea. A new method on > > WebWidgetClient is exposed which adds the ability to inject these > > synthesized gesture events. This is implemented in content in one of > > two fashions: > > - If the injection request happens during the handling of an input > > event, the gesture(s) will be dispatched directly once the current > > dispatch of the input event is complete. > > - Otherwise, it gets queued up on the main thread event queue. > > The latter condition comes into play when the autoscroll timer fires > > due to holding down the mouse on the button or track. > > > > The reason for this distinction is due to the way the main thread event > > queue dispatches events - it only dispatches the events that were > > queued prior to running. If we always queued events, for rAF aligned > > input (i.e. mouse-move) we'd be introducing a frame of latency as > > the scroll would not be executed before the commit that occurs after > > dispatching the rAF aligned input. > > > > This also has the nice side effect creating a mechanism to further > > unify main thread scrolling (i.e. keyboard scrolling can be converted > > to this code path as well). > > > > Once this mechanism is in place, we will dispatch the injected events > > with a LatencyInfo with a modified type. This will be done in a follow > > up change, as well as another one to convert the remaining scrolls > > from blink::Scrollbar to use this gesture-based system. > > > > Bug: 954007 > > Change-Id: I5da338103e833f2e909bc3163b618f57bd7142c4 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580588 > > Commit-Queue: Daniel Libby <dlibby@microsoft.com> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Reviewed-by: David Bokan <bokan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#657031} > > Change-Id: I2adab7c04ac8b36ceb9cda16e5a775fd2b1edb49 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619331 > Commit-Queue: Daniel Libby <dlibby@microsoft.com> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: David Bokan <bokan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#663201} TBR=bokan@chromium.org, dcheng@chromium.org Bug: 954007, 960747, 963249, 963825 Change-Id: I2ccb588cd97e51db13f75c50b6335accf7079d83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629054 Reviewed-by: Daniel Libby <dlibby@microsoft.com> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#663359} .../renderer/input/render_widget_input_handler.cc | 100 +++++++++++ .../renderer/input/render_widget_input_handler.h | 22 +++ content/renderer/render_widget.cc | 11 ++ content/renderer/render_widget.h | 10 +- third_party/blink/public/web/web_widget_client.h | 14 ++ .../renderer/core/exported/web_page_popup_impl.cc | 10 ++ .../renderer/core/frame/frame_test_helpers.cc | 11 ++ .../blink/renderer/core/frame/frame_test_helpers.h | 9 + .../renderer/core/input/event_handler_test.cc | 194 +++++++++++++++++++++ .../blink/renderer/core/layout/scrollbars_test.cc | 13 +- .../blink/renderer/core/page/chrome_client.h | 20 +++ .../blink/renderer/core/page/chrome_client_impl.cc | 14 ++ .../blink/renderer/core/page/chrome_client_impl.h | 6 + .../blink/renderer/core/scroll/scrollable_area.cc | 14 ++ .../blink/renderer/core/scroll/scrollable_area.h | 7 + .../blink/renderer/core/scroll/scrollbar.cc | 90 ++++++++-- third_party/blink/renderer/core/scroll/scrollbar.h | 3 + .../blink/renderer/core/scroll/scrollbar_theme.h | 2 + .../core/scroll/scrollbar_theme_overlay.cc | 4 + .../renderer/core/scroll/scrollbar_theme_overlay.h | 2 + third_party/blink/web_tests/TestExpectations | 14 ++ third_party/blink/web_tests/VirtualTestSuites | 5 + .../popup-menu-scrollbar-button-scrolls.html | 77 ++++++++ .../scrollbar-button-gesture-target.html | 60 +++++++ .../cross-origin-subframe-for-scrolling.html | 10 +- .../scroll-cross-origin-iframes-scrollbar.html | 51 ++++++ .../tests/misc/scroll-cross-origin-iframes.html | 2 +- .../main_thread_scrollbar_gestures/README.md | 2 + .../smooth-scroll/fixed-background-in-iframe.html | 19 +- ui/events/blink/DEPS | 1 + ui/events/blink/blink_event_util.cc | 45 +++++ ui/events/blink/blink_event_util.h | 18 ++ ui/events/blink/input_handler_proxy.cc | 43 ++--- 33 files changed, 849 insertions(+), 54 deletions(-) commit 0bdfaf1f10c4917d4711b9e173e7c537f35e37b7 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sat May 25 01:05:26 2019 +0000 Roll src/third_party/chromite 7cb7b0fac7f4..a9d64606650c (4 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/7cb7b0fac7f4..a9d64606650c git log 7cb7b0fac7f4..a9d64606650c --date=short --no-merges --format='%ad %ae %s' 2019-05-24 saklein@chromium.org SysrootService: Add portage binhost logging. 2019-05-23 saklein@chromium.org Reland "PrepareBinhostUploads: Write the package index file with sudo" 2019-05-23 saklein@chromium.org Build API: Standardize return codes. 2019-05-23 bhthompson@google.com Remove all daisy builder configs Created with: gclient setdep -r src/third_party/chromite@a9d64606650c The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: Ida446542f10b33464221314c5787ead407111712 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628557 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#663358} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit a2c95043b39c483977b774bd7eabd79b1e8a560c Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sat May 25 01:01:33 2019 +0000 Roll src/third_party/skia 5f3cd15760b3..46f2b58d86fb (8 commits) https://skia.googlesource.com/skia.git/+log/5f3cd15760b3..46f2b58d86fb git log 5f3cd15760b3..46f2b58d86fb --date=short --no-merges --format='%ad %ae %s' 2019-05-24 fmalita@chromium.org Reland "Active layer excludes outPoint" 2019-05-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-24 mtklein@google.com blacklist Samsung Mongoose 3 from ASIMDHP 2019-05-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-24 csmartdalton@google.com Add "GrMipMapped" parameter to visitProxies 2019-05-24 michaelludwig@google.com Update GrRTC to use GrFillRectOp::MakeGeneric 2019-05-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@46f2b58d86fb The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@google.com Change-Id: Ia25932d550760c47721a437f76b0d2948e76441c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629509 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#663357} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e2d863292681e4a3bc6f94be3539bbe77b1a9e52 Author: James Cook <jamescook@chromium.org> Date: Sat May 25 01:00:53 2019 +0000 SplitSettings: Close OS settings drawer menu when exiting narrow mode Port this behavior from browser settings to OS settings: https://chromium-review.googlesource.com/c/chromium/src/+/1611137 The tests are not ported yet because we're still setting up our test scaffolding for the OS settings pages: crbug.com/955731 Bug: 950007 Change-Id: I5e64081fa1d573d3984c3b8d63e61df46bc481ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628676 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#663356} .../settings/chromeos/os_settings_ui/os_settings_ui.js | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) commit 8c512177c98f926eb62f6708a133b0634becae54 Author: Joey Arhar <jarhar@chromium.org> Date: Sat May 25 01:00:13 2019 +0000 [DevTools] Make storage quota text selectable Bug: 966880 Change-Id: I0f16f67246e3b47a84bc9b63058d475c54f6861d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628604 Reviewed-by: Joel Einbinder <einbinder@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#663355} .../renderer/devtools/front_end/resources/ClearStorageView.js | 2 +- third_party/blink/renderer/devtools/front_end/ui/ReportView.js | 7 +++++++ third_party/blink/renderer/devtools/front_end/ui/reportView.css | 4 ++++ 3 files changed, 12 insertions(+), 1 deletion(-) commit 8ebdf7ce91ec21ee5ca99f69c0d30a0138c00b38 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Sat May 25 00:58:28 2019 +0000 Revert "[BGPT] Simplify and improve performance of transform decomposition" This reverts commit 7181ee07e464941e2aa3889dd19c7c3ea5eebd8d. Reason for revert: Caused problem of direct transform update. Some transform decomposited for some layer contributing to the offset of the layer can't be directly updated. Original change's description: > [BGPT] Simplify and improve performance of transform decomposition > > Instead of decompositing transforms of pending layers before updating > cc transforms, now decomposite a pending layer's transforms just after > we create cc effect, clip and scroll nodes. We don't decomposite a > transform if the cc transform node has been created during creating > other cc property nodes. > > Because decompositing transform of a layer is just to move the > transform pointer up along the transform path, it won't affect other > layers which may not decomposite the same transforms. > > This improves performance by avoiding hash map accesses and additional > pending layer iteration and blink paint property tree walks. > > Change-Id: Idfdc6bc510cfb83a1b3eb3956cc2fb0a11d457a2 > Bug: 954520, 954493 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597205 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Mason Freed <masonfreed@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#657459} TBR=wangxianzhu@chromium.org,pdr@chromium.org,masonfreed@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 954520, 954493, 966350 Change-Id: I300cdecc444c63ad5fb2c962289e7dcde480bbd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629231 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#663354} .../compositing/paint_artifact_compositor.cc | 174 ++++++++++++++------- .../compositing/paint_artifact_compositor.h | 4 +- .../graphics/compositing/property_tree_manager.cc | 6 +- .../graphics/compositing/property_tree_manager.h | 8 +- 4 files changed, 127 insertions(+), 65 deletions(-) commit b88e442395a4793672fdf127264479832f9dab06 Author: inglorion <inglorion@chromium.org> Date: Sat May 25 00:51:33 2019 +0000 Roll clang 361212:361565. Ran `tools/clang/scripts/upload_revision.py 342571e8d6eb1afb151ae1103431798e3d24054f`. Bug: 965768 Change-Id: Id83d35a8850c40b2e8577c350ab573c1af541643 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627461 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Bob Haarman <inglorion@chromium.org> Cr-Commit-Position: refs/heads/master@{#663353} tools/clang/scripts/update.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit ebb70620348731ea106e247cf740b26c74f2aaff Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sat May 25 00:46:09 2019 +0000 Roll src/third_party/catapult f239adeeed5e..cd7d9644c89f (2 commits) https://chromium.googlesource.com/catapult.git/+log/f239adeeed5e..cd7d9644c89f git log f239adeeed5e..cd7d9644c89f --date=short --no-merges --format='%ad %ae %s' 2019-05-24 benjhayden@chromium.org Defer computing memory measurement relationships. 2019-05-24 benjhayden@chromium.org Fix loading triaged alerts. Created with: gclient setdep -r src/third_party/catapult@cd7d9644c89f The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:954945 TBR=crouleau@chromium.org Change-Id: I72ea4777567056227455ad3ac96b402140b7e684 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629508 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#663352} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit dc16ac1d07c78646c2b63bdc895a2552ff567379 Author: Christian Biesinger <cbiesinger@chromium.org> Date: Sat May 25 00:44:13 2019 +0000 [css-flexbox] Use an existing file for a blank reference about:blank doesn't work, at least in the Chromium test harness, because it concatenates it to a path and then doesn't find the file. Bug: 963168 Change-Id: I377ee38ad1df1039e89257673b71c983099bab55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629332 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#663351} third_party/blink/web_tests/TestExpectations | 2 -- .../web_tests/external/wpt/css/css-flexbox/flexbox_stf-fixpos.html | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) commit cd14b4e239f545cae4c97313a839a3f8657cb25d Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Sat May 25 00:41:56 2019 +0000 Roll src-internal a0fb965292cb..69803aa39354 (3 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a0fb965292cb..69803aa39354 Created with: gclient setdep -r src-internal@69803aa39354 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=yukishiino@google.com,lgrey@google.com,masonfreed@google.com,rsorokin@google.com Change-Id: I2a0be6c0de7f3df406c3781c9c6f30e293328530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629507 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#663350} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit f83f9d5c495cfae0d43ffba5373ca797bb31c8e8 Author: Nate Chapin <japhet@chromium.org> Date: Sat May 25 00:40:06 2019 +0000 Don't flag form submissions as client redirects for extensions use We have two subtly different definitions of a client redirect. One is exposed on the extensions webNavigation API, the other is used in headless mode and is based on whether a navigation used to go through NavigationScheduler. These definitions differ on whether form submissions should be client redirects. Enable each use case to see the definition it expects. Bug: 960653 Test: WebNavigationApiTest.FormSubmission Change-Id: If727762b7b5feef79e2e5059eddc75d57f982e08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628158 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#663349} .../api/web_navigation/web_navigation_apitest.cc | 5 ++ .../api_test/webnavigation/formSubmission/a.html | 2 + .../api_test/webnavigation/formSubmission/a.js | 7 ++ .../api_test/webnavigation/formSubmission/b.html | 1 + .../webnavigation/formSubmission/manifest.json | 10 +++ .../formSubmission/test_formSubmission.html | 2 + .../formSubmission/test_formSubmission.js | 86 ++++++++++++++++++++++ .../blink/renderer/core/frame/local_frame.cc | 4 +- .../blink/renderer/core/frame/remote_frame.cc | 4 +- .../renderer/core/loader/frame_load_request.cc | 11 ++- .../renderer/core/loader/frame_load_request.h | 13 ++-- .../blink/renderer/core/loader/frame_loader.cc | 2 +- .../renderer/core/loader/frame_loader_types.h | 1 + 13 files changed, 134 insertions(+), 14 deletions(-) commit 04769ca1b923f3620987cb9d5a993bc225e2c92b Author: Dale Curtis <dalecurtis@chromium.org> Date: Sat May 25 00:38:10 2019 +0000 Delay closure of the network connection for preload=metadata LazyLoad. We won't know if the element is visible until a layout completes, so avoid closing the network connection before we know this. This should reduce the time to play penalty showing up on macOS telemetry bots. BUG=879406,965684 Change-Id: I977bb1471aecfee112e1797d6544d6a1dc909a82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629030 Reviewed-by: Dan Sanders <sandersd@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#663348} media/blink/multibuffer_data_source.h | 2 ++ media/blink/webmediaplayer_impl.cc | 52 ++++++++++++++++++++++++----- media/blink/webmediaplayer_impl.h | 2 ++ media/blink/webmediaplayer_impl_unittest.cc | 6 ++++ 4 files changed, 53 insertions(+), 9 deletions(-) commit 7b27e62ff99471c7b864001493c2369a4e6303d7 Author: Maksym Onufriienko <monufriienko@chromium.org> Date: Sat May 25 00:34:55 2019 +0000 Convert waitForWebStateContainingElement and waitForWebStateNotContainingText to compile under EG2. Also updated bookmark utilities to return NSError instead of BOOL. Bug: 922813 Change-Id: Ibdad2553aa8a5e32f390fcaf910a2bf525b0912c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625854 Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#663347} ios/chrome/test/earl_grey/BUILD.gn | 1 + ios/chrome/test/earl_grey/chrome_earl_grey.h | 26 ++++++----- ios/chrome/test/earl_grey/chrome_earl_grey.mm | 52 +++++++--------------- .../earl_grey/chrome_earl_grey_app_interface.h | 24 ++++++++-- .../earl_grey/chrome_earl_grey_app_interface.mm | 51 +++++++++++++++++++-- 5 files changed, 99 insertions(+), 55 deletions(-) Updated tag 'tree_truth' (was ca15ee4a01c0)