Back to build
Raw log | Switch to full mode | Login

!@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: b0179d714f8129f2e95e447f35fc5c1031ffdb65 Revert "[BrowserSwitcher] Build BHO for both bitnesses" Daniel Bratell, Sat May 25 09:29:41 2019 +0000 ffd20c5a6b7af5ae9cb5006d562ebad8e8be850d Revert "Switch webview bots to google devices." Andrew Luo, Sat May 25 04:41:07 2019 +0000 e463789eeb96404674d8fab3b3facd064834f075 Roll src/third_party/depot_tools 70968772003a..c47fcecdac30 (1 commits) chromium-autoroll, Sat May 25 04:25:05 2019 +0000 a56a9e1309a23bdcb8e60595929f935e6f52ca88 Roll src/third_party/skia f33c95cd6f55..186a2951113c (1 commits) chromium-autoroll, Sat May 25 03:58:42 2019 +0000 66cb82f9c6676ec0df82f70b33f1fb960f22bafa Roll src/third_party/catapult 9d1091665fb8..a7b33124672f (1 commits) chromium-autoroll, Sat May 25 03:52:22 2019 +0000 beb11e479e81f76ad84410194d4612ad40cf039d Roll src-internal 1edf6a6aaa9a..efcfb30614ad (2 commits) chromium-internal-autoroll, Sat May 25 03:51:27 2019 +0000 ec9f8f46352f142af5fa0131e7e9e6d859684b68 js2gtest: use named keys for featureList and featuresWithParameters API Dan Beam, Sat May 25 03:50:26 2019 +0000 4874fdef6dc7fc7b4f97750c290f1b9cdb447efc [blinkpy] Stop rebaselining on Android bots Robert Ma, Sat May 25 03:50:22 2019 +0000 8b7feb4835152977cc0b49608c3fdf4dac8deaff Revert "Reland "Removes ui/platform_window/mojo as it is not used by anyone."" Shu Chen, Sat May 25 03:37:59 2019 +0000 d301cb6d75cb7a88ee183334c204caea2f409ea9 WebUI: Import Polymer3 in third_party/polymer. dpapad, Sat May 25 03:19:21 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit b0179d714f8129f2e95e447f35fc5c1031ffdb65 Author: Daniel Bratell <bratell@opera.com> Date: Sat May 25 09:29:41 2019 +0000 Revert "[BrowserSwitcher] Build BHO for both bitnesses" This reverts commit 6c3a34bfc2030ffd304c54f5cb96d234622ef389. Reason for revert: It broke some builds with: The file: //out/Release_x64/win_clang_x86/browser_switcher_bho.dll.pdb is listed as an input or source for the target: //chrome/browser/browser_switcher/bho:copy_browser_switcher_binaries but no targets in the build generate that file. See for instance https://ci.chromium.org/p/chromium/builders/ci/Jumbo%20Win%20x64/35757 and the comment in the bug. Original change's description: > [BrowserSwitcher] Build BHO for both bitnesses > > To do so, this CL also adds support for the x86 toolchain in an x64 > build. > > Instead of generating one DLL, we now generate 2 DLLs in the root > out-dir: > > - browser_switcher_bho.dll (x86) > - browser_switcher_bho_64.dll (x64) > > The one that is cross-built (i.e. bitness doesn't match the host) is > built in a sub-directory, and then copied to the root out-dir. > > Bug: 952897 > Change-Id: Ie96ff95556dbe41c8d8eb2fb5ce748964705e096 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1589457 > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> > Cr-Commit-Position: refs/heads/master@{#663196} TBR=thakis@chromium.org,dpranke@chromium.org,brucedawson@chromium.org,nicolaso@chromium.org Change-Id: I2f1929a4e2ea2f9408273c5f04b52ee79580b4cc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 952897 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630427 Reviewed-by: Daniel Bratell <bratell@opera.com> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#663392} BUILD.gn | 5 +- build/toolchain/win/BUILD.gn | 101 ++++++++++++++++++++------- build/toolchain/win/midl.py | 3 +- chrome/browser/browser_switcher/bho/BUILD.gn | 59 ---------------- 4 files changed, 76 insertions(+), 92 deletions(-) Updated tag 'tree_truth' (was ffd20c5a6b7a)