Back to build
Raw log | Switch to full mode | Login

'C:\b\s\w\ir\cipd_bin_packages\bin\python.exe' -u 'C:\b\s\w\ir\kitchen-checkout\depot_tools\recipes\recipe_modules\bot_update\resources\bot_update.py' --spec-path 'c:\b\s\w\ir\tmp\t\tmpedr03s' --revision_mapping_file 'c:\b\s\w\ir\tmp\t\tmp_rhyh0.json' --git-cache-dir 'C:\b\s\w\ir\cache\git' --cleanup-dir 'C:\b\s\w\ir\k\recipe_cleanup\bot_update' --output_json 'c:\b\s\w\ir\tmp\t\tmpyva_dv.json' --revision boringssl@ad9eee1628aa4dac2ac3528cb6bb5ddf27e73560 in dir C:\b\s\w\ir\k: allow_subannotations: False cmd: ['C:\\b\\s\\w\\ir\\cipd_bin_packages\\bin\\python.exe', '-u', 'C:\\b\\s\\w\\ir\\kitchen-checkout\\depot_tools\\recipes\\recipe_modules\\bot_update\\resources\\bot_update.py', '--spec-path', 'c:\\b\\s\\w\\ir\\tmp\\t\\tmpedr03s', '--revision_mapping_file', 'c:\\b\\s\\w\\ir\\tmp\\t\\tmp_rhyh0.json', '--git-cache-dir', 'C:\\b\\s\\w\\ir\\cache\\git', '--cleanup-dir', 'C:\\b\\s\\w\\ir\\k\\recipe_cleanup\\bot_update', '--output_json', 'c:\\b\\s\\w\\ir\\tmp\\t\\tmpyva_dv.json', '--revision', 'boringssl@ad9eee1628aa4dac2ac3528cb6bb5ddf27e73560'] env: {} env_prefixes: {} env_suffixes: {'PATH': 'C:\\b\\s\\w\\ir\\kitchen-checkout\\depot_tools'} infra_step: True name_tokens: ('bot_update',) ok_ret: frozenset([0, 87, 88]) step_test_data: <lambda>(...) trigger_specs: () full environment: ALLUSERSPROFILE: C:\ProgramData APPDATA: C:\Users\chrome-bot\AppData\Roaming BOTO_CONFIG: C:\b\s\w\ir\tmp\gsutil_task\.boto BUILDBUCKET_EXPERIMENTAL: FALSE CIPD_CACHE_DIR: C:\b\s\cipd_cache\cache CIPD_EXE_SHIM: "C:\b\s\w\ir\cipd_bin_packages\vpython.exe" CIPD_PROTOCOL: v2 COMMONPROGRAMFILES: C:\Program Files\Common Files COMMONPROGRAMFILES(X86): C:\Program Files (x86)\Common Files COMMONPROGRAMW6432: C:\Program Files\Common Files COMPUTERNAME: LUCI-FLEX-CI-WI COMSPEC: C:\Windows\system32\cmd.exe DOCKER_CONFIG: C:\b\s\w\ir\tmp\docker_cfg_task DOCKER_TMPDIR: C:\b\s\w\ir\tmp\docker_tmp_task FPS_BROWSER_APP_PROFILE_STRING: Internet Explorer FPS_BROWSER_USER_PROFILE_STRING: Default GIT_CONFIG_NOSYSTEM: 1 GIT_TERMINAL_PROMPT: 0 HOMEDRIVE: C: HOMEPATH: \Users\chrome-bot INFRA_GIT_WRAPPER_HOME: C:\b\s\w\ir\tmp\git_home_task LC_ALL: English_United States.UTF-8 LC_COLLATE: English_United States.UTF-8 LC_CTYPE: English_United States.UTF-8 LC_MONETARY: English_United States.UTF-8 LC_NUMERIC: English_United States.UTF-8 LC_TIME: English_United States.UTF-8 LOCALAPPDATA: C:\Users\chrome-bot\AppData\Local LOGDOG_COORDINATOR_HOST: logs.chromium.org LOGDOG_STREAM_PREFIX: buildbucket/cr-buildbucket.appspot.com/8916526475145908752 LOGDOG_STREAM_PROJECT: boringssl LOGDOG_STREAM_SERVER_PATH: net.pipe:LUCILogDogKitchen_7164 LOGONSERVER: \\LUCI-FLEX-CI-WI LUCI_CONTEXT: C:\b\s\w\ituiwuav\luci_context.707655394 MAC_CHROMIUM_TMPDIR: C:\b\s\w\ir\tmp\t NO_GCE_CHECK: False NUMBER_OF_PROCESSORS: 8 ONEDRIVE: C:\Users\chrome-bot\OneDrive OS: Windows_NT PATH: C:\b\s\w\ir\cipd_bin_packages;C:\b\s\w\ir\cipd_bin_packages\bin;C:\b\s\cipd_cache\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\;C:\Program Files\Puppet Labs\Puppet\bin;C:\b\s\w\ir\kitchen-checkout\depot_tools PATHEXT: .COM;.EXE;.BAT;.CMD;.VBS;.VBE;.JS;.JSE;.WSF;.WSH;.MSC PROCESSOR_ARCHITECTURE: AMD64 PROCESSOR_IDENTIFIER: Intel64 Family 6 Model 79 Stepping 0, GenuineIntel PROCESSOR_LEVEL: 6 PROCESSOR_REVISION: 4f00 PROGRAMDATA: C:\ProgramData PROGRAMFILES: C:\Program Files PROGRAMFILES(X86): C:\Program Files (x86) PROGRAMW6432: C:\Program Files PROMPT: $P$G PSMODULEPATH: C:\Program Files\WindowsPowerShell\Modules;C:\Windows\system32\WindowsPowerShell\v1.0\Modules PUBLIC: C:\Users\Public PYTHONIOENCODING: UTF-8 PYTHONUNBUFFERED: 1 SESSIONNAME: Console SWARMING_BOT_ID: luci-flex-ci-win10-5-zf2g SWARMING_EXTERNAL_BOT_SETUP: 1 SWARMING_HEADLESS: 1 SWARMING_SERVER: https://chromium-swarm.appspot.com SWARMING_TASK_ID: 4422269d4a7c2511 SYSTEMDRIVE: C: SYSTEMROOT: C:\Windows TEMP: C:\b\s\w\ir\tmp\t TEMPDIR: C:\b\s\w\ir\tmp\t TMP: C:\b\s\w\ir\tmp\t TMPDIR: C:\b\s\w\ir\tmp\t USERDOMAIN: LUCI-FLEX-CI-WI USERDOMAIN_ROAMINGPROFILE: LUCI-FLEX-CI-WI USERNAME: chrome-bot USERPROFILE: C:\Users\chrome-bot VPYTHON_VIRTUALENV_ROOT: C:\b\s\w\ir\cache\vpython WINDIR: C:\Windows Debugging info: CURRENT_DIR: 'C:\\b\\s\\w\\ir\\k' DEPOT_TOOLS_DIR: 'C:\\b\\s\\w\\ir\\kitchen-checkout\\depot_tools' THIS_DIR: 'C:\\b\\s\\w\\ir\\kitchen-checkout\\depot_tools\\recipes\\recipe_modules\\bot_update\\resources' Gclient Solutions ================= boringssl (https://boringssl.googlesource.com/boringssl.git) Dependencies file is util/bot/DEPS Managed mode is OFF Custom Variables: checkout_nasm = True ===Running C:\b\s\w\ir\cipd_bin_packages\bin\python.exe -u C:\b\s\w\ir\kitchen-checkout\depot_tools\gclient.py recurse -v git update-index --refresh === In directory: C:\b\s\w\ir\k WARNING: Your metrics.cfg file was invalid or nonexistent. A new one will be created. Can't find .gclient_entries You need to run gclient sync at least once to use 'recurse'. This is because .gclient_entries needs to exist and be up to date. ===Failed in 0.0 mins of C:\b\s\w\ir\cipd_bin_packages\bin\python.exe -u C:\b\s\w\ir\kitchen-checkout\depot_tools\gclient.py recurse -v git update-index --refresh === WARNING: Failed to update git indices. Revisions: ['boringssl@ad9eee1628aa4dac2ac3528cb6bb5ddf27e73560'] Fetching Git checkout at boringssl@ad9eee1628aa4dac2ac3528cb6bb5ddf27e73560 Using Python version: 2.7.13 (v2.7.13:a06454b1afa1, Dec 17 2016, 20:53:40) [MSC v.1500 64 bit (AMD64)] Checking git version... ===Running git.bat version === In directory: C:\b\s\w\ir\k git version 2.21.0.windows.1 / Infra wrapper (infra/tools/git/windows-amd64 @ yS9x_4cqTRb7U_B3luBZy3B5BADUdSeyY0_qlThJvMUC) ===Succeeded in 0.0 mins of git.bat version === Using git version 2.21.0.windows.1 / Infra wrapper (infra/tools/git/windows-amd64 @ yS9x_4cqTRb7U_B3luBZy3B5BADUdSeyY0_qlThJvMUC) ===Running git.bat config --get protocol.version === In directory: C:\b\s\w\ir\k 2 ===Succeeded in 0.0 mins of git.bat config --get protocol.version === Using git protocol version 2 Fetching Git checkout ===Running C:\b\s\w\ir\cipd_bin_packages\bin\python.exe -u C:\b\s\w\ir\kitchen-checkout\depot_tools\git_cache.py exists --quiet --cache-dir C:\\b\\s\\w\\ir\\cache\\git https://boringssl.googlesource.com/boringssl.git === In directory: C:\b\s\w\ir\k C:\\b\\s\\w\\ir\\cache\\git\boringssl.googlesource.com-boringssl ===Succeeded in 0.0 mins of C:\b\s\w\ir\cipd_bin_packages\bin\python.exe -u C:\b\s\w\ir\kitchen-checkout\depot_tools\git_cache.py exists --quiet --cache-dir C:\\b\\s\\w\\ir\\cache\\git https://boringssl.googlesource.com/boringssl.git === ===Running git.bat cat-file -e ad9eee1628aa4dac2ac3528cb6bb5ddf27e73560 === In directory: C:\\b\\s\\w\\ir\\cache\\git\boringssl.googlesource.com-boringssl ===Failed in 0.0 mins of git.bat cat-file -e ad9eee1628aa4dac2ac3528cb6bb5ddf27e73560 === ===Running C:\b\s\w\ir\cipd_bin_packages\bin\python.exe -u C:\b\s\w\ir\kitchen-checkout\depot_tools\git_cache.py populate --ignore_locks -v --cache-dir C:\\b\\s\\w\\ir\\cache\\git https://boringssl.googlesource.com/boringssl.git --reset-fetch-config === In directory: C:\b\s\w\ir\k C:\\b\\s\\w\\ir\\cache\\git\boringssl.googlesource.com-boringssl has 1 .pack files, re-bootstrapping if >50 running "git config --unset-all remote.origin.fetch" in "C:\\b\\s\\w\\ir\\cache\\git\boringssl.googlesource.com-boringssl" running "git config gc.autodetach 0" in "C:\\b\\s\\w\\ir\\cache\\git\boringssl.googlesource.com-boringssl" running "git config core.deltaBaseCacheLimit 2g" in "C:\\b\\s\\w\\ir\\cache\\git\boringssl.googlesource.com-boringssl" running "git config remote.origin.url https://boringssl.googlesource.com/boringssl.git" in "C:\\b\\s\\w\\ir\\cache\\git\boringssl.googlesource.com-boringssl" running "git config --replace-all remote.origin.fetch +refs/heads/*:refs/heads/* \+refs/heads/\*:.*" in "C:\\b\\s\\w\\ir\\cache\\git\boringssl.googlesource.com-boringssl" Fetching +refs/heads/*:refs/heads/* running "git fetch -v --progress origin +refs/heads/*:refs/heads/*" in "C:\\b\\s\\w\\ir\\cache\\git\boringssl.googlesource.com-boringssl" sh: warning: setlocale: LC_ALL: cannot change locale (English_United States.UTF-8): No such file or directory sh: warning: setlocale: LC_ALL: cannot change locale (English_United States.UTF-8): No such file or directory remote: Counting objects: 1 remote: Counting objects: 210, done remote: Finding sources: 9% (1/11) remote: Finding sources: 18% (2/11) remote: Finding sources: 27% (3/11) remote: Finding sources: 36% (4/11) remote: Finding sources: 45% (5/11) remote: Finding sources: 54% (6/11) remote: Finding sources: 63% (7/11) remote: Finding sources: 72% (8/11) remote: Finding sources: 81% (9/11) remote: Finding sources: 90% (10/11) remote: Finding sources: 100% (11/11) remote: Finding sources: 100% (11/11) remote: Total 11 (delta 5), reused 11 (delta 5) From https://boringssl.googlesource.com/a/boringssl = [up to date] 2214 -> 2214 = [up to date] 2272 -> 2272 = [up to date] 2311 -> 2311 = [up to date] 2357 -> 2357 = [up to date] 2490 -> 2490 = [up to date] 2564 -> 2564 = [up to date] 2623 -> 2623 = [up to date] 2661 -> 2661 = [up to date] 2704 -> 2704 = [up to date] 2883 -> 2883 = [up to date] 2924 -> 2924 = [up to date] 2987 -> 2987 = [up to date] 3029 -> 3029 = [up to date] 3071 -> 3071 = [up to date] 3112 -> 3112 = [up to date] 3202 -> 3202 = [up to date] 3239 -> 3239 = [up to date] 3282 -> 3282 = [up to date] 3359 -> 3359 = [up to date] 3538 -> 3538 = [up to date] chromium-stable -> chromium-stable = [up to date] chromium-stable-with-bazel -> chromium-stable-with-bazel = [up to date] fips-20180730 -> fips-20180730 = [up to date] infra/config -> infra/config be7006ada..ad9eee162 master -> master 43ec262a6..c209bb0ae master-with-bazel -> master-with-bazel fetch +refs/heads/*:refs/heads/* took 0.0 minutes ===Succeeded in 0.0 mins of C:\b\s\w\ir\cipd_bin_packages\bin\python.exe -u C:\b\s\w\ir\kitchen-checkout\depot_tools\git_cache.py populate --ignore_locks -v --cache-dir C:\\b\\s\\w\\ir\\cache\\git https://boringssl.googlesource.com/boringssl.git --reset-fetch-config === ===Running C:\b\s\w\ir\cipd_bin_packages\bin\python.exe -u C:\b\s\w\ir\kitchen-checkout\depot_tools\git_cache.py exists --quiet --cache-dir C:\\b\\s\\w\\ir\\cache\\git https://boringssl.googlesource.com/boringssl.git === In directory: C:\b\s\w\ir\k C:\\b\\s\\w\\ir\\cache\\git\boringssl.googlesource.com-boringssl ===Succeeded in 0.0 mins of C:\b\s\w\ir\cipd_bin_packages\bin\python.exe -u C:\b\s\w\ir\kitchen-checkout\depot_tools\git_cache.py exists --quiet --cache-dir C:\\b\\s\\w\\ir\\cache\\git https://boringssl.googlesource.com/boringssl.git === ===Running git.bat cat-file -e ad9eee1628aa4dac2ac3528cb6bb5ddf27e73560 === In directory: C:\\b\\s\\w\\ir\\cache\\git\boringssl.googlesource.com-boringssl ===Succeeded in 0.0 mins of git.bat cat-file -e ad9eee1628aa4dac2ac3528cb6bb5ddf27e73560 === ===Running C:\b\s\w\ir\cipd_bin_packages\bin\python.exe -u C:\b\s\w\ir\kitchen-checkout\depot_tools\git_cache.py exists --quiet --cache-dir C:\\b\\s\\w\\ir\\cache\\git https://boringssl.googlesource.com/boringssl.git === In directory: C:\b\s\w\ir\k C:\\b\\s\\w\\ir\\cache\\git\boringssl.googlesource.com-boringssl ===Succeeded in 0.0 mins of C:\b\s\w\ir\cipd_bin_packages\bin\python.exe -u C:\b\s\w\ir\kitchen-checkout\depot_tools\git_cache.py exists --quiet --cache-dir C:\\b\\s\\w\\ir\\cache\\git https://boringssl.googlesource.com/boringssl.git === ===Running git.bat clone --no-checkout --local --shared C:\\b\\s\\w\\ir\\cache\\git\boringssl.googlesource.com-boringssl C:\b\s\w\ir\k\boringssl === In directory: C:\b\s\w\ir\k Cloning into 'C:\b\s\w\ir\k\boringssl'... sh: warning: setlocale: LC_ALL: cannot change locale (English_United States.UTF-8): No such file or directory done. ===Succeeded in 0.0 mins of git.bat clone --no-checkout --local --shared C:\\b\\s\\w\\ir\\cache\\git\boringssl.googlesource.com-boringssl C:\b\s\w\ir\k\boringssl === ===Running git.bat config gc.auto 0 === In directory: C:\b\s\w\ir\k\boringssl ===Succeeded in 0.0 mins of git.bat config gc.auto 0 === ===Running git.bat config gc.autodetach 0 === In directory: C:\b\s\w\ir\k\boringssl ===Succeeded in 0.0 mins of git.bat config gc.autodetach 0 === ===Running git.bat config gc.autopacklimit 0 === In directory: C:\b\s\w\ir\k\boringssl ===Succeeded in 0.0 mins of git.bat config gc.autopacklimit 0 === ===Running git.bat remote set-url --push origin https://boringssl.googlesource.com/boringssl.git === In directory: C:\b\s\w\ir\k\boringssl ===Succeeded in 0.0 mins of git.bat remote set-url --push origin https://boringssl.googlesource.com/boringssl.git === ===Running git.bat checkout --force ad9eee1628aa4dac2ac3528cb6bb5ddf27e73560 -- === In directory: C:\b\s\w\ir\k\boringssl Note: checking out 'ad9eee1628aa4dac2ac3528cb6bb5ddf27e73560'. You are in 'detached HEAD' state. You can look around, make experimental changes and commit them, and you can discard any commits you make in this state without impacting any branches by performing another checkout. If you want to create a new branch to retain commits you create, you may do so (now or later) by using -b with the checkout command again. Example: git checkout -b <new-branch-name> HEAD is now at ad9eee162 Handle CBB_cleanup on child CBBs more gracefully. ===Succeeded in 0.0 mins of git.bat checkout --force ad9eee1628aa4dac2ac3528cb6bb5ddf27e73560 -- === ===Running git.bat clean -dff === In directory: C:\b\s\w\ir\k\boringssl ===Succeeded in 0.0 mins of git.bat clean -dff === ===Running git.bat log --format=%H --max-count=1 === In directory: C:\b\s\w\ir\k\boringssl ad9eee1628aa4dac2ac3528cb6bb5ddf27e73560 ===Succeeded in 0.0 mins of git.bat log --format=%H --max-count=1 === ===Running git.bat config --global user.name === In directory: C:\b\s\w\ir\k boringssl-ci-builder ===Succeeded in 0.0 mins of git.bat config --global user.name === ===Running git.bat config --global user.email === In directory: C:\b\s\w\ir\k boringssl-ci-builder@chops-service-accounts.iam.gserviceaccount.com ===Succeeded in 0.0 mins of git.bat config --global user.email === ===Running C:\b\s\w\ir\cipd_bin_packages\bin\python.exe -u C:\b\s\w\ir\kitchen-checkout\depot_tools\gclient.py sync --verbose --reset --force --ignore_locks --output-json c:\b\s\w\ir\tmp\t\tmp_cdsx8.json --nohooks --noprehooks --delete_unversioned_trees --break_repo_locks --revision boringssl@unmanaged === In directory: C:\b\s\w\ir\k Looking for .gclient starting from C:\b\s\w\ir\k Loaded .gclient config in C:\b\s\w\ir\k: solutions = [ { 'custom_vars': { 'checkout_nasm': 'True'}, 'deps_file': 'util/bot/DEPS', 'managed': False, 'name': 'boringssl', 'url': 'https://boringssl.googlesource.com/boringssl.git'}] cache_dir = r"C:\\b\\s\\w\\ir\\cache\\git" target_os_only=False gclient(748) ParseDepsFile:Found recursedeps "{'boringssl/util/bot/android_tools': 'util\\\\bot\\\\DEPS'}". boringssl (Elapsed: 0:00:00) ---------------------------------------- [0:00:00] Started. _____ boringssl at refs/remotes/origin/master [0:00:00] ________ unmanaged solution; skipping boringssl [0:00:00] Finished. ---------------------------------------- boringssl/util/bot/libFuzzer (Elapsed: 0:00:01) ---------------------------------------- [0:00:00] Started. _____ boringssl\util\bot\libFuzzer at e847d8a9b47158695593d5693b0f69250472b229 [0:00:00] running "git cat-file -e e847d8a9b47158695593d5693b0f69250472b229^^^^{commit}" in "C:\b\s\w\ir\cache\git\chromium.googlesource.com-chromium-llvm--project-compiler--rt-lib-fuzzer" skipping mirror update, it has rev=e847d8a9b47158695593d5693b0f69250472b229 already ________ running 'git -c core.deltaBaseCacheLimit=2g clone --no-checkout --progress --shared --verbose C:\b\s\w\ir\cache\git\chromium.googlesource.com-chromium-llvm--project-compiler--rt-lib-fuzzer C:\b\s\w\ir\k\boringssl\util\bot\_gclient_libFuzzer_7cbtbd' in 'C:\b\s\w\ir\k' [0:00:00] Cloning into 'C:\b\s\w\ir\k\boringssl\util\bot\_gclient_libFuzzer_7cbtbd'... [0:00:00] done. ________ running 'git -c core.deltaBaseCacheLimit=2g fetch origin --prune --verbose' in 'C:\b\s\w\ir\k\boringssl\util\bot\libFuzzer' [0:00:01] From C:\b\s\w\ir\cache\git\chromium.googlesource.com-chromium-llvm--project-compiler--rt-lib-fuzzer [0:00:01] = [up to date] master -> origin/master [0:00:01] Checked out e847d8a9b47158695593d5693b0f69250472b229 to a detached HEAD. Before making any commits in this repo, you should use 'git checkout <branch>' to switch to an existing branch or use 'git checkout origin -b <branch>' to create a new branch for your work. [0:00:01] Finished. ---------------------------------------- boringssl/util/bot/gyp (Elapsed: 0:00:02) ---------------------------------------- [0:00:00] Started. _____ boringssl\util\bot\gyp at d61a9397e668fa9843c4aa7da9e79460fe590bfb [0:00:00] running "git cat-file -e d61a9397e668fa9843c4aa7da9e79460fe590bfb^^^^{commit}" in "C:\b\s\w\ir\cache\git\chromium.googlesource.com-external-gyp" skipping mirror update, it has rev=d61a9397e668fa9843c4aa7da9e79460fe590bfb already ________ running 'git -c core.deltaBaseCacheLimit=2g clone --no-checkout --progress --shared --verbose C:\b\s\w\ir\cache\git\chromium.googlesource.com-external-gyp C:\b\s\w\ir\k\boringssl\util\bot\_gclient_gyp_opjgte' in 'C:\b\s\w\ir\k' [0:00:00] Cloning into 'C:\b\s\w\ir\k\boringssl\util\bot\_gclient_gyp_opjgte'... [0:00:00] done. ________ running 'git -c core.deltaBaseCacheLimit=2g fetch origin --prune --verbose' in 'C:\b\s\w\ir\k\boringssl\util\bot\gyp' [0:00:01] From C:\b\s\w\ir\cache\git\chromium.googlesource.com-external-gyp [0:00:01] = [up to date] master -> origin/master [0:00:01] = [up to date] infra/config -> origin/infra/config [0:00:01] = [up to date] md-pages -> origin/md-pages [0:00:02] Checked out d61a9397e668fa9843c4aa7da9e79460fe590bfb to a detached HEAD. Before making any commits in this repo, you should use 'git checkout <branch>' to switch to an existing branch or use 'git checkout origin -b <branch>' to create a new branch for your work. [0:00:02] Finished. ---------------------------------------- ===Succeeded in 0.0 mins of C:\b\s\w\ir\cipd_bin_packages\bin\python.exe -u C:\b\s\w\ir\kitchen-checkout\depot_tools\gclient.py sync --verbose --reset --force --ignore_locks --output-json c:\b\s\w\ir\tmp\t\tmp_cdsx8.json --nohooks --noprehooks --delete_unversioned_trees --break_repo_locks --revision boringssl@unmanaged === ===Running git.bat ls-files .DEPS.git === In directory: boringssl ===Succeeded in 0.0 mins of git.bat ls-files .DEPS.git === ===Running git.bat rev-parse HEAD === In directory: boringssl/ ad9eee1628aa4dac2ac3528cb6bb5ddf27e73560 ===Succeeded in 0.0 mins of git.bat rev-parse HEAD === ===Running git.bat log --format=%B -n1 HEAD === In directory: boringssl/ Handle CBB_cleanup on child CBBs more gracefully. Child and root CBBs share a type, but are different kinds of things. C++ programmers sometimes mistakenly believe they should use ScopedCBB for everything. This mostly works because we NULL cbb->child->base on flush, making CBB_cleanup a no-op. This zeroing also skips the assert in CBB_cleanup. (If we ran it unconditionally, CBB_zero + CBB_cleanup would not work.) However, if a CBB operation fails and a function returns early, the child CBB is not cleared. ScopedCBB will then call CBB_cleanup which trips the assert but, in release build, misbehaves. Run the assert unconditionally and, when the assert fails, still behave well. To make this work with CBB_zero, negate is_top_level to is_child, so a flushed child CBB and a (presumably) root CBB in the zero state are distinguishable. Update-Note: Code that was using CBB wrong may trip an assert in debug builds. Change-Id: Ifea7759e1d0331f2e727c59bbafa355d70fb9dba Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/35524 Reviewed-by: Adam Langley <agl@google.com> ===Succeeded in 0.0 mins of git.bat log --format=%B -n1 HEAD === ===Running C:\b\s\w\ir\cipd_bin_packages\bin\python.exe -u C:\b\s\w\ir\kitchen-checkout\depot_tools\gclient.py revinfo -a === In directory: C:\b\s\w\ir\k boringssl: https://boringssl.googlesource.com/boringssl.git@ad9eee1628aa4dac2ac3528cb6bb5ddf27e73560 boringssl/util/bot/gyp: https://chromium.googlesource.com/external/gyp.git@d61a9397e668fa9843c4aa7da9e79460fe590bfb boringssl/util/bot/libFuzzer: https://chromium.googlesource.com/chromium/llvm-project/compiler-rt/lib/fuzzer.git@e847d8a9b47158695593d5693b0f69250472b229 ===Succeeded in 0.0 mins of C:\b\s\w\ir\cipd_bin_packages\bin\python.exe -u C:\b\s\w\ir\kitchen-checkout\depot_tools\gclient.py revinfo -a ===